1 2017-11-21T00:00:48  *** Kedstar has joined #bitcoin-core-dev
  2 2017-11-21T00:08:53  *** kaderate has quit IRC
  3 2017-11-21T00:16:31  *** d_t has quit IRC
  4 2017-11-21T00:19:41  *** goatpig has quit IRC
  5 2017-11-21T00:22:40  *** quantbot has joined #bitcoin-core-dev
  6 2017-11-21T00:23:12  *** AaronvanW has quit IRC
  7 2017-11-21T00:24:13  *** AaronvanW has joined #bitcoin-core-dev
  8 2017-11-21T00:27:20  *** quantbot has quit IRC
  9 2017-11-21T00:28:44  *** Aaronvan_ has joined #bitcoin-core-dev
 10 2017-11-21T00:31:15  *** d_t has joined #bitcoin-core-dev
 11 2017-11-21T00:31:38  *** AaronvanW has quit IRC
 12 2017-11-21T00:35:51  *** promag has joined #bitcoin-core-dev
 13 2017-11-21T00:54:46  *** dabura667 has joined #bitcoin-core-dev
 14 2017-11-21T01:04:33  *** esotericnonsense has quit IRC
 15 2017-11-21T01:06:09  *** jb55 has quit IRC
 16 2017-11-21T01:13:05  *** Kedstar has quit IRC
 17 2017-11-21T01:15:04  *** lojhgf has joined #bitcoin-core-dev
 18 2017-11-21T01:23:38  *** lojhgf has quit IRC
 19 2017-11-21T01:26:59  *** Aaronvan_ has quit IRC
 20 2017-11-21T01:30:00  *** promag has quit IRC
 21 2017-11-21T01:33:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 22 2017-11-21T01:36:55  <Murch> morcos: I was just looking at fee rate estimation. I'm surprised that the Bitcoin Core estimate is still on 170 for second block target when the network has been clearing the mempool of <40 for four days.
 23 2017-11-21T01:37:36  <Murch> morcos: A few minutes ago, the block would have cleared down to below 5 satoshis per byte, but now there is one MB waiting at 160+
 24 2017-11-21T01:37:51  <Murch> morcos: Maybe the estimation is a bit of o self-fulfilling prophecy?
 25 2017-11-21T01:38:15  *** owowo has quit IRC
 26 2017-11-21T01:38:26  <sipa> Murch: fee estimation does not look at what fees would be required to confirm given the current mempool
 27 2017-11-21T01:38:32  <sipa> but at what fees *are* confirming
 28 2017-11-21T01:38:34  <Murch> I know
 29 2017-11-21T01:38:53  <sipa> so yes, i guess it's by definition a self-fullfilling prophecy
 30 2017-11-21T01:39:07  <sipa> if people keep overpaying, fee estimation will keep telling them to overpay
 31 2017-11-21T01:39:18  <Murch> however, the fee estimation may be sustaining a higher fee level by jumping in at a too high level and generating enough send queue at that level
 32 2017-11-21T01:40:08  <Murch> I was considering that Morcos' algorithm may not be decreasing fees aggressively enough after such a great fee spike as we had.
 33 2017-11-21T01:40:19  <sipa> right
 34 2017-11-21T01:40:49  <morcos> Murch: I'm not sure what you mean about clearing the mempool of <40 for 4 days
 35 2017-11-21T01:41:22  <morcos> sipa: thats HOPEFU?LLy not true.  the design is such that if at least some poeple aren't overpaying, and are also being confirmed, then fee esitmation will let you know that
 36 2017-11-21T01:41:27  <morcos> even if most poeple are still overpaying
 37 2017-11-21T01:41:31  *** owowo has joined #bitcoin-core-dev
 38 2017-11-21T01:41:34  <sipa> morcos: right
 39 2017-11-21T01:41:56  <sipa> morcos: but to an extent, there is a self-sustaining property in it
 40 2017-11-21T01:42:09  <morcos> the short term estimate has a half-life of only 18 blocks... so anything that happened more than say 12 hours ago is pretty meaningless
 41 2017-11-21T01:43:06  <morcos> yeah, there used to be more though.  now some people do place lower fees b/c they are willing to wait and so they use a longer target, so that helps the estimates for the shorter targets come down
 42 2017-11-21T01:43:27  <morcos> that's a big part of why i wanted to increase the range to 1008.  incentivise people to try for those lower numbers
 43 2017-11-21T01:43:58  <morcos> but yea, i think there is definitely room to improve fee estimation, i just thinkthere is not much low hanging fruit.  it's going to be pretty complicated to make it significantly better
 44 2017-11-21T01:44:34  <Murch> well, the estimate does fit, as the fee level is now at ~170, but only 1.5MB over 30, and 1MB over 160 seems a bit unnatural
 45 2017-11-21T01:44:57  <morcos> Murch, looking at the last couple hours, there are several blocks that haven't cleared down below 100
 46 2017-11-21T01:45:07  <Murch> yeah, the next one won't either
 47 2017-11-21T01:45:23  <morcos> so then if you want to get confirmed in 2 blocks, you shouldn't pay something that low
 48 2017-11-21T01:45:33  <morcos> ask it for 12 and you'll get a much lower answer
 49 2017-11-21T01:46:16  <Murch> yeah, was just curious if anyone else was watching this and had thoughts on it
 50 2017-11-21T01:48:09  <morcos> Fee estimates for target of 6 have gone up recently actually
 51 2017-11-21T01:48:28  <morcos> but yeah its a good idea to keep an eye on it, especially since its' relatively new
 52 2017-11-21T01:49:27  <Murch> morcos: I was wondering, why is the fee estimate jumping at 45?
 53 2017-11-21T01:49:35  <Murch> Are you switching the confidence curve?
 54 2017-11-21T01:50:01  <Murch> sorry, 42
 55 2017-11-21T01:50:32  <Murch> Or, if you don't know what I'm talking about, that may be custom to our estimate.
 56 2017-11-21T01:50:34  <morcos> the time horizons break at 12 and 48, so there are often jumps around 6 , 12, 24, 48
 57 2017-11-21T01:50:44  <morcos> i don't know why that would happen at 42
 58 2017-11-21T01:51:08  <Murch> "23": 22152,
 59 2017-11-21T01:51:08  <Murch> "25": 20083,
 60 2017-11-21T01:51:09  <Murch> "42": 135327,
 61 2017-11-21T01:51:09  <Murch> "49": 128408,
 62 2017-11-21T01:51:36  <morcos> huh???
 63 2017-11-21T01:51:39  <morcos> that's broken
 64 2017-11-21T01:51:43  <morcos> it should never increase
 65 2017-11-21T01:51:46  <Murch> Maybe it's just a modification in our algorithm, maybe we're not using Vanilla-Core after all
 66 2017-11-21T01:51:53  <Murch> yeah, exactly
 67 2017-11-21T01:52:12  <morcos> i see 19201 for 42
 68 2017-11-21T01:52:17  <Murch> thanks
 69 2017-11-21T01:52:32  <morcos> maybe you stopped asking for ECONOMICAL estimates?
 70 2017-11-21T01:52:55  <Murch> We don't have RBF, so we don't do economical estimates
 71 2017-11-21T01:53:33  <morcos> i think you are for 23/25
 72 2017-11-21T01:53:53  <Murch> ah, that might be it
 73 2017-11-21T01:53:55  <morcos> my conservative estimates for those are higher
 74 2017-11-21T01:54:31  <Murch> Alright, well, I guess I was mistaken in my thinking that our fee estimation is vanilla Core :)
 75 2017-11-21T01:54:50  <morcos> oh.. forgot where you work, yeah i don't think it is
 76 2017-11-21T01:55:31  <Murch> alright, thanks for your insights
 77 2017-11-21T02:07:59  *** Chris_Stewart_5 has quit IRC
 78 2017-11-21T02:15:48  *** quantbot has joined #bitcoin-core-dev
 79 2017-11-21T02:16:02  *** bule has quit IRC
 80 2017-11-21T02:16:24  *** bule has joined #bitcoin-core-dev
 81 2017-11-21T02:16:35  *** TrufflePig has joined #bitcoin-core-dev
 82 2017-11-21T02:16:56  *** Ylbam has quit IRC
 83 2017-11-21T02:19:57  *** quantbot has quit IRC
 84 2017-11-21T02:22:56  *** quantbot has joined #bitcoin-core-dev
 85 2017-11-21T02:26:49  *** Murch has quit IRC
 86 2017-11-21T02:27:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 87 2017-11-21T02:29:17  *** TrufflePig has quit IRC
 88 2017-11-21T02:40:28  *** dabura667 has quit IRC
 89 2017-11-21T02:41:50  *** TrufflePig has joined #bitcoin-core-dev
 90 2017-11-21T02:42:47  *** TrufflePig has joined #bitcoin-core-dev
 91 2017-11-21T02:47:12  *** TrufflePig has quit IRC
 92 2017-11-21T02:48:53  *** TrufflePig has joined #bitcoin-core-dev
 93 2017-11-21T02:49:28  *** Chris_Stewart_5 has quit IRC
 94 2017-11-21T02:50:23  *** StopAndDecrypt has quit IRC
 95 2017-11-21T02:54:11  *** StopAndDecrypt has joined #bitcoin-core-dev
 96 2017-11-21T03:03:28  *** TrufflePig has quit IRC
 97 2017-11-21T03:03:48  *** clagrie has joined #bitcoin-core-dev
 98 2017-11-21T03:10:26  *** bule has quit IRC
 99 2017-11-21T03:10:59  *** bule has joined #bitcoin-core-dev
100 2017-11-21T03:24:07  *** jb55 has joined #bitcoin-core-dev
101 2017-11-21T03:24:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
102 2017-11-21T03:30:03  *** clagrie has quit IRC
103 2017-11-21T03:30:19  *** TrufflePig has joined #bitcoin-core-dev
104 2017-11-21T03:45:35  *** jb55 has quit IRC
105 2017-11-21T03:46:45  *** esotericnonsense has joined #bitcoin-core-dev
106 2017-11-21T03:53:22  *** Giszmo has quit IRC
107 2017-11-21T04:14:22  *** LumberCartel has joined #bitcoin-core-dev
108 2017-11-21T04:43:24  *** bule has quit IRC
109 2017-11-21T04:43:49  *** bule has joined #bitcoin-core-dev
110 2017-11-21T04:46:57  *** digifis has quit IRC
111 2017-11-21T04:47:13  *** digifis has joined #bitcoin-core-dev
112 2017-11-21T04:48:10  *** Chris_Stewart_5 has quit IRC
113 2017-11-21T04:57:33  *** LumberCartel has quit IRC
114 2017-11-21T05:01:27  *** quantbot has quit IRC
115 2017-11-21T05:02:00  *** quantbot has joined #bitcoin-core-dev
116 2017-11-21T05:03:25  *** quantbot has joined #bitcoin-core-dev
117 2017-11-21T05:04:25  *** ula has quit IRC
118 2017-11-21T05:16:08  *** Deacydal has joined #bitcoin-core-dev
119 2017-11-21T05:16:46  *** Randolf has joined #bitcoin-core-dev
120 2017-11-21T05:19:19  *** Deacyde has quit IRC
121 2017-11-21T05:31:57  *** justanotheruser has quit IRC
122 2017-11-21T05:45:35  *** bule has quit IRC
123 2017-11-21T05:45:58  *** bule has joined #bitcoin-core-dev
124 2017-11-21T06:03:31  *** MrPaz has quit IRC
125 2017-11-21T06:05:04  *** alc has joined #bitcoin-core-dev
126 2017-11-21T06:15:10  *** alc has quit IRC
127 2017-11-21T06:16:31  *** geezas has joined #bitcoin-core-dev
128 2017-11-21T06:23:02  *** booyah_ has quit IRC
129 2017-11-21T06:23:03  *** booyah_ has joined #bitcoin-core-dev
130 2017-11-21T06:26:27  *** Randolf has quit IRC
131 2017-11-21T06:28:03  *** Randolf has joined #bitcoin-core-dev
132 2017-11-21T06:45:00  *** bule has quit IRC
133 2017-11-21T06:54:57  *** BashCo_ has quit IRC
134 2017-11-21T06:55:16  *** justanotheruser has joined #bitcoin-core-dev
135 2017-11-21T06:55:36  *** BashCo has joined #bitcoin-core-dev
136 2017-11-21T06:56:59  *** JeffSlentz has joined #bitcoin-core-dev
137 2017-11-21T07:00:01  *** BashCo has quit IRC
138 2017-11-21T07:01:35  <JeffSlentz> Hey, as a recent grad with not much experience with the Bitcoin Core project, are there any suggestions for contributing?
139 2017-11-21T07:12:49  <Randolf> JeffSlentz:  Probably one of the best things you can do is to become familiar with the source code.
140 2017-11-21T07:13:05  <Randolf> JeffSlentz:  From there, you may find an area that can be improved and then raise discussions about it.
141 2017-11-21T07:13:25  <Randolf> JeffSlentz:  ...and suggestions on how to improve it, including source code if you feel inclined to write some.
142 2017-11-21T07:15:45  *** d_t has quit IRC
143 2017-11-21T07:24:54  *** fanquake has joined #bitcoin-core-dev
144 2017-11-21T07:25:24  <JeffSlentz> Randolf: Thanks! Is there a best practices way to learn the source code? I'm overwhelmed with the sheer amount
145 2017-11-21T07:26:18  <Randolf> JeffSlentz:  Are you familiar with the programming language(s) that said source code is written in?
146 2017-11-21T07:27:11  <Randolf> JeffSlentz:  If not, then there may be other options for you, but you'll probably need to ask about those possibilities in the #bitcoin channel.
147 2017-11-21T07:29:09  <fanquake> JeffSlentz Checkout the "good first issue" label on repo. https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
148 2017-11-21T07:29:19  <fanquake> JeffSlentz Trying to jump in and more generally "learn the source code" wont be the best place to start. Instead, pick an issue, familiarise yourself with the code concerned, submit a PR to fix it. Rinse & repeat.
149 2017-11-21T07:29:40  <JeffSlentz> Randolf: I've written some C++ but it's not my preferred language, I suppose.
150 2017-11-21T07:30:34  <JeffSlentz> fanquake: Thanks, I think that's a good approach
151 2017-11-21T07:34:04  <fanquake> JeffSlentz Also read through https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md & https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md . They explain how the development process works, and preferred code styles etc.
152 2017-11-21T07:34:36  *** dermoth has quit IRC
153 2017-11-21T07:36:09  *** dermoth has joined #bitcoin-core-dev
154 2017-11-21T07:36:53  *** qrest has quit IRC
155 2017-11-21T07:39:42  *** BashCo has joined #bitcoin-core-dev
156 2017-11-21T07:52:07  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/901ba3e38194...d4267a3ab271
157 2017-11-21T07:52:08  <bitcoin-git> bitcoin/master d9340ce Matt Corallo: Fix sendrawtransaction hang when sending a tx already in mempool
158 2017-11-21T07:52:08  <bitcoin-git> bitcoin/master d4267a3 Wladimir J. van der Laan: Merge #11738: Fix sendrawtransaction hang when sending a tx already in mempool...
159 2017-11-21T07:52:14  *** dermoth has quit IRC
160 2017-11-21T07:52:40  *** dermoth has joined #bitcoin-core-dev
161 2017-11-21T07:52:43  <bitcoin-git> [bitcoin] laanwj closed pull request #11738: Fix sendrawtransaction hang when sending a tx already in mempool (master...2017-11-fix-sendraw-block) https://github.com/bitcoin/bitcoin/pull/11738
162 2017-11-21T07:54:12  *** Kedstar has joined #bitcoin-core-dev
163 2017-11-21T07:58:57  *** shesek has quit IRC
164 2017-11-21T08:04:15  *** qrestlove has joined #bitcoin-core-dev
165 2017-11-21T08:18:44  <fanquake> wumpus exposed :p
166 2017-11-21T08:18:58  <wumpus> fanquake: yep :p
167 2017-11-21T08:25:13  <geezas> anyone know if network-adjusted time as described in the wiki on block timestamps is used as described there
168 2017-11-21T08:25:14  <geezas> ?
169 2017-11-21T08:25:25  <geezas> "A timestamp is accepted as valid if it is greater than the median timestamp of previous 11 blocks, and less than the network-adjusted time + 2 hours. "Network-adjusted time" is the median of the timestamps returned by all nodes connected to you."
170 2017-11-21T08:36:33  *** JackH has quit IRC
171 2017-11-21T08:41:44  *** laurentmt has joined #bitcoin-core-dev
172 2017-11-21T08:45:30  *** rundom has quit IRC
173 2017-11-21T08:46:25  *** unholymachine has quit IRC
174 2017-11-21T08:47:38  *** unholymachine has joined #bitcoin-core-dev
175 2017-11-21T09:01:03  *** rundom has joined #bitcoin-core-dev
176 2017-11-21T09:07:52  *** bj_ has joined #bitcoin-core-dev
177 2017-11-21T09:08:55  *** timothy has joined #bitcoin-core-dev
178 2017-11-21T09:10:00  *** d_t has joined #bitcoin-core-dev
179 2017-11-21T09:12:06  *** dermoth has quit IRC
180 2017-11-21T09:12:31  *** dermoth has joined #bitcoin-core-dev
181 2017-11-21T09:17:55  *** shesek has joined #bitcoin-core-dev
182 2017-11-21T09:33:25  *** BorisYelko has joined #bitcoin-core-dev
183 2017-11-21T09:40:24  *** quantbot has quit IRC
184 2017-11-21T09:40:37  *** booyah_ is now known as booyah
185 2017-11-21T09:42:25  <wumpus> see GetMedianTimePast
186 2017-11-21T09:49:07  *** shesek has quit IRC
187 2017-11-21T09:50:52  <Sentineo> wumpus: the timespamt from node is just the timestamp in the blocks my node receives, right? Checking getMedianTimePast(), it referencis the blockchain. I have a feeling geezas tends to think it is a message that is exchanged between nodes. Can you shed some light, which view is correct?
188 2017-11-21T09:51:48  <wumpus> the text he quotes talks about the median timestamp of the previous 11 blocks, that's implemented in GetMedianTimePast
189 2017-11-21T09:52:30  <wumpus> there is also a median filter get relative node times at connection, in src/timedata.h, but that is a wholly separate thing
190 2017-11-21T09:52:38  <sipa> it also talks about network-adjusted time, which is indeed there is a message exchanged between nodes
191 2017-11-21T09:52:52  <Sentineo> ah ok, that is what I wanted to know
192 2017-11-21T09:53:05  <Sentineo> tried doing an experiment, but can not force my system to change its time
193 2017-11-21T09:53:30  *** shesek has joined #bitcoin-core-dev
194 2017-11-21T09:53:31  *** shesek has joined #bitcoin-core-dev
195 2017-11-21T09:53:40  <Sentineo> so if I set my time to 2015 would I invalidate blocks? It sounds like bitcoin-core would take the blockchain (and other nodes) as the source of time
196 2017-11-21T09:53:48  <wumpus> there's an option to override that logic IIRC
197 2017-11-21T09:53:51  <Sentineo> need to look into timedata.h, that might answer it
198 2017-11-21T09:53:57  <sipa> it also never adjusts more than 1 hour iirc
199 2017-11-21T09:54:00  <wumpus> (for the node time, not for the consensus logic obviously)
200 2017-11-21T09:54:36  <wumpus> -maxtimeadjustment=0
201 2017-11-21T09:54:45  <Sentineo> yeah turned off ntp on my laptop, but will see. I will perhaps use regtest and disconnect from the internet for that time :)
202 2017-11-21T09:55:12  <wumpus> also if you just want to test w/ bitcoin and times there's setmocktime
203 2017-11-21T09:55:32  *** quantbot has joined #bitcoin-core-dev
204 2017-11-21T09:56:10  <Sentineo> ah ok, it must be in the unit tests than ... will look it up
205 2017-11-21T09:56:12  <Sentineo> ty!
206 2017-11-21T09:56:59  <wumpus> there's also the 'faketime' command that allows time machine experiments without changing time on your computer globally
207 2017-11-21T09:57:35  <Sentineo> ah wow
208 2017-11-21T09:57:40  <Sentineo> did not know that one
209 2017-11-21T09:57:48  <wumpus> "faketime - manipulate the system time for a given command" we use or at least used that for the gitian build to force a deterministic time
210 2017-11-21T09:58:09  <Sentineo> ah this is cool
211 2017-11-21T09:59:20  <wumpus> from my experience it doesn't work with very far future dates due to 32-bit timestamps, but YMMV
212 2017-11-21T10:00:01  *** quantbot has quit IRC
213 2017-11-21T10:07:06  <Sentineo> hm not getting peers when in future :)
214 2017-11-21T10:11:18  *** shesek has quit IRC
215 2017-11-21T10:16:22  *** AaronvanW has joined #bitcoin-core-dev
216 2017-11-21T10:17:16  *** jannes has joined #bitcoin-core-dev
217 2017-11-21T10:22:05  *** dermoth has quit IRC
218 2017-11-21T10:23:44  *** dermoth has joined #bitcoin-core-dev
219 2017-11-21T10:24:15  *** dermoth has joined #bitcoin-core-dev
220 2017-11-21T10:25:55  *** Deacyde has joined #bitcoin-core-dev
221 2017-11-21T10:27:26  *** Deacydal has quit IRC
222 2017-11-21T10:32:13  *** AaronvanW has quit IRC
223 2017-11-21T10:32:50  *** AaronvanW has joined #bitcoin-core-dev
224 2017-11-21T10:37:21  *** AaronvanW has quit IRC
225 2017-11-21T10:38:18  *** pergaminho has joined #bitcoin-core-dev
226 2017-11-21T10:49:17  *** AaronvanW has joined #bitcoin-core-dev
227 2017-11-21T10:51:02  *** TrufflePig has quit IRC
228 2017-11-21T11:02:54  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
229 2017-11-21T11:12:49  *** AaronvanW has quit IRC
230 2017-11-21T11:13:21  *** d_t has quit IRC
231 2017-11-21T11:14:45  *** AaronvanW has joined #bitcoin-core-dev
232 2017-11-21T11:31:18  *** Kieran4Stehr has quit IRC
233 2017-11-21T11:39:26  *** quantbot has joined #bitcoin-core-dev
234 2017-11-21T11:43:47  *** quantbot has quit IRC
235 2017-11-21T11:44:19  *** quantbot has joined #bitcoin-core-dev
236 2017-11-21T11:48:28  *** quantbot has quit IRC
237 2017-11-21T11:54:09  *** jtimon has quit IRC
238 2017-11-21T12:06:55  *** indistylo has joined #bitcoin-core-dev
239 2017-11-21T12:22:30  *** quantbot has joined #bitcoin-core-dev
240 2017-11-21T12:23:35  *** quantbot has joined #bitcoin-core-dev
241 2017-11-21T12:26:24  <Varunram> Hey guys, have a small question - Can anyone suggest an easy way to view the nSequence bit for rbf signalling? Thanks!
242 2017-11-21T12:27:45  *** quantbot has quit IRC
243 2017-11-21T12:34:09  <Varunram> well, nvm, I just parsed the json from getrawtransaction :)
244 2017-11-21T12:49:53  *** SopaXorzTaker has joined #bitcoin-core-dev
245 2017-11-21T13:00:14  *** ghost43 has quit IRC
246 2017-11-21T13:00:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
247 2017-11-21T13:02:31  *** ghost43 has joined #bitcoin-core-dev
248 2017-11-21T13:06:53  *** StopAndDecrypt has quit IRC
249 2017-11-21T13:07:02  *** StopAndDecrypt_ has joined #bitcoin-core-dev
250 2017-11-21T13:26:55  *** nelruk has joined #bitcoin-core-dev
251 2017-11-21T13:30:48  *** Emcy_ has joined #bitcoin-core-dev
252 2017-11-21T13:32:20  *** Emcy has quit IRC
253 2017-11-21T13:33:28  *** Giszmo has joined #bitcoin-core-dev
254 2017-11-21T13:42:30  *** nelruk has quit IRC
255 2017-11-21T13:46:02  *** instagibbs has quit IRC
256 2017-11-21T13:52:47  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11743: qa: Add multiwallet prefix test (master...Mf1711-qaMultiwallet) https://github.com/bitcoin/bitcoin/pull/11743
257 2017-11-21T13:58:38  *** Cogito_Ergo_Sum has quit IRC
258 2017-11-21T14:02:04  *** Chris_Stewart_5 has quit IRC
259 2017-11-21T14:03:03  *** meshcollider has quit IRC
260 2017-11-21T14:12:24  *** instagibbs has joined #bitcoin-core-dev
261 2017-11-21T14:14:10  *** quantbot has joined #bitcoin-core-dev
262 2017-11-21T14:14:30  *** Emcy has joined #bitcoin-core-dev
263 2017-11-21T14:14:35  *** quantbot has quit IRC
264 2017-11-21T14:15:01  *** quantbot has joined #bitcoin-core-dev
265 2017-11-21T14:15:11  *** TimTheEngineer has joined #bitcoin-core-dev
266 2017-11-21T14:16:11  *** Emcy_ has quit IRC
267 2017-11-21T14:18:49  *** fanquake has quit IRC
268 2017-11-21T14:30:12  *** quantbot has quit IRC
269 2017-11-21T14:30:28  *** quantbot has joined #bitcoin-core-dev
270 2017-11-21T14:33:55  *** Guyver2 has joined #bitcoin-core-dev
271 2017-11-21T14:45:05  *** Emcy has quit IRC
272 2017-11-21T14:47:10  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
273 2017-11-21T14:47:11  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
274 2017-11-21T14:53:48  *** Emcy has joined #bitcoin-core-dev
275 2017-11-21T14:55:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
276 2017-11-21T14:57:03  *** indistylo has quit IRC
277 2017-11-21T14:58:08  *** MrPaz has joined #bitcoin-core-dev
278 2017-11-21T14:59:07  *** Kedstar has quit IRC
279 2017-11-21T15:07:32  *** satwo has quit IRC
280 2017-11-21T15:17:57  *** laurentmt1 has joined #bitcoin-core-dev
281 2017-11-21T15:18:30  *** satwo has joined #bitcoin-core-dev
282 2017-11-21T15:19:03  *** laurentmt has quit IRC
283 2017-11-21T15:19:04  *** laurentmt1 is now known as laurentmt
284 2017-11-21T15:25:06  *** promag has joined #bitcoin-core-dev
285 2017-11-21T15:46:30  *** cai has joined #bitcoin-core-dev
286 2017-11-21T15:56:08  <promag> wumpus: should #10996 be discussed next meeting?
287 2017-11-21T15:56:10  <gribble> https://github.com/bitcoin/bitcoin/issues/10996 | Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
288 2017-11-21T15:57:29  <wumpus> promag: sure
289 2017-11-21T15:57:42  <promag> I'll give it a try
290 2017-11-21T15:57:52  <wumpus> promag: I think it'd help a lot in changes that we're making that effectively set configuration for a single network
291 2017-11-21T15:58:16  <promag> +
292 2017-11-21T15:58:18  <promag> +1
293 2017-11-21T15:58:54  <promag> I don't think we should allow overwriting logs different networks
294 2017-11-21T15:59:04  <promag> *of different networks
295 2017-11-21T15:59:47  <wumpus> we could allow some settings to only appear in per-network configuration or command line
296 2017-11-21T16:03:19  <wumpus> we have no way of handling multiple daemons writing to the same log file so we really want to avoid that
297 2017-11-21T16:03:44  <promag> right
298 2017-11-21T16:04:49  <promag> maybe GetArg and friends could automatically handle options like `-(<network>-)?<arg>`?
299 2017-11-21T16:05:13  <wumpus> also it'd make no sense, we'd have to distinguish which daemon is logging for each line - if you really want to dump all your bitcoin logging to one place, you can already use -printtoconsole w/ some log aggregation like systemd
300 2017-11-21T16:05:38  <promag> right, proper logging
301 2017-11-21T16:05:39  <wumpus> yea that'd be another option
302 2017-11-21T16:06:27  <wumpus> to make it possible to prefix options with -regtest- and -testnet- or -mainnet-, that would (afaik) work just as well as per-network configuration files...
303 2017-11-21T16:07:15  <promag> wumpus: the only difference is that you must launch with the network argument
304 2017-11-21T16:07:27  <promag> so that it can read from the correct config file
305 2017-11-21T16:08:46  <promag> with a single file, GetArg could 1st check -(<network>-)?<arg> and then -<arg>
306 2017-11-21T16:08:53  <aj> hmm, does "-testnet-logfile=BLAH" make more sense than "-logfile=blah-$NETWORK-log" ?
307 2017-11-21T16:09:43  <promag> aj: IMO it does, with $NETWORK you are stick to that replacement
308 2017-11-21T16:10:27  <promag> anyway, something to discuss thrusday
309 2017-11-21T16:12:15  <aj> promag: you could still use different conf files (-conffile or network specific) to have different names, but yeah, i think i agree
310 2017-11-21T16:13:03  <aj> promag: i think setting -logfile=blah should be treated as -mainnet-logfile=blah, so if you run -regtest or -testnet you get an error, though...
311 2017-11-21T16:13:12  <hkjn0> hey, I noticed that getrawtransaction says "Use gettransaction for wallet transactions" when it doesn't have a transaction.. but the gettransaction RPC doesn't seem to exist on my node, presumably because I compiled it with --disable-wallet?
312 2017-11-21T16:13:36  <aj> promag: (or it uses the default location, rather than erroring probably)
313 2017-11-21T16:13:54  <hkjn0> if that's what's going on, might it make sense to still have all the wallet RPCs stubbed out with a helpful message, even when wallet support is not compiled in?
314 2017-11-21T16:15:36  <wumpus> hkjn0: would be better to change the getrawtransaction message to not mention the wallet if wallet support is not built in
315 2017-11-21T16:15:50  <achow101> hkjn0: gettransaction is a wallet rpc, so if you did --disable-wallet, it won't exist
316 2017-11-21T16:16:23  <hkjn0> ok wumpus, that also would make sense to me, but we agree current messages are somewhat confusing?
317 2017-11-21T16:17:17  <wumpus> stubbing out the methods would add some code, and would make the wallet method names exist in yet another place, I prefer for nothing wallet-related to be in the client at all if built without
318 2017-11-21T16:17:55  <wumpus> --disable-build is very much an advanced option, we don't ship binaries with that, and assume people that use it know what they're doing
319 2017-11-21T16:18:00  <wumpus> disable-wallet lol
320 2017-11-21T16:18:20  <hkjn0> clearly a risky assumption, in my case! :)
321 2017-11-21T16:18:52  <hkjn0> ok, if the change is to just modify the getrawtransaction message if wallet isn't enabled, what's the best way to do that? should I file an issue?
322 2017-11-21T16:19:07  <wumpus> make a patch and file a PR
323 2017-11-21T16:19:53  <wumpus> if you create an issue for something non-critical without providing code, it's unlikely it's ever picked up
324 2017-11-21T16:21:35  <hkjn0> I'm just asking for advice for best processes here, change might be simple enough that I can give it a whirl.. but the change is so small an issue is unnecessary here?
325 2017-11-21T16:22:15  <hkjn0> or is it preferred to have issue + patch, even for small changes?
326 2017-11-21T16:24:33  *** DigitalDank has quit IRC
327 2017-11-21T16:24:37  *** geezas has quit IRC
328 2017-11-21T16:25:23  <wumpus> we always handle code changes through github PRs, even small ones
329 2017-11-21T16:25:28  <wumpus> they still need review
330 2017-11-21T16:27:52  *** bule has joined #bitcoin-core-dev
331 2017-11-21T16:29:21  <aj> jnewbery: btw, are you going to revive #11047 ?
332 2017-11-21T16:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/11047 | [tests] rename functional tests by jnewbery · Pull Request #11047 · bitcoin/bitcoin · GitHub
333 2017-11-21T16:33:21  <hkjn0> wumpus: sorry if I was unclear, I realize all changes go through PRs, but my question was whether it was encouraged to have PR + GH issue even for small changes, or if PR alone would suffice
334 2017-11-21T16:33:53  <wumpus> PR alone is fine
335 2017-11-21T16:34:22  <hkjn0> cool
336 2017-11-21T16:34:30  <wumpus> sorry, was also confused by terminology, as github regards a PR also as a kind of issue
337 2017-11-21T16:34:35  <instagibbs> hkjn0: please at least describe if it fixes something though
338 2017-11-21T16:36:12  <hkjn0> instagibbs: could you elaborate? are you saying "use good descriptions in commits / PRs", or something else?
339 2017-11-21T16:37:43  <instagibbs> hkjn0: right, as appropriate. At a minimum in the PR, so I can git blame and backtrace
340 2017-11-21T16:38:25  <instagibbs> certain contributors aren't that great at it :P
341 2017-11-21T16:38:28  *** Dizzle has joined #bitcoin-core-dev
342 2017-11-21T16:39:25  <hkjn0> kk, for sure.. I'm pretty used to commit messages many times longer than actual code diff :)
343 2017-11-21T16:39:48  <bitcoin-git> [bitcoin] practicalswift opened pull request #11744: net: Add missing locks in net.{cpp,h} (master...missing-net-locks) https://github.com/bitcoin/bitcoin/pull/11744
344 2017-11-21T16:40:20  *** promag has quit IRC
345 2017-11-21T16:40:32  *** Emcy_ has joined #bitcoin-core-dev
346 2017-11-21T16:41:52  *** Emcy has quit IRC
347 2017-11-21T16:44:56  *** jtimon has joined #bitcoin-core-dev
348 2017-11-21T16:45:53  *** Randolf has quit IRC
349 2017-11-21T16:46:04  <instagibbs> hkjn0: perfect :)
350 2017-11-21T16:53:19  *** Emcy has joined #bitcoin-core-dev
351 2017-11-21T16:53:51  *** ula has joined #bitcoin-core-dev
352 2017-11-21T16:54:28  *** Emcy_ has quit IRC
353 2017-11-21T16:58:57  *** Emcy_ has joined #bitcoin-core-dev
354 2017-11-21T16:59:57  *** Emcy has quit IRC
355 2017-11-21T17:03:01  *** jb55 has joined #bitcoin-core-dev
356 2017-11-21T17:05:14  <jnewbery> aj: it's not near the top of my list. If you want it, it's yours!
357 2017-11-21T17:07:30  *** Emcy has joined #bitcoin-core-dev
358 2017-11-21T17:08:49  *** Emcy_ has quit IRC
359 2017-11-21T17:10:33  *** BashCo has quit IRC
360 2017-11-21T17:11:09  *** BashCo has joined #bitcoin-core-dev
361 2017-11-21T17:15:02  *** Randolf has joined #bitcoin-core-dev
362 2017-11-21T17:15:37  *** BashCo has quit IRC
363 2017-11-21T17:20:34  <aj> jnewbery: does it need anything other than regular rebases and nit fixes?
364 2017-11-21T17:25:03  *** indistylo has joined #bitcoin-core-dev
365 2017-11-21T17:25:56  *** Emcy_ has joined #bitcoin-core-dev
366 2017-11-21T17:27:19  *** Emcy has quit IRC
367 2017-11-21T17:30:08  *** timothy has quit IRC
368 2017-11-21T17:34:16  *** BashCo has joined #bitcoin-core-dev
369 2017-11-21T17:42:56  *** StopAndDecrypt_ has quit IRC
370 2017-11-21T17:59:15  *** photonclock_ has quit IRC
371 2017-11-21T18:08:03  *** booyah is now known as SoCo__cpp_
372 2017-11-21T18:11:19  *** SoCo__cpp_ is now known as booyah
373 2017-11-21T18:15:52  <bitcoin-git> [bitcoin] practicalswift opened pull request #11746: trivial: Fix unsuccessful typo (master...unsuccesful) https://github.com/bitcoin/bitcoin/pull/11746
374 2017-11-21T18:19:17  *** dqx has joined #bitcoin-core-dev
375 2017-11-21T18:19:23  *** Ylbam has joined #bitcoin-core-dev
376 2017-11-21T18:19:59  *** dqx has quit IRC
377 2017-11-21T18:20:07  *** PaulCapestany has quit IRC
378 2017-11-21T18:22:16  *** PaulCapestany has joined #bitcoin-core-dev
379 2017-11-21T18:22:46  *** Emcy has joined #bitcoin-core-dev
380 2017-11-21T18:23:57  *** Emcy_ has quit IRC
381 2017-11-21T18:27:11  *** Emcy_ has joined #bitcoin-core-dev
382 2017-11-21T18:28:38  *** Emcy has quit IRC
383 2017-11-21T18:38:20  *** instagibbs has quit IRC
384 2017-11-21T18:41:23  *** Emcy has joined #bitcoin-core-dev
385 2017-11-21T18:42:17  *** Emcy_ has quit IRC
386 2017-11-21T18:43:06  <jonasschnelli> sipa: do you still have that "block request amount" graph? (what depth will be received how frequently)?
387 2017-11-21T18:46:40  *** AaronvanW has quit IRC
388 2017-11-21T18:47:18  *** AaronvanW has joined #bitcoin-core-dev
389 2017-11-21T18:50:23  *** promag has joined #bitcoin-core-dev
390 2017-11-21T18:52:38  *** Emcy_ has joined #bitcoin-core-dev
391 2017-11-21T18:53:52  *** Emcy has quit IRC
392 2017-11-21T18:53:58  *** laurentmt has quit IRC
393 2017-11-21T18:58:33  *** Randolf has quit IRC
394 2017-11-21T19:00:26  *** d_t has joined #bitcoin-core-dev
395 2017-11-21T19:03:23  *** Randolf has joined #bitcoin-core-dev
396 2017-11-21T19:05:13  *** StopAndDecrypt has joined #bitcoin-core-dev
397 2017-11-21T19:05:44  <sipa> jonasschnelli: i'm still gathering the data
398 2017-11-21T19:06:27  <jonasschnelli> sipa: okay.. you have a live graph? or you will produce one once you have collected enought points?
399 2017-11-21T19:06:41  *** Emcy has joined #bitcoin-core-dev
400 2017-11-21T19:08:01  *** Emcy_ has quit IRC
401 2017-11-21T19:08:28  *** promag has joined #bitcoin-core-dev
402 2017-11-21T19:08:48  *** bule has quit IRC
403 2017-11-21T19:09:26  *** bule has joined #bitcoin-core-dev
404 2017-11-21T19:14:32  *** Emcy has quit IRC
405 2017-11-21T19:17:12  *** Emcy has joined #bitcoin-core-dev
406 2017-11-21T19:22:44  *** SopaXorzTaker has quit IRC
407 2017-11-21T19:25:26  *** Emcy_ has joined #bitcoin-core-dev
408 2017-11-21T19:25:46  *** quantbot_ has joined #bitcoin-core-dev
409 2017-11-21T19:26:55  *** quantbot has quit IRC
410 2017-11-21T19:26:57  *** Emcy has quit IRC
411 2017-11-21T19:27:42  *** AaronvanW has quit IRC
412 2017-11-21T19:28:19  *** pergaminho has quit IRC
413 2017-11-21T19:29:39  *** AaronvanW has joined #bitcoin-core-dev
414 2017-11-21T19:30:35  *** jb55 has quit IRC
415 2017-11-21T19:31:39  *** Emcy has joined #bitcoin-core-dev
416 2017-11-21T19:32:49  *** Emcy_ has quit IRC
417 2017-11-21T19:35:30  *** AaronvanW has quit IRC
418 2017-11-21T19:36:07  *** AaronvanW has joined #bitcoin-core-dev
419 2017-11-21T19:41:06  *** Emcy_ has joined #bitcoin-core-dev
420 2017-11-21T19:41:23  *** Emcy has quit IRC
421 2017-11-21T19:41:30  *** ChuckSupport has joined #bitcoin-core-dev
422 2017-11-21T19:41:36  *** satwo has quit IRC
423 2017-11-21T19:41:44  <bitcoin-git> [bitcoin] Elbandi opened pull request #11747: Fix: Open files read only if requested (master...fix11745) https://github.com/bitcoin/bitcoin/pull/11747
424 2017-11-21T19:44:35  <ChuckSupport> Good day! I've been saving up since 2015 to buy my own antminer and finally mine on core and not GPU mine. I'm a QA first developer second and would like to contribute but I'm still new to github practices. Can someone suggest how I could go about this? Start with github practices, then how can I pull test code and test ,etc. Thanks for everything you've done and sacrificed for this!
425 2017-11-21T19:47:50  *** Emcy has joined #bitcoin-core-dev
426 2017-11-21T19:48:41  *** TrufflePig has joined #bitcoin-core-dev
427 2017-11-21T19:48:58  *** Emcy_ has quit IRC
428 2017-11-21T19:49:21  *** Jackson has joined #bitcoin-core-dev
429 2017-11-21T19:49:54  *** Jackson is now known as Guest32972
430 2017-11-21T19:54:10  *** Guest32972 has quit IRC
431 2017-11-21T19:55:56  *** ChuckSupport has quit IRC
432 2017-11-21T19:59:27  *** dcousens has quit IRC
433 2017-11-21T20:00:24  *** Emcy_ has joined #bitcoin-core-dev
434 2017-11-21T20:00:42  *** dcousens has joined #bitcoin-core-dev
435 2017-11-21T20:01:34  *** Emcy has quit IRC
436 2017-11-21T20:05:46  *** meshcollider has joined #bitcoin-core-dev
437 2017-11-21T20:06:10  <andytoshi> Chris_Stewart_5: #bitcoin-mining will probably be more helpful, or #bitcoin. this channel is specifically about software development of Bitcoin Core
438 2017-11-21T20:06:24  <andytoshi> sorry Chris_Stewart_5 i meant to highlight that guy who left
439 2017-11-21T20:06:40  *** wunpunch has joined #bitcoin-core-dev
440 2017-11-21T20:07:32  *** quantbot has joined #bitcoin-core-dev
441 2017-11-21T20:07:57  *** wunpunch has quit IRC
442 2017-11-21T20:08:01  *** indistylo has quit IRC
443 2017-11-21T20:08:16  *** wunpunch has joined #bitcoin-core-dev
444 2017-11-21T20:09:47  *** indistylo has joined #bitcoin-core-dev
445 2017-11-21T20:11:13  *** quantbot_ has quit IRC
446 2017-11-21T20:11:20  *** Emcy_ has quit IRC
447 2017-11-21T20:11:59  *** quantbot has quit IRC
448 2017-11-21T20:17:18  *** wunpunch has quit IRC
449 2017-11-21T20:17:36  *** wunpunch has joined #bitcoin-core-dev
450 2017-11-21T20:17:42  *** Chris_Stewart_5 has quit IRC
451 2017-11-21T20:20:28  *** Emcy has joined #bitcoin-core-dev
452 2017-11-21T20:27:35  *** laurentmt has joined #bitcoin-core-dev
453 2017-11-21T20:30:25  *** laurentmt has quit IRC
454 2017-11-21T20:32:04  *** wunpunch has quit IRC
455 2017-11-21T20:32:24  *** wunpunch has joined #bitcoin-core-dev
456 2017-11-21T20:33:49  *** wunpunch has quit IRC
457 2017-11-21T20:34:09  *** wunpunch has joined #bitcoin-core-dev
458 2017-11-21T20:35:36  *** satwo has joined #bitcoin-core-dev
459 2017-11-21T20:38:04  *** jeffrade has joined #bitcoin-core-dev
460 2017-11-21T20:40:31  *** jeffrade has quit IRC
461 2017-11-21T20:41:41  *** jannes has quit IRC
462 2017-11-21T20:44:51  *** Aaronvan_ has joined #bitcoin-core-dev
463 2017-11-21T20:46:05  *** AaronvanW has quit IRC
464 2017-11-21T20:51:24  *** Randolf has quit IRC
465 2017-11-21T20:54:17  *** Aaronvan_ is now known as AaronvanW
466 2017-11-21T20:54:49  *** promag has quit IRC
467 2017-11-21T20:55:51  *** laurentmt has joined #bitcoin-core-dev
468 2017-11-21T20:56:00  *** laurentmt has quit IRC
469 2017-11-21T20:56:47  *** Fabrice_ has joined #bitcoin-core-dev
470 2017-11-21T20:57:30  *** Fabrice_ has left #bitcoin-core-dev
471 2017-11-21T20:59:59  *** jb55 has joined #bitcoin-core-dev
472 2017-11-21T21:00:26  *** jb55 has quit IRC
473 2017-11-21T21:04:33  *** indistylo has quit IRC
474 2017-11-21T21:15:44  *** lio17 has joined #bitcoin-core-dev
475 2017-11-21T21:16:42  *** instagibbs has joined #bitcoin-core-dev
476 2017-11-21T21:17:02  *** jb55 has joined #bitcoin-core-dev
477 2017-11-21T21:26:25  *** jb55 has quit IRC
478 2017-11-21T21:28:49  *** TrufflePig has quit IRC
479 2017-11-21T21:31:12  *** jtimon has quit IRC
480 2017-11-21T21:37:53  *** ula has quit IRC
481 2017-11-21T21:45:44  *** Randolf has joined #bitcoin-core-dev
482 2017-11-21T21:51:45  *** Cheeseo has joined #bitcoin-core-dev
483 2017-11-21T21:55:12  *** wunpunch has quit IRC
484 2017-11-21T21:55:32  *** wunpunch has joined #bitcoin-core-dev
485 2017-11-21T21:56:48  *** cheese_ has joined #bitcoin-core-dev
486 2017-11-21T22:00:33  *** Cheeseo has quit IRC
487 2017-11-21T22:00:43  *** Guyver2 has quit IRC
488 2017-11-21T22:02:15  *** rundom has quit IRC
489 2017-11-21T22:02:36  *** jtimon has joined #bitcoin-core-dev
490 2017-11-21T22:08:08  *** Cheeseo has joined #bitcoin-core-dev
491 2017-11-21T22:11:13  *** cheese_ has quit IRC
492 2017-11-21T22:15:21  *** meshcollider has quit IRC
493 2017-11-21T22:24:49  *** meshcollider has joined #bitcoin-core-dev
494 2017-11-21T22:26:41  *** Cheeseo has quit IRC
495 2017-11-21T22:29:16  <meshcollider> aj: are you here atm?
496 2017-11-21T22:29:26  <aj> meshcollider: hey
497 2017-11-21T22:29:42  <meshcollider> aj: re #10996, I'm just a little confused now
498 2017-11-21T22:29:44  <gribble> https://github.com/bitcoin/bitcoin/issues/10996 | Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
499 2017-11-21T22:30:19  <meshcollider> -netconf is just -conf but relative to net-specific datadir?
500 2017-11-21T22:31:23  <aj> meshcollider: yeah: patch makes bitcoind load two config files, .bitcoin/bitcoin.conf and .bitcoin/testnet3/network.conf; -conf lets you choose a different name for the first one, -netconf a different name for the second one
501 2017-11-21T22:32:01  *** Randolf has quit IRC
502 2017-11-21T22:32:58  <meshcollider> I like the default reading of the network specific config file but I'm worried the parameter interaction between conf and netconf will confuse users
503 2017-11-21T22:34:04  <aj> meshcollider: i worry about that too. current behaviour is that bitcoin.conf is loaded first and network.conf second (so bitcoin.conf can specify the network), and any setting in bitcoin.conf overrides any setting in network.conf
504 2017-11-21T22:35:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
505 2017-11-21T22:35:31  <aj> meshcollider: (ie, GetArg returns the first value seen, GetArgs returns all of them from both files)
506 2017-11-21T22:36:10  <meshcollider> aj: Perhaps instead of -netconf parameter, just rely on -conf for specifying a config file if they want (because they can specify one in a net-specific directory explicitly if they want) and then only load the network.conf if -conf is not specified?
507 2017-11-21T22:38:02  <aj> meshcollider: hmm.. the choice i'm seeing is between having a param to let you choose a different name for the file, or no param at all and just always checking for datadir/network.conf
508 2017-11-21T22:38:41  <meshcollider> I think if people are explicitly specifying a different config with -conf parameter, we can assume they want to use it on the network they've specified right?
509 2017-11-21T22:39:08  *** arubi has quit IRC
510 2017-11-21T22:39:36  <meshcollider> So if they use -conf, we only load that, but if they don't then we load the network specific file by default too?
511 2017-11-21T22:40:00  *** Anduck has quit IRC
512 2017-11-21T22:40:11  <meshcollider> aj: But perhaps I haven't fully understood the use case so it's your call
513 2017-11-21T22:40:29  *** Cheeseo has joined #bitcoin-core-dev
514 2017-11-21T22:40:38  *** Anduck has joined #bitcoin-core-dev
515 2017-11-21T22:43:01  <jnewbery> aj: sorry for long delay. Yes, just rebase and nits. Rebase should be easy - it's just a case of re-running the script
516 2017-11-21T22:45:10  *** Dizzle has quit IRC
517 2017-11-21T22:47:31  <aj> jnewbery: no worries about the delay, that's why the i in irc doesn't stand for instant :) sounds good, i guess i'll check with MarcoFalke that there's not more reason to close it than inactivity
518 2017-11-21T22:51:01  <aj> meshcollider: i'm not sure if there's a use case... atm, you could have standard settings in bitcoin.conf and special settings in network.conf (mainnet addnode's say), and switch either independently via command line options. that just seems a bit more flexible and maybe natural to me?
519 2017-11-21T22:53:53  <meshcollider> aj: Or, what if both the net specific file and the root datadir one had the same name, and -conf specified them both?
520 2017-11-21T22:54:16  <meshcollider> Or would having them both called bitcoin.conf be confusing
521 2017-11-21T22:54:17  <aj> meshcollider: mainnet bitcoin.conf and network.conf live in the same directory :(
522 2017-11-21T22:54:30  <meshcollider> Ah true lol
523 2017-11-21T22:56:16  <meshcollider> aj: Hmm perhaps someone else will give feedback on the approach too, I think I'd still prefer not having the netconf command and just using conf if it's specified but yeah no massive leaning either way
524 2017-11-21T22:56:45  *** JeffSlentz has quit IRC
525 2017-11-21T22:59:20  *** promag has joined #bitcoin-core-dev
526 2017-11-21T22:59:58  <aj> meshcollider: i might see if i can code up your way and match the tests, see what it looks liek
527 2017-11-21T23:00:26  <meshcollider> aj: sounds good, thank you! :)
528 2017-11-21T23:00:39  <meshcollider> Sorry for being difficult :)
529 2017-11-21T23:00:39  <aj> meshcollider: i don't expect to like it, but i've been wrong before :)
530 2017-11-21T23:06:52  <aj> meshcollider: hmm, question is, if i respond in less than two weeks, will the difficulty increase...
531 2017-11-21T23:09:40  *** cheese_ has joined #bitcoin-core-dev
532 2017-11-21T23:12:42  *** Cheeseo has quit IRC
533 2017-11-21T23:19:12  *** cheese_ has quit IRC
534 2017-11-21T23:26:37  *** Cheeseo has joined #bitcoin-core-dev
535 2017-11-21T23:27:54  *** Cogito_Ergo_Sum has quit IRC
536 2017-11-21T23:30:31  *** Randolf has joined #bitcoin-core-dev
537 2017-11-21T23:31:46  *** Aaronvan_ has joined #bitcoin-core-dev
538 2017-11-21T23:33:30  *** tknp has joined #bitcoin-core-dev
539 2017-11-21T23:33:40  *** Aaronvan_ has quit IRC
540 2017-11-21T23:35:23  *** AaronvanW has quit IRC
541 2017-11-21T23:35:30  *** Aaronvan_ has joined #bitcoin-core-dev
542 2017-11-21T23:36:29  *** Aaronvan_ has quit IRC
543 2017-11-21T23:37:08  *** AaronvanW has joined #bitcoin-core-dev
544 2017-11-21T23:37:38  *** chjj has quit IRC
545 2017-11-21T23:37:50  <bitcoin-git> [bitcoin] fanquake closed pull request #11735: [refactor] Remove magic numbers from HMAC SHA256 (master...eliminate_magic_numbers) https://github.com/bitcoin/bitcoin/pull/11735
546 2017-11-21T23:38:16  *** fanquake has joined #bitcoin-core-dev
547 2017-11-21T23:39:08  *** Chris_Stewart_5 has quit IRC
548 2017-11-21T23:40:46  *** wxss has quit IRC