1 2017-11-25T00:11:35  *** go1111111 has quit IRC
  2 2017-11-25T00:11:48  *** go1111111 has joined #bitcoin-core-dev
  3 2017-11-25T00:11:55  *** go11111111111 has joined #bitcoin-core-dev
  4 2017-11-25T00:13:24  *** dqx_ has quit IRC
  5 2017-11-25T00:16:31  *** d_t has quit IRC
  6 2017-11-25T00:26:40  *** dqx_ has joined #bitcoin-core-dev
  7 2017-11-25T00:26:47  *** Khunbish has left #bitcoin-core-dev
  8 2017-11-25T00:29:56  *** dqx_ has quit IRC
  9 2017-11-25T00:36:37  *** Giszmo has joined #bitcoin-core-dev
 10 2017-11-25T00:39:12  *** Aaronvan_ has joined #bitcoin-core-dev
 11 2017-11-25T00:39:14  *** StopAndDecrypt has quit IRC
 12 2017-11-25T00:39:14  *** StopAndDecrypt has joined #bitcoin-core-dev
 13 2017-11-25T00:42:00  *** Aaronvan_ has quit IRC
 14 2017-11-25T00:42:09  *** AaronvanW has quit IRC
 15 2017-11-25T00:44:52  *** owowo has quit IRC
 16 2017-11-25T00:50:01  *** owowo has joined #bitcoin-core-dev
 17 2017-11-25T00:54:27  *** wxss has quit IRC
 18 2017-11-25T01:01:29  *** roadcrap has joined #bitcoin-core-dev
 19 2017-11-25T01:02:19  *** d_t has joined #bitcoin-core-dev
 20 2017-11-25T01:08:12  *** Randolf has quit IRC
 21 2017-11-25T01:10:09  *** Randolf has joined #bitcoin-core-dev
 22 2017-11-25T01:13:34  *** jtimon has joined #bitcoin-core-dev
 23 2017-11-25T01:19:54  *** alreadylate has joined #bitcoin-core-dev
 24 2017-11-25T01:24:57  *** d_t has quit IRC
 25 2017-11-25T01:44:31  *** Randolf has quit IRC
 26 2017-11-25T01:50:41  *** alreadylate has quit IRC
 27 2017-11-25T01:53:57  *** StopAndDecrypt_ has joined #bitcoin-core-dev
 28 2017-11-25T01:54:27  *** StopAndDecrypt has quit IRC
 29 2017-11-25T01:57:16  *** goatpig has quit IRC
 30 2017-11-25T01:57:54  *** vicenteH has quit IRC
 31 2017-11-25T01:58:10  *** vicenteH has joined #bitcoin-core-dev
 32 2017-11-25T02:02:25  *** Randolf has joined #bitcoin-core-dev
 33 2017-11-25T02:07:31  *** Randolf has quit IRC
 34 2017-11-25T02:23:01  *** Randolf has joined #bitcoin-core-dev
 35 2017-11-25T02:36:35  *** Ylbam has quit IRC
 36 2017-11-25T02:37:01  *** lifeofguenter has quit IRC
 37 2017-11-25T02:41:42  *** alreadylate has joined #bitcoin-core-dev
 38 2017-11-25T02:41:48  *** lifeofguenter has joined #bitcoin-core-dev
 39 2017-11-25T02:47:05  *** Randolf has quit IRC
 40 2017-11-25T02:59:54  *** cysm has quit IRC
 41 2017-11-25T03:06:13  *** Randolf has joined #bitcoin-core-dev
 42 2017-11-25T03:08:30  *** cysm has joined #bitcoin-core-dev
 43 2017-11-25T03:12:37  *** dqx_ has joined #bitcoin-core-dev
 44 2017-11-25T03:17:19  *** Randolf has quit IRC
 45 2017-11-25T03:25:35  *** dqx_ has quit IRC
 46 2017-11-25T03:33:57  *** Randolf has joined #bitcoin-core-dev
 47 2017-11-25T03:35:51  *** alreadylate has quit IRC
 48 2017-11-25T03:53:07  *** dqx_ has joined #bitcoin-core-dev
 49 2017-11-25T03:54:18  *** dqx has joined #bitcoin-core-dev
 50 2017-11-25T03:57:12  *** dqx_ has quit IRC
 51 2017-11-25T04:18:14  *** Randolf has quit IRC
 52 2017-11-25T04:21:23  *** pugsh has quit IRC
 53 2017-11-25T04:29:15  *** Randolf has joined #bitcoin-core-dev
 54 2017-11-25T04:40:19  *** digifis has joined #bitcoin-core-dev
 55 2017-11-25T04:43:02  *** Randolf has quit IRC
 56 2017-11-25T04:43:02  *** sin_ has quit IRC
 57 2017-11-25T04:53:07  *** Randolf has joined #bitcoin-core-dev
 58 2017-11-25T05:13:47  *** musalbas has quit IRC
 59 2017-11-25T05:29:11  *** d9b4bef9 has quit IRC
 60 2017-11-25T05:30:40  *** d9b4bef9 has joined #bitcoin-core-dev
 61 2017-11-25T05:46:23  *** quantbot has quit IRC
 62 2017-11-25T05:46:58  *** quantbot has joined #bitcoin-core-dev
 63 2017-11-25T05:51:29  *** quantbot has quit IRC
 64 2017-11-25T06:19:19  *** unholymachine has joined #bitcoin-core-dev
 65 2017-11-25T06:45:22  *** Evel-Knievel has quit IRC
 66 2017-11-25T06:57:13  *** Evel-Knievel has joined #bitcoin-core-dev
 67 2017-11-25T07:03:43  *** Sun has joined #bitcoin-core-dev
 68 2017-11-25T07:04:05  *** Sun is now known as Guest16480
 69 2017-11-25T07:07:39  *** justan0theruser has quit IRC
 70 2017-11-25T07:21:49  *** justan0theruser has joined #bitcoin-core-dev
 71 2017-11-25T07:25:00  *** Guest16480 has quit IRC
 72 2017-11-25T07:42:24  *** SopaXorzTaker has joined #bitcoin-core-dev
 73 2017-11-25T07:56:09  *** satwo has quit IRC
 74 2017-11-25T07:59:03  *** qrestlove has quit IRC
 75 2017-11-25T08:01:32  <bitcoin-git> [bitcoin] aaron-hanson opened pull request #11765: [REST] added blockhash api, tests and documentation (master...rest-blockhash-endpoint) https://github.com/bitcoin/bitcoin/pull/11765
 76 2017-11-25T08:02:14  *** Emcy_ has joined #bitcoin-core-dev
 77 2017-11-25T08:03:05  *** Emcy has quit IRC
 78 2017-11-25T08:04:07  *** quantbot has joined #bitcoin-core-dev
 79 2017-11-25T08:04:23  *** qrestlove has joined #bitcoin-core-dev
 80 2017-11-25T08:08:57  *** quantbot has quit IRC
 81 2017-11-25T08:31:33  *** AaronvanW has joined #bitcoin-core-dev
 82 2017-11-25T08:33:47  *** Aaronvan_ has joined #bitcoin-core-dev
 83 2017-11-25T08:37:21  *** AaronvanW has quit IRC
 84 2017-11-25T08:39:25  *** Aaronvan_ has quit IRC
 85 2017-11-25T09:06:52  *** qrestlove has quit IRC
 86 2017-11-25T09:13:46  *** Ylbam has joined #bitcoin-core-dev
 87 2017-11-25T09:18:45  *** qrestlove has joined #bitcoin-core-dev
 88 2017-11-25T09:36:39  *** StopAndDecrypt has joined #bitcoin-core-dev
 89 2017-11-25T09:36:39  *** StopAndDecrypt has quit IRC
 90 2017-11-25T09:36:39  *** StopAndDecrypt has joined #bitcoin-core-dev
 91 2017-11-25T09:37:03  *** StopAndDecrypt_ has quit IRC
 92 2017-11-25T10:14:07  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 93 2017-11-25T10:38:43  *** meshcollider has joined #bitcoin-core-dev
 94 2017-11-25T10:51:55  *** arubi has quit IRC
 95 2017-11-25T10:52:19  *** promag has joined #bitcoin-core-dev
 96 2017-11-25T10:52:54  *** arubi has joined #bitcoin-core-dev
 97 2017-11-25T10:59:29  *** goatpig has joined #bitcoin-core-dev
 98 2017-11-25T11:16:51  *** kiranymous has joined #bitcoin-core-dev
 99 2017-11-25T11:19:32  *** kiranymous has quit IRC
100 2017-11-25T11:19:57  *** kiranymous has joined #bitcoin-core-dev
101 2017-11-25T11:21:28  *** promag has quit IRC
102 2017-11-25T11:23:56  *** jamescowden has joined #bitcoin-core-dev
103 2017-11-25T11:36:13  *** promag has joined #bitcoin-core-dev
104 2017-11-25T11:45:49  *** kiranymous has quit IRC
105 2017-11-25T11:48:22  *** promag has quit IRC
106 2017-11-25T11:52:35  *** alreadylate has joined #bitcoin-core-dev
107 2017-11-25T11:53:24  *** justan0theruser has quit IRC
108 2017-11-25T12:07:39  *** user_____ has joined #bitcoin-core-dev
109 2017-11-25T12:07:45  *** justan0theruser has joined #bitcoin-core-dev
110 2017-11-25T12:08:40  *** jamescowden has quit IRC
111 2017-11-25T12:11:51  *** user_____ has quit IRC
112 2017-11-25T12:12:44  *** qube_ has joined #bitcoin-core-dev
113 2017-11-25T12:15:51  *** wxss has joined #bitcoin-core-dev
114 2017-11-25T12:20:36  *** qube_ has quit IRC
115 2017-11-25T12:22:04  *** quantbot has joined #bitcoin-core-dev
116 2017-11-25T12:26:27  *** quantbot has quit IRC
117 2017-11-25T12:29:31  *** quantbot has joined #bitcoin-core-dev
118 2017-11-25T12:33:32  *** satwo has joined #bitcoin-core-dev
119 2017-11-25T12:39:37  *** SopaXorzTaker has quit IRC
120 2017-11-25T12:40:21  *** SopaXorzTaker has joined #bitcoin-core-dev
121 2017-11-25T12:41:38  *** promag has joined #bitcoin-core-dev
122 2017-11-25T13:02:08  *** jamescowden has joined #bitcoin-core-dev
123 2017-11-25T13:04:20  *** promag has quit IRC
124 2017-11-25T13:21:51  *** Khunbish has joined #bitcoin-core-dev
125 2017-11-25T13:24:00  *** promag has joined #bitcoin-core-dev
126 2017-11-25T13:25:30  *** arubi has quit IRC
127 2017-11-25T13:25:53  *** arubi has joined #bitcoin-core-dev
128 2017-11-25T13:28:56  *** promag has quit IRC
129 2017-11-25T13:31:28  *** jamescowden has quit IRC
130 2017-11-25T13:32:00  *** jamescowden has joined #bitcoin-core-dev
131 2017-11-25T13:34:46  *** jamescowden has quit IRC
132 2017-11-25T13:34:59  *** jamescowden has joined #bitcoin-core-dev
133 2017-11-25T13:36:22  *** jamescowden has joined #bitcoin-core-dev
134 2017-11-25T13:38:50  *** Guyver2 has joined #bitcoin-core-dev
135 2017-11-25T13:41:05  *** jamescowden has quit IRC
136 2017-11-25T13:46:44  *** str4d has joined #bitcoin-core-dev
137 2017-11-25T13:51:41  *** promag has joined #bitcoin-core-dev
138 2017-11-25T13:54:48  *** jamescowden has joined #bitcoin-core-dev
139 2017-11-25T13:58:21  *** promag has quit IRC
140 2017-11-25T14:15:48  *** shesek has quit IRC
141 2017-11-25T14:26:13  *** jamescowden has quit IRC
142 2017-11-25T14:28:27  *** meshcollider has quit IRC
143 2017-11-25T14:33:29  *** shesek has joined #bitcoin-core-dev
144 2017-11-25T14:33:30  *** shesek has joined #bitcoin-core-dev
145 2017-11-25T14:56:14  *** jb55 has joined #bitcoin-core-dev
146 2017-11-25T14:56:44  *** jamescowden has joined #bitcoin-core-dev
147 2017-11-25T14:59:06  *** promag has joined #bitcoin-core-dev
148 2017-11-25T15:03:29  *** jamescowden has quit IRC
149 2017-11-25T15:36:53  *** jamescowden has joined #bitcoin-core-dev
150 2017-11-25T15:38:33  *** alreadylate has quit IRC
151 2017-11-25T15:42:12  *** jamescowden has quit IRC
152 2017-11-25T15:49:13  *** jamescowden has joined #bitcoin-core-dev
153 2017-11-25T15:49:28  *** jb55 has quit IRC
154 2017-11-25T15:53:41  *** jamescowden has quit IRC
155 2017-11-25T15:56:48  *** StopAndDecrypt has quit IRC
156 2017-11-25T16:00:38  *** jb55 has joined #bitcoin-core-dev
157 2017-11-25T16:06:58  *** StopAndDecrypt has joined #bitcoin-core-dev
158 2017-11-25T16:17:12  *** rhakhsa has joined #bitcoin-core-dev
159 2017-11-25T16:30:28  *** bitstein has joined #bitcoin-core-dev
160 2017-11-25T16:41:23  *** bitstein has quit IRC
161 2017-11-25T16:45:12  *** roadcrap has quit IRC
162 2017-11-25T16:54:20  *** jamescowden has joined #bitcoin-core-dev
163 2017-11-25T16:58:35  *** jamescowden has quit IRC
164 2017-11-25T17:11:42  *** musalbas has joined #bitcoin-core-dev
165 2017-11-25T17:19:15  *** THoVer has joined #bitcoin-core-dev
166 2017-11-25T17:21:58  *** THoVer has quit IRC
167 2017-11-25T17:21:58  *** jb55 has quit IRC
168 2017-11-25T17:23:00  *** Cogito_Ergo_Sum has quit IRC
169 2017-11-25T17:24:23  *** jamescowden has joined #bitcoin-core-dev
170 2017-11-25T17:28:55  *** jamescowden has quit IRC
171 2017-11-25T17:35:09  *** jb55 has joined #bitcoin-core-dev
172 2017-11-25T17:43:27  *** jb55 has quit IRC
173 2017-11-25T17:54:16  *** jamescowden has joined #bitcoin-core-dev
174 2017-11-25T17:58:41  *** jamescowden has quit IRC
175 2017-11-25T18:00:34  *** promag has quit IRC
176 2017-11-25T18:00:45  *** promag has joined #bitcoin-core-dev
177 2017-11-25T18:05:26  *** promag has quit IRC
178 2017-11-25T18:29:50  *** janoside has joined #bitcoin-core-dev
179 2017-11-25T18:30:00  *** jamescowden has joined #bitcoin-core-dev
180 2017-11-25T18:32:08  *** janoside has quit IRC
181 2017-11-25T18:34:39  *** jamescowden has quit IRC
182 2017-11-25T18:39:52  *** promag has joined #bitcoin-core-dev
183 2017-11-25T18:54:23  *** jamescowden has joined #bitcoin-core-dev
184 2017-11-25T18:59:13  *** jamescowden has quit IRC
185 2017-11-25T19:08:41  *** jamescowden has joined #bitcoin-core-dev
186 2017-11-25T19:13:38  *** jamescowden has quit IRC
187 2017-11-25T19:27:57  *** Randolf has quit IRC
188 2017-11-25T19:30:37  *** SopaXorzTaker has quit IRC
189 2017-11-25T19:44:46  *** jamescowden has joined #bitcoin-core-dev
190 2017-11-25T19:45:18  *** promag has quit IRC
191 2017-11-25T19:46:13  <Lauda> I did [insertUselessPapers]
192 2017-11-25T19:46:15  <Lauda> oops
193 2017-11-25T19:49:19  *** jamescowden has quit IRC
194 2017-11-25T20:10:39  *** owowo has quit IRC
195 2017-11-25T20:13:20  *** Guyver2 has quit IRC
196 2017-11-25T20:16:01  *** owowo has joined #bitcoin-core-dev
197 2017-11-25T20:16:43  *** jamescowden has joined #bitcoin-core-dev
198 2017-11-25T20:21:32  *** jamescowden has quit IRC
199 2017-11-25T20:26:01  *** riemann has joined #bitcoin-core-dev
200 2017-11-25T20:34:43  *** btcdrak has joined #bitcoin-core-dev
201 2017-11-25T20:36:18  *** promag has joined #bitcoin-core-dev
202 2017-11-25T20:36:37  *** meshcollider has joined #bitcoin-core-dev
203 2017-11-25T20:41:09  *** arubi has quit IRC
204 2017-11-25T20:41:55  <archaeal> when adding commits to an open pull request, is the convention to squash them and force push, or keep them separate?  I noticed the contributing readme mentions squashing before a merge to master, but I'm wondering about before that?
205 2017-11-25T20:43:31  <promag> archaeal: usually it depends
206 2017-11-25T20:43:46  <promag> if you already have reviews, maybe push a new commit
207 2017-11-25T20:44:13  <archaeal> makes sense...  thanks!
208 2017-11-25T20:44:27  <promag> also, see git commit --fixup
209 2017-11-25T20:45:03  <promag> it helps later when squashing if your PR has multiple commits and multiple fixups
210 2017-11-25T20:45:52  <promag> usually I do git remote update origin && git rebase  with origin/master when squashing
211 2017-11-25T20:46:11  <promag> git rebase -i --autosquash origin/master
212 2017-11-25T20:46:21  <archaeal> yeah i generally use fixup when squashing
213 2017-11-25T20:46:42  <sipa> also, even if you squash, avoid rebasing until necessary
214 2017-11-25T20:47:15  <archaeal> ok thanks
215 2017-11-25T20:47:16  <sipa> it helps review if people can look at the diff between your new pr overall and the old version, without it being cluttered with changes from master
216 2017-11-25T20:47:24  <archaeal> ah yes
217 2017-11-25T20:47:40  <sipa> for simple PRs i generally don't care about squashing liberally
218 2017-11-25T20:48:39  <promag> sipa: how do you diff with old version?
219 2017-11-25T20:48:58  <sipa> git diff <commit> <commit>
220 2017-11-25T20:49:51  <promag> how do you know the 1st commit?
221 2017-11-25T20:50:41  <promag> especially in the case I push -f
222 2017-11-25T20:51:33  <meshcollider> promag: you have to have checked out the branch locally first I think?
223 2017-11-25T20:51:43  <sipa> promag: it's the one you acked before
224 2017-11-25T20:52:48  <meshcollider> GitHub doesn't store commits which were overwritten with -f does it
225 2017-11-25T20:53:38  <sipa> not for long, but you can easily pull them locally
226 2017-11-25T20:53:54  <sipa> by adding the pulls branch to your remote
227 2017-11-25T20:54:05  *** satwo has quit IRC
228 2017-11-25T20:54:09  <sipa> that way you always have all commits locally from all prs
229 2017-11-25T20:54:21  *** jamescowden has joined #bitcoin-core-dev
230 2017-11-25T20:55:11  <promag> but I have to remote update all remotes right?
231 2017-11-25T20:57:18  *** satwo has joined #bitcoin-core-dev
232 2017-11-25T20:58:28  <sipa> i always use git fetch -a
233 2017-11-25T20:59:42  *** jamescowden has quit IRC
234 2017-11-25T21:02:34  <wxss> sipa, do you mean git fetch --all? Does that do the same as git remote update?
235 2017-11-25T21:03:55  *** promag has quit IRC
236 2017-11-25T21:04:43  <sipa> -a is the same as --all
237 2017-11-25T21:05:28  <wxss> git help fetch says -a is --append
238 2017-11-25T21:06:57  <sipa> heh!
239 2017-11-25T21:07:06  <sipa> you're right
240 2017-11-25T21:07:41  <sipa> git remote update seems to do the same
241 2017-11-25T21:08:56  <wxss> i can die happy now! yeah fetch --all and remote update seem to do the same afaict
242 2017-11-25T21:09:30  *** learnedh has joined #bitcoin-core-dev
243 2017-11-25T21:10:02  <sipa> apparently the difference is that remote update skips remotes that have a skipDefaultUpdate option set
244 2017-11-25T21:12:13  *** arubi has joined #bitcoin-core-dev
245 2017-11-25T21:16:35  <wxss> right, remote update is configurable with groups and skipDefault, where fetch --all isn't
246 2017-11-25T21:23:14  *** roadcrap has joined #bitcoin-core-dev
247 2017-11-25T21:24:23  *** Randolf has joined #bitcoin-core-dev
248 2017-11-25T21:26:37  *** jamescowden has joined #bitcoin-core-dev
249 2017-11-25T21:31:37  *** jamescowden has quit IRC
250 2017-11-25T21:50:44  *** wunpunch has joined #bitcoin-core-dev
251 2017-11-25T21:51:16  *** arubi has quit IRC
252 2017-11-25T21:52:38  *** arubi has joined #bitcoin-core-dev
253 2017-11-25T21:54:05  *** arubi has quit IRC
254 2017-11-25T21:55:35  *** arubi has joined #bitcoin-core-dev
255 2017-11-25T21:58:46  *** jamescowden has joined #bitcoin-core-dev
256 2017-11-25T22:03:50  *** jamescowden has quit IRC
257 2017-11-25T22:04:17  *** l3gion has joined #bitcoin-core-dev
258 2017-11-25T22:13:23  *** Guest21 has quit IRC
259 2017-11-25T22:22:25  *** str4d has quit IRC
260 2017-11-25T22:36:08  *** jamescowden has joined #bitcoin-core-dev
261 2017-11-25T22:40:33  *** jamescowden has quit IRC
262 2017-11-25T22:40:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
263 2017-11-25T22:42:38  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
264 2017-11-25T22:42:38  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
265 2017-11-25T22:54:21  *** wunpunch has quit IRC
266 2017-11-25T23:08:01  *** str4d has joined #bitcoin-core-dev
267 2017-11-25T23:08:35  <bitcoin-git> [bitcoin] fanquake closed pull request #11761: [WIP] [docs] initial QT documentation (master...qt-docs) https://github.com/bitcoin/bitcoin/pull/11761
268 2017-11-25T23:08:47  *** fanquake has joined #bitcoin-core-dev
269 2017-11-25T23:09:21  <fanquake> Apologies to anyone who's PRs I have closed inadvertently, keep hitting the close button after writing comments…
270 2017-11-25T23:10:02  <Randolf> fanquake++
271 2017-11-25T23:11:18  *** jamescowden has joined #bitcoin-core-dev
272 2017-11-25T23:14:25  *** btcdrak has quit IRC
273 2017-11-25T23:15:41  *** jamescowden has quit IRC
274 2017-11-25T23:26:09  *** intcat has quit IRC
275 2017-11-25T23:26:55  *** intcat has joined #bitcoin-core-dev
276 2017-11-25T23:34:42  *** Randolf has quit IRC