12017-11-25T00:11:35  *** go1111111 has quit IRC
  22017-11-25T00:11:48  *** go1111111 has joined #bitcoin-core-dev
  32017-11-25T00:11:55  *** go11111111111 has joined #bitcoin-core-dev
  42017-11-25T00:13:24  *** dqx_ has quit IRC
  52017-11-25T00:16:31  *** d_t has quit IRC
  62017-11-25T00:26:40  *** dqx_ has joined #bitcoin-core-dev
  72017-11-25T00:26:47  *** Khunbish has left #bitcoin-core-dev
  82017-11-25T00:29:56  *** dqx_ has quit IRC
  92017-11-25T00:36:37  *** Giszmo has joined #bitcoin-core-dev
 102017-11-25T00:39:12  *** Aaronvan_ has joined #bitcoin-core-dev
 112017-11-25T00:39:14  *** StopAndDecrypt has quit IRC
 122017-11-25T00:39:14  *** StopAndDecrypt has joined #bitcoin-core-dev
 132017-11-25T00:42:00  *** Aaronvan_ has quit IRC
 142017-11-25T00:42:09  *** AaronvanW has quit IRC
 152017-11-25T00:44:52  *** owowo has quit IRC
 162017-11-25T00:50:01  *** owowo has joined #bitcoin-core-dev
 172017-11-25T00:54:27  *** wxss has quit IRC
 182017-11-25T01:01:29  *** roadcrap has joined #bitcoin-core-dev
 192017-11-25T01:02:19  *** d_t has joined #bitcoin-core-dev
 202017-11-25T01:08:12  *** Randolf has quit IRC
 212017-11-25T01:10:09  *** Randolf has joined #bitcoin-core-dev
 222017-11-25T01:13:34  *** jtimon has joined #bitcoin-core-dev
 232017-11-25T01:19:54  *** alreadylate has joined #bitcoin-core-dev
 242017-11-25T01:24:57  *** d_t has quit IRC
 252017-11-25T01:44:31  *** Randolf has quit IRC
 262017-11-25T01:50:41  *** alreadylate has quit IRC
 272017-11-25T01:53:57  *** StopAndDecrypt_ has joined #bitcoin-core-dev
 282017-11-25T01:54:27  *** StopAndDecrypt has quit IRC
 292017-11-25T01:57:16  *** goatpig has quit IRC
 302017-11-25T01:57:54  *** vicenteH has quit IRC
 312017-11-25T01:58:10  *** vicenteH has joined #bitcoin-core-dev
 322017-11-25T02:02:25  *** Randolf has joined #bitcoin-core-dev
 332017-11-25T02:07:31  *** Randolf has quit IRC
 342017-11-25T02:23:01  *** Randolf has joined #bitcoin-core-dev
 352017-11-25T02:36:35  *** Ylbam has quit IRC
 362017-11-25T02:37:01  *** lifeofguenter has quit IRC
 372017-11-25T02:41:42  *** alreadylate has joined #bitcoin-core-dev
 382017-11-25T02:41:48  *** lifeofguenter has joined #bitcoin-core-dev
 392017-11-25T02:47:05  *** Randolf has quit IRC
 402017-11-25T02:59:54  *** cysm has quit IRC
 412017-11-25T03:06:13  *** Randolf has joined #bitcoin-core-dev
 422017-11-25T03:08:30  *** cysm has joined #bitcoin-core-dev
 432017-11-25T03:12:37  *** dqx_ has joined #bitcoin-core-dev
 442017-11-25T03:17:19  *** Randolf has quit IRC
 452017-11-25T03:25:35  *** dqx_ has quit IRC
 462017-11-25T03:33:57  *** Randolf has joined #bitcoin-core-dev
 472017-11-25T03:35:51  *** alreadylate has quit IRC
 482017-11-25T03:53:07  *** dqx_ has joined #bitcoin-core-dev
 492017-11-25T03:54:18  *** dqx has joined #bitcoin-core-dev
 502017-11-25T03:57:12  *** dqx_ has quit IRC
 512017-11-25T04:18:14  *** Randolf has quit IRC
 522017-11-25T04:21:23  *** pugsh has quit IRC
 532017-11-25T04:29:15  *** Randolf has joined #bitcoin-core-dev
 542017-11-25T04:40:19  *** digifis has joined #bitcoin-core-dev
 552017-11-25T04:43:02  *** Randolf has quit IRC
 562017-11-25T04:43:02  *** sin_ has quit IRC
 572017-11-25T04:53:07  *** Randolf has joined #bitcoin-core-dev
 582017-11-25T05:13:47  *** musalbas has quit IRC
 592017-11-25T05:29:11  *** d9b4bef9 has quit IRC
 602017-11-25T05:30:40  *** d9b4bef9 has joined #bitcoin-core-dev
 612017-11-25T05:46:23  *** quantbot has quit IRC
 622017-11-25T05:46:58  *** quantbot has joined #bitcoin-core-dev
 632017-11-25T05:51:29  *** quantbot has quit IRC
 642017-11-25T06:19:19  *** unholymachine has joined #bitcoin-core-dev
 652017-11-25T06:45:22  *** Evel-Knievel has quit IRC
 662017-11-25T06:57:13  *** Evel-Knievel has joined #bitcoin-core-dev
 672017-11-25T07:03:43  *** Sun has joined #bitcoin-core-dev
 682017-11-25T07:04:05  *** Sun is now known as Guest16480
 692017-11-25T07:07:39  *** justan0theruser has quit IRC
 702017-11-25T07:21:49  *** justan0theruser has joined #bitcoin-core-dev
 712017-11-25T07:25:00  *** Guest16480 has quit IRC
 722017-11-25T07:42:24  *** SopaXorzTaker has joined #bitcoin-core-dev
 732017-11-25T07:56:09  *** satwo has quit IRC
 742017-11-25T07:59:03  *** qrestlove has quit IRC
 752017-11-25T08:01:32  <bitcoin-git> [bitcoin] aaron-hanson opened pull request #11765: [REST] added blockhash api, tests and documentation (master...rest-blockhash-endpoint) https://github.com/bitcoin/bitcoin/pull/11765
 762017-11-25T08:02:14  *** Emcy_ has joined #bitcoin-core-dev
 772017-11-25T08:03:05  *** Emcy has quit IRC
 782017-11-25T08:04:07  *** quantbot has joined #bitcoin-core-dev
 792017-11-25T08:04:23  *** qrestlove has joined #bitcoin-core-dev
 802017-11-25T08:08:57  *** quantbot has quit IRC
 812017-11-25T08:31:33  *** AaronvanW has joined #bitcoin-core-dev
 822017-11-25T08:33:47  *** Aaronvan_ has joined #bitcoin-core-dev
 832017-11-25T08:37:21  *** AaronvanW has quit IRC
 842017-11-25T08:39:25  *** Aaronvan_ has quit IRC
 852017-11-25T09:06:52  *** qrestlove has quit IRC
 862017-11-25T09:13:46  *** Ylbam has joined #bitcoin-core-dev
 872017-11-25T09:18:45  *** qrestlove has joined #bitcoin-core-dev
 882017-11-25T09:36:39  *** StopAndDecrypt has joined #bitcoin-core-dev
 892017-11-25T09:36:39  *** StopAndDecrypt has quit IRC
 902017-11-25T09:36:39  *** StopAndDecrypt has joined #bitcoin-core-dev
 912017-11-25T09:37:03  *** StopAndDecrypt_ has quit IRC
 922017-11-25T10:14:07  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 932017-11-25T10:38:43  *** meshcollider has joined #bitcoin-core-dev
 942017-11-25T10:51:55  *** arubi has quit IRC
 952017-11-25T10:52:19  *** promag has joined #bitcoin-core-dev
 962017-11-25T10:52:54  *** arubi has joined #bitcoin-core-dev
 972017-11-25T10:59:29  *** goatpig has joined #bitcoin-core-dev
 982017-11-25T11:16:51  *** kiranymous has joined #bitcoin-core-dev
 992017-11-25T11:19:32  *** kiranymous has quit IRC
1002017-11-25T11:19:57  *** kiranymous has joined #bitcoin-core-dev
1012017-11-25T11:21:28  *** promag has quit IRC
1022017-11-25T11:23:56  *** jamescowden has joined #bitcoin-core-dev
1032017-11-25T11:36:13  *** promag has joined #bitcoin-core-dev
1042017-11-25T11:45:49  *** kiranymous has quit IRC
1052017-11-25T11:48:22  *** promag has quit IRC
1062017-11-25T11:52:35  *** alreadylate has joined #bitcoin-core-dev
1072017-11-25T11:53:24  *** justan0theruser has quit IRC
1082017-11-25T12:07:39  *** user_____ has joined #bitcoin-core-dev
1092017-11-25T12:07:45  *** justan0theruser has joined #bitcoin-core-dev
1102017-11-25T12:08:40  *** jamescowden has quit IRC
1112017-11-25T12:11:51  *** user_____ has quit IRC
1122017-11-25T12:12:44  *** qube_ has joined #bitcoin-core-dev
1132017-11-25T12:15:51  *** wxss has joined #bitcoin-core-dev
1142017-11-25T12:20:36  *** qube_ has quit IRC
1152017-11-25T12:22:04  *** quantbot has joined #bitcoin-core-dev
1162017-11-25T12:26:27  *** quantbot has quit IRC
1172017-11-25T12:29:31  *** quantbot has joined #bitcoin-core-dev
1182017-11-25T12:33:32  *** satwo has joined #bitcoin-core-dev
1192017-11-25T12:39:37  *** SopaXorzTaker has quit IRC
1202017-11-25T12:40:21  *** SopaXorzTaker has joined #bitcoin-core-dev
1212017-11-25T12:41:38  *** promag has joined #bitcoin-core-dev
1222017-11-25T13:02:08  *** jamescowden has joined #bitcoin-core-dev
1232017-11-25T13:04:20  *** promag has quit IRC
1242017-11-25T13:21:51  *** Khunbish has joined #bitcoin-core-dev
1252017-11-25T13:24:00  *** promag has joined #bitcoin-core-dev
1262017-11-25T13:25:30  *** arubi has quit IRC
1272017-11-25T13:25:53  *** arubi has joined #bitcoin-core-dev
1282017-11-25T13:28:56  *** promag has quit IRC
1292017-11-25T13:31:28  *** jamescowden has quit IRC
1302017-11-25T13:32:00  *** jamescowden has joined #bitcoin-core-dev
1312017-11-25T13:34:46  *** jamescowden has quit IRC
1322017-11-25T13:34:59  *** jamescowden has joined #bitcoin-core-dev
1332017-11-25T13:36:22  *** jamescowden has joined #bitcoin-core-dev
1342017-11-25T13:38:50  *** Guyver2 has joined #bitcoin-core-dev
1352017-11-25T13:41:05  *** jamescowden has quit IRC
1362017-11-25T13:46:44  *** str4d has joined #bitcoin-core-dev
1372017-11-25T13:51:41  *** promag has joined #bitcoin-core-dev
1382017-11-25T13:54:48  *** jamescowden has joined #bitcoin-core-dev
1392017-11-25T13:58:21  *** promag has quit IRC
1402017-11-25T14:15:48  *** shesek has quit IRC
1412017-11-25T14:26:13  *** jamescowden has quit IRC
1422017-11-25T14:28:27  *** meshcollider has quit IRC
1432017-11-25T14:33:29  *** shesek has joined #bitcoin-core-dev
1442017-11-25T14:33:30  *** shesek has joined #bitcoin-core-dev
1452017-11-25T14:56:14  *** jb55 has joined #bitcoin-core-dev
1462017-11-25T14:56:44  *** jamescowden has joined #bitcoin-core-dev
1472017-11-25T14:59:06  *** promag has joined #bitcoin-core-dev
1482017-11-25T15:03:29  *** jamescowden has quit IRC
1492017-11-25T15:36:53  *** jamescowden has joined #bitcoin-core-dev
1502017-11-25T15:38:33  *** alreadylate has quit IRC
1512017-11-25T15:42:12  *** jamescowden has quit IRC
1522017-11-25T15:49:13  *** jamescowden has joined #bitcoin-core-dev
1532017-11-25T15:49:28  *** jb55 has quit IRC
1542017-11-25T15:53:41  *** jamescowden has quit IRC
1552017-11-25T15:56:48  *** StopAndDecrypt has quit IRC
1562017-11-25T16:00:38  *** jb55 has joined #bitcoin-core-dev
1572017-11-25T16:06:58  *** StopAndDecrypt has joined #bitcoin-core-dev
1582017-11-25T16:17:12  *** rhakhsa has joined #bitcoin-core-dev
1592017-11-25T16:30:28  *** bitstein has joined #bitcoin-core-dev
1602017-11-25T16:41:23  *** bitstein has quit IRC
1612017-11-25T16:45:12  *** roadcrap has quit IRC
1622017-11-25T16:54:20  *** jamescowden has joined #bitcoin-core-dev
1632017-11-25T16:58:35  *** jamescowden has quit IRC
1642017-11-25T17:11:42  *** musalbas has joined #bitcoin-core-dev
1652017-11-25T17:19:15  *** THoVer has joined #bitcoin-core-dev
1662017-11-25T17:21:58  *** THoVer has quit IRC
1672017-11-25T17:21:58  *** jb55 has quit IRC
1682017-11-25T17:23:00  *** Cogito_Ergo_Sum has quit IRC
1692017-11-25T17:24:23  *** jamescowden has joined #bitcoin-core-dev
1702017-11-25T17:28:55  *** jamescowden has quit IRC
1712017-11-25T17:35:09  *** jb55 has joined #bitcoin-core-dev
1722017-11-25T17:43:27  *** jb55 has quit IRC
1732017-11-25T17:54:16  *** jamescowden has joined #bitcoin-core-dev
1742017-11-25T17:58:41  *** jamescowden has quit IRC
1752017-11-25T18:00:34  *** promag has quit IRC
1762017-11-25T18:00:45  *** promag has joined #bitcoin-core-dev
1772017-11-25T18:05:26  *** promag has quit IRC
1782017-11-25T18:29:50  *** janoside has joined #bitcoin-core-dev
1792017-11-25T18:30:00  *** jamescowden has joined #bitcoin-core-dev
1802017-11-25T18:32:08  *** janoside has quit IRC
1812017-11-25T18:34:39  *** jamescowden has quit IRC
1822017-11-25T18:39:52  *** promag has joined #bitcoin-core-dev
1832017-11-25T18:54:23  *** jamescowden has joined #bitcoin-core-dev
1842017-11-25T18:59:13  *** jamescowden has quit IRC
1852017-11-25T19:08:41  *** jamescowden has joined #bitcoin-core-dev
1862017-11-25T19:13:38  *** jamescowden has quit IRC
1872017-11-25T19:27:57  *** Randolf has quit IRC
1882017-11-25T19:30:37  *** SopaXorzTaker has quit IRC
1892017-11-25T19:44:46  *** jamescowden has joined #bitcoin-core-dev
1902017-11-25T19:45:18  *** promag has quit IRC
1912017-11-25T19:46:13  <Lauda> I did [insertUselessPapers]
1922017-11-25T19:46:15  <Lauda> oops
1932017-11-25T19:49:19  *** jamescowden has quit IRC
1942017-11-25T20:10:39  *** owowo has quit IRC
1952017-11-25T20:13:20  *** Guyver2 has quit IRC
1962017-11-25T20:16:01  *** owowo has joined #bitcoin-core-dev
1972017-11-25T20:16:43  *** jamescowden has joined #bitcoin-core-dev
1982017-11-25T20:21:32  *** jamescowden has quit IRC
1992017-11-25T20:26:01  *** riemann has joined #bitcoin-core-dev
2002017-11-25T20:34:43  *** btcdrak has joined #bitcoin-core-dev
2012017-11-25T20:36:18  *** promag has joined #bitcoin-core-dev
2022017-11-25T20:36:37  *** meshcollider has joined #bitcoin-core-dev
2032017-11-25T20:41:09  *** arubi has quit IRC
2042017-11-25T20:41:55  <archaeal> when adding commits to an open pull request, is the convention to squash them and force push, or keep them separate?  I noticed the contributing readme mentions squashing before a merge to master, but I'm wondering about before that?
2052017-11-25T20:43:31  <promag> archaeal: usually it depends
2062017-11-25T20:43:46  <promag> if you already have reviews, maybe push a new commit
2072017-11-25T20:44:13  <archaeal> makes sense...  thanks!
2082017-11-25T20:44:27  <promag> also, see git commit --fixup
2092017-11-25T20:45:03  <promag> it helps later when squashing if your PR has multiple commits and multiple fixups
2102017-11-25T20:45:52  <promag> usually I do git remote update origin && git rebase  with origin/master when squashing
2112017-11-25T20:46:11  <promag> git rebase -i --autosquash origin/master
2122017-11-25T20:46:21  <archaeal> yeah i generally use fixup when squashing
2132017-11-25T20:46:42  <sipa> also, even if you squash, avoid rebasing until necessary
2142017-11-25T20:47:15  <archaeal> ok thanks
2152017-11-25T20:47:16  <sipa> it helps review if people can look at the diff between your new pr overall and the old version, without it being cluttered with changes from master
2162017-11-25T20:47:24  <archaeal> ah yes
2172017-11-25T20:47:40  <sipa> for simple PRs i generally don't care about squashing liberally
2182017-11-25T20:48:39  <promag> sipa: how do you diff with old version?
2192017-11-25T20:48:58  <sipa> git diff <commit> <commit>
2202017-11-25T20:49:51  <promag> how do you know the 1st commit?
2212017-11-25T20:50:41  <promag> especially in the case I push -f
2222017-11-25T20:51:33  <meshcollider> promag: you have to have checked out the branch locally first I think?
2232017-11-25T20:51:43  <sipa> promag: it's the one you acked before
2242017-11-25T20:52:48  <meshcollider> GitHub doesn't store commits which were overwritten with -f does it
2252017-11-25T20:53:38  <sipa> not for long, but you can easily pull them locally
2262017-11-25T20:53:54  <sipa> by adding the pulls branch to your remote
2272017-11-25T20:54:05  *** satwo has quit IRC
2282017-11-25T20:54:09  <sipa> that way you always have all commits locally from all prs
2292017-11-25T20:54:21  *** jamescowden has joined #bitcoin-core-dev
2302017-11-25T20:55:11  <promag> but I have to remote update all remotes right?
2312017-11-25T20:57:18  *** satwo has joined #bitcoin-core-dev
2322017-11-25T20:58:28  <sipa> i always use git fetch -a
2332017-11-25T20:59:42  *** jamescowden has quit IRC
2342017-11-25T21:02:34  <wxss> sipa, do you mean git fetch --all? Does that do the same as git remote update?
2352017-11-25T21:03:55  *** promag has quit IRC
2362017-11-25T21:04:43  <sipa> -a is the same as --all
2372017-11-25T21:05:28  <wxss> git help fetch says -a is --append
2382017-11-25T21:06:57  <sipa> heh!
2392017-11-25T21:07:06  <sipa> you're right
2402017-11-25T21:07:41  <sipa> git remote update seems to do the same
2412017-11-25T21:08:56  <wxss> i can die happy now! yeah fetch --all and remote update seem to do the same afaict
2422017-11-25T21:09:30  *** learnedh has joined #bitcoin-core-dev
2432017-11-25T21:10:02  <sipa> apparently the difference is that remote update skips remotes that have a skipDefaultUpdate option set
2442017-11-25T21:12:13  *** arubi has joined #bitcoin-core-dev
2452017-11-25T21:16:35  <wxss> right, remote update is configurable with groups and skipDefault, where fetch --all isn't
2462017-11-25T21:23:14  *** roadcrap has joined #bitcoin-core-dev
2472017-11-25T21:24:23  *** Randolf has joined #bitcoin-core-dev
2482017-11-25T21:26:37  *** jamescowden has joined #bitcoin-core-dev
2492017-11-25T21:31:37  *** jamescowden has quit IRC
2502017-11-25T21:50:44  *** wunpunch has joined #bitcoin-core-dev
2512017-11-25T21:51:16  *** arubi has quit IRC
2522017-11-25T21:52:38  *** arubi has joined #bitcoin-core-dev
2532017-11-25T21:54:05  *** arubi has quit IRC
2542017-11-25T21:55:35  *** arubi has joined #bitcoin-core-dev
2552017-11-25T21:58:46  *** jamescowden has joined #bitcoin-core-dev
2562017-11-25T22:03:50  *** jamescowden has quit IRC
2572017-11-25T22:04:17  *** l3gion has joined #bitcoin-core-dev
2582017-11-25T22:13:23  *** Guest21 has quit IRC
2592017-11-25T22:22:25  *** str4d has quit IRC
2602017-11-25T22:36:08  *** jamescowden has joined #bitcoin-core-dev
2612017-11-25T22:40:33  *** jamescowden has quit IRC
2622017-11-25T22:40:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2632017-11-25T22:42:38  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2642017-11-25T22:42:38  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2652017-11-25T22:54:21  *** wunpunch has quit IRC
2662017-11-25T23:08:01  *** str4d has joined #bitcoin-core-dev
2672017-11-25T23:08:35  <bitcoin-git> [bitcoin] fanquake closed pull request #11761: [WIP] [docs] initial QT documentation (master...qt-docs) https://github.com/bitcoin/bitcoin/pull/11761
2682017-11-25T23:08:47  *** fanquake has joined #bitcoin-core-dev
2692017-11-25T23:09:21  <fanquake> Apologies to anyone who's PRs I have closed inadvertently, keep hitting the close button after writing comments…
2702017-11-25T23:10:02  <Randolf> fanquake++
2712017-11-25T23:11:18  *** jamescowden has joined #bitcoin-core-dev
2722017-11-25T23:14:25  *** btcdrak has quit IRC
2732017-11-25T23:15:41  *** jamescowden has quit IRC
2742017-11-25T23:26:09  *** intcat has quit IRC
2752017-11-25T23:26:55  *** intcat has joined #bitcoin-core-dev
2762017-11-25T23:34:42  *** Randolf has quit IRC