12017-12-22T00:04:54  *** talha_ has quit IRC
  22017-12-22T00:14:35  *** intcat has quit IRC
  32017-12-22T00:16:12  *** intcat has joined #bitcoin-core-dev
  42017-12-22T00:27:25  *** Randolf has joined #bitcoin-core-dev
  52017-12-22T00:31:42  *** intcat has quit IRC
  62017-12-22T00:32:57  *** intcat has joined #bitcoin-core-dev
  72017-12-22T00:41:49  *** cornben has joined #bitcoin-core-dev
  82017-12-22T00:43:16  *** jb55 has joined #bitcoin-core-dev
  92017-12-22T00:54:38  *** jb55 has quit IRC
 102017-12-22T01:00:41  *** AaronvanW has quit IRC
 112017-12-22T01:02:45  *** dabura667 has joined #bitcoin-core-dev
 122017-12-22T01:08:09  *** hytf has joined #bitcoin-core-dev
 132017-12-22T01:12:33  *** hytf has quit IRC
 142017-12-22T01:13:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 152017-12-22T01:15:43  *** intcat has quit IRC
 162017-12-22T01:16:54  *** intcat has joined #bitcoin-core-dev
 172017-12-22T01:27:39  *** intcat has quit IRC
 182017-12-22T01:29:04  *** intcat has joined #bitcoin-core-dev
 192017-12-22T01:35:20  *** fanquake has joined #bitcoin-core-dev
 202017-12-22T01:35:28  *** Moe has joined #bitcoin-core-dev
 212017-12-22T01:35:59  <fanquake> Can someone add zeromq 4.2.2 & 4.2.3 to /depends-sources on bitcoincore.org
 222017-12-22T01:42:58  *** Ylbam has quit IRC
 232017-12-22T01:45:19  *** Victor_sueca has quit IRC
 242017-12-22T01:46:32  *** Victor_sueca has joined #bitcoin-core-dev
 252017-12-22T01:48:27  *** Kozuch has quit IRC
 262017-12-22T01:49:25  *** Murch has quit IRC
 272017-12-22T01:50:21  *** larafale has quit IRC
 282017-12-22T01:55:37  *** Moe has quit IRC
 292017-12-22T02:00:52  *** belcher has quit IRC
 302017-12-22T02:04:17  *** Giszmo has quit IRC
 312017-12-22T02:09:26  *** Chris_Stewart_5 has quit IRC
 322017-12-22T02:15:53  *** Giszmo has joined #bitcoin-core-dev
 332017-12-22T02:19:17  *** adafdgfdvdsfew has joined #bitcoin-core-dev
 342017-12-22T02:24:38  *** intcat has quit IRC
 352017-12-22T02:25:31  *** np has joined #bitcoin-core-dev
 362017-12-22T02:26:27  *** intcat has joined #bitcoin-core-dev
 372017-12-22T02:28:13  *** np has quit IRC
 382017-12-22T02:38:24  *** cornben1 has joined #bitcoin-core-dev
 392017-12-22T02:38:25  *** cornben1 has quit IRC
 402017-12-22T02:40:35  *** intcat has quit IRC
 412017-12-22T02:40:38  *** Emcy_ has joined #bitcoin-core-dev
 422017-12-22T02:41:37  *** cornben has quit IRC
 432017-12-22T02:41:45  *** intcat has joined #bitcoin-core-dev
 442017-12-22T02:43:11  *** Emcy has quit IRC
 452017-12-22T02:47:35  *** adafdgfdvdsfew has quit IRC
 462017-12-22T02:50:24  *** cornben has joined #bitcoin-core-dev
 472017-12-22T02:50:30  *** valentinewallace has quit IRC
 482017-12-22T02:58:38  *** cornben1 has joined #bitcoin-core-dev
 492017-12-22T02:58:40  *** cornben1 has quit IRC
 502017-12-22T03:00:02  *** TheRec has joined #bitcoin-core-dev
 512017-12-22T03:00:35  *** Randolf has quit IRC
 522017-12-22T03:01:05  *** cornben has quit IRC
 532017-12-22T03:04:42  *** intcat has quit IRC
 542017-12-22T03:05:16  *** billbrofaggins has joined #bitcoin-core-dev
 552017-12-22T03:05:56  *** intcat has joined #bitcoin-core-dev
 562017-12-22T03:08:41  *** intcat has quit IRC
 572017-12-22T03:09:54  *** intcat has joined #bitcoin-core-dev
 582017-12-22T03:10:31  *** intcat has quit IRC
 592017-12-22T03:10:42  *** cornben has joined #bitcoin-core-dev
 602017-12-22T03:10:43  *** cornben has quit IRC
 612017-12-22T03:11:20  *** billbrofaggins has left #bitcoin-core-dev
 622017-12-22T03:11:38  *** intcat has joined #bitcoin-core-dev
 632017-12-22T03:18:42  *** cornben has joined #bitcoin-core-dev
 642017-12-22T03:18:43  *** cornben has quit IRC
 652017-12-22T03:26:46  *** cornben has joined #bitcoin-core-dev
 662017-12-22T03:26:48  *** cornben has quit IRC
 672017-12-22T03:27:17  *** cornben has joined #bitcoin-core-dev
 682017-12-22T03:29:55  *** Randolf has joined #bitcoin-core-dev
 692017-12-22T03:31:27  *** Emcy has joined #bitcoin-core-dev
 702017-12-22T03:31:32  *** gauravgoyal has joined #bitcoin-core-dev
 712017-12-22T03:33:21  *** Emcy_ has quit IRC
 722017-12-22T03:33:21  *** booyah is now known as booyah_
 732017-12-22T03:37:07  *** booyah_ is now known as booyah
 742017-12-22T03:37:48  *** mandric has joined #bitcoin-core-dev
 752017-12-22T03:39:15  *** cornben has joined #bitcoin-core-dev
 762017-12-22T03:53:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 772017-12-22T03:54:13  *** gauravgoyal has quit IRC
 782017-12-22T04:03:09  *** mandric has quit IRC
 792017-12-22T04:05:50  *** kmkmkmkm has joined #bitcoin-core-dev
 802017-12-22T04:07:05  *** kmkmkmkm has quit IRC
 812017-12-22T04:18:08  *** Chris_Stewart_5 has quit IRC
 822017-12-22T04:19:12  *** intcat has quit IRC
 832017-12-22T04:19:40  *** Syde has joined #bitcoin-core-dev
 842017-12-22T04:20:03  *** intcat has joined #bitcoin-core-dev
 852017-12-22T04:22:56  *** fanquake has quit IRC
 862017-12-22T04:23:42  *** intcat has quit IRC
 872017-12-22T04:24:57  *** intcat has joined #bitcoin-core-dev
 882017-12-22T04:31:57  *** intcat has quit IRC
 892017-12-22T04:33:16  *** intcat has joined #bitcoin-core-dev
 902017-12-22T04:44:46  *** intx has joined #bitcoin-core-dev
 912017-12-22T04:46:43  *** spence has joined #bitcoin-core-dev
 922017-12-22T04:49:04  <spence> I have a noob-ish question.  How does the code determine the buffer size when reading the blocks, like in reindexing?  I'm playing around with adding my own custom data structure to blocks, and I'm getting an ioerror "read attempted past buffer limit".
 932017-12-22T04:59:16  <sipa> ?
 942017-12-22T05:05:56  <spence> sipa is that in response to me?
 952017-12-22T05:10:43  *** intcat has quit IRC
 962017-12-22T05:11:53  *** intcat has joined #bitcoin-core-dev
 972017-12-22T05:12:20  *** phantomcircuit has left #bitcoin-core-dev
 982017-12-22T05:12:38  *** phantomcircuit has joined #bitcoin-core-dev
 992017-12-22T05:15:34  *** cornben1 has joined #bitcoin-core-dev
1002017-12-22T05:18:21  *** cornben has quit IRC
1012017-12-22T05:23:35  *** spence has quit IRC
1022017-12-22T05:23:39  *** intcat has quit IRC
1032017-12-22T05:24:56  *** intcat has joined #bitcoin-core-dev
1042017-12-22T05:25:53  <meshcollider> spence: I would imagine so :) adding custom data structure to blocks sounds like ##altcoin-dev rather than this channel I think?
1052017-12-22T05:27:02  <Varunram> meshcollider: he quit :/
1062017-12-22T05:27:14  <meshcollider> Heh oh well
1072017-12-22T05:43:49  *** murr4y has quit IRC
1082017-12-22T05:46:08  *** gauravgoyal has joined #bitcoin-core-dev
1092017-12-22T05:47:28  *** gauravgoyal has quit IRC
1102017-12-22T05:49:45  *** gauravgoyal has joined #bitcoin-core-dev
1112017-12-22T05:52:31  *** Syde has quit IRC
1122017-12-22T06:07:06  *** Bosma has joined #bitcoin-core-dev
1132017-12-22T06:25:21  *** intcat has quit IRC
1142017-12-22T06:25:58  *** Giszmo has quit IRC
1152017-12-22T06:26:12  *** mrannanay has joined #bitcoin-core-dev
1162017-12-22T06:26:32  *** intcat has joined #bitcoin-core-dev
1172017-12-22T06:30:48  *** intcat has quit IRC
1182017-12-22T06:32:03  *** intcat has joined #bitcoin-core-dev
1192017-12-22T06:34:10  *** cornben has joined #bitcoin-core-dev
1202017-12-22T06:35:43  *** cornben1 has quit IRC
1212017-12-22T06:37:41  *** youngentrepreneu has joined #bitcoin-core-dev
1222017-12-22T06:53:53  *** gauravgoyal has quit IRC
1232017-12-22T07:00:44  *** viru has joined #bitcoin-core-dev
1242017-12-22T07:00:53  <viru> hi
1252017-12-22T07:01:14  *** viru has quit IRC
1262017-12-22T07:01:59  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1272017-12-22T07:01:59  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1282017-12-22T07:05:23  *** Ylbam has joined #bitcoin-core-dev
1292017-12-22T07:06:44  *** intcat has quit IRC
1302017-12-22T07:07:56  *** intcat has joined #bitcoin-core-dev
1312017-12-22T07:12:59  *** wvr- has joined #bitcoin-core-dev
1322017-12-22T07:13:01  *** wvr has quit IRC
1332017-12-22T07:13:43  *** intcat has quit IRC
1342017-12-22T07:14:41  *** intcat has joined #bitcoin-core-dev
1352017-12-22T07:15:22  <meshcollider> viru: hi
1362017-12-22T07:19:40  *** Victor_sueca has quit IRC
1372017-12-22T07:21:03  *** Victor_sueca has joined #bitcoin-core-dev
1382017-12-22T07:27:52  *** dabura667 has quit IRC
1392017-12-22T07:28:55  *** dabura667 has joined #bitcoin-core-dev
1402017-12-22T07:56:55  <echeveria> wish list: getmempoolinfo should show the size of the extra transactions pool.
1412017-12-22T08:00:44  <wumpus> what is the 'extra transaction pool'?
1422017-12-22T08:01:35  <echeveria> the compact blocks rejected transaction cache.
1432017-12-22T08:06:24  <wumpus> oh that, yes was confused with the mempool relationship, but sure you could add the size of that structure on some RPC
1442017-12-22T08:06:27  <gmaxwell> echeveria: patches welcome, that would be a oneline change.
1452017-12-22T08:09:41  *** intcat has quit IRC
1462017-12-22T08:10:34  <wumpus> maybe three lines; would need to add a function to net_processing.cpp to query it from outside, too. But yeah definitely a good first PR.
1472017-12-22T08:10:46  *** intcat has joined #bitcoin-core-dev
1482017-12-22T08:23:14  <wumpus> zelest: great to hear that the second try worked :)
1492017-12-22T08:23:43  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/711d16ca4a91...180a25596a29
1502017-12-22T08:23:43  <bitcoin-git> bitcoin/master a6365c5 Cory Fields: depends: fix libzmq's needless linking against libstdc++...
1512017-12-22T08:23:44  <bitcoin-git> bitcoin/master 180a255 Wladimir J. van der Laan: Merge #11981: Fix gitian build after libzmq bump...
1522017-12-22T08:24:28  <bitcoin-git> [bitcoin] laanwj closed pull request #11981: Fix gitian build after libzmq bump (master...fix-gitian-build) https://github.com/bitcoin/bitcoin/pull/11981
1532017-12-22T08:29:39  *** intcat has quit IRC
1542017-12-22T08:30:53  *** intcat has joined #bitcoin-core-dev
1552017-12-22T08:33:59  *** ren0v0 has joined #bitcoin-core-dev
1562017-12-22T08:35:17  <zelest> wumpus, now it failed on Qt though.. :P
1572017-12-22T08:35:41  <zelest> wumpus, but I get the same errors from electrum when I start it.. I think it's related to how X is compiled :/
1582017-12-22T08:35:54  <wumpus> I don't think anyone ever got the GUI to work on openbsd
1592017-12-22T08:36:25  <wumpus> personally I've never used it with a graphical environment of any kind at all, just as server, so I don't know
1602017-12-22T08:36:38  <wumpus> (openbsd, that is.)
1612017-12-22T08:37:18  <wumpus> but please let us know (and add instructions to the openbsd build guide) if you do get it to work
1622017-12-22T08:37:29  <zelest> I'll do my best :)
1632017-12-22T08:37:38  <zelest> I use it as my primary OS since 1.5 year back so
1642017-12-22T08:38:09  <wumpus> I still use linux for that
1652017-12-22T08:39:06  <zelest> :)
1662017-12-22T08:40:12  <Lauda> wumpus kick in #11976, stupidly missed 1 link
1672017-12-22T08:40:13  <gribble> https://github.com/bitcoin/bitcoin/issues/11976 | [Doc] Fix link to installation script by laudaa · Pull Request #11976 · bitcoin/bitcoin · GitHub
1682017-12-22T08:41:05  <zelest> Lauda, i should've reported that myself :D
1692017-12-22T08:41:26  <Lauda> If you do find more errors in the docs, please do
1702017-12-22T08:41:32  <Lauda> this was broken for about a month I think :x
1712017-12-22T08:41:49  <zelest> as wumpus said, not many people use openbsd as their desktop OS :)
1722017-12-22T08:42:08  <zelest> also, this build fail is OpenBSD related..
1732017-12-22T08:42:18  <Lauda> True, but when I found the error I was checking other files for broken links
1742017-12-22T08:43:06  <zelest> https://pastebin.com/Drxb6mY4 :)
1752017-12-22T08:43:11  <zelest> Lauda, yeah :)
1762017-12-22T08:43:37  <luke-jr> will zelest become our new OpenBSD support dev? :P
1772017-12-22T08:43:55  <Lauda> uh oh, that would be nice
1782017-12-22T08:44:09  <zelest> Haha, if I only knew enough about coding :P
1792017-12-22T08:44:40  <zelest> However, I'll do my best :) OpenBSD does have some nice malloc features.. which basically make it a rather unpleasant OS for poorly written software..
1802017-12-22T08:44:48  <zelest> So it's nice to find bugs with :)
1812017-12-22T08:46:10  *** goatpig has quit IRC
1822017-12-22T08:47:28  <bitcoin-git> [bitcoin] laanwj opened pull request #11984: doc: Update OpenBSD build instructions for 6.2 (master...2017_12_openbsd_build_update) https://github.com/bitcoin/bitcoin/pull/11984
1832017-12-22T08:48:32  *** timothy has joined #bitcoin-core-dev
1842017-12-22T08:48:54  <bitcoin-git> [bitcoin] laanwj closed pull request #11976: [Doc] Fix link to installation script (master...master) https://github.com/bitcoin/bitcoin/pull/11976
1852017-12-22T08:53:05  *** fanquake has joined #bitcoin-core-dev
1862017-12-22T09:00:38  *** mark_otaris has joined #bitcoin-core-dev
1872017-12-22T09:04:49  *** laurentmt has joined #bitcoin-core-dev
1882017-12-22T09:23:26  *** Victor_sueca has quit IRC
1892017-12-22T09:24:42  *** Victor_sueca has joined #bitcoin-core-dev
1902017-12-22T09:24:47  *** intcat has quit IRC
1912017-12-22T09:25:02  *** puff has quit IRC
1922017-12-22T09:25:59  *** intcat has joined #bitcoin-core-dev
1932017-12-22T09:28:04  *** puff has joined #bitcoin-core-dev
1942017-12-22T09:36:49  *** fanquake has quit IRC
1952017-12-22T09:38:44  *** vicenteH has joined #bitcoin-core-dev
1962017-12-22T09:46:15  *** Ylbam has quit IRC
1972017-12-22T09:47:49  <bitcoin-git> [bitcoin] fanquake opened pull request #11986: [depends] zeromq 4.2.3 (master...zeromq-4-2-3) https://github.com/bitcoin/bitcoin/pull/11986
1982017-12-22T09:47:53  <zelest> aha! success!
1992017-12-22T09:48:04  * zelest will add some updates to the OpenBSD build guide :D
2002017-12-22T09:56:42  *** intcat has quit IRC
2012017-12-22T09:56:56  <jonasschnelli> zelest: thanks
2022017-12-22T09:57:41  *** intcat has joined #bitcoin-core-dev
2032017-12-22T09:59:21  <wumpus> zelest: please base it on https://github.com/bitcoin/bitcoin/pull/11984, so we can do the changes in one go
2042017-12-22T09:59:23  <zelest> just need to read up on the routines and such regarding forking and creating pull requests.. sadly at work atm as well :)
2052017-12-22T09:59:33  <zelest> ahh
2062017-12-22T10:00:05  <wumpus> you can also just comment on the review then I'll update the document
2072017-12-22T10:00:40  <zelest> I will setup a VM with a fresh install and verify all steps though
2082017-12-22T10:00:52  <zelest> as there's a few more packages that needs in (if one wish to run GUI)
2092017-12-22T10:03:13  *** rubensayshi has joined #bitcoin-core-dev
2102017-12-22T10:03:36  <wumpus> GUI is not currently part of the description at all, would add that in a separate section at least
2112017-12-22T10:05:28  <zelest> yeah
2122017-12-22T10:11:51  *** AaronvanW has joined #bitcoin-core-dev
2132017-12-22T10:14:41  *** intcat has quit IRC
2142017-12-22T10:15:19  *** Kozuch has joined #bitcoin-core-dev
2152017-12-22T10:16:53  *** intcat has joined #bitcoin-core-dev
2162017-12-22T10:17:37  <bitcoin-git> [bitcoin] janstary opened pull request #11987: Tweak the OSX build instructions (master...macos) https://github.com/bitcoin/bitcoin/pull/11987
2172017-12-22T10:35:31  *** lnostdal has joined #bitcoin-core-dev
2182017-12-22T10:47:22  *** dabura667 has quit IRC
2192017-12-22T11:08:51  *** wxss has quit IRC
2202017-12-22T11:09:27  *** Victor_sueca has quit IRC
2212017-12-22T11:10:41  *** Victor_sueca has joined #bitcoin-core-dev
2222017-12-22T11:15:52  *** wxss has joined #bitcoin-core-dev
2232017-12-22T11:19:11  *** Emcy_ has joined #bitcoin-core-dev
2242017-12-22T11:21:57  *** Emcy has quit IRC
2252017-12-22T11:26:10  <bitcoin-git> [bitcoin] AkioNak opened pull request #11988: Reduce redundant code of prevector and speed it up (master...prevector) https://github.com/bitcoin/bitcoin/pull/11988
2262017-12-22T11:35:48  *** SopaXorzTaker has joined #bitcoin-core-dev
2272017-12-22T11:39:22  *** Giovanny35Wunsch has joined #bitcoin-core-dev
2282017-12-22T11:39:58  *** locus_ has joined #bitcoin-core-dev
2292017-12-22T11:40:37  <locus_> What happen to Bitcoin network ? no block since 12 hours,  Is the price is falling due this issue?
2302017-12-22T11:41:42  <jouke> I just received a block a couple of minutes ago.
2312017-12-22T11:41:50  <bitcoin-git> [bitcoin] Sjors opened pull request #11989: [build] .gitignore: add QT Creator artifacts (master...ignore-qt-creator-artifacts) https://github.com/bitcoin/bitcoin/pull/11989
2322017-12-22T11:42:11  <jouke> It's not that uncommom to wait for a block for more than an hour.
2332017-12-22T11:42:32  <provoostenator> loucs_: #bitcoin is more appropriate for these questions.
2342017-12-22T11:43:15  <provoostenator> I mean locus_
2352017-12-22T11:44:46  *** locus_ has quit IRC
2362017-12-22T11:47:28  <wumpus> Last block was 500527, on Fri Dec 22 11:41:18 2017
2372017-12-22T11:47:59  <wumpus> well if it was bitcoin core he's running and it's stuck for 12 hours that might be a bug report, but he's already left
2382017-12-22T11:51:00  *** crazyprodigy has quit IRC
2392017-12-22T11:59:30  *** LordCow has joined #bitcoin-core-dev
2402017-12-22T12:04:41  <meshcollider> where should the actual code to register args for each module go do you think
2412017-12-22T12:05:24  <meshcollider> the RPC stuff has a separate rpc/register.h header for the registration functions, and then the functions are spread over multiple files
2422017-12-22T12:05:25  *** ghost43 has quit IRC
2432017-12-22T12:05:48  *** ghost43 has joined #bitcoin-core-dev
2442017-12-22T12:06:04  <zelest> When downloading and synking the full blockchain, is it the bandwidth that's the bottleneck or is it computationally heavy to validate it all?
2452017-12-22T12:06:05  <meshcollider> but using a struct to hold the globals for the args for each module was suggested right? So where would be the best place for each struct and the corresponding registration code
2462017-12-22T12:06:14  <zelest> syncing*
2472017-12-22T12:06:20  <meshcollider> zelest: computationally heavy, verifying the signatures
2482017-12-22T12:06:31  <zelest> Ah, gotcha :)
2492017-12-22T12:08:21  *** YellowSphere has joined #bitcoin-core-dev
2502017-12-22T12:08:37  <wumpus> meshcollider: in an init function per module, I guess
2512017-12-22T12:08:48  <wumpus> meshcollider: same as how the RPC registration works
2522017-12-22T12:12:02  <meshcollider> wumpus: I imagine all registration should happen during init and then call parseparameters, but how does that interact with -help, because -help should be checked before init proceeds further right?
2532017-12-22T12:12:22  <meshcollider> so really -help needs to be checked before the registration of args and thus before parseparameters?
2542017-12-22T12:12:41  <wumpus> meshcollider: I guess the registration needs to happen before -help handling
2552017-12-22T12:13:13  <meshcollider> wumpus: alright, seemed a little unnatural to me to put arg registration for everything even before that, but I guess it makes sense
2562017-12-22T12:13:14  <wumpus> meshcollider: that is kind of annoying, but no way around it, as -help is an argument itself *and* it needs access to all the registered other arguments
2572017-12-22T12:14:05  <wumpus> yes it seems kind of unnatural, but the alternative would be to make -help handling special, in that it separately calls the registration functions, I don't think that's better
2582017-12-22T12:14:17  <meshcollider> wumpus: no, I agree
2592017-12-22T12:15:55  <meshcollider> wumpus: So when you refer to "modules", do you mean like bitcoind, wallet, bitcoin-cli, bitcoin-qt and bitcoin-tx?
2602017-12-22T12:15:58  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/180a25596a29...f19ca129ffd7
2612017-12-22T12:15:58  <bitcoin-git> bitcoin/master 5cbbbd7 Sjors Provoost: [Wallet] Use RBF by default in QT only...
2622017-12-22T12:15:59  <bitcoin-git> bitcoin/master f19ca12 Wladimir J. van der Laan: Merge #11605: [Wallet] Enable RBF by default in QT...
2632017-12-22T12:16:19  <bitcoin-git> [bitcoin] laanwj closed pull request #11605: [Wallet] Enable RBF by default in QT (master...rbf-default) https://github.com/bitcoin/bitcoin/pull/11605
2642017-12-22T12:16:20  <meshcollider> wumpus: or more like wallet stuff, blockchain stuff, meta stuff like help/debug, etc.
2652017-12-22T12:16:35  <meshcollider> in terms of dividing up the structs of globals
2662017-12-22T12:16:38  *** Tomthiel has joined #bitcoin-core-dev
2672017-12-22T12:16:40  <wumpus> meshcollider: I mean separate implementation units
2682017-12-22T12:17:05  <wumpus> meshcollider: yes, the second
2692017-12-22T12:17:40  <wumpus> the idea is keep the options as close to the code that uses them as possible
2702017-12-22T12:18:08  <wumpus> this allows for localized changes, without generating merge hotspots
2712017-12-22T12:18:25  <meshcollider> wumpus: does a new directory for arg files, which contains one for each "type" of args along with the function to register it all make sense?
2722017-12-22T12:18:35  <meshcollider> a bit like the rpc/ dir with register.h header
2732017-12-22T12:18:56  <wumpus> no, definitely not
2742017-12-22T12:19:04  <wumpus> you don't want to group the args together
2752017-12-22T12:19:11  <wumpus> you want to group the args with the code that uses them
2762017-12-22T12:19:37  <meshcollider> ah I see, hmm
2772017-12-22T12:19:53  <wumpus> creating a directory 'arg' would be like creating a directory 'types' which contains all types. It's not a useful semantic grouping :)
2782017-12-22T12:20:08  <meshcollider> wumpus: true haha
2792017-12-22T12:20:29  <meshcollider> I feel like this is going to be quite messy to decide where each arg goes though and what groupings make sense
2802017-12-22T12:20:58  <meshcollider> especially if certain args are used in multiple places
2812017-12-22T12:21:08  <wumpus> I agree it's a bit funny in the rpc case, why would rpcblockchain be under rpc and not under 'block chain functionality' but beh
2822017-12-22T12:21:45  <wumpus> grouping things is hard
2832017-12-22T12:22:06  <wumpus> meshcollider: yes...
2842017-12-22T12:23:24  *** Tomthiel has quit IRC
2852017-12-22T12:23:53  <meshcollider> wumpus: and also, I have not thought much yet about how to replace SoftSetArg and ForceSetArg, the former being difficult to tell if a value has been set or not using just a pointer to a variable
2862017-12-22T12:24:17  <meshcollider> ForceSetArg should be ok I think
2872017-12-22T12:25:21  <wumpus> yes, this is quite an annoying project in that regard, having handle so many concerns at the same time
2882017-12-22T12:26:47  <meshcollider> mhm its a little overwhelming compared to what I have worked on up to this point :) good experience though
2892017-12-22T12:38:04  *** larafale has joined #bitcoin-core-dev
2902017-12-22T12:43:17  *** pkx2 has joined #bitcoin-core-dev
2912017-12-22T12:48:35  *** coscr has joined #bitcoin-core-dev
2922017-12-22T12:49:33  *** coscr has joined #bitcoin-core-dev
2932017-12-22T12:50:27  *** coscr has quit IRC
2942017-12-22T12:51:00  <ryanofsky> meshcollider, there should be no need for arg registration init functions in typical case. just declaring an arg could add it to global list of args as in https://gflags.github.io/gflags/#define
2952017-12-22T12:52:14  <ryanofsky> maybe you should describe what the proposed interface for registering and accessing args somewhere, before going to refactor all the code
2962017-12-22T12:53:45  *** larafale has quit IRC
2972017-12-22T12:54:21  *** larafale has joined #bitcoin-core-dev
2982017-12-22T12:56:51  <meshcollider> I was thinking to have a function like gArgs.RegisterArg("-foo", {"-foo", "does something", ARG_BOOL, &foo, false});
2992017-12-22T12:57:13  <meshcollider> Where second parameter is an enum with the info needed
3002017-12-22T12:58:27  *** larafale has quit IRC
3012017-12-22T12:58:49  <meshcollider> Then ParseParameters is called as normal which populate all the variables, and then those variables can be used directly without needing gArgs anymore?
3022017-12-22T13:05:44  *** larafale has joined #bitcoin-core-dev
3032017-12-22T13:06:21  *** contrapumpkin has quit IRC
3042017-12-22T13:17:09  *** contrapumpkin has joined #bitcoin-core-dev
3052017-12-22T13:23:31  *** Deacyde has quit IRC
3062017-12-22T13:24:39  *** larafale has quit IRC
3072017-12-22T13:31:31  *** Victor_sueca has quit IRC
3082017-12-22T13:33:08  *** Victor_sueca has joined #bitcoin-core-dev
3092017-12-22T13:37:49  *** larafale has joined #bitcoin-core-dev
3102017-12-22T13:51:38  <ryanofsky> meshcollider, that seems ok, but it is a little more verbose compared to gflags where you can just declare a global variable anywhere you want and don't need to write manual init code
3112017-12-22T13:52:18  <ryanofsky> also unclear why "-foo" option name needs to be repeated twice and why ARG_BOOL couldn't be derived from the type of &foo
3122017-12-22T13:59:04  *** pavi_ has joined #bitcoin-core-dev
3132017-12-22T14:05:52  *** Giszmo has joined #bitcoin-core-dev
3142017-12-22T14:11:54  *** pavi_ has quit IRC
3152017-12-22T14:16:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3162017-12-22T14:20:35  *** murr4y has joined #bitcoin-core-dev
3172017-12-22T14:35:48  *** larafale has quit IRC
3182017-12-22T14:45:10  *** larafale has joined #bitcoin-core-dev
3192017-12-22T14:50:16  *** Guyver2 has joined #bitcoin-core-dev
3202017-12-22T14:54:48  <bitcoin-git> [bitcoin] Sjors opened pull request #11991: Segwit qt bech32 receive (master...segwit-qt-bech32-receive) https://github.com/bitcoin/bitcoin/pull/11991
3212017-12-22T14:57:01  *** jb55 has joined #bitcoin-core-dev
3222017-12-22T14:57:09  *** jb55 has quit IRC
3232017-12-22T14:57:25  *** jb55 has joined #bitcoin-core-dev
3242017-12-22T15:05:50  *** meshcollider has quit IRC
3252017-12-22T15:06:01  *** YellowSphere has joined #bitcoin-core-dev
3262017-12-22T15:09:53  *** jb55 has quit IRC
3272017-12-22T15:11:45  *** Chris_Stewart_5 has quit IRC
3282017-12-22T15:13:56  *** justanotheruser has quit IRC
3292017-12-22T15:33:22  *** YellowSphere has quit IRC
3302017-12-22T15:49:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3312017-12-22T15:53:00  *** Victor_sueca has quit IRC
3322017-12-22T15:54:11  *** Victor_sueca has joined #bitcoin-core-dev
3332017-12-22T16:02:58  *** SopaXorzTaker has quit IRC
3342017-12-22T16:03:25  *** SopaXorzTaker has joined #bitcoin-core-dev
3352017-12-22T16:06:16  *** tiagotrs has joined #bitcoin-core-dev
3362017-12-22T16:08:46  *** pergaminho has joined #bitcoin-core-dev
3372017-12-22T16:09:33  *** timothy has quit IRC
3382017-12-22T16:13:45  *** cloud has joined #bitcoin-core-dev
3392017-12-22T16:14:09  *** cloud is now known as Guest60860
3402017-12-22T16:15:08  *** jb55 has joined #bitcoin-core-dev
3412017-12-22T16:19:04  *** pergaminho has quit IRC
3422017-12-22T16:21:38  *** Guest60860 has quit IRC
3432017-12-22T16:45:00  *** m8tion has quit IRC
3442017-12-22T16:45:53  *** Randolf has quit IRC
3452017-12-22T16:45:58  *** Murch has joined #bitcoin-core-dev
3462017-12-22T16:57:08  *** AaronvanW has quit IRC
3472017-12-22T17:33:37  *** Giszmo has quit IRC
3482017-12-22T17:35:24  *** Victor_sueca has quit IRC
3492017-12-22T17:36:42  *** Victor_sueca has joined #bitcoin-core-dev
3502017-12-22T17:42:08  *** jb55 has quit IRC
3512017-12-22T18:02:20  *** laurentmt has quit IRC
3522017-12-22T18:05:37  *** andrelam has joined #bitcoin-core-dev
3532017-12-22T18:28:14  *** larafale has quit IRC
3542017-12-22T18:28:29  *** davec has quit IRC
3552017-12-22T18:30:26  *** Randolf has joined #bitcoin-core-dev
3562017-12-22T18:31:15  *** Randolf has quit IRC
3572017-12-22T18:33:35  *** vicenteH has quit IRC
3582017-12-22T18:40:31  *** Syde has joined #bitcoin-core-dev
3592017-12-22T18:48:46  *** laurentmt has joined #bitcoin-core-dev
3602017-12-22T18:54:06  *** larafale has joined #bitcoin-core-dev
3612017-12-22T18:58:07  *** moctos has joined #bitcoin-core-dev
3622017-12-22T18:59:58  *** contrapumpkin is now known as Social-Justice-D
3632017-12-22T19:00:19  *** Social-Justice-D is now known as King-of-SJW
3642017-12-22T19:00:41  *** meshcollider has joined #bitcoin-core-dev
3652017-12-22T19:01:13  *** King-of-SJW is now known as contrapumpkin
3662017-12-22T19:02:57  *** moctos has quit IRC
3672017-12-22T19:08:38  *** goatpig has joined #bitcoin-core-dev
3682017-12-22T19:10:05  *** StopAndDecrypt has joined #bitcoin-core-dev
3692017-12-22T19:10:05  *** StopAndDecrypt has quit IRC
3702017-12-22T19:10:05  *** StopAndDecrypt has joined #bitcoin-core-dev
3712017-12-22T19:10:55  *** StopAndDecrypt_ has quit IRC
3722017-12-22T19:12:35  *** Kozuch has quit IRC
3732017-12-22T19:12:57  *** photonclock_ has quit IRC
3742017-12-22T19:13:10  *** photonclock_ has joined #bitcoin-core-dev
3752017-12-22T19:18:39  *** contrapumpkin is now known as sn0wflake
3762017-12-22T19:28:58  *** sn0wflake is now known as c0ntrapumpkin
3772017-12-22T19:43:51  *** Victor_sueca has quit IRC
3782017-12-22T19:45:04  *** Victor_sueca has joined #bitcoin-core-dev
3792017-12-22T19:49:49  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f19ca129ffd7...8f68fd281eec
3802017-12-22T19:49:49  <bitcoin-git> bitcoin/master 31a0135 Jonas Schnelli: Add required package dependencies for depends cross compilation...
3812017-12-22T19:49:50  <bitcoin-git> bitcoin/master 8f68fd2 Jonas Schnelli: Merge #11903: [trivial] Add required package dependencies for depends cross compilation...
3822017-12-22T19:50:24  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11903: [trivial] Add required package dependencies for depends cross compilation (master...2017/12/depends_pkg) https://github.com/bitcoin/bitcoin/pull/11903
3832017-12-22T19:58:25  *** Kozuch has joined #bitcoin-core-dev
3842017-12-22T20:02:41  *** tiagotrs has quit IRC
3852017-12-22T20:03:48  *** justanotheruser has joined #bitcoin-core-dev
3862017-12-22T20:10:44  *** Chris_Stewart_5 has quit IRC
3872017-12-22T20:15:26  *** Ylbam has joined #bitcoin-core-dev
3882017-12-22T20:21:13  *** quantbot_ has joined #bitcoin-core-dev
3892017-12-22T20:24:00  *** SopaXorzTaker has quit IRC
3902017-12-22T20:24:24  *** jb55 has joined #bitcoin-core-dev
3912017-12-22T20:25:23  *** quantbot has quit IRC
3922017-12-22T20:25:27  *** quantbot_ has quit IRC
3932017-12-22T20:27:51  *** marsadm has quit IRC
3942017-12-22T20:29:04  *** justanotheruser has quit IRC
3952017-12-22T20:30:23  *** gmaxwell has quit IRC
3962017-12-22T20:30:56  *** gmaxwell has joined #bitcoin-core-dev
3972017-12-22T20:31:19  *** gmaxwell is now known as Guest23082
3982017-12-22T20:34:27  *** marsadm has joined #bitcoin-core-dev
3992017-12-22T20:35:02  *** jb55 has quit IRC
4002017-12-22T20:43:02  *** justanotheruser has joined #bitcoin-core-dev
4012017-12-22T20:44:39  *** larafale has quit IRC
4022017-12-22T20:45:48  *** larafale has joined #bitcoin-core-dev
4032017-12-22T20:51:07  *** hirish has joined #bitcoin-core-dev
4042017-12-22T20:59:25  *** jb55 has joined #bitcoin-core-dev
4052017-12-22T21:00:51  *** laurentmt has quit IRC
4062017-12-22T21:01:24  *** laurentmt has joined #bitcoin-core-dev
4072017-12-22T21:16:11  *** jb55 has quit IRC
4082017-12-22T21:20:51  *** justanotheruser has quit IRC
4092017-12-22T21:22:07  *** timothy has joined #bitcoin-core-dev
4102017-12-22T21:29:55  *** tiagotrs has joined #bitcoin-core-dev
4112017-12-22T21:29:56  *** Victor_sueca has quit IRC
4122017-12-22T21:29:57  *** tiagotrs has quit IRC
4132017-12-22T21:29:58  *** tiagotrs has joined #bitcoin-core-dev
4142017-12-22T21:31:13  *** Victor_sueca has joined #bitcoin-core-dev
4152017-12-22T21:40:22  *** meshcollider has quit IRC
4162017-12-22T21:45:18  *** vicenteH has joined #bitcoin-core-dev
4172017-12-22T21:47:05  *** eyalsh has joined #bitcoin-core-dev
4182017-12-22T21:49:54  *** eyalsh has left #bitcoin-core-dev
4192017-12-22T21:50:19  *** eyalsh has joined #bitcoin-core-dev
4202017-12-22T21:51:36  *** Guest23082 has quit IRC
4212017-12-22T21:51:36  *** Guest23082 has joined #bitcoin-core-dev
4222017-12-22T21:51:40  *** Guest23082 is now known as gmaxwell
4232017-12-22T22:02:25  *** Guyver2 has quit IRC
4242017-12-22T22:06:36  *** mandric has joined #bitcoin-core-dev
4252017-12-22T22:07:18  *** Randolf has joined #bitcoin-core-dev
4262017-12-22T22:14:13  *** cornben1 has joined #bitcoin-core-dev
4272017-12-22T22:14:14  *** cornben1 has quit IRC
4282017-12-22T22:16:23  *** cornben has quit IRC
4292017-12-22T22:26:11  *** cornben has joined #bitcoin-core-dev
4302017-12-22T22:26:12  *** cornben has quit IRC
4312017-12-22T22:34:00  *** Hehwh has joined #bitcoin-core-dev
4322017-12-22T22:34:05  *** cornben has joined #bitcoin-core-dev
4332017-12-22T22:34:06  *** cornben has quit IRC
4342017-12-22T22:34:42  *** Hehwh has quit IRC
4352017-12-22T22:35:12  *** pkx2 has quit IRC
4362017-12-22T22:49:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4372017-12-22T22:51:36  <phantomcircuit> im not sure how i did this
4382017-12-22T22:51:44  <phantomcircuit> but everytime i issue the help rpc command
4392017-12-22T22:51:48  <phantomcircuit> my wallet is rescanned
4402017-12-22T22:52:30  <achow101> lol
4412017-12-22T22:52:56  <achow101> phantomcircuit: did you change any of the code?
4422017-12-22T22:55:58  <phantomcircuit> nope
4432017-12-22T22:56:05  *** davec has joined #bitcoin-core-dev
4442017-12-22T22:56:21  <phantomcircuit> 18a1bbad98bd4321f15e7921d9aec91661499d90
4452017-12-22T22:56:35  *** Randolf has quit IRC
4462017-12-22T22:56:38  <phantomcircuit> 2017-12-22 22:51:08 RescanFromTime: Rescanning last 500604 blocks
4472017-12-22T22:58:17  <achow101> That happens every time you use the help command?
4482017-12-22T22:59:13  <phantomcircuit> yeah
4492017-12-22T22:59:25  <phantomcircuit> actually i wonder if this binary is the one where i added my own rescan command
4502017-12-22T22:59:26  <phantomcircuit> hmm
4512017-12-22T22:59:59  <gmaxwell> did you add it to the wrong place?
4522017-12-22T23:12:30  *** luke-jr has quit IRC
4532017-12-22T23:14:40  *** ABC has joined #bitcoin-core-dev
4542017-12-22T23:15:06  *** ABC is now known as Guest60902
4552017-12-22T23:19:40  *** luke-jr has joined #bitcoin-core-dev
4562017-12-22T23:27:50  <phantomcircuit> gmaxwell, nope
4572017-12-22T23:27:57  <phantomcircuit> i did not acquire locks correctly
4582017-12-22T23:27:58  <phantomcircuit> so
4592017-12-22T23:28:03  <phantomcircuit> rng behavior i guess?
4602017-12-22T23:30:34  *** Guest60902 has quit IRC
4612017-12-22T23:30:34  *** mandric has quit IRC
4622017-12-22T23:31:05  *** Chris_Stewart_5 has quit IRC
4632017-12-22T23:37:26  *** mandric has joined #bitcoin-core-dev
4642017-12-22T23:41:36  *** ryanw has joined #bitcoin-core-dev
4652017-12-22T23:41:59  *** ryanw has joined #bitcoin-core-dev
4662017-12-22T23:43:15  *** Cogito_Ergo_Sum has quit IRC
4672017-12-22T23:53:56  <ryanw> just getting spun up for the first time, do people use qt as their ide like it mentions in the install docs?
4682017-12-22T23:56:57  *** ryanw has left #bitcoin-core-dev