1 2018-01-17T00:00:00  *** echelon has quit IRC
  2 2018-01-17T00:00:52  *** echelon has joined #bitcoin-core-dev
  3 2018-01-17T00:01:06  *** mandric has quit IRC
  4 2018-01-17T00:05:19  *** Randolf has quit IRC
  5 2018-01-17T00:08:08  *** owowo has quit IRC
  6 2018-01-17T00:08:21  *** owowo has joined #bitcoin-core-dev
  7 2018-01-17T00:12:34  *** Randolf has joined #bitcoin-core-dev
  8 2018-01-17T00:13:07  *** Asa89Marvin has joined #bitcoin-core-dev
  9 2018-01-17T00:14:56  *** vicenteH has quit IRC
 10 2018-01-17T00:15:33  *** anome has quit IRC
 11 2018-01-17T00:16:47  *** Chris_Stewart_5 has quit IRC
 12 2018-01-17T00:27:16  *** promag has joined #bitcoin-core-dev
 13 2018-01-17T00:28:22  <promag> is #12194 something to go in the next version?
 14 2018-01-17T00:28:24  <gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
 15 2018-01-17T00:30:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 16 2018-01-17T00:31:17  *** wacawacawaca has joined #bitcoin-core-dev
 17 2018-01-17T00:39:18  *** Victor_sueca has quit IRC
 18 2018-01-17T00:40:26  *** Victor_sueca has joined #bitcoin-core-dev
 19 2018-01-17T00:46:37  *** goatpig has quit IRC
 20 2018-01-17T00:48:35  *** luke-jr has quit IRC
 21 2018-01-17T00:48:52  *** luke-jr has joined #bitcoin-core-dev
 22 2018-01-17T00:51:04  *** stevenroose_ has quit IRC
 23 2018-01-17T00:52:26  *** stevenroose has joined #bitcoin-core-dev
 24 2018-01-17T00:53:06  <meshcollider> do we want #11708 in 0.16 as well for better P2SH-P2WSH support or no
 25 2018-01-17T00:53:08  <gribble> https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub
 26 2018-01-17T00:57:35  *** wacawacawaca has quit IRC
 27 2018-01-17T01:00:10  *** dabura667 has joined #bitcoin-core-dev
 28 2018-01-17T01:04:36  *** belcher has quit IRC
 29 2018-01-17T01:05:43  *** Tennis has quit IRC
 30 2018-01-17T01:06:09  *** AaronvanW has quit IRC
 31 2018-01-17T01:09:03  *** flokie has joined #bitcoin-core-dev
 32 2018-01-17T01:10:01  *** jb55 has quit IRC
 33 2018-01-17T01:10:13  *** YellowSphere has quit IRC
 34 2018-01-17T01:18:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12206: qa: Have wallet wait for TransactionAddedToMempool (master...Mf1801-qaWalletMempoolAsync) https://github.com/bitcoin/bitcoin/pull/12206
 35 2018-01-17T01:25:45  *** hirish is now known as hirishaway
 36 2018-01-17T01:33:08  *** Randolf has quit IRC
 37 2018-01-17T01:34:29  *** JackH has quit IRC
 38 2018-01-17T01:37:49  *** ghost43 has quit IRC
 39 2018-01-17T01:38:31  *** ghost43 has joined #bitcoin-core-dev
 40 2018-01-17T01:44:26  *** mrannanay has quit IRC
 41 2018-01-17T01:46:19  *** wacawacawaca has joined #bitcoin-core-dev
 42 2018-01-17T01:51:01  *** wacawacawaca has quit IRC
 43 2018-01-17T01:54:53  *** jb55 has joined #bitcoin-core-dev
 44 2018-01-17T02:06:14  *** Krellan has quit IRC
 45 2018-01-17T02:06:42  *** Krellan has joined #bitcoin-core-dev
 46 2018-01-17T02:08:26  *** twoken has joined #bitcoin-core-dev
 47 2018-01-17T02:09:55  *** echelon has quit IRC
 48 2018-01-17T02:11:43  *** Krellan has quit IRC
 49 2018-01-17T02:12:31  *** rattlnbones has joined #bitcoin-core-dev
 50 2018-01-17T02:13:34  *** rattlnbones has quit IRC
 51 2018-01-17T02:13:51  *** coincrispy has joined #bitcoin-core-dev
 52 2018-01-17T02:16:55  *** Chris_Stewart_5 has quit IRC
 53 2018-01-17T02:21:08  *** echelon has joined #bitcoin-core-dev
 54 2018-01-17T02:28:53  *** Scrat has quit IRC
 55 2018-01-17T02:30:11  *** intcat has quit IRC
 56 2018-01-17T02:30:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 57 2018-01-17T02:33:29  *** intcat has joined #bitcoin-core-dev
 58 2018-01-17T02:37:59  *** wxss has quit IRC
 59 2018-01-17T02:39:40  *** ghost43 has quit IRC
 60 2018-01-17T02:42:29  *** ula has quit IRC
 61 2018-01-17T02:47:08  *** ghost43 has joined #bitcoin-core-dev
 62 2018-01-17T02:49:06  *** Giszmo has joined #bitcoin-core-dev
 63 2018-01-17T02:51:05  *** DarylSharp has joined #bitcoin-core-dev
 64 2018-01-17T03:12:01  *** Randolf has joined #bitcoin-core-dev
 65 2018-01-17T03:15:39  *** dabura667 has quit IRC
 66 2018-01-17T03:18:03  *** Giszmo has quit IRC
 67 2018-01-17T03:20:06  *** indistylo has joined #bitcoin-core-dev
 68 2018-01-17T03:21:41  *** Chris_Stewart_5 has quit IRC
 69 2018-01-17T03:29:18  *** jb55 has quit IRC
 70 2018-01-17T03:31:10  *** aruns has joined #bitcoin-core-dev
 71 2018-01-17T03:33:20  *** indistylo has quit IRC
 72 2018-01-17T03:35:51  *** aruns has quit IRC
 73 2018-01-17T03:46:02  *** jb55 has joined #bitcoin-core-dev
 74 2018-01-17T03:59:31  *** tknp has quit IRC
 75 2018-01-17T04:00:38  *** arubi has quit IRC
 76 2018-01-17T04:01:41  *** arubi has joined #bitcoin-core-dev
 77 2018-01-17T04:02:01  *** echelon has quit IRC
 78 2018-01-17T04:06:27  *** dermoth has quit IRC
 79 2018-01-17T04:07:50  *** jtimon has quit IRC
 80 2018-01-17T04:35:12  *** rafalcpp_ has joined #bitcoin-core-dev
 81 2018-01-17T04:35:35  *** rabidus has quit IRC
 82 2018-01-17T04:35:35  *** boblee has quit IRC
 83 2018-01-17T04:35:35  *** boblee has joined #bitcoin-core-dev
 84 2018-01-17T04:35:37  *** rafalcpp has quit IRC
 85 2018-01-17T04:36:22  *** rabidus has joined #bitcoin-core-dev
 86 2018-01-17T04:42:50  *** tknp has joined #bitcoin-core-dev
 87 2018-01-17T04:42:56  *** echelon has joined #bitcoin-core-dev
 88 2018-01-17T04:47:00  *** rafalcpp__ has joined #bitcoin-core-dev
 89 2018-01-17T04:47:29  *** rafalcpp_ has quit IRC
 90 2018-01-17T04:58:43  *** arubi has quit IRC
 91 2018-01-17T05:02:33  *** arubi has joined #bitcoin-core-dev
 92 2018-01-17T05:18:27  <meshcollider> poor travis is still having a rest
 93 2018-01-17T05:50:35  *** shesek has joined #bitcoin-core-dev
 94 2018-01-17T05:57:50  *** arcz has joined #bitcoin-core-dev
 95 2018-01-17T06:00:51  *** eck has joined #bitcoin-core-dev
 96 2018-01-17T06:01:45  *** eck has joined #bitcoin-core-dev
 97 2018-01-17T06:08:57  *** eck has quit IRC
 98 2018-01-17T06:11:33  *** arcz has quit IRC
 99 2018-01-17T06:20:13  <bitcoin-git> [bitcoin] CryptAxe opened pull request #12207: Start renaming functional tests & update test runner (master...updateTests) https://github.com/bitcoin/bitcoin/pull/12207
100 2018-01-17T06:21:19  *** goksinen has quit IRC
101 2018-01-17T06:21:25  *** goksinen has joined #bitcoin-core-dev
102 2018-01-17T06:21:43  *** mrannanay has joined #bitcoin-core-dev
103 2018-01-17T06:24:34  *** windsok has quit IRC
104 2018-01-17T06:26:01  *** d9b4bef9 has quit IRC
105 2018-01-17T06:27:08  *** d9b4bef9 has joined #bitcoin-core-dev
106 2018-01-17T06:33:48  <bitcoin-git> [bitcoin] CryptAxe closed pull request #12207: Start renaming functional tests & update test runner (master...updateTests) https://github.com/bitcoin/bitcoin/pull/12207
107 2018-01-17T06:49:04  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cad504bf4c30...062c8b69f4cc
108 2018-01-17T06:49:04  <bitcoin-git> bitcoin/master 63ac890 Sjors Provoost: [qt] receive tab: bech32 address opt-in checkbox...
109 2018-01-17T06:49:05  <bitcoin-git> bitcoin/master 062c8b6 Jonas Schnelli: Merge #11991: [qt] Receive: checkbox for bech32 address...
110 2018-01-17T06:49:47  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11991: [qt] Receive: checkbox for bech32 address (master...segwit-qt-bech32-receive) https://github.com/bitcoin/bitcoin/pull/11991
111 2018-01-17T06:56:31  *** daouzo23 has joined #bitcoin-core-dev
112 2018-01-17T06:56:37  *** daouzo23 has quit IRC
113 2018-01-17T06:58:38  *** tknp has quit IRC
114 2018-01-17T07:03:54  <luke-jr> … that tooltip kinda sucks. people don't spend from addresses :/
115 2018-01-17T07:10:57  <sipa> luke-jr: improve it!
116 2018-01-17T07:11:11  <luke-jr> working on it ;)
117 2018-01-17T07:11:38  *** ryan-c has quit IRC
118 2018-01-17T07:12:07  <luke-jr> I wonder if there's a nicer name than "Bech32" to use here
119 2018-01-17T07:13:32  <jonasschnelli> luke-jr: 11937 uses "Native SegWit (Bech32)"
120 2018-01-17T07:13:45  <jonasschnelli> s/B/b
121 2018-01-17T07:14:53  <luke-jr> sgtm
122 2018-01-17T07:15:05  <jonasschnelli> sipa: since you have commented on #11281 (0.16 milestone), I'd like to see your ack there...
123 2018-01-17T07:15:09  <gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
124 2018-01-17T07:18:02  <sipa> jonasschnelli: about to pack and fly, but i'm fine with the split of the cs if it's documented
125 2018-01-17T07:18:19  <jonasschnelli> sipa: Okay. No hurry... thanks
126 2018-01-17T07:26:10  <bitcoin-git> [bitcoin] luke-jr opened pull request #12208: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default (master...gui_legacy_bech32) https://github.com/bitcoin/bitcoin/pull/12208
127 2018-01-17T07:30:27  *** Krellan has joined #bitcoin-core-dev
128 2018-01-17T07:30:39  *** Krellan has joined #bitcoin-core-dev
129 2018-01-17T07:32:51  <meshcollider> sipa: may want to delete the weird comment here  https://github.com/bitcoin/bitcoin/commit/d4aa54c5af925bd0ed81c7a9ffab457149e5d682#commitcomment-26900790
130 2018-01-17T07:32:52  <jonasschnelli> luke-jrl: whats the reason to do that: https://github.com/bitcoin/bitcoin/pull/12208/files#diff-dd8e54f9b8311348e3abf1ecb65eda10R151?
131 2018-01-17T07:33:14  <jonasschnelli> If someone wants Bech32, why override to OUTPUT_TYPE_P2SH_SEGWIT?
132 2018-01-17T07:34:43  <sipa> meshcollider: can't do that right now (on phone)
133 2018-01-17T07:34:54  <luke-jr> jonasschnelli: that's if the checkbox is unchecked
134 2018-01-17T07:35:04  <luke-jr> if they have it set to Bech32, the checkbox is checked by default
135 2018-01-17T07:35:04  <meshcollider> sipa: all good, sorry I posted that before I read your message about packing :)
136 2018-01-17T07:35:12  <meshcollider> maybe jonasschnelli can then
137 2018-01-17T07:35:37  <jonasschnelli> meshcollider: done
138 2018-01-17T07:40:31  *** windsok has joined #bitcoin-core-dev
139 2018-01-17T07:46:30  *** dabura667 has joined #bitcoin-core-dev
140 2018-01-17T07:48:21  <luke-jr> should we bump libsecp256k1 for 0.16? not sure how big a deal the optimisations are
141 2018-01-17T07:53:13  <sipa> i don't think there is anything very important
142 2018-01-17T07:54:42  <jonasschnelli> luke-jr: I was just confuse that you called OUTPUT_TYPE_P2SH_SEGWIT legacy
143 2018-01-17T07:55:42  <luke-jr> jonasschnelli: I did?
144 2018-01-17T07:56:02  <jonasschnelli> <bitcoin-git>	[bitcoin] luke-jr opened pull request #12208: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default
145 2018-01-17T07:56:04  <gribble> https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
146 2018-01-17T07:56:19  <luke-jr> jonasschnelli: that's referring to the ability to use Bech32, if your addresstype=legacy
147 2018-01-17T07:57:04  <jonasschnelli> Ah.. now I see.
148 2018-01-17T07:59:02  <luke-jr> jonasschnelli: squashed
149 2018-01-17T08:01:07  *** echelon has quit IRC
150 2018-01-17T08:05:09  *** whphhg has quit IRC
151 2018-01-17T08:07:54  *** whphhg has joined #bitcoin-core-dev
152 2018-01-17T08:08:13  *** echelon has joined #bitcoin-core-dev
153 2018-01-17T08:21:41  *** Cogito_Ergo_Sum has quit IRC
154 2018-01-17T08:22:57  <gmaxwell> sipa: https://github.com/bitcoin/bitcoin/pull/11991#issuecomment-357039103  < this QR encoded Bech32 address is apparently truncated in the QR code itself and it doesn't appear to be in allcaps.
155 2018-01-17T08:24:56  <gmaxwell> oh, I see, it's regtest, that threw me.
156 2018-01-17T08:25:36  <gmaxwell> but it still isn't allcaps and should be.
157 2018-01-17T08:28:35  *** gielbier has quit IRC
158 2018-01-17T08:31:39  *** lnostdal has quit IRC
159 2018-01-17T08:33:58  <gmaxwell> nevermind, I see there is a PR for that
160 2018-01-17T08:36:09  <wumpus> only an issue
161 2018-01-17T08:36:40  <gmaxwell> oh I see, issue. (ah, thats why I didn't previously see it on the PR list-- I was wondering how I missed it!)
162 2018-01-17T08:39:33  *** promag has quit IRC
163 2018-01-17T08:43:15  <jonasschnelli> gmaxwell: The QRCode truncation should be fixed in master
164 2018-01-17T08:43:27  <jonasschnelli> #12173
165 2018-01-17T08:43:29  <gribble> https://github.com/bitcoin/bitcoin/issues/12173 | [Qt] Use flexible font size for QRCode image address by jonasschnelli · Pull Request #12173 · bitcoin/bitcoin · GitHub
166 2018-01-17T08:43:55  <jonasschnelli> allcaps is a different thing
167 2018-01-17T08:44:32  *** atroxes has quit IRC
168 2018-01-17T08:44:50  *** timothy has joined #bitcoin-core-dev
169 2018-01-17T08:45:24  <gmaxwell> jonasschnelli: I was confused by the regtest prefix and thought the prefix was getting truncated.
170 2018-01-17T08:47:12  <wumpus> probably want only the URL encoding to capitalize it, and not in other places like below the image
171 2018-01-17T08:47:49  *** Victor_sueca is now known as Victorsueca
172 2018-01-17T08:48:54  <gmaxwell> Personally I think allcaps monospace addresses usually look nicer, at least when presented in isolation. might want to look at it both ways before deciding.
173 2018-01-17T08:49:16  *** drizztbsd has joined #bitcoin-core-dev
174 2018-01-17T08:49:19  <wumpus> but I think caps are wider so it'd have to use an even smaller font
175 2018-01-17T08:49:54  <gmaxwell> they're the same size in monospace font.
176 2018-01-17T08:49:57  *** timothy has quit IRC
177 2018-01-17T08:50:06  <wumpus> yes
178 2018-01-17T08:51:21  *** jtimon has joined #bitcoin-core-dev
179 2018-01-17T08:52:05  *** echelon has quit IRC
180 2018-01-17T08:57:43  *** atroxes has joined #bitcoin-core-dev
181 2018-01-17T08:58:07  *** trotski2000 has joined #bitcoin-core-dev
182 2018-01-17T08:58:14  *** trotski2000 has quit IRC
183 2018-01-17T08:58:14  *** trotski2000 has joined #bitcoin-core-dev
184 2018-01-17T08:58:14  *** trotski2000 has quit IRC
185 2018-01-17T08:58:14  *** trotski2000 has joined #bitcoin-core-dev
186 2018-01-17T09:04:49  *** echelon has joined #bitcoin-core-dev
187 2018-01-17T09:20:40  *** anome has joined #bitcoin-core-dev
188 2018-01-17T09:32:54  *** eck has joined #bitcoin-core-dev
189 2018-01-17T09:35:00  *** vicenteH has joined #bitcoin-core-dev
190 2018-01-17T09:37:57  *** anome has quit IRC
191 2018-01-17T09:42:54  *** eck has quit IRC
192 2018-01-17T09:45:26  *** AriseChikun has quit IRC
193 2018-01-17T09:45:53  *** shesek has quit IRC
194 2018-01-17T09:46:19  *** AaronvanW has joined #bitcoin-core-dev
195 2018-01-17T09:49:02  *** Krellan has quit IRC
196 2018-01-17T09:49:56  *** Krellan has joined #bitcoin-core-dev
197 2018-01-17T09:50:27  *** anuby has quit IRC
198 2018-01-17T09:55:44  *** eck has joined #bitcoin-core-dev
199 2018-01-17T10:02:16  *** anome has joined #bitcoin-core-dev
200 2018-01-17T10:02:50  *** larafale has joined #bitcoin-core-dev
201 2018-01-17T10:03:20  *** laurenwoods has joined #bitcoin-core-dev
202 2018-01-17T10:04:19  *** laurenwoods has quit IRC
203 2018-01-17T10:05:33  *** [Author] has quit IRC
204 2018-01-17T10:07:33  *** anome has quit IRC
205 2018-01-17T10:08:34  *** [Author] has joined #bitcoin-core-dev
206 2018-01-17T10:08:35  *** jtimon has quit IRC
207 2018-01-17T10:15:55  *** AaronvanW has quit IRC
208 2018-01-17T10:16:33  *** AaronvanW has joined #bitcoin-core-dev
209 2018-01-17T10:17:08  *** anome has joined #bitcoin-core-dev
210 2018-01-17T10:18:57  *** goksinen has quit IRC
211 2018-01-17T10:19:23  *** goksinen has joined #bitcoin-core-dev
212 2018-01-17T10:23:48  *** eck has quit IRC
213 2018-01-17T10:23:57  *** goksinen has quit IRC
214 2018-01-17T10:30:04  *** anome has quit IRC
215 2018-01-17T10:32:57  *** lnostdal has joined #bitcoin-core-dev
216 2018-01-17T10:33:24  *** larafale has quit IRC
217 2018-01-17T10:34:37  *** goksinen has joined #bitcoin-core-dev
218 2018-01-17T10:35:11  *** Asa89Marvin has quit IRC
219 2018-01-17T10:35:17  *** goksinen has quit IRC
220 2018-01-17T10:35:32  *** goksinen has joined #bitcoin-core-dev
221 2018-01-17T10:39:58  *** AaronvanW has quit IRC
222 2018-01-17T10:41:58  *** AaronvanW has joined #bitcoin-core-dev
223 2018-01-17T10:42:58  *** lnostdal has quit IRC
224 2018-01-17T10:46:32  *** dabura667 has quit IRC
225 2018-01-17T10:49:42  *** larafale has joined #bitcoin-core-dev
226 2018-01-17T10:50:47  *** anome has joined #bitcoin-core-dev
227 2018-01-17T10:57:30  *** lnostdal has joined #bitcoin-core-dev
228 2018-01-17T11:02:03  *** tomatopeel has quit IRC
229 2018-01-17T11:04:35  *** moctost has joined #bitcoin-core-dev
230 2018-01-17T11:09:21  *** larafale has quit IRC
231 2018-01-17T11:09:23  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/062c8b69f4cc...adce1de9a6ce
232 2018-01-17T11:09:23  <bitcoin-git> bitcoin/master 49e5f3f Wladimir J. van der Laan: rpc: Add deprecation error for `getinfo`...
233 2018-01-17T11:09:24  <bitcoin-git> bitcoin/master adce1de Wladimir J. van der Laan: Merge #12198: rpc: Add deprecation error for `getinfo`...
234 2018-01-17T11:09:26  *** moctost has quit IRC
235 2018-01-17T11:09:59  *** larafale has joined #bitcoin-core-dev
236 2018-01-17T11:10:13  <bitcoin-git> [bitcoin] laanwj closed pull request #12198: rpc: Add deprecation error for `getinfo` (master...2018_01_getinfo_deprecation_message) https://github.com/bitcoin/bitcoin/pull/12198
237 2018-01-17T11:13:07  *** Jaiden19Jakubows has joined #bitcoin-core-dev
238 2018-01-17T11:14:27  *** larafale has quit IRC
239 2018-01-17T11:16:02  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
240 2018-01-17T11:16:03  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
241 2018-01-17T11:16:25  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/adce1de9a6ce...c7978be89964
242 2018-01-17T11:16:26  <bitcoin-git> bitcoin/master 0b63e3c Andrew Chow: Clamp walletpassphrase timeout to 2^(30) seconds and check its bounds...
243 2018-01-17T11:16:26  <bitcoin-git> bitcoin/master 134cdc7 Andrew Chow: Test walletpassphrase timeout bounds and clamping
244 2018-01-17T11:16:27  <bitcoin-git> bitcoin/master c7978be Wladimir J. van der Laan: Merge #12101: Clamp walletpassphrase timeout to 2^30 seconds and check its bounds...
245 2018-01-17T11:17:05  <bitcoin-git> [bitcoin] laanwj closed pull request #12101: Clamp walletpassphrase timeout to 2^30 seconds and check its bounds (master...wallet-unlock-time-int32) https://github.com/bitcoin/bitcoin/pull/12101
246 2018-01-17T11:20:14  *** eck has joined #bitcoin-core-dev
247 2018-01-17T11:23:32  *** eck has quit IRC
248 2018-01-17T11:24:28  *** DarylSharp2 has joined #bitcoin-core-dev
249 2018-01-17T11:24:36  *** promag has joined #bitcoin-core-dev
250 2018-01-17T11:25:43  *** Cogito_Ergo_Sum has quit IRC
251 2018-01-17T11:27:35  *** DarylSharp has quit IRC
252 2018-01-17T11:27:44  *** drizztbsd is now known as timothy
253 2018-01-17T11:30:56  *** wxss has joined #bitcoin-core-dev
254 2018-01-17T11:36:32  *** promag has quit IRC
255 2018-01-17T11:44:59  *** echelon has quit IRC
256 2018-01-17T11:48:18  *** echelon has joined #bitcoin-core-dev
257 2018-01-17T11:52:16  <meshcollider> What actually needs to be done for #11048, since its in the 0.16 milestone
258 2018-01-17T11:52:17  <gribble> https://github.com/bitcoin/bitcoin/issues/11048 | Weird gettransaction details on testnet with segwit · Issue #11048 · bitcoin/bitcoin · GitHub
259 2018-01-17T11:52:34  <meshcollider> do the current PRs resolve that or does it still need work
260 2018-01-17T11:56:20  <gmaxwell> I think thats a non-issue.
261 2018-01-17T11:56:31  <gmaxwell> non-change send to selfs are not hidden.
262 2018-01-17T11:56:53  *** promag has joined #bitcoin-core-dev
263 2018-01-17T11:57:03  <gmaxwell> otherwise a service with multiple users which sends funds on user commands would lose payments when one user sends to another user by address.
264 2018-01-17T11:59:55  <luke-jr> I agree that looks as expected in RPC
265 2018-01-17T12:00:20  <gmaxwell> (and 'custom change' to a non-change address is not treated as change)
266 2018-01-17T12:01:09  <meshcollider> ok, wumpus or someone can remove it from the milestone then :)
267 2018-01-17T12:01:19  <luke-jr> I really don't see the use case for 'custom change'.
268 2018-01-17T12:02:16  <gmaxwell> I whined a bit about it when implemented. I could contrive up some for you, e.g. you're slowly migrating from one old wallet to a new one, and want all your change to go to the new one.
269 2018-01-17T12:02:53  <gmaxwell> it's certantly an advanced feature.
270 2018-01-17T12:03:15  <luke-jr> hmm, that's an interesting idea
271 2018-01-17T12:03:45  <gmaxwell> I can't think of any other usecase.
272 2018-01-17T12:04:04  <gmaxwell> oh sorry, I know another one but its bad.
273 2018-01-17T12:04:17  <gmaxwell> E.g. user really insistant on keeping all their funds on a single address.
274 2018-01-17T12:04:26  <gmaxwell> Which there can be justifications for, but they're still bad. :)
275 2018-01-17T12:05:07  <wumpus> meshcollider: ok
276 2018-01-17T12:05:29  *** larafale has joined #bitcoin-core-dev
277 2018-01-17T12:10:41  <sipa> i can't ooen an issue now, but we should mark addwitnessaddress as deprecated
278 2018-01-17T12:14:18  <gmaxwell> Does it do anything anymore?
279 2018-01-17T12:14:59  <gmaxwell> meshcollider: I went and added some explination to that issue with the sends to self.
280 2018-01-17T12:15:13  <meshcollider> gmaxwell: sounds good, thanks
281 2018-01-17T12:15:44  <gmaxwell> meshcollider: thanks for bringing attention to it.
282 2018-01-17T12:19:52  *** zautomata has joined #bitcoin-core-dev
283 2018-01-17T12:20:01  <sipa> gmaxwell: it probably at least resets the address label
284 2018-01-17T12:22:19  <wumpus> something like  #12210?
285 2018-01-17T12:22:20  <gribble> https://github.com/bitcoin/bitcoin/issues/12210 | wallet: Deprecate addwitnessaddress by laanwj · Pull Request #12210 · bitcoin/bitcoin · GitHub
286 2018-01-17T12:22:22  <bitcoin-git> [bitcoin] laanwj opened pull request #12210: wallet: Deprecate addwitnessaddress (master...2018_01_deprecate_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/12210
287 2018-01-17T12:29:34  *** CubicEarths has quit IRC
288 2018-01-17T12:29:45  <meshcollider> ping kallewoof: are you going to reopen #11489 for 0.16?
289 2018-01-17T12:29:47  <gribble> https://github.com/bitcoin/bitcoin/issues/11489 | [wallet] sendtoaddress style argument by kallewoof · Pull Request #11489 · bitcoin/bitcoin · GitHub
290 2018-01-17T12:29:57  <meshcollider> to close #11134
291 2018-01-17T12:29:58  <gribble> https://github.com/bitcoin/bitcoin/issues/11134 | Sendtoaddress flag for sending change to a segwit address? · Issue #11134 · bitcoin/bitcoin · GitHub
292 2018-01-17T12:33:31  <meshcollider> wumpus: is that !IsDeprecatedRPCEnabled() stuff overkill for this case
293 2018-01-17T12:33:32  *** gaf_ has quit IRC
294 2018-01-17T12:34:09  <gmaxwell> probably, but uniformity is cheap.
295 2018-01-17T12:34:37  <meshcollider> gmaxwell: I mean he hasn't currently used it, was wondering if that was a deliberate choice :)
296 2018-01-17T12:34:48  <gmaxwell> ah!
297 2018-01-17T12:35:48  <wumpus> meshcollider: how does that work?
298 2018-01-17T12:36:12  <wumpus> FWIW I've added it to the release notes as well now
299 2018-01-17T12:36:20  <meshcollider> wumpus: its the stuff which forces you to use -deprecatedrpc=addwitnessaddress argument to use it
300 2018-01-17T12:36:45  <meshcollider> like estimatefee uses
301 2018-01-17T12:36:53  <wumpus> oh I see, sure
302 2018-01-17T12:36:56  <gmaxwell> might be premature to do that?
303 2018-01-17T12:37:05  <gmaxwell> do we want it to immediately stop working without settings?
304 2018-01-17T12:37:15  <gmaxwell> (I'm asking, no strong opinions)
305 2018-01-17T12:37:19  <meshcollider> are we planning on removing it in 0.17?
306 2018-01-17T12:37:29  *** wacawacawaca has joined #bitcoin-core-dev
307 2018-01-17T12:37:40  <wumpus> I was assuming it would be removed in next major release, if not, should update the release notes :)
308 2018-01-17T12:37:57  <meshcollider> It should be a trivial transition for most use cases I'd imagine, and it was always advertised as experimental so I'd say its fine how it is
309 2018-01-17T12:38:02  <wumpus> waiting another release and going for 0.18 is fine with me too
310 2018-01-17T12:38:09  <gmaxwell> yea, I suppose! if we're going to remove it in 0.17 then the disruptive choice is probably the right one.
311 2018-01-17T12:38:24  <meshcollider> nah it shouldn't have gained enough use in this short timeframe to be necessary waiting another whole release
312 2018-01-17T12:38:30  <meshcollider> i vote remove in 17
313 2018-01-17T12:38:54  <gmaxwell> strangly I don't feel any cosmic force hurrying the removal of no-op RPCs.  Perhaps one GOOD argument for going faster is this: people are going to keep following old "how to segwit" guides.
314 2018-01-17T12:39:15  *** Guyver2 has joined #bitcoin-core-dev
315 2018-01-17T12:39:34  <wumpus> gmaxwell: which is another good reason to use the IsDeprecatedRPCEnabled()  stuff, I guess, as otherwise it will seem to just keep working a s intended
316 2018-01-17T12:39:49  <gmaxwell> yes, exactly, sorry "going faster" wasn't clear.
317 2018-01-17T12:39:59  <meshcollider> yeah users tend to ignore help text even if it is in caps ;)
318 2018-01-17T12:40:12  <gmaxwell> banner blindness.
319 2018-01-17T12:40:30  <wumpus> well, more that they'll not look at the help if they 'help' is some online or wiki guide
320 2018-01-17T12:41:53  <gmaxwell> right, which is why its important to fail.  I would sort of like if in general we start breaking interfaces a little faster, at least until we cause complaints. we've gone to far in the never breaking things direction for too long. :) and IsDeprecatedRPCEnabled is a pretty nice middle ground.
321 2018-01-17T12:42:25  *** gaf_ has joined #bitcoin-core-dev
322 2018-01-17T12:44:09  *** goatpig has joined #bitcoin-core-dev
323 2018-01-17T12:55:13  *** promag has quit IRC
324 2018-01-17T12:55:46  *** UnderDog_ has joined #bitcoin-core-dev
325 2018-01-17T12:56:04  <UnderDog_> good morning
326 2018-01-17T12:56:12  *** moctost has joined #bitcoin-core-dev
327 2018-01-17T12:57:09  <meshcollider> UnderDog_: maybe for some ;)
328 2018-01-17T12:57:25  *** AaronvanW has quit IRC
329 2018-01-17T12:57:31  <UnderDog_> work got cancled today
330 2018-01-17T12:57:34  <UnderDog_> bad freeze
331 2018-01-17T12:58:08  <UnderDog_> i still woke up at 4am and so i decided to make a whiskey and do laundry
332 2018-01-17T12:59:01  *** d9b4bef9 has quit IRC
333 2018-01-17T12:59:45  <UnderDog_> i haven't used IRC in almost 20 years
334 2018-01-17T13:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
335 2018-01-17T13:00:29  *** CubicEarths has joined #bitcoin-core-dev
336 2018-01-17T13:00:30  <meshcollider> UnderDog_: I think you might be in the wrong channel, maybe try #bitcoin for general discussion on it, this channel is just for bitcoin core development
337 2018-01-17T13:01:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
338 2018-01-17T13:01:05  *** anome has quit IRC
339 2018-01-17T13:02:22  <UnderDog_> well i'm not part of the development team but I did not see another IRC available and thought I might be likely to find similar persons of interest here.
340 2018-01-17T13:03:31  <sipa> #bitcoin may be a better place
341 2018-01-17T13:04:19  <UnderDog_> ok
342 2018-01-17T13:05:02  *** CubicEarths has quit IRC
343 2018-01-17T13:05:11  <UnderDog_> only think I might be able to help with is thermodynamic's and heat extraction designs for your servers
344 2018-01-17T13:05:27  <UnderDog_> no need ofr  's
345 2018-01-17T13:05:29  <UnderDog_> for*
346 2018-01-17T13:08:52  *** JackH has joined #bitcoin-core-dev
347 2018-01-17T13:10:35  *** UnderDog_ has quit IRC
348 2018-01-17T13:11:46  *** atroxes has quit IRC
349 2018-01-17T13:12:00  *** atroxes has joined #bitcoin-core-dev
350 2018-01-17T13:12:28  *** dermoth has joined #bitcoin-core-dev
351 2018-01-17T13:12:38  *** atroxes has quit IRC
352 2018-01-17T13:12:58  *** atroxes has joined #bitcoin-core-dev
353 2018-01-17T13:24:44  *** AaronvanW has joined #bitcoin-core-dev
354 2018-01-17T13:24:56  *** echelon has quit IRC
355 2018-01-17T13:25:42  *** echelon has joined #bitcoin-core-dev
356 2018-01-17T13:25:51  *** wtabata has quit IRC
357 2018-01-17T13:26:52  *** wtabata has joined #bitcoin-core-dev
358 2018-01-17T13:31:20  *** Jaiden19Jakubows has quit IRC
359 2018-01-17T13:34:02  *** CubicEarths has joined #bitcoin-core-dev
360 2018-01-17T13:38:39  *** CubicEarths has quit IRC
361 2018-01-17T13:45:15  *** keks has joined #bitcoin-core-dev
362 2018-01-17T13:51:48  *** laurentmt has joined #bitcoin-core-dev
363 2018-01-17T13:52:56  *** laurentmt has quit IRC
364 2018-01-17T14:00:30  *** intcat has quit IRC
365 2018-01-17T14:04:02  *** intcat has joined #bitcoin-core-dev
366 2018-01-17T14:06:43  *** waseem has joined #bitcoin-core-dev
367 2018-01-17T14:07:55  <waseem>  /UNIGNORE a5m0
368 2018-01-17T14:08:14  *** waseem has quit IRC
369 2018-01-17T14:09:48  *** laurentmt has joined #bitcoin-core-dev
370 2018-01-17T14:12:26  *** CubicEarths has joined #bitcoin-core-dev
371 2018-01-17T14:13:01  *** piedpiper has joined #bitcoin-core-dev
372 2018-01-17T14:13:08  *** Walton89Wisozk has joined #bitcoin-core-dev
373 2018-01-17T14:14:10  *** piedpiper is now known as PiedPiper
374 2018-01-17T14:14:18  *** PiedPiper has left #bitcoin-core-dev
375 2018-01-17T14:14:53  *** PiedPiper has joined #bitcoin-core-dev
376 2018-01-17T14:15:44  *** AriseChikun has joined #bitcoin-core-dev
377 2018-01-17T14:16:35  *** CubicEarths has quit IRC
378 2018-01-17T14:18:57  *** ma1210 has joined #bitcoin-core-dev
379 2018-01-17T14:19:45  *** Chris_Stewart_5 has quit IRC
380 2018-01-17T14:19:57  *** ma1210 has quit IRC
381 2018-01-17T14:21:51  *** PiedPiper has quit IRC
382 2018-01-17T14:22:02  *** PiedPiper has joined #bitcoin-core-dev
383 2018-01-17T14:23:59  *** Walton89Wisozk has quit IRC
384 2018-01-17T14:24:35  *** echelon has quit IRC
385 2018-01-17T14:26:05  *** echelon has joined #bitcoin-core-dev
386 2018-01-17T14:31:21  *** anome has joined #bitcoin-core-dev
387 2018-01-17T14:36:56  *** satwo has quit IRC
388 2018-01-17T14:42:19  *** echelon has quit IRC
389 2018-01-17T14:43:26  *** AaronvanW has quit IRC
390 2018-01-17T14:46:30  *** Giszmo has joined #bitcoin-core-dev
391 2018-01-17T14:48:23  *** jtimon has joined #bitcoin-core-dev
392 2018-01-17T14:49:05  *** promag has joined #bitcoin-core-dev
393 2018-01-17T14:54:10  *** AaronvanW has joined #bitcoin-core-dev
394 2018-01-17T14:54:27  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
395 2018-01-17T14:54:56  *** Cogito_Ergo_Sum has quit IRC
396 2018-01-17T14:55:11  *** echelon has joined #bitcoin-core-dev
397 2018-01-17T14:55:43  *** Aaronvan_ has joined #bitcoin-core-dev
398 2018-01-17T14:56:10  *** Victorsueca has quit IRC
399 2018-01-17T14:57:22  *** Victorsueca has joined #bitcoin-core-dev
400 2018-01-17T14:58:37  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
401 2018-01-17T14:58:37  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
402 2018-01-17T14:58:38  *** AaronvanW has quit IRC
403 2018-01-17T15:01:59  *** zautomata has quit IRC
404 2018-01-17T15:02:35  *** echelon has quit IRC
405 2018-01-17T15:02:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
406 2018-01-17T15:11:45  *** PiedPiper has quit IRC
407 2018-01-17T15:12:20  *** PiedPiper has joined #bitcoin-core-dev
408 2018-01-17T15:13:08  *** Duncan27Auer has joined #bitcoin-core-dev
409 2018-01-17T15:14:26  *** eck has joined #bitcoin-core-dev
410 2018-01-17T15:14:49  *** SopaXorzTaker has joined #bitcoin-core-dev
411 2018-01-17T15:18:45  *** Pritty_Kitty has joined #bitcoin-core-dev
412 2018-01-17T15:19:38  *** marku_ has joined #bitcoin-core-dev
413 2018-01-17T15:23:13  *** Pritty_Kitty has quit IRC
414 2018-01-17T15:23:13  *** Duncan27Auer has quit IRC
415 2018-01-17T15:23:18  *** promag has quit IRC
416 2018-01-17T15:23:19  *** marku_ is now known as Pritty_Kitty
417 2018-01-17T15:27:55  <Pritty_Kitty> Hello and thank you to all good Core developers for what you do.
418 2018-01-17T15:28:03  <Pritty_Kitty> I'm trying to learn the system and use it but hope to get answer for a question:
419 2018-01-17T15:28:12  <Pritty_Kitty> I have a 0.15.1 node with a "testnet=true" setting. getblocktemplate gives me a template where "txid" and "hash" field are identical for transaction.
420 2018-01-17T15:28:19  <Pritty_Kitty> Should they not be different for SegWit is running on testnet?
421 2018-01-17T15:28:29  <Pritty_Kitty> Will i use the "hash" field to create my witness hash tree and put a commit in my coinbase value? Do i put this commit value AFTER the BIP34 blockheight value?
422 2018-01-17T15:29:32  <Pritty_Kitty> I am trying to make blocks.
423 2018-01-17T15:29:48  <Pritty_Kitty> I want them SegWit compatible
424 2018-01-17T15:31:30  *** Giszmo has quit IRC
425 2018-01-17T15:33:21  *** eck has quit IRC
426 2018-01-17T15:33:40  *** lnostdal has quit IRC
427 2018-01-17T15:44:37  *** promag has joined #bitcoin-core-dev
428 2018-01-17T15:45:49  *** promag has quit IRC
429 2018-01-17T15:46:27  *** CubicEarths has joined #bitcoin-core-dev
430 2018-01-17T15:51:29  *** CubicEarths has quit IRC
431 2018-01-17T15:53:47  *** promag has joined #bitcoin-core-dev
432 2018-01-17T15:53:57  *** echelon has joined #bitcoin-core-dev
433 2018-01-17T15:57:41  *** Aaronvan_ is now known as AaronvanW
434 2018-01-17T16:00:48  *** Giszmo has joined #bitcoin-core-dev
435 2018-01-17T16:01:35  *** meshcollider has quit IRC
436 2018-01-17T16:03:42  *** AaronvanW has quit IRC
437 2018-01-17T16:04:19  *** AaronvanW has joined #bitcoin-core-dev
438 2018-01-17T16:06:28  <wxss> t
439 2018-01-17T16:08:50  *** AaronvanW has quit IRC
440 2018-01-17T16:08:50  *** wtabata has quit IRC
441 2018-01-17T16:09:14  *** wtabata has joined #bitcoin-core-dev
442 2018-01-17T16:13:08  *** Layla19Tillman has joined #bitcoin-core-dev
443 2018-01-17T16:14:40  *** jtimon has quit IRC
444 2018-01-17T16:15:56  *** dermoth has quit IRC
445 2018-01-17T16:16:41  *** dermoth has joined #bitcoin-core-dev
446 2018-01-17T16:17:50  *** Layla19Tillman has quit IRC
447 2018-01-17T16:20:19  *** AaronvanW has joined #bitcoin-core-dev
448 2018-01-17T16:24:11  *** AaronvanW has quit IRC
449 2018-01-17T16:24:29  *** AaronvanW has joined #bitcoin-core-dev
450 2018-01-17T16:25:01  *** CubicEarths has joined #bitcoin-core-dev
451 2018-01-17T16:25:58  <Randolf> Pritty_Kitty:  You seem to be asking a "how to use Bitcoin" type of question.  You'll likely find that such questions are better suited for the #bitcoin channel as this one you're asking in now is specifically focused on Bitcoin core software development.
452 2018-01-17T16:29:10  *** wraithm has joined #bitcoin-core-dev
453 2018-01-17T16:29:20  *** CubicEarths has quit IRC
454 2018-01-17T16:30:43  *** Emcy has quit IRC
455 2018-01-17T16:31:14  *** Emcy has joined #bitcoin-core-dev
456 2018-01-17T16:33:41  *** jb55 has quit IRC
457 2018-01-17T16:38:42  *** CubicEarths has joined #bitcoin-core-dev
458 2018-01-17T16:43:13  *** CubicEarths has quit IRC
459 2018-01-17T16:46:10  *** intcat has quit IRC
460 2018-01-17T16:47:44  *** jb55 has joined #bitcoin-core-dev
461 2018-01-17T16:48:21  *** intcat has joined #bitcoin-core-dev
462 2018-01-17T16:48:30  *** mhnd has joined #bitcoin-core-dev
463 2018-01-17T16:52:29  *** Randolf has quit IRC
464 2018-01-17T16:57:01  *** d9b4bef9 has quit IRC
465 2018-01-17T16:58:08  *** d9b4bef9 has joined #bitcoin-core-dev
466 2018-01-17T16:59:02  *** d9b4bef9 has quit IRC
467 2018-01-17T17:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
468 2018-01-17T17:01:52  *** anome has quit IRC
469 2018-01-17T17:02:15  *** CubicEarths has joined #bitcoin-core-dev
470 2018-01-17T17:02:24  *** AaronvanW has quit IRC
471 2018-01-17T17:06:01  *** marku_ has joined #bitcoin-core-dev
472 2018-01-17T17:06:17  *** anome has joined #bitcoin-core-dev
473 2018-01-17T17:07:07  *** CubicEarths has quit IRC
474 2018-01-17T17:08:04  *** daouzo23 has joined #bitcoin-core-dev
475 2018-01-17T17:08:45  *** Pritty_Kitty has quit IRC
476 2018-01-17T17:08:53  *** marku_ is now known as Pritty_Kitty
477 2018-01-17T17:09:48  *** mandric has joined #bitcoin-core-dev
478 2018-01-17T17:10:29  *** Giszmo has quit IRC
479 2018-01-17T17:11:10  *** Randolf has joined #bitcoin-core-dev
480 2018-01-17T17:13:07  *** Roel41Schinner has joined #bitcoin-core-dev
481 2018-01-17T17:15:17  <Pritty_Kitty> No no i am a developer asking technical questions about bitcoin. I have built php code to deserialize transactions and build a merkle tree. Now i am working on the witness tree.
482 2018-01-17T17:17:00  <Pritty_Kitty> But i could just mine regular blocks without SegWit. But I know you want SegWit so i hope for answers to my questions
483 2018-01-17T17:17:56  *** flokie has quit IRC
484 2018-01-17T17:18:13  *** Roel41Schinner has quit IRC
485 2018-01-17T17:18:28  *** hirishaway is now known as hirish
486 2018-01-17T17:20:35  *** Cogito_Ergo_Sum has quit IRC
487 2018-01-17T17:21:39  *** StopAndDecrypt has quit IRC
488 2018-01-17T17:23:06  <instagibbs> Pritty_Kitty, this isn't a question for Bitcoin Core development though. maybe #bitcoin-dev
489 2018-01-17T17:23:27  <Pritty_Kitty> ok ty i will try there
490 2018-01-17T17:23:53  *** AaronvanW has joined #bitcoin-core-dev
491 2018-01-17T17:24:57  *** owowo has quit IRC
492 2018-01-17T17:25:03  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
493 2018-01-17T17:25:03  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
494 2018-01-17T17:25:19  *** Pritty_Kitty has left #bitcoin-core-dev
495 2018-01-17T17:26:14  *** daouzo23 has quit IRC
496 2018-01-17T17:29:30  *** AaronvanW has quit IRC
497 2018-01-17T17:29:45  *** owowo has joined #bitcoin-core-dev
498 2018-01-17T17:29:46  *** owowo has joined #bitcoin-core-dev
499 2018-01-17T17:30:31  *** intcat has quit IRC
500 2018-01-17T17:31:04  *** Victorsueca has quit IRC
501 2018-01-17T17:31:31  *** intcat has joined #bitcoin-core-dev
502 2018-01-17T17:32:22  *** Victorsueca has joined #bitcoin-core-dev
503 2018-01-17T17:33:54  *** Arise2 has joined #bitcoin-core-dev
504 2018-01-17T17:33:56  *** goksinen has quit IRC
505 2018-01-17T17:33:57  *** AriseChikun has quit IRC
506 2018-01-17T17:35:57  *** promag has quit IRC
507 2018-01-17T17:38:21  *** AaronvanW has joined #bitcoin-core-dev
508 2018-01-17T17:39:32  *** PiedPiper has left #bitcoin-core-dev
509 2018-01-17T17:39:42  *** PiedPiper has joined #bitcoin-core-dev
510 2018-01-17T17:39:52  *** AaronvanW has quit IRC
511 2018-01-17T17:40:30  *** CubicEarths has joined #bitcoin-core-dev
512 2018-01-17T17:41:09  *** AaronvanW has joined #bitcoin-core-dev
513 2018-01-17T17:41:52  *** AaronvanW has quit IRC
514 2018-01-17T17:44:26  *** mrannanay has quit IRC
515 2018-01-17T17:45:20  *** CubicEarths has quit IRC
516 2018-01-17T17:49:45  *** eck has joined #bitcoin-core-dev
517 2018-01-17T17:53:28  *** timothy has quit IRC
518 2018-01-17T17:58:18  *** mrannanay has joined #bitcoin-core-dev
519 2018-01-17T17:59:15  *** moctost has quit IRC
520 2018-01-17T18:05:04  *** eenoch has quit IRC
521 2018-01-17T18:11:24  *** JC has joined #bitcoin-core-dev
522 2018-01-17T18:13:08  *** Odessa20Kautzer has joined #bitcoin-core-dev
523 2018-01-17T18:15:50  *** JC has quit IRC
524 2018-01-17T18:15:53  *** Dr10450 has joined #bitcoin-core-dev
525 2018-01-17T18:16:02  *** mhnd has quit IRC
526 2018-01-17T18:17:35  *** Odessa20Kautzer has quit IRC
527 2018-01-17T18:18:09  *** DoC10450 has quit IRC
528 2018-01-17T18:21:05  *** jtimon has joined #bitcoin-core-dev
529 2018-01-17T18:21:47  *** satwo has joined #bitcoin-core-dev
530 2018-01-17T18:25:41  *** SopaXT has joined #bitcoin-core-dev
531 2018-01-17T18:25:56  *** daouzo23 has joined #bitcoin-core-dev
532 2018-01-17T18:26:05  *** SopaXorzTaker has quit IRC
533 2018-01-17T18:27:03  *** daouzo23 has quit IRC
534 2018-01-17T18:28:05  *** SopaXT has quit IRC
535 2018-01-17T18:28:25  *** dermoth has quit IRC
536 2018-01-17T18:28:29  *** SopaXT has joined #bitcoin-core-dev
537 2018-01-17T18:30:21  *** PotentiallyGreat has quit IRC
538 2018-01-17T18:30:29  *** dermoth has joined #bitcoin-core-dev
539 2018-01-17T18:30:49  <bitcoin-git> [bitcoin] ryanofsky opened pull request #12211: Avoid potential null dereference in ReceiveCoinsDialog constructor (master...pr/nullrecv) https://github.com/bitcoin/bitcoin/pull/12211
540 2018-01-17T18:33:52  *** dermoth has quit IRC
541 2018-01-17T18:34:23  *** Emcy_ has joined #bitcoin-core-dev
542 2018-01-17T18:34:27  *** dermoth has joined #bitcoin-core-dev
543 2018-01-17T18:35:54  *** SopaXorzTaker has joined #bitcoin-core-dev
544 2018-01-17T18:37:40  *** SopaXT has quit IRC
545 2018-01-17T18:38:09  *** Emcy has quit IRC
546 2018-01-17T18:38:09  *** vicenteH has quit IRC
547 2018-01-17T18:41:57  *** Deacyde has joined #bitcoin-core-dev
548 2018-01-17T18:44:08  *** daouzo23 has joined #bitcoin-core-dev
549 2018-01-17T18:53:54  *** larafale has quit IRC
550 2018-01-17T18:54:31  *** larafale has joined #bitcoin-core-dev
551 2018-01-17T18:54:47  *** mandric_ has joined #bitcoin-core-dev
552 2018-01-17T18:55:13  *** CubicEarths has joined #bitcoin-core-dev
553 2018-01-17T18:56:53  *** mandric has quit IRC
554 2018-01-17T18:58:57  *** larafale has quit IRC
555 2018-01-17T18:59:23  *** ohnx has quit IRC
556 2018-01-17T19:00:10  *** Scrat has joined #bitcoin-core-dev
557 2018-01-17T19:03:42  *** ohnx- has joined #bitcoin-core-dev
558 2018-01-17T19:03:50  *** daouzo23 has quit IRC
559 2018-01-17T19:05:19  *** harrymm has joined #bitcoin-core-dev
560 2018-01-17T19:05:26  *** owowo has quit IRC
561 2018-01-17T19:05:39  *** Emcy_ has quit IRC
562 2018-01-17T19:06:17  *** Emcy_ has joined #bitcoin-core-dev
563 2018-01-17T19:06:35  *** harrymm_ has quit IRC
564 2018-01-17T19:09:33  *** PiedPiper has quit IRC
565 2018-01-17T19:09:46  *** Giszmo has joined #bitcoin-core-dev
566 2018-01-17T19:09:52  *** PiedPiper has joined #bitcoin-core-dev
567 2018-01-17T19:10:23  *** owowo has joined #bitcoin-core-dev
568 2018-01-17T19:10:47  *** PiedPiper has quit IRC
569 2018-01-17T19:10:58  *** PiedPiper has joined #bitcoin-core-dev
570 2018-01-17T19:11:05  *** jb55 has quit IRC
571 2018-01-17T19:12:46  *** PiedPiper has quit IRC
572 2018-01-17T19:13:07  *** Anya20Hayes has joined #bitcoin-core-dev
573 2018-01-17T19:15:13  *** PiedPiper has joined #bitcoin-core-dev
574 2018-01-17T19:15:48  *** twoken has quit IRC
575 2018-01-17T19:18:12  *** Anya20Hayes has quit IRC
576 2018-01-17T19:20:00  *** ohnx- is now known as ohnx
577 2018-01-17T19:20:37  *** PiedPiper has quit IRC
578 2018-01-17T19:20:48  *** PiedPiper has joined #bitcoin-core-dev
579 2018-01-17T19:22:40  *** Emcy has joined #bitcoin-core-dev
580 2018-01-17T19:23:46  *** twoken has joined #bitcoin-core-dev
581 2018-01-17T19:24:48  *** ghost43 has quit IRC
582 2018-01-17T19:24:49  *** intcat has quit IRC
583 2018-01-17T19:25:33  *** Emcy_ has quit IRC
584 2018-01-17T19:26:15  *** intcat has joined #bitcoin-core-dev
585 2018-01-17T19:26:17  *** ghost43 has joined #bitcoin-core-dev
586 2018-01-17T19:30:57  *** wumpus has quit IRC
587 2018-01-17T19:32:31  *** wumpus has joined #bitcoin-core-dev
588 2018-01-17T19:32:45  *** Giszmo has quit IRC
589 2018-01-17T19:36:04  *** harrymm_ has joined #bitcoin-core-dev
590 2018-01-17T19:37:57  *** harrymm has quit IRC
591 2018-01-17T19:38:51  *** belcher has joined #bitcoin-core-dev
592 2018-01-17T19:39:05  *** aj has quit IRC
593 2018-01-17T20:00:30  *** lightningbot has joined #bitcoin-core-dev
594 2018-01-17T20:00:55  <jojeyh> Can anyboyd give me a brief explanation for "struct zero_after_free_allocator" ?
595 2018-01-17T20:01:19  <jojeyh> What is the point of this object instead of a traditional std::allocator ?
596 2018-01-17T20:01:27  *** vghy has joined #bitcoin-core-dev
597 2018-01-17T20:01:33  *** Giszmo has quit IRC
598 2018-01-17T20:01:50  <jojeyh> in file "bitcoin/src/support/allocators/zeroafterfree.h"
599 2018-01-17T20:02:08  *** vghy has quit IRC
600 2018-01-17T20:02:09  *** Evel-Knievel has quit IRC
601 2018-01-17T20:02:26  *** daouzo235 has joined #bitcoin-core-dev
602 2018-01-17T20:02:26  *** Evel-Knievel has joined #bitcoin-core-dev
603 2018-01-17T20:04:29  *** daouzo23 has quit IRC
604 2018-01-17T20:06:38  <luke-jr> jojeyh: std::allocator probably doesn't zero when freeing
605 2018-01-17T20:06:50  <jojeyh> can you explain what this means?
606 2018-01-17T20:06:53  <luke-jr> jojeyh: in other words, it leaves the data in memory
607 2018-01-17T20:07:20  <luke-jr> which means when something else is allocated (hypothetically even in another program), it might have the data in its new memory
608 2018-01-17T20:07:28  <jojeyh> luke-jr: ok, so basically if a std::allocator were used then even after the memory is freed the bits will still be nonzero ?
609 2018-01-17T20:07:34  <luke-jr> right
610 2018-01-17T20:07:42  <jojeyh> k thanks
611 2018-01-17T20:08:01  <luke-jr> this is particularly bad if the memory might contain private key or passphrase info
612 2018-01-17T20:08:36  <jojeyh> ah that makes sense
613 2018-01-17T20:10:44  *** ohnx has quit IRC
614 2018-01-17T20:10:56  *** ohnx has joined #bitcoin-core-dev
615 2018-01-17T20:13:08  *** Lynn39Sanford has joined #bitcoin-core-dev
616 2018-01-17T20:15:15  *** daouzo235 has quit IRC
617 2018-01-17T20:16:05  *** Giszmo has joined #bitcoin-core-dev
618 2018-01-17T20:21:14  *** Lynn39Sanford has quit IRC
619 2018-01-17T20:27:39  *** Cogito_Ergo_Sum has quit IRC
620 2018-01-17T20:30:01  *** SopaXorzTaker has quit IRC
621 2018-01-17T20:35:32  *** daouzo235 has joined #bitcoin-core-dev
622 2018-01-17T20:41:23  *** mandric_ has quit IRC
623 2018-01-17T20:42:03  *** Giszmo has quit IRC
624 2018-01-17T20:48:19  *** eck has quit IRC
625 2018-01-17T20:53:59  *** daouzo235 has quit IRC
626 2018-01-17T20:54:29  *** daouzo235 has joined #bitcoin-core-dev
627 2018-01-17T20:55:24  *** lnostdal has joined #bitcoin-core-dev
628 2018-01-17T21:00:50  *** PiedPiper has joined #bitcoin-core-dev
629 2018-01-17T21:06:36  *** BashCo has quit IRC
630 2018-01-17T21:12:51  *** anome has quit IRC
631 2018-01-17T21:13:02  *** PiedPiper has quit IRC
632 2018-01-17T21:13:07  *** Flavio12Hilpert has joined #bitcoin-core-dev
633 2018-01-17T21:13:17  *** PiedPiper has joined #bitcoin-core-dev
634 2018-01-17T21:14:29  *** PiedPiper has quit IRC
635 2018-01-17T21:14:52  *** PiedPiper has joined #bitcoin-core-dev
636 2018-01-17T21:16:03  *** bule has joined #bitcoin-core-dev
637 2018-01-17T21:17:59  *** Flavio12Hilpert has quit IRC
638 2018-01-17T21:22:18  *** Dizzle has joined #bitcoin-core-dev
639 2018-01-17T21:24:06  *** BashCo has joined #bitcoin-core-dev
640 2018-01-17T21:30:46  *** promag has joined #bitcoin-core-dev
641 2018-01-17T21:40:15  *** mandric has joined #bitcoin-core-dev
642 2018-01-17T21:44:14  *** shesek has joined #bitcoin-core-dev
643 2018-01-17T21:44:14  *** shesek has joined #bitcoin-core-dev
644 2018-01-17T21:53:01  *** meshcollider has joined #bitcoin-core-dev
645 2018-01-17T21:59:38  *** lio17 has quit IRC
646 2018-01-17T21:59:41  *** mandric has quit IRC
647 2018-01-17T22:02:52  *** PiedPiper has quit IRC
648 2018-01-17T22:03:06  *** PiedPiper has joined #bitcoin-core-dev
649 2018-01-17T22:03:14  *** bitzap has joined #bitcoin-core-dev
650 2018-01-17T22:04:17  *** harrymm_ has quit IRC
651 2018-01-17T22:10:22  *** goksinen has joined #bitcoin-core-dev
652 2018-01-17T22:13:08  *** Eulah88Witting has joined #bitcoin-core-dev
653 2018-01-17T22:16:34  *** harrymm_ has joined #bitcoin-core-dev
654 2018-01-17T22:16:40  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
655 2018-01-17T22:17:35  *** Eulah88Witting has quit IRC
656 2018-01-17T22:18:09  *** lio17 has joined #bitcoin-core-dev
657 2018-01-17T22:23:39  *** daouzo235 has quit IRC
658 2018-01-17T22:38:27  <bitcoin-git> [bitcoin] bitspill opened pull request #12212: fix spelling (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12212
659 2018-01-17T22:40:16  <mrannanay> #11227 seems to have both milestones covered. Needs rebase.
660 2018-01-17T22:40:19  <gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
661 2018-01-17T22:42:35  *** Dizzle has quit IRC
662 2018-01-17T22:42:52  *** lio1754 has joined #bitcoin-core-dev
663 2018-01-17T22:44:14  *** wacawacawaca has quit IRC
664 2018-01-17T22:44:23  *** lio17 has quit IRC
665 2018-01-17T22:47:22  *** Victorsueca has quit IRC
666 2018-01-17T22:48:38  *** Victorsueca has joined #bitcoin-core-dev
667 2018-01-17T22:49:15  *** wacawacawaca has joined #bitcoin-core-dev
668 2018-01-17T22:50:11  <promag> sipa: addmultisigaddress should have address_type option?
669 2018-01-17T22:56:09  *** Randolf has quit IRC
670 2018-01-17T22:56:57  *** jb55 has quit IRC
671 2018-01-17T23:01:29  *** jojeyh has quit IRC
672 2018-01-17T23:04:59  *** bule2 has joined #bitcoin-core-dev
673 2018-01-17T23:05:47  *** shesek has quit IRC
674 2018-01-17T23:07:09  *** Guyver2 has quit IRC
675 2018-01-17T23:07:42  *** bule has quit IRC
676 2018-01-17T23:12:54  *** goksinen has quit IRC
677 2018-01-17T23:13:07  *** Rodolfo42Boehm has joined #bitcoin-core-dev
678 2018-01-17T23:16:49  *** lio175456 has joined #bitcoin-core-dev
679 2018-01-17T23:18:45  *** lio1754 has quit IRC
680 2018-01-17T23:21:25  *** gwillen has joined #bitcoin-core-dev
681 2018-01-17T23:23:14  *** anome has joined #bitcoin-core-dev
682 2018-01-17T23:30:09  *** anome has quit IRC
683 2018-01-17T23:30:37  *** anome has joined #bitcoin-core-dev
684 2018-01-17T23:31:21  *** netcraftdev has joined #bitcoin-core-dev
685 2018-01-17T23:32:20  *** netcraftdev has joined #bitcoin-core-dev
686 2018-01-17T23:33:50  *** netcraftdev has left #bitcoin-core-dev
687 2018-01-17T23:39:11  *** Chris_Stewart_5 has quit IRC
688 2018-01-17T23:40:48  <bitcoin-git> [bitcoin] promag opened pull request #12213: 2018 01 addmultisigaddress address type (master...2018-01-addmultisigaddress-address-type) https://github.com/bitcoin/bitcoin/pull/12213
689 2018-01-17T23:42:53  *** JackH has quit IRC
690 2018-01-17T23:45:32  *** ula has joined #bitcoin-core-dev
691 2018-01-17T23:47:13  *** jb55 has joined #bitcoin-core-dev
692 2018-01-17T23:51:16  *** anome has quit IRC
693 2018-01-17T23:52:22  *** AaronvanW has joined #bitcoin-core-dev
694 2018-01-17T23:55:23  *** belcher has quit IRC
695 2018-01-17T23:57:57  *** wxss has quit IRC
696 2018-01-17T23:58:00  *** Cogito_Ergo_Sum has quit IRC
697 2018-01-17T23:58:45  *** wacawacawaca has quit IRC