1 2018-01-24T00:06:33  *** afilini has quit IRC
  2 2018-01-24T00:10:02  *** leec has joined #bitcoin-core-dev
  3 2018-01-24T00:10:22  *** dermoth has joined #bitcoin-core-dev
  4 2018-01-24T00:12:50  *** dermoth has quit IRC
  5 2018-01-24T00:13:22  *** PaulCapestany has quit IRC
  6 2018-01-24T00:13:28  *** leec has quit IRC
  7 2018-01-24T00:13:49  *** dermoth has joined #bitcoin-core-dev
  8 2018-01-24T00:14:21  *** Chris_Stewart_5 has quit IRC
  9 2018-01-24T00:19:57  *** afilini has joined #bitcoin-core-dev
 10 2018-01-24T00:21:28  *** Tennis has quit IRC
 11 2018-01-24T00:27:06  *** mandric has joined #bitcoin-core-dev
 12 2018-01-24T00:27:24  *** afilini has quit IRC
 13 2018-01-24T00:32:45  *** shesek has quit IRC
 14 2018-01-24T00:32:55  *** larafale_ has quit IRC
 15 2018-01-24T00:33:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 16 2018-01-24T00:40:44  *** PaulCapestany has joined #bitcoin-core-dev
 17 2018-01-24T00:43:36  *** Sinclair6 has joined #bitcoin-core-dev
 18 2018-01-24T00:46:18  *** shesek has joined #bitcoin-core-dev
 19 2018-01-24T00:46:18  *** shesek has joined #bitcoin-core-dev
 20 2018-01-24T00:52:31  *** dermoth has quit IRC
 21 2018-01-24T00:53:16  *** Murch has quit IRC
 22 2018-01-24T00:53:26  *** Chris_Stewart_5 has quit IRC
 23 2018-01-24T00:57:47  *** dabura667 has joined #bitcoin-core-dev
 24 2018-01-24T01:09:19  *** Cory has quit IRC
 25 2018-01-24T01:11:47  *** PaulCape_ has joined #bitcoin-core-dev
 26 2018-01-24T01:12:00  *** PaulCapestany has quit IRC
 27 2018-01-24T01:19:32  *** PaulCape_ has quit IRC
 28 2018-01-24T01:25:34  *** vigorousbearhunt has quit IRC
 29 2018-01-24T01:27:34  *** niska has quit IRC
 30 2018-01-24T01:37:35  *** niska has joined #bitcoin-core-dev
 31 2018-01-24T01:37:55  *** harrymm_ has quit IRC
 32 2018-01-24T01:39:36  *** PaulCapestany has joined #bitcoin-core-dev
 33 2018-01-24T01:42:19  <bitcoin-git> [bitcoin] jimpo opened pull request #12254: BIP 158: Compact Block Filters for Light Clients (master...bip-158) https://github.com/bitcoin/bitcoin/pull/12254
 34 2018-01-24T01:46:29  *** goatpig has quit IRC
 35 2018-01-24T01:50:39  *** mandric has quit IRC
 36 2018-01-24T01:51:09  *** harrymm_ has joined #bitcoin-core-dev
 37 2018-01-24T01:54:10  *** r00tc0in has quit IRC
 38 2018-01-24T01:56:20  *** PaulCapestany has quit IRC
 39 2018-01-24T01:58:36  <phantomcircuit> jimpo, can you make it so the individual commits in 12254 actually work independently?
 40 2018-01-24T01:58:57  <phantomcircuit> pr's like that where the individual commits result in broken code make things like bisect less useful
 41 2018-01-24T01:59:10  *** PaulCapestany has joined #bitcoin-core-dev
 42 2018-01-24T02:08:33  <jimpo> I thought they do. What one breaks the build?
 43 2018-01-24T02:15:10  *** promag has quit IRC
 44 2018-01-24T02:19:25  <phantomcircuit> jimpo, hmm yeah you're right that it doesn't actually, my mistake
 45 2018-01-24T02:19:43  <phantomcircuit> still kind of odd to define interfaces in one commit and then implement them in several others i think
 46 2018-01-24T02:19:48  <phantomcircuit> but maybe that's just me
 47 2018-01-24T02:22:55  *** dcousens has quit IRC
 48 2018-01-24T02:27:24  <jimpo> Yeah, that's just sort of what made the most sense to me as far as trying to communicate why code is happening. Basically, it's just a lot of new code and I wanted to break it up somehow.
 49 2018-01-24T02:38:52  *** Sinclair6 has quit IRC
 50 2018-01-24T02:42:17  *** Chicago has quit IRC
 51 2018-01-24T02:46:02  *** promag has joined #bitcoin-core-dev
 52 2018-01-24T02:49:38  *** DoC10450 has quit IRC
 53 2018-01-24T03:22:23  *** Sinclai__ has joined #bitcoin-core-dev
 54 2018-01-24T03:26:05  *** belcher has quit IRC
 55 2018-01-24T03:26:45  *** givanse has quit IRC
 56 2018-01-24T03:39:57  *** Giszmo has quit IRC
 57 2018-01-24T03:42:11  *** Giszmo has joined #bitcoin-core-dev
 58 2018-01-24T04:00:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 59 2018-01-24T04:10:22  *** Giszmo has quit IRC
 60 2018-01-24T04:10:25  *** Cory has joined #bitcoin-core-dev
 61 2018-01-24T04:14:14  *** ProfMac has quit IRC
 62 2018-01-24T04:31:11  *** dcousens has joined #bitcoin-core-dev
 63 2018-01-24T04:33:56  *** ProfMac has joined #bitcoin-core-dev
 64 2018-01-24T04:33:57  *** contrapumpkin has quit IRC
 65 2018-01-24T04:34:19  *** flokie has quit IRC
 66 2018-01-24T04:34:42  *** flokie has joined #bitcoin-core-dev
 67 2018-01-24T04:36:37  *** propumpkin has joined #bitcoin-core-dev
 68 2018-01-24T04:43:11  *** jtimon has quit IRC
 69 2018-01-24T05:10:43  *** Chris_Stewart_5 has quit IRC
 70 2018-01-24T05:23:36  *** flokie_ has joined #bitcoin-core-dev
 71 2018-01-24T05:26:55  *** flokie has quit IRC
 72 2018-01-24T05:28:54  *** flokie_ is now known as flokie
 73 2018-01-24T05:29:09  *** PaulCapestany has quit IRC
 74 2018-01-24T05:36:06  <bitcoin-git> [bitcoin] dongcarl opened pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255
 75 2018-01-24T05:46:38  *** arbitrary_guy has joined #bitcoin-core-dev
 76 2018-01-24T05:58:26  *** PaulCapestany has joined #bitcoin-core-dev
 77 2018-01-24T06:00:35  *** eck has joined #bitcoin-core-dev
 78 2018-01-24T06:04:01  *** [Author] has quit IRC
 79 2018-01-24T06:06:55  *** [Author] has joined #bitcoin-core-dev
 80 2018-01-24T06:11:23  <mryandao> whats the general advice to "clean up commit body"?
 81 2018-01-24T06:11:42  <mryandao> does it mean I just have to rebase and re-write the commit message to reflect the final changes?
 82 2018-01-24T06:12:01  <mryandao> sorry, i'm still very new to contributing.
 83 2018-01-24T06:15:47  *** jojeyh has quit IRC
 84 2018-01-24T06:16:53  <gmaxwell> context?
 85 2018-01-24T06:17:59  <mryandao> gmaxwell: https://github.com/bitcoin/bitcoin/pull/12240
 86 2018-01-24T06:18:11  *** eck has quit IRC
 87 2018-01-24T06:19:02  *** r251d has joined #bitcoin-core-dev
 88 2018-01-24T06:19:06  *** promag has quit IRC
 89 2018-01-24T06:20:07  <r251d> mryandao: I think "commit body" refers to the commit message at https://github.com/bitcoin/bitcoin/pull/12240/commits/acde12c2f651912fdd04e4e50638502d5de26e91
 90 2018-01-24T06:22:35  *** mrannanay has joined #bitcoin-core-dev
 91 2018-01-24T06:22:47  <mryandao> basically just summarising the actual stuff i'm contributing less the changes made in all the commits i've squashed?
 92 2018-01-24T06:25:38  <r251d> I'm not sure exactly what to change about it but I think it may just be a bit verbose. Contributing.md says this:
 93 2018-01-24T06:25:48  <r251d> > Commit messages should be verbose by default consisting of a short subject line (50 chars max), a blank line and detailed explanatory text as separate paragraph(s), unless the title alone is self-explanatory (like "Corrected typo in init.cpp") in which case a single title line is sufficient. Commit messages should be helpful to people reading your code in the future, so explain the reasoning for
 94 2018-01-24T06:25:48  <r251d>  your decisions. Further explanation here.
 95 2018-01-24T06:28:31  <gmaxwell> mryandao: Its not clear to me what you're being asked to do there. Feel free to ask.
 96 2018-01-24T06:28:43  *** Murch has joined #bitcoin-core-dev
 97 2018-01-24T06:30:42  *** indistylo has joined #bitcoin-core-dev
 98 2018-01-24T06:33:05  *** aruns has joined #bitcoin-core-dev
 99 2018-01-24T06:34:16  <Randolf> mryandao:  You're new too?  And you got Squashing working?  You're ahead of me then.  :)
100 2018-01-24T06:35:04  <mryandao> the instructions were easy to follow.
101 2018-01-24T06:35:21  <mryandao> way more inituitive than git rebase --help really.
102 2018-01-24T06:36:00  *** indistylo has quit IRC
103 2018-01-24T06:39:29  <Randolf> I think I got rebasing working today.  Nothing showed up on GitHub.com though, so I figured it got queued or something and I'll check again later.
104 2018-01-24T06:43:31  <mryandao> you gotta do a git push -f
105 2018-01-24T06:44:01  <mryandao> and it should show in github.com after the push is done.
106 2018-01-24T06:44:02  *** maaku has joined #bitcoin-core-dev
107 2018-01-24T06:46:26  *** aruns has quit IRC
108 2018-01-24T06:46:31  <Randolf> I did that, it asked for my username and password, and then it finally reported that everything is up to date.
109 2018-01-24T06:46:38  *** promag has joined #bitcoin-core-dev
110 2018-01-24T06:46:48  *** indistylo has joined #bitcoin-core-dev
111 2018-01-24T06:49:42  <r251d> promag: could you please clarify your nit about commit body cleanup for mryandao at https://github.com/bitcoin/bitcoin/pull/12240 ?
112 2018-01-24T06:50:07  *** testtt has joined #bitcoin-core-dev
113 2018-01-24T06:52:27  *** testtt has quit IRC
114 2018-01-24T06:53:34  *** indistylo has quit IRC
115 2018-01-24T06:54:39  *** r251d has quit IRC
116 2018-01-24T06:55:57  *** indistylo has joined #bitcoin-core-dev
117 2018-01-24T06:59:55  *** aruns has joined #bitcoin-core-dev
118 2018-01-24T07:02:50  *** indistylo has quit IRC
119 2018-01-24T07:09:32  *** flokie_ has joined #bitcoin-core-dev
120 2018-01-24T07:13:03  *** flokie has quit IRC
121 2018-01-24T07:16:32  <bitcoin-git> [bitcoin] kallewoof opened pull request #12257: [wallet] Use destination groups instead of coins in coin select (master...feature-addrgrouped-coinselect) https://github.com/bitcoin/bitcoin/pull/12257
122 2018-01-24T07:28:56  <ProfMac> Is there a channel for people who want to study the code, but aren't strong developers?
123 2018-01-24T07:31:29  <Randolf> ProfMac:  There is a #bitcoin-dev channel.
124 2018-01-24T07:46:14  <gmaxwell> kallewoof: very cool
125 2018-01-24T07:47:29  <gmaxwell> kallewoof: did you consider/try  having the non-avoidpartialspends mode first try to see it to see if there is a solution?  I assume everyone would prefer an avoidpartial solution if it was otherwise about as good.
126 2018-01-24T07:49:14  <luke-jr> kallewoof: that doesn't avoid reuse, and has security issues in the event of QC (but we have enough issues there already, so not a big deal), but seems useful anyway
127 2018-01-24T07:51:02  <gmaxwell> kallewoof: it doesn't avoid reuse, but it reduces one of its major harms.
128 2018-01-24T07:51:12  <luke-jr> yes, hence useful anyway
129 2018-01-24T07:51:19  <gmaxwell> right now even a small amount of reuse results in your entire wallet being common-input linked.
130 2018-01-24T07:52:41  <luke-jr> my point was only that it isn't an "avoid address reuse" category PR as it seemed to be suggesting it was ;)
131 2018-01-24T07:53:43  *** Amuza has joined #bitcoin-core-dev
132 2018-01-24T07:57:58  *** SopaXorzTaker has joined #bitcoin-core-dev
133 2018-01-24T07:58:26  <gmaxwell> luke-jr: we could probably do a lot wrt reuse with two small features: when you send to an address you've sent to before, put up a dialog that asks if you're making a mistake.  (we've certantly seen people mess up by double paying addresses); and put a 'reuse' icon on any transaction paying you that pays to an address which has already been paid.
134 2018-01-24T08:02:54  *** aruns has quit IRC
135 2018-01-24T08:09:25  *** promag has quit IRC
136 2018-01-24T08:14:09  *** tryphe_ has joined #bitcoin-core-dev
137 2018-01-24T08:17:36  *** tryphe has quit IRC
138 2018-01-24T08:20:40  *** Murch has quit IRC
139 2018-01-24T08:32:18  *** Krellan has joined #bitcoin-core-dev
140 2018-01-24T08:36:15  *** promag has joined #bitcoin-core-dev
141 2018-01-24T08:36:36  <kallewoof> gmaxwell: you mean it should try to avoid partial spending and if it finds a fairly optimal solution it picks it over the per-coin selector?
142 2018-01-24T08:37:24  <kallewoof> gmaxwell: I'm not sure what would be a good factor for determining success in that case, but it does sound like a good strategy. (Maybe simply # of inputs with enabled vs disabled? If same, use the no-partial-spends variant.)
143 2018-01-24T08:38:52  <kallewoof> also, as noted in the PR, it is a fix to an issue raised in a different PR which marks addresses dirty. The two PRs together would avoid reuse completely, I believe. (Correct me if I'm missing something, though!)
144 2018-01-24T08:38:58  <kallewoof> luke-jr: ^
145 2018-01-24T08:39:13  <kallewoof> s/issue raised/issue addressed/
146 2018-01-24T08:41:35  <gmaxwell> kallewoof: the decision criteria is a complicated question that is cropping up in other areas too... generally if the current feerate is low compared to what you expect in the future you want to be spending more inputs, if it's high, fewer--  though solutions without change are preferable.
147 2018-01-24T08:46:47  <bitcoin-git> [bitcoin] tviho opened pull request #12258: Change app name, datadir location/settings (master...master) https://github.com/bitcoin/bitcoin/pull/12258
148 2018-01-24T08:46:50  <kallewoof> gmaxwell: ahh.. that's a good point. I really like the idea of testing both cases and using the avoidpartialspends variant if it's only marginally worse.
149 2018-01-24T08:47:59  <kallewoof> gmaxwell: just not sure what to base the criteria on. Maybe that's a different PR. It's simply a matter of calling https://github.com/bitcoin/bitcoin/pull/12257/files#diff-b2bb174788c7409b671c46ccc86034bdR4228 with false once and true once and comparing.
150 2018-01-24T08:47:59  <bitcoin-git> [bitcoin] fanquake closed pull request #12258: Change app name, datadir location/settings (master...master) https://github.com/bitcoin/bitcoin/pull/12258
151 2018-01-24T08:55:05  <gmaxwell> well at a minimum you can prefer the avoidpartial solution if it pays equal or less total fees, I think.
152 2018-01-24T08:55:47  <gmaxwell> Though I know that isn't ideal, but I think it's strictly better than not trying.
153 2018-01-24T08:56:52  *** timothy has joined #bitcoin-core-dev
154 2018-01-24T08:57:30  <kallewoof> If the fee rate is decided on coin selection (I don't think it is, but have to check), it could be used to consider more inputs as a better solution, maybe. I think I'll do the 'equal or less fee' fix right away though (but will it, ever? won't the same solution be found by the less restricted variant?)
155 2018-01-24T08:58:18  <kallewoof> I mean, if the fee rate is really low, it could see it as an opportunity to group up inputs. I think that's flawed, though, so nevermind.
156 2018-01-24T09:00:25  <gmaxwell> Fee rate is known then, so the software could decide to prefer more vs fewer, the challenge is how do you know if a specific feerate is a high vs a low one?
157 2018-01-24T09:01:37  <gmaxwell> as far as "won't it find it" -- unlikely, the stochastic solver only evaluates a tiny fraction of the search space... imagine you have 10 addresses, and 10 payments each, its unlikely the ungrouped solver will ever consider spending just two groups.
158 2018-01-24T09:02:29  <gmaxwell> I wouldn't be surprised if the grouped solution we seldom lower fees, though it might be equal not that infrequently.
159 2018-01-24T09:03:47  *** whphhg_ has joined #bitcoin-core-dev
160 2018-01-24T09:04:47  *** whphhg has quit IRC
161 2018-01-24T09:04:53  <kallewoof> Okay... yeah, I haven't considered the more complex cases. I'm mostly thinking of this from the "one actual payment with a bunch of tiny dust payments to track you" scenario.
162 2018-01-24T09:05:56  *** intcat has quit IRC
163 2018-01-24T09:08:10  <gmaxwell> I was about to say that with feerates at least tracking dust is less of an issue ... but then I remembed the last couple days...
164 2018-01-24T09:08:32  *** whphhg_ is now known as whphhg
165 2018-01-24T09:08:38  <gmaxwell> fun fact: I noticed recently that some obvious tracking dust I got years ago is now worth $10 each. :)
166 2018-01-24T09:08:48  <kallewoof> lol
167 2018-01-24T09:09:11  *** intcat has joined #bitcoin-core-dev
168 2018-01-24T09:12:14  *** echelon has quit IRC
169 2018-01-24T09:12:22  <kallewoof> gmaxwell: the only straightforward way I could think of to check if the fee drops is the # of coins selected (I assume every input + signature will cost the same, which is untrue with segwit vs p2pkh, but I think that's not a big issue in the long run)
170 2018-01-24T09:13:32  <gmaxwell> well one might have change and the other not...
171 2018-01-24T09:13:42  <gmaxwell> you could compare their weight instead?
172 2018-01-24T09:14:20  *** dermoth has joined #bitcoin-core-dev
173 2018-01-24T09:16:36  <kallewoof> I'm checking for change by seeing if nValueFromPresetInputs + nValueRet2 == nTargetValue. That's not precise though, due to dust limits and such, I guess.
174 2018-01-24T09:16:58  *** timothy has quit IRC
175 2018-01-24T09:16:59  <kallewoof> I didn't know you could get the weight for coins. Will look.
176 2018-01-24T09:18:35  *** promag has quit IRC
177 2018-01-24T09:18:47  *** promag has joined #bitcoin-core-dev
178 2018-01-24T09:19:52  <gmaxwell> oh I see.
179 2018-01-24T09:20:00  *** timothy has joined #bitcoin-core-dev
180 2018-01-24T09:20:01  <gmaxwell> right you're working with selections, not transactions.
181 2018-01-24T09:20:02  <kallewoof> Okay, I think I understand what you mean -- make both transactions and compare their weights and pick the avoid-partial one if it's reasonable in comparison to the non-avoiding one.
182 2018-01-24T09:20:18  <gmaxwell> yes, I was thinking that you were working with transactions for some reason.
183 2018-01-24T09:20:26  <kallewoof> I was hoping to do all this in SelectCoins. (My patch currently looks like this: https://github.com/bitcoin/bitcoin/pull/12257/commits/4593c6164891e5d766b33952702195288a241b2d)
184 2018-01-24T09:21:27  <promag> mryandao: do you need help addressing my comment??
185 2018-01-24T09:21:47  *** Emcy_ has joined #bitcoin-core-dev
186 2018-01-24T09:22:08  <gmaxwell> kallewoof: I think it's not unreasonable to do that.
187 2018-01-24T09:22:13  *** echelon has joined #bitcoin-core-dev
188 2018-01-24T09:24:35  *** Emcy has quit IRC
189 2018-01-24T09:25:17  *** tryphe_ is now known as tryphe
190 2018-01-24T09:31:11  *** timothy has quit IRC
191 2018-01-24T09:35:31  *** emzy has quit IRC
192 2018-01-24T09:35:32  *** emzy has joined #bitcoin-core-dev
193 2018-01-24T09:39:49  *** vicenteH has joined #bitcoin-core-dev
194 2018-01-24T09:41:57  *** timothy has joined #bitcoin-core-dev
195 2018-01-24T09:44:10  *** timothy has quit IRC
196 2018-01-24T09:44:42  *** Emcy has joined #bitcoin-core-dev
197 2018-01-24T09:45:06  *** timothy has joined #bitcoin-core-dev
198 2018-01-24T09:47:28  *** Emcy_ has quit IRC
199 2018-01-24T09:54:54  *** arbitrary_guy has quit IRC
200 2018-01-24T09:56:15  <kallewoof> gmaxwell: I think I've got it. Not sure what reviewers will say though (I wrapped CWallet::CreateTransaction and called the original twice for the case where avoid-partial is unset)... https://github.com/bitcoin/bitcoin/pull/12257/commits/3af1fac480fa08f92cd611ce93885d4501acc676
201 2018-01-24T09:58:10  *** afilini has joined #bitcoin-core-dev
202 2018-01-24T10:05:24  *** indistylo has joined #bitcoin-core-dev
203 2018-01-24T10:09:03  *** dabura667 has quit IRC
204 2018-01-24T10:13:09  *** dabura667 has joined #bitcoin-core-dev
205 2018-01-24T10:17:09  *** indistylo has quit IRC
206 2018-01-24T10:25:48  *** indistylo has joined #bitcoin-core-dev
207 2018-01-24T10:26:24  <kallewoof> (It's failing in places; will fix & push update later.)
208 2018-01-24T10:31:05  *** indistylo has quit IRC
209 2018-01-24T10:31:34  *** indistylo has joined #bitcoin-core-dev
210 2018-01-24T10:36:25  *** afilini has quit IRC
211 2018-01-24T10:37:32  *** Orion3k has joined #bitcoin-core-dev
212 2018-01-24T10:41:17  *** laurentmt has joined #bitcoin-core-dev
213 2018-01-24T10:41:47  *** laurentmt has quit IRC
214 2018-01-24T10:47:04  *** jtimon has joined #bitcoin-core-dev
215 2018-01-24T10:50:07  *** shesek has quit IRC
216 2018-01-24T10:55:59  *** wxss has joined #bitcoin-core-dev
217 2018-01-24T11:03:05  *** afilini has joined #bitcoin-core-dev
218 2018-01-24T11:06:48  *** shesek has joined #bitcoin-core-dev
219 2018-01-24T11:06:48  *** shesek has joined #bitcoin-core-dev
220 2018-01-24T11:07:20  *** Orion3k has quit IRC
221 2018-01-24T11:09:20  *** larafale has joined #bitcoin-core-dev
222 2018-01-24T11:16:39  *** dabura667 has quit IRC
223 2018-01-24T11:20:40  *** larafale has quit IRC
224 2018-01-24T11:21:16  *** larafale has joined #bitcoin-core-dev
225 2018-01-24T11:21:16  *** Krellan has quit IRC
226 2018-01-24T11:24:39  *** Krellan has joined #bitcoin-core-dev
227 2018-01-24T11:25:27  *** larafale has quit IRC
228 2018-01-24T11:29:27  *** timothy has quit IRC
229 2018-01-24T11:31:27  *** larafale has joined #bitcoin-core-dev
230 2018-01-24T11:32:51  *** indistylo has quit IRC
231 2018-01-24T11:35:55  *** indistylo has joined #bitcoin-core-dev
232 2018-01-24T11:39:10  *** indistylo has quit IRC
233 2018-01-24T11:39:28  *** indistylo has joined #bitcoin-core-dev
234 2018-01-24T11:46:32  *** timothy has joined #bitcoin-core-dev
235 2018-01-24T11:55:02  *** timothy has quit IRC
236 2018-01-24T11:57:09  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/b5e4b9b5100e...8470e64724cb
237 2018-01-24T11:57:10  <bitcoin-git> bitcoin/master 8d0b610 Jonas Schnelli: Avoid pemanent cs_main/cs_wallet lock during wallet rescans
238 2018-01-24T11:57:10  <bitcoin-git> bitcoin/master dbf8556 Jonas Schnelli: Add RAII wallet rescan reserver
239 2018-01-24T11:57:11  <bitcoin-git> bitcoin/master bc356b4 Jonas Schnelli: Make sure WalletRescanReserver has successfully reserved the rescan
240 2018-01-24T11:57:37  <bitcoin-git> [bitcoin] laanwj closed pull request #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime (master...2017/09/rescan_locks) https://github.com/bitcoin/bitcoin/pull/11281
241 2018-01-24T11:59:42  <promag> \o/
242 2018-01-24T12:07:27  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8470e64724cb...6e89de5ba7ce
243 2018-01-24T12:07:28  <bitcoin-git> bitcoin/master fb6f6b1 Matt Corallo: bluematt's testnet-seed now supports x9 (and is just a static list)
244 2018-01-24T12:07:28  <bitcoin-git> bitcoin/master 51ae766 Matt Corallo: Use GetDesireableServiceFlags in static seeds, document this....
245 2018-01-24T12:07:29  <bitcoin-git> bitcoin/master 62e7642 Matt Corallo: Fall back to oneshot for DNS Seeds which don't support filtering....
246 2018-01-24T12:08:01  <bitcoin-git> [bitcoin] laanwj closed pull request #11512: Use GetDesireableServiceFlags in seeds, dnsseeds, fixing static seed adding (master...2017-10-seed-service-bits-cleanups) https://github.com/bitcoin/bitcoin/pull/11512
247 2018-01-24T12:08:44  *** SopaXorzTaker has quit IRC
248 2018-01-24T12:08:58  *** whphhg_ has joined #bitcoin-core-dev
249 2018-01-24T12:10:07  *** SopaXorzTaker has joined #bitcoin-core-dev
250 2018-01-24T12:10:07  *** whphhg has quit IRC
251 2018-01-24T12:10:13  *** SopaXorzTaker has quit IRC
252 2018-01-24T12:11:02  *** timothy has joined #bitcoin-core-dev
253 2018-01-24T12:13:00  *** SopaXorzTaker has joined #bitcoin-core-dev
254 2018-01-24T12:13:56  *** tryphe_ has joined #bitcoin-core-dev
255 2018-01-24T12:14:03  *** SopaXorzTaker has joined #bitcoin-core-dev
256 2018-01-24T12:14:15  *** SopaXorzTaker has quit IRC
257 2018-01-24T12:14:44  *** SopaXorzTaker has joined #bitcoin-core-dev
258 2018-01-24T12:16:29  *** SopaXorzTaker has joined #bitcoin-core-dev
259 2018-01-24T12:16:33  *** tryphe has quit IRC
260 2018-01-24T12:18:00  *** afilini has quit IRC
261 2018-01-24T12:18:05  <promag> wumpus: #12213 do you agree with jnewbery?
262 2018-01-24T12:18:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
263 2018-01-24T12:19:30  *** eck has joined #bitcoin-core-dev
264 2018-01-24T12:20:08  <wumpus> promag: I agree it makes sense to separate it out and discuss it separately, not making it hold up 0.16
265 2018-01-24T12:20:22  <promag> ok, I'll adjust
266 2018-01-24T12:21:34  <wumpus> I agree with his points, also that we really don't want to be introducing new #ifdef ENABLE_WALLET, but in any case let's get the other two commits in
267 2018-01-24T12:21:41  *** maaku has left #bitcoin-core-dev
268 2018-01-24T12:23:30  <wumpus> it's doubly interesting because this code within ENABLE_WALLET doesn't use any wallet, implying, if we want this, that there is some utility code that needs to be moved out of the wallet
269 2018-01-24T12:25:10  *** aruns__ has joined #bitcoin-core-dev
270 2018-01-24T12:25:13  *** alfa has joined #bitcoin-core-dev
271 2018-01-24T12:27:43  *** indistylo has quit IRC
272 2018-01-24T12:33:25  <wumpus> going to merge #11415 first, seems it's ready
273 2018-01-24T12:33:29  <gribble> https://github.com/bitcoin/bitcoin/issues/11415 | [RPC] Disallow using addresses in createmultisig by achow101 · Pull Request #11415 · bitcoin/bitcoin · GitHub
274 2018-01-24T12:33:36  *** eck has quit IRC
275 2018-01-24T12:33:54  *** eck has joined #bitcoin-core-dev
276 2018-01-24T12:40:28  *** drizztbsd has joined #bitcoin-core-dev
277 2018-01-24T12:41:14  *** timothy has quit IRC
278 2018-01-24T12:48:46  *** drizztbsd has quit IRC
279 2018-01-24T12:50:45  *** drizztbsd has joined #bitcoin-core-dev
280 2018-01-24T12:52:30  *** promag has quit IRC
281 2018-01-24T13:04:04  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e89de5ba7ce...69ec021969a4
282 2018-01-24T13:04:04  <bitcoin-git> bitcoin/master 1df206f Andrew Chow: Disallow using addresses in createmultisig...
283 2018-01-24T13:04:05  <bitcoin-git> bitcoin/master 69ec021 Wladimir J. van der Laan: Merge #11415: [RPC] Disallow using addresses in createmultisig...
284 2018-01-24T13:04:28  <bitcoin-git> [bitcoin] laanwj closed pull request #11415: [RPC] Disallow using addresses in createmultisig (master...createmultisig-no-addr) https://github.com/bitcoin/bitcoin/pull/11415
285 2018-01-24T13:07:07  *** eck has quit IRC
286 2018-01-24T13:09:36  *** indistylo has joined #bitcoin-core-dev
287 2018-01-24T13:10:07  *** aruns__ has quit IRC
288 2018-01-24T13:17:30  *** Eetsi123 has joined #bitcoin-core-dev
289 2018-01-24T13:20:45  *** DarylSharp2 has quit IRC
290 2018-01-24T13:22:10  *** Eetsi123 has quit IRC
291 2018-01-24T13:22:10  *** drizztbsd has quit IRC
292 2018-01-24T13:23:09  *** promag has joined #bitcoin-core-dev
293 2018-01-24T13:23:10  *** drizztbsd has joined #bitcoin-core-dev
294 2018-01-24T13:25:05  *** drizztbsd has quit IRC
295 2018-01-24T13:25:30  *** drizztbsd has joined #bitcoin-core-dev
296 2018-01-24T13:27:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
297 2018-01-24T13:27:29  *** drizztbsd has quit IRC
298 2018-01-24T13:29:32  *** drizztbsd has joined #bitcoin-core-dev
299 2018-01-24T13:30:28  *** rafalcpp_ is now known as rafalcpp
300 2018-01-24T13:31:30  *** drizztbsd has quit IRC
301 2018-01-24T13:31:33  *** Stevie88Glover has quit IRC
302 2018-01-24T13:31:54  *** drizztbsd has joined #bitcoin-core-dev
303 2018-01-24T13:32:30  *** Guyver2 has joined #bitcoin-core-dev
304 2018-01-24T13:35:01  *** drizztbsd has quit IRC
305 2018-01-24T13:35:40  *** drizztbsd has joined #bitcoin-core-dev
306 2018-01-24T13:35:40  *** Krellan has quit IRC
307 2018-01-24T13:36:04  *** Gay6Rowe has joined #bitcoin-core-dev
308 2018-01-24T13:39:24  *** promag has quit IRC
309 2018-01-24T13:39:37  *** promag has joined #bitcoin-core-dev
310 2018-01-24T13:40:08  *** Krellan has joined #bitcoin-core-dev
311 2018-01-24T13:44:45  *** Chris_Stewart_5 has quit IRC
312 2018-01-24T13:47:31  *** Gay6Rowe has quit IRC
313 2018-01-24T13:49:56  *** Krellan has quit IRC
314 2018-01-24T13:50:30  *** Krellan has joined #bitcoin-core-dev
315 2018-01-24T13:50:47  *** wolfspraul has joined #bitcoin-core-dev
316 2018-01-24T13:52:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/69ec021969a4...126000ba9e7f
317 2018-01-24T13:52:27  <bitcoin-git> bitcoin/master ffffb10 MarcoFalke: qa: Rename cli.args to cli.options...
318 2018-01-24T13:52:27  <bitcoin-git> bitcoin/master fae7b14 MarcoFalke: qa: Make TestNodeCLI command optional in send_cli
319 2018-01-24T13:52:28  <bitcoin-git> bitcoin/master 126000b MarcoFalke: Merge #12089: qa: Make TestNodeCLI command optional in send_cli...
320 2018-01-24T13:53:10  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12089: qa: Make TestNodeCLI command optional in send_cli (master...Mf1801-qaCliOptions) https://github.com/bitcoin/bitcoin/pull/12089
321 2018-01-24T13:54:48  *** Krellan has quit IRC
322 2018-01-24T13:55:32  *** Krellan has joined #bitcoin-core-dev
323 2018-01-24T13:58:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
324 2018-01-24T13:59:50  *** Krellan has quit IRC
325 2018-01-24T14:00:32  *** Krellan has joined #bitcoin-core-dev
326 2018-01-24T14:04:57  *** Krellan has quit IRC
327 2018-01-24T14:05:33  *** Krellan has joined #bitcoin-core-dev
328 2018-01-24T14:07:16  *** SopaXorzTaker has quit IRC
329 2018-01-24T14:07:38  *** SopaXorzTaker has joined #bitcoin-core-dev
330 2018-01-24T14:23:08  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/126000ba9e7f...95941396fff8
331 2018-01-24T14:23:09  <bitcoin-git> bitcoin/master 596c446 Sjors Provoost: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH...
332 2018-01-24T14:23:09  <bitcoin-git> bitcoin/master 9594139 Wladimir J. van der Laan: Merge #12119: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH...
333 2018-01-24T14:23:51  *** tryphe_ has quit IRC
334 2018-01-24T14:23:55  <bitcoin-git> [bitcoin] laanwj closed pull request #12119:  [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (master...bech32-change) https://github.com/bitcoin/bitcoin/pull/12119
335 2018-01-24T14:25:57  *** Chris_Stewart_5 has quit IRC
336 2018-01-24T14:26:11  *** drizztbsd has quit IRC
337 2018-01-24T14:26:53  *** drizztbsd has joined #bitcoin-core-dev
338 2018-01-24T14:30:17  *** belcher_ has joined #bitcoin-core-dev
339 2018-01-24T14:35:53  *** Kayla10Mertz has joined #bitcoin-core-dev
340 2018-01-24T14:40:52  *** eck has joined #bitcoin-core-dev
341 2018-01-24T14:40:56  *** afilini has joined #bitcoin-core-dev
342 2018-01-24T14:45:00  *** alfa has quit IRC
343 2018-01-24T14:50:38  *** aruns__ has joined #bitcoin-core-dev
344 2018-01-24T14:52:23  *** afilini has quit IRC
345 2018-01-24T14:52:34  <promag> wumpus: #12213, rebased and removed createmultisig change
346 2018-01-24T14:52:37  <gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
347 2018-01-24T14:53:19  *** indistylo has quit IRC
348 2018-01-24T14:56:53  *** SopaXorzTaker has quit IRC
349 2018-01-24T14:59:38  *** propumpkin is now known as contrapumpkin
350 2018-01-24T14:59:55  <wumpus> promag: thanks!
351 2018-01-24T15:00:13  <promag> taking care of #12194 too
352 2018-01-24T15:00:17  <gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
353 2018-01-24T15:12:24  *** jojeyh has joined #bitcoin-core-dev
354 2018-01-24T15:13:07  *** drizztbsd has quit IRC
355 2018-01-24T15:14:09  *** neha has quit IRC
356 2018-01-24T15:17:22  *** tryphe has joined #bitcoin-core-dev
357 2018-01-24T15:22:03  *** lnostdal has joined #bitcoin-core-dev
358 2018-01-24T15:22:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
359 2018-01-24T15:24:30  *** aruns__ has quit IRC
360 2018-01-24T15:33:22  *** neha has joined #bitcoin-core-dev
361 2018-01-24T15:34:06  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/95941396fff8...e37ca2be91bd
362 2018-01-24T15:34:07  <bitcoin-git> bitcoin/master 04ededf Russell Yanofsky: Make CKey::Load references const...
363 2018-01-24T15:34:07  <bitcoin-git> bitcoin/master e37ca2b Wladimir J. van der Laan: Merge #12250: Make CKey::Load references const...
364 2018-01-24T15:34:57  <bitcoin-git> [bitcoin] laanwj closed pull request #12250: Make CKey::Load references const (master...pr/keyload) https://github.com/bitcoin/bitcoin/pull/12250
365 2018-01-24T15:35:39  <promag> wumpus: pushed #12194
366 2018-01-24T15:35:40  <gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
367 2018-01-24T15:35:52  <promag> those are the last 2 in 0.16 millestone
368 2018-01-24T15:37:42  *** neha has quit IRC
369 2018-01-24T15:38:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e37ca2be91bd...6e3fe936090d
370 2018-01-24T15:38:48  <bitcoin-git> bitcoin/master 1e0d6e9 Wladimir J. van der Laan: tx: Update transifex slug for 0.16...
371 2018-01-24T15:38:49  <bitcoin-git> bitcoin/master 6e3fe93 Wladimir J. van der Laan: qt: Update translation source file...
372 2018-01-24T15:40:58  *** wraithm has joined #bitcoin-core-dev
373 2018-01-24T15:42:22  *** SopaXorzTaker has joined #bitcoin-core-dev
374 2018-01-24T15:44:44  <achow101> Oh! 0.16 is almost ready. Only 2 PRs left
375 2018-01-24T15:45:19  <wumpus> yep, I hope we can tag it after the meeting tomorrow
376 2018-01-24T15:45:40  <wumpus> rc1, I mean
377 2018-01-24T15:46:51  <wumpus> still need to some some release process things, such as updating hardcoded seeds
378 2018-01-24T15:49:30  *** eck has quit IRC
379 2018-01-24T15:49:45  *** afilini has joined #bitcoin-core-dev
380 2018-01-24T15:50:42  <sipa> wumpus: do we want #12253 in 0.16?
381 2018-01-24T15:50:43  <gribble> https://github.com/bitcoin/bitcoin/issues/12253 | SegWit support for importmulti · Issue #12253 · bitcoin/bitcoin · GitHub
382 2018-01-24T15:51:48  <wumpus> sipa: if possible, but I think it's getting a bit late for that
383 2018-01-24T15:52:02  *** vigorousbearhunt has joined #bitcoin-core-dev
384 2018-01-24T15:52:32  <sipa> i certainly won't have time until next week
385 2018-01-24T15:52:33  <wumpus> I assume the code still needs to be written, and ofc it will need to go through a review cycle
386 2018-01-24T15:52:38  *** mrannanay has quit IRC
387 2018-01-24T15:52:42  <wumpus> right, so I guess that means no
388 2018-01-24T15:53:26  <wumpus> should probably mention lack of support in importmulti it in the 'known issues' in the release notes
389 2018-01-24T15:53:30  <promag> is that a thing for a 0.16.1?
390 2018-01-24T15:53:30  <sipa> you think it's not essential?
391 2018-01-24T15:53:51  <wumpus> no, I don't think it's essential
392 2018-01-24T15:54:04  <promag> sipa: you think it is?
393 2018-01-24T15:54:23  <sipa> signmessage may be worse, as it may silently break for people who didn't know we were switching to a new address format
394 2018-01-24T15:54:24  <wumpus> but I think segwit address support is worth a release in itself, even if not all supporting features have made it in yet
395 2018-01-24T15:54:45  <wumpus> so that one needs to be mentioned in the release notes as well
396 2018-01-24T15:55:28  <sipa> okay
397 2018-01-24T15:56:03  <wumpus> I can't be the only one that really wants a release with segwit wallet out?
398 2018-01-24T15:56:24  <sipa> no, i'm sure you're not :)
399 2018-01-24T15:56:42  *** SopaXorzTaker has quit IRC
400 2018-01-24T15:56:58  <wumpus> promag: yes, could be 0.16.1
401 2018-01-24T16:00:24  *** Giszmo has joined #bitcoin-core-dev
402 2018-01-24T16:00:30  *** timothy has joined #bitcoin-core-dev
403 2018-01-24T16:00:33  *** afilini has quit IRC
404 2018-01-24T16:00:54  <ryanofsky> promag, fyi #12213 nulldummy.py test currently fails
405 2018-01-24T16:00:56  <gribble> https://github.com/bitcoin/bitcoin/issues/12213 | Add address type to addmultisigaddress and createmultisig by promag · Pull Request #12213 · bitcoin/bitcoin · GitHub
406 2018-01-24T16:01:10  <instagibbs> there's going to be a lot of cleanup regardless, 0.16.1 is going to happen
407 2018-01-24T16:01:16  <promag> ryanofsky: ty
408 2018-01-24T16:01:31  <wumpus> instagibbs: that's true for any major release, though :)
409 2018-01-24T16:03:31  <instagibbs> I would look through release history to try and disprove, instead i shall just double-down, and log off
410 2018-01-24T16:03:35  <instagibbs> ;)
411 2018-01-24T16:04:17  <promag> is there anything deprecated in 0.15 to remove?
412 2018-01-24T16:07:57  *** mxg has joined #bitcoin-core-dev
413 2018-01-24T16:10:07  <bitcoin-git> [bitcoin] fwolfst opened pull request #12260: [Trivial] link mentioned scripted-diff-commit (developer-doc) (master...LINK_COMMIT_IN_DOC_DEVNOTES) https://github.com/bitcoin/bitcoin/pull/12260
414 2018-01-24T16:10:57  *** Amuza has quit IRC
415 2018-01-24T16:12:37  <achow101> promag: I think all the currently deprecated things are for removal in 0.17 (except the accounts system)
416 2018-01-24T16:13:10  <promag> so mark deprectated in X, remove in X+2?
417 2018-01-24T16:13:40  <wumpus> depends on the feature and the reason for deprecation, so depends on what was discussed at the time of deprecating it
418 2018-01-24T16:14:10  <achow101> no, the things currently deprecated were marked deprecated for 0.16
419 2018-01-24T16:16:21  *** mrannanay has joined #bitcoin-core-dev
420 2018-01-24T16:18:06  *** Murch has joined #bitcoin-core-dev
421 2018-01-24T16:18:12  <promag> got it
422 2018-01-24T16:19:13  *** Guest25674 has joined #bitcoin-core-dev
423 2018-01-24T16:19:29  *** Krellan has quit IRC
424 2018-01-24T16:19:51  <bitcoin-git> [bitcoin] laanwj opened pull request #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB (master...2018_01_block_chain_size) https://github.com/bitcoin/bitcoin/pull/12261
425 2018-01-24T16:21:02  *** Krellan has joined #bitcoin-core-dev
426 2018-01-24T16:24:14  <promag> ryanofsky: fixed segwit
427 2018-01-24T16:24:24  <promag> ^ test =)
428 2018-01-24T16:24:29  <sipa> that sounds ominous
429 2018-01-24T16:24:38  <promag> heh
430 2018-01-24T16:26:21  <promag> wumpus: "Bump BLOCK_CHAIN_SIZE to 200GB" typo there s/_CHAIN//
431 2018-01-24T16:26:56  <wumpus> promag: noooooooo
432 2018-01-24T16:27:07  <sipa> hahaha
433 2018-01-24T16:27:08  <promag> 100GB?
434 2018-01-24T16:27:27  *** neha has joined #bitcoin-core-dev
435 2018-01-24T16:27:42  <wumpus> promag: I already had to juggle partitions to fit the current one on my dev machine
436 2018-01-24T16:28:17  <Chris_Stewart_5> lol.
437 2018-01-24T16:28:57  <Chris_Stewart_5> we can now fit our entire previous blockchain in two blocks. MUCH THROUGHPUT
438 2018-01-24T16:30:33  *** Kayla10Mertz has quit IRC
439 2018-01-24T16:30:46  *** harrymm_ has quit IRC
440 2018-01-24T16:31:08  *** harrymm has joined #bitcoin-core-dev
441 2018-01-24T16:31:29  <jcorgan> how about we embed the entire current blockchain in an OP_RETURN of a new genesis block?
442 2018-01-24T16:33:15  <MarcoFalke> wumpus: What about #12251
443 2018-01-24T16:33:15  <wumpus> of course, and after that the OP_RETURN policy limit goes from 80 bytes to 80 GB, so it's possible to embed entire DVD images
444 2018-01-24T16:33:17  <gribble> https://github.com/bitcoin/bitcoin/issues/12251 | initwallet: Do not translate highly technical addresstype help by MarcoFalke · Pull Request #12251 · bitcoin/bitcoin · GitHub
445 2018-01-24T16:33:30  <MarcoFalke> Asking since you pushed the translations recently
446 2018-01-24T16:33:40  <promag> jcorgan:  another typo, s/OP_RETURN/javascript
447 2018-01-24T16:34:42  <wumpus> MarcoFalke: I think we should not translate option help messages at all
448 2018-01-24T16:34:45  *** Krellan has quit IRC
449 2018-01-24T16:34:48  <promag> I guess project:bitcoin/bitcoin/8 will be updated in the next days?
450 2018-01-24T16:34:53  <MarcoFalke> I know you proposed that #10962
451 2018-01-24T16:34:54  <gribble> https://github.com/bitcoin/bitcoin/issues/10962 | Stop translating command-line option help? · Issue #10962 · bitcoin/bitcoin · GitHub
452 2018-01-24T16:35:07  <wumpus> but yes it might be too late to do that for 0.16 so I'm ok with your change
453 2018-01-24T16:35:21  *** Krellan has joined #bitcoin-core-dev
454 2018-01-24T16:36:12  <MarcoFalke> Yeah, I want to save our translators from trying to translate "segwit" or "p2sh"
455 2018-01-24T16:36:41  <wumpus> agree
456 2018-01-24T16:37:54  *** Allan88Bergstrom has joined #bitcoin-core-dev
457 2018-01-24T16:39:29  <bitcoin-git> [bitcoin] laanwj opened pull request #12262: net: Hardcoded seed update (master...2018_01_seed_update) https://github.com/bitcoin/bitcoin/pull/12262
458 2018-01-24T16:39:53  *** Krellan has quit IRC
459 2018-01-24T16:40:22  *** Krellan has joined #bitcoin-core-dev
460 2018-01-24T16:41:41  *** tripleslash has joined #bitcoin-core-dev
461 2018-01-24T16:42:27  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e3fe936090d...cc5870a4057f
462 2018-01-24T16:42:27  <bitcoin-git> bitcoin/master fa7ecbf MarcoFalke: initwallet: Do not translate highly technical addresstype help
463 2018-01-24T16:42:28  <bitcoin-git> bitcoin/master cc5870a Wladimir J. van der Laan: Merge #12251: initwallet: Do not translate highly technical addresstype help...
464 2018-01-24T16:43:20  <bitcoin-git> [bitcoin] laanwj closed pull request #12251: initwallet: Do not translate highly technical addresstype help (master...Mf1801-walletNoTranslateInitHelp) https://github.com/bitcoin/bitcoin/pull/12251
465 2018-01-24T16:43:27  *** Giszmo has quit IRC
466 2018-01-24T16:50:57  *** Randolf has quit IRC
467 2018-01-24T16:52:38  *** promag has quit IRC
468 2018-01-24T16:59:01  *** Giszmo has joined #bitcoin-core-dev
469 2018-01-24T17:02:36  *** Victorsueca has quit IRC
470 2018-01-24T17:03:46  *** Victorsueca has joined #bitcoin-core-dev
471 2018-01-24T17:04:11  *** harrymm_ has joined #bitcoin-core-dev
472 2018-01-24T17:06:35  *** harrymm has quit IRC
473 2018-01-24T17:08:56  *** dermoth has quit IRC
474 2018-01-24T17:09:49  *** dermoth has joined #bitcoin-core-dev
475 2018-01-24T17:10:54  *** meshcollider has quit IRC
476 2018-01-24T17:13:55  *** mxg has quit IRC
477 2018-01-24T17:19:05  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
478 2018-01-24T17:19:05  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
479 2018-01-24T17:20:00  *** Randolf has joined #bitcoin-core-dev
480 2018-01-24T17:22:17  *** mxg has joined #bitcoin-core-dev
481 2018-01-24T17:23:11  *** promag has joined #bitcoin-core-dev
482 2018-01-24T17:24:43  *** afilini has joined #bitcoin-core-dev
483 2018-01-24T17:26:49  *** afilini has quit IRC
484 2018-01-24T17:29:36  *** Murch has quit IRC
485 2018-01-24T17:31:20  *** Amuza has joined #bitcoin-core-dev
486 2018-01-24T17:31:25  *** eck has joined #bitcoin-core-dev
487 2018-01-24T17:32:14  *** larafale has quit IRC
488 2018-01-24T17:43:36  *** Giszmo has quit IRC
489 2018-01-24T17:44:14  *** DigitalDank has quit IRC
490 2018-01-24T17:45:40  *** flokie_ is now known as flokie
491 2018-01-24T17:56:30  *** ghost43 has quit IRC
492 2018-01-24T17:58:35  *** ghost43 has joined #bitcoin-core-dev
493 2018-01-24T18:03:03  *** goatpig has joined #bitcoin-core-dev
494 2018-01-24T18:03:05  *** Murch has joined #bitcoin-core-dev
495 2018-01-24T18:07:13  *** __jnsmk__ has joined #bitcoin-core-dev
496 2018-01-24T18:07:49  *** mxg has quit IRC
497 2018-01-24T18:09:06  *** mxg has joined #bitcoin-core-dev
498 2018-01-24T18:17:11  *** eck has quit IRC
499 2018-01-24T18:27:06  *** Giszmo has joined #bitcoin-core-dev
500 2018-01-24T18:28:09  *** Murch has quit IRC
501 2018-01-24T18:43:28  *** mxg has quit IRC
502 2018-01-24T18:43:43  *** vicenteH has quit IRC
503 2018-01-24T18:49:37  *** vigorousbearhunt has quit IRC
504 2018-01-24T18:50:32  *** vigorousbearhunt has joined #bitcoin-core-dev
505 2018-01-24T18:54:05  *** Krellan has quit IRC
506 2018-01-24T18:58:37  *** Krellan has joined #bitcoin-core-dev
507 2018-01-24T19:00:10  <bitcoin-git> [bitcoin] jnewbery opened pull request #12264: Fix versionbits warning test (master...fix_versionbits_warning_test) https://github.com/bitcoin/bitcoin/pull/12264
508 2018-01-24T19:01:14  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cc5870a4057f...eadb2dacc3c6
509 2018-01-24T19:01:15  <bitcoin-git> bitcoin/master 886a92f João Barbosa: [rpc] Add address type option to addmultisigaddress
510 2018-01-24T19:01:16  <bitcoin-git> bitcoin/master f523c6b João Barbosa: [qa] Use address type in addmultisigaddress to avoid addwitnessaddress
511 2018-01-24T19:01:16  <bitcoin-git> bitcoin/master eadb2da Jonas Schnelli: Merge #12213: Add address type option to addmultisigaddress...
512 2018-01-24T19:01:36  *** Murch has joined #bitcoin-core-dev
513 2018-01-24T19:02:04  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12213: Add address type option to addmultisigaddress (master...2018-01-addmultisigaddress-address-type) https://github.com/bitcoin/bitcoin/pull/12213
514 2018-01-24T19:03:20  *** Krellan has quit IRC
515 2018-01-24T19:03:59  *** Krellan has joined #bitcoin-core-dev
516 2018-01-24T19:06:39  *** Allan88Bergstrom has quit IRC
517 2018-01-24T19:08:05  *** owowo has quit IRC
518 2018-01-24T19:08:24  *** Krellan has quit IRC
519 2018-01-24T19:08:52  *** Victorsueca has quit IRC
520 2018-01-24T19:09:00  *** Krellan has joined #bitcoin-core-dev
521 2018-01-24T19:10:14  *** Victorsueca has joined #bitcoin-core-dev
522 2018-01-24T19:10:19  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/eadb2dacc3c6...7abb0f0929bd
523 2018-01-24T19:10:20  <bitcoin-git> bitcoin/master 31dbd5a João Barbosa: [wallet] Add change type to CCoinControl
524 2018-01-24T19:10:20  <bitcoin-git> bitcoin/master 536ddeb João Barbosa: [rpc] Add change_type option to fundrawtransaction
525 2018-01-24T19:10:21  <bitcoin-git> bitcoin/master 16f6f59 João Barbosa: [qa] Test fundrawtransaction with change_type option
526 2018-01-24T19:11:05  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12194: Add change type option to fundrawtransaction (master...2018-01-fundrawtransaction-changetype) https://github.com/bitcoin/bitcoin/pull/12194
527 2018-01-24T19:13:01  *** owowo has joined #bitcoin-core-dev
528 2018-01-24T19:13:14  *** Krellan has quit IRC
529 2018-01-24T19:14:00  *** Krellan has joined #bitcoin-core-dev
530 2018-01-24T19:18:12  *** Krellan has quit IRC
531 2018-01-24T19:18:23  *** dermoth has quit IRC
532 2018-01-24T19:19:02  *** Krellan has joined #bitcoin-core-dev
533 2018-01-24T19:19:59  *** BashCo has joined #bitcoin-core-dev
534 2018-01-24T19:22:25  *** BashCo_ has quit IRC
535 2018-01-24T19:29:40  *** BashCo has quit IRC
536 2018-01-24T19:29:53  *** BashCo_ has joined #bitcoin-core-dev
537 2018-01-24T19:30:53  *** dermoth has joined #bitcoin-core-dev
538 2018-01-24T19:35:53  *** Melvin79Rodrigue has joined #bitcoin-core-dev
539 2018-01-24T19:37:37  *** Murch has quit IRC
540 2018-01-24T19:39:05  *** BashCo_ has quit IRC
541 2018-01-24T19:39:52  *** BashCo has joined #bitcoin-core-dev
542 2018-01-24T19:40:44  *** ghost43 has quit IRC
543 2018-01-24T19:41:31  *** ghost43 has joined #bitcoin-core-dev
544 2018-01-24T19:43:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7abb0f0929bd...f359afcc4104
545 2018-01-24T19:43:12  <bitcoin-git> bitcoin/master ba490d2 Wladimir J. van der Laan: qt: Bump BLOCK_CHAIN_SIZE to 200GB...
546 2018-01-24T19:43:13  <bitcoin-git> bitcoin/master f359afc MarcoFalke: Merge #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB...
547 2018-01-24T19:44:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12261: qt: Bump BLOCK_CHAIN_SIZE to 200GB (master...2018_01_block_chain_size) https://github.com/bitcoin/bitcoin/pull/12261
548 2018-01-24T19:47:24  *** givanse has joined #bitcoin-core-dev
549 2018-01-24T19:50:57  *** Randolf has quit IRC
550 2018-01-24T19:55:44  *** vigorousbearhunt has quit IRC
551 2018-01-24T19:56:31  *** vigorousbearhunt has joined #bitcoin-core-dev
552 2018-01-24T19:58:30  *** Murch has joined #bitcoin-core-dev
553 2018-01-24T19:59:04  *** Krellan has quit IRC
554 2018-01-24T19:59:05  *** BashCo has quit IRC
555 2018-01-24T19:59:44  *** Krellan has joined #bitcoin-core-dev
556 2018-01-24T20:01:07  *** afilini has joined #bitcoin-core-dev
557 2018-01-24T20:05:21  *** indistylo has joined #bitcoin-core-dev
558 2018-01-24T20:09:13  *** BashCo has joined #bitcoin-core-dev
559 2018-01-24T20:11:05  *** Randolf has joined #bitcoin-core-dev
560 2018-01-24T20:12:05  *** indistylo has quit IRC
561 2018-01-24T20:17:47  *** Giszmo has quit IRC
562 2018-01-24T20:18:49  *** Giszmo has joined #bitcoin-core-dev
563 2018-01-24T20:21:14  *** Scrat has quit IRC
564 2018-01-24T20:23:01  *** Scrat has joined #bitcoin-core-dev
565 2018-01-24T20:27:00  *** anome has joined #bitcoin-core-dev
566 2018-01-24T20:41:54  *** Murch has quit IRC
567 2018-01-24T20:42:01  *** anome has quit IRC
568 2018-01-24T20:51:03  <jonasschnelli> Our sighash tests do not exercise sigversion SIGVERSION_WITNESS_V0?
569 2018-01-24T20:51:27  <jonasschnelli> Or to ask different, where can I find the testvectors for SIGVERSION_WITNESS_V0 sighash?
570 2018-01-24T20:51:32  *** jb55 has joined #bitcoin-core-dev
571 2018-01-24T20:51:57  <Chris_Stewart_5> jonasschnelli: Isn't that tested by tx_{in}valid.json?
572 2018-01-24T20:52:21  <jonasschnelli> Let me check...
573 2018-01-24T20:53:04  <jonasschnelli> Chris_Stewart_5: I think your right,... was looking for bar sw sighash tests... thanks!
574 2018-01-24T20:55:21  <Chris_Stewart_5> jonasschnelli: script_tests.json might have simpler tests for the serialization algorithm
575 2018-01-24T20:55:34  <Chris_Stewart_5> there might be overhead to setting up the tx_valid.json test vectors
576 2018-01-24T21:02:18  <jonasschnelli> Thanks!
577 2018-01-24T21:07:21  *** echelon has quit IRC
578 2018-01-24T21:08:11  *** echelon has joined #bitcoin-core-dev
579 2018-01-24T21:10:12  *** jb55 has quit IRC
580 2018-01-24T21:17:18  *** bajohns has quit IRC
581 2018-01-24T21:17:49  *** droark has quit IRC
582 2018-01-24T21:22:40  *** neha has quit IRC
583 2018-01-24T21:23:36  *** ryan-c has quit IRC
584 2018-01-24T21:24:50  *** ryan-c has joined #bitcoin-core-dev
585 2018-01-24T21:25:35  *** dcousens has quit IRC
586 2018-01-24T21:28:54  *** neha has joined #bitcoin-core-dev
587 2018-01-24T21:29:08  *** vicenteH has joined #bitcoin-core-dev
588 2018-01-24T21:31:16  *** promag has quit IRC
589 2018-01-24T21:31:32  *** promag has joined #bitcoin-core-dev
590 2018-01-24T21:33:25  *** givanse has quit IRC
591 2018-01-24T21:37:10  *** Melvin79Rodrigue has quit IRC
592 2018-01-24T21:45:33  *** timothy has quit IRC
593 2018-01-24T21:50:29  *** __jnsmk__ has quit IRC
594 2018-01-24T21:52:48  *** meshcollider has joined #bitcoin-core-dev
595 2018-01-24T21:55:50  *** afilini has quit IRC
596 2018-01-24T21:58:50  *** afilini has joined #bitcoin-core-dev
597 2018-01-24T22:00:51  *** wraithm has quit IRC
598 2018-01-24T22:01:03  *** Scrat has quit IRC
599 2018-01-24T22:06:37  *** wraithm has joined #bitcoin-core-dev
600 2018-01-24T22:06:59  *** wraithm has quit IRC
601 2018-01-24T22:07:32  *** wraithm has joined #bitcoin-core-dev
602 2018-01-24T22:09:25  *** wraithm has quit IRC
603 2018-01-24T22:10:27  *** wraithm has joined #bitcoin-core-dev
604 2018-01-24T22:12:08  *** cryptapus has quit IRC
605 2018-01-24T22:17:13  *** cryptapus has joined #bitcoin-core-dev
606 2018-01-24T22:17:14  *** cryptapus has joined #bitcoin-core-dev
607 2018-01-24T22:18:24  *** Amuza has quit IRC
608 2018-01-24T22:21:38  *** larafale has joined #bitcoin-core-dev
609 2018-01-24T22:23:42  *** droark has joined #bitcoin-core-dev
610 2018-01-24T22:24:40  *** Giszmo has quit IRC
611 2018-01-24T22:25:19  *** Giszmo has joined #bitcoin-core-dev
612 2018-01-24T22:25:40  *** mxg has joined #bitcoin-core-dev
613 2018-01-24T22:27:17  *** Guyver2 has quit IRC
614 2018-01-24T22:28:01  *** phantomcircuit has quit IRC
615 2018-01-24T22:28:26  *** phantomcircuit has joined #bitcoin-core-dev
616 2018-01-24T22:30:13  *** givanse has joined #bitcoin-core-dev
617 2018-01-24T22:30:37  *** phantomcircuit has quit IRC
618 2018-01-24T22:30:49  *** phantomcircuit has joined #bitcoin-core-dev
619 2018-01-24T22:33:23  *** promag has quit IRC
620 2018-01-24T22:35:53  *** Jamey74Swift has joined #bitcoin-core-dev
621 2018-01-24T22:36:45  *** CubicEarths has joined #bitcoin-core-dev
622 2018-01-24T22:37:12  *** phantomcircuit has left #bitcoin-core-dev
623 2018-01-24T22:43:02  *** Murch has joined #bitcoin-core-dev
624 2018-01-24T22:43:22  *** mxg has quit IRC
625 2018-01-24T22:44:47  *** wxss has quit IRC
626 2018-01-24T22:45:01  *** phantomcircuit has joined #bitcoin-core-dev
627 2018-01-24T22:48:34  *** CubicEarths has quit IRC
628 2018-01-24T22:50:18  *** Jamey74Swift has quit IRC
629 2018-01-24T22:50:49  *** Cogito_Ergo_Sum has quit IRC
630 2018-01-24T22:54:44  *** Murch has quit IRC
631 2018-01-24T22:55:59  *** Chris_Stewart_5 has quit IRC
632 2018-01-24T23:03:55  *** promag has joined #bitcoin-core-dev
633 2018-01-24T23:04:43  *** phantomcircuit has quit IRC
634 2018-01-24T23:04:55  *** phantomcircuit has joined #bitcoin-core-dev
635 2018-01-24T23:07:53  *** vigorousbearhunt has quit IRC
636 2018-01-24T23:07:54  *** owowo has quit IRC
637 2018-01-24T23:09:50  *** vigorousbearhunt has joined #bitcoin-core-dev
638 2018-01-24T23:22:38  *** mrannanay has quit IRC
639 2018-01-24T23:29:49  *** wraithm has quit IRC
640 2018-01-24T23:32:20  *** givanse has quit IRC
641 2018-01-24T23:33:22  *** larafale has quit IRC
642 2018-01-24T23:34:02  *** larafale has joined #bitcoin-core-dev
643 2018-01-24T23:35:53  *** Melissa57Frami has joined #bitcoin-core-dev
644 2018-01-24T23:38:27  *** larafale has quit IRC
645 2018-01-24T23:41:12  *** sk8boy189 has joined #bitcoin-core-dev
646 2018-01-24T23:43:18  *** Melissa57Frami has quit IRC
647 2018-01-24T23:45:59  *** Murch has joined #bitcoin-core-dev
648 2018-01-24T23:48:48  *** afilini has quit IRC
649 2018-01-24T23:54:23  *** jb55 has joined #bitcoin-core-dev
650 2018-01-24T23:59:22  *** petertod1 is now known as petertodd