12018-02-05T00:04:33  *** Jeffery9Hauck has quit IRC
  22018-02-05T00:08:12  *** pgupta has quit IRC
  32018-02-05T00:09:07  *** Maud23Howell has joined #bitcoin-core-dev
  42018-02-05T00:16:30  *** pgupta has joined #bitcoin-core-dev
  52018-02-05T00:18:05  *** Maud23Howell has quit IRC
  62018-02-05T00:21:32  *** pgupta has quit IRC
  72018-02-05T00:25:56  *** promag has joined #bitcoin-core-dev
  82018-02-05T00:25:56  *** pgupta has joined #bitcoin-core-dev
  92018-02-05T00:30:36  *** promag has quit IRC
 102018-02-05T00:30:55  *** pgupta has quit IRC
 112018-02-05T00:31:24  *** kabaum has joined #bitcoin-core-dev
 122018-02-05T00:35:02  *** pgupta has joined #bitcoin-core-dev
 132018-02-05T00:40:14  *** pgupta has quit IRC
 142018-02-05T00:44:08  *** pgupta has joined #bitcoin-core-dev
 152018-02-05T00:45:30  *** owowo has quit IRC
 162018-02-05T00:48:44  *** pgupta has quit IRC
 172018-02-05T00:49:59  *** Murre has quit IRC
 182018-02-05T00:50:16  *** ghost43 has quit IRC
 192018-02-05T00:51:01  *** Randolf has joined #bitcoin-core-dev
 202018-02-05T00:53:14  *** pgupta has joined #bitcoin-core-dev
 212018-02-05T00:57:59  *** ghost43 has joined #bitcoin-core-dev
 222018-02-05T00:58:22  *** pgupta has quit IRC
 232018-02-05T00:58:24  *** meshcollider has joined #bitcoin-core-dev
 242018-02-05T00:59:21  *** dabura667 has joined #bitcoin-core-dev
 252018-02-05T01:02:20  *** pgupta has joined #bitcoin-core-dev
 262018-02-05T01:06:39  *** arbitrary_guy has joined #bitcoin-core-dev
 272018-02-05T01:07:05  *** pgupta has quit IRC
 282018-02-05T01:08:58  *** Rowland48West has joined #bitcoin-core-dev
 292018-02-05T01:11:44  *** pgupta has joined #bitcoin-core-dev
 302018-02-05T01:16:25  *** pgupta has quit IRC
 312018-02-05T01:17:25  *** cryptojanitor has quit IRC
 322018-02-05T01:20:33  *** pgupta has joined #bitcoin-core-dev
 332018-02-05T01:25:26  *** pgupta has quit IRC
 342018-02-05T01:29:40  *** pgupta has joined #bitcoin-core-dev
 352018-02-05T01:32:15  *** Krellan has quit IRC
 362018-02-05T01:33:03  *** Krellan has joined #bitcoin-core-dev
 372018-02-05T01:34:33  *** pgupta has quit IRC
 382018-02-05T01:37:52  *** promag has joined #bitcoin-core-dev
 392018-02-05T01:38:45  *** pgupta has joined #bitcoin-core-dev
 402018-02-05T01:42:25  *** promag has quit IRC
 412018-02-05T01:43:29  *** pgupta has quit IRC
 422018-02-05T01:47:50  *** pgupta has joined #bitcoin-core-dev
 432018-02-05T01:52:35  *** pgupta has quit IRC
 442018-02-05T01:56:56  *** pgupta has joined #bitcoin-core-dev
 452018-02-05T02:01:50  *** pgupta has quit IRC
 462018-02-05T02:05:05  *** promag has joined #bitcoin-core-dev
 472018-02-05T02:06:02  *** pgupta has joined #bitcoin-core-dev
 482018-02-05T02:08:31  *** arubi_ has joined #bitcoin-core-dev
 492018-02-05T02:09:50  *** arubi has quit IRC
 502018-02-05T02:10:33  *** promag has quit IRC
 512018-02-05T02:10:41  *** pgupta has quit IRC
 522018-02-05T02:13:13  *** cryptojanitor has joined #bitcoin-core-dev
 532018-02-05T02:15:11  *** pgupta has joined #bitcoin-core-dev
 542018-02-05T02:18:26  *** belcher has quit IRC
 552018-02-05T02:20:00  *** pgupta has quit IRC
 562018-02-05T02:24:14  *** pgupta has joined #bitcoin-core-dev
 572018-02-05T02:25:26  *** arubi_ has quit IRC
 582018-02-05T02:28:54  *** pgupta has quit IRC
 592018-02-05T02:30:30  *** arubi has joined #bitcoin-core-dev
 602018-02-05T02:33:22  *** pgupta has joined #bitcoin-core-dev
 612018-02-05T02:35:04  *** luke-jr has quit IRC
 622018-02-05T02:37:00  *** checksauce has joined #bitcoin-core-dev
 632018-02-05T02:37:57  *** pgupta has quit IRC
 642018-02-05T02:38:34  *** zautomata1 has joined #bitcoin-core-dev
 652018-02-05T02:40:08  *** gigoplast has joined #bitcoin-core-dev
 662018-02-05T02:40:22  *** zautomata has quit IRC
 672018-02-05T02:42:23  *** wunpunch has quit IRC
 682018-02-05T02:42:27  *** pgupta has joined #bitcoin-core-dev
 692018-02-05T02:43:55  *** gigoplast has left #bitcoin-core-dev
 702018-02-05T02:46:07  *** belcher has joined #bitcoin-core-dev
 712018-02-05T02:46:57  *** pgupta has quit IRC
 722018-02-05T02:50:12  *** conman has joined #bitcoin-core-dev
 732018-02-05T02:50:32  <conman> will 0.16.0 have bech32 support? I don't see it in the readme
 742018-02-05T02:51:08  <gmaxwell> conman: yes, it has BIP173 support for sending; and if you request it, for recieving too.
 752018-02-05T02:51:29  <conman> great, so validateaddress will return true for it too then
 762018-02-05T02:51:33  *** pgupta has joined #bitcoin-core-dev
 772018-02-05T02:51:33  <gmaxwell> it won't use it for rx by default, but you can set the default wallet wide, or request BC1 addresses on a case by case basis.
 782018-02-05T02:51:36  <gmaxwell> Yes.
 792018-02-05T02:51:40  <conman> ack
 802018-02-05T02:51:51  <conman> thanks
 812018-02-05T02:52:04  <conman> guess I better add support in my pools for it soon then
 822018-02-05T02:52:35  *** dabura667 has quit IRC
 832018-02-05T02:52:45  *** rhavar has quit IRC
 842018-02-05T02:53:05  <gmaxwell> would be nice, ... though we were expecting the rollout to take a long time.
 852018-02-05T02:53:17  <gmaxwell> Electrum has pushed it forward by making their segwit mode require it.
 862018-02-05T02:53:28  <conman> nod
 872018-02-05T02:54:21  <conman> my pool code asks bitcoin core to validate addresses so if I upgrade to .16 without adding support it will likely create corrupt generation transactions for bech32
 882018-02-05T02:54:48  <conman> should look to see what new rpc commands are in .16...
 892018-02-05T02:54:55  <gmaxwell> hm. how would it end up corrupt?
 902018-02-05T02:55:14  <conman> I hard code to look for a 3x address and it does p2sh output on that
 912018-02-05T02:55:42  <conman> if it doesn't see 3 it will assume it's a p2pkh and just code up the bech32 directly into that which will be of course a mess
 922018-02-05T02:56:09  <gmaxwell> how would it do that? the bech32 won't decode as base58.
 932018-02-05T02:56:13  *** dabura667 has joined #bitcoin-core-dev
 942018-02-05T02:56:19  <gmaxwell> even with an invalid checksum.
 952018-02-05T02:56:22  <conman> yeah that's what I mean, it will explode
 962018-02-05T02:56:28  <gmaxwell> okay, fair enough.
 972018-02-05T02:56:39  <gmaxwell> I could see paying to an empty address or 0x00 or something as a result.
 982018-02-05T02:56:45  *** pgupta has quit IRC
 992018-02-05T02:57:02  <conman> exploding is actually preferable to that :P
1002018-02-05T02:57:03  <gmaxwell> (though man, that would be fragile!)
1012018-02-05T02:57:11  <conman> heh
1022018-02-05T02:57:50  <gmaxwell> in any case, it's pretty straight forward to convert BC1 addressesto scriptpubkeys.
1032018-02-05T02:58:02  <conman> yeah that's what I need to figure out how to do
1042018-02-05T02:58:29  <gmaxwell> about the only gotcha is that the v0 vs other versions gap due to script.  There are test vectors that tell you what the resulting scriptpubkey should be.
1052018-02-05T02:58:37  * gmaxwell bbl
1062018-02-05T02:58:43  <conman> ty
1072018-02-05T02:59:27  <conman> hmm is there a core rpc that converts it to scriptpubkeys?
1082018-02-05T02:59:44  *** promag has joined #bitcoin-core-dev
1092018-02-05T02:59:45  <conman> I guess I need to investigate for myself
1102018-02-05T03:00:39  *** pgupta has joined #bitcoin-core-dev
1112018-02-05T03:04:44  *** promag has quit IRC
1122018-02-05T03:04:45  <conman> ok decode is one function, no rpc for it tho afaics
1132018-02-05T03:05:18  *** pgupta has quit IRC
1142018-02-05T03:09:22  *** justan0theruser has joined #bitcoin-core-dev
1152018-02-05T03:09:45  *** pgupta has joined #bitcoin-core-dev
1162018-02-05T03:10:24  *** justanotheruser has quit IRC
1172018-02-05T03:14:35  *** pgupta has quit IRC
1182018-02-05T03:18:50  *** pgupta has joined #bitcoin-core-dev
1192018-02-05T03:19:42  *** luke-jr has joined #bitcoin-core-dev
1202018-02-05T03:23:26  *** Giszmo has quit IRC
1212018-02-05T03:23:33  *** pgupta has quit IRC
1222018-02-05T03:26:52  <sipa> conman: validateaddress will give you the scriptpubkey iirc
1232018-02-05T03:27:11  <conman>  oh? That's awesome
1242018-02-05T03:27:57  *** pgupta has joined #bitcoin-core-dev
1252018-02-05T03:30:05  <conman> indeed it does
1262018-02-05T03:31:11  <conman> I should pay attention :P
1272018-02-05T03:32:48  *** pgupta has quit IRC
1282018-02-05T03:32:59  <conman> I seem to be duplicating work already done
1292018-02-05T03:33:35  <conman> oh and it returns the decoded address already
1302018-02-05T03:34:24  <sipa> what do you mean by decoded address?
1312018-02-05T03:34:44  <conman> bech32
1322018-02-05T03:34:52  <conman> no?
1332018-02-05T03:35:09  <conman> I'm looking at the function, not actually trying it
1342018-02-05T03:35:26  <sipa> if you give it a p2sh-p2wpkh, and it knows the script (which means it's your own address, really), it will report the embedded p2wpkh address
1352018-02-05T03:37:02  *** pgupta has joined #bitcoin-core-dev
1362018-02-05T03:37:40  <conman> okty
1372018-02-05T03:38:39  *** luke-jr has quit IRC
1382018-02-05T03:41:53  *** pgupta has quit IRC
1392018-02-05T03:46:08  *** pgupta has joined #bitcoin-core-dev
1402018-02-05T03:46:41  *** luke-jr has joined #bitcoin-core-dev
1412018-02-05T03:48:01  *** Emcy_ has joined #bitcoin-core-dev
1422018-02-05T03:49:57  *** Emcy has quit IRC
1432018-02-05T03:51:16  *** pgupta has quit IRC
1442018-02-05T03:51:41  *** belcher has quit IRC
1452018-02-05T03:58:33  *** mrannanay has joined #bitcoin-core-dev
1462018-02-05T04:13:14  *** serp has joined #bitcoin-core-dev
1472018-02-05T04:14:19  *** promag has joined #bitcoin-core-dev
1482018-02-05T04:15:04  *** Emcy has joined #bitcoin-core-dev
1492018-02-05T04:15:25  *** zivl has joined #bitcoin-core-dev
1502018-02-05T04:17:16  *** Emcy_ has quit IRC
1512018-02-05T04:19:24  *** promag has quit IRC
1522018-02-05T04:26:27  *** promag has joined #bitcoin-core-dev
1532018-02-05T04:29:49  <conman> ok this should be easy, check the validateaddress return value of "isscript" and then use the pubkey it returns with it
1542018-02-05T04:30:09  <conman> can consolidate and remove some of my duplicate code
1552018-02-05T04:30:56  *** promag has quit IRC
1562018-02-05T04:31:33  <sipa> conman: why do you need to know of something is a script?
1572018-02-05T04:31:44  <sipa> isscript will also return true for p2wsh
1582018-02-05T04:32:24  <conman> sipa: because I'm generating transactions
1592018-02-05T04:32:43  <conman> sec
1602018-02-05T04:33:20  <sipa> i'd expect that you'd need to put the scriptPubKey in the output?
1612018-02-05T04:33:52  <conman> I have two functions to determine what to put into the coinbase generation transaction
1622018-02-05T04:34:12  <conman> only 10 lines of code, so hopefully you wont mind me showing you? https://bitbucket.org/ckolivas/ckpool/src/0ab1e33e8193a28c7a4d9c89b5f6193fe926e7f2/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1733
1632018-02-05T04:34:25  <conman> address_to_pubkeytxn and address_to_scripttxn is what I currently use
1642018-02-05T04:34:39  <conman> it's extremely braindead
1652018-02-05T04:35:01  <sipa> right, but for p2wsh and p2wpkh you'll need more
1662018-02-05T04:35:12  <conman> hrm that's what I feared
1672018-02-05T04:35:23  <sipa> there is reference c code for doing that, btw
1682018-02-05T04:35:36  <conman> I must be looking in the wrong places
1692018-02-05T04:35:37  <sipa> https://github.com/sipa/bech32
1702018-02-05T04:35:42  <conman> ty
1712018-02-05T04:35:42  <sipa> it's listed in the bip
1722018-02-05T04:38:34  <conman> that's to decode, understood thanks
1732018-02-05T04:38:57  <sipa> it does both
1742018-02-05T04:39:24  <conman> but I'm still fuzzy on what extra is needed on creating a generation transaction from a decoded segwit address as opposed to a p2sh address
1752018-02-05T04:40:13  <conman> you say I'll need more
1762018-02-05T04:40:44  *** pgupta has joined #bitcoin-core-dev
1772018-02-05T04:41:05  <sipa> yes, it needs to be a segwit output
1782018-02-05T04:41:08  <sipa> it's not hard
1792018-02-05T04:41:14  <sipa> but it will be different logic
1802018-02-05T04:41:29  <sipa> it OP_0 + 20-byte push for P2WPKH
1812018-02-05T04:41:40  <sipa> and OP_0 + 32-byte push for P2WSH
1822018-02-05T04:42:22  <conman> ah
1832018-02-05T04:44:15  <conman> so if there was a current p2wsh address in the coinbase txn in my current code's form it would go to a random nowhere
1842018-02-05T04:45:09  <sipa> presumably
1852018-02-05T04:45:15  <sipa> i didn't look very closely
1862018-02-05T04:45:25  <conman> :\
1872018-02-05T04:45:29  <conman> that's okay
1882018-02-05T04:45:50  *** pgupta has quit IRC
1892018-02-05T04:46:09  <luke-jr> how would a p2wsh address get in the txn if you don't put it there?
1902018-02-05T04:46:41  <conman> huh?
1912018-02-05T04:47:09  <conman> it just applies the existing logic for any 3x address to all 3x addresses
1922018-02-05T04:47:16  <conman> in a braindead fashion
1932018-02-05T04:47:32  <luke-jr> all 3x addresses should work with your code; I think sipa is talking about the new bc1 addresses
1942018-02-05T04:47:40  <conman> hrm
1952018-02-05T04:48:25  <sipa> yes,p2sh-p2wpkh addresses are for the sender indistinguishable from p2sh addresses, by design
1962018-02-05T04:48:34  <conman> okay so it's still okay
1972018-02-05T04:48:58  <sipa> i'm talking about bech32 address, which encode p2wsh and p2wpkh addresses, without bech32
1982018-02-05T04:49:28  <conman> yeah so once bech32 is decoded, what to do with it then is what I'm still coming to grips with
1992018-02-05T04:49:52  *** pgupta has joined #bitcoin-core-dev
2002018-02-05T04:51:59  <luke-jr> sipa's reference code has: int segwit_addr_decode(int* witver, uint8_t* witdata, size_t* witdata_len, const char* hrp, const char* addr)
2012018-02-05T04:52:17  <luke-jr> test to be sure, but I think you can just concatenate the witver, witdata_len, and witdata
2022018-02-05T04:52:33  <luke-jr> to make the scriptpubkey
2032018-02-05T04:52:58  <sipa> the unit test code even demosnstrates that, actually
2042018-02-05T04:53:29  <sipa> it's not part of the reference itaelf, because in production wallet code it would likely tie in with existing scriot creation code already
2052018-02-05T04:54:40  *** pgupta has quit IRC
2062018-02-05T04:55:22  *** harrymm has quit IRC
2072018-02-05T04:56:32  <luke-jr> oh, right, you need to add 0x50 to any witver != 0
2082018-02-05T04:58:56  *** pgupta has joined #bitcoin-core-dev
2092018-02-05T05:01:05  *** arowser has joined #bitcoin-core-dev
2102018-02-05T05:03:05  <conman> bech32 automatically guarantees it is a p2w* address?
2112018-02-05T05:03:40  *** promag has joined #bitcoin-core-dev
2122018-02-05T05:03:43  <conman> oh my UPS hit
2132018-02-05T05:03:44  *** pgupta has quit IRC
2142018-02-05T05:03:54  * conman wonders if he's still connected
2152018-02-05T05:04:00  <luke-jr> it guaranteed it's a native segwit address, at least
2162018-02-05T05:04:03  <luke-jr> conman: yes
2172018-02-05T05:04:17  <conman> thanks, it's coming and going
2182018-02-05T05:04:27  <luke-jr> if there's a p2w-random-other-mode added in the future, bech32 will probably support that too without change
2192018-02-05T05:07:16  <conman> ok
2202018-02-05T05:08:02  *** pgupta has joined #bitcoin-core-dev
2212018-02-05T05:08:15  *** promag has quit IRC
2222018-02-05T05:13:15  *** pgupta has quit IRC
2232018-02-05T05:17:08  *** pgupta has joined #bitcoin-core-dev
2242018-02-05T05:22:00  *** pgupta has quit IRC
2252018-02-05T05:25:42  *** Evel-Knievel has quit IRC
2262018-02-05T05:26:15  *** pgupta has joined #bitcoin-core-dev
2272018-02-05T05:31:11  *** pgupta has quit IRC
2282018-02-05T05:33:53  *** promag has joined #bitcoin-core-dev
2292018-02-05T05:35:21  *** pgupta has joined #bitcoin-core-dev
2302018-02-05T05:38:01  *** AriseChikun has joined #bitcoin-core-dev
2312018-02-05T05:38:59  *** promag has quit IRC
2322018-02-05T05:40:15  *** pgupta has quit IRC
2332018-02-05T05:40:39  *** AriseChikun has quit IRC
2342018-02-05T05:41:08  *** AriseChikun has joined #bitcoin-core-dev
2352018-02-05T05:44:26  *** pgupta has joined #bitcoin-core-dev
2362018-02-05T05:49:04  *** pgupta has quit IRC
2372018-02-05T05:50:12  *** Lynet has quit IRC
2382018-02-05T05:53:33  *** pgupta has joined #bitcoin-core-dev
2392018-02-05T05:54:10  *** dabura667 has quit IRC
2402018-02-05T05:56:21  *** promag has joined #bitcoin-core-dev
2412018-02-05T05:58:29  *** pgupta has quit IRC
2422018-02-05T05:58:52  *** checksauce has quit IRC
2432018-02-05T06:00:48  *** promag has quit IRC
2442018-02-05T06:02:38  *** pgupta has joined #bitcoin-core-dev
2452018-02-05T06:07:18  *** pgupta has quit IRC
2462018-02-05T06:11:44  *** pgupta has joined #bitcoin-core-dev
2472018-02-05T06:16:27  *** pgupta has quit IRC
2482018-02-05T06:19:45  *** AriseChikun has quit IRC
2492018-02-05T06:20:50  *** pgupta has joined #bitcoin-core-dev
2502018-02-05T06:25:54  *** pgupta has quit IRC
2512018-02-05T06:28:02  *** checksauce has joined #bitcoin-core-dev
2522018-02-05T06:29:56  *** pgupta has joined #bitcoin-core-dev
2532018-02-05T06:34:15  *** sengehest has joined #bitcoin-core-dev
2542018-02-05T06:34:18  *** promag has joined #bitcoin-core-dev
2552018-02-05T06:34:41  *** pgupta has quit IRC
2562018-02-05T06:39:00  *** promag has quit IRC
2572018-02-05T06:39:05  *** pgupta has joined #bitcoin-core-dev
2582018-02-05T06:43:48  *** pgupta has quit IRC
2592018-02-05T06:48:10  *** pgupta has joined #bitcoin-core-dev
2602018-02-05T06:48:41  *** AriseChikun has joined #bitcoin-core-dev
2612018-02-05T06:50:38  *** Evel-Knievel has joined #bitcoin-core-dev
2622018-02-05T06:52:43  *** cryptojanitor has quit IRC
2632018-02-05T06:52:47  *** pgupta has quit IRC
2642018-02-05T06:57:01  <bitcoin-git> [bitcoin] kien999 opened pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
2652018-02-05T06:57:16  *** pgupta has joined #bitcoin-core-dev
2662018-02-05T06:57:51  <bitcoin-git> [bitcoin] fanquake closed pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
2672018-02-05T06:58:53  *** justan0theruser has quit IRC
2682018-02-05T06:59:09  *** AriseChikun has quit IRC
2692018-02-05T06:59:11  *** dabura667 has joined #bitcoin-core-dev
2702018-02-05T07:02:00  *** promag has joined #bitcoin-core-dev
2712018-02-05T07:02:17  *** pgupta has quit IRC
2722018-02-05T07:03:49  *** Victorsueca has quit IRC
2732018-02-05T07:04:56  *** Victorsueca has joined #bitcoin-core-dev
2742018-02-05T07:06:21  *** pgupta has joined #bitcoin-core-dev
2752018-02-05T07:06:27  *** promag has quit IRC
2762018-02-05T07:09:53  *** justan0theruser has joined #bitcoin-core-dev
2772018-02-05T07:10:55  *** sengehest has quit IRC
2782018-02-05T07:10:57  *** pgupta has quit IRC
2792018-02-05T07:15:27  *** pgupta has joined #bitcoin-core-dev
2802018-02-05T07:17:09  *** Sinclair6 has quit IRC
2812018-02-05T07:20:19  *** pgupta has quit IRC
2822018-02-05T07:24:34  *** pgupta has joined #bitcoin-core-dev
2832018-02-05T07:30:48  *** pgupta has quit IRC
2842018-02-05T07:33:44  *** pgupta has joined #bitcoin-core-dev
2852018-02-05T07:35:22  *** promag has joined #bitcoin-core-dev
2862018-02-05T07:35:52  *** tryphe has quit IRC
2872018-02-05T07:36:19  *** tryphe has joined #bitcoin-core-dev
2882018-02-05T07:37:56  *** pgupta has quit IRC
2892018-02-05T07:38:03  *** meshcollider has quit IRC
2902018-02-05T07:40:10  *** promag has quit IRC
2912018-02-05T07:48:53  *** promag has joined #bitcoin-core-dev
2922018-02-05T07:48:54  *** gribble has quit IRC
2932018-02-05T07:49:55  *** Rowland48West has quit IRC
2942018-02-05T07:51:36  *** pgupta has joined #bitcoin-core-dev
2952018-02-05T07:51:59  *** laurentmt has joined #bitcoin-core-dev
2962018-02-05T07:53:27  *** promag has quit IRC
2972018-02-05T07:53:27  *** Krellan has quit IRC
2982018-02-05T07:53:58  *** Krellan has joined #bitcoin-core-dev
2992018-02-05T07:54:57  *** gribble has joined #bitcoin-core-dev
3002018-02-05T07:55:57  *** pgupta has quit IRC
3012018-02-05T08:09:46  *** pgupta has joined #bitcoin-core-dev
3022018-02-05T08:12:59  *** Henri78Christian has joined #bitcoin-core-dev
3032018-02-05T08:14:09  *** Krellan has quit IRC
3042018-02-05T08:14:23  *** pgupta has quit IRC
3052018-02-05T08:17:04  <kallewoof> wumpus: we are in feature freeze right now, right? (was thinking of #10267)
3062018-02-05T08:17:07  <gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
3072018-02-05T08:20:45  <sipa> kallewoof: 0.16 is branched ofd
3082018-02-05T08:21:05  <sipa> so i don't think there is any freeze on the master branch, just not a lot of focus
3092018-02-05T08:27:56  *** pgupta has joined #bitcoin-core-dev
3102018-02-05T08:31:32  <kallewoof> sipa: ah, okay, cool :)
3112018-02-05T08:33:00  *** pgupta has quit IRC
3122018-02-05T08:35:47  *** jojeyh has quit IRC
3132018-02-05T08:39:21  *** farsider350 has joined #bitcoin-core-dev
3142018-02-05T08:46:08  *** pgupta has joined #bitcoin-core-dev
3152018-02-05T08:49:11  *** Henri78Christian has quit IRC
3162018-02-05T08:50:52  *** promag has joined #bitcoin-core-dev
3172018-02-05T08:50:59  *** pgupta has quit IRC
3182018-02-05T08:52:42  <Randolf> We need to be careful about updating copyright dates, and extending "2017" to a range of "2017-2018" instead of merely replacing with a new year of "2018."  I made these comments in this PR, but also mention it here in case someone else also encounters a year that needs updating elsewhere:
3192018-02-05T08:52:42  <Randolf> https://github.com/bitcoin/bitcoin/pull/12348
3202018-02-05T08:55:29  *** promag has quit IRC
3212018-02-05T08:56:28  *** nsh- is now known as nsh
3222018-02-05T08:57:29  *** FTBCraig has joined #bitcoin-core-dev
3232018-02-05T08:57:57  <FTBCraig> ho
3242018-02-05T08:58:07  <Randolf> FTBCraig:  ?
3252018-02-05T08:58:17  <FTBCraig> hi
3262018-02-05T08:58:25  <Randolf> Hello.
3272018-02-05T09:00:16  <dafuq> is it possible to get a log with the full output of a build? to see "g++ -Wall -whatever -o foo.o foo.c" instead of just "CXX     foo.o"
3282018-02-05T09:01:00  <dafuq> also ho
3292018-02-05T09:02:06  <Randolf> dafuq:  Do you have access to a tool called "script" (Unix, probably in Linux too)?  If so, that should capture everything for you.
3302018-02-05T09:03:18  <dafuq> no the problem is I don't see the "g++ ...", just "CXX ..." (which is cleaner admittedly)
3312018-02-05T09:03:53  <kallewoof> dafuq: do V=1 make
3322018-02-05T09:04:18  *** pgupta has joined #bitcoin-core-dev
3332018-02-05T09:04:18  <dafuq> cool, V for verbose?
3342018-02-05T09:04:20  <kallewoof> Yeah
3352018-02-05T09:04:36  <Randolf> You're asking to see the full commands.  That's actually quite interesting to know that V=1 will expose that.
3362018-02-05T09:04:58  <dafuq> thanks kallewoof what I was looking for
3372018-02-05T09:05:22  *** timothy has joined #bitcoin-core-dev
3382018-02-05T09:07:36  *** FTBCraig1 has joined #bitcoin-core-dev
3392018-02-05T09:09:30  *** pgupta has quit IRC
3402018-02-05T09:11:39  *** FTBCraig has quit IRC
3412018-02-05T09:13:26  *** FTBCraig has joined #bitcoin-core-dev
3422018-02-05T09:13:39  *** promag has joined #bitcoin-core-dev
3432018-02-05T09:14:41  <kallewoof> dafuq: great! :)
3442018-02-05T09:17:38  *** FTBCraig has quit IRC
3452018-02-05T09:18:10  *** promag has quit IRC
3462018-02-05T09:18:49  *** Enrico78Lind has joined #bitcoin-core-dev
3472018-02-05T09:22:29  *** pgupta has joined #bitcoin-core-dev
3482018-02-05T09:23:47  *** laurentmt has quit IRC
3492018-02-05T09:24:59  *** FTBCraig1 has quit IRC
3502018-02-05T09:25:18  *** FTBCraig has joined #bitcoin-core-dev
3512018-02-05T09:26:56  *** pgupta has quit IRC
3522018-02-05T09:28:27  *** promag has joined #bitcoin-core-dev
3532018-02-05T09:30:05  *** checksau_ has joined #bitcoin-core-dev
3542018-02-05T09:31:23  <wumpus> rc2 executables up https://bitcoincore.org/bin/bitcoin-core-0.16.0/test.rc2/
3552018-02-05T09:33:18  *** checksauce has quit IRC
3562018-02-05T09:34:35  *** FTBCraig has quit IRC
3572018-02-05T09:36:17  *** checksauce has joined #bitcoin-core-dev
3582018-02-05T09:39:29  *** promag has quit IRC
3592018-02-05T09:39:50  *** checksau_ has quit IRC
3602018-02-05T09:40:02  *** dabura667 has quit IRC
3612018-02-05T09:40:13  *** AriseChikun has joined #bitcoin-core-dev
3622018-02-05T09:40:25  *** dabura667 has joined #bitcoin-core-dev
3632018-02-05T09:40:39  *** pgupta has joined #bitcoin-core-dev
3642018-02-05T09:45:10  *** pgupta has quit IRC
3652018-02-05T09:45:50  *** anome has joined #bitcoin-core-dev
3662018-02-05T09:48:49  *** checksauce has quit IRC
3672018-02-05T09:50:02  *** FTBCraig has joined #bitcoin-core-dev
3682018-02-05T09:54:47  <Randolf> Nice!
3692018-02-05T09:56:26  *** Arise2 has joined #bitcoin-core-dev
3702018-02-05T09:57:34  *** AriseChikun has quit IRC
3712018-02-05T09:58:05  *** dabura667 has quit IRC
3722018-02-05T09:58:27  *** lnostdal has joined #bitcoin-core-dev
3732018-02-05T09:58:50  *** pgupta has joined #bitcoin-core-dev
3742018-02-05T09:59:14  *** promag has joined #bitcoin-core-dev
3752018-02-05T10:00:45  *** checksauce has joined #bitcoin-core-dev
3762018-02-05T10:02:53  *** Yuli has joined #bitcoin-core-dev
3772018-02-05T10:03:11  *** pgupta has quit IRC
3782018-02-05T10:05:05  *** promag has quit IRC
3792018-02-05T10:07:04  *** Yuli has quit IRC
3802018-02-05T10:08:39  *** Yuli has joined #bitcoin-core-dev
3812018-02-05T10:10:48  *** JackH_ has joined #bitcoin-core-dev
3822018-02-05T10:10:53  *** drizztbsd has joined #bitcoin-core-dev
3832018-02-05T10:11:08  *** JackH_ has quit IRC
3842018-02-05T10:11:16  *** Yuli has quit IRC
3852018-02-05T10:11:26  *** timothy has quit IRC
3862018-02-05T10:12:41  *** promag has joined #bitcoin-core-dev
3872018-02-05T10:13:05  *** JackH has quit IRC
3882018-02-05T10:14:36  *** mmgen has joined #bitcoin-core-dev
3892018-02-05T10:15:35  *** mmgen has quit IRC
3902018-02-05T10:15:42  *** Yuli has joined #bitcoin-core-dev
3912018-02-05T10:16:59  *** pgupta has joined #bitcoin-core-dev
3922018-02-05T10:17:44  *** mmgen has joined #bitcoin-core-dev
3932018-02-05T10:19:32  *** mmgen has quit IRC
3942018-02-05T10:20:20  *** promag has joined #bitcoin-core-dev
3952018-02-05T10:21:19  *** wxss has joined #bitcoin-core-dev
3962018-02-05T10:22:14  *** pgupta has quit IRC
3972018-02-05T10:25:29  *** dafuq[m] has joined #bitcoin-core-dev
3982018-02-05T10:25:51  *** larafale has joined #bitcoin-core-dev
3992018-02-05T10:26:30  *** pgupta has joined #bitcoin-core-dev
4002018-02-05T10:31:10  *** pgupta has quit IRC
4012018-02-05T10:31:56  *** shesek has joined #bitcoin-core-dev
4022018-02-05T10:31:56  *** shesek has joined #bitcoin-core-dev
4032018-02-05T10:43:01  *** pgupta has joined #bitcoin-core-dev
4042018-02-05T10:48:08  <dafuq> a pull request that changes the type of a variable in the code would fall under what prefix?
4052018-02-05T10:48:12  *** Yuli has quit IRC
4062018-02-05T10:48:27  <dafuq> not really trivial?
4072018-02-05T10:54:25  *** mmgen has joined #bitcoin-core-dev
4082018-02-05T10:54:42  *** AaronvanW has joined #bitcoin-core-dev
4092018-02-05T10:54:57  *** checksauce has quit IRC
4102018-02-05T10:55:19  *** checksauce has joined #bitcoin-core-dev
4112018-02-05T10:55:44  *** Arise2 has quit IRC
4122018-02-05T10:58:29  <bitcoin-git> [bitcoin] murrayn opened pull request #12351: Libraries: Use type more precisely indicating usage and avoid compilers warnings. (master...ptrdiff_t) https://github.com/bitcoin/bitcoin/pull/12351
4132018-02-05T11:01:36  *** AaronvanW has quit IRC
4142018-02-05T11:02:34  *** AaronvanW has joined #bitcoin-core-dev
4152018-02-05T11:04:44  *** promag has quit IRC
4162018-02-05T11:07:01  *** AaronvanW has quit IRC
4172018-02-05T11:07:39  *** farsider350 has quit IRC
4182018-02-05T11:08:01  *** farsider350 has joined #bitcoin-core-dev
4192018-02-05T11:08:22  *** farsider350 has joined #bitcoin-core-dev
4202018-02-05T11:08:44  *** farsider350 has joined #bitcoin-core-dev
4212018-02-05T11:09:09  *** farsider350 has joined #bitcoin-core-dev
4222018-02-05T11:09:34  *** farsider350 has joined #bitcoin-core-dev
4232018-02-05T11:09:52  *** tryphe has quit IRC
4242018-02-05T11:13:39  *** lnostdal has quit IRC
4252018-02-05T11:13:55  *** lnostdal has joined #bitcoin-core-dev
4262018-02-05T11:39:23  *** andytoshi has quit IRC
4272018-02-05T11:40:46  *** andytoshi has joined #bitcoin-core-dev
4282018-02-05T11:41:45  *** zautomata1 has quit IRC
4292018-02-05T11:42:50  *** bitcoin has joined #bitcoin-core-dev
4302018-02-05T11:45:06  *** Guyver2 has joined #bitcoin-core-dev
4312018-02-05T11:48:24  *** AaronvanW has joined #bitcoin-core-dev
4322018-02-05T11:54:21  *** promag has joined #bitcoin-core-dev
4332018-02-05T11:56:57  *** checksauce has quit IRC
4342018-02-05T12:01:52  *** AriseChikun has joined #bitcoin-core-dev
4352018-02-05T12:10:27  *** andytoshi has quit IRC
4362018-02-05T12:12:45  *** checksauce has joined #bitcoin-core-dev
4372018-02-05T12:17:54  *** arbitrary_guy has quit IRC
4382018-02-05T12:21:50  <bitcoin-git> [bitcoin] murrayn opened pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
4392018-02-05T12:23:16  <bitcoin-git> [bitcoin] fanquake closed pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
4402018-02-05T12:23:33  *** bitcoin has quit IRC
4412018-02-05T12:23:45  *** hodler has joined #bitcoin-core-dev
4422018-02-05T12:24:57  *** checksauce has quit IRC
4432018-02-05T12:28:08  *** hodler has quit IRC
4442018-02-05T12:29:40  *** ken2812221 has joined #bitcoin-core-dev
4452018-02-05T12:32:25  *** quer has quit IRC
4462018-02-05T12:33:22  *** quer has joined #bitcoin-core-dev
4472018-02-05T12:33:27  *** andytoshi has joined #bitcoin-core-dev
4482018-02-05T12:44:50  *** promag has quit IRC
4492018-02-05T12:45:46  <bitcoin-git> [bitcoin] fivepiece opened pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
4502018-02-05T12:45:52  *** checksauce has joined #bitcoin-core-dev
4512018-02-05T12:45:57  *** Enrico78Lind has quit IRC
4522018-02-05T12:46:01  <bitcoin-git> [bitcoin] fivepiece closed pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
4532018-02-05T12:46:11  <arubi> err sorry, wrong branch
4542018-02-05T12:47:35  *** Pavle has joined #bitcoin-core-dev
4552018-02-05T12:49:00  *** andytoshi has quit IRC
4562018-02-05T12:49:56  <bitcoin-git> [bitcoin] fivepiece opened pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354
4572018-02-05T12:50:17  <arubi> there we go
4582018-02-05T12:55:56  *** andytoshi has joined #bitcoin-core-dev
4592018-02-05T12:58:49  *** Pavle has quit IRC
4602018-02-05T13:03:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4612018-02-05T13:07:02  *** pgupta has quit IRC
4622018-02-05T13:13:33  *** CubicEarths has joined #bitcoin-core-dev
4632018-02-05T13:14:38  *** Sinclair6 has joined #bitcoin-core-dev
4642018-02-05T13:19:22  *** cryptojanitor has joined #bitcoin-core-dev
4652018-02-05T13:19:22  *** dafuq[m] has quit IRC
4662018-02-05T13:30:18  *** AaronvanW has quit IRC
4672018-02-05T13:30:54  *** AaronvanW has joined #bitcoin-core-dev
4682018-02-05T13:33:10  *** cryptojanitor is now known as SexyBeef77
4692018-02-05T13:34:16  *** AaronvanW has quit IRC
4702018-02-05T13:34:18  *** SexyBeef77 is now known as cryptojanitor
4712018-02-05T13:34:37  *** AaronvanW has joined #bitcoin-core-dev
4722018-02-05T13:36:38  *** pgupta has joined #bitcoin-core-dev
4732018-02-05T13:39:59  *** Chris_Stewart_5 has quit IRC
4742018-02-05T13:41:18  *** checksauce has quit IRC
4752018-02-05T13:41:55  *** promag has joined #bitcoin-core-dev
4762018-02-05T13:45:38  *** Amuza has joined #bitcoin-core-dev
4772018-02-05T13:46:46  *** Pavle has joined #bitcoin-core-dev
4782018-02-05T13:47:48  *** Pavle has quit IRC
4792018-02-05T13:48:44  *** belcher has joined #bitcoin-core-dev
4802018-02-05T14:00:58  *** zautomata has joined #bitcoin-core-dev
4812018-02-05T14:01:10  *** zautomata has joined #bitcoin-core-dev
4822018-02-05T14:02:12  *** Pavle has joined #bitcoin-core-dev
4832018-02-05T14:09:24  *** cheese_ has joined #bitcoin-core-dev
4842018-02-05T14:11:49  *** RoyceX has quit IRC
4852018-02-05T14:14:11  *** pgupta has quit IRC
4862018-02-05T14:15:01  *** Pavle has quit IRC
4872018-02-05T14:18:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4882018-02-05T14:27:05  *** zautomata has quit IRC
4892018-02-05T14:33:19  *** pgupta has joined #bitcoin-core-dev
4902018-02-05T14:34:40  *** laurentmt has joined #bitcoin-core-dev
4912018-02-05T14:36:26  *** checksauce has joined #bitcoin-core-dev
4922018-02-05T14:37:19  *** Giszmo has joined #bitcoin-core-dev
4932018-02-05T14:41:05  *** checksauce has quit IRC
4942018-02-05T14:41:50  *** checksauce has joined #bitcoin-core-dev
4952018-02-05T14:43:55  *** mandric has joined #bitcoin-core-dev
4962018-02-05T14:45:41  *** AaronvanW has quit IRC
4972018-02-05T14:46:17  *** AaronvanW has joined #bitcoin-core-dev
4982018-02-05T14:48:44  *** AaronvanW has quit IRC
4992018-02-05T14:49:31  *** AaronvanW has joined #bitcoin-core-dev
5002018-02-05T14:51:53  *** Victorsueca has quit IRC
5012018-02-05T14:53:05  *** Victorsueca has joined #bitcoin-core-dev
5022018-02-05T15:01:23  *** promag has quit IRC
5032018-02-05T15:03:16  *** AaronvanW has quit IRC
5042018-02-05T15:19:34  *** Krellan has joined #bitcoin-core-dev
5052018-02-05T15:19:44  *** SopaXorzTaker has joined #bitcoin-core-dev
5062018-02-05T15:26:30  *** checksauce has quit IRC
5072018-02-05T15:28:31  *** FTBCraig has quit IRC
5082018-02-05T15:30:38  *** checksauce has joined #bitcoin-core-dev
5092018-02-05T15:31:53  *** promag has joined #bitcoin-core-dev
5102018-02-05T15:33:23  *** laurentmt has quit IRC
5112018-02-05T15:33:53  *** neha has quit IRC
5122018-02-05T15:35:13  *** neha has joined #bitcoin-core-dev
5132018-02-05T15:36:44  *** promag has quit IRC
5142018-02-05T15:39:29  *** Pavle has joined #bitcoin-core-dev
5152018-02-05T15:39:48  *** Pavle has quit IRC
5162018-02-05T15:41:35  *** zautomata has joined #bitcoin-core-dev
5172018-02-05T15:52:02  *** promag has joined #bitcoin-core-dev
5182018-02-05T15:54:20  *** checksauce has quit IRC
5192018-02-05T15:55:42  <bitcoin-git> [bitcoin] Empact opened pull request #12356: Fix 'mempool min fee not met' debug output (master...minfee-message) https://github.com/bitcoin/bitcoin/pull/12356
5202018-02-05T15:56:45  *** promag has quit IRC
5212018-02-05T15:59:09  <bitcoin-git> [bitcoin] Empact opened pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
5222018-02-05T16:11:15  *** promag has joined #bitcoin-core-dev
5232018-02-05T16:15:55  *** Amuza has quit IRC
5242018-02-05T16:15:59  *** promag has quit IRC
5252018-02-05T16:24:02  *** Guyver2 has quit IRC
5262018-02-05T16:24:43  *** promag has joined #bitcoin-core-dev
5272018-02-05T16:27:21  *** pergaminho has joined #bitcoin-core-dev
5282018-02-05T16:29:45  *** promag has quit IRC
5292018-02-05T16:34:28  *** promag has joined #bitcoin-core-dev
5302018-02-05T16:35:32  *** pergaminho has quit IRC
5312018-02-05T16:36:16  *** pergaminho has joined #bitcoin-core-dev
5322018-02-05T16:47:44  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
5332018-02-05T16:48:27  *** promag has quit IRC
5342018-02-05T16:48:27  *** harrymm has joined #bitcoin-core-dev
5352018-02-05T16:49:35  *** Randolf has quit IRC
5362018-02-05T16:49:58  *** pergaminho has quit IRC
5372018-02-05T16:55:30  <bitcoin-git> [bitcoin] filips123 opened pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
5382018-02-05T16:55:31  *** promag has joined #bitcoin-core-dev
5392018-02-05T16:59:39  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12348: Update year to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12348
5402018-02-05T17:00:28  *** mandric has quit IRC
5412018-02-05T17:04:18  *** Krellan has quit IRC
5422018-02-05T17:08:27  *** AaronvanW has joined #bitcoin-core-dev
5432018-02-05T17:09:13  *** pgupta has quit IRC
5442018-02-05T17:13:10  *** Victorsueca has quit IRC
5452018-02-05T17:13:29  *** Randolf has joined #bitcoin-core-dev
5462018-02-05T17:13:39  *** Dizzle has joined #bitcoin-core-dev
5472018-02-05T17:14:27  *** Victorsueca has joined #bitcoin-core-dev
5482018-02-05T17:23:30  <bitcoin-git> [bitcoin] jnewbery opened pull request #12360: Bury bip9 deployments (master...bury_bip9_deployments) https://github.com/bitcoin/bitcoin/pull/12360
5492018-02-05T17:23:53  *** jarthur has joined #bitcoin-core-dev
5502018-02-05T17:27:19  *** Randolf has quit IRC
5512018-02-05T17:34:16  *** Amuza has joined #bitcoin-core-dev
5522018-02-05T17:40:17  *** mmgen has quit IRC
5532018-02-05T17:40:32  *** promag has quit IRC
5542018-02-05T17:41:36  *** mmgen has joined #bitcoin-core-dev
5552018-02-05T17:42:14  *** thiago has joined #bitcoin-core-dev
5562018-02-05T17:42:38  *** thiago is now known as Guest9589
5572018-02-05T17:46:00  *** drizztbsd has quit IRC
5582018-02-05T17:48:13  *** Giszmo has quit IRC
5592018-02-05T17:50:46  *** Krellan has joined #bitcoin-core-dev
5602018-02-05T17:56:25  *** owowo has joined #bitcoin-core-dev
5612018-02-05T17:58:09  *** Krellan has quit IRC
5622018-02-05T18:01:12  *** Amuza has quit IRC
5632018-02-05T18:06:32  *** Krellan has joined #bitcoin-core-dev
5642018-02-05T18:12:38  *** Krellan has quit IRC
5652018-02-05T18:19:16  *** JackH has joined #bitcoin-core-dev
5662018-02-05T18:21:29  *** Murch has joined #bitcoin-core-dev
5672018-02-05T18:22:57  *** arubi_ has joined #bitcoin-core-dev
5682018-02-05T18:23:21  *** arubi has quit IRC
5692018-02-05T18:25:17  *** Giszmo has joined #bitcoin-core-dev
5702018-02-05T18:27:19  *** he1io5 has joined #bitcoin-core-dev
5712018-02-05T18:28:59  *** Randolf has joined #bitcoin-core-dev
5722018-02-05T18:29:35  *** he1io5 has left #bitcoin-core-dev
5732018-02-05T18:40:05  *** PaulCapestany has quit IRC
5742018-02-05T18:40:48  *** Randolf has quit IRC
5752018-02-05T18:43:42  *** PaulCapestany has joined #bitcoin-core-dev
5762018-02-05T18:48:21  *** sengehest has joined #bitcoin-core-dev
5772018-02-05T18:52:21  *** Amuza has joined #bitcoin-core-dev
5782018-02-05T18:55:53  *** klow has left #bitcoin-core-dev
5792018-02-05T19:06:57  *** sengehest has quit IRC
5802018-02-05T19:07:04  *** AaronvanW has quit IRC
5812018-02-05T19:12:12  *** mandric has joined #bitcoin-core-dev
5822018-02-05T19:13:53  *** mirese_ has joined #bitcoin-core-dev
5832018-02-05T19:16:03  *** anome has quit IRC
5842018-02-05T19:17:34  *** mirese has quit IRC
5852018-02-05T19:19:04  *** Krellan has joined #bitcoin-core-dev
5862018-02-05T19:20:11  *** arubi_ has quit IRC
5872018-02-05T19:26:00  *** arubi has joined #bitcoin-core-dev
5882018-02-05T19:27:57  *** Krellan has quit IRC
5892018-02-05T19:29:03  *** CubicEarths has quit IRC
5902018-02-05T19:29:42  *** CubicEarths has joined #bitcoin-core-dev
5912018-02-05T19:32:58  *** SopaXorzTaker has quit IRC
5922018-02-05T19:34:32  *** jtimon has joined #bitcoin-core-dev
5932018-02-05T19:35:11  *** Krellan has joined #bitcoin-core-dev
5942018-02-05T19:37:51  *** Krellan has joined #bitcoin-core-dev
5952018-02-05T19:39:52  *** CubicEar_ has joined #bitcoin-core-dev
5962018-02-05T19:40:53  *** arbitrary_guy has joined #bitcoin-core-dev
5972018-02-05T19:43:12  *** CubicEarths has quit IRC
5982018-02-05T19:48:02  <sipa> wumpus, mesh_: i went over the release notes and added some things about validateaddress
5992018-02-05T19:48:09  <sipa> and made some more edits
6002018-02-05T19:48:17  *** dcousens has quit IRC
6012018-02-05T19:48:18  *** Chris_Stewart_5 has quit IRC
6022018-02-05T19:48:46  *** checksauce has joined #bitcoin-core-dev
6032018-02-05T19:48:49  <sipa> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes/_compare/8b4da4b6acc70361c00eaea5cc3929127f3733f0...024b9407344717a0c55ec48698c38328dad617c8
6042018-02-05T19:49:45  *** dcousens has joined #bitcoin-core-dev
6052018-02-05T20:06:35  *** Amuza has quit IRC
6062018-02-05T20:20:06  <BlueMatt> cfields: #12349 isnt a regression, right?
6072018-02-05T20:20:08  <gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
6082018-02-05T20:20:15  <BlueMatt> afaict you should absolutely be able to hit that same case in 0.15.1
6092018-02-05T20:20:30  <BlueMatt> just as long as your disk is somewhat slow to get the first block loaded before you can quit
6102018-02-05T20:23:17  <BlueMatt> oh, err...wow that's one hell of a race, you have to manage to kill right after pcoinsTip is created after the db is loaded and emptied and before the ActivateBestChain call in LoadChainTip (so that it returns from the ShutdownRequested() check)
6112018-02-05T20:27:32  <jtimon> so jnewbery, regarding #12360, do we want to remove bip9? don't we want to reuse that code for bip8 ?
6122018-02-05T20:27:33  <gribble> https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery · Pull Request #12360 · bitcoin/bitcoin · GitHub
6132018-02-05T20:30:06  <jtimon> nevermind you're just removing tests related to csv it seems, perhaps conserve some parts of feature_bip9_softforks with the dummy deployment?
6142018-02-05T20:31:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6152018-02-05T20:32:58  *** Randolf has joined #bitcoin-core-dev
6162018-02-05T20:34:12  *** AaronvanW has joined #bitcoin-core-dev
6172018-02-05T20:34:57  *** mandric has quit IRC
6182018-02-05T20:36:12  *** Victorsueca has quit IRC
6192018-02-05T20:37:27  *** Victorsueca has joined #bitcoin-core-dev
6202018-02-05T20:46:18  <cfields> BlueMatt: unsure. I hit it last night and didn't have time to look at it deeply, I just didn't want to forget about it. Looking now
6212018-02-05T20:46:19  *** eklitzke has quit IRC
6222018-02-05T20:46:52  <cfields> BlueMatt: I assumed it was a regression caused by the FlushStateToDisk changes in init, but sure, maybe it's unrelated
6232018-02-05T20:50:58  *** meshcollider has joined #bitcoin-core-dev
6242018-02-05T20:57:14  *** rex_4539 has joined #bitcoin-core-dev
6252018-02-05T21:01:19  *** AaronvanW has quit IRC
6262018-02-05T21:03:57  <jnewbery> jtimon: feature_bip9_softforks only tests CSV. it was never extended to test other bip9 deployments. It's also written using the comparison test framework, so i think it should just be removed
6272018-02-05T21:06:25  <jtimon> jnewbery: makes sense, thanks, we have the unittests for the dummy deployment anyway
6282018-02-05T21:16:45  *** Randolf has quit IRC
6292018-02-05T21:18:03  <arubi> if anybody's got some spare time for more review on #12315 or #12321, I'd appreciate your input
6302018-02-05T21:18:06  <gribble> https://github.com/bitcoin/bitcoin/issues/12315 | Bech32 addresses in dumpwallet by fivepiece · Pull Request #12315 · bitcoin/bitcoin · GitHub
6312018-02-05T21:18:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
6322018-02-05T21:19:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d32528e733f2...2a30e67d20f7
6332018-02-05T21:19:42  <bitcoin-git> bitcoin/master c409b1a João Barbosa: [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions
6342018-02-05T21:19:43  <bitcoin-git> bitcoin/master 2a30e67 MarcoFalke: Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions...
6352018-02-05T21:20:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (master...2018-02-listtransactions) https://github.com/bitcoin/bitcoin/pull/12330
6362018-02-05T21:22:27  *** Randolf has joined #bitcoin-core-dev
6372018-02-05T21:26:17  *** jarthur has quit IRC
6382018-02-05T21:26:17  *** Dizzle has quit IRC
6392018-02-05T21:28:41  *** mrannanay has quit IRC
6402018-02-05T21:30:12  *** checksauce has quit IRC
6412018-02-05T21:30:53  <BlueMatt> cfields: I dont recall any such changes in 0.16, though we did do a few late in 0.15
6422018-02-05T21:33:17  <cfields> BlueMatt: looks like you're right, I was thinking commit 3192975 was new for 0.16
6432018-02-05T21:33:33  *** checksauce has joined #bitcoin-core-dev
6442018-02-05T21:34:46  *** arbitrary_guy has quit IRC
6452018-02-05T21:35:01  *** mmgen has quit IRC
6462018-02-05T21:39:54  *** promag has joined #bitcoin-core-dev
6472018-02-05T21:44:15  *** andreas has joined #bitcoin-core-dev
6482018-02-05T21:49:48  *** Giszmo has quit IRC
6492018-02-05T21:55:17  *** Chris_Stewart_5 has quit IRC
6502018-02-05T21:58:28  *** andreas has quit IRC
6512018-02-05T22:03:01  *** satwo has joined #bitcoin-core-dev
6522018-02-05T22:05:24  *** eklitzke has joined #bitcoin-core-dev
6532018-02-05T22:07:29  *** mandric has joined #bitcoin-core-dev
6542018-02-05T22:11:06  *** lio1760 has joined #bitcoin-core-dev
6552018-02-05T22:11:10  *** Giszmo has joined #bitcoin-core-dev
6562018-02-05T22:14:18  *** satwo has quit IRC
6572018-02-05T22:19:38  *** arbitrary_guy has joined #bitcoin-core-dev
6582018-02-05T22:20:05  *** Giszmo has quit IRC
6592018-02-05T22:22:41  *** wunpunch has joined #bitcoin-core-dev
6602018-02-05T22:23:34  *** lio17 has quit IRC
6612018-02-05T22:24:26  <bitcoin-git> [bitcoin] fanquake closed pull request #11398: Hardcode CSV and SEGWIT deployment (master...csvburied) https://github.com/bitcoin/bitcoin/pull/11398
6622018-02-05T22:24:41  *** intcat has quit IRC
6632018-02-05T22:27:43  <bitcoin-git> [bitcoin] promag opened pull request #12361: Replace unreachable error handling with assertions in feebumber (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361
6642018-02-05T22:29:12  *** mandric has quit IRC
6652018-02-05T22:31:01  *** niska has quit IRC
6662018-02-05T22:32:25  *** satwo has joined #bitcoin-core-dev
6672018-02-05T22:36:37  *** niska has joined #bitcoin-core-dev
6682018-02-05T22:38:34  *** mandric has joined #bitcoin-core-dev
6692018-02-05T22:38:52  *** wunpunch has quit IRC
6702018-02-05T22:40:23  *** nehan has quit IRC
6712018-02-05T22:41:04  *** nehan has joined #bitcoin-core-dev
6722018-02-05T22:41:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6732018-02-05T22:44:33  *** lio1760 has quit IRC
6742018-02-05T22:45:09  *** lio1760 has joined #bitcoin-core-dev
6752018-02-05T22:47:39  *** tryphe has joined #bitcoin-core-dev
6762018-02-05T22:47:55  *** spinza has quit IRC
6772018-02-05T22:52:09  *** intcat has joined #bitcoin-core-dev
6782018-02-05T22:58:06  *** spinza has joined #bitcoin-core-dev
6792018-02-05T23:03:50  *** jigawatt has quit IRC
6802018-02-05T23:07:26  *** intcat has quit IRC
6812018-02-05T23:07:53  *** pgupta has joined #bitcoin-core-dev
6822018-02-05T23:08:18  *** wxss has quit IRC
6832018-02-05T23:08:55  *** intcat has joined #bitcoin-core-dev
6842018-02-05T23:09:01  *** Randolf has quit IRC
6852018-02-05T23:09:24  *** jigawatt has joined #bitcoin-core-dev
6862018-02-05T23:09:46  *** pgupta has quit IRC
6872018-02-05T23:12:09  *** lio1760 is now known as lio17
6882018-02-05T23:13:43  <promag> ryanofsky: are you aiming at me?
6892018-02-05T23:13:43  *** lio17 has quit IRC
6902018-02-05T23:14:14  *** lio17 has joined #bitcoin-core-dev
6912018-02-05T23:16:07  *** Randolf has joined #bitcoin-core-dev
6922018-02-05T23:16:29  *** AaronvanW has joined #bitcoin-core-dev
6932018-02-05T23:16:55  *** pgupta has joined #bitcoin-core-dev
6942018-02-05T23:21:37  *** pgupta has quit IRC
6952018-02-05T23:24:07  *** larafale has quit IRC
6962018-02-05T23:32:27  *** AaronvanW has quit IRC
6972018-02-05T23:36:21  *** lio17 has quit IRC
6982018-02-05T23:36:53  *** Cchadwicka has joined #bitcoin-core-dev
6992018-02-05T23:37:00  *** lio17 has joined #bitcoin-core-dev
7002018-02-05T23:37:06  *** FTBCraig has joined #bitcoin-core-dev
7012018-02-05T23:37:30  *** lio17 has quit IRC
7022018-02-05T23:38:10  *** lio17 has joined #bitcoin-core-dev
7032018-02-05T23:38:21  *** ossifrage has left #bitcoin-core-dev
7042018-02-05T23:39:01  *** Shayne has quit IRC
7052018-02-05T23:40:15  *** promag has quit IRC
7062018-02-05T23:41:45  *** Randolf has quit IRC
7072018-02-05T23:44:01  *** pgupta has joined #bitcoin-core-dev
7082018-02-05T23:47:45  *** Randolf has joined #bitcoin-core-dev
7092018-02-05T23:48:18  *** pgupta has quit IRC
7102018-02-05T23:56:16  *** Cogito_Ergo_Sum has quit IRC
7112018-02-05T23:57:11  *** Randolf has quit IRC