1 2018-02-05T00:04:33  *** Jeffery9Hauck has quit IRC
  2 2018-02-05T00:08:12  *** pgupta has quit IRC
  3 2018-02-05T00:09:07  *** Maud23Howell has joined #bitcoin-core-dev
  4 2018-02-05T00:16:30  *** pgupta has joined #bitcoin-core-dev
  5 2018-02-05T00:18:05  *** Maud23Howell has quit IRC
  6 2018-02-05T00:21:32  *** pgupta has quit IRC
  7 2018-02-05T00:25:56  *** promag has joined #bitcoin-core-dev
  8 2018-02-05T00:25:56  *** pgupta has joined #bitcoin-core-dev
  9 2018-02-05T00:30:36  *** promag has quit IRC
 10 2018-02-05T00:30:55  *** pgupta has quit IRC
 11 2018-02-05T00:31:24  *** kabaum has joined #bitcoin-core-dev
 12 2018-02-05T00:35:02  *** pgupta has joined #bitcoin-core-dev
 13 2018-02-05T00:40:14  *** pgupta has quit IRC
 14 2018-02-05T00:44:08  *** pgupta has joined #bitcoin-core-dev
 15 2018-02-05T00:45:30  *** owowo has quit IRC
 16 2018-02-05T00:48:44  *** pgupta has quit IRC
 17 2018-02-05T00:49:59  *** Murre has quit IRC
 18 2018-02-05T00:50:16  *** ghost43 has quit IRC
 19 2018-02-05T00:51:01  *** Randolf has joined #bitcoin-core-dev
 20 2018-02-05T00:53:14  *** pgupta has joined #bitcoin-core-dev
 21 2018-02-05T00:57:59  *** ghost43 has joined #bitcoin-core-dev
 22 2018-02-05T00:58:22  *** pgupta has quit IRC
 23 2018-02-05T00:58:24  *** meshcollider has joined #bitcoin-core-dev
 24 2018-02-05T00:59:21  *** dabura667 has joined #bitcoin-core-dev
 25 2018-02-05T01:02:20  *** pgupta has joined #bitcoin-core-dev
 26 2018-02-05T01:06:39  *** arbitrary_guy has joined #bitcoin-core-dev
 27 2018-02-05T01:07:05  *** pgupta has quit IRC
 28 2018-02-05T01:08:58  *** Rowland48West has joined #bitcoin-core-dev
 29 2018-02-05T01:11:44  *** pgupta has joined #bitcoin-core-dev
 30 2018-02-05T01:16:25  *** pgupta has quit IRC
 31 2018-02-05T01:17:25  *** cryptojanitor has quit IRC
 32 2018-02-05T01:20:33  *** pgupta has joined #bitcoin-core-dev
 33 2018-02-05T01:25:26  *** pgupta has quit IRC
 34 2018-02-05T01:29:40  *** pgupta has joined #bitcoin-core-dev
 35 2018-02-05T01:32:15  *** Krellan has quit IRC
 36 2018-02-05T01:33:03  *** Krellan has joined #bitcoin-core-dev
 37 2018-02-05T01:34:33  *** pgupta has quit IRC
 38 2018-02-05T01:37:52  *** promag has joined #bitcoin-core-dev
 39 2018-02-05T01:38:45  *** pgupta has joined #bitcoin-core-dev
 40 2018-02-05T01:42:25  *** promag has quit IRC
 41 2018-02-05T01:43:29  *** pgupta has quit IRC
 42 2018-02-05T01:47:50  *** pgupta has joined #bitcoin-core-dev
 43 2018-02-05T01:52:35  *** pgupta has quit IRC
 44 2018-02-05T01:56:56  *** pgupta has joined #bitcoin-core-dev
 45 2018-02-05T02:01:50  *** pgupta has quit IRC
 46 2018-02-05T02:05:05  *** promag has joined #bitcoin-core-dev
 47 2018-02-05T02:06:02  *** pgupta has joined #bitcoin-core-dev
 48 2018-02-05T02:08:31  *** arubi_ has joined #bitcoin-core-dev
 49 2018-02-05T02:09:50  *** arubi has quit IRC
 50 2018-02-05T02:10:33  *** promag has quit IRC
 51 2018-02-05T02:10:41  *** pgupta has quit IRC
 52 2018-02-05T02:13:13  *** cryptojanitor has joined #bitcoin-core-dev
 53 2018-02-05T02:15:11  *** pgupta has joined #bitcoin-core-dev
 54 2018-02-05T02:18:26  *** belcher has quit IRC
 55 2018-02-05T02:20:00  *** pgupta has quit IRC
 56 2018-02-05T02:24:14  *** pgupta has joined #bitcoin-core-dev
 57 2018-02-05T02:25:26  *** arubi_ has quit IRC
 58 2018-02-05T02:28:54  *** pgupta has quit IRC
 59 2018-02-05T02:30:30  *** arubi has joined #bitcoin-core-dev
 60 2018-02-05T02:33:22  *** pgupta has joined #bitcoin-core-dev
 61 2018-02-05T02:35:04  *** luke-jr has quit IRC
 62 2018-02-05T02:37:00  *** checksauce has joined #bitcoin-core-dev
 63 2018-02-05T02:37:57  *** pgupta has quit IRC
 64 2018-02-05T02:38:34  *** zautomata1 has joined #bitcoin-core-dev
 65 2018-02-05T02:40:08  *** gigoplast has joined #bitcoin-core-dev
 66 2018-02-05T02:40:22  *** zautomata has quit IRC
 67 2018-02-05T02:42:23  *** wunpunch has quit IRC
 68 2018-02-05T02:42:27  *** pgupta has joined #bitcoin-core-dev
 69 2018-02-05T02:43:55  *** gigoplast has left #bitcoin-core-dev
 70 2018-02-05T02:46:07  *** belcher has joined #bitcoin-core-dev
 71 2018-02-05T02:46:57  *** pgupta has quit IRC
 72 2018-02-05T02:50:12  *** conman has joined #bitcoin-core-dev
 73 2018-02-05T02:50:32  <conman> will 0.16.0 have bech32 support? I don't see it in the readme
 74 2018-02-05T02:51:08  <gmaxwell> conman: yes, it has BIP173 support for sending; and if you request it, for recieving too.
 75 2018-02-05T02:51:29  <conman> great, so validateaddress will return true for it too then
 76 2018-02-05T02:51:33  *** pgupta has joined #bitcoin-core-dev
 77 2018-02-05T02:51:33  <gmaxwell> it won't use it for rx by default, but you can set the default wallet wide, or request BC1 addresses on a case by case basis.
 78 2018-02-05T02:51:36  <gmaxwell> Yes.
 79 2018-02-05T02:51:40  <conman> ack
 80 2018-02-05T02:51:51  <conman> thanks
 81 2018-02-05T02:52:04  <conman> guess I better add support in my pools for it soon then
 82 2018-02-05T02:52:35  *** dabura667 has quit IRC
 83 2018-02-05T02:52:45  *** rhavar has quit IRC
 84 2018-02-05T02:53:05  <gmaxwell> would be nice, ... though we were expecting the rollout to take a long time.
 85 2018-02-05T02:53:17  <gmaxwell> Electrum has pushed it forward by making their segwit mode require it.
 86 2018-02-05T02:53:28  <conman> nod
 87 2018-02-05T02:54:21  <conman> my pool code asks bitcoin core to validate addresses so if I upgrade to .16 without adding support it will likely create corrupt generation transactions for bech32
 88 2018-02-05T02:54:48  <conman> should look to see what new rpc commands are in .16...
 89 2018-02-05T02:54:55  <gmaxwell> hm. how would it end up corrupt?
 90 2018-02-05T02:55:14  <conman> I hard code to look for a 3x address and it does p2sh output on that
 91 2018-02-05T02:55:42  <conman> if it doesn't see 3 it will assume it's a p2pkh and just code up the bech32 directly into that which will be of course a mess
 92 2018-02-05T02:56:09  <gmaxwell> how would it do that? the bech32 won't decode as base58.
 93 2018-02-05T02:56:13  *** dabura667 has joined #bitcoin-core-dev
 94 2018-02-05T02:56:19  <gmaxwell> even with an invalid checksum.
 95 2018-02-05T02:56:22  <conman> yeah that's what I mean, it will explode
 96 2018-02-05T02:56:28  <gmaxwell> okay, fair enough.
 97 2018-02-05T02:56:39  <gmaxwell> I could see paying to an empty address or 0x00 or something as a result.
 98 2018-02-05T02:56:45  *** pgupta has quit IRC
 99 2018-02-05T02:57:02  <conman> exploding is actually preferable to that :P
100 2018-02-05T02:57:03  <gmaxwell> (though man, that would be fragile!)
101 2018-02-05T02:57:11  <conman> heh
102 2018-02-05T02:57:50  <gmaxwell> in any case, it's pretty straight forward to convert BC1 addressesto scriptpubkeys.
103 2018-02-05T02:58:02  <conman> yeah that's what I need to figure out how to do
104 2018-02-05T02:58:29  <gmaxwell> about the only gotcha is that the v0 vs other versions gap due to script.  There are test vectors that tell you what the resulting scriptpubkey should be.
105 2018-02-05T02:58:37  * gmaxwell bbl
106 2018-02-05T02:58:43  <conman> ty
107 2018-02-05T02:59:27  <conman> hmm is there a core rpc that converts it to scriptpubkeys?
108 2018-02-05T02:59:44  *** promag has joined #bitcoin-core-dev
109 2018-02-05T02:59:45  <conman> I guess I need to investigate for myself
110 2018-02-05T03:00:39  *** pgupta has joined #bitcoin-core-dev
111 2018-02-05T03:04:44  *** promag has quit IRC
112 2018-02-05T03:04:45  <conman> ok decode is one function, no rpc for it tho afaics
113 2018-02-05T03:05:18  *** pgupta has quit IRC
114 2018-02-05T03:09:22  *** justan0theruser has joined #bitcoin-core-dev
115 2018-02-05T03:09:45  *** pgupta has joined #bitcoin-core-dev
116 2018-02-05T03:10:24  *** justanotheruser has quit IRC
117 2018-02-05T03:14:35  *** pgupta has quit IRC
118 2018-02-05T03:18:50  *** pgupta has joined #bitcoin-core-dev
119 2018-02-05T03:19:42  *** luke-jr has joined #bitcoin-core-dev
120 2018-02-05T03:23:26  *** Giszmo has quit IRC
121 2018-02-05T03:23:33  *** pgupta has quit IRC
122 2018-02-05T03:26:52  <sipa> conman: validateaddress will give you the scriptpubkey iirc
123 2018-02-05T03:27:11  <conman>  oh? That's awesome
124 2018-02-05T03:27:57  *** pgupta has joined #bitcoin-core-dev
125 2018-02-05T03:30:05  <conman> indeed it does
126 2018-02-05T03:31:11  <conman> I should pay attention :P
127 2018-02-05T03:32:48  *** pgupta has quit IRC
128 2018-02-05T03:32:59  <conman> I seem to be duplicating work already done
129 2018-02-05T03:33:35  <conman> oh and it returns the decoded address already
130 2018-02-05T03:34:24  <sipa> what do you mean by decoded address?
131 2018-02-05T03:34:44  <conman> bech32
132 2018-02-05T03:34:52  <conman> no?
133 2018-02-05T03:35:09  <conman> I'm looking at the function, not actually trying it
134 2018-02-05T03:35:26  <sipa> if you give it a p2sh-p2wpkh, and it knows the script (which means it's your own address, really), it will report the embedded p2wpkh address
135 2018-02-05T03:37:02  *** pgupta has joined #bitcoin-core-dev
136 2018-02-05T03:37:40  <conman> okty
137 2018-02-05T03:38:39  *** luke-jr has quit IRC
138 2018-02-05T03:41:53  *** pgupta has quit IRC
139 2018-02-05T03:46:08  *** pgupta has joined #bitcoin-core-dev
140 2018-02-05T03:46:41  *** luke-jr has joined #bitcoin-core-dev
141 2018-02-05T03:48:01  *** Emcy_ has joined #bitcoin-core-dev
142 2018-02-05T03:49:57  *** Emcy has quit IRC
143 2018-02-05T03:51:16  *** pgupta has quit IRC
144 2018-02-05T03:51:41  *** belcher has quit IRC
145 2018-02-05T03:58:33  *** mrannanay has joined #bitcoin-core-dev
146 2018-02-05T04:13:14  *** serp has joined #bitcoin-core-dev
147 2018-02-05T04:14:19  *** promag has joined #bitcoin-core-dev
148 2018-02-05T04:15:04  *** Emcy has joined #bitcoin-core-dev
149 2018-02-05T04:15:25  *** zivl has joined #bitcoin-core-dev
150 2018-02-05T04:17:16  *** Emcy_ has quit IRC
151 2018-02-05T04:19:24  *** promag has quit IRC
152 2018-02-05T04:26:27  *** promag has joined #bitcoin-core-dev
153 2018-02-05T04:29:49  <conman> ok this should be easy, check the validateaddress return value of "isscript" and then use the pubkey it returns with it
154 2018-02-05T04:30:09  <conman> can consolidate and remove some of my duplicate code
155 2018-02-05T04:30:56  *** promag has quit IRC
156 2018-02-05T04:31:33  <sipa> conman: why do you need to know of something is a script?
157 2018-02-05T04:31:44  <sipa> isscript will also return true for p2wsh
158 2018-02-05T04:32:24  <conman> sipa: because I'm generating transactions
159 2018-02-05T04:32:43  <conman> sec
160 2018-02-05T04:33:20  <sipa> i'd expect that you'd need to put the scriptPubKey in the output?
161 2018-02-05T04:33:52  <conman> I have two functions to determine what to put into the coinbase generation transaction
162 2018-02-05T04:34:12  <conman> only 10 lines of code, so hopefully you wont mind me showing you? https://bitbucket.org/ckolivas/ckpool/src/0ab1e33e8193a28c7a4d9c89b5f6193fe926e7f2/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1733
163 2018-02-05T04:34:25  <conman> address_to_pubkeytxn and address_to_scripttxn is what I currently use
164 2018-02-05T04:34:39  <conman> it's extremely braindead
165 2018-02-05T04:35:01  <sipa> right, but for p2wsh and p2wpkh you'll need more
166 2018-02-05T04:35:12  <conman> hrm that's what I feared
167 2018-02-05T04:35:23  <sipa> there is reference c code for doing that, btw
168 2018-02-05T04:35:36  <conman> I must be looking in the wrong places
169 2018-02-05T04:35:37  <sipa> https://github.com/sipa/bech32
170 2018-02-05T04:35:42  <conman> ty
171 2018-02-05T04:35:42  <sipa> it's listed in the bip
172 2018-02-05T04:38:34  <conman> that's to decode, understood thanks
173 2018-02-05T04:38:57  <sipa> it does both
174 2018-02-05T04:39:24  <conman> but I'm still fuzzy on what extra is needed on creating a generation transaction from a decoded segwit address as opposed to a p2sh address
175 2018-02-05T04:40:13  <conman> you say I'll need more
176 2018-02-05T04:40:44  *** pgupta has joined #bitcoin-core-dev
177 2018-02-05T04:41:05  <sipa> yes, it needs to be a segwit output
178 2018-02-05T04:41:08  <sipa> it's not hard
179 2018-02-05T04:41:14  <sipa> but it will be different logic
180 2018-02-05T04:41:29  <sipa> it OP_0 + 20-byte push for P2WPKH
181 2018-02-05T04:41:40  <sipa> and OP_0 + 32-byte push for P2WSH
182 2018-02-05T04:42:22  <conman> ah
183 2018-02-05T04:44:15  <conman> so if there was a current p2wsh address in the coinbase txn in my current code's form it would go to a random nowhere
184 2018-02-05T04:45:09  <sipa> presumably
185 2018-02-05T04:45:15  <sipa> i didn't look very closely
186 2018-02-05T04:45:25  <conman> :\
187 2018-02-05T04:45:29  <conman> that's okay
188 2018-02-05T04:45:50  *** pgupta has quit IRC
189 2018-02-05T04:46:09  <luke-jr> how would a p2wsh address get in the txn if you don't put it there?
190 2018-02-05T04:46:41  <conman> huh?
191 2018-02-05T04:47:09  <conman> it just applies the existing logic for any 3x address to all 3x addresses
192 2018-02-05T04:47:16  <conman> in a braindead fashion
193 2018-02-05T04:47:32  <luke-jr> all 3x addresses should work with your code; I think sipa is talking about the new bc1 addresses
194 2018-02-05T04:47:40  <conman> hrm
195 2018-02-05T04:48:25  <sipa> yes,p2sh-p2wpkh addresses are for the sender indistinguishable from p2sh addresses, by design
196 2018-02-05T04:48:34  <conman> okay so it's still okay
197 2018-02-05T04:48:58  <sipa> i'm talking about bech32 address, which encode p2wsh and p2wpkh addresses, without bech32
198 2018-02-05T04:49:28  <conman> yeah so once bech32 is decoded, what to do with it then is what I'm still coming to grips with
199 2018-02-05T04:49:52  *** pgupta has joined #bitcoin-core-dev
200 2018-02-05T04:51:59  <luke-jr> sipa's reference code has: int segwit_addr_decode(int* witver, uint8_t* witdata, size_t* witdata_len, const char* hrp, const char* addr)
201 2018-02-05T04:52:17  <luke-jr> test to be sure, but I think you can just concatenate the witver, witdata_len, and witdata
202 2018-02-05T04:52:33  <luke-jr> to make the scriptpubkey
203 2018-02-05T04:52:58  <sipa> the unit test code even demosnstrates that, actually
204 2018-02-05T04:53:29  <sipa> it's not part of the reference itaelf, because in production wallet code it would likely tie in with existing scriot creation code already
205 2018-02-05T04:54:40  *** pgupta has quit IRC
206 2018-02-05T04:55:22  *** harrymm has quit IRC
207 2018-02-05T04:56:32  <luke-jr> oh, right, you need to add 0x50 to any witver != 0
208 2018-02-05T04:58:56  *** pgupta has joined #bitcoin-core-dev
209 2018-02-05T05:01:05  *** arowser has joined #bitcoin-core-dev
210 2018-02-05T05:03:05  <conman> bech32 automatically guarantees it is a p2w* address?
211 2018-02-05T05:03:40  *** promag has joined #bitcoin-core-dev
212 2018-02-05T05:03:43  <conman> oh my UPS hit
213 2018-02-05T05:03:44  *** pgupta has quit IRC
214 2018-02-05T05:03:54  * conman wonders if he's still connected
215 2018-02-05T05:04:00  <luke-jr> it guaranteed it's a native segwit address, at least
216 2018-02-05T05:04:03  <luke-jr> conman: yes
217 2018-02-05T05:04:17  <conman> thanks, it's coming and going
218 2018-02-05T05:04:27  <luke-jr> if there's a p2w-random-other-mode added in the future, bech32 will probably support that too without change
219 2018-02-05T05:07:16  <conman> ok
220 2018-02-05T05:08:02  *** pgupta has joined #bitcoin-core-dev
221 2018-02-05T05:08:15  *** promag has quit IRC
222 2018-02-05T05:13:15  *** pgupta has quit IRC
223 2018-02-05T05:17:08  *** pgupta has joined #bitcoin-core-dev
224 2018-02-05T05:22:00  *** pgupta has quit IRC
225 2018-02-05T05:25:42  *** Evel-Knievel has quit IRC
226 2018-02-05T05:26:15  *** pgupta has joined #bitcoin-core-dev
227 2018-02-05T05:31:11  *** pgupta has quit IRC
228 2018-02-05T05:33:53  *** promag has joined #bitcoin-core-dev
229 2018-02-05T05:35:21  *** pgupta has joined #bitcoin-core-dev
230 2018-02-05T05:38:01  *** AriseChikun has joined #bitcoin-core-dev
231 2018-02-05T05:38:59  *** promag has quit IRC
232 2018-02-05T05:40:15  *** pgupta has quit IRC
233 2018-02-05T05:40:39  *** AriseChikun has quit IRC
234 2018-02-05T05:41:08  *** AriseChikun has joined #bitcoin-core-dev
235 2018-02-05T05:44:26  *** pgupta has joined #bitcoin-core-dev
236 2018-02-05T05:49:04  *** pgupta has quit IRC
237 2018-02-05T05:50:12  *** Lynet has quit IRC
238 2018-02-05T05:53:33  *** pgupta has joined #bitcoin-core-dev
239 2018-02-05T05:54:10  *** dabura667 has quit IRC
240 2018-02-05T05:56:21  *** promag has joined #bitcoin-core-dev
241 2018-02-05T05:58:29  *** pgupta has quit IRC
242 2018-02-05T05:58:52  *** checksauce has quit IRC
243 2018-02-05T06:00:48  *** promag has quit IRC
244 2018-02-05T06:02:38  *** pgupta has joined #bitcoin-core-dev
245 2018-02-05T06:07:18  *** pgupta has quit IRC
246 2018-02-05T06:11:44  *** pgupta has joined #bitcoin-core-dev
247 2018-02-05T06:16:27  *** pgupta has quit IRC
248 2018-02-05T06:19:45  *** AriseChikun has quit IRC
249 2018-02-05T06:20:50  *** pgupta has joined #bitcoin-core-dev
250 2018-02-05T06:25:54  *** pgupta has quit IRC
251 2018-02-05T06:28:02  *** checksauce has joined #bitcoin-core-dev
252 2018-02-05T06:29:56  *** pgupta has joined #bitcoin-core-dev
253 2018-02-05T06:34:15  *** sengehest has joined #bitcoin-core-dev
254 2018-02-05T06:34:18  *** promag has joined #bitcoin-core-dev
255 2018-02-05T06:34:41  *** pgupta has quit IRC
256 2018-02-05T06:39:00  *** promag has quit IRC
257 2018-02-05T06:39:05  *** pgupta has joined #bitcoin-core-dev
258 2018-02-05T06:43:48  *** pgupta has quit IRC
259 2018-02-05T06:48:10  *** pgupta has joined #bitcoin-core-dev
260 2018-02-05T06:48:41  *** AriseChikun has joined #bitcoin-core-dev
261 2018-02-05T06:50:38  *** Evel-Knievel has joined #bitcoin-core-dev
262 2018-02-05T06:52:43  *** cryptojanitor has quit IRC
263 2018-02-05T06:52:47  *** pgupta has quit IRC
264 2018-02-05T06:57:01  <bitcoin-git> [bitcoin] kien999 opened pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
265 2018-02-05T06:57:16  *** pgupta has joined #bitcoin-core-dev
266 2018-02-05T06:57:51  <bitcoin-git> [bitcoin] fanquake closed pull request #12350: i want (master...master) https://github.com/bitcoin/bitcoin/pull/12350
267 2018-02-05T06:58:53  *** justan0theruser has quit IRC
268 2018-02-05T06:59:09  *** AriseChikun has quit IRC
269 2018-02-05T06:59:11  *** dabura667 has joined #bitcoin-core-dev
270 2018-02-05T07:02:00  *** promag has joined #bitcoin-core-dev
271 2018-02-05T07:02:17  *** pgupta has quit IRC
272 2018-02-05T07:03:49  *** Victorsueca has quit IRC
273 2018-02-05T07:04:56  *** Victorsueca has joined #bitcoin-core-dev
274 2018-02-05T07:06:21  *** pgupta has joined #bitcoin-core-dev
275 2018-02-05T07:06:27  *** promag has quit IRC
276 2018-02-05T07:09:53  *** justan0theruser has joined #bitcoin-core-dev
277 2018-02-05T07:10:55  *** sengehest has quit IRC
278 2018-02-05T07:10:57  *** pgupta has quit IRC
279 2018-02-05T07:15:27  *** pgupta has joined #bitcoin-core-dev
280 2018-02-05T07:17:09  *** Sinclair6 has quit IRC
281 2018-02-05T07:20:19  *** pgupta has quit IRC
282 2018-02-05T07:24:34  *** pgupta has joined #bitcoin-core-dev
283 2018-02-05T07:30:48  *** pgupta has quit IRC
284 2018-02-05T07:33:44  *** pgupta has joined #bitcoin-core-dev
285 2018-02-05T07:35:22  *** promag has joined #bitcoin-core-dev
286 2018-02-05T07:35:52  *** tryphe has quit IRC
287 2018-02-05T07:36:19  *** tryphe has joined #bitcoin-core-dev
288 2018-02-05T07:37:56  *** pgupta has quit IRC
289 2018-02-05T07:38:03  *** meshcollider has quit IRC
290 2018-02-05T07:40:10  *** promag has quit IRC
291 2018-02-05T07:48:53  *** promag has joined #bitcoin-core-dev
292 2018-02-05T07:48:54  *** gribble has quit IRC
293 2018-02-05T07:49:55  *** Rowland48West has quit IRC
294 2018-02-05T07:51:36  *** pgupta has joined #bitcoin-core-dev
295 2018-02-05T07:51:59  *** laurentmt has joined #bitcoin-core-dev
296 2018-02-05T07:53:27  *** promag has quit IRC
297 2018-02-05T07:53:27  *** Krellan has quit IRC
298 2018-02-05T07:53:58  *** Krellan has joined #bitcoin-core-dev
299 2018-02-05T07:54:57  *** gribble has joined #bitcoin-core-dev
300 2018-02-05T07:55:57  *** pgupta has quit IRC
301 2018-02-05T08:09:46  *** pgupta has joined #bitcoin-core-dev
302 2018-02-05T08:12:59  *** Henri78Christian has joined #bitcoin-core-dev
303 2018-02-05T08:14:09  *** Krellan has quit IRC
304 2018-02-05T08:14:23  *** pgupta has quit IRC
305 2018-02-05T08:17:04  <kallewoof> wumpus: we are in feature freeze right now, right? (was thinking of #10267)
306 2018-02-05T08:17:07  <gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
307 2018-02-05T08:20:45  <sipa> kallewoof: 0.16 is branched ofd
308 2018-02-05T08:21:05  <sipa> so i don't think there is any freeze on the master branch, just not a lot of focus
309 2018-02-05T08:27:56  *** pgupta has joined #bitcoin-core-dev
310 2018-02-05T08:31:32  <kallewoof> sipa: ah, okay, cool :)
311 2018-02-05T08:33:00  *** pgupta has quit IRC
312 2018-02-05T08:35:47  *** jojeyh has quit IRC
313 2018-02-05T08:39:21  *** farsider350 has joined #bitcoin-core-dev
314 2018-02-05T08:46:08  *** pgupta has joined #bitcoin-core-dev
315 2018-02-05T08:49:11  *** Henri78Christian has quit IRC
316 2018-02-05T08:50:52  *** promag has joined #bitcoin-core-dev
317 2018-02-05T08:50:59  *** pgupta has quit IRC
318 2018-02-05T08:52:42  <Randolf> We need to be careful about updating copyright dates, and extending "2017" to a range of "2017-2018" instead of merely replacing with a new year of "2018."  I made these comments in this PR, but also mention it here in case someone else also encounters a year that needs updating elsewhere:
319 2018-02-05T08:52:42  <Randolf> https://github.com/bitcoin/bitcoin/pull/12348
320 2018-02-05T08:55:29  *** promag has quit IRC
321 2018-02-05T08:56:28  *** nsh- is now known as nsh
322 2018-02-05T08:57:29  *** FTBCraig has joined #bitcoin-core-dev
323 2018-02-05T08:57:57  <FTBCraig> ho
324 2018-02-05T08:58:07  <Randolf> FTBCraig:  ?
325 2018-02-05T08:58:17  <FTBCraig> hi
326 2018-02-05T08:58:25  <Randolf> Hello.
327 2018-02-05T09:00:16  <dafuq> is it possible to get a log with the full output of a build? to see "g++ -Wall -whatever -o foo.o foo.c" instead of just "CXX     foo.o"
328 2018-02-05T09:01:00  <dafuq> also ho
329 2018-02-05T09:02:06  <Randolf> dafuq:  Do you have access to a tool called "script" (Unix, probably in Linux too)?  If so, that should capture everything for you.
330 2018-02-05T09:03:18  <dafuq> no the problem is I don't see the "g++ ...", just "CXX ..." (which is cleaner admittedly)
331 2018-02-05T09:03:53  <kallewoof> dafuq: do V=1 make
332 2018-02-05T09:04:18  *** pgupta has joined #bitcoin-core-dev
333 2018-02-05T09:04:18  <dafuq> cool, V for verbose?
334 2018-02-05T09:04:20  <kallewoof> Yeah
335 2018-02-05T09:04:36  <Randolf> You're asking to see the full commands.  That's actually quite interesting to know that V=1 will expose that.
336 2018-02-05T09:04:58  <dafuq> thanks kallewoof what I was looking for
337 2018-02-05T09:05:22  *** timothy has joined #bitcoin-core-dev
338 2018-02-05T09:07:36  *** FTBCraig1 has joined #bitcoin-core-dev
339 2018-02-05T09:09:30  *** pgupta has quit IRC
340 2018-02-05T09:11:39  *** FTBCraig has quit IRC
341 2018-02-05T09:13:26  *** FTBCraig has joined #bitcoin-core-dev
342 2018-02-05T09:13:39  *** promag has joined #bitcoin-core-dev
343 2018-02-05T09:14:41  <kallewoof> dafuq: great! :)
344 2018-02-05T09:17:38  *** FTBCraig has quit IRC
345 2018-02-05T09:18:10  *** promag has quit IRC
346 2018-02-05T09:18:49  *** Enrico78Lind has joined #bitcoin-core-dev
347 2018-02-05T09:22:29  *** pgupta has joined #bitcoin-core-dev
348 2018-02-05T09:23:47  *** laurentmt has quit IRC
349 2018-02-05T09:24:59  *** FTBCraig1 has quit IRC
350 2018-02-05T09:25:18  *** FTBCraig has joined #bitcoin-core-dev
351 2018-02-05T09:26:56  *** pgupta has quit IRC
352 2018-02-05T09:28:27  *** promag has joined #bitcoin-core-dev
353 2018-02-05T09:30:05  *** checksau_ has joined #bitcoin-core-dev
354 2018-02-05T09:31:23  <wumpus> rc2 executables up https://bitcoincore.org/bin/bitcoin-core-0.16.0/test.rc2/
355 2018-02-05T09:33:18  *** checksauce has quit IRC
356 2018-02-05T09:34:35  *** FTBCraig has quit IRC
357 2018-02-05T09:36:17  *** checksauce has joined #bitcoin-core-dev
358 2018-02-05T09:39:29  *** promag has quit IRC
359 2018-02-05T09:39:50  *** checksau_ has quit IRC
360 2018-02-05T09:40:02  *** dabura667 has quit IRC
361 2018-02-05T09:40:13  *** AriseChikun has joined #bitcoin-core-dev
362 2018-02-05T09:40:25  *** dabura667 has joined #bitcoin-core-dev
363 2018-02-05T09:40:39  *** pgupta has joined #bitcoin-core-dev
364 2018-02-05T09:45:10  *** pgupta has quit IRC
365 2018-02-05T09:45:50  *** anome has joined #bitcoin-core-dev
366 2018-02-05T09:48:49  *** checksauce has quit IRC
367 2018-02-05T09:50:02  *** FTBCraig has joined #bitcoin-core-dev
368 2018-02-05T09:54:47  <Randolf> Nice!
369 2018-02-05T09:56:26  *** Arise2 has joined #bitcoin-core-dev
370 2018-02-05T09:57:34  *** AriseChikun has quit IRC
371 2018-02-05T09:58:05  *** dabura667 has quit IRC
372 2018-02-05T09:58:27  *** lnostdal has joined #bitcoin-core-dev
373 2018-02-05T09:58:50  *** pgupta has joined #bitcoin-core-dev
374 2018-02-05T09:59:14  *** promag has joined #bitcoin-core-dev
375 2018-02-05T10:00:45  *** checksauce has joined #bitcoin-core-dev
376 2018-02-05T10:02:53  *** Yuli has joined #bitcoin-core-dev
377 2018-02-05T10:03:11  *** pgupta has quit IRC
378 2018-02-05T10:05:05  *** promag has quit IRC
379 2018-02-05T10:07:04  *** Yuli has quit IRC
380 2018-02-05T10:08:39  *** Yuli has joined #bitcoin-core-dev
381 2018-02-05T10:10:48  *** JackH_ has joined #bitcoin-core-dev
382 2018-02-05T10:10:53  *** drizztbsd has joined #bitcoin-core-dev
383 2018-02-05T10:11:08  *** JackH_ has quit IRC
384 2018-02-05T10:11:16  *** Yuli has quit IRC
385 2018-02-05T10:11:26  *** timothy has quit IRC
386 2018-02-05T10:12:41  *** promag has joined #bitcoin-core-dev
387 2018-02-05T10:13:05  *** JackH has quit IRC
388 2018-02-05T10:14:36  *** mmgen has joined #bitcoin-core-dev
389 2018-02-05T10:15:35  *** mmgen has quit IRC
390 2018-02-05T10:15:42  *** Yuli has joined #bitcoin-core-dev
391 2018-02-05T10:16:59  *** pgupta has joined #bitcoin-core-dev
392 2018-02-05T10:17:44  *** mmgen has joined #bitcoin-core-dev
393 2018-02-05T10:19:32  *** mmgen has quit IRC
394 2018-02-05T10:20:20  *** promag has joined #bitcoin-core-dev
395 2018-02-05T10:21:19  *** wxss has joined #bitcoin-core-dev
396 2018-02-05T10:22:14  *** pgupta has quit IRC
397 2018-02-05T10:25:29  *** dafuq[m] has joined #bitcoin-core-dev
398 2018-02-05T10:25:51  *** larafale has joined #bitcoin-core-dev
399 2018-02-05T10:26:30  *** pgupta has joined #bitcoin-core-dev
400 2018-02-05T10:31:10  *** pgupta has quit IRC
401 2018-02-05T10:31:56  *** shesek has joined #bitcoin-core-dev
402 2018-02-05T10:31:56  *** shesek has joined #bitcoin-core-dev
403 2018-02-05T10:43:01  *** pgupta has joined #bitcoin-core-dev
404 2018-02-05T10:48:08  <dafuq> a pull request that changes the type of a variable in the code would fall under what prefix?
405 2018-02-05T10:48:12  *** Yuli has quit IRC
406 2018-02-05T10:48:27  <dafuq> not really trivial?
407 2018-02-05T10:54:25  *** mmgen has joined #bitcoin-core-dev
408 2018-02-05T10:54:42  *** AaronvanW has joined #bitcoin-core-dev
409 2018-02-05T10:54:57  *** checksauce has quit IRC
410 2018-02-05T10:55:19  *** checksauce has joined #bitcoin-core-dev
411 2018-02-05T10:55:44  *** Arise2 has quit IRC
412 2018-02-05T10:58:29  <bitcoin-git> [bitcoin] murrayn opened pull request #12351: Libraries: Use type more precisely indicating usage and avoid compilers warnings. (master...ptrdiff_t) https://github.com/bitcoin/bitcoin/pull/12351
413 2018-02-05T11:01:36  *** AaronvanW has quit IRC
414 2018-02-05T11:02:34  *** AaronvanW has joined #bitcoin-core-dev
415 2018-02-05T11:04:44  *** promag has quit IRC
416 2018-02-05T11:07:01  *** AaronvanW has quit IRC
417 2018-02-05T11:07:39  *** farsider350 has quit IRC
418 2018-02-05T11:08:01  *** farsider350 has joined #bitcoin-core-dev
419 2018-02-05T11:08:22  *** farsider350 has joined #bitcoin-core-dev
420 2018-02-05T11:08:44  *** farsider350 has joined #bitcoin-core-dev
421 2018-02-05T11:09:09  *** farsider350 has joined #bitcoin-core-dev
422 2018-02-05T11:09:34  *** farsider350 has joined #bitcoin-core-dev
423 2018-02-05T11:09:52  *** tryphe has quit IRC
424 2018-02-05T11:13:39  *** lnostdal has quit IRC
425 2018-02-05T11:13:55  *** lnostdal has joined #bitcoin-core-dev
426 2018-02-05T11:39:23  *** andytoshi has quit IRC
427 2018-02-05T11:40:46  *** andytoshi has joined #bitcoin-core-dev
428 2018-02-05T11:41:45  *** zautomata1 has quit IRC
429 2018-02-05T11:42:50  *** bitcoin has joined #bitcoin-core-dev
430 2018-02-05T11:45:06  *** Guyver2 has joined #bitcoin-core-dev
431 2018-02-05T11:48:24  *** AaronvanW has joined #bitcoin-core-dev
432 2018-02-05T11:54:21  *** promag has joined #bitcoin-core-dev
433 2018-02-05T11:56:57  *** checksauce has quit IRC
434 2018-02-05T12:01:52  *** AriseChikun has joined #bitcoin-core-dev
435 2018-02-05T12:10:27  *** andytoshi has quit IRC
436 2018-02-05T12:12:45  *** checksauce has joined #bitcoin-core-dev
437 2018-02-05T12:17:54  *** arbitrary_guy has quit IRC
438 2018-02-05T12:21:50  <bitcoin-git> [bitcoin] murrayn opened pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
439 2018-02-05T12:23:16  <bitcoin-git> [bitcoin] fanquake closed pull request #12352: Libraries: Get rid of compiler warning (master...logging_warning_fix) https://github.com/bitcoin/bitcoin/pull/12352
440 2018-02-05T12:23:33  *** bitcoin has quit IRC
441 2018-02-05T12:23:45  *** hodler has joined #bitcoin-core-dev
442 2018-02-05T12:24:57  *** checksauce has quit IRC
443 2018-02-05T12:28:08  *** hodler has quit IRC
444 2018-02-05T12:29:40  *** ken2812221 has joined #bitcoin-core-dev
445 2018-02-05T12:32:25  *** quer has quit IRC
446 2018-02-05T12:33:22  *** quer has joined #bitcoin-core-dev
447 2018-02-05T12:33:27  *** andytoshi has joined #bitcoin-core-dev
448 2018-02-05T12:44:50  *** promag has quit IRC
449 2018-02-05T12:45:46  <bitcoin-git> [bitcoin] fivepiece opened pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
450 2018-02-05T12:45:52  *** checksauce has joined #bitcoin-core-dev
451 2018-02-05T12:45:57  *** Enrico78Lind has quit IRC
452 2018-02-05T12:46:01  <bitcoin-git> [bitcoin] fivepiece closed pull request #12353: Add fivepiece gpg key (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12353
453 2018-02-05T12:46:11  <arubi> err sorry, wrong branch
454 2018-02-05T12:47:35  *** Pavle has joined #bitcoin-core-dev
455 2018-02-05T12:49:00  *** andytoshi has quit IRC
456 2018-02-05T12:49:56  <bitcoin-git> [bitcoin] fivepiece opened pull request #12354: add gpg key for fivepiece (master...add-fivepiece-gpg-key) https://github.com/bitcoin/bitcoin/pull/12354
457 2018-02-05T12:50:17  <arubi> there we go
458 2018-02-05T12:55:56  *** andytoshi has joined #bitcoin-core-dev
459 2018-02-05T12:58:49  *** Pavle has quit IRC
460 2018-02-05T13:03:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
461 2018-02-05T13:07:02  *** pgupta has quit IRC
462 2018-02-05T13:13:33  *** CubicEarths has joined #bitcoin-core-dev
463 2018-02-05T13:14:38  *** Sinclair6 has joined #bitcoin-core-dev
464 2018-02-05T13:19:22  *** cryptojanitor has joined #bitcoin-core-dev
465 2018-02-05T13:19:22  *** dafuq[m] has quit IRC
466 2018-02-05T13:30:18  *** AaronvanW has quit IRC
467 2018-02-05T13:30:54  *** AaronvanW has joined #bitcoin-core-dev
468 2018-02-05T13:33:10  *** cryptojanitor is now known as SexyBeef77
469 2018-02-05T13:34:16  *** AaronvanW has quit IRC
470 2018-02-05T13:34:18  *** SexyBeef77 is now known as cryptojanitor
471 2018-02-05T13:34:37  *** AaronvanW has joined #bitcoin-core-dev
472 2018-02-05T13:36:38  *** pgupta has joined #bitcoin-core-dev
473 2018-02-05T13:39:59  *** Chris_Stewart_5 has quit IRC
474 2018-02-05T13:41:18  *** checksauce has quit IRC
475 2018-02-05T13:41:55  *** promag has joined #bitcoin-core-dev
476 2018-02-05T13:45:38  *** Amuza has joined #bitcoin-core-dev
477 2018-02-05T13:46:46  *** Pavle has joined #bitcoin-core-dev
478 2018-02-05T13:47:48  *** Pavle has quit IRC
479 2018-02-05T13:48:44  *** belcher has joined #bitcoin-core-dev
480 2018-02-05T14:00:58  *** zautomata has joined #bitcoin-core-dev
481 2018-02-05T14:01:10  *** zautomata has joined #bitcoin-core-dev
482 2018-02-05T14:02:12  *** Pavle has joined #bitcoin-core-dev
483 2018-02-05T14:09:24  *** cheese_ has joined #bitcoin-core-dev
484 2018-02-05T14:11:49  *** RoyceX has quit IRC
485 2018-02-05T14:14:11  *** pgupta has quit IRC
486 2018-02-05T14:15:01  *** Pavle has quit IRC
487 2018-02-05T14:18:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
488 2018-02-05T14:27:05  *** zautomata has quit IRC
489 2018-02-05T14:33:19  *** pgupta has joined #bitcoin-core-dev
490 2018-02-05T14:34:40  *** laurentmt has joined #bitcoin-core-dev
491 2018-02-05T14:36:26  *** checksauce has joined #bitcoin-core-dev
492 2018-02-05T14:37:19  *** Giszmo has joined #bitcoin-core-dev
493 2018-02-05T14:41:05  *** checksauce has quit IRC
494 2018-02-05T14:41:50  *** checksauce has joined #bitcoin-core-dev
495 2018-02-05T14:43:55  *** mandric has joined #bitcoin-core-dev
496 2018-02-05T14:45:41  *** AaronvanW has quit IRC
497 2018-02-05T14:46:17  *** AaronvanW has joined #bitcoin-core-dev
498 2018-02-05T14:48:44  *** AaronvanW has quit IRC
499 2018-02-05T14:49:31  *** AaronvanW has joined #bitcoin-core-dev
500 2018-02-05T14:51:53  *** Victorsueca has quit IRC
501 2018-02-05T14:53:05  *** Victorsueca has joined #bitcoin-core-dev
502 2018-02-05T15:01:23  *** promag has quit IRC
503 2018-02-05T15:03:16  *** AaronvanW has quit IRC
504 2018-02-05T15:19:34  *** Krellan has joined #bitcoin-core-dev
505 2018-02-05T15:19:44  *** SopaXorzTaker has joined #bitcoin-core-dev
506 2018-02-05T15:26:30  *** checksauce has quit IRC
507 2018-02-05T15:28:31  *** FTBCraig has quit IRC
508 2018-02-05T15:30:38  *** checksauce has joined #bitcoin-core-dev
509 2018-02-05T15:31:53  *** promag has joined #bitcoin-core-dev
510 2018-02-05T15:33:23  *** laurentmt has quit IRC
511 2018-02-05T15:33:53  *** neha has quit IRC
512 2018-02-05T15:35:13  *** neha has joined #bitcoin-core-dev
513 2018-02-05T15:36:44  *** promag has quit IRC
514 2018-02-05T15:39:29  *** Pavle has joined #bitcoin-core-dev
515 2018-02-05T15:39:48  *** Pavle has quit IRC
516 2018-02-05T15:41:35  *** zautomata has joined #bitcoin-core-dev
517 2018-02-05T15:52:02  *** promag has joined #bitcoin-core-dev
518 2018-02-05T15:54:20  *** checksauce has quit IRC
519 2018-02-05T15:55:42  <bitcoin-git> [bitcoin] Empact opened pull request #12356: Fix 'mempool min fee not met' debug output (master...minfee-message) https://github.com/bitcoin/bitcoin/pull/12356
520 2018-02-05T15:56:45  *** promag has quit IRC
521 2018-02-05T15:59:09  <bitcoin-git> [bitcoin] Empact opened pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
522 2018-02-05T16:11:15  *** promag has joined #bitcoin-core-dev
523 2018-02-05T16:15:55  *** Amuza has quit IRC
524 2018-02-05T16:15:59  *** promag has quit IRC
525 2018-02-05T16:24:02  *** Guyver2 has quit IRC
526 2018-02-05T16:24:43  *** promag has joined #bitcoin-core-dev
527 2018-02-05T16:27:21  *** pergaminho has joined #bitcoin-core-dev
528 2018-02-05T16:29:45  *** promag has quit IRC
529 2018-02-05T16:34:28  *** promag has joined #bitcoin-core-dev
530 2018-02-05T16:35:32  *** pergaminho has quit IRC
531 2018-02-05T16:36:16  *** pergaminho has joined #bitcoin-core-dev
532 2018-02-05T16:47:44  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
533 2018-02-05T16:48:27  *** promag has quit IRC
534 2018-02-05T16:48:27  *** harrymm has joined #bitcoin-core-dev
535 2018-02-05T16:49:35  *** Randolf has quit IRC
536 2018-02-05T16:49:58  *** pergaminho has quit IRC
537 2018-02-05T16:55:30  <bitcoin-git> [bitcoin] filips123 opened pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
538 2018-02-05T16:55:31  *** promag has joined #bitcoin-core-dev
539 2018-02-05T16:59:39  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12348: Update year to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12348
540 2018-02-05T17:00:28  *** mandric has quit IRC
541 2018-02-05T17:04:18  *** Krellan has quit IRC
542 2018-02-05T17:08:27  *** AaronvanW has joined #bitcoin-core-dev
543 2018-02-05T17:09:13  *** pgupta has quit IRC
544 2018-02-05T17:13:10  *** Victorsueca has quit IRC
545 2018-02-05T17:13:29  *** Randolf has joined #bitcoin-core-dev
546 2018-02-05T17:13:39  *** Dizzle has joined #bitcoin-core-dev
547 2018-02-05T17:14:27  *** Victorsueca has joined #bitcoin-core-dev
548 2018-02-05T17:23:30  <bitcoin-git> [bitcoin] jnewbery opened pull request #12360: Bury bip9 deployments (master...bury_bip9_deployments) https://github.com/bitcoin/bitcoin/pull/12360
549 2018-02-05T17:23:53  *** jarthur has joined #bitcoin-core-dev
550 2018-02-05T17:27:19  *** Randolf has quit IRC
551 2018-02-05T17:34:16  *** Amuza has joined #bitcoin-core-dev
552 2018-02-05T17:40:17  *** mmgen has quit IRC
553 2018-02-05T17:40:32  *** promag has quit IRC
554 2018-02-05T17:41:36  *** mmgen has joined #bitcoin-core-dev
555 2018-02-05T17:42:14  *** thiago has joined #bitcoin-core-dev
556 2018-02-05T17:42:38  *** thiago is now known as Guest9589
557 2018-02-05T17:46:00  *** drizztbsd has quit IRC
558 2018-02-05T17:48:13  *** Giszmo has quit IRC
559 2018-02-05T17:50:46  *** Krellan has joined #bitcoin-core-dev
560 2018-02-05T17:56:25  *** owowo has joined #bitcoin-core-dev
561 2018-02-05T17:58:09  *** Krellan has quit IRC
562 2018-02-05T18:01:12  *** Amuza has quit IRC
563 2018-02-05T18:06:32  *** Krellan has joined #bitcoin-core-dev
564 2018-02-05T18:12:38  *** Krellan has quit IRC
565 2018-02-05T18:19:16  *** JackH has joined #bitcoin-core-dev
566 2018-02-05T18:21:29  *** Murch has joined #bitcoin-core-dev
567 2018-02-05T18:22:57  *** arubi_ has joined #bitcoin-core-dev
568 2018-02-05T18:23:21  *** arubi has quit IRC
569 2018-02-05T18:25:17  *** Giszmo has joined #bitcoin-core-dev
570 2018-02-05T18:27:19  *** he1io5 has joined #bitcoin-core-dev
571 2018-02-05T18:28:59  *** Randolf has joined #bitcoin-core-dev
572 2018-02-05T18:29:35  *** he1io5 has left #bitcoin-core-dev
573 2018-02-05T18:40:05  *** PaulCapestany has quit IRC
574 2018-02-05T18:40:48  *** Randolf has quit IRC
575 2018-02-05T18:43:42  *** PaulCapestany has joined #bitcoin-core-dev
576 2018-02-05T18:48:21  *** sengehest has joined #bitcoin-core-dev
577 2018-02-05T18:52:21  *** Amuza has joined #bitcoin-core-dev
578 2018-02-05T18:55:53  *** klow has left #bitcoin-core-dev
579 2018-02-05T19:06:57  *** sengehest has quit IRC
580 2018-02-05T19:07:04  *** AaronvanW has quit IRC
581 2018-02-05T19:12:12  *** mandric has joined #bitcoin-core-dev
582 2018-02-05T19:13:53  *** mirese_ has joined #bitcoin-core-dev
583 2018-02-05T19:16:03  *** anome has quit IRC
584 2018-02-05T19:17:34  *** mirese has quit IRC
585 2018-02-05T19:19:04  *** Krellan has joined #bitcoin-core-dev
586 2018-02-05T19:20:11  *** arubi_ has quit IRC
587 2018-02-05T19:26:00  *** arubi has joined #bitcoin-core-dev
588 2018-02-05T19:27:57  *** Krellan has quit IRC
589 2018-02-05T19:29:03  *** CubicEarths has quit IRC
590 2018-02-05T19:29:42  *** CubicEarths has joined #bitcoin-core-dev
591 2018-02-05T19:32:58  *** SopaXorzTaker has quit IRC
592 2018-02-05T19:34:32  *** jtimon has joined #bitcoin-core-dev
593 2018-02-05T19:35:11  *** Krellan has joined #bitcoin-core-dev
594 2018-02-05T19:37:51  *** Krellan has joined #bitcoin-core-dev
595 2018-02-05T19:39:52  *** CubicEar_ has joined #bitcoin-core-dev
596 2018-02-05T19:40:53  *** arbitrary_guy has joined #bitcoin-core-dev
597 2018-02-05T19:43:12  *** CubicEarths has quit IRC
598 2018-02-05T19:48:02  <sipa> wumpus, mesh_: i went over the release notes and added some things about validateaddress
599 2018-02-05T19:48:09  <sipa> and made some more edits
600 2018-02-05T19:48:17  *** dcousens has quit IRC
601 2018-02-05T19:48:18  *** Chris_Stewart_5 has quit IRC
602 2018-02-05T19:48:46  *** checksauce has joined #bitcoin-core-dev
603 2018-02-05T19:48:49  <sipa> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes/_compare/8b4da4b6acc70361c00eaea5cc3929127f3733f0...024b9407344717a0c55ec48698c38328dad617c8
604 2018-02-05T19:49:45  *** dcousens has joined #bitcoin-core-dev
605 2018-02-05T20:06:35  *** Amuza has quit IRC
606 2018-02-05T20:20:06  <BlueMatt> cfields: #12349 isnt a regression, right?
607 2018-02-05T20:20:08  <gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
608 2018-02-05T20:20:15  <BlueMatt> afaict you should absolutely be able to hit that same case in 0.15.1
609 2018-02-05T20:20:30  <BlueMatt> just as long as your disk is somewhat slow to get the first block loaded before you can quit
610 2018-02-05T20:23:17  <BlueMatt> oh, err...wow that's one hell of a race, you have to manage to kill right after pcoinsTip is created after the db is loaded and emptied and before the ActivateBestChain call in LoadChainTip (so that it returns from the ShutdownRequested() check)
611 2018-02-05T20:27:32  <jtimon> so jnewbery, regarding #12360, do we want to remove bip9? don't we want to reuse that code for bip8 ?
612 2018-02-05T20:27:33  <gribble> https://github.com/bitcoin/bitcoin/issues/12360 | Bury bip9 deployments by jnewbery · Pull Request #12360 · bitcoin/bitcoin · GitHub
613 2018-02-05T20:30:06  <jtimon> nevermind you're just removing tests related to csv it seems, perhaps conserve some parts of feature_bip9_softforks with the dummy deployment?
614 2018-02-05T20:31:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
615 2018-02-05T20:32:58  *** Randolf has joined #bitcoin-core-dev
616 2018-02-05T20:34:12  *** AaronvanW has joined #bitcoin-core-dev
617 2018-02-05T20:34:57  *** mandric has quit IRC
618 2018-02-05T20:36:12  *** Victorsueca has quit IRC
619 2018-02-05T20:37:27  *** Victorsueca has joined #bitcoin-core-dev
620 2018-02-05T20:46:18  <cfields> BlueMatt: unsure. I hit it last night and didn't have time to look at it deeply, I just didn't want to forget about it. Looking now
621 2018-02-05T20:46:19  *** eklitzke has quit IRC
622 2018-02-05T20:46:52  <cfields> BlueMatt: I assumed it was a regression caused by the FlushStateToDisk changes in init, but sure, maybe it's unrelated
623 2018-02-05T20:50:58  *** meshcollider has joined #bitcoin-core-dev
624 2018-02-05T20:57:14  *** rex_4539 has joined #bitcoin-core-dev
625 2018-02-05T21:01:19  *** AaronvanW has quit IRC
626 2018-02-05T21:03:57  <jnewbery> jtimon: feature_bip9_softforks only tests CSV. it was never extended to test other bip9 deployments. It's also written using the comparison test framework, so i think it should just be removed
627 2018-02-05T21:06:25  <jtimon> jnewbery: makes sense, thanks, we have the unittests for the dummy deployment anyway
628 2018-02-05T21:16:45  *** Randolf has quit IRC
629 2018-02-05T21:18:03  <arubi> if anybody's got some spare time for more review on #12315 or #12321, I'd appreciate your input
630 2018-02-05T21:18:06  <gribble> https://github.com/bitcoin/bitcoin/issues/12315 | Bech32 addresses in dumpwallet by fivepiece · Pull Request #12315 · bitcoin/bitcoin · GitHub
631 2018-02-05T21:18:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12321 | p2wsh address in decodescript by fivepiece · Pull Request #12321 · bitcoin/bitcoin · GitHub
632 2018-02-05T21:19:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d32528e733f2...2a30e67d20f7
633 2018-02-05T21:19:42  <bitcoin-git> bitcoin/master c409b1a João Barbosa: [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions
634 2018-02-05T21:19:43  <bitcoin-git> bitcoin/master 2a30e67 MarcoFalke: Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions...
635 2018-02-05T21:20:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (master...2018-02-listtransactions) https://github.com/bitcoin/bitcoin/pull/12330
636 2018-02-05T21:22:27  *** Randolf has joined #bitcoin-core-dev
637 2018-02-05T21:26:17  *** jarthur has quit IRC
638 2018-02-05T21:26:17  *** Dizzle has quit IRC
639 2018-02-05T21:28:41  *** mrannanay has quit IRC
640 2018-02-05T21:30:12  *** checksauce has quit IRC
641 2018-02-05T21:30:53  <BlueMatt> cfields: I dont recall any such changes in 0.16, though we did do a few late in 0.15
642 2018-02-05T21:33:17  <cfields> BlueMatt: looks like you're right, I was thinking commit 3192975 was new for 0.16
643 2018-02-05T21:33:33  *** checksauce has joined #bitcoin-core-dev
644 2018-02-05T21:34:46  *** arbitrary_guy has quit IRC
645 2018-02-05T21:35:01  *** mmgen has quit IRC
646 2018-02-05T21:39:54  *** promag has joined #bitcoin-core-dev
647 2018-02-05T21:44:15  *** andreas has joined #bitcoin-core-dev
648 2018-02-05T21:49:48  *** Giszmo has quit IRC
649 2018-02-05T21:55:17  *** Chris_Stewart_5 has quit IRC
650 2018-02-05T21:58:28  *** andreas has quit IRC
651 2018-02-05T22:03:01  *** satwo has joined #bitcoin-core-dev
652 2018-02-05T22:05:24  *** eklitzke has joined #bitcoin-core-dev
653 2018-02-05T22:07:29  *** mandric has joined #bitcoin-core-dev
654 2018-02-05T22:11:06  *** lio1760 has joined #bitcoin-core-dev
655 2018-02-05T22:11:10  *** Giszmo has joined #bitcoin-core-dev
656 2018-02-05T22:14:18  *** satwo has quit IRC
657 2018-02-05T22:19:38  *** arbitrary_guy has joined #bitcoin-core-dev
658 2018-02-05T22:20:05  *** Giszmo has quit IRC
659 2018-02-05T22:22:41  *** wunpunch has joined #bitcoin-core-dev
660 2018-02-05T22:23:34  *** lio17 has quit IRC
661 2018-02-05T22:24:26  <bitcoin-git> [bitcoin] fanquake closed pull request #11398: Hardcode CSV and SEGWIT deployment (master...csvburied) https://github.com/bitcoin/bitcoin/pull/11398
662 2018-02-05T22:24:41  *** intcat has quit IRC
663 2018-02-05T22:27:43  <bitcoin-git> [bitcoin] promag opened pull request #12361: Replace unreachable error handling with assertions in feebumber (master...2018-02-feebumper) https://github.com/bitcoin/bitcoin/pull/12361
664 2018-02-05T22:29:12  *** mandric has quit IRC
665 2018-02-05T22:31:01  *** niska has quit IRC
666 2018-02-05T22:32:25  *** satwo has joined #bitcoin-core-dev
667 2018-02-05T22:36:37  *** niska has joined #bitcoin-core-dev
668 2018-02-05T22:38:34  *** mandric has joined #bitcoin-core-dev
669 2018-02-05T22:38:52  *** wunpunch has quit IRC
670 2018-02-05T22:40:23  *** nehan has quit IRC
671 2018-02-05T22:41:04  *** nehan has joined #bitcoin-core-dev
672 2018-02-05T22:41:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
673 2018-02-05T22:44:33  *** lio1760 has quit IRC
674 2018-02-05T22:45:09  *** lio1760 has joined #bitcoin-core-dev
675 2018-02-05T22:47:39  *** tryphe has joined #bitcoin-core-dev
676 2018-02-05T22:47:55  *** spinza has quit IRC
677 2018-02-05T22:52:09  *** intcat has joined #bitcoin-core-dev
678 2018-02-05T22:58:06  *** spinza has joined #bitcoin-core-dev
679 2018-02-05T23:03:50  *** jigawatt has quit IRC
680 2018-02-05T23:07:26  *** intcat has quit IRC
681 2018-02-05T23:07:53  *** pgupta has joined #bitcoin-core-dev
682 2018-02-05T23:08:18  *** wxss has quit IRC
683 2018-02-05T23:08:55  *** intcat has joined #bitcoin-core-dev
684 2018-02-05T23:09:01  *** Randolf has quit IRC
685 2018-02-05T23:09:24  *** jigawatt has joined #bitcoin-core-dev
686 2018-02-05T23:09:46  *** pgupta has quit IRC
687 2018-02-05T23:12:09  *** lio1760 is now known as lio17
688 2018-02-05T23:13:43  <promag> ryanofsky: are you aiming at me?
689 2018-02-05T23:13:43  *** lio17 has quit IRC
690 2018-02-05T23:14:14  *** lio17 has joined #bitcoin-core-dev
691 2018-02-05T23:16:07  *** Randolf has joined #bitcoin-core-dev
692 2018-02-05T23:16:29  *** AaronvanW has joined #bitcoin-core-dev
693 2018-02-05T23:16:55  *** pgupta has joined #bitcoin-core-dev
694 2018-02-05T23:21:37  *** pgupta has quit IRC
695 2018-02-05T23:24:07  *** larafale has quit IRC
696 2018-02-05T23:32:27  *** AaronvanW has quit IRC
697 2018-02-05T23:36:21  *** lio17 has quit IRC
698 2018-02-05T23:36:53  *** Cchadwicka has joined #bitcoin-core-dev
699 2018-02-05T23:37:00  *** lio17 has joined #bitcoin-core-dev
700 2018-02-05T23:37:06  *** FTBCraig has joined #bitcoin-core-dev
701 2018-02-05T23:37:30  *** lio17 has quit IRC
702 2018-02-05T23:38:10  *** lio17 has joined #bitcoin-core-dev
703 2018-02-05T23:38:21  *** ossifrage has left #bitcoin-core-dev
704 2018-02-05T23:39:01  *** Shayne has quit IRC
705 2018-02-05T23:40:15  *** promag has quit IRC
706 2018-02-05T23:41:45  *** Randolf has quit IRC
707 2018-02-05T23:44:01  *** pgupta has joined #bitcoin-core-dev
708 2018-02-05T23:47:45  *** Randolf has joined #bitcoin-core-dev
709 2018-02-05T23:48:18  *** pgupta has quit IRC
710 2018-02-05T23:56:16  *** Cogito_Ergo_Sum has quit IRC
711 2018-02-05T23:57:11  *** Randolf has quit IRC