1 2018-02-06T00:09:16  *** FTBCraig has quit IRC
  2 2018-02-06T00:10:28  *** mandric has quit IRC
  3 2018-02-06T00:10:30  *** meshcollider has quit IRC
  4 2018-02-06T00:10:37  *** Cchadwicka has quit IRC
  5 2018-02-06T00:11:20  *** lnostdal has quit IRC
  6 2018-02-06T00:11:34  *** Cchadwicka has joined #bitcoin-core-dev
  7 2018-02-06T00:15:59  *** lnostdal has joined #bitcoin-core-dev
  8 2018-02-06T00:20:00  *** checksau_ has joined #bitcoin-core-dev
  9 2018-02-06T00:20:01  *** checksauce has quit IRC
 10 2018-02-06T00:20:17  *** pgupta has joined #bitcoin-core-dev
 11 2018-02-06T00:24:50  *** pgupta has quit IRC
 12 2018-02-06T00:27:36  *** rex_4539 has quit IRC
 13 2018-02-06T00:29:04  *** promag has joined #bitcoin-core-dev
 14 2018-02-06T00:30:14  <conman> heh is there a testnet explorer that recognises bech32 addresses? I've mined a few and can't see anything on any explorers
 15 2018-02-06T00:32:57  *** mandric has joined #bitcoin-core-dev
 16 2018-02-06T00:33:09  <conman> I guess it doesnt matter if my bitcoind shows it as present
 17 2018-02-06T00:33:23  *** intcat has quit IRC
 18 2018-02-06T00:33:51  *** Chris_Stewart_5 has quit IRC
 19 2018-02-06T00:34:56  *** checksau_ has quit IRC
 20 2018-02-06T00:35:28  *** checksauce has joined #bitcoin-core-dev
 21 2018-02-06T00:37:25  *** intcat has joined #bitcoin-core-dev
 22 2018-02-06T00:38:21  *** pgupta has joined #bitcoin-core-dev
 23 2018-02-06T00:42:39  *** pgupta has quit IRC
 24 2018-02-06T00:42:48  <gmaxwell> conman: smartbits shows them like this https://testnet.smartbit.com.au/tx/794bd7016aa9f70eea3138d231c22c981f68badc33ec037c38c356a812dd3958
 25 2018-02-06T00:44:44  <conman> https://testnet.smartbit.com.au/tx/252b673ff3af4a3282881137d3f3212b30dc758d9b86f38754c36a9a4f67688f
 26 2018-02-06T00:44:54  <conman> there's one I mined to a tb1 address
 27 2018-02-06T00:45:02  <conman> seems okay, but it can't decipher the address
 28 2018-02-06T00:47:01  <conman> does anyone have a sample testnet bech32 script address I can try?
 29 2018-02-06T00:47:32  *** promag has quit IRC
 30 2018-02-06T00:48:44  *** Emcy_ has joined #bitcoin-core-dev
 31 2018-02-06T00:48:54  <conman> oh there are samples online, nm
 32 2018-02-06T00:50:10  <conman> https://testnet.smartbit.com.au/tx/2f94872811ca3855cb7a5069bf2f4ea75377c3310d47a3ce36c082de19c205c3
 33 2018-02-06T00:50:14  <conman> there, mined a script one too
 34 2018-02-06T00:50:21  <conman> great, thanks everyone for your help
 35 2018-02-06T00:50:39  <gmaxwell> Did you make sure you handle version 0 vs later versions correctly?
 36 2018-02-06T00:50:53  <conman> no, I only handled v0 for now
 37 2018-02-06T00:51:24  <gmaxwell> ugh.
 38 2018-02-06T00:51:27  <gmaxwell> wtf dude.
 39 2018-02-06T00:51:34  <conman> I'm still coding ?
 40 2018-02-06T00:51:38  <gmaxwell> oh okay.
 41 2018-02-06T00:51:39  <gmaxwell> :P
 42 2018-02-06T00:51:40  <conman> haha
 43 2018-02-06T00:52:02  <gmaxwell> Back to work!
 44 2018-02-06T00:52:09  <conman> sir yes sir o\
 45 2018-02-06T00:52:21  *** Emcy has quit IRC
 46 2018-02-06T00:56:26  *** pgupta has joined #bitcoin-core-dev
 47 2018-02-06T00:57:12  <conman> and v > 0 needs 0x50 I was told... just looking to figure out where exactly Mr. 0x50 goes
 48 2018-02-06T00:58:40  <sipa> conman: BIP173 (https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki) under "The following list gives valid segwit addresses and the scriptPubKey that they translate to in hex" gives you what you need
 49 2018-02-06T00:59:11  <conman> ty again
 50 2018-02-06T01:00:44  *** pgupta has quit IRC
 51 2018-02-06T01:01:49  <conman> are versions > 0 currently valid on the network?
 52 2018-02-06T01:02:30  <sipa> they're nonstandard, but valid by consensus rules (otherwise introducing a  new version would require a hard fork)
 53 2018-02-06T01:02:46  <conman> great
 54 2018-02-06T01:02:48  *** dabura667 has joined #bitcoin-core-dev
 55 2018-02-06T01:03:02  <sipa> ideally wallets don't need an upgrade to be able to send to future versions, though
 56 2018-02-06T01:03:22  <conman> sure but I'm not creating a wallet per se
 57 2018-02-06T01:03:51  *** Emcy has joined #bitcoin-core-dev
 58 2018-02-06T01:06:04  *** Emcy_ has quit IRC
 59 2018-02-06T01:07:30  <conman> where does the op_reserved go for v>0 ? After the witness program?
 60 2018-02-06T01:07:42  <sipa> what op_reserved?
 61 2018-02-06T01:08:00  <conman> ‎[15:56] ‎<‎luke-jr‎>‎ oh, right, you need to add 0x50 to any witver != 0
 62 2018-02-06T01:08:18  <sipa> witver 1 = OP_1 + witness program push
 63 2018-02-06T01:08:26  <sipa> witver 0 = OP_0 + witness program push
 64 2018-02-06T01:08:27  <sipa> etc
 65 2018-02-06T01:08:30  <sipa> OP_1 is just 0x51
 66 2018-02-06T01:08:32  <conman> oh doh
 67 2018-02-06T01:08:35  <conman> lol
 68 2018-02-06T01:08:42  <sipa> while OP_0 is 0x00
 69 2018-02-06T01:08:48  * conman facepalms
 70 2018-02-06T01:08:58  <conman> thanks, now I know what you mean by add
 71 2018-02-06T01:09:00  <conman> thanks
 72 2018-02-06T01:09:02  <sipa> yw
 73 2018-02-06T01:13:48  *** Giszmo has joined #bitcoin-core-dev
 74 2018-02-06T01:14:27  *** JackH has quit IRC
 75 2018-02-06T01:14:28  *** pgupta has joined #bitcoin-core-dev
 76 2018-02-06T01:16:28  *** satwo has quit IRC
 77 2018-02-06T01:18:48  *** pgupta has quit IRC
 78 2018-02-06T01:23:05  *** zautomata1 has joined #bitcoin-core-dev
 79 2018-02-06T01:25:02  *** zautomata has quit IRC
 80 2018-02-06T01:27:15  <conman> well I made up a random v1 and it got mined
 81 2018-02-06T01:27:23  <conman> so that's good I guess
 82 2018-02-06T01:27:32  <conman> https://testnet.smartbit.com.au/tx/8f3fb2cba3deeb57d9432ca13b03306aac40638a99cce3fc06c6240ca65ac25f
 83 2018-02-06T01:31:08  <conman> alright, it's a wrap, I've pushed mine-to-bech32 support into my master branch
 84 2018-02-06T01:32:33  *** pgupta has joined #bitcoin-core-dev
 85 2018-02-06T01:32:40  <gmaxwell> conman: link the commit.
 86 2018-02-06T01:32:52  <conman> https://bitbucket.org/ckolivas/ckpool/commits/61513a765b12947fae30535179194b1672dc82b5
 87 2018-02-06T01:33:38  <conman> the address is first checked against bitcoind
 88 2018-02-06T01:33:49  <conman> hence why there's no error checking in that code
 89 2018-02-06T01:36:57  *** pgupta has quit IRC
 90 2018-02-06T01:46:45  <windsok> conman: this explorer is pretty good too https://tchain.btc.com/2f94872811ca3855cb7a5069bf2f4ea75377c3310d47a3ce36c082de19c205c3
 91 2018-02-06T01:50:37  *** pgupta has joined #bitcoin-core-dev
 92 2018-02-06T01:54:56  *** pgupta has quit IRC
 93 2018-02-06T01:59:08  *** zautomata1 has quit IRC
 94 2018-02-06T01:59:37  *** zautomata has joined #bitcoin-core-dev
 95 2018-02-06T02:00:03  *** zautomata has joined #bitcoin-core-dev
 96 2018-02-06T02:00:04  *** Randolf has joined #bitcoin-core-dev
 97 2018-02-06T02:06:34  <luke-jr> conman: anything can get mined. the trick is when you go to spend it
 98 2018-02-06T02:08:41  *** pgupta has joined #bitcoin-core-dev
 99 2018-02-06T02:09:49  <conman> windsok: thanks :)
100 2018-02-06T02:11:50  <conman> didn't know those scumbags had testnet explorer, I couldn't see the link initially
101 2018-02-06T02:14:25  *** pgupta has quit IRC
102 2018-02-06T02:22:07  <windsok> I'm no fan of bitmain, but I enjoy that explorer
103 2018-02-06T02:25:55  <conman> yeah it is actually good
104 2018-02-06T02:26:55  *** pgupta has joined #bitcoin-core-dev
105 2018-02-06T02:28:30  *** CubicEar_ has quit IRC
106 2018-02-06T02:28:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
107 2018-02-06T02:29:07  *** CubicEarths has joined #bitcoin-core-dev
108 2018-02-06T02:31:53  *** pgupta has quit IRC
109 2018-02-06T02:33:35  *** CubicEarths has quit IRC
110 2018-02-06T02:33:57  *** Randolf has quit IRC
111 2018-02-06T02:45:07  *** pgupta has joined #bitcoin-core-dev
112 2018-02-06T02:48:12  *** Chris_Stewart_5 has quit IRC
113 2018-02-06T02:49:18  *** pgupta has quit IRC
114 2018-02-06T02:49:36  *** flokie has joined #bitcoin-core-dev
115 2018-02-06T02:56:05  *** AriseChikun has quit IRC
116 2018-02-06T02:56:32  *** AriseChikun has joined #bitcoin-core-dev
117 2018-02-06T03:03:16  *** Giszmo has quit IRC
118 2018-02-06T03:03:18  *** pgupta has joined #bitcoin-core-dev
119 2018-02-06T03:03:58  *** Giszmo has joined #bitcoin-core-dev
120 2018-02-06T03:08:09  *** pgupta has quit IRC
121 2018-02-06T03:18:49  *** Randolf has joined #bitcoin-core-dev
122 2018-02-06T03:21:28  *** pgupta has joined #bitcoin-core-dev
123 2018-02-06T03:23:32  *** satwo has joined #bitcoin-core-dev
124 2018-02-06T03:25:56  *** pgupta has quit IRC
125 2018-02-06T03:27:28  *** Murch has quit IRC
126 2018-02-06T03:39:38  *** pgupta has joined #bitcoin-core-dev
127 2018-02-06T03:40:29  *** CubicEarths has joined #bitcoin-core-dev
128 2018-02-06T03:44:20  *** pgupta has quit IRC
129 2018-02-06T03:47:13  *** dgenr8 has quit IRC
130 2018-02-06T03:48:04  *** dgenr8 has joined #bitcoin-core-dev
131 2018-02-06T03:53:53  <jnewbery> I don't know how serious it is, but I've observed a new corrupted double-linked list error in master and v0.16rc2
132 2018-02-06T03:53:58  <jnewbery> #12362
133 2018-02-06T03:54:00  <gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
134 2018-02-06T03:54:43  <jnewbery> I've bisected it to a commit in the last couple of weeks or so
135 2018-02-06T03:55:06  <jnewbery> only observed when running multiple multiwallet.py tests in parallel
136 2018-02-06T03:55:32  <jnewbery> (or rather, when running multiwallet.py in parallel with other tests)
137 2018-02-06T03:56:49  *** meshcollider has joined #bitcoin-core-dev
138 2018-02-06T03:57:49  *** pgupta has joined #bitcoin-core-dev
139 2018-02-06T04:00:56  *** Krellan has quit IRC
140 2018-02-06T04:02:01  *** luke-jr has quit IRC
141 2018-02-06T04:02:09  *** pgupta has quit IRC
142 2018-02-06T04:02:21  *** luke-jr has joined #bitcoin-core-dev
143 2018-02-06T04:11:56  *** belcher has quit IRC
144 2018-02-06T04:15:59  *** pgupta has joined #bitcoin-core-dev
145 2018-02-06T04:20:05  *** pgupta has quit IRC
146 2018-02-06T04:24:46  *** dermoth has quit IRC
147 2018-02-06T04:25:18  *** dermoth has joined #bitcoin-core-dev
148 2018-02-06T04:34:10  *** pgupta has joined #bitcoin-core-dev
149 2018-02-06T04:38:18  *** pgupta has quit IRC
150 2018-02-06T04:52:05  <esotericnonsense> hm. has anyone used libjson-rpc-cpp with bitcoind?
151 2018-02-06T04:52:18  *** pgupta has joined #bitcoin-core-dev
152 2018-02-06T04:52:39  <esotericnonsense> I get a "The response is invalid" exception but it looks like perfectly cromulent json to me
153 2018-02-06T04:56:50  *** pgupta has quit IRC
154 2018-02-06T04:59:35  <sipa> can you paste it somewhere?
155 2018-02-06T04:59:58  <esotericnonsense> https://0bin.net/paste/XIEvc4xwV48k262L#AhFeXj9gcTlR-kcpU10eycgTuRaJ5HvS3TGT31wVyrn
156 2018-02-06T05:00:23  <esotericnonsense> the rpc passwords and stuff don't need to be censored btw. :P
157 2018-02-06T05:00:56  * esotericnonsense changes it to make that more explicit
158 2018-02-06T05:02:11  <esotericnonsense> using basically their example code it just seems to explode.
159 2018-02-06T05:06:01  *** Giszmo has quit IRC
160 2018-02-06T05:07:12  <esotericnonsense> (same happens for anything, getmininginfo for example, it pulls out the response but raises an exception)
161 2018-02-06T05:07:50  <sipa> looks fine to me
162 2018-02-06T05:09:10  <esotericnonsense> yeah. i'm trying to figure out where the exception originates from like whether it's trying to parse the json and failing somehow.
163 2018-02-06T05:10:30  *** pgupta has joined #bitcoin-core-dev
164 2018-02-06T05:15:42  *** pgupta has quit IRC
165 2018-02-06T05:16:08  *** mrannanay has joined #bitcoin-core-dev
166 2018-02-06T05:17:03  *** Giszmo has joined #bitcoin-core-dev
167 2018-02-06T05:19:08  *** cryptojanitor has quit IRC
168 2018-02-06T05:21:06  *** Giszmo has quit IRC
169 2018-02-06T05:24:05  <esotericnonsense> bah. it's json-rpc 1.0 not 2.0.
170 2018-02-06T05:25:07  <esotericnonsense> https://github.com/cinemast/libjson-rpc-cpp/blob/e960bf5c00489dd2451be087ac4f05c9e5a47aa4/src/jsonrpccpp/client/rpcprotocolclient.cpp#L109 this is where it borked. changing to v1.0 client works fine. thanks anyway sipa :)
171 2018-02-06T05:28:40  *** pgupta has joined #bitcoin-core-dev
172 2018-02-06T05:33:21  *** pgupta has quit IRC
173 2018-02-06T05:42:13  *** MrPaz has joined #bitcoin-core-dev
174 2018-02-06T05:45:24  *** tryphe has quit IRC
175 2018-02-06T05:45:47  *** tryphe has joined #bitcoin-core-dev
176 2018-02-06T05:46:52  *** pgupta has joined #bitcoin-core-dev
177 2018-02-06T05:51:21  *** pgupta has quit IRC
178 2018-02-06T06:05:02  *** pgupta has joined #bitcoin-core-dev
179 2018-02-06T06:08:43  *** sengehest has joined #bitcoin-core-dev
180 2018-02-06T06:09:30  *** pgupta has quit IRC
181 2018-02-06T06:11:18  *** meshcollider has quit IRC
182 2018-02-06T06:15:02  *** Cchadwicka has quit IRC
183 2018-02-06T06:23:13  *** pgupta has joined #bitcoin-core-dev
184 2018-02-06T06:24:31  *** CubicEarths has quit IRC
185 2018-02-06T06:27:57  *** pgupta has quit IRC
186 2018-02-06T06:29:06  *** pgupta has joined #bitcoin-core-dev
187 2018-02-06T06:36:05  *** sengehest has quit IRC
188 2018-02-06T06:39:42  *** pgupta has quit IRC
189 2018-02-06T06:47:11  *** pgupta has joined #bitcoin-core-dev
190 2018-02-06T06:51:45  *** pgupta has quit IRC
191 2018-02-06T07:07:46  *** jojeyh has joined #bitcoin-core-dev
192 2018-02-06T07:11:36  *** MrPaz has quit IRC
193 2018-02-06T07:14:17  *** pgupta has joined #bitcoin-core-dev
194 2018-02-06T07:14:42  *** Emcy_ has joined #bitcoin-core-dev
195 2018-02-06T07:17:56  *** Emcy has quit IRC
196 2018-02-06T07:18:09  *** rex_4539 has joined #bitcoin-core-dev
197 2018-02-06T07:18:56  *** pgupta has quit IRC
198 2018-02-06T07:19:08  *** Krellan has joined #bitcoin-core-dev
199 2018-02-06T07:21:13  *** Krellan has joined #bitcoin-core-dev
200 2018-02-06T07:50:17  *** satwo has quit IRC
201 2018-02-06T07:51:49  *** flokie has quit IRC
202 2018-02-06T07:56:32  *** Amuza has joined #bitcoin-core-dev
203 2018-02-06T08:01:51  *** meshcollider has joined #bitcoin-core-dev
204 2018-02-06T08:09:14  *** lnostdal has quit IRC
205 2018-02-06T08:24:14  *** BashCo_ has quit IRC
206 2018-02-06T08:26:06  *** BashCo has joined #bitcoin-core-dev
207 2018-02-06T08:30:51  *** pgupta has joined #bitcoin-core-dev
208 2018-02-06T08:34:46  *** justan0theruser has quit IRC
209 2018-02-06T08:35:46  *** Aliencorpse has quit IRC
210 2018-02-06T08:36:20  *** justanotheruser has joined #bitcoin-core-dev
211 2018-02-06T08:41:27  *** justanotheruser has quit IRC
212 2018-02-06T08:44:24  *** Aliencorpse has joined #bitcoin-core-dev
213 2018-02-06T08:45:04  *** pgupta has joined #bitcoin-core-dev
214 2018-02-06T08:51:24  *** intcat has quit IRC
215 2018-02-06T08:52:06  *** pgupta has quit IRC
216 2018-02-06T08:52:22  *** laurentmt has joined #bitcoin-core-dev
217 2018-02-06T08:52:34  *** intcat has joined #bitcoin-core-dev
218 2018-02-06T08:53:38  *** justanotheruser has joined #bitcoin-core-dev
219 2018-02-06T09:02:05  *** Krellan_ has joined #bitcoin-core-dev
220 2018-02-06T09:02:26  *** Krellan has quit IRC
221 2018-02-06T09:06:02  *** promag has joined #bitcoin-core-dev
222 2018-02-06T09:07:43  *** zautomata has quit IRC
223 2018-02-06T09:08:56  *** Pavle has joined #bitcoin-core-dev
224 2018-02-06T09:12:31  *** laurentmt has quit IRC
225 2018-02-06T09:12:46  *** arbitrary_guy has quit IRC
226 2018-02-06T09:13:02  <promag> wumpus: is this updated https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Aopen+project%3Abitcoin%2Fbitcoin%2F8+ ?
227 2018-02-06T09:13:45  <promag> which is/are more important?
228 2018-02-06T09:14:05  <promag> #10740 is wip, not sure if it should be in that list
229 2018-02-06T09:14:08  <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
230 2018-02-06T09:21:25  *** Krellan_ has quit IRC
231 2018-02-06T09:23:42  *** timothy has joined #bitcoin-core-dev
232 2018-02-06T09:25:41  *** timothy has joined #bitcoin-core-dev
233 2018-02-06T09:26:31  *** berndj has quit IRC
234 2018-02-06T09:27:22  *** Krellan has joined #bitcoin-core-dev
235 2018-02-06T09:30:39  *** dabura667 has quit IRC
236 2018-02-06T09:37:58  <wumpus> promag: no, that hasn't been updated for weeks, as the 0.16 milestone was effectively 'high priority for review', so we'll want to go over it next meeting and determine what still belongs there and what not
237 2018-02-06T09:38:35  <wumpus> I agree it's somewhat strange to have a WIP there
238 2018-02-06T09:40:23  *** whphhg_ has joined #bitcoin-core-dev
239 2018-02-06T09:40:45  *** whphhg has quit IRC
240 2018-02-06T09:40:53  <promag> are we done regarding feature freeze?
241 2018-02-06T09:41:00  *** whphhg_ is now known as whphhg
242 2018-02-06T09:47:12  *** AaronvanW has joined #bitcoin-core-dev
243 2018-02-06T09:47:13  <wumpus> yes, 0.16 is forked off
244 2018-02-06T09:47:22  <wumpus> so we can merge new features into master, if they're ready
245 2018-02-06T09:57:54  *** TheRec has quit IRC
246 2018-02-06T10:00:50  *** intcat has quit IRC
247 2018-02-06T10:04:27  *** intcat has joined #bitcoin-core-dev
248 2018-02-06T10:06:24  <bitcoin-git> [bitcoin] laanwj closed pull request #12359: Update license year range to 2018 (master...master) https://github.com/bitcoin/bitcoin/pull/12359
249 2018-02-06T10:07:11  *** Victorsueca has quit IRC
250 2018-02-06T10:08:21  *** Victorsueca has joined #bitcoin-core-dev
251 2018-02-06T10:09:36  <gmaxwell> wumpus: assuming no other issues come up do you think we'll release RC2 as final (now that we know that qt assert is not new and really fringe) or do you think we'd do an RC3 for that alone?
252 2018-02-06T10:11:24  *** berndj has joined #bitcoin-core-dev
253 2018-02-06T10:11:54  <wumpus> gmaxwell: as it's only a crash on shutdown and happens only in certain circumstances, I'd say we shouldn't hold up the release just for that
254 2018-02-06T10:12:32  <gmaxwell> thats my view. it's an assert and it looks like it requires lucky timing and a shutdown when started with reindex.
255 2018-02-06T10:12:58  <wumpus> right, an assertion fail, not even a proper 'crash'
256 2018-02-06T10:15:41  *** Pavle has quit IRC
257 2018-02-06T10:19:27  <gmaxwell> anyone else see a bunch of connections from 23.92.36.0/24 ?
258 2018-02-06T10:19:35  *** laurentmt has joined #bitcoin-core-dev
259 2018-02-06T10:19:57  <Sentineo> let me check
260 2018-02-06T10:20:39  *** dabura667 has joined #bitcoin-core-dev
261 2018-02-06T10:21:03  <Sentineo> gmaxwell: yes, 5
262 2018-02-06T10:22:09  <Sentineo> but I see it from tor and all bitcoinj:0.14.5
263 2018-02-06T10:22:35  *** dabura667 has quit IRC
264 2018-02-06T10:22:50  *** dabura667 has joined #bitcoin-core-dev
265 2018-02-06T10:23:16  <esotericnonsense> same
266 2018-02-06T10:23:17  *** dabura667 has quit IRC
267 2018-02-06T10:23:49  <esotericnonsense> i also have 5
268 2018-02-06T10:24:17  *** LeMiner2 has joined #bitcoin-core-dev
269 2018-02-06T10:24:24  <gmaxwell> Sentineo: what do you mean 'from tor'?
270 2018-02-06T10:24:42  *** promag has quit IRC
271 2018-02-06T10:25:58  <wumpus> connections from tor hs would come from 127.0.0.1
272 2018-02-06T10:26:21  <esotericnonsense> i also seem to have a ton of spy nodes or something odd like that lately
273 2018-02-06T10:26:36  * wumpus keeps typing listpeers instead of getpeerinfo now, argh
274 2018-02-06T10:26:40  *** LeMiner has quit IRC
275 2018-02-06T10:26:40  *** LeMiner2 is now known as LeMiner
276 2018-02-06T10:27:18  <esotericnonsense> actually perhaps not, i think i'm actually getting inbound peers where before i'd only get like 10 :op
277 2018-02-06T10:27:30  <wumpus> gmaxwell: yes, five here on two nodes  checked
278 2018-02-06T10:30:16  <wumpus> a .2 .51 .62 .52  .59 b .2  .54 .57 .59. .61
279 2018-02-06T10:32:28  <Sentineo> ah true for tor wumpus, but I do see the local address as 127.0.0.1:8333 for all of them.
280 2018-02-06T10:32:52  <Sentineo> so that is why I thought tor, but yeh it would come through tor socks ...
281 2018-02-06T10:34:17  <gmaxwell> wumpus: interesting, different hosts than I see too.
282 2018-02-06T10:34:48  <esotericnonsense> i have 2, 51, 44, 42, 41
283 2018-02-06T10:34:55  <Sentineo> not sure why some connections show for addrlocal my public IP, some show 127.0.0.1:8333 and some the ipv6 one.
284 2018-02-06T10:34:57  <esotericnonsense> https://esotericnonsense.com/ peers tab
285 2018-02-06T10:35:36  <gmaxwell> anyone see any outside of 23.92.36/24 but inside 23.92.32/20 ?
286 2018-02-06T10:36:04  <Sentineo> nope
287 2018-02-06T10:36:21  <Sentineo> http://node.ispol.sk/#!/overview - just the /24
288 2018-02-06T10:36:43  <wumpus> nope, all .36
289 2018-02-06T10:37:14  <gmaxwell> I think this is the first time I've added a subnet to my banlist.
290 2018-02-06T10:37:19  <Sentineo> 34,32,2,30,29
291 2018-02-06T10:41:56  <rabidus> .2, .56, .58, .59, .60
292 2018-02-06T10:45:34  <gmaxwell> Updated my banlists:
293 2018-02-06T10:45:36  <gmaxwell> https://people.xiph.org/~greg/banlist.cli.txt
294 2018-02-06T10:45:39  <gmaxwell> https://people.xiph.org/~greg/banlist.gui.txt
295 2018-02-06T10:48:33  <rabidus> entered those, 5 new ip address were banned
296 2018-02-06T10:48:56  <gmaxwell> rabidus: you mean 5 got disconnected as a result of loading those?
297 2018-02-06T10:49:01  <rabidus> yep
298 2018-02-06T10:49:35  <rabidus> i used your list ~6 months ago
299 2018-02-06T10:49:54  <gmaxwell> ::nods::
300 2018-02-06T10:50:00  <wumpus> esotericnonsense: just curious, what features prevent json rpc 2.0 from working?
301 2018-02-06T10:51:23  <Sentineo> is there a list for ipv6 gmaxwell ?
302 2018-02-06T10:53:41  *** TheRec has joined #bitcoin-core-dev
303 2018-02-06T10:53:57  *** nehan has quit IRC
304 2018-02-06T10:54:37  <wumpus> ipv6 nodes could be included in this list, there just aren't any  in it at the moment
305 2018-02-06T10:54:41  *** nehan has joined #bitcoin-core-dev
306 2018-02-06T10:55:18  <gmaxwell> I don't run v6 nodes currently, so I can't gather data on them.
307 2018-02-06T10:56:32  <wumpus> fwiw I have one node on ipv6
308 2018-02-06T10:56:51  <esotericnonsense> wumpus: i believe it's the client being strict about the spec
309 2018-02-06T10:56:54  <esotericnonsense> wumpus: see http://www.jsonrpc.org/specification#response_object
310 2018-02-06T10:57:02  <esotericnonsense> jsonrpc: A String specifying the version of the JSON-RPC protocol. MUST be exactly "2.0".
311 2018-02-06T10:57:13  <wumpus> esotericnonsense: sure, ok, but do you know what *specifically* it fails on
312 2018-02-06T10:57:23  <wumpus> oh simply the version number
313 2018-02-06T10:57:37  <esotericnonsense> there are other bits in the spec that are REQUIRED but at least in the core dev docs they're not REQUIRED (for the requests at least if not the responses)
314 2018-02-06T10:57:47  <esotericnonsense> but I know that the developer docs are often outdated
315 2018-02-06T10:57:54  <wumpus> can you try to lolpatch that to 2.0 and see if it works?
316 2018-02-06T10:58:00  <esotericnonsense> it doesn't even respond with jsonrpc
317 2018-02-06T10:58:13  *** zautomata has joined #bitcoin-core-dev
318 2018-02-06T10:58:14  <esotericnonsense> i.e. it's not jsonrpc 1.0, it's just not there :P
319 2018-02-06T10:58:28  *** zautomata has quit IRC
320 2018-02-06T10:58:28  *** zautomata has joined #bitcoin-core-dev
321 2018-02-06T10:58:39  <esotericnonsense> i can yeah but not immediately (a lolhack I suppose would be to reply with whatever was in the request :P)
322 2018-02-06T10:58:45  <wumpus> we pretty much do 2.0, there might be some small things missing
323 2018-02-06T10:59:17  *** Krellan has quit IRC
324 2018-02-06T11:00:16  <wumpus> for example features such as batching are 2.0 afaik
325 2018-02-06T11:02:28  *** shaowei has joined #bitcoin-core-dev
326 2018-02-06T11:03:11  <esotericnonsense> indeed
327 2018-02-06T11:03:28  * esotericnonsense now has coffee which was the important bit before trying to rpc2.0ise it
328 2018-02-06T11:05:05  *** Emcy has joined #bitcoin-core-dev
329 2018-02-06T11:07:11  *** Emcy_ has quit IRC
330 2018-02-06T11:11:06  *** meshcollider has quit IRC
331 2018-02-06T11:11:45  *** AaronvanW has quit IRC
332 2018-02-06T11:15:15  *** Krellan has joined #bitcoin-core-dev
333 2018-02-06T11:15:38  *** Pavle has joined #bitcoin-core-dev
334 2018-02-06T11:20:25  *** booyah_ has joined #bitcoin-core-dev
335 2018-02-06T11:20:55  *** booyah has quit IRC
336 2018-02-06T11:21:18  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a30e67d20f7...eaeaa2d0b4e8
337 2018-02-06T11:21:18  <bitcoin-git> bitcoin/master c887f87 Clem Taylor: Extend #11583 to include the most common message generated by non-contributing peers (port scanners?)...
338 2018-02-06T11:21:19  <bitcoin-git> bitcoin/master eaeaa2d Wladimir J. van der Laan: Merge #12342: Extend #11583 to include "version handshake timeout" message...
339 2018-02-06T11:21:25  <esotericnonsense> wumpus: nah that doesn't work. from looking at the code above (github link) it's clear why
340 2018-02-06T11:21:45  <esotericnonsense> it interprets the spec very literally. we send error: null when it wants the error field to not exist if there's a result
341 2018-02-06T11:22:10  <esotericnonsense> from memory i think we might also send result: null when the error is non-null
342 2018-02-06T11:22:19  <bitcoin-git> [bitcoin] laanwj closed pull request #12342: Extend #11583 to include "version handshake timeout" message (master...master) https://github.com/bitcoin/bitcoin/pull/12342
343 2018-02-06T11:22:24  * esotericnonsense tries hacking error to not exist ...
344 2018-02-06T11:22:41  <wumpus> in the long run we should move toward compliance with the spec, maybe first a command line option (for backwards compatiblity)
345 2018-02-06T11:23:35  <esotericnonsense> yes that works
346 2018-02-06T11:24:10  <esotericnonsense> lolpatch required to make it work in this specific instance: https://0bin.net/paste/d4-gThuaT2e1ZRk7#rsIjxU2jNyfmuWZHDaM76BRiVYOE723m7sP5vzVILEt
347 2018-02-06T11:24:22  *** Krellan has quit IRC
348 2018-02-06T11:24:25  <esotericnonsense> i agree, you'd need to track the client version though
349 2018-02-06T11:24:56  *** Krellan has joined #bitcoin-core-dev
350 2018-02-06T11:26:11  <esotericnonsense> it would have to be a commandline option because I think it would make sense to enforce the restrictions on the client at the same time
351 2018-02-06T11:26:53  <wumpus> I mean to moving to strict json rpc 2.0 only, and keep the hack-1.0 compatibility as a command line option for the forseeable future for backwards compatiblity
352 2018-02-06T11:27:03  <esotericnonsense> ah sure
353 2018-02-06T11:27:44  <esotericnonsense> that might be something I could look at in the next few weeks :)
354 2018-02-06T11:28:51  <wumpus> the way it is now is pretty much a historical mistake, but as a lot of software is written against our peculiar json-rpc dialect we can't and shouldn't completely drop it, but having a spec-compliant mode would be great
355 2018-02-06T11:30:15  <wumpus> awesome
356 2018-02-06T11:31:38  *** whphhg has quit IRC
357 2018-02-06T11:31:55  <wumpus> btcd has this option: --rpcquirks             Mirror some JSON-RPC quirks of Bitcoin Core -- NOTE: Discouraged unless interoperability issues need to be worked around   -- O dpm
358 2018-02-06T11:32:03  <wumpus> I don't know what it exactly changes
359 2018-02-06T11:32:49  *** whphhg has joined #bitcoin-core-dev
360 2018-02-06T11:33:56  <esotericnonsense> the JSONRPCReplyObj function seems to encapsulate all the problems if you could assume the client is jsonrpc 2.0
361 2018-02-06T11:34:27  <wumpus> ok
362 2018-02-06T11:34:28  <esotericnonsense> on the response side at least
363 2018-02-06T11:35:07  <esotericnonsense> i guess it's less important to be strict about what clients send you, but then you don't want to later have a 'really really jsonrpc2.0' flag
364 2018-02-06T11:35:07  <wumpus> right might be that bitcoin-cli needs changes as well
365 2018-02-06T11:35:08  <esotericnonsense> :P
366 2018-02-06T11:35:17  <esotericnonsense> yes\
367 2018-02-06T11:35:18  <wumpus> haha no
368 2018-02-06T11:36:12  * esotericnonsense wonders if bitcoind-ncurses would explode if the server were compliant
369 2018-02-06T11:37:11  * esotericnonsense smashes himself in the face with a hammer after remembering how he handles rpc in general
370 2018-02-06T11:40:31  *** wxss has joined #bitcoin-core-dev
371 2018-02-06T11:45:29  *** AaronvanW has joined #bitcoin-core-dev
372 2018-02-06T11:49:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/eaeaa2d0b4e8...9a32114626fc
373 2018-02-06T11:49:33  <bitcoin-git> bitcoin/master d3a185a Wladimir J. van der Laan: net: Move misbehaving logging to net logging category...
374 2018-02-06T11:49:34  <bitcoin-git> bitcoin/master 9a32114 Wladimir J. van der Laan: Merge #12218: net: Move misbehaving logging to net logging category...
375 2018-02-06T11:49:46  *** CubicEarths has joined #bitcoin-core-dev
376 2018-02-06T11:50:23  <bitcoin-git> [bitcoin] laanwj closed pull request #12218: net: Move misbehaving logging to net logging category (master...2018_01_misbehaving_logging) https://github.com/bitcoin/bitcoin/pull/12218
377 2018-02-06T11:53:46  *** AaronvanW has quit IRC
378 2018-02-06T11:54:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a32114626fc...c3451483d283
379 2018-02-06T11:54:25  <bitcoin-git> bitcoin/master eeeb416 murrayn: Remove suggestion to make cloned repository world-writable for Windows build.
380 2018-02-06T11:54:26  <bitcoin-git> bitcoin/master c345148 Wladimir J. van der Laan: Merge #12322: Docs: Remove step making cloned repository world-writable for Windows build....
381 2018-02-06T11:54:51  *** AaronvanW has joined #bitcoin-core-dev
382 2018-02-06T11:55:13  <bitcoin-git> [bitcoin] laanwj closed pull request #12322: Docs: Remove step making cloned repository world-writable for Windows build. (master...doc_change) https://github.com/bitcoin/bitcoin/pull/12322
383 2018-02-06T11:57:07  *** CubicEarths has quit IRC
384 2018-02-06T12:02:27  *** shaowei has quit IRC
385 2018-02-06T12:08:47  *** booyah_ has quit IRC
386 2018-02-06T12:08:57  *** booyah_ has joined #bitcoin-core-dev
387 2018-02-06T12:10:51  *** Guyver2 has joined #bitcoin-core-dev
388 2018-02-06T12:11:58  *** michagogo has quit IRC
389 2018-02-06T12:12:35  *** michagogo has joined #bitcoin-core-dev
390 2018-02-06T12:14:35  *** shesek has quit IRC
391 2018-02-06T12:19:43  *** mrannanay has quit IRC
392 2018-02-06T12:20:39  *** cryptojanitor has joined #bitcoin-core-dev
393 2018-02-06T12:23:37  *** shaowei has joined #bitcoin-core-dev
394 2018-02-06T12:25:20  *** Pavle has quit IRC
395 2018-02-06T12:30:23  *** ken2812221 has quit IRC
396 2018-02-06T12:39:26  *** AaronvanW has quit IRC
397 2018-02-06T12:39:37  <bitcoin-git> [bitcoin] laanwj closed pull request #12325: Use dynamic_cast for downcasting instead of static_cast. (master...use_dynamic_cast_to_downcast) https://github.com/bitcoin/bitcoin/pull/12325
398 2018-02-06T12:39:56  *** AaronvanW has joined #bitcoin-core-dev
399 2018-02-06T12:43:33  *** SopaXorzTaker has joined #bitcoin-core-dev
400 2018-02-06T12:45:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
401 2018-02-06T13:03:15  *** larafale has joined #bitcoin-core-dev
402 2018-02-06T13:04:55  *** larafale has quit IRC
403 2018-02-06T13:05:41  *** larafale has joined #bitcoin-core-dev
404 2018-02-06T13:09:57  *** larafale has quit IRC
405 2018-02-06T13:18:07  *** Chris_Stewart_5 has quit IRC
406 2018-02-06T13:20:52  *** shesek has joined #bitcoin-core-dev
407 2018-02-06T13:20:52  *** shesek has joined #bitcoin-core-dev
408 2018-02-06T13:27:48  *** SopaXorzTaker has quit IRC
409 2018-02-06T13:30:57  *** CubicEarths has joined #bitcoin-core-dev
410 2018-02-06T13:30:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
411 2018-02-06T13:35:18  *** Chris_Stewart_5 has quit IRC
412 2018-02-06T13:44:48  *** farmerwampum has quit IRC
413 2018-02-06T13:46:52  *** Giszmo has joined #bitcoin-core-dev
414 2018-02-06T13:48:03  *** Emcy_ has joined #bitcoin-core-dev
415 2018-02-06T13:49:02  *** shesek has quit IRC
416 2018-02-06T13:49:37  *** Emcy has quit IRC
417 2018-02-06T13:50:00  *** belcher has joined #bitcoin-core-dev
418 2018-02-06T13:55:07  *** shesek has joined #bitcoin-core-dev
419 2018-02-06T14:00:16  *** promag has joined #bitcoin-core-dev
420 2018-02-06T14:15:29  *** shesek has quit IRC
421 2018-02-06T14:15:34  *** promag has joined #bitcoin-core-dev
422 2018-02-06T14:17:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
423 2018-02-06T14:20:32  *** AaronvanW has quit IRC
424 2018-02-06T14:29:47  *** Krellan has quit IRC
425 2018-02-06T14:36:08  *** Krellan has joined #bitcoin-core-dev
426 2018-02-06T14:45:02  *** Krellan has quit IRC
427 2018-02-06T14:46:32  <bitcoin-git> [bitcoin] conscott opened pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
428 2018-02-06T14:50:13  *** Krellan has joined #bitcoin-core-dev
429 2018-02-06T14:50:37  *** shesek has joined #bitcoin-core-dev
430 2018-02-06T14:50:37  *** shesek has joined #bitcoin-core-dev
431 2018-02-06T14:54:50  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3451483d283...88971352f610
432 2018-02-06T14:54:51  <bitcoin-git> bitcoin/master faeab66 MarcoFalke: contrib: Replace developer keys with list of pgp fingerprints
433 2018-02-06T14:54:51  <bitcoin-git> bitcoin/master fabb72b MarcoFalke: contrib: Remove xpired 522739F6 key
434 2018-02-06T14:54:52  <bitcoin-git> bitcoin/master 8897135 Wladimir J. van der Laan: Merge #11909: contrib: Replace developer keys with list of pgp fingerprints...
435 2018-02-06T14:55:26  <bitcoin-git> [bitcoin] laanwj closed pull request #11909: contrib: Replace developer keys with list of pgp fingerprints (master...Mf1712-gitianKeysDel) https://github.com/bitcoin/bitcoin/pull/11909
436 2018-02-06T15:14:37  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/88971352f610...f6cd41d93e12
437 2018-02-06T15:14:38  <bitcoin-git> bitcoin/master a1e1305 James O'Beirne: Clarify help messages for path args to mention datadir prefix...
438 2018-02-06T15:14:38  <bitcoin-git> bitcoin/master 5460460 James O'Beirne: Add AbsPathForConfigVal to consolidate datadir prefixing for path args...
439 2018-02-06T15:14:39  <bitcoin-git> bitcoin/master f6cd41d Wladimir J. van der Laan: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling...
440 2018-02-06T15:15:26  <bitcoin-git> [bitcoin] laanwj closed pull request #12305: [docs] [refactor] Add help messages for datadir path mangling (master...jamesob/conf-flag-path-help) https://github.com/bitcoin/bitcoin/pull/12305
441 2018-02-06T15:17:42  *** SopaXorzTaker has joined #bitcoin-core-dev
442 2018-02-06T15:20:30  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
443 2018-02-06T15:20:30  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
444 2018-02-06T15:22:53  *** larafale has joined #bitcoin-core-dev
445 2018-02-06T15:34:09  *** sugarpuff has quit IRC
446 2018-02-06T15:34:26  *** sugarpuff has joined #bitcoin-core-dev
447 2018-02-06T15:35:55  *** ken2812221 has joined #bitcoin-core-dev
448 2018-02-06T15:40:25  *** cryptojanitor has quit IRC
449 2018-02-06T15:48:09  *** promag has quit IRC
450 2018-02-06T15:48:50  *** justanotheruser has quit IRC
451 2018-02-06T15:49:03  *** ossifrage has joined #bitcoin-core-dev
452 2018-02-06T15:50:24  *** justanotheruser has joined #bitcoin-core-dev
453 2018-02-06T15:52:16  *** Dizzle has joined #bitcoin-core-dev
454 2018-02-06T15:53:21  *** Pavle has joined #bitcoin-core-dev
455 2018-02-06T15:53:45  *** Dudley has joined #bitcoin-core-dev
456 2018-02-06T15:54:12  <ossifrage>  Has anyone noticed a reduction in the number of connections with v0.16.x? Normally after ~3ish days of uptime I'd be upto 90 or so peers and with the new version I'm having a hard time keeping 60 connections?
457 2018-02-06T15:54:30  *** Victorsueca has quit IRC
458 2018-02-06T15:55:51  *** Victorsueca has joined #bitcoin-core-dev
459 2018-02-06T15:57:36  <Dudley> Should  DEFAULT_WALLET_RBF be set to TRUE in wallet.h for version 0.16?
460 2018-02-06T16:02:27  *** shesek has quit IRC
461 2018-02-06T16:03:34  <Randolf> ossifrage:  I wonder if some folks have simply stopped running Bitcoin nodes given the recent downturn in price.  Or are you seeing the same number of initial connections as you did before?
462 2018-02-06T16:05:07  <ossifrage> Randolf, previously I had no problem hitting ~100 connections in a few days and often >120
463 2018-02-06T16:05:21  <ossifrage> Now I'm only hitting 50-60
464 2018-02-06T16:06:17  <Randolf> I suppose you've been checking your logs?
465 2018-02-06T16:06:39  <adiabat> ossifrage: I've also seen a big dropoff in nodes and also network traffic, down 50% or so in the last 2 weeks
466 2018-02-06T16:07:17  <ossifrage> it could just be fall off in price results in a fall off in the number of nodes
467 2018-02-06T16:08:34  <Randolf> Markets have been down a lot over the past few weeks (more than two weeks), and so I'm guessing that a number of folks might have chosen to stop running their nodes because of that.  I've certainly seen some chatter about that with other cryptocurrencies too from folks getting out while the markets
468 2018-02-06T16:08:34  <Randolf> drop.
469 2018-02-06T16:09:09  <Randolf> It could be interesting to find out which countries are seeing the most drops in node runners.
470 2018-02-06T16:09:15  <Randolf> ...assuming that's what's happening.
471 2018-02-06T16:09:35  <Randolf> It would also be nice to know whether some major ISPs have actively started blocking Bitcoin node traffic.
472 2018-02-06T16:09:51  <rabidus> i haven't seen any drop in my node peer count (.fi)
473 2018-02-06T16:10:19  <Randolf> rabidus:  Are you using v0.16?
474 2018-02-06T16:10:35  <rabidus> ah, sry, no.
475 2018-02-06T16:10:55  <Randolf> rabidus:  It's still good to know that you haven't seen a drop.  :)
476 2018-02-06T16:11:25  <rabidus> hmmm, well now i'm very curious to test that
477 2018-02-06T16:11:33  * Randolf smiles
478 2018-02-06T16:12:47  <Randolf> Maybe I'll set up a node too, and let it run for a week.
479 2018-02-06T16:12:55  <Randolf> ...at least.
480 2018-02-06T16:13:30  <BlueMatt> I belive #12273 needs an 0.16 tag
481 2018-02-06T16:13:31  <gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
482 2018-02-06T16:15:09  <BlueMatt> wumpus: #12337 has two bugs, the first is a regression (so should likely be tagged 0.16, but should be an easy fix), the second is not a regression, though should also be an easy fix so dunno why we shouldnt just fix it
483 2018-02-06T16:15:11  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
484 2018-02-06T16:15:25  <Dudley> Command line options help displays   "walletrbf Send transactions with full-RBF opt-in enabled (RPC only, default: 0)" for version 0.16rc2
485 2018-02-06T16:15:27  <BlueMatt> #12273 is a regression
486 2018-02-06T16:15:29  <gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
487 2018-02-06T16:16:42  <wumpus> BlueMatt: we removed the 0.16 tag from 12337, it doesn't warrant doing another r
488 2018-02-06T16:16:44  <wumpus> rc
489 2018-02-06T16:17:06  <wumpus> (which I also explained in my post there)
490 2018-02-06T16:17:08  <BlueMatt> a regression causing a scarry assert on shutdown?
491 2018-02-06T16:17:22  <wumpus> it's very rare
492 2018-02-06T16:17:31  <wumpus> and it's only an assert, and only on shutdown
493 2018-02-06T16:17:39  <BlueMatt> I mean I ran into it like 3 times during testing yesterday
494 2018-02-06T16:17:48  <BlueMatt> its only rare if you never quit during startup, afaict
495 2018-02-06T16:17:55  <wumpus> yeah...
496 2018-02-06T16:18:13  <BlueMatt> (and other stuff probably does merit an rc3, so might as well, imo)
497 2018-02-06T16:19:25  <wumpus> yes, if an rc3 turns out to be needed we can include the fix
498 2018-02-06T16:20:23  <BlueMatt> #12273 could be rather annoying for a user who doesnt notice...it probably doesnt itself warrant an rc3 but that + the two bugs in 12337 might
499 2018-02-06T16:20:25  <gribble> https://github.com/bitcoin/bitcoin/issues/12273 | rpc: Add back missing cs_main lock in getrawmempool by MarcoFalke · Pull Request #12273 · bitcoin/bitcoin · GitHub
500 2018-02-06T16:20:29  <BlueMatt> and 12362 may by itself warrant one
501 2018-02-06T16:20:54  <wumpus> 12273 affects more than just the tests?
502 2018-02-06T16:21:29  <BlueMatt> its a race between eg sendrawtransaction and getrawmempool....someone who does a sendrawtransaction followed by an immediate getrawmempool to...test for something or check fee or something may suddenly start failing
503 2018-02-06T16:21:47  <BlueMatt> its not exactly critical, especially since it doesnt effect wallet
504 2018-02-06T16:21:56  <wumpus> right, it seems far-fetched
505 2018-02-06T16:21:57  *** Amuza has quit IRC
506 2018-02-06T16:21:58  <BlueMatt> but its kinda gross
507 2018-02-06T16:22:04  <wumpus> needs to be fixed but does not warrant another rc
508 2018-02-06T16:22:10  <BlueMatt> agreed (by itself)
509 2018-02-06T16:22:47  *** promag has joined #bitcoin-core-dev
510 2018-02-06T16:23:34  <wumpus> #12362 is scary though, it's exactly what I was afraid of merging #12266 last minute :/
511 2018-02-06T16:23:35  <gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
512 2018-02-06T16:23:36  <gribble> https://github.com/bitcoin/bitcoin/issues/12266 | Move scheduler/threadGroup into common-init instead of per-app by TheBlueMatt · Pull Request #12266 · bitcoin/bitcoin · GitHub
513 2018-02-06T16:24:28  <BlueMatt> yea, its rather surprising to me...something is really sketchy there :(
514 2018-02-06T16:25:09  <BlueMatt> I mean this is why I wanted a full cycle of testing on all the parallell/background stuff, turns out even that seems like it wasnt enough :(
515 2018-02-06T16:29:51  *** promag has quit IRC
516 2018-02-06T16:30:08  <Dudley> Discard my question.     I guess default for walletrbf is different for RPC then the GUI
517 2018-02-06T16:31:09  <wumpus> Dudley: yes
518 2018-02-06T16:32:47  *** booyah_ is now known as booyah
519 2018-02-06T16:40:33  *** Randolf has quit IRC
520 2018-02-06T16:42:49  *** bizancio has joined #bitcoin-core-dev
521 2018-02-06T16:43:36  *** Murch has joined #bitcoin-core-dev
522 2018-02-06T16:53:26  *** Pavle has quit IRC
523 2018-02-06T16:56:01  *** Krellan has quit IRC
524 2018-02-06T16:59:08  <provoostenator> I'm making a fresh Debian 8 VM for Gitian to see which of the issues that I encountered last week are Debian 9 specific (probably still worth fixing at some point).
525 2018-02-06T16:59:41  <provoostenator> (for rc3)
526 2018-02-06T17:00:29  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6cd41d93e12...5ad320598f06
527 2018-02-06T17:00:29  <bitcoin-git> bitcoin/master 8a6c62b Conor Scott: [tests] Update README after filename change
528 2018-02-06T17:00:30  <bitcoin-git> bitcoin/master 5ad3205 Wladimir J. van der Laan: Merge #12363: Update README after filename change...
529 2018-02-06T17:00:40  *** Krellan has joined #bitcoin-core-dev
530 2018-02-06T17:01:24  <bitcoin-git> [bitcoin] laanwj closed pull request #12363: Update README after filename change (master...test-readme-update) https://github.com/bitcoin/bitcoin/pull/12363
531 2018-02-06T17:03:22  <wumpus> provoostenator: yeah it would help a lot if someone worked through that guide and fixed the things that are no longer correct, it's been too long
532 2018-02-06T17:03:43  <wumpus> most people who have a working gitian environment dread to touch it again
533 2018-02-06T17:03:49  <provoostenator> I already left about 10 issues on the docs repo, but I suspect some of it was Debian 9 related.
534 2018-02-06T17:05:07  <wumpus> ok cool
535 2018-02-06T17:05:56  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ad320598f06...1462bde767a1
536 2018-02-06T17:05:56  <bitcoin-git> bitcoin/master bdb3231 251: Implements a virtual destructor on the BaseRequestHandler class....
537 2018-02-06T17:05:57  <bitcoin-git> bitcoin/master 1462bde Wladimir J. van der Laan: Merge #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class....
538 2018-02-06T17:06:12  <provoostenator> I'm also looking at clarifying how to build on the VM, but sign on the host machine.
539 2018-02-06T17:06:33  <provoostenator> As well as push to github fro the host machine.
540 2018-02-06T17:06:41  <bitcoin-git> [bitcoin] laanwj closed pull request #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class. (master...patch/BaseRequestHandler-virtual-dtor) https://github.com/bitcoin/bitcoin/pull/12050
541 2018-02-06T17:07:21  <provoostenator> I already have a bash script for that, but need to combine that with the existing script (before or after someone converts that to Python).
542 2018-02-06T17:08:32  *** owowo has quit IRC
543 2018-02-06T17:08:38  *** AaronvanW has joined #bitcoin-core-dev
544 2018-02-06T17:09:08  *** owowo has joined #bitcoin-core-dev
545 2018-02-06T17:10:01  *** Krellan has quit IRC
546 2018-02-06T17:14:06  <arubi> provoostenator, I'm successfully building w/ debian 9 as the host VM, here are my notes if it helps https://gist.github.com/fivepiece/4c5cd8733973b9821dba9c9c42958209
547 2018-02-06T17:15:37  <arubi> it's also possible to set up the bridge stuff using the new `ip` commands, but I wasn't sure if the gitian builder scripts look for ifconfig and friends so I'm also pulling the net-tools package
548 2018-02-06T17:16:13  <arubi> one plus is that it doesn't require installing an old vmbuilder as root
549 2018-02-06T17:20:41  *** Krellan has joined #bitcoin-core-dev
550 2018-02-06T17:27:39  *** Dizzle has quit IRC
551 2018-02-06T17:28:55  *** paracyst has quit IRC
552 2018-02-06T17:29:07  *** paracyst_ has joined #bitcoin-core-dev
553 2018-02-06T17:31:17  *** Krellan has quit IRC
554 2018-02-06T17:31:17  *** spinza has quit IRC
555 2018-02-06T17:31:46  *** Krellan has joined #bitcoin-core-dev
556 2018-02-06T17:34:12  *** paracyst_ has quit IRC
557 2018-02-06T17:36:14  *** Krellan has quit IRC
558 2018-02-06T17:36:25  *** cryptojanitor has joined #bitcoin-core-dev
559 2018-02-06T17:41:18  *** bizancio has quit IRC
560 2018-02-06T17:43:33  *** paracyst has joined #bitcoin-core-dev
561 2018-02-06T17:46:50  *** Krellan has joined #bitcoin-core-dev
562 2018-02-06T17:49:43  *** Amuza has joined #bitcoin-core-dev
563 2018-02-06T17:55:58  <BlueMatt> ok, so found the issue in #12362...trying to find minimal patch
564 2018-02-06T17:56:00  <gribble> https://github.com/bitcoin/bitcoin/issues/12362 | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel · Issue #12362 · bitcoin/bitcoin · GitHub
565 2018-02-06T17:56:05  <BlueMatt> wumpus: you still around? you know this code much better than I
566 2018-02-06T17:56:23  <wumpus> BlueMatt: yes
567 2018-02-06T17:57:01  <wumpus> (as in still around, not sure about knowing the code better)
568 2018-02-06T17:57:03  <BlueMatt> issue is simple: HTTPWorkQueueRun starting in a new thread may take longer to get to the queue->Run() call than it takes for us to go through InterruptHTTPServer(); StopHTTPServer()
569 2018-02-06T17:57:14  <BlueMatt> so the thread will start after the underlying queue has been deleted
570 2018-02-06T17:57:17  <BlueMatt> resulting in garbage
571 2018-02-06T17:57:43  <wumpus> looks like we need a lock
572 2018-02-06T17:57:57  <BlueMatt> prior to the commit to move the threadGroup to interrupt later, the only thing between VerifyWallets() was threadGroup.interrupt_all(), which was enough to keep from seeing this
573 2018-02-06T17:58:30  <BlueMatt> but once that was removed if VerifyWallets() fails you essentially just immediately call InterruptHTTPServer() and then StopHTTPRPC(), StopREST(), StopRPC() and StopHTTPServer()
574 2018-02-06T17:58:34  <BlueMatt> so you just get into a simple race there
575 2018-02-06T17:59:10  <wumpus> yes, so when interrupthttpserver is run, we first need to wait that it is actually running
576 2018-02-06T17:59:13  <BlueMatt> easy to test for - add a sleep at the top of HTTPWorkQueueRun and run in valgrind
577 2018-02-06T17:59:15  <BlueMatt> you'll see it immediately
578 2018-02-06T17:59:35  <BlueMatt> yea, just need to somehow pause until stuff is running
579 2018-02-06T17:59:53  <BlueMatt> the stupid patch at https://github.com/bitcoin/bitcoin/issues/12362#issuecomment-363503855 apparently works
580 2018-02-06T17:59:55  <wumpus> also, queue->run shouldn't run if it is already terminated
581 2018-02-06T18:01:33  <BlueMatt> yea, i think that would be an equivalent fix
582 2018-02-06T18:01:44  <wumpus> but does this fix the race?
583 2018-02-06T18:02:20  *** Krellan has quit IRC
584 2018-02-06T18:02:23  <wumpus> there's still a small window where threads_running is incrased but queue->run is not yet executed
585 2018-02-06T18:02:38  <BlueMatt> oh yea I mean its not a sufficient fix
586 2018-02-06T18:02:40  <BlueMatt> its just a hack for testing
587 2018-02-06T18:02:51  <wumpus> right
588 2018-02-06T18:03:51  <BlueMatt> wumpus: do you understand the qt init stuff well enough to fix #12337? (it just needs to have its shutdown match bitcoind - Shutdown() should always get called if AppInitMain() gets called, even if it fails)
589 2018-02-06T18:03:52  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
590 2018-02-06T18:04:12  <BlueMatt> I mean I can do a dirty hack for an rc3 that just does it directly but I dont understand the lifetimes well enough to not break things
591 2018-02-06T18:04:14  <wumpus> I lost track of the qt init stuff to be honest, I used to understand it, but a lot changed
592 2018-02-06T18:04:19  <BlueMatt> :(
593 2018-02-06T18:04:40  <wumpus> oh that part, yes that should be easy
594 2018-02-06T18:04:59  <wumpus> it's interesting because it used to be exactly the other way around
595 2018-02-06T18:05:01  <BlueMatt> ok, well I'd propose we do that and just fix the 4 outstanding issues and do an rc3, then
596 2018-02-06T18:05:18  <BlueMatt> yea, that stuff got confused and bitcoind and qt diverged introducing the bug in 12337 :(
597 2018-02-06T18:05:35  <wumpus> I think that switched around a few times
598 2018-02-06T18:05:55  <BlueMatt> well also AppInit got split.....
599 2018-02-06T18:06:03  <wumpus> that shouldn't change this
600 2018-02-06T18:06:32  *** Krellan has joined #bitcoin-core-dev
601 2018-02-06T18:06:43  <wumpus> the earlier appinits shouldn't require a shutdown
602 2018-02-06T18:06:45  <wumpus> only the last one
603 2018-02-06T18:06:54  <BlueMatt> yea, well when there was only one appinit... :p
604 2018-02-06T18:06:55  <wumpus> as that is what is executed in the daemon process
605 2018-02-06T18:07:11  <wumpus> the other ones are preparation
606 2018-02-06T18:07:13  *** Krellan has quit IRC
607 2018-02-06T18:07:49  <BlueMatt> so one thing we should maybe consider is a test framework that changes shutdownrequested to just start shutdown after being called N times, and then run for all N 0...inf to make sure we handle all these cases well
608 2018-02-06T18:08:05  <BlueMatt> cause we now have, what, 2 issues that would be caught by a test like that
609 2018-02-06T18:08:07  <wumpus> yes it definitely needs tests
610 2018-02-06T18:08:39  *** spinza has joined #bitcoin-core-dev
611 2018-02-06T18:08:45  <wumpus> the initialization sequence and shutdown are really undertested
612 2018-02-06T18:13:00  *** Randolf has joined #bitcoin-core-dev
613 2018-02-06T18:14:07  *** AaronvanW has quit IRC
614 2018-02-06T18:14:44  *** AaronvanW has joined #bitcoin-core-dev
615 2018-02-06T18:14:58  <wumpus> so for the queue->Run() I don't understand why interrupting it before the Run is hit is a problem, interrupt should set the stopped flag on the queue, so it should just fall through and exit the thread immediately
616 2018-02-06T18:15:50  <wumpus> or does deletion (which should happen in ShutdownHTTPServer, not Interrupt) somehow not wait for the threads to have stopped?
617 2018-02-06T18:16:52  <BlueMatt> wumpus: I do not believe ShutdownHTTPServer does any meaningful waiting, no
618 2018-02-06T18:17:03  <wumpus> then that is likely the issue, let me see
619 2018-02-06T18:17:09  <BlueMatt> yea, I dont think Interrupt is the issue, I think its Shutdown
620 2018-02-06T18:17:45  <wumpus> it does workqueue->WaitExit()
621 2018-02-06T18:17:52  <wumpus> in Shutdown
622 2018-02-06T18:18:32  <BlueMatt> yea, but if the thread hasnt joined (ie is still waiting to call numThreads++) then the wait is null
623 2018-02-06T18:18:33  <ryanofsky> #11625 adds some testing for qt init code, fwiw
624 2018-02-06T18:18:36  <gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
625 2018-02-06T18:19:10  <wumpus> ah apparently it doesn't actually join the thread objects
626 2018-02-06T18:19:18  <wumpus> ryanofsky: good!
627 2018-02-06T18:20:04  <wumpus> the threads are detached and the handle is thrown away
628 2018-02-06T18:20:49  *** neha has quit IRC
629 2018-02-06T18:20:52  <BlueMatt> yea
630 2018-02-06T18:21:10  <wumpus> ok this is easy to solve
631 2018-02-06T18:22:22  <wumpus> will PR in a minute
632 2018-02-06T18:24:47  <wumpus> thanks for finding this, I wonder if I introduced this bug or it somehow snuck in when going from boost::thread to std::thread (probably the former)
633 2018-02-06T18:25:26  *** AaronvanW has quit IRC
634 2018-02-06T18:26:01  *** AaronvanW has joined #bitcoin-core-dev
635 2018-02-06T18:28:27  *** Chris_Stewart_5 has quit IRC
636 2018-02-06T18:28:47  *** neha has joined #bitcoin-core-dev
637 2018-02-06T18:29:09  <BlueMatt> alright, well I propose we fix all 4 bugs here and then rc3
638 2018-02-06T18:29:52  <BlueMatt> wait, i may have another....
639 2018-02-06T18:30:42  <BlueMatt> yup, ok, 5 bugs
640 2018-02-06T18:30:44  *** AaronvanW has quit IRC
641 2018-02-06T18:32:36  <bitcoin-git> [bitcoin] laanwj opened pull request #12366: http: Join worker threads before deleting work queue (master...2017_02_httpserver_join) https://github.com/bitcoin/bitcoin/pull/12366
642 2018-02-06T18:34:19  *** MrPaz has joined #bitcoin-core-dev
643 2018-02-06T18:36:06  *** AaronvanW has joined #bitcoin-core-dev
644 2018-02-06T18:37:57  <wumpus> as for qt, it seems it's already supposed to call Shutdown() even if AppInitMain() fails, don't know what goes wrong
645 2018-02-06T18:38:30  <BlueMatt> wumpus: [13:15:15] <cfields> BlueMatt: i think i might see the issue
646 2018-02-06T18:38:30  <BlueMatt> [13:16:58] <cfields> BlueMatt: BitcoinApplication connects requestedShutdown to shutdown(), but SplashScreen connects it to close()
647 2018-02-06T18:38:43  <BlueMatt> [13:17:32] <cfields> so it looks like we should re-route that after AppInitMain has started
648 2018-02-06T18:39:21  <wumpus> a signal can be connected to two handlers, I don't see the problem
649 2018-02-06T18:40:00  <wumpus> that just makes sure that the splash screen is hidden when the shutdown window is shown
650 2018-02-06T18:40:02  <BlueMatt> ahh, well I didnt look into it that deeply, but if Shutdown() is called, nThreadsServicingQueue should be pretty clearly 0
651 2018-02-06T18:40:14  <BlueMatt> as it join()s
652 2018-02-06T18:40:27  *** AaronvanW has quit IRC
653 2018-02-06T18:40:49  <wumpus> I'm fairly sure that this has always worked, when closing during the splash screen the shutdown window is shown and it waits for proper shutdown
654 2018-02-06T18:41:09  <wumpus> no idea wtf messed this up...
655 2018-02-06T18:43:52  <wumpus> so the assertion is triggered after exiting main()?
656 2018-02-06T18:44:04  <BlueMatt> yes
657 2018-02-06T18:44:07  <BlueMatt> static-deinit
658 2018-02-06T18:45:49  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12367: Fix two fast-shutdown bugs (master...2018-02-wait-genesis-exit) https://github.com/bitcoin/bitcoin/pull/12367
659 2018-02-06T18:46:01  <BlueMatt> ^ fixes two fast-shutdown bugs, hopefully with really-simple patches
660 2018-02-06T18:46:27  <MarcoFalke> rc2 is basically rc1
661 2018-02-06T18:46:41  <MarcoFalke> As we need to give users time to test, there is no downside in rc3
662 2018-02-06T18:47:36  *** sengehest has joined #bitcoin-core-dev
663 2018-02-06T18:52:18  *** dongcarl has joined #bitcoin-core-dev
664 2018-02-06T18:53:36  <dongcarl> Hi all, I've been trying to get gitian on LXC working to no avail. I'm running into the same issues kallewoof ran into on Dec 1st, 2017. where the error is "sudo: unable to resolve host gitian / cannot set terminal process group (1): Inappropriate ioctl for device / no job control in this shell"
665 2018-02-06T18:53:54  <dongcarl> I fixed the unable to resolve host error by modifying the /etc/hosts of the base image
666 2018-02-06T18:53:54  <wumpus> unable to resolve host is harmless at least
667 2018-02-06T18:54:04  <wumpus> that's just a warning
668 2018-02-06T18:54:24  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #12368: Hold mempool.cs for the duration of ATMP. (master...2018-02-getrawmempool-race) https://github.com/bitcoin/bitcoin/pull/12368
669 2018-02-06T18:54:25  <BlueMatt> MarcoFalke: ^
670 2018-02-06T18:54:34  <wumpus> never saw the others though
671 2018-02-06T18:55:16  <dongcarl> wumpus: thanks, it seems like there were case before where this happened as well, e.g. https://github.com/devrandom/gitian-builder/issues/63
672 2018-02-06T18:55:24  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12273: rpc: Add back missing cs_main lock in getrawmempool (master...Mf1801-rpcMempoolGetLock) https://github.com/bitcoin/bitcoin/pull/12273
673 2018-02-06T18:56:15  <dongcarl> What happens with the error is that I get dropped into a root shell, and when I ctrl-d, a loop of "sudo: unknown user: ubuntu" and "sudo: unable to initialize policy plugin" pops up
674 2018-02-06T18:56:18  <BlueMatt> ok, so #12368 + #12367 + #12366 + the qt bug and then rc3? I think all of those except the last are at least super-trivial patches...and at this rate getting an extra week on testing cycles seems to make sense
675 2018-02-06T18:56:19  <gribble> https://github.com/bitcoin/bitcoin/issues/12368 | Hold mempool.cs for the duration of ATMP. by TheBlueMatt · Pull Request #12368 · bitcoin/bitcoin · GitHub
676 2018-02-06T18:56:21  <gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub
677 2018-02-06T18:56:22  <gribble> https://github.com/bitcoin/bitcoin/issues/12366 | http: Join worker threads before deleting work queue by laanwj · Pull Request #12366 · bitcoin/bitcoin · GitHub
678 2018-02-06T18:56:50  * dongcarl waits patiently for a savior
679 2018-02-06T19:04:55  *** Amuza has quit IRC
680 2018-02-06T19:05:00  *** neha has quit IRC
681 2018-02-06T19:05:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
682 2018-02-06T19:06:16  *** neha has joined #bitcoin-core-dev
683 2018-02-06T19:06:21  *** laurentmt has quit IRC
684 2018-02-06T19:13:31  *** AaronvanW has joined #bitcoin-core-dev
685 2018-02-06T19:15:17  <wumpus> dongcarl: is that perhaps with debian 9?
686 2018-02-06T19:15:35  <dongcarl> wumpus: the base image is trusty
687 2018-02-06T19:15:44  <wumpus> no, I mean the outer VM
688 2018-02-06T19:15:56  <dongcarl> I'm on Arch right now
689 2018-02-06T19:16:22  <dongcarl> am I understanding this wrong? I thought there were two layers, my laptop (Arch) and the lxc container (Trusty)
690 2018-02-06T19:16:23  <wumpus> heh you might be the first that tries running gitian on arch
691 2018-02-06T19:16:49  <dongcarl> wumpus: yeah I wanted to make a PR on how to workaround the kinks
692 2018-02-06T19:16:55  <provoostenator> dongcarl: I've only used the Debian VM. Not sure if it's worth maintaining documentation for 2 distros.
693 2018-02-06T19:17:22  <provoostenator> Although I suppose it would make the scripts more robust.
694 2018-02-06T19:17:22  <MarcoFalke> provoostenator: We already have it for fedora as well
695 2018-02-06T19:17:24  <dongcarl> provoostenator: I think it'll be nice if the scripts are distro-agnostic
696 2018-02-06T19:17:24  <esotericnonsense> bah run debian or whatever in a vm and run the lxc within that. solved. :P
697 2018-02-06T19:17:27  <dongcarl> yeah
698 2018-02-06T19:17:30  <wumpus> well iI assumed you were following the gitian-building md, it starts out with debian VM in which the LXC based gitian is run
699 2018-02-06T19:17:47  <wumpus> it would be nice, but not realistic I think
700 2018-02-06T19:17:55  <wumpus> we have lots of trouble keeping it working in just debian
701 2018-02-06T19:18:07  <dongcarl> :-/
702 2018-02-06T19:18:29  <provoostenator> I'm getting better at it though, having nuked and rebuilt a Gitian VM half a dozen times now.
703 2018-02-06T19:18:35  <dongcarl> So I know the zcash people use gitian+vagrant
704 2018-02-06T19:18:49  <dongcarl> and vagrant is pretty portable across hosts and drivers
705 2018-02-06T19:18:56  <dongcarl> but that's a whole other thing
706 2018-02-06T19:19:02  <dongcarl> I think I know where the problem lies...
707 2018-02-06T19:19:10  <MarcoFalke> Maybe we can get rid of gitian ...
708 2018-02-06T19:19:18  <sipa> in theory there shouldn't be that much dependece on the outer host
709 2018-02-06T19:19:25  <sipa> but that's theory...
710 2018-02-06T19:19:27  <wumpus> hahaha
711 2018-02-06T19:19:28  <wumpus> in theory
712 2018-02-06T19:19:46  <MarcoFalke> sipa: The lxc bridge thing usually breaks
713 2018-02-06T19:19:58  <sipa> the difference between theory and practice is of course that in theory there is nome, but in practice...
714 2018-02-06T19:19:59  *** twoken has quit IRC
715 2018-02-06T19:20:00  <wumpus> the lxc setup is quite fragile
716 2018-02-06T19:20:06  <MarcoFalke> yeah
717 2018-02-06T19:20:32  <wumpus> maybe it's easier with vagrant or another container hoster, I don't know
718 2018-02-06T19:20:48  <wumpus> if someone has time to play around with that it'd be appreciated
719 2018-02-06T19:21:04  <arubi> vagrant requires virtualbox right?
720 2018-02-06T19:21:13  <dongcarl> arubi: no
721 2018-02-06T19:21:19  <dongcarl> it can take a lot of drivers
722 2018-02-06T19:21:20  <wumpus> I thought it was just another user of linux containers, just like lxc and docker
723 2018-02-06T19:21:29  <arubi> oic
724 2018-02-06T19:21:34  <arubi> I was using qemu for mine
725 2018-02-06T19:21:42  <dongcarl> it's orchestration layer on top of multiple drivers, lxc, qemu, etc
726 2018-02-06T19:21:49  <arubi> oh cool
727 2018-02-06T19:21:50  <dongcarl> quite easy to write extensions
728 2018-02-06T19:22:06  <wumpus> that sounds like another layer of complexity
729 2018-02-06T19:22:32  <dongcarl> wumpus: right, that's why I don't know if people would want vagrant
730 2018-02-06T19:22:37  <wumpus> the problem is that lxc is hard to set up, so switch to something that is another abstraction layer over multiple kinds of virtualization, just like gitian is already trying to be
731 2018-02-06T19:22:43  <dongcarl> wumpus: but it's quite well-tested and easy to set up
732 2018-02-06T19:23:19  <wumpus> gitian as-is can also be used with qemu, lxc or even virtualbox (though no one is doing the latter anymore since Gavin left, I think)
733 2018-02-06T19:23:19  <arubi> maybe aboriginal linux -> mkroot -> build? :P
734 2018-02-06T19:23:38  <dongcarl> wumpus: I think the end goal is for gitian to target vagrant, and for vagrant to handle interacting with the drivers
735 2018-02-06T19:23:45  <dongcarl> which would make gitian work much easier
736 2018-02-06T19:24:04  <dongcarl> anyways, I'll play around with it and see if it actually delivers
737 2018-02-06T19:24:17  <dongcarl> (or just makes things more complicated)
738 2018-02-06T19:24:54  *** twoken has joined #bitcoin-core-dev
739 2018-02-06T19:25:00  <wumpus> right, that could work I guess
740 2018-02-06T19:25:19  *** sengehest has quit IRC
741 2018-02-06T19:26:18  <dongcarl> quick question: is anyone allowed to submit their gitian sigs or just a limited group of people?
742 2018-02-06T19:27:00  <sipa> dongcarl: if you plan to regularly dongitian builds foe bitcoin core releases, you're very mufh encouraged to upload your key and do so:)
743 2018-02-06T19:27:22  <sipa> that n between do and gitian is a typo, i swear!
744 2018-02-06T19:27:37  <dongcarl> sipa: I'm definitely going to name my PR branch dongitian now ;-)
745 2018-02-06T19:27:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
746 2018-02-06T19:28:58  <wumpus> everyone is allowed to submit gitian sigs, the more the better
747 2018-02-06T19:30:56  <dongcarl> <3
748 2018-02-06T19:32:20  <wumpus> the only requirement is that you get the build working :)
749 2018-02-06T19:33:34  <BlueMatt> wumpus: did you have any idea why the qt shit isnt calling Shutdown() reliably or should I try to decipher qt
750 2018-02-06T19:33:55  <wumpus> no, I have no idea right now
751 2018-02-06T19:33:58  <BlueMatt> k
752 2018-02-06T19:34:07  <wumpus> from what I see it should simply work
753 2018-02-06T19:36:25  *** jamesob has joined #bitcoin-core-dev
754 2018-02-06T19:37:04  <cfields> BlueMatt: see my last comment on that ticket, I think I'm in the right ballpark
755 2018-02-06T19:37:18  <BlueMatt> cfields: wumpus indicated that didnt seem likely
756 2018-02-06T19:37:25  <cfields> though admittedly, I tried a million theories and probably crossed myself up in the process
757 2018-02-06T19:37:26  <cfields> oh?
758 2018-02-06T19:37:28  <BlueMatt> lol well I currently cant build qt due to the moc bug, so...ugh
759 2018-02-06T19:37:41  <jnewbery> wumpus: change looks good. I can't reproduce 12362 with your PR
760 2018-02-06T19:37:44  <cfields> eh? still?
761 2018-02-06T19:37:45  <wumpus> cfields had a different theory there, I haven't checked that one
762 2018-02-06T19:38:15  <wumpus> jnewbery: great!
763 2018-02-06T19:38:30  *** finkan has joined #bitcoin-core-dev
764 2018-02-06T19:38:38  <BlueMatt> cfields: well I never found any resolution to it? moc doesnt build bitcoin-qt right now....no idea why
765 2018-02-06T19:39:24  <wumpus> cfields: just that the one about re-attaching the signal was not correct, because it's perfectly valid to attach multiple listeners to a signal (or did I misunderstand what you meant?)
766 2018-02-06T19:39:29  <BlueMatt> cfields: is it just me or is the issue simply that BitcoinCore::initialize() calls initializeResult(false) if AppInitMain() fails, which calls quit() directly instead of calling shutdown() (which would call Interrupt(), Shutdown(), and then shutdownResult() which calls quit())?
767 2018-02-06T19:39:43  <wumpus> quit() just exits the main loop
768 2018-02-06T19:39:54  <BlueMatt> yes, but we thus wont call Shutdown(), I think
769 2018-02-06T19:39:56  <wumpus> after that it starts the shutdown sequence in a new main loop
770 2018-02-06T19:39:59  <BlueMatt> oh
771 2018-02-06T19:40:04  <wumpus> after showing the shutdown window
772 2018-02-06T19:40:21  <BlueMatt> funny because shutdown() will call Interrupt() and then Shutdown() and then quit()
773 2018-02-06T19:40:32  <wumpus> that should just work, I tested it a zillion times
774 2018-02-06T19:40:36  <wumpus> yes it calls quit again
775 2018-02-06T19:40:51  <wumpus> to exit the new mainloop (which handles exiting)
776 2018-02-06T19:40:51  <BlueMatt> hmm, ok, well I guess I'm just confused
777 2018-02-06T19:45:04  <wumpus> FWIW it's structured like this because existing the main window will exit the main loop, so we need a new main loop instance to handle the shutdown window while it's shutting down (in the background). There's certainly different ways to do it, but this used to work at least.
778 2018-02-06T19:46:11  *** cryptojanitor has quit IRC
779 2018-02-06T19:46:28  <BlueMatt> well I'll debug moc a bit more and see if I can get that working again
780 2018-02-06T19:47:05  *** dcousens has quit IRC
781 2018-02-06T19:47:58  <cfields> BlueMatt: the problem as i saw it was that quit() is called _both_ by the failed AppInitMain(), as well as when it gets the shutdown signal.
782 2018-02-06T19:48:17  *** dcousens has joined #bitcoin-core-dev
783 2018-02-06T19:48:18  <cfields> I can only defer to wumpus as to whether that's an issue or not.
784 2018-02-06T19:49:16  *** laurentmt has joined #bitcoin-core-dev
785 2018-02-06T19:49:42  <cfields> but yes, in all of my tests, exit does wait on the shutdown procedure to finish. I can't force any other result :\
786 2018-02-06T19:50:09  <wumpus> cfields: wait, we don't stop the shutdown poll timer while shutting down?
787 2018-02-06T19:50:19  <cfields> hmm?
788 2018-02-06T19:50:42  *** Krellan has joined #bitcoin-core-dev
789 2018-02-06T19:50:58  <wumpus> BitcoinGUI::detectShutdown()
790 2018-02-06T19:51:08  *** SopaXorzTaker has quit IRC
791 2018-02-06T19:51:17  <wumpus> does that run while it's in the second main loop (while the shutdown window is visible)?
792 2018-02-06T19:51:46  <wumpus> if so it will prematurely end that loop becuase, yes, it's shut down
793 2018-02-06T19:52:20  <cfields> wumpus: ugh, no clue. I didn't even look at that.
794 2018-02-06T19:52:58  <wumpus> cfields: I thought that's what you mean with 'when it gets the shutdown signal'
795 2018-02-06T19:53:27  *** owowo has quit IRC
796 2018-02-06T19:54:07  <wumpus> the other one (in shutdownResult) is for *after Shutdown() finished* so that's ok
797 2018-02-06T19:54:34  <wumpus> and the one in initializeResult() is ok too, it means it goes into the shutdown sequence
798 2018-02-06T19:54:48  <wumpus> but the timer might create such a weird race issue
799 2018-02-06T19:55:45  <wumpus> ah, pollShutdownTimer is stopped
800 2018-02-06T19:55:51  <wumpus> in requestShutdown
801 2018-02-06T19:56:32  <wumpus> no, that should be ok
802 2018-02-06T19:58:54  *** owowo has joined #bitcoin-core-dev
803 2018-02-06T20:00:05  <cfields> wumpus: ah, so the timer sees StartShutdown() and fires requestedShutdown(). I see. I thought that was coming from the close button. So shutdown() isn't an overridden qt function?
804 2018-02-06T20:00:37  <wumpus> cfields: no :)
805 2018-02-06T20:01:07  <cfields> heh ok
806 2018-02-06T20:01:08  <wumpus> shutdown() is just the background thread function that actually calls Interrupt() and Shutdown()
807 2018-02-06T20:02:25  <wumpus> this is bound to the signal requestedShutdown(), coming from the GUI thread
808 2018-02-06T20:02:29  <cfields> right. I know we call it, but I thought qt emitted it too as some life-cycle callback
809 2018-02-06T20:02:49  *** Pavle has joined #bitcoin-core-dev
810 2018-02-06T20:03:10  <cfields> yes, I have a much better idea now, thanks
811 2018-02-06T20:04:27  *** timothy has quit IRC
812 2018-02-06T20:05:18  *** mmgen has joined #bitcoin-core-dev
813 2018-02-06T20:09:42  *** Krellan has quit IRC
814 2018-02-06T20:14:13  *** promag has joined #bitcoin-core-dev
815 2018-02-06T20:18:52  *** promag has quit IRC
816 2018-02-06T20:22:29  <dongcarl> If anyone has a working LXC Trusty gitian container, could they show me `ls -la /dev/tty*'?
817 2018-02-06T20:30:06  *** promag has joined #bitcoin-core-dev
818 2018-02-06T20:30:40  *** Cogito_Ergo_Sum has quit IRC
819 2018-02-06T20:31:38  <arubi> dongcarl, are you running a nested lxc then?  lxc host and gitian builder lxc inside it?  if so fwiw it's not so straight forward
820 2018-02-06T20:35:05  *** promag has quit IRC
821 2018-02-06T20:38:52  *** Krellan has joined #bitcoin-core-dev
822 2018-02-06T20:40:04  *** promag has joined #bitcoin-core-dev
823 2018-02-06T20:42:06  <arubi> if anybody's up for it, please kill the current running #25110 travis job.  it's obsolete a waste to keep folks waiting
824 2018-02-06T20:42:07  <gribble> https://github.com/bitcoin/bitcoin/issues/25110 | HTTP Error 404: Not Found
825 2018-02-06T20:43:42  <sipa> do you have URL?
826 2018-02-06T20:43:55  <arubi> sipa, https://travis-ci.org/bitcoin/bitcoin/builds/338165077
827 2018-02-06T20:44:32  *** cheese_ has quit IRC
828 2018-02-06T20:44:33  *** cryptojanitor has joined #bitcoin-core-dev
829 2018-02-06T20:45:34  *** gribble has quit IRC
830 2018-02-06T20:47:46  *** meshcollider has joined #bitcoin-core-dev
831 2018-02-06T20:53:11  *** gribble has joined #bitcoin-core-dev
832 2018-02-06T20:56:16  <sipa> arubi: done
833 2018-02-06T20:56:26  <arubi> cheers
834 2018-02-06T21:01:56  *** timothy has joined #bitcoin-core-dev
835 2018-02-06T21:07:20  *** timothy has quit IRC
836 2018-02-06T21:13:30  *** mmgen has quit IRC
837 2018-02-06T21:18:27  *** laurentmt has quit IRC
838 2018-02-06T21:21:44  *** wunpunch has joined #bitcoin-core-dev
839 2018-02-06T21:23:29  *** arubi has quit IRC
840 2018-02-06T21:26:57  *** finkan has quit IRC
841 2018-02-06T21:28:55  *** arubi has joined #bitcoin-core-dev
842 2018-02-06T21:32:40  <BlueMatt> MarcoFalke: you can just close #12365 its a launchpad security issue that launchpad appears to give 0 fucks about fixing
843 2018-02-06T21:32:42  <gribble> https://github.com/bitcoin/bitcoin/issues/12365 | Add ppa:bitcoin/bitcoin repository on linux problem · Issue #12365 · bitcoin/bitcoin · GitHub
844 2018-02-06T21:32:47  <BlueMatt> yay ubuntu dgaf about security, apparently
845 2018-02-06T21:32:59  <BlueMatt> well, i guess we knew that
846 2018-02-06T21:33:35  <sipa> dgaf?
847 2018-02-06T21:33:40  <BlueMatt> dont give a fuck
848 2018-02-06T21:33:54  <dongcarl> (kids these days)
849 2018-02-06T21:35:39  <dongcarl> arubi: no, it's just that I've isolated the problem down to the fact that 'sudo lxc-execute -n gitian -f var/lxc.config -- bash' doesn't work
850 2018-02-06T21:35:52  <dongcarl> it says 'bash: cannot set terminal process group (1): Inappropriate ioctl for device'
851 2018-02-06T21:36:11  <dongcarl> when i do s/bash/sh/
852 2018-02-06T21:36:20  <dongcarl> it says 'sh: 0: can't access tty; job control turned off'
853 2018-02-06T21:36:28  <dongcarl> so something's wrong with tty somewhere...
854 2018-02-06T21:37:31  <arubi> I see, sorry, I didn't get this error here
855 2018-02-06T21:37:55  <dongcarl> I think it's to do with me running a newer version of lxc
856 2018-02-06T21:38:12  <dongcarl> it complains about the config file being an old format too and I had to look at what key names changed
857 2018-02-06T21:39:00  <arubi> oh man that sounds like a lot of work once non bleeding edge os's are updated to newer lxc..
858 2018-02-06T21:39:14  <dongcarl> arubi: yup, which is why I'm starting now...
859 2018-02-06T21:39:23  <arubi> good luck
860 2018-02-06T21:39:30  <dongcarl> <3
861 2018-02-06T21:42:39  *** Dudley has quit IRC
862 2018-02-06T21:47:57  *** Chris_Stewart_5 has quit IRC
863 2018-02-06T22:01:01  *** promag has joined #bitcoin-core-dev
864 2018-02-06T22:05:48  *** jamesob has quit IRC
865 2018-02-06T22:08:51  *** Pavle has quit IRC
866 2018-02-06T22:13:05  <BlueMatt> cfields: were you ever able to materially reproduce #12337?
867 2018-02-06T22:13:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
868 2018-02-06T22:13:51  <cfields> BlueMatt: no :(
869 2018-02-06T22:14:17  <BlueMatt> you "killed" by just closing window?
870 2018-02-06T22:14:18  <cfields> BlueMatt: i can confirm that Shutdown() wasn't called though
871 2018-02-06T22:14:29  <cfields> yep
872 2018-02-06T22:15:25  <cfields> BlueMatt: I tried all kinds of sleeps/early returns to try to hit it again, but no luck
873 2018-02-06T22:15:29  *** rex_4539 has quit IRC
874 2018-02-06T22:17:18  <cfields> tail of log:
875 2018-02-06T22:17:21  <cfields> 2018-02-02 20:39:50 Upgrading utxo-set database...
876 2018-02-06T22:17:22  <cfields> 2018-02-02 20:39:50 [0%]...[CANCELLED].
877 2018-02-06T22:17:22  <cfields> 2018-02-02 20:39:50 Shutdown requested. Exiting
878 2018-02-06T22:19:06  <bitcoin-git> [bitcoin] akx20000a opened pull request #12371: Add gitian PGP key: akx20000 (master...gitian-key) https://github.com/bitcoin/bitcoin/pull/12371
879 2018-02-06T22:19:25  <BlueMatt> hmm, k
880 2018-02-06T22:20:32  <promag> BlueMatt: https://github.com/bitcoin/bitcoin/pull/12368#issuecomment-363584547
881 2018-02-06T22:20:35  *** arubi has quit IRC
882 2018-02-06T22:21:07  *** arubi has joined #bitcoin-core-dev
883 2018-02-06T22:22:26  *** Lynet has joined #bitcoin-core-dev
884 2018-02-06T22:24:12  <BlueMatt> promag: the validationinterface background-thread stuff breaks lock-order =D
885 2018-02-06T22:25:19  *** Tennis has joined #bitcoin-core-dev
886 2018-02-06T22:34:41  <promag> BlueMatt: got it, forgot about that X)
887 2018-02-06T22:44:08  *** rex_4539 has joined #bitcoin-core-dev
888 2018-02-06T22:50:05  *** Victorsueca has quit IRC
889 2018-02-06T22:51:18  *** Victorsueca has joined #bitcoin-core-dev
890 2018-02-06T22:59:01  *** meshcollider has quit IRC
891 2018-02-06T23:03:20  *** dongcarl has quit IRC
892 2018-02-06T23:07:04  *** promag has quit IRC
893 2018-02-06T23:07:50  <BlueMatt> ugh, alright cfields I give up :/ at least I found #12372 in the process
894 2018-02-06T23:07:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12372 | Qt Splash Screen is deleted (and accesses wallet) after Shutdown() (and wallets are deleted). · Issue #12372 · bitcoin/bitcoin · GitHub
895 2018-02-06T23:07:58  <BlueMatt> hopefully it doesnt show up again in rc3
896 2018-02-06T23:08:30  *** Krellan has quit IRC
897 2018-02-06T23:08:49  <cfields> heh
898 2018-02-06T23:08:54  <cfields> BlueMatt: i never saw that one :\
899 2018-02-06T23:09:18  <BlueMatt> I have no idea how realistic it is
900 2018-02-06T23:09:31  <BlueMatt> I was just putting sleeps in the middle of AppInitMain and closing splashscreen
901 2018-02-06T23:13:53  <cfields> BlueMatt: how long are the sleeps? anywhere near reasonable?
902 2018-02-06T23:16:48  *** Randolf has quit IRC
903 2018-02-06T23:20:18  *** promag has joined #bitcoin-core-dev
904 2018-02-06T23:26:22  *** promag has quit IRC
905 2018-02-06T23:38:05  *** Guyver2 has quit IRC
906 2018-02-06T23:45:10  *** arbitrary_guy has joined #bitcoin-core-dev
907 2018-02-06T23:50:02  *** vicenteH has quit IRC
908 2018-02-06T23:56:34  *** dongcarl has joined #bitcoin-core-dev