12018-02-12T00:02:21  *** dgy_ has joined #bitcoin-core-dev
  22018-02-12T00:05:01  *** grafcaps has joined #bitcoin-core-dev
  32018-02-12T00:05:53  *** dgy has quit IRC
  42018-02-12T00:06:28  *** Victorsueca has quit IRC
  52018-02-12T00:07:47  *** Victorsueca has joined #bitcoin-core-dev
  62018-02-12T00:17:10  *** dgy__ has joined #bitcoin-core-dev
  72018-02-12T00:19:35  *** dgy_ has quit IRC
  82018-02-12T00:31:32  *** dgy_ has joined #bitcoin-core-dev
  92018-02-12T00:32:04  *** dgy__ has quit IRC
 102018-02-12T00:38:54  *** grafcaps has quit IRC
 112018-02-12T00:42:27  *** nehan has quit IRC
 122018-02-12T00:44:21  *** grafcaps has joined #bitcoin-core-dev
 132018-02-12T00:49:44  *** grafcaps has quit IRC
 142018-02-12T00:51:19  *** AaronvanW has quit IRC
 152018-02-12T00:58:52  *** larafale has joined #bitcoin-core-dev
 162018-02-12T01:01:37  *** belcher has joined #bitcoin-core-dev
 172018-02-12T01:02:57  *** larafale has quit IRC
 182018-02-12T01:05:53  *** DarylSharp has joined #bitcoin-core-dev
 192018-02-12T01:53:02  *** arubi has quit IRC
 202018-02-12T01:55:17  *** intcat has quit IRC
 212018-02-12T01:56:37  *** grafcaps has joined #bitcoin-core-dev
 222018-02-12T01:58:02  *** intcat has joined #bitcoin-core-dev
 232018-02-12T01:58:09  *** arubi has joined #bitcoin-core-dev
 242018-02-12T02:15:42  *** eklitzke has quit IRC
 252018-02-12T02:16:01  *** eklitzke has joined #bitcoin-core-dev
 262018-02-12T02:21:21  *** huie has joined #bitcoin-core-dev
 272018-02-12T02:27:26  *** jojeyh has quit IRC
 282018-02-12T02:29:24  *** huie has quit IRC
 292018-02-12T02:58:12  *** intcat has quit IRC
 302018-02-12T02:59:16  *** intcat has joined #bitcoin-core-dev
 312018-02-12T03:09:13  *** arubi has quit IRC
 322018-02-12T03:10:00  *** arubi has joined #bitcoin-core-dev
 332018-02-12T03:16:17  *** Sinclair6 has quit IRC
 342018-02-12T03:18:37  *** Sinclair6 has joined #bitcoin-core-dev
 352018-02-12T03:29:12  *** goatpig has joined #bitcoin-core-dev
 362018-02-12T03:49:47  *** btcdrak has joined #bitcoin-core-dev
 372018-02-12T03:58:32  *** belcher has quit IRC
 382018-02-12T04:09:37  *** intcat has quit IRC
 392018-02-12T04:10:49  *** intcat has joined #bitcoin-core-dev
 402018-02-12T05:12:56  *** cryptojanitor has quit IRC
 412018-02-12T05:23:48  *** Victorsueca has quit IRC
 422018-02-12T05:25:16  *** Victorsueca has joined #bitcoin-core-dev
 432018-02-12T05:27:43  *** ohnx has quit IRC
 442018-02-12T05:28:55  *** ohnx has joined #bitcoin-core-dev
 452018-02-12T05:32:02  *** owowo has quit IRC
 462018-02-12T05:47:14  *** mmgen has joined #bitcoin-core-dev
 472018-02-12T05:50:32  *** dlb76 has quit IRC
 482018-02-12T05:54:50  *** dlb76 has joined #bitcoin-core-dev
 492018-02-12T06:03:06  *** mmgen has quit IRC
 502018-02-12T06:03:23  *** mmgen has joined #bitcoin-core-dev
 512018-02-12T06:36:04  *** sengehest has joined #bitcoin-core-dev
 522018-02-12T06:44:55  *** rex_4539 has joined #bitcoin-core-dev
 532018-02-12T06:48:51  *** eklitzke has quit IRC
 542018-02-12T06:50:34  *** eklitzke has joined #bitcoin-core-dev
 552018-02-12T07:03:44  *** sengehest has quit IRC
 562018-02-12T07:05:43  *** rex_4539 has quit IRC
 572018-02-12T07:07:45  *** jtimon has quit IRC
 582018-02-12T07:39:31  *** btcdrak has quit IRC
 592018-02-12T07:54:26  *** rex_4539 has joined #bitcoin-core-dev
 602018-02-12T08:35:28  *** Lightsword has left #bitcoin-core-dev
 612018-02-12T09:06:42  *** razor948 has joined #bitcoin-core-dev
 622018-02-12T09:06:47  <razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐
 632018-02-12T09:06:48  <razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐
 642018-02-12T09:06:48  <razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐
 652018-02-12T09:06:48  <razor948> ┬┬─┐┌─┐ ┌─┐┬ ┬┌─┐┌─┐┬─┐┌┐┌┌─┐┌┬┐┌─┐ ┌─┐┬─┐┌─┐
 662018-02-12T09:06:50  <razor948> │├┬┘│   └─┐│ │├─┘├┤ ├┬┘│││├┤  │ └─┐ │ │├┬┘│ ┬
 672018-02-12T09:06:51  <razor948> │├┬┘│   └─┐│ │├─┘├┤ ├┬┘│││├┤  │ └─┐ │ │├┬┘│ ┬
 682018-02-12T09:06:51  <razor948> │├┬┘│   └─┐│ │├─┘├┤ ├┬┘│││├┤  │ └─┐ │ │├┬┘│ ┬
 692018-02-12T09:06:52  <razor948> │├┬┘│   └─┐│ │├─┘├┤ ├┬┘│││├┤  │ └─┐ │ │├┬┘│ ┬
 702018-02-12T09:06:55  <razor948> ┴┴└─└─┘o└─┘└─┘┴  └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘
 712018-02-12T09:06:56  <razor948> ┴┴└─└─┘o└─┘└─┘┴  └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘
 722018-02-12T09:06:56  <razor948> ┴┴└─└─┘o└─┘└─┘┴  └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘
 732018-02-12T09:06:56  <razor948> ┴┴└─└─┘o└─┘└─┘┴  └─┘┴└─┘└┘└─┘ ┴ └─┘o└─┘┴└─└─┘
 742018-02-12T09:06:59  <razor948> rex_4539 eklitzke mmgen dlb76 ohnx Victorsueca intcat goatpig Sinclair6 arubi grafcaps DarylSharp dgy_ tryphe Randolf shesek Emcy meshcollider dcousens Arise2 mirese Evel-Knievel ghost43 Cory mandric DrFeelGood justanotheruser gmaxwell droark spinza unholymachine lnostdal boblee ludens[m] Masaomi[m] ajtowns[m] kewde[m] herzmeister[m] cncr04s Scrat Apocalyptic NielsvG bordeaux_facile_ Varunram Muis dagurval mariorz jnewbery mlz punch rockhouse Bas
 752018-02-12T09:07:00  *** razor948 has quit IRC
 762018-02-12T09:07:33  <meshcollider> not this again -_-
 772018-02-12T09:07:46  <wumpus> yeah...
 782018-02-12T09:07:57  <aj> at least it's not in colour?
 792018-02-12T09:08:56  <wumpus> can anyone, that uses bitcoin-tx, comment on https://github.com/bitcoin/bitcoin/pull/10694?
 802018-02-12T09:12:10  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fe53d5f3636a...79313d2e2040
 812018-02-12T09:12:10  <bitcoin-git> bitcoin/master a8b5d20 Sjors Provoost: Reset pblocktree before deleting LevelDB file
 822018-02-12T09:12:11  <bitcoin-git> bitcoin/master 79313d2 Wladimir J. van der Laan: Merge #12401: Reset pblocktree before deleting LevelDB file...
 832018-02-12T09:12:59  <bitcoin-git> [bitcoin] laanwj closed pull request #12401: Reset pblocktree before deleting LevelDB file (master...2018/02/reset-pblocktree) https://github.com/bitcoin/bitcoin/pull/12401
 842018-02-12T09:14:28  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/79313d2e2040...a8cbbdb07a59
 852018-02-12T09:14:28  <bitcoin-git> bitcoin/master c4af738 Matt Corallo: Fix ignoring tx data requests when fPauseSend is set on a peer...
 862018-02-12T09:14:29  <bitcoin-git> bitcoin/master a8cbbdb Wladimir J. van der Laan: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer...
 872018-02-12T09:15:19  <bitcoin-git> [bitcoin] laanwj closed pull request #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (master...2018-02-fix-fpausesend-getdata-resp) https://github.com/bitcoin/bitcoin/pull/12392
 882018-02-12T09:22:34  *** timothy has joined #bitcoin-core-dev
 892018-02-12T09:25:55  <jonasschnelli> rc4?
 902018-02-12T09:26:27  <wumpus> maybe...
 912018-02-12T09:26:47  <wumpus> might be too soon
 922018-02-12T09:27:06  <jonasschnelli> maybe wait for other report, right.
 932018-02-12T09:27:11  <jonasschnelli> *reports
 942018-02-12T09:27:33  *** Muis has quit IRC
 952018-02-12T09:27:43  <wumpus> if you release too many rcs in short succession the number of testers will likely drop; I've already seen the first "I'll test next weekend when rc n+1 is out"
 962018-02-12T09:27:50  *** Muis has joined #bitcoin-core-dev
 972018-02-12T09:28:00  *** drizztbsd has joined #bitcoin-core-dev
 982018-02-12T09:29:00  <wumpus> so let's keep it to 1 per week
 992018-02-12T09:29:12  *** timothy has quit IRC
1002018-02-12T09:29:46  <wumpus> going to do the backports already so people on the 0.16 branch can test
1012018-02-12T09:30:15  <jonasschnelli> Makes sense.
1022018-02-12T09:31:04  <gmaxwell> wumpus: though perhaps the things that would be in rc3 should ... nevermind you got it. :P
1032018-02-12T09:31:26  * gmaxwell will test as soon as the backports are merged.
1042018-02-12T09:31:31  *** profall has quit IRC
1052018-02-12T09:32:11  *** profall has joined #bitcoin-core-dev
1062018-02-12T09:32:51  *** larafale has joined #bitcoin-core-dev
1072018-02-12T09:34:14  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/a5e3d44cc8f6...0f616517e1f2
1082018-02-12T09:34:14  <bitcoin-git> bitcoin/0.16 d44cd7e Sjors Provoost: Reset pblocktree before deleting LevelDB file...
1092018-02-12T09:34:15  <bitcoin-git> bitcoin/0.16 0f61651 Matt Corallo: Fix ignoring tx data requests when fPauseSend is set on a peer...
1102018-02-12T09:34:22  <wumpus> gmaxwell: ^^
1112018-02-12T09:35:23  <gmaxwell> oh lol I was already running with those two patches.
1122018-02-12T09:35:30  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8cbbdb07a59...0dfc25f82a01
1132018-02-12T09:35:31  <bitcoin-git> bitcoin/master f26866b Cory Fields: boost: drop boost threads for upnp
1142018-02-12T09:35:31  <bitcoin-git> bitcoin/master ba91724 Cory Fields: boost: remove useless threadGroup parameter from Discover
1152018-02-12T09:35:32  <bitcoin-git> bitcoin/master 0827267 Cory Fields: boost: drop boost threads from torcontrol
1162018-02-12T09:35:37  <wumpus> heh
1172018-02-12T09:35:43  *** Lightsword has joined #bitcoin-core-dev
1182018-02-12T09:36:14  <bitcoin-git> [bitcoin] laanwj closed pull request #12381: Remove more boost threads (master...boost-threads-again) https://github.com/bitcoin/bitcoin/pull/12381
1192018-02-12T09:38:59  <Randolf> Maybe #12393 is an easy one to close?
1202018-02-12T09:39:01  <gribble> https://github.com/bitcoin/bitcoin/issues/12393 | Fix a-vs-an typos by practicalswift · Pull Request #12393 · bitcoin/bitcoin · GitHub
1212018-02-12T09:39:02  <Randolf> Merge?
1222018-02-12T09:39:14  <Randolf> Simple documentation fixes.
1232018-02-12T09:39:30  *** laurentmt has joined #bitcoin-core-dev
1242018-02-12T09:39:31  <Randolf> Not a high priority.
1252018-02-12T09:40:06  <gmaxwell> Randolf: it has pending requested changes by reviewers.
1262018-02-12T09:40:28  <wumpus> documentation is high priority unless. yeah, this is only typos
1272018-02-12T09:40:58  <Randolf> gmaxwell:  Okay.  Is there a place where one can see what's in the "pending requested changes by reviewers" list?  Or is the fact that they're open already implying that?
1282018-02-12T09:41:11  <gmaxwell> Randolf: look at the last comments on it.
1292018-02-12T09:41:25  <gmaxwell> oh I misread, sorry!
1302018-02-12T09:41:41  <Randolf> I see "utACK" from luke-jr.
1312018-02-12T09:41:43  <gmaxwell> (I thought the last comment was asking to remove that change, and I saw no commits after it)
1322018-02-12T09:42:04  *** nejon has quit IRC
1332018-02-12T09:42:14  <Randolf> My curiosity on this is motivated by my desire to gain a better understanding of how this all works.
1342018-02-12T09:42:23  *** nejon has joined #bitcoin-core-dev
1352018-02-12T09:43:08  <Randolf> (So far, the process overall seems to be well organized and efficient.)
1362018-02-12T09:44:38  *** gribble has quit IRC
1372018-02-12T09:50:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0dfc25f82a01...108af52ef75a
1382018-02-12T09:50:30  <bitcoin-git> bitcoin/master 11376b5 practicalswift: Fix a-vs-an typos
1392018-02-12T09:50:31  <bitcoin-git> bitcoin/master 108af52 Wladimir J. van der Laan: Merge #12393: Fix a-vs-an typos...
1402018-02-12T09:51:19  <bitcoin-git> [bitcoin] laanwj closed pull request #12393: Fix a-vs-an typos (master...a-vs-an-typos) https://github.com/bitcoin/bitcoin/pull/12393
1412018-02-12T09:53:05  <Randolf> wumpus:  I agree.
1422018-02-12T10:00:14  *** gribble has joined #bitcoin-core-dev
1432018-02-12T10:03:18  <wumpus> Randolf: cool, someone finally agrees with me for once, mind if I save the quote? :)
1442018-02-12T10:06:00  <Sentineo> :D
1452018-02-12T10:07:44  *** mturquette has quit IRC
1462018-02-12T10:08:18  *** mturquette has joined #bitcoin-core-dev
1472018-02-12T10:10:39  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1482018-02-12T10:10:39  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1492018-02-12T10:10:40  *** ken2812221 has joined #bitcoin-core-dev
1502018-02-12T10:16:58  <Randolf> wumpus:  Yes, I have no objections to being quoted.  (My full name is Randolf Richardson.)
1512018-02-12T10:17:19  <wumpus> Randolf: woohoo!
1522018-02-12T10:17:52  <Randolf> wumpus:  I'm a big fan of writing documentation before coding.  I do this with all the software that I write.
1532018-02-12T10:18:06  <Randolf> wumpus:  It sure makes maintenance easier later on.
1542018-02-12T10:19:19  <wumpus> Randolf: yup; it's good to have a background idea why something was done; and the most important thing is correct documentation, comments that are deceiving and don't match the code are worse than having no comments at all
1552018-02-12T10:20:36  <Randolf> I like comments in code too.  Sometimes they are overdone though, so I prefer to have a mixture of per-line comments (for specific things that need it) and an introductory set prior to a number of instructions / lines of code.
1562018-02-12T10:21:31  <wumpus> I think what is important about code comments is that they explain reasoning, not directly what the code does which is obvious to everyone with knowledge of the programming language
1572018-02-12T10:31:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/108af52ef75a...b4d85490f09e
1582018-02-12T10:31:46  <bitcoin-git> bitcoin/master faefd29 MarcoFalke: qa: Prepare functional tests for Windows...
1592018-02-12T10:31:47  <bitcoin-git> bitcoin/master b4d8549 Wladimir J. van der Laan: Merge #11858: qa: Prepare tests for Windows...
1602018-02-12T10:32:16  <bitcoin-git> [bitcoin] laanwj closed pull request #11858: qa: Prepare tests for Windows (master...Mf1712-qaWinForRealNow) https://github.com/bitcoin/bitcoin/pull/11858
1612018-02-12T10:36:17  *** promag has joined #bitcoin-core-dev
1622018-02-12T10:38:02  *** nOgAnOo has quit IRC
1632018-02-12T10:38:59  *** nOgAnOo has joined #bitcoin-core-dev
1642018-02-12T10:41:37  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4d85490f09e...c8b54b2044db
1652018-02-12T10:41:37  <bitcoin-git> bitcoin/master a25cb0f murrayn: Use ptrdiff_t type to more precisely indicate usage and avoid compiler warnings.
1662018-02-12T10:41:38  <bitcoin-git> bitcoin/master c8b54b2 Wladimir J. van der Laan: Merge #12351: Libraries: Use correct type ; avoid compiler warnings....
1672018-02-12T10:42:22  <bitcoin-git> [bitcoin] laanwj closed pull request #12351: Libraries: Use correct type ; avoid compiler warnings. (master...ptrdiff_t) https://github.com/bitcoin/bitcoin/pull/12351
1682018-02-12T10:44:20  *** AaronvanW has joined #bitcoin-core-dev
1692018-02-12T10:44:32  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c8b54b2044db...8e6f9f4ebc74
1702018-02-12T10:44:33  <bitcoin-git> bitcoin/master 718f05c Gregory Sanders: move more bumpfee prechecks to feebumper::PreconditionChecks
1712018-02-12T10:44:33  <bitcoin-git> bitcoin/master faca18d MarcoFalke: feebumper: Use PreconditionChecks to determine bump eligibility
1722018-02-12T10:44:34  <bitcoin-git> bitcoin/master 8e6f9f4 Jonas Schnelli: Merge #12296: wallet: Only fee-bump non-conflicted/non-confirmed txes...
1732018-02-12T10:45:18  *** Victorsueca has quit IRC
1742018-02-12T10:45:40  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12296: wallet: Only fee-bump non-conflicted/non-confirmed txes (master...Mf1801-walletFeeBumpNoConf) https://github.com/bitcoin/bitcoin/pull/12296
1752018-02-12T10:46:34  *** Victorsueca has joined #bitcoin-core-dev
1762018-02-12T10:47:26  <provoostenator> In at least some cases the reference code is more clear than the BIP it implements, thanks to an abundance of comments.
1772018-02-12T10:48:43  <bitcoin-git> [bitcoin] laanwj closed pull request #12023: update the OpenBSD build guide (master...openbsd) https://github.com/bitcoin/bitcoin/pull/12023
1782018-02-12T10:48:48  <promag> is it valid or not to have the on scriptpubkey duplicated?
1792018-02-12T10:48:55  <wumpus> provoostenator: that's a good thing, yes :)
1802018-02-12T10:48:57  <promag> *the same
1812018-02-12T10:49:27  *** DrFeelGood has quit IRC
1822018-02-12T10:49:50  *** Aaronvan_ has joined #bitcoin-core-dev
1832018-02-12T10:50:05  <gmaxwell> the same scriptpubkey duplicated where?
1842018-02-12T10:50:59  <gmaxwell> promag: are you asking if a transaction can have multiple outputs using the same scriptpubkey?
1852018-02-12T10:51:18  <promag> yes, sorry if it was't clear
1862018-02-12T10:51:30  <gmaxwell> If so, thats valid in the consensus rules, though bitcoin core's wallet (and I assume most other wallets) won't produce it.
1872018-02-12T10:51:35  *** AaronvanW has quit IRC
1882018-02-12T10:52:00  <gmaxwell> (e.g. if you do a sendmany with repeated outputs it just merges them)
1892018-02-12T10:52:04  <murrayn> sipa, I get that. But where's the bottleneck? I could see if one cpu was pegged. Or disk IO. But nothing seems to be happening. It's just slow.
1902018-02-12T10:52:28  <bitcoin-git> [bitcoin] laanwj closed pull request #11790: Add pixmaps for testnet and regtest (master...pixmaps) https://github.com/bitcoin/bitcoin/pull/11790
1912018-02-12T10:52:29  <promag> gmaxwell: well fundrawtransaction allows a change address to be one of the outputs
1922018-02-12T10:52:37  *** Julie73Donnelly has joined #bitcoin-core-dev
1932018-02-12T10:52:45  <promag> gmaxwell: should probably check that?
1942018-02-12T10:53:55  <wumpus> sounds like an edge case that might be checked, yes. Not because it would be invalid, but because it 100% sure means someone made amistake.
1952018-02-12T10:54:13  <promag> maybe 99%
1962018-02-12T10:54:14  <promag> :P
1972018-02-12T10:54:27  <wumpus> I can't think of any reason why it wouldn't be
1982018-02-12T10:55:02  <promag> like a stupid coin split to same address
1992018-02-12T10:55:28  <wumpus> I see no point to doing that
2002018-02-12T10:55:29  <promag> anyway, should we bother to check that on these raw rpc?
2012018-02-12T10:58:05  <wumpus> esp. after #12257, when the coin selection is changed so that all coins sent to a certain destination will always be spent at once
2022018-02-12T10:58:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
2032018-02-12T11:00:38  <promag> wumpus: should the check be in fundrawtransaction or CWallet::CreateTransaction?
2042018-02-12T11:01:53  <wumpus> probably in CreateTransaction if you want to catch all cases where this is a possibility
2052018-02-12T11:02:33  <wumpus> e.g. otherwise you could still do the same trick from the GUI with coincontrol?
2062018-02-12T11:02:43  <sipa> murrayn: usually it's RAM and disk access that's the bottleneck
2072018-02-12T11:04:02  <murrayn> sipa I can confirm that it's neither for me. I am running dbcache 2048 and disk IO is not a factor.
2082018-02-12T11:04:16  <sipa> what are you observing?
2092018-02-12T11:04:26  <murrayn> what do you mean?
2102018-02-12T11:04:41  <sipa> what do you see, what do you expect to see
2112018-02-12T11:05:15  <murrayn> like i said i could understand if one cpu was pegged. i have a quad core processor
2122018-02-12T11:05:29  <murrayn> there is no heavy disk i/o
2132018-02-12T11:05:34  <sipa> well is it making progress?
2142018-02-12T11:05:46  <murrayn> it moves forward, like time itself
2152018-02-12T11:06:05  <sipa> is it validating blocks?
2162018-02-12T11:06:10  <murrayn> yes!
2172018-02-12T11:06:26  <sipa> what's in debug.log?
2182018-02-12T11:06:42  <murrayn> but if i have the hardware, why not do it quicker? i'm waiting dammit!
2192018-02-12T11:07:20  <gmaxwell> murrayn: bitcoin it takes hours to sync even on the fastest hardware available, its doing a tremendous amount of work.
2202018-02-12T11:07:48  <gmaxwell> when you say 'disk IO is not a factor' -- this isn't particularly convincing. IOwait often doesn't look like high usage.
2212018-02-12T11:08:18  <phantomcircuit> gmaxwell, i do experience stang performance things doing IBD over the network where there isn't any obvious bottleneck
2222018-02-12T11:08:27  <phantomcircuit> (vm with fsync off)
2232018-02-12T11:08:28  <sipa> with dbcache 2048 i would expect 100% cpu usage on one core though
2242018-02-12T11:08:38  <sipa> for extended periods of time between flushes
2252018-02-12T11:08:51  <echeveria> it comes across to me as sort of bursty for no real reason.
2262018-02-12T11:08:53  <wumpus> I'm missing the context, but if it doesn't max out your CPUs, don't you happen to have bad peers so it's waiting for blocks?
2272018-02-12T11:09:15  <murrayn> https://pastebin.com/nAipD6J3
2282018-02-12T11:09:16  <phantomcircuit> wumpus, yes
2292018-02-12T11:09:18  <echeveria> wumpus: even when directly connected to a single peer on a 200Mbit line, I've seen that.
2302018-02-12T11:09:18  <wumpus> in the latter stages of synchronization it will generally use all cores at 100% where it can, in my experience
2312018-02-12T11:09:23  <murrayn> that's the tail of debug.log
2322018-02-12T11:09:30  <phantomcircuit> iirc there is supposed to be logic to handle that but it doesn't seem to work great
2332018-02-12T11:09:40  <phantomcircuit> but it works well enough that i haven't looked carefully
2342018-02-12T11:09:59  <sipa> murrayn: can you show a bit more?
2352018-02-12T11:10:09  <murrayn> sure, how much?
2362018-02-12T11:10:13  <sipa> a page
2372018-02-12T11:10:13  <gmaxwell> stalling peers is certantly a thing, the functionality to deal with that is "simplest thing necessary to avoid totally failing" grade.
2382018-02-12T11:10:33  <gmaxwell> murrayn: are you doing this sync on a computer you physically have or AWS or what?
2392018-02-12T11:10:37  <wumpus> gmaxwell: indeed
2402018-02-12T11:10:59  <murrayn> https://pastebin.com/jXXLpmxE
2412018-02-12T11:11:11  <murrayn> gmaxwell, my desktop
2422018-02-12T11:11:33  <echeveria> 2018-02-12 11:06:21 version handshake timeout from 476
2432018-02-12T11:11:34  <echeveria> 2018-02-12 11:06:24 version handshake timeout from 477
2442018-02-12T11:11:35  <echeveria> that's fun.
2452018-02-12T11:12:52  <echeveria> it's in my log a bunch too but I've never been able to work out a pattern in it.
2462018-02-12T11:13:10  <sipa> murrayn: you may want to run with -debug=bench of you want to figure out what it's spending time on
2472018-02-12T11:13:17  <sipa> but it may just be shitty peers
2482018-02-12T11:13:34  <sipa> that don't give you blocks fast enough for you to process
2492018-02-12T11:13:37  <murrayn> well i'm afraid to start over!
2502018-02-12T11:13:44  <sipa> it won't
2512018-02-12T11:13:57  <murrayn> "only" 1 year 16 weeks behind
2522018-02-12T11:14:05  <sipa> if you shutdown cleanly it will continue where it left off
2532018-02-12T11:14:50  <murrayn> ok sipa i will try
2542018-02-12T11:15:06  <gmaxwell> These logs look pretty normal.
2552018-02-12T11:15:26  <gmaxwell> other than it being a bit slow.
2562018-02-12T11:15:28  <murrayn> just to add some background this is running with -reindex-chainstate because i already had all the blocks downloaded
2572018-02-12T11:15:44  <sipa> oh
2582018-02-12T11:15:57  <gmaxwell> see now all these peer theories go out the window.
2592018-02-12T11:15:58  <sipa> well, then it's not due to slow peers
2602018-02-12T11:16:01  <murrayn> no
2612018-02-12T11:16:22  <sipa> but in any case, don't run with -reindex-chainstate the second time or it will start over again
2622018-02-12T11:16:24  <murrayn> my initial sync took 10 days which i thought was crazy
2632018-02-12T11:16:40  <sipa> but you can shutdown and it will continue the reindex
2642018-02-12T11:17:02  <gmaxwell> murrayn: what OS and what version of the software is this?
2652018-02-12T11:17:15  <murrayn> win7, 0.15.1
2662018-02-12T11:17:29  <gmaxwell> some anti-virus can absurdly slow down sync.
2672018-02-12T11:17:37  <murrayn> n/a
2682018-02-12T11:18:16  *** Guyver2 has joined #bitcoin-core-dev
2692018-02-12T11:18:31  <gmaxwell> wumpus: why are you running -reindex-chainstate?
2702018-02-12T11:19:03  <murrayn> gmaxwell, do you mean me?
2712018-02-12T11:19:06  <gmaxwell> lol yes
2722018-02-12T11:19:10  <murrayn> ok
2732018-02-12T11:19:21  <murrayn> i moved the datadir to a new disk
2742018-02-12T11:19:38  <gmaxwell> would it happen to be a USB hard drive?
2752018-02-12T11:19:42  <murrayn> and when i restarted bitcoin-qt it did it's thing
2762018-02-12T11:19:45  <murrayn> gmaxwell, no
2772018-02-12T11:19:52  <phantomcircuit> murrayn, that looks like io issues
2782018-02-12T11:19:58  <phantomcircuit> there's 2-3 seconds between blocks
2792018-02-12T11:20:00  <phantomcircuit> it's not bursty
2802018-02-12T11:20:15  <murrayn> i would be glad to see 2-3s/block
2812018-02-12T11:21:00  *** larafale has quit IRC
2822018-02-12T11:21:02  <murrayn> phantomcircuit, it's just not IO. these aren't slow drives
2832018-02-12T11:21:06  <murrayn> i would hear them!
2842018-02-12T11:21:37  *** larafale has joined #bitcoin-core-dev
2852018-02-12T11:21:51  <bitcoin-git> [bitcoin] promag opened pull request #12415: Interrupt loading thread after shutdown request (master...2018-02-shutdown) https://github.com/bitcoin/bitcoin/pull/12415
2862018-02-12T11:22:15  <gmaxwell> hear them?
2872018-02-12T11:22:17  <murrayn> i do see memory use climb up to 2G+, but then it drops down and starts the cycle again
2882018-02-12T11:22:49  * gmaxwell waits to hear that he's using a shingled spinning disk...
2892018-02-12T11:22:50  <murrayn> it's under 1G now
2902018-02-12T11:23:12  <gmaxwell> murrayn: yes when the cache fills it flushes.
2912018-02-12T11:23:28  <murrayn> yeah, makes sense
2922018-02-12T11:23:41  <gmaxwell> The name cache is largely a misnomer, the main useful thing the cache does during sync is act as a buffer to prevent spent outputs from ever hitting the database.
2932018-02-12T11:24:02  <gmaxwell> it caches too, but that function doesn't do much for performance.
2942018-02-12T11:24:11  <gmaxwell> (during sync)
2952018-02-12T11:24:15  <murrayn> ok, well i'm using -dbcache=2048
2962018-02-12T11:25:41  <murrayn> just out of curiosity, when is the last time any of you guys in this conversation started a new datadir
2972018-02-12T11:26:23  <murrayn> i'm willing to believe it's some issue with the windows build, and willing to try to track it down.
2982018-02-12T11:27:01  <gmaxwell> murrayn: several times a month.
2992018-02-12T11:27:09  <murrayn> ok, thought so
3002018-02-12T11:27:24  <gmaxwell> murrayn: it's not an issue with the 'windows build' people have reported couple hour syncs in windows with 0.15.x
3012018-02-12T11:27:28  <murrayn> gmaxwell, from the network?
3022018-02-12T11:27:52  <gmaxwell> murrayn: yes, and reindexes.
3032018-02-12T11:28:38  <murrayn> well in any case i would like to help track it down. from what I read I'm not alone.
3042018-02-12T11:28:58  *** Pavle has joined #bitcoin-core-dev
3052018-02-12T11:29:17  <gmaxwell> in your case either you finished syncing from blocks on disk and started pulling from the network and your slower due to peers/network.. or your IO is just super high latency on your system.
3062018-02-12T11:29:39  <gmaxwell> murrayn: sipa asked you earlier to turn up bench debugging.
3072018-02-12T11:30:03  <gmaxwell> murrayn: you can turn them on without restarting dunno why he didn't suggest that.
3082018-02-12T11:30:10  <murrayn> gmaxwell, yeah but i don't want to restart and lose over two days of "progress"
3092018-02-12T11:30:16  <murrayn> oh ok
3102018-02-12T11:30:18  <gmaxwell> you won't lose progress.
3112018-02-12T11:30:27  <gmaxwell> regardless, it'll continue from where it is.
3122018-02-12T11:30:45  <gmaxwell> use the logging rpc/cli command to enable bench and net
3132018-02-12T11:31:02  <murrayn> can you give me a tldr?
3142018-02-12T11:31:13  <murrayn> the command
3152018-02-12T11:31:18  <wumpus> I think it's time to move this to #bitcoin
3162018-02-12T11:31:54  <gmaxwell> murrayn: you're using the gui interface? bring up the debug console and run logging '["bench","net"]'
3172018-02-12T11:32:02  *** Giszmo has joined #bitcoin-core-dev
3182018-02-12T11:32:12  <murrayn> or console. ok will try
3192018-02-12T11:32:47  <murrayn> done will report back in a few
3202018-02-12T11:35:05  *** drizztbsd has quit IRC
3212018-02-12T11:38:30  *** timothy has joined #bitcoin-core-dev
3222018-02-12T11:41:21  *** arubi has quit IRC
3232018-02-12T11:42:06  *** arubi has joined #bitcoin-core-dev
3242018-02-12T11:44:59  *** drizztbsd has joined #bitcoin-core-dev
3252018-02-12T11:46:15  *** timothy has quit IRC
3262018-02-12T12:08:26  *** Sentineo has quit IRC
3272018-02-12T12:11:30  <dcousens> wumpus - hope https://github.com/bitcoin/bitcoin/pull/12169#issuecomment-364903510 didn't de-rail,  I was genuinely curious and figured it might be useful to others to see a code example
3282018-02-12T12:13:57  *** PiedPiper has joined #bitcoin-core-dev
3292018-02-12T12:19:25  *** Sentineo has joined #bitcoin-core-dev
3302018-02-12T12:31:39  *** PiedPiper has left #bitcoin-core-dev
3312018-02-12T12:33:28  *** Giszmo1 has joined #bitcoin-core-dev
3322018-02-12T12:51:01  *** Giszmo1 has quit IRC
3332018-02-12T13:03:53  *** cryptojanitor has joined #bitcoin-core-dev
3342018-02-12T13:09:33  *** Aaronvan_ is now known as AaronvanW
3352018-02-12T13:19:23  *** Victorsueca has quit IRC
3362018-02-12T13:20:47  *** Victorsueca has joined #bitcoin-core-dev
3372018-02-12T13:22:30  *** SopaXorzTaker has joined #bitcoin-core-dev
3382018-02-12T13:32:52  *** Jacinthe3Hermist has joined #bitcoin-core-dev
3392018-02-12T13:40:48  *** Pavle has quit IRC
3402018-02-12T13:43:16  *** belcher has joined #bitcoin-core-dev
3412018-02-12T13:48:27  *** mariorz has quit IRC
3422018-02-12T13:48:43  *** jtimon has joined #bitcoin-core-dev
3432018-02-12T13:48:45  *** mariorz has joined #bitcoin-core-dev
3442018-02-12T13:54:46  *** hasish has joined #bitcoin-core-dev
3452018-02-12T14:02:35  *** hasish has quit IRC
3462018-02-12T14:07:00  *** DarylSharp has quit IRC
3472018-02-12T14:13:09  *** wbnns has quit IRC
3482018-02-12T14:13:26  *** wbnns has joined #bitcoin-core-dev
3492018-02-12T14:18:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/8e6f9f4ebc74...5dc00f68c49c
3502018-02-12T14:18:29  <bitcoin-git> bitcoin/master a570098 MarcoFalke: Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba...
3512018-02-12T14:18:29  <bitcoin-git> bitcoin/master fa1388e MarcoFalke: univalue: Bump subtree
3522018-02-12T14:18:30  <bitcoin-git> bitcoin/master 91986ed Karel Bilek: scripted-diff: Use UniValue.pushKV instead of push_back(Pair())...
3532018-02-12T14:19:13  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) (master...Mf1801-univalueDeprecatedPair) https://github.com/bitcoin/bitcoin/pull/12193
3542018-02-12T14:28:18  *** ibrightly has quit IRC
3552018-02-12T14:28:35  *** ibrightly has joined #bitcoin-core-dev
3562018-02-12T14:29:35  *** unholymachine has quit IRC
3572018-02-12T14:30:35  *** unholymachine has joined #bitcoin-core-dev
3582018-02-12T14:33:18  *** sferrini has quit IRC
3592018-02-12T14:34:49  *** sferrini has joined #bitcoin-core-dev
3602018-02-12T14:51:45  <bitcoin-git> [bitcoin] practicalswift opened pull request #12416: Fix Windows build errors introduced in #10498 (master...fix-windows-build) https://github.com/bitcoin/bitcoin/pull/12416
3612018-02-12T15:08:50  *** CodeShark has quit IRC
3622018-02-12T15:09:04  *** CodeShark has joined #bitcoin-core-dev
3632018-02-12T15:22:48  *** meshcollider has quit IRC
3642018-02-12T15:28:15  *** NicolasDorier has quit IRC
3652018-02-12T15:28:34  *** NicolasDorier has joined #bitcoin-core-dev
3662018-02-12T15:58:13  *** laurentmt has quit IRC
3672018-02-12T16:00:21  *** grafcaps has quit IRC
3682018-02-12T16:20:57  *** grafcaps has joined #bitcoin-core-dev
3692018-02-12T16:21:27  *** owowo has joined #bitcoin-core-dev
3702018-02-12T16:22:09  <instagibbs> is someone generating hashes of issues/prs somewhere?
3712018-02-12T16:22:10  *** FraJah has joined #bitcoin-core-dev
3722018-02-12T16:22:37  <instagibbs> wumpus, oh i see you linked, nevermind
3732018-02-12T16:23:20  *** neha has quit IRC
3742018-02-12T16:23:37  *** neha has joined #bitcoin-core-dev
3752018-02-12T16:24:06  <wumpus> yes not so much hashes as a full mirror of information available through the API, though of course you can use it to compute hashes: https://github.com/zw/bitcoin-gh-meta
3762018-02-12T16:25:33  *** grafcaps has quit IRC
3772018-02-12T16:25:36  *** dermoth has quit IRC
3782018-02-12T16:26:41  *** dermoth has joined #bitcoin-core-dev
3792018-02-12T16:28:17  *** grafcaps has joined #bitcoin-core-dev
3802018-02-12T16:30:02  *** trotski2000 has quit IRC
3812018-02-12T16:30:34  *** trotski2000 has joined #bitcoin-core-dev
3822018-02-12T16:32:21  *** Varunram has quit IRC
3832018-02-12T16:32:34  *** Varunram has joined #bitcoin-core-dev
3842018-02-12T16:34:54  *** Dizzle has joined #bitcoin-core-dev
3852018-02-12T16:42:26  *** quer has joined #bitcoin-core-dev
3862018-02-12T16:49:24  *** JackH has quit IRC
3872018-02-12T16:50:23  *** hasish has joined #bitcoin-core-dev
3882018-02-12T17:11:09  *** Guyver2 has quit IRC
3892018-02-12T17:40:56  *** Dizzle has quit IRC
3902018-02-12T17:41:23  *** Dizzle has joined #bitcoin-core-dev
3912018-02-12T17:45:06  *** Victorsueca has quit IRC
3922018-02-12T17:46:18  *** Victorsueca has joined #bitcoin-core-dev
3932018-02-12T17:52:33  *** twistedline has quit IRC
3942018-02-12T17:56:11  *** twistedline has joined #bitcoin-core-dev
3952018-02-12T18:04:42  *** qttmyth88 has joined #bitcoin-core-dev
3962018-02-12T18:10:33  <qttmyth88> Hello, Is there a precaution to sending a request through bitcoin core. What happens if a malware classified me as a fraud because my name doesn't show as the name on the internet provider. Is there away to remove me off that alert?
3972018-02-12T18:11:57  *** spinza has quit IRC
3982018-02-12T18:16:53  *** drizztbsd has quit IRC
3992018-02-12T18:18:43  *** jojeyh has joined #bitcoin-core-dev
4002018-02-12T18:20:26  *** qttmyth88 has quit IRC
4012018-02-12T18:37:47  *** Harvey_Birdman has joined #bitcoin-core-dev
4022018-02-12T18:40:06  *** laurentmt has joined #bitcoin-core-dev
4032018-02-12T18:45:44  <provoostenator> How is change_type in coincontrol used? There's no UI for it afaik, but maybe an RPC command?
4042018-02-12T18:46:16  *** Harvey_Birdman has quit IRC
4052018-02-12T18:46:17  *** polpol has joined #bitcoin-core-dev
4062018-02-12T18:48:04  <provoostenator> Or is coincontrol.h alwasys used even if the user turns off "Enable coin control features"?
4072018-02-12T18:49:46  <sipa> yes, it's just the interface to pass information to the coin selection algorithm
4082018-02-12T18:57:38  *** sengehest has joined #bitcoin-core-dev
4092018-02-12T18:59:15  <polpol> i heard that after 0.16.0 segwit will be used "by default" is that correct?
4102018-02-12T19:00:07  <sipa> yes
4112018-02-12T19:02:04  <polpol> that means that segwit usage will be 100% or not necessarily?
4122018-02-12T19:02:30  <sipa> no, people may be using wallet software other than bitcoin core
4132018-02-12T19:02:54  <sipa> or may choose to turn it off
4142018-02-12T19:03:10  <sipa> or may continue to use addresses they created before
4152018-02-12T19:03:25  <polpol> got it, thank you sipa
4162018-02-12T19:03:26  <sipa> or may keep spending coins sent to earlier addresses
4172018-02-12T19:04:20  <michagogo> Does anyone here have any experience in working with Ubuntu packages (backports etc.)?
4182018-02-12T19:05:12  *** ghost43 has quit IRC
4192018-02-12T19:07:06  *** ghost43 has joined #bitcoin-core-dev
4202018-02-12T19:12:20  *** zautomata has joined #bitcoin-core-dev
4212018-02-12T19:13:23  *** alephzero has quit IRC
4222018-02-12T19:14:34  *** AdrianG has joined #bitcoin-core-dev
4232018-02-12T19:15:55  *** AdrianG is now known as AlephZero
4242018-02-12T19:17:31  <instagibbs> provoostenator, yeah coin control is an overloaded term imo. consumers see it as that qt window, Core contributors see it as what sipa said
4252018-02-12T19:18:54  <provoostenator> Is there a good reason not to just remove that checbox and turn it on by default?
4262018-02-12T19:20:05  <sipa> which checkbox?
4272018-02-12T19:20:37  <provoostenator> There's a "Enable Coin Control Features" checkbox in the QT settings.Maybe move Coin Control Features to the bottom of the Send screen, below fees. As long as the basic stuff is at the top, it shouldn't be too intimiating.
4282018-02-12T19:21:30  <provoostenator> And some sort of Show / Hide toggle in the send screen itself make more sense to me in general.
4292018-02-12T19:21:53  <sipa> define basic stuff
4302018-02-12T19:22:09  <provoostenator> Basic stuff: how much, to which address
4312018-02-12T19:22:33  <sipa> the idea is that most users don't know and shouldn't care about things like coins, inputs, outputs, groupings, ...
4322018-02-12T19:22:36  <provoostenator> (and label / note)
4332018-02-12T19:23:43  *** Scrat has quit IRC
4342018-02-12T19:24:13  <provoostenator> The Coin Control Feature at the moment are only Input selection and a custom change address. They can be hidden by default, but I don't need you need a setting to reveal them.
4352018-02-12T19:24:35  *** lnostdal has quit IRC
4362018-02-12T19:25:34  *** lnostdal has joined #bitcoin-core-dev
4372018-02-12T19:26:00  <provoostenator> E.g. there could be Coin Control button next to Add Recipient at the bottom of the screen to toggle that section.
4382018-02-12T19:39:41  *** spinza has joined #bitcoin-core-dev
4392018-02-12T19:40:17  *** mirese_ has joined #bitcoin-core-dev
4402018-02-12T19:41:19  *** owowo has quit IRC
4412018-02-12T19:44:04  *** mirese has quit IRC
4422018-02-12T19:44:11  <provoostenator> ryanofsky or someone else: re #11625, I have no idea how to use gdb other than "gdb src/qt/test/test_bitcoin-qt"
4432018-02-12T19:44:14  <gribble> https://github.com/bitcoin/bitcoin/issues/11625 | Add BitcoinApplication & RPCConsole tests by ryanofsky · Pull Request #11625 · bitcoin/bitcoin · GitHub
4442018-02-12T19:44:54  <provoostenator> And do I need to use any special configure flags?
4452018-02-12T19:46:16  *** owowo has joined #bitcoin-core-dev
4462018-02-12T19:47:30  *** dermoth has quit IRC
4472018-02-12T19:48:15  *** dermoth has joined #bitcoin-core-dev
4482018-02-12T19:58:33  *** polpol has quit IRC
4492018-02-12T20:03:49  *** SopaXorzTaker has quit IRC
4502018-02-12T20:06:18  *** dcousens has quit IRC
4512018-02-12T20:07:21  *** dcousens has joined #bitcoin-core-dev
4522018-02-12T20:10:03  <michagogo> Hm
4532018-02-12T20:10:19  <michagogo> I tried to see if mingw-w64 was easily backportable
4542018-02-12T20:10:37  <michagogo> And it's not really working, something about dependencies
4552018-02-12T20:11:08  *** cysm has quit IRC
4562018-02-12T20:12:13  <michagogo> For all I know it's easy to fix, but I don't actually know ~anything about Ubuntu packaging, so I have no idea how to do more than run the `backportpackage` command :-/
4572018-02-12T20:19:39  <cfields> sipa: 1day-ago pong.
4582018-02-12T20:25:45  <instagibbs> fAllowOtherInputs comment seems to be off. "//! If false, allows unselected inputs, but requires all selected inputs be used". But AvailableCoins immediately filters things not on the selected list when list is non-zero
4592018-02-12T20:25:51  <instagibbs> am I understanding it right
4602018-02-12T20:27:02  <instagibbs> SelectCoins allows you to use other inputs, but those inputs will never be fed in the normal Available->Select flow
4612018-02-12T20:32:41  <provoostenator> Gotta love Stack Overflow... "Here's one million ways to fix gdb on OSX...." "Oh by the way, you can use lldb"
4622018-02-12T20:33:25  *** jamesob has joined #bitcoin-core-dev
4632018-02-12T20:34:15  *** Pavle has joined #bitcoin-core-dev
4642018-02-12T20:37:03  <bitcoin-git> [bitcoin] droark opened pull request #12417: [WIP] Delete mac_alias patch (master...master_del_mac_alias) https://github.com/bitcoin/bitcoin/pull/12417
4652018-02-12T20:38:05  *** AaronvanW has quit IRC
4662018-02-12T20:41:58  *** hasish has quit IRC
4672018-02-12T20:43:21  *** mmgen has quit IRC
4682018-02-12T20:49:02  *** d9b4bef9 has quit IRC
4692018-02-12T20:50:08  *** d9b4bef9 has joined #bitcoin-core-dev
4702018-02-12T21:00:04  *** Pavle has quit IRC
4712018-02-12T21:07:46  *** laurentmt has quit IRC
4722018-02-12T21:08:43  *** cysm has joined #bitcoin-core-dev
4732018-02-12T21:17:40  *** AaronvanW has joined #bitcoin-core-dev
4742018-02-12T21:26:09  *** sengehest has quit IRC
4752018-02-12T21:35:30  *** Cheeseo has joined #bitcoin-core-dev
4762018-02-12T21:38:21  *** AaronvanW has quit IRC
4772018-02-12T21:38:55  *** AaronvanW has joined #bitcoin-core-dev
4782018-02-12T21:43:41  *** AaronvanW has quit IRC
4792018-02-12T21:49:02  *** AaronvanW has joined #bitcoin-core-dev
4802018-02-12T21:50:23  *** jamesob has quit IRC
4812018-02-12T21:51:57  *** neha has quit IRC
4822018-02-12T21:52:40  *** justanotheruser has quit IRC
4832018-02-12T21:53:41  *** AaronvanW has quit IRC
4842018-02-12T21:55:35  *** esotericnonsense has quit IRC
4852018-02-12T22:00:06  *** neha has joined #bitcoin-core-dev
4862018-02-12T22:00:53  *** meshcollider has joined #bitcoin-core-dev
4872018-02-12T22:04:29  *** AaronvanW has joined #bitcoin-core-dev
4882018-02-12T22:07:05  *** esotericnonsense has joined #bitcoin-core-dev
4892018-02-12T22:07:56  *** Cogito_Ergo_Sum has quit IRC
4902018-02-12T22:08:57  *** Aaronvan_ has joined #bitcoin-core-dev
4912018-02-12T22:11:44  *** AaronvanW has quit IRC
4922018-02-12T22:20:07  *** n1bor has joined #bitcoin-core-dev
4932018-02-12T22:22:20  <n1bor> @murrayn how much RAM do you have? I have seen this sort of performance with 4Gig or less of RAM. Put in 8-12 Gig and same machine was 10x faster.
4942018-02-12T22:23:17  <n1bor> ibd hate to be short of RAM. I think the filesystem cache needs it for leveldb reads?
4952018-02-12T22:24:34  *** Randolf has quit IRC
4962018-02-12T22:25:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5dc00f68c49c...c997f8808256
4972018-02-12T22:25:17  <bitcoin-git> bitcoin/master f40df29 practicalswift: Fix Windows build errors introduced in #10498...
4982018-02-12T22:25:18  <bitcoin-git> bitcoin/master c997f88 MarcoFalke: Merge #12416: Fix Windows build errors introduced in #10498...
4992018-02-12T22:26:19  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12416: Fix Windows build errors introduced in #10498 (master...fix-windows-build) https://github.com/bitcoin/bitcoin/pull/12416
5002018-02-12T22:34:05  *** Dizzle has quit IRC
5012018-02-12T22:36:50  *** farmerwampum_ has joined #bitcoin-core-dev
5022018-02-12T22:37:18  *** farmerwampum has quit IRC
5032018-02-12T22:37:18  *** farmerwampum_ is now known as farmerwampum
5042018-02-12T22:39:09  *** Aaronvan_ is now known as AaronvanW
5052018-02-12T22:39:45  *** farmerwampum has quit IRC
5062018-02-12T22:40:01  *** farmerwampum has joined #bitcoin-core-dev
5072018-02-12T23:05:23  *** mirese has joined #bitcoin-core-dev
5082018-02-12T23:08:41  *** mirese_ has quit IRC
5092018-02-12T23:09:39  *** laurentmt has joined #bitcoin-core-dev
5102018-02-12T23:10:33  *** laurentmt has quit IRC
5112018-02-12T23:18:39  *** TheRec_ has quit IRC
5122018-02-12T23:18:44  *** TheRec has joined #bitcoin-core-dev
5132018-02-12T23:18:44  *** TheRec has joined #bitcoin-core-dev
5142018-02-12T23:24:02  *** Victorsueca has quit IRC
5152018-02-12T23:24:25  *** Arise2 has quit IRC
5162018-02-12T23:25:11  *** Arise2 has joined #bitcoin-core-dev
5172018-02-12T23:25:17  *** Victorsueca has joined #bitcoin-core-dev
5182018-02-12T23:32:53  <BlueMatt> ugh, duh
5192018-02-12T23:33:00  <BlueMatt> cfields: see https://github.com/bitcoin/bitcoin/pull/12349#issuecomment-365095741
5202018-02-12T23:33:56  <BlueMatt> #12367 only fixed the issue for non-reindex cases (ie where LoadChainTip gets called)...any other cases will simply happily initialize pcoinsTip on top of an empty chainstate and then expect to have genesis loaded in the ThreadImport
5212018-02-12T23:33:58  <gribble> https://github.com/bitcoin/bitcoin/issues/12367 | Fix two fast-shutdown bugs by TheBlueMatt · Pull Request #12367 · bitcoin/bitcoin · GitHub
5222018-02-12T23:34:57  <cfields> grr
5232018-02-12T23:36:05  <BlueMatt> we could revert to the initial suggestion of #12349 and just short-circuit flushing, but I really hate that
5242018-02-12T23:36:07  <gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
5252018-02-12T23:36:15  <BlueMatt> would rather be smarter and not call FlushStateToDisk somehow
5262018-02-12T23:36:50  *** goatpig has quit IRC
5272018-02-12T23:37:11  <cfields> BlueMatt: yes, I don't like that either. It was really only intended to jump of discussion about where to fix it for real.
5282018-02-12T23:37:25  <cfields> *jump off
5292018-02-12T23:37:34  <BlueMatt> I mean looking at the issue I dont really see a way to fix it that I like to begin with :(
5302018-02-12T23:37:47  <cfields> same, hence the punt :p
5312018-02-12T23:37:47  <BlueMatt> but should slip it into the next rc :(
5322018-02-12T23:38:00  <BlueMatt> well I liked my earlier fix...that didnt actually fix it :/
5332018-02-12T23:39:01  <BlueMatt> I mean the other obvious option is to make it explicit - have some static in validation.cpp/CChainState that just means "ive gotten as far as loading the genesis block, I can flush now"
5342018-02-12T23:39:26  *** larafale has quit IRC
5352018-02-12T23:39:39  <cfields> right
5362018-02-12T23:39:46  <cfields> and don't we already have that, in some form?
5372018-02-12T23:40:20  <BlueMatt> not afaik.....I mean we just explicitly refuse to finish loading until we've gotten that far
5382018-02-12T23:41:24  <BlueMatt> Ive gotta run, but I'd say just do something in CChainState that gets set to true the first time we do a DisconnectBlock or ConnectBlock, and refuse to flush until then?
5392018-02-12T23:41:37  <BlueMatt> should fix the bug without hiding a hack in utxo flushing
5402018-02-12T23:41:41  <cfields> fHaveGenesis... ?
5412018-02-12T23:41:59  <BlueMatt> fHaveLoadedGenesis
5422018-02-12T23:42:00  <BlueMatt> sure
5432018-02-12T23:42:11  <BlueMatt> set either in LoadChainTip
5442018-02-12T23:42:15  <BlueMatt> or ConnectBlock
5452018-02-12T23:42:17  <BlueMatt> I think
5462018-02-12T23:42:24  <cfields> no i mean, look in init.cpp
5472018-02-12T23:42:46  <BlueMatt> yea, I know
5482018-02-12T23:42:58  <BlueMatt> it feels cleaner to duplicate it inside CChainState
5492018-02-12T23:43:03  <BlueMatt> so that its clearly a validation thing
5502018-02-12T23:43:09  <BlueMatt> instead of yet more global pollution
5512018-02-12T23:43:26  <BlueMatt> fHaveGenesis can continue to sit in init as a block-on-me-before-continuing
5522018-02-12T23:43:58  <BlueMatt> @eklitzke gets the credit for discovery, btw
5532018-02-12T23:44:01  * BlueMatt -> out
5542018-02-12T23:44:34  <cfields> looking, cya