1 2018-02-27T00:00:03  *** weez17 has quit IRC
  2 2018-02-27T00:00:36  *** weez17 has joined #bitcoin-core-dev
  3 2018-02-27T00:03:53  *** MrPaz has quit IRC
  4 2018-02-27T00:06:27  *** Aaronvan_ has quit IRC
  5 2018-02-27T00:06:36  *** CubicEarths has quit IRC
  6 2018-02-27T00:12:02  *** Cogito_Ergo_Sum has quit IRC
  7 2018-02-27T00:16:40  *** MrPaz has joined #bitcoin-core-dev
  8 2018-02-27T00:18:32  *** CubicEarths has joined #bitcoin-core-dev
  9 2018-02-27T00:26:33  *** grafcaps has quit IRC
 10 2018-02-27T00:31:10  *** delta__ has joined #bitcoin-core-dev
 11 2018-02-27T00:31:11  *** HFRadical has quit IRC
 12 2018-02-27T00:31:35  *** delta__ has quit IRC
 13 2018-02-27T00:35:21  <bitcoin-git> [bitcoin] denis2342 closed pull request #12541: streamlined the use of include_hex (master...master) https://github.com/bitcoin/bitcoin/pull/12541
 14 2018-02-27T00:38:51  *** grafcaps has joined #bitcoin-core-dev
 15 2018-02-27T00:43:18  <eklitzke> 31% of the time in ReadBlockFromDisk() is spent in prevector::resize
 16 2018-02-27T00:43:22  <eklitzke> smh
 17 2018-02-27T00:44:22  <eklitzke> actually that's just one of the code paths, altogether it's 37% if you count the other code paths
 18 2018-02-27T00:45:13  *** Thad34Watsica has quit IRC
 19 2018-02-27T00:45:42  <sipa> that's remarkable
 20 2018-02-27T00:45:51  <sipa> oh, scriptSigs
 21 2018-02-27T00:46:31  <sipa> (for scriptPubKeys, prevector should almost never need an allocation)
 22 2018-02-27T00:46:41  <eklitzke> https://monad.io/readblockfromdisk.svg
 23 2018-02-27T00:48:03  <sipa> \o/ flame diagram
 24 2018-02-27T00:50:05  <sipa> and 44% in sse4_transform
 25 2018-02-27T00:50:40  <eklitzke> i don't quite get it, so when you call resize() on a prevector, if it grows the vector it calls operator new in a loop for the full new capacity?
 26 2018-02-27T00:51:47  <cfields> eklitzke: I assume it mallocs what's needed, then calls placement-new for each element
 27 2018-02-27T00:51:57  <sipa> eklitzke: those are just placement news, they don't allocate
 28 2018-02-27T00:52:03  <eklitzke> ah
 29 2018-02-27T00:52:15  <cfields> if that's the case and where it's spending its time, we could short-circuit that for the unsigned char case.
 30 2018-02-27T00:52:26  <sipa> eklitzke: it's filling the new space with objects (which should be trivial in the case the type is unsigned char)
 31 2018-02-27T00:52:36  <sipa> cfields: ack
 32 2018-02-27T00:52:41  <sipa> didn't you have a branch to do that?
 33 2018-02-27T00:53:24  <cfields> sipa: i did at one point, but I believe the main slow-down was in the dtor, which was fixed. so I didn't go any further with it
 34 2018-02-27T00:54:39  <cfields> eklitzke: grep for is_trivially_destructible. We could do the same for the ctor and is_trivially_default_constructible.
 35 2018-02-27T00:56:10  <cfields> (though it should be possible to skip the runtime check entirely with SFINAE)
 36 2018-02-27T00:56:42  <eklitzke> wait does this actually do the is_trivially_destructible check at runtime?
 37 2018-02-27T00:56:44  <eklitzke> yeah
 38 2018-02-27T00:56:48  <eklitzke> that's where i was going to go
 39 2018-02-27T00:57:05  <sipa> eklitzke: a smart compiler will do it at compile time
 40 2018-02-27T00:57:10  <cfields> eklitzke: hopefully the compiler optimizes it away
 41 2018-02-27T00:57:11  <cfields> heh
 42 2018-02-27T00:57:19  <eklitzke> right, looks strange to me though
 43 2018-02-27T00:57:25  <sipa> it's possible to write the code in a way that forces it at compile time
 44 2018-02-27T00:57:34  <eklitzke> yeah i'm used to doing this with std::enable_if
 45 2018-02-27T00:57:45  <eklitzke> i'll try to make the prevector code a little faster
 46 2018-02-27T00:58:08  *** justanotheruser has joined #bitcoin-core-dev
 47 2018-02-27T01:00:35  *** promag has quit IRC
 48 2018-02-27T01:01:48  *** echeveria has joined #bitcoin-core-dev
 49 2018-02-27T01:02:11  *** echeveria is now known as Guest12590
 50 2018-02-27T01:02:29  *** echeveria_ has joined #bitcoin-core-dev
 51 2018-02-27T01:02:41  *** echeveria_ has joined #bitcoin-core-dev
 52 2018-02-27T01:03:29  <cfields> eklitzke: you may find it helpful to add resize() to the existing prevector benches
 53 2018-02-27T01:03:38  <cfields> that'd make it trivial to demonstrate a speedup
 54 2018-02-27T01:03:58  <eklitzke> good advice, i wouldn't have thought of that
 55 2018-02-27T01:05:28  <sipa> also, given that the only instance of prevector today uses unsigned char, you could just unconditionally hack it in and remove that loop entirely (for the purpose of benchmarking it)
 56 2018-02-27T01:06:34  *** echeveria_ has quit IRC
 57 2018-02-27T01:06:42  *** echeveria_ has joined #bitcoin-core-dev
 58 2018-02-27T01:06:58  *** echeveria_ has quit IRC
 59 2018-02-27T01:06:59  *** echeveria_ has joined #bitcoin-core-dev
 60 2018-02-27T01:10:15  *** echeveria_ has quit IRC
 61 2018-02-27T01:10:24  *** echeveria_ has joined #bitcoin-core-dev
 62 2018-02-27T01:10:40  *** echeveria_ has joined #bitcoin-core-dev
 63 2018-02-27T01:11:00  *** rongze has joined #bitcoin-core-dev
 64 2018-02-27T01:11:55  *** rongze has joined #bitcoin-core-dev
 65 2018-02-27T01:15:23  *** rongze_ has joined #bitcoin-core-dev
 66 2018-02-27T01:15:24  *** rongze has quit IRC
 67 2018-02-27T01:16:31  *** Randolf has joined #bitcoin-core-dev
 68 2018-02-27T01:25:49  <Randolf> I'm hoping someone can help me with this -- I tried to rebase PR #12546 down to a single commit, but it's just not showing up on GitHub, although "git log" shows me what I'm expecting to see.  Is "git push -f" not synchronizing because the Travis CI build failed?  Thanks in advance.
 69 2018-02-27T01:25:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub
 70 2018-02-27T01:27:22  <esotericnonsense> Randolf: you pushed to randolf:master rather than randolf:patch-3
 71 2018-02-27T01:27:50  <esotericnonsense> Randolf: the PR is tracking patch-3, https://github.com/randolf/bitcoin looks to have the single commit on top of master I think?
 72 2018-02-27T01:29:31  *** rongze_ has quit IRC
 73 2018-02-27T01:31:09  *** promag has joined #bitcoin-core-dev
 74 2018-02-27T01:31:26  <Randolf> esotericnonsense:  Oh, okay.  I'll try to figure out what I've missed then.  Thank you.
 75 2018-02-27T01:31:44  <Randolf> I did use this command prior to rebase:  git reset --hard origin/patch-3
 76 2018-02-27T01:31:47  *** rongze has joined #bitcoin-core-dev
 77 2018-02-27T01:31:50  <cfields> eklitzke: something else you may be interested in benching, our utxo decompressor decompresses to a std::vector rather than a prevec, forcing an unnecessary copy into the resulting prevec.
 78 2018-02-27T01:31:57  <cfields> (from my reading of the code, anyway)
 79 2018-02-27T01:32:21  <cfields> though I realize you're probably just looking at blocks atm
 80 2018-02-27T01:32:34  *** Flo80Mills has joined #bitcoin-core-dev
 81 2018-02-27T01:33:03  *** rongze has quit IRC
 82 2018-02-27T01:33:10  <Randolf> Ah, yes, I see that "git push -f" is resulting in this:   + 393545d85...b787a7fc6 master -> master (forced update)
 83 2018-02-27T01:33:37  *** rongze has joined #bitcoin-core-dev
 84 2018-02-27T01:35:33  *** promag has quit IRC
 85 2018-02-27T01:39:19  <esotericnonsense> it sounds like you checked out master, reset it to origin/patch-3, then rebased and squashed, something like that.
 86 2018-02-27T01:39:56  *** dabura667 has joined #bitcoin-core-dev
 87 2018-02-27T01:41:43  <Randolf> I'm going to try again with a "git checkout patch-3" command.  (I'm still new to git.)
 88 2018-02-27T01:43:28  <Randolf> That was it -- I missed the checkout step.  It seems that I don't need to do the reset step then.
 89 2018-02-27T01:44:24  *** promag has joined #bitcoin-core-dev
 90 2018-02-27T01:49:51  *** echeveria_ is now known as echeveria
 91 2018-02-27T01:54:59  *** promag has quit IRC
 92 2018-02-27T02:10:33  *** CubicEarths has quit IRC
 93 2018-02-27T02:26:48  *** shesek has quit IRC
 94 2018-02-27T02:38:00  *** belcher has quit IRC
 95 2018-02-27T03:00:21  *** arbitrary_guy has joined #bitcoin-core-dev
 96 2018-02-27T03:17:01  *** promag has joined #bitcoin-core-dev
 97 2018-02-27T03:21:14  *** Giszmo has joined #bitcoin-core-dev
 98 2018-02-27T03:21:35  *** promag has quit IRC
 99 2018-02-27T03:25:33  *** Giszmo has quit IRC
100 2018-02-27T03:38:46  *** promag has joined #bitcoin-core-dev
101 2018-02-27T03:40:46  *** Giszmo has joined #bitcoin-core-dev
102 2018-02-27T03:43:39  *** promag has quit IRC
103 2018-02-27T03:47:59  *** Giszmo has quit IRC
104 2018-02-27T03:48:38  *** Danilo_ has joined #bitcoin-core-dev
105 2018-02-27T03:53:41  *** promag has joined #bitcoin-core-dev
106 2018-02-27T03:58:23  *** promag has quit IRC
107 2018-02-27T03:59:52  *** arbitrary_guy has quit IRC
108 2018-02-27T04:05:06  *** Giszmo has joined #bitcoin-core-dev
109 2018-02-27T04:06:06  *** Danilo_ has quit IRC
110 2018-02-27T04:16:56  <bitcoin-git> [bitcoin] eklitzke opened pull request #12549: Make prevector::resize() and other prevector operations much faster (master...prevector) https://github.com/bitcoin/bitcoin/pull/12549
111 2018-02-27T04:18:13  *** promag has joined #bitcoin-core-dev
112 2018-02-27T04:23:13  *** promag has quit IRC
113 2018-02-27T04:24:02  *** Cheeseo has joined #bitcoin-core-dev
114 2018-02-27T04:24:59  *** RoyceX has quit IRC
115 2018-02-27T04:25:07  <sipa> eklitzke: nice!
116 2018-02-27T04:25:33  *** LumberCartel has joined #bitcoin-core-dev
117 2018-02-27T04:25:58  *** arbitrary_guy has joined #bitcoin-core-dev
118 2018-02-27T04:26:01  *** LumberCartel has quit IRC
119 2018-02-27T04:26:47  *** Randolf has quit IRC
120 2018-02-27T04:27:01  *** Randolf has joined #bitcoin-core-dev
121 2018-02-27T04:28:02  <bitcoin-git> [bitcoin] bedri opened pull request #12550: Utils and libraries: Leveldb warning fixes (0.16...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12550
122 2018-02-27T04:35:21  <eklitzke> hmm, what version of gcc/libstdc++ does travis use?
123 2018-02-27T04:35:38  <sipa> gcc 4.8 i believe
124 2018-02-27T04:38:38  <bitcoin-git> [bitcoin] bedri closed pull request #12550: Utils and libraries: Leveldb warning fixes (0.16...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12550
125 2018-02-27T04:44:12  <bitcoin-git> [bitcoin] bedri opened pull request #12551: Leveldb warning fixes (master...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12551
126 2018-02-27T04:50:47  *** promag has joined #bitcoin-core-dev
127 2018-02-27T04:56:02  *** promag has quit IRC
128 2018-02-27T05:02:35  *** promag has joined #bitcoin-core-dev
129 2018-02-27T05:07:17  *** promag has quit IRC
130 2018-02-27T05:19:08  *** arbitrary_guy has quit IRC
131 2018-02-27T05:23:06  *** promag has joined #bitcoin-core-dev
132 2018-02-27T05:23:58  <esotericnonsense> hm.
133 2018-02-27T05:27:43  *** promag has quit IRC
134 2018-02-27T05:37:27  *** arbitrary_guy has joined #bitcoin-core-dev
135 2018-02-27T05:38:01  *** d9b4bef9 has quit IRC
136 2018-02-27T05:39:08  *** d9b4bef9 has joined #bitcoin-core-dev
137 2018-02-27T05:40:58  *** aruns__ has joined #bitcoin-core-dev
138 2018-02-27T05:57:55  *** promag has joined #bitcoin-core-dev
139 2018-02-27T06:01:24  *** Victorsueca has quit IRC
140 2018-02-27T06:02:13  *** promag has quit IRC
141 2018-02-27T06:02:33  *** Victorsueca has joined #bitcoin-core-dev
142 2018-02-27T06:08:43  *** CubicEarths has joined #bitcoin-core-dev
143 2018-02-27T06:28:03  <bitcoin-git> [bitcoin] fanquake closed pull request #12551: Utils and libraries: Leveldb warning fixes (master...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12551
144 2018-02-27T06:28:30  *** PaulCape_ has quit IRC
145 2018-02-27T06:28:47  *** PaulCapestany has joined #bitcoin-core-dev
146 2018-02-27T06:31:44  *** cryptojanitor has quit IRC
147 2018-02-27T06:35:39  *** promag has joined #bitcoin-core-dev
148 2018-02-27T06:37:42  <bitcoin-git> [bitcoin] Empact opened pull request #12553: Prefer wait_until over polling with time.sleep (master...wait-until) https://github.com/bitcoin/bitcoin/pull/12553
149 2018-02-27T06:40:12  *** promag has quit IRC
150 2018-02-27T06:54:29  *** promag has joined #bitcoin-core-dev
151 2018-02-27T06:56:05  *** MrPaz has quit IRC
152 2018-02-27T06:58:57  *** promag has quit IRC
153 2018-02-27T07:15:50  *** promag has joined #bitcoin-core-dev
154 2018-02-27T07:19:19  *** Strepsils has joined #bitcoin-core-dev
155 2018-02-27T07:20:04  *** Strepsils has quit IRC
156 2018-02-27T07:20:39  *** promag has quit IRC
157 2018-02-27T07:21:33  *** whphhg has quit IRC
158 2018-02-27T07:34:18  *** Murch has quit IRC
159 2018-02-27T07:43:33  *** Sentineo has quit IRC
160 2018-02-27T07:44:00  *** ken2812221 has joined #bitcoin-core-dev
161 2018-02-27T07:52:50  *** promag has joined #bitcoin-core-dev
162 2018-02-27T07:54:10  *** aruns has joined #bitcoin-core-dev
163 2018-02-27T07:56:43  *** aruns__ has quit IRC
164 2018-02-27T07:58:07  *** promag has quit IRC
165 2018-02-27T07:58:16  *** mmgen has joined #bitcoin-core-dev
166 2018-02-27T08:02:17  *** JackH has quit IRC
167 2018-02-27T08:06:27  <bitcoin-git> [bitcoin] multibhw opened pull request #12555: Tweet  RUN TIME (master...TWEET) https://github.com/bitcoin/bitcoin/pull/12555
168 2018-02-27T08:07:31  <bitcoin-git> [bitcoin] fanquake closed pull request #12555: Tweet  RUN TIME (master...TWEET) https://github.com/bitcoin/bitcoin/pull/12555
169 2018-02-27T08:16:17  *** JackH has joined #bitcoin-core-dev
170 2018-02-27T08:18:12  *** promag has joined #bitcoin-core-dev
171 2018-02-27T08:22:11  *** nullptr| has quit IRC
172 2018-02-27T08:22:55  *** promag has quit IRC
173 2018-02-27T08:28:14  *** nullptr| has joined #bitcoin-core-dev
174 2018-02-27T08:29:32  <hkjn0> eklitzke: cool flame graph! mind sharing how you produced it?
175 2018-02-27T08:32:33  *** nullptr| has quit IRC
176 2018-02-27T08:36:40  *** nullptr| has joined #bitcoin-core-dev
177 2018-02-27T08:55:54  *** promag has joined #bitcoin-core-dev
178 2018-02-27T09:00:17  *** promag has quit IRC
179 2018-02-27T09:03:52  *** mistakenine has joined #bitcoin-core-dev
180 2018-02-27T09:05:51  <mistakenine> hi,Is there anyone interested in a parallel block chain?a complex data structure
181 2018-02-27T09:17:04  *** mehdi0x61 has joined #bitcoin-core-dev
182 2018-02-27T09:20:38  *** timothy has joined #bitcoin-core-dev
183 2018-02-27T09:23:55  *** promag has joined #bitcoin-core-dev
184 2018-02-27T09:25:07  *** drizztbsd has joined #bitcoin-core-dev
185 2018-02-27T09:25:36  *** dabura667 has quit IRC
186 2018-02-27T09:25:51  *** AaronvanW has joined #bitcoin-core-dev
187 2018-02-27T09:25:53  *** timothy has quit IRC
188 2018-02-27T09:27:31  *** Aaronvan_ has joined #bitcoin-core-dev
189 2018-02-27T09:28:32  *** mehdi0x61 has quit IRC
190 2018-02-27T09:28:36  *** promag has quit IRC
191 2018-02-27T09:29:24  *** promag has joined #bitcoin-core-dev
192 2018-02-27T09:30:41  *** larafale has joined #bitcoin-core-dev
193 2018-02-27T09:30:46  *** promag has quit IRC
194 2018-02-27T09:30:53  *** AaronvanW has quit IRC
195 2018-02-27T09:31:19  *** promag has joined #bitcoin-core-dev
196 2018-02-27T09:35:37  *** promag has quit IRC
197 2018-02-27T09:39:11  *** Flo80Mills has quit IRC
198 2018-02-27T09:44:21  *** larafale has quit IRC
199 2018-02-27T09:44:57  *** larafale has joined #bitcoin-core-dev
200 2018-02-27T09:48:43  *** aruns__ has joined #bitcoin-core-dev
201 2018-02-27T09:48:57  *** larafale has quit IRC
202 2018-02-27T09:49:54  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/5d41110c745c74e1eeb85f187f54777bf5e6407f
203 2018-02-27T09:49:54  <bitcoin-git> bitcoin/0.16 5d41110 Wladimir J. van der Laan: doc: Clear out release notes post-0.16.0...
204 2018-02-27T09:50:16  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/01f931b928fbe0266b3a8d48d0fb2ecc728bd7f3
205 2018-02-27T09:50:16  <bitcoin-git> bitcoin/0.16 01f931b Wladimir J. van der Laan: test: Add missing signal.h header...
206 2018-02-27T09:50:53  *** aruns has quit IRC
207 2018-02-27T09:55:04  <mistakenine> hi,Is there anyone interested in a parallel block chain?a complex data structure
208 2018-02-27T09:56:00  <mistakenine> to see all the parallel blockchain as a whole
209 2018-02-27T09:56:35  <wumpus> mistakenine: not here please
210 2018-02-27T09:56:57  <provoostenator> CubicEarths: I know, I prefer the GUI myself. But technical people can use bitcoin.conf, so it's the less-technical users I'm trying to help here.
211 2018-02-27T09:57:04  *** drizztbsd is now known as timothy
212 2018-02-27T09:57:43  <wumpus> (a "parallel chain" is an interesting self-contradiction, anyway)
213 2018-02-27T09:58:32  <mistakenine> yes,but i find a way to give a solution
214 2018-02-27T09:58:46  <mistakenine> it's a very hard problem
215 2018-02-27T09:59:41  <CubicEarths> provoostenator: understood.
216 2018-02-27T09:59:49  <mistakenine> i give a math proof,but don't know how where to discuss that
217 2018-02-27T10:00:05  <wumpus> mistakenine: not here at least, it has nothing to do with bitcoin core development
218 2018-02-27T10:00:44  *** echonaut has quit IRC
219 2018-02-27T10:00:49  *** larafale has joined #bitcoin-core-dev
220 2018-02-27T10:01:01  *** echonaut has joined #bitcoin-core-dev
221 2018-02-27T10:02:14  *** go1111111 has quit IRC
222 2018-02-27T10:03:04  *** aruns__ has quit IRC
223 2018-02-27T10:03:26  *** aruns__ has joined #bitcoin-core-dev
224 2018-02-27T10:04:03  *** Aaronvan_ has quit IRC
225 2018-02-27T10:05:32  *** C4R3Bear has joined #bitcoin-core-dev
226 2018-02-27T10:10:13  *** aruns__ has quit IRC
227 2018-02-27T10:10:16  *** mistakenine has quit IRC
228 2018-02-27T10:10:17  *** aruns has joined #bitcoin-core-dev
229 2018-02-27T10:14:19  *** AaronvanW has joined #bitcoin-core-dev
230 2018-02-27T10:14:54  *** go1111111 has joined #bitcoin-core-dev
231 2018-02-27T10:16:31  *** shesek has joined #bitcoin-core-dev
232 2018-02-27T10:16:31  *** shesek has quit IRC
233 2018-02-27T10:16:31  *** shesek has joined #bitcoin-core-dev
234 2018-02-27T10:22:05  *** arbitrary_guy has quit IRC
235 2018-02-27T10:32:34  *** Stefan87Krajcik has joined #bitcoin-core-dev
236 2018-02-27T10:47:35  <bitcoin-git> [bitcoin] tamasblummer opened pull request #12556: [Trivial] fix version typo in getpeerinfo RPC call help (master...fix_version_typo) https://github.com/bitcoin/bitcoin/pull/12556
237 2018-02-27T10:48:00  *** CubicEarths has quit IRC
238 2018-02-27T10:51:25  *** ProfMac has quit IRC
239 2018-02-27T10:51:52  *** Lynet has joined #bitcoin-core-dev
240 2018-02-27T10:52:26  *** SopaXorzTaker has joined #bitcoin-core-dev
241 2018-02-27T11:02:58  *** C4R3Bear has quit IRC
242 2018-02-27T11:03:54  *** belcher has joined #bitcoin-core-dev
243 2018-02-27T11:08:24  *** zrc has joined #bitcoin-core-dev
244 2018-02-27T11:11:57  *** shesek has quit IRC
245 2018-02-27T11:17:52  *** zrc has quit IRC
246 2018-02-27T11:22:54  *** mehdi0x61 has joined #bitcoin-core-dev
247 2018-02-27T11:23:48  *** xpan has joined #bitcoin-core-dev
248 2018-02-27T11:28:12  *** mehdi0x61 has quit IRC
249 2018-02-27T11:29:20  *** zrc has joined #bitcoin-core-dev
250 2018-02-27T11:33:22  <bitcoin-git> [bitcoin] Sjors opened pull request #12557: [WIP] [depends] openssl: add aarch64_darwin (master...2018/02/depends-openssl-aarch64-apple-darwin1) https://github.com/bitcoin/bitcoin/pull/12557
251 2018-02-27T11:35:36  *** zrc has quit IRC
252 2018-02-27T11:35:56  *** zrc has joined #bitcoin-core-dev
253 2018-02-27T11:37:16  *** zrc has quit IRC
254 2018-02-27T11:46:48  *** mehdi0x61 has joined #bitcoin-core-dev
255 2018-02-27T11:50:38  *** mehdi0x61 has quit IRC
256 2018-02-27T11:54:22  *** C4R3Bear has joined #bitcoin-core-dev
257 2018-02-27T12:02:44  *** xpan has quit IRC
258 2018-02-27T12:09:27  *** Guyver2 has joined #bitcoin-core-dev
259 2018-02-27T12:32:17  *** C4R3Bear has quit IRC
260 2018-02-27T12:34:23  *** shesek has joined #bitcoin-core-dev
261 2018-02-27T12:34:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
262 2018-02-27T12:36:09  *** useruseruser has joined #bitcoin-core-dev
263 2018-02-27T12:36:24  *** useruseruser has left #bitcoin-core-dev
264 2018-02-27T12:37:26  <rabidus> Am I the only one who gets their top-bar written in chinese when clicking "use previously used address" in 0.16.0 @ windows? Binaries was downloaded from bitcoin.org. AVG detected something and moved quarantine, but I granted permission. Screenshot: https://pasteboard.co/H9zSGvJ.png
265 2018-02-27T12:44:52  *** mogitate has joined #bitcoin-core-dev
266 2018-02-27T12:48:18  <michagogo> mlz: but I assume you don’t test on Vista
267 2018-02-27T12:48:49  <michagogo> rabidus: o_O
268 2018-02-27T12:48:55  <michagogo> I’ll check…
269 2018-02-27T12:49:12  <mlz> michagogo, oh.. no, I do have a Vista, it doesn't have enough space for bitcoin :D
270 2018-02-27T12:49:44  <michagogo> Seriously?
271 2018-02-27T12:49:47  <michagogo> Why?
272 2018-02-27T12:50:31  <rabidus> ok, AVG now says that the file is ok, so I assume that was because because of too fresh binaries :). Still that chinese top-bar is confusing
273 2018-02-27T12:51:37  *** papaya has joined #bitcoin-core-dev
274 2018-02-27T12:55:08  <ken2812221> https://github.com/bitcoin/bitcoin/blob/0.16/src/qt/locale/bitcoin_en_US.ts
275 2018-02-27T12:55:28  *** C4R3Bear has joined #bitcoin-core-dev
276 2018-02-27T12:55:41  <rabidus> seems "ok" then :)
277 2018-02-27T13:00:50  <michagogo> ken2812221: …
278 2018-02-27T13:00:53  <michagogo> oops.
279 2018-02-27T13:01:02  <rabidus> at least I'm not running any chinese binaries .. probably
280 2018-02-27T13:01:43  * michagogo wonders if wumpus will want to put out a 0.16.0.1
281 2018-02-27T13:01:43  *** C4R3Bear has quit IRC
282 2018-02-27T13:01:55  <mlz> rabidus, that's very strange, i wouldn't use it, did you verify the binaries ?
283 2018-02-27T13:02:01  <ken2812221> Maybe someone can fix it on Transifex
284 2018-02-27T13:02:03  *** mehdi0x61 has joined #bitcoin-core-dev
285 2018-02-27T13:02:13  *** C4R3Bear has joined #bitcoin-core-dev
286 2018-02-27T13:02:21  <michagogo> mlz: look at the link ken2812221 just posted
287 2018-02-27T13:02:26  <michagogo> It’s in the source code
288 2018-02-27T13:02:27  <rabidus> no, i didn't check any hashes, but as you can see from that translation url, it's "feature" :)
289 2018-02-27T13:02:44  <michagogo> No, it’s definitely a bug
290 2018-02-27T13:02:49  <rabidus> hehe, jk
291 2018-02-27T13:04:26  <mlz> i see, but not verifying download files on windows is a crime :P
292 2018-02-27T13:06:02  <Anduck> ^
293 2018-02-27T13:06:11  <michagogo> I mean, the installer _is_ signed
294 2018-02-27T13:06:16  <rabidus> wouldn't change anything
295 2018-02-27T13:06:29  <rabidus> top bar would still be in chinese
296 2018-02-27T13:06:32  <rabidus> :)
297 2018-02-27T13:06:33  <michagogo> Which shows up when it asks you to elevate
298 2018-02-27T13:07:34  *** papaya has quit IRC
299 2018-02-27T13:08:51  <michagogo> Oh, there’s already #12577
300 2018-02-27T13:08:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12577 | HTTP Error 404: Not Found
301 2018-02-27T13:09:01  <michagogo> I mean #12544
302 2018-02-27T13:09:02  <gribble> https://github.com/bitcoin/bitcoin/issues/12544 | Bitcoin Qt 0.16.0 displays a window title in Chinese instead of English · Issue #12544 · bitcoin/bitcoin · GitHub
303 2018-02-27T13:09:17  <rabidus> oh, ok, nice
304 2018-02-27T13:09:23  *** Ylbam_ has joined #bitcoin-core-dev
305 2018-02-27T13:10:18  <bitcoin-git> [bitcoin] drodil opened pull request #12558: Fix translations in en_US.ts (0.16...patch-1) https://github.com/bitcoin/bitcoin/pull/12558
306 2018-02-27T13:18:09  *** C4R3Bear has quit IRC
307 2018-02-27T13:24:03  *** Sentineo has joined #bitcoin-core-dev
308 2018-02-27T13:29:33  *** shesek has quit IRC
309 2018-02-27T13:31:34  *** larafale has quit IRC
310 2018-02-27T13:31:56  <provoostenator> Somewhat related to the issue of translation review: #11875
311 2018-02-27T13:31:57  <gribble> https://github.com/bitcoin/bitcoin/issues/11875 | Snoei: a.k.a. how to translate technical jargon · Issue #11875 · bitcoin/bitcoin · GitHub
312 2018-02-27T13:33:46  *** TyrfingMjolnir has joined #bitcoin-core-dev
313 2018-02-27T13:33:53  *** larafale has joined #bitcoin-core-dev
314 2018-02-27T13:33:57  *** Chris_Stewart_5 has quit IRC
315 2018-02-27T13:34:00  <TyrfingMjolnir> Anyone got 2 consequtive sample blocks?
316 2018-02-27T13:34:28  <TyrfingMjolnir> with full schematics
317 2018-02-27T13:34:29  *** aruns has quit IRC
318 2018-02-27T13:34:47  *** larafale_ has joined #bitcoin-core-dev
319 2018-02-27T13:38:04  *** Stefan87Krajcik has quit IRC
320 2018-02-27T13:38:27  *** larafale has quit IRC
321 2018-02-27T13:42:44  *** dagurval has quit IRC
322 2018-02-27T13:44:47  *** jimmysong__ has quit IRC
323 2018-02-27T13:44:52  *** conor has joined #bitcoin-core-dev
324 2018-02-27T13:47:05  *** indistylo has joined #bitcoin-core-dev
325 2018-02-27T13:54:21  *** promag has joined #bitcoin-core-dev
326 2018-02-27T14:00:38  *** indistylo has quit IRC
327 2018-02-27T14:01:12  *** indistylo has joined #bitcoin-core-dev
328 2018-02-27T14:11:20  *** zrc has joined #bitcoin-core-dev
329 2018-02-27T14:13:27  *** Sentineo has quit IRC
330 2018-02-27T14:18:03  *** AaronvanW has quit IRC
331 2018-02-27T14:21:10  *** meshcollider has quit IRC
332 2018-02-27T14:30:03  *** zrc has quit IRC
333 2018-02-27T14:33:48  *** cryptojanitor has joined #bitcoin-core-dev
334 2018-02-27T14:34:42  *** Elliot4Osinski has joined #bitcoin-core-dev
335 2018-02-27T14:39:27  *** Elliot4Osinski has quit IRC
336 2018-02-27T14:42:41  *** laurentmt has joined #bitcoin-core-dev
337 2018-02-27T14:44:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
338 2018-02-27T14:46:10  *** Victorsueca has quit IRC
339 2018-02-27T14:47:37  *** Victorsueca has joined #bitcoin-core-dev
340 2018-02-27T14:49:24  *** rongze has quit IRC
341 2018-02-27T14:52:02  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/ea2e39fd2004e83375c1703543e32a10e3b9d981
342 2018-02-27T14:52:02  <bitcoin-git> bitcoin/0.16 ea2e39f Wladimir J. van der Laan: qt: Remove faulty and unnecessary en_US translation...
343 2018-02-27T14:52:03  <eklitzke> hkjn0: i have a wrapper script around perf(1) here that i use to actually collect the profiling data (which requires that you have a build with debug symbols): https://github.com/eklitzke/bitcoin-tools/blob/master/perf.sh
344 2018-02-27T14:52:35  <eklitzke> then the flame graph itself is generated using https://github.com/brendangregg/FlameGraph
345 2018-02-27T14:53:17  <eklitzke> i have a wrapper script for invoking that as well here: https://github.com/eklitzke/bitcoin-tools/blob/master/gensvg.sh (although in practice i've found i often want to use grep to filter out more data before invoking flamegraph.pl)
346 2018-02-27T14:54:21  <bitcoin-git> [bitcoin] laanwj closed pull request #12558: Fix translations in en_US.ts (0.16...patch-1) https://github.com/bitcoin/bitcoin/pull/12558
347 2018-02-27T14:54:55  *** rongze has joined #bitcoin-core-dev
348 2018-02-27T14:56:06  *** rongze has quit IRC
349 2018-02-27T14:56:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/228b086b9a3d...9e2ed253f505
350 2018-02-27T14:56:59  <bitcoin-git> bitcoin/master d16bfaa Tamas Blummer: fix version typo
351 2018-02-27T14:57:00  <bitcoin-git> bitcoin/master 9e2ed25 Wladimir J. van der Laan: Merge #12556: [Trivial] fix version typo in getpeerinfo RPC call help...
352 2018-02-27T14:57:56  <bitcoin-git> [bitcoin] laanwj closed pull request #12556: [Trivial] fix version typo in getpeerinfo RPC call help (master...fix_version_typo) https://github.com/bitcoin/bitcoin/pull/12556
353 2018-02-27T15:04:47  <wumpus> michagogo: nah, IMO the only thing to warrant a 0.16.0.1 release is a crash bug
354 2018-02-27T15:05:52  <luke-jr> 0.16.0 crashes if I overclock my CPU by 50%. hjelp! :p
355 2018-02-27T15:06:16  *** laurentmt has quit IRC
356 2018-02-27T15:07:46  *** alforro has joined #bitcoin-core-dev
357 2018-02-27T15:13:37  *** indistylo has quit IRC
358 2018-02-27T15:15:29  <wumpus> I get bit flips on one of my nodes even without overclocking, caused quite a panic this morning when it resulted in the node splitting from consensus
359 2018-02-27T15:19:01  *** Ylbam_ has quit IRC
360 2018-02-27T15:19:52  <provoostenator> So I've been studying how the QT send screen composes a transaction. It all seems to revolve around WalletModelTransaction.
361 2018-02-27T15:21:29  <wumpus> yes, walletmodeltransaction is the GUI-side model for a transaction to be sent
362 2018-02-27T15:21:29  <provoostenator> The way it works now is  that an initial WalletModelTransaction  is created, but several aspects of the transaciton are "stored" in the UI itself. E.g. there's a UI element that holds the list of destinations. Only when you hit Send is all that information collected and added to the WalletModelTransaciton instance.
363 2018-02-27T15:21:53  <wumpus> yes, don't forget about the static coincontrol instance :(
364 2018-02-27T15:22:07  <provoostenator> So I'm thinking about seperating the model from the view a bit better, so that any time you add / change a destination the WalletModelTransaction instance is updated and that's the source of truth.
365 2018-02-27T15:22:37  <provoostenator> Which would be very nice for RBF: just give it a transaction hex, deserialize it and then render the UI.
366 2018-02-27T15:22:41  <wumpus> that was really a bad design choice, but it was never cleaned up after the initial coin control contribution
367 2018-02-27T15:22:58  <provoostenator> Yeah I've been digging through historical commits to see how this came to be :-)
368 2018-02-27T15:23:01  <wumpus> yes, that'd probably be better
369 2018-02-27T15:24:06  <provoostenator> But I wonder about the RPC. Wouldn't it benefit from some mechanism to build up a transaction in a modular way as well? So rather than needing to create a tranaction in one giant RPC command, you'd create a draft and manipulate that through smaller commands.
370 2018-02-27T15:24:43  <provoostenator> And if that's the case, maybe this should all be moved one level deeper (and not depend on QT).
371 2018-02-27T15:26:15  <wumpus> that's what the raw transactions API does
372 2018-02-27T15:26:37  <wumpus> createrawtransaction, fundrawtransaction, signrwatransactions are the RPC equivalent of building up a transaction step by step
373 2018-02-27T15:26:56  <wumpus> but intentionally entirely stateless
374 2018-02-27T15:27:12  *** mehdi0x61 has quit IRC
375 2018-02-27T15:27:29  <wumpus> please do keep that code in qt, the reason for having a UI-specific structure there is to make it easier to split off the GUI some day
376 2018-02-27T15:28:23  <provoostenator> Would it make sense to make CMutableTransaction more powerful though? Why wouldn't QT be able to include that?
377 2018-02-27T15:28:53  <wumpus> if things are only necessary for the UI, it's better to keep the code in the UI
378 2018-02-27T15:29:21  <provoostenator> Coin selection and replacing transaction seem useful to both RPC and UI to me.
379 2018-02-27T15:29:40  <wumpus> RPC has that, in other ways
380 2018-02-27T15:29:47  <wumpus> I think you're extending the scope of what you want to do too much
381 2018-02-27T15:30:29  <provoostenator> I don't know, I'm trying to figure out what's the best approach here. My own scope was to improve RBF in QT, prefereably without reinventing the wheel.
382 2018-02-27T15:30:42  <provoostenator> If that makes the RPC better that's nice, but not my goal.
383 2018-02-27T15:30:43  <wumpus> if you want to improve the UI, then improving th UI is what to do, if you start refactoring all over the place it's much harder to move forward
384 2018-02-27T15:31:13  <provoostenator> I agree that a huge refactor is a bad idea regardless.
385 2018-02-27T15:31:41  <wumpus> refactor of the UI would be ok, but combining it with changing CMutableTransaction etc is just too much
386 2018-02-27T15:32:34  *** Jannie4Runolfsso has joined #bitcoin-core-dev
387 2018-02-27T15:34:48  <provoostenator> Actually I'm not sure if UI is my only concern here. I like the idea of keeping QT relatively simple and making it possible to build a UI on top of RPC (using whatever framework).
388 2018-02-27T15:35:16  <provoostenator> But I agree that changing both at this point would involve too many moving parts.
389 2018-02-27T15:37:42  *** grafcaps has quit IRC
390 2018-02-27T15:38:42  *** mehdi0x61 has joined #bitcoin-core-dev
391 2018-02-27T15:40:06  <wumpus> I'm fairly sure it's possible to build this UI on top of listunspent and *rawtransaction API
392 2018-02-27T15:40:37  <provoostenator> The above is a fairly complicated way to achieve RBF, but has the advatage of letting UI users tweak the new transaction anyway they want.
393 2018-02-27T15:41:02  <provoostenator> A simpler approach would be improve the bumpfee RPC stuff and then create a UI where the user can merely change the fee, nothing else.
394 2018-02-27T15:41:31  *** mehdi0x61 has quit IRC
395 2018-02-27T15:41:39  *** conor has quit IRC
396 2018-02-27T15:43:39  *** HFRadical has joined #bitcoin-core-dev
397 2018-02-27T15:44:18  <provoostenator> (by "the above" I mean moving some stuff from the view code into WalletModelTransaction, I don't mean changing CMutableTransaction)
398 2018-02-27T15:46:13  *** mehdi0x61 has joined #bitcoin-core-dev
399 2018-02-27T16:04:28  *** MrPaz has joined #bitcoin-core-dev
400 2018-02-27T16:05:59  *** Murch has joined #bitcoin-core-dev
401 2018-02-27T16:06:02  *** lifeofguenter has quit IRC
402 2018-02-27T16:12:54  *** lifeofguenter has joined #bitcoin-core-dev
403 2018-02-27T16:14:47  *** Victorsueca has quit IRC
404 2018-02-27T16:16:02  *** Victorsueca has joined #bitcoin-core-dev
405 2018-02-27T16:16:59  <michagogo> wumpus: I think I actually saw the commit that introduced the en_us translation
406 2018-02-27T16:17:19  <michagogo> It was 5109347, which added a whole lot of translations
407 2018-02-27T16:17:34  <michagogo> I remember I saw that and idly wondered what was going on there
408 2018-02-27T16:17:40  <michagogo> And forgot to follow up on that thought
409 2018-02-27T16:18:12  <michagogo> For example, I haven’t looked at the content, but I saw that it added a he_IL translation in addition to the existing he?
410 2018-02-27T16:18:28  <michagogo> As far as I know there isn’t really a Hebrew besides he_IL
411 2018-02-27T16:18:45  <michagogo> I also don’t really know how the translation stuff works
412 2018-02-27T16:18:55  *** rongze has joined #bitcoin-core-dev
413 2018-02-27T16:19:40  <wumpus> well it synced the transifex translations with the ones in the repository
414 2018-02-27T16:20:06  <michagogo> That commit seems to introduce a bunch of new languages, but also a whole lot of new files with country codes where previously there was just the country-less language
415 2018-02-27T16:20:41  <michagogo> Can anyone on transifex just create a new language?
416 2018-02-27T16:20:42  <wumpus> well, if translations need to be deleted they need to be deleted from transifex first,t hen from the repository, that prevents them from coming back
417 2018-02-27T16:20:47  <wumpus> no, they have to be approved
418 2018-02-27T16:20:57  <wumpus> though the policy seems to be that everything is approved
419 2018-02-27T16:21:08  <michagogo> And within the release cycle all those new ones went in?
420 2018-02-27T16:21:27  <wumpus> it's hard to think of a valid reason to reject someone adding a translation for someone's language/country
421 2018-02-27T16:21:36  <wumpus> though adding en_US was stupid :)
422 2018-02-27T16:21:59  <michagogo> I suspect it might be a good idea to go over and do a sanity check of the languages that added a new single country code where previously there was just a bare language
423 2018-02-27T16:22:41  <michagogo> For example, adding he_IL when he exists seems vaguely suspicious to me
424 2018-02-27T16:23:10  *** rongze has quit IRC
425 2018-02-27T16:23:54  <michagogo> Another example, de_DE was added when de exists, and no other de_XX versions
426 2018-02-27T16:24:10  <michagogo> I would expect that bare de would be German German
427 2018-02-27T16:24:29  <michagogo> If the new file were de_CH or something it would make sense, but…
428 2018-02-27T16:24:51  <bitcoin-git> [bitcoin] promag opened pull request #12559: Avoid locking cs_main in some wallet RPC (master...2018-02-avoid-cs_main-lock) https://github.com/bitcoin/bitcoin/pull/12559
429 2018-02-27T16:26:45  *** Randolf has quit IRC
430 2018-02-27T16:29:38  *** Amuza has joined #bitcoin-core-dev
431 2018-02-27T16:32:08  <bitcoin-git> [bitcoin] achow101 opened pull request #12560: [wallet][RPC] Set or generate a new HD seed (master...sethdseed) https://github.com/bitcoin/bitcoin/pull/12560
432 2018-02-27T16:36:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
433 2018-02-27T16:36:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
434 2018-02-27T16:38:37  *** HFRadical has quit IRC
435 2018-02-27T16:39:54  *** wxss has joined #bitcoin-core-dev
436 2018-02-27T16:41:02  <bitcoin-git> [bitcoin] sdaftuar opened pull request #12561: Remove call to CheckBlock() in ConnectBlock() (master...2018-02-improve-checkblock-failure) https://github.com/bitcoin/bitcoin/pull/12561
437 2018-02-27T16:43:15  <TyrfingMjolnir> How can I create my own local block chain and generate 10 valid blocks at random for development purposes?
438 2018-02-27T16:44:01  <Chris_Stewart_5> TyrfingMjolnir: $ bitcoind -regtest -daemon && bitcoin-cli -regtest generate 10
439 2018-02-27T16:45:13  <TyrfingMjolnir> Perfect, thanks
440 2018-02-27T16:52:06  *** Randolf has joined #bitcoin-core-dev
441 2018-02-27T16:53:19  *** JackH has quit IRC
442 2018-02-27T16:54:18  <wumpus> michagogo: I agree, but I don't have enough international lingual knowledge to make decisions about such things, if you find specific ones that make no sense, please report them
443 2018-02-27T16:54:50  <wumpus> this has happened in the past, that a transifex translator reported that a certain language/locale pair makes no sense and it was removed
444 2018-02-27T16:55:08  <michagogo> Yeah, I guess
445 2018-02-27T16:55:57  <michagogo> It’s things like this that make me really wish I had free time to do stuff like go and look at he vs he_IL
446 2018-02-27T16:55:59  <wumpus> but in the absence of specific information I tend to err on the side of allowing it
447 2018-02-27T16:58:25  <michagogo> I’m on my phone on the bus, so I didn’t look into the content, but I see the new he_IL is much, much shorter than the existing he
448 2018-02-27T16:59:16  <michagogo> Does Qt have a fallback thing, where if you’re set to xx_YY and a string is missing, it will use the translation for bare xx?
449 2018-02-27T16:59:26  <michagogo> Or is each translation completely independent?
450 2018-02-27T16:59:35  <wumpus> shortness doesn't matter, it will just override the general one for the messages that are specified
451 2018-02-27T16:59:54  <michagogo> Okay, good - at least there’s that
452 2018-02-27T17:00:06  <wumpus> e.g. fallback order would be he_IL -> he -> en/original
453 2018-02-27T17:00:13  <michagogo> Okay, that’s good at least
454 2018-02-27T17:00:19  <luke-jr> michagogo: wumpus: I did a sanity check a few months ago, and made a todo list
455 2018-02-27T17:00:24  <luke-jr> but it's probably not updated anymore
456 2018-02-27T17:00:51  <luke-jr> and I have no clue where I saved it :x
457 2018-02-27T17:01:02  <michagogo> But I still doubt there’s anything that belongs in he_IL that shouldn’t just be in he
458 2018-02-27T17:02:19  <luke-jr> someone should probably just do the obvious ones (eg, if there's no he, rename he_IL to it)
459 2018-02-27T17:02:27  <luke-jr> and then contact people in non-obvious cases
460 2018-02-27T17:05:42  <wumpus> wanted: localization maintainer
461 2018-02-27T17:06:29  <michagogo> There’s a Hebrew with >80% coverage, and a Hebrew (Israel) with <3%
462 2018-02-27T17:06:40  <luke-jr> that sounds about right?
463 2018-02-27T17:06:56  <michagogo> Well, that’s not really a division that makes sense AFAIK
464 2018-02-27T17:06:57  <luke-jr> the Israel one would presumably just have strings that differ from the "standard" Hebrew
465 2018-02-27T17:06:58  *** JackH has joined #bitcoin-core-dev
466 2018-02-27T17:07:03  <luke-jr> oh
467 2018-02-27T17:07:03  <wumpus> right.
468 2018-02-27T17:07:15  *** grafcaps has joined #bitcoin-core-dev
469 2018-02-27T17:07:25  <luke-jr> disclaimer: I know nothing about the Hebrew language or its variations :P
470 2018-02-27T17:07:38  <michagogo> Actually, the Windows 10 setup process asks you that at some point
471 2018-02-27T17:07:49  <michagogo> When you choose a keyboard layout
472 2018-02-27T17:07:58  <michagogo> I have no clue what the difference is…
473 2018-02-27T17:09:24  <esotericnonsense> i think I submitted a translation for en_GB vs en_US at some point
474 2018-02-27T17:09:50  <esotericnonsense> and then realised that someone who actually cares about the distinction should do it
475 2018-02-27T17:10:04  <esotericnonsense> what's the default en? !?!?!?!?! </trollface>
476 2018-02-27T17:10:07  *** mehdi0x61 has quit IRC
477 2018-02-27T17:10:55  <wumpus> US is the default
478 2018-02-27T17:11:10  <wumpus> that's why it was wrong for a separate en_US translation to exist
479 2018-02-27T17:12:33  <wumpus> en_UK would be a possible addition
480 2018-02-27T17:12:44  <esotericnonsense> there is an en_GB
481 2018-02-27T17:12:48  <esotericnonsense> or at least there was
482 2018-02-27T17:13:16  <wumpus> ehh yes, GB
483 2018-02-27T17:13:23  *** mehdi0x61 has joined #bitcoin-core-dev
484 2018-02-27T17:13:58  <wumpus> Great Britain instead of United Kingdom, I guess a distinction like Holland versus The Netherlands
485 2018-02-27T17:14:12  <michagogo> I don’t know about the latter
486 2018-02-27T17:14:25  <michagogo> But it’s the United Kingdom of Great Britain and Northern Ireland
487 2018-02-27T17:14:47  <esotericnonsense> in this context it doesn't make a difference because there's no 'locality' to the fact we spell a few words slightly differently other than 'generally on that island'
488 2018-02-27T17:14:58  <wumpus> strictly, Holland is a part of the Netherlands, Zuid and Noord Holland, but everyone uses them interchangably in practice
489 2018-02-27T17:15:11  <michagogo> So UK would make more sense than GB, but that’s not what the standards organizations decided
490 2018-02-27T17:15:14  <esotericnonsense> do norwegians learn 'color' or 'colour'? :D
491 2018-02-27T17:16:18  <esotericnonsense> i feel like i'm bikeshedding a thing that no-one actually cares about, but the idea of inheriting feels a bit odd to me
492 2018-02-27T17:16:22  <michagogo> Hm, why is en_US the default and not bare en?
493 2018-02-27T17:16:52  <michagogo> Oh, I guess if something isn’t defined in en then it’ll fall through to en_US
494 2018-02-27T17:16:55  <wumpus> esotericnonsense: it's simply how localization tends to work, so there's no use bikeshedding that here
495 2018-02-27T17:17:02  <michagogo> But why have bare en at all?
496 2018-02-27T17:17:20  <esotericnonsense> heh. some dialogs with 'colour' and some with 'color'. *shudders*
497 2018-02-27T17:17:23  <wumpus> bare en is the source language
498 2018-02-27T17:17:25  * esotericnonsense wanders off to do something useful
499 2018-02-27T17:17:36  <wumpus> it cannot be edited on transifex
500 2018-02-27T17:17:41  <michagogo> Uh
501 2018-02-27T17:17:47  <michagogo> Is source different from default
502 2018-02-27T17:17:48  <michagogo> ?
503 2018-02-27T17:18:06  <wumpus> it's the language that the messages in the source code are in
504 2018-02-27T17:18:13  <michagogo> Right, makes sense
505 2018-02-27T17:18:40  <michagogo> But why have the default be en_US, and not just not use a translation by default?
506 2018-02-27T17:18:51  <michagogo> Oh, wait
507 2018-02-27T17:18:59  <michagogo> That’s what we do, since we deleted en_US
508 2018-02-27T17:19:03  <michagogo> Never mind.
509 2018-02-27T17:21:43  *** Randolf has quit IRC
510 2018-02-27T17:22:21  *** Randolf has joined #bitcoin-core-dev
511 2018-02-27T17:22:31  *** arbitrary_guy has joined #bitcoin-core-dev
512 2018-02-27T17:34:35  <wumpus> right, 'en' is not really a translation in our case, it only contains messages to be translated, no translations. There is no strict requirement that American English is the source language, it just happens to be the case for our project (and for many other projects).
513 2018-02-27T17:35:33  *** timothy has quit IRC
514 2018-02-27T17:36:27  *** Giszmo has quit IRC
515 2018-02-27T17:41:12  *** bule has joined #bitcoin-core-dev
516 2018-02-27T17:42:03  <luke-jr> wumpus: American English is? I thought standard English was, and that's why we have an en_US translation? :x
517 2018-02-27T17:42:33  <wumpus> no, we don't have an en_US translation, that was a mistake
518 2018-02-27T17:44:10  <wumpus> it was accidentally added for 0.16
519 2018-02-27T17:44:18  <wumpus> and removed again, now
520 2018-02-27T17:49:59  *** CubicEarths has joined #bitcoin-core-dev
521 2018-02-27T17:50:28  <wumpus> the messages in the source code are American English (minimize, synchronize, etc), and that's what defines the source language
522 2018-02-27T17:50:53  <wumpus> en_GB would be 'standard English'
523 2018-02-27T17:52:15  *** shesek has joined #bitcoin-core-dev
524 2018-02-27T17:52:24  *** Giszmo has joined #bitcoin-core-dev
525 2018-02-27T17:56:32  *** mehdi0x61 has quit IRC
526 2018-02-27T17:58:59  *** Amuza has quit IRC
527 2018-02-27T18:05:24  *** bule has quit IRC
528 2018-02-27T18:05:59  *** bule has joined #bitcoin-core-dev
529 2018-02-27T18:06:53  *** Giszmo has quit IRC
530 2018-02-27T18:08:49  *** mdrollette has joined #bitcoin-core-dev
531 2018-02-27T18:09:44  *** alforro has quit IRC
532 2018-02-27T18:10:27  *** MrPaz has quit IRC
533 2018-02-27T18:11:34  *** MrPaz has joined #bitcoin-core-dev
534 2018-02-27T18:22:14  *** larafale_ has quit IRC
535 2018-02-27T18:22:28  *** kos__ has joined #bitcoin-core-dev
536 2018-02-27T18:25:42  *** Emcy_ has joined #bitcoin-core-dev
537 2018-02-27T18:26:41  *** Emcy has quit IRC
538 2018-02-27T18:45:36  *** larafale has joined #bitcoin-core-dev
539 2018-02-27T18:47:35  *** Jannie4Runolfsso has quit IRC
540 2018-02-27T18:48:47  *** indistylo has joined #bitcoin-core-dev
541 2018-02-27T19:04:35  *** larafale has quit IRC
542 2018-02-27T19:05:08  *** larafale has joined #bitcoin-core-dev
543 2018-02-27T19:06:05  *** mirese_ has joined #bitcoin-core-dev
544 2018-02-27T19:08:57  *** mirese has quit IRC
545 2018-02-27T19:09:27  *** larafale has quit IRC
546 2018-02-27T19:09:39  *** mehdi0x61 has joined #bitcoin-core-dev
547 2018-02-27T19:15:53  *** bule has quit IRC
548 2018-02-27T19:16:41  *** bule has joined #bitcoin-core-dev
549 2018-02-27T19:18:30  *** Murch has quit IRC
550 2018-02-27T19:19:59  *** Murch has joined #bitcoin-core-dev
551 2018-02-27T19:22:21  *** ProfMac has joined #bitcoin-core-dev
552 2018-02-27T19:23:57  *** Randolf has quit IRC
553 2018-02-27T19:30:58  *** larafale has joined #bitcoin-core-dev
554 2018-02-27T19:32:41  *** Nona20Reilly has joined #bitcoin-core-dev
555 2018-02-27T19:34:12  *** mehdi0x61 has quit IRC
556 2018-02-27T19:37:24  *** Nona20Reilly has quit IRC
557 2018-02-27T19:42:05  *** Victorsueca has quit IRC
558 2018-02-27T19:43:18  *** Victorsueca has joined #bitcoin-core-dev
559 2018-02-27T19:43:35  *** intcat has quit IRC
560 2018-02-27T19:44:24  *** MrPaz has quit IRC
561 2018-02-27T19:45:11  *** larafale has quit IRC
562 2018-02-27T19:45:51  *** larafale has joined #bitcoin-core-dev
563 2018-02-27T19:48:04  *** intcat has joined #bitcoin-core-dev
564 2018-02-27T19:49:57  *** larafale has quit IRC
565 2018-02-27T19:57:54  *** mehdi0x61 has joined #bitcoin-core-dev
566 2018-02-27T20:03:52  *** intcat has quit IRC
567 2018-02-27T20:05:08  *** intcat has joined #bitcoin-core-dev
568 2018-02-27T20:09:33  *** bule has quit IRC
569 2018-02-27T20:10:27  *** bule has joined #bitcoin-core-dev
570 2018-02-27T20:11:53  *** shesek has quit IRC
571 2018-02-27T20:13:41  *** jb55 has joined #bitcoin-core-dev
572 2018-02-27T20:16:52  *** indistylo has quit IRC
573 2018-02-27T20:30:29  *** jb55 has quit IRC
574 2018-02-27T20:31:12  *** MrPaz has joined #bitcoin-core-dev
575 2018-02-27T20:32:34  *** Sonia47Hammes has joined #bitcoin-core-dev
576 2018-02-27T20:34:21  *** larafale has joined #bitcoin-core-dev
577 2018-02-27T20:37:40  *** Sonia47Hammes has quit IRC
578 2018-02-27T20:38:27  *** larafale has quit IRC
579 2018-02-27T20:43:10  <bitcoin-git> [bitcoin] bedri opened pull request #12562: Utils and libraries: Leveldb compile warnings (master...leveldbCompileWarnings) https://github.com/bitcoin/bitcoin/pull/12562
580 2018-02-27T20:49:18  *** Sentineo has joined #bitcoin-core-dev
581 2018-02-27T20:51:39  *** mmgen has quit IRC
582 2018-02-27T20:59:51  <eklitzke> i'm going to show my github ignorance here, but when a pull request gets merged, is the first comment on the PR (the one created by the PR author) what ends up in the git logs for the merge commit?
583 2018-02-27T21:00:17  *** zrc has joined #bitcoin-core-dev
584 2018-02-27T21:00:32  <achow101> eklitzke: we have our own github merging script that does that
585 2018-02-27T21:00:59  <achow101> https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/github-merge.py
586 2018-02-27T21:02:40  *** zrc has quit IRC
587 2018-02-27T21:03:56  *** bule has quit IRC
588 2018-02-27T21:03:58  *** SopaXorzTaker has quit IRC
589 2018-02-27T21:05:00  *** bule has joined #bitcoin-core-dev
590 2018-02-27T21:07:00  <eklitzke> ok i think i understand, the right side of the merge has the original commits with their descriptions intact, and the merge commit itself is autogenerated with the pull request title, first comment description, and a signature
591 2018-02-27T21:11:00  <sipa> correct
592 2018-02-27T21:16:07  *** bule has quit IRC
593 2018-02-27T21:16:37  *** bule has joined #bitcoin-core-dev
594 2018-02-27T21:23:26  *** larafale has joined #bitcoin-core-dev
595 2018-02-27T21:31:24  *** droark has joined #bitcoin-core-dev
596 2018-02-27T21:32:34  *** Cortney61Schimme has joined #bitcoin-core-dev
597 2018-02-27T21:37:51  *** meshcollider has joined #bitcoin-core-dev
598 2018-02-27T21:45:37  *** Cortney61Schimme has quit IRC
599 2018-02-27T21:48:03  *** Chris_Stewart_5 has quit IRC
600 2018-02-27T21:53:43  *** MrPaz has quit IRC
601 2018-02-27T22:04:27  *** bule has quit IRC
602 2018-02-27T22:05:03  *** bule has joined #bitcoin-core-dev
603 2018-02-27T22:17:43  *** MrPaz has joined #bitcoin-core-dev
604 2018-02-27T22:32:35  *** Leonora45Goldner has joined #bitcoin-core-dev
605 2018-02-27T22:40:33  *** rex_4539 has joined #bitcoin-core-dev
606 2018-02-27T22:43:07  *** Leonora45Goldner has quit IRC
607 2018-02-27T22:47:21  *** mehdi0x61 has quit IRC
608 2018-02-27T22:50:14  *** Victorsueca has quit IRC
609 2018-02-27T22:51:45  *** Victorsueca has joined #bitcoin-core-dev
610 2018-02-27T22:54:09  *** larafale has quit IRC
611 2018-02-27T22:54:47  *** larafale has joined #bitcoin-core-dev
612 2018-02-27T22:54:52  *** laurentmt has joined #bitcoin-core-dev
613 2018-02-27T22:58:57  *** larafale has quit IRC
614 2018-02-27T23:02:10  *** Cogito_Ergo_Sum has quit IRC
615 2018-02-27T23:02:29  *** rongze has joined #bitcoin-core-dev
616 2018-02-27T23:03:04  *** rongze has joined #bitcoin-core-dev
617 2018-02-27T23:07:19  *** rongze has quit IRC
618 2018-02-27T23:14:39  *** bule has quit IRC
619 2018-02-27T23:15:02  *** wxss has quit IRC
620 2018-02-27T23:15:16  *** bule has joined #bitcoin-core-dev
621 2018-02-27T23:22:47  *** shesek has joined #bitcoin-core-dev
622 2018-02-27T23:23:35  *** Guyver2 has quit IRC
623 2018-02-27T23:32:31  *** Randolf has joined #bitcoin-core-dev
624 2018-02-27T23:32:41  *** Lawson85Schimmel has joined #bitcoin-core-dev
625 2018-02-27T23:35:20  *** laurentmt has quit IRC
626 2018-02-27T23:35:59  *** vicenteH has quit IRC
627 2018-02-27T23:41:19  <CubicEarths> Why does the client seem to only download blocks a certain distance ahead of what the CPU has processed?
628 2018-02-27T23:43:57  *** rongze has joined #bitcoin-core-dev
629 2018-02-27T23:44:37  *** rongze has joined #bitcoin-core-dev
630 2018-02-27T23:44:44  <sipa> CubicEarths: to not interfere too much with pruning
631 2018-02-27T23:46:55  <sipa> (if the blocks are too much out of order on disk, you need to wait very long before a file which can contain a block of blocks from everywhere can be deleted)
632 2018-02-27T23:48:45  *** rongze has quit IRC
633 2018-02-27T23:51:20  *** rex_4539 has quit IRC
634 2018-02-27T23:51:39  <CubicEarths> I don't understand...  I can see reasons related to being a good citizen on the network, but you are saying it has to do with my own node's syncing performance?
635 2018-02-27T23:52:31  <sipa> if you enable pruning, you delete block files which only have old blocks in them
636 2018-02-27T23:52:48  <sipa> this is not possible if every block files contains blocks from all over the place
637 2018-02-27T23:53:02  <CubicEarths> ahh
638 2018-02-27T23:53:58  <sipa> by not letting downloading getting ahead too far of validation (1024 blocks ahead max), we guarantee that after 1024 blocks, you're always able to delete the old files with blocks before that point (plus some overhead blocks, i think 288, to not interfere with reorgs)
639 2018-02-27T23:54:37  <sipa> it doesn't really matter if you don't prune and don't plan to ever do so
640 2018-02-27T23:54:47  <CubicEarths> yeah
641 2018-02-27T23:54:52  <sipa> but it also doesn't hurt you much to restrict yourself to 1024 blocks ahead
642 2018-02-27T23:55:56  <CubicEarths> well, sometimes you are near great internet, and it would be nice to be able to download blocks as fast as possible, and allow the processing to happen later
643 2018-02-27T23:56:54  <CubicEarths> I am surprised that blocks are not put in blockfiles according to the block number
644 2018-02-27T23:57:28  <CubicEarths> But it sounds like the files are just filled up sequentially with blocks as the come in?
645 2018-02-27T23:57:53  <bitcoin-git> [bitcoin] AkioNak closed pull request #11988: Reduce redundant code of prevector and speed it up (master...prevector) https://github.com/bitcoin/bitcoin/pull/11988
646 2018-02-27T23:58:54  <aj> CubicEarths: if you had blocks 1000-2000 in a single file, then had hundreds of reorgs in that range, that particular file could grow absurdly large; likewise if all those blocks were empty, you'd end up with unnecessarily small files