12018-02-27T00:00:03  *** weez17 has quit IRC
  22018-02-27T00:00:36  *** weez17 has joined #bitcoin-core-dev
  32018-02-27T00:03:53  *** MrPaz has quit IRC
  42018-02-27T00:06:27  *** Aaronvan_ has quit IRC
  52018-02-27T00:06:36  *** CubicEarths has quit IRC
  62018-02-27T00:12:02  *** Cogito_Ergo_Sum has quit IRC
  72018-02-27T00:16:40  *** MrPaz has joined #bitcoin-core-dev
  82018-02-27T00:18:32  *** CubicEarths has joined #bitcoin-core-dev
  92018-02-27T00:26:33  *** grafcaps has quit IRC
 102018-02-27T00:31:10  *** delta__ has joined #bitcoin-core-dev
 112018-02-27T00:31:11  *** HFRadical has quit IRC
 122018-02-27T00:31:35  *** delta__ has quit IRC
 132018-02-27T00:35:21  <bitcoin-git> [bitcoin] denis2342 closed pull request #12541: streamlined the use of include_hex (master...master) https://github.com/bitcoin/bitcoin/pull/12541
 142018-02-27T00:38:51  *** grafcaps has joined #bitcoin-core-dev
 152018-02-27T00:43:18  <eklitzke> 31% of the time in ReadBlockFromDisk() is spent in prevector::resize
 162018-02-27T00:43:22  <eklitzke> smh
 172018-02-27T00:44:22  <eklitzke> actually that's just one of the code paths, altogether it's 37% if you count the other code paths
 182018-02-27T00:45:13  *** Thad34Watsica has quit IRC
 192018-02-27T00:45:42  <sipa> that's remarkable
 202018-02-27T00:45:51  <sipa> oh, scriptSigs
 212018-02-27T00:46:31  <sipa> (for scriptPubKeys, prevector should almost never need an allocation)
 222018-02-27T00:46:41  <eklitzke> https://monad.io/readblockfromdisk.svg
 232018-02-27T00:48:03  <sipa> \o/ flame diagram
 242018-02-27T00:50:05  <sipa> and 44% in sse4_transform
 252018-02-27T00:50:40  <eklitzke> i don't quite get it, so when you call resize() on a prevector, if it grows the vector it calls operator new in a loop for the full new capacity?
 262018-02-27T00:51:47  <cfields> eklitzke: I assume it mallocs what's needed, then calls placement-new for each element
 272018-02-27T00:51:57  <sipa> eklitzke: those are just placement news, they don't allocate
 282018-02-27T00:52:03  <eklitzke> ah
 292018-02-27T00:52:15  <cfields> if that's the case and where it's spending its time, we could short-circuit that for the unsigned char case.
 302018-02-27T00:52:26  <sipa> eklitzke: it's filling the new space with objects (which should be trivial in the case the type is unsigned char)
 312018-02-27T00:52:36  <sipa> cfields: ack
 322018-02-27T00:52:41  <sipa> didn't you have a branch to do that?
 332018-02-27T00:53:24  <cfields> sipa: i did at one point, but I believe the main slow-down was in the dtor, which was fixed. so I didn't go any further with it
 342018-02-27T00:54:39  <cfields> eklitzke: grep for is_trivially_destructible. We could do the same for the ctor and is_trivially_default_constructible.
 352018-02-27T00:56:10  <cfields> (though it should be possible to skip the runtime check entirely with SFINAE)
 362018-02-27T00:56:42  <eklitzke> wait does this actually do the is_trivially_destructible check at runtime?
 372018-02-27T00:56:44  <eklitzke> yeah
 382018-02-27T00:56:48  <eklitzke> that's where i was going to go
 392018-02-27T00:57:05  <sipa> eklitzke: a smart compiler will do it at compile time
 402018-02-27T00:57:10  <cfields> eklitzke: hopefully the compiler optimizes it away
 412018-02-27T00:57:11  <cfields> heh
 422018-02-27T00:57:19  <eklitzke> right, looks strange to me though
 432018-02-27T00:57:25  <sipa> it's possible to write the code in a way that forces it at compile time
 442018-02-27T00:57:34  <eklitzke> yeah i'm used to doing this with std::enable_if
 452018-02-27T00:57:45  <eklitzke> i'll try to make the prevector code a little faster
 462018-02-27T00:58:08  *** justanotheruser has joined #bitcoin-core-dev
 472018-02-27T01:00:35  *** promag has quit IRC
 482018-02-27T01:01:48  *** echeveria has joined #bitcoin-core-dev
 492018-02-27T01:02:11  *** echeveria is now known as Guest12590
 502018-02-27T01:02:29  *** echeveria_ has joined #bitcoin-core-dev
 512018-02-27T01:02:41  *** echeveria_ has joined #bitcoin-core-dev
 522018-02-27T01:03:29  <cfields> eklitzke: you may find it helpful to add resize() to the existing prevector benches
 532018-02-27T01:03:38  <cfields> that'd make it trivial to demonstrate a speedup
 542018-02-27T01:03:58  <eklitzke> good advice, i wouldn't have thought of that
 552018-02-27T01:05:28  <sipa> also, given that the only instance of prevector today uses unsigned char, you could just unconditionally hack it in and remove that loop entirely (for the purpose of benchmarking it)
 562018-02-27T01:06:34  *** echeveria_ has quit IRC
 572018-02-27T01:06:42  *** echeveria_ has joined #bitcoin-core-dev
 582018-02-27T01:06:58  *** echeveria_ has quit IRC
 592018-02-27T01:06:59  *** echeveria_ has joined #bitcoin-core-dev
 602018-02-27T01:10:15  *** echeveria_ has quit IRC
 612018-02-27T01:10:24  *** echeveria_ has joined #bitcoin-core-dev
 622018-02-27T01:10:40  *** echeveria_ has joined #bitcoin-core-dev
 632018-02-27T01:11:00  *** rongze has joined #bitcoin-core-dev
 642018-02-27T01:11:55  *** rongze has joined #bitcoin-core-dev
 652018-02-27T01:15:23  *** rongze_ has joined #bitcoin-core-dev
 662018-02-27T01:15:24  *** rongze has quit IRC
 672018-02-27T01:16:31  *** Randolf has joined #bitcoin-core-dev
 682018-02-27T01:25:49  <Randolf> I'm hoping someone can help me with this -- I tried to rebase PR #12546 down to a single commit, but it's just not showing up on GitHub, although "git log" shows me what I'm expecting to see.  Is "git push -f" not synchronizing because the Travis CI build failed?  Thanks in advance.
 692018-02-27T01:25:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub
 702018-02-27T01:27:22  <esotericnonsense> Randolf: you pushed to randolf:master rather than randolf:patch-3
 712018-02-27T01:27:50  <esotericnonsense> Randolf: the PR is tracking patch-3, https://github.com/randolf/bitcoin looks to have the single commit on top of master I think?
 722018-02-27T01:29:31  *** rongze_ has quit IRC
 732018-02-27T01:31:09  *** promag has joined #bitcoin-core-dev
 742018-02-27T01:31:26  <Randolf> esotericnonsense:  Oh, okay.  I'll try to figure out what I've missed then.  Thank you.
 752018-02-27T01:31:44  <Randolf> I did use this command prior to rebase:  git reset --hard origin/patch-3
 762018-02-27T01:31:47  *** rongze has joined #bitcoin-core-dev
 772018-02-27T01:31:50  <cfields> eklitzke: something else you may be interested in benching, our utxo decompressor decompresses to a std::vector rather than a prevec, forcing an unnecessary copy into the resulting prevec.
 782018-02-27T01:31:57  <cfields> (from my reading of the code, anyway)
 792018-02-27T01:32:21  <cfields> though I realize you're probably just looking at blocks atm
 802018-02-27T01:32:34  *** Flo80Mills has joined #bitcoin-core-dev
 812018-02-27T01:33:03  *** rongze has quit IRC
 822018-02-27T01:33:10  <Randolf> Ah, yes, I see that "git push -f" is resulting in this:   + 393545d85...b787a7fc6 master -> master (forced update)
 832018-02-27T01:33:37  *** rongze has joined #bitcoin-core-dev
 842018-02-27T01:35:33  *** promag has quit IRC
 852018-02-27T01:39:19  <esotericnonsense> it sounds like you checked out master, reset it to origin/patch-3, then rebased and squashed, something like that.
 862018-02-27T01:39:56  *** dabura667 has joined #bitcoin-core-dev
 872018-02-27T01:41:43  <Randolf> I'm going to try again with a "git checkout patch-3" command.  (I'm still new to git.)
 882018-02-27T01:43:28  <Randolf> That was it -- I missed the checkout step.  It seems that I don't need to do the reset step then.
 892018-02-27T01:44:24  *** promag has joined #bitcoin-core-dev
 902018-02-27T01:49:51  *** echeveria_ is now known as echeveria
 912018-02-27T01:54:59  *** promag has quit IRC
 922018-02-27T02:10:33  *** CubicEarths has quit IRC
 932018-02-27T02:26:48  *** shesek has quit IRC
 942018-02-27T02:38:00  *** belcher has quit IRC
 952018-02-27T03:00:21  *** arbitrary_guy has joined #bitcoin-core-dev
 962018-02-27T03:17:01  *** promag has joined #bitcoin-core-dev
 972018-02-27T03:21:14  *** Giszmo has joined #bitcoin-core-dev
 982018-02-27T03:21:35  *** promag has quit IRC
 992018-02-27T03:25:33  *** Giszmo has quit IRC
1002018-02-27T03:38:46  *** promag has joined #bitcoin-core-dev
1012018-02-27T03:40:46  *** Giszmo has joined #bitcoin-core-dev
1022018-02-27T03:43:39  *** promag has quit IRC
1032018-02-27T03:47:59  *** Giszmo has quit IRC
1042018-02-27T03:48:38  *** Danilo_ has joined #bitcoin-core-dev
1052018-02-27T03:53:41  *** promag has joined #bitcoin-core-dev
1062018-02-27T03:58:23  *** promag has quit IRC
1072018-02-27T03:59:52  *** arbitrary_guy has quit IRC
1082018-02-27T04:05:06  *** Giszmo has joined #bitcoin-core-dev
1092018-02-27T04:06:06  *** Danilo_ has quit IRC
1102018-02-27T04:16:56  <bitcoin-git> [bitcoin] eklitzke opened pull request #12549: Make prevector::resize() and other prevector operations much faster (master...prevector) https://github.com/bitcoin/bitcoin/pull/12549
1112018-02-27T04:18:13  *** promag has joined #bitcoin-core-dev
1122018-02-27T04:23:13  *** promag has quit IRC
1132018-02-27T04:24:02  *** Cheeseo has joined #bitcoin-core-dev
1142018-02-27T04:24:59  *** RoyceX has quit IRC
1152018-02-27T04:25:07  <sipa> eklitzke: nice!
1162018-02-27T04:25:33  *** LumberCartel has joined #bitcoin-core-dev
1172018-02-27T04:25:58  *** arbitrary_guy has joined #bitcoin-core-dev
1182018-02-27T04:26:01  *** LumberCartel has quit IRC
1192018-02-27T04:26:47  *** Randolf has quit IRC
1202018-02-27T04:27:01  *** Randolf has joined #bitcoin-core-dev
1212018-02-27T04:28:02  <bitcoin-git> [bitcoin] bedri opened pull request #12550: Utils and libraries: Leveldb warning fixes (0.16...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12550
1222018-02-27T04:35:21  <eklitzke> hmm, what version of gcc/libstdc++ does travis use?
1232018-02-27T04:35:38  <sipa> gcc 4.8 i believe
1242018-02-27T04:38:38  <bitcoin-git> [bitcoin] bedri closed pull request #12550: Utils and libraries: Leveldb warning fixes (0.16...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12550
1252018-02-27T04:44:12  <bitcoin-git> [bitcoin] bedri opened pull request #12551: Leveldb warning fixes (master...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12551
1262018-02-27T04:50:47  *** promag has joined #bitcoin-core-dev
1272018-02-27T04:56:02  *** promag has quit IRC
1282018-02-27T05:02:35  *** promag has joined #bitcoin-core-dev
1292018-02-27T05:07:17  *** promag has quit IRC
1302018-02-27T05:19:08  *** arbitrary_guy has quit IRC
1312018-02-27T05:23:06  *** promag has joined #bitcoin-core-dev
1322018-02-27T05:23:58  <esotericnonsense> hm.
1332018-02-27T05:27:43  *** promag has quit IRC
1342018-02-27T05:37:27  *** arbitrary_guy has joined #bitcoin-core-dev
1352018-02-27T05:38:01  *** d9b4bef9 has quit IRC
1362018-02-27T05:39:08  *** d9b4bef9 has joined #bitcoin-core-dev
1372018-02-27T05:40:58  *** aruns__ has joined #bitcoin-core-dev
1382018-02-27T05:57:55  *** promag has joined #bitcoin-core-dev
1392018-02-27T06:01:24  *** Victorsueca has quit IRC
1402018-02-27T06:02:13  *** promag has quit IRC
1412018-02-27T06:02:33  *** Victorsueca has joined #bitcoin-core-dev
1422018-02-27T06:08:43  *** CubicEarths has joined #bitcoin-core-dev
1432018-02-27T06:28:03  <bitcoin-git> [bitcoin] fanquake closed pull request #12551: Utils and libraries: Leveldb warning fixes (master...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12551
1442018-02-27T06:28:30  *** PaulCape_ has quit IRC
1452018-02-27T06:28:47  *** PaulCapestany has joined #bitcoin-core-dev
1462018-02-27T06:31:44  *** cryptojanitor has quit IRC
1472018-02-27T06:35:39  *** promag has joined #bitcoin-core-dev
1482018-02-27T06:37:42  <bitcoin-git> [bitcoin] Empact opened pull request #12553: Prefer wait_until over polling with time.sleep (master...wait-until) https://github.com/bitcoin/bitcoin/pull/12553
1492018-02-27T06:40:12  *** promag has quit IRC
1502018-02-27T06:54:29  *** promag has joined #bitcoin-core-dev
1512018-02-27T06:56:05  *** MrPaz has quit IRC
1522018-02-27T06:58:57  *** promag has quit IRC
1532018-02-27T07:15:50  *** promag has joined #bitcoin-core-dev
1542018-02-27T07:19:19  *** Strepsils has joined #bitcoin-core-dev
1552018-02-27T07:20:04  *** Strepsils has quit IRC
1562018-02-27T07:20:39  *** promag has quit IRC
1572018-02-27T07:21:33  *** whphhg has quit IRC
1582018-02-27T07:34:18  *** Murch has quit IRC
1592018-02-27T07:43:33  *** Sentineo has quit IRC
1602018-02-27T07:44:00  *** ken2812221 has joined #bitcoin-core-dev
1612018-02-27T07:52:50  *** promag has joined #bitcoin-core-dev
1622018-02-27T07:54:10  *** aruns has joined #bitcoin-core-dev
1632018-02-27T07:56:43  *** aruns__ has quit IRC
1642018-02-27T07:58:07  *** promag has quit IRC
1652018-02-27T07:58:16  *** mmgen has joined #bitcoin-core-dev
1662018-02-27T08:02:17  *** JackH has quit IRC
1672018-02-27T08:06:27  <bitcoin-git> [bitcoin] multibhw opened pull request #12555: Tweet  RUN TIME (master...TWEET) https://github.com/bitcoin/bitcoin/pull/12555
1682018-02-27T08:07:31  <bitcoin-git> [bitcoin] fanquake closed pull request #12555: Tweet  RUN TIME (master...TWEET) https://github.com/bitcoin/bitcoin/pull/12555
1692018-02-27T08:16:17  *** JackH has joined #bitcoin-core-dev
1702018-02-27T08:18:12  *** promag has joined #bitcoin-core-dev
1712018-02-27T08:22:11  *** nullptr| has quit IRC
1722018-02-27T08:22:55  *** promag has quit IRC
1732018-02-27T08:28:14  *** nullptr| has joined #bitcoin-core-dev
1742018-02-27T08:29:32  <hkjn0> eklitzke: cool flame graph! mind sharing how you produced it?
1752018-02-27T08:32:33  *** nullptr| has quit IRC
1762018-02-27T08:36:40  *** nullptr| has joined #bitcoin-core-dev
1772018-02-27T08:55:54  *** promag has joined #bitcoin-core-dev
1782018-02-27T09:00:17  *** promag has quit IRC
1792018-02-27T09:03:52  *** mistakenine has joined #bitcoin-core-dev
1802018-02-27T09:05:51  <mistakenine> hi,Is there anyone interested in a parallel block chain？a complex data structure
1812018-02-27T09:17:04  *** mehdi0x61 has joined #bitcoin-core-dev
1822018-02-27T09:20:38  *** timothy has joined #bitcoin-core-dev
1832018-02-27T09:23:55  *** promag has joined #bitcoin-core-dev
1842018-02-27T09:25:07  *** drizztbsd has joined #bitcoin-core-dev
1852018-02-27T09:25:36  *** dabura667 has quit IRC
1862018-02-27T09:25:51  *** AaronvanW has joined #bitcoin-core-dev
1872018-02-27T09:25:53  *** timothy has quit IRC
1882018-02-27T09:27:31  *** Aaronvan_ has joined #bitcoin-core-dev
1892018-02-27T09:28:32  *** mehdi0x61 has quit IRC
1902018-02-27T09:28:36  *** promag has quit IRC
1912018-02-27T09:29:24  *** promag has joined #bitcoin-core-dev
1922018-02-27T09:30:41  *** larafale has joined #bitcoin-core-dev
1932018-02-27T09:30:46  *** promag has quit IRC
1942018-02-27T09:30:53  *** AaronvanW has quit IRC
1952018-02-27T09:31:19  *** promag has joined #bitcoin-core-dev
1962018-02-27T09:35:37  *** promag has quit IRC
1972018-02-27T09:39:11  *** Flo80Mills has quit IRC
1982018-02-27T09:44:21  *** larafale has quit IRC
1992018-02-27T09:44:57  *** larafale has joined #bitcoin-core-dev
2002018-02-27T09:48:43  *** aruns__ has joined #bitcoin-core-dev
2012018-02-27T09:48:57  *** larafale has quit IRC
2022018-02-27T09:49:54  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/5d41110c745c74e1eeb85f187f54777bf5e6407f
2032018-02-27T09:49:54  <bitcoin-git> bitcoin/0.16 5d41110 Wladimir J. van der Laan: doc: Clear out release notes post-0.16.0...
2042018-02-27T09:50:16  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/01f931b928fbe0266b3a8d48d0fb2ecc728bd7f3
2052018-02-27T09:50:16  <bitcoin-git> bitcoin/0.16 01f931b Wladimir J. van der Laan: test: Add missing signal.h header...
2062018-02-27T09:50:53  *** aruns has quit IRC
2072018-02-27T09:55:04  <mistakenine> hi,Is there anyone interested in a parallel block chain？a complex data structure
2082018-02-27T09:56:00  <mistakenine> to see all the parallel blockchain as a whole
2092018-02-27T09:56:35  <wumpus> mistakenine: not here please
2102018-02-27T09:56:57  <provoostenator> CubicEarths: I know, I prefer the GUI myself. But technical people can use bitcoin.conf, so it's the less-technical users I'm trying to help here.
2112018-02-27T09:57:04  *** drizztbsd is now known as timothy
2122018-02-27T09:57:43  <wumpus> (a "parallel chain" is an interesting self-contradiction, anyway)
2132018-02-27T09:58:32  <mistakenine> yes,but i find a way to give a solution
2142018-02-27T09:58:46  <mistakenine> it's a very hard problem
2152018-02-27T09:59:41  <CubicEarths> provoostenator: understood.
2162018-02-27T09:59:49  <mistakenine> i give a math proof，but don't know how where to discuss that
2172018-02-27T10:00:05  <wumpus> mistakenine: not here at least, it has nothing to do with bitcoin core development
2182018-02-27T10:00:44  *** echonaut has quit IRC
2192018-02-27T10:00:49  *** larafale has joined #bitcoin-core-dev
2202018-02-27T10:01:01  *** echonaut has joined #bitcoin-core-dev
2212018-02-27T10:02:14  *** go1111111 has quit IRC
2222018-02-27T10:03:04  *** aruns__ has quit IRC
2232018-02-27T10:03:26  *** aruns__ has joined #bitcoin-core-dev
2242018-02-27T10:04:03  *** Aaronvan_ has quit IRC
2252018-02-27T10:05:32  *** C4R3Bear has joined #bitcoin-core-dev
2262018-02-27T10:10:13  *** aruns__ has quit IRC
2272018-02-27T10:10:16  *** mistakenine has quit IRC
2282018-02-27T10:10:17  *** aruns has joined #bitcoin-core-dev
2292018-02-27T10:14:19  *** AaronvanW has joined #bitcoin-core-dev
2302018-02-27T10:14:54  *** go1111111 has joined #bitcoin-core-dev
2312018-02-27T10:16:31  *** shesek has joined #bitcoin-core-dev
2322018-02-27T10:16:31  *** shesek has quit IRC
2332018-02-27T10:16:31  *** shesek has joined #bitcoin-core-dev
2342018-02-27T10:22:05  *** arbitrary_guy has quit IRC
2352018-02-27T10:32:34  *** Stefan87Krajcik has joined #bitcoin-core-dev
2362018-02-27T10:47:35  <bitcoin-git> [bitcoin] tamasblummer opened pull request #12556: [Trivial] fix version typo in getpeerinfo RPC call help (master...fix_version_typo) https://github.com/bitcoin/bitcoin/pull/12556
2372018-02-27T10:48:00  *** CubicEarths has quit IRC
2382018-02-27T10:51:25  *** ProfMac has quit IRC
2392018-02-27T10:51:52  *** Lynet has joined #bitcoin-core-dev
2402018-02-27T10:52:26  *** SopaXorzTaker has joined #bitcoin-core-dev
2412018-02-27T11:02:58  *** C4R3Bear has quit IRC
2422018-02-27T11:03:54  *** belcher has joined #bitcoin-core-dev
2432018-02-27T11:08:24  *** zrc has joined #bitcoin-core-dev
2442018-02-27T11:11:57  *** shesek has quit IRC
2452018-02-27T11:17:52  *** zrc has quit IRC
2462018-02-27T11:22:54  *** mehdi0x61 has joined #bitcoin-core-dev
2472018-02-27T11:23:48  *** xpan has joined #bitcoin-core-dev
2482018-02-27T11:28:12  *** mehdi0x61 has quit IRC
2492018-02-27T11:29:20  *** zrc has joined #bitcoin-core-dev
2502018-02-27T11:33:22  <bitcoin-git> [bitcoin] Sjors opened pull request #12557: [WIP] [depends] openssl: add aarch64_darwin (master...2018/02/depends-openssl-aarch64-apple-darwin1) https://github.com/bitcoin/bitcoin/pull/12557
2512018-02-27T11:35:36  *** zrc has quit IRC
2522018-02-27T11:35:56  *** zrc has joined #bitcoin-core-dev
2532018-02-27T11:37:16  *** zrc has quit IRC
2542018-02-27T11:46:48  *** mehdi0x61 has joined #bitcoin-core-dev
2552018-02-27T11:50:38  *** mehdi0x61 has quit IRC
2562018-02-27T11:54:22  *** C4R3Bear has joined #bitcoin-core-dev
2572018-02-27T12:02:44  *** xpan has quit IRC
2582018-02-27T12:09:27  *** Guyver2 has joined #bitcoin-core-dev
2592018-02-27T12:32:17  *** C4R3Bear has quit IRC
2602018-02-27T12:34:23  *** shesek has joined #bitcoin-core-dev
2612018-02-27T12:34:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2622018-02-27T12:36:09  *** useruseruser has joined #bitcoin-core-dev
2632018-02-27T12:36:24  *** useruseruser has left #bitcoin-core-dev
2642018-02-27T12:37:26  <rabidus> Am I the only one who gets their top-bar written in chinese when clicking "use previously used address" in 0.16.0 @ windows? Binaries was downloaded from bitcoin.org. AVG detected something and moved quarantine, but I granted permission. Screenshot: https://pasteboard.co/H9zSGvJ.png
2652018-02-27T12:44:52  *** mogitate has joined #bitcoin-core-dev
2662018-02-27T12:48:18  <michagogo> mlz: but I assume you don’t test on Vista
2672018-02-27T12:48:49  <michagogo> rabidus: o_O
2682018-02-27T12:48:55  <michagogo> I’ll check…
2692018-02-27T12:49:12  <mlz> michagogo, oh.. no, I do have a Vista, it doesn't have enough space for bitcoin :D
2702018-02-27T12:49:44  <michagogo> Seriously?
2712018-02-27T12:49:47  <michagogo> Why?
2722018-02-27T12:50:31  <rabidus> ok, AVG now says that the file is ok, so I assume that was because because of too fresh binaries :). Still that chinese top-bar is confusing
2732018-02-27T12:51:37  *** papaya has joined #bitcoin-core-dev
2742018-02-27T12:55:08  <ken2812221> https://github.com/bitcoin/bitcoin/blob/0.16/src/qt/locale/bitcoin_en_US.ts
2752018-02-27T12:55:28  *** C4R3Bear has joined #bitcoin-core-dev
2762018-02-27T12:55:41  <rabidus> seems "ok" then :)
2772018-02-27T13:00:50  <michagogo> ken2812221: …
2782018-02-27T13:00:53  <michagogo> oops.
2792018-02-27T13:01:02  <rabidus> at least I'm not running any chinese binaries .. probably
2802018-02-27T13:01:43  * michagogo wonders if wumpus will want to put out a 0.16.0.1
2812018-02-27T13:01:43  *** C4R3Bear has quit IRC
2822018-02-27T13:01:55  <mlz> rabidus, that's very strange, i wouldn't use it, did you verify the binaries ?
2832018-02-27T13:02:01  <ken2812221> Maybe someone can fix it on Transifex
2842018-02-27T13:02:03  *** mehdi0x61 has joined #bitcoin-core-dev
2852018-02-27T13:02:13  *** C4R3Bear has joined #bitcoin-core-dev
2862018-02-27T13:02:21  <michagogo> mlz: look at the link ken2812221 just posted
2872018-02-27T13:02:26  <michagogo> It’s in the source code
2882018-02-27T13:02:27  <rabidus> no, i didn't check any hashes, but as you can see from that translation url, it's "feature" :)
2892018-02-27T13:02:44  <michagogo> No, it’s definitely a bug
2902018-02-27T13:02:49  <rabidus> hehe, jk
2912018-02-27T13:04:26  <mlz> i see, but not verifying download files on windows is a crime :P
2922018-02-27T13:06:02  <Anduck> ^
2932018-02-27T13:06:11  <michagogo> I mean, the installer _is_ signed
2942018-02-27T13:06:16  <rabidus> wouldn't change anything
2952018-02-27T13:06:29  <rabidus> top bar would still be in chinese
2962018-02-27T13:06:32  <rabidus> :)
2972018-02-27T13:06:33  <michagogo> Which shows up when it asks you to elevate
2982018-02-27T13:07:34  *** papaya has quit IRC
2992018-02-27T13:08:51  <michagogo> Oh, there’s already #12577
3002018-02-27T13:08:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12577 | HTTP Error 404: Not Found
3012018-02-27T13:09:01  <michagogo> I mean #12544
3022018-02-27T13:09:02  <gribble> https://github.com/bitcoin/bitcoin/issues/12544 | Bitcoin Qt 0.16.0 displays a window title in Chinese instead of English · Issue #12544 · bitcoin/bitcoin · GitHub
3032018-02-27T13:09:17  <rabidus> oh, ok, nice
3042018-02-27T13:09:23  *** Ylbam_ has joined #bitcoin-core-dev
3052018-02-27T13:10:18  <bitcoin-git> [bitcoin] drodil opened pull request #12558: Fix translations in en_US.ts (0.16...patch-1) https://github.com/bitcoin/bitcoin/pull/12558
3062018-02-27T13:18:09  *** C4R3Bear has quit IRC
3072018-02-27T13:24:03  *** Sentineo has joined #bitcoin-core-dev
3082018-02-27T13:29:33  *** shesek has quit IRC
3092018-02-27T13:31:34  *** larafale has quit IRC
3102018-02-27T13:31:56  <provoostenator> Somewhat related to the issue of translation review: #11875
3112018-02-27T13:31:57  <gribble> https://github.com/bitcoin/bitcoin/issues/11875 | Snoei: a.k.a. how to translate technical jargon · Issue #11875 · bitcoin/bitcoin · GitHub
3122018-02-27T13:33:46  *** TyrfingMjolnir has joined #bitcoin-core-dev
3132018-02-27T13:33:53  *** larafale has joined #bitcoin-core-dev
3142018-02-27T13:33:57  *** Chris_Stewart_5 has quit IRC
3152018-02-27T13:34:00  <TyrfingMjolnir> Anyone got 2 consequtive sample blocks?
3162018-02-27T13:34:28  <TyrfingMjolnir> with full schematics
3172018-02-27T13:34:29  *** aruns has quit IRC
3182018-02-27T13:34:47  *** larafale_ has joined #bitcoin-core-dev
3192018-02-27T13:38:04  *** Stefan87Krajcik has quit IRC
3202018-02-27T13:38:27  *** larafale has quit IRC
3212018-02-27T13:42:44  *** dagurval has quit IRC
3222018-02-27T13:44:47  *** jimmysong__ has quit IRC
3232018-02-27T13:44:52  *** conor has joined #bitcoin-core-dev
3242018-02-27T13:47:05  *** indistylo has joined #bitcoin-core-dev
3252018-02-27T13:54:21  *** promag has joined #bitcoin-core-dev
3262018-02-27T14:00:38  *** indistylo has quit IRC
3272018-02-27T14:01:12  *** indistylo has joined #bitcoin-core-dev
3282018-02-27T14:11:20  *** zrc has joined #bitcoin-core-dev
3292018-02-27T14:13:27  *** Sentineo has quit IRC
3302018-02-27T14:18:03  *** AaronvanW has quit IRC
3312018-02-27T14:21:10  *** meshcollider has quit IRC
3322018-02-27T14:30:03  *** zrc has quit IRC
3332018-02-27T14:33:48  *** cryptojanitor has joined #bitcoin-core-dev
3342018-02-27T14:34:42  *** Elliot4Osinski has joined #bitcoin-core-dev
3352018-02-27T14:39:27  *** Elliot4Osinski has quit IRC
3362018-02-27T14:42:41  *** laurentmt has joined #bitcoin-core-dev
3372018-02-27T14:44:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3382018-02-27T14:46:10  *** Victorsueca has quit IRC
3392018-02-27T14:47:37  *** Victorsueca has joined #bitcoin-core-dev
3402018-02-27T14:49:24  *** rongze has quit IRC
3412018-02-27T14:52:02  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/ea2e39fd2004e83375c1703543e32a10e3b9d981
3422018-02-27T14:52:02  <bitcoin-git> bitcoin/0.16 ea2e39f Wladimir J. van der Laan: qt: Remove faulty and unnecessary en_US translation...
3432018-02-27T14:52:03  <eklitzke> hkjn0: i have a wrapper script around perf(1) here that i use to actually collect the profiling data (which requires that you have a build with debug symbols): https://github.com/eklitzke/bitcoin-tools/blob/master/perf.sh
3442018-02-27T14:52:35  <eklitzke> then the flame graph itself is generated using https://github.com/brendangregg/FlameGraph
3452018-02-27T14:53:17  <eklitzke> i have a wrapper script for invoking that as well here: https://github.com/eklitzke/bitcoin-tools/blob/master/gensvg.sh (although in practice i've found i often want to use grep to filter out more data before invoking flamegraph.pl)
3462018-02-27T14:54:21  <bitcoin-git> [bitcoin] laanwj closed pull request #12558: Fix translations in en_US.ts (0.16...patch-1) https://github.com/bitcoin/bitcoin/pull/12558
3472018-02-27T14:54:55  *** rongze has joined #bitcoin-core-dev
3482018-02-27T14:56:06  *** rongze has quit IRC
3492018-02-27T14:56:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/228b086b9a3d...9e2ed253f505
3502018-02-27T14:56:59  <bitcoin-git> bitcoin/master d16bfaa Tamas Blummer: fix version typo
3512018-02-27T14:57:00  <bitcoin-git> bitcoin/master 9e2ed25 Wladimir J. van der Laan: Merge #12556: [Trivial] fix version typo in getpeerinfo RPC call help...
3522018-02-27T14:57:56  <bitcoin-git> [bitcoin] laanwj closed pull request #12556: [Trivial] fix version typo in getpeerinfo RPC call help (master...fix_version_typo) https://github.com/bitcoin/bitcoin/pull/12556
3532018-02-27T15:04:47  <wumpus> michagogo: nah, IMO the only thing to warrant a 0.16.0.1 release is a crash bug
3542018-02-27T15:05:52  <luke-jr> 0.16.0 crashes if I overclock my CPU by 50%. hjelp! :p
3552018-02-27T15:06:16  *** laurentmt has quit IRC
3562018-02-27T15:07:46  *** alforro has joined #bitcoin-core-dev
3572018-02-27T15:13:37  *** indistylo has quit IRC
3582018-02-27T15:15:29  <wumpus> I get bit flips on one of my nodes even without overclocking, caused quite a panic this morning when it resulted in the node splitting from consensus
3592018-02-27T15:19:01  *** Ylbam_ has quit IRC
3602018-02-27T15:19:52  <provoostenator> So I've been studying how the QT send screen composes a transaction. It all seems to revolve around WalletModelTransaction.
3612018-02-27T15:21:29  <wumpus> yes, walletmodeltransaction is the GUI-side model for a transaction to be sent
3622018-02-27T15:21:29  <provoostenator> The way it works now is  that an initial WalletModelTransaction  is created, but several aspects of the transaciton are "stored" in the UI itself. E.g. there's a UI element that holds the list of destinations. Only when you hit Send is all that information collected and added to the WalletModelTransaciton instance.
3632018-02-27T15:21:53  <wumpus> yes, don't forget about the static coincontrol instance :(
3642018-02-27T15:22:07  <provoostenator> So I'm thinking about seperating the model from the view a bit better, so that any time you add / change a destination the WalletModelTransaction instance is updated and that's the source of truth.
3652018-02-27T15:22:37  <provoostenator> Which would be very nice for RBF: just give it a transaction hex, deserialize it and then render the UI.
3662018-02-27T15:22:41  <wumpus> that was really a bad design choice, but it was never cleaned up after the initial coin control contribution
3672018-02-27T15:22:58  <provoostenator> Yeah I've been digging through historical commits to see how this came to be :-)
3682018-02-27T15:23:01  <wumpus> yes, that'd probably be better
3692018-02-27T15:24:06  <provoostenator> But I wonder about the RPC. Wouldn't it benefit from some mechanism to build up a transaction in a modular way as well? So rather than needing to create a tranaction in one giant RPC command, you'd create a draft and manipulate that through smaller commands.
3702018-02-27T15:24:43  <provoostenator> And if that's the case, maybe this should all be moved one level deeper (and not depend on QT).
3712018-02-27T15:26:15  <wumpus> that's what the raw transactions API does
3722018-02-27T15:26:37  <wumpus> createrawtransaction, fundrawtransaction, signrwatransactions are the RPC equivalent of building up a transaction step by step
3732018-02-27T15:26:56  <wumpus> but intentionally entirely stateless
3742018-02-27T15:27:12  *** mehdi0x61 has quit IRC
3752018-02-27T15:27:29  <wumpus> please do keep that code in qt, the reason for having a UI-specific structure there is to make it easier to split off the GUI some day
3762018-02-27T15:28:23  <provoostenator> Would it make sense to make CMutableTransaction more powerful though? Why wouldn't QT be able to include that?
3772018-02-27T15:28:53  <wumpus> if things are only necessary for the UI, it's better to keep the code in the UI
3782018-02-27T15:29:21  <provoostenator> Coin selection and replacing transaction seem useful to both RPC and UI to me.
3792018-02-27T15:29:40  <wumpus> RPC has that, in other ways
3802018-02-27T15:29:47  <wumpus> I think you're extending the scope of what you want to do too much
3812018-02-27T15:30:29  <provoostenator> I don't know, I'm trying to figure out what's the best approach here. My own scope was to improve RBF in QT, prefereably without reinventing the wheel.
3822018-02-27T15:30:42  <provoostenator> If that makes the RPC better that's nice, but not my goal.
3832018-02-27T15:30:43  <wumpus> if you want to improve the UI, then improving th UI is what to do, if you start refactoring all over the place it's much harder to move forward
3842018-02-27T15:31:13  <provoostenator> I agree that a huge refactor is a bad idea regardless.
3852018-02-27T15:31:41  <wumpus> refactor of the UI would be ok, but combining it with changing CMutableTransaction etc is just too much
3862018-02-27T15:32:34  *** Jannie4Runolfsso has joined #bitcoin-core-dev
3872018-02-27T15:34:48  <provoostenator> Actually I'm not sure if UI is my only concern here. I like the idea of keeping QT relatively simple and making it possible to build a UI on top of RPC (using whatever framework).
3882018-02-27T15:35:16  <provoostenator> But I agree that changing both at this point would involve too many moving parts.
3892018-02-27T15:37:42  *** grafcaps has quit IRC
3902018-02-27T15:38:42  *** mehdi0x61 has joined #bitcoin-core-dev
3912018-02-27T15:40:06  <wumpus> I'm fairly sure it's possible to build this UI on top of listunspent and *rawtransaction API
3922018-02-27T15:40:37  <provoostenator> The above is a fairly complicated way to achieve RBF, but has the advatage of letting UI users tweak the new transaction anyway they want.
3932018-02-27T15:41:02  <provoostenator> A simpler approach would be improve the bumpfee RPC stuff and then create a UI where the user can merely change the fee, nothing else.
3942018-02-27T15:41:31  *** mehdi0x61 has quit IRC
3952018-02-27T15:41:39  *** conor has quit IRC
3962018-02-27T15:43:39  *** HFRadical has joined #bitcoin-core-dev
3972018-02-27T15:44:18  <provoostenator> (by "the above" I mean moving some stuff from the view code into WalletModelTransaction, I don't mean changing CMutableTransaction)
3982018-02-27T15:46:13  *** mehdi0x61 has joined #bitcoin-core-dev
3992018-02-27T16:04:28  *** MrPaz has joined #bitcoin-core-dev
4002018-02-27T16:05:59  *** Murch has joined #bitcoin-core-dev
4012018-02-27T16:06:02  *** lifeofguenter has quit IRC
4022018-02-27T16:12:54  *** lifeofguenter has joined #bitcoin-core-dev
4032018-02-27T16:14:47  *** Victorsueca has quit IRC
4042018-02-27T16:16:02  *** Victorsueca has joined #bitcoin-core-dev
4052018-02-27T16:16:59  <michagogo> wumpus: I think I actually saw the commit that introduced the en_us translation
4062018-02-27T16:17:19  <michagogo> It was 5109347, which added a whole lot of translations
4072018-02-27T16:17:34  <michagogo> I remember I saw that and idly wondered what was going on there
4082018-02-27T16:17:40  <michagogo> And forgot to follow up on that thought
4092018-02-27T16:18:12  <michagogo> For example, I haven’t looked at the content, but I saw that it added a he_IL translation in addition to the existing he?
4102018-02-27T16:18:28  <michagogo> As far as I know there isn’t really a Hebrew besides he_IL
4112018-02-27T16:18:45  <michagogo> I also don’t really know how the translation stuff works
4122018-02-27T16:18:55  *** rongze has joined #bitcoin-core-dev
4132018-02-27T16:19:40  <wumpus> well it synced the transifex translations with the ones in the repository
4142018-02-27T16:20:06  <michagogo> That commit seems to introduce a bunch of new languages, but also a whole lot of new files with country codes where previously there was just the country-less language
4152018-02-27T16:20:41  <michagogo> Can anyone on transifex just create a new language?
4162018-02-27T16:20:42  <wumpus> well, if translations need to be deleted they need to be deleted from transifex first,t hen from the repository, that prevents them from coming back
4172018-02-27T16:20:47  <wumpus> no, they have to be approved
4182018-02-27T16:20:57  <wumpus> though the policy seems to be that everything is approved
4192018-02-27T16:21:08  <michagogo> And within the release cycle all those new ones went in?
4202018-02-27T16:21:27  <wumpus> it's hard to think of a valid reason to reject someone adding a translation for someone's language/country
4212018-02-27T16:21:36  <wumpus> though adding en_US was stupid :)
4222018-02-27T16:21:59  <michagogo> I suspect it might be a good idea to go over and do a sanity check of the languages that added a new single country code where previously there was just a bare language
4232018-02-27T16:22:41  <michagogo> For example, adding he_IL when he exists seems vaguely suspicious to me
4242018-02-27T16:23:10  *** rongze has quit IRC
4252018-02-27T16:23:54  <michagogo> Another example, de_DE was added when de exists, and no other de_XX versions
4262018-02-27T16:24:10  <michagogo> I would expect that bare de would be German German
4272018-02-27T16:24:29  <michagogo> If the new file were de_CH or something it would make sense, but…
4282018-02-27T16:24:51  <bitcoin-git> [bitcoin] promag opened pull request #12559: Avoid locking cs_main in some wallet RPC (master...2018-02-avoid-cs_main-lock) https://github.com/bitcoin/bitcoin/pull/12559
4292018-02-27T16:26:45  *** Randolf has quit IRC
4302018-02-27T16:29:38  *** Amuza has joined #bitcoin-core-dev
4312018-02-27T16:32:08  <bitcoin-git> [bitcoin] achow101 opened pull request #12560: [wallet][RPC] Set or generate a new HD seed (master...sethdseed) https://github.com/bitcoin/bitcoin/pull/12560
4322018-02-27T16:36:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4332018-02-27T16:36:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4342018-02-27T16:38:37  *** HFRadical has quit IRC
4352018-02-27T16:39:54  *** wxss has joined #bitcoin-core-dev
4362018-02-27T16:41:02  <bitcoin-git> [bitcoin] sdaftuar opened pull request #12561: Remove call to CheckBlock() in ConnectBlock() (master...2018-02-improve-checkblock-failure) https://github.com/bitcoin/bitcoin/pull/12561
4372018-02-27T16:43:15  <TyrfingMjolnir> How can I create my own local block chain and generate 10 valid blocks at random for development purposes?
4382018-02-27T16:44:01  <Chris_Stewart_5> TyrfingMjolnir: $ bitcoind -regtest -daemon && bitcoin-cli -regtest generate 10
4392018-02-27T16:45:13  <TyrfingMjolnir> Perfect, thanks
4402018-02-27T16:52:06  *** Randolf has joined #bitcoin-core-dev
4412018-02-27T16:53:19  *** JackH has quit IRC
4422018-02-27T16:54:18  <wumpus> michagogo: I agree, but I don't have enough international lingual knowledge to make decisions about such things, if you find specific ones that make no sense, please report them
4432018-02-27T16:54:50  <wumpus> this has happened in the past, that a transifex translator reported that a certain language/locale pair makes no sense and it was removed
4442018-02-27T16:55:08  <michagogo> Yeah, I guess
4452018-02-27T16:55:57  <michagogo> It’s things like this that make me really wish I had free time to do stuff like go and look at he vs he_IL
4462018-02-27T16:55:59  <wumpus> but in the absence of specific information I tend to err on the side of allowing it
4472018-02-27T16:58:25  <michagogo> I’m on my phone on the bus, so I didn’t look into the content, but I see the new he_IL is much, much shorter than the existing he
4482018-02-27T16:59:16  <michagogo> Does Qt have a fallback thing, where if you’re set to xx_YY and a string is missing, it will use the translation for bare xx?
4492018-02-27T16:59:26  <michagogo> Or is each translation completely independent?
4502018-02-27T16:59:35  <wumpus> shortness doesn't matter, it will just override the general one for the messages that are specified
4512018-02-27T16:59:54  <michagogo> Okay, good - at least there’s that
4522018-02-27T17:00:06  <wumpus> e.g. fallback order would be he_IL -> he -> en/original
4532018-02-27T17:00:13  <michagogo> Okay, that’s good at least
4542018-02-27T17:00:19  <luke-jr> michagogo: wumpus: I did a sanity check a few months ago, and made a todo list
4552018-02-27T17:00:24  <luke-jr> but it's probably not updated anymore
4562018-02-27T17:00:51  <luke-jr> and I have no clue where I saved it :x
4572018-02-27T17:01:02  <michagogo> But I still doubt there’s anything that belongs in he_IL that shouldn’t just be in he
4582018-02-27T17:02:19  <luke-jr> someone should probably just do the obvious ones (eg, if there's no he, rename he_IL to it)
4592018-02-27T17:02:27  <luke-jr> and then contact people in non-obvious cases
4602018-02-27T17:05:42  <wumpus> wanted: localization maintainer
4612018-02-27T17:06:29  <michagogo> There’s a Hebrew with >80% coverage, and a Hebrew (Israel) with <3%
4622018-02-27T17:06:40  <luke-jr> that sounds about right?
4632018-02-27T17:06:56  <michagogo> Well, that’s not really a division that makes sense AFAIK
4642018-02-27T17:06:57  <luke-jr> the Israel one would presumably just have strings that differ from the "standard" Hebrew
4652018-02-27T17:06:58  *** JackH has joined #bitcoin-core-dev
4662018-02-27T17:07:03  <luke-jr> oh
4672018-02-27T17:07:03  <wumpus> right.
4682018-02-27T17:07:15  *** grafcaps has joined #bitcoin-core-dev
4692018-02-27T17:07:25  <luke-jr> disclaimer: I know nothing about the Hebrew language or its variations :P
4702018-02-27T17:07:38  <michagogo> Actually, the Windows 10 setup process asks you that at some point
4712018-02-27T17:07:49  <michagogo> When you choose a keyboard layout
4722018-02-27T17:07:58  <michagogo> I have no clue what the difference is…
4732018-02-27T17:09:24  <esotericnonsense> i think I submitted a translation for en_GB vs en_US at some point
4742018-02-27T17:09:50  <esotericnonsense> and then realised that someone who actually cares about the distinction should do it
4752018-02-27T17:10:04  <esotericnonsense> what's the default en? !?!?!?!?! </trollface>
4762018-02-27T17:10:07  *** mehdi0x61 has quit IRC
4772018-02-27T17:10:55  <wumpus> US is the default
4782018-02-27T17:11:10  <wumpus> that's why it was wrong for a separate en_US translation to exist
4792018-02-27T17:12:33  <wumpus> en_UK would be a possible addition
4802018-02-27T17:12:44  <esotericnonsense> there is an en_GB
4812018-02-27T17:12:48  <esotericnonsense> or at least there was
4822018-02-27T17:13:16  <wumpus> ehh yes, GB
4832018-02-27T17:13:23  *** mehdi0x61 has joined #bitcoin-core-dev
4842018-02-27T17:13:58  <wumpus> Great Britain instead of United Kingdom, I guess a distinction like Holland versus The Netherlands
4852018-02-27T17:14:12  <michagogo> I don’t know about the latter
4862018-02-27T17:14:25  <michagogo> But it’s the United Kingdom of Great Britain and Northern Ireland
4872018-02-27T17:14:47  <esotericnonsense> in this context it doesn't make a difference because there's no 'locality' to the fact we spell a few words slightly differently other than 'generally on that island'
4882018-02-27T17:14:58  <wumpus> strictly, Holland is a part of the Netherlands, Zuid and Noord Holland, but everyone uses them interchangably in practice
4892018-02-27T17:15:11  <michagogo> So UK would make more sense than GB, but that’s not what the standards organizations decided
4902018-02-27T17:15:14  <esotericnonsense> do norwegians learn 'color' or 'colour'? :D
4912018-02-27T17:16:18  <esotericnonsense> i feel like i'm bikeshedding a thing that no-one actually cares about, but the idea of inheriting feels a bit odd to me
4922018-02-27T17:16:22  <michagogo> Hm, why is en_US the default and not bare en?
4932018-02-27T17:16:52  <michagogo> Oh, I guess if something isn’t defined in en then it’ll fall through to en_US
4942018-02-27T17:16:55  <wumpus> esotericnonsense: it's simply how localization tends to work, so there's no use bikeshedding that here
4952018-02-27T17:17:02  <michagogo> But why have bare en at all?
4962018-02-27T17:17:20  <esotericnonsense> heh. some dialogs with 'colour' and some with 'color'. *shudders*
4972018-02-27T17:17:23  <wumpus> bare en is the source language
4982018-02-27T17:17:25  * esotericnonsense wanders off to do something useful
4992018-02-27T17:17:36  <wumpus> it cannot be edited on transifex
5002018-02-27T17:17:41  <michagogo> Uh
5012018-02-27T17:17:47  <michagogo> Is source different from default
5022018-02-27T17:17:48  <michagogo> ?
5032018-02-27T17:18:06  <wumpus> it's the language that the messages in the source code are in
5042018-02-27T17:18:13  <michagogo> Right, makes sense
5052018-02-27T17:18:40  <michagogo> But why have the default be en_US, and not just not use a translation by default?
5062018-02-27T17:18:51  <michagogo> Oh, wait
5072018-02-27T17:18:59  <michagogo> That’s what we do, since we deleted en_US
5082018-02-27T17:19:03  <michagogo> Never mind.
5092018-02-27T17:21:43  *** Randolf has quit IRC
5102018-02-27T17:22:21  *** Randolf has joined #bitcoin-core-dev
5112018-02-27T17:22:31  *** arbitrary_guy has joined #bitcoin-core-dev
5122018-02-27T17:34:35  <wumpus> right, 'en' is not really a translation in our case, it only contains messages to be translated, no translations. There is no strict requirement that American English is the source language, it just happens to be the case for our project (and for many other projects).
5132018-02-27T17:35:33  *** timothy has quit IRC
5142018-02-27T17:36:27  *** Giszmo has quit IRC
5152018-02-27T17:41:12  *** bule has joined #bitcoin-core-dev
5162018-02-27T17:42:03  <luke-jr> wumpus: American English is? I thought standard English was, and that's why we have an en_US translation? :x
5172018-02-27T17:42:33  <wumpus> no, we don't have an en_US translation, that was a mistake
5182018-02-27T17:44:10  <wumpus> it was accidentally added for 0.16
5192018-02-27T17:44:18  <wumpus> and removed again, now
5202018-02-27T17:49:59  *** CubicEarths has joined #bitcoin-core-dev
5212018-02-27T17:50:28  <wumpus> the messages in the source code are American English (minimize, synchronize, etc), and that's what defines the source language
5222018-02-27T17:50:53  <wumpus> en_GB would be 'standard English'
5232018-02-27T17:52:15  *** shesek has joined #bitcoin-core-dev
5242018-02-27T17:52:24  *** Giszmo has joined #bitcoin-core-dev
5252018-02-27T17:56:32  *** mehdi0x61 has quit IRC
5262018-02-27T17:58:59  *** Amuza has quit IRC
5272018-02-27T18:05:24  *** bule has quit IRC
5282018-02-27T18:05:59  *** bule has joined #bitcoin-core-dev
5292018-02-27T18:06:53  *** Giszmo has quit IRC
5302018-02-27T18:08:49  *** mdrollette has joined #bitcoin-core-dev
5312018-02-27T18:09:44  *** alforro has quit IRC
5322018-02-27T18:10:27  *** MrPaz has quit IRC
5332018-02-27T18:11:34  *** MrPaz has joined #bitcoin-core-dev
5342018-02-27T18:22:14  *** larafale_ has quit IRC
5352018-02-27T18:22:28  *** kos__ has joined #bitcoin-core-dev
5362018-02-27T18:25:42  *** Emcy_ has joined #bitcoin-core-dev
5372018-02-27T18:26:41  *** Emcy has quit IRC
5382018-02-27T18:45:36  *** larafale has joined #bitcoin-core-dev
5392018-02-27T18:47:35  *** Jannie4Runolfsso has quit IRC
5402018-02-27T18:48:47  *** indistylo has joined #bitcoin-core-dev
5412018-02-27T19:04:35  *** larafale has quit IRC
5422018-02-27T19:05:08  *** larafale has joined #bitcoin-core-dev
5432018-02-27T19:06:05  *** mirese_ has joined #bitcoin-core-dev
5442018-02-27T19:08:57  *** mirese has quit IRC
5452018-02-27T19:09:27  *** larafale has quit IRC
5462018-02-27T19:09:39  *** mehdi0x61 has joined #bitcoin-core-dev
5472018-02-27T19:15:53  *** bule has quit IRC
5482018-02-27T19:16:41  *** bule has joined #bitcoin-core-dev
5492018-02-27T19:18:30  *** Murch has quit IRC
5502018-02-27T19:19:59  *** Murch has joined #bitcoin-core-dev
5512018-02-27T19:22:21  *** ProfMac has joined #bitcoin-core-dev
5522018-02-27T19:23:57  *** Randolf has quit IRC
5532018-02-27T19:30:58  *** larafale has joined #bitcoin-core-dev
5542018-02-27T19:32:41  *** Nona20Reilly has joined #bitcoin-core-dev
5552018-02-27T19:34:12  *** mehdi0x61 has quit IRC
5562018-02-27T19:37:24  *** Nona20Reilly has quit IRC
5572018-02-27T19:42:05  *** Victorsueca has quit IRC
5582018-02-27T19:43:18  *** Victorsueca has joined #bitcoin-core-dev
5592018-02-27T19:43:35  *** intcat has quit IRC
5602018-02-27T19:44:24  *** MrPaz has quit IRC
5612018-02-27T19:45:11  *** larafale has quit IRC
5622018-02-27T19:45:51  *** larafale has joined #bitcoin-core-dev
5632018-02-27T19:48:04  *** intcat has joined #bitcoin-core-dev
5642018-02-27T19:49:57  *** larafale has quit IRC
5652018-02-27T19:57:54  *** mehdi0x61 has joined #bitcoin-core-dev
5662018-02-27T20:03:52  *** intcat has quit IRC
5672018-02-27T20:05:08  *** intcat has joined #bitcoin-core-dev
5682018-02-27T20:09:33  *** bule has quit IRC
5692018-02-27T20:10:27  *** bule has joined #bitcoin-core-dev
5702018-02-27T20:11:53  *** shesek has quit IRC
5712018-02-27T20:13:41  *** jb55 has joined #bitcoin-core-dev
5722018-02-27T20:16:52  *** indistylo has quit IRC
5732018-02-27T20:30:29  *** jb55 has quit IRC
5742018-02-27T20:31:12  *** MrPaz has joined #bitcoin-core-dev
5752018-02-27T20:32:34  *** Sonia47Hammes has joined #bitcoin-core-dev
5762018-02-27T20:34:21  *** larafale has joined #bitcoin-core-dev
5772018-02-27T20:37:40  *** Sonia47Hammes has quit IRC
5782018-02-27T20:38:27  *** larafale has quit IRC
5792018-02-27T20:43:10  <bitcoin-git> [bitcoin] bedri opened pull request #12562: Utils and libraries: Leveldb compile warnings (master...leveldbCompileWarnings) https://github.com/bitcoin/bitcoin/pull/12562
5802018-02-27T20:49:18  *** Sentineo has joined #bitcoin-core-dev
5812018-02-27T20:51:39  *** mmgen has quit IRC
5822018-02-27T20:59:51  <eklitzke> i'm going to show my github ignorance here, but when a pull request gets merged, is the first comment on the PR (the one created by the PR author) what ends up in the git logs for the merge commit?
5832018-02-27T21:00:17  *** zrc has joined #bitcoin-core-dev
5842018-02-27T21:00:32  <achow101> eklitzke: we have our own github merging script that does that
5852018-02-27T21:00:59  <achow101> https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/github-merge.py
5862018-02-27T21:02:40  *** zrc has quit IRC
5872018-02-27T21:03:56  *** bule has quit IRC
5882018-02-27T21:03:58  *** SopaXorzTaker has quit IRC
5892018-02-27T21:05:00  *** bule has joined #bitcoin-core-dev
5902018-02-27T21:07:00  <eklitzke> ok i think i understand, the right side of the merge has the original commits with their descriptions intact, and the merge commit itself is autogenerated with the pull request title, first comment description, and a signature
5912018-02-27T21:11:00  <sipa> correct
5922018-02-27T21:16:07  *** bule has quit IRC
5932018-02-27T21:16:37  *** bule has joined #bitcoin-core-dev
5942018-02-27T21:23:26  *** larafale has joined #bitcoin-core-dev
5952018-02-27T21:31:24  *** droark has joined #bitcoin-core-dev
5962018-02-27T21:32:34  *** Cortney61Schimme has joined #bitcoin-core-dev
5972018-02-27T21:37:51  *** meshcollider has joined #bitcoin-core-dev
5982018-02-27T21:45:37  *** Cortney61Schimme has quit IRC
5992018-02-27T21:48:03  *** Chris_Stewart_5 has quit IRC
6002018-02-27T21:53:43  *** MrPaz has quit IRC
6012018-02-27T22:04:27  *** bule has quit IRC
6022018-02-27T22:05:03  *** bule has joined #bitcoin-core-dev
6032018-02-27T22:17:43  *** MrPaz has joined #bitcoin-core-dev
6042018-02-27T22:32:35  *** Leonora45Goldner has joined #bitcoin-core-dev
6052018-02-27T22:40:33  *** rex_4539 has joined #bitcoin-core-dev
6062018-02-27T22:43:07  *** Leonora45Goldner has quit IRC
6072018-02-27T22:47:21  *** mehdi0x61 has quit IRC
6082018-02-27T22:50:14  *** Victorsueca has quit IRC
6092018-02-27T22:51:45  *** Victorsueca has joined #bitcoin-core-dev
6102018-02-27T22:54:09  *** larafale has quit IRC
6112018-02-27T22:54:47  *** larafale has joined #bitcoin-core-dev
6122018-02-27T22:54:52  *** laurentmt has joined #bitcoin-core-dev
6132018-02-27T22:58:57  *** larafale has quit IRC
6142018-02-27T23:02:10  *** Cogito_Ergo_Sum has quit IRC
6152018-02-27T23:02:29  *** rongze has joined #bitcoin-core-dev
6162018-02-27T23:03:04  *** rongze has joined #bitcoin-core-dev
6172018-02-27T23:07:19  *** rongze has quit IRC
6182018-02-27T23:14:39  *** bule has quit IRC
6192018-02-27T23:15:02  *** wxss has quit IRC
6202018-02-27T23:15:16  *** bule has joined #bitcoin-core-dev
6212018-02-27T23:22:47  *** shesek has joined #bitcoin-core-dev
6222018-02-27T23:23:35  *** Guyver2 has quit IRC
6232018-02-27T23:32:31  *** Randolf has joined #bitcoin-core-dev
6242018-02-27T23:32:41  *** Lawson85Schimmel has joined #bitcoin-core-dev
6252018-02-27T23:35:20  *** laurentmt has quit IRC
6262018-02-27T23:35:59  *** vicenteH has quit IRC
6272018-02-27T23:41:19  <CubicEarths> Why does the client seem to only download blocks a certain distance ahead of what the CPU has processed?
6282018-02-27T23:43:57  *** rongze has joined #bitcoin-core-dev
6292018-02-27T23:44:37  *** rongze has joined #bitcoin-core-dev
6302018-02-27T23:44:44  <sipa> CubicEarths: to not interfere too much with pruning
6312018-02-27T23:46:55  <sipa> (if the blocks are too much out of order on disk, you need to wait very long before a file which can contain a block of blocks from everywhere can be deleted)
6322018-02-27T23:48:45  *** rongze has quit IRC
6332018-02-27T23:51:20  *** rex_4539 has quit IRC
6342018-02-27T23:51:39  <CubicEarths> I don't understand...  I can see reasons related to being a good citizen on the network, but you are saying it has to do with my own node's syncing performance?
6352018-02-27T23:52:31  <sipa> if you enable pruning, you delete block files which only have old blocks in them
6362018-02-27T23:52:48  <sipa> this is not possible if every block files contains blocks from all over the place
6372018-02-27T23:53:02  <CubicEarths> ahh
6382018-02-27T23:53:58  <sipa> by not letting downloading getting ahead too far of validation (1024 blocks ahead max), we guarantee that after 1024 blocks, you're always able to delete the old files with blocks before that point (plus some overhead blocks, i think 288, to not interfere with reorgs)
6392018-02-27T23:54:37  <sipa> it doesn't really matter if you don't prune and don't plan to ever do so
6402018-02-27T23:54:47  <CubicEarths> yeah
6412018-02-27T23:54:52  <sipa> but it also doesn't hurt you much to restrict yourself to 1024 blocks ahead
6422018-02-27T23:55:56  <CubicEarths> well, sometimes you are near great internet, and it would be nice to be able to download blocks as fast as possible, and allow the processing to happen later
6432018-02-27T23:56:54  <CubicEarths> I am surprised that blocks are not put in blockfiles according to the block number
6442018-02-27T23:57:28  <CubicEarths> But it sounds like the files are just filled up sequentially with blocks as the come in?
6452018-02-27T23:57:53  <bitcoin-git> [bitcoin] AkioNak closed pull request #11988: Reduce redundant code of prevector and speed it up (master...prevector) https://github.com/bitcoin/bitcoin/pull/11988
6462018-02-27T23:58:54  <aj> CubicEarths: if you had blocks 1000-2000 in a single file, then had hundreds of reorgs in that range, that particular file could grow absurdly large; likewise if all those blocks were empty, you'd end up with unnecessarily small files