1 2018-03-29T00:00:03  *** weez17 has quit IRC
  2 2018-03-29T00:00:40  *** weez17 has joined #bitcoin-core-dev
  3 2018-03-29T00:07:38  <aj> wow travis sure isn't behaving at its best this week
  4 2018-03-29T00:08:05  <Randolf> Is it just slow, or is it exhibiting some problems?
  5 2018-03-29T00:12:51  *** shesek` has quit IRC
  6 2018-03-29T00:13:23  *** shesek` has joined #bitcoin-core-dev
  7 2018-03-29T00:14:11  *** suldev has joined #bitcoin-core-dev
  8 2018-03-29T00:17:15  <aj> jnewbery: +1 on splitting up release-notes and combining in the rc-phase
  9 2018-03-29T00:19:49  <aj> Randolf: https://travis-ci.org/bitcoin/bitcoin/builds/359365323 failed badly, causing a bug to slip through into master that's only picked up in a travis-only (ish) test, causing travis to fail for all PRs after that, needing #12821 to fix
 10 2018-03-29T00:19:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
 11 2018-03-29T00:27:57  *** nitramiz has quit IRC
 12 2018-03-29T00:34:42  <Randolf> aj:  Have the folks in the #travis channel become aware of this?  I found them to be very helpful when I asked them a question a few weeks ago.
 13 2018-03-29T00:39:19  *** unholymachine has quit IRC
 14 2018-03-29T00:39:30  *** Murch has quit IRC
 15 2018-03-29T00:43:02  *** d9b4bef9 has quit IRC
 16 2018-03-29T00:44:08  *** d9b4bef9 has joined #bitcoin-core-dev
 17 2018-03-29T00:50:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 18 2018-03-29T01:00:46  *** Lauda has quit IRC
 19 2018-03-29T01:01:47  *** Chris_Stewart_5 has quit IRC
 20 2018-03-29T01:02:12  *** qinfengling has quit IRC
 21 2018-03-29T01:03:00  *** Lauda has joined #bitcoin-core-dev
 22 2018-03-29T01:05:12  *** qinfengling has joined #bitcoin-core-dev
 23 2018-03-29T01:15:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 24 2018-03-29T01:20:21  *** grafcaps has quit IRC
 25 2018-03-29T01:20:50  *** dafunkiz_ has joined #bitcoin-core-dev
 26 2018-03-29T01:28:28  *** rex4539 has joined #bitcoin-core-dev
 27 2018-03-29T01:35:32  *** dafunkiz_ has quit IRC
 28 2018-03-29T01:43:42  *** dafunkiz_ has joined #bitcoin-core-dev
 29 2018-03-29T01:47:37  *** grafcaps has joined #bitcoin-core-dev
 30 2018-03-29T01:58:14  *** AaronvanW has quit IRC
 31 2018-03-29T01:59:31  *** nitramiz has joined #bitcoin-core-dev
 32 2018-03-29T02:04:05  *** Chris_Stewart_5 has quit IRC
 33 2018-03-29T02:13:35  *** dafunkiz_ has quit IRC
 34 2018-03-29T02:16:18  *** dafunkiz_ has joined #bitcoin-core-dev
 35 2018-03-29T02:30:04  *** Evel-Knievel has quit IRC
 36 2018-03-29T02:30:47  *** Evel-Knievel has joined #bitcoin-core-dev
 37 2018-03-29T02:39:08  *** dafunkiz_ has quit IRC
 38 2018-03-29T02:44:35  *** dafunkiz_ has joined #bitcoin-core-dev
 39 2018-03-29T02:52:10  *** dafunkiz_ has quit IRC
 40 2018-03-29T02:52:49  *** arbitrary_guy has quit IRC
 41 2018-03-29T02:53:42  *** arbitrary_guy has joined #bitcoin-core-dev
 42 2018-03-29T02:57:27  *** belcher has quit IRC
 43 2018-03-29T03:03:35  *** rex4539 has quit IRC
 44 2018-03-29T03:07:21  *** da2ce7 has quit IRC
 45 2018-03-29T03:15:33  *** da2ce7 has joined #bitcoin-core-dev
 46 2018-03-29T03:23:32  *** Krellan has quit IRC
 47 2018-03-29T03:24:02  *** Krellan has joined #bitcoin-core-dev
 48 2018-03-29T03:43:34  *** suldev has quit IRC
 49 2018-03-29T03:48:08  *** derrekito_ has joined #bitcoin-core-dev
 50 2018-03-29T03:49:35  *** musalbas has quit IRC
 51 2018-03-29T03:50:25  *** Derrekito has quit IRC
 52 2018-03-29T03:51:34  *** musalbas has joined #bitcoin-core-dev
 53 2018-03-29T03:52:57  *** hirish has quit IRC
 54 2018-03-29T03:54:07  *** BashCo has joined #bitcoin-core-dev
 55 2018-03-29T03:55:06  *** hirish has joined #bitcoin-core-dev
 56 2018-03-29T03:55:34  *** BashCo_ has quit IRC
 57 2018-03-29T04:00:35  *** nitramiz has quit IRC
 58 2018-03-29T04:09:02  *** d9b4bef9 has quit IRC
 59 2018-03-29T04:10:08  *** d9b4bef9 has joined #bitcoin-core-dev
 60 2018-03-29T04:19:01  *** d9b4bef9 has quit IRC
 61 2018-03-29T04:20:09  *** d9b4bef9 has joined #bitcoin-core-dev
 62 2018-03-29T04:21:32  *** Samdney has quit IRC
 63 2018-03-29T04:24:46  *** justanotheruser has joined #bitcoin-core-dev
 64 2018-03-29T04:25:40  *** justanotheruser has joined #bitcoin-core-dev
 65 2018-03-29T04:25:51  *** goatpig has quit IRC
 66 2018-03-29T04:25:58  *** karimofthecrop has joined #bitcoin-core-dev
 67 2018-03-29T04:27:19  *** justan0theruser has quit IRC
 68 2018-03-29T04:27:24  *** Deadhand has quit IRC
 69 2018-03-29T04:41:37  <jtimon> sorry for not following up, but promag will take care of the second part he discovered, please let's move on with https://github.com/bitcoin/bitcoin/pull/12172 's from 58 comments anf +9-4 as it was supposed to be
 70 2018-03-29T04:53:50  <bitcoin-git> [bitcoin] jtimon closed pull request #11426: BIP90: Make buried deployments slightly more easily extensible (master...e16-bip90-extensible) https://github.com/bitcoin/bitcoin/pull/11426
 71 2018-03-29T04:55:48  *** indistylo has joined #bitcoin-core-dev
 72 2018-03-29T05:00:32  *** arubi has quit IRC
 73 2018-03-29T05:00:32  *** ghost43 has quit IRC
 74 2018-03-29T05:00:32  *** dermoth has quit IRC
 75 2018-03-29T05:01:27  *** arubi has joined #bitcoin-core-dev
 76 2018-03-29T05:05:20  *** r251d has quit IRC
 77 2018-03-29T05:05:44  *** r251d has joined #bitcoin-core-dev
 78 2018-03-29T05:06:38  *** Deadhand has joined #bitcoin-core-dev
 79 2018-03-29T05:08:46  *** baldur has quit IRC
 80 2018-03-29T05:10:35  *** suldev has joined #bitcoin-core-dev
 81 2018-03-29T05:15:24  *** arbitrary_guy has quit IRC
 82 2018-03-29T05:21:15  *** baldur has joined #bitcoin-core-dev
 83 2018-03-29T05:35:05  *** jtimon has quit IRC
 84 2018-03-29T05:37:53  *** aruns has joined #bitcoin-core-dev
 85 2018-03-29T05:40:48  *** indistylo has quit IRC
 86 2018-03-29T05:42:05  *** Soligor has quit IRC
 87 2018-03-29T05:46:07  *** Soligor has joined #bitcoin-core-dev
 88 2018-03-29T05:55:02  *** rex4539 has joined #bitcoin-core-dev
 89 2018-03-29T05:55:20  *** suldev has quit IRC
 90 2018-03-29T05:56:46  *** qinfengling has quit IRC
 91 2018-03-29T05:59:45  *** rex4539 has quit IRC
 92 2018-03-29T06:05:19  *** karimofthecrop has quit IRC
 93 2018-03-29T06:10:17  *** rex4539 has joined #bitcoin-core-dev
 94 2018-03-29T06:18:53  <bitcoin-git> [bitcoin] eklitzke opened pull request #12825: Only allocate a LevelDB block cache if LevelDB will actually use it (master...buffer-cache) https://github.com/bitcoin/bitcoin/pull/12825
 95 2018-03-29T06:38:29  *** fanquake has joined #bitcoin-core-dev
 96 2018-03-29T06:42:49  *** r251d has quit IRC
 97 2018-03-29T06:44:51  *** r251d has joined #bitcoin-core-dev
 98 2018-03-29T06:50:38  *** fanquake has quit IRC
 99 2018-03-29T07:00:40  *** lnostdal has joined #bitcoin-core-dev
100 2018-03-29T07:01:55  *** jtimon has joined #bitcoin-core-dev
101 2018-03-29T07:14:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
102 2018-03-29T07:14:22  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
103 2018-03-29T07:28:03  *** Cogito_Ergo_Sum has quit IRC
104 2018-03-29T07:40:39  *** JackH has quit IRC
105 2018-03-29T07:50:13  *** zarez has joined #bitcoin-core-dev
106 2018-03-29T07:52:05  *** andytoshi has quit IRC
107 2018-03-29T07:53:10  *** andytoshi has joined #bitcoin-core-dev
108 2018-03-29T07:53:17  *** JackH has joined #bitcoin-core-dev
109 2018-03-29T08:05:10  *** jtimon has quit IRC
110 2018-03-29T08:07:10  *** CubicEarths has quit IRC
111 2018-03-29T08:11:02  *** d9b4bef9 has quit IRC
112 2018-03-29T08:11:34  *** timothy has joined #bitcoin-core-dev
113 2018-03-29T08:12:09  *** d9b4bef9 has joined #bitcoin-core-dev
114 2018-03-29T08:12:54  *** aruns__ has joined #bitcoin-core-dev
115 2018-03-29T08:13:30  *** CubicEarths has joined #bitcoin-core-dev
116 2018-03-29T08:16:03  *** drizztbsd has joined #bitcoin-core-dev
117 2018-03-29T08:16:25  *** aruns has quit IRC
118 2018-03-29T08:17:02  *** timothy has quit IRC
119 2018-03-29T08:20:21  *** aruns has joined #bitcoin-core-dev
120 2018-03-29T08:22:35  *** aruns__ has quit IRC
121 2018-03-29T08:28:00  *** promag has joined #bitcoin-core-dev
122 2018-03-29T08:38:25  *** rls has quit IRC
123 2018-03-29T08:41:47  *** psyopp has joined #bitcoin-core-dev
124 2018-03-29T08:42:27  *** BashCo has quit IRC
125 2018-03-29T08:44:20  *** justanotheruser has quit IRC
126 2018-03-29T08:49:21  *** aruns has quit IRC
127 2018-03-29T08:49:45  *** BashCo has joined #bitcoin-core-dev
128 2018-03-29T08:50:13  *** SopaXorzTaker has joined #bitcoin-core-dev
129 2018-03-29T08:54:33  *** aruns has joined #bitcoin-core-dev
130 2018-03-29T09:00:49  *** JackH has quit IRC
131 2018-03-29T09:04:17  *** ohnx has quit IRC
132 2018-03-29T09:04:23  *** grafcaps has quit IRC
133 2018-03-29T09:07:10  *** ohnx has joined #bitcoin-core-dev
134 2018-03-29T09:07:25  *** aruns has quit IRC
135 2018-03-29T09:07:33  *** AaronvanW has joined #bitcoin-core-dev
136 2018-03-29T09:08:05  *** JackH has joined #bitcoin-core-dev
137 2018-03-29T09:08:06  *** aruns has joined #bitcoin-core-dev
138 2018-03-29T09:08:16  *** Aaronvan_ has joined #bitcoin-core-dev
139 2018-03-29T09:08:45  <murrayn> what's the best way of proceeding with this PR: https://github.com/bitcoin/bitcoin/pull/12809
140 2018-03-29T09:08:59  <murrayn> Have I messed it up by merging master into it?
141 2018-03-29T09:11:26  *** CubicEarths has quit IRC
142 2018-03-29T09:11:57  *** AaronvanW has quit IRC
143 2018-03-29T09:12:06  *** CubicEarths has joined #bitcoin-core-dev
144 2018-03-29T09:17:15  *** CubicEar_ has joined #bitcoin-core-dev
145 2018-03-29T09:17:55  <promag> murrayn: you should remove merge commit
146 2018-03-29T09:20:03  <promag> on that branch do git rebase -i HEAD~3
147 2018-03-29T09:20:12  *** CubicEarths has quit IRC
148 2018-03-29T09:20:20  <promag> then in the editor remove the line with the merge commit
149 2018-03-29T09:20:51  *** Victorsueca has quit IRC
150 2018-03-29T09:20:58  <promag> save and quit, git log to verify, then force git push
151 2018-03-29T09:21:56  <murrayn> there are a lot of lines, the merge is split into separate itms
152 2018-03-29T09:21:59  <murrayn> remove them all?
153 2018-03-29T09:22:03  *** Victorsueca has joined #bitcoin-core-dev
154 2018-03-29T09:22:36  <promag> murrayn: let me see
155 2018-03-29T09:22:45  <murrayn> i.e. just leave the original commit
156 2018-03-29T09:23:49  *** laurentmt has joined #bitcoin-core-dev
157 2018-03-29T09:24:48  <promag> well, you can do git reset --hard master, git cherry-pick 91c8756, git cherry-pick e133491
158 2018-03-29T09:25:01  <promag> but don't forget to git rebaes --abort first
159 2018-03-29T09:26:36  <murrayn> e133491 was a change to something in the merge commit. so omit it?
160 2018-03-29T09:29:21  <promag> yes
161 2018-03-29T09:30:04  <murrayn> ok here goes :-)
162 2018-03-29T09:31:23  <murrayn> so the i will need to merge the cherry-pick of 91c8756
163 2018-03-29T09:33:24  *** meshcollider has quit IRC
164 2018-03-29T09:35:09  <promag> what you mean by merge?
165 2018-03-29T09:35:41  <promag> you just have to cherry pick 91c8756 after git reset --hard master
166 2018-03-29T09:39:22  *** drizztbsd is now known as timothy
167 2018-03-29T09:40:47  *** laurentmt has quit IRC
168 2018-03-29T09:41:56  <murrayn> promag, i mean i need to resolve the conflicts
169 2018-03-29T09:43:51  *** lnostdal has quit IRC
170 2018-03-29T09:48:20  <murrayn> ok, resolved the 3 or 4 conflicts in src/init.cpp
171 2018-03-29T09:49:39  *** lnostdal has joined #bitcoin-core-dev
172 2018-03-29T09:50:28  <murrayn> promag, now what? just commit?
173 2018-03-29T09:50:37  *** AaronvanW has joined #bitcoin-core-dev
174 2018-03-29T09:50:49  <promag> murrayn: pm please
175 2018-03-29T09:50:59  <murrayn> ok thanks for your help
176 2018-03-29T09:53:38  *** Aaronvan_ has quit IRC
177 2018-03-29T09:55:27  *** lnostdal has quit IRC
178 2018-03-29T09:56:19  *** karimofthecrop has joined #bitcoin-core-dev
179 2018-03-29T09:59:36  *** lnostdal has joined #bitcoin-core-dev
180 2018-03-29T10:00:59  *** karimofthecrop has quit IRC
181 2018-03-29T10:12:50  *** Aaronvan_ has joined #bitcoin-core-dev
182 2018-03-29T10:16:02  *** AaronvanW has quit IRC
183 2018-03-29T10:24:37  *** wxss has joined #bitcoin-core-dev
184 2018-03-29T10:36:18  *** promag has quit IRC
185 2018-03-29T10:37:42  *** marcinja has joined #bitcoin-core-dev
186 2018-03-29T10:38:08  *** Strepsils has joined #bitcoin-core-dev
187 2018-03-29T10:40:47  *** marcinja has quit IRC
188 2018-03-29T10:41:22  *** Deinogalerix21 has joined #bitcoin-core-dev
189 2018-03-29T10:42:41  *** Deinogalerix21 has joined #bitcoin-core-dev
190 2018-03-29T10:49:41  *** karimofthecrop has joined #bitcoin-core-dev
191 2018-03-29T10:51:29  *** promag has joined #bitcoin-core-dev
192 2018-03-29T10:54:22  *** karimofthecrop has quit IRC
193 2018-03-29T10:59:03  *** StopAndDecrypt_ has quit IRC
194 2018-03-29T11:00:19  *** promag has quit IRC
195 2018-03-29T11:04:58  <bitcoin-git> [bitcoin] conscott opened pull request #12826: Fix lint error - making travis builds fail  (master...fix_lint_error) https://github.com/bitcoin/bitcoin/pull/12826
196 2018-03-29T11:05:59  <bitcoin-git> [bitcoin] fanquake closed pull request #12826: Fix lint error that is making travis builds fail  (master...fix_lint_error) https://github.com/bitcoin/bitcoin/pull/12826
197 2018-03-29T11:06:22  *** fanquake has joined #bitcoin-core-dev
198 2018-03-29T11:14:42  *** grafcaps has joined #bitcoin-core-dev
199 2018-03-29T11:17:38  *** anome has joined #bitcoin-core-dev
200 2018-03-29T11:19:34  *** grafcaps has quit IRC
201 2018-03-29T11:19:45  *** Strepsils has quit IRC
202 2018-03-29T11:23:45  *** Giszmo has quit IRC
203 2018-03-29T11:28:10  *** Deinogalerix21 has quit IRC
204 2018-03-29T11:34:53  *** StopAndDecrypt has joined #bitcoin-core-dev
205 2018-03-29T11:35:14  *** StopAndDecrypt has quit IRC
206 2018-03-29T11:35:14  *** StopAndDecrypt has joined #bitcoin-core-dev
207 2018-03-29T11:37:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
208 2018-03-29T11:37:34  *** Giszmo has joined #bitcoin-core-dev
209 2018-03-29T11:40:47  <bitcoin-git> [bitcoin] murrayn closed pull request #12809: Formatting changes to --help code for increased readability. (master...help_formatting) https://github.com/bitcoin/bitcoin/pull/12809
210 2018-03-29T11:42:04  *** anome has quit IRC
211 2018-03-29T12:04:02  *** suldev has joined #bitcoin-core-dev
212 2018-03-29T12:05:02  *** belcher has joined #bitcoin-core-dev
213 2018-03-29T12:05:27  <fanquake> wumpus/sipa are you around tonight? Be good to get #12821 in and get Travis back.
214 2018-03-29T12:05:28  <gribble> https://github.com/bitcoin/bitcoin/issues/12821 | contrib: Remove unused import string by MarcoFalke · Pull Request #12821 · bitcoin/bitcoin · GitHub
215 2018-03-29T12:13:22  <bitcoin-git> [bitcoin] matthias-g opened pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
216 2018-03-29T12:26:15  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/624bee96597c...082e26c08bb0
217 2018-03-29T12:26:15  <bitcoin-git> bitcoin/master 05120ee MarcoFalke: contrib: Remove unused import string
218 2018-03-29T12:26:16  <bitcoin-git> bitcoin/master 082e26c Wladimir J. van der Laan: Merge #12821: contrib: Remove unused import string...
219 2018-03-29T12:26:59  *** fanquake has quit IRC
220 2018-03-29T12:27:05  <bitcoin-git> [bitcoin] laanwj closed pull request #12821: contrib: Remove unused import string (master...Mf1803-contribUnusedImportClangFormatDiff) https://github.com/bitcoin/bitcoin/pull/12821
221 2018-03-29T12:27:53  *** Aaronvan_ has quit IRC
222 2018-03-29T12:28:28  *** AaronvanW has joined #bitcoin-core-dev
223 2018-03-29T12:30:37  *** Chris_Stewart_5 has quit IRC
224 2018-03-29T12:32:09  *** promag has joined #bitcoin-core-dev
225 2018-03-29T12:32:33  *** AaronvanW has quit IRC
226 2018-03-29T12:35:48  *** ghost43 has joined #bitcoin-core-dev
227 2018-03-29T12:47:42  *** promag has quit IRC
228 2018-03-29T12:52:33  *** AaronvanW has joined #bitcoin-core-dev
229 2018-03-29T12:56:38  *** fanquake has joined #bitcoin-core-dev
230 2018-03-29T12:59:17  <wumpus> fanquake: thanks
231 2018-03-29T12:59:50  <fanquake> wumpus no worries. I'll go restart a few tests
232 2018-03-29T13:01:23  <fanquake> Was also going to suggest #12495 for high-priority, but I see you've just approved it
233 2018-03-29T13:01:26  <gribble> https://github.com/bitcoin/bitcoin/issues/12495 | Increase LevelDB max_open_files by eklitzke · Pull Request #12495 · bitcoin/bitcoin · GitHub
234 2018-03-29T13:02:01  *** suldev has quit IRC
235 2018-03-29T13:03:10  <fanquake> Looks like #12787 is ready to go.
236 2018-03-29T13:03:12  <gribble> https://github.com/bitcoin/bitcoin/issues/12787 | rpc: Adjust ifdef to avoid unreachable code by practicalswift · Pull Request #12787 · bitcoin/bitcoin · GitHub
237 2018-03-29T13:04:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/082e26c08bb0...047865e8d188
238 2018-03-29T13:04:04  <bitcoin-git> bitcoin/master ccedbaf Evan Klitzke: Increase LevelDB max_open_files unless on 32-bit Unix....
239 2018-03-29T13:04:04  <bitcoin-git> bitcoin/master 047865e Wladimir J. van der Laan: Merge #12495: Increase LevelDB max_open_files...
240 2018-03-29T13:04:42  <bitcoin-git> [bitcoin] laanwj closed pull request #12495: Increase LevelDB max_open_files (master...ldb_max_open_files) https://github.com/bitcoin/bitcoin/pull/12495
241 2018-03-29T13:04:49  <fanquake> #12784 also
242 2018-03-29T13:04:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12784 | Fix bug in memory usage calculation (unintended integer division) by practicalswift · Pull Request #12784 · bitcoin/bitcoin · GitHub
243 2018-03-29T13:06:32  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/047865e8d188...cd99e5bdc8fc
244 2018-03-29T13:06:32  <bitcoin-git> bitcoin/master 61f8298 practicalswift: rpc: Adjust ifdef to avoid unreachable code
245 2018-03-29T13:06:33  <bitcoin-git> bitcoin/master cd99e5b Wladimir J. van der Laan: Merge #12787: rpc: Adjust ifdef to avoid unreachable code...
246 2018-03-29T13:07:25  <bitcoin-git> [bitcoin] laanwj closed pull request #12787: rpc: Adjust ifdef to avoid unreachable code (master...unreachable-code-ifdef-ENABLE_WALLET) https://github.com/bitcoin/bitcoin/pull/12787
247 2018-03-29T13:09:55  <fanquake> wumpus do you want to make a decision on #12767
248 2018-03-29T13:09:56  <gribble> https://github.com/bitcoin/bitcoin/issues/12767 | Initialize nVersionDummy to zero in deserialization code by practicalswift · Pull Request #12767 · bitcoin/bitcoin · GitHub
249 2018-03-29T13:12:14  *** goatpig has joined #bitcoin-core-dev
250 2018-03-29T13:13:00  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd99e5bdc8fc...e80716d3b324
251 2018-03-29T13:13:01  <bitcoin-git> bitcoin/master a16c6d2 practicalswift: Fix error in memory usage calculation (unintended integer division)
252 2018-03-29T13:13:01  <bitcoin-git> bitcoin/master e80716d Wladimir J. van der Laan: Merge #12784: Fix bug in memory usage calculation (unintended integer division)...
253 2018-03-29T13:13:50  <bitcoin-git> [bitcoin] laanwj closed pull request #12784: Fix bug in memory usage calculation (unintended integer division) (master...calc-error) https://github.com/bitcoin/bitcoin/pull/12784
254 2018-03-29T13:14:34  <fanquake> #12759 also looks like it's ready. The final nit can be handled another time.
255 2018-03-29T13:14:36  <gribble> https://github.com/bitcoin/bitcoin/issues/12759 | [Docs] Improve formatting of developer notes by eklitzke · Pull Request #12759 · bitcoin/bitcoin · GitHub
256 2018-03-29T13:16:53  *** tryphe_ has joined #bitcoin-core-dev
257 2018-03-29T13:19:01  *** tryphe has quit IRC
258 2018-03-29T13:20:55  <wumpus> fanquake: I'm not sure about #12767 - tend to agree with sipa. We shouldn't make unbridled changed to the code everywhere just to make broken static analysis tools happy. I have a similar problem with #12827.
259 2018-03-29T13:20:56  <gribble> https://github.com/bitcoin/bitcoin/issues/12767 | Initialize nVersionDummy to zero in deserialization code by practicalswift · Pull Request #12767 · bitcoin/bitcoin · GitHub
260 2018-03-29T13:20:57  <gribble> https://github.com/bitcoin/bitcoin/issues/12827 | Trivial: Dont use short version of tinyformat/fmt namespace by matthias-g · Pull Request #12827 · bitcoin/bitcoin · GitHub
261 2018-03-29T13:25:02  <bitcoin-git> [bitcoin] matthias-g closed pull request #12827: Trivial: Don't use short version of 'tinyformat/fmt' namespace (master...tinyformat-fmt) https://github.com/bitcoin/bitcoin/pull/12827
262 2018-03-29T13:26:21  *** Evel-Knievel has quit IRC
263 2018-03-29T13:26:59  <fanquake> wumpus heh, looks like the second issue was fixing a problem with a specific IDE?
264 2018-03-29T13:27:36  <wumpus> fanquake: apparently! I only now see it's an IDE, thought it was another analysis tool
265 2018-03-29T13:29:13  <wumpus> there are so many of those, and while they can be useful, they tend to have lots of false positives too. Most of the PRs resulting from them solve false positives, not actual problems found.
266 2018-03-29T13:31:00  <fanquake> Looks like #12790 can be merged.
267 2018-03-29T13:31:03  <gribble> https://github.com/bitcoin/bitcoin/issues/12790 | [Tests] Use blockmaxweight where tests previously had blockmaxsize by conscott · Pull Request #12790 · bitcoin/bitcoin · GitHub
268 2018-03-29T13:31:33  *** Randolf has quit IRC
269 2018-03-29T13:33:52  *** lukedashjr has joined #bitcoin-core-dev
270 2018-03-29T13:35:57  *** luke-jr has quit IRC
271 2018-03-29T13:36:01  <wumpus> fanquake: indeed
272 2018-03-29T13:36:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e80716d3b324...490644d29e64
273 2018-03-29T13:36:46  <bitcoin-git> bitcoin/master b466f6b Conor Scott: [Tests] Use blockmaxweight where tests previously had blockmaxsize
274 2018-03-29T13:36:47  <bitcoin-git> bitcoin/master 490644d Wladimir J. van der Laan: Merge #12790: [Tests] Use blockmaxweight where tests previously had blockmaxsize...
275 2018-03-29T13:37:36  <bitcoin-git> [bitcoin] laanwj closed pull request #12790: [Tests] Use blockmaxweight where tests previously had blockmaxsize (master...12768_remove_blockmaxsize) https://github.com/bitcoin/bitcoin/pull/12790
276 2018-03-29T13:38:20  *** lukedashjr is now known as luke-jr
277 2018-03-29T13:39:57  *** aruns has quit IRC
278 2018-03-29T13:40:24  <fanquake> wumpus also #12759 if you missed above.
279 2018-03-29T13:40:26  <gribble> https://github.com/bitcoin/bitcoin/issues/12759 | [Docs] Improve formatting of developer notes by eklitzke · Pull Request #12759 · bitcoin/bitcoin · GitHub
280 2018-03-29T13:42:25  <aj> wumpus: "our (or their or both)" is referring to --ours/--theirs/--union options respectively
281 2018-03-29T13:42:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
282 2018-03-29T13:42:45  *** AaronvanW has quit IRC
283 2018-03-29T13:43:20  *** AaronvanW has joined #bitcoin-core-dev
284 2018-03-29T13:44:43  <wumpus> fanquake: yep, still looking at that one
285 2018-03-29T13:45:20  *** jtimon has joined #bitcoin-core-dev
286 2018-03-29T13:46:05  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/490644d29e64...d3908e2cee65
287 2018-03-29T13:46:05  <bitcoin-git> bitcoin/master 0bd2ec5 Evan Klitzke: Improve formatting of developer notes...
288 2018-03-29T13:46:06  <bitcoin-git> bitcoin/master d3908e2 Wladimir J. van der Laan: Merge #12759: [Docs] Improve formatting of developer notes...
289 2018-03-29T13:46:56  <bitcoin-git> [bitcoin] laanwj closed pull request #12759: [Docs] Improve formatting of developer notes (master...developer-notes) https://github.com/bitcoin/bitcoin/pull/12759
290 2018-03-29T13:47:54  *** AaronvanW has quit IRC
291 2018-03-29T13:50:02  *** indistylo has joined #bitcoin-core-dev
292 2018-03-29T13:58:16  *** Guyver2 has joined #bitcoin-core-dev
293 2018-03-29T14:00:52  *** unholymachine has joined #bitcoin-core-dev
294 2018-03-29T14:04:17  *** moneyball has joined #bitcoin-core-dev
295 2018-03-29T14:05:00  *** moneyball has quit IRC
296 2018-03-29T14:06:51  <bitcoin-git> [bitcoin] practicalswift closed pull request #12789: Don't return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) (master...CExtKey-junk) https://github.com/bitcoin/bitcoin/pull/12789
297 2018-03-29T14:09:36  *** moneyball has joined #bitcoin-core-dev
298 2018-03-29T14:15:21  <jnewbery> wumpus: if you're on a merge spree, #10762 and #11773 look ready
299 2018-03-29T14:15:24  <gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
300 2018-03-29T14:15:26  <gribble> https://github.com/bitcoin/bitcoin/issues/11773 | [tests] Change feature_block.py to use BitcoinTestFramework by jnewbery · Pull Request #11773 · bitcoin/bitcoin · GitHub
301 2018-03-29T14:16:06  <wumpus> jnewbery: thanks, I'll have a look
302 2018-03-29T14:17:17  <jtimon> https://github.com/bitcoin/bitcoin/pull/12172 got acks, then people asked for more things and I started to work on that but we decided to leave them out at the end
303 2018-03-29T14:17:35  <bitcoin-git> [bitcoin] jnewbery opened pull request #12829: Python3 fixup (master...python3_fixup) https://github.com/bitcoin/bitcoin/pull/12829
304 2018-03-29T14:17:39  <jtimon> so it should be ready too, I think
305 2018-03-29T14:19:21  *** Randolf has joined #bitcoin-core-dev
306 2018-03-29T14:21:01  *** arubi has quit IRC
307 2018-03-29T14:21:30  *** arubi has joined #bitcoin-core-dev
308 2018-03-29T14:30:44  <jtimon> hmm, https://travis-ci.org/bitcoin/bitcoin/builds/359681523 seems stuck or something
309 2018-03-29T14:31:42  <wumpus> jtimon: looks like build 1 didn't even start yet?
310 2018-03-29T14:32:09  <jtimon> I tried cancelling the job and restarting it, but yeah, it didn't even start
311 2018-03-29T14:32:45  *** AaronvanW has joined #bitcoin-core-dev
312 2018-03-29T14:34:25  <wumpus> it's possible that it's hanging on a previous PR/build and cannot allocate a builder to that, yet
313 2018-03-29T14:34:46  <jnewbery> Perhaps we should just not update release-notes.md at all in individual PRs and just have the wiki page open from the beginning of the release cycle. PRs that require release notes can be tagged as requires_release_notes so we can verify that they all got done at the end of the cycle.
314 2018-03-29T14:34:52  <jnewbery> Maybe something to discuss in the meeting
315 2018-03-29T14:35:41  <wumpus> I'd never have expected the release notes to become a bottleneck. One positive thing about this is: people are writing release notes for their changes!
316 2018-03-29T14:36:22  *** Randolf has quit IRC
317 2018-03-29T14:36:23  <jnewbery> it's not a huge bottleneck, but it seems like a completely avoidable annoyance to have reviews invalidated by release-notes.md conflicts
318 2018-03-29T14:37:05  <wumpus> yes, a wiki might be better for this, though on the other hand, having the changed synced to merges makes sense
319 2018-03-29T14:37:12  <wumpus> changes*
320 2018-03-29T14:38:12  *** user989098 has joined #bitcoin-core-dev
321 2018-03-29T14:38:13  <jnewbery> yes, good point. Let's discuss in the meeting
322 2018-03-29T14:38:37  *** user989098 has quit IRC
323 2018-03-29T14:39:00  *** karimofthecrop has joined #bitcoin-core-dev
324 2018-03-29T14:39:59  *** shesek` has quit IRC
325 2018-03-29T14:42:47  <fanquake> Forgot it was meeting night tonight. Should probably make and effort to join.
326 2018-03-29T14:44:28  *** karimofthecrop has quit IRC
327 2018-03-29T14:47:26  <wumpus> that'd be cool, though I know it's not easy for that part of the world
328 2018-03-29T14:48:23  *** laurentmt has joined #bitcoin-core-dev
329 2018-03-29T14:48:42  *** zarez has quit IRC
330 2018-03-29T14:48:52  *** zarez has joined #bitcoin-core-dev
331 2018-03-29T14:50:43  *** shesek` has joined #bitcoin-core-dev
332 2018-03-29T14:50:56  *** Krellan has quit IRC
333 2018-03-29T14:51:35  *** Krellan has joined #bitcoin-core-dev
334 2018-03-29T14:57:54  *** Lightsword has quit IRC
335 2018-03-29T15:03:48  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3908e2cee65...6d53663a4339
336 2018-03-29T15:03:49  <bitcoin-git> bitcoin/master 5fb5421 John Newbery: [wallet] Move wallet init functions into WalletInit class.
337 2018-03-29T15:03:49  <bitcoin-git> bitcoin/master caaf972 John Newbery: [wallet] Create wallet init interface.
338 2018-03-29T15:03:50  <bitcoin-git> bitcoin/master 49baa4a John Newbery: [wallet] Use global g_wallet_init_interface to init/destroy the wallet....
339 2018-03-29T15:04:03  <bitcoin-git> [bitcoin] laanwj closed pull request #10762: [wallet] Remove Wallet dependencies from init.cpp (master...walletinit) https://github.com/bitcoin/bitcoin/pull/10762
340 2018-03-29T15:05:10  *** Chris_Stewart_5 has quit IRC
341 2018-03-29T15:06:09  *** psyopp has quit IRC
342 2018-03-29T15:09:01  *** Randolf has joined #bitcoin-core-dev
343 2018-03-29T15:16:50  *** zarez has quit IRC
344 2018-03-29T15:17:00  *** zarez has joined #bitcoin-core-dev
345 2018-03-29T15:17:46  <bitcoin-git> [bitcoin] jamesob opened pull request #12830: [qt] [tests] Clarify address book error messages, add tests (master...2018-03-27-send-recv-addressbook-error) https://github.com/bitcoin/bitcoin/pull/12830
346 2018-03-29T15:23:03  *** karimofthecrop has joined #bitcoin-core-dev
347 2018-03-29T15:28:00  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
348 2018-03-29T15:28:00  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
349 2018-03-29T15:29:12  *** juscamarena has joined #bitcoin-core-dev
350 2018-03-29T15:32:44  *** arbitrary_guy has joined #bitcoin-core-dev
351 2018-03-29T15:34:27  *** karimofthecrop has quit IRC
352 2018-03-29T15:36:11  *** bule has joined #bitcoin-core-dev
353 2018-03-29T15:36:20  *** indistylo has quit IRC
354 2018-03-29T15:36:21  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d53663a4339...f0f9732d05d7
355 2018-03-29T15:36:21  <bitcoin-git> bitcoin/master 5cd01d2 John Newbery: [tests] Fix flake8 warnings in feature_block.py
356 2018-03-29T15:36:22  <bitcoin-git> bitcoin/master 3898c4f John Newbery: [tests] Tidy up feature_block.py...
357 2018-03-29T15:36:22  <bitcoin-git> bitcoin/master fc02c12 John Newbery: [tests] Add logging to feature_block.py
358 2018-03-29T15:36:44  <bitcoin-git> [bitcoin] laanwj closed pull request #11773:  [tests] Change feature_block.py to use BitcoinTestFramework (master...refactor_p2pfullblocktest) https://github.com/bitcoin/bitcoin/pull/11773
359 2018-03-29T15:44:15  *** fanquake has quit IRC
360 2018-03-29T15:47:51  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12831: [WIP] Run unit tests in parallel (master...Mf1803-qaUnitParallel) https://github.com/bitcoin/bitcoin/pull/12831
361 2018-03-29T15:50:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
362 2018-03-29T15:55:13  *** moneyball has quit IRC
363 2018-03-29T15:56:46  *** zarez has quit IRC
364 2018-03-29T15:57:14  *** Randolf has quit IRC
365 2018-03-29T15:58:06  *** ProfMac has quit IRC
366 2018-03-29T15:59:38  *** ProfMac has joined #bitcoin-core-dev
367 2018-03-29T16:00:36  *** laurentmt has quit IRC
368 2018-03-29T16:06:22  *** JackH has quit IRC
369 2018-03-29T16:09:41  *** grafcaps has joined #bitcoin-core-dev
370 2018-03-29T16:13:50  *** ProfMac has quit IRC
371 2018-03-29T16:15:17  *** ProfMac has joined #bitcoin-core-dev
372 2018-03-29T16:32:42  *** harrymm has joined #bitcoin-core-dev
373 2018-03-29T16:37:27  *** suldev has joined #bitcoin-core-dev
374 2018-03-29T16:37:33  *** lnostdal has quit IRC
375 2018-03-29T16:39:45  *** tryphe_ has quit IRC
376 2018-03-29T16:40:11  *** tryphe_ has joined #bitcoin-core-dev
377 2018-03-29T16:52:30  *** AriseChikun has joined #bitcoin-core-dev
378 2018-03-29T16:53:22  *** pierre_rochard has joined #bitcoin-core-dev
379 2018-03-29T16:53:40  *** pierre_rochard has joined #bitcoin-core-dev
380 2018-03-29T16:56:06  *** rex4539 has quit IRC
381 2018-03-29T17:01:27  *** Murch has joined #bitcoin-core-dev
382 2018-03-29T17:09:06  *** tryphe_ has quit IRC
383 2018-03-29T17:09:33  *** tryphe_ has joined #bitcoin-core-dev
384 2018-03-29T17:11:55  *** Krellan has quit IRC
385 2018-03-29T17:15:39  *** Samdney has joined #bitcoin-core-dev
386 2018-03-29T17:22:57  *** moneyball has joined #bitcoin-core-dev
387 2018-03-29T17:26:56  *** timothy has quit IRC
388 2018-03-29T17:29:46  *** lnostdal has joined #bitcoin-core-dev
389 2018-03-29T17:31:45  *** suldev has quit IRC
390 2018-03-29T17:32:06  *** ProfMac has quit IRC
391 2018-03-29T17:34:28  *** ProfMac has joined #bitcoin-core-dev
392 2018-03-29T17:36:29  *** skeees has joined #bitcoin-core-dev
393 2018-03-29T17:37:27  *** lnostdal has quit IRC
394 2018-03-29T17:40:06  *** warren has quit IRC
395 2018-03-29T17:40:06  *** adam3us has quit IRC
396 2018-03-29T17:40:18  *** laurentmt has joined #bitcoin-core-dev
397 2018-03-29T17:47:43  *** Evel-Knievel has joined #bitcoin-core-dev
398 2018-03-29T17:47:53  *** laurentmt has quit IRC
399 2018-03-29T17:48:30  *** timothy has joined #bitcoin-core-dev
400 2018-03-29T17:49:10  *** timothy has quit IRC
401 2018-03-29T17:49:12  *** Chris_Stewart_5 has quit IRC
402 2018-03-29T17:49:19  *** lnostdal has joined #bitcoin-core-dev
403 2018-03-29T18:00:21  *** ProfMac has quit IRC
404 2018-03-29T18:02:14  <wumpus> wtf is up with travis: https://travis-ci.org/bitcoin/bitcoin/jobs/359847093  - looks like it creates a shallow clone, then tries to check out an older commit
405 2018-03-29T18:02:33  <wumpus> I think this happens before our own script kicks in
406 2018-03-29T18:06:35  *** lnostdal has quit IRC
407 2018-03-29T18:07:16  <arubi> wumpus, the config tab shows '"depth": 1'
408 2018-03-29T18:07:54  <arubi> so for some reason .travis.yml is set to that..?  weird
409 2018-03-29T18:09:48  <wumpus> but that's nothing new
410 2018-03-29T18:09:53  <ken2812221> Maybe this job must be auto-cancelled
411 2018-03-29T18:10:00  *** lnostdal has joined #bitcoin-core-dev
412 2018-03-29T18:10:50  <wumpus> depth was changed to 1 in fa79016ab0d23aa3d2c0322ab6be90b37dcd01c1, that's two week ago, not sure why it'd start giving problems now
413 2018-03-29T18:11:12  <wumpus> fa44af5cd2152a21da9ef3e48c073a668bf2df27 added depth: false
414 2018-03-29T18:11:23  <arubi> hm
415 2018-03-29T18:11:25  <wumpus> (feb 10)
416 2018-03-29T18:11:32  <wumpus> before that, we had no depth defined in the yml
417 2018-03-29T18:17:44  <wumpus> (which effectively means depth=1 IIRC)
418 2018-03-29T18:19:54  <arubi> it's 50 I think
419 2018-03-29T18:24:28  <wumpus> so maybe it'd be better to remove the depth specification and leave it up to travis again
420 2018-03-29T18:25:57  <wumpus> on the other hand, this way it spends less time building old master commits :-)
421 2018-03-29T18:34:13  *** skypper has joined #bitcoin-core-dev
422 2018-03-29T18:40:16  *** moneyball has quit IRC
423 2018-03-29T18:41:45  *** ProfMac has joined #bitcoin-core-dev
424 2018-03-29T18:47:03  *** moneyball has joined #bitcoin-core-dev
425 2018-03-29T18:49:10  *** nitramiz has joined #bitcoin-core-dev
426 2018-03-29T18:58:50  *** CubicEar_ has quit IRC
427 2018-03-29T18:59:19  *** CubicEarths has joined #bitcoin-core-dev
428 2018-03-29T19:00:09  *** Victorsueca has quit IRC
429 2018-03-29T19:00:43  <sipa> meeting time?
430 2018-03-29T19:00:48  <jnewbery> hello
431 2018-03-29T19:01:06  <eklitzke> hi
432 2018-03-29T19:01:14  <provoostenator> hi
433 2018-03-29T19:01:27  <bitcoin-git> [bitcoin] Sjors opened pull request #12833: WIP [qt] move QSettings to bitcoin.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
434 2018-03-29T19:01:28  *** Victorsueca has joined #bitcoin-core-dev
435 2018-03-29T19:01:50  <achow101> meting?
436 2018-03-29T19:02:06  <sipa> meeting, me think
437 2018-03-29T19:02:14  <jamesob_> yo
438 2018-03-29T19:03:30  <sipa> wumpus: ?
439 2018-03-29T19:03:37  <jimpo> hi
440 2018-03-29T19:03:52  <wumpus> #startmeeting
441 2018-03-29T19:03:52  <lightningbot> Meeting started Thu Mar 29 19:03:52 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
442 2018-03-29T19:03:52  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
443 2018-03-29T19:03:56  <BlueMatt> my high-priority: #11775 (yay, I have one again)
444 2018-03-29T19:03:58  <gribble> https://github.com/bitcoin/bitcoin/issues/11775 | Move fee estimator into validationinterface/cscheduler thread by TheBlueMatt · Pull Request #11775 · bitcoin/bitcoin · GitHub
445 2018-03-29T19:04:04  <wumpus> (DST sucks)
446 2018-03-29T19:04:24  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
447 2018-03-29T19:04:37  <kanzure> hi.
448 2018-03-29T19:04:39  <cfields> hi
449 2018-03-29T19:05:21  <wumpus> #topic high priority for review
450 2018-03-29T19:05:39  *** bule has quit IRC
451 2018-03-29T19:05:42  <jnewbery> BlueMatt: needs rebase again. Sorry!
452 2018-03-29T19:05:42  <wumpus> BlueMatt: added
453 2018-03-29T19:05:59  <instagibbs> hi
454 2018-03-29T19:06:15  <BlueMatt> jnewbery: well its a trivial rebase that shouldnt materially effect review
455 2018-03-29T19:06:21  <jamesob_> I'd like to nominate ryanofsky's #10244. The burden of rebasing/conflict resolution is high and I think it's in pretty good shape (though needs rebase atm).
456 2018-03-29T19:06:25  <gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
457 2018-03-29T19:06:37  <provoostenator> agreed
458 2018-03-29T19:06:53  <BlueMatt> can we make that a topic? I'd like to discuss it in more depth
459 2018-03-29T19:07:12  <BlueMatt> (10244, that is)
460 2018-03-29T19:07:24  <jnewbery> +1. Seems to be getting some review traction. It'd be a shame for that to go to waste
461 2018-03-29T19:07:44  <wumpus> #topic separate gui from wallet and node  (#10244)
462 2018-03-29T19:07:48  <gribble> https://github.com/bitcoin/bitcoin/issues/10244 | Refactor: separate gui from wallet and node by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
463 2018-03-29T19:08:34  <ryanofsky> did you have a question BlueMatt?
464 2018-03-29T19:08:38  <BlueMatt> yea, sec
465 2018-03-29T19:09:02  <wumpus> I've... already said everything I wanted to said about that, won't repeat myself
466 2018-03-29T19:09:18  <BlueMatt> so I guess I'm more of a fan of this than the wallet/main split, but I feel like we need to think a bit harder about the api between the gui/wallet+main before we go split it
467 2018-03-29T19:09:30  <BlueMatt> I mean some of these things maybe shouldnt be blocking calls
468 2018-03-29T19:09:40  <wumpus> TBH we discussed this at the new york meeting
469 2018-03-29T19:09:52  <wumpus> and the agreement was that this could be improved after it goes in
470 2018-03-29T19:09:57  <BlueMatt> ok, well I will shut up, then, if its been beaten to death
471 2018-03-29T19:09:59  <BlueMatt> ok, nvm
472 2018-03-29T19:10:12  <wumpus> I'm ok with that. I'd have preferred to make the GUI asynchronous first
473 2018-03-29T19:10:20  <wumpus> but Iom' not going to beat that topic to death
474 2018-03-29T19:10:21  <wumpus> right
475 2018-03-29T19:10:25  <ryanofsky> api is definitely meant to be improved, especially the init stuff which is pretty ugly
476 2018-03-29T19:10:32  <kanzure> are there any big blockers to asynchronous gui things?
477 2018-03-29T19:10:38  <BlueMatt> yea, I mean that was what I was gonna say, but if there was agreement its not worth re-opening the book on that to discuss
478 2018-03-29T19:10:42  <wumpus> no, it's just a different set of work
479 2018-03-29T19:11:21  <wumpus> it's somewhat orthogonal to this - my gut just hates blocking RPC calls in GUI threads, it's more of an instinctive revulsion than anything I can explain, so I'll just go along
480 2018-03-29T19:11:39  <jamesob_> this PR introduces no RPC calls
481 2018-03-29T19:11:47  <provoostenator> I think part of the understanding was that this interface should be considered very much not final.
482 2018-03-29T19:11:53  <BlueMatt> jamesob_: it introduces a whole new rpc interface...
483 2018-03-29T19:11:57  <wumpus> it does, it introduces an RPC layer between the wallet and the core
484 2018-03-29T19:12:03  <provoostenator> Just having _an_ interface was step one.
485 2018-03-29T19:12:06  <wumpus> please don't deny that
486 2018-03-29T19:12:12  <BlueMatt> anyway, next topic?
487 2018-03-29T19:12:22  <wumpus> yes, any other topic suggestions?
488 2018-03-29T19:12:33  <sipa> wumpus: i think jamesob_ means RPC as in the existing JSON RPC system
489 2018-03-29T19:12:40  <sipa> not RPC as a generic term
490 2018-03-29T19:12:50  <jamesob_> correct
491 2018-03-29T19:12:56  <wumpus> ok, yes, RPC is a general term for cross-process calls
492 2018-03-29T19:13:14  <ryanofsky> jamesob_, an earlier version of this pr did mention ipc, but i took that stuff out
493 2018-03-29T19:13:15  <jnewbery> This first step isn't cross-process
494 2018-03-29T19:13:40  <BlueMatt> lol, ok, so any topics *aside* from debating rpc/ipc/whatever terminology?
495 2018-03-29T19:13:44  <wumpus> yes...
496 2018-03-29T19:14:12  <jnewbery> topic suggestion (quick one): release notes conflicts
497 2018-03-29T19:14:36  <wumpus> #topic release notes conflicts
498 2018-03-29T19:14:41  <jnewbery> I don't think it's a major issue, but it is irritating to have reviews invalidated due to release notes conflicts
499 2018-03-29T19:14:57  <jnewbery> options: 1) do nothing because it's not a huge issue
500 2018-03-29T19:14:58  <wumpus> could do them in a separate commit, at the end
501 2018-03-29T19:15:10  <sipa> do we know if githubdeals correctly with the gitattributes merge=union stuff?
502 2018-03-29T19:15:14  <wumpus> oh wait that doesn't help with rebases...
503 2018-03-29T19:15:18  <achow101> Maybe we should have the release notes dev wiki thing continuously up and people just add stuff to it as needed
504 2018-03-29T19:15:33  <jnewbery> 2) don't use release_notes.md and just use a wiki for the whole release cycle
505 2018-03-29T19:15:46  <jnewbery> 3) have separate release_notes files for each PR and merge them at the end
506 2018-03-29T19:15:48  <BlueMatt> I mean as long as its a separate commit no reason to invalidate reviews
507 2018-03-29T19:15:49  <jnewbery> 4) ?
508 2018-03-29T19:16:16  <sipa> 4) is the merge=union thing?
509 2018-03-29T19:16:29  <jnewbery> merge=union doesn't help with github I think
510 2018-03-29T19:16:33  <achow101> I prefer 2
511 2018-03-29T19:16:41  <sipa> i don't like 2
512 2018-03-29T19:16:47  <sipa> too much process overhead
513 2018-03-29T19:16:55  <wumpus> achow101: I think the only argument against 2 is that it decouples the merge from the release mode update
514 2018-03-29T19:17:01  <wumpus> notes*
515 2018-03-29T19:17:06  <ryanofsky> an option 4) would be to insert 50-100 blank lines in the file, and add release new notes in the blank space. this would avoid most conflicts
516 2018-03-29T19:17:10  <jnewbery> sipa: https://github.com/isaacs/github/issues/487
517 2018-03-29T19:17:14  <cfields> outside the box: notes can be added as individual files and aggregated at the end
518 2018-03-29T19:17:23  <wumpus> so the author of the PR has to update the wiki after their thing was merged
519 2018-03-29T19:17:25  <sipa> jnewbery: right, but we also.don't really use github for merges
520 2018-03-29T19:17:30  <wumpus> cfields: unless they somehow interact :)
521 2018-03-29T19:17:38  <sipa> i mean more... how does it affect our github merge scriot etc
522 2018-03-29T19:17:41  <jnewbery> cfields: I think that's 3
523 2018-03-29T19:17:45  <sipa> which compares with the github merge
524 2018-03-29T19:17:55  <instagibbs> sipa, would be annoying to see conflict on GUI and just hope it's a merge we can avoid directly handling
525 2018-03-29T19:18:06  <sipa> instagibbs: fair
526 2018-03-29T19:18:07  <cfields> jnewbery: ah yes, missed 3.
527 2018-03-29T19:18:11  <sipa> i think my preference is 3
528 2018-03-29T19:18:15  <wumpus> cfields: I mean, sometimes an update to the release notes updates/extends earlier text - though
529 2018-03-29T19:18:15  <sdaftuar> i like 3 too
530 2018-03-29T19:18:17  <instagibbs> maybe i need to learn that tool better, might give a better view of it
531 2018-03-29T19:18:17  <ryanofsky> link describing option 4: https://about.gitlab.com/2015/02/10/gitlab-reduced-merge-conflicts-by-90-percent-with-changelog-placeholders/
532 2018-03-29T19:18:17  <jamesob_> I like 3
533 2018-03-29T19:18:30  <BlueMatt> option n) leave release notes as a comment on pr and tag the release-notes-needed issue
534 2018-03-29T19:18:31  <wumpus> cfields: storing it *per section* would still help!
535 2018-03-29T19:18:32  <BlueMatt> easy to merge at the end
536 2018-03-29T19:18:37  <BlueMatt> and they exist in the pr itself
537 2018-03-29T19:18:44  <ryanofsky> i also like 3 best
538 2018-03-29T19:19:04  <wumpus> 'leave it to the maintainer at the end' is not an option :p
539 2018-03-29T19:19:23  <sipa> it may be a release notes file per "feature" too, i think, if multiple PRs sequentially update the se thing
540 2018-03-29T19:19:41  <jnewbery> sipa: sounds reasonable, if they're serial
541 2018-03-29T19:19:46  <sipa> right
542 2018-03-29T19:19:55  <jimpo> Yeah, I like the idea of basically having a file for each section in the current release notes
543 2018-03-29T19:19:59  <wumpus> I mean what you want to avoid is that *unrelated* PRs collide in the release notes
544 2018-03-29T19:20:17  <sipa> wumpus: yyp
545 2018-03-29T19:20:23  <wumpus> if PRs that already affect the same thing collide, that's not too bad, because the code likely does too
546 2018-03-29T19:21:05  *** phantomcircuit has quit IRC
547 2018-03-29T19:21:30  *** Murchone has joined #bitcoin-core-dev
548 2018-03-29T19:22:37  <wumpus> so yes, 3 sounds like a good idea to me, though it might be overdesign for something that doesn't cause too much trouble in practice, I wonder if anyone will actually do it
549 2018-03-29T19:23:06  <sipa> we can see how it plays out
550 2018-03-29T19:23:11  <jnewbery> if it's in the developer notes, then I think people will do it
551 2018-03-29T19:23:22  <jnewbery> I'll do it for my PRs to avoid conflicts
552 2018-03-29T19:24:04  <jamesob_> could add a lint step to the build that fails if the PR touches the main release notes files as well as src/ files
553 2018-03-29T19:24:04  <wumpus> definitely needs to be in the developer notes, like "what directory to use for partial release notes'
554 2018-03-29T19:24:11  <wumpus> oh no no more lints
555 2018-03-29T19:24:31  <jnewbery> I think that's probably enough discussion. As long as the maintainers don't object to partial release notes then individual contributors can start using them
556 2018-03-29T19:24:36  *** Murch has quit IRC
557 2018-03-29T19:24:38  <wumpus> I get quite angry if yet another redundant python import breaks travis
558 2018-03-29T19:24:53  <jamesob_> suggestion retracted :)
559 2018-03-29T19:24:59  <instagibbs> I don't even think there's contribution notes yet
560 2018-03-29T19:25:03  <instagibbs> for release notes
561 2018-03-29T19:25:07  <wumpus> jamesob_: sorry :)
562 2018-03-29T19:25:09  <instagibbs> i had to ask promag
563 2018-03-29T19:25:14  <jnewbery> wumpus: is that not caught in the PR's travis run?
564 2018-03-29T19:25:16  *** Murch has joined #bitcoin-core-dev
565 2018-03-29T19:25:27  <wumpus> jnewbery: I think it is
566 2018-03-29T19:26:56  <sipa> topic suggestion: avoid undefined behaviour when it shouldn't matter? (#12789)
567 2018-03-29T19:26:58  <gribble> https://github.com/bitcoin/bitcoin/issues/12789 | Dont return a CExtPubKey filled with random data when DecodeExt{Pub,}Key is given input not passing DecodeBase58Check(...) by practicalswift · Pull Request #12789 · bitcoin/bitcoin · GitHub
568 2018-03-29T19:27:11  <wumpus> #topic avoid undefined behaviour when it shouldn't matter?
569 2018-03-29T19:27:18  <jtimon> ryanofsky: why not just create a separated pr editing the release notes after the actual pr doing things has been merged?
570 2018-03-29T19:27:31  <BlueMatt> "shouldnt"
571 2018-03-29T19:27:36  <sipa> i bring it up here because it may be something we should or shouldn't have as a guideline
572 2018-03-29T19:28:10  <sipa> for example,  should you initialize a variable that isn't read anywhere, because soke compiler warning fails to understand it isn't being read?
573 2018-03-29T19:28:22  <sipa> argument in favor: more deterministic failures
574 2018-03-29T19:28:24  <BlueMatt> oh, well that isnt "shouldnt"
575 2018-03-29T19:28:35  <BlueMatt> that is "doesnt, but compiler warns"
576 2018-03-29T19:28:38  <sipa> argument against: reduces the ability for tools to detect things stativally
577 2018-03-29T19:29:03  <provoostenator> Other argument in favor: means a linter can catch all uninitialized variables.
578 2018-03-29T19:29:04  <sipa> well i say shouldn't, because reviewers may be wrong and the compiler may be right
579 2018-03-29T19:29:08  <wumpus> jtimon: that's a possibility too, though like the wiki option it decouples the code change from the release notes change itselff
580 2018-03-29T19:29:10  *** Murchone has quit IRC
581 2018-03-29T19:29:25  <wumpus> jtimon: also: EVEN MORE PRs :(
582 2018-03-29T19:29:36  <jtimon> wumpus: yep, although I guess the bigger drawback is more prs
583 2018-03-29T19:29:38  <jtimon> right
584 2018-03-29T19:29:43  <BlueMatt> I mean if its at all tricky to show that it *wont* be read, then should def follow the compiler, but the nonstop stream of "this compiler is shit and warned on something that it shouldnt be" prs is....not ideal
585 2018-03-29T19:30:02  <wumpus> yeah...
586 2018-03-29T19:30:24  <BlueMatt> honestly of all those pros/cons, the pr volume is probably the most important imnsho
587 2018-03-29T19:30:26  <wumpus> so many *fix some and some false positive for my crappy static analysis tool/compiler with warnings jacked up*
588 2018-03-29T19:30:37  <sipa> i generally dislike the "compiler/analyzer/linter/tool doesn't understand X, let's initialize everything to shut it up"
589 2018-03-29T19:30:43  <wumpus> me too
590 2018-03-29T19:30:48  <wumpus> just fix your tools FFS
591 2018-03-29T19:30:59  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12823:  doc: Switch release-notes.md to union merge  (master...Mf1803-docGitattributes) https://github.com/bitcoin/bitcoin/pull/12823
592 2018-03-29T19:31:18  <wumpus> if it's correct, human-understandable C++ code and we know there's no problems with it, it should not be changes because compiler blabla
593 2018-03-29T19:31:31  <wumpus> too risky, too
594 2018-03-29T19:31:31  <sipa> or improve the code so it is easier for tools (and humans) to see it is correct
595 2018-03-29T19:31:42  <wumpus> if it's not broken don't change it
596 2018-03-29T19:31:47  <sipa> true
597 2018-03-29T19:31:56  <sipa> ok, just wanted to hear opinions about this
598 2018-03-29T19:32:11  <wumpus> unless it's a refactor to prepare for osmething else, of course, but that wasn't the premise :)
599 2018-03-29T19:32:51  <wumpus> so I think we agree
600 2018-03-29T19:32:56  <sipa> yes
601 2018-03-29T19:32:59  <wumpus> any other topics?
602 2018-03-29T19:33:49  <jtimon> BlueMatt: I don't know, will more volume of prs specific to release notes be that much more cumbersome?
603 2018-03-29T19:34:06  *** Murch has quit IRC
604 2018-03-29T19:34:07  <wumpus> jtimon: yes. In that case I prefer the wiki
605 2018-03-29T19:34:10  <BlueMatt> less so than code-change pr volume
606 2018-03-29T19:34:15  <BlueMatt> but whatever
607 2018-03-29T19:34:25  <jnewbery> wumpus: I agree
608 2018-03-29T19:34:32  <wumpus> that's why we have the wiki-phase at all before releases, to prevent a jungle of update-release-notes PRs
609 2018-03-29T19:34:33  <jtimon> yeah, I mean, I don't have a strong opinion either way
610 2018-03-29T19:34:51  <wumpus> (which will also conflict with each other! though easier to rebase..)
611 2018-03-29T19:35:05  <ryanofsky> jtimon, imo including release notes along with changes makes changes easier to understand, and also probably more well thought out
612 2018-03-29T19:35:07  <wumpus> yes, it's better than code-change PR volume that's for sure
613 2018-03-29T19:35:17  <wumpus> ryanofsky: hey that's a good point
614 2018-03-29T19:36:19  <jtimon> sipa: sometimes warning are useful, sometimes they are not and it's alright to leave them there. but not sure what the discussion is. nobody is proposing we use -Werror, right?
615 2018-03-29T19:36:33  <wumpus> I remember seeing the 'release notes per item' before in some project, not sure which
616 2018-03-29T19:36:59  <jtimon> ryanofsky: I agree, but then you have to deal with rebases, I don't see a way around it
617 2018-03-29T19:37:24  <wumpus> jtimon: warning being good or evil wasn't what the topic was about
618 2018-03-29T19:37:45  <sipa> jtimon: my view is (for example) that if you systemativally initialize every variable (even those for which you know won't be used), you will lose the ability for the compiler to give you warnings about accidentially uninitialized things
619 2018-03-29T19:38:05  <jtimon> wumpus: that's what I'm saying, that I'm not sure what the topic is
620 2018-03-29T19:38:15  <sipa> this is more general than just compiler warnings, and variable initialization though
621 2018-03-29T19:38:29  <wumpus> at ASML we had that as part of the C coding standard - every, single, variable had to be initialized
622 2018-03-29T19:38:41  <wumpus> no I don't think we need that here :)
623 2018-03-29T19:38:44  *** SopaXorzTaker has quit IRC
624 2018-03-29T19:39:44  <cfields> sipa: yes, i really like newer gcc/clang's ability to warn about being unitialized for one or more paths
625 2018-03-29T19:40:27  <wumpus> I do think all class variables should be initialized in the constructor, in general
626 2018-03-29T19:40:43  *** juscamarena has quit IRC
627 2018-03-29T19:41:50  <cfields> wumpus: agreed, but I'd like to start using more c++11 member-initialization for trivial types as it's so much less verbose
628 2018-03-29T19:41:51  <wumpus> cfields: they had that in the static analyzer for quite a while, now it moved to a compiler warning, a good thing
629 2018-03-29T19:42:16  <cfields> right
630 2018-03-29T19:42:53  *** Murch has joined #bitcoin-core-dev
631 2018-03-29T19:42:54  <wumpus> cfields: yes, that's a nicer syntax
632 2018-03-29T19:43:43  <wumpus> ok, any other topics?
633 2018-03-29T19:44:23  <sipa> seems not
634 2018-03-29T19:44:25  <wumpus> #endmeeting
635 2018-03-29T19:44:25  <lightningbot> Meeting ended Thu Mar 29 19:44:25 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
636 2018-03-29T19:44:25  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.html
637 2018-03-29T19:44:25  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.txt
638 2018-03-29T19:44:25  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-29-19.03.log.html
639 2018-03-29T19:46:21  *** dafunkiz_ has joined #bitcoin-core-dev
640 2018-03-29T19:48:35  *** jamesob_ has quit IRC
641 2018-03-29T19:57:39  <cfields> out of curiosity, does the c spec allow for compilers to ignore initializers if a value is always set before it's used?
642 2018-03-29T19:58:06  <wumpus> only if there are no side effects
643 2018-03-29T19:58:13  <cfields> i'm wondering if compilers are allowed to do the opposite optimization: you always initialize, but it removes them when possible.
644 2018-03-29T19:58:54  <BlueMatt> the compiler could run any obvious part of your program and just change the program to have the same effective in/out results, so....yes?
645 2018-03-29T19:59:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
646 2018-03-29T19:59:07  <wumpus> ^^
647 2018-03-29T19:59:27  <BlueMatt> see-also: crypto-memset
648 2018-03-29T19:59:48  <wumpus> the C spec wouldn't say anything on that, because it's not visible to the code in any path
649 2018-03-29T19:59:50  <luke-jr> ETA until compilers try to do IBD for you?
650 2018-03-29T19:59:54  <luke-jr> ☺
651 2018-03-29T20:00:14  <BlueMatt> luke-jr: they'll fail on the first net access :(
652 2018-03-29T20:00:32  <luke-jr> BlueMatt: yes, I'm joking :P
653 2018-03-29T20:01:06  <wumpus> luke-jr: only if you manage to do blockvalidation in c++78 metaprogramming
654 2018-03-29T20:01:54  <wumpus> (or maybe it's already possible with current standards, at least compile time hashing is already possible :-)
655 2018-03-29T20:02:39  <cfields> heh
656 2018-03-29T20:03:28  <BlueMatt> rust has a fucking full ast interpreter in the front-end compiler now, to in the future run anything with no io as a constexpr.......
657 2018-03-29T20:05:31  <wumpus> that's an interesting choice
658 2018-03-29T20:05:59  <BlueMatt> or, well, thats a possible future use for it, but they have an interpreter in the front-end
659 2018-03-29T20:06:07  <wumpus> the drawback with c++ compile-time metaprogramming has always been that it's really slow, as it's circuitous because it (ab)uses features meant for something else. So, why not just include an ast interpreter.
660 2018-03-29T20:06:36  <wumpus> (compile-time slow, I mean)
661 2018-03-29T20:09:21  <wumpus> so apparently the Tor project is working on porting parts to rust
662 2018-03-29T20:12:03  <wumpus> not sure what parts, but it has always been an exclusively C codebase before
663 2018-03-29T20:12:09  <booyah> also, what for
664 2018-03-29T20:12:19  *** lnostdal has quit IRC
665 2018-03-29T20:12:32  <booyah> after decades it's probably rather safe from low-level errors, isn't it
666 2018-03-29T20:12:39  <wumpus> hehe :)
667 2018-03-29T20:12:49  <wumpus> that's anyone's guess, really
668 2018-03-29T20:13:00  <BlueMatt> seems premature tbh to me, mostly cause if you want to, eg, compile it on debian stable you have to use a super-old version of rust and end up getting a billion warnings from recent versions telling you to use new syntax :(
669 2018-03-29T20:13:46  <wumpus> debian stable is the problem there
670 2018-03-29T20:13:46  <sipa> cfields: not only can they, i believe that SSA transforms will pretty much automatically do that
671 2018-03-29T20:14:23  <BlueMatt> wumpus: true, but, what, you're gonna not support debian stable? so...you lose, what, 1/5 your users?
672 2018-03-29T20:14:49  <cfields> sipa: so there's no (performance) downside of initialize-by-default as a rule?
673 2018-03-29T20:15:00  <wumpus> BlueMatt: but the only way to pressure them into upgrading their rust version is likely for major projects to start using it, it's always a chicken/egg problem
674 2018-03-29T20:15:27  <BlueMatt> why would they make an exception to their ship-only-insanely-out-of-date-software rule for a *compiler*?
675 2018-03-29T20:15:33  <wumpus> if e.g. bitcoin would start using it, no one would care, but something like tor has quite a lot of influence I think
676 2018-03-29T20:15:38  <BlueMatt> that seems like the one thing they'd be least likely to make an exception for
677 2018-03-29T20:15:50  <wumpus> oh we'll see
678 2018-03-29T20:17:21  <wumpus> I'm glad someone is taking the initative there that's not me
679 2018-03-29T20:17:31  *** dafunkiz_ has quit IRC
680 2018-03-29T20:18:50  <BlueMatt> lol, well at least we succeeded at getting them to stop shiping bitcoin
681 2018-03-29T20:18:51  <wumpus> firefox is likely the main pusher for (decent) rust support in distros
682 2018-03-29T20:18:54  <BlueMatt> maybe if the tor folks also succeed
683 2018-03-29T20:19:09  <BlueMatt> debian already stopped shipping firefox a long time ago :p
684 2018-03-29T20:19:16  <BlueMatt> (because of this exact issue, too....)
685 2018-03-29T20:19:37  <wumpus> huh? really?
686 2018-03-29T20:19:54  *** dafunkiz_ has joined #bitcoin-core-dev
687 2018-03-29T20:19:54  <BlueMatt> iceweasel, yo
688 2018-03-29T20:20:15  <wumpus> iceweasel is simply a rebranded firefox
689 2018-03-29T20:20:29  <wumpus> because of some license issue...
690 2018-03-29T20:20:29  <BlueMatt> yes, but they had to because they wanted to ship super old versions and that wasnt allowed
691 2018-03-29T20:20:43  <BlueMatt> afair
692 2018-03-29T20:21:15  <BlueMatt> (among other issues)
693 2018-03-29T20:21:27  <wumpus> shipping old versions of browsers is really dangerous
694 2018-03-29T20:21:52  <BlueMatt> yes, just pointing out that debian was so headstrong in their desire to do stupid insecure shit that they rebranded firefox for it....
695 2018-03-29T20:22:54  <wumpus> yes I didn't know that was the reason
696 2018-03-29T20:22:57  *** Giszmo has quit IRC
697 2018-03-29T20:23:21  <BlueMatt> i mean i may be misrecalling, but I believe that was one of the things that violated the acceptable-use license that firefox required to use their branding
698 2018-03-29T20:23:27  <BlueMatt> (among a few other issues)
699 2018-03-29T20:25:06  *** lnostdal has joined #bitcoin-core-dev
700 2018-03-29T20:26:25  *** suldev has joined #bitcoin-core-dev
701 2018-03-29T20:27:13  <cfields> I thought debian was back to firefox now?
702 2018-03-29T20:27:23  <cfields> iirc the tm issue was resolved somehow
703 2018-03-29T20:28:27  <BlueMatt> seems like it, yes, still, my point stands
704 2018-03-29T20:28:52  *** rls has joined #bitcoin-core-dev
705 2018-03-29T20:35:02  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0f9732d05d7...252c1b0faef4
706 2018-03-29T20:35:03  <bitcoin-git> bitcoin/master 5de2b18 John Newbery: [contrib] fixup security-check.py Python3 support
707 2018-03-29T20:35:04  <bitcoin-git> bitcoin/master f50975b John Newbery: [contrib] fixup symbol-check.py Python3 support
708 2018-03-29T20:35:04  <bitcoin-git> bitcoin/master 252c1b0 Wladimir J. van der Laan: Merge #12829: Python3 fixup...
709 2018-03-29T20:35:47  <bitcoin-git> [bitcoin] laanwj closed pull request #12829: Python3 fixup (master...python3_fixup) https://github.com/bitcoin/bitcoin/pull/12829
710 2018-03-29T20:37:23  *** lnostdal has quit IRC
711 2018-03-29T20:41:44  *** Giszmo has joined #bitcoin-core-dev
712 2018-03-29T20:46:05  *** Giszmo has quit IRC
713 2018-03-29T20:47:06  <sipa> cfields: there is when the compiler can't figure out the value is unused
714 2018-03-29T20:48:21  <sipa> but in the naive situatiin where there are no branches/loops that conplicate flow analysis, sure
715 2018-03-29T20:48:21  *** andytoshi has quit IRC
716 2018-03-29T20:48:22  *** andytoshi has joined #bitcoin-core-dev
717 2018-03-29T20:48:39  *** lnostdal has joined #bitcoin-core-dev
718 2018-03-29T20:58:01  *** d9b4bef9 has quit IRC
719 2018-03-29T20:58:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/252c1b0faef4...de6bdfd78f22
720 2018-03-29T20:58:46  <bitcoin-git> bitcoin/master 6feb46c Evan Klitzke: Add --with-sanitizers option to configure...
721 2018-03-29T20:58:47  <bitcoin-git> bitcoin/master de6bdfd Wladimir J. van der Laan: Merge #12692: Add configure options for various -fsanitize flags...
722 2018-03-29T20:59:07  *** d9b4bef9 has joined #bitcoin-core-dev
723 2018-03-29T20:59:24  <bitcoin-git> [bitcoin] laanwj closed pull request #12692: Add configure options for various -fsanitize flags (master...sanitize) https://github.com/bitcoin/bitcoin/pull/12692
724 2018-03-29T21:00:04  *** Guest2527 has joined #bitcoin-core-dev
725 2018-03-29T21:02:57  <bitcoin-git> [bitcoin] laanwj closed pull request #12774: Issue #10542 Signmessage doesn't work with segwit addresses (master...master) https://github.com/bitcoin/bitcoin/pull/12774
726 2018-03-29T21:05:51  *** Giszmo has joined #bitcoin-core-dev
727 2018-03-29T21:06:56  *** Randolf has joined #bitcoin-core-dev
728 2018-03-29T21:08:32  <bitcoin-git> [bitcoin] laanwj closed pull request #12124: [wallet] Remove segwit status check (master...master) https://github.com/bitcoin/bitcoin/pull/12124
729 2018-03-29T21:09:26  <sipa> m-m-m-multiclose PR
730 2018-03-29T21:09:36  <wumpus> hehe
731 2018-03-29T21:10:46  *** dafunkiz_ has quit IRC
732 2018-03-29T21:13:21  *** dafunkiz_ has joined #bitcoin-core-dev
733 2018-03-29T21:14:45  *** dafunkiz_ has quit IRC
734 2018-03-29T21:16:08  *** grafcaps has quit IRC
735 2018-03-29T21:17:47  *** dafunkiz_ has joined #bitcoin-core-dev
736 2018-03-29T21:19:05  *** moneyball has quit IRC
737 2018-03-29T21:23:57  *** Chris_Stewart_5 has quit IRC
738 2018-03-29T21:24:35  *** Victorsueca has quit IRC
739 2018-03-29T21:25:43  *** Victorsueca has joined #bitcoin-core-dev
740 2018-03-29T21:28:33  <wumpus> hm we should probably have discussed #12764 at the meeting
741 2018-03-29T21:28:34  <gribble> https://github.com/bitcoin/bitcoin/issues/12764 | Remove field in getblocktemplate help that has never been used. by conscott · Pull Request #12764 · bitcoin/bitcoin · GitHub
742 2018-03-29T21:29:17  <wumpus> not sure if having the help conform to BIP22 or to our current implementation of it is better
743 2018-03-29T21:31:04  <luke-jr> wumpus: I'd be inclined to just point to BIP 22 and leave the docs at that.
744 2018-03-29T21:33:10  *** grafcaps has joined #bitcoin-core-dev
745 2018-03-29T21:36:39  <wumpus> that'd be another option
746 2018-03-29T21:42:51  *** grafcaps has quit IRC
747 2018-03-29T21:46:49  *** jb55 has joined #bitcoin-core-dev
748 2018-03-29T21:51:35  *** meshcollider has joined #bitcoin-core-dev
749 2018-03-29T21:55:58  *** skeees has quit IRC
750 2018-03-29T21:56:27  *** Cogito_Ergo_Sum has quit IRC
751 2018-03-29T21:58:31  *** wxss_ has joined #bitcoin-core-dev
752 2018-03-29T22:01:27  *** wxss has quit IRC
753 2018-03-29T22:11:13  *** jb55 has quit IRC
754 2018-03-29T22:12:19  *** jb55 has joined #bitcoin-core-dev
755 2018-03-29T22:12:41  *** wxss_ has quit IRC
756 2018-03-29T22:16:51  *** jb55 has quit IRC
757 2018-03-29T22:18:10  *** skypper has quit IRC
758 2018-03-29T22:20:34  *** dafunkiz_ has quit IRC
759 2018-03-29T22:27:02  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de6bdfd78f22...3b62a9138657
760 2018-03-29T22:27:02  <bitcoin-git> bitcoin/master cb1e319 Jorge Timón: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished
761 2018-03-29T22:27:03  <bitcoin-git> bitcoin/master 3b62a91 Wladimir J. van der Laan: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished...
762 2018-03-29T22:27:37  <bitcoin-git> [bitcoin] laanwj closed pull request #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished (master...b16-bugfix-savemempool) https://github.com/bitcoin/bitcoin/pull/12172
763 2018-03-29T22:39:46  *** spinza has quit IRC
764 2018-03-29T22:44:34  *** nitramiz has quit IRC
765 2018-03-29T22:55:50  *** suldev has quit IRC
766 2018-03-29T23:04:01  *** BashCo has quit IRC
767 2018-03-29T23:04:58  *** BashCo has joined #bitcoin-core-dev
768 2018-03-29T23:05:09  *** suldev has joined #bitcoin-core-dev
769 2018-03-29T23:07:09  *** spinza has joined #bitcoin-core-dev
770 2018-03-29T23:22:08  *** go1111111 has quit IRC
771 2018-03-29T23:31:46  *** Guyver2 has quit IRC
772 2018-03-29T23:35:37  *** TrustTrade has joined #bitcoin-core-dev
773 2018-03-29T23:49:15  *** Tennis has joined #bitcoin-core-dev
774 2018-03-29T23:49:40  *** drexl has joined #bitcoin-core-dev
775 2018-03-29T23:50:45  *** lnostdal has quit IRC
776 2018-03-29T23:53:07  *** Randolf has quit IRC
777 2018-03-29T23:54:30  *** Tennis has quit IRC
778 2018-03-29T23:56:12  *** lnostdal has joined #bitcoin-core-dev