1 2018-04-09T00:00:02  *** weez17 has quit IRC
  2 2018-04-09T00:00:49  *** weez17 has joined #bitcoin-core-dev
  3 2018-04-09T00:02:01  *** d9b4bef9 has quit IRC
  4 2018-04-09T00:03:07  *** d9b4bef9 has joined #bitcoin-core-dev
  5 2018-04-09T00:04:37  *** promag has quit IRC
  6 2018-04-09T00:05:07  *** tester2 has quit IRC
  7 2018-04-09T00:06:21  *** promag has joined #bitcoin-core-dev
  8 2018-04-09T00:06:26  *** promag has quit IRC
  9 2018-04-09T00:06:39  *** promag has joined #bitcoin-core-dev
 10 2018-04-09T00:06:42  *** promag has quit IRC
 11 2018-04-09T00:09:33  *** rls has joined #bitcoin-core-dev
 12 2018-04-09T00:15:17  *** Murch has joined #bitcoin-core-dev
 13 2018-04-09T00:43:23  *** promag has joined #bitcoin-core-dev
 14 2018-04-09T00:47:57  *** promag has quit IRC
 15 2018-04-09T00:54:22  *** pyericz_ has joined #bitcoin-core-dev
 16 2018-04-09T01:00:51  *** dafunkiz_ has joined #bitcoin-core-dev
 17 2018-04-09T01:04:24  *** promag has joined #bitcoin-core-dev
 18 2018-04-09T01:04:57  *** dgenr8 has joined #bitcoin-core-dev
 19 2018-04-09T01:09:24  *** promag has quit IRC
 20 2018-04-09T01:10:29  *** lifeofguenter has quit IRC
 21 2018-04-09T01:11:39  *** lifeofguenter has joined #bitcoin-core-dev
 22 2018-04-09T01:12:52  *** dafunkiz_ has quit IRC
 23 2018-04-09T01:30:38  *** cryptojanitor has quit IRC
 24 2018-04-09T01:34:03  *** Randolf has joined #bitcoin-core-dev
 25 2018-04-09T01:34:22  *** satwo has joined #bitcoin-core-dev
 26 2018-04-09T01:34:41  *** zigen has joined #bitcoin-core-dev
 27 2018-04-09T01:37:29  *** Krellan has quit IRC
 28 2018-04-09T01:38:03  *** Krellan has joined #bitcoin-core-dev
 29 2018-04-09T01:52:01  *** luke-jr has quit IRC
 30 2018-04-09T01:56:51  *** AaronvanW has joined #bitcoin-core-dev
 31 2018-04-09T01:56:57  *** satwo has quit IRC
 32 2018-04-09T02:06:16  *** moneyball has joined #bitcoin-core-dev
 33 2018-04-09T02:22:56  *** rev_strangehope has joined #bitcoin-core-dev
 34 2018-04-09T02:29:14  *** luke-jr has joined #bitcoin-core-dev
 35 2018-04-09T02:29:16  *** moneyball has quit IRC
 36 2018-04-09T02:41:21  *** lifeofguenter has quit IRC
 37 2018-04-09T02:42:55  *** lifeofguenter has joined #bitcoin-core-dev
 38 2018-04-09T02:47:59  *** moneyball has joined #bitcoin-core-dev
 39 2018-04-09T02:53:21  *** moneyball has quit IRC
 40 2018-04-09T02:53:57  *** moneyball has joined #bitcoin-core-dev
 41 2018-04-09T02:54:53  *** grafcaps has quit IRC
 42 2018-04-09T02:55:30  *** moneyball has quit IRC
 43 2018-04-09T02:58:15  <kallewoof> I'm a little confused about coinbase transactions and 'is all from me'. Currently, CWallet::IsAllFromMe will say no to a coinbase transaction, even (it appears) if it's the miner's wallet. The check itself tries to find the prevout in the wallet, but prevout is 0000..., so it obviously won't be there. This causes issues with the IsAllFromMe PR (#12508), which I patched by explicitly saying 'true'
 44 2018-04-09T02:58:17  <kallewoof> for coinbase txs in CWallet::IsAllFromMe, but I wonder if this will cause everyone to think they own all coinbase transactions...
 45 2018-04-09T02:58:17  <gribble> https://github.com/bitcoin/bitcoin/issues/12508 | IsAllFromMe by kallewoof · Pull Request #12508 · bitcoin/bitcoin · GitHub
 46 2018-04-09T02:59:22  *** moneyball has joined #bitcoin-core-dev
 47 2018-04-09T03:00:03  <kallewoof> Then again, if it's a coinbase tx, it will have 100+ confirmations, so in all cases where IsAllFromMe matters (mostly unconfirmed, or low confirm count), it's irrelevant.
 48 2018-04-09T03:00:07  *** AaronvanW has quit IRC
 49 2018-04-09T03:00:41  *** grafcaps has joined #bitcoin-core-dev
 50 2018-04-09T03:00:45  <wumpus> hmm interesting
 51 2018-04-09T03:01:10  <kallewoof> Or is there a case where a 100+ confirm input being mine or not mine makes a difference? I guess in spending it someone could double spend, so ^ is probably not right..
 52 2018-04-09T03:02:32  <wumpus> for 100+ confirms there is no difference. The reason for the 100 depth is to make sure it's deep enough to avoid any realistic reorgs causing trouble.
 53 2018-04-09T03:03:28  <kallewoof> wumpus: Right. But I realized someone could spend a coinbase tx sending 12.5 btc to me, my node would think it was 'from me' and act accordingly, and then they would double spend it and I would risk losing 12.5 btc.
 54 2018-04-09T03:04:27  <luke-jr> huh? I don't understand what you're saying at all
 55 2018-04-09T03:04:36  <luke-jr> generated coins are from noone..
 56 2018-04-09T03:04:43  <kallewoof> luke-jr: Me neither. I think I'm very confused.
 57 2018-04-09T03:05:00  <sipa> from me means that the inputs were coins treated as yours
 58 2018-04-09T03:05:26  <kallewoof> Right. So a coinbase input would not be considered yours even if you created the block?
 59 2018-04-09T03:05:31  <wumpus> it's impossible to double-spend a coinbase, by definition the coinbase can only be in the block where the reward is taken
 60 2018-04-09T03:05:54  <luke-jr> kallewoof: the coinbase isn't really an input at all, just dummy data
 61 2018-04-09T03:06:03  <kallewoof> A coinbase transaction has a coinbase input and an output. I was talking about double spending the output.
 62 2018-04-09T03:06:27  <kallewoof> luke-jr: The question is, should IsAllFromMe(a coinbase tx) say true or false, for the miner mining it?
 63 2018-04-09T03:06:34  <luke-jr> false obviously?
 64 2018-04-09T03:06:38  <luke-jr> it's TO the miner, not FROM him
 65 2018-04-09T03:08:32  <kallewoof> luke-jr: All right. That makes things a bit tricky, I guess, but I'll dig.
 66 2018-04-09T03:09:29  <kallewoof> luke-jr: It doesn't seem like morcos's initial idea in #9167 is compatible with your interpretation, though: "Created a new wallet and walletTx function IsAllFromMe which correctly computes whether all the inputs to a transaction match the requested IsMine filter.
 67 2018-04-09T03:09:31  <gribble> https://github.com/bitcoin/bitcoin/issues/9167 | IsAllFromMe by morcos · Pull Request #9167 · bitcoin/bitcoin · GitHub
 68 2018-04-09T03:09:47  <sipa> kallewoof: i don't understand why you're concerned about coinbase txn at all
 69 2018-04-09T03:10:01  <sipa> coinbases are by definition never from anything
 70 2018-04-09T03:10:09  <kallewoof> sipa: IsMine says true and IsAllFromMe says false for coinbase txs
 71 2018-04-09T03:10:21  <sipa> yes, as it should?
 72 2018-04-09T03:11:26  <kallewoof> Sorry, I meant, IsFromMe and IsAllFromMe say true/false for coinbase
 73 2018-04-09T03:11:35  <sipa> yes, why is that a problem?
 74 2018-04-09T03:11:53  *** pyericz_ has quit IRC
 75 2018-04-09T03:12:02  *** grafcaps has quit IRC
 76 2018-04-09T03:12:47  *** zigen has quit IRC
 77 2018-04-09T03:13:08  <kallewoof> Wait, are coinbase transactions from me or not from me? If IsFromMe says true and there's only a coinbase input why would IsAllFromMe say false? Shouldn't both say the same in this case?
 78 2018-04-09T03:13:20  *** zigen has joined #bitcoin-core-dev
 79 2018-04-09T03:13:34  <kallewoof> luke-jr says false is correct. In which case IsFromMe is wrong, no?
 80 2018-04-09T03:13:39  <sipa> wait
 81 2018-04-09T03:13:47  <sipa> oh, IsFromMe is true?
 82 2018-04-09T03:13:49  <kallewoof> Yes
 83 2018-04-09T03:13:52  <sipa> that i don't understand!
 84 2018-04-09T03:13:53  *** pyericz_ has joined #bitcoin-core-dev
 85 2018-04-09T03:14:01  <sipa> maybe it's a special rule for foinbase tzn
 86 2018-04-09T03:14:04  <sipa> coinbase tzn
 87 2018-04-09T03:14:05  <kallewoof> All it does is check GetDebit(tx, ISMINE_ALL) > 0
 88 2018-04-09T03:14:07  <sipa> txn
 89 2018-04-09T03:14:22  <kallewoof> Right -- I'm saying I need to add that to CWallet::IsAllFromMe as well.
 90 2018-04-09T03:14:29  <kallewoof> that=the special rule for coinbase txs
 91 2018-04-09T03:14:52  <sipa> what is IsAllFromMe even used for?
 92 2018-04-09T03:15:45  <kallewoof> That's a great question. It seems to be used in feebumper, and in wallet.cpp in some places.
 93 2018-04-09T03:16:05  <kallewoof> Actually no it's only used in feebumper on master.
 94 2018-04-09T03:17:16  <sipa> yay
 95 2018-04-09T03:17:18  <kallewoof> So it seems completely fine to allow the special case.
 96 2018-04-09T03:17:24  <sipa> well, you can't feebump a coinbase!
 97 2018-04-09T03:17:33  * kallewoof nods
 98 2018-04-09T03:17:37  *** zigen has quit IRC
 99 2018-04-09T03:19:33  *** jtimon has quit IRC
100 2018-04-09T03:21:19  *** ken2812221 has quit IRC
101 2018-04-09T03:22:33  *** Randolf has quit IRC
102 2018-04-09T03:29:01  *** ken2812221 has joined #bitcoin-core-dev
103 2018-04-09T03:29:43  *** ken2812221 has quit IRC
104 2018-04-09T03:32:06  *** ken2812221 has joined #bitcoin-core-dev
105 2018-04-09T03:37:36  *** Randolf has joined #bitcoin-core-dev
106 2018-04-09T03:55:25  *** Krellan has quit IRC
107 2018-04-09T03:56:02  *** Krellan has joined #bitcoin-core-dev
108 2018-04-09T03:57:46  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/27278dffe877...4781813b5617
109 2018-04-09T03:57:47  <bitcoin-git> bitcoin/master 08b17de Karl-Johan Alm: [arith_uint256] Do not destroy *this content if passed-in operator may reference it
110 2018-04-09T03:57:48  <bitcoin-git> bitcoin/master b120f7b Karl-Johan Alm: [test] Add tests for self usage in arith_uint256
111 2018-04-09T03:57:48  <bitcoin-git> bitcoin/master 4781813 Wladimir J. van der Laan: Merge #12537: [arith_uint256] Make it safe to use "self" in operators...
112 2018-04-09T03:58:24  <bitcoin-git> [bitcoin] laanwj closed pull request #12537: [arith_uint256] Make it safe to use "self" in operators (master...uint-safe-self-op) https://github.com/bitcoin/bitcoin/pull/12537
113 2018-04-09T04:07:02  *** zigen has joined #bitcoin-core-dev
114 2018-04-09T04:10:30  *** zigen has quit IRC
115 2018-04-09T04:13:17  *** Michael___ has joined #bitcoin-core-dev
116 2018-04-09T04:14:58  *** moneyball has quit IRC
117 2018-04-09T04:15:30  *** pyericz_ has quit IRC
118 2018-04-09T04:28:27  *** grafcaps has joined #bitcoin-core-dev
119 2018-04-09T04:43:53  *** promag has joined #bitcoin-core-dev
120 2018-04-09T04:48:21  *** promag has quit IRC
121 2018-04-09T04:58:57  *** zigen has joined #bitcoin-core-dev
122 2018-04-09T04:59:40  *** Michael___ has quit IRC
123 2018-04-09T05:04:20  *** zigen has quit IRC
124 2018-04-09T05:04:53  *** zigen has joined #bitcoin-core-dev
125 2018-04-09T05:05:35  *** zigen has quit IRC
126 2018-04-09T05:05:48  *** zigen has joined #bitcoin-core-dev
127 2018-04-09T05:06:57  *** lnostdal has quit IRC
128 2018-04-09T05:09:03  *** lnostdal has joined #bitcoin-core-dev
129 2018-04-09T05:15:51  *** lnostdal_ has joined #bitcoin-core-dev
130 2018-04-09T05:16:01  *** lnostdal has quit IRC
131 2018-04-09T05:17:49  *** goatpig has joined #bitcoin-core-dev
132 2018-04-09T05:40:04  *** zautomata3 has quit IRC
133 2018-04-09T05:45:41  *** zautomata4 has joined #bitcoin-core-dev
134 2018-04-09T05:54:57  *** grafcaps has quit IRC
135 2018-04-09T05:56:54  <bitcoin-git> [bitcoin] VizXu opened pull request #12919: no message (0.8...master) https://github.com/bitcoin/bitcoin/pull/12919
136 2018-04-09T05:57:42  <bitcoin-git> [bitcoin] fanquake closed pull request #12919: no message (0.8...master) https://github.com/bitcoin/bitcoin/pull/12919
137 2018-04-09T06:02:13  *** zigen has quit IRC
138 2018-04-09T06:02:50  *** zigen has joined #bitcoin-core-dev
139 2018-04-09T06:03:05  *** zigen has quit IRC
140 2018-04-09T06:03:20  *** zigen has joined #bitcoin-core-dev
141 2018-04-09T06:09:48  *** Murch has quit IRC
142 2018-04-09T06:10:33  *** Victorsueca has quit IRC
143 2018-04-09T06:11:02  *** kanexxz has joined #bitcoin-core-dev
144 2018-04-09T06:11:09  *** promag has joined #bitcoin-core-dev
145 2018-04-09T06:11:59  *** Victorsueca has joined #bitcoin-core-dev
146 2018-04-09T06:15:08  *** grafcaps has joined #bitcoin-core-dev
147 2018-04-09T06:15:54  *** promag has quit IRC
148 2018-04-09T06:16:41  *** Krellan has quit IRC
149 2018-04-09T06:17:26  *** Krellan has joined #bitcoin-core-dev
150 2018-04-09T06:19:45  *** zigen has quit IRC
151 2018-04-09T06:19:47  *** grafcaps has quit IRC
152 2018-04-09T06:20:20  *** zigen has joined #bitcoin-core-dev
153 2018-04-09T06:23:10  *** zigen has quit IRC
154 2018-04-09T06:23:22  *** zigen has joined #bitcoin-core-dev
155 2018-04-09T06:24:38  *** Guest34 has quit IRC
156 2018-04-09T06:29:20  *** benma has joined #bitcoin-core-dev
157 2018-04-09T06:29:21  *** benma has joined #bitcoin-core-dev
158 2018-04-09T06:33:55  *** RoyceX has joined #bitcoin-core-dev
159 2018-04-09T06:36:53  *** cheese_ has quit IRC
160 2018-04-09T06:39:21  *** harrymm_ has joined #bitcoin-core-dev
161 2018-04-09T06:41:19  *** owowo has quit IRC
162 2018-04-09T06:42:32  *** harrymm has quit IRC
163 2018-04-09T06:51:59  *** cheese_ has joined #bitcoin-core-dev
164 2018-04-09T06:52:26  *** zigen has quit IRC
165 2018-04-09T06:52:40  *** zigen has joined #bitcoin-core-dev
166 2018-04-09T06:53:36  *** grafcaps has joined #bitcoin-core-dev
167 2018-04-09T06:54:51  *** RoyceX has quit IRC
168 2018-04-09T06:57:09  *** zigen has quit IRC
169 2018-04-09T06:57:44  *** zigen has joined #bitcoin-core-dev
170 2018-04-09T06:58:47  *** grafcaps has quit IRC
171 2018-04-09T07:00:45  *** zigen has quit IRC
172 2018-04-09T07:00:51  *** zigen has joined #bitcoin-core-dev
173 2018-04-09T07:05:36  *** zigen has quit IRC
174 2018-04-09T07:06:03  *** zigen has joined #bitcoin-core-dev
175 2018-04-09T07:09:29  *** promag has joined #bitcoin-core-dev
176 2018-04-09T07:16:01  *** promag has quit IRC
177 2018-04-09T07:20:20  *** ddd has joined #bitcoin-core-dev
178 2018-04-09T07:21:48  *** ddd has quit IRC
179 2018-04-09T07:41:46  *** zigen has quit IRC
180 2018-04-09T07:43:36  *** zarez has joined #bitcoin-core-dev
181 2018-04-09T07:45:13  *** zigen has joined #bitcoin-core-dev
182 2018-04-09T07:46:51  *** nickler has quit IRC
183 2018-04-09T07:47:53  *** nickler has joined #bitcoin-core-dev
184 2018-04-09T07:52:35  <bitcoin-git> [bitcoin] kallewoof opened pull request #12920: test: Fix sign for expected values (master...test-signs) https://github.com/bitcoin/bitcoin/pull/12920
185 2018-04-09T07:56:37  *** nickler has quit IRC
186 2018-04-09T07:58:14  *** Emcy has joined #bitcoin-core-dev
187 2018-04-09T07:59:58  *** laurentmt has joined #bitcoin-core-dev
188 2018-04-09T08:02:33  *** nickler has joined #bitcoin-core-dev
189 2018-04-09T08:03:12  *** laurentmt1 has joined #bitcoin-core-dev
190 2018-04-09T08:03:42  *** grafcaps has joined #bitcoin-core-dev
191 2018-04-09T08:04:25  *** laurentmt has quit IRC
192 2018-04-09T08:04:25  *** laurentmt1 is now known as laurentmt
193 2018-04-09T08:05:19  *** andytoshi has quit IRC
194 2018-04-09T08:08:59  *** grafcaps has quit IRC
195 2018-04-09T08:09:47  *** timothy has joined #bitcoin-core-dev
196 2018-04-09T08:10:04  *** setpill has joined #bitcoin-core-dev
197 2018-04-09T08:12:06  *** andytoshi has joined #bitcoin-core-dev
198 2018-04-09T08:18:43  *** Victorsueca has quit IRC
199 2018-04-09T08:19:16  *** drizztbsd has joined #bitcoin-core-dev
200 2018-04-09T08:19:59  *** Victorsueca has joined #bitcoin-core-dev
201 2018-04-09T08:20:02  *** timothy has quit IRC
202 2018-04-09T08:26:24  *** promag has joined #bitcoin-core-dev
203 2018-04-09T08:26:30  *** promag has quit IRC
204 2018-04-09T08:29:59  *** drizztbsd is now known as timothy
205 2018-04-09T08:30:21  *** rafalcpp has quit IRC
206 2018-04-09T08:51:54  *** zarez has quit IRC
207 2018-04-09T08:52:19  *** zarez has joined #bitcoin-core-dev
208 2018-04-09T08:53:27  <bitcoin-git> [bitcoin] Empact opened pull request #12921: Make use of cpuid.h bit definitions (master...cpuid-bits) https://github.com/bitcoin/bitcoin/pull/12921
209 2018-04-09T08:57:05  *** zautomata4 has quit IRC
210 2018-04-09T08:59:06  *** zautomata4 has joined #bitcoin-core-dev
211 2018-04-09T08:59:59  *** vicenteH has joined #bitcoin-core-dev
212 2018-04-09T09:03:11  *** zautomata has joined #bitcoin-core-dev
213 2018-04-09T09:04:14  *** zautomata4 has quit IRC
214 2018-04-09T09:07:03  *** zautomata1 has joined #bitcoin-core-dev
215 2018-04-09T09:09:22  *** zautomata has quit IRC
216 2018-04-09T09:15:17  *** zautomata1 has quit IRC
217 2018-04-09T09:15:52  *** zautomata2 has joined #bitcoin-core-dev
218 2018-04-09T09:17:51  *** zigen has quit IRC
219 2018-04-09T09:18:07  *** zigen has joined #bitcoin-core-dev
220 2018-04-09T09:36:46  *** zautomata has joined #bitcoin-core-dev
221 2018-04-09T09:38:28  *** zautomata2 has quit IRC
222 2018-04-09T09:48:29  *** zautomata1 has joined #bitcoin-core-dev
223 2018-04-09T09:49:23  *** zautomata has quit IRC
224 2018-04-09T09:56:09  *** zautomata1 has quit IRC
225 2018-04-09T09:58:24  *** jtimon has joined #bitcoin-core-dev
226 2018-04-09T09:58:39  *** zautomata1 has joined #bitcoin-core-dev
227 2018-04-09T10:04:02  *** zautomata1 has quit IRC
228 2018-04-09T10:04:11  *** zautomata2 has joined #bitcoin-core-dev
229 2018-04-09T10:04:39  *** laurentmt has quit IRC
230 2018-04-09T10:05:53  *** zigen has quit IRC
231 2018-04-09T10:06:26  *** zigen has joined #bitcoin-core-dev
232 2018-04-09T10:07:28  *** zigen has joined #bitcoin-core-dev
233 2018-04-09T10:14:45  *** lnostdal_ has quit IRC
234 2018-04-09T10:30:14  *** grafcaps has joined #bitcoin-core-dev
235 2018-04-09T10:32:37  *** zigen has quit IRC
236 2018-04-09T10:33:12  *** zigen has joined #bitcoin-core-dev
237 2018-04-09T10:35:01  *** grafcaps has quit IRC
238 2018-04-09T10:37:57  *** zigen has quit IRC
239 2018-04-09T10:43:27  *** zigen has joined #bitcoin-core-dev
240 2018-04-09T10:47:42  *** zigen has quit IRC
241 2018-04-09T10:57:54  *** zautomata2 has quit IRC
242 2018-04-09T10:59:29  *** zautomata has joined #bitcoin-core-dev
243 2018-04-09T10:59:42  *** zautomata has joined #bitcoin-core-dev
244 2018-04-09T10:59:57  <wumpus> does anyone happen to have an arm32 system with crc32 feature in /proc/cpuinfo?
245 2018-04-09T11:01:11  *** belcher_ has joined #bitcoin-core-dev
246 2018-04-09T11:02:40  <wumpus> I want to port https://github.com/laanwj/crcbench to arm32 (with the goal of integrating that into leveldb) however I currently have no wway to test. Well I could check if it compiles, I guess.
247 2018-04-09T11:04:35  <wumpus> oh right, I guess 64-bit ARM can run 32-bit executables
248 2018-04-09T11:11:07  *** promag has joined #bitcoin-core-dev
249 2018-04-09T11:11:37  *** CubicEarths has joined #bitcoin-core-dev
250 2018-04-09T11:16:56  *** wunpunch has joined #bitcoin-core-dev
251 2018-04-09T11:21:54  *** Allen_ has joined #bitcoin-core-dev
252 2018-04-09T11:23:29  *** Allen_ has left #bitcoin-core-dev
253 2018-04-09T11:25:04  *** AaronvanW has joined #bitcoin-core-dev
254 2018-04-09T11:26:15  *** rls has quit IRC
255 2018-04-09T11:27:09  *** Aaronvan_ has joined #bitcoin-core-dev
256 2018-04-09T11:30:37  *** AaronvanW has quit IRC
257 2018-04-09T11:36:53  *** zautomata has quit IRC
258 2018-04-09T11:37:10  *** zautomata1 has joined #bitcoin-core-dev
259 2018-04-09T11:40:20  *** farsider350 has joined #bitcoin-core-dev
260 2018-04-09T11:41:58  <MarcoFalke> PSA: We now have 15 parallel jobs on travis for the next year :3
261 2018-04-09T11:42:57  <wumpus> awesome, thank you MarcoFalke :)
262 2018-04-09T11:43:13  <MarcoFalke> Thanks to ChainCode for sponsoring that!
263 2018-04-09T11:44:44  <wumpus> yes!
264 2018-04-09T11:49:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4781813b5617...6fc5a050f216
265 2018-04-09T11:49:44  <bitcoin-git> bitcoin/master bf08fc5 Karl-Johan Alm: test: Assert on correct variable
266 2018-04-09T11:49:45  <bitcoin-git> bitcoin/master 6fc5a05 MarcoFalke: Merge #12918: test: Assert on correct variable...
267 2018-04-09T11:50:31  *** intcat has quit IRC
268 2018-04-09T11:50:36  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12918: test: Assert on correct variable (master...test-typo-rpcrawtx) https://github.com/bitcoin/bitcoin/pull/12918
269 2018-04-09T11:55:56  *** Samdney has joined #bitcoin-core-dev
270 2018-04-09T11:58:02  *** intcat has joined #bitcoin-core-dev
271 2018-04-09T11:59:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6fc5a050f216...a04440feb9c9
272 2018-04-09T11:59:01  <bitcoin-git> bitcoin/master 280023f practicalswift: Remove duplicate includes
273 2018-04-09T11:59:02  <bitcoin-git> bitcoin/master c36b720 practicalswift: Add Travis check for duplicate includes...
274 2018-04-09T11:59:02  <bitcoin-git> bitcoin/master a04440f MarcoFalke: Merge #11878: Add Travis check for duplicate includes...
275 2018-04-09T11:59:30  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11878: Add Travis check for duplicate includes (master...lint-includes) https://github.com/bitcoin/bitcoin/pull/11878
276 2018-04-09T12:05:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a04440feb9c9...cd8e45b4e75a
277 2018-04-09T12:05:28  <bitcoin-git> bitcoin/master c198dc0 Jan Čapek: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC
278 2018-04-09T12:05:29  <bitcoin-git> bitcoin/master cd8e45b MarcoFalke: Merge #12007: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC...
279 2018-04-09T12:05:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12007: [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC (master...master) https://github.com/bitcoin/bitcoin/pull/12007
280 2018-04-09T12:07:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd8e45b4e75a...603975b96a15
281 2018-04-09T12:07:26  <bitcoin-git> bitcoin/master 9142dfe practicalswift: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion
282 2018-04-09T12:07:26  <bitcoin-git> bitcoin/master 603975b MarcoFalke: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion...
283 2018-04-09T12:08:10  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion (master...cuckoocache) https://github.com/bitcoin/bitcoin/pull/12770
284 2018-04-09T12:10:38  *** Guyver2 has joined #bitcoin-core-dev
285 2018-04-09T12:13:37  <aj> MarcoFalke: wow!
286 2018-04-09T12:16:26  *** promag has quit IRC
287 2018-04-09T12:18:43  *** farsider350 has quit IRC
288 2018-04-09T12:35:31  *** lnostdal has joined #bitcoin-core-dev
289 2018-04-09T12:42:17  *** lnostdal has quit IRC
290 2018-04-09T12:44:41  *** ProfMac has quit IRC
291 2018-04-09T12:46:07  <wumpus> so apparently the crc32 extension only exists on armv8, but I didn't know 32-bit-only armv8 existed but apparently it does (Cortex-A32)
292 2018-04-09T12:46:24  *** ProfMac has joined #bitcoin-core-dev
293 2018-04-09T12:50:20  <wumpus> anyhow getauxv trick to detect cpu features works; if (getauxval(AT_HWCAP) & HWCAP_CRC32) { on aarch64 and  if (getauxval(AT_HWCAP2) & HWCAP2_CRC32) {  on arm32
294 2018-04-09T12:50:54  *** Aaronvan_ has quit IRC
295 2018-04-09T12:51:30  *** AaronvanW has joined #bitcoin-core-dev
296 2018-04-09T12:55:23  *** lnostdal has joined #bitcoin-core-dev
297 2018-04-09T13:02:30  *** promag has joined #bitcoin-core-dev
298 2018-04-09T13:15:11  *** Krellan has quit IRC
299 2018-04-09T13:16:01  *** Krellan has joined #bitcoin-core-dev
300 2018-04-09T13:18:29  *** lnostdal has quit IRC
301 2018-04-09T13:22:02  <MarcoFalke> Anyone else seeing this: #12915?
302 2018-04-09T13:22:03  <gribble> https://github.com/bitcoin/bitcoin/issues/12915 | Segmentation fault in util: ScheduleBatchPriority · Issue #12915 · bitcoin/bitcoin · GitHub
303 2018-04-09T13:27:11  <aj> hmm, i thought designator initialisers (param{.sched_priority=0}) weren't ok for c++11 (http://en.cppreference.com/w/cpp/language/aggregate_initialization says they're c++20 fwiw)
304 2018-04-09T13:31:24  <wumpus> MarcoFalke: nope. it crashes inside pthread_setschedparam? that's curious
305 2018-04-09T13:32:37  <wumpus> the only way I see that can happen if is a null pointer is passed, but as it is passing a pointer to a static variable you'd say that's not possible
306 2018-04-09T13:33:06  <wumpus> does this only happen with the sanitize ron?
307 2018-04-09T13:35:39  <aj> err, should it be pthread_self() not 0 as the first argument?
308 2018-04-09T13:36:53  <wumpus> uhmm
309 2018-04-09T13:37:04  <wumpus> the man page doesn't say anything about 0 being a valid value, at least
310 2018-04-09T13:37:33  <wumpus> MarcoFalke: can you try that ^^
311 2018-04-09T13:38:30  <MarcoFalke> happens also with sanitizer off
312 2018-04-09T13:39:00  <MarcoFalke> I've seen segfaults in the unit test a couple of days ago, but they went away after a reboot. Really sketchy
313 2018-04-09T13:41:48  <wumpus> should definitely be pthread_self() - non-determinism in thread ids might explain why it sometimes crashes and sometimes not?
314 2018-04-09T13:42:51  <MarcoFalke> For me it always faults
315 2018-04-09T13:43:25  <MarcoFalke> The unit test thing was a different topic. Just related because it was also a segfault
316 2018-04-09T13:46:19  <MarcoFalke> Making it "const static sched_param param{0};" didn't help
317 2018-04-09T13:47:19  <bitcoin-git> [bitcoin] laanwj opened pull request #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0 (master...2018_04_pthread_self) https://github.com/bitcoin/bitcoin/pull/12923
318 2018-04-09T13:48:35  <MarcoFalke> will try that ^
319 2018-04-09T13:49:42  *** Strepsils has joined #bitcoin-core-dev
320 2018-04-09T13:51:15  *** Randolf has quit IRC
321 2018-04-09T13:51:42  <MarcoFalke> aj: wumpus: Thx. Work for me now
322 2018-04-09T13:51:51  * MarcoFalke subway
323 2018-04-09T13:51:52  <wumpus> I can make the initializer change in the same PR, but as it compiles in c++11 mode, I'm not sure .
324 2018-04-09T13:53:07  <aj> https://stackoverflow.com/questions/43471743/pthread-self-on-linux -- suggests that without linking pthreads, pthread_self() will sometimes/often/?? return 0
325 2018-04-09T13:54:40  <wumpus> that explains why it works for some
326 2018-04-09T13:54:57  <MarcoFalke> aj: I added the cout and it is definetly not 0 for me
327 2018-04-09T13:54:59  *** Strepsils has quit IRC
328 2018-04-09T13:55:07  <wumpus> it depends on the specifics of the pthread implementation, after all posix threads is an interface, not a specific implementation
329 2018-04-09T13:55:08  <luke-jr> aj: if you don't link pthreads, pthread_self won't resolve at all, and calling it would be a segfault..
330 2018-04-09T13:55:16  <luke-jr> I would expect
331 2018-04-09T13:55:37  <wumpus> so one should not make any assumptions about the value that it returns
332 2018-04-09T13:58:29  <aj> luke-jr: works fine for me without linking libpthread, value is very non-zero either way though. (i don't get a segfault with marcofalke's test case)
333 2018-04-09T13:59:14  <luke-jr> aj: well, glibc no longer has libpthread anymore
334 2018-04-09T13:59:43  <luke-jr> (threading is part of the libc now, and linking libpthread explicitly actually can have harmful side effects)
335 2018-04-09T14:04:13  *** Strepsils has joined #bitcoin-core-dev
336 2018-04-09T14:06:28  *** grafcaps has joined #bitcoin-core-dev
337 2018-04-09T14:11:04  *** grafcaps has quit IRC
338 2018-04-09T14:14:06  *** cryptojanitor has joined #bitcoin-core-dev
339 2018-04-09T14:14:32  <wumpus> about time that threading moved into libc, even little embedded SoCs are mulitcore these days, having threading as something special/optional is just absurd
340 2018-04-09T14:14:36  <bitcoin-git> [bitcoin] jamesob closed pull request #12873: [ci] Run functional tests using bitcoin-qt in one Travis job (master...2018-04-03-travis-func-qt) https://github.com/bitcoin/bitcoin/pull/12873
341 2018-04-09T14:15:09  <luke-jr> wumpus: would be nice if they didn't have bugs doing it though :p
342 2018-04-09T14:15:37  <luke-jr> (with glibc, if you link libpthread, and then call vfork early on, it will just return a pointer to the vfork function rather than actually forking)
343 2018-04-09T14:15:56  <aj> jamesob: maybe just open a new PR instead? :(
344 2018-04-09T14:16:36  <jamesob> aj: yeah, probably a good idea. Wonder why/how that PR is screwing travis up.
345 2018-04-09T14:16:45  <jamesob> sorry for the spam
346 2018-04-09T14:20:45  *** qu4ku has joined #bitcoin-core-dev
347 2018-04-09T14:23:09  *** jimpo has quit IRC
348 2018-04-09T14:26:34  *** owowo has joined #bitcoin-core-dev
349 2018-04-09T14:26:34  *** owowo has joined #bitcoin-core-dev
350 2018-04-09T14:27:55  *** Strepsil_ has joined #bitcoin-core-dev
351 2018-04-09T14:27:58  *** zautomata1 has quit IRC
352 2018-04-09T14:28:42  *** jimpo has joined #bitcoin-core-dev
353 2018-04-09T14:29:51  *** zautomata1 has joined #bitcoin-core-dev
354 2018-04-09T14:30:54  *** Strepsils has quit IRC
355 2018-04-09T14:34:48  *** AaronvanW has quit IRC
356 2018-04-09T14:35:24  *** AaronvanW has joined #bitcoin-core-dev
357 2018-04-09T14:38:37  *** lnostdal has joined #bitcoin-core-dev
358 2018-04-09T14:40:07  *** AaronvanW has quit IRC
359 2018-04-09T14:42:51  *** lnostdal_ has joined #bitcoin-core-dev
360 2018-04-09T14:43:34  *** lnostdal has quit IRC
361 2018-04-09T14:48:38  *** SopaXorzTaker has joined #bitcoin-core-dev
362 2018-04-09T14:52:23  <jonasschnelli> wumpus: curious: whats the reason for implementing NI crc for arm 32bit?
363 2018-04-09T14:53:34  *** AaronvanW has joined #bitcoin-core-dev
364 2018-04-09T14:53:42  <wumpus> jonasschnelli: last time I checked, quite a lot of time is spent crcing (for leveldb checksums), while verifying the chain
365 2018-04-09T14:54:08  *** grafcaps has joined #bitcoin-core-dev
366 2018-04-09T14:55:35  <jonasschnelli> wumpus: Good to know. I just started to play with the ODROID HC2 (Cortex-A15)
367 2018-04-09T14:55:37  <wumpus> so using those extensions on hardware that support them probably helps, though I agree the 32-bit case is unlikley to be hit
368 2018-04-09T14:55:55  <wumpus> (as 32-bit armv8 are very rare)
369 2018-04-09T14:56:10  <wumpus> ah, nice
370 2018-04-09T14:56:33  <jonasschnelli> I guess Odroids XU4 and HC2 are 32 bit armv7?
371 2018-04-09T14:57:00  <jonasschnelli> Not sure if the have NI crc32
372 2018-04-09T14:58:07  <jonasschnelli> Don't have access until Thursday to the machine... so no /proc/cpuinto right now
373 2018-04-09T14:58:27  *** grafcaps has quit IRC
374 2018-04-09T14:59:15  <wumpus> armv7 never has crc32
375 2018-04-09T14:59:29  <jonasschnelli> Just read that up... v8 is min, right.
376 2018-04-09T14:59:40  <jonasschnelli> v8.1-A AFAIK
377 2018-04-09T15:10:28  *** AaronvanW has quit IRC
378 2018-04-09T15:11:07  *** AaronvanW has joined #bitcoin-core-dev
379 2018-04-09T15:12:58  *** satwo has joined #bitcoin-core-dev
380 2018-04-09T15:14:10  *** kanexxz has quit IRC
381 2018-04-09T15:15:27  *** AaronvanW has quit IRC
382 2018-04-09T15:16:28  <bitcoin-git> [bitcoin] jnewbery opened pull request #12924: Fix hdmaster-key / seed-key confusion (scripted diff) (master...master_key_to_seed) https://github.com/bitcoin/bitcoin/pull/12924
383 2018-04-09T15:16:37  *** grafcaps has joined #bitcoin-core-dev
384 2018-04-09T15:18:21  *** Strepsil_ has quit IRC
385 2018-04-09T15:20:51  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12094: Fix hdmaster-key / seed-key confusion (master...2018/01/hdseed) https://github.com/bitcoin/bitcoin/pull/12094
386 2018-04-09T15:21:09  *** AaronvanW has joined #bitcoin-core-dev
387 2018-04-09T15:23:28  *** Murch has joined #bitcoin-core-dev
388 2018-04-09T15:25:44  *** AaronvanW has quit IRC
389 2018-04-09T15:27:06  *** satwo has quit IRC
390 2018-04-09T15:28:23  *** grafcaps has quit IRC
391 2018-04-09T15:33:47  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/603975b96a15...a7cbe38ae2dd
392 2018-04-09T15:33:48  <bitcoin-git> bitcoin/master cff66e6 Wladimir J. van der Laan: util: Pass pthread_self() to pthread_setschedparam instead of 0...
393 2018-04-09T15:33:48  <bitcoin-git> bitcoin/master b86730a Wladimir J. van der Laan: util: Remove designator initializer from ScheduleBatchPriority...
394 2018-04-09T15:33:49  <bitcoin-git> bitcoin/master a7cbe38 Wladimir J. van der Laan: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0...
395 2018-04-09T15:34:22  *** Giszmo has quit IRC
396 2018-04-09T15:34:23  *** Krellan has quit IRC
397 2018-04-09T15:34:41  <bitcoin-git> [bitcoin] laanwj closed pull request #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0 (master...2018_04_pthread_self) https://github.com/bitcoin/bitcoin/pull/12923
398 2018-04-09T15:35:07  *** Krellan has joined #bitcoin-core-dev
399 2018-04-09T15:40:47  *** moneyball has joined #bitcoin-core-dev
400 2018-04-09T15:48:34  *** moneyball has quit IRC
401 2018-04-09T15:56:57  *** zarez has quit IRC
402 2018-04-09T15:59:08  *** jbisch has quit IRC
403 2018-04-09T15:59:21  *** nhill has quit IRC
404 2018-04-09T16:00:02  *** str4d has joined #bitcoin-core-dev
405 2018-04-09T16:00:38  *** AaronvanW has joined #bitcoin-core-dev
406 2018-04-09T16:07:09  *** setpill has quit IRC
407 2018-04-09T16:15:11  *** Randolf has joined #bitcoin-core-dev
408 2018-04-09T16:16:03  <bitcoin-git> [bitcoin] Empact closed pull request #12921: Make use of cpuid.h bit definitions (master...cpuid-bits) https://github.com/bitcoin/bitcoin/pull/12921
409 2018-04-09T16:20:27  *** Randolf has quit IRC
410 2018-04-09T16:22:30  <promag> it it me or CWalletTx::GetRequestCount() is not used?
411 2018-04-09T16:23:28  *** lnostdal_ is now known as lnostdal
412 2018-04-09T16:24:44  *** Newton35Dickens has joined #bitcoin-core-dev
413 2018-04-09T16:25:38  *** benma has quit IRC
414 2018-04-09T16:27:15  *** isis is now known as isis_
415 2018-04-09T16:29:12  *** shesek has quit IRC
416 2018-04-09T16:29:42  <instagibbs> promag, src/interface/wallet.cpp:95:    result.request_count = wtx.GetRequestCount();
417 2018-04-09T16:30:00  <promag> rigth, but request_count is not used
418 2018-04-09T16:30:16  <promag> oh sorry, it is
419 2018-04-09T16:30:33  <promag> my bad :/
420 2018-04-09T16:30:36  <instagibbs> np
421 2018-04-09T16:32:51  *** shesek has joined #bitcoin-core-dev
422 2018-04-09T16:32:51  *** shesek has joined #bitcoin-core-dev
423 2018-04-09T16:33:05  *** moneyball has joined #bitcoin-core-dev
424 2018-04-09T16:36:34  *** Dizzle has joined #bitcoin-core-dev
425 2018-04-09T16:36:42  *** wunpunch has quit IRC
426 2018-04-09T16:49:27  *** Giszmo has joined #bitcoin-core-dev
427 2018-04-09T16:53:12  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #12925: [Trivial] Logprint the start of a rescan (master...2018/04/rescan) https://github.com/bitcoin/bitcoin/pull/12925
428 2018-04-09T17:10:26  *** Krellan has quit IRC
429 2018-04-09T17:10:54  *** Krellan has joined #bitcoin-core-dev
430 2018-04-09T17:15:12  *** Krellan has quit IRC
431 2018-04-09T17:21:10  <jamesob> now that we're not supporting Python2, can we start adding function (type) annotations to functional test code? I think that'll help make the test framework a bit easier to use
432 2018-04-09T17:23:02  *** Giszmo has quit IRC
433 2018-04-09T17:23:57  *** cryptojanitor has quit IRC
434 2018-04-09T17:24:55  *** cryptojanitor has joined #bitcoin-core-dev
435 2018-04-09T17:27:47  *** Randolf has joined #bitcoin-core-dev
436 2018-04-09T17:28:53  *** Murch has quit IRC
437 2018-04-09T17:29:39  *** Murch has joined #bitcoin-core-dev
438 2018-04-09T17:30:33  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a7cbe38ae2dd...0700b6f778d9
439 2018-04-09T17:30:34  <bitcoin-git> bitcoin/master ea23945 Russell Yanofsky: scripted-diff: Rename wallet database classes...
440 2018-04-09T17:30:34  <bitcoin-git> bitcoin/master 398c6f0 Russell Yanofsky: Update walletdb comment after renaming....
441 2018-04-09T17:30:35  <bitcoin-git> bitcoin/master 9b0f0c5 Russell Yanofsky: Add m_ prefix to WalletBatch::m_batch
442 2018-04-09T17:30:56  <bitcoin-git> [bitcoin] laanwj closed pull request #11851: scripted-diff: Rename wallet database classes (master...pr/wren) https://github.com/bitcoin/bitcoin/pull/11851
443 2018-04-09T17:31:54  <wumpus> jamesob: I guess so
444 2018-04-09T17:33:41  <jamesob> I'm thinking particularly for arguments in util functions like "pubkey" and "blockhash" which are pretty ambiguous
445 2018-04-09T17:37:27  *** vicenteH has quit IRC
446 2018-04-09T17:42:14  <wumpus> I've never used type annotations in python so I don't know how useful they are
447 2018-04-09T17:46:03  <jamesob> the use is pretty limited out of the box; they're like more succinct docstrings. there are third-party tools that do verification, though I've never used any of them
448 2018-04-09T18:04:25  *** SopaXorzTaker has quit IRC
449 2018-04-09T18:06:07  *** qu4ku has quit IRC
450 2018-04-09T18:07:35  *** Randolf has quit IRC
451 2018-04-09T18:16:41  *** Krellan has joined #bitcoin-core-dev
452 2018-04-09T18:19:05  <wumpus> I'd say make an example PR where you change a few functions, then see how the review goes
453 2018-04-09T18:21:21  *** Krellan has quit IRC
454 2018-04-09T18:25:43  *** timothy has quit IRC
455 2018-04-09T18:28:34  *** Dizzle has quit IRC
456 2018-04-09T18:33:25  *** promag has quit IRC
457 2018-04-09T18:38:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0700b6f778d9...cf8073f8d1d1
458 2018-04-09T18:38:28  <bitcoin-git> bitcoin/master fab9095 MarcoFalke: qa: Windows fixups for functional tests
459 2018-04-09T18:38:28  <bitcoin-git> bitcoin/master cf8073f MarcoFalke: Merge #12917: qa: Windows fixups for functional tests...
460 2018-04-09T18:39:16  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12917: qa: Windows fixups for functional tests (master...Mf1804-qaWinFixups) https://github.com/bitcoin/bitcoin/pull/12917
461 2018-04-09T18:39:43  *** promag has joined #bitcoin-core-dev
462 2018-04-09T18:41:33  *** Randolf has joined #bitcoin-core-dev
463 2018-04-09T18:43:38  *** Murch has quit IRC
464 2018-04-09T18:44:14  *** Victorsueca has quit IRC
465 2018-04-09T18:44:46  *** zigen has joined #bitcoin-core-dev
466 2018-04-09T18:45:30  *** Victorsueca has joined #bitcoin-core-dev
467 2018-04-09T18:46:38  *** promag has quit IRC
468 2018-04-09T18:46:53  *** wunpunch has joined #bitcoin-core-dev
469 2018-04-09T18:49:19  *** zigen has quit IRC
470 2018-04-09T18:50:08  *** drexl has joined #bitcoin-core-dev
471 2018-04-09T18:52:05  *** goatpig has quit IRC
472 2018-04-09T18:53:55  *** dafunkiz_ has joined #bitcoin-core-dev
473 2018-04-09T18:54:35  *** andytoshi has quit IRC
474 2018-04-09T18:54:35  *** andytoshi has joined #bitcoin-core-dev
475 2018-04-09T18:54:53  *** dafunkiz_ has quit IRC
476 2018-04-09T18:56:04  *** Giszmo has joined #bitcoin-core-dev
477 2018-04-09T18:56:05  *** dafunkiz_ has joined #bitcoin-core-dev
478 2018-04-09T18:59:13  *** Victorsueca has quit IRC
479 2018-04-09T19:00:29  *** Victorsueca has joined #bitcoin-core-dev
480 2018-04-09T19:01:06  *** Murch has joined #bitcoin-core-dev
481 2018-04-09T19:09:05  *** drexl has quit IRC
482 2018-04-09T19:12:30  *** dafunkiz_ has quit IRC
483 2018-04-09T19:17:19  *** Randolf has quit IRC
484 2018-04-09T19:26:12  <jamesob> wumpus: sounds good
485 2018-04-09T19:29:37  *** kanexxz has joined #bitcoin-core-dev
486 2018-04-09T19:31:10  *** kanexxz has quit IRC
487 2018-04-09T19:37:56  *** donaloconnor has joined #bitcoin-core-dev
488 2018-04-09T19:39:14  *** moneyball has quit IRC
489 2018-04-09T19:40:06  *** moneyball has joined #bitcoin-core-dev
490 2018-04-09T19:44:27  *** lightningbot has joined #bitcoin-core-dev
491 2018-04-09T19:46:06  *** shtirlic has joined #bitcoin-core-dev
492 2018-04-09T19:46:12  *** promag has joined #bitcoin-core-dev
493 2018-04-09T19:50:22  *** provoostenator has quit IRC
494 2018-04-09T19:53:27  *** provoostenator has joined #bitcoin-core-dev
495 2018-04-09T19:53:52  *** promag has quit IRC
496 2018-04-09T20:01:10  *** BashCo has joined #bitcoin-core-dev
497 2018-04-09T20:02:05  *** BashCo_ has quit IRC
498 2018-04-09T20:05:33  *** Victorsueca has quit IRC
499 2018-04-09T20:06:59  *** Victorsueca has joined #bitcoin-core-dev
500 2018-04-09T20:11:14  *** Randolf has joined #bitcoin-core-dev
501 2018-04-09T20:15:08  *** ProfMac has quit IRC
502 2018-04-09T20:15:32  *** dafunkiz_ has joined #bitcoin-core-dev
503 2018-04-09T20:19:24  *** murchandamus has quit IRC
504 2018-04-09T20:23:53  *** dafunkiz_ has quit IRC
505 2018-04-09T20:24:18  *** qu4ku has joined #bitcoin-core-dev
506 2018-04-09T20:26:58  *** murchandamus has joined #bitcoin-core-dev
507 2018-04-09T20:29:29  *** murchandamus has quit IRC
508 2018-04-09T20:30:14  *** CubicEarths has quit IRC
509 2018-04-09T20:31:59  *** dafunkiz_ has joined #bitcoin-core-dev
510 2018-04-09T20:34:55  *** CubicEarths has joined #bitcoin-core-dev
511 2018-04-09T20:35:26  <bitcoin-git> [bitcoin] sipa opened pull request #12926: Run unit tests in parallel (master...201804_parunit) https://github.com/bitcoin/bitcoin/pull/12926
512 2018-04-09T20:39:48  *** qu4ku has quit IRC
513 2018-04-09T20:40:26  *** CubicEarths has quit IRC
514 2018-04-09T20:42:15  *** intcat has quit IRC
515 2018-04-09T20:42:49  *** murchandamus has joined #bitcoin-core-dev
516 2018-04-09T20:44:02  *** dafunkiz_ has quit IRC
517 2018-04-09T20:45:27  *** intcat has joined #bitcoin-core-dev
518 2018-04-09T20:53:17  *** dafunkiz_ has joined #bitcoin-core-dev
519 2018-04-09T20:56:01  <bitcoin-git> [bitcoin] trulex opened pull request #12927: Docs: fixed link, replaced QT with Qt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12927
520 2018-04-09T20:58:38  *** zautomata1 has quit IRC
521 2018-04-09T20:59:03  *** zautomata has joined #bitcoin-core-dev
522 2018-04-09T21:00:07  *** zautomata has quit IRC
523 2018-04-09T21:00:08  *** zautomata has joined #bitcoin-core-dev
524 2018-04-09T21:00:16  *** Murch has quit IRC
525 2018-04-09T21:00:46  *** Randolf has quit IRC
526 2018-04-09T21:02:50  *** Murch has joined #bitcoin-core-dev
527 2018-04-09T21:03:15  *** Randolf has joined #bitcoin-core-dev
528 2018-04-09T21:05:42  *** freedomcode is now known as reardencode
529 2018-04-09T21:08:11  *** Randolf has quit IRC
530 2018-04-09T21:08:44  *** AaronvanW has quit IRC
531 2018-04-09T21:08:49  *** Guyver2 has quit IRC
532 2018-04-09T21:09:21  *** AaronvanW has joined #bitcoin-core-dev
533 2018-04-09T21:13:27  *** AaronvanW has quit IRC
534 2018-04-09T21:14:31  *** Krellan has joined #bitcoin-core-dev
535 2018-04-09T21:15:24  *** satwo has joined #bitcoin-core-dev
536 2018-04-09T21:17:57  *** dafunkiz_ has quit IRC
537 2018-04-09T21:19:14  *** Krellan has quit IRC
538 2018-04-09T21:23:21  *** dafunkiz_ has joined #bitcoin-core-dev
539 2018-04-09T21:28:10  <jnewbery> wumpus: I'm adding #12892 as high priority for review. Please go ahead and remove it if you don't think it merits that.
540 2018-04-09T21:28:12  <gribble> https://github.com/bitcoin/bitcoin/issues/12892 | [wallet] [rpc] introduce label API for wallet by jnewbery · Pull Request #12892 · bitcoin/bitcoin · GitHub
541 2018-04-09T21:29:01  <jnewbery> oh, looks like I'm not allowed to. It needs triage into one of the columns
542 2018-04-09T21:30:51  *** moneybal_ has joined #bitcoin-core-dev
543 2018-04-09T21:31:49  *** moneyball has quit IRC
544 2018-04-09T21:45:19  *** Victorsueca has quit IRC
545 2018-04-09T21:46:28  *** ProfMac has joined #bitcoin-core-dev
546 2018-04-09T21:46:28  *** Victorsueca has joined #bitcoin-core-dev
547 2018-04-09T21:48:59  *** Murch has quit IRC
548 2018-04-09T21:49:32  *** CubicEarths has joined #bitcoin-core-dev
549 2018-04-09T21:57:03  *** Murch has joined #bitcoin-core-dev
550 2018-04-09T21:58:04  *** moneybal_ has quit IRC
551 2018-04-09T21:59:56  *** moneyball has joined #bitcoin-core-dev
552 2018-04-09T22:02:33  *** satwo has quit IRC
553 2018-04-09T22:05:29  *** donaloconnor has quit IRC
554 2018-04-09T22:06:06  *** Randolf has joined #bitcoin-core-dev
555 2018-04-09T22:09:13  *** moneyball has quit IRC
556 2018-04-09T22:11:07  *** moneyball has joined #bitcoin-core-dev
557 2018-04-09T22:11:45  *** moneyball has quit IRC
558 2018-04-09T22:12:16  *** moneyball has joined #bitcoin-core-dev
559 2018-04-09T22:12:51  *** moneyball has quit IRC
560 2018-04-09T22:13:18  *** moneyball has joined #bitcoin-core-dev
561 2018-04-09T22:20:09  *** AaronvanW has joined #bitcoin-core-dev
562 2018-04-09T22:24:58  *** AaronvanW has quit IRC
563 2018-04-09T22:29:17  *** promag has joined #bitcoin-core-dev
564 2018-04-09T22:34:22  *** zigen has joined #bitcoin-core-dev
565 2018-04-09T22:39:03  *** zigen has quit IRC
566 2018-04-09T22:41:28  *** moneyball has quit IRC
567 2018-04-09T22:50:11  *** Emcy has quit IRC
568 2018-04-09T22:51:21  *** Emcy has joined #bitcoin-core-dev
569 2018-04-09T23:03:57  *** cryptojanitor has quit IRC
570 2018-04-09T23:09:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf8073f8d1d1...7ee6fc58f87b
571 2018-04-09T23:09:24  <bitcoin-git> bitcoin/master 23abfb7 Steve Lee: added logging line back that was accidentally removed with #10762
572 2018-04-09T23:09:25  <bitcoin-git> bitcoin/master 7ee6fc5 MarcoFalke: Merge #12845: Trivial: Add logging line in init.cpp that was accidentally removed with #10762...
573 2018-04-09T23:10:06  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12845: Trivial: Add logging line in init.cpp that was accidentally removed with #10762 (master...add_logging_line_to_newer_branch) https://github.com/bitcoin/bitcoin/pull/12845
574 2018-04-09T23:11:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee6fc58f87b...06ead15050f5
575 2018-04-09T23:11:14  <bitcoin-git> bitcoin/master 7039319 Darko Janković: Docs: fixed link, replaced QT with Qt
576 2018-04-09T23:11:15  <bitcoin-git> bitcoin/master 06ead15 MarcoFalke: Merge #12927: Docs: fixed link, replaced QT with Qt...
577 2018-04-09T23:12:10  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12927: Docs: fixed link, replaced QT with Qt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12927
578 2018-04-09T23:12:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/06ead15050f5...727175a08dff
579 2018-04-09T23:12:30  <bitcoin-git> bitcoin/master 75d0e4c Suhas Daftuar: [qa] Delete cookie file before starting node...
580 2018-04-09T23:12:31  <bitcoin-git> bitcoin/master 727175a MarcoFalke: Merge #12902: [qa] Handle potential cookie race when starting node...
581 2018-04-09T23:13:14  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12902: [qa] Handle potential cookie race when starting node (master...2018-04-improve-dbcrash-restarts) https://github.com/bitcoin/bitcoin/pull/12902
582 2018-04-09T23:21:39  *** wunpunch has quit IRC
583 2018-04-09T23:26:13  <bitcoin-git> [bitcoin] practicalswift opened pull request #12928: qt: Initialize variables previously neither defined where defined nor in constructor (master...qt-constructors) https://github.com/bitcoin/bitcoin/pull/12928
584 2018-04-09T23:29:13  *** belcher_ has quit IRC
585 2018-04-09T23:52:34  *** cryptojanitor has joined #bitcoin-core-dev
586 2018-04-09T23:53:53  *** satwo has joined #bitcoin-core-dev