1 2018-04-18T00:00:02  *** weez17 has quit IRC
  2 2018-04-18T00:00:39  *** weez17 has joined #bitcoin-core-dev
  3 2018-04-18T00:01:27  *** grafcaps has joined #bitcoin-core-dev
  4 2018-04-18T00:02:53  *** techspartan has joined #bitcoin-core-dev
  5 2018-04-18T00:05:42  *** grafcaps has quit IRC
  6 2018-04-18T00:06:17  *** shtirlic_ has quit IRC
  7 2018-04-18T00:08:57  *** shtirlic_ has joined #bitcoin-core-dev
  8 2018-04-18T00:10:28  *** grafcaps has joined #bitcoin-core-dev
  9 2018-04-18T00:14:27  *** grafcaps has quit IRC
 10 2018-04-18T00:28:29  *** grafcaps has joined #bitcoin-core-dev
 11 2018-04-18T00:29:51  *** cryptojanitor has joined #bitcoin-core-dev
 12 2018-04-18T00:32:53  *** grafcaps has quit IRC
 13 2018-04-18T00:36:56  *** techspartan has quit IRC
 14 2018-04-18T00:37:31  *** grafcaps has joined #bitcoin-core-dev
 15 2018-04-18T00:40:46  *** shtirlic_ has quit IRC
 16 2018-04-18T00:42:07  *** grafcaps has quit IRC
 17 2018-04-18T00:45:05  *** shtirlic_ has joined #bitcoin-core-dev
 18 2018-04-18T00:46:31  *** grafcaps has joined #bitcoin-core-dev
 19 2018-04-18T00:50:43  *** grafcaps has quit IRC
 20 2018-04-18T00:55:32  *** grafcaps has joined #bitcoin-core-dev
 21 2018-04-18T00:57:10  *** MatthewH1 has joined #bitcoin-core-dev
 22 2018-04-18T00:59:57  *** grafcaps has quit IRC
 23 2018-04-18T01:04:33  *** grafcaps has joined #bitcoin-core-dev
 24 2018-04-18T01:09:21  *** grafcaps has quit IRC
 25 2018-04-18T01:09:42  *** jtimon_ has quit IRC
 26 2018-04-18T01:12:58  *** MatthewH1 has quit IRC
 27 2018-04-18T01:13:34  *** grafcaps has joined #bitcoin-core-dev
 28 2018-04-18T01:17:21  *** shtirlic_ has quit IRC
 29 2018-04-18T01:17:55  *** grafcaps has quit IRC
 30 2018-04-18T01:20:00  *** shtirlic_ has joined #bitcoin-core-dev
 31 2018-04-18T01:27:38  *** shtirlic_ has quit IRC
 32 2018-04-18T01:28:12  *** shtirlic_ has joined #bitcoin-core-dev
 33 2018-04-18T01:42:07  *** zigen has joined #bitcoin-core-dev
 34 2018-04-18T01:49:08  *** grafcaps has joined #bitcoin-core-dev
 35 2018-04-18T01:52:24  *** isis_ is now known as isis
 36 2018-04-18T01:56:48  *** Murch has quit IRC
 37 2018-04-18T01:57:22  *** Murch has joined #bitcoin-core-dev
 38 2018-04-18T02:02:00  *** Murch has quit IRC
 39 2018-04-18T02:06:05  *** Giszmo has quit IRC
 40 2018-04-18T02:08:09  *** AaronvanW has quit IRC
 41 2018-04-18T02:15:35  *** Krellan has quit IRC
 42 2018-04-18T02:15:44  *** jtimon has quit IRC
 43 2018-04-18T02:22:07  *** Giszmo has joined #bitcoin-core-dev
 44 2018-04-18T02:32:40  *** Samdney has quit IRC
 45 2018-04-18T03:09:58  *** zigen has quit IRC
 46 2018-04-18T03:58:07  *** go1111111 has quit IRC
 47 2018-04-18T04:07:06  *** grafcaps has quit IRC
 48 2018-04-18T04:12:54  *** Randolf has quit IRC
 49 2018-04-18T04:30:50  *** fanquake has joined #bitcoin-core-dev
 50 2018-04-18T04:44:05  <kallewoof> RFC: I started on a file format for storing mempool history -> https://bc-2.jp/mempool%20file%20format.txt (sorry if off-topic)
 51 2018-04-18T04:54:34  <fanquake> kallewoof sounds on-topic
 52 2018-04-18T04:58:02  <kallewoof> fanquake: Thanks, it felt borderline. Btw did that gist work for you?
 53 2018-04-18T04:59:28  *** cryptojanitor has quit IRC
 54 2018-04-18T05:01:34  <fanquake> kallewoof Sorry that's the next thing I'm working on. Got stuck inside Windows reviewing :(
 55 2018-04-18T05:02:32  *** ctrlbreak has quit IRC
 56 2018-04-18T05:02:55  *** ctrlbreak has joined #bitcoin-core-dev
 57 2018-04-18T05:03:10  <kallewoof> fanquake: NP!
 58 2018-04-18T05:05:02  <sipa> complete.
 59 2018-04-18T05:06:31  <aj> kallewoof: gist worked for me fwiw (i'd missed running autogen under scan-build)
 60 2018-04-18T05:23:23  *** fanquake has quit IRC
 61 2018-04-18T05:26:43  <kallewoof> aj: Great!
 62 2018-04-18T05:28:50  *** booyah has quit IRC
 63 2018-04-18T05:40:03  *** lnostdal has joined #bitcoin-core-dev
 64 2018-04-18T05:41:17  *** zigen has joined #bitcoin-core-dev
 65 2018-04-18T05:43:34  <wumpus> kallewoof: IMO it' technical and specific enough to be on-topic
 66 2018-04-18T05:52:49  <kallewoof> wumpus: Okay. Technical+specific makes sense to me.
 67 2018-04-18T05:53:19  <kallewoof> FWIW, I made a gist version: https://gist.github.com/kallewoof/8f722c4365cdfad88b845d1f3cb1bd9f#file-mff-txt
 68 2018-04-18T05:56:31  <wumpus> you're not the first to do this but probably the first to try to formalize the data format. There's also some synergies with e.g. the zmq notification protocol here.
 69 2018-04-18T06:01:28  <aj> kallewoof: fwiw, i have about 12GB of compressed mempool tx data from the last few months, with the idea to some day analyse if any of the non-confirming txes display any interesting behaviour
 70 2018-04-18T06:01:51  <aj> kallewoof: the 1-satoshi-is-plenty phase started shortly after i started keeping track though, so it's probably boring :(
 71 2018-04-18T06:01:55  <wumpus> after all, a log format is pretty much *concatanate all the notifications*
 72 2018-04-18T06:02:35  <aj> kallewoof: (my data is basically hexified zmq data, with a timestamp, then lz compressed)
 73 2018-04-18T06:05:30  <aj> kallewoof: includeconf travis -- test_runner is failing travis of the warning stderr output i think?
 74 2018-04-18T06:07:50  <kallewoof> aj: Oh, you have data? I would love to get my hands on it!
 75 2018-04-18T06:08:25  <kallewoof> wumpus: I figured, yeah. Having a formalized format would be beneficial I think, unless the format is crap. (Hence RFC :) )
 76 2018-04-18T06:08:34  <wumpus> kallewoof: yes
 77 2018-04-18T06:08:44  <kallewoof> aj: Ah... of course. I'll switch to regular printf()..
 78 2018-04-18T06:09:22  *** fanquake has joined #bitcoin-core-dev
 79 2018-04-18T06:09:39  <kallewoof> wumpus: I should def look at zmq notification protocol, yeah. I forgot about that.
 80 2018-04-18T06:10:45  <wumpus> kallewoof: but you have a good point I think the difference conceptually is that the zmq notification protocol is specific to bitcoin core, and includes some specific implementation details, while you're trying to make a more general exchange format
 81 2018-04-18T06:11:01  <wumpus> (e.g. we have many more mempool retirement reasons, but some of those are very specific)
 82 2018-04-18T06:11:49  <fanquake> kallewoof Followed static analyzer your steps, seems to be working correctly. Cheers.
 83 2018-04-18T06:11:58  <kallewoof> wumpus: What other than 'old not confirmed', 'rbf-replaced', and 'double-spent-in-block'?
 84 2018-04-18T06:12:10  <kallewoof> fanquake: Cool :)
 85 2018-04-18T06:12:31  <wumpus> kallewoof: see MemPoolRemovalReason enum
 86 2018-04-18T06:13:03  <kallewoof> wumpus: Will do!
 87 2018-04-18T06:13:13  <aj> kallewoof: http://azure.erisian.com.au/~aj/tmp/kalle/ has data from yesterday (24 hours, 1000 UTC - 0959 UTC ish) and the logging script
 88 2018-04-18T06:13:48  <aj> kallewoof: most of the data's behind my home internet which will make getting it out usefully less than easy :)
 89 2018-04-18T06:13:50  <kallewoof> aj: Nice. Downloading
 90 2018-04-18T06:14:27  <kallewoof> aj: Would access to an ssh machine somewhere be helpful?
 91 2018-04-18T06:14:37  <kallewoof> s/ssh machine/ssh account/
 92 2018-04-18T06:15:51  <aj> kallewoof: maybe? somewhere with disk to put it would be helpful; otherwise it's just upstream-b/w-bound
 93 2018-04-18T06:16:42  <kallewoof> aj: Wasn't sure if your problem is bandwidth or simply don't have a disk online with enough space. I can give you access to a digital ocean machine somewhere.
 94 2018-04-18T06:19:02  <kallewoof> aj: I got the files. Thanks, will check soon :)
 95 2018-04-18T06:19:11  *** crt4 has joined #bitcoin-core-dev
 96 2018-04-18T06:19:11  <aj> kallewoof: well, probably be more useful to see if the data's actually interesting; b/w and storage i can solve myself without too much hassle :)
 97 2018-04-18T06:19:41  <kallewoof> aj: Makes sense yeah
 98 2018-04-18T06:20:32  *** fanquake has quit IRC
 99 2018-04-18T06:20:52  *** fanquake has joined #bitcoin-core-dev
100 2018-04-18T06:21:34  *** fanquake has joined #bitcoin-core-dev
101 2018-04-18T06:22:05  *** fanquake has quit IRC
102 2018-04-18T06:22:26  *** fanquake has joined #bitcoin-core-dev
103 2018-04-18T06:24:06  *** fanquake has joined #bitcoin-core-dev
104 2018-04-18T06:29:00  *** promag has joined #bitcoin-core-dev
105 2018-04-18T06:29:47  *** TheCharlatan has quit IRC
106 2018-04-18T06:35:34  *** rymism has joined #bitcoin-core-dev
107 2018-04-18T06:37:11  *** promag has quit IRC
108 2018-04-18T06:39:49  *** Krellan has joined #bitcoin-core-dev
109 2018-04-18T06:45:50  *** Randolf has joined #bitcoin-core-dev
110 2018-04-18T06:54:46  *** grafcaps has joined #bitcoin-core-dev
111 2018-04-18T06:57:26  *** promag has joined #bitcoin-core-dev
112 2018-04-18T06:59:22  *** grafcaps has quit IRC
113 2018-04-18T07:00:08  *** Randolf has quit IRC
114 2018-04-18T07:02:02  *** d9b4bef9 has quit IRC
115 2018-04-18T07:03:06  <jonasschnelli> If someone is interested, one of my machines does dump the mempool (mammempool 300MB) every hour since a couple of month... a lot of data though
116 2018-04-18T07:03:07  *** d9b4bef9 has joined #bitcoin-core-dev
117 2018-04-18T07:05:34  *** promag has quit IRC
118 2018-04-18T07:07:51  <wumpus> the incremental format is probably slightly more efficient in storage, sounds like dumping the entire thing every hour will get you a lot of duplicate data, though compression helps ofc
119 2018-04-18T07:10:17  *** ProfMac has quit IRC
120 2018-04-18T07:10:37  <jonasschnelli> Yes! I had to trade off storage space vs. implementing an incremental dump solution
121 2018-04-18T07:12:06  <wumpus> yep
122 2018-04-18T07:13:01  <fanquake> jonasschnelli Thanks
123 2018-04-18T07:13:51  <jonasschnelli> fanquake: I need to finish my IRC bot that allows triggering a gitian build on my machine
124 2018-04-18T07:14:10  *** anstaendig has quit IRC
125 2018-04-18T07:15:39  <jonasschnelli> Building all pull requests would require a couple of machines (=much more expensive setup)
126 2018-04-18T07:16:39  *** anstaendig has joined #bitcoin-core-dev
127 2018-04-18T07:16:50  <wumpus> indeed, I think it's better to have it as something manually triggered, at least at first, can always be automatized if there's need for it
128 2018-04-18T07:18:11  <jonasschnelli> Also, there are risks running pre-built binaries...
129 2018-04-18T07:19:15  <wumpus> yes, there are security issues with building ,as well as hosting binaries for PRs that no human has looked at
130 2018-04-18T07:21:06  <fanquake> handy way for someone to submit a malicious PR and get their binaries built ready for distribution
131 2018-04-18T07:21:14  *** promag has joined #bitcoin-core-dev
132 2018-04-18T07:21:30  <wumpus> exactly
133 2018-04-18T07:22:06  *** promag has quit IRC
134 2018-04-18T07:22:34  <wumpus> it does leave one hell of an audit trail, so I doubt it's the best way to parasitize on someone else's infrastructure to host binaries, but still we really want to avoid it
135 2018-04-18T07:22:49  <jonasschnelli> Trigger a build could be protected over a github username (via special comment) or via an IRC handle. Both not very secure... additionally a gpg signature coule be added
136 2018-04-18T07:23:18  *** ProfMac has joined #bitcoin-core-dev
137 2018-04-18T07:24:58  <wumpus> jonasschnelli: well as long as you check that freenode user is authenticated and using TLS, your only worry is that freenode itself is compromised, it's unlikely anyone will go that far to trigger a build :-)
138 2018-04-18T07:25:17  <jonasschnelli> heh,  true.
139 2018-04-18T07:25:27  <wumpus> same for spoofing github handles I think
140 2018-04-18T07:25:50  <fanquake> Probably easier to spin up some EC2 instances using credit cards before compromising the freenode infrastructure
141 2018-04-18T07:25:57  <fanquake> *stolen credit cards
142 2018-04-18T07:30:05  <fanquake> wumpus Did you want to merge #12715 tomorrow or the day after? I've just about finished testing, looks like it's ready to go. Just want to minimise disruption.
143 2018-04-18T07:30:06  <gribble> https://github.com/bitcoin/bitcoin/issues/12715 | depends: Add make clean rule by hkjn · Pull Request #12715 · bitcoin/bitcoin · GitHub
144 2018-04-18T07:35:21  *** ProfMac has quit IRC
145 2018-04-18T07:39:58  *** ccook has quit IRC
146 2018-04-18T07:41:08  *** ProfMac has joined #bitcoin-core-dev
147 2018-04-18T07:42:12  *** goatpig has joined #bitcoin-core-dev
148 2018-04-18T07:42:31  *** ccook has joined #bitcoin-core-dev
149 2018-04-18T07:48:52  *** Randolf has joined #bitcoin-core-dev
150 2018-04-18T07:48:59  *** zarez has joined #bitcoin-core-dev
151 2018-04-18T07:49:38  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #13014: Allow txindex in prune mode (master...2018/04/txindex_prune) https://github.com/bitcoin/bitcoin/pull/13014
152 2018-04-18T07:51:27  *** wolfspraul has quit IRC
153 2018-04-18T07:51:33  *** zigen has quit IRC
154 2018-04-18T07:51:44  *** wolfspraul has joined #bitcoin-core-dev
155 2018-04-18T07:52:08  *** zigen has joined #bitcoin-core-dev
156 2018-04-18T07:52:49  <jonasschnelli> wow... I can load #11857 again
157 2018-04-18T07:52:54  <gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
158 2018-04-18T07:52:59  <jonasschnelli> no "github unicorn"
159 2018-04-18T07:55:58  <luke-jr> (I can't)
160 2018-04-18T07:56:29  *** zigen has quit IRC
161 2018-04-18T07:56:41  *** zigen has joined #bitcoin-core-dev
162 2018-04-18T07:57:59  *** laurentmt has joined #bitcoin-core-dev
163 2018-04-18T07:58:15  *** wxss has joined #bitcoin-core-dev
164 2018-04-18T07:58:46  <fanquake> (neither)
165 2018-04-18T07:59:07  *** laurentmt has quit IRC
166 2018-04-18T08:01:22  *** zigen has quit IRC
167 2018-04-18T08:01:37  <jonasschnelli> hmm...
168 2018-04-18T08:01:38  *** zigen has joined #bitcoin-core-dev
169 2018-04-18T08:02:04  <jonasschnelli> I don't see the reason why this PR needs more time to load...
170 2018-04-18T08:02:32  <jonasschnelli> Maybe we reopen a new PR (could be a comment that blocks it) or jimpo tries to rebase and force push
171 2018-04-18T08:02:57  <jonasschnelli> It's a bit odd that we have a high-prio PR that can't be discussed.
172 2018-04-18T08:07:21  *** anstaendig has quit IRC
173 2018-04-18T08:08:29  <fanquake> It's loading now, so it must just be some temporary issue.
174 2018-04-18T08:08:32  <jonasschnelli> fanquake@testing is on fire!
175 2018-04-18T08:10:46  *** setpill has joined #bitcoin-core-dev
176 2018-04-18T08:11:35  *** timothy has joined #bitcoin-core-dev
177 2018-04-18T08:19:07  *** fanquake has quit IRC
178 2018-04-18T08:21:33  *** crt4 has quit IRC
179 2018-04-18T08:24:05  *** booyah has joined #bitcoin-core-dev
180 2018-04-18T08:26:54  *** timothy has quit IRC
181 2018-04-18T08:29:59  *** timothy has joined #bitcoin-core-dev
182 2018-04-18T08:34:29  *** drizztbsd has joined #bitcoin-core-dev
183 2018-04-18T08:35:06  *** timothy has quit IRC
184 2018-04-18T08:38:37  *** paracyst_ has joined #bitcoin-core-dev
185 2018-04-18T08:38:48  *** ctrlbreak has quit IRC
186 2018-04-18T08:38:59  *** paracyst has quit IRC
187 2018-04-18T08:39:02  *** ctrlbreak has joined #bitcoin-core-dev
188 2018-04-18T08:50:14  *** ProfMac has quit IRC
189 2018-04-18T08:51:25  *** grafcaps has joined #bitcoin-core-dev
190 2018-04-18T08:55:47  *** grafcaps has quit IRC
191 2018-04-18T08:56:23  *** crt4 has joined #bitcoin-core-dev
192 2018-04-18T08:57:27  *** Krellan has quit IRC
193 2018-04-18T09:00:55  *** meshcollider has joined #bitcoin-core-dev
194 2018-04-18T09:02:54  *** Krellan has joined #bitcoin-core-dev
195 2018-04-18T09:09:21  *** shesek has quit IRC
196 2018-04-18T09:14:03  *** ProfMac has joined #bitcoin-core-dev
197 2018-04-18T09:23:52  *** drizztbsd has quit IRC
198 2018-04-18T09:25:03  *** drizztbsd has joined #bitcoin-core-dev
199 2018-04-18T09:28:53  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3a8a4dc4a130...8fd62437c683
200 2018-04-18T09:28:53  <bitcoin-git> bitcoin/master aff16fd Henrik Jonsson: depends: Add 'make clean' and 'make clean-all' rules...
201 2018-04-18T09:28:54  <bitcoin-git> bitcoin/master 8fd6243 Wladimir J. van der Laan: Merge #12715: depends: Add 'make clean' rule...
202 2018-04-18T09:29:39  <bitcoin-git> [bitcoin] laanwj closed pull request #12715: depends: Add 'make clean' rule (master...clean-depends) https://github.com/bitcoin/bitcoin/pull/12715
203 2018-04-18T09:30:41  *** fanquake has joined #bitcoin-core-dev
204 2018-04-18T09:30:54  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8fd62437c683...0d12570a8037
205 2018-04-18T09:30:54  <bitcoin-git> bitcoin/master d41a420 João Barbosa: test: Fix dangling wallet pointer in vpwallets
206 2018-04-18T09:30:55  <bitcoin-git> bitcoin/master 0d12570 Wladimir J. van der Laan: Merge #13007: test: Fix dangling wallet pointer in vpwallets...
207 2018-04-18T09:31:38  <bitcoin-git> [bitcoin] laanwj closed pull request #13007: test: Fix dangling wallet pointer in vpwallets (master...2018-04-fixwallettest) https://github.com/bitcoin/bitcoin/pull/13007
208 2018-04-18T09:33:13  *** jtimon has joined #bitcoin-core-dev
209 2018-04-18T09:34:48  *** zautomata2 has joined #bitcoin-core-dev
210 2018-04-18T09:34:58  *** shesek has joined #bitcoin-core-dev
211 2018-04-18T09:34:58  *** shesek has joined #bitcoin-core-dev
212 2018-04-18T09:35:20  *** zautomata1 has quit IRC
213 2018-04-18T09:39:05  *** zautomata3 has joined #bitcoin-core-dev
214 2018-04-18T09:39:55  <fanquake> wumpus In agreement to close #12990 ?
215 2018-04-18T09:39:57  <gribble> https://github.com/bitcoin/bitcoin/issues/12990 | depends: Fix libX11 build on gcc 8 by MarcoFalke · Pull Request #12990 · bitcoin/bitcoin · GitHub
216 2018-04-18T09:40:05  *** zautomata2 has quit IRC
217 2018-04-18T09:40:42  <wumpus> <jonasschnelli> fanquake@testing is on fire! <- yeah, thanks for all the testing!
218 2018-04-18T09:40:47  <wumpus> fanquake: will take a look
219 2018-04-18T09:41:10  *** crt4 has quit IRC
220 2018-04-18T09:41:49  <wumpus> fanquake: I was leaving that to marcofalke, but I guess, as we all seem to agree we can just close it, someone who needs the patch right now could always pull that branch I guess...
221 2018-04-18T09:42:08  <bitcoin-git> [bitcoin] laanwj closed pull request #12990: depends: Fix libX11 build on gcc 8 (master...Mf1804-dependsGCC8Fix) https://github.com/bitcoin/bitcoin/pull/12990
222 2018-04-18T09:48:08  *** zautomata3 has quit IRC
223 2018-04-18T09:50:59  *** zautomata has joined #bitcoin-core-dev
224 2018-04-18T09:52:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d12570a8037...615f7c288414
225 2018-04-18T09:52:41  <bitcoin-git> bitcoin/master 7d8a8cc JeremyRand: Avoid launching as admin when NSIS installer ends....
226 2018-04-18T09:52:42  <bitcoin-git> bitcoin/master 615f7c2 Wladimir J. van der Laan: Merge #12985: Windows: Avoid launching as admin when NSIS installer ends....
227 2018-04-18T09:53:28  <bitcoin-git> [bitcoin] laanwj closed pull request #12985: Windows: Avoid launching as admin when NSIS installer ends. (master...nsis-de-elevate) https://github.com/bitcoin/bitcoin/pull/12985
228 2018-04-18T10:00:26  *** zautomata1 has joined #bitcoin-core-dev
229 2018-04-18T10:00:48  *** zautomata has quit IRC
230 2018-04-18T10:09:37  *** zautomata1 has quit IRC
231 2018-04-18T10:10:02  *** zautomata has joined #bitcoin-core-dev
232 2018-04-18T10:19:53  <michagogo_> wumpus: #12985 may be problematic
233 2018-04-18T10:19:55  <gribble> https://github.com/bitcoin/bitcoin/issues/12985 | Windows: Avoid launching as admin when NSIS installer ends. by JeremyRand · Pull Request #12985 · bitcoin/bitcoin · GitHub
234 2018-04-18T10:19:56  <michagogo_> https://mdb-blog.blogspot.com/2013/01/nsis-lunch-program-as-user-from-uac.html?showComment=1388694317801#c939517856791332836
235 2018-04-18T10:20:21  *** ProfMac has quit IRC
236 2018-04-18T10:25:12  *** opdenkamp has quit IRC
237 2018-04-18T10:25:41  *** michagogo_ is now known as michagogo
238 2018-04-18T10:32:49  *** opdenkamp has joined #bitcoin-core-dev
239 2018-04-18T10:34:28  *** zigen has quit IRC
240 2018-04-18T10:35:02  *** zigen has joined #bitcoin-core-dev
241 2018-04-18T10:35:56  *** zigen has joined #bitcoin-core-dev
242 2018-04-18T10:42:19  *** wolfspraul has quit IRC
243 2018-04-18T10:42:28  *** wolfspraul has joined #bitcoin-core-dev
244 2018-04-18T10:44:07  *** wolfspraul has quit IRC
245 2018-04-18T10:44:18  *** wolfspraul has joined #bitcoin-core-dev
246 2018-04-18T10:45:02  *** d9b4bef9 has quit IRC
247 2018-04-18T10:46:09  *** d9b4bef9 has joined #bitcoin-core-dev
248 2018-04-18T10:47:01  *** d9b4bef9 has quit IRC
249 2018-04-18T10:48:08  *** d9b4bef9 has joined #bitcoin-core-dev
250 2018-04-18T10:49:39  *** wolfspraul has quit IRC
251 2018-04-18T10:50:16  *** wolfspraul has joined #bitcoin-core-dev
252 2018-04-18T10:51:44  *** fanquake has quit IRC
253 2018-04-18T10:54:11  *** crt4 has joined #bitcoin-core-dev
254 2018-04-18T10:56:10  *** shesek has quit IRC
255 2018-04-18T10:59:18  *** wolfspraul has quit IRC
256 2018-04-18T10:59:42  *** wolfspraul has joined #bitcoin-core-dev
257 2018-04-18T11:04:26  *** zigen has quit IRC
258 2018-04-18T11:05:01  *** zigen has joined #bitcoin-core-dev
259 2018-04-18T11:09:31  *** zigen has quit IRC
260 2018-04-18T11:16:56  *** Krellan has quit IRC
261 2018-04-18T11:18:08  *** Krellan has joined #bitcoin-core-dev
262 2018-04-18T11:23:35  *** Giszmo has quit IRC
263 2018-04-18T11:24:49  *** CubicEarths has quit IRC
264 2018-04-18T11:25:30  *** CubicEarths has joined #bitcoin-core-dev
265 2018-04-18T11:27:32  *** timothy has joined #bitcoin-core-dev
266 2018-04-18T11:27:51  *** drizztbsd has quit IRC
267 2018-04-18T11:31:36  *** CubicEarths has quit IRC
268 2018-04-18T11:36:55  <bitcoin-git> [bitcoin] Empact closed pull request #12991: Remove unused default args to Invalid and DoS (master...remove-unused-default-args-dos) https://github.com/bitcoin/bitcoin/pull/12991
269 2018-04-18T11:38:24  *** Giszmo has joined #bitcoin-core-dev
270 2018-04-18T11:38:37  *** crt4 has quit IRC
271 2018-04-18T11:40:29  *** SopaXorzTaker has joined #bitcoin-core-dev
272 2018-04-18T11:40:43  *** crt4 has joined #bitcoin-core-dev
273 2018-04-18T11:50:45  *** AaronvanW has joined #bitcoin-core-dev
274 2018-04-18T11:52:07  *** Aaronvan_ has joined #bitcoin-core-dev
275 2018-04-18T11:55:27  *** AaronvanW has quit IRC
276 2018-04-18T12:00:58  *** crt4 has quit IRC
277 2018-04-18T12:02:17  *** pergaminho has joined #bitcoin-core-dev
278 2018-04-18T12:08:07  *** promag has joined #bitcoin-core-dev
279 2018-04-18T12:08:10  *** BGL has quit IRC
280 2018-04-18T12:08:52  *** crt4 has joined #bitcoin-core-dev
281 2018-04-18T12:10:05  *** crt4 has quit IRC
282 2018-04-18T12:10:05  *** zigen has joined #bitcoin-core-dev
283 2018-04-18T12:11:30  <bitcoin-git> [bitcoin] Empact opened pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (master...g-failed-blocks) https://github.com/bitcoin/bitcoin/pull/13016
284 2018-04-18T12:11:44  *** votefrac has joined #bitcoin-core-dev
285 2018-04-18T12:14:26  *** zigen has quit IRC
286 2018-04-18T12:22:39  *** CubicEarths has joined #bitcoin-core-dev
287 2018-04-18T12:27:41  *** grafcaps has joined #bitcoin-core-dev
288 2018-04-18T12:28:42  *** Aaronvan_ has quit IRC
289 2018-04-18T12:29:18  *** AaronvanW has joined #bitcoin-core-dev
290 2018-04-18T12:32:32  *** CubicEarths has quit IRC
291 2018-04-18T12:32:41  *** grafcaps has quit IRC
292 2018-04-18T12:34:40  *** votefrac has quit IRC
293 2018-04-18T12:35:08  *** Krellan has quit IRC
294 2018-04-18T12:38:28  *** Krellan has joined #bitcoin-core-dev
295 2018-04-18T12:38:45  <bitcoin-git> [bitcoin] promag opened pull request #13017: Add AddWallet, RemoveWallet, GetWallet and GetWallets (master...2018-04-vpwallets) https://github.com/bitcoin/bitcoin/pull/13017
296 2018-04-18T12:39:30  <bitcoin-git> [bitcoin] Empact opened pull request #13018: Make AbortNode function static (master...abort-node-static) https://github.com/bitcoin/bitcoin/pull/13018
297 2018-04-18T12:46:37  *** ProfMac has joined #bitcoin-core-dev
298 2018-04-18T12:51:25  *** ProfMac has quit IRC
299 2018-04-18T12:52:37  *** ProfMac has joined #bitcoin-core-dev
300 2018-04-18T13:01:05  *** ProfMac has quit IRC
301 2018-04-18T13:05:17  <bitcoin-git> [bitcoin] Empact closed pull request #13018: Make AbortNode function static (master...abort-node-static) https://github.com/bitcoin/bitcoin/pull/13018
302 2018-04-18T13:08:04  *** CubicEarths has joined #bitcoin-core-dev
303 2018-04-18T13:13:37  *** Aaronvan_ has joined #bitcoin-core-dev
304 2018-04-18T13:15:38  *** AaronvanW has quit IRC
305 2018-04-18T13:23:23  *** promag has quit IRC
306 2018-04-18T13:24:10  *** promag has joined #bitcoin-core-dev
307 2018-04-18T13:38:33  *** promag has quit IRC
308 2018-04-18T13:50:54  *** Guyver2 has joined #bitcoin-core-dev
309 2018-04-18T13:54:58  *** promag has joined #bitcoin-core-dev
310 2018-04-18T13:56:33  *** Krellan has quit IRC
311 2018-04-18T13:58:48  *** Krellan has joined #bitcoin-core-dev
312 2018-04-18T14:02:08  *** rymism has quit IRC
313 2018-04-18T14:18:53  *** Giszmo has quit IRC
314 2018-04-18T14:21:01  *** zigen has joined #bitcoin-core-dev
315 2018-04-18T14:22:17  *** zautomata1 has joined #bitcoin-core-dev
316 2018-04-18T14:22:56  *** Giszmo has joined #bitcoin-core-dev
317 2018-04-18T14:23:46  *** zautomata has quit IRC
318 2018-04-18T14:25:41  *** zigen has quit IRC
319 2018-04-18T14:26:31  *** zautomata2 has joined #bitcoin-core-dev
320 2018-04-18T14:27:01  *** Giszmo has quit IRC
321 2018-04-18T14:27:36  *** zautomata1 has quit IRC
322 2018-04-18T14:30:49  *** Krellan has quit IRC
323 2018-04-18T14:31:58  *** Aaronvan_ is now known as AaronvanW
324 2018-04-18T14:33:57  *** Krellan has joined #bitcoin-core-dev
325 2018-04-18T14:36:28  *** promag has quit IRC
326 2018-04-18T14:37:44  *** shesek has joined #bitcoin-core-dev
327 2018-04-18T14:37:45  *** shesek has joined #bitcoin-core-dev
328 2018-04-18T14:38:21  *** Krellan has quit IRC
329 2018-04-18T14:39:41  *** zarez has quit IRC
330 2018-04-18T14:44:42  *** Nurlan23 has joined #bitcoin-core-dev
331 2018-04-18T14:44:50  <Nurlan23> Hi ya all!
332 2018-04-18T14:45:27  *** Nurlan23 has quit IRC
333 2018-04-18T14:48:53  *** Krellan has joined #bitcoin-core-dev
334 2018-04-18T14:49:04  *** grafcaps has joined #bitcoin-core-dev
335 2018-04-18T14:50:55  <jamesob> jonasschnelli luke-jr fanquake: #11857 loads pretty reliably when emulating a mobile device using chrome's developer tools :)
336 2018-04-18T14:51:00  <gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
337 2018-04-18T15:02:37  *** ProfMac has joined #bitcoin-core-dev
338 2018-04-18T15:03:04  *** Giszmo has joined #bitcoin-core-dev
339 2018-04-18T15:07:00  *** promag has joined #bitcoin-core-dev
340 2018-04-18T15:07:09  *** laurentmt has joined #bitcoin-core-dev
341 2018-04-18T15:10:16  *** CubicEarths has quit IRC
342 2018-04-18T15:11:01  *** crt4 has joined #bitcoin-core-dev
343 2018-04-18T15:11:37  *** Murch has joined #bitcoin-core-dev
344 2018-04-18T15:11:48  *** promag has quit IRC
345 2018-04-18T15:13:58  *** Samdney has joined #bitcoin-core-dev
346 2018-04-18T15:14:34  *** zarez has joined #bitcoin-core-dev
347 2018-04-18T15:18:36  <instagibbs> huh, loaded it in incognito browser, and now it just works for me
348 2018-04-18T15:19:12  <instagibbs> oops false alarm, hit or miss
349 2018-04-18T15:19:57  <instagibbs> incognito works reliably here
350 2018-04-18T15:21:51  *** Dizzle has joined #bitcoin-core-dev
351 2018-04-18T15:29:00  *** cubancorona has joined #bitcoin-core-dev
352 2018-04-18T15:31:50  *** CubicEarths has joined #bitcoin-core-dev
353 2018-04-18T15:32:23  <jonasschnelli> Indeed. Private browsing mitigates. Strange!
354 2018-04-18T15:33:13  *** rafalcpp has quit IRC
355 2018-04-18T15:36:14  *** BGL has joined #bitcoin-core-dev
356 2018-04-18T15:40:40  *** meshcollider has quit IRC
357 2018-04-18T15:46:04  *** Randolf has quit IRC
358 2018-04-18T15:46:05  *** Giszmo has quit IRC
359 2018-04-18T15:46:28  <MarcoFalke> wumpus: minor nit: It says 15.99 on https://dev.visucore.com/bitcoin/doxygen/index.html ; I guess you'd have to run ./configure before generating the docs?
360 2018-04-18T15:49:27  *** CubicEarths has quit IRC
361 2018-04-18T15:49:51  *** CubicEarths has joined #bitcoin-core-dev
362 2018-04-18T15:52:08  <bitcoin-git> [bitcoin] Empact opened pull request #13019: Trivial: Consistently use FormatStateMessage (master...format-state-message) https://github.com/bitcoin/bitcoin/pull/13019
363 2018-04-18T15:56:20  *** CubicEarths has quit IRC
364 2018-04-18T16:04:38  *** Giszmo has joined #bitcoin-core-dev
365 2018-04-18T16:05:44  *** cubancorona has quit IRC
366 2018-04-18T16:06:07  *** cubancorona has joined #bitcoin-core-dev
367 2018-04-18T16:15:55  <bitcoin-git> [bitcoin] Empact opened pull request #13020: Consistently log CValidationState on call failure (master...log-cvalidation-state) https://github.com/bitcoin/bitcoin/pull/13020
368 2018-04-18T16:16:21  *** shesek has quit IRC
369 2018-04-18T16:22:05  *** cryptojanitor has joined #bitcoin-core-dev
370 2018-04-18T16:22:46  *** cubancorona has quit IRC
371 2018-04-18T16:22:48  *** zigen has joined #bitcoin-core-dev
372 2018-04-18T16:24:14  *** cubancorona has joined #bitcoin-core-dev
373 2018-04-18T16:24:52  *** Randolf has joined #bitcoin-core-dev
374 2018-04-18T16:27:22  *** zigen has quit IRC
375 2018-04-18T16:28:13  *** Dizzle has quit IRC
376 2018-04-18T16:29:42  <cubancorona> hi, all
377 2018-04-18T16:30:54  <cubancorona> I think signrawtransaction -prextxs should take the json output from decoderawtransaction.  Any reason why not?
378 2018-04-18T16:32:31  *** crt4 has quit IRC
379 2018-04-18T16:32:50  *** lnostdal has quit IRC
380 2018-04-18T16:38:35  *** cubancorona has quit IRC
381 2018-04-18T16:41:35  *** dcousens has quit IRC
382 2018-04-18T16:42:25  *** dcousens has joined #bitcoin-core-dev
383 2018-04-18T16:46:19  *** anstaendig has joined #bitcoin-core-dev
384 2018-04-18T16:48:02  *** zautomata2 has quit IRC
385 2018-04-18T16:56:55  *** zarez has quit IRC
386 2018-04-18T16:59:09  *** StopAndDecrypt has quit IRC
387 2018-04-18T17:00:47  *** Krellan has quit IRC
388 2018-04-18T17:03:14  *** anstaendig has quit IRC
389 2018-04-18T17:11:58  *** crt4 has joined #bitcoin-core-dev
390 2018-04-18T17:12:04  *** Giszmo has quit IRC
391 2018-04-18T17:18:37  *** Krellan has joined #bitcoin-core-dev
392 2018-04-18T17:19:52  <bitcoin-git> [bitcoin] jimpo opened pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (master...logging-files) https://github.com/bitcoin/bitcoin/pull/13021
393 2018-04-18T17:28:07  *** Giszmo has joined #bitcoin-core-dev
394 2018-04-18T17:29:22  *** setpill has quit IRC
395 2018-04-18T17:30:22  *** crt4 has quit IRC
396 2018-04-18T17:36:22  *** anstaendig has joined #bitcoin-core-dev
397 2018-04-18T17:37:17  *** promag has joined #bitcoin-core-dev
398 2018-04-18T17:51:25  *** Giszmo has quit IRC
399 2018-04-18T17:56:06  *** shesek has joined #bitcoin-core-dev
400 2018-04-18T17:56:06  *** shesek has joined #bitcoin-core-dev
401 2018-04-18T18:03:32  *** Dizzle has joined #bitcoin-core-dev
402 2018-04-18T18:03:58  *** laurentmt has quit IRC
403 2018-04-18T18:04:39  *** CubicEarths has joined #bitcoin-core-dev
404 2018-04-18T18:06:06  *** SopaXorzTaker has quit IRC
405 2018-04-18T18:06:21  *** Giszmo has joined #bitcoin-core-dev
406 2018-04-18T18:08:54  *** GAit_ has quit IRC
407 2018-04-18T18:09:09  *** GAit has joined #bitcoin-core-dev
408 2018-04-18T18:20:04  <promag> wumpus: friendly ping #12639
409 2018-04-18T18:20:06  <gribble> https://github.com/bitcoin/bitcoin/issues/12639 | Reduce cs_main lock in listunspent by promag · Pull Request #12639 · bitcoin/bitcoin · GitHub
410 2018-04-18T18:37:49  *** jojeyh has joined #bitcoin-core-dev
411 2018-04-18T18:41:50  *** cryptojanitor has quit IRC
412 2018-04-18T18:43:04  *** promag has quit IRC
413 2018-04-18T18:43:09  <jamesob> has there been any talk of moving from trusty to xenial on travis? It may be the case that we're unable to run bitcoin-qt using the functional test framework due to a bug in the version of openssl trusty uses
414 2018-04-18T18:44:28  <jamesob> ah, just found #13000 :)
415 2018-04-18T18:44:29  <gribble> https://github.com/bitcoin/bitcoin/issues/13000 | travis: Switch to xenial by MarcoFalke · Pull Request #13000 · bitcoin/bitcoin · GitHub
416 2018-04-18T18:45:19  <MarcoFalke> jamesob: Yeah, they don't have documentation on it, so it is not worth to jump into it too much right now
417 2018-04-18T18:46:50  <luke-jr> jamesob: bionic would be more useful IMO
418 2018-04-18T18:47:03  <luke-jr> problem is vmbuilder (and therefore make-base-vm) doesn't work with it yet :/
419 2018-04-18T18:48:26  <MarcoFalke> luke-jr: I think it makes sense to run on a somewhat older version of gcc, which xenial provides
420 2018-04-18T18:48:45  <MarcoFalke> iirc we don't use vmbuilder on travis?
421 2018-04-18T18:49:18  *** Dizzle has quit IRC
422 2018-04-18T18:51:39  *** CubicEarths has quit IRC
423 2018-04-18T18:54:42  *** drexl has joined #bitcoin-core-dev
424 2018-04-18T18:56:00  *** isis is now known as isis_
425 2018-04-18T18:58:43  <bitcoin-git> [bitcoin] Empact closed pull request #13019: validation: Consistently use FormatStateMessage (master...format-state-message) https://github.com/bitcoin/bitcoin/pull/13019
426 2018-04-18T19:01:57  *** crt4 has joined #bitcoin-core-dev
427 2018-04-18T19:03:57  *** CubicEarths has joined #bitcoin-core-dev
428 2018-04-18T19:08:40  *** Randolf has quit IRC
429 2018-04-18T19:11:53  <jamesob> MarcoFalke: I'm happy to pick up 13000 if you don't have time to investigate; looks like you may just need to obtain python's setuptools through a different package (though I'm sure there may be more problems)
430 2018-04-18T19:13:18  <MarcoFalke> jamesob: I think I got it working with that yaml. The issue was that it would just randomly time out without output, not run at all or apt update fails due to locks
431 2018-04-18T19:13:59  <MarcoFalke> Really it is up to travis to make it work first.
432 2018-04-18T19:14:18  <jamesob> MarcoFalke: doesn't look like it: https://travis-ci.org/bitcoin/bitcoin/jobs/367259625
433 2018-04-18T19:15:29  *** crt4 has quit IRC
434 2018-04-18T19:15:29  <jamesob> ah but I see other jobs in that build timed out
435 2018-04-18T19:22:11  <bitcoin-git> [bitcoin] jamesob opened pull request #13022: [qa] Attach node index to test_node AssertionError and print messages (master...2018-04-18-func-test-debug-log) https://github.com/bitcoin/bitcoin/pull/13022
436 2018-04-18T19:24:17  *** CubicEarths has quit IRC
437 2018-04-18T19:26:32  *** CubicEarths has joined #bitcoin-core-dev
438 2018-04-18T19:29:25  *** Aaronvan_ has joined #bitcoin-core-dev
439 2018-04-18T19:32:50  *** AaronvanW has quit IRC
440 2018-04-18T19:35:54  *** CubicEarths has quit IRC
441 2018-04-18T19:39:00  *** CubicEarths has joined #bitcoin-core-dev
442 2018-04-18T19:40:15  *** crt4 has joined #bitcoin-core-dev
443 2018-04-18T19:44:40  *** Giszmo has quit IRC
444 2018-04-18T19:46:37  *** Aaronvan_ is now known as AaronvanW
445 2018-04-18T19:47:02  *** d9b4bef9 has quit IRC
446 2018-04-18T19:48:15  *** d9b4bef9 has joined #bitcoin-core-dev
447 2018-04-18T19:52:30  *** Randolf has joined #bitcoin-core-dev
448 2018-04-18T20:00:14  *** Giszmo has joined #bitcoin-core-dev
449 2018-04-18T20:01:06  *** zarez has joined #bitcoin-core-dev
450 2018-04-18T20:06:42  *** lnostdal has joined #bitcoin-core-dev
451 2018-04-18T20:09:48  <bitcoin-git> [bitcoin] skeees opened pull request #13023: Add unit tests for signals generated by ProcessNewBlock (master...event-tests) https://github.com/bitcoin/bitcoin/pull/13023
452 2018-04-18T20:11:23  *** arbitrary_guy has joined #bitcoin-core-dev
453 2018-04-18T20:21:57  *** Randolf has quit IRC
454 2018-04-18T20:24:23  *** zigen has joined #bitcoin-core-dev
455 2018-04-18T20:24:25  *** promag has joined #bitcoin-core-dev
456 2018-04-18T20:29:09  *** zigen has quit IRC
457 2018-04-18T20:39:40  *** Randolf has joined #bitcoin-core-dev
458 2018-04-18T20:40:18  *** lnostdal has quit IRC
459 2018-04-18T20:45:34  *** jojeyh has quit IRC
460 2018-04-18T20:51:25  <jimpo> jonasshnelli: Odd that processing the validation interface queue would take so long. Are there any other log lines after that?
461 2018-04-18T20:52:59  *** wxss has quit IRC
462 2018-04-18T21:08:45  *** Cory has quit IRC
463 2018-04-18T21:08:55  <jnewbery> promag: I think your #13017 could go on the high-priority for review, since it's a pre-req for dynamic wallet load/create/unload. Agree?
464 2018-04-18T21:08:57  <gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
465 2018-04-18T21:09:28  <jnewbery> I've overhauled `loadwallet` and rebased it on that. Ready for review at #10740 if people are interested
466 2018-04-18T21:09:30  <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
467 2018-04-18T21:10:03  *** mlz has quit IRC
468 2018-04-18T21:11:36  *** zarez has quit IRC
469 2018-04-18T21:15:57  *** Cory has joined #bitcoin-core-dev
470 2018-04-18T21:16:15  *** TheRec has quit IRC
471 2018-04-18T21:22:07  *** prady has joined #bitcoin-core-dev
472 2018-04-18T21:22:47  <promag> jnewbery: missing postInitProcess on #10740?
473 2018-04-18T21:22:49  <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
474 2018-04-18T21:24:18  *** Guyver2 has quit IRC
475 2018-04-18T21:26:00  *** goatpig has quit IRC
476 2018-04-18T21:26:43  *** TheRec has joined #bitcoin-core-dev
477 2018-04-18T21:26:43  *** TheRec has joined #bitcoin-core-dev
478 2018-04-18T21:30:01  *** Randolf has quit IRC
479 2018-04-18T21:34:39  *** pierre_rochard has joined #bitcoin-core-dev
480 2018-04-18T21:39:40  *** timothy has quit IRC
481 2018-04-18T21:40:57  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13024: test: Add rpcauth pair that generated by rpcauth (master...rpc_test) https://github.com/bitcoin/bitcoin/pull/13024
482 2018-04-18T21:55:34  *** crt4 has quit IRC
483 2018-04-18T22:02:41  *** Emcy has quit IRC
484 2018-04-18T22:03:25  *** mlz has joined #bitcoin-core-dev
485 2018-04-18T22:03:59  *** Emcy has joined #bitcoin-core-dev
486 2018-04-18T22:13:49  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
487 2018-04-18T22:13:49  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
488 2018-04-18T22:25:07  *** zigen has joined #bitcoin-core-dev
489 2018-04-18T22:29:50  *** zigen has quit IRC
490 2018-04-18T22:31:55  *** prady has quit IRC
491 2018-04-18T22:34:05  *** isis_ is now known as isis
492 2018-04-18T22:50:35  <promag> sipa: can you explain IsMineSigVersion::TOP?
493 2018-04-18T22:51:28  <sipa> promag: there's a comment!
494 2018-04-18T22:51:33  <sipa> TOP = 0,        //! scriptPubKey execution
495 2018-04-18T23:00:35  *** Cogito_Ergo_Sum has quit IRC
496 2018-04-18T23:01:44  *** cryptojanitor has joined #bitcoin-core-dev
497 2018-04-18T23:06:34  *** StopAndDecrypt has joined #bitcoin-core-dev
498 2018-04-18T23:09:07  *** Randolf has joined #bitcoin-core-dev
499 2018-04-18T23:09:12  <promag> sipa: got it, any reason to not pick BASE?
500 2018-04-18T23:09:35  <sipa> yes, to help review
501 2018-04-18T23:09:53  <sipa> SigVersion::BASE means toplevel or p2sh
502 2018-04-18T23:10:23  <sipa> IsMineSigVersion::TOP means only toplevel, and as it has a different meaning it's better to rename it
503 2018-04-18T23:10:40  <sipa> so that as a reviewer you can easily ascertain that all sites have been addressed
504 2018-04-18T23:13:20  <promag> only top got me confused, toplevel or root would be more clear
505 2018-04-18T23:13:50  <promag> at least for me, as this is not the code I usually see
506 2018-04-18T23:17:09  <sipa> meh :)
507 2018-04-18T23:17:13  <sipa> there's a comment
508 2018-04-18T23:20:04  *** cdecker has quit IRC
509 2018-04-18T23:20:25  *** Sentineo has quit IRC
510 2018-04-18T23:20:33  *** cdecker has joined #bitcoin-core-dev
511 2018-04-18T23:21:05  *** Sentineo has joined #bitcoin-core-dev
512 2018-04-18T23:21:05  <promag> yes, and the commit message is also clear about the distinction
513 2018-04-18T23:38:58  *** AaronvanW has quit IRC
514 2018-04-18T23:41:54  *** jojeyh has joined #bitcoin-core-dev
515 2018-04-18T23:52:34  *** grafcaps has quit IRC
516 2018-04-18T23:54:37  *** AaronvanW has joined #bitcoin-core-dev