1 2018-04-24T00:00:02  *** weez17 has quit IRC
  2 2018-04-24T00:01:08  *** weez17 has joined #bitcoin-core-dev
  3 2018-04-24T00:06:33  *** niftynei has quit IRC
  4 2018-04-24T00:20:53  *** opdenkamp has joined #bitcoin-core-dev
  5 2018-04-24T00:21:53  *** Giszmo has quit IRC
  6 2018-04-24T00:31:35  *** Murch has quit IRC
  7 2018-04-24T00:39:49  *** promag has quit IRC
  8 2018-04-24T00:40:58  *** Giszmo has joined #bitcoin-core-dev
  9 2018-04-24T00:42:55  *** zigen has joined #bitcoin-core-dev
 10 2018-04-24T00:45:21  *** murrayn has quit IRC
 11 2018-04-24T00:46:27  *** rfree_irc has quit IRC
 12 2018-04-24T00:46:42  *** Giszmo has quit IRC
 13 2018-04-24T00:47:09  *** marsadm has quit IRC
 14 2018-04-24T00:47:47  *** zigen has quit IRC
 15 2018-04-24T00:52:44  *** tryphe has quit IRC
 16 2018-04-24T00:53:09  *** tryphe has joined #bitcoin-core-dev
 17 2018-04-24T00:56:09  *** cubancorona has quit IRC
 18 2018-04-24T01:00:38  *** promag has joined #bitcoin-core-dev
 19 2018-04-24T01:03:03  *** Giszmo has joined #bitcoin-core-dev
 20 2018-04-24T01:05:45  *** promag has quit IRC
 21 2018-04-24T01:06:41  *** harrymm has quit IRC
 22 2018-04-24T01:15:22  *** justanotheruser has quit IRC
 23 2018-04-24T01:15:47  *** LeMiner2 has joined #bitcoin-core-dev
 24 2018-04-24T01:16:40  *** LeMiner2 has joined #bitcoin-core-dev
 25 2018-04-24T01:17:16  *** justanotheruser has joined #bitcoin-core-dev
 26 2018-04-24T01:17:46  *** LeMiner has quit IRC
 27 2018-04-24T01:17:46  *** LeMiner2 is now known as LeMiner
 28 2018-04-24T01:19:41  *** harrymm has joined #bitcoin-core-dev
 29 2018-04-24T01:25:49  *** adiabat has quit IRC
 30 2018-04-24T01:34:27  *** jtimon has quit IRC
 31 2018-04-24T01:39:06  *** isis_ is now known as isis
 32 2018-04-24T01:40:44  *** cryptojanitor has quit IRC
 33 2018-04-24T01:41:49  *** LeMiner has quit IRC
 34 2018-04-24T01:42:29  *** LeMiner has joined #bitcoin-core-dev
 35 2018-04-24T01:44:20  *** AaronvanW has quit IRC
 36 2018-04-24T01:48:52  *** jtimon has joined #bitcoin-core-dev
 37 2018-04-24T01:57:48  *** jtimon has quit IRC
 38 2018-04-24T01:58:19  <jimpo> wumpus: You're having trouble viewing #13033?
 39 2018-04-24T01:58:21  <gribble> https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub
 40 2018-04-24T01:58:35  <jimpo> That is the PR reopened. It has only like 3 comments.
 41 2018-04-24T02:03:42  <sipa> Yes, i'm confused too. It opens perfectly here.
 42 2018-04-24T02:11:01  *** d9b4bef9 has quit IRC
 43 2018-04-24T02:12:07  *** d9b4bef9 has joined #bitcoin-core-dev
 44 2018-04-24T02:14:22  *** meshcollider has joined #bitcoin-core-dev
 45 2018-04-24T02:16:31  *** Krellan has joined #bitcoin-core-dev
 46 2018-04-24T02:24:34  *** murrayn has joined #bitcoin-core-dev
 47 2018-04-24T02:28:06  *** yoshi has joined #bitcoin-core-dev
 48 2018-04-24T02:28:29  *** yoshi is now known as Guest19800
 49 2018-04-24T02:33:02  *** Krellan has quit IRC
 50 2018-04-24T02:57:16  *** jb55 has quit IRC
 51 2018-04-24T02:57:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 52 2018-04-24T03:17:15  *** Guest19800 has quit IRC
 53 2018-04-24T03:17:44  *** tryphe has quit IRC
 54 2018-04-24T03:18:08  *** tryphe has joined #bitcoin-core-dev
 55 2018-04-24T03:18:20  *** cryptojanitor has joined #bitcoin-core-dev
 56 2018-04-24T03:21:44  *** tryphe has quit IRC
 57 2018-04-24T03:29:02  <roasbeef> odd that a PR would stop loading, just due to the # of comments it has I guess?
 58 2018-04-24T03:30:40  <roasbeef> guess the solution is to Download More RAM
 59 2018-04-24T03:31:13  *** Chris_Stewart_5 has quit IRC
 60 2018-04-24T03:33:01  <sipa> roasbeef: i believe it's the github html renderer that times out
 61 2018-04-24T03:33:09  <sipa> as mobile github clients etc work fine
 62 2018-04-24T03:50:42  *** Giszmo has quit IRC
 63 2018-04-24T03:59:45  *** mol has joined #bitcoin-core-dev
 64 2018-04-24T03:59:54  *** zautomata has joined #bitcoin-core-dev
 65 2018-04-24T04:01:39  *** zautomata4 has quit IRC
 66 2018-04-24T04:03:14  *** mlz has quit IRC
 67 2018-04-24T04:03:48  *** tryphe has joined #bitcoin-core-dev
 68 2018-04-24T04:05:04  *** tryphe has quit IRC
 69 2018-04-24T04:07:16  <jimpo> It's pretty bizarry though that it would load reliably for some accounts and in incognito mode, but not others
 70 2018-04-24T04:08:13  <jimpo> I wouldn't think that there's so much rendering logic that differs between accounts
 71 2018-04-24T04:08:36  *** promag has joined #bitcoin-core-dev
 72 2018-04-24T04:13:24  *** promag has quit IRC
 73 2018-04-24T04:44:28  *** zigen has joined #bitcoin-core-dev
 74 2018-04-24T04:46:41  <sipa> jimpo: i wonder if it's geographical
 75 2018-04-24T04:47:12  <sipa> maybe the render servers are distributed and not the same load/sprcs for people in europe vs north america etc
 76 2018-04-24T04:48:57  *** zigen has quit IRC
 77 2018-04-24T04:54:25  *** grafcaps has quit IRC
 78 2018-04-24T05:00:32  *** arubi has quit IRC
 79 2018-04-24T05:00:32  *** dermoth has quit IRC
 80 2018-04-24T05:00:32  *** intcat has quit IRC
 81 2018-04-24T05:01:26  *** arubi has joined #bitcoin-core-dev
 82 2018-04-24T05:02:44  *** intcat has joined #bitcoin-core-dev
 83 2018-04-24T05:06:36  *** Samdney has quit IRC
 84 2018-04-24T05:17:46  *** mol has quit IRC
 85 2018-04-24T05:18:02  *** mol has joined #bitcoin-core-dev
 86 2018-04-24T05:19:54  *** justanotheruser has quit IRC
 87 2018-04-24T05:21:34  *** justanotheruser has joined #bitcoin-core-dev
 88 2018-04-24T05:25:49  *** tryphe has joined #bitcoin-core-dev
 89 2018-04-24T05:26:02  *** grafcaps has joined #bitcoin-core-dev
 90 2018-04-24T05:35:35  *** tryphe has quit IRC
 91 2018-04-24T05:35:40  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13065: Let travis run verify-commits.sh without errors (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13065
 92 2018-04-24T05:36:04  *** tryphe has joined #bitcoin-core-dev
 93 2018-04-24T05:37:54  *** cryptojanitor has quit IRC
 94 2018-04-24T05:38:18  *** rfree_irc has joined #bitcoin-core-dev
 95 2018-04-24T05:39:50  *** marsadm has joined #bitcoin-core-dev
 96 2018-04-24T05:43:19  *** bedotech has joined #bitcoin-core-dev
 97 2018-04-24T05:54:29  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bdda14d1c01c...569e3817e000
 98 2018-04-24T05:54:29  <bitcoin-git> bitcoin/master 4d33039 Pieter Wuille: List support for BIP173 in bips.md
 99 2018-04-24T05:54:30  <bitcoin-git> bitcoin/master 569e381 Wladimir J. van der Laan: Merge #13064: List support for BIP173 in bips.md...
100 2018-04-24T05:55:25  <bitcoin-git> [bitcoin] laanwj closed pull request #13064: List support for BIP173 in bips.md (master...201804_docbip173) https://github.com/bitcoin/bitcoin/pull/13064
101 2018-04-24T06:02:19  *** fanquake has joined #bitcoin-core-dev
102 2018-04-24T06:08:22  <fanquake> Looking forward to Bionic tomorrow. Hopefully we can start using it on WSL soon after..
103 2018-04-24T06:14:07  *** meshcollider has quit IRC
104 2018-04-24T06:18:50  *** molly has joined #bitcoin-core-dev
105 2018-04-24T06:20:13  <kallewoof> How are READWRITE(REF(CFlatData(ob))) done these days? I got barfed at when rebasing something.
106 2018-04-24T06:20:32  * kallewoof does git log serialize.h to find clues
107 2018-04-24T06:20:51  *** molz_ has joined #bitcoin-core-dev
108 2018-04-24T06:20:56  <sipa> kallewoof: depends, what type is ob?
109 2018-04-24T06:21:25  <kallewoof> sipa: std::vector<uint256>
110 2018-04-24T06:21:34  <kallewoof> Wait, no..
111 2018-04-24T06:21:58  <kallewoof> Sorry. Yes. std::vector<uint256>
112 2018-04-24T06:22:06  <sipa> with compile-time known length?
113 2018-04-24T06:22:35  <kallewoof> No, it's a merkle proof skip list
114 2018-04-24T06:22:45  *** mol has quit IRC
115 2018-04-24T06:22:46  <sipa> then what do you need the flatdata for?
116 2018-04-24T06:23:16  * kallewoof headscratch
117 2018-04-24T06:23:17  <sipa> just READWRITE(the_vector) will work fine
118 2018-04-24T06:23:34  <kallewoof> Is CFlatData only used for fixed length stuff?
119 2018-04-24T06:24:07  <sipa> CFlatData was historically used to write things as raw bytes, as opposed to the object's serializer
120 2018-04-24T06:24:22  <sipa> it's been replaced with native support for arrays
121 2018-04-24T06:24:33  *** molly has quit IRC
122 2018-04-24T06:24:48  <sipa> so you can READWRITE(blah) if blah is 'unsigned char blah[4]' for example, and it will just write 4 bytes
123 2018-04-24T06:24:55  <sipa> and with Span
124 2018-04-24T06:25:36  <sipa> but uint256 has a serializer that just writes 32 bytes
125 2018-04-24T06:25:46  <kallewoof> Okay, so actually reading the comment above, it seems Mark wanted to avoid using the Satoshi-defined compact size format as it was less efficient than the internal varint.
126 2018-04-24T06:26:00  <kallewoof> Hence why he wrote the length of the vector and the vector as CFlatData
127 2018-04-24T06:26:16  <sipa> i see
128 2018-04-24T06:26:19  <sipa> seems overkill to me
129 2018-04-24T06:26:31  <kallewoof> Yes, seems unnecessary.
130 2018-04-24T06:26:37  <sipa> as the native varint's aren't used anywhere in the p2p protocol already
131 2018-04-24T06:27:42  <kallewoof> *nod*
132 2018-04-24T06:28:34  <sipa> the same issue came up around bip152
133 2018-04-24T06:29:26  <kallewoof> How much more efficient are the varints compared to the compactsize version anyway?
134 2018-04-24T06:29:42  <sipa> it depends on the distribution
135 2018-04-24T06:29:50  <kallewoof> Right. Of course it does.
136 2018-04-24T06:29:57  <sipa> for some distributions the compactsize ones are better
137 2018-04-24T06:30:04  <kallewoof> But for a skip list in a merkle proof, I kind of don't think you'll ever have more than 10.
138 2018-04-24T06:30:16  <kallewoof> Or very seldom anyway. I could be wrong though.
139 2018-04-24T06:30:29  <sipa> then both serializations will give you just 1 byte anyway
140 2018-04-24T06:30:35  <kallewoof> Yeah
141 2018-04-24T06:30:56  <sipa> compactsize uses 1 byte up to (iirc) 252
142 2018-04-24T06:31:02  <sipa> varint only up to 127
143 2018-04-24T06:31:17  <sipa> but after that compactsize immediately jumps to 3 bytes
144 2018-04-24T06:31:29  <sipa> while varint only uses 2 up to 16000 ish
145 2018-04-24T06:32:56  <kallewoof> Oh, they're that different? I thought they were tweaks of the same thing.
146 2018-04-24T06:34:26  <ossifrage> Does bitcoin core do some sort of io maintenance task that gobbles up a bunch of disk IO?
147 2018-04-24T06:34:46  <kallewoof> Either way, the size of the size of the skip lists is a fraction of the size of the skip lists themselves which are 32 bytes per entry, so I doubt this matters. With 253 entries there are 8096 bytes of data aside from the size. 3 or 2 bytes isn't really gonna make a difference.
148 2018-04-24T06:35:18  <ossifrage> QThread just started generating a bunch of disk io without any large corresponding newtwork IO
149 2018-04-24T06:35:38  *** Krellan has joined #bitcoin-core-dev
150 2018-04-24T06:38:37  *** he1io5 has joined #bitcoin-core-dev
151 2018-04-24T06:45:15  *** fanquake has quit IRC
152 2018-04-24T06:45:57  *** zigen has joined #bitcoin-core-dev
153 2018-04-24T06:50:18  *** zigen has quit IRC
154 2018-04-24T07:04:14  *** he1io5 has left #bitcoin-core-dev
155 2018-04-24T07:06:09  <wumpus> jimpo: I can view it now, couldn't open it yesterday
156 2018-04-24T07:06:31  <wumpus> strange
157 2018-04-24T07:09:03  <wumpus> and yeah I couldn't see it had only three replies because I couldn't see the thing at all
158 2018-04-24T07:23:39  *** someotherguy_ has joined #bitcoin-core-dev
159 2018-04-24T07:30:56  *** molz_ has quit IRC
160 2018-04-24T07:32:14  *** molz has joined #bitcoin-core-dev
161 2018-04-24T07:39:01  *** shtirlic_ has quit IRC
162 2018-04-24T07:39:37  *** shtirlic_ has joined #bitcoin-core-dev
163 2018-04-24T07:43:33  <kallewoof> sipa: Mark pointed out compactsize is malleable (e.g. 00000001 = 01).
164 2018-04-24T07:44:43  *** zarez has joined #bitcoin-core-dev
165 2018-04-24T07:45:05  *** Krellan has quit IRC
166 2018-04-24T07:45:25  <kallewoof> sipa: Also noted concern about a non-optimized storage format in consensus code, which I can sort of understand. Gonna think this through some more.
167 2018-04-24T07:46:12  <kallewoof> I think the key issue is, what size will the average skip list be, in a merkle proof. If it's "thousands" then using varint sounds sensible. If it's "tens" it sounds overkill.
168 2018-04-24T07:49:44  *** timothy has joined #bitcoin-core-dev
169 2018-04-24T07:50:56  *** tryphe_ has joined #bitcoin-core-dev
170 2018-04-24T07:54:16  *** drizztbsd has joined #bitcoin-core-dev
171 2018-04-24T07:54:22  *** tryphe has quit IRC
172 2018-04-24T07:54:22  *** timothy has quit IRC
173 2018-04-24T07:56:14  *** drizztbsd is now known as timothy
174 2018-04-24T08:07:48  *** he1io5 has joined #bitcoin-core-dev
175 2018-04-24T08:07:49  *** he1io5 has left #bitcoin-core-dev
176 2018-04-24T08:08:05  *** promag has joined #bitcoin-core-dev
177 2018-04-24T08:43:38  *** Krellan has joined #bitcoin-core-dev
178 2018-04-24T08:44:44  *** vicenteH has joined #bitcoin-core-dev
179 2018-04-24T09:04:33  <promag> #13028 is pretty straightforward, would love some ack/nack there
180 2018-04-24T09:04:35  <gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
181 2018-04-24T09:09:10  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/569e3817e000...896a9d026ccf
182 2018-04-24T09:09:10  <bitcoin-git> bitcoin/master 80a5e59 James O'Beirne: [qa] Attach node index to test_node AssertionError and print messages...
183 2018-04-24T09:09:11  <bitcoin-git> bitcoin/master 896a9d0 Wladimir J. van der Laan: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages...
184 2018-04-24T09:09:59  <bitcoin-git> [bitcoin] laanwj closed pull request #13022: [qa] Attach node index to test_node AssertionError and print messages (master...2018-04-18-func-test-debug-log) https://github.com/bitcoin/bitcoin/pull/13022
185 2018-04-24T09:12:40  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/896a9d026ccf...34dd1a6d5e36
186 2018-04-24T09:12:40  <bitcoin-git> bitcoin/master 1accfbc Kristaps Kaupe: Output values for "min relay fee not met" error
187 2018-04-24T09:12:41  <bitcoin-git> bitcoin/master 34dd1a6 Wladimir J. van der Laan: Merge #13032: Output values for "min relay fee not met" error...
188 2018-04-24T09:13:24  *** CubicEarths has quit IRC
189 2018-04-24T09:13:34  <bitcoin-git> [bitcoin] laanwj closed pull request #13032: Output values for "min relay fee not met" error (master...min-relay-fee-not-met-debug) https://github.com/bitcoin/bitcoin/pull/13032
190 2018-04-24T09:14:04  *** CubicEarths has joined #bitcoin-core-dev
191 2018-04-24T09:17:00  *** CubicEar_ has joined #bitcoin-core-dev
192 2018-04-24T09:20:46  *** CubicEarths has quit IRC
193 2018-04-24T09:29:25  *** someotherguy_ has quit IRC
194 2018-04-24T09:57:13  *** larafale has joined #bitcoin-core-dev
195 2018-04-24T09:58:04  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/34dd1a6d5e36...6e67754e481f
196 2018-04-24T09:58:04  <bitcoin-git> bitcoin/master 09b30db 251: Asserts that the tx version number is a signed 32-bit integer.
197 2018-04-24T09:58:05  <bitcoin-git> bitcoin/master 6e67754 Wladimir J. van der Laan: Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output...
198 2018-04-24T09:58:39  <bitcoin-git> [bitcoin] laanwj closed pull request #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output (master...issue/11561/test-negative-transaction-version-numbers) https://github.com/bitcoin/bitcoin/pull/12436
199 2018-04-24T10:15:26  *** jtimon has joined #bitcoin-core-dev
200 2018-04-24T10:29:29  *** laurentmt has joined #bitcoin-core-dev
201 2018-04-24T10:45:02  *** d9b4bef9 has quit IRC
202 2018-04-24T10:46:08  *** d9b4bef9 has joined #bitcoin-core-dev
203 2018-04-24T10:47:22  *** zigen has joined #bitcoin-core-dev
204 2018-04-24T10:52:07  *** zigen has quit IRC
205 2018-04-24T10:52:34  *** CubicEar_ has quit IRC
206 2018-04-24T11:20:15  *** tralfaz has quit IRC
207 2018-04-24T11:25:01  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e67754e481f...54865cf9e6a8
208 2018-04-24T11:25:01  <bitcoin-git> bitcoin/master 3ee4be1 Bernhard M. Wiedemann: Make tests pass after 2020...
209 2018-04-24T11:25:02  <bitcoin-git> bitcoin/master 54865cf Wladimir J. van der Laan: Merge #13061: Make tests pass after 2020...
210 2018-04-24T11:25:43  <bitcoin-git> [bitcoin] laanwj closed pull request #13061: Make tests pass after 2020 (master...ftbfs-2020) https://github.com/bitcoin/bitcoin/pull/13061
211 2018-04-24T11:35:25  *** laurentmt has quit IRC
212 2018-04-24T11:41:17  *** CubicEarths has joined #bitcoin-core-dev
213 2018-04-24T11:43:26  *** SopaXorzTaker has joined #bitcoin-core-dev
214 2018-04-24T11:55:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
215 2018-04-24T12:06:23  *** epic has quit IRC
216 2018-04-24T12:06:40  *** epic has joined #bitcoin-core-dev
217 2018-04-24T12:07:38  *** promag has quit IRC
218 2018-04-24T12:07:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/54865cf9e6a8...018c7e5dadc1
219 2018-04-24T12:07:59  <bitcoin-git> bitcoin/master 8b8032e Chun Kuan Lee: test: Add rpcauth pair that generated by rpcauth
220 2018-04-24T12:08:00  <bitcoin-git> bitcoin/master 018c7e5 Wladimir J. van der Laan: Merge #13024: test: Add rpcauth pair that generated by rpcauth.py...
221 2018-04-24T12:08:06  *** CubicEarths has quit IRC
222 2018-04-24T12:08:42  <bitcoin-git> [bitcoin] laanwj closed pull request #13024: test: Add rpcauth pair that generated by rpcauth.py (master...rpc_test) https://github.com/bitcoin/bitcoin/pull/13024
223 2018-04-24T12:10:18  *** hsmiths has quit IRC
224 2018-04-24T12:10:35  *** hsmiths has joined #bitcoin-core-dev
225 2018-04-24T12:13:57  *** CubicEarths has joined #bitcoin-core-dev
226 2018-04-24T12:16:49  *** jl2012 has quit IRC
227 2018-04-24T12:17:06  *** jl2012 has joined #bitcoin-core-dev
228 2018-04-24T12:29:57  *** Chris_Stewart_5 has quit IRC
229 2018-04-24T12:42:27  *** shesek has quit IRC
230 2018-04-24T12:42:52  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13066: Make travis to run verify-commits (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13066
231 2018-04-24T13:00:30  *** promag has joined #bitcoin-core-dev
232 2018-04-24T13:05:28  <jonasschnelli> bluematt: has the bitcoincore.org deployment stalled? IMO https://bitcoincore.org/en/segwit_adoption/ should be gone by now
233 2018-04-24T13:06:08  <wumpus> you mean it's no longer updating from the github?
234 2018-04-24T13:12:09  *** tralfaz has joined #bitcoin-core-dev
235 2018-04-24T13:15:02  *** cryptojanitor has joined #bitcoin-core-dev
236 2018-04-24T13:15:27  *** lari has quit IRC
237 2018-04-24T13:16:52  *** lari has joined #bitcoin-core-dev
238 2018-04-24T13:21:13  *** Guyver2 has joined #bitcoin-core-dev
239 2018-04-24T13:21:54  <bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/018c7e5dadc1...d1d54ae6a362
240 2018-04-24T13:21:55  <bitcoin-git> bitcoin/master a28b907 John Newbery: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table...
241 2018-04-24T13:21:55  <bitcoin-git> bitcoin/master 4e671f0 John Newbery: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py...
242 2018-04-24T13:21:56  <bitcoin-git> bitcoin/master 3db1ba0 John Newbery: [tests] Set -deprecatedrpc=accounts in tests...
243 2018-04-24T13:21:57  *** wumpus has quit IRC
244 2018-04-24T13:22:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
245 2018-04-24T13:22:38  <bitcoin-git> [bitcoin] laanwj closed pull request #12953: Deprecate accounts (master...deprecate_accounts) https://github.com/bitcoin/bitcoin/pull/12953
246 2018-04-24T13:22:45  *** shesek has joined #bitcoin-core-dev
247 2018-04-24T13:22:45  *** shesek has joined #bitcoin-core-dev
248 2018-04-24T13:27:07  <instagibbs> \o/ die accounts, die
249 2018-04-24T13:31:00  <sdaftuar> The accounts, the.
250 2018-04-24T13:35:50  *** rodarmor has quit IRC
251 2018-04-24T13:36:15  *** rodarmor has joined #bitcoin-core-dev
252 2018-04-24T13:37:06  <jamesob> anyone know what an exit code of -6 from bitcoin-qt signifies? didn't turn anything up with grep
253 2018-04-24T13:41:05  <jouke> sdaftuar: that's how I read it :)
254 2018-04-24T13:47:42  *** CubicEarths has quit IRC
255 2018-04-24T13:51:30  *** AaronvanW has joined #bitcoin-core-dev
256 2018-04-24T13:52:56  *** Aaronvan_ has joined #bitcoin-core-dev
257 2018-04-24T13:53:17  <bitcoin-git> [bitcoin] ccdle12 opened pull request #13067: Pr fixes ccdle12 (master...PR-fixes-ccdle12) https://github.com/bitcoin/bitcoin/pull/13067
258 2018-04-24T13:55:13  *** wumpus has joined #bitcoin-core-dev
259 2018-04-24T13:56:27  *** AaronvanW has quit IRC
260 2018-04-24T14:03:22  <bitcoin-git> [bitcoin] MarcoFalke pushed 10 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/845838c4451e...9ea62a3dc4bd
261 2018-04-24T14:03:23  <bitcoin-git> bitcoin/0.16 cfebd40 Karl-Johan Alm: [test] Round target fee to 8 decimals in assert_fee_amount...
262 2018-04-24T14:03:23  <bitcoin-git> bitcoin/0.16 1286f3e Ben Woosley: test: Use wait_until to ensure ping goes out...
263 2018-04-24T14:03:24  <bitcoin-git> bitcoin/0.16 0e98f96 Ben Woosley: test: Use wait_until in tests where time was used for polling...
264 2018-04-24T14:03:49  *** SopaXorzTaker has quit IRC
265 2018-04-24T14:08:11  *** grafcaps has quit IRC
266 2018-04-24T14:23:33  *** grafcaps has joined #bitcoin-core-dev
267 2018-04-24T14:26:44  <sdaftuar> sipa: regarding your comment in https://github.com/bitcoin/bitcoin/pull/13011#issuecomment-383145046 -- #9700 did have a mechanism to avoid doing the precomputation, so that block requests (and rescan) wouldn't be impacted
268 2018-04-24T14:26:47  <gribble> https://github.com/bitcoin/bitcoin/issues/9700 | Cache segwit signature hash components inside CTransaction to optimize validation performance by sdaftuar · Pull Request #9700 · bitcoin/bitcoin · GitHub
269 2018-04-24T14:28:02  <sdaftuar> anyway not sure if that is enough to mitigate the concerns?  i'm also happy to adopt a different approach, i tried several designs last year, but i could use some direction to help figure out the best path forward (if this is something we want)
270 2018-04-24T14:29:21  <jtimon> re-re-review re-re-beg: https://github.com/bitcoin/bitcoin/pull/10757
271 2018-04-24T14:30:31  <jtimon> I really think it's ready this time, thanks everyone for the many nits that made it much better
272 2018-04-24T14:32:42  <aj> jtimon: you could change "bool do_mediantxsize" etc back to "const bool" if you wanted :)
273 2018-04-24T14:38:11  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1d54ae6a362...476cb35551f5
274 2018-04-24T14:38:11  <bitcoin-git> bitcoin/master fac0db0 MarcoFalke: wallet: Make fee settings non-static members
275 2018-04-24T14:38:12  <bitcoin-git> bitcoin/master 476cb35 Wladimir J. van der Laan: Merge #12909: wallet: Make fee settings to be non-static members...
276 2018-04-24T14:38:57  <bitcoin-git> [bitcoin] laanwj closed pull request #12909: wallet: Make fee settings to be non-static members (master...Mf1804-walletMembers) https://github.com/bitcoin/bitcoin/pull/12909
277 2018-04-24T14:39:53  *** timothy has quit IRC
278 2018-04-24T14:48:56  *** zigen has joined #bitcoin-core-dev
279 2018-04-24T14:49:30  <jtimon> aj: oh, right, thanks
280 2018-04-24T14:50:42  *** timothy has joined #bitcoin-core-dev
281 2018-04-24T14:53:19  *** zigen has quit IRC
282 2018-04-24T14:54:49  *** Dizzle has joined #bitcoin-core-dev
283 2018-04-24T14:55:18  *** drizztbsd has joined #bitcoin-core-dev
284 2018-04-24T14:55:56  *** Murch has joined #bitcoin-core-dev
285 2018-04-24T14:55:57  *** timothy has quit IRC
286 2018-04-24T14:56:13  <jtimon> aj: done
287 2018-04-24T14:57:51  *** CubicEarths has joined #bitcoin-core-dev
288 2018-04-24T15:09:06  <BlueMatt> MarcoFalke: I'd like to nominate #12998 for backporting. It has 0 risk of breaking supported configurations and virtually 0 risk of breaking anything else but is useful for a downstream project
289 2018-04-24T15:09:08  <gribble> https://github.com/bitcoin/bitcoin/issues/12998 | Default to defining endian-conversion DECLs in compat w/o config by TheBlueMatt · Pull Request #12998 · bitcoin/bitcoin · GitHub
290 2018-04-24T15:10:44  *** Guyver2_ has joined #bitcoin-core-dev
291 2018-04-24T15:13:44  *** Guyver2 has quit IRC
292 2018-04-24T15:13:48  *** Guyver2_ is now known as Guyver2
293 2018-04-24T15:23:45  *** ProfMac has quit IRC
294 2018-04-24T15:26:14  *** CubicEarths has quit IRC
295 2018-04-24T15:26:20  <BlueMatt> jonasschnelli: yea, I'll look into it when someone shows up with a 2fa
296 2018-04-24T15:26:45  *** bedotech has quit IRC
297 2018-04-24T15:26:55  *** CubicEarths has joined #bitcoin-core-dev
298 2018-04-24T15:30:28  *** CubicEar_ has joined #bitcoin-core-dev
299 2018-04-24T15:34:07  *** CubicEarths has quit IRC
300 2018-04-24T15:34:58  *** adiabat has joined #bitcoin-core-dev
301 2018-04-24T15:38:54  *** Krellan has quit IRC
302 2018-04-24T15:39:30  *** Krellan has joined #bitcoin-core-dev
303 2018-04-24T15:40:04  *** SopaXorzTaker has joined #bitcoin-core-dev
304 2018-04-24T15:40:40  *** skeees has quit IRC
305 2018-04-24T15:40:48  <promag> AccessByTxid requires cs_main?
306 2018-04-24T15:40:57  *** skeees has joined #bitcoin-core-dev
307 2018-04-24T15:45:27  *** Randolf has quit IRC
308 2018-04-24T15:46:58  *** Guyver2 has quit IRC
309 2018-04-24T15:47:09  *** Guyver2 has joined #bitcoin-core-dev
310 2018-04-24T15:47:11  *** Guyver2_ has joined #bitcoin-core-dev
311 2018-04-24T15:49:11  *** Guyver2 has quit IRC
312 2018-04-24T15:49:13  *** Guyver2_ is now known as Guyver2
313 2018-04-24T15:51:00  *** promag has quit IRC
314 2018-04-24T15:51:57  *** zarez has quit IRC
315 2018-04-24T15:54:09  *** lnostdal has quit IRC
316 2018-04-24T16:00:56  *** CubicEar_ has quit IRC
317 2018-04-24T16:04:21  *** Krellan has quit IRC
318 2018-04-24T16:07:27  <jnewbery> promag: I don't think shared pointers are required for wallet load/create. I'd rather not rebase on your PR unless necessary. I think loadwallet and g_wallet_manager can move forward in parallel
319 2018-04-24T16:11:48  *** Randolf has joined #bitcoin-core-dev
320 2018-04-24T16:12:51  *** Aliencorpse has quit IRC
321 2018-04-24T16:14:17  *** Aaronvan_ has quit IRC
322 2018-04-24T16:14:52  *** AaronvanW has joined #bitcoin-core-dev
323 2018-04-24T16:17:55  *** ProfMac has joined #bitcoin-core-dev
324 2018-04-24T16:19:34  *** AaronvanW has quit IRC
325 2018-04-24T16:22:19  *** promag has joined #bitcoin-core-dev
326 2018-04-24T16:22:46  <promag> jnewbery: yes agree
327 2018-04-24T16:24:34  *** Aliencorpse has joined #bitcoin-core-dev
328 2018-04-24T16:31:03  *** promag has quit IRC
329 2018-04-24T16:31:15  *** CubicEarths has joined #bitcoin-core-dev
330 2018-04-24T16:32:47  *** laurentmt has joined #bitcoin-core-dev
331 2018-04-24T16:40:02  *** Krellan has joined #bitcoin-core-dev
332 2018-04-24T16:40:03  *** CubicEarths has quit IRC
333 2018-04-24T16:40:04  *** AaronvanW has joined #bitcoin-core-dev
334 2018-04-24T16:41:10  *** isis is now known as isis_
335 2018-04-24T16:44:09  *** shesek has quit IRC
336 2018-04-24T16:44:42  *** laurentmt has quit IRC
337 2018-04-24T16:58:06  *** Giszmo has joined #bitcoin-core-dev
338 2018-04-24T16:59:30  *** shesek has joined #bitcoin-core-dev
339 2018-04-24T17:02:02  *** Krellan has quit IRC
340 2018-04-24T17:02:47  *** lnostdal has joined #bitcoin-core-dev
341 2018-04-24T17:02:57  *** drizztbsd has quit IRC
342 2018-04-24T17:03:24  *** CubicEarths has joined #bitcoin-core-dev
343 2018-04-24T17:05:01  *** lnostdal has quit IRC
344 2018-04-24T17:05:19  *** lnostdal has joined #bitcoin-core-dev
345 2018-04-24T17:12:44  *** shesek has quit IRC
346 2018-04-24T17:22:59  *** promag has joined #bitcoin-core-dev
347 2018-04-24T17:27:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/476cb35551f5...a0079d4b6dc6
348 2018-04-24T17:27:46  <bitcoin-git> bitcoin/master 962d223 MarcoFalke: bench: Move constructors out of mempool_eviction hot loop
349 2018-04-24T17:27:47  <bitcoin-git> bitcoin/master fa3bb18 MarcoFalke: bench: Amend mempool_eviction test for witness txs
350 2018-04-24T17:27:47  <bitcoin-git> bitcoin/master a0079d4 MarcoFalke: Merge #13013: bench: Amend mempool_eviction test for witness txs...
351 2018-04-24T17:28:36  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13013: bench: Amend mempool_eviction test for witness txs (master...Mf1804-benchWitnessMempool) https://github.com/bitcoin/bitcoin/pull/13013
352 2018-04-24T17:29:08  *** mistergold has joined #bitcoin-core-dev
353 2018-04-24T17:29:44  *** shesek has joined #bitcoin-core-dev
354 2018-04-24T17:30:59  <promag> got "test_framework.authproxy.JSONRPCException: The mempool was not loaded yet (-1)" in https://travis-ci.org/bitcoin/bitcoin/jobs/370654669
355 2018-04-24T17:32:57  <promag> should it retry?
356 2018-04-24T17:37:27  *** CubicEarths has quit IRC
357 2018-04-24T17:38:45  *** vicenteH has quit IRC
358 2018-04-24T17:41:54  *** lnostdal has quit IRC
359 2018-04-24T17:43:57  *** lnostdal has joined #bitcoin-core-dev
360 2018-04-24T17:44:07  *** Samdney has joined #bitcoin-core-dev
361 2018-04-24T17:44:17  *** cphrmky has quit IRC
362 2018-04-24T17:49:06  *** lnostdal has quit IRC
363 2018-04-24T17:49:23  *** lnostdal has joined #bitcoin-core-dev
364 2018-04-24T17:49:31  *** cphrmky has joined #bitcoin-core-dev
365 2018-04-24T17:53:22  <bitcoin-git> [bitcoin] jimpo closed pull request #12647: wallet: Fix possible memory leak in CreateWalletFromFile. (master...wallet-pointer) https://github.com/bitcoin/bitcoin/pull/12647
366 2018-04-24T17:54:03  *** SopaXorzTaker has quit IRC
367 2018-04-24T18:01:02  *** d9b4bef9 has quit IRC
368 2018-04-24T18:02:08  *** d9b4bef9 has joined #bitcoin-core-dev
369 2018-04-24T18:05:20  <sdaftuar> sipa: actually, never mind about the segwit-hash-caching. now that we cache script validation success, we can achieve nearly all the benefit with a lot less work (and less controversial design) by just only doing the computation for transactions that aren't in the script cache
370 2018-04-24T18:06:24  *** niftynei has joined #bitcoin-core-dev
371 2018-04-24T18:10:45  *** Krellan has joined #bitcoin-core-dev
372 2018-04-24T18:11:53  *** harrymm has quit IRC
373 2018-04-24T18:12:33  *** Krellan has quit IRC
374 2018-04-24T18:12:54  *** Krellan has joined #bitcoin-core-dev
375 2018-04-24T18:14:29  *** promag has quit IRC
376 2018-04-24T18:16:41  *** games_ is now known as tyrone_
377 2018-04-24T18:18:30  *** larafale has quit IRC
378 2018-04-24T18:18:54  *** TheCharlatan has joined #bitcoin-core-dev
379 2018-04-24T18:19:04  *** larafale has joined #bitcoin-core-dev
380 2018-04-24T18:21:08  *** basidb has joined #bitcoin-core-dev
381 2018-04-24T18:23:27  *** larafale has quit IRC
382 2018-04-24T18:24:51  *** harrymm has joined #bitcoin-core-dev
383 2018-04-24T18:25:19  *** larafale has joined #bitcoin-core-dev
384 2018-04-24T18:31:29  *** Chris_Stewart_5 has quit IRC
385 2018-04-24T18:31:54  *** rex4539 has joined #bitcoin-core-dev
386 2018-04-24T18:32:30  *** basidb has quit IRC
387 2018-04-24T18:33:42  *** owowo has quit IRC
388 2018-04-24T18:34:37  *** cryptojanitor has quit IRC
389 2018-04-24T18:38:22  *** owowo has joined #bitcoin-core-dev
390 2018-04-24T18:46:40  <jnewbery> promag: looks like that job was restarted so I can't see the failure. Was it: https://github.com/bitcoin/bitcoin/issues/12863 ?
391 2018-04-24T18:50:30  *** zigen has joined #bitcoin-core-dev
392 2018-04-24T18:54:58  *** zigen has quit IRC
393 2018-04-24T19:01:30  *** promag has joined #bitcoin-core-dev
394 2018-04-24T19:06:44  <bitcoin-git> [bitcoin] practicalswift opened pull request #13068: tests: Remove unused constant MAX_INV_SZ (master...MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13068
395 2018-04-24T19:09:08  *** rex4539 has quit IRC
396 2018-04-24T19:14:45  <bitcoin-git> [bitcoin] practicalswift opened pull request #13069: docs: Fix typos (master...typos-201804) https://github.com/bitcoin/bitcoin/pull/13069
397 2018-04-24T19:15:25  <promag> jnewbery: yes I've restarted it. Yap, that's the error (it's pasted above)
398 2018-04-24T19:25:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
399 2018-04-24T19:25:15  *** CubicEarths has joined #bitcoin-core-dev
400 2018-04-24T19:26:06  *** Krellan has quit IRC
401 2018-04-24T19:28:06  *** Randolf has quit IRC
402 2018-04-24T19:40:41  *** laurentmt has joined #bitcoin-core-dev
403 2018-04-24T19:49:59  *** promag has quit IRC
404 2018-04-24T19:52:40  *** laurentmt has quit IRC
405 2018-04-24T19:53:44  *** zautomata has quit IRC
406 2018-04-24T19:58:18  *** Dizzle has quit IRC
407 2018-04-24T19:59:47  *** Krellan has joined #bitcoin-core-dev
408 2018-04-24T20:00:27  *** CubicEarths has quit IRC
409 2018-04-24T20:00:56  *** CubicEarths has joined #bitcoin-core-dev
410 2018-04-24T20:04:05  *** ossifrage_ has joined #bitcoin-core-dev
411 2018-04-24T20:04:26  *** ossifrage has quit IRC
412 2018-04-24T20:04:49  *** Krellan has quit IRC
413 2018-04-24T20:05:54  *** CubicEarths has quit IRC
414 2018-04-24T20:08:32  *** zivl_ has joined #bitcoin-core-dev
415 2018-04-24T20:09:59  *** zivl has quit IRC
416 2018-04-24T20:11:04  *** zivl_ is now known as zivl
417 2018-04-24T20:22:21  *** Aaronvan_ has joined #bitcoin-core-dev
418 2018-04-24T20:22:26  *** ProfMac has quit IRC
419 2018-04-24T20:24:57  *** AaronvanW has quit IRC
420 2018-04-24T20:25:27  *** Giszmo has quit IRC
421 2018-04-24T20:26:37  *** niftynei has quit IRC
422 2018-04-24T20:29:20  *** CubicEarths has joined #bitcoin-core-dev
423 2018-04-24T20:34:34  *** CubicEarths has quit IRC
424 2018-04-24T20:35:29  *** cryptojanitor has joined #bitcoin-core-dev
425 2018-04-24T20:37:40  *** Krellan has joined #bitcoin-core-dev
426 2018-04-24T20:48:43  *** Giszmo has joined #bitcoin-core-dev
427 2018-04-24T20:49:11  *** Krellan has quit IRC
428 2018-04-24T20:49:24  *** Krellan_ has joined #bitcoin-core-dev
429 2018-04-24T20:54:32  *** promag has joined #bitcoin-core-dev
430 2018-04-24T21:03:39  *** CubicEarths has joined #bitcoin-core-dev
431 2018-04-24T21:07:40  *** Aaronvan_ has quit IRC
432 2018-04-24T21:07:53  *** AaronvanW has joined #bitcoin-core-dev
433 2018-04-24T21:08:52  *** Guyver2 has quit IRC
434 2018-04-24T21:12:32  *** Randolf has joined #bitcoin-core-dev
435 2018-04-24T21:13:06  *** shesek has quit IRC
436 2018-04-24T21:14:03  *** promag has quit IRC
437 2018-04-24T21:14:30  *** promag has joined #bitcoin-core-dev
438 2018-04-24T21:15:24  *** AaronvanW has quit IRC
439 2018-04-24T21:17:16  *** dongcarl has joined #bitcoin-core-dev
440 2018-04-24T21:18:16  *** AaronvanW has joined #bitcoin-core-dev
441 2018-04-24T21:22:55  *** drexl has joined #bitcoin-core-dev
442 2018-04-24T21:26:37  *** shesek has joined #bitcoin-core-dev
443 2018-04-24T21:26:37  *** shesek has joined #bitcoin-core-dev
444 2018-04-24T21:26:42  *** zautomata has joined #bitcoin-core-dev
445 2018-04-24T21:27:58  *** promag has quit IRC
446 2018-04-24T21:34:33  *** Chris_Stewart_5 has quit IRC
447 2018-04-24T21:40:23  *** Krellan_ has quit IRC
448 2018-04-24T21:42:05  *** Giszmo has quit IRC
449 2018-04-24T21:56:54  *** Giszmo has joined #bitcoin-core-dev
450 2018-04-24T22:00:29  *** larafale has quit IRC
451 2018-04-24T22:03:31  *** mistergo1d has joined #bitcoin-core-dev
452 2018-04-24T22:06:22  *** mistergold has quit IRC
453 2018-04-24T22:06:22  *** nickler has quit IRC
454 2018-04-24T22:07:04  *** nickler has joined #bitcoin-core-dev
455 2018-04-24T22:08:55  *** mistergo1d has quit IRC
456 2018-04-24T22:09:21  *** promag has joined #bitcoin-core-dev
457 2018-04-24T22:26:39  <jtimon> jimpo: promag re https://github.com/bitcoin/bitcoin/pull/10757#discussion_r183860805 I mean why is https://github.com/bitcoin/bitcoin/pull/10757/commits/c42248053a7cab3356f72413caafcb4a8fa845d4#diff-dbccfb6d2ff211cd44b8f5e532e3238aR170 working?
458 2018-04-24T22:27:21  <jtimon> sorry, this https://github.com/bitcoin/bitcoin/pull/10757/commits/c42248053a7cab3356f72413caafcb4a8fa845d4#diff-dbccfb6d2ff211cd44b8f5e532e3238aR146
459 2018-04-24T22:28:00  <promag> jtimon: vRPCConvertParams is only used by bitcoin-cli
460 2018-04-24T22:28:14  <promag> to parse argv correctly
461 2018-04-24T22:28:27  <jtimon> promag: which is used by that test, no?
462 2018-04-24T22:28:33  <promag> test framework uses python rpc client
463 2018-04-24T22:28:37  <promag> no
464 2018-04-24T22:28:42  <jtimon> oh, sorry, got you
465 2018-04-24T22:28:47  <promag> np
466 2018-04-24T22:29:22  <promag> I also forget testing with bitcoin-cli..
467 2018-04-24T22:30:11  <jtimon> yeah, not the first time it happens to me either, should had understood your comment simply by past experience
468 2018-04-24T22:34:02  *** d9b4bef9 has quit IRC
469 2018-04-24T22:35:08  *** d9b4bef9 has joined #bitcoin-core-dev
470 2018-04-24T22:45:57  *** Randolf has quit IRC
471 2018-04-24T22:48:20  *** Murch has quit IRC
472 2018-04-24T22:52:12  *** zigen has joined #bitcoin-core-dev
473 2018-04-24T22:56:54  *** zigen has quit IRC
474 2018-04-24T23:01:01  *** Giszmo has quit IRC
475 2018-04-24T23:05:17  *** justanotheruser has quit IRC
476 2018-04-24T23:05:56  *** ProfMac has joined #bitcoin-core-dev
477 2018-04-24T23:07:09  *** justanotheruser has joined #bitcoin-core-dev
478 2018-04-24T23:21:37  *** grafcaps has quit IRC
479 2018-04-24T23:21:47  *** Giszmo has joined #bitcoin-core-dev
480 2018-04-24T23:24:02  *** drexl has quit IRC
481 2018-04-24T23:24:51  *** grafcaps has joined #bitcoin-core-dev
482 2018-04-24T23:29:46  *** grafcaps has quit IRC
483 2018-04-24T23:40:31  *** ossifrage_ is now known as ossifrage
484 2018-04-24T23:52:25  *** grafcaps has joined #bitcoin-core-dev
485 2018-04-24T23:58:00  *** Randolf has joined #bitcoin-core-dev