12018-05-04T00:06:24  *** AaronvanW has joined #bitcoin-core-dev
  22018-05-04T00:06:41  <cfields> jamesob: heh, no worries
  32018-05-04T00:07:14  <cfields> sipa: it just occured to me that Span is begging to be used for scatter/gather
  42018-05-04T00:07:28  *** isis_ is now known as isis
  52018-05-04T00:07:43  <sipa> ha, yes
  62018-05-04T00:08:58  <cfields> Span& even casts perfectly to iovec*
  72018-05-04T00:09:38  <cfields> trying to decide if we should encourage that with a helper, or encourage iovec vec(span.data(), span.size()) instead.
  82018-05-04T00:10:17  *** Aaronvan_ has quit IRC
  92018-05-04T00:11:21  <cfields> https://0bin.net/paste/gRcNPbxui+WjB-jK#rXShNTSfMZHh6hZXiUbjxHBzcUwb4dXmy2J3aUYkBzR
 102018-05-04T00:12:36  <sipa> that sounds awefully platform specific
 112018-05-04T00:12:41  <sipa> *awfully?
 122018-05-04T00:13:00  *** lnostdal has quit IRC
 132018-05-04T00:13:48  <cfields> i think it's pretty universal, the struct padding is the only thing i can see practically changing...
 142018-05-04T00:14:08  <cfields> but I guess you're right, it doesn't save much
 152018-05-04T00:14:24  *** meshcollider has joined #bitcoin-core-dev
 162018-05-04T00:35:15  *** belcher has quit IRC
 172018-05-04T00:38:07  *** moneyball has joined #bitcoin-core-dev
 182018-05-04T00:40:10  *** moneyball has quit IRC
 192018-05-04T00:48:27  *** justanotheruser has quit IRC
 202018-05-04T00:51:56  *** justanotheruser has joined #bitcoin-core-dev
 212018-05-04T01:04:52  *** fanquake has joined #bitcoin-core-dev
 222018-05-04T01:08:05  *** AaronvanW has quit IRC
 232018-05-04T01:09:27  *** DrFeelGood has quit IRC
 242018-05-04T01:10:02  <fanquake> pierre_rochard nice rupdates to bitcoinacks so far.
 252018-05-04T01:18:15  <pierre_rochard> Thanks fanquake! ICYMI: https://bitcoinacks.com/ I have a few ideas for the next big iteration ( https://github.com/PierreRochard/bitcoin-acks/blob/acks/README.md ), happy to add more if you have anything that is dragging you down as a contributor/reviewer/maintainer. Something I was thinking about during today’s meeting was surfacing High Priority for review PRs in the UI.
 262018-05-04T01:26:02  <fanquake> pierre_rochard Cool, I'll take a look. Even something as simple as a different background colour on the High Priority PRs might work.
 272018-05-04T01:29:26  *** arowser has quit IRC
 282018-05-04T01:29:43  *** arowser has joined #bitcoin-core-dev
 292018-05-04T02:15:08  <bitcoin-git> [bitcoin] fanquake opened pull request #13165: doc: Mention good first issue list in CONTRIBUTING.md (master...good-first-issue) https://github.com/bitcoin/bitcoin/pull/13165
 302018-05-04T02:16:21  <luke-jr> pierre_rochard: not forcing the horizontal scrollbar off would be nice
 312018-05-04T02:16:55  <luke-jr> and some way to hide closed PRs
 322018-05-04T02:17:16  <luke-jr> not sure why adding a filter for Closed insists on the value being a date O.o
 332018-05-04T02:23:02  *** Emcy has joined #bitcoin-core-dev
 342018-05-04T03:02:36  *** furnace has joined #bitcoin-core-dev
 352018-05-04T03:04:26  *** furnace has left #bitcoin-core-dev
 362018-05-04T03:27:30  <fanquake> Not the most useful error message for Core to spit out heh: https://0bin.net/paste/fIINOwfRR9GIR-SZ#c7Sx1+EM3HJjYaTx0C6c5Exa6MYt7AIO-RweISgWZcG
 372018-05-04T03:27:57  <fanquake> Looking at #13161, there seems to be a case where even after a database error Core just continues on, and then segfaults at shutdown.
 382018-05-04T03:27:59  <gribble> https://github.com/bitcoin/bitcoin/issues/13161 | wallet: Reset BerkeleyDB handle after connection fails by real-or-random · Pull Request #13161 · bitcoin/bitcoin · GitHub
 392018-05-04T03:59:29  *** grafcaps has quit IRC
 402018-05-04T04:18:16  *** thrasher`` has quit IRC
 412018-05-04T04:23:45  *** Emcy has quit IRC
 422018-05-04T05:11:30  <ken2812221> fanquake: That happened while I was testing #12985 if Bitcoin Core cannot write wallet file
 432018-05-04T05:11:32  <gribble> https://github.com/bitcoin/bitcoin/issues/12985 | Windows: Avoid launching as admin when NSIS installer ends. by JeremyRand · Pull Request #12985 · bitcoin/bitcoin · GitHub
 442018-05-04T05:15:43  *** Bosma has quit IRC
 452018-05-04T05:15:44  *** felco has quit IRC
 462018-05-04T05:15:44  *** Megumiin has quit IRC
 472018-05-04T05:15:44  *** DougieBot5000 has quit IRC
 482018-05-04T05:15:44  *** gmaxwell has quit IRC
 492018-05-04T05:15:44  *** nsh has quit IRC
 502018-05-04T05:15:44  *** mdrollette has quit IRC
 512018-05-04T05:15:44  *** MarcoFalke has quit IRC
 522018-05-04T05:15:44  *** Apocalyptic has quit IRC
 532018-05-04T05:15:49  *** mdrollette has joined #bitcoin-core-dev
 542018-05-04T05:15:50  *** MarcoFalke has joined #bitcoin-core-dev
 552018-05-04T05:15:54  *** gmaxwell has joined #bitcoin-core-dev
 562018-05-04T05:16:01  *** Bosma has joined #bitcoin-core-dev
 572018-05-04T05:16:09  *** felco has joined #bitcoin-core-dev
 582018-05-04T05:16:12  *** DougieBot5000 has joined #bitcoin-core-dev
 592018-05-04T05:16:12  *** Apocalyptic has joined #bitcoin-core-dev
 602018-05-04T05:16:12  *** Megumiin has joined #bitcoin-core-dev
 612018-05-04T05:16:16  *** gmaxwell is now known as Guest9910
 622018-05-04T05:18:19  *** infernix has quit IRC
 632018-05-04T05:18:54  *** spinza has quit IRC
 642018-05-04T05:25:18  *** nsh has joined #bitcoin-core-dev
 652018-05-04T05:26:57  *** cryptojanitor has quit IRC
 662018-05-04T05:27:37  *** spinza has joined #bitcoin-core-dev
 672018-05-04T05:35:29  *** DrFeelGood has joined #bitcoin-core-dev
 682018-05-04T05:37:54  *** infernix has joined #bitcoin-core-dev
 692018-05-04T05:40:23  *** jtimon has quit IRC
 702018-05-04T05:47:43  *** LeMiner has joined #bitcoin-core-dev
 712018-05-04T05:51:01  *** JackH_ has joined #bitcoin-core-dev
 722018-05-04T05:52:15  *** Victorsueca has quit IRC
 732018-05-04T05:53:25  *** Victorsueca has joined #bitcoin-core-dev
 742018-05-04T05:53:25  *** JackH has quit IRC
 752018-05-04T06:08:21  *** amiller has quit IRC
 762018-05-04T06:26:38  *** Guest9910 has quit IRC
 772018-05-04T06:26:38  *** Guest9910 has joined #bitcoin-core-dev
 782018-05-04T06:27:04  *** Guest9910 is now known as gmaxwell
 792018-05-04T06:38:39  *** promag has joined #bitcoin-core-dev
 802018-05-04T06:41:33  *** promag has quit IRC
 812018-05-04T06:47:47  *** LeMiner2 has joined #bitcoin-core-dev
 822018-05-04T06:51:22  *** LeMiner has quit IRC
 832018-05-04T06:51:22  *** LeMiner2 is now known as LeMiner
 842018-05-04T06:55:37  *** grafcaps has joined #bitcoin-core-dev
 852018-05-04T07:00:39  *** grafcaps has quit IRC
 862018-05-04T07:21:35  *** glaksmono has joined #bitcoin-core-dev
 872018-05-04T07:22:10  <glaksmono> hi all
 882018-05-04T07:22:12  <glaksmono> anyone is around?
 892018-05-04T07:29:02  <luke-jr> if you have a question, just ask; don't ask to ask or if anyone is around (your client can show you there are 241 people here)
 902018-05-04T07:29:55  <glaksmono> Is there a tutorial somewhere on how to fork a coin?
 912018-05-04T07:30:09  <glaksmono> I want to learn how is Bitcoin born from the technical perspective
 922018-05-04T07:30:15  <glaksmono> @luke-jr
 932018-05-04T07:32:55  <luke-jr> it wasn't born by a fork, and such things are not on topic here
 942018-05-04T07:34:35  <sipa> try ##altcoin-dev
 952018-05-04T07:36:23  <glaksmono> thanks @sipa @luke-jr
 962018-05-04T07:36:27  <glaksmono> in any case, how it was born?
 972018-05-04T07:36:39  <glaksmono> so let's assume Satoshi on the early days finish his coding.. and then compiled
 982018-05-04T07:36:47  <glaksmono> then he deployed the first bitcoind in a server i presume?
 992018-05-04T07:37:07  <glaksmono> i also posted my question here: https://bitcointalk.org/index.php?topic=3526903.0
1002018-05-04T07:45:04  *** ghost43 has quit IRC
1012018-05-04T07:45:16  *** ghost43 has joined #bitcoin-core-dev
1022018-05-04T07:46:23  *** Krellan has joined #bitcoin-core-dev
1032018-05-04T07:47:53  *** LeMiner2 has joined #bitcoin-core-dev
1042018-05-04T07:51:22  *** LeMiner has quit IRC
1052018-05-04T07:51:22  *** LeMiner2 is now known as LeMiner
1062018-05-04T07:57:10  <sipa> glaksmono: this is a place for development, not bitcoin mythology
1072018-05-04T08:13:50  *** setpill has joined #bitcoin-core-dev
1082018-05-04T08:27:56  *** Victorsueca has quit IRC
1092018-05-04T08:29:09  *** Victorsueca has joined #bitcoin-core-dev
1102018-05-04T08:29:18  *** laurentmt has joined #bitcoin-core-dev
1112018-05-04T08:29:40  *** laurentmt has quit IRC
1122018-05-04T08:32:40  *** timothy has joined #bitcoin-core-dev
1132018-05-04T08:37:10  *** drizztbsd has joined #bitcoin-core-dev
1142018-05-04T08:37:27  *** timothy has quit IRC
1152018-05-04T08:38:59  *** JackH_ has quit IRC
1162018-05-04T08:43:47  *** grafcaps has joined #bitcoin-core-dev
1172018-05-04T08:47:57  *** LeMiner2 has joined #bitcoin-core-dev
1182018-05-04T08:48:01  *** grafcaps has quit IRC
1192018-05-04T08:51:22  *** LeMiner has quit IRC
1202018-05-04T08:51:22  *** LeMiner2 is now known as LeMiner
1212018-05-04T09:07:33  *** drizztbsd is now known as timothy
1222018-05-04T09:09:50  <jonasschnelli> external tx index via p2p with leveldb and ~1'000'000 record mem cache: full index via p2p localhost up to block 500'000: 87m41.629s
1232018-05-04T09:09:52  <jonasschnelli> (SSD)
1242018-05-04T09:10:09  <jonasschnelli> PoC: https://github.com/jonasschnelli/bitcoincore-indexd
1252018-05-04T09:20:48  <wumpus> jonasschnelli: awesome!
1262018-05-04T09:21:03  <wumpus> jonasschnelli: is that with or without my patch at the bitcoind side?
1272018-05-04T09:21:18  <jonasschnelli> without... will compare performance soon
1282018-05-04T09:22:00  <jonasschnelli> I'm working on a test setup where block 450'000 to 500'000 will be requested probably 100-1000 times... then print the median result
1292018-05-04T09:22:11  <jonasschnelli> the client just loads the block but does not deserialize it
1302018-05-04T09:22:48  <wumpus> right, you have block request logic in bitcoincore-indexd, so might be an idea to start from that and make a benchmarker that just pulls blocks and drops them
1312018-05-04T09:23:14  <wumpus> I thought about making something based on the P2P functional test framework, but python is likely going to be a bottleneck then
1322018-05-04T09:27:06  <jonasschnelli> yes. the current poc uses libbtc which is a straight forward p2p client using libevent2
1332018-05-04T09:28:38  *** arowser has quit IRC
1342018-05-04T09:34:45  *** arowser has joined #bitcoin-core-dev
1352018-05-04T09:34:57  *** justanotheruser has quit IRC
1362018-05-04T09:48:04  *** LeMiner2 has joined #bitcoin-core-dev
1372018-05-04T09:51:22  *** LeMiner has quit IRC
1382018-05-04T09:51:22  *** LeMiner2 is now known as LeMiner
1392018-05-04T09:59:37  *** forrestpan has joined #bitcoin-core-dev
1402018-05-04T10:01:19  *** Krellan has quit IRC
1412018-05-04T10:01:55  *** Krellan has joined #bitcoin-core-dev
1422018-05-04T10:04:00  *** forrestpan has quit IRC
1432018-05-04T10:07:57  *** glaksmono has quit IRC
1442018-05-04T10:08:20  *** AaronvanW has joined #bitcoin-core-dev
1452018-05-04T10:08:24  *** glaksmono has joined #bitcoin-core-dev
1462018-05-04T10:09:04  *** lnostdal has joined #bitcoin-core-dev
1472018-05-04T10:11:03  <wumpus> jonasschnelli: going to try to build it
1482018-05-04T10:11:56  <jonasschnelli> wumpus: great. with python?
1492018-05-04T10:12:09  <wumpus> jonasschnelli: I mean your indexd project
1502018-05-04T10:12:34  <wumpus> and try to do some benchmarking with it
1512018-05-04T10:13:08  <jonasschnelli> wumpus: it's very immature and sketchy
1522018-05-04T10:13:32  <wumpus> yes but I only need a very basic node framework for this, the less overhead the better
1532018-05-04T10:13:39  <jonasschnelli> also... you probably need a manual -lpthread for linking... :)
1542018-05-04T10:13:47  *** Emcy has joined #bitcoin-core-dev
1552018-05-04T10:13:57  *** belcher has joined #bitcoin-core-dev
1562018-05-04T10:15:48  *** glaksmono has quit IRC
1572018-05-04T10:17:30  <jonasschnelli> yes... give it a try
1582018-05-04T10:17:32  <wumpus> I first have to make it find my customized libevent
1592018-05-04T10:18:10  <wumpus> hopefully PKG_CONFIG_PATH does just work :)
1602018-05-04T10:18:12  *** glaksmono has joined #bitcoin-core-dev
1612018-05-04T10:19:54  *** SopaXorzTaker has joined #bitcoin-core-dev
1622018-05-04T10:23:56  <wumpus> jonasschnelli: a shame, looks like the libbtc libevent2 check doesn't use pkgconfig to check where the library is
1632018-05-04T10:24:33  <wumpus> I'll see if I can add that or maybe I'll just whack in CPPFLAGS=... for now
1642018-05-04T10:31:59  *** grafcaps has joined #bitcoin-core-dev
1652018-05-04T10:35:10  *** Emcy has quit IRC
1662018-05-04T10:36:35  *** grafcaps has quit IRC
1672018-05-04T10:36:46  *** laurentmt has joined #bitcoin-core-dev
1682018-05-04T10:37:04  *** Guyver2 has joined #bitcoin-core-dev
1692018-05-04T10:42:17  *** laurentmt has quit IRC
1702018-05-04T10:46:03  *** Emcy has joined #bitcoin-core-dev
1712018-05-04T10:48:12  *** LeMiner2 has joined #bitcoin-core-dev
1722018-05-04T10:49:23  <jonasschnelli> wumpus: Good point. happy if you open a PR at github.com/libbtc/libbtc ;)
1732018-05-04T10:51:22  *** LeMiner has quit IRC
1742018-05-04T10:51:22  *** LeMiner2 is now known as LeMiner
1752018-05-04T10:56:46  <bitcoin-git> [bitcoin] mocacinno opened pull request #13166: Master (0.14...master) https://github.com/bitcoin/bitcoin/pull/13166
1762018-05-04T10:57:35  <bitcoin-git> [bitcoin] fanquake closed pull request #13166: Master (0.14...master) https://github.com/bitcoin/bitcoin/pull/13166
1772018-05-04T11:04:08  *** larafale has joined #bitcoin-core-dev
1782018-05-04T11:08:21  *** Victorsueca has quit IRC
1792018-05-04T11:10:03  *** Victorsueca has joined #bitcoin-core-dev
1802018-05-04T11:10:33  <wumpus> jonasschnelli: also need to pass in -fPIC I suposse /usr/bin/ld: bitcoincore_indexd-btcnode.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
1812018-05-04T11:15:32  *** aknb has joined #bitcoin-core-dev
1822018-05-04T11:16:39  *** arowser has quit IRC
1832018-05-04T11:17:46  *** arowser has joined #bitcoin-core-dev
1842018-05-04T11:26:51  *** glaksmono has quit IRC
1852018-05-04T11:27:17  *** glaksmono has joined #bitcoin-core-dev
1862018-05-04T11:29:48  *** glaksmon_ has joined #bitcoin-core-dev
1872018-05-04T11:31:21  *** glaksmono has quit IRC
1882018-05-04T11:32:40  *** arowser has quit IRC
1892018-05-04T11:32:57  *** arowser has joined #bitcoin-core-dev
1902018-05-04T11:33:51  *** glaksmon_ has quit IRC
1912018-05-04T11:34:34  *** promag has joined #bitcoin-core-dev
1922018-05-04T11:34:57  *** DrFeelGood has quit IRC
1932018-05-04T11:35:58  *** arowser has quit IRC
1942018-05-04T11:36:16  *** arowser has joined #bitcoin-core-dev
1952018-05-04T11:36:53  *** fanquake has quit IRC
1962018-05-04T11:37:43  *** aknb has left #bitcoin-core-dev
1972018-05-04T11:41:20  *** arowser has quit IRC
1982018-05-04T11:41:38  *** arowser has joined #bitcoin-core-dev
1992018-05-04T11:43:33  *** arowser has quit IRC
2002018-05-04T11:43:52  *** arowser has joined #bitcoin-core-dev
2012018-05-04T11:46:01  *** promag has quit IRC
2022018-05-04T11:46:26  *** DrFeelGood has joined #bitcoin-core-dev
2032018-05-04T11:48:16  *** LeMiner2 has joined #bitcoin-core-dev
2042018-05-04T11:48:20  *** Emcy has quit IRC
2052018-05-04T11:48:25  *** DrFeelGood has quit IRC
2062018-05-04T11:49:27  *** DrFeelGood has joined #bitcoin-core-dev
2072018-05-04T11:50:00  *** Emcy has joined #bitcoin-core-dev
2082018-05-04T11:51:58  *** LeMiner has quit IRC
2092018-05-04T11:51:58  *** LeMiner2 is now known as LeMiner
2102018-05-04T11:53:50  *** arowser has quit IRC
2112018-05-04T11:54:08  *** arowser has joined #bitcoin-core-dev
2122018-05-04T11:54:54  *** promag has joined #bitcoin-core-dev
2132018-05-04T11:58:05  <wumpus> jonasschnelli: where does it get the node configuration (where to connect to) from?
2142018-05-04T11:58:32  <jonasschnelli> wumpus: btcnode.cpp
2152018-05-04T11:58:42  <jonasschnelli> search after 127.0.0,1
2162018-05-04T11:58:59  <wumpus> ok I see,t hanks
2172018-05-04T12:00:17  <wumpus> so simply 127.0.0.1:8333, but it wasn't connecting because my node was not listening
2182018-05-04T12:02:04  *** arowser has quit IRC
2192018-05-04T12:02:27  *** arowser has joined #bitcoin-core-dev
2202018-05-04T12:05:19  <wumpus> it doesn't start requesting blocks :/
2212018-05-04T12:06:51  <wumpus> jonasschnelli: is there anything I need to do to make it start pulling blocks? https://0bin.net/paste/TJj0okkQanP2H++H#VgX0GogDES9a0RXqsvgyKYJC5Ed0Y-4RFQwgO2aKQYe is my output, seems to be idling
2222018-05-04T12:08:34  <jonasschnelli> wumpus: What do you do in handshake_done()?
2232018-05-04T12:08:42  <jonasschnelli> This is where you should ask for blocks
2242018-05-04T12:08:55  <jonasschnelli> the current bitcoincore-indexd does sync headers first
2252018-05-04T12:09:10  <wumpus> jonasschnelli: haven't changed the function
2262018-05-04T12:10:15  <jonasschnelli> wumpus: it looks like it doesn request headers then
2272018-05-04T12:10:29  <jonasschnelli> maybe set a breakpoint in void handshake_done(struct btc_node_ *node)
2282018-05-04T12:10:44  <jonasschnelli> wumpus: wait..
2292018-05-04T12:10:53  <jonasschnelli> your client-peer is sending a getheaders()
2302018-05-04T12:11:02  <jonasschnelli> -()
2312018-05-04T12:11:15  <jonasschnelli> but seems like your remote node does not answer
2322018-05-04T12:11:19  <wumpus> will do - the node syncing from is not up to date with the chain, could that be a problem?
2332018-05-04T12:11:25  <jonasschnelli> Are they on the same network? Mainnet/etc.?
2342018-05-04T12:11:31  <wumpus> yes both on mainnet
2352018-05-04T12:11:50  <wumpus> I'll look into it
2362018-05-04T12:12:01  <jonasschnelli> wumpus: eventually... the client node will ask for headers from genesis... could be that your remote node is refusing that during IBD
2372018-05-04T12:13:23  *** arowser has quit IRC
2382018-05-04T12:13:45  *** arowser has joined #bitcoin-core-dev
2392018-05-04T12:14:59  *** pierre_rochard has quit IRC
2402018-05-04T12:16:16  <wumpus> jonasschnelli: indeed - seems like the old "Ignoring getheaders from peer=%d because node is in initial block download" plague again, adding whitelist=127.0.0.1 solved it
2412018-05-04T12:16:47  <wumpus> it's rolling
2422018-05-04T12:17:09  <jonasschnelli> wumpus: why did you use a custom built libevent? Did you modify the sources for performance measuring?
2432018-05-04T12:18:18  <wumpus> I want to have a newer one that is installed on this version of ubuntu by default, I've also made some http changes to make it work with UNIX domain sockets, though that part isn't necessary here it's the only version of libevent I have installed
2442018-05-04T12:18:54  <wumpus> (and I always install manuall-compiled things into /opt/<libname>, not in /usr)
2452018-05-04T12:19:09  <jonasschnelli> I see
2462018-05-04T12:21:41  *** arowser has quit IRC
2472018-05-04T12:21:59  *** arowser has joined #bitcoin-core-dev
2482018-05-04T12:22:33  *** grafcaps has joined #bitcoin-core-dev
2492018-05-04T12:24:07  *** arowser has quit IRC
2502018-05-04T12:24:26  *** arowser has joined #bitcoin-core-dev
2512018-05-04T12:27:18  *** blackbaba has joined #bitcoin-core-dev
2522018-05-04T12:27:36  *** cryptojanitor has joined #bitcoin-core-dev
2532018-05-04T12:29:11  *** jtimon has joined #bitcoin-core-dev
2542018-05-04T12:31:31  <wumpus> jonasschnelli: looks like it doesn't hit the fast path, I suppose your indexer doesn't request MSG_WITNESS_BLOCK?
2552018-05-04T12:32:34  <jonasschnelli> wumpus: the indexer does send a inv with blockhashes... shouldn't this result in a MSG_WITNESS_BLOCK?
2562018-05-04T12:34:44  <wumpus> jonasschnelli: ser_u32(inv_msg_cstr, 2);   <- that's MSG_BLOCK, not MSG_WITNESS_BLOCK
2572018-05-04T12:35:13  <wumpus> needs 1 << 30 ORed in
2582018-05-04T12:37:58  <jonasschnelli> Right. Yes. I guess just changing to MSG_BLOCK | MSG_WITNESS_FLAG should do the job.
2592018-05-04T12:38:29  <wumpus> yes
2602018-05-04T12:38:58  <wumpus> eh no, those constants are not defined anywhere
2612018-05-04T12:39:58  <wumpus> would be a good idea though
2622018-05-04T12:42:57  <jonasschnelli> yes
2632018-05-04T12:43:44  *** blackbaba has quit IRC
2642018-05-04T12:48:32  *** LeMiner2 has joined #bitcoin-core-dev
2652018-05-04T12:50:27  <wumpus> ok, hitting the fast path now on the server side, I commented out the transaction processing code on the client side - and make it quit when current block height is 473600 (arbitrary)... just a matter of waiting now
2662018-05-04T12:51:24  *** Victorsueca has quit IRC
2672018-05-04T12:51:58  *** LeMiner has quit IRC
2682018-05-04T12:51:58  *** LeMiner2 is now known as LeMiner
2692018-05-04T12:52:39  *** Victorsueca has joined #bitcoin-core-dev
2702018-05-04T12:55:18  <jonasschnelli> wumpus: I would probably start from 450000 up to 500000 for performance tests.
2712018-05-04T12:56:19  <wumpus> yes maybe - I don't have any more recennt blocks on this node, so this will have to do for now
2722018-05-04T12:58:15  <wumpus> including the small blocks in the beginning is not very useful, probably, but should not take a lot of time
2732018-05-04T12:59:17  <jonasschnelli> Indeed.
2742018-05-04T13:00:02  <jonasschnelli> wumpus: for performance benchmarks, what do you think in requesting 450k-500k, measure time, loop this for 1000 and calculate avg/med?
2752018-05-04T13:00:16  <jonasschnelli> 450-500k should take seconds
2762018-05-04T13:01:41  <wumpus> requesting the same blocks over again will make them end up in the disk cache, though it's easy to average out especially when you disregard the first run
2772018-05-04T13:06:47  *** promag has joined #bitcoin-core-dev
2782018-05-04T13:07:31  *** tryphe_ has joined #bitcoin-core-dev
2792018-05-04T13:08:00  *** str4d has joined #bitcoin-core-dev
2802018-05-04T13:11:09  *** tryphe has quit IRC
2812018-05-04T13:11:22  *** promag has quit IRC
2822018-05-04T13:24:06  *** cryptapus has quit IRC
2832018-05-04T13:24:35  *** cryptapus has joined #bitcoin-core-dev
2842018-05-04T13:24:35  *** cryptapus has quit IRC
2852018-05-04T13:24:35  *** cryptapus has joined #bitcoin-core-dev
2862018-05-04T13:47:19  *** justanotheruser has joined #bitcoin-core-dev
2872018-05-04T13:48:34  *** LeMiner2 has joined #bitcoin-core-dev
2882018-05-04T13:50:22  *** arowser has quit IRC
2892018-05-04T13:50:39  *** arowser has joined #bitcoin-core-dev
2902018-05-04T13:51:58  *** LeMiner has quit IRC
2912018-05-04T13:51:58  *** LeMiner2 is now known as LeMiner
2922018-05-04T13:55:33  *** arowser has quit IRC
2932018-05-04T13:56:05  *** arowser has joined #bitcoin-core-dev
2942018-05-04T13:58:00  *** arowser has quit IRC
2952018-05-04T13:58:17  *** arowser has joined #bitcoin-core-dev
2962018-05-04T13:59:24  *** arowser has quit IRC
2972018-05-04T13:59:41  *** arowser has joined #bitcoin-core-dev
2982018-05-04T14:10:42  *** grafcaps has quit IRC
2992018-05-04T14:11:21  *** str4d has quit IRC
3002018-05-04T14:12:01  *** tryphe_000 has joined #bitcoin-core-dev
3012018-05-04T14:15:05  *** tryphe_000 has quit IRC
3022018-05-04T14:15:07  *** tryphe_ has quit IRC
3032018-05-04T14:15:18  *** m8tion has joined #bitcoin-core-dev
3042018-05-04T14:15:31  *** tryphe_000 has joined #bitcoin-core-dev
3052018-05-04T14:16:47  *** larafale has quit IRC
3062018-05-04T14:21:17  *** setpill has quit IRC
3072018-05-04T14:21:57  *** bsm1175321 has quit IRC
3082018-05-04T14:23:43  *** Soligor has quit IRC
3092018-05-04T14:23:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7eb7076f7007...627c3762ce5d
3102018-05-04T14:23:50  <bitcoin-git> bitcoin/master a508091 fanquake: doc: Mention good first issue list in CONTRIBUTING.md
3112018-05-04T14:23:50  <bitcoin-git> bitcoin/master 627c376 MarcoFalke: Merge #13165: doc: Mention good first issue list in CONTRIBUTING.md...
3122018-05-04T14:24:44  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13165: doc: Mention good first issue list in CONTRIBUTING.md (master...good-first-issue) https://github.com/bitcoin/bitcoin/pull/13165
3132018-05-04T14:26:00  *** SopaXorzTaker has quit IRC
3142018-05-04T14:31:52  *** Soligor has joined #bitcoin-core-dev
3152018-05-04T14:33:15  *** vinny has joined #bitcoin-core-dev
3162018-05-04T14:39:26  *** glaksmono has joined #bitcoin-core-dev
3172018-05-04T14:44:02  *** glaksmono has quit IRC
3182018-05-04T14:48:41  *** LeMiner2 has joined #bitcoin-core-dev
3192018-05-04T14:51:58  *** LeMiner has quit IRC
3202018-05-04T14:51:58  *** LeMiner2 is now known as LeMiner
3212018-05-04T14:57:23  *** cryptojanitor has quit IRC
3222018-05-04T15:23:51  *** harrymm has quit IRC
3232018-05-04T15:37:43  <bitcoin-git> [bitcoin] martinus opened pull request #13167: Refactoring: optimize SelectCoinsBnB (master...optimize-SelectCoinsBnB) https://github.com/bitcoin/bitcoin/pull/13167
3242018-05-04T15:46:45  *** promag has joined #bitcoin-core-dev
3252018-05-04T15:47:54  *** Randolf has quit IRC
3262018-05-04T15:48:47  *** LeMiner2 has joined #bitcoin-core-dev
3272018-05-04T15:50:35  *** promag has quit IRC
3282018-05-04T15:51:27  *** promag has joined #bitcoin-core-dev
3292018-05-04T15:51:58  *** LeMiner has quit IRC
3302018-05-04T15:51:58  *** LeMiner2 is now known as LeMiner
3312018-05-04T16:05:39  *** str4d has joined #bitcoin-core-dev
3322018-05-04T16:14:10  *** meshcollider has quit IRC
3332018-05-04T16:18:02  *** promag has quit IRC
3342018-05-04T16:28:12  <sdaftuar> BlueMatt: i think there might be another edge case bug in ABC that we didn't talk about yet
3352018-05-04T16:28:31  <BlueMatt> oh? ugh
3362018-05-04T16:28:40  <sdaftuar> it seems like it might be possible for pruning to run in between cs_main lock acquisitions?
3372018-05-04T16:28:58  <sdaftuar> and it's FindMostWorkChain's job to deal with that
3382018-05-04T16:29:23  <sdaftuar> probably it couldn't really happen in any "normal" scenario
3392018-05-04T16:31:24  <sdaftuar> anyway i think this may not be so different than other modes where pruning might fail, so i don't know that we should worry about it, except maybe add some comments to remind ourselves
3402018-05-04T16:34:16  *** Randolf has joined #bitcoin-core-dev
3412018-05-04T16:40:04  *** mistergold has joined #bitcoin-core-dev
3422018-05-04T16:42:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3432018-05-04T16:44:44  *** m8tion has quit IRC
3442018-05-04T16:45:58  *** rmsz005 has joined #bitcoin-core-dev
3452018-05-04T16:47:24  *** ramzo has joined #bitcoin-core-dev
3462018-05-04T16:47:28  <ramzo> hello
3472018-05-04T16:48:51  *** LeMiner2 has joined #bitcoin-core-dev
3482018-05-04T16:50:11  *** mryandao has quit IRC
3492018-05-04T16:52:26  *** ramzo has quit IRC
3502018-05-04T16:52:34  *** LeMiner has quit IRC
3512018-05-04T16:52:34  *** LeMiner2 is now known as LeMiner
3522018-05-04T16:54:21  *** mryandao has joined #bitcoin-core-dev
3532018-05-04T16:55:57  *** Dizzle has joined #bitcoin-core-dev
3542018-05-04T16:55:59  *** SopaXorzTaker has joined #bitcoin-core-dev
3552018-05-04T16:56:11  *** Krellan has quit IRC
3562018-05-04T16:56:53  *** Krellan has joined #bitcoin-core-dev
3572018-05-04T17:04:07  *** promag has joined #bitcoin-core-dev
3582018-05-04T17:07:59  <ken2812221> Is there a way to update-alternatives in gitian builder? I'm trying to bump my gitian build to 18.04, but stuck at Windows update-alternatives to posix version.
3592018-05-04T17:09:01  *** Krellan has quit IRC
3602018-05-04T17:09:42  <wumpus> ken2812221: yes, you can sudo afaik
3612018-05-04T17:10:01  <ken2812221> no, sudo or su does not work.
3622018-05-04T17:13:21  <wumpus> I think it's possible to enable that in the descriptor
3632018-05-04T17:14:17  <ken2812221> Ok, I would find it, thanks.
3642018-05-04T17:15:50  *** timothy has quit IRC
3652018-05-04T17:17:34  <wumpus> gbuild has to be run with --alow-sudo in that case, too
3662018-05-04T17:17:52  *** ff_ has joined #bitcoin-core-dev
3672018-05-04T17:18:17  *** ff_ has quit IRC
3682018-05-04T17:19:50  <ken2812221> Ok. I'm trying.
3692018-05-04T17:21:38  <ken2812221> Thanks, it does work!!
3702018-05-04T17:33:23  <wumpus> good!
3712018-05-04T17:37:29  *** promag has quit IRC
3722018-05-04T17:38:17  *** promag has joined #bitcoin-core-dev
3732018-05-04T17:39:00  *** promag has quit IRC
3742018-05-04T17:39:22  *** lnostdal has quit IRC
3752018-05-04T17:45:39  *** lnostdal has joined #bitcoin-core-dev
3762018-05-04T17:47:32  *** vicenteH has quit IRC
3772018-05-04T17:48:59  *** LeMiner2 has joined #bitcoin-core-dev
3782018-05-04T17:52:35  *** LeMiner has quit IRC
3792018-05-04T17:52:35  *** LeMiner2 is now known as LeMiner
3802018-05-04T17:59:33  *** isis is now known as isis_
3812018-05-04T18:07:09  *** timothy has joined #bitcoin-core-dev
3822018-05-04T18:13:25  <ken2812221> Gitian-build fails due to no 'rename' program. it's a pain after it has been compiled for a long time.
3832018-05-04T18:15:10  *** Krellan has joined #bitcoin-core-dev
3842018-05-04T18:18:19  <MarcoFalke> How hard would it be to transcribe the gitian-descriptors into a docker file?
3852018-05-04T18:19:27  *** Krellan has quit IRC
3862018-05-04T18:20:26  <ken2812221> I'm not using docker, I'm using lxc.
3872018-05-04T18:22:43  *** glaksmono has joined #bitcoin-core-dev
3882018-05-04T18:23:15  *** timothy has quit IRC
3892018-05-04T18:27:05  *** glaksmono has quit IRC
3902018-05-04T18:27:45  <ken2812221> I've created a PR to gitian-builder, so we can use lxc 3.0.0 to do gitian-build
3912018-05-04T18:29:21  *** lnostdal has quit IRC
3922018-05-04T18:43:21  *** Victorsueca has quit IRC
3932018-05-04T18:44:40  *** Victorsueca has joined #bitcoin-core-dev
3942018-05-04T18:46:48  *** AaronvanW has quit IRC
3952018-05-04T18:49:07  *** LeMiner2 has joined #bitcoin-core-dev
3962018-05-04T18:50:26  *** Giszmo has quit IRC
3972018-05-04T18:52:34  *** LeMiner has quit IRC
3982018-05-04T18:52:34  *** LeMiner2 is now known as LeMiner
3992018-05-04T18:53:58  *** Giszmo has joined #bitcoin-core-dev
4002018-05-04T18:57:43  *** AaronvanW has joined #bitcoin-core-dev
4012018-05-04T18:59:06  *** Aaronvan_ has joined #bitcoin-core-dev
4022018-05-04T19:01:09  *** SopaXorzTaker has quit IRC
4032018-05-04T19:02:57  *** AaronvanW has quit IRC
4042018-05-04T19:04:32  <wumpus> ken2812221: great!
4052018-05-04T19:32:52  *** laurentmt has joined #bitcoin-core-dev
4062018-05-04T19:35:05  *** laurentmt has quit IRC
4072018-05-04T19:45:05  *** cphrmky has quit IRC
4082018-05-04T19:46:59  *** Giszmo has quit IRC
4092018-05-04T19:49:13  *** LeMiner2 has joined #bitcoin-core-dev
4102018-05-04T19:52:34  *** LeMiner has quit IRC
4112018-05-04T19:52:34  *** LeMiner2 is now known as LeMiner
4122018-05-04T20:03:35  <TheCharlatan> Are there existing benchmarking results for the bench tests available between armv7 and armv8 ?
4132018-05-04T20:09:49  *** zautomata3 has quit IRC
4142018-05-04T20:10:27  *** glaksmono has joined #bitcoin-core-dev
4152018-05-04T20:14:57  *** glaksmono has quit IRC
4162018-05-04T20:16:45  *** cphrmky has joined #bitcoin-core-dev
4172018-05-04T20:18:45  <skeees> sdaftuar: i'm unable to reproduce that genesis block failure - what are you doing to achieve?
4182018-05-04T20:19:24  <sdaftuar> while src/test/test_bitcoin -t validation_block_tests; do :; done
4192018-05-04T20:19:42  <sdaftuar> that was with a patch to try to get rid of that other error (i got rid of the BOOST_CHECK() call at line 160)
4202018-05-04T20:20:10  <skeees> hah - yeah i've been doing that a bunch too - no dice. maybe platform specific
4212018-05-04T20:20:25  *** promag has joined #bitcoin-core-dev
4222018-05-04T20:23:11  *** grafcaps has joined #bitcoin-core-dev
4232018-05-04T20:23:52  *** vicenteH has joined #bitcoin-core-dev
4242018-05-04T20:24:43  <sdaftuar> oh i see what you're saying about the genesis block -- yes that does seem like a test bug
4252018-05-04T20:25:30  <sdaftuar> and i guess the callbacks are all happening in a single thread anyway, so the BOOST_CHECK calls there should be safe
4262018-05-04T20:27:19  *** zautomata3 has joined #bitcoin-core-dev
4272018-05-04T20:27:48  *** ossifrage has quit IRC
4282018-05-04T20:28:21  <skeees> even though unable to reproduce - i've updated pr with something that i *think* will fix the error you're seeing related to that
4292018-05-04T20:28:44  *** lnostdal has joined #bitcoin-core-dev
4302018-05-04T20:29:18  *** ProfMac has quit IRC
4312018-05-04T20:31:38  *** promag has quit IRC
4322018-05-04T20:32:26  *** promag has joined #bitcoin-core-dev
4332018-05-04T20:33:18  *** promag has quit IRC
4342018-05-04T20:37:33  *** Emcy has quit IRC
4352018-05-04T20:39:58  *** lnostdal has quit IRC
4362018-05-04T20:42:24  <sdaftuar> skeees: i don't know how the threading works in the boost testing framework, but i did notice that you don't acquire cs_main before accessing chainActive.Tip() when you construct the TestSubscriber()
4372018-05-04T20:42:41  <sdaftuar> is it possible that there's a race where you're able to pull the value of the tip before the callback fires (very rarely?)
4382018-05-04T20:43:15  *** dx25 has quit IRC
4392018-05-04T20:43:42  *** mistergold has quit IRC
4402018-05-04T20:44:21  *** lnostdal has joined #bitcoin-core-dev
4412018-05-04T20:44:57  <skeees> hmmm you still seeing this issue even after 04176fc?
4422018-05-04T20:45:21  <skeees> didn't acquire because I assumed I'd be the only thread running in the test framework at that point
4432018-05-04T20:45:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/627c3762ce5d...f82e1c948212
4442018-05-04T20:45:24  <bitcoin-git> bitcoin/master c3f34d0 practicalswift: Make it clear which functions that are intended to be translation unit local...
4452018-05-04T20:45:25  <bitcoin-git> bitcoin/master f82e1c9 MarcoFalke: Merge #13163: Make it clear which functions that are intended to be translation unit local...
4462018-05-04T20:45:51  <sdaftuar> i was still trying to reproduce, haven't taken your fix yet
4472018-05-04T20:46:15  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13163: Make it clear which functions that are intended to be translation unit local (master...internal-linkage) https://github.com/bitcoin/bitcoin/pull/13163
4482018-05-04T20:48:43  *** Emcy has joined #bitcoin-core-dev
4492018-05-04T20:49:29  *** LeMiner2 has joined #bitcoin-core-dev
4502018-05-04T20:50:23  <sdaftuar> hmm that hypothesis doesn't seem to be panning out (i tried adding a sleep before the BlockConnected callbacks after we connect the genesis block, to see if that would trigger it -- no dice)
4512018-05-04T20:52:34  *** LeMiner has quit IRC
4522018-05-04T20:52:34  *** LeMiner2 is now known as LeMiner
4532018-05-04T20:59:27  <sdaftuar> skeees: oh, could it just be an issue of the scheduler getting to run the genesis block BlockConnected callbacks after the TestSubscriber is created?  i don't know what the callback semantics are--
4542018-05-04T20:59:58  <sdaftuar> do we callback only the callbacks that were subscribed at the time the event was generated, or do we callback everyone who is subscribed at the time the callback is actually fired off by the scheduler?
4552018-05-04T21:00:19  *** glaksmono has joined #bitcoin-core-dev
4562018-05-04T21:00:31  <skeees> i think it could be that
4572018-05-04T21:00:44  <sdaftuar> i can't figure out where to stick a sleep to verify that this is the issue...
4582018-05-04T21:00:50  <skeees> its not well defined right now because we push a callback to the scheduler that invokes the signal
4592018-05-04T21:01:05  <skeees> so you could subscribe after you push that callback but before signal is invoked i think
4602018-05-04T21:01:15  <sdaftuar> that's pretty weird behavior imo
4612018-05-04T21:01:24  *** LeMiner has quit IRC
4622018-05-04T21:01:34  <sdaftuar> but sort of exactly why we need these tests!
4632018-05-04T21:01:35  <bitcoin-git> [bitcoin] jamesob opened pull request #13168: Thread names in logs and deadlock debug tools (take 2) (master...2018-05-threadnames-take-2) https://github.com/bitcoin/bitcoin/pull/13168
4642018-05-04T21:02:24  <skeees> yeah - its strange - that behavior in particular starts to become a problem if you ever get into a state where you have a lot of dynamic subscription / unsubscription (e.g. may actually pose some challenges getting rid of mempool signals)
4652018-05-04T21:02:43  <skeees> but in current use case where you just subscribe on startup and those remain fixed - its not a huge deal
4662018-05-04T21:02:59  <sdaftuar> right
4672018-05-04T21:04:33  *** Krellan has joined #bitcoin-core-dev
4682018-05-04T21:05:04  *** glaksmono has quit IRC
4692018-05-04T21:05:35  *** lnostdal has quit IRC
4702018-05-04T21:08:09  <sdaftuar> aha! i think that's it
4712018-05-04T21:08:16  <sdaftuar> i managed to reproduce it with a sleep added to the scheduler
4722018-05-04T21:10:09  *** promag has joined #bitcoin-core-dev
4732018-05-04T21:10:25  *** zautomata3 has quit IRC
4742018-05-04T21:11:03  <sdaftuar> so we should decide if we want to stick with that behavior or not...  seems kind of shitty to me.  perhaps registering with the validationinterface should require the queue to be drained first?
4752018-05-04T21:11:08  <sdaftuar> not sure if that idea works
4762018-05-04T21:11:41  <sdaftuar> BlueMatt: ^^^
4772018-05-04T21:12:39  *** jtimon has quit IRC
4782018-05-04T21:14:35  <skeees> i think that's a separate pr - i'll put something together
4792018-05-04T21:14:50  <skeees> for this one - i think it'll suffice to change some of the subscription ordering
4802018-05-04T21:16:45  *** zautomata3 has joined #bitcoin-core-dev
4812018-05-04T21:17:41  *** lnostdal has joined #bitcoin-core-dev
4822018-05-04T21:32:39  *** Victorsueca has quit IRC
4832018-05-04T21:33:15  *** dx25 has joined #bitcoin-core-dev
4842018-05-04T21:33:54  *** Victorsueca has joined #bitcoin-core-dev
4852018-05-04T21:33:54  *** promag has quit IRC
4862018-05-04T21:34:41  *** harrymm has joined #bitcoin-core-dev
4872018-05-04T21:46:29  *** lnostdal has quit IRC
4882018-05-04T21:52:06  *** tryphe_000 is now known as tryphe
4892018-05-04T21:53:43  *** promag has joined #bitcoin-core-dev
4902018-05-04T21:59:35  *** str4d has quit IRC
4912018-05-04T22:03:05  *** Randolf has quit IRC
4922018-05-04T22:15:36  *** promag has quit IRC
4932018-05-04T22:15:43  *** lnostdal has joined #bitcoin-core-dev
4942018-05-04T22:21:58  *** lnostdal has quit IRC
4952018-05-04T22:33:21  *** lnostdal has joined #bitcoin-core-dev
4962018-05-04T22:34:12  *** Ignacio13Russel has quit IRC
4972018-05-04T22:38:27  *** lnostdal has quit IRC
4982018-05-04T22:39:16  *** spinza has quit IRC
4992018-05-04T22:39:56  *** glaksmono has joined #bitcoin-core-dev
5002018-05-04T22:44:46  *** glaksmono has quit IRC
5012018-05-04T22:44:53  *** Guyver2 has quit IRC
5022018-05-04T22:46:09  *** promag has joined #bitcoin-core-dev
5032018-05-04T22:47:10  *** spinza has joined #bitcoin-core-dev
5042018-05-04T22:48:27  *** Emcy has quit IRC
5052018-05-04T22:48:28  *** Victorsueca has quit IRC
5062018-05-04T22:49:40  *** Victorsueca has joined #bitcoin-core-dev
5072018-05-04T22:54:27  *** promag has quit IRC
5082018-05-04T22:57:03  *** Emcy has joined #bitcoin-core-dev
5092018-05-04T23:10:53  *** lnostdal has joined #bitcoin-core-dev
5102018-05-04T23:11:51  *** lnostdal has quit IRC
5112018-05-04T23:12:11  *** lnostdal has joined #bitcoin-core-dev
5122018-05-04T23:12:18  *** ossifrage has joined #bitcoin-core-dev
5132018-05-04T23:12:40  *** Gabo has joined #bitcoin-core-dev
5142018-05-04T23:12:50  <Gabo> Hi
5152018-05-04T23:18:35  *** Gabo has quit IRC
5162018-05-04T23:20:59  *** lnostdal has quit IRC
5172018-05-04T23:21:03  *** cryptojanitor has joined #bitcoin-core-dev
5182018-05-04T23:36:57  *** Giszmo has joined #bitcoin-core-dev
5192018-05-04T23:41:35  *** Chris_Stewart_5 has quit IRC
5202018-05-04T23:43:57  *** Dizzle has quit IRC
5212018-05-04T23:54:14  *** StopAndDecrypt has quit IRC