1 2018-05-07T00:23:10  *** cryptojanitor has joined #bitcoin-core-dev
  2 2018-05-07T00:27:08  *** Krellan has quit IRC
  3 2018-05-07T00:32:15  *** Krellan has joined #bitcoin-core-dev
  4 2018-05-07T00:57:12  *** Randolf has quit IRC
  5 2018-05-07T01:12:12  *** jb55 has quit IRC
  6 2018-05-07T01:17:13  *** t0adst00l has quit IRC
  7 2018-05-07T01:31:04  *** AaronvanW has quit IRC
  8 2018-05-07T01:57:20  *** satwo has joined #bitcoin-core-dev
  9 2018-05-07T02:04:02  *** d9b4bef9 has quit IRC
 10 2018-05-07T02:05:11  *** d9b4bef9 has joined #bitcoin-core-dev
 11 2018-05-07T02:29:14  *** arowser has quit IRC
 12 2018-05-07T02:29:31  *** arowser has joined #bitcoin-core-dev
 13 2018-05-07T02:30:33  *** isis_ is now known as isis
 14 2018-05-07T02:31:43  *** arowser has quit IRC
 15 2018-05-07T02:32:27  *** arowser has joined #bitcoin-core-dev
 16 2018-05-07T02:33:28  *** arowser has quit IRC
 17 2018-05-07T02:34:39  *** arowser has joined #bitcoin-core-dev
 18 2018-05-07T02:36:42  *** arowser has quit IRC
 19 2018-05-07T02:37:16  *** arowser has joined #bitcoin-core-dev
 20 2018-05-07T02:39:39  *** arowser has joined #bitcoin-core-dev
 21 2018-05-07T02:44:33  *** arowser has quit IRC
 22 2018-05-07T02:52:36  *** Krellan has quit IRC
 23 2018-05-07T02:59:39  *** grafcaps has joined #bitcoin-core-dev
 24 2018-05-07T03:00:29  *** Krellan has joined #bitcoin-core-dev
 25 2018-05-07T03:03:18  *** satwo has quit IRC
 26 2018-05-07T03:04:50  *** satwo has joined #bitcoin-core-dev
 27 2018-05-07T03:06:21  *** jojeyh has quit IRC
 28 2018-05-07T03:13:05  *** grafcaps has quit IRC
 29 2018-05-07T03:29:39  *** grafcaps has joined #bitcoin-core-dev
 30 2018-05-07T03:38:27  *** satwo has quit IRC
 31 2018-05-07T03:46:01  *** satwo has joined #bitcoin-core-dev
 32 2018-05-07T04:07:13  *** satwo has quit IRC
 33 2018-05-07T04:08:16  *** satwo has joined #bitcoin-core-dev
 34 2018-05-07T04:12:30  *** satwo has quit IRC
 35 2018-05-07T04:32:59  *** ryan-c has quit IRC
 36 2018-05-07T04:37:48  *** StopAndDecrypt has quit IRC
 37 2018-05-07T04:41:53  *** zautomata3 has quit IRC
 38 2018-05-07T04:42:38  *** cryptojanitor has quit IRC
 39 2018-05-07T04:43:14  *** zautomata3 has joined #bitcoin-core-dev
 40 2018-05-07T04:51:45  *** jpe has quit IRC
 41 2018-05-07T04:55:40  *** arowser has joined #bitcoin-core-dev
 42 2018-05-07T05:11:44  *** jpe has joined #bitcoin-core-dev
 43 2018-05-07T05:32:46  *** davec_ has quit IRC
 44 2018-05-07T05:38:57  *** Ana25Lindgren has quit IRC
 45 2018-05-07T05:45:34  *** arowser has quit IRC
 46 2018-05-07T05:49:11  *** davec has joined #bitcoin-core-dev
 47 2018-05-07T05:50:11  *** arowser has joined #bitcoin-core-dev
 48 2018-05-07T05:52:43  *** Randolf has joined #bitcoin-core-dev
 49 2018-05-07T06:06:01  *** d9b4bef9 has quit IRC
 50 2018-05-07T06:07:17  *** d9b4bef9 has joined #bitcoin-core-dev
 51 2018-05-07T06:18:18  *** Beatrice46Champl has joined #bitcoin-core-dev
 52 2018-05-07T06:20:05  *** arowser has quit IRC
 53 2018-05-07T06:21:02  *** arowser has joined #bitcoin-core-dev
 54 2018-05-07T06:26:18  *** AaronvanW has joined #bitcoin-core-dev
 55 2018-05-07T06:38:03  *** AaronvanW has quit IRC
 56 2018-05-07T06:38:38  *** AaronvanW has joined #bitcoin-core-dev
 57 2018-05-07T06:40:29  *** laurentmt has joined #bitcoin-core-dev
 58 2018-05-07T06:42:57  *** AaronvanW has quit IRC
 59 2018-05-07T06:47:18  *** AaronvanW has joined #bitcoin-core-dev
 60 2018-05-07T06:49:47  *** murchandamus has quit IRC
 61 2018-05-07T06:50:05  *** murchandamus has joined #bitcoin-core-dev
 62 2018-05-07T07:09:51  *** Randolf has quit IRC
 63 2018-05-07T07:14:46  *** meshcollider has joined #bitcoin-core-dev
 64 2018-05-07T07:30:27  *** zautomata3 has quit IRC
 65 2018-05-07T07:33:17  *** zautomata3 has joined #bitcoin-core-dev
 66 2018-05-07T07:36:57  *** arowser has quit IRC
 67 2018-05-07T07:37:13  *** arowser has joined #bitcoin-core-dev
 68 2018-05-07T07:41:28  *** ken2812221 has quit IRC
 69 2018-05-07T07:42:17  *** ken2812221 has joined #bitcoin-core-dev
 70 2018-05-07T07:50:11  *** Randolf has joined #bitcoin-core-dev
 71 2018-05-07T08:09:48  *** setpill has joined #bitcoin-core-dev
 72 2018-05-07T08:10:11  *** Krellan has quit IRC
 73 2018-05-07T08:12:57  *** Randolf has quit IRC
 74 2018-05-07T08:17:28  *** Victorsueca has quit IRC
 75 2018-05-07T08:18:38  *** Victorsueca has joined #bitcoin-core-dev
 76 2018-05-07T08:19:00  *** timothy has joined #bitcoin-core-dev
 77 2018-05-07T08:21:43  *** dafuq_ has joined #bitcoin-core-dev
 78 2018-05-07T08:22:57  *** murrayn has quit IRC
 79 2018-05-07T08:23:27  *** timothy has quit IRC
 80 2018-05-07T08:23:28  *** drizztbsd has joined #bitcoin-core-dev
 81 2018-05-07T08:23:35  *** drizztbsd is now known as timothy
 82 2018-05-07T08:23:54  *** mistergold has joined #bitcoin-core-dev
 83 2018-05-07T08:26:23  *** promag has joined #bitcoin-core-dev
 84 2018-05-07T08:39:37  *** harrymm has quit IRC
 85 2018-05-07T08:43:19  *** Krellan has joined #bitcoin-core-dev
 86 2018-05-07T08:48:47  *** Krellan has quit IRC
 87 2018-05-07T08:48:57  *** Randolf has joined #bitcoin-core-dev
 88 2018-05-07T08:51:53  *** harrymm has joined #bitcoin-core-dev
 89 2018-05-07T09:01:05  *** Beatrice46Champl has quit IRC
 90 2018-05-07T09:10:38  <provoostenator> TL&DR: 3:00 hours on t2.2xlarge, c5.2xlarge, 3:50 hours on m5.2xlarge. I ran out of ideas to make it run faster, see logs in #blockchain-sync.
 91 2018-05-07T09:22:28  *** dafuq_ has quit IRC
 92 2018-05-07T09:22:48  *** murrayn has joined #bitcoin-core-dev
 93 2018-05-07T09:40:35  *** Krellan has joined #bitcoin-core-dev
 94 2018-05-07T09:43:02  *** Krellan has quit IRC
 95 2018-05-07T09:43:09  *** Krellan has joined #bitcoin-core-dev
 96 2018-05-07T09:53:55  *** jtimon has joined #bitcoin-core-dev
 97 2018-05-07T09:55:06  *** Brant73Grady has joined #bitcoin-core-dev
 98 2018-05-07T10:00:14  *** jtimon has quit IRC
 99 2018-05-07T10:08:01  *** d9b4bef9 has quit IRC
100 2018-05-07T10:09:04  *** jtimon has joined #bitcoin-core-dev
101 2018-05-07T10:09:12  *** d9b4bef9 has joined #bitcoin-core-dev
102 2018-05-07T10:11:33  *** AaronvanW has quit IRC
103 2018-05-07T10:22:12  *** AaronvanW has joined #bitcoin-core-dev
104 2018-05-07T10:27:04  *** AaronvanW has quit IRC
105 2018-05-07T10:28:46  <bitcoin-git> [bitcoin] glaksmono opened pull request #13183: [WIP][bitcoin-11004] New Travis job for CHECK_DOCS steps (master...bitcoin-11004) https://github.com/bitcoin/bitcoin/pull/13183
106 2018-05-07T10:42:26  *** dafuq[m] has quit IRC
107 2018-05-07T10:44:33  *** drexl has joined #bitcoin-core-dev
108 2018-05-07T10:49:51  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66cc47be982a...a174702bad1c
109 2018-05-07T10:49:51  <bitcoin-git> bitcoin/master fad63eb John Newbery: [logging] Don't incorrectly log that REJECT messages are unknown....
110 2018-05-07T10:49:52  <bitcoin-git> bitcoin/master a174702 Wladimir J. van der Laan: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown....
111 2018-05-07T10:50:41  <bitcoin-git> [bitcoin] laanwj closed pull request #13162: [net] Don't incorrectly log that REJECT messages are unknown. (master...fix_reject_logging) https://github.com/bitcoin/bitcoin/pull/13162
112 2018-05-07T10:55:17  <jtimon> sorry, I forgot to fix BlueMatt's latest nits on https://github.com/bitcoin/bitcoin/pull/10757 fixed now
113 2018-05-07T10:56:38  <jtimon> btw, I'm confused about what "matt was here" means in this context. I thought it was mostly for refactors and meant something like "I don't see the value of this refactor but it doesn't break things and I don't care, so I won't nack", but this is adding new functionality
114 2018-05-07T10:57:06  *** Victorsueca has quit IRC
115 2018-05-07T10:57:17  <jtimon> can someone clarify what's that supposed to mean, perhaps we can put that on the documentation like we have ACK, utACK, etc ?
116 2018-05-07T10:57:44  <luke-jr> jtimon: the impression I got (but I never asked him) was that it was a kind of "I looked at this, but I didn't review it sufficiently to ACK"
117 2018-05-07T10:58:18  *** Victorsueca has joined #bitcoin-core-dev
118 2018-05-07T11:00:12  <jtimon> luke-jr: I was under the impression he had reviewed it enough, but perhaps that's it
119 2018-05-07T11:01:39  <luke-jr> well, sounds like BlueMatt should clarify ;)
120 2018-05-07T11:02:49  *** Emcy has quit IRC
121 2018-05-07T11:12:35  *** jtimon has quit IRC
122 2018-05-07T11:16:17  *** AaronvanW has joined #bitcoin-core-dev
123 2018-05-07T11:17:39  *** mistergold has quit IRC
124 2018-05-07T11:21:54  *** AaronvanW has quit IRC
125 2018-05-07T11:25:57  *** zautomata3 has quit IRC
126 2018-05-07T11:28:18  *** zautomata has joined #bitcoin-core-dev
127 2018-05-07T11:28:58  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a174702bad1c...6a01a50f4906
128 2018-05-07T11:28:58  <bitcoin-git> bitcoin/master 43f3dec donaloconnor: Remove enum specifier (to avoid re-declare scoped enum as unscoped)
129 2018-05-07T11:28:59  <bitcoin-git> bitcoin/master 6a01a50 Jonas Schnelli: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers)...
130 2018-05-07T11:29:40  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers) (master...06052018_unscoped_enum) https://github.com/bitcoin/bitcoin/pull/13180
131 2018-05-07T11:33:10  *** Krellan has quit IRC
132 2018-05-07T11:33:29  *** murrayn has quit IRC
133 2018-05-07T11:33:44  *** Krellan has joined #bitcoin-core-dev
134 2018-05-07T11:33:51  *** murrayn has joined #bitcoin-core-dev
135 2018-05-07T11:33:51  *** murrayn has joined #bitcoin-core-dev
136 2018-05-07T11:39:58  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a01a50f4906...bd83704ec6fa
137 2018-05-07T11:39:59  <bitcoin-git> bitcoin/master 29c9bdc practicalswift: Handle unsuccessful fseek(...):s
138 2018-05-07T11:40:00  <bitcoin-git> bitcoin/master 20ce5af practicalswift: Print a log message if we fail to shrink the debug log file
139 2018-05-07T11:40:00  <bitcoin-git> bitcoin/master bd83704 Wladimir J. van der Laan: Merge #13149: Handle unsuccessful fseek(...):s...
140 2018-05-07T11:40:50  <bitcoin-git> [bitcoin] laanwj closed pull request #13149: Handle unsuccessful fseek(...):s (master...fseek) https://github.com/bitcoin/bitcoin/pull/13149
141 2018-05-07T11:50:06  *** SopaXorzTaker has joined #bitcoin-core-dev
142 2018-05-07T12:07:41  *** infernix has quit IRC
143 2018-05-07T12:12:20  *** promag has quit IRC
144 2018-05-07T12:16:47  *** Cory has quit IRC
145 2018-05-07T12:18:25  *** Emcy has joined #bitcoin-core-dev
146 2018-05-07T12:22:36  *** jtimon has joined #bitcoin-core-dev
147 2018-05-07T12:23:14  *** Cory has joined #bitcoin-core-dev
148 2018-05-07T12:33:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd83704ec6fa...57aae632e288
149 2018-05-07T12:33:42  <bitcoin-git> bitcoin/master ddebde7 Chun Kuan Lee: Add Windows shutdown handler
150 2018-05-07T12:33:42  <bitcoin-git> bitcoin/master 57aae63 Wladimir J. van der Laan: Merge #13131: Add Windows shutdown handler...
151 2018-05-07T12:34:31  <bitcoin-git> [bitcoin] laanwj closed pull request #13131: Add Windows shutdown handler (master...win-quit) https://github.com/bitcoin/bitcoin/pull/13131
152 2018-05-07T12:52:05  *** tryphe_ has joined #bitcoin-core-dev
153 2018-05-07T12:53:42  *** promag has joined #bitcoin-core-dev
154 2018-05-07T12:54:14  *** tryphe_ has quit IRC
155 2018-05-07T12:54:34  *** tryphe_ has joined #bitcoin-core-dev
156 2018-05-07T12:55:05  *** tryphe has quit IRC
157 2018-05-07T12:55:14  *** Anduck has quit IRC
158 2018-05-07T12:56:18  *** vicenteH has joined #bitcoin-core-dev
159 2018-05-07T12:56:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
160 2018-05-07T13:01:06  *** dafuq_ has joined #bitcoin-core-dev
161 2018-05-07T13:04:00  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57aae632e288...5778d44aa857
162 2018-05-07T13:04:00  <bitcoin-git> bitcoin/master 16be133 Ben Woosley: Fix rescanblockchain rpc to property report progress...
163 2018-05-07T13:04:01  *** BCBot_ has joined #bitcoin-core-dev
164 2018-05-07T13:04:01  <bitcoin-git> bitcoin/master 5778d44 Jonas Schnelli: Merge #13079: Fix rescanblockchain rpc to properly report progress...
165 2018-05-07T13:04:35  *** AaronvanW has joined #bitcoin-core-dev
166 2018-05-07T13:04:40  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13079: Fix rescanblockchain rpc to properly report progress (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079
167 2018-05-07T13:05:28  *** roasbeef_ has joined #bitcoin-core-dev
168 2018-05-07T13:05:55  *** karl has joined #bitcoin-core-dev
169 2018-05-07T13:06:21  *** Sentineo_ has joined #bitcoin-core-dev
170 2018-05-07T13:06:31  *** dongcarl_ has joined #bitcoin-core-dev
171 2018-05-07T13:08:53  *** chainhead_ has joined #bitcoin-core-dev
172 2018-05-07T13:08:57  *** AaronvanW has quit IRC
173 2018-05-07T13:09:01  *** instagibbs_ has joined #bitcoin-core-dev
174 2018-05-07T13:09:04  *** gaf__ has joined #bitcoin-core-dev
175 2018-05-07T13:09:39  *** lysobit_ has joined #bitcoin-core-dev
176 2018-05-07T13:10:26  *** wraithm_ has joined #bitcoin-core-dev
177 2018-05-07T13:11:08  *** murrayn has quit IRC
178 2018-05-07T13:11:08  *** Brant73Grady has quit IRC
179 2018-05-07T13:11:08  *** harrymm has quit IRC
180 2018-05-07T13:11:08  *** instagibbs has quit IRC
181 2018-05-07T13:11:08  *** gaf_ has quit IRC
182 2018-05-07T13:11:08  *** chainhead has quit IRC
183 2018-05-07T13:11:08  *** dongcarl has quit IRC
184 2018-05-07T13:11:08  *** [b__b] has quit IRC
185 2018-05-07T13:11:08  *** Sentineo has quit IRC
186 2018-05-07T13:11:08  *** kallewoof has quit IRC
187 2018-05-07T13:11:08  *** BCBot has quit IRC
188 2018-05-07T13:11:08  *** musalbas has quit IRC
189 2018-05-07T13:11:09  *** wraithm has quit IRC
190 2018-05-07T13:11:09  *** roasbeef has quit IRC
191 2018-05-07T13:11:09  *** lysobit_ is now known as musalbas
192 2018-05-07T13:11:48  *** [b__b] has joined #bitcoin-core-dev
193 2018-05-07T13:13:28  *** Randolf has quit IRC
194 2018-05-07T13:13:37  *** infernix has joined #bitcoin-core-dev
195 2018-05-07T13:15:17  *** Randolf has joined #bitcoin-core-dev
196 2018-05-07T13:15:23  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5778d44aa857...bf9b03ddcc65
197 2018-05-07T13:15:23  <bitcoin-git> bitcoin/master ab3f4dd Chun Kuan Lee: tests: Add test for 64-bit PE, modify 32-bit test results...
198 2018-05-07T13:15:24  <bitcoin-git> bitcoin/master bf9b03d Wladimir J. van der Laan: Merge #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results...
199 2018-05-07T13:15:36  *** cphrmky has quit IRC
200 2018-05-07T13:16:03  <bitcoin-git> [bitcoin] laanwj closed pull request #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13094
201 2018-05-07T13:17:32  *** harrymm has joined #bitcoin-core-dev
202 2018-05-07T13:21:45  *** Guyver2 has joined #bitcoin-core-dev
203 2018-05-07T13:23:28  <wumpus> #10267 gives me an unicorn
204 2018-05-07T13:23:32  <gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
205 2018-05-07T13:24:14  *** Anduck has joined #bitcoin-core-dev
206 2018-05-07T13:29:36  <wumpus> I'll complain to github
207 2018-05-07T13:29:39  *** nullptr| has quit IRC
208 2018-05-07T13:34:11  *** jouke has quit IRC
209 2018-05-07T13:34:51  *** jouke has joined #bitcoin-core-dev
210 2018-05-07T13:35:00  *** nullptr| has joined #bitcoin-core-dev
211 2018-05-07T13:35:54  <aj> wumpus: tried clearing your cookies?
212 2018-05-07T13:36:24  <wumpus> yeah I can try that again...
213 2018-05-07T13:37:53  <jonasschnelli> Also getting a unicorn
214 2018-05-07T13:37:55  <wumpus> though I have a hard time believing my browser's handling of cookies is at fault here
215 2018-05-07T13:38:51  <wumpus> contacted github anyhow
216 2018-05-07T13:38:58  *** Oldnewbie has joined #bitcoin-core-dev
217 2018-05-07T13:39:23  *** jouke has quit IRC
218 2018-05-07T13:42:38  *** zivl has joined #bitcoin-core-dev
219 2018-05-07T13:43:10  <Oldnewbie> Quit
220 2018-05-07T13:43:24  *** Oldnewbie has quit IRC
221 2018-05-07T13:45:56  <promag> unicorn too
222 2018-05-07T13:45:57  *** m8tion has joined #bitcoin-core-dev
223 2018-05-07T13:46:13  *** promag has quit IRC
224 2018-05-07T13:46:58  <wumpus> jonasschnelli: btw - what is the process for importing a new libbtc into bitcoincore-indexd? I need MSG_WITNESS_BLOCK
225 2018-05-07T13:47:03  <wumpus> is it a subtree?
226 2018-05-07T13:47:03  *** Krellan has quit IRC
227 2018-05-07T13:47:24  <jonasschnelli> wumpus: I think I have added it as subtree
228 2018-05-07T13:47:45  <jonasschnelli> wumpus: BTW: I'm currently running a script that runs 10 times block fetching from 490000 till 500000 and measures times
229 2018-05-07T13:47:57  <jonasschnelli> Currently running on master... will compare than against your PR and report.
230 2018-05-07T13:48:07  *** jouke has joined #bitcoin-core-dev
231 2018-05-07T13:48:09  <jonasschnelli> Since this is on SSD, may result may be even more promissing then yours
232 2018-05-07T13:48:39  <wumpus> I hope so :)
233 2018-05-07T13:48:55  <wumpus> though 10% gain is already somewhat neat
234 2018-05-07T13:49:00  *** Krellan has joined #bitcoin-core-dev
235 2018-05-07T13:49:23  <jonasschnelli> wumpus: Yes! 10% is already great!
236 2018-05-07T13:50:52  <BlueMatt> jtimon: in this case it means what you thought - "I dont care about this feature, so I'm not gonna ack it, but it seems like some folks want it, so certainly wont oppose. Aside from the comments left, I see no other bugs, and so am fine with it advancing, but do not wish to in any way imply a concept ack"
237 2018-05-07T13:50:52  *** rafalcpp has joined #bitcoin-core-dev
238 2018-05-07T13:54:49  *** BCBot_ has quit IRC
239 2018-05-07T13:55:04  *** Kaylin69Doyle has joined #bitcoin-core-dev
240 2018-05-07T13:55:05  *** BCBot has joined #bitcoin-core-dev
241 2018-05-07T13:55:17  *** satwo has joined #bitcoin-core-dev
242 2018-05-07T13:55:57  <BlueMatt> luke-jr: plz2rebase #12208? Trying to whip 0.16.1 :p
243 2018-05-07T13:55:59  <gribble> https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
244 2018-05-07T13:57:52  *** arowser has quit IRC
245 2018-05-07T13:58:25  *** arowser has joined #bitcoin-core-dev
246 2018-05-07T14:00:17  <jtimon> BlueMatt: thanks for claryfing
247 2018-05-07T14:02:30  *** arowser has quit IRC
248 2018-05-07T14:02:50  *** arowser has joined #bitcoin-core-dev
249 2018-05-07T14:03:54  *** arowser has quit IRC
250 2018-05-07T14:04:13  *** arowser has joined #bitcoin-core-dev
251 2018-05-07T14:07:07  *** arowser has quit IRC
252 2018-05-07T14:07:24  *** arowser has joined #bitcoin-core-dev
253 2018-05-07T14:09:03  *** arowser has quit IRC
254 2018-05-07T14:09:40  *** arowser has joined #bitcoin-core-dev
255 2018-05-07T14:11:35  *** arowser has quit IRC
256 2018-05-07T14:11:45  *** glaksmono has joined #bitcoin-core-dev
257 2018-05-07T14:11:46  *** tryphe_ has quit IRC
258 2018-05-07T14:11:46  <bitcoin-git> [bitcoin] harding opened pull request #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts (master...2018-05-rpc-help-bestblock) https://github.com/bitcoin/bitcoin/pull/13184
259 2018-05-07T14:11:52  *** arowser has joined #bitcoin-core-dev
260 2018-05-07T14:12:01  <jonasschnelli> How do I only allow connection from 127.0.0.1?
261 2018-05-07T14:12:11  <glaksmono> hi guys, i'm trying to find a reviewer for this: https://github.com/bitcoin/bitcoin/pull/13183
262 2018-05-07T14:12:12  <glaksmono> can someone help?
263 2018-05-07T14:12:13  <jonasschnelli> Seems like whitelist=127.0.0.1 and connect=0 won't work
264 2018-05-07T14:12:27  <jonasschnelli> glaksmono: have some patience
265 2018-05-07T14:12:38  <glaksmono> alright @jonasschnelli
266 2018-05-07T14:12:43  <glaksmono> i'm a newbie contributor :)
267 2018-05-07T14:12:57  <jonasschnelli> glaksmono: also, maybe write some pull request description (not only refere to the issue)
268 2018-05-07T14:13:51  <jonasschnelli> NM: whitebind=127.0.0.1:8333 fixed my issue
269 2018-05-07T14:13:53  *** grafcaps has quit IRC
270 2018-05-07T14:14:06  *** tryphe has joined #bitcoin-core-dev
271 2018-05-07T14:19:59  *** arowser has quit IRC
272 2018-05-07T14:20:40  *** arowser has joined #bitcoin-core-dev
273 2018-05-07T14:20:46  *** promag has joined #bitcoin-core-dev
274 2018-05-07T14:25:06  *** rex4539 has joined #bitcoin-core-dev
275 2018-05-07T14:26:49  *** tryphe has quit IRC
276 2018-05-07T14:28:03  *** StopAndDecrypt has joined #bitcoin-core-dev
277 2018-05-07T14:28:52  <wumpus> jonasschnelli: subtree merge from libbtc/libbtc gives me tons of conflicts
278 2018-05-07T14:29:04  *** Dizzle has joined #bitcoin-core-dev
279 2018-05-07T14:29:31  *** tryphe has joined #bitcoin-core-dev
280 2018-05-07T14:29:53  <jonasschnelli> wumpus: try rm -rf src/libbtc and then a fresh git subtree add?
281 2018-05-07T14:30:15  <jonasschnelli> I'm pretty sure I haven't done local changes
282 2018-05-07T14:30:18  <wumpus> or I'll resolve the conflicts to 'theirs'
283 2018-05-07T14:30:26  <jonasschnelli> yeah
284 2018-05-07T14:30:34  <wumpus> let's see if it still builds at all
285 2018-05-07T14:31:31  *** SopaXorzTaker has quit IRC
286 2018-05-07T14:32:07  <jonasschnelli> I don't know why I had to manually add a LDADD+=-lpthread in the bitcoincore-indexd project... seems that lpthread will not auto-added via Makefile.leveldb.am
287 2018-05-07T14:32:20  *** grafcaps has joined #bitcoin-core-dev
288 2018-05-07T14:40:28  <jonasschnelli> hmm... master is quicker then PR 13151?! let me double check...
289 2018-05-07T14:40:44  <wumpus> jonasschnelli: eh whoops libbbtc serialize.h has two LIBBTC_END_DECL
290 2018-05-07T14:41:06  <jonasschnelli> wumpus: hmm.. that was a recent change by promag...
291 2018-05-07T14:41:14  <jonasschnelli> should this not have been detected by travis..
292 2018-05-07T14:45:29  <wumpus> jonasschnelli: if that header is used in one of the tests, which I assume, yes :)
293 2018-05-07T14:48:07  <wumpus> jonasschnelli: I think I know why travis passed with it: in C, the macros are defined as nothing
294 2018-05-07T14:48:23  <wumpus> this problem is only apparent when the lib is used from C++
295 2018-05-07T14:49:44  <jonasschnelli> ah.. right!
296 2018-05-07T14:50:38  <jonasschnelli> wumpus: any reason why your PR 13151 preforms ~6% slower then master?
297 2018-05-07T14:51:24  <jonasschnelli> I just reverted back to 598db389c33e5e90783ef1223df2eeab095ed622 from 13151 head to make sure im comparing the right things
298 2018-05-07T14:51:25  <wumpus> jonasschnelli: you do request MSG_WITNESS_BLOCK at all?
299 2018-05-07T14:51:49  <jonasschnelli> let me dbl check
300 2018-05-07T14:52:24  <wumpus> if so, I'm confused, I don't see how this can be *slower*
301 2018-05-07T14:52:39  <wumpus> maybe add back the LogPrintf to make sure it's hitting the new fast path at all
302 2018-05-07T14:52:47  *** AaronvanW has joined #bitcoin-core-dev
303 2018-05-07T14:52:54  <jonasschnelli> wumpus: ser_u32(inv_msg_cstr, 2 | (1 << 30));
304 2018-05-07T14:52:56  <jonasschnelli> seems correct
305 2018-05-07T14:53:00  <wumpus> yes
306 2018-05-07T14:53:37  *** tryphe has quit IRC
307 2018-05-07T14:54:01  *** tryphe has joined #bitcoin-core-dev
308 2018-05-07T14:56:57  *** AaronvanW has quit IRC
309 2018-05-07T14:57:11  *** tryphe_ has joined #bitcoin-core-dev
310 2018-05-07T14:57:24  <jonasschnelli> wumpus: you mean that one: https://github.com/bitcoin/bitcoin/pull/13151/commits/4c790dff7481d1464a906ad6b17a3179a7da3431#diff-eff7adeaec73a769788bb78858815c91R1149?
311 2018-05-07T15:00:15  *** grafcaps has quit IRC
312 2018-05-07T15:00:21  *** tryphe has quit IRC
313 2018-05-07T15:00:48  <wumpus> yes the ""debug: Serving raw block directly from disk"
314 2018-05-07T15:01:07  <wumpus> although remove it when performance benchmarking, as all the log messages will again make it slower...
315 2018-05-07T15:01:43  <jonasschnelli> Yes. Sure
316 2018-05-07T15:02:05  <jonasschnelli> jup.. its firing...
317 2018-05-07T15:02:12  *** tryphe_000 has joined #bitcoin-core-dev
318 2018-05-07T15:02:46  <jonasschnelli> I do now disable the logprintf and test again...
319 2018-05-07T15:04:39  *** arowser has quit IRC
320 2018-05-07T15:05:19  *** tryphe has joined #bitcoin-core-dev
321 2018-05-07T15:05:43  *** tryphe_ has quit IRC
322 2018-05-07T15:06:36  *** AaronvanW has joined #bitcoin-core-dev
323 2018-05-07T15:07:39  *** tryphe_000 has quit IRC
324 2018-05-07T15:08:40  *** arowser has joined #bitcoin-core-dev
325 2018-05-07T15:10:42  *** arowser has quit IRC
326 2018-05-07T15:13:20  *** arowser has joined #bitcoin-core-dev
327 2018-05-07T15:14:25  *** arowser has quit IRC
328 2018-05-07T15:14:41  *** arowser has joined #bitcoin-core-dev
329 2018-05-07T15:16:42  *** arowser has quit IRC
330 2018-05-07T15:16:51  *** jb55 has joined #bitcoin-core-dev
331 2018-05-07T15:18:58  *** promag has quit IRC
332 2018-05-07T15:19:14  *** promag has joined #bitcoin-core-dev
333 2018-05-07T15:19:29  *** spudowiar has joined #bitcoin-core-dev
334 2018-05-07T15:19:40  *** spudowiar has quit IRC
335 2018-05-07T15:22:04  *** spudowiar has joined #bitcoin-core-dev
336 2018-05-07T15:29:25  *** arowser has joined #bitcoin-core-dev
337 2018-05-07T15:30:38  *** arowser has quit IRC
338 2018-05-07T15:31:57  *** arowser has joined #bitcoin-core-dev
339 2018-05-07T15:33:22  <promag> wumpus: regarding block.resize(blk_size);
340 2018-05-07T15:34:20  <promag> filein.read((char*)block.data(), blk_size) will overwrite those zeros.. so I really don't get it
341 2018-05-07T15:34:43  <wumpus> what if it somehow fails
342 2018-05-07T15:35:13  <wumpus> my point is defense in depth here
343 2018-05-07T15:35:17  *** ula has quit IRC
344 2018-05-07T15:35:37  *** glaksmono has quit IRC
345 2018-05-07T15:35:41  <promag> you mean read fails?
346 2018-05-07T15:35:50  <wumpus> yes
347 2018-05-07T15:36:12  *** glaksmono has joined #bitcoin-core-dev
348 2018-05-07T15:36:32  <promag> then it shouldn't serve, it should fail?
349 2018-05-07T15:36:40  <wumpus> it should, but a bug might prevent that
350 2018-05-07T15:36:48  <wumpus> either a kernel bug or something else
351 2018-05-07T15:38:17  *** arowser has quit IRC
352 2018-05-07T15:38:39  <promag> ok, I wounder if it has performance impact regarding jonas bench
353 2018-05-07T15:38:42  *** arowser has joined #bitcoin-core-dev
354 2018-05-07T15:38:52  <wumpus> only if you can measure a significant improvement of not zeroing I'm willing to argue about this further
355 2018-05-07T15:39:12  <wumpus> otherwise it seems pointless shed painting...
356 2018-05-07T15:39:30  <jamesob> hm. If I'm gonna implement a threadsafe ring buffer for use with the async logging stuff, better to do that as a general module (a util sort of thing) or within a logging-specific module?
357 2018-05-07T15:40:44  *** arowser has quit IRC
358 2018-05-07T15:40:48  <wumpus> jamesob: depends on how much work it is to make it general instead of specific, and how much extra code that brings. If not much, making it general is preferable of course.
359 2018-05-07T15:40:52  *** glaksmono has quit IRC
360 2018-05-07T15:41:10  <jamesob> wumpus: good advice, thanks
361 2018-05-07T15:43:14  *** arowser has joined #bitcoin-core-dev
362 2018-05-07T15:43:22  <sipa> wumpus, promag: is there even a way to resize a vector _without_ initializing the chars to 0?
363 2018-05-07T15:43:33  <wumpus> jonasschnelli: seems you merged https://github.com/jonasschnelli/bitcoincore-indexd/pull/1, I think we had to update it to include https://github.com/libbtc/libbtc/pull/127
364 2018-05-07T15:43:37  <wumpus> sipa: no :/
365 2018-05-07T15:44:37  *** arowser has quit IRC
366 2018-05-07T15:45:29  <wumpus> so indeed, I don't know what the c++11 "nice" way to do that is, could use a unique_ptr to a new [] array instead of a vector, or something else, but nothing seems really elegant
367 2018-05-07T15:45:35  <sipa> std::array :)
368 2018-05-07T15:45:37  *** arowser has joined #bitcoin-core-dev
369 2018-05-07T15:45:46  <sipa> which does not seem to require initializing the elements
370 2018-05-07T15:45:48  <wumpus> does that work for variable lengths?
371 2018-05-07T15:45:51  <sipa> no
372 2018-05-07T15:48:38  <spudowiar> How is someone actually supposed to say they know C++ when you might blink and we'll suddenly be on C++18428 and it'll look like some dialect of Python
373 2018-05-07T15:51:31  <spudowiar> https://github.com/facebook/folly/blob/master/folly/memory/UninitializedMemoryHacks.h
374 2018-05-07T15:52:15  <spudowiar> That looks perfectly safe and not at all a terrible hack
375 2018-05-07T15:57:09  <cfields> sipa: I believe a std::vector with a custom allocator can
376 2018-05-07T16:01:54  *** setpill has quit IRC
377 2018-05-07T16:05:34  *** arowser has quit IRC
378 2018-05-07T16:05:39  <wumpus> spudowiar: yeah... language evolution is not a bad thing, and c++11 brings a lot of useful things, but c++ is alread such a crazy complex language, it's increasingly impossible to say you really know it.
379 2018-05-07T16:06:59  *** arowser has joined #bitcoin-core-dev
380 2018-05-07T16:09:26  *** arowser has quit IRC
381 2018-05-07T16:09:47  <sipa> spudowiar: "folly" i would say
382 2018-05-07T16:09:57  *** arowser has joined #bitcoin-core-dev
383 2018-05-07T16:10:11  *** Krellan has quit IRC
384 2018-05-07T16:10:52  <wumpus> yes it scares me, let's just zero the vector ok
385 2018-05-07T16:12:53  *** arowser has quit IRC
386 2018-05-07T16:13:11  *** arowser has joined #bitcoin-core-dev
387 2018-05-07T16:14:18  *** Krellan has joined #bitcoin-core-dev
388 2018-05-07T16:17:13  *** arowser has quit IRC
389 2018-05-07T16:17:33  *** arowser has joined #bitcoin-core-dev
390 2018-05-07T16:17:38  <sipa> wumpus: ack
391 2018-05-07T16:18:47  <jonasschnelli> wumpus: meh. yes. Let me push a subtree update then.
392 2018-05-07T16:20:35  *** arowser has quit IRC
393 2018-05-07T16:20:53  *** arowser has joined #bitcoin-core-dev
394 2018-05-07T16:20:57  <promag> jonasschnelli: wumpus: should libbtc have a c++ job in travis?
395 2018-05-07T16:22:52  *** arowser has quit IRC
396 2018-05-07T16:23:10  *** arowser has joined #bitcoin-core-dev
397 2018-05-07T16:24:12  <jonasschnelli> promag: yes. a little c++ test would be great.
398 2018-05-07T16:27:07  *** arowser has quit IRC
399 2018-05-07T16:27:30  *** arowser has joined #bitcoin-core-dev
400 2018-05-07T16:29:25  *** arowser has quit IRC
401 2018-05-07T16:29:35  *** spudowiar is now known as x123456789
402 2018-05-07T16:29:42  *** arowser has joined #bitcoin-core-dev
403 2018-05-07T16:30:06  *** x123456789 is now known as spudowiar
404 2018-05-07T16:31:08  *** meshcollider has quit IRC
405 2018-05-07T16:33:12  <wumpus> promag: I think for most intents and purposes it doesn't matter, for a C library, except the specific thing (`extern "C" {` in headers) you were changing
406 2018-05-07T16:34:12  *** arowser has quit IRC
407 2018-05-07T16:35:46  *** arowser has joined #bitcoin-core-dev
408 2018-05-07T16:36:53  *** arowser has quit IRC
409 2018-05-07T16:37:23  *** arowser has joined #bitcoin-core-dev
410 2018-05-07T16:39:17  *** arowser has quit IRC
411 2018-05-07T16:39:35  *** arowser has joined #bitcoin-core-dev
412 2018-05-07T16:40:36  *** arowser has quit IRC
413 2018-05-07T16:40:54  *** arowser has joined #bitcoin-core-dev
414 2018-05-07T16:42:58  *** arowser has quit IRC
415 2018-05-07T16:43:38  *** Krellan has quit IRC
416 2018-05-07T16:44:14  *** arowser has joined #bitcoin-core-dev
417 2018-05-07T16:44:22  *** Krellan has joined #bitcoin-core-dev
418 2018-05-07T16:44:23  *** isis is now known as isis_
419 2018-05-07T16:47:42  <promag> BlueMatt: I can rebase #13063 on master and leave walletmanager out for now
420 2018-05-07T16:47:45  <gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
421 2018-05-07T16:48:38  <BlueMatt> I mean I presume given the annoyance of moving forward with the loadwallet stuff we should do a minimal fix to get that through, and then we can clean it up as all that stuff matures
422 2018-05-07T16:48:58  *** m8tion has quit IRC
423 2018-05-07T16:50:00  <promag> so you suggest to reopen #12647?
424 2018-05-07T16:50:04  <gribble> https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub
425 2018-05-07T16:50:10  <promag> BlueMatt: annoyance? :)
426 2018-05-07T16:50:28  *** jtimon has quit IRC
427 2018-05-07T16:52:32  *** arowser has quit IRC
428 2018-05-07T16:52:48  *** arowser has joined #bitcoin-core-dev
429 2018-05-07T16:53:21  *** Krellan has quit IRC
430 2018-05-07T16:54:21  *** arowser has quit IRC
431 2018-05-07T16:54:54  *** Krellan has joined #bitcoin-core-dev
432 2018-05-07T16:56:02  *** tryphe has quit IRC
433 2018-05-07T16:58:17  *** arowser has joined #bitcoin-core-dev
434 2018-05-07T17:05:58  *** tryphe has joined #bitcoin-core-dev
435 2018-05-07T17:11:45  *** tryphe has quit IRC
436 2018-05-07T17:13:47  *** tryphe has joined #bitcoin-core-dev
437 2018-05-07T17:14:28  *** tryphe has quit IRC
438 2018-05-07T17:18:01  *** glaksmono has joined #bitcoin-core-dev
439 2018-05-07T17:18:24  *** CubicEarths has joined #bitcoin-core-dev
440 2018-05-07T17:18:45  *** Krellan has quit IRC
441 2018-05-07T17:19:25  *** Krellan has joined #bitcoin-core-dev
442 2018-05-07T17:20:36  *** spudowiar has quit IRC
443 2018-05-07T17:21:51  *** Emcy has quit IRC
444 2018-05-07T17:22:34  *** glaksmono has quit IRC
445 2018-05-07T17:27:46  *** timothy has quit IRC
446 2018-05-07T17:30:05  *** zivl has quit IRC
447 2018-05-07T17:31:03  *** mol has quit IRC
448 2018-05-07T17:31:15  *** lnostdal has joined #bitcoin-core-dev
449 2018-05-07T17:32:15  *** AaronvanW has quit IRC
450 2018-05-07T17:33:51  *** Krellan has quit IRC
451 2018-05-07T17:35:13  *** glaksmono has joined #bitcoin-core-dev
452 2018-05-07T17:38:12  *** molz has joined #bitcoin-core-dev
453 2018-05-07T17:39:35  *** glaksmono has quit IRC
454 2018-05-07T17:41:21  *** vicenteH has quit IRC
455 2018-05-07T17:56:37  *** zivl has joined #bitcoin-core-dev
456 2018-05-07T18:01:37  *** Randolf has quit IRC
457 2018-05-07T18:16:59  *** roasbeef_ is now known as roasbeef
458 2018-05-07T18:22:37  <bitcoin-git> [bitcoin] sipa opened pull request #13185: Bugfix: the end of a reorged chain is invalid when connect fails (master...201805_bugfix_invalidchain_end) https://github.com/bitcoin/bitcoin/pull/13185
459 2018-05-07T18:35:19  *** pierre_rochard has joined #bitcoin-core-dev
460 2018-05-07T18:37:56  *** bsm1175321 has joined #bitcoin-core-dev
461 2018-05-07T18:38:19  *** moneyball has joined #bitcoin-core-dev
462 2018-05-07T18:49:58  *** Randolf has joined #bitcoin-core-dev
463 2018-05-07T18:50:06  <bitcoin-git> [bitcoin] skeees opened pull request #13186: Use a semaphore to trigger shutdown procedures (master...shutdown-cv) https://github.com/bitcoin/bitcoin/pull/13186
464 2018-05-07T18:53:41  *** glaksmono has joined #bitcoin-core-dev
465 2018-05-07T18:55:02  *** DrDraake has joined #bitcoin-core-dev
466 2018-05-07T18:55:38  <DrDraake> hey guys
467 2018-05-07T18:58:12  *** glaksmono has quit IRC
468 2018-05-07T19:01:04  <DrDraake> Don't know if this is the right channel.  If someone has a offline bitcoin core wallet showing a balance and you can do not see the corresponding wallet on chain.  If they send you a core to core transaction offline and you bring your core wallet online can that transaction confirm and previously they have sent the same amount of BTC to someone else who gets the BTC?  Will it show in my wallet and when I go to spend it wil
469 2018-05-07T19:02:05  *** lnostdal has quit IRC
470 2018-05-07T19:02:10  <BlueMatt> DrDraake: you probably want #bitcoin, but, if a transaction is not mine-able and your node is synced, it will be displayed as "conflicted"
471 2018-05-07T19:02:25  <BlueMatt> (probably)
472 2018-05-07T19:03:03  <DrDraake> I'm trying to figure out how can this wallet send me BTC if I can not verify they have the coin to begin with....
473 2018-05-07T19:03:26  <BlueMatt> you probably want #bitcoin, way more people there to help you out if you clarify what you want to do
474 2018-05-07T19:03:37  <DrDraake> Thanks
475 2018-05-07T19:03:45  *** glaksmono has joined #bitcoin-core-dev
476 2018-05-07T19:05:15  *** arowser has quit IRC
477 2018-05-07T19:05:32  *** arowser has joined #bitcoin-core-dev
478 2018-05-07T19:07:57  *** glaksmono has quit IRC
479 2018-05-07T19:09:37  *** arowser has quit IRC
480 2018-05-07T19:09:55  *** arowser has joined #bitcoin-core-dev
481 2018-05-07T19:11:51  *** arowser has quit IRC
482 2018-05-07T19:12:08  *** arowser has joined #bitcoin-core-dev
483 2018-05-07T19:13:27  *** arowser has quit IRC
484 2018-05-07T19:13:31  *** promag has quit IRC
485 2018-05-07T19:13:53  *** arowser has joined #bitcoin-core-dev
486 2018-05-07T19:14:16  *** pierre_rochard has quit IRC
487 2018-05-07T19:15:22  *** lnostdal has joined #bitcoin-core-dev
488 2018-05-07T19:17:00  *** arowser has quit IRC
489 2018-05-07T19:21:09  *** arowser has joined #bitcoin-core-dev
490 2018-05-07T19:21:56  *** CubicEarths has quit IRC
491 2018-05-07T19:23:01  *** pierre_rochard has joined #bitcoin-core-dev
492 2018-05-07T19:24:08  *** CubicEarths has joined #bitcoin-core-dev
493 2018-05-07T19:25:31  *** arowser has quit IRC
494 2018-05-07T19:25:48  *** arowser has joined #bitcoin-core-dev
495 2018-05-07T19:42:34  *** pierre_rochard has quit IRC
496 2018-05-07T19:43:09  *** pierre_rochard has joined #bitcoin-core-dev
497 2018-05-07T19:49:35  *** Randolf has quit IRC
498 2018-05-07T19:59:45  *** promag has joined #bitcoin-core-dev
499 2018-05-07T20:00:58  *** isis_ has quit IRC
500 2018-05-07T20:02:05  *** RoyceX has joined #bitcoin-core-dev
501 2018-05-07T20:03:59  *** isis_ has joined #bitcoin-core-dev
502 2018-05-07T20:05:27  *** cheese_ has quit IRC
503 2018-05-07T20:15:17  *** Sinclair_ has quit IRC
504 2018-05-07T20:21:46  *** rex4539 has quit IRC
505 2018-05-07T20:27:05  *** Sinclair_ has joined #bitcoin-core-dev
506 2018-05-07T20:27:55  *** cheese_ has joined #bitcoin-core-dev
507 2018-05-07T20:30:14  *** Krellan has joined #bitcoin-core-dev
508 2018-05-07T20:31:33  *** RoyceX has quit IRC
509 2018-05-07T20:36:51  <jnewbery> I think we should consider putting #10973 on high priority for review. So far it has full review from jamesob and me, and partial review from jeremyrubin.
510 2018-05-07T20:36:55  <gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
511 2018-05-07T20:38:40  <jnewbery> It's a large changeset (+1526,-670), so it's quite an involved review. I don't know if it makes sense to chop it up into smaller PRs (although logically, the intermediate commits don't really make sense unless we take the whole lot)
512 2018-05-07T20:38:47  <jnewbery> Perhaps something to discuss at the next meeting
513 2018-05-07T20:40:28  <promag> BlueMatt: could you take a look at #13063? ty
514 2018-05-07T20:40:30  <gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
515 2018-05-07T20:41:20  <promag> jnewbery: I was planning to see that one too
516 2018-05-07T20:43:34  *** Randolf has joined #bitcoin-core-dev
517 2018-05-07T20:44:35  *** Cheeseo has joined #bitcoin-core-dev
518 2018-05-07T20:45:05  *** Dizzle has quit IRC
519 2018-05-07T20:45:18  *** laurentmt1 has joined #bitcoin-core-dev
520 2018-05-07T20:45:26  *** CodeShark_ has joined #bitcoin-core-dev
521 2018-05-07T20:46:11  *** robby938__ has joined #bitcoin-core-dev
522 2018-05-07T20:46:29  *** NicolasDorier_ has joined #bitcoin-core-dev
523 2018-05-07T20:46:47  *** epic_ has joined #bitcoin-core-dev
524 2018-05-07T20:47:24  *** games__ has joined #bitcoin-core-dev
525 2018-05-07T20:48:22  *** wump has joined #bitcoin-core-dev
526 2018-05-07T20:48:58  *** nickler_ has joined #bitcoin-core-dev
527 2018-05-07T20:50:09  *** brianhoffman has quit IRC
528 2018-05-07T20:51:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf9b03ddcc65...6b824c090f53
529 2018-05-07T20:51:45  <bitcoin-git> bitcoin/master f30e9be David A. Harding: RPC Docs: gettxout*: clarify bestblock and unspent counts
530 2018-05-07T20:51:46  <bitcoin-git> bitcoin/master 6b824c0 MarcoFalke: Merge #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts...
531 2018-05-07T20:51:48  *** kakobreklaa has joined #bitcoin-core-dev
532 2018-05-07T20:51:55  *** dx25_ has joined #bitcoin-core-dev
533 2018-05-07T20:52:08  *** mryandao- has joined #bitcoin-core-dev
534 2018-05-07T20:52:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts (master...2018-05-rpc-help-bestblock) https://github.com/bitcoin/bitcoin/pull/13184
535 2018-05-07T20:52:34  *** nullptr_ has joined #bitcoin-core-dev
536 2018-05-07T20:53:21  *** cheese_ has quit IRC
537 2018-05-07T20:53:21  *** nullptr| has quit IRC
538 2018-05-07T20:53:21  *** laurentmt has quit IRC
539 2018-05-07T20:53:21  *** ProfMac has quit IRC
540 2018-05-07T20:53:21  *** robby938_ has quit IRC
541 2018-05-07T20:53:21  *** games_ has quit IRC
542 2018-05-07T20:53:21  *** dx25 has quit IRC
543 2018-05-07T20:53:21  *** mryandao has quit IRC
544 2018-05-07T20:53:22  *** _flow__ has quit IRC
545 2018-05-07T20:53:22  *** kakobrekla has quit IRC
546 2018-05-07T20:53:22  *** NicolasDorier has quit IRC
547 2018-05-07T20:53:22  *** CodeShark has quit IRC
548 2018-05-07T20:53:22  *** nickler has quit IRC
549 2018-05-07T20:53:22  *** wumpus has quit IRC
550 2018-05-07T20:53:22  *** epic has quit IRC
551 2018-05-07T20:53:24  *** robby938__ is now known as robby938_
552 2018-05-07T20:53:26  *** laurentmt1 is now known as laurentmt
553 2018-05-07T20:53:27  *** mryandao- is now known as mryandao
554 2018-05-07T20:53:31  *** CodeShark_ is now known as CodeShark
555 2018-05-07T20:53:33  *** games__ is now known as games_
556 2018-05-07T20:53:38  *** NicolasDorier_ is now known as NicolasDorier
557 2018-05-07T20:54:07  *** epic_ is now known as epic
558 2018-05-07T20:54:47  *** ProfMac has joined #bitcoin-core-dev
559 2018-05-07T20:55:57  *** Randolf has quit IRC
560 2018-05-07T20:56:30  <jamesob> when writing a class that mimics a vector, should our naming conventions take precedence over interface imitation? e.g. PushBack vs. push_back
561 2018-05-07T20:57:43  *** promag has quit IRC
562 2018-05-07T20:57:45  *** Randolf has joined #bitcoin-core-dev
563 2018-05-07T20:57:54  *** _flow__ has joined #bitcoin-core-dev
564 2018-05-07T20:58:51  *** jb55 has quit IRC
565 2018-05-07T20:59:51  *** arowser has quit IRC
566 2018-05-07T21:01:04  *** arowser has joined #bitcoin-core-dev
567 2018-05-07T21:01:30  <skeees> if you're just adding something that exists in a future std (e.g. c++17) then preference is to maintain api compatibility
568 2018-05-07T21:02:31  *** arowser has quit IRC
569 2018-05-07T21:06:31  *** arowser has joined #bitcoin-core-dev
570 2018-05-07T21:08:25  *** arowser has quit IRC
571 2018-05-07T21:08:41  *** Guyver2 has quit IRC
572 2018-05-07T21:08:45  *** arowser has joined #bitcoin-core-dev
573 2018-05-07T21:09:48  *** arowser has quit IRC
574 2018-05-07T21:10:25  *** arowser has joined #bitcoin-core-dev
575 2018-05-07T21:12:17  *** rex4539 has joined #bitcoin-core-dev
576 2018-05-07T21:13:21  *** arowser has quit IRC
577 2018-05-07T21:14:15  *** arowser has joined #bitcoin-core-dev
578 2018-05-07T21:15:50  *** glaksmono has joined #bitcoin-core-dev
579 2018-05-07T21:17:15  *** arowser has quit IRC
580 2018-05-07T21:17:32  *** arowser has joined #bitcoin-core-dev
581 2018-05-07T21:19:27  *** promag has joined #bitcoin-core-dev
582 2018-05-07T21:20:46  *** glaksmono has quit IRC
583 2018-05-07T21:22:22  *** pierre_rochard has quit IRC
584 2018-05-07T21:23:01  *** arowser_ has joined #bitcoin-core-dev
585 2018-05-07T21:26:57  *** arowser_ has quit IRC
586 2018-05-07T21:27:38  *** pierre_rochard has joined #bitcoin-core-dev
587 2018-05-07T21:27:38  *** arowser_ has joined #bitcoin-core-dev
588 2018-05-07T21:27:49  *** promag_ has joined #bitcoin-core-dev
589 2018-05-07T21:29:38  *** arowser_ has quit IRC
590 2018-05-07T21:30:45  *** arowser_ has joined #bitcoin-core-dev
591 2018-05-07T21:31:48  *** arowser_ has quit IRC
592 2018-05-07T21:32:10  *** arowser_ has joined #bitcoin-core-dev
593 2018-05-07T21:32:28  *** promag has quit IRC
594 2018-05-07T21:32:28  *** arowser has quit IRC
595 2018-05-07T21:32:28  *** _flow__ has quit IRC
596 2018-05-07T21:32:45  *** wraithm_ is now known as wraithm
597 2018-05-07T21:33:42  *** Chris_Stewart_5 has quit IRC
598 2018-05-07T21:36:26  *** arowser_ has quit IRC
599 2018-05-07T21:38:01  *** arowser_ has joined #bitcoin-core-dev
600 2018-05-07T21:39:34  *** arowser_ has joined #bitcoin-core-dev
601 2018-05-07T21:39:44  *** moneyball has quit IRC
602 2018-05-07T21:40:32  *** promag_ has quit IRC
603 2018-05-07T21:42:17  *** _flow__ has joined #bitcoin-core-dev
604 2018-05-07T21:43:30  *** arowser_ has quit IRC
605 2018-05-07T21:43:53  *** arowser_ has joined #bitcoin-core-dev
606 2018-05-07T21:45:48  *** arowser_ has quit IRC
607 2018-05-07T21:46:08  *** arowser_ has joined #bitcoin-core-dev
608 2018-05-07T21:46:34  *** moneyball has joined #bitcoin-core-dev
609 2018-05-07T21:48:03  *** arowser_ has quit IRC
610 2018-05-07T21:48:20  *** arowser_ has joined #bitcoin-core-dev
611 2018-05-07T21:53:15  *** arowser_ has quit IRC
612 2018-05-07T21:53:31  *** arowser_ has joined #bitcoin-core-dev
613 2018-05-07T21:55:57  *** moneyball has quit IRC
614 2018-05-07T21:56:14  *** promag has joined #bitcoin-core-dev
615 2018-05-07T21:58:36  *** spinza has quit IRC
616 2018-05-07T21:59:58  *** promag has quit IRC
617 2018-05-07T22:03:05  *** Randolf has quit IRC
618 2018-05-07T22:04:27  *** promag has joined #bitcoin-core-dev
619 2018-05-07T22:04:32  *** pierre_rochard has quit IRC
620 2018-05-07T22:06:07  *** spinza has joined #bitcoin-core-dev
621 2018-05-07T22:06:12  *** promag has quit IRC
622 2018-05-07T22:06:22  *** pierre_rochard has joined #bitcoin-core-dev
623 2018-05-07T22:16:17  *** arubi has quit IRC
624 2018-05-07T22:17:00  *** arubi has joined #bitcoin-core-dev
625 2018-05-07T22:18:00  *** pierre_rochard has quit IRC
626 2018-05-07T22:23:09  <jimpo> Friendly reminder: #12254 is still ready for review
627 2018-05-07T22:23:12  <gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
628 2018-05-07T22:32:02  <luke-jr> BlueMatt: what timeframe do you need it in? been meaning to rebase/address stuff for a week or so now..
629 2018-05-07T22:32:35  *** Victorsueca has quit IRC
630 2018-05-07T22:33:48  *** Victorsueca has joined #bitcoin-core-dev
631 2018-05-07T22:37:46  *** spinza has quit IRC
632 2018-05-07T22:39:07  *** laurentmt has quit IRC
633 2018-05-07T22:41:00  *** fanquake has joined #bitcoin-core-dev
634 2018-05-07T22:44:28  <satwo> Hi all, wasn't able to get a clear answer in #bitcoin, so thought I'd ask here: Why is nSequence an input-level field while nLockTime is transaction-level, and what happens when there are multiple inputs with different nSequence values?
635 2018-05-07T22:44:37  *** spinza has joined #bitcoin-core-dev
636 2018-05-07T22:49:57  *** Dizzle has joined #bitcoin-core-dev
637 2018-05-07T22:51:06  <luke-jr> satwo: originally, or today?
638 2018-05-07T22:53:43  <satwo> luke-jr Today, though if evolution of the protocol would shed light on it I'd be interested in that too.
639 2018-05-07T22:53:47  *** Randolf has joined #bitcoin-core-dev
640 2018-05-07T22:54:36  *** Randolf has quit IRC
641 2018-05-07T22:55:42  *** glaksmono has joined #bitcoin-core-dev
642 2018-05-07T22:55:59  *** Randolf has joined #bitcoin-core-dev
643 2018-05-07T22:57:32  *** laurentmt has joined #bitcoin-core-dev
644 2018-05-07T22:58:27  *** rex4539 has quit IRC
645 2018-05-07T23:00:05  *** glaksmono has quit IRC
646 2018-05-07T23:02:27  *** arowser_ has quit IRC
647 2018-05-07T23:02:44  *** arowser_ has joined #bitcoin-core-dev
648 2018-05-07T23:02:56  *** CubicEarths has quit IRC
649 2018-05-07T23:03:15  *** CubicEarths has joined #bitcoin-core-dev
650 2018-05-07T23:04:04  *** laurentmt has quit IRC
651 2018-05-07T23:04:52  <fanquake> eklitzke Any chance you can rebase #12744 ?
652 2018-05-07T23:04:54  <gribble> https://github.com/bitcoin/bitcoin/issues/12744 | WIP: eliminate dependency on boost::program_options by eklitzke · Pull Request #12744 · bitcoin/bitcoin · GitHub
653 2018-05-07T23:09:46  *** belcher has joined #bitcoin-core-dev
654 2018-05-07T23:10:05  *** tryphe has joined #bitcoin-core-dev
655 2018-05-07T23:13:05  *** Randolf has quit IRC
656 2018-05-07T23:44:46  *** drexl has quit IRC
657 2018-05-07T23:45:44  *** m8tion has joined #bitcoin-core-dev
658 2018-05-07T23:47:59  *** moneyball has joined #bitcoin-core-dev
659 2018-05-07T23:55:39  *** Randolf has joined #bitcoin-core-dev
660 2018-05-07T23:58:55  *** brianhoffman has joined #bitcoin-core-dev
661 2018-05-07T23:59:25  *** kanzure has quit IRC