12018-05-07T00:23:10  *** cryptojanitor has joined #bitcoin-core-dev
  22018-05-07T00:27:08  *** Krellan has quit IRC
  32018-05-07T00:32:15  *** Krellan has joined #bitcoin-core-dev
  42018-05-07T00:57:12  *** Randolf has quit IRC
  52018-05-07T01:12:12  *** jb55 has quit IRC
  62018-05-07T01:17:13  *** t0adst00l has quit IRC
  72018-05-07T01:31:04  *** AaronvanW has quit IRC
  82018-05-07T01:57:20  *** satwo has joined #bitcoin-core-dev
  92018-05-07T02:04:02  *** d9b4bef9 has quit IRC
 102018-05-07T02:05:11  *** d9b4bef9 has joined #bitcoin-core-dev
 112018-05-07T02:29:14  *** arowser has quit IRC
 122018-05-07T02:29:31  *** arowser has joined #bitcoin-core-dev
 132018-05-07T02:30:33  *** isis_ is now known as isis
 142018-05-07T02:31:43  *** arowser has quit IRC
 152018-05-07T02:32:27  *** arowser has joined #bitcoin-core-dev
 162018-05-07T02:33:28  *** arowser has quit IRC
 172018-05-07T02:34:39  *** arowser has joined #bitcoin-core-dev
 182018-05-07T02:36:42  *** arowser has quit IRC
 192018-05-07T02:37:16  *** arowser has joined #bitcoin-core-dev
 202018-05-07T02:39:39  *** arowser has joined #bitcoin-core-dev
 212018-05-07T02:44:33  *** arowser has quit IRC
 222018-05-07T02:52:36  *** Krellan has quit IRC
 232018-05-07T02:59:39  *** grafcaps has joined #bitcoin-core-dev
 242018-05-07T03:00:29  *** Krellan has joined #bitcoin-core-dev
 252018-05-07T03:03:18  *** satwo has quit IRC
 262018-05-07T03:04:50  *** satwo has joined #bitcoin-core-dev
 272018-05-07T03:06:21  *** jojeyh has quit IRC
 282018-05-07T03:13:05  *** grafcaps has quit IRC
 292018-05-07T03:29:39  *** grafcaps has joined #bitcoin-core-dev
 302018-05-07T03:38:27  *** satwo has quit IRC
 312018-05-07T03:46:01  *** satwo has joined #bitcoin-core-dev
 322018-05-07T04:07:13  *** satwo has quit IRC
 332018-05-07T04:08:16  *** satwo has joined #bitcoin-core-dev
 342018-05-07T04:12:30  *** satwo has quit IRC
 352018-05-07T04:32:59  *** ryan-c has quit IRC
 362018-05-07T04:37:48  *** StopAndDecrypt has quit IRC
 372018-05-07T04:41:53  *** zautomata3 has quit IRC
 382018-05-07T04:42:38  *** cryptojanitor has quit IRC
 392018-05-07T04:43:14  *** zautomata3 has joined #bitcoin-core-dev
 402018-05-07T04:51:45  *** jpe has quit IRC
 412018-05-07T04:55:40  *** arowser has joined #bitcoin-core-dev
 422018-05-07T05:11:44  *** jpe has joined #bitcoin-core-dev
 432018-05-07T05:32:46  *** davec_ has quit IRC
 442018-05-07T05:38:57  *** Ana25Lindgren has quit IRC
 452018-05-07T05:45:34  *** arowser has quit IRC
 462018-05-07T05:49:11  *** davec has joined #bitcoin-core-dev
 472018-05-07T05:50:11  *** arowser has joined #bitcoin-core-dev
 482018-05-07T05:52:43  *** Randolf has joined #bitcoin-core-dev
 492018-05-07T06:06:01  *** d9b4bef9 has quit IRC
 502018-05-07T06:07:17  *** d9b4bef9 has joined #bitcoin-core-dev
 512018-05-07T06:18:18  *** Beatrice46Champl has joined #bitcoin-core-dev
 522018-05-07T06:20:05  *** arowser has quit IRC
 532018-05-07T06:21:02  *** arowser has joined #bitcoin-core-dev
 542018-05-07T06:26:18  *** AaronvanW has joined #bitcoin-core-dev
 552018-05-07T06:38:03  *** AaronvanW has quit IRC
 562018-05-07T06:38:38  *** AaronvanW has joined #bitcoin-core-dev
 572018-05-07T06:40:29  *** laurentmt has joined #bitcoin-core-dev
 582018-05-07T06:42:57  *** AaronvanW has quit IRC
 592018-05-07T06:47:18  *** AaronvanW has joined #bitcoin-core-dev
 602018-05-07T06:49:47  *** murchandamus has quit IRC
 612018-05-07T06:50:05  *** murchandamus has joined #bitcoin-core-dev
 622018-05-07T07:09:51  *** Randolf has quit IRC
 632018-05-07T07:14:46  *** meshcollider has joined #bitcoin-core-dev
 642018-05-07T07:30:27  *** zautomata3 has quit IRC
 652018-05-07T07:33:17  *** zautomata3 has joined #bitcoin-core-dev
 662018-05-07T07:36:57  *** arowser has quit IRC
 672018-05-07T07:37:13  *** arowser has joined #bitcoin-core-dev
 682018-05-07T07:41:28  *** ken2812221 has quit IRC
 692018-05-07T07:42:17  *** ken2812221 has joined #bitcoin-core-dev
 702018-05-07T07:50:11  *** Randolf has joined #bitcoin-core-dev
 712018-05-07T08:09:48  *** setpill has joined #bitcoin-core-dev
 722018-05-07T08:10:11  *** Krellan has quit IRC
 732018-05-07T08:12:57  *** Randolf has quit IRC
 742018-05-07T08:17:28  *** Victorsueca has quit IRC
 752018-05-07T08:18:38  *** Victorsueca has joined #bitcoin-core-dev
 762018-05-07T08:19:00  *** timothy has joined #bitcoin-core-dev
 772018-05-07T08:21:43  *** dafuq_ has joined #bitcoin-core-dev
 782018-05-07T08:22:57  *** murrayn has quit IRC
 792018-05-07T08:23:27  *** timothy has quit IRC
 802018-05-07T08:23:28  *** drizztbsd has joined #bitcoin-core-dev
 812018-05-07T08:23:35  *** drizztbsd is now known as timothy
 822018-05-07T08:23:54  *** mistergold has joined #bitcoin-core-dev
 832018-05-07T08:26:23  *** promag has joined #bitcoin-core-dev
 842018-05-07T08:39:37  *** harrymm has quit IRC
 852018-05-07T08:43:19  *** Krellan has joined #bitcoin-core-dev
 862018-05-07T08:48:47  *** Krellan has quit IRC
 872018-05-07T08:48:57  *** Randolf has joined #bitcoin-core-dev
 882018-05-07T08:51:53  *** harrymm has joined #bitcoin-core-dev
 892018-05-07T09:01:05  *** Beatrice46Champl has quit IRC
 902018-05-07T09:10:38  <provoostenator> TL&DR: 3:00 hours on t2.2xlarge, c5.2xlarge, 3:50 hours on m5.2xlarge. I ran out of ideas to make it run faster, see logs in #blockchain-sync.
 912018-05-07T09:22:28  *** dafuq_ has quit IRC
 922018-05-07T09:22:48  *** murrayn has joined #bitcoin-core-dev
 932018-05-07T09:40:35  *** Krellan has joined #bitcoin-core-dev
 942018-05-07T09:43:02  *** Krellan has quit IRC
 952018-05-07T09:43:09  *** Krellan has joined #bitcoin-core-dev
 962018-05-07T09:53:55  *** jtimon has joined #bitcoin-core-dev
 972018-05-07T09:55:06  *** Brant73Grady has joined #bitcoin-core-dev
 982018-05-07T10:00:14  *** jtimon has quit IRC
 992018-05-07T10:08:01  *** d9b4bef9 has quit IRC
1002018-05-07T10:09:04  *** jtimon has joined #bitcoin-core-dev
1012018-05-07T10:09:12  *** d9b4bef9 has joined #bitcoin-core-dev
1022018-05-07T10:11:33  *** AaronvanW has quit IRC
1032018-05-07T10:22:12  *** AaronvanW has joined #bitcoin-core-dev
1042018-05-07T10:27:04  *** AaronvanW has quit IRC
1052018-05-07T10:28:46  <bitcoin-git> [bitcoin] glaksmono opened pull request #13183: [WIP][bitcoin-11004] New Travis job for CHECK_DOCS steps (master...bitcoin-11004) https://github.com/bitcoin/bitcoin/pull/13183
1062018-05-07T10:42:26  *** dafuq[m] has quit IRC
1072018-05-07T10:44:33  *** drexl has joined #bitcoin-core-dev
1082018-05-07T10:49:51  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66cc47be982a...a174702bad1c
1092018-05-07T10:49:51  <bitcoin-git> bitcoin/master fad63eb John Newbery: [logging] Don't incorrectly log that REJECT messages are unknown....
1102018-05-07T10:49:52  <bitcoin-git> bitcoin/master a174702 Wladimir J. van der Laan: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown....
1112018-05-07T10:50:41  <bitcoin-git> [bitcoin] laanwj closed pull request #13162: [net] Don't incorrectly log that REJECT messages are unknown. (master...fix_reject_logging) https://github.com/bitcoin/bitcoin/pull/13162
1122018-05-07T10:55:17  <jtimon> sorry, I forgot to fix BlueMatt's latest nits on https://github.com/bitcoin/bitcoin/pull/10757 fixed now
1132018-05-07T10:56:38  <jtimon> btw, I'm confused about what "matt was here" means in this context. I thought it was mostly for refactors and meant something like "I don't see the value of this refactor but it doesn't break things and I don't care, so I won't nack", but this is adding new functionality
1142018-05-07T10:57:06  *** Victorsueca has quit IRC
1152018-05-07T10:57:17  <jtimon> can someone clarify what's that supposed to mean, perhaps we can put that on the documentation like we have ACK, utACK, etc ?
1162018-05-07T10:57:44  <luke-jr> jtimon: the impression I got (but I never asked him) was that it was a kind of "I looked at this, but I didn't review it sufficiently to ACK"
1172018-05-07T10:58:18  *** Victorsueca has joined #bitcoin-core-dev
1182018-05-07T11:00:12  <jtimon> luke-jr: I was under the impression he had reviewed it enough, but perhaps that's it
1192018-05-07T11:01:39  <luke-jr> well, sounds like BlueMatt should clarify ;)
1202018-05-07T11:02:49  *** Emcy has quit IRC
1212018-05-07T11:12:35  *** jtimon has quit IRC
1222018-05-07T11:16:17  *** AaronvanW has joined #bitcoin-core-dev
1232018-05-07T11:17:39  *** mistergold has quit IRC
1242018-05-07T11:21:54  *** AaronvanW has quit IRC
1252018-05-07T11:25:57  *** zautomata3 has quit IRC
1262018-05-07T11:28:18  *** zautomata has joined #bitcoin-core-dev
1272018-05-07T11:28:58  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a174702bad1c...6a01a50f4906
1282018-05-07T11:28:58  <bitcoin-git> bitcoin/master 43f3dec donaloconnor: Remove enum specifier (to avoid re-declare scoped enum as unscoped)
1292018-05-07T11:28:59  <bitcoin-git> bitcoin/master 6a01a50 Jonas Schnelli: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers)...
1302018-05-07T11:29:40  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers) (master...06052018_unscoped_enum) https://github.com/bitcoin/bitcoin/pull/13180
1312018-05-07T11:33:10  *** Krellan has quit IRC
1322018-05-07T11:33:29  *** murrayn has quit IRC
1332018-05-07T11:33:44  *** Krellan has joined #bitcoin-core-dev
1342018-05-07T11:33:51  *** murrayn has joined #bitcoin-core-dev
1352018-05-07T11:33:51  *** murrayn has joined #bitcoin-core-dev
1362018-05-07T11:39:58  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a01a50f4906...bd83704ec6fa
1372018-05-07T11:39:59  <bitcoin-git> bitcoin/master 29c9bdc practicalswift: Handle unsuccessful fseek(...):s
1382018-05-07T11:40:00  <bitcoin-git> bitcoin/master 20ce5af practicalswift: Print a log message if we fail to shrink the debug log file
1392018-05-07T11:40:00  <bitcoin-git> bitcoin/master bd83704 Wladimir J. van der Laan: Merge #13149: Handle unsuccessful fseek(...):s...
1402018-05-07T11:40:50  <bitcoin-git> [bitcoin] laanwj closed pull request #13149: Handle unsuccessful fseek(...):s (master...fseek) https://github.com/bitcoin/bitcoin/pull/13149
1412018-05-07T11:50:06  *** SopaXorzTaker has joined #bitcoin-core-dev
1422018-05-07T12:07:41  *** infernix has quit IRC
1432018-05-07T12:12:20  *** promag has quit IRC
1442018-05-07T12:16:47  *** Cory has quit IRC
1452018-05-07T12:18:25  *** Emcy has joined #bitcoin-core-dev
1462018-05-07T12:22:36  *** jtimon has joined #bitcoin-core-dev
1472018-05-07T12:23:14  *** Cory has joined #bitcoin-core-dev
1482018-05-07T12:33:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd83704ec6fa...57aae632e288
1492018-05-07T12:33:42  <bitcoin-git> bitcoin/master ddebde7 Chun Kuan Lee: Add Windows shutdown handler
1502018-05-07T12:33:42  <bitcoin-git> bitcoin/master 57aae63 Wladimir J. van der Laan: Merge #13131: Add Windows shutdown handler...
1512018-05-07T12:34:31  <bitcoin-git> [bitcoin] laanwj closed pull request #13131: Add Windows shutdown handler (master...win-quit) https://github.com/bitcoin/bitcoin/pull/13131
1522018-05-07T12:52:05  *** tryphe_ has joined #bitcoin-core-dev
1532018-05-07T12:53:42  *** promag has joined #bitcoin-core-dev
1542018-05-07T12:54:14  *** tryphe_ has quit IRC
1552018-05-07T12:54:34  *** tryphe_ has joined #bitcoin-core-dev
1562018-05-07T12:55:05  *** tryphe has quit IRC
1572018-05-07T12:55:14  *** Anduck has quit IRC
1582018-05-07T12:56:18  *** vicenteH has joined #bitcoin-core-dev
1592018-05-07T12:56:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1602018-05-07T13:01:06  *** dafuq_ has joined #bitcoin-core-dev
1612018-05-07T13:04:00  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57aae632e288...5778d44aa857
1622018-05-07T13:04:00  <bitcoin-git> bitcoin/master 16be133 Ben Woosley: Fix rescanblockchain rpc to property report progress...
1632018-05-07T13:04:01  *** BCBot_ has joined #bitcoin-core-dev
1642018-05-07T13:04:01  <bitcoin-git> bitcoin/master 5778d44 Jonas Schnelli: Merge #13079: Fix rescanblockchain rpc to properly report progress...
1652018-05-07T13:04:35  *** AaronvanW has joined #bitcoin-core-dev
1662018-05-07T13:04:40  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13079: Fix rescanblockchain rpc to properly report progress (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079
1672018-05-07T13:05:28  *** roasbeef_ has joined #bitcoin-core-dev
1682018-05-07T13:05:55  *** karl has joined #bitcoin-core-dev
1692018-05-07T13:06:21  *** Sentineo_ has joined #bitcoin-core-dev
1702018-05-07T13:06:31  *** dongcarl_ has joined #bitcoin-core-dev
1712018-05-07T13:08:53  *** chainhead_ has joined #bitcoin-core-dev
1722018-05-07T13:08:57  *** AaronvanW has quit IRC
1732018-05-07T13:09:01  *** instagibbs_ has joined #bitcoin-core-dev
1742018-05-07T13:09:04  *** gaf__ has joined #bitcoin-core-dev
1752018-05-07T13:09:39  *** lysobit_ has joined #bitcoin-core-dev
1762018-05-07T13:10:26  *** wraithm_ has joined #bitcoin-core-dev
1772018-05-07T13:11:08  *** murrayn has quit IRC
1782018-05-07T13:11:08  *** Brant73Grady has quit IRC
1792018-05-07T13:11:08  *** harrymm has quit IRC
1802018-05-07T13:11:08  *** instagibbs has quit IRC
1812018-05-07T13:11:08  *** gaf_ has quit IRC
1822018-05-07T13:11:08  *** chainhead has quit IRC
1832018-05-07T13:11:08  *** dongcarl has quit IRC
1842018-05-07T13:11:08  *** [b__b] has quit IRC
1852018-05-07T13:11:08  *** Sentineo has quit IRC
1862018-05-07T13:11:08  *** kallewoof has quit IRC
1872018-05-07T13:11:08  *** BCBot has quit IRC
1882018-05-07T13:11:08  *** musalbas has quit IRC
1892018-05-07T13:11:09  *** wraithm has quit IRC
1902018-05-07T13:11:09  *** roasbeef has quit IRC
1912018-05-07T13:11:09  *** lysobit_ is now known as musalbas
1922018-05-07T13:11:48  *** [b__b] has joined #bitcoin-core-dev
1932018-05-07T13:13:28  *** Randolf has quit IRC
1942018-05-07T13:13:37  *** infernix has joined #bitcoin-core-dev
1952018-05-07T13:15:17  *** Randolf has joined #bitcoin-core-dev
1962018-05-07T13:15:23  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5778d44aa857...bf9b03ddcc65
1972018-05-07T13:15:23  <bitcoin-git> bitcoin/master ab3f4dd Chun Kuan Lee: tests: Add test for 64-bit PE, modify 32-bit test results...
1982018-05-07T13:15:24  <bitcoin-git> bitcoin/master bf9b03d Wladimir J. van der Laan: Merge #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results...
1992018-05-07T13:15:36  *** cphrmky has quit IRC
2002018-05-07T13:16:03  <bitcoin-git> [bitcoin] laanwj closed pull request #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13094
2012018-05-07T13:17:32  *** harrymm has joined #bitcoin-core-dev
2022018-05-07T13:21:45  *** Guyver2 has joined #bitcoin-core-dev
2032018-05-07T13:23:28  <wumpus> #10267 gives me an unicorn
2042018-05-07T13:23:32  <gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub
2052018-05-07T13:24:14  *** Anduck has joined #bitcoin-core-dev
2062018-05-07T13:29:36  <wumpus> I'll complain to github
2072018-05-07T13:29:39  *** nullptr| has quit IRC
2082018-05-07T13:34:11  *** jouke has quit IRC
2092018-05-07T13:34:51  *** jouke has joined #bitcoin-core-dev
2102018-05-07T13:35:00  *** nullptr| has joined #bitcoin-core-dev
2112018-05-07T13:35:54  <aj> wumpus: tried clearing your cookies?
2122018-05-07T13:36:24  <wumpus> yeah I can try that again...
2132018-05-07T13:37:53  <jonasschnelli> Also getting a unicorn
2142018-05-07T13:37:55  <wumpus> though I have a hard time believing my browser's handling of cookies is at fault here
2152018-05-07T13:38:51  <wumpus> contacted github anyhow
2162018-05-07T13:38:58  *** Oldnewbie has joined #bitcoin-core-dev
2172018-05-07T13:39:23  *** jouke has quit IRC
2182018-05-07T13:42:38  *** zivl has joined #bitcoin-core-dev
2192018-05-07T13:43:10  <Oldnewbie> Quit
2202018-05-07T13:43:24  *** Oldnewbie has quit IRC
2212018-05-07T13:45:56  <promag> unicorn too
2222018-05-07T13:45:57  *** m8tion has joined #bitcoin-core-dev
2232018-05-07T13:46:13  *** promag has quit IRC
2242018-05-07T13:46:58  <wumpus> jonasschnelli: btw - what is the process for importing a new libbtc into bitcoincore-indexd? I need MSG_WITNESS_BLOCK
2252018-05-07T13:47:03  <wumpus> is it a subtree?
2262018-05-07T13:47:03  *** Krellan has quit IRC
2272018-05-07T13:47:24  <jonasschnelli> wumpus: I think I have added it as subtree
2282018-05-07T13:47:45  <jonasschnelli> wumpus: BTW: I'm currently running a script that runs 10 times block fetching from 490000 till 500000 and measures times
2292018-05-07T13:47:57  <jonasschnelli> Currently running on master... will compare than against your PR and report.
2302018-05-07T13:48:07  *** jouke has joined #bitcoin-core-dev
2312018-05-07T13:48:09  <jonasschnelli> Since this is on SSD, may result may be even more promissing then yours
2322018-05-07T13:48:39  <wumpus> I hope so :)
2332018-05-07T13:48:55  <wumpus> though 10% gain is already somewhat neat
2342018-05-07T13:49:00  *** Krellan has joined #bitcoin-core-dev
2352018-05-07T13:49:23  <jonasschnelli> wumpus: Yes! 10% is already great!
2362018-05-07T13:50:52  <BlueMatt> jtimon: in this case it means what you thought - "I dont care about this feature, so I'm not gonna ack it, but it seems like some folks want it, so certainly wont oppose. Aside from the comments left, I see no other bugs, and so am fine with it advancing, but do not wish to in any way imply a concept ack"
2372018-05-07T13:50:52  *** rafalcpp has joined #bitcoin-core-dev
2382018-05-07T13:54:49  *** BCBot_ has quit IRC
2392018-05-07T13:55:04  *** Kaylin69Doyle has joined #bitcoin-core-dev
2402018-05-07T13:55:05  *** BCBot has joined #bitcoin-core-dev
2412018-05-07T13:55:17  *** satwo has joined #bitcoin-core-dev
2422018-05-07T13:55:57  <BlueMatt> luke-jr: plz2rebase #12208? Trying to whip 0.16.1 :p
2432018-05-07T13:55:59  <gribble> https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
2442018-05-07T13:57:52  *** arowser has quit IRC
2452018-05-07T13:58:25  *** arowser has joined #bitcoin-core-dev
2462018-05-07T14:00:17  <jtimon> BlueMatt: thanks for claryfing
2472018-05-07T14:02:30  *** arowser has quit IRC
2482018-05-07T14:02:50  *** arowser has joined #bitcoin-core-dev
2492018-05-07T14:03:54  *** arowser has quit IRC
2502018-05-07T14:04:13  *** arowser has joined #bitcoin-core-dev
2512018-05-07T14:07:07  *** arowser has quit IRC
2522018-05-07T14:07:24  *** arowser has joined #bitcoin-core-dev
2532018-05-07T14:09:03  *** arowser has quit IRC
2542018-05-07T14:09:40  *** arowser has joined #bitcoin-core-dev
2552018-05-07T14:11:35  *** arowser has quit IRC
2562018-05-07T14:11:45  *** glaksmono has joined #bitcoin-core-dev
2572018-05-07T14:11:46  *** tryphe_ has quit IRC
2582018-05-07T14:11:46  <bitcoin-git> [bitcoin] harding opened pull request #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts (master...2018-05-rpc-help-bestblock) https://github.com/bitcoin/bitcoin/pull/13184
2592018-05-07T14:11:52  *** arowser has joined #bitcoin-core-dev
2602018-05-07T14:12:01  <jonasschnelli> How do I only allow connection from 127.0.0.1?
2612018-05-07T14:12:11  <glaksmono> hi guys, i'm trying to find a reviewer for this: https://github.com/bitcoin/bitcoin/pull/13183
2622018-05-07T14:12:12  <glaksmono> can someone help?
2632018-05-07T14:12:13  <jonasschnelli> Seems like whitelist=127.0.0.1 and connect=0 won't work
2642018-05-07T14:12:27  <jonasschnelli> glaksmono: have some patience
2652018-05-07T14:12:38  <glaksmono> alright @jonasschnelli
2662018-05-07T14:12:43  <glaksmono> i'm a newbie contributor :)
2672018-05-07T14:12:57  <jonasschnelli> glaksmono: also, maybe write some pull request description (not only refere to the issue)
2682018-05-07T14:13:51  <jonasschnelli> NM: whitebind=127.0.0.1:8333 fixed my issue
2692018-05-07T14:13:53  *** grafcaps has quit IRC
2702018-05-07T14:14:06  *** tryphe has joined #bitcoin-core-dev
2712018-05-07T14:19:59  *** arowser has quit IRC
2722018-05-07T14:20:40  *** arowser has joined #bitcoin-core-dev
2732018-05-07T14:20:46  *** promag has joined #bitcoin-core-dev
2742018-05-07T14:25:06  *** rex4539 has joined #bitcoin-core-dev
2752018-05-07T14:26:49  *** tryphe has quit IRC
2762018-05-07T14:28:03  *** StopAndDecrypt has joined #bitcoin-core-dev
2772018-05-07T14:28:52  <wumpus> jonasschnelli: subtree merge from libbtc/libbtc gives me tons of conflicts
2782018-05-07T14:29:04  *** Dizzle has joined #bitcoin-core-dev
2792018-05-07T14:29:31  *** tryphe has joined #bitcoin-core-dev
2802018-05-07T14:29:53  <jonasschnelli> wumpus: try rm -rf src/libbtc and then a fresh git subtree add?
2812018-05-07T14:30:15  <jonasschnelli> I'm pretty sure I haven't done local changes
2822018-05-07T14:30:18  <wumpus> or I'll resolve the conflicts to 'theirs'
2832018-05-07T14:30:26  <jonasschnelli> yeah
2842018-05-07T14:30:34  <wumpus> let's see if it still builds at all
2852018-05-07T14:31:31  *** SopaXorzTaker has quit IRC
2862018-05-07T14:32:07  <jonasschnelli> I don't know why I had to manually add a LDADD+=-lpthread in the bitcoincore-indexd project... seems that lpthread will not auto-added via Makefile.leveldb.am
2872018-05-07T14:32:20  *** grafcaps has joined #bitcoin-core-dev
2882018-05-07T14:40:28  <jonasschnelli> hmm... master is quicker then PR 13151?! let me double check...
2892018-05-07T14:40:44  <wumpus> jonasschnelli: eh whoops libbbtc serialize.h has two LIBBTC_END_DECL
2902018-05-07T14:41:06  <jonasschnelli> wumpus: hmm.. that was a recent change by promag...
2912018-05-07T14:41:14  <jonasschnelli> should this not have been detected by travis..
2922018-05-07T14:45:29  <wumpus> jonasschnelli: if that header is used in one of the tests, which I assume, yes :)
2932018-05-07T14:48:07  <wumpus> jonasschnelli: I think I know why travis passed with it: in C, the macros are defined as nothing
2942018-05-07T14:48:23  <wumpus> this problem is only apparent when the lib is used from C++
2952018-05-07T14:49:44  <jonasschnelli> ah.. right!
2962018-05-07T14:50:38  <jonasschnelli> wumpus: any reason why your PR 13151 preforms ~6% slower then master?
2972018-05-07T14:51:24  <jonasschnelli> I just reverted back to 598db389c33e5e90783ef1223df2eeab095ed622 from 13151 head to make sure im comparing the right things
2982018-05-07T14:51:25  <wumpus> jonasschnelli: you do request MSG_WITNESS_BLOCK at all?
2992018-05-07T14:51:49  <jonasschnelli> let me dbl check
3002018-05-07T14:52:24  <wumpus> if so, I'm confused, I don't see how this can be *slower*
3012018-05-07T14:52:39  <wumpus> maybe add back the LogPrintf to make sure it's hitting the new fast path at all
3022018-05-07T14:52:47  *** AaronvanW has joined #bitcoin-core-dev
3032018-05-07T14:52:54  <jonasschnelli> wumpus: ser_u32(inv_msg_cstr, 2 | (1 << 30));
3042018-05-07T14:52:56  <jonasschnelli> seems correct
3052018-05-07T14:53:00  <wumpus> yes
3062018-05-07T14:53:37  *** tryphe has quit IRC
3072018-05-07T14:54:01  *** tryphe has joined #bitcoin-core-dev
3082018-05-07T14:56:57  *** AaronvanW has quit IRC
3092018-05-07T14:57:11  *** tryphe_ has joined #bitcoin-core-dev
3102018-05-07T14:57:24  <jonasschnelli> wumpus: you mean that one: https://github.com/bitcoin/bitcoin/pull/13151/commits/4c790dff7481d1464a906ad6b17a3179a7da3431#diff-eff7adeaec73a769788bb78858815c91R1149?
3112018-05-07T15:00:15  *** grafcaps has quit IRC
3122018-05-07T15:00:21  *** tryphe has quit IRC
3132018-05-07T15:00:48  <wumpus> yes the ""debug: Serving raw block directly from disk"
3142018-05-07T15:01:07  <wumpus> although remove it when performance benchmarking, as all the log messages will again make it slower...
3152018-05-07T15:01:43  <jonasschnelli> Yes. Sure
3162018-05-07T15:02:05  <jonasschnelli> jup.. its firing...
3172018-05-07T15:02:12  *** tryphe_000 has joined #bitcoin-core-dev
3182018-05-07T15:02:46  <jonasschnelli> I do now disable the logprintf and test again...
3192018-05-07T15:04:39  *** arowser has quit IRC
3202018-05-07T15:05:19  *** tryphe has joined #bitcoin-core-dev
3212018-05-07T15:05:43  *** tryphe_ has quit IRC
3222018-05-07T15:06:36  *** AaronvanW has joined #bitcoin-core-dev
3232018-05-07T15:07:39  *** tryphe_000 has quit IRC
3242018-05-07T15:08:40  *** arowser has joined #bitcoin-core-dev
3252018-05-07T15:10:42  *** arowser has quit IRC
3262018-05-07T15:13:20  *** arowser has joined #bitcoin-core-dev
3272018-05-07T15:14:25  *** arowser has quit IRC
3282018-05-07T15:14:41  *** arowser has joined #bitcoin-core-dev
3292018-05-07T15:16:42  *** arowser has quit IRC
3302018-05-07T15:16:51  *** jb55 has joined #bitcoin-core-dev
3312018-05-07T15:18:58  *** promag has quit IRC
3322018-05-07T15:19:14  *** promag has joined #bitcoin-core-dev
3332018-05-07T15:19:29  *** spudowiar has joined #bitcoin-core-dev
3342018-05-07T15:19:40  *** spudowiar has quit IRC
3352018-05-07T15:22:04  *** spudowiar has joined #bitcoin-core-dev
3362018-05-07T15:29:25  *** arowser has joined #bitcoin-core-dev
3372018-05-07T15:30:38  *** arowser has quit IRC
3382018-05-07T15:31:57  *** arowser has joined #bitcoin-core-dev
3392018-05-07T15:33:22  <promag> wumpus: regarding block.resize(blk_size);
3402018-05-07T15:34:20  <promag> filein.read((char*)block.data(), blk_size) will overwrite those zeros.. so I really don't get it
3412018-05-07T15:34:43  <wumpus> what if it somehow fails
3422018-05-07T15:35:13  <wumpus> my point is defense in depth here
3432018-05-07T15:35:17  *** ula has quit IRC
3442018-05-07T15:35:37  *** glaksmono has quit IRC
3452018-05-07T15:35:41  <promag> you mean read fails?
3462018-05-07T15:35:50  <wumpus> yes
3472018-05-07T15:36:12  *** glaksmono has joined #bitcoin-core-dev
3482018-05-07T15:36:32  <promag> then it shouldn't serve, it should fail?
3492018-05-07T15:36:40  <wumpus> it should, but a bug might prevent that
3502018-05-07T15:36:48  <wumpus> either a kernel bug or something else
3512018-05-07T15:38:17  *** arowser has quit IRC
3522018-05-07T15:38:39  <promag> ok, I wounder if it has performance impact regarding jonas bench
3532018-05-07T15:38:42  *** arowser has joined #bitcoin-core-dev
3542018-05-07T15:38:52  <wumpus> only if you can measure a significant improvement of not zeroing I'm willing to argue about this further
3552018-05-07T15:39:12  <wumpus> otherwise it seems pointless shed painting...
3562018-05-07T15:39:30  <jamesob> hm. If I'm gonna implement a threadsafe ring buffer for use with the async logging stuff, better to do that as a general module (a util sort of thing) or within a logging-specific module?
3572018-05-07T15:40:44  *** arowser has quit IRC
3582018-05-07T15:40:48  <wumpus> jamesob: depends on how much work it is to make it general instead of specific, and how much extra code that brings. If not much, making it general is preferable of course.
3592018-05-07T15:40:52  *** glaksmono has quit IRC
3602018-05-07T15:41:10  <jamesob> wumpus: good advice, thanks
3612018-05-07T15:43:14  *** arowser has joined #bitcoin-core-dev
3622018-05-07T15:43:22  <sipa> wumpus, promag: is there even a way to resize a vector _without_ initializing the chars to 0?
3632018-05-07T15:43:33  <wumpus> jonasschnelli: seems you merged https://github.com/jonasschnelli/bitcoincore-indexd/pull/1, I think we had to update it to include https://github.com/libbtc/libbtc/pull/127
3642018-05-07T15:43:37  <wumpus> sipa: no :/
3652018-05-07T15:44:37  *** arowser has quit IRC
3662018-05-07T15:45:29  <wumpus> so indeed, I don't know what the c++11 "nice" way to do that is, could use a unique_ptr to a new [] array instead of a vector, or something else, but nothing seems really elegant
3672018-05-07T15:45:35  <sipa> std::array :)
3682018-05-07T15:45:37  *** arowser has joined #bitcoin-core-dev
3692018-05-07T15:45:46  <sipa> which does not seem to require initializing the elements
3702018-05-07T15:45:48  <wumpus> does that work for variable lengths?
3712018-05-07T15:45:51  <sipa> no
3722018-05-07T15:48:38  <spudowiar> How is someone actually supposed to say they know C++ when you might blink and we'll suddenly be on C++18428 and it'll look like some dialect of Python
3732018-05-07T15:51:31  <spudowiar> https://github.com/facebook/folly/blob/master/folly/memory/UninitializedMemoryHacks.h
3742018-05-07T15:52:15  <spudowiar> That looks perfectly safe and not at all a terrible hack
3752018-05-07T15:57:09  <cfields> sipa: I believe a std::vector with a custom allocator can
3762018-05-07T16:01:54  *** setpill has quit IRC
3772018-05-07T16:05:34  *** arowser has quit IRC
3782018-05-07T16:05:39  <wumpus> spudowiar: yeah... language evolution is not a bad thing, and c++11 brings a lot of useful things, but c++ is alread such a crazy complex language, it's increasingly impossible to say you really know it.
3792018-05-07T16:06:59  *** arowser has joined #bitcoin-core-dev
3802018-05-07T16:09:26  *** arowser has quit IRC
3812018-05-07T16:09:47  <sipa> spudowiar: "folly" i would say
3822018-05-07T16:09:57  *** arowser has joined #bitcoin-core-dev
3832018-05-07T16:10:11  *** Krellan has quit IRC
3842018-05-07T16:10:52  <wumpus> yes it scares me, let's just zero the vector ok
3852018-05-07T16:12:53  *** arowser has quit IRC
3862018-05-07T16:13:11  *** arowser has joined #bitcoin-core-dev
3872018-05-07T16:14:18  *** Krellan has joined #bitcoin-core-dev
3882018-05-07T16:17:13  *** arowser has quit IRC
3892018-05-07T16:17:33  *** arowser has joined #bitcoin-core-dev
3902018-05-07T16:17:38  <sipa> wumpus: ack
3912018-05-07T16:18:47  <jonasschnelli> wumpus: meh. yes. Let me push a subtree update then.
3922018-05-07T16:20:35  *** arowser has quit IRC
3932018-05-07T16:20:53  *** arowser has joined #bitcoin-core-dev
3942018-05-07T16:20:57  <promag> jonasschnelli: wumpus: should libbtc have a c++ job in travis?
3952018-05-07T16:22:52  *** arowser has quit IRC
3962018-05-07T16:23:10  *** arowser has joined #bitcoin-core-dev
3972018-05-07T16:24:12  <jonasschnelli> promag: yes. a little c++ test would be great.
3982018-05-07T16:27:07  *** arowser has quit IRC
3992018-05-07T16:27:30  *** arowser has joined #bitcoin-core-dev
4002018-05-07T16:29:25  *** arowser has quit IRC
4012018-05-07T16:29:35  *** spudowiar is now known as x123456789
4022018-05-07T16:29:42  *** arowser has joined #bitcoin-core-dev
4032018-05-07T16:30:06  *** x123456789 is now known as spudowiar
4042018-05-07T16:31:08  *** meshcollider has quit IRC
4052018-05-07T16:33:12  <wumpus> promag: I think for most intents and purposes it doesn't matter, for a C library, except the specific thing (`extern "C" {` in headers) you were changing
4062018-05-07T16:34:12  *** arowser has quit IRC
4072018-05-07T16:35:46  *** arowser has joined #bitcoin-core-dev
4082018-05-07T16:36:53  *** arowser has quit IRC
4092018-05-07T16:37:23  *** arowser has joined #bitcoin-core-dev
4102018-05-07T16:39:17  *** arowser has quit IRC
4112018-05-07T16:39:35  *** arowser has joined #bitcoin-core-dev
4122018-05-07T16:40:36  *** arowser has quit IRC
4132018-05-07T16:40:54  *** arowser has joined #bitcoin-core-dev
4142018-05-07T16:42:58  *** arowser has quit IRC
4152018-05-07T16:43:38  *** Krellan has quit IRC
4162018-05-07T16:44:14  *** arowser has joined #bitcoin-core-dev
4172018-05-07T16:44:22  *** Krellan has joined #bitcoin-core-dev
4182018-05-07T16:44:23  *** isis is now known as isis_
4192018-05-07T16:47:42  <promag> BlueMatt: I can rebase #13063 on master and leave walletmanager out for now
4202018-05-07T16:47:45  <gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
4212018-05-07T16:48:38  <BlueMatt> I mean I presume given the annoyance of moving forward with the loadwallet stuff we should do a minimal fix to get that through, and then we can clean it up as all that stuff matures
4222018-05-07T16:48:58  *** m8tion has quit IRC
4232018-05-07T16:50:00  <promag> so you suggest to reopen #12647?
4242018-05-07T16:50:04  <gribble> https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub
4252018-05-07T16:50:10  <promag> BlueMatt: annoyance? :)
4262018-05-07T16:50:28  *** jtimon has quit IRC
4272018-05-07T16:52:32  *** arowser has quit IRC
4282018-05-07T16:52:48  *** arowser has joined #bitcoin-core-dev
4292018-05-07T16:53:21  *** Krellan has quit IRC
4302018-05-07T16:54:21  *** arowser has quit IRC
4312018-05-07T16:54:54  *** Krellan has joined #bitcoin-core-dev
4322018-05-07T16:56:02  *** tryphe has quit IRC
4332018-05-07T16:58:17  *** arowser has joined #bitcoin-core-dev
4342018-05-07T17:05:58  *** tryphe has joined #bitcoin-core-dev
4352018-05-07T17:11:45  *** tryphe has quit IRC
4362018-05-07T17:13:47  *** tryphe has joined #bitcoin-core-dev
4372018-05-07T17:14:28  *** tryphe has quit IRC
4382018-05-07T17:18:01  *** glaksmono has joined #bitcoin-core-dev
4392018-05-07T17:18:24  *** CubicEarths has joined #bitcoin-core-dev
4402018-05-07T17:18:45  *** Krellan has quit IRC
4412018-05-07T17:19:25  *** Krellan has joined #bitcoin-core-dev
4422018-05-07T17:20:36  *** spudowiar has quit IRC
4432018-05-07T17:21:51  *** Emcy has quit IRC
4442018-05-07T17:22:34  *** glaksmono has quit IRC
4452018-05-07T17:27:46  *** timothy has quit IRC
4462018-05-07T17:30:05  *** zivl has quit IRC
4472018-05-07T17:31:03  *** mol has quit IRC
4482018-05-07T17:31:15  *** lnostdal has joined #bitcoin-core-dev
4492018-05-07T17:32:15  *** AaronvanW has quit IRC
4502018-05-07T17:33:51  *** Krellan has quit IRC
4512018-05-07T17:35:13  *** glaksmono has joined #bitcoin-core-dev
4522018-05-07T17:38:12  *** molz has joined #bitcoin-core-dev
4532018-05-07T17:39:35  *** glaksmono has quit IRC
4542018-05-07T17:41:21  *** vicenteH has quit IRC
4552018-05-07T17:56:37  *** zivl has joined #bitcoin-core-dev
4562018-05-07T18:01:37  *** Randolf has quit IRC
4572018-05-07T18:16:59  *** roasbeef_ is now known as roasbeef
4582018-05-07T18:22:37  <bitcoin-git> [bitcoin] sipa opened pull request #13185: Bugfix: the end of a reorged chain is invalid when connect fails (master...201805_bugfix_invalidchain_end) https://github.com/bitcoin/bitcoin/pull/13185
4592018-05-07T18:35:19  *** pierre_rochard has joined #bitcoin-core-dev
4602018-05-07T18:37:56  *** bsm1175321 has joined #bitcoin-core-dev
4612018-05-07T18:38:19  *** moneyball has joined #bitcoin-core-dev
4622018-05-07T18:49:58  *** Randolf has joined #bitcoin-core-dev
4632018-05-07T18:50:06  <bitcoin-git> [bitcoin] skeees opened pull request #13186: Use a semaphore to trigger shutdown procedures (master...shutdown-cv) https://github.com/bitcoin/bitcoin/pull/13186
4642018-05-07T18:53:41  *** glaksmono has joined #bitcoin-core-dev
4652018-05-07T18:55:02  *** DrDraake has joined #bitcoin-core-dev
4662018-05-07T18:55:38  <DrDraake> hey guys
4672018-05-07T18:58:12  *** glaksmono has quit IRC
4682018-05-07T19:01:04  <DrDraake> Don't know if this is the right channel.  If someone has a offline bitcoin core wallet showing a balance and you can do not see the corresponding wallet on chain.  If they send you a core to core transaction offline and you bring your core wallet online can that transaction confirm and previously they have sent the same amount of BTC to someone else who gets the BTC?  Will it show in my wallet and when I go to spend it wil
4692018-05-07T19:02:05  *** lnostdal has quit IRC
4702018-05-07T19:02:10  <BlueMatt> DrDraake: you probably want #bitcoin, but, if a transaction is not mine-able and your node is synced, it will be displayed as "conflicted"
4712018-05-07T19:02:25  <BlueMatt> (probably)
4722018-05-07T19:03:03  <DrDraake> I'm trying to figure out how can this wallet send me BTC if I can not verify they have the coin to begin with....
4732018-05-07T19:03:26  <BlueMatt> you probably want #bitcoin, way more people there to help you out if you clarify what you want to do
4742018-05-07T19:03:37  <DrDraake> Thanks
4752018-05-07T19:03:45  *** glaksmono has joined #bitcoin-core-dev
4762018-05-07T19:05:15  *** arowser has quit IRC
4772018-05-07T19:05:32  *** arowser has joined #bitcoin-core-dev
4782018-05-07T19:07:57  *** glaksmono has quit IRC
4792018-05-07T19:09:37  *** arowser has quit IRC
4802018-05-07T19:09:55  *** arowser has joined #bitcoin-core-dev
4812018-05-07T19:11:51  *** arowser has quit IRC
4822018-05-07T19:12:08  *** arowser has joined #bitcoin-core-dev
4832018-05-07T19:13:27  *** arowser has quit IRC
4842018-05-07T19:13:31  *** promag has quit IRC
4852018-05-07T19:13:53  *** arowser has joined #bitcoin-core-dev
4862018-05-07T19:14:16  *** pierre_rochard has quit IRC
4872018-05-07T19:15:22  *** lnostdal has joined #bitcoin-core-dev
4882018-05-07T19:17:00  *** arowser has quit IRC
4892018-05-07T19:21:09  *** arowser has joined #bitcoin-core-dev
4902018-05-07T19:21:56  *** CubicEarths has quit IRC
4912018-05-07T19:23:01  *** pierre_rochard has joined #bitcoin-core-dev
4922018-05-07T19:24:08  *** CubicEarths has joined #bitcoin-core-dev
4932018-05-07T19:25:31  *** arowser has quit IRC
4942018-05-07T19:25:48  *** arowser has joined #bitcoin-core-dev
4952018-05-07T19:42:34  *** pierre_rochard has quit IRC
4962018-05-07T19:43:09  *** pierre_rochard has joined #bitcoin-core-dev
4972018-05-07T19:49:35  *** Randolf has quit IRC
4982018-05-07T19:59:45  *** promag has joined #bitcoin-core-dev
4992018-05-07T20:00:58  *** isis_ has quit IRC
5002018-05-07T20:02:05  *** RoyceX has joined #bitcoin-core-dev
5012018-05-07T20:03:59  *** isis_ has joined #bitcoin-core-dev
5022018-05-07T20:05:27  *** cheese_ has quit IRC
5032018-05-07T20:15:17  *** Sinclair_ has quit IRC
5042018-05-07T20:21:46  *** rex4539 has quit IRC
5052018-05-07T20:27:05  *** Sinclair_ has joined #bitcoin-core-dev
5062018-05-07T20:27:55  *** cheese_ has joined #bitcoin-core-dev
5072018-05-07T20:30:14  *** Krellan has joined #bitcoin-core-dev
5082018-05-07T20:31:33  *** RoyceX has quit IRC
5092018-05-07T20:36:51  <jnewbery> I think we should consider putting #10973 on high priority for review. So far it has full review from jamesob and me, and partial review from jeremyrubin.
5102018-05-07T20:36:55  <gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
5112018-05-07T20:38:40  <jnewbery> It's a large changeset (+1526,-670), so it's quite an involved review. I don't know if it makes sense to chop it up into smaller PRs (although logically, the intermediate commits don't really make sense unless we take the whole lot)
5122018-05-07T20:38:47  <jnewbery> Perhaps something to discuss at the next meeting
5132018-05-07T20:40:28  <promag> BlueMatt: could you take a look at #13063? ty
5142018-05-07T20:40:30  <gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub
5152018-05-07T20:41:20  <promag> jnewbery: I was planning to see that one too
5162018-05-07T20:43:34  *** Randolf has joined #bitcoin-core-dev
5172018-05-07T20:44:35  *** Cheeseo has joined #bitcoin-core-dev
5182018-05-07T20:45:05  *** Dizzle has quit IRC
5192018-05-07T20:45:18  *** laurentmt1 has joined #bitcoin-core-dev
5202018-05-07T20:45:26  *** CodeShark_ has joined #bitcoin-core-dev
5212018-05-07T20:46:11  *** robby938__ has joined #bitcoin-core-dev
5222018-05-07T20:46:29  *** NicolasDorier_ has joined #bitcoin-core-dev
5232018-05-07T20:46:47  *** epic_ has joined #bitcoin-core-dev
5242018-05-07T20:47:24  *** games__ has joined #bitcoin-core-dev
5252018-05-07T20:48:22  *** wump has joined #bitcoin-core-dev
5262018-05-07T20:48:58  *** nickler_ has joined #bitcoin-core-dev
5272018-05-07T20:50:09  *** brianhoffman has quit IRC
5282018-05-07T20:51:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf9b03ddcc65...6b824c090f53
5292018-05-07T20:51:45  <bitcoin-git> bitcoin/master f30e9be David A. Harding: RPC Docs: gettxout*: clarify bestblock and unspent counts
5302018-05-07T20:51:46  <bitcoin-git> bitcoin/master 6b824c0 MarcoFalke: Merge #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts...
5312018-05-07T20:51:48  *** kakobreklaa has joined #bitcoin-core-dev
5322018-05-07T20:51:55  *** dx25_ has joined #bitcoin-core-dev
5332018-05-07T20:52:08  *** mryandao- has joined #bitcoin-core-dev
5342018-05-07T20:52:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts (master...2018-05-rpc-help-bestblock) https://github.com/bitcoin/bitcoin/pull/13184
5352018-05-07T20:52:34  *** nullptr_ has joined #bitcoin-core-dev
5362018-05-07T20:53:21  *** cheese_ has quit IRC
5372018-05-07T20:53:21  *** nullptr| has quit IRC
5382018-05-07T20:53:21  *** laurentmt has quit IRC
5392018-05-07T20:53:21  *** ProfMac has quit IRC
5402018-05-07T20:53:21  *** robby938_ has quit IRC
5412018-05-07T20:53:21  *** games_ has quit IRC
5422018-05-07T20:53:21  *** dx25 has quit IRC
5432018-05-07T20:53:21  *** mryandao has quit IRC
5442018-05-07T20:53:22  *** _flow__ has quit IRC
5452018-05-07T20:53:22  *** kakobrekla has quit IRC
5462018-05-07T20:53:22  *** NicolasDorier has quit IRC
5472018-05-07T20:53:22  *** CodeShark has quit IRC
5482018-05-07T20:53:22  *** nickler has quit IRC
5492018-05-07T20:53:22  *** wumpus has quit IRC
5502018-05-07T20:53:22  *** epic has quit IRC
5512018-05-07T20:53:24  *** robby938__ is now known as robby938_
5522018-05-07T20:53:26  *** laurentmt1 is now known as laurentmt
5532018-05-07T20:53:27  *** mryandao- is now known as mryandao
5542018-05-07T20:53:31  *** CodeShark_ is now known as CodeShark
5552018-05-07T20:53:33  *** games__ is now known as games_
5562018-05-07T20:53:38  *** NicolasDorier_ is now known as NicolasDorier
5572018-05-07T20:54:07  *** epic_ is now known as epic
5582018-05-07T20:54:47  *** ProfMac has joined #bitcoin-core-dev
5592018-05-07T20:55:57  *** Randolf has quit IRC
5602018-05-07T20:56:30  <jamesob> when writing a class that mimics a vector, should our naming conventions take precedence over interface imitation? e.g. PushBack vs. push_back
5612018-05-07T20:57:43  *** promag has quit IRC
5622018-05-07T20:57:45  *** Randolf has joined #bitcoin-core-dev
5632018-05-07T20:57:54  *** _flow__ has joined #bitcoin-core-dev
5642018-05-07T20:58:51  *** jb55 has quit IRC
5652018-05-07T20:59:51  *** arowser has quit IRC
5662018-05-07T21:01:04  *** arowser has joined #bitcoin-core-dev
5672018-05-07T21:01:30  <skeees> if you're just adding something that exists in a future std (e.g. c++17) then preference is to maintain api compatibility
5682018-05-07T21:02:31  *** arowser has quit IRC
5692018-05-07T21:06:31  *** arowser has joined #bitcoin-core-dev
5702018-05-07T21:08:25  *** arowser has quit IRC
5712018-05-07T21:08:41  *** Guyver2 has quit IRC
5722018-05-07T21:08:45  *** arowser has joined #bitcoin-core-dev
5732018-05-07T21:09:48  *** arowser has quit IRC
5742018-05-07T21:10:25  *** arowser has joined #bitcoin-core-dev
5752018-05-07T21:12:17  *** rex4539 has joined #bitcoin-core-dev
5762018-05-07T21:13:21  *** arowser has quit IRC
5772018-05-07T21:14:15  *** arowser has joined #bitcoin-core-dev
5782018-05-07T21:15:50  *** glaksmono has joined #bitcoin-core-dev
5792018-05-07T21:17:15  *** arowser has quit IRC
5802018-05-07T21:17:32  *** arowser has joined #bitcoin-core-dev
5812018-05-07T21:19:27  *** promag has joined #bitcoin-core-dev
5822018-05-07T21:20:46  *** glaksmono has quit IRC
5832018-05-07T21:22:22  *** pierre_rochard has quit IRC
5842018-05-07T21:23:01  *** arowser_ has joined #bitcoin-core-dev
5852018-05-07T21:26:57  *** arowser_ has quit IRC
5862018-05-07T21:27:38  *** pierre_rochard has joined #bitcoin-core-dev
5872018-05-07T21:27:38  *** arowser_ has joined #bitcoin-core-dev
5882018-05-07T21:27:49  *** promag_ has joined #bitcoin-core-dev
5892018-05-07T21:29:38  *** arowser_ has quit IRC
5902018-05-07T21:30:45  *** arowser_ has joined #bitcoin-core-dev
5912018-05-07T21:31:48  *** arowser_ has quit IRC
5922018-05-07T21:32:10  *** arowser_ has joined #bitcoin-core-dev
5932018-05-07T21:32:28  *** promag has quit IRC
5942018-05-07T21:32:28  *** arowser has quit IRC
5952018-05-07T21:32:28  *** _flow__ has quit IRC
5962018-05-07T21:32:45  *** wraithm_ is now known as wraithm
5972018-05-07T21:33:42  *** Chris_Stewart_5 has quit IRC
5982018-05-07T21:36:26  *** arowser_ has quit IRC
5992018-05-07T21:38:01  *** arowser_ has joined #bitcoin-core-dev
6002018-05-07T21:39:34  *** arowser_ has joined #bitcoin-core-dev
6012018-05-07T21:39:44  *** moneyball has quit IRC
6022018-05-07T21:40:32  *** promag_ has quit IRC
6032018-05-07T21:42:17  *** _flow__ has joined #bitcoin-core-dev
6042018-05-07T21:43:30  *** arowser_ has quit IRC
6052018-05-07T21:43:53  *** arowser_ has joined #bitcoin-core-dev
6062018-05-07T21:45:48  *** arowser_ has quit IRC
6072018-05-07T21:46:08  *** arowser_ has joined #bitcoin-core-dev
6082018-05-07T21:46:34  *** moneyball has joined #bitcoin-core-dev
6092018-05-07T21:48:03  *** arowser_ has quit IRC
6102018-05-07T21:48:20  *** arowser_ has joined #bitcoin-core-dev
6112018-05-07T21:53:15  *** arowser_ has quit IRC
6122018-05-07T21:53:31  *** arowser_ has joined #bitcoin-core-dev
6132018-05-07T21:55:57  *** moneyball has quit IRC
6142018-05-07T21:56:14  *** promag has joined #bitcoin-core-dev
6152018-05-07T21:58:36  *** spinza has quit IRC
6162018-05-07T21:59:58  *** promag has quit IRC
6172018-05-07T22:03:05  *** Randolf has quit IRC
6182018-05-07T22:04:27  *** promag has joined #bitcoin-core-dev
6192018-05-07T22:04:32  *** pierre_rochard has quit IRC
6202018-05-07T22:06:07  *** spinza has joined #bitcoin-core-dev
6212018-05-07T22:06:12  *** promag has quit IRC
6222018-05-07T22:06:22  *** pierre_rochard has joined #bitcoin-core-dev
6232018-05-07T22:16:17  *** arubi has quit IRC
6242018-05-07T22:17:00  *** arubi has joined #bitcoin-core-dev
6252018-05-07T22:18:00  *** pierre_rochard has quit IRC
6262018-05-07T22:23:09  <jimpo> Friendly reminder: #12254 is still ready for review
6272018-05-07T22:23:12  <gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
6282018-05-07T22:32:02  <luke-jr> BlueMatt: what timeframe do you need it in? been meaning to rebase/address stuff for a week or so now..
6292018-05-07T22:32:35  *** Victorsueca has quit IRC
6302018-05-07T22:33:48  *** Victorsueca has joined #bitcoin-core-dev
6312018-05-07T22:37:46  *** spinza has quit IRC
6322018-05-07T22:39:07  *** laurentmt has quit IRC
6332018-05-07T22:41:00  *** fanquake has joined #bitcoin-core-dev
6342018-05-07T22:44:28  <satwo> Hi all, wasn't able to get a clear answer in #bitcoin, so thought I'd ask here: Why is nSequence an input-level field while nLockTime is transaction-level, and what happens when there are multiple inputs with different nSequence values?
6352018-05-07T22:44:37  *** spinza has joined #bitcoin-core-dev
6362018-05-07T22:49:57  *** Dizzle has joined #bitcoin-core-dev
6372018-05-07T22:51:06  <luke-jr> satwo: originally, or today?
6382018-05-07T22:53:43  <satwo> luke-jr Today, though if evolution of the protocol would shed light on it I'd be interested in that too.
6392018-05-07T22:53:47  *** Randolf has joined #bitcoin-core-dev
6402018-05-07T22:54:36  *** Randolf has quit IRC
6412018-05-07T22:55:42  *** glaksmono has joined #bitcoin-core-dev
6422018-05-07T22:55:59  *** Randolf has joined #bitcoin-core-dev
6432018-05-07T22:57:32  *** laurentmt has joined #bitcoin-core-dev
6442018-05-07T22:58:27  *** rex4539 has quit IRC
6452018-05-07T23:00:05  *** glaksmono has quit IRC
6462018-05-07T23:02:27  *** arowser_ has quit IRC
6472018-05-07T23:02:44  *** arowser_ has joined #bitcoin-core-dev
6482018-05-07T23:02:56  *** CubicEarths has quit IRC
6492018-05-07T23:03:15  *** CubicEarths has joined #bitcoin-core-dev
6502018-05-07T23:04:04  *** laurentmt has quit IRC
6512018-05-07T23:04:52  <fanquake> eklitzke Any chance you can rebase #12744 ?
6522018-05-07T23:04:54  <gribble> https://github.com/bitcoin/bitcoin/issues/12744 | WIP: eliminate dependency on boost::program_options by eklitzke · Pull Request #12744 · bitcoin/bitcoin · GitHub
6532018-05-07T23:09:46  *** belcher has joined #bitcoin-core-dev
6542018-05-07T23:10:05  *** tryphe has joined #bitcoin-core-dev
6552018-05-07T23:13:05  *** Randolf has quit IRC
6562018-05-07T23:44:46  *** drexl has quit IRC
6572018-05-07T23:45:44  *** m8tion has joined #bitcoin-core-dev
6582018-05-07T23:47:59  *** moneyball has joined #bitcoin-core-dev
6592018-05-07T23:55:39  *** Randolf has joined #bitcoin-core-dev
6602018-05-07T23:58:55  *** brianhoffman has joined #bitcoin-core-dev
6612018-05-07T23:59:25  *** kanzure has quit IRC