1 2018-05-15T00:03:13  <bitcoin-git> [bitcoin] Empact opened pull request #13234: Break circular dependency: chain -> pow -> chain (master...chain-pow-chain) https://github.com/bitcoin/bitcoin/pull/13234
  2 2018-05-15T00:04:58  *** glaksmono has joined #bitcoin-core-dev
  3 2018-05-15T00:09:37  *** glaksmono has quit IRC
  4 2018-05-15T00:12:44  *** BashCo has joined #bitcoin-core-dev
  5 2018-05-15T00:13:45  <gmaxwell> re: 13191  is there no gain from making a 64-byte specalized sha256^2 that is 1-way SSE4?
  6 2018-05-15T00:14:13  *** intcat has quit IRC
  7 2018-05-15T00:17:01  *** intcat has joined #bitcoin-core-dev
  8 2018-05-15T00:17:04  <sipa> gmaxwell: there is a pure C++ one
  9 2018-05-15T00:17:48  <sipa> there is probably a way to combine the advantages of the 1-way SSE4 code and the fixed-64-byte input one
 10 2018-05-15T00:18:19  <sipa> but since that SSE4 code is transpiled intel asm code, it's not trivial
 11 2018-05-15T00:19:10  *** pierre_rochard has quit IRC
 12 2018-05-15T00:24:26  *** honeybadgerdgaf has joined #bitcoin-core-dev
 13 2018-05-15T00:33:21  *** glaksmono has joined #bitcoin-core-dev
 14 2018-05-15T00:37:42  *** jtimon has quit IRC
 15 2018-05-15T00:37:53  *** glaksmono has quit IRC
 16 2018-05-15T00:38:31  *** Victorsueca has quit IRC
 17 2018-05-15T00:39:08  *** fanquake has quit IRC
 18 2018-05-15T00:39:49  *** Victorsueca has joined #bitcoin-core-dev
 19 2018-05-15T00:42:13  *** d9b4bef9 has joined #bitcoin-core-dev
 20 2018-05-15T00:49:07  *** Krellan has quit IRC
 21 2018-05-15T00:54:01  *** Krellan has joined #bitcoin-core-dev
 22 2018-05-15T01:21:55  <gmaxwell> sipa: IIRC the 64-byte specialized non-asm code was a fair bit slower than the sse4 non-64-byte-specialized code when tested before.
 23 2018-05-15T01:30:52  <sipa> gmaxwell: correct, which is why the sse4 1-way non-64 code is used on sse systems when there are no  hashes simultaneously
 24 2018-05-15T01:31:11  <sipa> but a combined sse4-1way-64byte should presumably be even faster
 25 2018-05-15T01:32:27  *** honeybadgerdgaf has quit IRC
 26 2018-05-15T01:33:09  *** promag has quit IRC
 27 2018-05-15T01:34:59  *** honeybadgerdgaf has joined #bitcoin-core-dev
 28 2018-05-15T01:38:49  *** cryptojanitor has joined #bitcoin-core-dev
 29 2018-05-15T01:40:29  <bitcoin-git> [bitcoin] Empact opened pull request #13235: Break circular dependency: init -> * -> init by extracting shutdown.h (master...init-circ-init) https://github.com/bitcoin/bitcoin/pull/13235
 30 2018-05-15T01:47:08  *** glaksmono has joined #bitcoin-core-dev
 31 2018-05-15T01:56:00  *** Randolf has quit IRC
 32 2018-05-15T01:58:04  *** Randolf has joined #bitcoin-core-dev
 33 2018-05-15T01:59:09  *** ohnx has quit IRC
 34 2018-05-15T02:03:40  *** promag has joined #bitcoin-core-dev
 35 2018-05-15T02:07:35  *** Randolf has quit IRC
 36 2018-05-15T02:08:16  *** Randolf has joined #bitcoin-core-dev
 37 2018-05-15T02:08:46  *** CubicEarths has joined #bitcoin-core-dev
 38 2018-05-15T02:34:53  *** Guest94782 has joined #bitcoin-core-dev
 39 2018-05-15T02:48:48  *** Krellan has quit IRC
 40 2018-05-15T02:50:16  *** honeybadgerdgaf has quit IRC
 41 2018-05-15T02:52:50  *** fighterweng has joined #bitcoin-core-dev
 42 2018-05-15T02:53:05  *** honeybadgerdgaf has joined #bitcoin-core-dev
 43 2018-05-15T02:53:26  *** fighterweng has left #bitcoin-core-dev
 44 2018-05-15T02:59:52  *** honeybadgerdgaf has quit IRC
 45 2018-05-15T03:00:50  *** CubicEarths has quit IRC
 46 2018-05-15T03:01:43  *** unholymachine has joined #bitcoin-core-dev
 47 2018-05-15T03:02:25  *** CubicEarths has joined #bitcoin-core-dev
 48 2018-05-15T03:12:23  *** glaksmono has quit IRC
 49 2018-05-15T03:12:52  *** glaksmono has joined #bitcoin-core-dev
 50 2018-05-15T03:14:36  *** CubicEarths has quit IRC
 51 2018-05-15T03:17:22  *** glaksmono has quit IRC
 52 2018-05-15T03:21:38  *** CubicEarths has joined #bitcoin-core-dev
 53 2018-05-15T03:23:31  *** honeybadgerdgaf has joined #bitcoin-core-dev
 54 2018-05-15T03:25:18  *** AaronvanW has joined #bitcoin-core-dev
 55 2018-05-15T03:35:16  *** AaronvanW has quit IRC
 56 2018-05-15T03:50:16  *** honeybadgerdgaf has quit IRC
 57 2018-05-15T03:51:46  *** Victorsueca has quit IRC
 58 2018-05-15T03:53:08  *** Victorsueca has joined #bitcoin-core-dev
 59 2018-05-15T03:54:23  *** honeybadgerdgaf has joined #bitcoin-core-dev
 60 2018-05-15T03:57:44  *** commavir has quit IRC
 61 2018-05-15T03:58:51  *** commavir has joined #bitcoin-core-dev
 62 2018-05-15T04:03:57  *** harrymm has quit IRC
 63 2018-05-15T04:09:59  *** glaksmono has joined #bitcoin-core-dev
 64 2018-05-15T04:14:27  *** glaksmono has quit IRC
 65 2018-05-15T04:14:33  <savantgarde> Thanks promag 🙂
 66 2018-05-15T04:15:21  *** commavir has quit IRC
 67 2018-05-15T04:16:45  *** harrymm has joined #bitcoin-core-dev
 68 2018-05-15T04:19:29  *** honeybadgerdgaf has quit IRC
 69 2018-05-15T04:20:27  *** AaronvanW has joined #bitcoin-core-dev
 70 2018-05-15T04:20:40  *** honeybadgerdgaf has joined #bitcoin-core-dev
 71 2018-05-15T04:24:57  *** AaronvanW has quit IRC
 72 2018-05-15T04:27:53  *** CubicEarths has quit IRC
 73 2018-05-15T04:28:50  *** commavir has joined #bitcoin-core-dev
 74 2018-05-15T04:32:55  *** CryptAxe_ has quit IRC
 75 2018-05-15T04:34:17  *** commavir has quit IRC
 76 2018-05-15T04:38:00  *** CubicEarths has joined #bitcoin-core-dev
 77 2018-05-15T04:38:17  *** cryptojanitor has quit IRC
 78 2018-05-15T04:39:55  *** CryptAxe has joined #bitcoin-core-dev
 79 2018-05-15T04:41:00  *** commavir has joined #bitcoin-core-dev
 80 2018-05-15T04:41:10  *** CubicEar_ has joined #bitcoin-core-dev
 81 2018-05-15T04:42:27  *** CubicEarths has quit IRC
 82 2018-05-15T04:43:52  *** honeybadgerdgaf has quit IRC
 83 2018-05-15T04:44:13  *** honeybadgerdgaf has joined #bitcoin-core-dev
 84 2018-05-15T04:46:17  *** commavir has quit IRC
 85 2018-05-15T04:52:47  *** commavir has joined #bitcoin-core-dev
 86 2018-05-15T04:56:43  *** glaksmono has joined #bitcoin-core-dev
 87 2018-05-15T05:02:21  *** commavir has quit IRC
 88 2018-05-15T05:08:40  *** CubicEar_ has quit IRC
 89 2018-05-15T05:09:15  *** unholymachine has quit IRC
 90 2018-05-15T05:10:39  *** commavir has joined #bitcoin-core-dev
 91 2018-05-15T05:14:33  *** AaronvanW has joined #bitcoin-core-dev
 92 2018-05-15T05:18:57  *** AaronvanW has quit IRC
 93 2018-05-15T05:25:27  *** Randolf has quit IRC
 94 2018-05-15T05:26:26  *** Randolf has joined #bitcoin-core-dev
 95 2018-05-15T05:29:25  *** rex4539 has quit IRC
 96 2018-05-15T05:31:11  *** rex4539 has joined #bitcoin-core-dev
 97 2018-05-15T05:40:56  *** BGL has quit IRC
 98 2018-05-15T05:44:47  *** ken2812221 has quit IRC
 99 2018-05-15T05:45:37  *** ken2812221 has joined #bitcoin-core-dev
100 2018-05-15T05:50:11  *** Krellan has joined #bitcoin-core-dev
101 2018-05-15T05:52:10  *** wumpus has joined #bitcoin-core-dev
102 2018-05-15T05:56:29  *** Krellan has quit IRC
103 2018-05-15T05:59:54  *** wumpus has quit IRC
104 2018-05-15T06:00:19  *** wumpus has joined #bitcoin-core-dev
105 2018-05-15T06:08:39  *** AaronvanW has joined #bitcoin-core-dev
106 2018-05-15T06:13:29  *** AaronvanW has quit IRC
107 2018-05-15T06:24:35  <wumpus> the board running my IRC client died yesterday, so I was gone for a while and have no logs. Currently using a temporary workaround hosting elsewhere. Did I miss anything?
108 2018-05-15T06:25:09  *** glaksmono has quit IRC
109 2018-05-15T06:26:41  <aj> wumpus: bluematt pinged you and fanquake mentioned #13093 at you i think
110 2018-05-15T06:26:43  <gribble> https://github.com/bitcoin/bitcoin/issues/13093 | [0.15] backport: depends qt patches by fanquake · Pull Request #13093 · bitcoin/bitcoin · GitHub
111 2018-05-15T06:28:58  *** glaksmon_ has joined #bitcoin-core-dev
112 2018-05-15T06:33:08  *** isis_ is now known as isis
113 2018-05-15T06:33:26  <wumpus> aj: thanks!
114 2018-05-15T06:33:27  *** glaksmon_ has quit IRC
115 2018-05-15T06:40:51  *** jtimon has joined #bitcoin-core-dev
116 2018-05-15T06:44:31  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/cb7ef312ff34...1618c63095db
117 2018-05-15T06:44:32  <bitcoin-git> bitcoin/0.15 9bb1a16 fanquake: [Depends] Fix Qt build with Xcode 9.2...
118 2018-05-15T06:44:32  <bitcoin-git> bitcoin/0.15 93b9a61 fanquake: depends: Fix Qt build with XCode 9.3...
119 2018-05-15T06:44:33  <bitcoin-git> bitcoin/0.15 1618c63 Wladimir J. van der Laan: Merge #13093: [0.15] backport: depends qt patches...
120 2018-05-15T06:50:43  *** Krellan has joined #bitcoin-core-dev
121 2018-05-15T06:55:38  *** Krellan has quit IRC
122 2018-05-15T07:02:43  *** AaronvanW has joined #bitcoin-core-dev
123 2018-05-15T07:03:07  *** bzb has joined #bitcoin-core-dev
124 2018-05-15T07:07:26  *** dgenr8 has quit IRC
125 2018-05-15T07:07:51  *** AaronvanW has quit IRC
126 2018-05-15T07:08:12  *** dgenr8 has joined #bitcoin-core-dev
127 2018-05-15T07:17:41  *** glaksmono has joined #bitcoin-core-dev
128 2018-05-15T07:18:27  *** Randolf has quit IRC
129 2018-05-15T07:18:40  *** Randolf has joined #bitcoin-core-dev
130 2018-05-15T07:21:21  *** BGL has joined #bitcoin-core-dev
131 2018-05-15T07:23:54  *** bzb has quit IRC
132 2018-05-15T07:27:39  *** promag has quit IRC
133 2018-05-15T07:28:31  *** fanquake has joined #bitcoin-core-dev
134 2018-05-15T07:28:54  <fanquake> thanks aj
135 2018-05-15T07:29:14  <fanquake> wumpus I just assumed you'd finally started to ignore me :p
136 2018-05-15T07:29:55  <wumpus> fanquake: you were talking to a ghost :)
137 2018-05-15T07:31:10  <fanquake> :o well if the real wumpus is back, I think #13234 can go in
138 2018-05-15T07:31:12  <gribble> https://github.com/bitcoin/bitcoin/issues/13234 | Break circular dependency: chain -> pow -> chain by Empact · Pull Request #13234 · bitcoin/bitcoin · GitHub
139 2018-05-15T07:33:19  *** zarez has joined #bitcoin-core-dev
140 2018-05-15T07:36:00  <wumpus> fanquake: the real wumpus, or at least a newly-checked out clone. But I'll take a look.
141 2018-05-15T07:39:10  *** zarez1 has joined #bitcoin-core-dev
142 2018-05-15T07:40:36  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81c533c6f481...3b84ebb5bc0d
143 2018-05-15T07:40:36  <bitcoin-git> bitcoin/master 5b35b92 Ben Woosley: Break circular dependency: chain -> pow -> chain...
144 2018-05-15T07:40:37  <bitcoin-git> bitcoin/master 3b84ebb Wladimir J. van der Laan: Merge #13234: Break circular dependency: chain -> pow -> chain...
145 2018-05-15T07:41:14  *** zarez has quit IRC
146 2018-05-15T07:41:14  *** zarez1 is now known as zarez
147 2018-05-15T07:41:18  <bitcoin-git> [bitcoin] laanwj closed pull request #13234: Break circular dependency: chain -> pow -> chain (master...chain-pow-chain) https://github.com/bitcoin/bitcoin/pull/13234
148 2018-05-15T07:44:23  *** bzb has joined #bitcoin-core-dev
149 2018-05-15T07:45:50  *** gary has joined #bitcoin-core-dev
150 2018-05-15T07:46:13  *** gary is now known as Guest34043
151 2018-05-15T07:49:44  *** Guest34043 has quit IRC
152 2018-05-15T07:51:45  *** glaksmono has quit IRC
153 2018-05-15T07:52:27  *** glaksmono has joined #bitcoin-core-dev
154 2018-05-15T07:56:37  *** glaksmono has quit IRC
155 2018-05-15T08:01:34  *** owowo has quit IRC
156 2018-05-15T08:01:58  *** Victorsueca has quit IRC
157 2018-05-15T08:03:34  *** Victorsueca has joined #bitcoin-core-dev
158 2018-05-15T08:33:00  *** timothy has joined #bitcoin-core-dev
159 2018-05-15T08:33:28  *** jtimon has quit IRC
160 2018-05-15T08:37:20  *** laurentmt has joined #bitcoin-core-dev
161 2018-05-15T08:40:28  *** drizztbsd has joined #bitcoin-core-dev
162 2018-05-15T08:40:30  *** timothy has quit IRC
163 2018-05-15T08:40:53  <bitcoin-git> [bitcoin] kallewoof closed pull request #12966: [WIP] Mempool optimized feerate (master...mempool-optimized-feerate) https://github.com/bitcoin/bitcoin/pull/12966
164 2018-05-15T08:43:20  <kallewoof> wumpus: Is it possible to add #12634 to the high priority list? It would be very helpful in trimming down the output group (bundle address reuse UTXO) PR.
165 2018-05-15T08:43:24  <gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub
166 2018-05-15T08:44:11  *** promag has joined #bitcoin-core-dev
167 2018-05-15T08:50:38  *** AaronvanW has joined #bitcoin-core-dev
168 2018-05-15T08:55:59  *** AaronvanW has quit IRC
169 2018-05-15T08:58:30  <harding> jonasschnelli, wumpus: for the website, the GitHub is setup so that I can't merge my own PRs unless they have an "Approve" review from someone else with commit access.  The following PR numbers there have ACKs from known contributors and so are just waiting for someone besides me with commit access to Approve them: 546, 547, 550, 551, 552, and 553.
170 2018-05-15T09:01:01  *** drizztbsd is now known as timothy
171 2018-05-15T09:02:31  <fanquake> kallewoof I've added it
172 2018-05-15T09:05:32  *** StopAndDecrypt has quit IRC
173 2018-05-15T09:05:46  *** StopAndDecrypt has joined #bitcoin-core-dev
174 2018-05-15T09:05:55  *** StopAndDecrypt has quit IRC
175 2018-05-15T09:05:55  *** StopAndDecrypt has joined #bitcoin-core-dev
176 2018-05-15T09:13:56  <kallewoof> fanquake: Thanks
177 2018-05-15T09:15:14  *** bzb has quit IRC
178 2018-05-15T09:17:01  <murrayn> any chance
179 2018-05-15T09:17:11  <murrayn> of getting some feedback on 12881?
180 2018-05-15T09:17:56  <promag> murrayn: i think it's mergeable
181 2018-05-15T09:18:46  <murrayn> yes i saw your utACK, thanks
182 2018-05-15T09:21:04  <promag> murrayn: np, you can pay me by reviewing #13193 x)
183 2018-05-15T09:21:05  <gribble> https://github.com/bitcoin/bitcoin/issues/13193 | Avoid 2nd mapTx lookup in CTxMemPool::UpdateTransactionsFromBlock by promag · Pull Request #13193 · bitcoin/bitcoin · GitHub
184 2018-05-15T09:21:29  <wumpus> kallewoof: sure - I think it's usually most helpful to discuss the high priority list during the meeting, but we can do it in-between if you're in a hurry. Oh I see someone already added it anyway :)
185 2018-05-15T09:21:50  <wumpus> harding: yes I'm extremely behind on website review, will take a look!
186 2018-05-15T09:22:24  <kallewoof> wumpus: Yeah, I just tend to not be awake 4 am. I am trying to pull it off though. Maybe this week...
187 2018-05-15T09:22:58  <wumpus> kallewoof: yes that's a crazy time, if you can't make it, no problem
188 2018-05-15T09:24:44  <kallewoof> wumpus: It should be doable, but I tend to wake up late. 4 am is usually a few hours after I fall asleep :)
189 2018-05-15T09:26:05  <wumpus> murrayn: I haven't looked at it since my comment about locale-specific functions, will re-review
190 2018-05-15T09:36:23  <wumpus> murrayn: what was your motivation for optimizing bech32::Decode? is this on any critical path?
191 2018-05-15T09:36:51  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13236: break circular dependency: random -> util -> random (master...random_util) https://github.com/bitcoin/bitcoin/pull/13236
192 2018-05-15T09:41:36  <wumpus> harding: looks like the problem is also that people are using ACKs, not the approval system
193 2018-05-15T09:42:24  <wumpus> should probably become routine in that repository that people who utACK/ACK also 'approve' the PR
194 2018-05-15T09:42:40  <wumpus> unfortunately github doesn't count in-text ACKs
195 2018-05-15T09:43:07  <murrayn> promag, i have reviewed 13193
196 2018-05-15T09:43:59  <murrayn> wumpus, the original motivation was just something that caught my eye as an optimization.
197 2018-05-15T09:47:41  <wumpus> murrayn: right, I see your point, but at some point I wonder about the cognitive load of reviewing that a change is correct versus the reason to make it
198 2018-05-15T09:52:50  <wumpus> murrayn: so your conclusion in https://github.com/bitcoin/bitcoin/pull/12881#issuecomment-383039089 is pretty much "it doesn't matter if compiler optimizations are enabled"
199 2018-05-15T09:57:35  *** lio17 has quit IRC
200 2018-05-15T09:59:46  <murrayn> wumpus, yes i see your point re: the cognitive load. in this case the change and its effect is very localized.
201 2018-05-15T10:01:48  <wumpus> there's certainly a place for micro-optimizations, but I'm not sure this is it
202 2018-05-15T10:01:59  *** glaksmono has joined #bitcoin-core-dev
203 2018-05-15T10:01:59  <wumpus> I agree it's a very localized change, sure
204 2018-05-15T10:02:59  <harding> wumpus: true about ACKs versus Approvals, although I think most of the ACKs on those PRs are from people without commit access, so GitHub doesn't wouldn't count their Approves towards unlocking mergability.  That's a bit unfortunate to my mind, as I think it somewhat discourages people who don't alreday have commit access from reviewing.
205 2018-05-15T10:03:50  <wumpus> murrayn: anyhow I'm going to ACK it - but please next time if you optimize, try to find something that is on the critical path (e.g. validation) and can clearly demonstrate improvement
206 2018-05-15T10:04:39  <wumpus> murrayn: and this makes the code somewhat easier to read, that's good
207 2018-05-15T10:05:51  <wumpus> harding: oh, I didn't know only approvals of repo members counted. Maybe we should remove this github-side requirement and leave it up to the committer to count the ACKs?
208 2018-05-15T10:06:59  *** Victorsueca has quit IRC
209 2018-05-15T10:08:35  *** Victorsueca has joined #bitcoin-core-dev
210 2018-05-15T10:09:05  <murrayn> wumpus, ACK. as sipa pointed out, it's not an important function to optimize, so it does come down to readability.
211 2018-05-15T10:09:43  <wumpus> murrayn: apart from validation there's some other things that would benefit from optimization: for example some GUI things with regard to handling lots of transactions/addresses, network code, RPC/web server latency
212 2018-05-15T10:10:02  <wumpus> handling of large wallets
213 2018-05-15T10:10:39  <murrayn> wumpus, i'm working on it, getting my feet wet :-)
214 2018-05-15T10:11:19  <harding> wumpus: I'm in favor of that.  I initially thought it was a security requirement, and it makes sense to me that you'd want to prevent any person from unilaterally pushing to the master branch for a live-deployed website.  But then I realzed how easy it would be to circumvent by creating a secondary account to open PRs from, so I'd prefer to indeed just do the usual 'count PRs from known contributors and ensure there are enough
215 2018-05-15T10:11:19  <harding> given the impact of the PR'.
216 2018-05-15T10:11:24  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b84ebb5bc0d...1d4662f5dcf6
217 2018-05-15T10:11:25  <bitcoin-git> bitcoin/master 60f61f9 murrayn: Tighten up bech32::Decode(); add tests.
218 2018-05-15T10:11:25  <bitcoin-git> bitcoin/master 1d4662f Wladimir J. van der Laan: Merge #12881: Minor optimizations to bech32::Decode(); add tests....
219 2018-05-15T10:12:00  <bitcoin-git> [bitcoin] laanwj closed pull request #12881: Minor optimizations to bech32::Decode(); add tests. (master...bech32_decode) https://github.com/bitcoin/bitcoin/pull/12881
220 2018-05-15T10:15:13  *** marcoagner has joined #bitcoin-core-dev
221 2018-05-15T10:22:33  <wumpus> harding: yes from a security point of view it makes some sense, espeically if only repo members are counted
222 2018-05-15T10:27:57  *** tryphe has joined #bitcoin-core-dev
223 2018-05-15T10:30:00  <wumpus> harding: so are you sure only people with *write access* count, or everyone who is part of the repository team, also read-only members? if the latter we could just add everyone from the bitcoincore organization in it
224 2018-05-15T10:30:47  *** Guyver2 has joined #bitcoin-core-dev
225 2018-05-15T10:32:50  *** vicenteH has joined #bitcoin-core-dev
226 2018-05-15T10:35:09  *** Phoebe68Witting has joined #bitcoin-core-dev
227 2018-05-15T10:38:35  *** harrymm has quit IRC
228 2018-05-15T10:40:08  <harding> wumpus: good question.  The GitHub UI says, "At least 1 approving review is required by reviewers with write access."  Looking deeper at the documentation, it seems to confirm that, and I think that's what I observed for one of MarcoFalke's Approves (that the UI still said I needed a review by someone with write access).
229 2018-05-15T10:41:37  <harding> wumpus: in any case, thanks for all your reviews this morning!
230 2018-05-15T10:42:17  *** commavir has quit IRC
231 2018-05-15T10:42:50  *** commavir has joined #bitcoin-core-dev
232 2018-05-15T10:47:41  *** commavir has quit IRC
233 2018-05-15T10:48:55  *** commavir has joined #bitcoin-core-dev
234 2018-05-15T10:50:24  *** Krellan has joined #bitcoin-core-dev
235 2018-05-15T10:51:32  *** harrymm has joined #bitcoin-core-dev
236 2018-05-15T10:55:12  *** Krellan has quit IRC
237 2018-05-15T10:55:20  *** commavir has quit IRC
238 2018-05-15T10:55:53  *** commavir has joined #bitcoin-core-dev
239 2018-05-15T11:03:00  <wumpus> harding: np, feel free to poke me when you need review for the website again
240 2018-05-15T11:03:37  *** commavir has quit IRC
241 2018-05-15T11:04:27  *** commavir has joined #bitcoin-core-dev
242 2018-05-15T11:06:17  *** mess110 has joined #bitcoin-core-dev
243 2018-05-15T11:06:33  <mess110> hi, can I please get some reviews on https://github.com/bitcoin/bitcoin/pull/11491 ?
244 2018-05-15T11:06:42  *** lio17 has joined #bitcoin-core-dev
245 2018-05-15T11:09:47  *** commavir has quit IRC
246 2018-05-15T11:10:10  <wumpus> mess110: yes
247 2018-05-15T11:10:13  *** jtimon has joined #bitcoin-core-dev
248 2018-05-15T11:10:21  *** aj has quit IRC
249 2018-05-15T11:10:32  *** commavir has joined #bitcoin-core-dev
250 2018-05-15T11:15:15  *** lightningbot has joined #bitcoin-core-dev
251 2018-05-15T11:16:01  *** commavir has quit IRC
252 2018-05-15T11:17:50  <provoostenator> Two PRs with baby steps towards making RBF easier to use: #12096, #12818
253 2018-05-15T11:17:54  <gribble> https://github.com/bitcoin/bitcoin/issues/12096 | [rpc] [wallet] Allow specifying the output index when using bumpfee by kallewoof · Pull Request #12096 · bitcoin/bitcoin · GitHub
254 2018-05-15T11:17:55  <gribble> https://github.com/bitcoin/bitcoin/issues/12818 | [qt] TransactionView: highlight replacement tx after fee bump by Sjors · Pull Request #12818 · bitcoin/bitcoin · GitHub
255 2018-05-15T11:21:07  <bitcoin-git> [bitcoin] Sjors closed pull request #12565: [qt] bumpfee: offer user to reduce output for transactions without change (master...2018/02/qt-bumpfee-reduce-output) https://github.com/bitcoin/bitcoin/pull/12565
256 2018-05-15T11:28:33  *** SopaXorzTaker has joined #bitcoin-core-dev
257 2018-05-15T11:44:42  *** glaksmono has quit IRC
258 2018-05-15T11:45:16  *** glaksmono has joined #bitcoin-core-dev
259 2018-05-15T11:55:15  *** glaksmono has quit IRC
260 2018-05-15T11:55:27  *** glaksmono has joined #bitcoin-core-dev
261 2018-05-15T11:55:59  *** commavir has joined #bitcoin-core-dev
262 2018-05-15T12:17:26  *** AaronvanW has joined #bitcoin-core-dev
263 2018-05-15T12:17:53  *** tryphe has quit IRC
264 2018-05-15T12:18:05  *** Aaronvan_ has joined #bitcoin-core-dev
265 2018-05-15T12:19:48  *** promag has quit IRC
266 2018-05-15T12:19:59  *** tryphe has joined #bitcoin-core-dev
267 2018-05-15T12:21:27  *** AaronvanW has quit IRC
268 2018-05-15T12:34:05  *** JackH has quit IRC
269 2018-05-15T12:39:26  *** CubicEarths has joined #bitcoin-core-dev
270 2018-05-15T12:45:37  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d4662f5dcf6...13da2899ae42
271 2018-05-15T12:45:38  <bitcoin-git> bitcoin/master 244f4ba practicalswift: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending
272 2018-05-15T12:45:38  <bitcoin-git> bitcoin/master 13da289 MarcoFalke: Merge #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending...
273 2018-05-15T12:46:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending (master...m_cs_callbacks_pending) https://github.com/bitcoin/bitcoin/pull/13125
274 2018-05-15T12:49:34  *** cheese_ has quit IRC
275 2018-05-15T12:49:40  *** DougieBot5000 has quit IRC
276 2018-05-15T12:49:56  *** glaksmono has quit IRC
277 2018-05-15T12:50:27  *** DougieBot5000 has joined #bitcoin-core-dev
278 2018-05-15T12:50:30  *** glaksmono has joined #bitcoin-core-dev
279 2018-05-15T12:54:57  *** glaksmono has quit IRC
280 2018-05-15T12:56:48  *** Guyver2 has quit IRC
281 2018-05-15T12:59:29  *** promag has joined #bitcoin-core-dev
282 2018-05-15T13:02:55  *** m8tion_ has joined #bitcoin-core-dev
283 2018-05-15T13:03:31  *** fanquake has quit IRC
284 2018-05-15T13:05:24  *** lari_ has joined #bitcoin-core-dev
285 2018-05-15T13:05:35  *** lari has quit IRC
286 2018-05-15T13:22:49  <promag> I guess could be merged #10757
287 2018-05-15T13:22:55  <gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
288 2018-05-15T13:23:44  <promag> jnewbery: ping
289 2018-05-15T13:29:31  *** tryphe has quit IRC
290 2018-05-15T13:32:15  *** promag has quit IRC
291 2018-05-15T13:35:15  *** Aaronvan_ has quit IRC
292 2018-05-15T13:35:21  *** glaksmono has joined #bitcoin-core-dev
293 2018-05-15T13:41:32  *** m8tion_ has quit IRC
294 2018-05-15T13:50:16  *** marcoagner has quit IRC
295 2018-05-15T13:50:57  *** m8tion has joined #bitcoin-core-dev
296 2018-05-15T13:57:09  <jnewbery> promag: I'm here
297 2018-05-15T13:59:40  *** Sinclair6 has joined #bitcoin-core-dev
298 2018-05-15T14:05:03  *** CubicEarths has quit IRC
299 2018-05-15T14:05:30  *** CubicEarths has joined #bitcoin-core-dev
300 2018-05-15T14:08:47  *** mess110 has quit IRC
301 2018-05-15T14:10:25  *** CubicEarths has quit IRC
302 2018-05-15T14:13:09  *** AaronvanW has joined #bitcoin-core-dev
303 2018-05-15T14:15:49  *** marcoagner has joined #bitcoin-core-dev
304 2018-05-15T14:17:15  *** AaronvanW has quit IRC
305 2018-05-15T14:30:22  *** glaksmono has quit IRC
306 2018-05-15T14:34:32  *** marcoagner has quit IRC
307 2018-05-15T14:41:29  *** promag has joined #bitcoin-core-dev
308 2018-05-15T14:42:50  *** Aliencorpse has quit IRC
309 2018-05-15T14:46:34  <promag> jnewbery: I see you are already checking out #10740
310 2018-05-15T14:46:40  <gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
311 2018-05-15T14:46:57  *** Ishtv4n has joined #bitcoin-core-dev
312 2018-05-15T14:50:10  *** Krellan has joined #bitcoin-core-dev
313 2018-05-15T14:55:07  *** Aliencorpse has joined #bitcoin-core-dev
314 2018-05-15T14:57:17  *** Krellan has quit IRC
315 2018-05-15T15:00:01  *** Guyver2 has joined #bitcoin-core-dev
316 2018-05-15T15:06:31  *** Dyaheon has quit IRC
317 2018-05-15T15:12:56  *** Dyaheon has joined #bitcoin-core-dev
318 2018-05-15T15:17:07  *** Victorsueca has quit IRC
319 2018-05-15T15:18:37  *** Victorsueca has joined #bitcoin-core-dev
320 2018-05-15T15:38:20  *** promag has quit IRC
321 2018-05-15T15:42:19  *** marcoagner has joined #bitcoin-core-dev
322 2018-05-15T15:43:48  *** owowo has joined #bitcoin-core-dev
323 2018-05-15T15:52:00  *** Randolf has quit IRC
324 2018-05-15T15:53:48  *** isis is now known as isis_
325 2018-05-15T16:03:45  *** Ishtv4n has quit IRC
326 2018-05-15T16:08:50  *** promag has joined #bitcoin-core-dev
327 2018-05-15T16:14:50  *** SopaXorzTaker has quit IRC
328 2018-05-15T16:21:01  *** Dizzle has joined #bitcoin-core-dev
329 2018-05-15T16:28:05  *** Randolf has joined #bitcoin-core-dev
330 2018-05-15T16:29:02  *** zarez has quit IRC
331 2018-05-15T16:29:42  *** Dizzle has quit IRC
332 2018-05-15T16:29:53  *** Dizzle has joined #bitcoin-core-dev
333 2018-05-15T16:50:02  <provoostenator> I have two nodes on master and a v0.16.0 which all seem to refuse to relay 1 sat / byte transactions, despite "minrelaytxfee": 0.00010000 ...
334 2018-05-15T16:50:30  *** Randolf has quit IRC
335 2018-05-15T16:51:42  <provoostenator> The nodes on master don't throw any errors when you use the GUI or sendrawtransaction. The 0.16.0 node however compalins that the minimum relay fee isn't met.
336 2018-05-15T16:54:39  <sipa> provoostenator: 0.0001 is 10sat/byte, no?
337 2018-05-15T16:55:21  <sipa> so not relaying 1sat/byte seems expected
338 2018-05-15T16:59:07  <provoostenator> I set maxmempool to something really large, but on the 0.16 node I forgot to remove minrelaytxfee, which indeed set it to 10.
339 2018-05-15T17:06:34  <provoostenator> The other two nodes have 0.000010000, but once I fixed the 0.16.0 node transactions get relayed as expected, so nvm...
340 2018-05-15T17:09:50  *** Victorsueca has quit IRC
341 2018-05-15T17:09:56  *** Dizzle has quit IRC
342 2018-05-15T17:10:30  *** Dizzle has joined #bitcoin-core-dev
343 2018-05-15T17:10:59  *** Victorsueca has joined #bitcoin-core-dev
344 2018-05-15T17:13:47  *** Guest94782 has quit IRC
345 2018-05-15T17:14:07  <provoostenator> Different issue: I'm comparing #12404 with master on a node with 1 GB ram. I didn't confiugre dbcache, yet it OOM'd at  cache=568 MiB (on master as well as my PR)
346 2018-05-15T17:14:09  <gribble> https://github.com/bitcoin/bitcoin/issues/12404 | Prune more aggressively during IBD by Sjors · Pull Request #12404 · bitcoin/bitcoin · GitHub
347 2018-05-15T17:14:41  <provoostenator> Is there room wiggle room above the default 450 MB or could this be a bug?
348 2018-05-15T17:22:45  <sipa> there's a couple hundred MB in other things, yes
349 2018-05-15T17:26:22  *** promag has quit IRC
350 2018-05-15T17:39:34  *** marcoagner has quit IRC
351 2018-05-15T17:39:41  <provoostenator> Wouldn't it be better for dbache to be inclusive of these "other things"? So it would flush when the total hits 450, rather than some unpredicatable(?) point?
352 2018-05-15T17:47:29  *** Samdney has joined #bitcoin-core-dev
353 2018-05-15T17:49:43  *** Dizzle has quit IRC
354 2018-05-15T17:50:57  *** Dizzle has joined #bitcoin-core-dev
355 2018-05-15T17:52:26  *** BashCo has quit IRC
356 2018-05-15T17:53:15  *** BashCo has joined #bitcoin-core-dev
357 2018-05-15T17:53:18  *** promag has joined #bitcoin-core-dev
358 2018-05-15T17:53:39  <provoostenator> It flushed at 716 MB (April 2013), so I'll try dbcache=200 on the 1 GB machine which leave 100 MB margin of error.  This is useful too: https://gist.github.com/laanwj/efe29c7661ce9b6620a7
359 2018-05-15T17:54:28  <provoostenator> (that last number was on a machine with more RAM, I'll keep it running to see where the other peaks are)
360 2018-05-15T18:05:45  *** timothy has quit IRC
361 2018-05-15T18:06:52  *** Randolf has joined #bitcoin-core-dev
362 2018-05-15T18:07:09  <sipa> provoostenator: it's very hard to account for all memory
363 2018-05-15T18:07:25  <sipa> we could include a few easily-accountable things like block headers
364 2018-05-15T18:07:46  <sipa> and i'm generally in favor of ways of making total memory more predictable
365 2018-05-15T18:08:27  <provoostenator> But the log entries say "cache=223.1MiB" so at least that number is known and could be kept below dbcache, right?
366 2018-05-15T18:08:40  <sipa> yes it should be
367 2018-05-15T18:08:42  <provoostenator> (except during the flush itself)
368 2018-05-15T18:08:48  *** Guest37850 has joined #bitcoin-core-dev
369 2018-05-15T18:08:57  <sipa> below dbcache+mempoolsize
370 2018-05-15T18:09:44  <provoostenator> Ah, so setting maxmempool would also make it more predicatable?
371 2018-05-15T18:10:38  <sipa> mempoolsize + dbcache should always be below -maxmempool + -dbcache
372 2018-05-15T18:11:04  <provoostenator> Isn't the mempool empty during IBD?
373 2018-05-15T18:11:24  <sipa> yes, that's the point
374 2018-05-15T18:11:36  <sipa> dbcache can "borrow" the unused mempool memory
375 2018-05-15T18:14:28  <sipa> because during IBD we have mempool memory to spare, and more dbcache helps a lot
376 2018-05-15T18:16:40  *** Guest37850 has quit IRC
377 2018-05-15T18:17:56  <provoostenator> That makes sense. Would be useful to mention that in the -dbcache command documentation.
378 2018-05-15T18:18:54  <provoostenator> Though the "reducing bitcoind memory usage" doc does mention this.
379 2018-05-15T18:30:23  <sipa> sounds good
380 2018-05-15T18:30:32  <sipa> I wasn't aware it wasn't mentioned
381 2018-05-15T18:40:36  *** laurentmt has quit IRC
382 2018-05-15T18:53:14  *** marcoagner has joined #bitcoin-core-dev
383 2018-05-15T18:58:43  *** m8tion has quit IRC
384 2018-05-15T19:02:02  *** rex4539 has joined #bitcoin-core-dev
385 2018-05-15T19:04:15  *** m8tion_ has joined #bitcoin-core-dev
386 2018-05-15T19:19:35  *** promag has quit IRC
387 2018-05-15T19:19:48  *** promag has joined #bitcoin-core-dev
388 2018-05-15T19:33:36  *** promag has quit IRC
389 2018-05-15T19:41:07  *** Victorsueca has quit IRC
390 2018-05-15T19:42:19  *** dx25 has quit IRC
391 2018-05-15T19:42:24  *** Victorsueca has joined #bitcoin-core-dev
392 2018-05-15T19:42:34  *** Guest18565 has joined #bitcoin-core-dev
393 2018-05-15T19:45:28  *** m8tion_ has quit IRC
394 2018-05-15T19:49:35  *** dx25 has joined #bitcoin-core-dev
395 2018-05-15T19:50:22  <BlueMatt> sipa (or whoever): you wanna re-ack-and-merge #13023? then we can tag 16.1rc1 =D
396 2018-05-15T19:50:26  <gribble> https://github.com/bitcoin/bitcoin/issues/13023 | Fix some concurrency issues in ActivateBestChain() by skeees · Pull Request #13023 · bitcoin/bitcoin · GitHub
397 2018-05-15T19:50:55  <BlueMatt> (the fd things I dont think make sense to wait for, they haven't made much progress that I see, unless cfields wants to object)
398 2018-05-15T19:51:17  *** BashCo has quit IRC
399 2018-05-15T19:51:30  <skeees> =)
400 2018-05-15T19:52:54  *** BashCo has joined #bitcoin-core-dev
401 2018-05-15T19:55:42  *** m8tion_ has joined #bitcoin-core-dev
402 2018-05-15T19:59:25  <bitcoin-git> [bitcoin] Empact opened pull request #13239: [moveonly] Fix CConnman template methods to be fully-defined in net.h (master...net-template-methods) https://github.com/bitcoin/bitcoin/pull/13239
403 2018-05-15T20:04:13  *** promag has joined #bitcoin-core-dev
404 2018-05-15T20:06:01  *** sanada has quit IRC
405 2018-05-15T20:07:55  *** BashCo_ has joined #bitcoin-core-dev
406 2018-05-15T20:11:18  *** BashCo has quit IRC
407 2018-05-15T20:19:30  *** BashCo has joined #bitcoin-core-dev
408 2018-05-15T20:20:20  *** BashCo_ has quit IRC
409 2018-05-15T20:24:54  *** BashCo has quit IRC
410 2018-05-15T20:25:16  *** BashCo has joined #bitcoin-core-dev
411 2018-05-15T20:29:02  *** d9b4bef9 has quit IRC
412 2018-05-15T20:30:06  *** BashCo_ has joined #bitcoin-core-dev
413 2018-05-15T20:30:07  *** d9b4bef9 has joined #bitcoin-core-dev
414 2018-05-15T20:31:32  *** Arnes has left #bitcoin-core-dev
415 2018-05-15T20:32:42  *** Dizzle has quit IRC
416 2018-05-15T20:33:41  *** BashCo has quit IRC
417 2018-05-15T20:49:52  *** BashCo has joined #bitcoin-core-dev
418 2018-05-15T20:50:46  *** BashCo_ has quit IRC
419 2018-05-15T20:58:29  *** BashCo has quit IRC
420 2018-05-15T21:10:33  *** luke-jr has quit IRC
421 2018-05-15T21:10:42  *** luke-jr has joined #bitcoin-core-dev
422 2018-05-15T21:25:21  <cfields> BlueMatt: whoops, never ended up getting back to that
423 2018-05-15T21:26:28  <cfields> I'm not too worried though
424 2018-05-15T21:26:45  *** Guyver2 has quit IRC
425 2018-05-15T21:45:28  *** Dizzle has joined #bitcoin-core-dev
426 2018-05-15T21:48:16  *** honeybadgerdgaf has quit IRC
427 2018-05-15T21:51:45  *** honeybadgerdgaf has joined #bitcoin-core-dev
428 2018-05-15T21:59:29  *** honeybadgerdgaf has quit IRC
429 2018-05-15T22:00:39  *** marcoagner has quit IRC
430 2018-05-15T22:09:07  *** intcat has quit IRC
431 2018-05-15T22:11:04  *** CubicEarths has joined #bitcoin-core-dev
432 2018-05-15T22:11:58  *** intcat has joined #bitcoin-core-dev
433 2018-05-15T22:12:58  *** Randolf has quit IRC
434 2018-05-15T22:15:27  *** CubicEarths has quit IRC
435 2018-05-15T22:19:42  <BlueMatt> cfields: yea, I'm not either
436 2018-05-15T22:35:17  *** Randolf has joined #bitcoin-core-dev
437 2018-05-15T22:36:30  *** Dizzle has quit IRC
438 2018-05-15T22:40:18  *** Randolf has quit IRC
439 2018-05-15T22:40:41  *** Randolf has joined #bitcoin-core-dev
440 2018-05-15T22:51:22  *** honeybadgerdgaf has joined #bitcoin-core-dev
441 2018-05-15T22:58:22  *** JackH has joined #bitcoin-core-dev
442 2018-05-15T23:09:23  *** honeybadgerdgaf has quit IRC
443 2018-05-15T23:11:10  *** nickler has quit IRC
444 2018-05-15T23:11:15  *** honeybadgerdgaf has joined #bitcoin-core-dev
445 2018-05-15T23:11:47  *** nickler has joined #bitcoin-core-dev
446 2018-05-15T23:22:45  <bitcoin-git> [bitcoin] Empact opened pull request #13241: scripted-diff: Avoid temporary copies when looping over std::map (master...pair-const-key) https://github.com/bitcoin/bitcoin/pull/13241
447 2018-05-15T23:24:27  *** lnostdal has quit IRC
448 2018-05-15T23:27:04  *** honeybadgerdgaf has quit IRC
449 2018-05-15T23:29:09  *** Lynet has joined #bitcoin-core-dev
450 2018-05-15T23:35:09  *** Victorsueca has quit IRC
451 2018-05-15T23:36:37  *** Victorsueca has joined #bitcoin-core-dev
452 2018-05-15T23:52:09  *** glaksmono has joined #bitcoin-core-dev