1 2018-05-16T00:00:01  *** glaksmono has quit IRC
  2 2018-05-16T00:10:27  *** Randolf has quit IRC
  3 2018-05-16T00:11:08  *** Randolf has joined #bitcoin-core-dev
  4 2018-05-16T00:24:18  *** rex4539 has quit IRC
  5 2018-05-16T00:34:44  <bitcoin-git> [bitcoin] Empact closed pull request #13223: refactor: Extract BnB-specific data from CInputCoin  (master...duplicate-fee-calc) https://github.com/bitcoin/bitcoin/pull/13223
  6 2018-05-16T00:36:54  *** isis_ is now known as isis
  7 2018-05-16T00:45:16  *** ghost43 has quit IRC
  8 2018-05-16T00:45:56  *** ghost43 has joined #bitcoin-core-dev
  9 2018-05-16T00:49:17  *** tryphe has joined #bitcoin-core-dev
 10 2018-05-16T00:53:49  <bitcoin-git> [bitcoin] kallewoof opened pull request #13242: uint256: Remove unnecessary crypto/common.h use (master...uint256-no-crypto) https://github.com/bitcoin/bitcoin/pull/13242
 11 2018-05-16T01:02:02  *** jtimon has quit IRC
 12 2018-05-16T01:02:35  *** dgenr8 has quit IRC
 13 2018-05-16T01:09:37  *** honeybadgerdgaf has joined #bitcoin-core-dev
 14 2018-05-16T01:11:02  *** d9b4bef9 has quit IRC
 15 2018-05-16T01:11:35  *** honeybadgerdgaf has quit IRC
 16 2018-05-16T01:12:08  *** d9b4bef9 has joined #bitcoin-core-dev
 17 2018-05-16T01:14:19  *** honeybadgerdgaf has joined #bitcoin-core-dev
 18 2018-05-16T01:16:28  *** Lynet has quit IRC
 19 2018-05-16T01:16:30  *** Lynet_ has joined #bitcoin-core-dev
 20 2018-05-16T01:18:35  <bitcoin-git> [bitcoin] jimpo opened pull request #13243: Make reusable base class for auxiliary indices (master...index-abstraction) https://github.com/bitcoin/bitcoin/pull/13243
 21 2018-05-16T01:56:50  *** Lynet_ has quit IRC
 22 2018-05-16T02:11:14  *** honeybadgerdgaf has quit IRC
 23 2018-05-16T02:12:37  *** fanquake has joined #bitcoin-core-dev
 24 2018-05-16T02:12:41  *** honeybadgerdgaf has joined #bitcoin-core-dev
 25 2018-05-16T02:12:52  *** cryptojanitor has joined #bitcoin-core-dev
 26 2018-05-16T02:14:16  <fanquake> If we want to tag 0.16.1, can I get some ACKS on #12967
 27 2018-05-16T02:14:19  <gribble> https://github.com/bitcoin/bitcoin/issues/12967 | [0.16] Backports by fanquake · Pull Request #12967 · bitcoin/bitcoin · GitHub
 28 2018-05-16T02:34:43  * kallewoof rubs head at addrman_new_collisions test.
 29 2018-05-16T02:35:21  <kallewoof> It.. assumes that the first 17 IP addresses will not cause a collision. They don't. On little endian machines.
 30 2018-05-16T02:35:41  <kallewoof> It then assumes taht the 18th IP address will collide. And then it assumes that the 19th won't (where Xth = 250.1.1.<X>).
 31 2018-05-16T02:36:52  <kallewoof> No wonder big endian systems would fail the uint256 quick hash stuff. It depended on hashes being a certain way for the tests to succeed. That's not exactly how you test collisions normally. I would totally understand if these hashes were consensus critical somehow.
 32 2018-05-16T02:37:38  <kallewoof> I honestly can't see the purpose of this test at all.
 33 2018-05-16T02:41:48  <sipa> delete it :)
 34 2018-05-16T02:43:38  <kallewoof> sipa: I might! If I can't convince myself they fulfill a purpose.
 35 2018-05-16T02:45:20  <kallewoof> I literally tried changing the IP to 250.1.2.<X> and the tests now fail horribly..
 36 2018-05-16T02:46:21  <kallewoof> These seem to be from an attempt to increase test coverage from a couple of yrs ago or so, according to git blame.
 37 2018-05-16T02:47:13  <kallewoof> Maybe rewrite them to assume that X % of inserted addresses should not cause a collision. That should work on all architectures.
 38 2018-05-16T02:51:15  *** ohnx has joined #bitcoin-core-dev
 39 2018-05-16T02:57:22  *** Krellan has joined #bitcoin-core-dev
 40 2018-05-16T03:02:14  *** Krellan has quit IRC
 41 2018-05-16T03:07:09  <mryandao> hmm, i noticed that the -alertnotify flag is still in the manpages for `bitcoind` -- shouldn't that be removed already since 0.14?
 42 2018-05-16T03:09:11  <mryandao> and what does 'a really long fork' even mean?
 43 2018-05-16T03:11:41  <mryandao> oh nvm, just looked into the src and its basically doing an alert if there's a fork thats >= 6 blocks
 44 2018-05-16T03:14:30  *** unholymachine has joined #bitcoin-core-dev
 45 2018-05-16T03:32:49  *** justanotheruser has quit IRC
 46 2018-05-16T03:43:44  *** honeybadgerdgaf has quit IRC
 47 2018-05-16T03:54:48  *** unholymachine has quit IRC
 48 2018-05-16T04:01:17  *** honeybadgerdgaf has joined #bitcoin-core-dev
 49 2018-05-16T04:28:35  *** honeybadgerdgaf has quit IRC
 50 2018-05-16T04:37:45  *** honeybadgerdgaf has joined #bitcoin-core-dev
 51 2018-05-16T04:47:18  *** AaronvanW has joined #bitcoin-core-dev
 52 2018-05-16T05:00:03  *** rex4539 has joined #bitcoin-core-dev
 53 2018-05-16T05:02:35  *** cryptojanitor has quit IRC
 54 2018-05-16T05:08:02  *** d9b4bef9 has quit IRC
 55 2018-05-16T05:09:08  *** d9b4bef9 has joined #bitcoin-core-dev
 56 2018-05-16T05:17:54  <kallewoof> sipa: I ended up keeping the tests for now. I just checked where big endian would see collisions and changed tests to work on both. These tests are pretty bad, though, but I guess for the sake of coverage, or something.
 57 2018-05-16T05:23:55  *** honeybadgerdgaf has quit IRC
 58 2018-05-16T05:36:18  *** Samdney has quit IRC
 59 2018-05-16T05:36:48  *** AaronvanW has quit IRC
 60 2018-05-16T05:37:48  *** AaronvanW has joined #bitcoin-core-dev
 61 2018-05-16T05:40:57  *** lnostdal has joined #bitcoin-core-dev
 62 2018-05-16T05:42:05  *** AaronvanW has quit IRC
 63 2018-05-16T05:42:50  *** rex4539 has quit IRC
 64 2018-05-16T05:54:05  *** lnostdal has quit IRC
 65 2018-05-16T05:54:45  *** glaksmono has joined #bitcoin-core-dev
 66 2018-05-16T06:32:02  *** AaronvanW has joined #bitcoin-core-dev
 67 2018-05-16T06:38:24  *** AaronvanW has quit IRC
 68 2018-05-16T06:50:19  <jonasschnelli> MarcoFalke: merge with a single ack? https://github.com/bitcoin/bitcoin/pull/13158
 69 2018-05-16T06:54:21  *** Krellan has joined #bitcoin-core-dev
 70 2018-05-16T07:04:49  *** rex4539 has joined #bitcoin-core-dev
 71 2018-05-16T07:07:49  *** promag has quit IRC
 72 2018-05-16T07:08:02  *** promag has joined #bitcoin-core-dev
 73 2018-05-16T07:10:00  *** promag has quit IRC
 74 2018-05-16T07:13:31  *** Ishtv4n has joined #bitcoin-core-dev
 75 2018-05-16T07:14:51  *** timothy has joined #bitcoin-core-dev
 76 2018-05-16T07:22:22  *** drizztbsd has joined #bitcoin-core-dev
 77 2018-05-16T07:22:28  *** timothy has quit IRC
 78 2018-05-16T07:29:13  *** drizztbsd is now known as timothy
 79 2018-05-16T07:43:26  *** zarez has joined #bitcoin-core-dev
 80 2018-05-16T07:51:02  *** zhrek has joined #bitcoin-core-dev
 81 2018-05-16T08:09:14  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/13da2899ae42...40c34a0a29f6
 82 2018-05-16T08:09:14  <bitcoin-git> bitcoin/master 73cd5b2 Cristian Mircea Messel: [gui] Add proxy icon in statusbar
 83 2018-05-16T08:09:15  <bitcoin-git> bitcoin/master 40c34a0 Jonas Schnelli: Merge #11491: [gui] Add proxy icon in statusbar...
 84 2018-05-16T08:09:30  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11491: [gui] Add proxy icon in statusbar (master...add_proxy_icon) https://github.com/bitcoin/bitcoin/pull/11491
 85 2018-05-16T08:14:02  *** Krellan has quit IRC
 86 2018-05-16T08:14:43  *** laurentmt has joined #bitcoin-core-dev
 87 2018-05-16T08:16:38  *** marcoagner has joined #bitcoin-core-dev
 88 2018-05-16T08:20:22  *** AaronvanW has joined #bitcoin-core-dev
 89 2018-05-16T08:21:59  *** Lynet has joined #bitcoin-core-dev
 90 2018-05-16T08:25:06  *** AaronvanW has quit IRC
 91 2018-05-16T08:38:24  *** rex4539 has quit IRC
 92 2018-05-16T08:59:11  *** bhbbh has joined #bitcoin-core-dev
 93 2018-05-16T08:59:28  <bhbbh> join
 94 2018-05-16T09:01:40  *** bhbbh has quit IRC
 95 2018-05-16T09:01:48  *** booyah has quit IRC
 96 2018-05-16T09:14:28  *** AaronvanW has joined #bitcoin-core-dev
 97 2018-05-16T09:19:03  *** AaronvanW has quit IRC
 98 2018-05-16T09:20:04  *** goatpig has joined #bitcoin-core-dev
 99 2018-05-16T09:26:03  *** lnostdal has joined #bitcoin-core-dev
100 2018-05-16T09:50:43  *** setpill has joined #bitcoin-core-dev
101 2018-05-16T09:53:07  *** AaronvanW has joined #bitcoin-core-dev
102 2018-05-16T09:56:04  *** lnostdal has quit IRC
103 2018-05-16T09:57:16  *** AaronvanW has quit IRC
104 2018-05-16T10:02:38  *** AaronvanW has joined #bitcoin-core-dev
105 2018-05-16T10:05:06  *** AaronvanW has quit IRC
106 2018-05-16T10:06:27  *** booyah has joined #bitcoin-core-dev
107 2018-05-16T10:08:24  *** lnostdal has joined #bitcoin-core-dev
108 2018-05-16T10:12:39  *** AaronvanW has joined #bitcoin-core-dev
109 2018-05-16T10:19:47  *** rex4539 has joined #bitcoin-core-dev
110 2018-05-16T10:24:16  *** glaksmono has quit IRC
111 2018-05-16T10:25:24  *** Lynet has quit IRC
112 2018-05-16T10:31:26  *** AaronvanW has quit IRC
113 2018-05-16T10:33:21  *** setpill has quit IRC
114 2018-05-16T10:38:47  *** jtimon has joined #bitcoin-core-dev
115 2018-05-16T10:40:32  *** rex4539 has quit IRC
116 2018-05-16T10:42:54  *** justanotheruser has joined #bitcoin-core-dev
117 2018-05-16T11:20:10  *** promag has joined #bitcoin-core-dev
118 2018-05-16T11:22:43  *** promag has quit IRC
119 2018-05-16T11:22:57  *** promag has joined #bitcoin-core-dev
120 2018-05-16T11:23:42  *** glaksmono has joined #bitcoin-core-dev
121 2018-05-16T11:35:29  *** Victorsueca has quit IRC
122 2018-05-16T11:36:38  *** Victorsueca has joined #bitcoin-core-dev
123 2018-05-16T11:38:13  *** glaksmono has quit IRC
124 2018-05-16T11:38:47  *** glaksmono has joined #bitcoin-core-dev
125 2018-05-16T11:41:32  <bitcoin-git> [bitcoin] laanwj pushed 10 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/9ea62a3dc4bd...feba12fe85e8
126 2018-05-16T11:41:33  <bitcoin-git> bitcoin/0.16 f60e84d e0: Limit the number of IPs we use from each DNS seeder...
127 2018-05-16T11:41:33  <bitcoin-git> bitcoin/0.16 f118a7a 251: Fix illegal default `addProxy` and `addrSeparateProxyTor` settings....
128 2018-05-16T11:41:34  <bitcoin-git> bitcoin/0.16 e802c22 John Newbery: [config] Remove blockmaxsize option...
129 2018-05-16T11:43:18  *** glaksmono has quit IRC
130 2018-05-16T11:49:23  *** laurentmt has quit IRC
131 2018-05-16T11:56:12  *** laurentmt has joined #bitcoin-core-dev
132 2018-05-16T12:05:40  <promag> wumpus: which PR are you looking at?
133 2018-05-16T12:10:31  *** Ishtv4n has quit IRC
134 2018-05-16T12:13:07  *** Ishtv4n has joined #bitcoin-core-dev
135 2018-05-16T12:14:09  *** tryphe has quit IRC
136 2018-05-16T12:16:02  *** tryphe has joined #bitcoin-core-dev
137 2018-05-16T12:31:50  *** glaksmono has joined #bitcoin-core-dev
138 2018-05-16T12:36:15  *** glaksmono has quit IRC
139 2018-05-16T12:44:17  *** AaronvanW has joined #bitcoin-core-dev
140 2018-05-16T12:51:53  *** glaksmono has joined #bitcoin-core-dev
141 2018-05-16T12:53:43  *** Ishtv4n has quit IRC
142 2018-05-16T13:02:24  *** tryphe has quit IRC
143 2018-05-16T13:04:35  *** justanotheruser has quit IRC
144 2018-05-16T13:04:57  *** justan0theruser has joined #bitcoin-core-dev
145 2018-05-16T13:06:19  *** marcoagner has quit IRC
146 2018-05-16T13:06:25  *** AaronvanW has quit IRC
147 2018-05-16T13:06:48  *** CubicEarths has joined #bitcoin-core-dev
148 2018-05-16T13:11:03  *** glaksmono has quit IRC
149 2018-05-16T13:14:11  *** Victorsueca has quit IRC
150 2018-05-16T13:15:37  *** Victorsueca has joined #bitcoin-core-dev
151 2018-05-16T13:17:25  *** glaksmono has joined #bitcoin-core-dev
152 2018-05-16T13:18:31  *** pergaminho has joined #bitcoin-core-dev
153 2018-05-16T13:22:09  *** glaksmono has quit IRC
154 2018-05-16T13:23:50  *** AaronvanW has joined #bitcoin-core-dev
155 2018-05-16T13:25:01  *** CubicEarths has quit IRC
156 2018-05-16T13:25:55  *** pergaminho has quit IRC
157 2018-05-16T13:28:07  *** glaksmono has joined #bitcoin-core-dev
158 2018-05-16T13:29:32  *** pergaminho has joined #bitcoin-core-dev
159 2018-05-16T13:30:31  *** arubi has quit IRC
160 2018-05-16T13:32:29  *** glaksmono has quit IRC
161 2018-05-16T13:33:04  *** glaksmono has joined #bitcoin-core-dev
162 2018-05-16T13:40:34  *** glaksmono has quit IRC
163 2018-05-16T13:40:48  *** glaksmono has joined #bitcoin-core-dev
164 2018-05-16T13:44:10  *** arubi has joined #bitcoin-core-dev
165 2018-05-16T13:49:11  *** Guyver2 has joined #bitcoin-core-dev
166 2018-05-16T14:02:15  *** lnostdal_ has joined #bitcoin-core-dev
167 2018-05-16T14:04:17  *** lnostdal has quit IRC
168 2018-05-16T14:04:40  <jonasschnelli> Q for anyone with leveldb experience (maybe sipa, wumpus): Is there a performance downside of seeking the cursor to a specific key and read the current cursors value rather then just "read" a keys value "directly"?
169 2018-05-16T14:11:08  <wumpus> I wouldn't expect there to be a significant difference, as long as you're looking for an existing key - both have to locate the key in the same way
170 2018-05-16T14:12:09  *** ExtraCrispy has joined #bitcoin-core-dev
171 2018-05-16T14:14:49  <jonasschnelli> wumpus: thanks
172 2018-05-16T14:16:01  <jonasschnelli> I was thinking of storing 1-to-n relations (addressindex; address maps to many txns). Instead of constantly update a single object (read->(update)->write) I though of just reducing to a write operation
173 2018-05-16T14:16:22  <jonasschnelli> Though it will lead to more disk-space being consumed due to the repetitive key-parts
174 2018-05-16T14:18:19  <gmaxwell> I would expect pretty poor performance if you look up a non-existing entry, however. (also implied by wumpus' statement; but thought it was worth making a point of)-- otherwise leveldb is pretty fast for misses.
175 2018-05-16T14:20:06  *** m8tion_ has quit IRC
176 2018-05-16T14:23:46  *** ExtraCrispy has quit IRC
177 2018-05-16T14:30:27  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13246: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13246
178 2018-05-16T14:35:47  *** AaronvanW has quit IRC
179 2018-05-16T14:39:44  *** Deinogalerix21 has joined #bitcoin-core-dev
180 2018-05-16T14:40:48  *** Samdney has joined #bitcoin-core-dev
181 2018-05-16T14:44:35  *** justan0theruser has quit IRC
182 2018-05-16T14:49:12  *** AaronvanW has joined #bitcoin-core-dev
183 2018-05-16T14:52:04  <wumpus> right, the per-ldb bloom filter would be expected to make direct misses fast, but if it still has to look at the next record after the cursor, that will be a slower operation
184 2018-05-16T15:00:54  <jonasschnelli> gmaxwell, wumpus: so for a 1-to-n relation, a exist-check is probably the biggest slowdown (especially for the first entry where the key does not exists). So a single write with hash160-blockkey-txpos is probably faster during indexing...
185 2018-05-16T15:01:29  <jonasschnelli> for a lookup, just set the cursor to the key (hash160) and itterate as long as the key matches the hash160
186 2018-05-16T15:01:46  *** ExtraCrispy has joined #bitcoin-core-dev
187 2018-05-16T15:02:01  <jonasschnelli> lookup may be slower compared to storing the entire serialized object
188 2018-05-16T15:02:36  <jonasschnelli> (though I expect cursor->next() must be pretty fast)
189 2018-05-16T15:03:08  *** fanquake has quit IRC
190 2018-05-16T15:04:29  *** kabaum has joined #bitcoin-core-dev
191 2018-05-16T15:04:52  <jonasschnelli> hmm.. my IDE debugger refuses to debug wallet.cpp since we also have interface/wallet.cpp... meh!
192 2018-05-16T15:05:19  <jonasschnelli> Is that common c++ practice to have same filenames in different subfolders?
193 2018-05-16T15:06:48  *** AaronvanW has quit IRC
194 2018-05-16T15:07:08  *** Victorsueca has quit IRC
195 2018-05-16T15:08:37  *** Victorsueca has joined #bitcoin-core-dev
196 2018-05-16T15:11:39  <ryanofsky> of course it is, i don't think you would use folders at all if filenames were supposed to be globally unique
197 2018-05-16T15:11:59  *** elichai2 has joined #bitcoin-core-dev
198 2018-05-16T15:11:59  <promag> jonasschnelli: should not be a problem
199 2018-05-16T15:12:45  <jonasschnelli> Yes. Your both righ,.. Qt Create dbg/lldb integration is just buggy.
200 2018-05-16T15:12:55  <jonasschnelli> *Qt Creator
201 2018-05-16T15:13:01  *** elichai2 has left #bitcoin-core-dev
202 2018-05-16T15:13:37  *** laurentmt has quit IRC
203 2018-05-16T15:18:17  *** Deinogalerix21 has quit IRC
204 2018-05-16T15:24:21  *** raarr has joined #bitcoin-core-dev
205 2018-05-16T15:30:20  *** m8tion has joined #bitcoin-core-dev
206 2018-05-16T15:31:27  *** glaksmono has quit IRC
207 2018-05-16T15:31:59  *** glaksmono has joined #bitcoin-core-dev
208 2018-05-16T15:36:21  *** glaksmono has quit IRC
209 2018-05-16T15:37:03  *** Guyver2 has quit IRC
210 2018-05-16T15:37:15  *** Guyver2 has joined #bitcoin-core-dev
211 2018-05-16T15:38:55  <wumpus> right, C/C++ has no requirement for filenames to be unique in a project
212 2018-05-16T15:40:35  <wumpus> this would be really difficult to enforce for large projects with a lot of people working on them. Even more, linkers have no concept of 'project-local' so it'd also collide between libraries then.
213 2018-05-16T15:40:57  *** Randolf has quit IRC
214 2018-05-16T15:42:35  *** Randolf has joined #bitcoin-core-dev
215 2018-05-16T15:43:22  <wumpus> (at one employer we did have a requirement that every include file and compilation unit had a unique name; don't know why; but it resulted in everything being prefixed to the point of absurdity; every module had a two/four letter name, and every file had to be prefixed with the concatenated submodule identifiers)
216 2018-05-16T15:47:13  *** Randolf has quit IRC
217 2018-05-16T15:47:24  *** justan0theruser has joined #bitcoin-core-dev
218 2018-05-16T15:47:32  <wumpus> inbefore someone proposes it for the bitcoin repository someone to have a reason to add another linter
219 2018-05-16T15:56:34  *** lei_ has joined #bitcoin-core-dev
220 2018-05-16T15:57:38  *** lei_ has quit IRC
221 2018-05-16T16:00:29  *** Krellan has joined #bitcoin-core-dev
222 2018-05-16T16:06:22  *** justan0theruser has quit IRC
223 2018-05-16T16:09:08  <sipa> like src/a/b/c/a_b_c_file.h?
224 2018-05-16T16:14:12  *** marcoagner has joined #bitcoin-core-dev
225 2018-05-16T16:16:52  *** Randolf has joined #bitcoin-core-dev
226 2018-05-16T16:16:53  <ryanofsky> i don't think that's repetitive enough, maybe src/a/a_b/a_b_c/src_a_b_c_file.h
227 2018-05-16T16:17:30  <sipa> haha
228 2018-05-16T16:22:04  *** lnostdal_ is now known as lnostdal
229 2018-05-16T16:22:11  *** Sinclair6 has quit IRC
230 2018-05-16T16:30:37  *** marcoagner has quit IRC
231 2018-05-16T16:31:01  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/40c34a0a29f6...11e7bdfd903e
232 2018-05-16T16:31:02  <bitcoin-git> bitcoin/master ecc3c4a Matt Corallo: Do not unlock cs_main in ABC unless we've actually made progress....
233 2018-05-16T16:31:02  <bitcoin-git> bitcoin/master a3ae8e6 Jesse Cohen: Fix concurrency-related bugs in ActivateBestChain...
234 2018-05-16T16:31:03  <bitcoin-git> bitcoin/master dd435ad Jesse Cohen: Add unit tests for signals generated by ProcessNewBlock()...
235 2018-05-16T16:31:09  *** marcoagner has joined #bitcoin-core-dev
236 2018-05-16T16:31:45  <bitcoin-git> [bitcoin] laanwj closed pull request #13023: Fix some concurrency issues in ActivateBestChain() (master...event-tests) https://github.com/bitcoin/bitcoin/pull/13023
237 2018-05-16T16:35:57  *** davec has quit IRC
238 2018-05-16T16:40:56  *** justanotheruser has joined #bitcoin-core-dev
239 2018-05-16T16:44:49  <wumpus> yes, that idea, EADGxBLxAP_foowidget.[ch]
240 2018-05-16T16:45:01  *** Sinclair6 has joined #bitcoin-core-dev
241 2018-05-16T17:00:48  *** laurentmt has joined #bitcoin-core-dev
242 2018-05-16T17:01:26  *** isis is now known as isis_
243 2018-05-16T17:07:25  *** Samdney has quit IRC
244 2018-05-16T17:07:25  *** Victorsueca has quit IRC
245 2018-05-16T17:08:38  *** Victorsueca has joined #bitcoin-core-dev
246 2018-05-16T17:09:21  *** timothy has quit IRC
247 2018-05-16T17:10:54  *** Iconate has joined #bitcoin-core-dev
248 2018-05-16T17:15:51  *** glaksmono has joined #bitcoin-core-dev
249 2018-05-16T17:20:46  *** glaksmono has quit IRC
250 2018-05-16T17:24:19  *** davec has joined #bitcoin-core-dev
251 2018-05-16T17:26:34  *** pergaminho has quit IRC
252 2018-05-16T17:32:21  *** glaksmono has joined #bitcoin-core-dev
253 2018-05-16T17:32:29  *** drexl has joined #bitcoin-core-dev
254 2018-05-16T17:36:27  *** glaksmono has quit IRC
255 2018-05-16T17:41:05  *** mistergold has joined #bitcoin-core-dev
256 2018-05-16T17:46:49  *** timothy has joined #bitcoin-core-dev
257 2018-05-16T17:46:55  *** AaronvanW has joined #bitcoin-core-dev
258 2018-05-16T17:52:35  *** timothy has quit IRC
259 2018-05-16T17:59:44  *** Aaronvan_ has joined #bitcoin-core-dev
260 2018-05-16T17:59:48  *** rex4539 has joined #bitcoin-core-dev
261 2018-05-16T18:00:57  *** AaronvanW has quit IRC
262 2018-05-16T18:02:22  *** Aaronvan_ has quit IRC
263 2018-05-16T18:03:12  *** AaronvanW has joined #bitcoin-core-dev
264 2018-05-16T18:08:21  *** Krellan has quit IRC
265 2018-05-16T18:10:06  *** SopaXorzTaker has joined #bitcoin-core-dev
266 2018-05-16T18:11:30  *** glaksmono has joined #bitcoin-core-dev
267 2018-05-16T18:12:22  *** AaronvanW has quit IRC
268 2018-05-16T18:12:40  *** AaronvanW has joined #bitcoin-core-dev
269 2018-05-16T18:14:32  *** mistergold has quit IRC
270 2018-05-16T18:15:25  *** AaronvanW has quit IRC
271 2018-05-16T18:15:35  *** glaksmono has quit IRC
272 2018-05-16T18:16:23  *** AaronvanW has joined #bitcoin-core-dev
273 2018-05-16T18:19:18  *** AaronvanW has quit IRC
274 2018-05-16T18:23:58  *** AaronvanW has joined #bitcoin-core-dev
275 2018-05-16T18:25:04  *** justanotheruser has quit IRC
276 2018-05-16T18:25:27  *** Aaronvan_ has joined #bitcoin-core-dev
277 2018-05-16T18:26:47  *** justanotheruser has joined #bitcoin-core-dev
278 2018-05-16T18:29:05  *** AaronvanW has quit IRC
279 2018-05-16T18:34:50  *** justanotheruser has quit IRC
280 2018-05-16T18:35:17  *** Aaronvan_ has quit IRC
281 2018-05-16T18:39:25  *** marcoagner has quit IRC
282 2018-05-16T18:44:05  *** laurentmt has quit IRC
283 2018-05-16T18:44:30  *** marcoagner has joined #bitcoin-core-dev
284 2018-05-16T18:47:18  *** SopaXorzTaker has quit IRC
285 2018-05-16T18:49:00  *** glaksmono has joined #bitcoin-core-dev
286 2018-05-16T18:49:45  *** justanotheruser has joined #bitcoin-core-dev
287 2018-05-16T18:52:57  *** Randolf has quit IRC
288 2018-05-16T18:53:07  *** m8tion has quit IRC
289 2018-05-16T18:53:19  *** glaksmono has quit IRC
290 2018-05-16T18:54:07  *** Randolf has joined #bitcoin-core-dev
291 2018-05-16T18:54:45  *** AaronvanW has joined #bitcoin-core-dev
292 2018-05-16T19:00:05  *** ken2812221 has quit IRC
293 2018-05-16T19:00:08  *** AaronvanW has quit IRC
294 2018-05-16T19:00:34  *** Krellan has joined #bitcoin-core-dev
295 2018-05-16T19:12:48  *** Deadhand has quit IRC
296 2018-05-16T19:24:35  <BlueMatt> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.16.1 <-- I think we should untag the remaining things and move forward with backports
297 2018-05-16T19:24:36  <BlueMatt> wumpus: ?
298 2018-05-16T19:26:57  *** dx25 has quit IRC
299 2018-05-16T19:28:53  *** isis_ is now known as isis
300 2018-05-16T19:34:05  *** AaronvanW has joined #bitcoin-core-dev
301 2018-05-16T19:37:06  *** glaksmono has joined #bitcoin-core-dev
302 2018-05-16T19:38:05  *** Iconate has quit IRC
303 2018-05-16T19:39:43  <bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/11e7bdfd903e...4cfe17c3382b
304 2018-05-16T19:39:44  <bitcoin-git> bitcoin/master 59b87a2 John Newbery: [wallet] Fix potential memory leak in CreateWalletFromFile...
305 2018-05-16T19:39:44  <bitcoin-git> bitcoin/master 470316c John Newbery: [wallet] setup wallet background flushing in WalletInit directly...
306 2018-05-16T19:39:45  <bitcoin-git> bitcoin/master e0e90db John Newbery: [wallet] Add CWallet::Verify function...
307 2018-05-16T19:39:58  <bitcoin-git> [bitcoin] laanwj closed pull request #10740: [wallet] `loadwallet` RPC - load wallet at runtime (master...load_unload_wallet) https://github.com/bitcoin/bitcoin/pull/10740
308 2018-05-16T19:40:08  <BlueMatt> nice!
309 2018-05-16T19:41:14  <BlueMatt> another easy high-priority-merge-win: #13011 :p
310 2018-05-16T19:41:16  <gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub
311 2018-05-16T19:41:44  *** glaksmono has quit IRC
312 2018-05-16T19:42:18  *** AaronvanW has quit IRC
313 2018-05-16T19:45:51  <promag> yap ^
314 2018-05-16T19:49:33  <bitcoin-git> [bitcoin] skeees opened pull request #13247: Add tests to SingleThreadedSchedulerClient() and document the memory model (master...scheduler-tests) https://github.com/bitcoin/bitcoin/pull/13247
315 2018-05-16T19:50:52  <promag> would be nice to have some reviews in #13097
316 2018-05-16T19:50:55  <gribble> https://github.com/bitcoin/bitcoin/issues/13097 | ui: Support wallets loaded dynamically by promag · Pull Request #13097 · bitcoin/bitcoin · GitHub
317 2018-05-16T19:51:37  <promag> jonasschnelli luke-jr ^
318 2018-05-16T19:54:01  *** marcoagner has quit IRC
319 2018-05-16T19:55:03  *** AaronvanW has joined #bitcoin-core-dev
320 2018-05-16T20:07:52  *** AaronvanW has quit IRC
321 2018-05-16T20:08:05  *** mathwetrust has joined #bitcoin-core-dev
322 2018-05-16T20:21:13  *** AaronvanW has joined #bitcoin-core-dev
323 2018-05-16T20:26:59  *** AaronvanW has quit IRC
324 2018-05-16T20:38:50  *** rex4539 has quit IRC
325 2018-05-16T20:45:02  *** d9b4bef9 has quit IRC
326 2018-05-16T20:46:07  *** d9b4bef9 has joined #bitcoin-core-dev
327 2018-05-16T21:01:30  <phantomcircuit> sipa, flags ^= 1; is sort of confusing in the transaction deserialization function btw
328 2018-05-16T21:04:43  *** glaksmono has joined #bitcoin-core-dev
329 2018-05-16T21:07:10  *** tripleslash is now known as [\\\]
330 2018-05-16T21:08:06  *** Victorsueca has quit IRC
331 2018-05-16T21:09:05  *** glaksmono has quit IRC
332 2018-05-16T21:09:27  *** Victorsueca has joined #bitcoin-core-dev
333 2018-05-16T21:14:38  *** AaronvanW has joined #bitcoin-core-dev
334 2018-05-16T21:18:37  *** AaronvanW has quit IRC
335 2018-05-16T21:18:48  <phantomcircuit> AllocateFileRange seems to fallback to writting 1 byte at a time?
336 2018-05-16T21:19:05  *** AaronvanW has joined #bitcoin-core-dev
337 2018-05-16T21:21:21  *** AaronvanW has quit IRC
338 2018-05-16T21:22:03  *** AaronvanW has joined #bitcoin-core-dev
339 2018-05-16T21:22:44  *** honeybadgerdgaf has joined #bitcoin-core-dev
340 2018-05-16T21:27:50  *** Guyver2 has quit IRC
341 2018-05-16T21:34:06  *** [\\\] is now known as tripleslash
342 2018-05-16T21:46:07  <bitcoin-git> [bitcoin] mess110 opened pull request #13248: [gui] Make proxy icon from statusbar clickable (master...make_proxy_icon_clickable) https://github.com/bitcoin/bitcoin/pull/13248
343 2018-05-16T21:49:30  *** promag has quit IRC
344 2018-05-16T21:53:34  *** honeybadgerdgaf has quit IRC
345 2018-05-16T21:55:41  *** promag has joined #bitcoin-core-dev
346 2018-05-16T21:56:35  *** honeybadgerdgaf has joined #bitcoin-core-dev
347 2018-05-16T22:01:53  <bitcoin-git> [bitcoin] practicalswift opened pull request #13249: Make objects in range declarations immutable by default (master...for-const) https://github.com/bitcoin/bitcoin/pull/13249
348 2018-05-16T22:03:35  *** Randolf has quit IRC
349 2018-05-16T22:04:02  *** AaronvanW has quit IRC
350 2018-05-16T22:10:20  *** goatpig has quit IRC
351 2018-05-16T22:19:45  *** spinza has quit IRC
352 2018-05-16T22:20:55  *** Randolf has joined #bitcoin-core-dev
353 2018-05-16T22:21:21  *** mathwetrust has quit IRC
354 2018-05-16T22:21:45  *** glaksmono has joined #bitcoin-core-dev
355 2018-05-16T22:27:30  *** gaf_ has quit IRC
356 2018-05-16T22:29:53  *** promag has quit IRC
357 2018-05-16T22:30:21  *** gaf_ has joined #bitcoin-core-dev
358 2018-05-16T22:31:22  *** glaksmono has quit IRC
359 2018-05-16T22:31:54  *** glaksmono has joined #bitcoin-core-dev
360 2018-05-16T22:34:12  *** honeybadgerdgaf has quit IRC
361 2018-05-16T22:34:30  *** spinza has joined #bitcoin-core-dev
362 2018-05-16T22:35:40  *** honeybadgerdgaf has joined #bitcoin-core-dev
363 2018-05-16T22:36:05  *** glaksmono has quit IRC
364 2018-05-16T22:36:40  *** Victorsueca has quit IRC
365 2018-05-16T22:37:58  *** Victorsueca has joined #bitcoin-core-dev
366 2018-05-16T22:48:54  *** promag has joined #bitcoin-core-dev
367 2018-05-16T22:50:18  *** promag has quit IRC
368 2018-05-16T22:50:42  <bitcoin-git> [bitcoin] pstratem opened pull request #13250: Simplify ProcessGetBlockData execution (master...2018-05-16-processgetblockdata) https://github.com/bitcoin/bitcoin/pull/13250
369 2018-05-16T22:56:11  <phantomcircuit> ^ but why BlueMatt
370 2018-05-16T22:56:45  <BlueMatt> cause old code got moved, dont blame me
371 2018-05-16T22:57:00  *** honeybadgerdgaf has quit IRC
372 2018-05-16T22:59:41  *** honeybadgerdgaf has joined #bitcoin-core-dev
373 2018-05-16T23:00:31  *** AaronvanW has joined #bitcoin-core-dev
374 2018-05-16T23:01:03  <phantomcircuit> sipa, it's making BlueMatt simpler
375 2018-05-16T23:02:16  <sipa> well please elaborate in the PR description!
376 2018-05-16T23:02:18  *** Victorsueca has quit IRC
377 2018-05-16T23:02:30  *** Victorsueca has joined #bitcoin-core-dev
378 2018-05-16T23:02:34  <sipa> does it decrease the size of his color pallette?
379 2018-05-16T23:05:48  <phantomcircuit> im not sure how that is possible
380 2018-05-16T23:05:52  <phantomcircuit> blue -> blue
381 2018-05-16T23:09:30  <sipa> seriously, please give a better description on your PR
382 2018-05-16T23:10:34  *** Randolf has quit IRC
383 2018-05-16T23:14:33  *** Krellan has quit IRC
384 2018-05-16T23:15:46  *** Krellan has joined #bitcoin-core-dev
385 2018-05-16T23:15:48  *** honeybadgerdgaf has quit IRC
386 2018-05-16T23:17:15  *** honeybadgerdgaf has joined #bitcoin-core-dev
387 2018-05-16T23:21:52  *** Aaronvan_ has joined #bitcoin-core-dev
388 2018-05-16T23:23:05  *** GreatSock has joined #bitcoin-core-dev
389 2018-05-16T23:24:57  *** AaronvanW has quit IRC
390 2018-05-16T23:25:24  *** GreatSock has quit IRC
391 2018-05-16T23:36:48  *** eparham7861 has joined #bitcoin-core-dev
392 2018-05-16T23:37:38  *** eparham7861 has quit IRC
393 2018-05-16T23:42:03  *** dgenr8 has joined #bitcoin-core-dev
394 2018-05-16T23:52:05  *** honeybadgerdgaf has quit IRC
395 2018-05-16T23:56:10  *** StopAndDecrypt has quit IRC
396 2018-05-16T23:56:28  *** drexl has quit IRC