1 2018-06-04T00:10:05  *** rfree_irc has quit IRC
  2 2018-06-04T00:10:05  *** marsadm has quit IRC
  3 2018-06-04T00:17:46  *** jcorgan has quit IRC
  4 2018-06-04T00:19:53  *** m8tion_ has joined #bitcoin-core-dev
  5 2018-06-04T00:23:05  *** m8tion has quit IRC
  6 2018-06-04T00:54:20  *** Aaronvan_ has joined #bitcoin-core-dev
  7 2018-06-04T00:57:05  *** AaronvanW has quit IRC
  8 2018-06-04T01:17:15  *** unholymachine has quit IRC
  9 2018-06-04T01:28:25  <bitcoin-git> [bitcoin] yuntai closed pull request #13365: RPC/REST/ZMQ, Wallet: Set label with importprivkey only requested (master...master) https://github.com/bitcoin/bitcoin/pull/13365
 10 2018-06-04T01:46:48  *** Randolf has joined #bitcoin-core-dev
 11 2018-06-04T01:52:56  *** meshcollider has quit IRC
 12 2018-06-04T01:54:35  *** Chris_Stewart_5 has quit IRC
 13 2018-06-04T02:08:47  *** Aaronvan_ has quit IRC
 14 2018-06-04T02:25:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 15 2018-06-04T02:34:43  *** ToURniQue has quit IRC
 16 2018-06-04T02:55:47  *** Emcy has quit IRC
 17 2018-06-04T02:58:28  <bitcoin-git> [bitcoin] qmma70 opened pull request #13388: util: Implement boolean conversion and !operator for uint_* (master...uint_bool) https://github.com/bitcoin/bitcoin/pull/13388
 18 2018-06-04T03:02:34  *** DrFeelGood has quit IRC
 19 2018-06-04T03:05:20  *** Chris_Stewart_5 has quit IRC
 20 2018-06-04T03:18:27  *** grubles has joined #bitcoin-core-dev
 21 2018-06-04T03:18:57  <mryandao> i actually asked about patch submission via mailing list in response to the takeover rumors.
 22 2018-06-04T03:34:36  *** abcjoe has joined #bitcoin-core-dev
 23 2018-06-04T04:24:40  *** qmma70 has quit IRC
 24 2018-06-04T04:39:06  *** jtimon has quit IRC
 25 2018-06-04T04:46:00  *** jtimon has joined #bitcoin-core-dev
 26 2018-06-04T05:25:30  <wumpus> mryandao: eek I understand now
 27 2018-06-04T05:30:05  <bitcoin-git> [bitcoin] n2yen opened pull request #13389: Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() (master...13371) https://github.com/bitcoin/bitcoin/pull/13389
 28 2018-06-04T05:36:29  <wumpus> mryandao: I don't think there's a hurry to get away from github, but I do think the microsoft takeover is the slow road to obsolence, just like sourceforge, until the service is finally put out of its misery (like happened with microsoft's other code hosting service, codeplex)
 29 2018-06-04T05:38:02  <wumpus> aanyhow maybe we should bring up the host-our-own-gitlab-instance topic again at next meeting
 30 2018-06-04T05:45:01  *** d9b4bef9 has quit IRC
 31 2018-06-04T05:46:11  *** d9b4bef9 has joined #bitcoin-core-dev
 32 2018-06-04T05:46:18  *** abcjoe has quit IRC
 33 2018-06-04T05:50:02  <wumpus> at the least I'm going to cancel my paid github membership as asoon as the announcement goes through, having to pay microsoft-tax with laptops is enough, not going to give them any more money...
 34 2018-06-04T05:53:43  <wumpus> (while I didn't mind supporting a smaller company that simply provides a, generally well-maintained, service)
 35 2018-06-04T05:58:23  *** justan0theruser has joined #bitcoin-core-dev
 36 2018-06-04T06:01:20  *** justanotheruser has quit IRC
 37 2018-06-04T06:03:27  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e24bf1ce184b...f0149330d2f8
 38 2018-06-04T06:03:27  <bitcoin-git> bitcoin/master 1e4eec4 steverusso: doc: split FreeBSD build instructions out of build-unix.md...
 39 2018-06-04T06:03:28  <bitcoin-git> bitcoin/master f014933 Wladimir J. van der Laan: Merge #13372: doc: split FreeBSD build instructions out of build-unix.md...
 40 2018-06-04T06:04:12  <bitcoin-git> [bitcoin] laanwj closed pull request #13372: doc: split FreeBSD build instructions out of build-unix.md (master...link-to-building-on-freebsd) https://github.com/bitcoin/bitcoin/pull/13372
 41 2018-06-04T06:41:06  *** lxer has joined #bitcoin-core-dev
 42 2018-06-04T06:47:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0149330d2f8...2722a1f8e935
 43 2018-06-04T06:47:41  <bitcoin-git> bitcoin/master f41d339 practicalswift: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)
 44 2018-06-04T06:47:42  <bitcoin-git> bitcoin/master 2722a1f Wladimir J. van der Laan: Merge #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)...
 45 2018-06-04T06:48:22  <bitcoin-git> [bitcoin] laanwj closed pull request #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...) (master...remove-dependency-on-lexical_cast-which-is-boost-and-also-throws) https://github.com/bitcoin/bitcoin/pull/13383
 46 2018-06-04T07:29:58  *** bitconner has joined #bitcoin-core-dev
 47 2018-06-04T07:30:46  *** Victorsueca has quit IRC
 48 2018-06-04T07:31:15  *** Victorsueca has joined #bitcoin-core-dev
 49 2018-06-04T07:32:12  *** setpill has joined #bitcoin-core-dev
 50 2018-06-04T07:41:08  *** Guest7379 has quit IRC
 51 2018-06-04T07:42:28  *** da2ce7 has joined #bitcoin-core-dev
 52 2018-06-04T07:51:05  *** Krellan has quit IRC
 53 2018-06-04T07:57:54  <jonasschnelli> roasbeef: what is the reason for using the version byte twice? Once in the enciphered payload and once prepended in plaintext: https://github.com/lightningnetwork/lnd/blob/master/aezeed/cipherseed.go#L39
 54 2018-06-04T08:19:20  *** Randolf has quit IRC
 55 2018-06-04T08:20:19  *** Randolf has joined #bitcoin-core-dev
 56 2018-06-04T08:24:51  *** esotericnonsense has joined #bitcoin-core-dev
 57 2018-06-04T08:26:45  *** ProfMac has joined #bitcoin-core-dev
 58 2018-06-04T08:30:11  *** timothy has joined #bitcoin-core-dev
 59 2018-06-04T08:35:39  *** drizztbsd has joined #bitcoin-core-dev
 60 2018-06-04T08:35:51  *** timothy has quit IRC
 61 2018-06-04T08:54:27  *** vicenteH has joined #bitcoin-core-dev
 62 2018-06-04T08:56:37  *** booyah has quit IRC
 63 2018-06-04T08:57:47  *** booyah has joined #bitcoin-core-dev
 64 2018-06-04T09:00:42  *** Guyver2 has joined #bitcoin-core-dev
 65 2018-06-04T09:02:02  *** promag has joined #bitcoin-core-dev
 66 2018-06-04T09:35:02  *** rex4539_ has joined #bitcoin-core-dev
 67 2018-06-04T09:35:12  *** rex4539 has quit IRC
 68 2018-06-04T09:53:10  *** rex4539_ has quit IRC
 69 2018-06-04T09:59:01  *** d9b4bef9 has quit IRC
 70 2018-06-04T10:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
 71 2018-06-04T10:12:17  <bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/2722a1f8e935...0de7cc848e07
 72 2018-06-04T10:12:18  <bitcoin-git> bitcoin/master 0df0178 Pieter Wuille: Benchmark Merkle root computation
 73 2018-06-04T10:12:18  <bitcoin-git> bitcoin/master 57f3463 Pieter Wuille: Refactor SHA256 code
 74 2018-06-04T10:12:19  <bitcoin-git> bitcoin/master d0c9632 Pieter Wuille: Specialized double sha256 for 64 byte inputs
 75 2018-06-04T10:12:23  *** zhrek` has joined #bitcoin-core-dev
 76 2018-06-04T10:12:56  <bitcoin-git> [bitcoin] laanwj closed pull request #13191: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 (master...201709_dsha256_64) https://github.com/bitcoin/bitcoin/pull/13191
 77 2018-06-04T10:15:35  *** drgrid has joined #bitcoin-core-dev
 78 2018-06-04T10:15:59  *** sturles_ has joined #bitcoin-core-dev
 79 2018-06-04T10:15:59  *** sturles_ has joined #bitcoin-core-dev
 80 2018-06-04T10:16:17  *** asoltys_ has joined #bitcoin-core-dev
 81 2018-06-04T10:16:21  *** earlz_ has joined #bitcoin-core-dev
 82 2018-06-04T10:17:08  *** sturles has quit IRC
 83 2018-06-04T10:17:09  *** sturles_ is now known as sturles
 84 2018-06-04T10:17:11  *** bitbee_ has joined #bitcoin-core-dev
 85 2018-06-04T10:18:26  *** jimpo_ has joined #bitcoin-core-dev
 86 2018-06-04T10:19:14  *** atroxes_ has joined #bitcoin-core-dev
 87 2018-06-04T10:19:19  *** rev_strangehope_ has joined #bitcoin-core-dev
 88 2018-06-04T10:19:21  *** TD--Linux has joined #bitcoin-core-dev
 89 2018-06-04T10:19:39  *** Deadhandd has joined #bitcoin-core-dev
 90 2018-06-04T10:20:33  *** Deadhand has quit IRC
 91 2018-06-04T10:20:33  *** jimpo has quit IRC
 92 2018-06-04T10:20:33  *** spinza has quit IRC
 93 2018-06-04T10:20:33  *** bitbee has quit IRC
 94 2018-06-04T10:20:33  *** TheCharlatan has quit IRC
 95 2018-06-04T10:20:34  *** earlz has quit IRC
 96 2018-06-04T10:20:34  *** zhrek has quit IRC
 97 2018-06-04T10:20:34  *** atroxes has quit IRC
 98 2018-06-04T10:20:34  *** TD-Linux has quit IRC
 99 2018-06-04T10:20:34  *** asoltys has quit IRC
100 2018-06-04T10:20:34  *** rev_strangehope has quit IRC
101 2018-06-04T10:20:36  *** atroxes_ is now known as atroxes
102 2018-06-04T10:23:35  *** owowo has quit IRC
103 2018-06-04T10:24:10  *** Randolf has quit IRC
104 2018-06-04T10:25:38  *** owowo has joined #bitcoin-core-dev
105 2018-06-04T10:25:50  *** Randolf has joined #bitcoin-core-dev
106 2018-06-04T10:26:05  *** bitconner has quit IRC
107 2018-06-04T10:29:08  *** spinza has joined #bitcoin-core-dev
108 2018-06-04T10:31:23  *** bitconner has joined #bitcoin-core-dev
109 2018-06-04T10:31:35  *** AaronvanW has joined #bitcoin-core-dev
110 2018-06-04T10:36:12  *** Aaronvan_ has joined #bitcoin-core-dev
111 2018-06-04T10:36:25  *** bitconner has quit IRC
112 2018-06-04T10:39:38  <promag> is `./test/functional/wallet_multiwallet.py --usecli` working in master?
113 2018-06-04T10:39:53  *** AaronvanW has quit IRC
114 2018-06-04T10:47:22  *** rafalcpp has joined #bitcoin-core-dev
115 2018-06-04T10:49:06  <marcoagner> promag: it's running and passing in master here
116 2018-06-04T10:50:30  <marcoagner> if that's what you're asking
117 2018-06-04T10:57:50  <promag> ty
118 2018-06-04T10:58:11  <wumpus> yep, all the tests are passing on master
119 2018-06-04T10:58:12  <promag> is there a test cache?
120 2018-06-04T10:58:49  <wumpus> what do you mean with a test cache?
121 2018-06-04T11:00:16  <wumpus> I think the only cache used by the tests is a pre-generated blockchain and wallet
122 2018-06-04T11:00:29  <promag> never mind, I'm trying make clean && make
123 2018-06-04T11:08:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
124 2018-06-04T11:22:41  *** justan0theruser has quit IRC
125 2018-06-04T11:26:28  <promag> make clean && ccache -C && make and the test above continues to fail :S
126 2018-06-04T11:27:41  *** promag_ has joined #bitcoin-core-dev
127 2018-06-04T11:27:42  *** promag has quit IRC
128 2018-06-04T11:32:51  *** bitconner has joined #bitcoin-core-dev
129 2018-06-04T11:37:40  *** bitconner has quit IRC
130 2018-06-04T11:39:01  *** domble has quit IRC
131 2018-06-04T11:40:45  *** drizztbsd is now known as timothy
132 2018-06-04T11:44:58  <wumpus> promag_: with what problem?
133 2018-06-04T11:45:36  *** promag_ is now known as promag
134 2018-06-04T11:46:56  <promag> wumpus: https://pastebin.com/Ghy69Ud0
135 2018-06-04T11:47:17  *** bitconner has joined #bitcoin-core-dev
136 2018-06-04T11:52:10  *** bitconner has quit IRC
137 2018-06-04T11:52:22  <wumpus> so it expects "Requested wallet does not exist or is not loaded" but it gets a CalledProcessError
138 2018-06-04T11:53:12  <wumpus> "subprocess.CalledProcessError: Command '/Users/joao/Projects/bitcoin/src/bitcoin-cli' returned non-zero exit status 18."
139 2018-06-04T11:53:48  <wumpus> code 18 is RPC_WALLET_NOT_FOUND
140 2018-06-04T11:54:03  <wumpus> so that looks correct, I'm confused
141 2018-06-04T11:55:32  *** promag has quit IRC
142 2018-06-04T12:00:10  *** SopaXorzTaker has joined #bitcoin-core-dev
143 2018-06-04T12:02:24  *** bitconner has joined #bitcoin-core-dev
144 2018-06-04T12:06:05  *** str4d has quit IRC
145 2018-06-04T12:06:57  *** bitconner has quit IRC
146 2018-06-04T12:09:07  *** Chris_Stewart_5 has quit IRC
147 2018-06-04T12:09:56  *** bitconner has joined #bitcoin-core-dev
148 2018-06-04T12:14:42  *** bitconner has quit IRC
149 2018-06-04T12:15:19  *** promag has joined #bitcoin-core-dev
150 2018-06-04T12:25:17  *** bitconner has joined #bitcoin-core-dev
151 2018-06-04T12:29:57  *** bitconner has quit IRC
152 2018-06-04T12:33:39  <wumpus> promag: just tried to run that test separately here on master (ubuntu 16.04), no issues
153 2018-06-04T12:34:52  *** goatpig has joined #bitcoin-core-dev
154 2018-06-04T12:36:13  <wumpus> promag: not sure what is special about your environment that could trigger this
155 2018-06-04T12:36:37  <promag> wumpus: thanks
156 2018-06-04T12:36:56  <promag> wumpus: I too can't understand why
157 2018-06-04T12:38:38  *** bitconner has joined #bitcoin-core-dev
158 2018-06-04T12:39:03  <wumpus> you could try doing a completely new checkout, then if that passes, compare the difference
159 2018-06-04T12:42:56  <wumpus> if even a new build from a clean tree doesn't pass, it would be extremely confusing
160 2018-06-04T12:43:53  *** bitconner has quit IRC
161 2018-06-04T12:43:54  <promag> right, I hate on this happens
162 2018-06-04T12:43:59  <promag> *when
163 2018-06-04T12:46:47  <wumpus> it's bad, but one level of badness below issues that reproduce on travis but not locally
164 2018-06-04T12:53:32  *** bitconner has joined #bitcoin-core-dev
165 2018-06-04T12:58:09  *** bitconner has quit IRC
166 2018-06-04T13:01:16  *** bitconner has joined #bitcoin-core-dev
167 2018-06-04T13:03:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
168 2018-06-04T13:09:27  *** bitconner has quit IRC
169 2018-06-04T13:14:38  *** bitconner has joined #bitcoin-core-dev
170 2018-06-04T13:19:59  *** bitconner has quit IRC
171 2018-06-04T13:22:09  *** bitconner has joined #bitcoin-core-dev
172 2018-06-04T13:23:26  *** btcdrak has joined #bitcoin-core-dev
173 2018-06-04T13:25:04  <promag> wumpus: git clone, autogen, configure, make, test same error :|
174 2018-06-04T13:25:51  <promag> Python 3.6.5
175 2018-06-04T13:25:58  * wumpus eats his hat
176 2018-06-04T13:26:02  *** kabaum has quit IRC
177 2018-06-04T13:27:08  *** bitconner has quit IRC
178 2018-06-04T13:27:46  <wumpus> promag: what OS?
179 2018-06-04T13:28:09  *** bitconner has joined #bitcoin-core-dev
180 2018-06-04T13:28:11  <promag> wumpus: macos 10.13.3
181 2018-06-04T13:28:43  <wumpus> can't try that, but I see ubuntu 1804 has the same version of python, will try that
182 2018-06-04T13:29:25  <promag> ok, ty
183 2018-06-04T13:29:40  <promag> I'll be back in a bit
184 2018-06-04T13:29:45  *** promag has quit IRC
185 2018-06-04T13:32:35  *** bitconner has quit IRC
186 2018-06-04T13:36:33  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13390: Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node (master...stop_node) https://github.com/bitcoin/bitcoin/pull/13390
187 2018-06-04T13:41:01  *** kabaum has joined #bitcoin-core-dev
188 2018-06-04T13:43:02  *** Aaronvan_ has quit IRC
189 2018-06-04T13:43:23  *** bitconner has joined #bitcoin-core-dev
190 2018-06-04T13:43:38  *** AaronvanW has joined #bitcoin-core-dev
191 2018-06-04T13:43:43  <bitcoin-git> [bitcoin] practicalswift opened pull request #13391: Make tinyformat noexcept: Use default error handling (assert(0 && reason)) on incorrect format strings (master...non-throwing-tinyformat) https://github.com/bitcoin/bitcoin/pull/13391
192 2018-06-04T13:46:19  *** intcat has quit IRC
193 2018-06-04T13:47:57  *** AaronvanW has quit IRC
194 2018-06-04T13:48:41  *** bitconner has quit IRC
195 2018-06-04T13:48:52  *** intcat has joined #bitcoin-core-dev
196 2018-06-04T13:49:23  *** promag has joined #bitcoin-core-dev
197 2018-06-04T13:51:32  *** bitconner has joined #bitcoin-core-dev
198 2018-06-04T13:55:57  *** bitconner has quit IRC
199 2018-06-04T14:03:09  *** ap has joined #bitcoin-core-dev
200 2018-06-04T14:03:31  *** ap is now known as Guest67224
201 2018-06-04T14:04:02  *** bitconner has joined #bitcoin-core-dev
202 2018-06-04T14:09:07  *** bitconner has quit IRC
203 2018-06-04T14:10:00  *** rafalcpp has quit IRC
204 2018-06-04T14:11:07  *** Emcy has joined #bitcoin-core-dev
205 2018-06-04T14:11:39  *** rafalcpp has joined #bitcoin-core-dev
206 2018-06-04T14:12:09  *** AaronvanW has joined #bitcoin-core-dev
207 2018-06-04T14:13:12  <wumpus> pierre_rochard: for some reason, bitcoinacks is not counting my concept ACK here: https://github.com/bitcoin/bitcoin/pull/12136
208 2018-06-04T14:14:44  <pierre_rochard> wumpus: I'm taking a look, it should've picked that up automatically
209 2018-06-04T14:18:52  *** bitconner has joined #bitcoin-core-dev
210 2018-06-04T14:21:03  <bitcoin-git> [bitcoin] practicalswift closed pull request #13391: Make tinyformat noexcept: Use default error handling (assert(0 && reason)) on incorrect format strings (master...non-throwing-tinyformat) https://github.com/bitcoin/bitcoin/pull/13391
211 2018-06-04T14:24:20  *** bitconner has quit IRC
212 2018-06-04T14:25:12  *** bitconner has joined #bitcoin-core-dev
213 2018-06-04T14:26:25  *** pergaminho has joined #bitcoin-core-dev
214 2018-06-04T14:28:01  *** d9b4bef9 has quit IRC
215 2018-06-04T14:29:08  *** d9b4bef9 has joined #bitcoin-core-dev
216 2018-06-04T14:29:22  <pierre_rochard> wumpus: fix is deployed https://bitcoinacks.com/?search=12136
217 2018-06-04T14:29:52  <wumpus> pierre_rochard: thanks!
218 2018-06-04T14:30:11  *** bitconner has quit IRC
219 2018-06-04T14:31:23  *** AaronvanW has quit IRC
220 2018-06-04T14:31:58  *** AaronvanW has joined #bitcoin-core-dev
221 2018-06-04T14:32:50  *** bitconner has joined #bitcoin-core-dev
222 2018-06-04T14:34:41  *** justanotheruser has joined #bitcoin-core-dev
223 2018-06-04T14:36:37  *** AaronvanW has quit IRC
224 2018-06-04T14:37:35  *** bitconner has quit IRC
225 2018-06-04T14:40:22  *** AaronvanW has joined #bitcoin-core-dev
226 2018-06-04T14:45:58  *** bitconner has joined #bitcoin-core-dev
227 2018-06-04T14:46:15  *** jcorgan has joined #bitcoin-core-dev
228 2018-06-04T14:47:10  <jnewbery> promag: seems like the bitcoin-cli stderr is not matching the expected string. See test_node.py L370. I suggest you put a breakpoint in there and see what cli_stderr is set to
229 2018-06-04T14:50:21  <promag> jnewbery: will do
230 2018-06-04T14:50:22  *** callonme10 has quit IRC
231 2018-06-04T14:50:45  *** bitconner has quit IRC
232 2018-06-04T14:56:52  *** drgrid has quit IRC
233 2018-06-04T14:57:46  *** TheCharlatan has joined #bitcoin-core-dev
234 2018-06-04T14:57:58  *** bitconner has joined #bitcoin-core-dev
235 2018-06-04T14:59:16  *** pergaminho has quit IRC
236 2018-06-04T15:04:10  *** bitconner has quit IRC
237 2018-06-04T15:05:56  *** pergaminho has joined #bitcoin-core-dev
238 2018-06-04T15:08:18  *** pergaminho has quit IRC
239 2018-06-04T15:09:41  *** Victorsueca has quit IRC
240 2018-06-04T15:09:54  <wumpus> promag: passed on ubuntu 18.04 with 3.6.5
241 2018-06-04T15:09:59  <wumpus> +python
242 2018-06-04T15:10:06  <promag> right
243 2018-06-04T15:10:23  *** justanotheruser has quit IRC
244 2018-06-04T15:10:54  *** Victorsueca has joined #bitcoin-core-dev
245 2018-06-04T15:11:34  *** bitconner has joined #bitcoin-core-dev
246 2018-06-04T15:12:50  *** jhfrontz has joined #bitcoin-core-dev
247 2018-06-04T15:12:52  <wumpus> so yes makes sense to try to debug this issue locally, it's unlikely we're going to be able to reproduce it
248 2018-06-04T15:13:38  <bitcoin-git> [bitcoin] practicalswift opened pull request #13392: util: Make strprintf noexcept. Improve error message on format string error. (master...strprintf-noexcept) https://github.com/bitcoin/bitcoin/pull/13392
249 2018-06-04T15:17:05  *** bitconner has quit IRC
250 2018-06-04T15:18:22  *** justanotheruser has joined #bitcoin-core-dev
251 2018-06-04T15:18:32  <marcoagner> promag: got curious at lunch and successfully passed the test you're having issue on my other laptop (macos 10.13.4 with python 3.6.5)... no help, it seems.
252 2018-06-04T15:20:13  <wumpus> promag: you don't happen to have a different version of bitcoind running that it, for some reason or bug, runs against?
253 2018-06-04T15:20:25  *** bitconner has joined #bitcoin-core-dev
254 2018-06-04T15:22:26  *** JackH has quit IRC
255 2018-06-04T15:22:48  <jonasschnelli> roasbeef: what is the reason for using the version byte twice? Once in the enciphered payload and once prepended in plaintext: https://github.com/lightningnetwork/lnd/blob/master/aezeed/cipherseed.go#L39
256 2018-06-04T15:23:18  <jonasschnelli> (sry, wanted to post that on #lightning-dev)
257 2018-06-04T15:25:19  *** bitconner has quit IRC
258 2018-06-04T15:28:27  *** bitconner has joined #bitcoin-core-dev
259 2018-06-04T15:33:32  *** bitconner has quit IRC
260 2018-06-04T15:34:53  *** ExtraCrispy has joined #bitcoin-core-dev
261 2018-06-04T15:37:04  <promag> wumpus: jnewbery: marcoagner: fixed :|
262 2018-06-04T15:37:14  <promag> export EVENT_NOKQUEUE=1
263 2018-06-04T15:38:01  <promag> jnewbery: thanks for the tip
264 2018-06-04T15:38:05  *** bitconner has joined #bitcoin-core-dev
265 2018-06-04T15:38:16  <promag> so my stderr has `[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0`
266 2018-06-04T15:42:35  *** bitconner has quit IRC
267 2018-06-04T15:43:39  *** SopaXorzTaker has quit IRC
268 2018-06-04T15:44:08  <wumpus> promag: whoa. GOod find. I'm surprised you get that warning only for that test thoug!
269 2018-06-04T15:45:04  *** promag has quit IRC
270 2018-06-04T15:45:38  *** bitconner has joined #bitcoin-core-dev
271 2018-06-04T15:46:42  *** JRob has joined #bitcoin-core-dev
272 2018-06-04T15:47:31  *** promag has joined #bitcoin-core-dev
273 2018-06-04T15:48:43  *** Randolf has quit IRC
274 2018-06-04T15:49:59  *** promag has quit IRC
275 2018-06-04T15:50:27  *** bitconner has quit IRC
276 2018-06-04T15:56:34  *** bitconner has joined #bitcoin-core-dev
277 2018-06-04T16:01:47  *** bitconner has quit IRC
278 2018-06-04T16:02:52  *** btcdrak has quit IRC
279 2018-06-04T16:08:22  *** setpill has quit IRC
280 2018-06-04T16:08:53  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13390: Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node (master...stop_node) https://github.com/bitcoin/bitcoin/pull/13390
281 2018-06-04T16:10:28  *** bitconner has joined #bitcoin-core-dev
282 2018-06-04T16:15:15  *** bitconner has quit IRC
283 2018-06-04T16:19:26  <bitcoin-git> [bitcoin] ken2812221 reopened pull request #13390: Tests: Ignore RemoteDisconnected and BadStatusLine when stopping node (master...stop_node) https://github.com/bitcoin/bitcoin/pull/13390
284 2018-06-04T16:22:43  <cfields> wumpus: that's just libevent falling back to poll(), as kqueue was known-buggy for 1 or 2 major macOS releases.
285 2018-06-04T16:24:17  *** rafalcpp has quit IRC
286 2018-06-04T16:25:05  *** bitconner has joined #bitcoin-core-dev
287 2018-06-04T16:31:02  *** Krellan has joined #bitcoin-core-dev
288 2018-06-04T16:32:59  *** bitconner has quit IRC
289 2018-06-04T16:33:06  <wumpus> cfields: we should probably make sure that that warning is silenced, at least for the tests
290 2018-06-04T16:34:04  <cfields> wumpus: I believe it should be fed to the logger. Maybe we don't have the libevent log callbacks hooked up for the tests?
291 2018-06-04T16:35:07  *** gribble has quit IRC
292 2018-06-04T16:39:29  *** bitconner has joined #bitcoin-core-dev
293 2018-06-04T16:39:51  <wumpus> cfields: we don't set up a logger at all in bitcoin-cli
294 2018-06-04T16:40:05  <wumpus> cfields: (and this is in a --with-cli test)
295 2018-06-04T16:40:15  <cfields> wumpus: ahh, I missed that this was with -cli!
296 2018-06-04T16:40:58  <cfields> yep, that's the problem then. Need to event_set_log_callback() there.
297 2018-06-04T16:42:10  *** Chris_Stewart_5 has quit IRC
298 2018-06-04T16:43:57  *** bitconner has quit IRC
299 2018-06-04T16:45:52  *** Randolf has joined #bitcoin-core-dev
300 2018-06-04T16:47:41  *** gribble has joined #bitcoin-core-dev
301 2018-06-04T16:48:42  *** timothy has quit IRC
302 2018-06-04T16:49:47  *** bitconner has joined #bitcoin-core-dev
303 2018-06-04T16:52:53  <wumpus> cfields: where to send the output though? or just drop it
304 2018-06-04T16:53:36  <cfields> wumpus: iirc it makes a distinction between errors and warnings. For -cli I suppose we could just drop warnings?
305 2018-06-04T16:54:44  *** bitconner has quit IRC
306 2018-06-04T16:55:15  *** roidster has joined #bitcoin-core-dev
307 2018-06-04T16:57:02  <echeveria> kind of feels like the extra transaction pool default should be slightly higher
308 2018-06-04T16:57:23  <echeveria> I'm getting a lot of compact block value out of doubling it, without an enormous memory usage hit.
309 2018-06-04T16:57:27  <wumpus> cfields: seems it indeed passes in a severity, so it's possible to distinguish. I think it's fine to drop warnings for bitcoin-cli.
310 2018-06-04T16:58:15  <wumpus> cfields: though I'm happy this goes to stderr, not stdout, at least it won't corrupt the output!
311 2018-06-04T16:58:36  *** lnostdal has quit IRC
312 2018-06-04T16:58:48  <cfields> heh yes, that's nice
313 2018-06-04T16:58:49  <wumpus> would be kind of messed-up for RPCs that only return a string, and suddenly it has some silly libevent warning in it
314 2018-06-04T16:59:26  <cfields> wumpus: I'll PR a quick change to ignore warnings and abort on errors (as I assume it would do now anyway)
315 2018-06-04T16:59:53  *** Krellan has quit IRC
316 2018-06-04T17:00:28  *** bitconner has joined #bitcoin-core-dev
317 2018-06-04T17:03:59  <wumpus> cfields: sgtm
318 2018-06-04T17:04:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
319 2018-06-04T17:05:13  *** bitconner has quit IRC
320 2018-06-04T17:07:57  *** bitconner has joined #bitcoin-core-dev
321 2018-06-04T17:11:53  *** lnostdal has joined #bitcoin-core-dev
322 2018-06-04T17:13:02  *** bitconner has quit IRC
323 2018-06-04T17:15:51  *** Dizzle has joined #bitcoin-core-dev
324 2018-06-04T17:18:49  <luke-jr> echeveria: comparing two nodes running at the same time?
325 2018-06-04T17:18:55  <luke-jr> or different times?
326 2018-06-04T17:19:17  *** bitconner has joined #bitcoin-core-dev
327 2018-06-04T17:20:39  *** promag has joined #bitcoin-core-dev
328 2018-06-04T17:23:55  *** bitconner has quit IRC
329 2018-06-04T17:26:33  <echeveria> luke-jr: comparing two nods, but only visually looking at the logs for now.
330 2018-06-04T17:27:24  <luke-jr> right, I just mean time the transactions/blocks were received (ie, comparing the same circumstances)
331 2018-06-04T17:27:46  *** laurentmt has joined #bitcoin-core-dev
332 2018-06-04T17:28:16  <luke-jr> echeveria: want to make a PR and I can throw it in Knots 0.16.1 to give it some more real-world exposure? ;)
333 2018-06-04T17:30:31  *** laurentmt has quit IRC
334 2018-06-04T17:30:51  *** promag has quit IRC
335 2018-06-04T17:31:51  *** bitconner has joined #bitcoin-core-dev
336 2018-06-04T17:54:58  *** marcoagner has quit IRC
337 2018-06-04T18:03:01  *** vicenteH has quit IRC
338 2018-06-04T18:04:28  *** SopaXorzTaker has joined #bitcoin-core-dev
339 2018-06-04T18:06:53  *** m8tion_ has quit IRC
340 2018-06-04T18:07:26  *** lnostdal has quit IRC
341 2018-06-04T18:08:01  *** mistergold has joined #bitcoin-core-dev
342 2018-06-04T18:20:24  *** lnostdal has joined #bitcoin-core-dev
343 2018-06-04T18:22:01  *** d9b4bef9 has quit IRC
344 2018-06-04T18:23:09  *** d9b4bef9 has joined #bitcoin-core-dev
345 2018-06-04T18:25:51  *** marcoagner has joined #bitcoin-core-dev
346 2018-06-04T18:28:45  *** SopaXorzTaker has quit IRC
347 2018-06-04T18:29:14  *** SopaXorzTaker has joined #bitcoin-core-dev
348 2018-06-04T18:33:19  <bitcoin-git> [bitcoin] sipa opened pull request #13393: Enable double-SHA256-for-64-byte code on 32-bit x86 (master...201806_dsha256_i386) https://github.com/bitcoin/bitcoin/pull/13393
349 2018-06-04T18:36:19  <gmaxwell> sipa: I thought there was intel core stuff that had SSE4 but not 64-bit?
350 2018-06-04T18:37:01  <sipa> gmaxwell: perhaps, let me check!
351 2018-06-04T18:37:40  <gmaxwell> echeveria: if you felt board you could do a bit of code copying, and keep an extra cache of each size...
352 2018-06-04T18:37:58  <echeveria> hm, yeah
353 2018-06-04T18:38:07  <echeveria> can simulate misses
354 2018-06-04T18:38:10  <sipa> gmaxwell: they were introduced in Penryn, which supports x86_64
355 2018-06-04T18:38:22  <sipa> perhaps SSE4 was later 'backported' to 32-bit CPU lines, though
356 2018-06-04T18:38:55  <gmaxwell> Also technically our SSE4 code before was SSSE3, I dunno if thats the case for the new stuff.
357 2018-06-04T18:39:20  <gmaxwell> (and I do have a cpu here which is SSSE3 and not SSE4 and I did try our old SSE4 code on it)
358 2018-06-04T18:40:22  <sipa> hmm, can you try the new code?
359 2018-06-04T18:40:35  *** lnostdal has quit IRC
360 2018-06-04T18:42:12  *** lnostdal has joined #bitcoin-core-dev
361 2018-06-04T18:43:12  <luke-jr> hmm, I wonder if I should make a 32-bit chroot to test this on then
362 2018-06-04T18:43:30  <luke-jr> SSSE3 does NOT work correctly on Haswell CPUs running in 32-bit mode
363 2018-06-04T18:43:36  <luke-jr> even though the CPU claims to support it
364 2018-06-04T18:43:56  <luke-jr> (possibly an ABI/alignment issue)
365 2018-06-04T18:45:00  <luke-jr> but that's assuming the new code is still SSSE3 at all.. :P
366 2018-06-04T18:49:40  *** earlz_ is now known as earlz
367 2018-06-04T18:51:13  *** MagicZ has joined #bitcoin-core-dev
368 2018-06-04T18:52:12  *** promag has joined #bitcoin-core-dev
369 2018-06-04T18:59:18  <jonasschnelli> Before:
370 2018-06-04T18:59:18  <jonasschnelli> SHA256, 5, 340, 3.79253, 0.00222458, 0.00224373, 0.00222941
371 2018-06-04T18:59:26  <jonasschnelli> Current master:
372 2018-06-04T18:59:26  <jonasschnelli> SHA256, 5, 340, 3.85136, 0.00224624, 0.00227539, 0.00226702
373 2018-06-04T19:00:35  <sipa> jonasschnelli: use the Merkle branchmark or SHA256D64 benchmark
374 2018-06-04T19:00:47  <jonasschnelli> SHA256D64_1024, 5, 7400, 3.54442, 9.52022e-05, 9.65184e-05, 9.57865e-05
375 2018-06-04T19:00:53  <bitcoin-git> [bitcoin] theuni opened pull request #13394: cli: Ignore libevent warnings (master...cli-event) https://github.com/bitcoin/bitcoin/pull/13394
376 2018-06-04T19:01:02  <sipa> the normal SHA256 isn't affected by #13191
377 2018-06-04T19:01:05  *** drexl has joined #bitcoin-core-dev
378 2018-06-04T19:01:06  <gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub
379 2018-06-04T19:01:14  <jonasschnelli> sipa: Yes. Right. SSE4 was enabled before..
380 2018-06-04T19:02:45  *** str4d has joined #bitcoin-core-dev
381 2018-06-04T19:05:32  *** SopaXorzTaker has quit IRC
382 2018-06-04T19:09:01  *** promag has quit IRC
383 2018-06-04T19:15:24  *** TD--Linux is now known as TD-Linux
384 2018-06-04T19:15:24  *** TD-Linux has joined #bitcoin-core-dev
385 2018-06-04T19:15:45  <roasbeef> jonasschnelli: external version for how to decipher the thing in the first place, internal version tells wallet what scheme was used to derive the set of addrs
386 2018-06-04T19:16:21  <jonasschnelli> roasbeef: I see. Thanks!
387 2018-06-04T19:17:08  <gmaxwell> sipa: I can but it'll be a bit since that computer is in a box right now.
388 2018-06-04T19:19:30  <gmaxwell> echeveria: At least a few weeks ago I was watching it and almost never seeing hits out of my ordinary sized extrapool... but that might have just been because it was a bit too small.
389 2018-06-04T19:22:42  <echeveria> 2018-06-04 18:15:44.495322 Successfully reconstructed block 00000000000000000037acbd8ccb51a8f09222800eab38f30c89bbe48ade3925 with 1 txn prefilled, 2075 txn from mempool (incl at least 13 from extra pool) and 16 txn requested
390 2018-06-04T19:22:56  <echeveria> 2018-06-04 18:06:29.634709 Successfully reconstructed block 0000000000000000000e62f80def774b415e812da4473cdb49f3ba56ea0f1865 with 1 txn prefilled, 343 txn from mempool (incl at least 11 from extra pool) and 332 txn requested
391 2018-06-04T19:22:57  <echeveria> woof.
392 2018-06-04T19:23:07  <gmaxwell> oh man, yea thats pretty good
393 2018-06-04T19:23:57  <echeveria> yeah I'll collect some proper stats.
394 2018-06-04T19:24:34  <echeveria> a lot of the time I'm getting complete reconstructions which is nice. the node is running on a core i3 box that's mega underpowered, intentionally to see how it'll run.
395 2018-06-04T19:29:09  *** twistedline has quit IRC
396 2018-06-04T19:31:35  <gmaxwell> sipa: should call for someone to try out 13386 on shani supporting intel, ... they only have it on some atom cpus.
397 2018-06-04T19:32:10  <sipa> i know; Goldmont only
398 2018-06-04T19:32:28  <gmaxwell> not that its that important but it would be interesting to see numbers.
399 2018-06-04T19:32:56  <echeveria> I looked around a while ago and couldn't find anything easy to get my hands on with a goldmont chip
400 2018-06-04T19:33:04  *** promag has joined #bitcoin-core-dev
401 2018-06-04T19:33:15  <echeveria> works on my rizen 7 server though.
402 2018-06-04T19:33:20  *** twistedline has joined #bitcoin-core-dev
403 2018-06-04T19:34:07  <gmaxwell> I assume DO or some other hosting provider is using goldmonts in vpses.
404 2018-06-04T19:34:33  <echeveria> they're larger x86 cores for DO and ScaleWay.
405 2018-06-04T19:34:42  <gmaxwell> (since basically thats the target application for that chip, AFAICT)
406 2018-06-04T19:35:03  <echeveria> ScaleWay has armv7 servers which is vaguely interesting, I run an edge router node on one of their ARM boxes.
407 2018-06-04T19:40:18  *** promag has quit IRC
408 2018-06-04T19:49:28  <luke-jr> what is the cpuinfo entry for shani?
409 2018-06-04T19:50:57  <luke-jr> a: sha_ni
410 2018-06-04T19:53:05  *** kabaum has quit IRC
411 2018-06-04T19:55:05  *** MagicZ has quit IRC
412 2018-06-04T19:56:21  <sipa> luke-jr: sha ?
413 2018-06-04T19:57:22  <sipa> sha_ni, indeed
414 2018-06-04T19:57:25  <sipa> on my Ryzen
415 2018-06-04T19:59:37  *** vicenteH has joined #bitcoin-core-dev
416 2018-06-04T20:02:45  *** opdenkamp has joined #bitcoin-core-dev
417 2018-06-04T20:07:58  *** kabaum has joined #bitcoin-core-dev
418 2018-06-04T20:18:41  *** Randolf has quit IRC
419 2018-06-04T20:21:45  *** Randolf has joined #bitcoin-core-dev
420 2018-06-04T20:25:24  *** promag has joined #bitcoin-core-dev
421 2018-06-04T20:34:23  *** jhfrontz has quit IRC
422 2018-06-04T20:46:10  *** Guyver2 has quit IRC
423 2018-06-04T20:46:58  *** jhfrontz has joined #bitcoin-core-dev
424 2018-06-04T21:21:08  *** bitconner has joined #bitcoin-core-dev
425 2018-06-04T21:28:10  *** bitconner has quit IRC
426 2018-06-04T21:30:02  *** nullptr| has quit IRC
427 2018-06-04T21:32:10  *** str4d has quit IRC
428 2018-06-04T21:36:53  *** nullptr| has joined #bitcoin-core-dev
429 2018-06-04T21:44:10  *** lukedashjr has joined #bitcoin-core-dev
430 2018-06-04T21:44:10  *** luke-jr has quit IRC
431 2018-06-04T21:47:34  *** lukedashjr is now known as luke-jr
432 2018-06-04T21:49:28  *** zautomata has joined #bitcoin-core-dev
433 2018-06-04T21:50:23  *** zautomata has quit IRC
434 2018-06-04T21:50:23  *** zautomata has joined #bitcoin-core-dev
435 2018-06-04T21:54:52  <cfields> sipa: taking an optim from the intel sha2 whitepaper gives me a ~6% speedup on the SHA256D64_1024 bench, using sse4 (no avx2 here :( )
436 2018-06-04T21:55:01  <cfields> paper: https://www.intel.com/content/dam/www/public/us/en/documents/white-papers/sha-256-implementations-paper.pdf
437 2018-06-04T21:55:28  <cfields> changes: https://github.com/theuni/bitcoin/commits/sha2-avx1 (top two, very simple)
438 2018-06-04T21:56:09  <cfields> I assume it would benefit the avx2 impl the same way, but can't test
439 2018-06-04T21:56:36  <sipa> cfields: oh, nice
440 2018-06-04T22:00:15  *** Randolf has quit IRC
441 2018-06-04T22:03:07  *** Chris_Stewart_5 has quit IRC
442 2018-06-04T22:03:53  <sipa> cfields: testing
443 2018-06-04T22:05:58  <sipa> cfields: makes it slower for me
444 2018-06-04T22:06:19  <sipa> 3.5% slower
445 2018-06-04T22:07:31  <cfields> sipa: huh. Is that sse4, or did you merge it into avx2?
446 2018-06-04T22:07:52  <sipa> i merged it into avx2
447 2018-06-04T22:08:55  <cfields> sipa: is it slower for the sse4 path on your cpu too?
448 2018-06-04T22:24:50  <sipa> cfields: 5% speedup for SSE4
449 2018-06-04T22:24:57  <sipa> (when disabling AVX2 in both)
450 2018-06-04T22:25:00  <sipa> so go for it
451 2018-06-04T22:25:05  <cfields> ok, so I'm not crazy
452 2018-06-04T22:35:35  *** jarthur has joined #bitcoin-core-dev
453 2018-06-04T22:36:09  <jarthur> gmaxwell sipa sorry I haven't had a chance to play with trying the dual SHA-NI on Ryzen yet. Anyone else had a chance to try it yet?
454 2018-06-04T22:44:53  *** Aaronvan_ has joined #bitcoin-core-dev
455 2018-06-04T22:46:40  *** Megumiin has joined #bitcoin-core-dev
456 2018-06-04T22:48:05  *** AaronvanW has quit IRC
457 2018-06-04T22:50:16  *** bitconner has joined #bitcoin-core-dev
458 2018-06-04T23:00:47  *** mistergold has quit IRC
459 2018-06-04T23:01:01  *** ttes23 has joined #bitcoin-core-dev
460 2018-06-04T23:03:37  *** qmma70 has joined #bitcoin-core-dev
461 2018-06-04T23:08:05  *** ttes23 has quit IRC
462 2018-06-04T23:09:37  *** Victorsueca has quit IRC
463 2018-06-04T23:10:54  *** Victorsueca has joined #bitcoin-core-dev
464 2018-06-04T23:10:57  *** lxer has quit IRC
465 2018-06-04T23:13:52  <promag> #13111
466 2018-06-04T23:13:54  <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
467 2018-06-04T23:14:11  <promag> ^ awesome PR to review!..
468 2018-06-04T23:17:50  <sipa> "coredevelopers do not want you to see this awesome trick!"
469 2018-06-04T23:18:43  <promag> :P
470 2018-06-04T23:19:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
471 2018-06-04T23:21:09  *** lxer has joined #bitcoin-core-dev
472 2018-06-04T23:34:34  *** bitconner has quit IRC
473 2018-06-04T23:35:27  *** jarthur has quit IRC
474 2018-06-04T23:35:28  *** Dizzle has quit IRC
475 2018-06-04T23:36:33  *** zautomata has quit IRC
476 2018-06-04T23:37:22  *** bitconner has joined #bitcoin-core-dev
477 2018-06-04T23:41:00  *** lxer has quit IRC
478 2018-06-04T23:46:27  *** drexl has quit IRC
479 2018-06-04T23:47:46  *** zautomata has joined #bitcoin-core-dev
480 2018-06-04T23:50:39  *** zautomata has quit IRC
481 2018-06-04T23:50:39  *** zautomata has joined #bitcoin-core-dev
482 2018-06-04T23:50:46  *** vicenteH has quit IRC
483 2018-06-04T23:51:37  *** Randolf has joined #bitcoin-core-dev