12018-06-07T00:01:44 *** BGL has joined #bitcoin-core-dev
22018-06-07T00:11:10 *** grafcaps has quit IRC
32018-06-07T00:25:28 *** grafcaps has joined #bitcoin-core-dev
42018-06-07T00:25:29 *** ProfMac has quit IRC
52018-06-07T00:25:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
62018-06-07T00:30:56 *** drexl has quit IRC
72018-06-07T00:39:31 *** intcat has quit IRC
82018-06-07T00:41:46 *** intcat has joined #bitcoin-core-dev
92018-06-07T00:44:10 *** Randolf has quit IRC
102018-06-07T00:51:17 *** vicenteH has joined #bitcoin-core-dev
112018-06-07T00:54:25 *** Chris_Stewart_5 has quit IRC
122018-06-07T00:56:58 *** jhfrontz has joined #bitcoin-core-dev
132018-06-07T01:02:46 *** Randolf has joined #bitcoin-core-dev
142018-06-07T01:12:09 *** snickerfritz has quit IRC
152018-06-07T01:12:31 *** snickerfritz has joined #bitcoin-core-dev
162018-06-07T01:13:38 *** snickerfritz has quit IRC
172018-06-07T01:13:43 *** AaronvanW has joined #bitcoin-core-dev
182018-06-07T01:14:01 *** snickerfritz has joined #bitcoin-core-dev
192018-06-07T01:14:07 *** AaronvanW has quit IRC
202018-06-07T01:15:16 *** snickerfritz has quit IRC
212018-06-07T01:15:36 *** snickerfritz has joined #bitcoin-core-dev
222018-06-07T01:16:49 *** Aaronvan_ has quit IRC
232018-06-07T01:22:05 *** snickerfritz has quit IRC
242018-06-07T01:22:27 *** snickerfritz has joined #bitcoin-core-dev
252018-06-07T01:25:10 *** snickerfritz has quit IRC
262018-06-07T01:25:31 *** snickerfritz has joined #bitcoin-core-dev
272018-06-07T01:32:56 *** snickerfritz has quit IRC
282018-06-07T01:33:15 *** snickerfritz has joined #bitcoin-core-dev
292018-06-07T01:35:26 *** cryptojanitor has joined #bitcoin-core-dev
302018-06-07T01:49:39 *** jhfrontz has quit IRC
312018-06-07T01:51:34 <bitcoin-git> [bitcoin] lucash-dev closed pull request #13050: [tests] improvements to slow unit tests (master...slow-unit-tests-improvement) https://github.com/bitcoin/bitcoin/pull/13050
322018-06-07T01:52:16 <promag> MarcoFalke: #13230 needs rebase tag?
332018-06-07T01:52:19 <gribble> https://github.com/bitcoin/bitcoin/issues/13230 | Simplify include analysis by enforcing the developer guides include syntax by practicalswift · Pull Request #13230 · bitcoin/bitcoin · GitHub
342018-06-07T02:01:06 *** promag has quit IRC
352018-06-07T02:10:32 *** jhfrontz has joined #bitcoin-core-dev
362018-06-07T02:13:47 *** fanquake has joined #bitcoin-core-dev
372018-06-07T02:14:54 <fanquake> promag it looks ok to me?
382018-06-07T02:16:15 <fanquake> MarcoFalke is your bot on GH somewhere?
392018-06-07T02:34:02 *** d9b4bef9 has quit IRC
402018-06-07T02:35:09 *** d9b4bef9 has joined #bitcoin-core-dev
412018-06-07T02:41:13 *** jhfrontz has quit IRC
422018-06-07T02:56:24 *** jhfrontz has joined #bitcoin-core-dev
432018-06-07T02:57:54 *** jnewshoes has joined #bitcoin-core-dev
442018-06-07T03:01:50 *** enervey has joined #bitcoin-core-dev
452018-06-07T03:02:50 *** jhfrontz has quit IRC
462018-06-07T03:13:39 *** jhfrontz has joined #bitcoin-core-dev
472018-06-07T03:16:18 *** jhfrontz has quit IRC
482018-06-07T03:31:44 *** JackH has quit IRC
492018-06-07T03:33:40 *** snickerfritz has quit IRC
502018-06-07T03:33:51 *** snickerfritz has joined #bitcoin-core-dev
512018-06-07T04:01:55 *** Krellan has quit IRC
522018-06-07T04:02:54 *** Krellan has joined #bitcoin-core-dev
532018-06-07T04:04:05 *** jhfrontz has joined #bitcoin-core-dev
542018-06-07T04:04:42 *** tryphe_ has joined #bitcoin-core-dev
552018-06-07T04:05:07 *** cryptojanitor has quit IRC
562018-06-07T04:08:10 *** tryphe has quit IRC
572018-06-07T04:08:10 *** grubles has quit IRC
582018-06-07T04:08:38 *** grubles has joined #bitcoin-core-dev
592018-06-07T04:32:36 *** jnewshoes has quit IRC
602018-06-07T04:34:44 *** jnewshoes has joined #bitcoin-core-dev
612018-06-07T04:55:20 *** bitconner has quit IRC
622018-06-07T05:08:32 *** bitconner has joined #bitcoin-core-dev
632018-06-07T05:33:40 *** Randolf has quit IRC
642018-06-07T05:58:31 *** rafalcpp has quit IRC
652018-06-07T06:06:08 *** vicenteH has quit IRC
662018-06-07T06:06:17 *** vicenteH has joined #bitcoin-core-dev
672018-06-07T06:08:03 *** Krellan has quit IRC
682018-06-07T06:09:08 *** Krellan has joined #bitcoin-core-dev
692018-06-07T06:13:37 *** rafalcpp has joined #bitcoin-core-dev
702018-06-07T06:39:45 *** promag has joined #bitcoin-core-dev
712018-06-07T06:41:16 *** fanquake has quit IRC
722018-06-07T06:48:35 <promag> wumpus: #13394 done
732018-06-07T06:48:37 <gribble> https://github.com/bitcoin/bitcoin/issues/13394 | cli: Ignore libevent warnings by theuni · Pull Request #13394 · bitcoin/bitcoin · GitHub
742018-06-07T06:51:24 <wumpus> promag: thanks!
752018-06-07T06:54:05 <promag> cfields: +1
762018-06-07T06:57:15 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4082d59f53d...5779dc4f76ad
772018-06-07T06:57:16 <bitcoin-git> bitcoin/master 0a4ea2f practicalswift: build: Add linter for checking accidental locale dependence
782018-06-07T06:57:16 <bitcoin-git> bitcoin/master 698cfd0 practicalswift: docs: Mention lint-locale-dependence.sh in developer-notes.md
792018-06-07T06:57:17 <bitcoin-git> bitcoin/master 5779dc4 Wladimir J. van der Laan: Merge #13041: build: Add linter checking for accidental introduction of locale dependence...
802018-06-07T06:57:57 <bitcoin-git> [bitcoin] laanwj closed pull request #13041: build: Add linter checking for accidental introduction of locale dependence (master...lint-locale-dependence) https://github.com/bitcoin/bitcoin/pull/13041
812018-06-07T06:59:47 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5779dc4f76ad...e1f8dce9939a
822018-06-07T06:59:47 <bitcoin-git> bitcoin/master 0231ef6 Cory Fields: cli: Ignore libevent warnings
832018-06-07T06:59:48 <bitcoin-git> bitcoin/master e1f8dce Wladimir J. van der Laan: Merge #13394: cli: Ignore libevent warnings...
842018-06-07T07:00:32 <bitcoin-git> [bitcoin] laanwj closed pull request #13394: cli: Ignore libevent warnings (master...cli-event) https://github.com/bitcoin/bitcoin/pull/13394
852018-06-07T07:03:15 *** promag has quit IRC
862018-06-07T07:14:45 <kallewoof> cfields: are you able to debug using lldb on mac? even with ./configure --enable-debug and make clean I get 'optimized', which is because it puts in -O2. Despite --enable-debug.
872018-06-07T07:20:07 <wumpus> anyhow, going to tag rc2
882018-06-07T07:21:33 <wumpus> * [new tag] v0.16.1rc2 -> v0.16.1rc2
892018-06-07T07:23:57 *** vicenteH has quit IRC
902018-06-07T07:25:09 *** harrymm has joined #bitcoin-core-dev
912018-06-07T07:29:10 *** vicenteH has joined #bitcoin-core-dev
922018-06-07T07:57:12 *** Dyaheon has quit IRC
932018-06-07T08:03:57 *** achow101 has quit IRC
942018-06-07T08:07:55 *** Dyaheon has joined #bitcoin-core-dev
952018-06-07T08:10:26 *** achow101 has joined #bitcoin-core-dev
962018-06-07T08:24:02 *** promag has joined #bitcoin-core-dev
972018-06-07T08:35:11 <sipa> w00t
982018-06-07T08:35:57 *** vicenteH has quit IRC
992018-06-07T08:41:23 *** fanquake has joined #bitcoin-core-dev
1002018-06-07T08:42:31 *** vicenteH has joined #bitcoin-core-dev
1012018-06-07T08:42:50 <fanquake> wumpus If you're still here, #13369 can go in
1022018-06-07T08:42:52 <gribble> https://github.com/bitcoin/bitcoin/issues/13369 | [docs] update transifex doc link by mess110 · Pull Request #13369 · bitcoin/bitcoin · GitHub
1032018-06-07T08:53:01 *** d9b4bef9 has quit IRC
1042018-06-07T08:54:08 *** d9b4bef9 has joined #bitcoin-core-dev
1052018-06-07T09:35:24 *** zhrek` has quit IRC
1062018-06-07T09:37:29 <wumpus> fanquake: ack
1072018-06-07T09:39:01 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e1f8dce9939a...f8bcef38fb9b
1082018-06-07T09:39:02 <bitcoin-git> bitcoin/master 2b30ccc Cristian Mircea Messel: [docs] update transifex doc link
1092018-06-07T09:39:02 <bitcoin-git> bitcoin/master f8bcef3 Wladimir J. van der Laan: Merge #13369: [docs] update transifex doc link...
1102018-06-07T09:39:42 <bitcoin-git> [bitcoin] laanwj closed pull request #13369: [docs] update transifex doc link (master...fix_transifex_doc_link) https://github.com/bitcoin/bitcoin/pull/13369
1112018-06-07T10:03:51 *** sturles has quit IRC
1122018-06-07T10:08:44 *** vicenteH has quit IRC
1132018-06-07T10:10:11 *** vicenteH has joined #bitcoin-core-dev
1142018-06-07T10:10:27 *** sturles has joined #bitcoin-core-dev
1152018-06-07T10:10:27 *** sturles has joined #bitcoin-core-dev
1162018-06-07T10:15:05 *** AaronvanW has joined #bitcoin-core-dev
1172018-06-07T10:19:09 *** Aaronvan_ has joined #bitcoin-core-dev
1182018-06-07T10:22:35 *** AaronvanW has quit IRC
1192018-06-07T10:24:44 *** Krellan has quit IRC
1202018-06-07T10:25:13 *** Krellan has joined #bitcoin-core-dev
1212018-06-07T10:31:11 *** snickerfritz has quit IRC
1222018-06-07T10:36:58 <rafalcpp> no one ported the github-merge.py script to support gitlab?
1232018-06-07T10:39:19 <wumpus> not that I know
1242018-06-07T10:40:10 <wumpus> i'd guess that they have similar APIs, and it's just a matter of tweaking some things
1252018-06-07T10:41:25 <wumpus> huh, test_runner stopped printing progress dots here
1262018-06-07T10:43:53 <rafalcpp> API differs, and they do not want to write compatiblity layer. But probably allows same needed functions
1272018-06-07T10:46:09 <wumpus> oh it still prints ".", but it looks like it takes a lot longer to initially generate the cache
1282018-06-07T10:56:37 *** promag has quit IRC
1292018-06-07T11:00:35 *** Sinclair6 has quit IRC
1302018-06-07T11:01:57 <wumpus> (ok, can't bisect it either, must be something that changed locally in the environment here)
1312018-06-07T11:03:41 *** vicenteH has quit IRC
1322018-06-07T11:03:51 *** vicenteH has joined #bitcoin-core-dev
1332018-06-07T11:07:01 <wumpus> rafalcpp: yes, I did not mean to imply it would be an exact mapping
1342018-06-07T11:08:20 <wumpus> rafalcpp: looking at it, it does only use one call from the gh api, the one to get PR information
1352018-06-07T11:08:51 <rafalcpp> wumpus: yeap, perhaps it will be written tomorrow
1362018-06-07T11:09:18 <wumpus> and from that, it only uses the title, body and branch base ref
1372018-06-07T11:09:25 *** Evel-Knievel has quit IRC
1382018-06-07T11:19:48 *** rongze has joined #bitcoin-core-dev
1392018-06-07T11:20:17 *** promag has joined #bitcoin-core-dev
1402018-06-07T11:47:16 *** Evel-Knievel has joined #bitcoin-core-dev
1412018-06-07T12:05:46 *** bitconner has quit IRC
1422018-06-07T12:06:43 *** laurentmt has joined #bitcoin-core-dev
1432018-06-07T12:06:54 *** SopaXorzTaker has joined #bitcoin-core-dev
1442018-06-07T12:08:01 *** d9b4bef9 has quit IRC
1452018-06-07T12:08:02 *** Victorsueca has quit IRC
1462018-06-07T12:09:09 *** d9b4bef9 has joined #bitcoin-core-dev
1472018-06-07T12:09:15 *** Victorsueca has joined #bitcoin-core-dev
1482018-06-07T12:25:17 <bitcoin-git> [bitcoin] marcoagner opened pull request #13410: Qt: removes html tags from tr calls (master...refactor_remove_tr_html_tags) https://github.com/bitcoin/bitcoin/pull/13410
1492018-06-07T12:34:05 *** bitconner has joined #bitcoin-core-dev
1502018-06-07T12:34:06 *** Krellan has quit IRC
1512018-06-07T12:34:42 *** Krellan has joined #bitcoin-core-dev
1522018-06-07T12:35:36 *** SopaXorzTaker has quit IRC
1532018-06-07T12:59:32 *** Guyver2 has joined #bitcoin-core-dev
1542018-06-07T13:06:49 *** ren0v0 has joined #bitcoin-core-dev
1552018-06-07T13:13:05 *** jnewshoes has quit IRC
1562018-06-07T13:20:05 *** jnewshoes has joined #bitcoin-core-dev
1572018-06-07T13:32:09 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1582018-06-07T13:35:23 *** jhfrontz has quit IRC
1592018-06-07T13:41:12 *** jhfrontz has joined #bitcoin-core-dev
1602018-06-07T13:53:38 *** rongze has quit IRC
1612018-06-07T14:04:01 <rafalcpp> wumpus: any idea how "refs/heads/pull/1/merge" is created, because it seems to not exist on github.com repo for PR 1, and yet the script wants it
1622018-06-07T14:07:10 *** grafcaps has quit IRC
1632018-06-07T14:10:26 <harding> rafalcpp: it's a special GitHub endpoint for PRs. I don't know how they generate it. You can see some instructions for one way to use it here that may be helpful (or not): https://gist.github.com/harding/1a99b0bad37f9498709f#opening-a-pr-for-a-pr
1642018-06-07T14:11:36 <ryanofsky> you may need a line like "fetch = +refs/pull/*/merge:refs/remotes/origin/pull/*/merge" in your .git/config file
1652018-06-07T14:12:04 <rafalcpp> hmm actually that /head etc might be created by script itself. checking
1662018-06-07T14:18:44 *** grafcaps has joined #bitcoin-core-dev
1672018-06-07T14:21:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8bcef38fb9b...3d3d8ae3a0a9
1682018-06-07T14:21:03 <bitcoin-git> bitcoin/master ebebedc lucash.dev@gmail.com: speed up of tx_validationcache_tests by reusing of CTransaction....
1692018-06-07T14:21:04 <bitcoin-git> bitcoin/master 3d3d8ae MarcoFalke: Merge #13404: [tests] speed up of tx_validationcache_tests by reusing of CTransaction....
1702018-06-07T14:21:57 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13404: [tests] speed up of tx_validationcache_tests by reusing of CTransaction. (master...speedup-tx_validationcache_tests) https://github.com/bitcoin/bitcoin/pull/13404
1712018-06-07T14:32:27 *** laurentmt has quit IRC
1722018-06-07T14:32:52 *** belcher has quit IRC
1732018-06-07T14:39:38 *** fanquake has quit IRC
1742018-06-07T14:41:35 *** Krellan has quit IRC
1752018-06-07T14:42:08 *** Krellan has joined #bitcoin-core-dev
1762018-06-07T14:42:17 *** jcohen has joined #bitcoin-core-dev
1772018-06-07T14:43:23 *** Aaronvan_ has quit IRC
1782018-06-07T14:53:02 *** Sinclair6 has joined #bitcoin-core-dev
1792018-06-07T14:55:47 *** grubles has quit IRC
1802018-06-07T14:57:20 *** jcohen has quit IRC
1812018-06-07T14:57:30 *** zivl has quit IRC
1822018-06-07T14:58:49 *** jcohen has joined #bitcoin-core-dev
1832018-06-07T15:10:37 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13412: Make ReceivedBlockTransactions return void (master...Mf1806-refactorReturnCodeValidation) https://github.com/bitcoin/bitcoin/pull/13412
1842018-06-07T15:12:43 *** AaronvanW has joined #bitcoin-core-dev
1852018-06-07T15:14:01 *** grubles has joined #bitcoin-core-dev
1862018-06-07T15:21:37 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13384: qa: Remove polling loop from test_runner (master...Mf1806-qaTestRunnerConcurrentFuture) https://github.com/bitcoin/bitcoin/pull/13384
1872018-06-07T15:23:07 <bitcoin-git> [bitcoin] skeees opened pull request #13413: [net,mempool] Call AcceptToMemoryPool() asynchronously in p2p (master...mempool-async) https://github.com/bitcoin/bitcoin/pull/13413
1882018-06-07T15:23:46 *** Victorsueca has quit IRC
1892018-06-07T15:24:54 *** Victorsueca has joined #bitcoin-core-dev
1902018-06-07T15:30:48 *** AaronvanW has quit IRC
1912018-06-07T15:31:25 *** AaronvanW has joined #bitcoin-core-dev
1922018-06-07T15:35:43 *** dgenr8 has joined #bitcoin-core-dev
1932018-06-07T15:35:49 *** AaronvanW has quit IRC
1942018-06-07T15:36:23 *** Emcy has quit IRC
1952018-06-07T15:38:24 *** Emcy has joined #bitcoin-core-dev
1962018-06-07T15:41:17 *** intcat has quit IRC
1972018-06-07T15:43:39 *** intcat has joined #bitcoin-core-dev
1982018-06-07T15:52:05 *** AaronvanW has joined #bitcoin-core-dev
1992018-06-07T15:59:39 *** promag has quit IRC
2002018-06-07T16:01:24 <bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/3d3d8ae3a0a9...ea263e1eb030
2012018-06-07T16:01:25 <bitcoin-git> bitcoin/master 9b0ec1a Jim Posen: db: Remove obsolete methods from CBlockTreeDB.
2022018-06-07T16:01:25 <bitcoin-git> bitcoin/master e5af5fc Jim Posen: db: Make reusable base class for index databases.
2032018-06-07T16:01:26 <bitcoin-git> bitcoin/master 61a1226 Jim Posen: index: Extract logic from TxIndex into reusable base class.
2042018-06-07T16:02:01 *** Chris_Stewart_5 has quit IRC
2052018-06-07T16:02:12 <bitcoin-git> [bitcoin] laanwj closed pull request #13243: Make reusable base class for auxiliary indices (master...index-abstraction) https://github.com/bitcoin/bitcoin/pull/13243
2062018-06-07T16:02:30 <jamesob> nice change, congrats jimpo
2072018-06-07T16:05:07 <wumpus> I think we should invite jimpo / Jim Posen to the organizations, he's certainly a frequent contributor
2082018-06-07T16:06:30 <sipa> ack
2092018-06-07T16:15:26 *** jcohen has quit IRC
2102018-06-07T16:18:06 <luke-jr> is there some reason we went from single-value args + multi-value args to override-args + config-args? the former seems a lot better..
2112018-06-07T16:31:24 *** promag has joined #bitcoin-core-dev
2122018-06-07T16:38:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2132018-06-07T16:41:22 *** jcohen has joined #bitcoin-core-dev
2142018-06-07T16:42:23 *** intcat has quit IRC
2152018-06-07T16:44:51 *** intcat has joined #bitcoin-core-dev
2162018-06-07T16:45:17 *** gaf_ has quit IRC
2172018-06-07T16:46:21 *** jcohen has quit IRC
2182018-06-07T16:50:23 *** gaf_ has joined #bitcoin-core-dev
2192018-06-07T16:54:41 <rafalcpp> wumpus: gitlab support is added probably. Though I see git submodules are not supported at all. Ok to add support for it? maybe just convert them to text of the sha1 commit?
2202018-06-07T17:04:00 *** Sinclair6 has quit IRC
2212018-06-07T17:04:01 *** GoldenBear has quit IRC
2222018-06-07T17:09:05 *** Krellan has quit IRC
2232018-06-07T17:10:09 *** EpicBaldGuy has quit IRC
2242018-06-07T17:14:45 *** jcohen has joined #bitcoin-core-dev
2252018-06-07T17:17:33 <wumpus> rafalcpp: in bitcoin we use subtrees, not submodules, that's why there's no support for them
2262018-06-07T17:17:55 <sipa> support for submodules where?
2272018-06-07T17:19:38 *** Emcy has quit IRC
2282018-06-07T17:20:38 <sipa> ah, in github-merge
2292018-06-07T17:21:46 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea263e1eb030...97073f8837f3
2302018-06-07T17:21:46 <bitcoin-git> bitcoin/master 2acd1d6 Ben Woosley: Drop uint 256 not operator...
2312018-06-07T17:21:47 <bitcoin-git> bitcoin/master 97073f8 Wladimir J. van der Laan: Merge #13396: Drop unused arith_uint256 ! operator...
2322018-06-07T17:22:21 <bitcoin-git> [bitcoin] laanwj closed pull request #13388: util: Implement boolean conversion and !operator for uint* (master...uint_bool) https://github.com/bitcoin/bitcoin/pull/13388
2332018-06-07T17:22:41 <bitcoin-git> [bitcoin] laanwj closed pull request #13396: Drop unused arith_uint256 ! operator (master...drop-bool-not) https://github.com/bitcoin/bitcoin/pull/13396
2342018-06-07T17:25:29 <bitcoin-git> [bitcoin] rfree-d opened pull request #13414: Support gitlab API in github-merge.py (master...githubmerge_support_gitlab) https://github.com/bitcoin/bitcoin/pull/13414
2352018-06-07T17:35:46 *** rafalcpp has quit IRC
2362018-06-07T17:39:07 *** drexl has joined #bitcoin-core-dev
2372018-06-07T17:50:17 *** EpicBaldGuy has joined #bitcoin-core-dev
2382018-06-07T17:57:17 *** Giszmo has joined #bitcoin-core-dev
2392018-06-07T18:08:34 *** Guest77272 is now known as wbnns
2402018-06-07T18:08:47 *** wbnns has joined #bitcoin-core-dev
2412018-06-07T18:12:58 *** EpicBaldGuy has quit IRC
2422018-06-07T18:17:08 *** zivl has joined #bitcoin-core-dev
2432018-06-07T18:18:31 <skeees> what would reaction / opinion be to defining a macro that allows a function to be static except in unit test builds
2442018-06-07T18:18:51 <skeees> something like #ifdef TEST "" #else static
2452018-06-07T18:19:45 <sipa> that would mean compiling the core objects separately for tests and for normal operation
2462018-06-07T18:20:13 <sipa> which may have performance advantages, but also downsides w.r.t. testability (you're not testing the exact same code as the one that goes in production)
2472018-06-07T18:31:05 *** grafcaps has quit IRC
2482018-06-07T18:39:10 <cfields> skeees: for what purpose?
2492018-06-07T18:40:41 <skeees> basically, theres a bunch of stuff (e.g. in net_processing) that could become static (and a lot of which is only called from one place so probably even inlined at compile time) except that its unit tested somewhere. might have some perf benefits, and would also help readability because you can immediately assess that something is translation unit local
2502018-06-07T18:41:03 <skeees> but i imagine the work to configure separate builds is substantial
2512018-06-07T18:41:20 <sipa> the perf benefits we can get longer term through lto as well
2522018-06-07T18:41:21 <cfields> skeees: sounds like you're looking for lto?
2532018-06-07T18:42:45 <skeees> mostly actually, i'm trying to separate net_processing a bit more from validation, and its been somewhat of a manual exercise, but finding lots of these - so i would say primarily readability / modularization actually
2542018-06-07T18:42:59 <skeees> probably better static analysis tools would accomplish the same
2552018-06-07T18:44:08 <cfields> ah, I see
2562018-06-07T18:45:45 <gmaxwell> If we just want a cosmetic note for arch reasons, there could be a STATICBUTFORTESTS that turns into STATIC for a specific test build (to verify that its used correctly) but otherwise isn't.
2572018-06-07T18:46:57 <skeees> hmmm yeah, that would do it
2582018-06-07T18:47:23 <wumpus> skeees: yes, pretty much an alternative to this: https://github.com/bitcoin/bitcoin/pull/13301#issuecomment-391712408
2592018-06-07T18:47:59 <wumpus> skeees: there's some good reasons to be against including cpp files, but it's also useful for testing static functions :)
2602018-06-07T18:48:29 *** DougieBot5000 has quit IRC
2612018-06-07T18:48:48 <skeees> ahhh, well you could have that linter not run on anything in test/*
2622018-06-07T18:48:57 *** DougieBot5000 has joined #bitcoin-core-dev
2632018-06-07T18:49:15 *** zivl_ has joined #bitcoin-core-dev
2642018-06-07T18:50:02 <gmaxwell> In other projects I've had okay success with including .c files for unit tests. I can get arguments against it though.
2652018-06-07T18:50:18 *** tripleslash has quit IRC
2662018-06-07T18:50:35 *** dgenr8 has quit IRC
2672018-06-07T18:51:36 *** tripleslash has joined #bitcoin-core-dev
2682018-06-07T18:52:14 *** zivl has quit IRC
2692018-06-07T18:52:15 <wumpus> well it still has sipa's problem that "you're not testing the exact same code as the one that goes in production", it avoids the macro magic, but has including c/cpp files
2702018-06-07T18:52:40 <wumpus> choosing between evils...
2712018-06-07T18:53:22 *** nmnkgl has joined #bitcoin-core-dev
2722018-06-07T18:54:14 <wumpus> the advantage of "my" method is that it also works for anonymous namespaces
2732018-06-07T18:54:37 <wumpus> a macro to replace static, would just work for static
2742018-06-07T18:54:55 *** grafcaps has joined #bitcoin-core-dev
2752018-06-07T18:55:04 <gmaxwell> Not testing the exact same code that goes into production is already pretty complicated. What the compiler is doing for inlinable functions already is inlining them where it can, potentially at every use in the file, and then the export is some other code. So the test may well already be testing code that is not used anywhere else.
2762018-06-07T18:55:20 <wumpus> gmaxwell: indeed
2772018-06-07T18:55:28 *** clarkmoody has joined #bitcoin-core-dev
2782018-06-07T18:55:29 <gmaxwell> (obviously this doesn't matter if the code is all defined behavior and the compiler is bug free...)
2792018-06-07T18:55:45 *** Krellan has joined #bitcoin-core-dev
2802018-06-07T18:56:11 <gmaxwell> I like to think of the "not testing the exact same code" as more of just a fundimental limitation of unit tests.
2812018-06-07T18:56:14 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13415: rpc: Add testblocktemplatevalidity (master...Mf1806-rpcTestblocktemplatevalidity) https://github.com/bitcoin/bitcoin/pull/13415
2822018-06-07T18:56:39 <jcorgan> meeting?
2832018-06-07T18:57:05 <wumpus> I mean it's a good point - internal/static functions are very likely inlined, so it's impossible to test exactly the same assembly code as used in production functions
2842018-06-07T18:57:23 <wumpus> the point of the unit test would be to test the functionality of the code, not the compiler
2852018-06-07T18:57:35 <wumpus> jcorgan: still 3 minutes to go according to my clock
2862018-06-07T18:57:56 <jcorgan> ah, need to fix ntpd on my irc bouncer :)
2872018-06-07T18:58:49 *** Emcy has joined #bitcoin-core-dev
2882018-06-07T18:59:24 <gmaxwell> wumpus: yes, point of the unit test is testing functionality of the code not the compiler-- though if the code executes undefined behavior you can't fully decouple those things. In any case, my point is that static vs not static doesn't differ in the functionality of the code...
2892018-06-07T19:00:05 <sipa> *GONG*
2902018-06-07T19:00:08 <wumpus> #startmeeting
2912018-06-07T19:00:08 <lightningbot> Meeting started Thu Jun 7 19:00:08 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2922018-06-07T19:00:08 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2932018-06-07T19:00:16 *** Krellan has quit IRC
2942018-06-07T19:00:56 <achow101> hi
2952018-06-07T19:01:03 <sipa> hi
2962018-06-07T19:01:05 <wumpus> PSA: v0.16.1rc2 has been tagged, please start your gitian builders if you haven't yet, hopefully this can be a short rc, the only change is translations
2972018-06-07T19:01:22 <sipa> reasonable chance that rc2 will be final?
2982018-06-07T19:01:29 <sipa> (sorry, i haven't followed 0.16.1 much)
2992018-06-07T19:01:34 <achow101> yes
3002018-06-07T19:01:37 *** GoldenBear has joined #bitcoin-core-dev
3012018-06-07T19:01:46 <wumpus> well at least I haven't seen any other reports to it, except the Russian translation issue
3022018-06-07T19:01:48 <promag> hi
3032018-06-07T19:02:26 <wumpus> so yes I hope this can be final very quickly
3042018-06-07T19:02:58 <jimpo_> hi
3052018-06-07T19:03:02 <wumpus> topic proposals?
3062018-06-07T19:03:44 <wumpus> #topic High priority for review
3072018-06-07T19:03:56 <wumpus> #link https://github.com/bitcoin/bitcoin/projects/8
3082018-06-07T19:04:54 <wumpus> I don't understand why I added #13059 there last week, it's an issue, not a PR
3092018-06-07T19:04:55 <gribble> https://github.com/bitcoin/bitcoin/issues/13059 | Dynamic wallet load / create / unload · Issue #13059 · bitcoin/bitcoin · GitHub
3102018-06-07T19:05:59 <wumpus> at least we merged #13243
3112018-06-07T19:06:02 <gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub
3122018-06-07T19:06:06 <sipa> yay
3132018-06-07T19:06:10 <promag> =)
3142018-06-07T19:06:27 <wumpus> so 6 PRs left, I'll remove the issue, surprised no one notified me about that
3152018-06-07T19:06:49 <promag> I saw that, didn't mind :P
3162018-06-07T19:07:35 *** bitconner has quit IRC
3172018-06-07T19:08:16 <wumpus> I had an attempt at reviewing and testing #12196, but seems I found a bug
3182018-06-07T19:08:21 <gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub
3192018-06-07T19:08:29 <wumpus> it also needs rebase
3202018-06-07T19:08:33 <wumpus> @jonasschnelli
3212018-06-07T19:08:55 <jonasschnelli> hi
3222018-06-07T19:09:18 <sipa> i was going to follow up with some ideas for writing sets of scripts/addresses
3232018-06-07T19:09:28 <jonasschnelli> yes. will take care. had some busy days but will work on it next week
3242018-06-07T19:09:40 <wumpus> ok, thanks for letting me know
3252018-06-07T19:09:44 <jonasschnelli> please do sipa
3262018-06-07T19:09:51 <sipa> yeah, it's on my todo list
3272018-06-07T19:11:09 <wumpus> #13062 I already reviewed a while ago, though it's been needed to rebase since
3282018-06-07T19:11:11 <gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub
3292018-06-07T19:11:24 <sipa> i'll happily keep rebasing it :)
3302018-06-07T19:11:58 <wumpus> luke-jr: #11082 needs rebase too
3312018-06-07T19:12:00 <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
3322018-06-07T19:12:15 *** jimpo_ has quit IRC
3332018-06-07T19:12:26 <luke-jr> is there some reason we went from single-value args + multi-value args to override-args + config-args? the former seems a lot better..
3342018-06-07T19:12:35 *** jimpo has joined #bitcoin-core-dev
3352018-06-07T19:12:36 <luke-jr> (this is blocking me on 11082 rebasing)
3362018-06-07T19:12:49 <wumpus> I'll take that as a topic suggestion
3372018-06-07T19:12:51 <sipa> i'm not sure what you mean by that
3382018-06-07T19:13:05 <wumpus> (for later)
3392018-06-07T19:13:20 <wumpus> #12136 still has lots of active discussion
3402018-06-07T19:13:25 <gribble> https://github.com/bitcoin/bitcoin/issues/12136 | Implement BIP 174 Partially Signed Bitcoin Transactions by achow101 · Pull Request #12136 · bitcoin/bitcoin · GitHub
3412018-06-07T19:13:57 <wumpus> achow101: any idea what's needed to move forward there?
3422018-06-07T19:14:06 <gmaxwell> Is 13191 waiting on my review and testing?
3432018-06-07T19:14:08 <achow101> wumpus: more review
3442018-06-07T19:14:17 <wumpus> achow101: just review? ok
3452018-06-07T19:14:20 <achow101> wumpus: perhaps on the bip itself too
3462018-06-07T19:14:28 <sipa> i've also been discussion some ideas for splitting part of it up
3472018-06-07T19:15:04 <wumpus> gmaxwell: #13191 is already merged, but you're very welcome to test and review it anyhow
3482018-06-07T19:15:07 <gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub
3492018-06-07T19:15:41 <wumpus> sipa: that's a good idea, I think, just to have progress
3502018-06-07T19:15:44 *** Krellan has joined #bitcoin-core-dev
3512018-06-07T19:16:09 <wumpus> better to make sure as many as possible non-controversial things already merged
3522018-06-07T19:16:30 <gmaxwell> wumpus: lol. sorry, I had an old page up and on reload the post merge discussion caused me to miss that it was merged. :P
3532018-06-07T19:16:45 <gmaxwell> So I was confused as to why it wasn't merged yet.
3542018-06-07T19:16:45 <wumpus> gmaxwell: hehe
3552018-06-07T19:17:21 <sipa> there are a few more specialized-instructions-optimized-code PRs open
3562018-06-07T19:17:49 <sipa> we discovered yesterday that compiling the sse4 intrinsics code with -mavx gives a 30% speedup
3572018-06-07T19:18:02 <wumpus> #13111 should be pretty close, I guess it's just a boring thing to manually test because it unloads
3582018-06-07T19:18:05 <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
3592018-06-07T19:18:24 <cfields> sipa: how much work do you think it would be to switch the sse41 to intrinsics?
3602018-06-07T19:18:26 <promag> reviews are welcome
3612018-06-07T19:18:36 <wumpus> promag: I will
3622018-06-07T19:18:46 <promag> i think it's almost there
3632018-06-07T19:18:54 <sipa> cfields: that would be neat
3642018-06-07T19:19:01 <sipa> cfields: i can try, but it's low priority for me
3652018-06-07T19:19:08 <wumpus> sipa: yes, that was really neat
3662018-06-07T19:19:08 <gmaxwell> I'll put money on it being a boatload slower. :P
3672018-06-07T19:19:32 <sipa> gmaxwell: define "boatload" please
3682018-06-07T19:19:37 <gmaxwell> (based on the mavx result suggests to me that the compiler is failing to achieve a good register allocation that doesn't kill performance)
3692018-06-07T19:19:40 <gmaxwell> 30%.
3702018-06-07T19:19:42 <sipa> (so i know whether to take the bet or not)
3712018-06-07T19:19:54 <sipa> nah, no way it's 30% slower with intrinsics :)
3722018-06-07T19:20:13 <wumpus> I supose it's only boatloads slower on my stupid AMD system :)
3732018-06-07T19:20:41 <cfields> sipa: ok, I'll look around for an impl on the net to copy from. I doubt I'd fare well myself, though :(
3742018-06-07T19:20:46 *** Krellan has quit IRC
3752018-06-07T19:21:02 <sipa> cfields: the asm code we have is derived from nasm code that's more readable
3762018-06-07T19:21:05 <sipa> that may help
3772018-06-07T19:21:13 <wumpus> but anyhow if anyone needs benchmarking of anything on AMD, just let me know
3782018-06-07T19:21:21 <cfields> ok
3792018-06-07T19:21:30 <cfields> wumpus: I'd prefer to merge before getting the AMD numbers :p
3802018-06-07T19:21:51 <wumpus> cfields: I understand :p
3812018-06-07T19:22:42 <gmaxwell> wumpus: have you seen if the mavx compiled SSE4 code is slower on your system? I wouldn't expect it to be.
3822018-06-07T19:22:43 <wumpus> too bad I seem to collect them
3832018-06-07T19:23:18 <cfields> gmaxwell: iirc he benched those and it was ~the same.
3842018-06-07T19:23:34 <wumpus> gmaxwell: there was almost no difference with avx here
3852018-06-07T19:23:44 <wumpus> it was very slightly faster
3862018-06-07T19:23:48 <gmaxwell> odd.
3872018-06-07T19:23:58 *** Giszmo has quit IRC
3882018-06-07T19:24:03 <wumpus> looks like they go in to some emulation mode
3892018-06-07T19:24:05 <cfields> right: https://0bin.net/paste/ReThQTAAWhKYfH7x#K99wDsZBBbtqEnc1N44e9UWz2E-t1y2jDhByhD8BBZe
3902018-06-07T19:24:20 <gmaxwell> (odd because my understanding was that the 30% speedup from getting better register space, not from using any AVX instructions...)
3912018-06-07T19:24:52 <sipa> gmaxwell: in AVX mode there literally is 2x more register space
3922018-06-07T19:25:10 <sipa> but maybe that's not the reason for the speedup, i haven't analysed
3932018-06-07T19:25:28 <sipa> still, i would be very surprised if equivalent code with intrinsics rather than asm is more than a few % slower
3942018-06-07T19:25:37 <gmaxwell> We can take this discussion offline, but I don't completely agree. :)
3952018-06-07T19:25:42 <sipa> ok!
3962018-06-07T19:25:45 <wumpus> intrinsics should do very well, with modern SIMD instruction sets
3972018-06-07T19:26:08 <wumpus> (they're pretty much designed to work well with them)
3982018-06-07T19:26:21 <wumpus> but yes, it's getting a bit off topic
3992018-06-07T19:26:42 <wumpus> #topic single-value args + multi-value args to override-args + config-args? (luke-jr)
4002018-06-07T19:26:55 <sipa> luke-jr: elaborate
4012018-06-07T19:27:08 <gmaxwell> I have cached skeptcisism mostly because compilers used to be VERY bad with register allocations for SIMD, resulting in a lot of code that is more complex than 'run this code 4x in parallel' not getting a speedup when hand asm hapily got a 3x speedup. I know they're much better now. So perhaps ignore me. :)
4022018-06-07T19:27:21 <luke-jr> we used to have a map of arg name -> single value and arg name -> multiple values
4032018-06-07T19:28:04 <luke-jr> it's been changed to arg name-> multiple values, but with two maps, one for config file, and one for command line options
4042018-06-07T19:28:36 <luke-jr> it seems better to have config/commandline share maps
4052018-06-07T19:28:37 <wumpus> gmaxwell: compilers seem to have become better with that, but I understand your skepticism
4062018-06-07T19:29:16 <wumpus> gmaxwell: there's also the *optimizing for a specific CPU type* versus *optimizing it to be, on average, fast, for many families of CPUs* thing
4072018-06-07T19:29:33 <luke-jr> this comes up because the change complicates how to implement rwconf
4082018-06-07T19:30:40 <achow101> luke-jr: I think that change may be for qt settings interactions
4092018-06-07T19:30:50 <wumpus> luke-jr: I'm not sure I know enough about this to understand the implications of this in practice
4102018-06-07T19:30:59 <jnewbery> luke-jr: it was changed in #11862
4112018-06-07T19:31:02 <gribble> https://github.com/bitcoin/bitcoin/issues/11862 | Network specific conf sections by ajtowns · Pull Request #11862 · bitcoin/bitcoin · GitHub
4122018-06-07T19:31:34 *** Krellan has joined #bitcoin-core-dev
4132018-06-07T19:31:38 <wumpus> whatever you do, please don't mess up the bitcoin-qt initialization order, the rest is fine with me :p
4142018-06-07T19:31:56 <sipa> i think it would also be useful to make the arg information know whether a particular argument is single-value or multi-value
4152018-06-07T19:32:16 <sipa> rather than have that information be at query time
4162018-06-07T19:32:38 *** bitconner has joined #bitcoin-core-dev
4172018-06-07T19:32:39 <sipa> but i also don't understand the interactions well enough
4182018-06-07T19:32:42 <sipa> aj: you here?
4192018-06-07T19:32:43 <luke-jr> sipa: yes, I was thinking about that too
4202018-06-07T19:32:48 <wumpus> #13389 kind of scared me
4212018-06-07T19:32:50 <gribble> https://github.com/bitcoin/bitcoin/issues/13389 | Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen · Pull Request #13389 · bitcoin/bitcoin · GitHub
4222018-06-07T19:33:25 <luke-jr> the reason they're split one way or the other, is because the last command line option overrides the former ones, and the earlier config file overrides the later ones
4232018-06-07T19:33:45 <wumpus> we don't have good tests for half of this stuff
4242018-06-07T19:33:57 <luke-jr> so now when we do Get*Arg, the code is going for the end of the command line list, then the start of the config file list
4252018-06-07T19:34:22 <luke-jr> (the altnerative being, to just parse into a single value at startup, and just access that map at runtime)
4262018-06-07T19:35:48 <sipa> i feel like the right people aren't here to discuss that
4272018-06-07T19:35:57 <wumpus> yes
4282018-06-07T19:35:57 *** Krellan has quit IRC
4292018-06-07T19:35:59 <luke-jr> maybe
4302018-06-07T19:36:06 <sipa> it sounds reasonable what you're saying, but i don't know enough to really comment
4312018-06-07T19:36:32 <wumpus> I agree
4322018-06-07T19:37:11 <jnewbery> There's a lot of discussion and review in both #12878 and #11862. AJ also added really good code coverage in those PRs, so it should be pretty straightforward to follow
4332018-06-07T19:37:14 <wumpus> other topics?
4342018-06-07T19:37:14 <gribble> https://github.com/bitcoin/bitcoin/issues/12878 | [refactor] Config handling refactoring in preparation for network-specific sections by ajtowns · Pull Request #12878 · bitcoin/bitcoin · GitHub
4352018-06-07T19:37:17 <gribble> https://github.com/bitcoin/bitcoin/issues/11862 | Network specific conf sections by ajtowns · Pull Request #11862 · bitcoin/bitcoin · GitHub
4362018-06-07T19:37:20 <promag> it also sounds reasonable to encapsulate the arg chaining in a map lookup lookalike
4372018-06-07T19:38:49 <wumpus> meh
4382018-06-07T19:39:07 <luke-jr> sounds like either way I should start with tests
4392018-06-07T19:39:15 <wumpus> personally I prefer method calls to just look like method calls, not operator overrides, in the common case
4402018-06-07T19:40:05 <wumpus> luke-jr: yes! tests are always good
4412018-06-07T19:41:42 *** Giszmo has joined #bitcoin-core-dev
4422018-06-07T19:41:54 <wumpus> other topics?
4432018-06-07T19:42:27 *** ccdle12 has joined #bitcoin-core-dev
4442018-06-07T19:42:34 <promag> actually I have a question
4452018-06-07T19:43:10 <promag> #13374 and #13375
4462018-06-07T19:43:12 <gribble> https://github.com/bitcoin/bitcoin/issues/13374 | utils and libraries: checking for bitcoin address in translations by kaplanmaxe · Pull Request #13374 · bitcoin/bitcoin · GitHub
4472018-06-07T19:43:14 <gribble> https://github.com/bitcoin/bitcoin/issues/13375 | utils and libraries: address check in update-translations.py by undercoverGod · Pull Request #13375 · bitcoin/bitcoin · GitHub
4482018-06-07T19:43:17 <wumpus> if you have a topic, just propose it, there's no need to tell that you have a question
4492018-06-07T19:43:46 <promag> they are the same, why isn't one closed?
4502018-06-07T19:44:18 <wumpus> because no one told me (or fanquake, or anyone) to?
4512018-06-07T19:44:38 <wumpus> I do not have the capacity to pay attention to all PRs in parallel
4522018-06-07T19:44:54 <promag> really? :P
4532018-06-07T19:44:54 <sipa> we need to have an AVX2 wumpus
4542018-06-07T19:45:00 <wumpus> sipa: +1
4552018-06-07T19:45:04 <sipa> +8
4562018-06-07T19:45:21 <sipa> end of meeting, i assume?
4572018-06-07T19:45:26 <wumpus> yes
4582018-06-07T19:45:28 <wumpus> #endmeeting
4592018-06-07T19:45:28 <lightningbot> Meeting ended Thu Jun 7 19:45:28 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4602018-06-07T19:45:28 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-06-07-19.00.html
4612018-06-07T19:45:28 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-06-07-19.00.txt
4622018-06-07T19:45:28 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-06-07-19.00.log.html
4632018-06-07T19:47:14 <BlueMatt> oh, quick comment: if you have had ideas about things you want to fork into the protocol in the future, *please* read https://github.com/TheBlueMatt/bips/blob/betterhash/bip-XXXX.mediawiki and make sure that your ideas can be added without protocol modifications so that miners dont need firmware updates
4642018-06-07T19:47:19 <BlueMatt> and pools wouldnt need to change
4652018-06-07T19:47:38 <BlueMatt> obviously basic things like additional commitments especially via the witness reserved value are clearly supported
4662018-06-07T19:48:30 <wumpus> promag: if people open "competing PRs" for the same issue that makes things more difficult
4672018-06-07T19:49:00 <wumpus> instead of just reviewing code, you suddenly need to be judge of what is the best approach
4682018-06-07T19:49:23 <promag> what are the odds to open competing PRs at the "same time"?
4692018-06-07T19:49:36 <promag> right
4702018-06-07T19:49:52 <wumpus> promag: it luckily doesn't happen too much!
4712018-06-07T19:50:09 <promag> imo one of the authors (the last?) should review the other
4722018-06-07T19:50:23 <promag> and close his own
4732018-06-07T19:50:26 <wumpus> I like your approach, get them to cooporate intead of compete
4742018-06-07T19:50:53 * luke-jr goes through the PR list, rewrites them, and opens new PRs to compete. jk
4752018-06-07T19:51:37 <promag> luke-jr: in this case they are very very similar
4762018-06-07T19:51:38 <wumpus> luke-jr: I know it, I shouldn't have given away this obvious DoS strategy
4772018-06-07T19:52:01 <promag> it's not a rewrite like you say
4782018-06-07T19:52:03 <luke-jr> wumpus: actually, if someone does try to DoS with it, it may end up improving our flow quickly
4792018-06-07T19:52:08 *** justanotheruser has joined #bitcoin-core-dev
4802018-06-07T19:52:38 <wumpus> I'm... not going to say more about this, not giving people ideas :)
4812018-06-07T19:53:07 <promag> wumpus: then feel free to review my PR
4822018-06-07T19:53:14 <wumpus> promag: which one?
4832018-06-07T19:53:39 <promag> all
4842018-06-07T19:53:42 <promag> :|
4852018-06-07T19:53:57 *** justan0theruser has quit IRC
4862018-06-07T19:54:06 <promag> unloadwallet
4872018-06-07T19:54:27 <promag> in travis its failing with -with-incompatible-bdb i think
4882018-06-07T19:54:56 <wumpus> lets' first see why travis is failing on it
4892018-06-07T19:55:44 <promag> I'll
4902018-06-07T19:55:57 <promag> .. to reproduce locally
4912018-06-07T19:56:21 <wumpus> multiwallet failing on x86_64 linux platforms
4922018-06-07T19:57:48 <promag> hm
4932018-06-07T19:59:37 <wumpus> I'll try locally too, on AMD :p
4942018-06-07T20:00:44 <promag> ty
4952018-06-07T20:02:53 *** bitconner has quit IRC
4962018-06-07T20:05:23 *** promag_ has joined #bitcoin-core-dev
4972018-06-07T20:05:27 *** promag has quit IRC
4982018-06-07T20:09:51 <bitcoin-git> [bitcoin] wodry opened pull request #13416: More precise explanation of parameter onlynet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13416
4992018-06-07T20:16:24 <wumpus> promag_: /home/orion/projects/bitcoin/bitcoin/src/qt/bitcoingui.cpp:122:5: warning: field 'spinnerFrame' will be initialized after field 'm_wallet_selector_label' [-Wreorder]
5002018-06-07T20:17:55 <wumpus> (I think that's due to your change, I haven't seen it before)
5012018-06-07T20:19:00 *** belcher has joined #bitcoin-core-dev
5022018-06-07T20:21:05 *** justanotheruser has quit IRC
5032018-06-07T20:23:04 *** Tralfaz has joined #bitcoin-core-dev
5042018-06-07T20:23:27 *** Tralfaz has quit IRC
5052018-06-07T20:27:40 *** nmnkgl has quit IRC
5062018-06-07T20:27:55 *** justanotheruser has joined #bitcoin-core-dev
5072018-06-07T20:28:17 *** nmnkgl has joined #bitcoin-core-dev
5082018-06-07T20:31:09 *** clarkmoody has quit IRC
5092018-06-07T20:32:17 *** nmnkgl has quit IRC
5102018-06-07T20:33:43 <wumpus> promag_: I don't get the same crash locally
5112018-06-07T20:33:57 *** promag_ is now known as promag
5122018-06-07T20:34:30 <promag> regarding the warning, i'll fix
5132018-06-07T20:35:14 <promag> strange
5142018-06-07T20:36:41 <promag> mtt bug?
5152018-06-07T20:37:21 <wumpus> mtt?
5162018-06-07T20:37:29 <promag> multithread
5172018-06-07T20:37:37 <promag> crash aside, a code review + concept ack would be nice
5182018-06-07T20:38:55 <bitcoin-git> [bitcoin] skeees opened pull request #13417: [net] Tighten scope in net_processing (master...net_processing-disentangle) https://github.com/bitcoin/bitcoin/pull/13417
5192018-06-07T20:43:25 *** jhfrontz has quit IRC
5202018-06-07T20:45:05 *** jhfrontz has joined #bitcoin-core-dev
5212018-06-07T20:45:55 *** gkgkgk has joined #bitcoin-core-dev
5222018-06-07T20:47:45 *** gkgkgk has quit IRC
5232018-06-07T20:48:45 *** hfdtfsuaiwhaiwoe has joined #bitcoin-core-dev
5242018-06-07T20:48:56 *** hfdtfsuaiwhaiwoe has quit IRC
5252018-06-07T20:49:22 *** hfdtfsuaiwhaiwoe has joined #bitcoin-core-dev
5262018-06-07T21:00:49 <bitcoin-git> [bitcoin] wodry closed pull request #13416: More precise explanation of parameter onlynet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13416
5272018-06-07T21:06:00 *** jcohen has quit IRC
5282018-06-07T21:06:22 <bitcoin-git> [bitcoin] wodry opened pull request #13418: More precise explanation of parameter onlynet (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13418
5292018-06-07T21:13:51 *** Guyver2 has quit IRC
5302018-06-07T21:19:03 *** Krellan has joined #bitcoin-core-dev
5312018-06-07T21:22:19 *** bitconner has joined #bitcoin-core-dev
5322018-06-07T21:23:27 *** Krellan has quit IRC
5332018-06-07T21:29:24 *** Cheeseo has joined #bitcoin-core-dev
5342018-06-07T21:29:58 <MarcoFalke> > <fanquake> MarcoFalke is your bot on GH somewhere?
5352018-06-07T21:30:00 <MarcoFalke> Not yet
5362018-06-07T21:32:47 *** nmnkgl has joined #bitcoin-core-dev
5372018-06-07T21:34:06 *** bitconner has quit IRC
5382018-06-07T21:37:29 *** nmnkgl has quit IRC
5392018-06-07T21:39:32 *** nmnkgl has joined #bitcoin-core-dev
5402018-06-07T21:48:23 <jimpo> Why in BIP 141 is the coinbase witness stack restricted to 1 item instead of making the reserved value the entire witness?
5412018-06-07T21:52:15 *** Cheeseo has quit IRC
5422018-06-07T21:57:13 <sipa> jimpo: perhaps that was a mistake
5432018-06-07T21:57:39 <sipa> the reasoning was that you only need 1 reserved value in each level to 'chain' a new piece of data necessary for consensus
5442018-06-07T22:06:58 *** Giszmo has quit IRC
5452018-06-07T22:09:25 *** ccdle12 has quit IRC
5462018-06-07T22:11:55 <jimpo> OK, thanks. Yeah, seems like it would just require more hash operations if it's linear in the number of levels/commitments.
5472018-06-07T22:20:44 *** AaronvanW has quit IRC
5482018-06-07T22:23:05 *** AaronvanW has joined #bitcoin-core-dev
5492018-06-07T22:27:03 *** bitconner has joined #bitcoin-core-dev
5502018-06-07T22:29:57 *** Giszmo has joined #bitcoin-core-dev
5512018-06-07T22:32:56 *** nmnkgl has quit IRC
5522018-06-07T22:40:36 *** hfdtfsuaiwhaiwoe has quit IRC
5532018-06-07T22:40:37 *** hfdtfsuaiwhaiwoe has joined #bitcoin-core-dev
5542018-06-07T22:45:25 *** Sinclair_ has joined #bitcoin-core-dev
5552018-06-07T22:45:29 *** bitconner has quit IRC
5562018-06-07T22:49:25 *** bitconner has joined #bitcoin-core-dev
5572018-06-07T22:49:40 *** hfdtfsuaiwhaiwoe has quit IRC
5582018-06-07T22:50:00 *** snickerfritz_ has joined #bitcoin-core-dev
5592018-06-07T22:51:00 *** snickerfritz_ has quit IRC
5602018-06-07T22:51:00 *** snickerfritz_ has joined #bitcoin-core-dev
5612018-06-07T22:52:45 *** snickerfritz_ is now known as snickerfritz
5622018-06-07T23:05:07 *** Aaronvan_ has joined #bitcoin-core-dev
5632018-06-07T23:05:45 *** nekotribal has joined #bitcoin-core-dev
5642018-06-07T23:06:38 *** Aaronva__ has joined #bitcoin-core-dev
5652018-06-07T23:07:13 *** AaronvanW has quit IRC
5662018-06-07T23:08:10 *** Chris_Stewart_5 has quit IRC
5672018-06-07T23:09:35 *** Aaronvan_ has quit IRC
5682018-06-07T23:19:50 *** snickerfritz has quit IRC
5692018-06-07T23:30:13 *** Krellan has joined #bitcoin-core-dev
5702018-06-07T23:34:03 *** promag has quit IRC
5712018-06-07T23:36:52 *** drexl has quit IRC
5722018-06-07T23:52:43 *** snickerfritz has joined #bitcoin-core-dev
5732018-06-07T23:52:51 *** Krellan has quit IRC
5742018-06-07T23:56:25 *** Krellan has joined #bitcoin-core-dev