1 2018-06-11T00:17:20  * luke-jr is not very surprised
  2 2018-06-11T00:18:49  *** drexl has quit IRC
  3 2018-06-11T00:22:17  *** AaronvanW has quit IRC
  4 2018-06-11T00:23:43  *** AaronvanW has joined #bitcoin-core-dev
  5 2018-06-11T00:27:57  *** AaronvanW has quit IRC
  6 2018-06-11T00:38:24  *** Chris_Stewart_5 has quit IRC
  7 2018-06-11T00:38:48  *** justanotheruser has quit IRC
  8 2018-06-11T00:55:25  *** justanotheruser has joined #bitcoin-core-dev
  9 2018-06-11T01:00:12  *** richbd has joined #bitcoin-core-dev
 10 2018-06-11T01:04:18  *** richbd has quit IRC
 11 2018-06-11T01:22:26  *** booyah has quit IRC
 12 2018-06-11T01:24:28  *** AaronvanW has joined #bitcoin-core-dev
 13 2018-06-11T01:30:21  *** AaronvanW has quit IRC
 14 2018-06-11T01:39:54  *** nullptr| has joined #bitcoin-core-dev
 15 2018-06-11T01:46:35  *** nullptr| has quit IRC
 16 2018-06-11T01:47:57  *** nullptr| has joined #bitcoin-core-dev
 17 2018-06-11T01:54:55  *** nullptr| has quit IRC
 18 2018-06-11T01:59:55  *** nullptr| has joined #bitcoin-core-dev
 19 2018-06-11T02:00:05  *** Krellan has quit IRC
 20 2018-06-11T02:00:56  *** Krellan has joined #bitcoin-core-dev
 21 2018-06-11T02:04:14  <echeveria> 2018-06-11 02:03:03.384975 Verifying last 3 blocks at level 3
 22 2018-06-11T02:04:14  <echeveria> 2018-06-11 02:03:23.676793 No coin database inconsistencies in last 4 blocks (6564 transactions)
 23 2018-06-11T02:04:18  <echeveria> off by one?
 24 2018-06-11T02:23:02  *** d9b4bef9 has quit IRC
 25 2018-06-11T02:24:15  *** d9b4bef9 has joined #bitcoin-core-dev
 26 2018-06-11T02:34:35  <sipa> echeveria: possibly!
 27 2018-06-11T02:40:47  *** marc_pango has joined #bitcoin-core-dev
 28 2018-06-11T02:42:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 29 2018-06-11T02:45:05  *** Sinclair6 has quit IRC
 30 2018-06-11T03:03:32  *** justanotheruser has quit IRC
 31 2018-06-11T03:04:20  *** Chris_Stewart_5 has quit IRC
 32 2018-06-11T03:21:33  *** ula has quit IRC
 33 2018-06-11T03:27:01  *** AaronvanW has joined #bitcoin-core-dev
 34 2018-06-11T03:31:13  *** AaronvanW has quit IRC
 35 2018-06-11T04:01:51  *** grafcaps has quit IRC
 36 2018-06-11T04:05:42  *** justanotheruser has joined #bitcoin-core-dev
 37 2018-06-11T04:08:09  *** Krellan has quit IRC
 38 2018-06-11T04:09:02  *** Krellan has joined #bitcoin-core-dev
 39 2018-06-11T04:14:45  *** grafcaps has joined #bitcoin-core-dev
 40 2018-06-11T04:18:57  <kallewoof> Looks like it checks one more block than suggested. `if (pindex->nHeight < chainActive.Height()-nCheckDepth) break;` should probably be `<=`.
 41 2018-06-11T04:20:25  *** Emcy has quit IRC
 42 2018-06-11T04:36:03  *** Empact has quit IRC
 43 2018-06-11T04:45:17  *** Empact has joined #bitcoin-core-dev
 44 2018-06-11T04:46:52  *** nullptr| has quit IRC
 45 2018-06-11T04:52:00  <sipa> kallewoof: agree
 46 2018-06-11T04:53:40  *** nullptr| has joined #bitcoin-core-dev
 47 2018-06-11T05:21:02  *** grafcaps has quit IRC
 48 2018-06-11T05:27:49  *** AaronvanW has joined #bitcoin-core-dev
 49 2018-06-11T05:28:49  <bitcoin-git> [bitcoin] kallewoof opened pull request #13428: validation: check the specified number of blocks (off-by-one) (master...validation-off-by-one) https://github.com/bitcoin/bitcoin/pull/13428
 50 2018-06-11T05:29:04  <bitcoin-git> [bitcoin] Empact opened pull request #13429: Return the script type from Solver (master...solver-return) https://github.com/bitcoin/bitcoin/pull/13429
 51 2018-06-11T05:29:08  *** victorSN has quit IRC
 52 2018-06-11T05:29:08  *** rockhouse has quit IRC
 53 2018-06-11T05:32:30  *** AaronvanW has quit IRC
 54 2018-06-11T05:50:11  <gmaxwell> sipa: you created a 32-byte version of the specialized 1-way SSE4 asm?
 55 2018-06-11T06:07:58  *** Emcy has joined #bitcoin-core-dev
 56 2018-06-11T06:49:24  *** bitconne1 has joined #bitcoin-core-dev
 57 2018-06-11T06:52:05  *** bitconner has quit IRC
 58 2018-06-11T06:52:57  *** jimpo has quit IRC
 59 2018-06-11T06:55:33  *** rockhouse has joined #bitcoin-core-dev
 60 2018-06-11T06:55:37  *** victorSN has joined #bitcoin-core-dev
 61 2018-06-11T06:56:00  *** rockhouse has quit IRC
 62 2018-06-11T06:56:00  *** rockhouse has joined #bitcoin-core-dev
 63 2018-06-11T07:05:36  <bitcoin-git> [bitcoin] kallewoof opened pull request #13430: use IsBlockPruned() where appropriate (master...use-isblockpruned) https://github.com/bitcoin/bitcoin/pull/13430
 64 2018-06-11T07:16:46  <bitcoin-git> [bitcoin] kallewoof opened pull request #13431: validation: update pindexState for check level < 3 (master...verifydb_pindexstate_lvl0-2) https://github.com/bitcoin/bitcoin/pull/13431
 65 2018-06-11T07:24:28  *** AaronvanW has joined #bitcoin-core-dev
 66 2018-06-11T07:25:50  *** bitconne1 has quit IRC
 67 2018-06-11T07:29:11  *** AaronvanW has quit IRC
 68 2018-06-11T07:29:22  *** ren0v0 has quit IRC
 69 2018-06-11T07:31:17  *** jimpo has joined #bitcoin-core-dev
 70 2018-06-11T07:32:45  *** Sentineo has quit IRC
 71 2018-06-11T07:37:48  *** marc_pango has quit IRC
 72 2018-06-11T07:58:18  *** ccdle12 has joined #bitcoin-core-dev
 73 2018-06-11T08:06:09  *** bitconner has joined #bitcoin-core-dev
 74 2018-06-11T08:06:15  *** setpill has joined #bitcoin-core-dev
 75 2018-06-11T08:06:45  *** BashCo has quit IRC
 76 2018-06-11T08:11:13  *** BashCo has joined #bitcoin-core-dev
 77 2018-06-11T08:17:10  *** grafcaps has joined #bitcoin-core-dev
 78 2018-06-11T08:19:54  *** Krellan has quit IRC
 79 2018-06-11T08:21:21  *** grafcaps has quit IRC
 80 2018-06-11T08:30:39  *** laurentmt has joined #bitcoin-core-dev
 81 2018-06-11T08:30:58  *** promag has joined #bitcoin-core-dev
 82 2018-06-11T08:34:20  *** Krellan has joined #bitcoin-core-dev
 83 2018-06-11T08:35:05  *** sturles has quit IRC
 84 2018-06-11T08:38:04  *** ren0v0 has joined #bitcoin-core-dev
 85 2018-06-11T08:39:30  *** timothy has joined #bitcoin-core-dev
 86 2018-06-11T08:44:31  *** sturles has joined #bitcoin-core-dev
 87 2018-06-11T08:44:32  *** sturles has joined #bitcoin-core-dev
 88 2018-06-11T08:45:51  *** timothy has quit IRC
 89 2018-06-11T08:45:57  *** drizztbsd has joined #bitcoin-core-dev
 90 2018-06-11T08:55:33  *** rafalcpp has joined #bitcoin-core-dev
 91 2018-06-11T08:56:46  *** promag has quit IRC
 92 2018-06-11T08:59:09  <ossifrage> FYI, bitcoin-qt from the head I built today won't start if you have "daemon=0" in the config file, so you can't use the same config for either bitcoind or bitcoin-qt
 93 2018-06-11T09:00:43  <ossifrage> Seems like bitcoin-qt should ignore this option?
 94 2018-06-11T09:01:52  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13434: Set default CFLAGS, CXXFLAGS to empty (master...enable_debug) https://github.com/bitcoin/bitcoin/pull/13434
 95 2018-06-11T09:06:33  <provoostenator> ossifrage: probably caused by 13112. Another problem is disablewallet=1 will prevent a launch if you compile bitcoind without wallet. It probably needs to be relaxed slightly.
 96 2018-06-11T09:06:45  <provoostenator> #13112
 97 2018-06-11T09:06:51  <gribble> https://github.com/bitcoin/bitcoin/issues/13112 | Throw an error for unknown args by achow101 · Pull Request #13112 · bitcoin/bitcoin · GitHub
 98 2018-06-11T09:11:29  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13434: Set default CFLAGS, CXXFLAGS to empty (master...enable_debug) https://github.com/bitcoin/bitcoin/pull/13434
 99 2018-06-11T09:20:21  *** promag has joined #bitcoin-core-dev
100 2018-06-11T09:25:19  *** AaronvanW has joined #bitcoin-core-dev
101 2018-06-11T09:29:58  *** AaronvanW has quit IRC
102 2018-06-11T09:31:23  <wumpus> rc2 executables up https://bitcoincore.org/bin/bitcoin-core-0.16.1/test.rc2/, sorry for the delay
103 2018-06-11T09:32:11  *** laurentmt has quit IRC
104 2018-06-11T09:36:37  *** murrayn has quit IRC
105 2018-06-11T09:45:31  *** murrayn has joined #bitcoin-core-dev
106 2018-06-11T09:45:31  *** murrayn has joined #bitcoin-core-dev
107 2018-06-11T09:47:45  <bitcoin-git> [bitcoin] Empact opened pull request #13435: When build fails due to lib missing, indicate which one (master...lib-missing) https://github.com/bitcoin/bitcoin/pull/13435
108 2018-06-11T09:48:41  <kallewoof> Regarding #13434, shouldn't --enable-debug automatically do --disable-maintainer-mode? Currently --enable-debug is useless at least on macs, as it still generates optimized code so lldb barfs.
109 2018-06-11T09:48:43  <gribble> https://github.com/bitcoin/bitcoin/issues/13434 | Set default CFLAGS, CXXFLAGS to empty by ken2812221 · Pull Request #13434 · bitcoin/bitcoin · GitHub
110 2018-06-11T10:04:12  *** promag has quit IRC
111 2018-06-11T10:05:23  *** grafcaps has joined #bitcoin-core-dev
112 2018-06-11T10:09:27  *** grafcaps has quit IRC
113 2018-06-11T10:32:45  *** promag has joined #bitcoin-core-dev
114 2018-06-11T10:40:29  *** Krellan has quit IRC
115 2018-06-11T10:41:14  *** Krellan has joined #bitcoin-core-dev
116 2018-06-11T10:48:57  *** AaronvanW has joined #bitcoin-core-dev
117 2018-06-11T10:55:09  *** Aaronvan_ has joined #bitcoin-core-dev
118 2018-06-11T10:58:20  *** AaronvanW has quit IRC
119 2018-06-11T11:03:58  *** owowo has quit IRC
120 2018-06-11T11:08:23  *** owowo has joined #bitcoin-core-dev
121 2018-06-11T11:09:32  *** str4d has joined #bitcoin-core-dev
122 2018-06-11T11:12:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
123 2018-06-11T11:21:31  *** promag has quit IRC
124 2018-06-11T11:25:35  <wumpus> kallewoof: maintainer mode affects optimization?
125 2018-06-11T11:27:11  <wumpus> provoostenator: I think that one makes sense, if you compile without wallet the program has no way to know about wallet options, so will reject them
126 2018-06-11T11:27:31  <wumpus> provoostenator: the alternative would be to move knowledge of wallet options into the core, that'd be even worse
127 2018-06-11T11:28:11  <rafalcpp> wumpus: I wonder how githubmerge could support git submodules. The submodules are linked by sha1 which is useless.
128 2018-06-11T11:28:49  <rafalcpp> perhaps we should recursivly calculate our tree-sha512 of a submodule, and that checksum will be placed as data (next to blobs) of the tree of parent
129 2018-06-11T11:28:57  <provoostenator> Not full knowledge, just any option that disables these features, like upnp=0, disablewallet=1. That way if you forget to leave them out of compilation, those features don't just turn themselves on.
130 2018-06-11T11:29:18  <wumpus> hmm okay that sounds better at least
131 2018-06-11T11:29:37  *** bitconner has quit IRC
132 2018-06-11T11:30:34  <wumpus> rafalcpp: sounds like a lot of hassle, indeed
133 2018-06-11T11:31:27  * rafalcpp spanks Torvalds to have git move to sha512 nativly
134 2018-06-11T11:31:50  <wumpus> agree
135 2018-06-11T11:33:03  <wumpus> I think he keeps insisting that 'commit hashes are not a security feature', fair enough, but many people need a way to authenticate repositories securely
136 2018-06-11T11:33:15  <rafalcpp> yeap
137 2018-06-11T11:33:16  <wumpus> and the commit hash is the weakest link in that
138 2018-06-11T11:41:44  <rafalcpp> someone should ask him does he again want CIA to if (uid = 0) ... him like they did old CVS, but this time with false sense of security
139 2018-06-11T11:42:59  *** promag has joined #bitcoin-core-dev
140 2018-06-11T11:43:58  <wumpus> well it's open source so someone that cares should do it,instead of trying to convince Linus, that's how these things work. I wish I had the energy and time.
141 2018-06-11T11:47:59  <wumpus> whoa is bitcoinacks correct here https://bitcoinacks.com/?flt1_closed_empty=1&flt0_merged_empty=1&sort=7 none of the open PRs that are non high priority for review have any ACK/NACKs? or is it glitching somehow
142 2018-06-11T11:54:10  <wumpus> nm, got the sorting wrong, phew
143 2018-06-11T11:57:50  *** bitconner has joined #bitcoin-core-dev
144 2018-06-11T11:58:09  <rafalcpp> that Tree-SHA512 format, is something that bitcoin invented, or is it strictly based on some agreed upon convention? (ordering and format of data that is the material to be hashed)?
145 2018-06-11T11:58:37  <wumpus> it's something that was invented for our script AFAIK
146 2018-06-11T12:01:37  *** pergaminho has joined #bitcoin-core-dev
147 2018-06-11T12:01:54  *** pergaminho has quit IRC
148 2018-06-11T12:02:50  *** bitconner has quit IRC
149 2018-06-11T12:06:52  *** bitconner has joined #bitcoin-core-dev
150 2018-06-11T12:08:38  *** Chris_Stewart_5 has quit IRC
151 2018-06-11T12:11:54  *** Kvaciral has quit IRC
152 2018-06-11T12:11:56  *** bitconner has quit IRC
153 2018-06-11T12:13:56  *** grafcaps has joined #bitcoin-core-dev
154 2018-06-11T12:19:11  *** grafcaps has quit IRC
155 2018-06-11T12:21:56  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56f69360dc98...6e249e46789f
156 2018-06-11T12:21:56  <bitcoin-git> bitcoin/master cbede7d Sjors Provoost: [qt] OptionsDialog: add prune setting
157 2018-06-11T12:21:57  <bitcoin-git> bitcoin/master 6e249e4 Wladimir J. van der Laan: Merge #13043: [qt] OptionsDialog: add prune setting...
158 2018-06-11T12:22:35  <bitcoin-git> [bitcoin] laanwj closed pull request #13043: [qt] OptionsDialog: add prune setting (master...2018/04/qt-prune) https://github.com/bitcoin/bitcoin/pull/13043
159 2018-06-11T12:26:22  *** Guyver2 has joined #bitcoin-core-dev
160 2018-06-11T12:34:19  <promag> wumpus: are you available for merges?
161 2018-06-11T12:39:08  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6e249e46789f...531a0337ca93
162 2018-06-11T12:39:08  <bitcoin-git> bitcoin/master fa6edfe MarcoFalke: qa: Remove portseed_offset from test runner
163 2018-06-11T12:39:09  <bitcoin-git> bitcoin/master 531a033 Wladimir J. van der Laan: Merge #13421: qa: Remove portseed_offset from test runner...
164 2018-06-11T12:39:53  <bitcoin-git> [bitcoin] laanwj closed pull request #13421: qa: Remove portseed_offset from test runner (master...Mf1806-qaPortseedOffset) https://github.com/bitcoin/bitcoin/pull/13421
165 2018-06-11T12:43:50  *** Aaronvan_ is now known as AaronvanW
166 2018-06-11T12:44:15  *** SopaXorzTaker has joined #bitcoin-core-dev
167 2018-06-11T12:45:01  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/531a0337ca93...70a03c635b73
168 2018-06-11T12:45:01  <bitcoin-git> bitcoin/master f68049d Cory Fields: crypto: cleanup sha256 build...
169 2018-06-11T12:45:01  <bitcoin-git> bitcoin/master 70a03c6 Wladimir J. van der Laan: Merge #13408: crypto: cleanup sha256 build...
170 2018-06-11T12:45:46  <bitcoin-git> [bitcoin] laanwj closed pull request #13408: crypto: cleanup sha256 build (master...sha2-cleanup) https://github.com/bitcoin/bitcoin/pull/13408
171 2018-06-11T12:49:56  *** bitconner has joined #bitcoin-core-dev
172 2018-06-11T13:00:17  *** str4d has quit IRC
173 2018-06-11T13:01:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
174 2018-06-11T13:05:50  *** drizztbsd is now known as timothy
175 2018-06-11T13:07:15  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/70a03c635b73...26c93edf1de9
176 2018-06-11T13:07:15  <bitcoin-git> bitcoin/master a426098 practicalswift: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
177 2018-06-11T13:07:16  <bitcoin-git> bitcoin/master 26c93ed Wladimir J. van der Laan: Merge #13294: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3...
178 2018-06-11T13:08:03  <bitcoin-git> [bitcoin] laanwj closed pull request #13294: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 (master...openbsd-warnings) https://github.com/bitcoin/bitcoin/pull/13294
179 2018-06-11T13:14:30  *** rafalcpp has quit IRC
180 2018-06-11T13:21:52  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/26c93edf1de9...3f0f39415bd7
181 2018-06-11T13:21:53  <bitcoin-git> bitcoin/master 8160817 John Newbery: [wallet] [rpc] Remove getlabeladdress RPC...
182 2018-06-11T13:21:54  <bitcoin-git> bitcoin/master 67e0e04 John Newbery: [wallet] [docs] Update release notes for removing `getlabeladdress`
183 2018-06-11T13:21:54  <bitcoin-git> bitcoin/master 3f0f394 Wladimir J. van der Laan: Merge #13060: [wallet] [rpc] Remove getlabeladdress RPC...
184 2018-06-11T13:21:56  *** ExtraCrispy has quit IRC
185 2018-06-11T13:22:30  <bitcoin-git> [bitcoin] laanwj closed pull request #13060: [wallet] [rpc] Remove getlabeladdress RPC (master...remove_getlabeladdress) https://github.com/bitcoin/bitcoin/pull/13060
186 2018-06-11T13:22:31  *** ExtraCrispy has joined #bitcoin-core-dev
187 2018-06-11T13:52:45  <wumpus> promag: yes
188 2018-06-11T13:53:31  *** Tralfaz has joined #bitcoin-core-dev
189 2018-06-11T14:04:41  *** AaronvanW has quit IRC
190 2018-06-11T14:15:01  *** AaronvanW has joined #bitcoin-core-dev
191 2018-06-11T14:16:12  <promag> wumpus: #12151
192 2018-06-11T14:16:15  <gribble> https://github.com/bitcoin/bitcoin/issues/12151 | rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
193 2018-06-11T14:17:21  <promag> or #13160
194 2018-06-11T14:17:23  <gribble> https://github.com/bitcoin/bitcoin/issues/13160 | wallet: Unlock spent outputs by promag · Pull Request #13160 · bitcoin/bitcoin · GitHub
195 2018-06-11T14:18:49  <MarcoFalke> promag: #12151 was just pushed, imo not ready for merge
196 2018-06-11T14:18:51  <gribble> https://github.com/bitcoin/bitcoin/issues/12151 | rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
197 2018-06-11T14:19:35  *** AaronvanW has quit IRC
198 2018-06-11T14:20:09  <wumpus> thanks, I'll have a look at those
199 2018-06-11T14:20:36  <promag> MarcoFalke: right, should be re-ack
200 2018-06-11T14:21:39  <promag> MarcoFalke: if you can take a look at 13160 too
201 2018-06-11T14:24:57  *** AaronvanW has joined #bitcoin-core-dev
202 2018-06-11T14:26:35  <bitcoin-git> [bitcoin] laanwj pushed 10 new commits to master: https://github.com/bitcoin/bitcoin/compare/3f0f39415bd7...43ae5ee9e4c2
203 2018-06-11T14:26:36  <bitcoin-git> bitcoin/master b9ef21d Karl-Johan Alm: mempool: Add explicit max_descendants...
204 2018-06-11T14:26:36  <bitcoin-git> bitcoin/master 46847d6 Karl-Johan Alm: mempool: Fix max descendants check...
205 2018-06-11T14:26:37  <bitcoin-git> bitcoin/master 475a385 Karl-Johan Alm: Add GetTransactionAncestry to CTxMemPool for general purpose chain limit checking
206 2018-06-11T14:27:07  <bitcoin-git> [bitcoin] laanwj closed pull request #12634: [refactor] Make TransactionWithinChainLimit more flexible (master...txmempool-chain-limit-value) https://github.com/bitcoin/bitcoin/pull/12634
207 2018-06-11T14:32:17  *** Chris_Stewart_5 has quit IRC
208 2018-06-11T14:37:04  *** JackH has joined #bitcoin-core-dev
209 2018-06-11T14:48:30  <wumpus> #13160 has only my utACK
210 2018-06-11T14:48:34  <gribble> https://github.com/bitcoin/bitcoin/issues/13160 | wallet: Unlock spent outputs by promag · Pull Request #13160 · bitcoin/bitcoin · GitHub
211 2018-06-11T14:48:45  <wumpus> I don't think that's enough for a change in behavior like that
212 2018-06-11T14:49:02  <wumpus> even though code-wise it's very simple to review
213 2018-06-11T14:51:29  *** goatpig has joined #bitcoin-core-dev
214 2018-06-11T14:52:35  *** StopAndDecrypt has quit IRC
215 2018-06-11T14:53:25  *** StopAndDecrypt has joined #bitcoin-core-dev
216 2018-06-11T14:53:35  *** StopAndDecrypt has quit IRC
217 2018-06-11T14:53:35  *** StopAndDecrypt has joined #bitcoin-core-dev
218 2018-06-11T14:53:58  *** Tralfaz has quit IRC
219 2018-06-11T14:54:40  *** Krellan has quit IRC
220 2018-06-11T14:55:24  *** Krellan has joined #bitcoin-core-dev
221 2018-06-11T14:57:05  *** StopAndDecrypt has quit IRC
222 2018-06-11T14:57:25  *** StopAndDecrypt has joined #bitcoin-core-dev
223 2018-06-11T14:57:34  *** StopAndDecrypt has quit IRC
224 2018-06-11T14:57:34  *** StopAndDecrypt has joined #bitcoin-core-dev
225 2018-06-11T15:00:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
226 2018-06-11T15:05:11  *** laurentmt has joined #bitcoin-core-dev
227 2018-06-11T15:06:29  *** grafcaps has joined #bitcoin-core-dev
228 2018-06-11T15:10:09  <sipa> MarcoFalke: you mentioned that fetching PR information from github was the bottleneck for drahtbot? are you using the git interface for PRs?
229 2018-06-11T15:11:01  <MarcoFalke> I do. But I also need to get the open pull requests and metadata for them.
230 2018-06-11T15:12:40  <sipa> hmm
231 2018-06-11T15:13:30  <ken2812221> Hi all. In order to fix #13103, is it allowed to add additional functions and methods like #13426 for Windows, and add macros for other OS? (The first and second commits)
232 2018-06-11T15:13:32  <gribble> https://github.com/bitcoin/bitcoin/issues/13103 | Invalid wallet path with Chinese characters in windows · Issue #13103 · bitcoin/bitcoin · GitHub
233 2018-06-11T15:13:33  <gribble> https://github.com/bitcoin/bitcoin/issues/13426 | [WIP, bugfix] Add u8path and u8string to boost to fix #13103 by ken2812221 · Pull Request #13426 · bitcoin/bitcoin · GitHub
234 2018-06-11T15:14:29  <ken2812221> additional function and method in boost header
235 2018-06-11T15:14:34  <MarcoFalke> And the "Needs rebase" task of DrahtBot is purely based on the api
236 2018-06-11T15:15:17  <MarcoFalke> Since GitHub hasn't yet disclosed which merge tool they use
237 2018-06-11T15:19:29  <sipa> MarcoFalke: seems reasonablw that it's pretty much vanilla git
238 2018-06-11T15:19:49  <sipa> as our merge tool compares the local merge with the github merge
239 2018-06-11T15:19:52  *** laurentmt has quit IRC
240 2018-06-11T15:20:06  <sipa> and afaik never failed for noticing a differencw
241 2018-06-11T15:20:28  <MarcoFalke> They advertise as merge conflict when one of the files got moved
242 2018-06-11T15:20:37  <MarcoFalke> vanilla git doen't afaict
243 2018-06-11T15:21:13  <sipa> hmm
244 2018-06-11T15:32:46  *** grafcaps has quit IRC
245 2018-06-11T15:37:06  *** booyah has joined #bitcoin-core-dev
246 2018-06-11T15:53:06  *** owowo has quit IRC
247 2018-06-11T15:56:53  *** grafcaps has joined #bitcoin-core-dev
248 2018-06-11T15:57:47  *** owowo has joined #bitcoin-core-dev
249 2018-06-11T16:01:32  <echeveria> https://pastebin.com/Ar8cT76q
250 2018-06-11T16:01:45  <echeveria> bitcoind seems to get very sad sometimes if you have a low maxconnections
251 2018-06-11T16:01:45  <ryanofsky> i have a hacky script that checks for merge conflicts reasonably quickly with "git diff | git apply" https://github.com/ryanofsky/home/blob/master/src/pr.sh#L558
252 2018-06-11T16:02:03  *** tryphe has joined #bitcoin-core-dev
253 2018-06-11T16:04:52  *** tryphe_ has quit IRC
254 2018-06-11T16:05:40  *** Krellan has quit IRC
255 2018-06-11T16:08:53  *** Krellan has joined #bitcoin-core-dev
256 2018-06-11T16:10:11  *** ghost43 has quit IRC
257 2018-06-11T16:10:38  *** grafcaps has quit IRC
258 2018-06-11T16:10:54  *** ghost43 has joined #bitcoin-core-dev
259 2018-06-11T16:12:55  *** setpill has quit IRC
260 2018-06-11T16:18:19  <promag> wumpus: I can't reproduce #13111 failures locally
261 2018-06-11T16:18:22  <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
262 2018-06-11T16:18:37  <promag> should retry travis job?
263 2018-06-11T16:26:14  *** grafcaps has joined #bitcoin-core-dev
264 2018-06-11T16:27:09  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13107: Fix Windows locale problem (master...win-enc) https://github.com/bitcoin/bitcoin/pull/13107
265 2018-06-11T16:30:30  *** grafcaps has quit IRC
266 2018-06-11T16:31:30  *** ccdle12 has quit IRC
267 2018-06-11T16:33:15  *** grafcaps has joined #bitcoin-core-dev
268 2018-06-11T16:46:20  *** Purple7 has joined #bitcoin-core-dev
269 2018-06-11T16:47:13  <Purple7> Hi everyone :)
270 2018-06-11T16:48:06  <Purple7> can someone here help me create a bitcoin script. I just installed Bitcoin core node and have tried bitcoin-cli commands
271 2018-06-11T16:48:23  <echeveria> I don't know what you imagine bitcoin script to be capable of.
272 2018-06-11T16:48:30  <Purple7> I want to create a script but not sure how to create one and how to run one
273 2018-06-11T16:48:32  <wumpus> promag: I had some segfaults locally with it, but seems hard to reproduce
274 2018-06-11T16:48:41  <Purple7> to carry out transactions
275 2018-06-11T16:48:45  <echeveria> Purple7: lets do this in #bitcoin.
276 2018-06-11T16:50:00  <promag> wumpus: yes I think I can reproduce now
277 2018-06-11T16:50:13  <Purple7> Thanks echeveria
278 2018-06-11T16:50:14  <Purple7> :)
279 2018-06-11T16:50:40  <promag> wumpus: delete regtest folder, launch, then rpc stop
280 2018-06-11T16:51:02  <promag> looks like that way always segfaults
281 2018-06-11T16:54:06  <Chris_Stewart_5> Is there any ordering required for the rpcport config option? We are seeing behavior where it is being read if passed in as a command line arg but not being recogonized inside of a bitcoin.conf file
282 2018-06-11T16:54:33  *** nmnkgl has joined #bitcoin-core-dev
283 2018-06-11T16:54:50  *** Purple7 has quit IRC
284 2018-06-11T16:56:20  <Chris_Stewart_5> we are reading other config options from the bitcoin.conf file
285 2018-06-11T16:56:25  <Chris_Stewart_5> just not rpcport it seems
286 2018-06-11T16:56:58  <sipa> Chris_Stewart_5: what version of the code?
287 2018-06-11T16:57:04  <Chris_Stewart_5> 0.16.0
288 2018-06-11T16:57:22  <wumpus> rpcport should work fine in the bitcoin.conf, I've had it in there for ages
289 2018-06-11T16:57:54  <wumpus> note that master has per-network config sections, but 0.16 does not
290 2018-06-11T16:58:01  <Chris_Stewart_5> yeah it is pretty bizzare. We are reading other options like daemon=1 in the conf file. Just not the rpcport for some reason
291 2018-06-11T16:58:30  <wumpus> are you really sure? as said, I have a setup myself that uses that
292 2018-06-11T16:58:49  <Chris_Stewart_5> just a sec, I'm double checking he didn't compile from master
293 2018-06-11T16:59:47  <Chris_Stewart_5> nvm, he is on 0.16.99.
294 2018-06-11T17:00:41  <sipa> how do you observe it's not using rpcport?
295 2018-06-11T17:00:46  <wumpus> ok on master you need to put it in a network-specific section, this is described in the doc/release-notes.md
296 2018-06-11T17:00:54  <sipa> wumpus: oh!
297 2018-06-11T17:01:02  *** Rebo has joined #bitcoin-core-dev
298 2018-06-11T17:01:06  <wumpus> it should also warn in the log
299 2018-06-11T17:02:33  <sipa> wumpus: nothing here: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes.md
300 2018-06-11T17:02:36  <Chris_Stewart_5> basically it was always binding to 18433 if we set rpcport via the command line
301 2018-06-11T17:03:03  <Chris_Stewart_5> unless we set it via the command line* sorry
302 2018-06-11T17:04:23  <provoostenator> Anyone else noticed bitcoin-cli crashing on macOS 10.13.5? I had to recompile. It's quite possible I did something stupid unrelated, but seeing c-lightning and random Github projects struggling with macOS 10.13.5, thought I'd check...
303 2018-06-11T17:05:59  <provoostenator> What's stranger - and why I initially assume I did something else wrong: it didn't happen immediately after the upgrade but a few days later, so it may have been a homebrew or xcode update.
304 2018-06-11T17:07:12  <wumpus> sipa: release-notes-pr12823.md apparently
305 2018-06-11T17:07:34  <sipa> oh, i forgot we added pr-specific files
306 2018-06-11T17:08:13  <wumpus> it does make things harder to find
307 2018-06-11T17:09:54  <sipa> wumpus: any opinion about converting the existing sse4 assembly code (which was in 0.16) into intrinsics based code?
308 2018-06-11T17:10:13  <sipa> downside: possibly a bit slower (i've seen up to 4% slower) and compiler dependent
309 2018-06-11T17:10:27  <sipa> upside: more easily reusable, readable, and works on 32-bit systems
310 2018-06-11T17:14:18  <promag> wumpus: found the problem, will push a fix in a separate commit for now
311 2018-06-11T17:18:45  <echeveria> yeah, that's a weird one. I have hardcoded `connect` peers but it doesn't sync.
312 2018-06-11T17:21:12  <echeveria> random peers, syncs perfectly, hardcoded it doesn't sync, even with the same peers.
313 2018-06-11T17:33:03  <wumpus> sipa: no strong opinion on that; 32 bit x86 is very rare so I wouldn't do it for that, given that it's also 4% slower, "do nothing" sounds like a good option to me
314 2018-06-11T17:33:39  *** Krellan has quit IRC
315 2018-06-11T17:35:04  <gmaxwell> 22:50:10 < gmaxwell> sipa: you created a 32-byte version of the specialized 1-way SSE4 asm?
316 2018-06-11T17:35:35  <sipa> gmaxwell: no, not specialized
317 2018-06-11T17:36:20  <sipa> we just have a benchmark for SHA256 with 32-byte inputs, and that benchmark shows a slowdown when going from asm-based 1-way SSE4 to intrin-based 1-way SSE4
318 2018-06-11T17:39:11  *** JackH_ has joined #bitcoin-core-dev
319 2018-06-11T17:40:31  <sipa> gmaxwell: also, the speedup from the 1-way SSE4 is pretty neat: it does the expansion for rounds X+16...X+19 in SSE registers simultaneously, interleaved with an otherwise totally ordinary implementation for rounds X..X+3
320 2018-06-11T17:40:51  *** JackH has quit IRC
321 2018-06-11T17:43:23  <wumpus> I wonder, is anyone using 32-bit x86 for bitcoin nodes? the last 32-bit-only x86 CPU was sold in 2008 or so, 10 years ago now
322 2018-06-11T17:43:46  <sipa> wumpus: ah, but those don't even have SSE4 :)
323 2018-06-11T17:44:04  <sipa> the only use for SSE4 in 32-bit mode is people running a 32-bit binary on 64-bit hardware
324 2018-06-11T17:44:05  <wumpus> too bad we don't have statistics how much those get downloaded
325 2018-06-11T17:44:26  <wumpus> right
326 2018-06-11T17:44:59  <sipa> my goal in converting to intrinsics was making it reusable for specialized 32-byte or 64-byte inputs; we can leave the original untouched of course, and only have intrinsics based versions for the specialized versions
327 2018-06-11T17:46:56  <wumpus> for that it certainly makes sense, easier to specialize code w/ intrinsics than manual register allocation
328 2018-06-11T17:48:21  *** JackH_ has quit IRC
329 2018-06-11T17:48:33  <sipa> i also wonder what to do about CI for special hardware
330 2018-06-11T17:48:42  *** JackH has joined #bitcoin-core-dev
331 2018-06-11T17:48:43  <sipa> SHA-NI is unlikely to be available on any Travis system
332 2018-06-11T17:48:59  <sipa> and POWER9 would surprise me even more :D
333 2018-06-11T17:51:21  <luke-jr> test these things more carefully when they change?
334 2018-06-11T17:51:34  <wumpus> it's the same case as platforms such as FreeBSD and OpenBSD, we'll have to rely on people regularly compilng and testing master with them
335 2018-06-11T17:51:51  <luke-jr> well, at least the platform-specific stuff in this case is isolated
336 2018-06-11T17:52:04  <sipa> i'm also going to extend the self-test code for these
337 2018-06-11T17:52:18  <sipa> so at least it will fail at startup rather than arbitrarily
338 2018-06-11T17:52:43  <wumpus> it's notrealistic to have CI for all OS/architecture combinations, not even all OSes and architectures separately
339 2018-06-11T17:53:23  <wumpus> I still have a PR open to run travis on at least one bigendian platform, but even that seems untenable
340 2018-06-11T17:53:26  <luke-jr> maybe if someone were to volunteer to maintain a CI system for us that does all that, but yeah, probably not with Travis
341 2018-06-11T17:53:45  <wumpus> it's not realistic to do that for every PR, sure, some daily cron job would work
342 2018-06-11T18:01:17  <MarcoFalke> Apparently we have  some jenkins running somewhere, maybe jamesob can see if that would work with FreeBSD/OpenBSD
343 2018-06-11T18:01:32  <MarcoFalke> SHA-NI and POWER9 should already be tested by devs regularly, no?
344 2018-06-11T18:03:07  *** satwo has joined #bitcoin-core-dev
345 2018-06-11T18:03:34  <gmaxwell> with jenkins it would be as simple as adding a ssh key on a host and telling jenkins to use it as a remote. I guess travis doesn't have a similar facility for non-travis build hosts?
346 2018-06-11T18:04:19  <jamesob> gmaxwell: travis is limited to execution on their infra AFAICT
347 2018-06-11T18:04:32  <MarcoFalke> I think so as well ^
348 2018-06-11T18:05:13  *** drexl has joined #bitcoin-core-dev
349 2018-06-11T18:06:03  <gmaxwell> in any case, I assume jenkins hosts will have sha-ni sometime, for now we'll just have to count on developers (lol, pieter is the only person I know with it right now.) catching it.
350 2018-06-11T18:06:09  <wumpus> in theory it's possible to ssh out from travis, but that sounds horribly fragile
351 2018-06-11T18:06:19  <wumpus> (also, key management is a problem)
352 2018-06-11T18:07:02  <gmaxwell> for jenkins the integration is super nice, it's not just 'sshing out' but once you give jenkins access it does all the stuff to properly use it as a build host automagically. (wow, java actually useful for something)
353 2018-06-11T18:08:32  <wumpus> right, that sounds better
354 2018-06-11T18:10:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (master...Mf1806-walletPrunedFundsSegfault) https://github.com/bitcoin/bitcoin/pull/13437
355 2018-06-11T18:10:06  <luke-jr> MarcoFalke: I should be moving my development to my POWER9 system in this next week
356 2018-06-11T18:10:22  <MarcoFalke> luke-jr: Good to hear
357 2018-06-11T18:10:34  <MarcoFalke> Also BlueMatt switched to POWER9
358 2018-06-11T18:11:12  <cfields> sipa: fwiw, I now fully understand the 1way sha2 optims for sse4/avx. I started working on the intrinsics over the weekend
359 2018-06-11T18:11:28  <sipa> cfields: too late :)
360 2018-06-11T18:11:30  <cfields> sipa: just thought I'd mention in case you were also looking at it
361 2018-06-11T18:11:42  <cfields> oh?
362 2018-06-11T18:11:52  <cfields> heh, did I miss a PR?
363 2018-06-11T18:11:54  <sipa> cfields: i have intrinsics based 1-way sse4 working
364 2018-06-11T18:11:56  <sipa> not PRed yet
365 2018-06-11T18:12:28  <sipa> sorry, didn't know you were planning to work on it so soon as well
366 2018-06-11T18:12:47  <cfields> sipa: no worries. Now I can pick yours apart :p
367 2018-06-11T18:13:32  <BlueMatt> yea, POWER9 should get pretty good testing, sdaftuar and I have already been using it for some time now
368 2018-06-11T18:13:37  <provoostenator> cfields: or work on #13401
369 2018-06-11T18:13:38  <gribble> https://github.com/bitcoin/bitcoin/issues/13401 | ARMv8 sha2 support · Issue #13401 · bitcoin/bitcoin · GitHub
370 2018-06-11T18:13:40  <provoostenator> :-)
371 2018-06-11T18:13:51  <BlueMatt> and I think we might be getting a shared test box on it soonish if people want to get an ssh key to have access to it
372 2018-06-11T18:15:33  <gmaxwell> sipa: would the 1-way sha2 be more efficient for longer inputs if it processed more blocks at once?
373 2018-06-11T18:15:48  <gmaxwell> (e.g. could it be expanding the next group)
374 2018-06-11T18:18:36  <sipa> gmaxwell: hmm, yes!
375 2018-06-11T18:18:38  <cfields> sipa: did you include the lane duplication optim for quicker rotates?
376 2018-06-11T18:19:03  <sipa> cfields: i literally translated the asm code instruction per instruction to intrinsics
377 2018-06-11T18:19:15  <sipa> and then restructured it into functions that make sense
378 2018-06-11T18:19:23  <provoostenator> What does "1-way" mean in the context of a SHA256 hash?
379 2018-06-11T18:19:34  <cfields> sipa: ah, I think some of that will pessimize avx though, no?
380 2018-06-11T18:19:40  <cfields> I guess I'll wait to see it
381 2018-06-11T18:20:01  <gmaxwell> provoostenator: computing one hash at a time, as opposted to concurrently computing many hashes.
382 2018-06-11T18:20:20  <sipa> cfields: recompiling this code with -mavx gains virtually no advantage
383 2018-06-11T18:20:52  <sipa> provoostenator: say you have 8 64-byte vectors, and want to independently compute the 8 32-byte hashes of those
384 2018-06-11T18:20:59  <sipa> provoostenator: we have a specialized function that does that
385 2018-06-11T18:21:07  <sipa> that's 8-way
386 2018-06-11T18:21:38  <cfields> sipa: hmm, that's really surprising.
387 2018-06-11T18:21:44  <provoostenator> Ah ok, so that's useful if you're able to do some of the validation stuff in parallel?
388 2018-06-11T18:22:59  <sipa> provoostenator: it's currently used (in master) for merkle tree root computations
389 2018-06-11T18:26:09  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/43ae5ee9e4c2...7c32b414b632
390 2018-06-11T18:26:10  <bitcoin-git> bitcoin/master 906bee8 practicalswift: Use bracket syntax includes ("#include <foo.h>")
391 2018-06-11T18:26:10  <bitcoin-git> bitcoin/master 6d10f43 practicalswift: Enforce the use of bracket syntax includes ("#include <foo.h>")
392 2018-06-11T18:26:11  <bitcoin-git> bitcoin/master 16e3cd3 practicalswift: Clarify include recommendation
393 2018-06-11T18:26:40  <gmaxwell> in theory we could also use them for hashing a bunch of transactions at once, but handling the variable length stuff is slightly gnarly.
394 2018-06-11T18:26:43  <provoostenator> sipa: why not in script validation? Not worth it or still on todo lists?
395 2018-06-11T18:26:46  <cfields> sipa: no clue if it's still state-of-the-art, but this is what I was using as a basis for understanding/implementing multi-block speedup: https://eprint.iacr.org/2012/067.pdf
396 2018-06-11T18:26:50  <bitcoin-git> [bitcoin] laanwj closed pull request #13230: Simplify include analysis by enforcing the developer guide's include syntax (master...bracket-syntax-includes) https://github.com/bitcoin/bitcoin/pull/13230
397 2018-06-11T18:26:56  <cfields> gmaxwell: ^^
398 2018-06-11T18:27:07  <sipa> provoostenator: todo list
399 2018-06-11T18:27:31  <gmaxwell> provoostenator: yes, it could be done, but it requires having things aranged so there are multiple messages to hash all ready to hash at once.
400 2018-06-11T18:27:49  <gmaxwell> So easiest was hashtrees, since that all gets computed at once.
401 2018-06-11T18:27:54  <provoostenator> Right now script validation can is done in parallel on _multiple_ cpu's, rather than on a single one?
402 2018-06-11T18:28:33  <cfields> (ofc that's separate from the per-block optimizations)
403 2018-06-11T18:28:45  <cfields> provoostenator: yes
404 2018-06-11T18:30:23  <provoostenator> But if you verify e.g. 8 scripts in parallel on the same core to take advantage of that 256 optimzation, I guess the risk is that these cores are just sitting there waiting for these 8 threads to be ready?
405 2018-06-11T18:30:50  <provoostenator> If they're not otherwise identical.
406 2018-06-11T18:31:10  <provoostenator> But 1-way doesn't change anything
407 2018-06-11T18:33:33  <gmaxwell> provoostenator: using n-at-a-time hashing requires restructing code so that it actually has n things to hash available at a time.  Script validation doesn't work that way today and would need significant overhalls to make use of it.
408 2018-06-11T18:35:04  *** ExtraCrispy has quit IRC
409 2018-06-11T18:45:45  *** Rebo has quit IRC
410 2018-06-11T18:59:15  <cfields> sipa: would you be ok with a separate avx-optimized version of those intrinsics if the speedup was as significant as before?
411 2018-06-11T19:00:39  *** str4d has joined #bitcoin-core-dev
412 2018-06-11T19:00:43  *** jhfrontz has quit IRC
413 2018-06-11T19:01:02  *** jhfrontz has joined #bitcoin-core-dev
414 2018-06-11T19:03:46  <sipa> cfields: the avx speedup is for the 4-way sse4, not the 1-way sse4 code
415 2018-06-11T19:03:49  <sipa> cfields: and yes
416 2018-06-11T19:04:07  *** ^nix has joined #bitcoin-core-dev
417 2018-06-11T19:04:28  <cfields> sipa: there are definitely 1way speedups due to non-destructive xor's
418 2018-06-11T19:05:10  *** dariusmaximus has joined #bitcoin-core-dev
419 2018-06-11T19:07:03  <sipa> cfields: ah, the compiler may not be smart enough to use those?
420 2018-06-11T19:07:32  <cfields> sipa: I really would've expected it to, since there's not a separate intrinsic for them
421 2018-06-11T19:07:41  <cfields> it might be how the other registers are setup, though
422 2018-06-11T19:08:43  *** SopaXorzTaker has quit IRC
423 2018-06-11T19:09:07  <cfields> the sigma1 implementation for sse4, for example, duplicates data in 2 registers so that it can do quicker but destructive rotates. Avx doesn't need to do that, so the duplication is strictly a slowdown.
424 2018-06-11T19:09:47  <sipa> cfields: i'll cleanup my code and PR
425 2018-06-11T19:10:38  <cfields> ok
426 2018-06-11T19:10:52  <bitcoin-git> [bitcoin] sipa opened pull request #13438: Improve coverage of SHA256 SelfTest code (master...201806_selftestsha) https://github.com/bitcoin/bitcoin/pull/13438
427 2018-06-11T19:11:32  <cfields> sipa: thanks for that :)
428 2018-06-11T19:12:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13395: rpc: Avoid "duplicate" return value for invalid submitblock (master...Mf1806-rpcMiningSubmitblock) https://github.com/bitcoin/bitcoin/pull/13395
429 2018-06-11T19:17:45  *** nmnkgl has quit IRC
430 2018-06-11T19:22:02  <provoostenator> Any other live metrics I should collect on my slow pruned AWS node? https://github.com/bitcoin/bitcoin/pull/12404#issuecomment-396356384
431 2018-06-11T19:24:17  <gmaxwell> cfields: so somewhere intel has published sse4/avx/avx2 code (which is where our 1-way sse4 comes from) when we previously benchmarked the avx code we found that it was a couple percent faster on intel but a lot slower on AMD.
432 2018-06-11T19:24:54  <gmaxwell> cfields: I don't see any problem with having a seperate AVX version but we would need to deal with not choosing it on AMD somehow, if its slower there.
433 2018-06-11T19:25:05  <cfields> gmaxwell: do you mean intel's modified Sigma0/Sigma1 ?
434 2018-06-11T19:25:43  <gmaxwell> I don't know what optimizations it had inside it, IIRC it was the same code intel submitted for the linux kernel (the kernel can realistically benchmark to decide what code to use, not as reasonable for us)
435 2018-06-11T19:25:46  <cfields> if so, yea, most of the code I've found in the wild opts out of those for that reason
436 2018-06-11T19:26:15  <cfields> gmaxwell: I'm guessing it's what I PR'd, which we closed for that reason :(
437 2018-06-11T19:26:57  <gmaxwell> for us we could decide to use some AVX version that was faster on intel by string matching the cpu version and only using it on intel chips.  But if it's only a couple percent it might not be worth it.
438 2018-06-11T19:27:10  <gmaxwell> ESP since anything with AVX is pretty quick regardless.
439 2018-06-11T19:28:03  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #13439: rpc: Avoid "duplicate" return value for invalid submitblock (master...2018-06-marcos-submitblock-fix) https://github.com/bitcoin/bitcoin/pull/13439
440 2018-06-11T19:28:43  *** ghost43 has quit IRC
441 2018-06-11T19:28:58  *** ghost43 has joined #bitcoin-core-dev
442 2018-06-11T19:31:23  <cfields> gmaxwell: agreed. I'd rather avoid per-vendor optims unless it's really really significant
443 2018-06-11T19:31:37  <cfields> might be harder to avoid that if we get into arm, though
444 2018-06-11T19:32:06  <gmaxwell> for arm it's more worth it...
445 2018-06-11T19:32:26  <gmaxwell> even a small percantage change is a large absolute time there.
446 2018-06-11T19:35:01  <cfields> fair point.
447 2018-06-11T19:35:19  <cfields> gmaxwell: #13400 is what I was referencing, btw. Hopefully that's the same one as the kernel discussion you had in mind.
448 2018-06-11T19:35:21  <gribble> https://github.com/bitcoin/bitcoin/issues/13400 | sha256: small speedup for sse4 path. by theuni · Pull Request #13400 · bitcoin/bitcoin · GitHub
449 2018-06-11T19:35:30  <gmaxwell> cfields: I guess for AVX ... Intel x86_64 cpus with AVX but without AVX2 or SHA-NI are _very_ common. I'd guess they outnumber all other kinds in our deployment by a large margin.
450 2018-06-11T19:36:22  *** bitconner has quit IRC
451 2018-06-11T19:37:37  <cfields> huh, I figured my Sandy Bridge was the outlier
452 2018-06-11T19:40:23  <gmaxwell> AVX2 is only haswell and later on intel, and the xeons lag desktops in microarch by a couple years.
453 2018-06-11T19:56:00  *** tryphe_ has joined #bitcoin-core-dev
454 2018-06-11T19:58:34  *** tryphe has quit IRC
455 2018-06-11T19:58:43  *** bitconner has joined #bitcoin-core-dev
456 2018-06-11T20:15:22  *** nmnkgl has joined #bitcoin-core-dev
457 2018-06-11T20:19:29  *** OS-11936 has joined #bitcoin-core-dev
458 2018-06-11T20:20:07  *** OS-11936 has quit IRC
459 2018-06-11T20:22:47  *** str4d has quit IRC
460 2018-06-11T20:24:27  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13440: qa: Log as utf-8 (master...Mf1806-qaLogUtf8) https://github.com/bitcoin/bitcoin/pull/13440
461 2018-06-11T20:37:10  *** Cheeseo has joined #bitcoin-core-dev
462 2018-06-11T20:37:13  *** Krellan has joined #bitcoin-core-dev
463 2018-06-11T20:41:37  *** Krellan has quit IRC
464 2018-06-11T20:49:00  *** edgar_ has joined #bitcoin-core-dev
465 2018-06-11T20:53:45  <edgar_> hello
466 2018-06-11T20:54:12  *** edgar_ has left #bitcoin-core-dev
467 2018-06-11T21:02:10  *** gloata has quit IRC
468 2018-06-11T21:12:22  *** Cheeseo has quit IRC
469 2018-06-11T21:23:29  *** CubicEarths has quit IRC
470 2018-06-11T21:23:54  *** ^nix has quit IRC
471 2018-06-11T21:25:39  *** CubicEarths has joined #bitcoin-core-dev
472 2018-06-11T21:28:02  <bitcoin-git> [bitcoin] achow101 opened pull request #13441: Prevent shared conf files from failing with different available options in different binaries (master...gargs-disabled-options) https://github.com/bitcoin/bitcoin/pull/13441
473 2018-06-11T21:28:38  <achow101> ossifrage: provoostenator: ^ that PR should fix the problem with the options
474 2018-06-11T21:30:50  *** CubicEarths has quit IRC
475 2018-06-11T21:36:43  *** CubicEarths has joined #bitcoin-core-dev
476 2018-06-11T21:43:16  *** satwo has quit IRC
477 2018-06-11T21:53:36  *** timothy has quit IRC
478 2018-06-11T22:05:18  *** Guyver2 has quit IRC
479 2018-06-11T22:11:44  *** Guest99396 is now known as Guest47913
480 2018-06-11T22:12:59  *** Guest47913 is now known as eenoch
481 2018-06-11T22:13:29  *** eenoch is now known as Guest25972
482 2018-06-11T22:13:44  *** Guest25972 is now known as Guest47913
483 2018-06-11T22:17:31  *** Guest47913 has quit IRC
484 2018-06-11T22:17:46  *** eenoch_ has joined #bitcoin-core-dev
485 2018-06-11T22:25:50  *** Sinclair6 has joined #bitcoin-core-dev
486 2018-06-11T22:42:35  *** snickerfritz has joined #bitcoin-core-dev
487 2018-06-11T22:42:35  *** snickerfritz has quit IRC
488 2018-06-11T22:42:35  *** snickerfritz has joined #bitcoin-core-dev
489 2018-06-11T22:53:29  *** AaronvanW has quit IRC
490 2018-06-11T23:04:11  *** AaronvanW has joined #bitcoin-core-dev
491 2018-06-11T23:08:55  *** AaronvanW has quit IRC
492 2018-06-11T23:09:18  <sipa> gmaxwell: got it faster than the asm version now
493 2018-06-11T23:09:29  <sipa> 3.68 ms vs 3.77 ms
494 2018-06-11T23:09:34  <sipa> on i7
495 2018-06-11T23:20:17  *** AaronvanW has joined #bitcoin-core-dev
496 2018-06-11T23:35:12  *** promag has quit IRC
497 2018-06-11T23:37:00  <bitcoin-git> [bitcoin] sipa opened pull request #13442: Convert the 1-way SSE4 SHA256 code from asm to intrinsics (master...201806_sse4intrin) https://github.com/bitcoin/bitcoin/pull/13442
498 2018-06-11T23:37:50  <cfields> sipa: nice
499 2018-06-11T23:38:32  <cfields> sipa: and it looks like it should be friendlier to avx now. Was that purposeful, or nice side-effect?
500 2018-06-11T23:38:45  <sipa> cfields: i don't know why or how
501 2018-06-11T23:38:50  <sipa> elaborate please :)
502 2018-06-11T23:40:08  <sipa> cfields: it's crazy how much the compiler affects things, though
503 2018-06-11T23:40:19  <sipa> in one place changing a constant from const to static const made it 10% slower
504 2018-06-11T23:40:33  <sipa> in another place changing it from static const to const made it 3% slower
505 2018-06-11T23:40:42  <cfields> sipa: yea, I was going to ask you if the ordering really matters, I assume the compiler will reorder as it sees fit
506 2018-06-11T23:40:54  <cfields> huh
507 2018-06-11T23:40:54  *** Victorsueca has quit IRC
508 2018-06-11T23:41:36  <sipa> generally reordering seems to have only a marginal affect, to none at all
509 2018-06-11T23:41:45  <sipa> changing the types of constants and variables has a large affect
510 2018-06-11T23:42:04  *** Victorsueca has joined #bitcoin-core-dev
511 2018-06-11T23:42:08  <cfields> interesting, I would've thought the interleaving timing was the crucial part
512 2018-06-11T23:42:12  <sipa> (the trick with Ws, as opposed to just keeping it as a __m128i and extracting the elements from it, does have a different)
513 2018-06-11T23:42:25  <sipa> oh, the interleaving is absolutely crucial
514 2018-06-11T23:42:27  <cfields> ...I guess it probably is, but you have to fight the compiler to get there first
515 2018-06-11T23:42:31  <sipa> but the compiler reorders things anyway
516 2018-06-11T23:42:40  <sipa> regardless of how you write it... to an extent
517 2018-06-11T23:43:45  <cfields> sipa: by avx-friendly, I mean that you pass variables in which may or may not be overwritten, based on what instructions are available
518 2018-06-11T23:43:51  <cfields> for example: XTMP0 = Palignr(X3, X2, 4);
519 2018-06-11T23:44:19  *** Krellan has joined #bitcoin-core-dev
520 2018-06-11T23:44:23  <sipa> cfields: heh, SSA transformation will destroy that
521 2018-06-11T23:44:40  <sipa> don't assume the compiler will map every variable to a single register all of the time
522 2018-06-11T23:45:02  <cfields> ofc, I just mean that it has the option with avx
523 2018-06-11T23:45:08  <sipa> even if you write things in a A = f(A, B) form everywhere, the compiler may still store the resulting A in a different register than the source A
524 2018-06-11T23:45:17  <sipa> yes, but the way the code is written shouldn't affect that at all
525 2018-06-11T23:45:43  <sipa> the SSA transform will effectively turn every assignment to a variable into a new variable, from the compiler's perspective
526 2018-06-11T23:46:31  <cfields> I see
527 2018-06-11T23:48:49  <sipa> with -msse4.1: 3.68ms
528 2018-06-11T23:48:56  <sipa> with -mavx: 3.54ms
529 2018-06-11T23:49:00  *** Krellan has quit IRC
530 2018-06-11T23:49:56  <cfields> sipa: huh, odd. I get a massive speedup with avx
531 2018-06-11T23:50:10  <cfields> SHA256D64_1024, 20, 7400, 123.736, 0.000835992, 0.000836151, 0.000836061
532 2018-06-11T23:50:20  <cfields> SHA256D64_1024, 20, 7400, 73.563, 0.000496887, 0.000497227, 0.000497053
533 2018-06-11T23:53:57  <sipa> cfields: oh, i was looking at the SHA256 benchmark