1 2018-06-18T00:01:31  *** nuke_bloodaxe has quit IRC
  2 2018-06-18T00:02:58  *** Emcy has quit IRC
  3 2018-06-18T00:35:17  <bitcoin-git> [bitcoin] qmma70 opened pull request #13490: Rewind when active block tip is higher than nStopAtHeight (master...rewind) https://github.com/bitcoin/bitcoin/pull/13490
  4 2018-06-18T00:38:49  <gmaxwell> uh, that would make stop at height less useful for me. :(
  5 2018-06-18T00:39:43  <gmaxwell> sjors request for a 'determinstic blockchain snapshot' as I understand what he's saying  wouldn't be achieved by that
  6 2018-06-18T00:44:24  <sipa> isn't there an easier solution to make sure ABC just doesn't pass the stopatheight value?
  7 2018-06-18T00:45:53  <luke-jr> or just have a tx spend index, so we can calculate past UTXO states if that's the goal
  8 2018-06-18T00:46:42  <gmaxwell> why tie it with stop at height, we could have a version of invalidateblock that rewinds to a particular block.
  9 2018-06-18T00:47:38  <sipa> well the fact that -stopatheight doesn't actually stop at that height is a bug afaik, and it should be fixed
 10 2018-06-18T00:47:59  <sipa> but going past it and then rolling back seems like an enormously roundabout way of accomplishing that
 11 2018-06-18T00:48:39  <gmaxwell> ::nods::
 12 2018-06-18T00:51:59  <sipa> actually i don't understand how this is possible at all, except in case there is a reorg just around that height
 13 2018-06-18T00:53:10  *** jtimon has quit IRC
 14 2018-06-18T00:54:53  *** belcher has joined #bitcoin-core-dev
 15 2018-06-18T00:55:41  *** promag has quit IRC
 16 2018-06-18T00:55:56  *** promag has joined #bitcoin-core-dev
 17 2018-06-18T00:56:04  <gmaxwell> in any case if someone needs a utxo set at a particular place it should be triggered by blockhash
 18 2018-06-18T01:01:12  <bitcoin-git> [bitcoin] sipa opened pull request #13491: Improve handling of INVALID in IsMine (master...201806_cleanmine) https://github.com/bitcoin/bitcoin/pull/13491
 19 2018-06-18T01:46:05  *** fanquake has joined #bitcoin-core-dev
 20 2018-06-18T01:49:45  *** meshcollider has quit IRC
 21 2018-06-18T01:50:47  <bitcoin-git> [bitcoin] promag opened pull request #13492: Fix reply not sent when event loop terminates prematurely (master...2018-06-http-shutdown) https://github.com/bitcoin/bitcoin/pull/13492
 22 2018-06-18T01:58:34  *** promag has quit IRC
 23 2018-06-18T02:00:40  *** str4d has joined #bitcoin-core-dev
 24 2018-06-18T02:01:35  *** promag has joined #bitcoin-core-dev
 25 2018-06-18T02:10:06  *** promag has quit IRC
 26 2018-06-18T02:20:46  *** promag has joined #bitcoin-core-dev
 27 2018-06-18T02:22:21  *** str4d has quit IRC
 28 2018-06-18T02:25:46  *** promag has quit IRC
 29 2018-06-18T02:26:50  *** TESTA has quit IRC
 30 2018-06-18T02:36:30  *** justanotheruser has quit IRC
 31 2018-06-18T02:37:15  *** justan0theruser has joined #bitcoin-core-dev
 32 2018-06-18T02:37:31  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13485: Ensure that http event loop is empty before the loop exit (master...http_shutdown) https://github.com/bitcoin/bitcoin/pull/13485
 33 2018-06-18T03:09:36  *** fanquake has quit IRC
 34 2018-06-18T03:09:54  *** fanquake has joined #bitcoin-core-dev
 35 2018-06-18T03:10:39  *** fanquake has joined #bitcoin-core-dev
 36 2018-06-18T03:11:30  *** fanquake has joined #bitcoin-core-dev
 37 2018-06-18T03:12:15  *** fanquake has joined #bitcoin-core-dev
 38 2018-06-18T03:12:43  *** fanquake has quit IRC
 39 2018-06-18T03:16:44  *** fanquake has joined #bitcoin-core-dev
 40 2018-06-18T03:31:11  *** Victorsueca has quit IRC
 41 2018-06-18T03:32:32  *** Victorsueca has joined #bitcoin-core-dev
 42 2018-06-18T03:36:58  *** goatpig has joined #bitcoin-core-dev
 43 2018-06-18T04:00:32  *** fanquake has quit IRC
 44 2018-06-18T04:05:27  *** intcat has quit IRC
 45 2018-06-18T04:06:21  *** intcat has joined #bitcoin-core-dev
 46 2018-06-18T04:13:24  *** Krellan has quit IRC
 47 2018-06-18T04:14:07  *** Krellan has joined #bitcoin-core-dev
 48 2018-06-18T04:35:03  <bitcoin-git> [bitcoin] fanquake opened pull request #13493: gui: Add leading 0 to QT_VERSION check for QFontDatabase (master...remove-qtversion-qfontdatabase) https://github.com/bitcoin/bitcoin/pull/13493
 49 2018-06-18T05:07:17  *** unholymachine has quit IRC
 50 2018-06-18T05:16:43  *** Emcy has joined #bitcoin-core-dev
 51 2018-06-18T06:02:24  *** justan0theruser has quit IRC
 52 2018-06-18T06:02:47  *** justanotheruser has joined #bitcoin-core-dev
 53 2018-06-18T07:41:28  *** setpill has joined #bitcoin-core-dev
 54 2018-06-18T07:51:01  *** laurentmt has joined #bitcoin-core-dev
 55 2018-06-18T07:56:14  *** laurentmt has quit IRC
 56 2018-06-18T08:06:07  *** HearingVo has joined #bitcoin-core-dev
 57 2018-06-18T08:06:17  <HearingVo> Can someone provide me with some BitCoin?
 58 2018-06-18T08:08:34  *** Victorsueca has quit IRC
 59 2018-06-18T08:10:01  *** Victorsueca has joined #bitcoin-core-dev
 60 2018-06-18T08:11:05  *** timothy has joined #bitcoin-core-dev
 61 2018-06-18T08:15:35  *** drizztbsd has joined #bitcoin-core-dev
 62 2018-06-18T08:16:34  *** timothy has quit IRC
 63 2018-06-18T08:19:01  *** d9b4bef9 has quit IRC
 64 2018-06-18T08:20:08  *** d9b4bef9 has joined #bitcoin-core-dev
 65 2018-06-18T08:22:42  *** setpill has quit IRC
 66 2018-06-18T08:24:10  *** setpill has joined #bitcoin-core-dev
 67 2018-06-18T08:29:56  *** promag has joined #bitcoin-core-dev
 68 2018-06-18T08:35:42  *** rk3y has quit IRC
 69 2018-06-18T08:35:43  *** rk3y has joined #bitcoin-core-dev
 70 2018-06-18T08:39:28  *** HearingVo has left #bitcoin-core-dev
 71 2018-06-18T08:48:46  <promag> jonasschnelli: friendly ping #13111
 72 2018-06-18T08:48:49  <gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
 73 2018-06-18T08:54:59  *** setpill has quit IRC
 74 2018-06-18T08:56:02  *** rafalcpp has joined #bitcoin-core-dev
 75 2018-06-18T08:56:19  *** setpill has joined #bitcoin-core-dev
 76 2018-06-18T09:03:57  *** setpill has quit IRC
 77 2018-06-18T09:04:26  *** setpill has joined #bitcoin-core-dev
 78 2018-06-18T09:11:35  *** AaronvanW has joined #bitcoin-core-dev
 79 2018-06-18T09:16:37  *** Deinogalerix21 has joined #bitcoin-core-dev
 80 2018-06-18T09:19:01  *** Aaronvan_ has joined #bitcoin-core-dev
 81 2018-06-18T09:20:44  *** Aaronvan_ is now known as AaronvanW_
 82 2018-06-18T09:22:09  *** AaronvanW has quit IRC
 83 2018-06-18T09:24:34  *** jtimon has joined #bitcoin-core-dev
 84 2018-06-18T09:30:56  *** fanquake has joined #bitcoin-core-dev
 85 2018-06-18T09:33:18  *** Deinogalerix21 has quit IRC
 86 2018-06-18T09:38:28  *** fanquake has quit IRC
 87 2018-06-18T09:43:42  *** gnappuraz has joined #bitcoin-core-dev
 88 2018-06-18T09:44:21  <gnappuraz> Hi, I have a question regarding some bitcoin source code i'm trying to understand. Is this the right place?
 89 2018-06-18T09:49:14  *** Deinogalerix21 has joined #bitcoin-core-dev
 90 2018-06-18T09:51:19  <jonasschnelli> promag: Yes. Will review this afternoon
 91 2018-06-18T09:51:40  <promag> gnappuraz: just ask
 92 2018-06-18T09:51:43  <promag> jonasschnelli: nice
 93 2018-06-18T09:53:46  *** Deinogalerix21 has quit IRC
 94 2018-06-18T09:54:40  <gnappuraz> I was looking at the wallet.h file, there is a mapWallet map<uint256, CWalletTx>... I was trying to figure out what this map exactly contains
 95 2018-06-18T09:56:08  <gnappuraz> it seems the main memory storage to bookkeep the transactions seen so far. Not sure if invalid txs and txs from forks are there too though
 96 2018-06-18T09:58:02  <jonasschnelli> gnappuraz: What do you mean with invalid txns?
 97 2018-06-18T09:58:21  <jonasschnelli> Yes. It is the main storage for transactions filtered out of the blockchain and mempool that are relevant to the wallet keys
 98 2018-06-18T09:58:48  <gnappuraz> also orphans?
 99 2018-06-18T09:58:52  <jonasschnelli> But they are checked for confirmation or conflicts during presentation... so you can't assume that all transactions in mapWallet are confirmed, etc.
100 2018-06-18T09:58:56  <jonasschnelli> Orphans possible, yes.
101 2018-06-18T09:59:04  <gnappuraz> ok thank you very much!
102 2018-06-18T09:59:28  <jonasschnelli> Its just a set of transactions that have relevance to your keys/scripts in your wallet...
103 2018-06-18T09:59:57  <jonasschnelli> If you want to render a balance, etc. you need to check / calculate if the transactions counts, etc.
104 2018-06-18T10:00:03  <gnappuraz> if instead I need to fetch txs that are not related to my wallet?
105 2018-06-18T10:00:50  <jonasschnelli> gnappuraz: depends... if you know the blockhash/heigh and the txid, you can use getrawtransaction
106 2018-06-18T10:01:04  <jonasschnelli> If you only know the txid, you may need the -txindex=1 (enabled tx index)
107 2018-06-18T10:01:34  <gnappuraz> right, thanks
108 2018-06-18T10:02:00  <jonasschnelli> The wallet is a partial indexing service for the blockchain,... it "indexes" transactions relevant to the keys/scripts in the wallet
109 2018-06-18T10:02:17  <jonasschnelli> (it not only indexes, it "extracts" the transactions)
110 2018-06-18T10:02:30  <gnappuraz> i understand
111 2018-06-18T10:31:26  *** fanquake has joined #bitcoin-core-dev
112 2018-06-18T10:31:45  <fanquake> wumpus: You commented on the wrong PR re squashing commits
113 2018-06-18T10:41:01  <wumpus> fanquake: yep, resolved now
114 2018-06-18T10:45:02  <fanquake> qt4 changes looking good
115 2018-06-18T10:46:02  <fanquake> managed to engage the wrong @wumpus again
116 2018-06-18T10:46:38  <promag> thanks jonas, will sort it out
117 2018-06-18T10:57:52  *** setpill has quit IRC
118 2018-06-18T10:58:13  <fanquake> provoostenator: As far as I can tell I've gotten ios cross builds working. Will PR some depends changes shortly.
119 2018-06-18T10:58:19  *** setpill has joined #bitcoin-core-dev
120 2018-06-18T11:14:37  <murrayn> was there not a time, not so long ago, where transaction age was a factor in prioritization? am i misremembering?
121 2018-06-18T11:17:52  <wumpus> utxo age was
122 2018-06-18T11:19:06  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6cf4bd7eb3b...45c00f841612
123 2018-06-18T11:19:07  <bitcoin-git> bitcoin/master 3352da8 practicalswift: Add "export LC_ALL=C" to all shell scripts
124 2018-06-18T11:19:07  <bitcoin-git> bitcoin/master 47776a9 practicalswift: Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
125 2018-06-18T11:19:08  <bitcoin-git> bitcoin/master 45c00f8 Wladimir J. van der Laan: Merge #13454: Make sure LC_ALL=C is set in all shell scripts...
126 2018-06-18T11:19:51  <bitcoin-git> [bitcoin] laanwj closed pull request #13454: Make sure LC_ALL=C is set in all shell scripts (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454
127 2018-06-18T11:20:32  <wumpus> it used to be the sorting criterion for the free transaction area that some miners maintained in blocks
128 2018-06-18T11:22:34  *** vicenteH has joined #bitcoin-core-dev
129 2018-06-18T11:24:05  *** gnappuraz has quit IRC
130 2018-06-18T11:56:41  *** Victorsueca has quit IRC
131 2018-06-18T11:58:01  *** Victorsueca has joined #bitcoin-core-dev
132 2018-06-18T12:00:49  <promag> jonasschnelli: pushed a fix
133 2018-06-18T12:01:23  <jonasschnelli> promag: will test asap
134 2018-06-18T12:02:11  <promag> jonasschnelli: ty
135 2018-06-18T12:03:12  <promag> jonasschnelli: now in the main window the wallet selector hidden when there is only 1 wallet loaded
136 2018-06-18T12:03:22  <promag> *is hidden*
137 2018-06-18T12:03:39  <rabidus> oispa liivit
138 2018-06-18T12:03:49  <rabidus> oops sorry, wrong channel :(
139 2018-06-18T12:04:20  <promag> jonasschnelli: we should create a model for wallets no?
140 2018-06-18T12:04:52  <promag> btw, any objection to change QObject::connect to qt5 syntax (after qt4 is dropped)?
141 2018-06-18T12:08:27  *** promag has quit IRC
142 2018-06-18T12:12:25  <fanquake> promag sounds good
143 2018-06-18T12:15:01  *** d9b4bef9 has quit IRC
144 2018-06-18T12:18:08  *** d9b4bef9 has joined #bitcoin-core-dev
145 2018-06-18T12:21:27  <bitcoin-git> [bitcoin] practicalswift opened pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
146 2018-06-18T12:26:28  *** ahp1992 has joined #bitcoin-core-dev
147 2018-06-18T12:26:36  <ahp1992> hi
148 2018-06-18T12:27:31  <ahp1992> hello all
149 2018-06-18T12:28:33  *** promag has joined #bitcoin-core-dev
150 2018-06-18T12:31:45  <promag> thank fanquake
151 2018-06-18T12:34:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/45c00f841612...d67eff8002d7
152 2018-06-18T12:34:07  <bitcoin-git> bitcoin/master 7b23e6e practicalswift: Follow-up to #13454: Fix broken build by exporting LC_ALL=C
153 2018-06-18T12:34:08  <bitcoin-git> bitcoin/master d67eff8 MarcoFalke: Merge #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C...
154 2018-06-18T12:34:59  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
155 2018-06-18T12:38:04  *** promag has quit IRC
156 2018-06-18T12:39:20  *** setpill has quit IRC
157 2018-06-18T12:39:50  *** setpill has joined #bitcoin-core-dev
158 2018-06-18T12:52:09  *** jhfrontz has joined #bitcoin-core-dev
159 2018-06-18T12:54:51  <ahp1992> let me know, how can i study to do own currency using bitcoin core.
160 2018-06-18T12:58:28  *** promag has joined #bitcoin-core-dev
161 2018-06-18T13:00:51  *** ahp1992 has quit IRC
162 2018-06-18T13:03:32  *** promag has quit IRC
163 2018-06-18T13:05:01  <fanquake> ahp1992 off-topic here.
164 2018-06-18T13:05:54  *** fanquake has quit IRC
165 2018-06-18T13:08:56  *** Guyver2 has joined #bitcoin-core-dev
166 2018-06-18T13:19:53  *** promag has joined #bitcoin-core-dev
167 2018-06-18T13:20:01  *** ExtraCrispy has quit IRC
168 2018-06-18T13:21:40  *** codyrutscher has joined #bitcoin-core-dev
169 2018-06-18T13:24:55  *** berndj has quit IRC
170 2018-06-18T13:28:57  *** berndj has joined #bitcoin-core-dev
171 2018-06-18T13:31:47  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d67eff8002d7...2d071f5a7055
172 2018-06-18T13:31:47  <bitcoin-git> bitcoin/master 55771b7 lucash.dev@gmail.com: Removed unused == operator from CMutableTransaction.
173 2018-06-18T13:31:48  <bitcoin-git> bitcoin/master 2d071f5 Wladimir J. van der Laan: Merge #13443: Removed unused == operator from CMutableTransaction....
174 2018-06-18T13:32:28  <bitcoin-git> [bitcoin] laanwj closed pull request #13443: Removed unused == operator from CMutableTransaction. (master...remove-CMutableTransaction-equals) https://github.com/bitcoin/bitcoin/pull/13443
175 2018-06-18T13:32:50  *** ExtraCrispy has joined #bitcoin-core-dev
176 2018-06-18T13:33:03  *** codyrutscher has quit IRC
177 2018-06-18T13:35:00  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2d071f5a7055...450055bdbdcb
178 2018-06-18T13:35:00  <bitcoin-git> bitcoin/master 1e1eb63 Pieter Wuille: Improve coverage of SHA256 SelfTest code
179 2018-06-18T13:35:01  <bitcoin-git> bitcoin/master 450055b Wladimir J. van der Laan: Merge #13438: Improve coverage of SHA256 SelfTest code...
180 2018-06-18T13:35:53  <bitcoin-git> [bitcoin] laanwj closed pull request #13438: Improve coverage of SHA256 SelfTest code (master...201806_selftestsha) https://github.com/bitcoin/bitcoin/pull/13438
181 2018-06-18T14:01:13  *** Gnappuraz has joined #bitcoin-core-dev
182 2018-06-18T14:06:07  *** qu4ku has joined #bitcoin-core-dev
183 2018-06-18T14:12:47  *** SopaXorzTaker has joined #bitcoin-core-dev
184 2018-06-18T14:17:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
185 2018-06-18T14:27:14  *** grafcaps has joined #bitcoin-core-dev
186 2018-06-18T14:31:00  *** jhfrontz has quit IRC
187 2018-06-18T14:32:46  *** grafcaps has quit IRC
188 2018-06-18T14:39:04  *** qu4ku has quit IRC
189 2018-06-18T14:48:25  *** jhfrontz has joined #bitcoin-core-dev
190 2018-06-18T14:55:30  <jonasschnelli> sipa: would it be possible to have 3 different BCHs in Bech32X (three length of checksum)?
191 2018-06-18T15:07:55  *** ken2812221 has quit IRC
192 2018-06-18T15:08:05  *** ctrlbreak has quit IRC
193 2018-06-18T15:08:24  *** ken2812221 has joined #bitcoin-core-dev
194 2018-06-18T15:08:27  *** ctrlbreak has joined #bitcoin-core-dev
195 2018-06-18T15:12:56  *** jwhoisthat has quit IRC
196 2018-06-18T15:13:25  *** grafcaps has joined #bitcoin-core-dev
197 2018-06-18T15:17:50  *** miya has joined #bitcoin-core-dev
198 2018-06-18T15:19:23  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/450055bdbdcb...ac3224c8eea9
199 2018-06-18T15:19:24  <bitcoin-git> bitcoin/master fafa270 MarcoFalke: Make ReceivedBlockTransactions return void
200 2018-06-18T15:19:24  <bitcoin-git> bitcoin/master ac3224c Wladimir J. van der Laan: Merge #13412: Make ReceivedBlockTransactions return void...
201 2018-06-18T15:20:15  <bitcoin-git> [bitcoin] laanwj closed pull request #13412: Make ReceivedBlockTransactions return void (master...Mf1806-refactorReturnCodeValidation) https://github.com/bitcoin/bitcoin/pull/13412
202 2018-06-18T15:21:28  <bitcoin-git> [bitcoin] wodry opened pull request #13496: Test: Harden lint-filenames.sh (master...harden-test-lint-filenames.sh) https://github.com/bitcoin/bitcoin/pull/13496
203 2018-06-18T15:22:40  *** miya has quit IRC
204 2018-06-18T15:27:33  *** Ylbam has joined #bitcoin-core-dev
205 2018-06-18T15:30:39  <sipa> jonasschnelli: sure, what lengths
206 2018-06-18T15:31:24  <jonasschnelli> I think 7, 14, and 21 (correction)
207 2018-06-18T15:32:26  <jonasschnelli> Or maybe 7, 14, 28
208 2018-06-18T15:32:38  <jonasschnelli> 7 is ~5%, 14: ~10%, 28: ~20%
209 2018-06-18T15:32:51  <jonasschnelli> (for 512bit)
210 2018-06-18T15:34:43  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac3224c8eea9...088240685456
211 2018-06-18T15:34:44  <bitcoin-git> bitcoin/master faa18ca MarcoFalke: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
212 2018-06-18T15:34:44  <bitcoin-git> bitcoin/master 0882406 Wladimir J. van der Laan: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds...
213 2018-06-18T15:35:40  <bitcoin-git> [bitcoin] laanwj closed pull request #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (master...Mf1806-walletPrunedFundsSegfault) https://github.com/bitcoin/bitcoin/pull/13437
214 2018-06-18T15:39:40  *** jwhoisthat has joined #bitcoin-core-dev
215 2018-06-18T15:48:32  *** promag has quit IRC
216 2018-06-18T15:59:01  *** d9b4bef9 has quit IRC
217 2018-06-18T16:00:08  *** d9b4bef9 has joined #bitcoin-core-dev
218 2018-06-18T16:02:40  *** Ango_ has joined #bitcoin-core-dev
219 2018-06-18T16:07:04  *** qu4ku has joined #bitcoin-core-dev
220 2018-06-18T16:08:02  *** Krellan has quit IRC
221 2018-06-18T16:13:08  *** Ango_ has quit IRC
222 2018-06-18T16:25:13  *** Krellan has joined #bitcoin-core-dev
223 2018-06-18T16:29:47  *** setpill has quit IRC
224 2018-06-18T16:37:07  <bitcoin-git> [bitcoin] jnewbery opened pull request #13498: [wallet] Fixups from account API deprecation (master...account_deprecation_fixups) https://github.com/bitcoin/bitcoin/pull/13498
225 2018-06-18T17:00:57  *** rafalcpp has quit IRC
226 2018-06-18T17:07:15  *** dendisuhubdy has joined #bitcoin-core-dev
227 2018-06-18T17:08:11  *** rafalcpp has joined #bitcoin-core-dev
228 2018-06-18T17:17:53  *** harrymm has quit IRC
229 2018-06-18T17:21:43  *** nmnkgl has joined #bitcoin-core-dev
230 2018-06-18T17:29:10  *** Krellan has quit IRC
231 2018-06-18T17:30:46  *** harrymm has joined #bitcoin-core-dev
232 2018-06-18T17:33:31  *** Chris_Stewart_5 has quit IRC
233 2018-06-18T17:39:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
234 2018-06-18T17:47:08  *** Ylbam has quit IRC
235 2018-06-18T17:57:22  *** Gnappuraz has quit IRC
236 2018-06-18T17:58:49  *** Tester_ has joined #bitcoin-core-dev
237 2018-06-18T18:05:54  *** drizztbsd has quit IRC
238 2018-06-18T18:08:24  *** drexl has joined #bitcoin-core-dev
239 2018-06-18T18:08:50  *** qu4ku has quit IRC
240 2018-06-18T18:19:23  *** SopaXorzTaker has quit IRC
241 2018-06-18T19:01:53  *** dendisuhubdy has quit IRC
242 2018-06-18T19:02:15  <sipa> jonasschnelli: around?
243 2018-06-18T19:02:44  <jonasschnelli> sipa: yes (phonetyping)
244 2018-06-18T19:04:25  <sipa> jonasschnelli: i have a few thoughts on a format for describing sets of scriptPubKey
245 2018-06-18T19:04:54  <sipa> it's probably more complicated than what you're thinking about, but it's also pretty much what i'd want the entire wallet to migrate to
246 2018-06-18T19:05:06  <sipa> i'll do a writeup/prototype over the next few days if you're interested
247 2018-06-18T19:05:28  <jonasschnelli> sure. I think we could first use it for the scantxoutset
248 2018-06-18T19:05:38  <sipa> yeah
249 2018-06-18T19:06:07  <sipa> but it would also support things like multisig of multiple hd paths etc
250 2018-06-18T19:06:37  <jonasschnelli> I think that's great... i guess it's related to your thoughts on PSBT
251 2018-06-18T19:06:52  <sipa> yes
252 2018-06-18T19:07:20  <sipa> and also for supporting hw wallets directly in core, and forward compatibility with schnorr etc
253 2018-06-18T19:07:45  <jonasschnelli> Good.
254 2018-06-18T19:08:02  <jonasschnelli> I wanted to comment about the encoding...
255 2018-06-18T19:08:30  <jonasschnelli> Do you think pure binary serialization is unacceptable?
256 2018-06-18T19:08:38  <sipa> for psbt?
257 2018-06-18T19:08:43  <jonasschnelli> yes
258 2018-06-18T19:08:53  <sipa> sure, that'd be the most common thing to do
259 2018-06-18T19:08:59  <jonasschnelli> or where do you see advantages of base64 and z85, etc.
260 2018-06-18T19:09:03  <sipa> but we can't put pure binary in an RPC response
261 2018-06-18T19:09:12  <jonasschnelli> yes. sure.
262 2018-06-18T19:09:28  <sipa> the common assumption i think is using hex
263 2018-06-18T19:09:46  <jonasschnelli> yeah... I guess size won't matter to much on that layer
264 2018-06-18T19:09:55  <sipa> but as i know how annoying raw transactions in hex can be to copy paste, i wanted to suggest something smaller
265 2018-06-18T19:10:02  <sipa> and z85 looks pretty neat actually
266 2018-06-18T19:10:08  <jonasschnelli> yes. I like it.
267 2018-06-18T19:10:10  <sipa> it's 5 characters per 4 bytes
268 2018-06-18T19:10:33  <jonasschnelli> but PSBT could also have it own file type... end user could email and dbl-click etc
269 2018-06-18T19:10:42  <sipa> it probably should
270 2018-06-18T19:11:18  <jonasschnelli> For RPC it will be a long chuck of text. both with hex or z85.
271 2018-06-18T19:11:25  <sipa> yes
272 2018-06-18T19:11:51  <sipa> but 1.6x shorter with z85
273 2018-06-18T19:12:26  <jonasschnelli> Yes. But hassle on the client side... eventually opt-in?
274 2018-06-18T19:12:48  <sipa> yeah, the burden of implementing z85 would be a deterrent i guess
275 2018-06-18T19:12:58  <sipa> base64 is more common
276 2018-06-18T19:13:12  <jonasschnelli> Yes.
277 2018-06-18T19:13:15  <sipa> i don't care much; i just brought it up because it would be good to standardize on one
278 2018-06-18T19:13:49  <jonasschnelli> I think z85 brings in some perfection and I generally think it's worth to explore
279 2018-06-18T19:14:18  <sipa> cfields: what clang version will be used for 0.17 osx builds?
280 2018-06-18T19:14:35  <jonasschnelli> and it not very complex so if one can deal with PSBT, z85 seem a trivial puzzlepiece
281 2018-06-18T19:14:51  <jonasschnelli> *its
282 2018-06-18T19:28:37  *** BashCo has quit IRC
283 2018-06-18T19:30:14  *** BashCo has joined #bitcoin-core-dev
284 2018-06-18T19:30:15  *** andytoshi has quit IRC
285 2018-06-18T19:30:23  *** andytoshi has joined #bitcoin-core-dev
286 2018-06-18T19:30:24  *** andytoshi has joined #bitcoin-core-dev
287 2018-06-18T19:38:00  *** Randolf has joined #bitcoin-core-dev
288 2018-06-18T19:39:54  *** laurentmt has joined #bitcoin-core-dev
289 2018-06-18T19:59:57  *** promag has joined #bitcoin-core-dev
290 2018-06-18T20:03:05  *** laurentmt has quit IRC
291 2018-06-18T20:03:05  <bitcoin-git> [bitcoin] JeremyRubin reopened pull request #12763: Add RPC Whitelist Feature from #12248 (master...whitelistrpc) https://github.com/bitcoin/bitcoin/pull/12763
292 2018-06-18T20:06:10  *** goatpig has quit IRC
293 2018-06-18T20:08:27  <bitcoin-git> [bitcoin] jamesob closed pull request #12407: Ensure nStatus is set properly for all invalid blocks (master...jamesob/2018-02-mark-headers-invalid) https://github.com/bitcoin/bitcoin/pull/12407
294 2018-06-18T20:15:05  *** nmnkgl has quit IRC
295 2018-06-18T20:15:41  *** nmnkgl has joined #bitcoin-core-dev
296 2018-06-18T20:19:57  *** nmnkgl has quit IRC
297 2018-06-18T20:23:24  *** Guyver2 has quit IRC
298 2018-06-18T20:35:41  *** qu4ku has joined #bitcoin-core-dev
299 2018-06-18T20:40:37  *** qu4ku has quit IRC
300 2018-06-18T20:45:27  *** Randolf has quit IRC
301 2018-06-18T21:19:35  *** nmnkgl has joined #bitcoin-core-dev
302 2018-06-18T21:30:18  *** drexl_ has joined #bitcoin-core-dev
303 2018-06-18T21:32:59  *** drexl has quit IRC
304 2018-06-18T21:33:06  *** drexl_ is now known as drexl
305 2018-06-18T21:36:55  *** jojeyh has quit IRC
306 2018-06-18T21:42:02  *** CubicEarths has quit IRC
307 2018-06-18T21:42:41  *** CubicEarths has joined #bitcoin-core-dev
308 2018-06-18T21:47:23  *** CubicEarths has quit IRC
309 2018-06-18T21:53:26  *** nkohen has joined #bitcoin-core-dev
310 2018-06-18T21:54:29  *** tryphe_ is now known as tryphe
311 2018-06-18T21:55:14  <nkohen> Does anyone know what the intended functionality of combinerawtransaction is with bitcoind?
312 2018-06-18T21:57:56  <sipa> nkohen: create a raw transaction for a 2-of-2 multisig, give it to both parties, each sign their part with a single signature; combinerawtransaction will turn it into a full transaction
313 2018-06-18T22:01:02  <nkohen> Thanks!
314 2018-06-18T22:05:55  *** dgenr8 has quit IRC
315 2018-06-18T22:06:26  *** spinza has quit IRC
316 2018-06-18T22:11:26  *** dgenr8 has joined #bitcoin-core-dev
317 2018-06-18T22:17:14  *** grafcaps has quit IRC
318 2018-06-18T22:19:49  *** spinza has joined #bitcoin-core-dev
319 2018-06-18T22:31:48  <bitcoin-git> [bitcoin] achow101 opened pull request #13500: [wallet] Decouple wallet version from client version (master...decouple-wallet-version) https://github.com/bitcoin/bitcoin/pull/13500
320 2018-06-18T22:31:55  *** nekotribal_ has quit IRC
321 2018-06-18T22:33:15  *** rev_strangehope_ is now known as revstrangehope
322 2018-06-18T22:35:00  <gmaxwell> sipa: is z85 as copy and paste friendly as base64?
323 2018-06-18T22:38:45  *** AaronvanW_ has quit IRC
324 2018-06-18T22:39:21  *** AaronvanW has joined #bitcoin-core-dev
325 2018-06-18T22:41:55  <sipa> gmaxwell: probably not
326 2018-06-18T22:42:43  <sipa> it's designed to not need escaping in typical programming languages when surrounded by quotation marks, though
327 2018-06-18T22:43:27  *** AaronvanW has quit IRC
328 2018-06-18T22:43:28  <sipa> wait, what do you mean by copy-paste friendly?
329 2018-06-18T22:46:11  *** Chris_Stewart_5 has quit IRC
330 2018-06-18T22:48:17  *** CubicEarths has joined #bitcoin-core-dev
331 2018-06-18T22:48:49  <bitcoin-git> [bitcoin] promag opened pull request #13501: Remove race on shutdown between event loop exit and http reply (master...2018-06-loopexit) https://github.com/bitcoin/bitcoin/pull/13501
332 2018-06-18T22:49:14  *** meshcollider has joined #bitcoin-core-dev
333 2018-06-18T22:51:04  <gmaxwell> sipa: mostly not having weird escape characters that will cause misbehavior when pasted.
334 2018-06-18T22:52:01  <gmaxwell> it has / which is unfortunate for pasting into IRC.
335 2018-06-18T22:52:28  <sipa> gmaxwell: it excludes \ ' " ; ,
336 2018-06-18T22:52:50  <sipa> and |
337 2018-06-18T22:53:16  <sipa> if it would have excluded < / >, and included , ; | instead it would be clean html
338 2018-06-18T22:53:21  *** AaronvanW has joined #bitcoin-core-dev
339 2018-06-18T22:53:53  <gmaxwell> I'm surprised it doesn't include ,;| as those are generally safe AFAIK.
340 2018-06-18T22:54:07  <sipa> yup
341 2018-06-18T22:54:57  <sipa> hmm, there are are 94 non-space printable ascii characters
342 2018-06-18T22:55:03  <sipa> so 9 must be excluded
343 2018-06-18T22:58:08  *** nkohen has quit IRC
344 2018-06-18T22:59:03  <sipa> \ ' " ; , | ` ~
345 2018-06-18T22:59:07  <sipa> i must be missing one still
346 2018-06-18T22:59:08  *** Empact_ has joined #bitcoin-core-dev
347 2018-06-18T23:00:50  *** AaronvanW has quit IRC
348 2018-06-18T23:01:01  <gmaxwell> https://tools.ietf.org/html/rfc1924  has < and > but leaves out the slashes.
349 2018-06-18T23:01:20  <gmaxwell> it gives rationale for each of the omitted characters.
350 2018-06-18T23:01:26  *** AaronvanW has joined #bitcoin-core-dev
351 2018-06-18T23:02:10  *** Empact has quit IRC
352 2018-06-18T23:02:30  <sipa> that's specific for ipv6 addresses, though
353 2018-06-18T23:02:36  <sipa> for example the chose to exclude [ ]
354 2018-06-18T23:03:12  <gmaxwell> Right.  & is also an escape character that should be aboided.
355 2018-06-18T23:03:17  <gmaxwell> (at that document argues,
356 2018-06-18T23:04:07  <gmaxwell> <>"'`/\&. seem more obvious safe characters to exclude to me.
357 2018-06-18T23:05:39  <sipa> or just base64... only 6.25% less efficient
358 2018-06-18T23:05:46  *** AaronvanW has quit IRC
359 2018-06-18T23:05:51  <sipa> and far more common
360 2018-06-18T23:06:18  <gmaxwell> it is sad that base64 has / but at least it's a common and well understood thing.
361 2018-06-18T23:06:26  <sipa> the base85 trick of encoding 32-bit integers is neat, though
362 2018-06-18T23:10:07  *** CubicEarths has quit IRC
363 2018-06-18T23:10:14  *** drexl has quit IRC
364 2018-06-18T23:21:22  *** Randolf has joined #bitcoin-core-dev
365 2018-06-18T23:33:20  *** vicenteH has quit IRC
366 2018-06-18T23:39:12  *** AaronvanW has joined #bitcoin-core-dev
367 2018-06-18T23:45:42  *** AaronvanW has quit IRC
368 2018-06-18T23:46:19  *** AaronvanW has joined #bitcoin-core-dev
369 2018-06-18T23:50:43  *** AaronvanW has quit IRC
370 2018-06-18T23:55:13  *** fanquake has joined #bitcoin-core-dev
371 2018-06-18T23:59:15  *** AaronvanW has joined #bitcoin-core-dev