12018-07-12T00:31:21  *** Krellan has quit IRC
  22018-07-12T00:33:46  *** HFRadical has quit IRC
  32018-07-12T00:40:16  *** Randolf has joined #bitcoin-core-dev
  42018-07-12T00:52:27  *** Squidicuz has joined #bitcoin-core-dev
  52018-07-12T00:55:11  *** Randolf has quit IRC
  62018-07-12T01:10:45  *** grubles has quit IRC
  72018-07-12T01:21:02  *** grafcaps has joined #bitcoin-core-dev
  82018-07-12T01:25:21  *** grafcaps has quit IRC
  92018-07-12T01:26:10  *** jpe__ has joined #bitcoin-core-dev
 102018-07-12T01:28:46  *** jpe_ has quit IRC
 112018-07-12T01:55:15  *** bitconner has joined #bitcoin-core-dev
 122018-07-12T02:13:23  *** grubles has joined #bitcoin-core-dev
 132018-07-12T02:14:11  *** bitconne1 has joined #bitcoin-core-dev
 142018-07-12T02:16:57  *** bitconner has quit IRC
 152018-07-12T02:42:41  *** justanotheruser has quit IRC
 162018-07-12T02:50:02  *** d9b4bef9 has quit IRC
 172018-07-12T02:51:17  *** d9b4bef9 has joined #bitcoin-core-dev
 182018-07-12T03:01:25  *** TheRec has quit IRC
 192018-07-12T03:25:35  *** Krellan has joined #bitcoin-core-dev
 202018-07-12T03:27:17  *** Krellan_ has joined #bitcoin-core-dev
 212018-07-12T03:30:21  *** Krellan has quit IRC
 222018-07-12T03:31:46  *** Krellan_ has quit IRC
 232018-07-12T03:32:38  *** Krellan has joined #bitcoin-core-dev
 242018-07-12T03:35:27  *** Krellan has quit IRC
 252018-07-12T03:36:00  *** Krellan has joined #bitcoin-core-dev
 262018-07-12T03:46:47  *** Randolf has joined #bitcoin-core-dev
 272018-07-12T04:07:40  *** grafcaps has joined #bitcoin-core-dev
 282018-07-12T04:11:53  *** grafcaps has quit IRC
 292018-07-12T04:46:25  <gmaxwell> BlueMatt: Do you think we can start disconnecting (banning?) non-whitelisted peers that send us unrequested whole blocks that we already have (/have in flight)?
 302018-07-12T05:20:14  *** harrymm has quit IRC
 312018-07-12T05:43:29  *** Krellan has quit IRC
 322018-07-12T05:44:38  *** Krellan has joined #bitcoin-core-dev
 332018-07-12T05:48:19  *** Krellan__ has joined #bitcoin-core-dev
 342018-07-12T05:49:30  *** Krellan has quit IRC
 352018-07-12T05:53:15  <bitcoin-git> [bitcoin] Empact opened pull request #13639: Fix the chainparamsbase -> util -> chainparamsbase circular dependency (master...chainparamsbase-circ) https://github.com/bitcoin/bitcoin/pull/13639
 362018-07-12T05:53:58  *** quer has quit IRC
 372018-07-12T05:54:37  *** quer has joined #bitcoin-core-dev
 382018-07-12T05:56:08  *** Victorsueca has quit IRC
 392018-07-12T05:56:43  *** crc32 has joined #bitcoin-core-dev
 402018-07-12T05:57:32  *** Victorsueca has joined #bitcoin-core-dev
 412018-07-12T05:59:50  *** Krellan has joined #bitcoin-core-dev
 422018-07-12T06:03:47  *** Krellan__ has quit IRC
 432018-07-12T06:11:29  *** SopaXorzTaker has joined #bitcoin-core-dev
 442018-07-12T06:18:05  *** Randolf has quit IRC
 452018-07-12T06:19:01  *** Randolf has joined #bitcoin-core-dev
 462018-07-12T07:01:02  *** d9b4bef9 has quit IRC
 472018-07-12T07:02:17  *** d9b4bef9 has joined #bitcoin-core-dev
 482018-07-12T07:43:56  *** grafcaps has joined #bitcoin-core-dev
 492018-07-12T07:45:39  *** SopaXorzTaker has quit IRC
 502018-07-12T07:48:34  *** grafcaps has quit IRC
 512018-07-12T07:51:27  *** TheRec has joined #bitcoin-core-dev
 522018-07-12T07:51:27  *** TheRec has joined #bitcoin-core-dev
 532018-07-12T07:57:14  *** AaronvanW has joined #bitcoin-core-dev
 542018-07-12T08:09:30  *** Krellan has quit IRC
 552018-07-12T08:10:18  *** Krellan has joined #bitcoin-core-dev
 562018-07-12T08:15:45  <provoostenator> I'm chasing a theory that the kernel watchdog on one my ARM machines resets the device during IBD, often during heavier I/O like pruning or cache flushes. Is that even plausible? And is there anything we should do to put said watchdog at ease? http://forum.khadas.com/t/how-to-debug-spontaneous-resets/2624
 572018-07-12T08:15:59  *** Deadhand has quit IRC
 582018-07-12T08:18:53  *** Victorsueca has quit IRC
 592018-07-12T08:19:52  <warren> provoostenator: not exactly on topic for this channel, but I can comment from my experience that I had ARM devices overheat with CPU load due to inadequate heatsinking, causing such problems.
 602018-07-12T08:20:01  *** Victorsueca has joined #bitcoin-core-dev
 612018-07-12T08:21:52  *** Deadhand has joined #bitcoin-core-dev
 622018-07-12T08:23:34  <provoostenator> warran: thanks. I'll let the folks on that forum help with the device itself. The part that's more relevant here is that these resets often leave the chain in an unrecoverable state, at least with pruning enabled. And maybe there's a way to shut down gracefully or not use max resources that we can recommend / do by default on these devices.
 632018-07-12T08:23:41  <provoostenator> warren
 642018-07-12T08:23:48  <gmaxwell> provoostenator: totally plausable. one of my older odroids does it reliably. adding sleeps to the sync OR putting a fan on top of it, fixes it.
 652018-07-12T08:24:34  *** crc32 has quit IRC
 662018-07-12T08:24:35  <gmaxwell> It's really hard to deal with unreliable hardware, nothing in software is written to handle mystery memory corruption or similar, so all bets are off.
 672018-07-12T08:30:34  <provoostenator> I did add a heatsink and fan btw, but I wouldn't be surprised if Kernel / OS support for that is misconfigured.
 682018-07-12T08:33:32  <warren> The heatsink + fan that came with one of my ODroids a few years ago was inadequate to cool the device and keep it reliable while under full CPU load on the four cores.
 692018-07-12T08:43:59  *** SopaXorzTaker has joined #bitcoin-core-dev
 702018-07-12T08:44:35  *** vicenteH has joined #bitcoin-core-dev
 712018-07-12T08:48:04  *** shinohai has quit IRC
 722018-07-12T09:44:42  *** ExtraCrispy has joined #bitcoin-core-dev
 732018-07-12T09:49:38  *** booyah has quit IRC
 742018-07-12T09:50:47  *** booyah has joined #bitcoin-core-dev
 752018-07-12T09:57:21  *** Krellan has quit IRC
 762018-07-12T09:58:02  *** Krellan has joined #bitcoin-core-dev
 772018-07-12T10:04:28  *** belcher has joined #bitcoin-core-dev
 782018-07-12T10:24:01  <jonasschnelli> I made good experience with the Odroid HC1 (passive / heatsink) and the XU4 with heatsink. Testing both since 3 months.
 792018-07-12T10:47:54  *** Guest41 has joined #bitcoin-core-dev
 802018-07-12T10:52:32  *** Guest41 has left #bitcoin-core-dev
 812018-07-12T11:08:11  *** Victorsueca has quit IRC
 822018-07-12T11:09:24  *** Victorsueca has joined #bitcoin-core-dev
 832018-07-12T11:11:40  *** jpe__ has quit IRC
 842018-07-12T11:19:42  *** jpe has joined #bitcoin-core-dev
 852018-07-12T11:20:14  *** grafcaps has joined #bitcoin-core-dev
 862018-07-12T11:21:05  *** bitconne1 has quit IRC
 872018-07-12T11:25:12  *** grafcaps has quit IRC
 882018-07-12T11:43:33  *** goatpig has joined #bitcoin-core-dev
 892018-07-12T11:44:56  *** justanotheruser has joined #bitcoin-core-dev
 902018-07-12T11:50:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5ba77df15de9...d3dae3ddf9fa
 912018-07-12T11:50:30  <bitcoin-git> bitcoin/master 075429a winder: Use common SetDataDir method to create temp directory in tests.
 922018-07-12T11:50:31  <bitcoin-git> bitcoin/master d3dae3d MarcoFalke: Merge #13145: Use common getPath method to create temp directory in tests....
 932018-07-12T11:51:11  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13145: Use common getPath method to create temp directory in tests. (master...master) https://github.com/bitcoin/bitcoin/pull/13145
 942018-07-12T11:55:54  *** zautomata has quit IRC
 952018-07-12T11:58:34  *** spinza has quit IRC
 962018-07-12T12:02:11  *** spinza has joined #bitcoin-core-dev
 972018-07-12T12:06:15  *** Krellan has quit IRC
 982018-07-12T12:06:33  *** bitconner has joined #bitcoin-core-dev
 992018-07-12T12:10:24  *** Krellan has joined #bitcoin-core-dev
1002018-07-12T12:11:52  *** bitconner has quit IRC
1012018-07-12T12:15:37  *** SopaXorzTaker has quit IRC
1022018-07-12T12:22:09  *** ExtraCrispy has quit IRC
1032018-07-12T12:27:30  *** ExtraCrispy has joined #bitcoin-core-dev
1042018-07-12T12:38:01  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3dae3ddf9fa...9b638c7ce1b9
1052018-07-12T12:38:01  <bitcoin-git> bitcoin/master d0b9405 251: Refactors `keystore.h` type aliases....
1062018-07-12T12:38:02  <bitcoin-git> bitcoin/master 9b638c7 Wladimir J. van der Laan: Merge #13627: Free keystore.h from file scope level type aliases...
1072018-07-12T12:38:47  <bitcoin-git> [bitcoin] laanwj closed pull request #13627: Free keystore.h from file scope level type aliases (master...patch/cleanup-keystore.h) https://github.com/bitcoin/bitcoin/pull/13627
1082018-07-12T12:49:10  *** fanquake has joined #bitcoin-core-dev
1092018-07-12T12:57:45  *** bitconner has joined #bitcoin-core-dev
1102018-07-12T13:02:24  *** bitconner has quit IRC
1112018-07-12T13:05:06  *** justan0theruser has joined #bitcoin-core-dev
1122018-07-12T13:06:29  *** justanotheruser has quit IRC
1132018-07-12T13:18:03  *** bitconner has joined #bitcoin-core-dev
1142018-07-12T13:22:35  *** bitconner has quit IRC
1152018-07-12T13:26:41  *** quer has quit IRC
1162018-07-12T13:33:38  *** Victorsueca has quit IRC
1172018-07-12T13:35:06  *** Victorsueca has joined #bitcoin-core-dev
1182018-07-12T13:35:13  *** Krellan has quit IRC
1192018-07-12T13:37:01  *** promag has joined #bitcoin-core-dev
1202018-07-12T13:38:08  *** Guyver2 has joined #bitcoin-core-dev
1212018-07-12T13:40:17  *** Krellan has joined #bitcoin-core-dev
1222018-07-12T13:42:20  <promag> wumpus: can you add #13100 to hp?
1232018-07-12T13:42:22  <gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
1242018-07-12T13:45:13  *** bitconner has joined #bitcoin-core-dev
1252018-07-12T13:47:23  <fanquake> promag added it
1262018-07-12T13:47:30  <promag> ty!
1272018-07-12T13:47:58  <promag> if this doesn't get some reviews in the next couple of days it won't go in 0.17
1282018-07-12T13:48:13  <promag> and I guess that's fine
1292018-07-12T13:49:27  *** bitconner has quit IRC
1302018-07-12T13:53:22  <wumpus> thanks
1312018-07-12T13:59:42  *** bitconner has joined #bitcoin-core-dev
1322018-07-12T14:01:50  *** davec has quit IRC
1332018-07-12T14:03:02  *** davec has joined #bitcoin-core-dev
1342018-07-12T14:05:07  *** belcher has quit IRC
1352018-07-12T14:05:35  *** belcher has joined #bitcoin-core-dev
1362018-07-12T14:06:41  <bitcoin-git> [bitcoin] h4x3rotab opened pull request #13643: Switch to NSIS 3.03 to avoid DLL hijacking (master...nsis-fix) https://github.com/bitcoin/bitcoin/pull/13643
1372018-07-12T14:07:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #13644: 0.16: Remaining backports for 0.16.2 (0.16...Mf1804-16Backports) https://github.com/bitcoin/bitcoin/pull/13644
1382018-07-12T14:08:05  *** bitconner has quit IRC
1392018-07-12T14:11:58  *** ddt_is_dead has joined #bitcoin-core-dev
1402018-07-12T14:20:19  <fanquake> What else needs to happen to make #12511 a reality for 0.17.0? I think I'm losing track of any related PRs.
1412018-07-12T14:20:21  <gribble> https://github.com/bitcoin/bitcoin/issues/12511 | Switch to Ubuntu 18.04 for gitian building · Issue #12511 · bitcoin/bitcoin · GitHub
1422018-07-12T14:21:33  <wumpus> the GLIBC compat PR
1432018-07-12T14:22:32  <fanquake> Would be good to get that in to avoid the NSIS problem, and also fix qt on Windows
1442018-07-12T14:22:57  *** bitconner has joined #bitcoin-core-dev
1452018-07-12T14:23:53  <wumpus> https://github.com/bitcoin/bitcoin/pull/13177
1462018-07-12T14:24:00  *** brianhoffman has joined #bitcoin-core-dev
1472018-07-12T14:24:44  <fanquake> wumpus is feature freeze still the 16th
1482018-07-12T14:27:27  *** bitconner has quit IRC
1492018-07-12T14:30:05  <wumpus> we could discuss that at the meeting
1502018-07-12T14:30:17  <wumpus> if there's a good reason to move it, we'll move it...
1512018-07-12T14:32:30  <fanquake> I might head to bed now then, and set an alarm for the meeting. A bit to discuss.
1522018-07-12T14:42:08  *** bitconner has joined #bitcoin-core-dev
1532018-07-12T14:46:49  *** bitconner has quit IRC
1542018-07-12T14:49:44  *** AaronvanW has quit IRC
1552018-07-12T14:57:10  *** bitconner has joined #bitcoin-core-dev
1562018-07-12T14:57:39  *** fanquake has quit IRC
1572018-07-12T15:01:59  *** bitconner has quit IRC
1582018-07-12T15:14:59  *** Handa has joined #bitcoin-core-dev
1592018-07-12T15:18:15  *** fgdf has joined #bitcoin-core-dev
1602018-07-12T15:18:26  <fgdf> jhkjh
1612018-07-12T15:18:37  *** fgdf has quit IRC
1622018-07-12T15:18:39  *** bitconner has joined #bitcoin-core-dev
1632018-07-12T15:22:57  *** bitconner has quit IRC
1642018-07-12T15:24:25  *** Victorsueca has quit IRC
1652018-07-12T15:25:36  *** Victorsueca has joined #bitcoin-core-dev
1662018-07-12T15:27:05  *** bitconner has joined #bitcoin-core-dev
1672018-07-12T15:32:19  *** bitconner has quit IRC
1682018-07-12T15:32:27  *** gmaxwell has quit IRC
1692018-07-12T15:33:36  *** gmaxwell has joined #bitcoin-core-dev
1702018-07-12T15:33:59  *** gmaxwell is now known as Guest81320
1712018-07-12T15:39:30  *** bitconner has joined #bitcoin-core-dev
1722018-07-12T15:39:58  *** ddt_is_dead has quit IRC
1732018-07-12T15:44:19  *** Krellan has quit IRC
1742018-07-12T15:44:34  *** bitconner has quit IRC
1752018-07-12T15:46:58  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b638c7ce1b9...dcb154e5aad8
1762018-07-12T15:46:59  <bitcoin-git> bitcoin/master 908c1d7 Chun Kuan Lee: GCC-7 and glibc-2.27 compat code
1772018-07-12T15:47:00  <bitcoin-git> bitcoin/master fc6a9f2 Cory Fields: Use IN6ADDR_ANY_INIT instead of in6addr_any
1782018-07-12T15:47:00  <bitcoin-git> bitcoin/master 253f592 Chun Kuan Lee: Add stdin, stdout, stderr to ignored export list
1792018-07-12T15:47:33  <bitcoin-git> [bitcoin] laanwj closed pull request #13177: GCC-7 and glibc-2.27 back compat code (master...compat) https://github.com/bitcoin/bitcoin/pull/13177
1802018-07-12T15:52:30  *** Krellan has joined #bitcoin-core-dev
1812018-07-12T15:54:38  <bitcoin-git> [bitcoin] jamesob opened pull request #13645: [tests] skip rpc_zmq functional test as necessary (master...2018-07-skip-zmq-tests) https://github.com/bitcoin/bitcoin/pull/13645
1822018-07-12T15:55:13  <bitcoin-git> [bitcoin] domob1812 opened pull request #13646: tests: Skip rpc_zmq.py when ZMQ is disabled (master...skip-zmq-test) https://github.com/bitcoin/bitcoin/pull/13646
1832018-07-12T16:00:27  <kanzure> is there a publicly-hosted log bot for this channel other than bitcoinstats.com?
1842018-07-12T16:04:10  *** bitconner has joined #bitcoin-core-dev
1852018-07-12T16:06:27  *** lol1 has joined #bitcoin-core-dev
1862018-07-12T16:06:50  <lol1> kanzure: use https://botbot.me/freenode/bitcoin-core-dev/
1872018-07-12T16:06:57  *** lol1 has quit IRC
1882018-07-12T16:07:22  <kanzure> yeah that interface has never worked for me
1892018-07-12T16:07:43  <kanzure> okay, i am logging here now: http://gnusha.org/bitcoin-core-dev/
1902018-07-12T16:07:54  <luke-jr> kanzure: see topic..
1912018-07-12T16:08:30  *** ChanServ sets mode: +o luke-jr
1922018-07-12T16:08:35  *** gnusha has joined #bitcoin-core-dev
1932018-07-12T16:08:36  *** luke-jr changes topic to "Bitcoin Core development discussion and commit log | This is the channel for developing Bitcoin Core. Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: https://botbot.me/freenode/bitcoin-core-dev, http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/"
1942018-07-12T16:08:40  *** luke-jr sets mode: -o luke-jr
1952018-07-12T16:09:04  *** bitconner has quit IRC
1962018-07-12T16:12:45  *** nickler has quit IRC
1972018-07-12T16:13:37  *** Murch has joined #bitcoin-core-dev
1982018-07-12T16:14:45  *** jb55 has joined #bitcoin-core-dev
1992018-07-12T16:17:18  *** nickler has joined #bitcoin-core-dev
2002018-07-12T16:17:53  <bitcoin-git> [bitcoin] conradoplg opened pull request #13647: Scripts and tools: Fix BIND_NOW check in security-check.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13647
2012018-07-12T16:18:31  *** SopaXorzTaker has joined #bitcoin-core-dev
2022018-07-12T16:24:54  *** bitconner has joined #bitcoin-core-dev
2032018-07-12T16:29:35  *** bitconner has quit IRC
2042018-07-12T16:33:19  *** Murch has quit IRC
2052018-07-12T16:35:49  *** chakaponden has joined #bitcoin-core-dev
2062018-07-12T16:39:50  *** bitconner has joined #bitcoin-core-dev
2072018-07-12T16:40:34  *** Guest81320 has quit IRC
2082018-07-12T16:40:35  *** Guest81320 has joined #bitcoin-core-dev
2092018-07-12T16:40:50  *** Guest81320 is now known as gmaxwell
2102018-07-12T16:41:11  *** arubi has quit IRC
2112018-07-12T16:41:33  *** arubi has joined #bitcoin-core-dev
2122018-07-12T16:42:17  *** ken2812221 has joined #bitcoin-core-dev
2132018-07-12T16:44:39  *** bitconner has quit IRC
2142018-07-12T16:55:14  *** grafcaps has joined #bitcoin-core-dev
2152018-07-12T16:56:43  *** bitconner has joined #bitcoin-core-dev
2162018-07-12T17:01:05  *** bitconner has quit IRC
2172018-07-12T17:05:11  *** Murch has joined #bitcoin-core-dev
2182018-07-12T17:05:16  *** timothy has quit IRC
2192018-07-12T17:12:15  *** bitconner has joined #bitcoin-core-dev
2202018-07-12T17:15:56  *** escrivner has joined #bitcoin-core-dev
2212018-07-12T17:17:19  *** bitconner has quit IRC
2222018-07-12T17:24:50  <luke-jr> so only 4 days left until feature freeze; if people want to commit to review rwconf in time, I'll try to get it done tonight or tomorrow, otherwise I won't even bother trying (and we get left with an ugly GUI pruning mess to maintain)
2232018-07-12T17:24:57  *** escrivner has quit IRC
2242018-07-12T17:26:25  *** bitconner has joined #bitcoin-core-dev
2252018-07-12T17:27:11  <gmaxwell> luke-jr: unrelated, you might find 12257 interesting to review... since it undoes some of the damage of address reuse.
2262018-07-12T17:28:55  <sipa> gah, unicorn on #13557 :(
2272018-07-12T17:29:06  <gribble> https://github.com/bitcoin/bitcoin/issues/13557 | BIP 174 PSBT Serializations and RPCs by achow101 · Pull Request #13557 · bitcoin/bitcoin · GitHub
2282018-07-12T17:29:30  <gmaxwell> Thanks Microsoft.
2292018-07-12T17:29:38  <cfields> haha
2302018-07-12T17:30:09  <cfields> gmaxwell: we'll know the transition is complete when it bsod's instead.
2312018-07-12T17:30:17  <instagibbs> refreshing.. usually works
2322018-07-12T17:30:32  *** Randolf has quit IRC
2332018-07-12T17:30:51  *** Murch has quit IRC
2342018-07-12T17:30:57  *** bitconner has quit IRC
2352018-07-12T17:34:24  *** Murch has joined #bitcoin-core-dev
2362018-07-12T17:44:10  *** vicenteH has quit IRC
2372018-07-12T17:44:12  *** bitconner has joined #bitcoin-core-dev
2382018-07-12T17:48:14  *** davec has quit IRC
2392018-07-12T17:48:57  *** bitconner has quit IRC
2402018-07-12T17:50:51  *** Krellan has quit IRC
2412018-07-12T17:54:06  *** Murch has quit IRC
2422018-07-12T17:55:12  <sipa> and a unicorn on #12196 as well
2432018-07-12T17:55:22  <gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub
2442018-07-12T17:56:04  *** davec has joined #bitcoin-core-dev
2452018-07-12T18:03:49  *** str4d has joined #bitcoin-core-dev
2462018-07-12T18:11:09  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13648: [travis] Increase ccache size for the one which enable debug (master...travis-400m) https://github.com/bitcoin/bitcoin/pull/13648
2472018-07-12T18:12:48  *** bitconner has joined #bitcoin-core-dev
2482018-07-12T18:16:04  <bitcoin-git> [bitcoin] jamesob opened pull request #13649: test: allow arguments to be forwarded to flake8 in lint-python.sh (master...2018-07-python-lint-args) https://github.com/bitcoin/bitcoin/pull/13649
2492018-07-12T18:17:18  *** bitconner has quit IRC
2502018-07-12T18:26:09  *** StayCool has joined #bitcoin-core-dev
2512018-07-12T18:26:52  *** str4d has quit IRC
2522018-07-12T18:27:17  *** str4d has joined #bitcoin-core-dev
2532018-07-12T18:29:46  <StayCool> I've been wondering about the lightning network, i'm running a full node using Bitcoin Core, however to run a full node on the lightning network i need to install one of the few implementations so far. Will lightning payments using a JSON-RPC api ever be available in Bitcoin Core, or will it always be a separate client?
2542018-07-12T18:30:02  <sipa> StayCool: who knows?
2552018-07-12T18:30:56  <sipa> for the foreseeable future i don't expect they to become integrated - bitcoin core's review process is slow and integrating such an amount of complexity would take a long time
2562018-07-12T18:31:10  <sipa> but ultimately it is up to contributors and what they want to work on
2572018-07-12T18:31:12  <luke-jr> StayCool: Bitcoin implementation diversity makes Lightning implementation diversity look good XD
2582018-07-12T18:31:17  <StayCool> I guess time will tell :-) that's a valid point.
2592018-07-12T18:32:13  <sipa> perhaps i'm pessimistic but i expect integrating lightning into bitcoin core would take longer than the concept of lightning has been around so far...
2602018-07-12T18:32:41  <luke-jr> more likely the wallet finally getting split out (or simply deprecated entirely)
2612018-07-12T18:32:59  *** ExtraCrispy has quit IRC
2622018-07-12T18:33:57  *** str4d has quit IRC
2632018-07-12T18:35:46  *** dx25 has quit IRC
2642018-07-12T18:35:58  <StayCool> Yeah that's true. It's also taken a long time for the current implementations to become functional. I know that c-lightning has a JSON-RPC, it's just wishful thinking for it to be integrated in Bitcoin Core :-)
2652018-07-12T18:36:12  <StayCool> It has*
2662018-07-12T18:36:27  *** str4d has joined #bitcoin-core-dev
2672018-07-12T18:37:02  *** nmnkgl has joined #bitcoin-core-dev
2682018-07-12T18:38:39  <bitcoin-git> [bitcoin] ken2812221 closed pull request #13648: [travis] Increase ccache size for the one which enable debug (master...travis-400m) https://github.com/bitcoin/bitcoin/pull/13648
2692018-07-12T18:39:52  <BlueMatt> gmaxwell: remind me to check next week
2702018-07-12T18:41:33  *** bitconner has joined #bitcoin-core-dev
2712018-07-12T18:46:05  *** bitconner has quit IRC
2722018-07-12T18:46:40  *** bitconner has joined #bitcoin-core-dev
2732018-07-12T18:49:31  *** drexl has joined #bitcoin-core-dev
2742018-07-12T18:51:37  <StayCool> May be another stupid question - is there any plans to integrate support for hardware wallets in Bitcoin Core? the issue with Ledger is that i rely on them for validating transactions, which i'd prefer to do myself, also increasing privacy. Perhaps there is some sort of roadmap for what you guys are working on?
2752018-07-12T18:52:08  <sipa> StayCool: have you looked at BIP174 (PSBT) ?
2762018-07-12T18:53:13  <StayCool> Ah yes i heard about that earlier, i'll have to give it a readthrough :-) Thanks!
2772018-07-12T18:55:25  *** ken2812221 has joined #bitcoin-core-dev
2782018-07-12T18:59:24  *** bitconner has quit IRC
2792018-07-12T18:59:37  *** meshcollider_ has joined #bitcoin-core-dev
2802018-07-12T19:00:03  <wumpus> #startmeeting
2812018-07-12T19:00:03  <lightningbot> Meeting started Thu Jul 12 19:00:03 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2822018-07-12T19:00:03  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2832018-07-12T19:00:10  <achow101> hi
2842018-07-12T19:00:22  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
2852018-07-12T19:00:30  *** bitconner has joined #bitcoin-core-dev
2862018-07-12T19:00:45  <kanzure> hi.
2872018-07-12T19:00:51  <meshcollider_> Hi
2882018-07-12T19:00:53  <jonasschnelli> hi
2892018-07-12T19:00:54  <nmnkgl> hi
2902018-07-12T19:01:10  <cfields> very quick topic suggestion: meeting time poll
2912018-07-12T19:01:20  <ken2812221> hi first time to the meeting
2922018-07-12T19:01:28  <wumpus> so quite some things to discuss today, at least: - Move feature freeze date? (currently july 16th) - 0.16.2 - gitian build to 18.04: what is left to do
2932018-07-12T19:01:32  <meshcollider> Welcome ken2812221 :)
2942018-07-12T19:01:37  <jamesob> howdy
2952018-07-12T19:01:56  <wumpus> #topic meeting time poll (cfields)
2962018-07-12T19:01:59  <cfields> ken2812221: good to see you here :)
2972018-07-12T19:02:06  <cfields> remember to vote on meeting time. If you didn't get a mail about it, now's the time to tell me!
2982018-07-12T19:02:07  *** meshcollider is now known as mesh_
2992018-07-12T19:02:08  *** meshcollider_ is now known as meshcollider
3002018-07-12T19:02:13  * wumpus has voted
3012018-07-12T19:02:13  <cfields> </topic>
3022018-07-12T19:02:18  * sipa has voted
3032018-07-12T19:02:21  * jonasschnelli has voted
3042018-07-12T19:02:23  <instagibbs> yo vote
3052018-07-12T19:02:23  <achow101> when does the poll close?
3062018-07-12T19:02:24  <luke-jr> cfields: your poll made me realise the current time is among the worst possible times for me :P
3072018-07-12T19:02:35  <luke-jr> achow101: after the meeting today IIRC
3082018-07-12T19:02:40  <cfields> achow101: this time next week
3092018-07-12T19:02:46  <luke-jr> ah, next meeting
3102018-07-12T19:02:50  *** meshcollider has quit IRC
3112018-07-12T19:03:03  *** meshcollider has joined #bitcoin-core-dev
3122018-07-12T19:03:10  <wumpus> #topic Move feature freeze date? (wumpus)
3132018-07-12T19:03:11  <cfields> luke-jr: I wanted to give enough time for people to realize they didn't receive a mail to vote
3142018-07-12T19:03:14  <ken2812221> cfield: Can I get an email for voting?
3152018-07-12T19:03:23  <jonasschnelli> wumpus: + how many days/weeks?
3162018-07-12T19:03:29  <wumpus> so the current future freeze is july 16th, which is in a few days
3172018-07-12T19:03:35  <jnewbery> hi
3182018-07-12T19:03:42  <cfields> also, sorry about not using the more convenient doodle. I figured Cornell would be more polite with everyone's email addresses.
3192018-07-12T19:03:42  <sipa> i would be in favor of delaying slightly, let's say a week
3202018-07-12T19:03:49  <jonasschnelli> I'm in favor of moving since i'd like to get scantxout and disableprivatekey in
3212018-07-12T19:03:53  <luke-jr> rwconf is not ready for review yet; I can prioritise it, but unless there's hope for sufficient review before the freeze, I won't
3222018-07-12T19:03:54  <achow101> it would be nice to get psbt (#13557) in for 0.17
3232018-07-12T19:03:58  <sipa> we have many relative big but important improvements that are almost ready
3242018-07-12T19:03:58  <instagibbs> cfields, what effort was made to reach out to folks who don't attend already, yet contribute in either review or PR?
3252018-07-12T19:04:03  <wumpus> so my question is, should we delay it, are there important things that would otherwise miss but are *almost* ready?
3262018-07-12T19:04:04  <gribble> https://github.com/bitcoin/bitcoin/issues/13557 | BIP 174 PSBT Serializations and RPCs by achow101 · Pull Request #13557 · bitcoin/bitcoin · GitHub
3272018-07-12T19:04:04  *** schmidty has joined #bitcoin-core-dev
3282018-07-12T19:04:08  <cfields> ken2812221: pm me your email?
3292018-07-12T19:04:09  <instagibbs> the poll as-is will heavily bias current times :)
3302018-07-12T19:04:28  <instagibbs> oh sorry, new topic
3312018-07-12T19:04:31  <jonasschnelli> achow101: isn't the BIP still in discussion? Or have we finalized it?
3322018-07-12T19:04:36  <cfields> instagibbs: i posted to the mailing list as well. but no further outreach.
3332018-07-12T19:04:43  <sipa> jonasschnelli: it was marked as proposed
3342018-07-12T19:04:44  <luke-jr> wumpus: things can always go into 0.18; my only concern is that the GUI pruning was merged in advance of rwconf
3352018-07-12T19:04:45  <kanzure> i've answered the poll but i also want to complain about its setup (it's like 500 button clicks to answer the full thing)
3362018-07-12T19:04:53  <sipa> jonasschnelli: so not material changes
3372018-07-12T19:04:59  <achow101> jonasschnelli: spec part is finalized. some wording for clarifications may change, but its basically final
3382018-07-12T19:05:07  <jonasschnelli> ack... have plans to review #13557
3392018-07-12T19:05:14  *** bitconner has quit IRC
3402018-07-12T19:05:16  <gribble> https://github.com/bitcoin/bitcoin/issues/13557 | BIP 174 PSBT Serializations and RPCs by achow101 · Pull Request #13557 · bitcoin/bitcoin · GitHub
3412018-07-12T19:05:21  *** bitconne1 has joined #bitcoin-core-dev
3422018-07-12T19:05:23  <achow101> jonasschnelli: beware of unicorns when attempting to review it though
3432018-07-12T19:05:42  <jonasschnelli> achow101: private browsing help while reviewing. :)
3442018-07-12T19:05:47  <cfields> kanzure: sorry :(
3452018-07-12T19:05:51  <sipa> yes, but doesn't let you comment
3462018-07-12T19:06:03  <luke-jr> kanzure: drag and drop worked best IMO
3472018-07-12T19:06:09  <kanzure> oh
3482018-07-12T19:06:51  <sipa> wumpus: would it make sense to put the feature freeze date on or shortly after a weekly meeting?
3492018-07-12T19:07:11  <meshcollider> sipa: you can still log in to GitHub when on private browsing
3502018-07-12T19:07:13  <wumpus> sipa: possibly, though I don't want to keep moving it forward
3512018-07-12T19:07:17  <sipa> wumpus: fair
3522018-07-12T19:07:54  <sipa> meshcollider: heh, i assumed the unicorn was due to being logged in or not; does private browsing itself (regardless of login status) help?
3532018-07-12T19:08:11  <wumpus> we have time-based releases for a good reason, the idea is not to switch to "let's decide in the meeting when it's ready"
3542018-07-12T19:08:16  <achow101> how about moving it to next thursday and try to review things this week?
3552018-07-12T19:08:30  <jonasschnelli> ack
3562018-07-12T19:08:41  <sipa> that's a 3 day delay; ok
3572018-07-12T19:08:42  <wumpus> let's just move it by a week then
3582018-07-12T19:08:49  <meshcollider> I think it helps anyway, don't ask me why lol
3592018-07-12T19:09:06  <achow101> wumpus: ack
3602018-07-12T19:09:07  <wumpus> so july 23
3612018-07-12T19:09:08  <meshcollider> Ack for move
3622018-07-12T19:09:23  <wumpus> will update #12624
3632018-07-12T19:09:24  <gribble> https://github.com/bitcoin/bitcoin/issues/12624 | Release schedule for 0.17.0 · Issue #12624 · bitcoin/bitcoin · GitHub
3642018-07-12T19:10:18  <wumpus> #topic 0.16.2 (wumpus)
3652018-07-12T19:10:42  <wumpus> it'd make sense to do a 0.16.2 release soon
3662018-07-12T19:10:54  <sipa> yeah
3672018-07-12T19:10:57  <wumpus> so it's not too little before 0.17
3682018-07-12T19:11:08  <wumpus> too short*
3692018-07-12T19:11:36  <wumpus> anything that really needs to make it in, besides what is already backported in #13644?
3702018-07-12T19:11:36  <BlueMatt> there is already a backports pr for the rest, I think at #13644
3712018-07-12T19:11:38  <gribble> https://github.com/bitcoin/bitcoin/issues/13644 | 0.16: Remaining backports for 0.16.2 by MarcoFalke · Pull Request #13644 · bitcoin/bitcoin · GitHub
3722018-07-12T19:11:40  <gribble> https://github.com/bitcoin/bitcoin/issues/13644 | 0.16: Remaining backports for 0.16.2 by MarcoFalke · Pull Request #13644 · bitcoin/bitcoin · GitHub
3732018-07-12T19:11:43  <luke-jr> tbh, I'd almost think it's preferable to do a bugfix right before the next major release; but no objections either way
3742018-07-12T19:12:00  <wumpus> ok
3752018-07-12T19:12:05  <luke-jr> (well, right before RC1 anyway)
3762018-07-12T19:12:21  <cfields> luke-jr: but that way if a backport goes bad, potentially both new versions end up busted :\
3772018-07-12T19:12:31  <luke-jr> since we're up against rc1 anyway, this timing seems good
3782018-07-12T19:12:38  <cfields> I'd rather stagger a bit, generally speaking
3792018-07-12T19:12:59  <luke-jr> cfields: true, but hopefully we're more careful than that :x
3802018-07-12T19:13:39  <instagibbs> what is 0.16.2 timeline like?
3812018-07-12T19:14:18  <BlueMatt> instagibbs: once 13644 gets merged, essentially, I think
3822018-07-12T19:14:27  <BlueMatt> hence the "anyone have anything else to shove in?"
3832018-07-12T19:14:38  <MarcoFalke> Yeah. timeline: Backports, merge+test, release
3842018-07-12T19:14:39  <wumpus> yes, as no one mentioned anything else it's just 13644
3852018-07-12T19:14:41  <wumpus> make sure you review that
3862018-07-12T19:14:53  <luke-jr> well, we need a rc1 at least I think?
3872018-07-12T19:14:57  <MarcoFalke> sure
3882018-07-12T19:15:00  <wumpus> yes, as always
3892018-07-12T19:16:39  <wumpus> rc1 then if no significant bug reports, tag final
3902018-07-12T19:16:45  <wumpus> usually a week
3912018-07-12T19:17:27  <wumpus> #topic gitian build to 18.04 ubuntu bionic
3922018-07-12T19:17:37  <sipa> what are the current issues?
3932018-07-12T19:17:47  <sipa> (with upgrading to 18.04)
3942018-07-12T19:17:48  <wumpus> I merged #13177 today, wondering what the remaining issues are
3952018-07-12T19:17:50  <gribble> https://github.com/bitcoin/bitcoin/issues/13177 | GCC-7 and glibc-2.27 back compat code by ken2812221 · Pull Request #13177 · bitcoin/bitcoin · GitHub
3962018-07-12T19:18:14  <wumpus> note that we *must* upgrade, otherwise the qt build will fail (or would have to downgrade qt again, which is a mess)
3972018-07-12T19:18:17  <luke-jr> did vmbuilder get fixed for 18.04?
3982018-07-12T19:18:17  <cfields> I was in denial that I would have toolchain stuff done in time for 0.17. Sadly it's not happening. Just started having a look at the current PRs.
3992018-07-12T19:18:30  <achow101> IIRC vmbuilder doesn't work with 18.04. or maybe it was vmbuilder doesn't work on 18.04.
4002018-07-12T19:18:50  <luke-jr> achow101: I tried it on Gentoo and it couldn't build :/
4012018-07-12T19:18:57  <wumpus> so would need to find another way to build 18.04 VMs?
4022018-07-12T19:19:10  <achow101> yes
4032018-07-12T19:19:11  <luke-jr> or get vmbuilder fixed ideally
4042018-07-12T19:19:21  <achow101> I think vmbuilder is a dead project though
4052018-07-12T19:19:24  <luke-jr> :/
4062018-07-12T19:19:29  <achow101> wumpus: hence my docker thing
4072018-07-12T19:19:55  <cfields> is it not possible to just use a static, pre-prepared rootfs?
4082018-07-12T19:19:57  <wumpus> well, switching to another container shouldn't be necessary
4092018-07-12T19:20:03  <luke-jr> cfields: need a bootloader
4102018-07-12T19:20:04  <wumpus> it's just a matter of building a rootfs
4112018-07-12T19:20:14  <luke-jr> cfields: and who to trust with a rootfs anyway?
4122018-07-12T19:20:27  <cfields> luke-jr: well... ubuntu. currently.
4132018-07-12T19:20:28  <wumpus> you can download pre-made cloud rootfses from ubuntu
4142018-07-12T19:20:32  <luke-jr> oh
4152018-07-12T19:20:45  <cfields> (I was just suggesting we use one of their docker images as a rootfs for gitian)
4162018-07-12T19:20:47  <sipa> dongcarl: present? you were looking into minimal linux images to bootstrap from?
4172018-07-12T19:20:49  <luke-jr> do they have bootloaders somehow too?
4182018-07-12T19:21:26  <wumpus> #link https://cloud-images.ubuntu.com/bionic/current/
4192018-07-12T19:21:44  <achow101> is vmbuilder used for both lxc and kvm?
4202018-07-12T19:21:51  <cfields> luke-jr: tbh I have no idea how bootloaders work for kvm/lxc
4212018-07-12T19:21:52  <achow101> (in gitian)
4222018-07-12T19:22:10  <luke-jr> cfields: for KVM, like real hardware
4232018-07-12T19:22:11  <wumpus> to convert the img to qcow2 for qemu:   qemu-img convert -O qcow2  ${IMAGE} ${VMDIR}/os.img
4242018-07-12T19:22:14  <sipa> wumpus: daily builds? do we retain determinism if people use different builds?
4252018-07-12T19:22:14  <cfields> I always assumed they just jumped straight into init
4262018-07-12T19:22:28  * luke-jr wonders if these ppc64el rootfs would build identical binaries :D
4272018-07-12T19:22:50  <luke-jr> cfields: KVM just virtualized/emulates a real machine
4282018-07-12T19:22:52  <wumpus> sipa: well it does already do an apt-get upgrade before buildling so I don't know if that matters
4292018-07-12T19:23:24  <wumpus> but yes maybe uncertain...
4302018-07-12T19:23:42  <sipa> cfields: LXC even skips init afaik
4312018-07-12T19:23:55  <sipa> cfields: you just run processes in a namespace that doesn't see the rest of your system
4322018-07-12T19:23:57  <luke-jr> I guess the .img files would have a bootloader probably
4332018-07-12T19:24:01  <achow101> sipa: at least with docker, the base ubuntu image changes fairly frequently (within the same version though) and that has produced deterministic binaries for me with different base images
4342018-07-12T19:24:10  <wumpus> right - LXC certainly doesn't need a bootloader
4352018-07-12T19:24:11  <sipa> okay
4362018-07-12T19:24:12  <luke-jr> sipa: init is a userspace process; you can't skip it :P
4372018-07-12T19:24:13  <cfields> I can investigate all this and report back next week
4382018-07-12T19:24:31  <sipa> luke-jr: ...?
4392018-07-12T19:24:35  <wumpus> as I understand it, basically you just launch *any* exceutable in the container
4402018-07-12T19:24:52  <sipa> wumpus: yes, that's my understanding
4412018-07-12T19:24:53  <luke-jr> sipa: init is what handles all the startup daemons etc
4422018-07-12T19:25:02  <wumpus> this an be init, but it can also be just a shell (fairly sure gitian does the latter)
4432018-07-12T19:25:10  <wumpus> luke-jr: there are no startup daemons in gitian
4442018-07-12T19:25:14  <luke-jr> O.o
4452018-07-12T19:25:17  <cfields> wumpus: I always assumed init was just a thin launcher for whatever binary you're telling it to run
4462018-07-12T19:25:18  <wumpus> luke-jr: it simply calls the build script
4472018-07-12T19:25:22  <luke-jr> there are with KVM ofc
4482018-07-12T19:25:30  <wumpus> yes, I mean with LXC
4492018-07-12T19:25:47  <wumpus> cfields: thanks!
4502018-07-12T19:26:14  <cfields> I have a related subtopic, if nothing's queued up next
4512018-07-12T19:26:19  *** ddt_is_dead has joined #bitcoin-core-dev
4522018-07-12T19:27:20  <wumpus> I don't have any more topics
4532018-07-12T19:27:29  <cfields> So, I didn't get the toolchain work done in time for 0.17, but I am nearly finished with the first part: A deterministic, fully static, native x86_64 toolchain capable of rebuilding another native toolchain...
4542018-07-12T19:27:35  <cfields> that doesn't get us anywhere for 0.17...
4552018-07-12T19:27:43  <achow101> for lxc, we don't use vmbuilder, but I'm pretty sure what it does use is not the way to use lxc
4562018-07-12T19:27:49  <achow101> it uses debootstrap
4572018-07-12T19:28:30  <cfields> but it might be helpful to have at least that much built as part of the 0.17 release process. As with that done deterministically, we wouldn't have to rely on a distro toolchain at all for 0.18.
4582018-07-12T19:28:39  <wumpus> ah yes debootstrap, that's a good way to build debian rootfs'es
4592018-07-12T19:29:09  <cfields> so, I'd like to propose possibly adding an extra (optional) gitian descriptor that builders can run as part of the 0.17 release.
4602018-07-12T19:29:10  <sipa> cfields: so what would that entail for 0.17?
4612018-07-12T19:29:11  <cfields> thoughts?
4622018-07-12T19:29:41  *** vicenteH has joined #bitcoin-core-dev
4632018-07-12T19:30:29  <sipa> cfields: i'm not sure what you're suggesting
4642018-07-12T19:30:45  <luke-jr> achow101: vmbuilder also uses debootstrap internally
4652018-07-12T19:31:11  <luke-jr> cfields: is there a way to make this work for non-x86_64?
4662018-07-12T19:31:23  *** dcousens has quit IRC
4672018-07-12T19:31:35  *** dcousens has joined #bitcoin-core-dev
4682018-07-12T19:32:47  <sipa> cfields: adding an extra gitian descriptor for what?
4692018-07-12T19:32:59  <cfields> sipa: at some point we're going to have to use gitian (or similar) to build all deterministic toolchains. The work isn't done for all toolchains yet, but I do have something working that gets us a native one. I'm proposing that we go ahead and build that one, so that it can later be used to build the rest.
4702018-07-12T19:33:12  *** hashist has joined #bitcoin-core-dev
4712018-07-12T19:33:20  *** SopaXorzTaker has quit IRC
4722018-07-12T19:33:31  <sipa> cfields: seems fine to me, but it seems independent of release schedule
4732018-07-12T19:33:41  <cfields> luke-jr: yes, I've just focused on x86_64 as a start
4742018-07-12T19:33:53  <luke-jr> cfields: x86_64 isn't native for me ;)
4752018-07-12T19:34:02  <cfields> sipa: indeed, mostly. I just doubt I'll be able to convince a bunch of people to run a gitian build at any other time :p
4762018-07-12T19:34:17  <sipa> ah, fair
4772018-07-12T19:34:45  * sipa is reminded to try a gitian build again
4782018-07-12T19:35:03  <luke-jr> cfields: ie, I'm not looking at the target platforms, but the build platform
4792018-07-12T19:35:06  <cfields> ok, it's probably not at all clear what I'm getting at. I'll try to get enough together to PR something.
4802018-07-12T19:36:08  <wumpus> ok! thanks in advance
4812018-07-12T19:36:11  <cfields> luke-jr: understood. native x86_64 is capable of building a cross-compiler for a new host. We just need one as a start.
4822018-07-12T19:37:21  <luke-jr> Ubuntu has ppc64el images; so there's no native x86_64 needed is my point
4832018-07-12T19:38:40  <cfields> luke-jr: ok
4842018-07-12T19:38:47  <cfields> </topic>
4852018-07-12T19:39:02  <gmaxwell> cool
4862018-07-12T19:39:03  <wumpus> topic proposals?
4872018-07-12T19:39:57  <gmaxwell> I guess kallewoof isn't here (timezome) but I wondered what was the status of 12257.
4882018-07-12T19:40:05  <gmaxwell> It seems to just be in a rebase rebase cycle.
4892018-07-12T19:40:29  <jonasschnelli> #12257
4902018-07-12T19:40:33  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
4912018-07-12T19:40:57  <wumpus> it has only one "light utack"
4922018-07-12T19:41:20  <sipa> i held off on it, expecting other more invesive changes to coin selection to go in first
4932018-07-12T19:41:34  <gmaxwell> sipa: well, they did!
4942018-07-12T19:41:35  <sipa> but if that isn't happening for 0.17, maybe we can do destination groups first
4952018-07-12T19:41:39  <wumpus> and a "code review ack" but with comments
4962018-07-12T19:41:45  <gmaxwell> (I mean things like BNB got done since that was open)
4972018-07-12T19:42:12  <achow101> gmaxwell: sipa srd fallback is more invasive and probably won't make 0.17
4982018-07-12T19:42:23  <sipa> yeah
4992018-07-12T19:42:31  *** |EHG| has quit IRC
5002018-07-12T19:43:06  <gmaxwell> one of my thougts is that this kind of behavior might makes things like SRD easier to do, from a "impact on the UTXO set" perspective, as it'll cause more utxo consolidation at least for users tha reused.
5012018-07-12T19:44:14  <achow101> gmaxwell: perhaps. I can try a siulation of srd on top of 12257
5022018-07-12T19:44:21  <gmaxwell> In any case, I just wondered where it was standing, I guess its state is "people need to be nagged to review it". I'm not sure if it's a candidate to go in before the freeze.
5032018-07-12T19:44:22  <sipa> achow101: that would be useful
5042018-07-12T19:44:49  <gmaxwell> achow101: would be interesting, but I expect the benefit to be highly usage-pattern dependant. (e.g. this does nothing if you never reuse)
5052018-07-12T19:45:23  <wumpus> no opinion of whether it should go into 0.17, but I think it could just as well be called a fix as a feature
5062018-07-12T19:45:56  <gmaxwell> I also agree that it's a (privacy) fix.
5072018-07-12T19:46:18  <sipa> it's an obvious improvement for sure
5082018-07-12T19:46:35  <gmaxwell> in any case, I hit the PR accidentally, I'd forgotten about it, sounds like some of the rest of us did to. I'll give it a review. (or try, wallet stuff isn't my strongest point :) )
5092018-07-12T19:46:37  <luke-jr> I don't agree it's a fix, since it only affects people doing things with undefined behaviour; but it seems harmless enough
5102018-07-12T19:47:44  *** hashist has left #bitcoin-core-dev
5112018-07-12T19:48:26  <gmaxwell> luke-jr: https://bitcointalk.org/index.php?action=profile;u=3318  I see an address there, and it's been paid mannny times. :P so seems like it might help you personally.
5122018-07-12T19:48:31  <luke-jr> also the behavioural changes can be made a no-op pretty trivially
5132018-07-12T19:49:01  <luke-jr> ie, we could merge it before the freeze, and trivially revert the behaviour if a problem is found
5142018-07-12T19:49:21  *** StayCool has quit IRC
5152018-07-12T19:49:44  <gmaxwell> Right, it's also very unagressive by default. E.g. won't pay extra fees to achieve its end.. which sounded reasonable to me for an initial deployment.
5162018-07-12T19:50:21  <gmaxwell> I'd hope in the future we'd let it pay more in fees, esp if we have a mechnism to estimate if fees are historically high or low.
5172018-07-12T19:50:39  <gmaxwell> but getting to that future requires getting the basic functionality in. :)
5182018-07-12T19:50:46  <luke-jr> FWIW, I have read through the code at least once; just not in enough detail I'd felt comfortable ACKing
5192018-07-12T19:51:23  <gmaxwell> Okay, I think this topic is done... Consider yourselves reminded. I'm glad to know there wasn't some other blocker.
5202018-07-12T19:51:59  <wumpus> any other topics?
5212018-07-12T19:52:11  <gmaxwell> [META] Perhaps we should have a standing item to load up the PR list for regular contribtors who aren't at the meeting to make sure we're not forgetting their PRs.
5222018-07-12T19:52:29  *** ken2812221 has quit IRC
5232018-07-12T19:52:39  <gmaxwell> I see also that there are some jl2012 PRs languishing that I'll probably talk to pieter about outside of the meeting.
5242018-07-12T19:53:10  <wumpus> well I've intentially skipped high priority for review this time, seems it's pretty clear, just need to get the features for 0.17 in asap
5252018-07-12T19:53:23  <gmaxwell> yea, I meant that as a long term thing.
5262018-07-12T19:53:29  <wumpus> right, I agree then
5272018-07-12T19:53:32  *** ken2812221 has joined #bitcoin-core-dev
5282018-07-12T19:55:29  <wumpus> #endmeeting
5292018-07-12T19:55:29  <lightningbot> Meeting ended Thu Jul 12 19:55:29 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5302018-07-12T19:55:29  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-07-12-19.00.html
5312018-07-12T19:55:29  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-07-12-19.00.txt
5322018-07-12T19:55:29  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-07-12-19.00.log.html
5332018-07-12T19:56:02  <jonasschnelli> I think #9662 is ready,... maybe needs a final review
5342018-07-12T19:56:07  <gribble> https://github.com/bitcoin/bitcoin/issues/9662 | Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets by jonasschnelli · Pull Request #9662 · bitcoin/bitcoin · GitHub
5352018-07-12T19:56:44  <gmaxwell> thats a low PR number.
5362018-07-12T19:56:57  <jonasschnelli> Yes. We should nail this down... or close.
5372018-07-12T19:57:00  <sipa> woooooow 4 digits
5382018-07-12T19:57:16  <sipa> jonasschnelli: i'm hesitant about adding more "modes" to a wallet that aren't very well integrated
5392018-07-12T19:57:30  <luke-jr> I have a 3-digit PR I still maintain :p
5402018-07-12T19:57:38  *** Murch has joined #bitcoin-core-dev
5412018-07-12T19:58:04  <jonasschnelli> sipa: IMO an enforce watch-only mode is required for a transition to move keys away from the wallet
5422018-07-12T19:58:12  <sipa> jonasschnelli: and longer-term the descriptors work should generalize it
5432018-07-12T19:58:28  <sipa> jonasschnelli: so i'm thinking about additional difficulty of converting more types of wallets from one thing to another
5442018-07-12T19:58:32  <sipa> but i also don't want to delay things
5452018-07-12T19:59:13  <jonasschnelli> I think disableprivatekey is a transition mode. We need something that ensures that no hot key will be created in cold storage mode
5462018-07-12T19:59:22  <wumpus> it's certainly a useful mode
5472018-07-12T19:59:23  <jonasschnelli> Assume you forget the change address in fundrawtx with watch-only
5482018-07-12T19:59:29  <sipa> yes, i'm not disagreeing with the functionality at all
5492018-07-12T19:59:29  <jonasschnelli> bum... change key is hot
5502018-07-12T19:59:41  <sipa> just scared about more combinations of things to deal with
5512018-07-12T20:00:05  <wumpus> yes
5522018-07-12T20:00:07  <jonasschnelli> Yes. I see that point...
5532018-07-12T20:00:10  <gmaxwell> The functionality seems like an obvious no brainer.
5542018-07-12T20:00:15  <sipa> indeed
5552018-07-12T20:00:41  <jonasschnelli> IMO that mode will probably stay (not the implementation though)
5562018-07-12T20:01:01  <gmaxwell> The wallet is a mess of conditional logic though from grafted on features.  I wonder how related this feature is to the "don't create a wallet file at all, until a key is requested or encryption is activated".
5572018-07-12T20:02:30  <jonasschnelli> gmaxwell: Yes. Though you would still want a feature where you are sure "keys can't be requested".
5582018-07-12T20:04:02  * jonasschnelli sees plenty of unicorns recently
5592018-07-12T20:06:11  <jonasschnelli> A thought for next meeting: enforce PGP signature for security@bitcoincore.org (bounce email with no PGP signature), drop spam.
5602018-07-12T20:06:41  <gmaxwell> PGP encryption, I assume you mean. :)
5612018-07-12T20:07:00  <gmaxwell> It would need to bounce with pgp instructions. I guess. But I've thought that before.
5622018-07-12T20:07:05  <jonasschnelli> Ideally,... but a valid signature would probably be okay?
5632018-07-12T20:07:07  <BlueMatt> what, you dont enjoy the nonstop stream of "I'm being blackmailed, can you send free moneyz to addr A" or "please freeze account Y, your bitcoin project is clearly an illegal front and you need to shut it down" garbage?
5642018-07-12T20:07:32  <BlueMatt> also, no backscatter, please
5652018-07-12T20:07:33  <jonasschnelli> BlueMatt: hehe,... not really. :)
5662018-07-12T20:07:35  <gmaxwell> For people who don't get those emails, some context is that the address gets a fair number of email from sad confused people who lost their bitcoin (or claim to be), and other ... emails that we really can't do anything about.
5672018-07-12T20:09:05  <harding> Maybe gate the actual email address by a form on the website?  It wouldn't ask them to submit their actual security content to the website, but it could probably redirect some of those people to other places.
5682018-07-12T20:09:10  <gmaxwell> jonasschnelli: probably just matching for the pgp header. :P
5692018-07-12T20:09:37  <jonasschnelli> gmaxwell: Yes! Indeed... that shouldn't be to hard to implement... probably a spamassasin rule
5702018-07-12T20:09:42  *** goatpig has quit IRC
5712018-07-12T20:09:46  <jonasschnelli> (with a custom bounce text)
5722018-07-12T20:11:05  *** davec has quit IRC
5732018-07-12T20:11:59  <promag> heh meeting day :/
5742018-07-12T20:15:18  <promag> unicorn on #12196
5752018-07-12T20:15:26  <gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub
5762018-07-12T20:19:42  *** |EHG| has joined #bitcoin-core-dev
5772018-07-12T20:25:54  <bitcoin-git> [bitcoin] ken2812221 opened pull request #13650: [travis] Don't store debug info if --enable-debug is set (master...travis-debug-fix) https://github.com/bitcoin/bitcoin/pull/13650
5782018-07-12T20:26:46  <bitcoin-git> [bitcoin] Empact opened pull request #13651: Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe (master...mark-inputs-dirty) https://github.com/bitcoin/bitcoin/pull/13651
5792018-07-12T20:27:41  *** bitconne1 has quit IRC
5802018-07-12T20:35:04  *** ken2812221 has quit IRC
5812018-07-12T20:42:57  *** str4d has quit IRC
5822018-07-12T20:45:51  *** hashist has joined #bitcoin-core-dev
5832018-07-12T21:15:03  *** bitconner has joined #bitcoin-core-dev
5842018-07-12T21:20:49  <bitcoin-git> [bitcoin] Empact opened pull request #13652: Fix that CWallet::AbandonTransaction would only traverse one level (master...fix-abandon-transaction) https://github.com/bitcoin/bitcoin/pull/13652
5852018-07-12T21:29:45  <achow101> gmaxwell: so I tried doing a "create wallet on use" thing and it got horribly complicated due to some things directly calling walletdb functions rather than some wrapper where it could be more easily implemented
5862018-07-12T21:31:35  *** davec has joined #bitcoin-core-dev
5872018-07-12T21:42:15  *** Guyver2 has quit IRC
5882018-07-12T21:46:14  *** bitconner has quit IRC
5892018-07-12T21:59:46  <cfields> wtf
5902018-07-12T21:59:53  <cfields> "debootstrap was written by Anthony Towns <ajt@debian.org>"
5912018-07-12T22:00:15  <cfields> we've had a ringer in here all along?!
5922018-07-12T22:04:47  *** belcher has quit IRC
5932018-07-12T22:09:19  *** meshcollider has quit IRC
5942018-07-12T22:11:13  *** Victorsueca has quit IRC
5952018-07-12T22:11:35  *** drexl has quit IRC
5962018-07-12T22:12:25  *** Victorsueca has joined #bitcoin-core-dev
5972018-07-12T22:13:07  *** schmidty has quit IRC
5982018-07-12T22:14:14  *** vicenteH has quit IRC
5992018-07-12T22:17:52  <kanzure> cfields: ajtowns was leader of the debian project for a while
6002018-07-12T22:18:37  <aj> cfields: haha :)
6012018-07-12T22:19:16  <cfields> huh, I had no clue
6022018-07-12T22:19:29  *** vicenteH has joined #bitcoin-core-dev
6032018-07-12T22:19:33  <cfields> aj: this Bionic mess is all yours, then :p
6042018-07-12T22:20:31  <aj> cfields: that sounds like an ubuntu codename though!
6052018-07-12T22:21:54  <cfields> aj: ah, so that's the problem :)
6062018-07-12T22:21:58  <aj> wow, launchpad bug ids are over 1.7M now
6072018-07-12T22:22:44  <aj> cfields: what's the mess?
6082018-07-12T22:23:36  *** bitconner has joined #bitcoin-core-dev
6092018-07-12T22:23:43  <cfields> aj: heh, just kidding about the mess. we're migrating to a newer Ubuntu version for Gitian, but some of the tools are deprecated.
6102018-07-12T22:27:32  *** hashist has left #bitcoin-core-dev
6112018-07-12T22:31:57  *** bitconner has quit IRC
6122018-07-12T22:37:47  *** Krellan has joined #bitcoin-core-dev
6132018-07-12T22:38:32  <achow101> I think the problems I have been having with lxc are version problems. apparently lxc 3 changed a bunch of stuff for config files but gitian-builder hasn't updated to those yet. there's an open pr to fix that though
6142018-07-12T22:38:51  <achow101> for kvm, vmbuilder is just borked. afaict, it hasn't been updated since 2010
6152018-07-12T22:41:11  *** bitconner has joined #bitcoin-core-dev
6162018-07-12T23:15:58  *** nmnkgl has quit IRC
6172018-07-12T23:24:12  <luke-jr> aj: the mess is that vmbuilder fails to build bionic VMs
6182018-07-12T23:32:52  <achow101> luke-jr: there's some forks of vmbuilder that have updated it. e.g. https://github.com/newroco/vmbuilder
6192018-07-12T23:33:29  <luke-jr> ooh
6202018-07-12T23:33:29  <achow101> I was thinking that maybe gitian-builder can just have that directly in the git tree and just use it for building the kvm vms instead of using the old vmbuilder
6212018-07-12T23:33:57  <luke-jr> embedding copies of dependencies is stupid; just need to make it easy for people to get the updated dep
6222018-07-12T23:34:10  <cfields> lxc doesn't require vmbuilder. I've almost got it going, just a few annoying version bugs
6232018-07-12T23:34:26  <sipa> cfields: nice
6242018-07-12T23:34:34  <cfields> and for kvm, I think maybe we can transition to uvtool
6252018-07-12T23:34:37  <achow101> cfields: I got lxc working after applying https://github.com/devrandom/gitian-builder/pull/178
6262018-07-12T23:35:03  <luke-jr> cfields: another Ubuntu-specific tool? :/
6272018-07-12T23:35:16  <cfields> achow101: it depends on versions. xenial -> bionic is currently busted
6282018-07-12T23:35:17  <luke-jr> sounds like it requires libvirt :<
6292018-07-12T23:35:39  <cfields> the lxc devs aren't doing too well with back/forward compatibility :(
6302018-07-12T23:35:47  <achow101> yeah..
6312018-07-12T23:36:22  <cfields> and ubuntu has some dependency hell. haven't run into that in a while
6322018-07-12T23:36:49  <luke-jr> cfields: not everyone uses Ubuntu
6332018-07-12T23:37:06  <cfields> luke-jr: I'm aware.
6342018-07-12T23:38:08  <cfields> luke-jr: this is just broken distro stuff that we can create notes for. Hopefully other distros don't need as much hand-holding :\