1 2018-07-23T00:01:13  <sipa> ha, the tv show?
  2 2018-07-23T00:02:11  <MarcoFalke> jup
  3 2018-07-23T00:02:31  *** sneakerhax has joined #bitcoin-core-dev
  4 2018-07-23T00:03:05  <gmaxwell> so now "CI" means confidential informant, not continious integration?
  5 2018-07-23T00:03:33  <sipa> gmaxwell: oh! now i understand the tv show!
  6 2018-07-23T00:03:39  <sipa> (j/k)
  7 2018-07-23T00:05:33  <MarcoFalke> lol, I don't get much in the show. Not sure if its due to the language or the way they made the 3:4 to widescreen
  8 2018-07-23T00:16:29  <luke-jr> that's seriously annoying. -.-
  9 2018-07-23T00:16:37  <luke-jr> (the close/reopen)
 10 2018-07-23T00:17:36  <sipa> MarcoFalke: watch with english subtitles
 11 2018-07-23T00:19:30  *** goatpig has quit IRC
 12 2018-07-23T00:19:30  <MarcoFalke> luke-jr: It seems less annoying than having to re-run all travis configurations locally
 13 2018-07-23T00:21:59  <ken2812221> Is there any way to have bitcoin-git ignore DrahtBot?
 14 2018-07-23T00:24:09  <gmaxwell> would it be better if drahtbot did the close reopen all at once, once a week?
 15 2018-07-23T00:25:26  <sipa> MarcoFalke: another idea for the "this PR conflicts with ..." message; what if it's just a single comment that gets updated, rather than a new one each time?
 16 2018-07-23T00:25:41  <MarcoFalke> sipa: I do update the comment
 17 2018-07-23T00:25:56  *** promag has joined #bitcoin-core-dev
 18 2018-07-23T00:26:17  <sipa> oh!
 19 2018-07-23T00:26:37  <sipa> my apologies, i should have checked
 20 2018-07-23T00:26:56  <sipa> what's the threshold for closing/reopening?
 21 2018-07-23T00:27:23  <sipa> MarcoFalke: also, does travis not have an api through which you can re-run things?
 22 2018-07-23T00:27:43  <MarcoFalke> See for example the dropdown in https://github.com/bitcoin/bitcoin/pull/13449#issuecomment-397424236
 23 2018-07-23T00:28:15  <MarcoFalke> sipa: It does, but it uses the merge commit of  when the pull was created
 24 2018-07-23T00:28:22  <MarcoFalke> Also the yaml of when the pull was created
 25 2018-07-23T00:28:35  <sipa> MarcoFalke: ah, yes
 26 2018-07-23T00:28:45  <MarcoFalke> It might be possible to overwrite the yaml: https://docs.travis-ci.com/user/triggering-builds/#Customizing-the-build-configuration
 27 2018-07-23T00:29:13  <MarcoFalke> though, I haven't checked if it might also be possible to overwrite the commit
 28 2018-07-23T00:29:35  <MarcoFalke>  <gmaxwell> would it be better if drahtbot did the close reopen all at once, once a week?
 29 2018-07-23T00:29:38  <MarcoFalke> Thats a good idea
 30 2018-07-23T00:30:21  *** promag has quit IRC
 31 2018-07-23T00:30:26  <MarcoFalke> The initial volume was so high because it was the first runs (and I lowered the threshold a bit for each run)
 32 2018-07-23T00:52:04  *** promag has joined #bitcoin-core-dev
 33 2018-07-23T00:57:08  *** promag has quit IRC
 34 2018-07-23T01:11:18  *** jpe_ has joined #bitcoin-core-dev
 35 2018-07-23T01:12:02  *** jpe__ has quit IRC
 36 2018-07-23T01:12:51  *** abhayka has joined #bitcoin-core-dev
 37 2018-07-23T01:14:02  *** sneakerhax has quit IRC
 38 2018-07-23T01:30:59  *** Krellan has quit IRC
 39 2018-07-23T01:36:08  *** Krellan has joined #bitcoin-core-dev
 40 2018-07-23T01:37:31  *** unixb0y has quit IRC
 41 2018-07-23T01:42:01  *** unixb0y has joined #bitcoin-core-dev
 42 2018-07-23T01:48:49  *** fanquake has joined #bitcoin-core-dev
 43 2018-07-23T01:51:06  <fanquake> MarcoFalke I forgot to ask yesterday, why would the bot be editing PR descriptions/bodies? Or does that happen for some reason when it open/closes PRs?
 44 2018-07-23T02:01:41  *** promag has joined #bitcoin-core-dev
 45 2018-07-23T02:06:27  *** promag has quit IRC
 46 2018-07-23T02:41:27  *** ken2812221 has quit IRC
 47 2018-07-23T02:44:46  *** mistergold has quit IRC
 48 2018-07-23T02:50:16  *** promag has joined #bitcoin-core-dev
 49 2018-07-23T02:50:58  *** fanquake has quit IRC
 50 2018-07-23T02:52:53  *** rex4539 has quit IRC
 51 2018-07-23T02:53:46  *** ken2812221 has joined #bitcoin-core-dev
 52 2018-07-23T02:54:31  <kallewoof> I'm wondering about #12257. Is it something people would like to try to get into 0.17 or would you rather wait. Also wonder if it is considered a fix or feature, since the feature freeze is today. (I think someone noted that it may be considered a fix, which is why I didn't ask for it to be in high pri list. But I'm not sure if I misunderstood)
 53 2018-07-23T02:54:35  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHubAsset 1Asset 1
 54 2018-07-23T02:55:01  *** promag has quit IRC
 55 2018-07-23T03:10:57  *** ken2812221 has quit IRC
 56 2018-07-23T03:11:02  *** bitconner has quit IRC
 57 2018-07-23T03:14:36  *** bitconner has joined #bitcoin-core-dev
 58 2018-07-23T03:17:58  *** ken2812221 has joined #bitcoin-core-dev
 59 2018-07-23T03:32:51  *** ken2812221 has quit IRC
 60 2018-07-23T03:33:44  *** promag has joined #bitcoin-core-dev
 61 2018-07-23T03:38:59  *** promag has quit IRC
 62 2018-07-23T03:39:00  *** Victorsueca has quit IRC
 63 2018-07-23T03:40:22  *** Victorsueca has joined #bitcoin-core-dev
 64 2018-07-23T03:43:48  *** ken2812221 has joined #bitcoin-core-dev
 65 2018-07-23T03:52:09  *** ken2812221 has quit IRC
 66 2018-07-23T03:52:40  *** ken2812221 has joined #bitcoin-core-dev
 67 2018-07-23T04:01:29  *** DigitalDank has joined #bitcoin-core-dev
 68 2018-07-23T04:03:06  *** DigitalDank has quit IRC
 69 2018-07-23T04:03:50  *** Bill has joined #bitcoin-core-dev
 70 2018-07-23T04:04:14  *** Bill is now known as Guest21850
 71 2018-07-23T04:09:23  *** Guest21850 has quit IRC
 72 2018-07-23T04:09:50  *** Guest21850 has joined #bitcoin-core-dev
 73 2018-07-23T04:10:24  *** Guest21850 has left #bitcoin-core-dev
 74 2018-07-23T04:16:33  *** BillSmith4lyfe has joined #bitcoin-core-dev
 75 2018-07-23T04:18:40  *** masonicb_ has quit IRC
 76 2018-07-23T04:23:04  *** BillSmith4lyfe has quit IRC
 77 2018-07-23T04:23:26  *** BillSmith4lyfe has joined #bitcoin-core-dev
 78 2018-07-23T04:30:58  *** BillSmith4lyfe has quit IRC
 79 2018-07-23T04:32:27  *** BillSmith4lyfe has joined #bitcoin-core-dev
 80 2018-07-23T04:32:50  *** Tralfaz has joined #bitcoin-core-dev
 81 2018-07-23T04:39:45  *** BillSmith4lyfe has quit IRC
 82 2018-07-23T04:40:14  *** BillSmith4lyfe has joined #bitcoin-core-dev
 83 2018-07-23T04:49:35  *** promag has joined #bitcoin-core-dev
 84 2018-07-23T04:53:39  *** intcat has quit IRC
 85 2018-07-23T04:54:25  *** promag has quit IRC
 86 2018-07-23T04:57:43  *** intcat has joined #bitcoin-core-dev
 87 2018-07-23T04:59:08  *** Kaizen_ has joined #bitcoin-core-dev
 88 2018-07-23T05:03:30  *** Kaizen_ has quit IRC
 89 2018-07-23T05:07:20  *** _flow__ has quit IRC
 90 2018-07-23T05:32:16  *** shesek has quit IRC
 91 2018-07-23T05:46:10  *** Krellan has quit IRC
 92 2018-07-23T05:47:00  *** promag has joined #bitcoin-core-dev
 93 2018-07-23T05:48:11  *** SopaXorzTaker has joined #bitcoin-core-dev
 94 2018-07-23T05:50:01  *** Krellan has joined #bitcoin-core-dev
 95 2018-07-23T05:51:58  *** promag has quit IRC
 96 2018-07-23T05:52:11  *** rex4539 has joined #bitcoin-core-dev
 97 2018-07-23T05:52:54  *** rex4539 has joined #bitcoin-core-dev
 98 2018-07-23T06:18:46  *** SopaXorzTaker has quit IRC
 99 2018-07-23T06:19:17  *** SopaXorzTaker has joined #bitcoin-core-dev
100 2018-07-23T06:30:11  *** endless_1 has joined #bitcoin-core-dev
101 2018-07-23T06:33:47  *** endless_1 has quit IRC
102 2018-07-23T07:04:33  *** GoldenBear_ has quit IRC
103 2018-07-23T07:14:46  *** Victorsueca has quit IRC
104 2018-07-23T07:16:02  *** Victorsueca has joined #bitcoin-core-dev
105 2018-07-23T07:17:42  <gmaxwell> it's unfortunate json can't have comments.
106 2018-07-23T07:18:59  <gmaxwell> In juniper configs, the system always writes a comments on lines containing secret data like authentication strings. It's useful so you can grep out the secret lines, but also so you're less likely to foolishly paste them where you shouldn't. It would be nice if e.g. for key outputs we could have a //SECRET KEY, KEEP PRIVATE
107 2018-07-23T07:19:16  <gmaxwell> (inspired by someone who looked like they nearly pasted the output of dumpprivkey into #bitcoin)
108 2018-07-23T07:20:28  *** IGHOR has quit IRC
109 2018-07-23T07:23:27  *** Sinclair6 has quit IRC
110 2018-07-23T07:30:00  *** SopaXorzTaker has quit IRC
111 2018-07-23T07:30:16  <gmaxwell> nmnkgl: I wonder how likely it will be that we'll see a massive rise in 'listeners' as a result of improving propagation privacy.  That attack wont work all that well, but I suppose it makes sense that they'll try. Maybe those who are already willing run run a lot of listners already are.
112 2018-07-23T07:30:32  *** SopaXorzTaker has joined #bitcoin-core-dev
113 2018-07-23T07:31:14  <gmaxwell> I suppose it might be a reason to up the priority of doing things like treating all amazon as a single netgroup.
114 2018-07-23T07:44:33  *** promag has joined #bitcoin-core-dev
115 2018-07-23T07:47:23  *** ken2812221 has quit IRC
116 2018-07-23T07:52:34  *** promag has quit IRC
117 2018-07-23T08:06:08  *** contrapumpkin has quit IRC
118 2018-07-23T08:11:13  *** setpill has joined #bitcoin-core-dev
119 2018-07-23T08:28:35  *** rex4539 has quit IRC
120 2018-07-23T08:29:36  *** timothy has joined #bitcoin-core-dev
121 2018-07-23T08:41:29  *** vicenteH has joined #bitcoin-core-dev
122 2018-07-23T08:42:58  *** owowo has quit IRC
123 2018-07-23T08:47:45  *** masonicboom has joined #bitcoin-core-dev
124 2018-07-23T08:52:23  *** masonicboom has quit IRC
125 2018-07-23T09:04:37  *** SopaXorzTaker has quit IRC
126 2018-07-23T09:04:41  *** SopaXT has joined #bitcoin-core-dev
127 2018-07-23T09:06:00  *** csknk has joined #bitcoin-core-dev
128 2018-07-23T09:22:52  <wumpus> 09:17 < gmaxwell> it's unfortunate json can't have comments.  <- yes :-( all you can do is include dummy text fields
129 2018-07-23T09:23:31  <wumpus> e.g. define what is a comment in your own meta-schema. It's inelegant ofcourse.
130 2018-07-23T09:24:50  <wumpus> but might be worth it for some things, also because it survives the typical json->internal->json roundtrip
131 2018-07-23T09:26:14  <wumpus> "privkey;comment":"SECRET KEY, KEEP PRIVATE"
132 2018-07-23T09:29:56  *** rex4539 has joined #bitcoin-core-dev
133 2018-07-23T09:33:46  *** promag has joined #bitcoin-core-dev
134 2018-07-23T09:47:16  <gmaxwell> darn I was hoping someone that knew more about json would tell me I was wrong. :P
135 2018-07-23T09:48:30  *** bitconner has quit IRC
136 2018-07-23T09:50:58  <wumpus> no, but in this case, being able to embed comments in JSON wouldn't help, they'd get lost in transit. bitcoin-cli parses and reformats the JSON to add indentation and such to make it more human-readable , which would lose comments
137 2018-07-23T09:51:30  <wumpus> for configuration files, comments would be useful, though I think JSON is not a very good confirmation file format
138 2018-07-23T09:54:47  *** akolen has joined #bitcoin-core-dev
139 2018-07-23T09:55:47  <bitcoin-git> [bitcoin] kallewoof opened pull request #13746: -masterdatadir for datadir bootstrapping (master...masterdatadir) https://github.com/bitcoin/bitcoin/pull/13746
140 2018-07-23T09:59:33  *** vicenteH has quit IRC
141 2018-07-23T10:00:06  *** vicenteH has joined #bitcoin-core-dev
142 2018-07-23T10:02:10  *** Krellan has quit IRC
143 2018-07-23T10:03:29  *** bitconner has joined #bitcoin-core-dev
144 2018-07-23T10:08:07  *** bitconner has quit IRC
145 2018-07-23T10:08:27  *** Krellan has joined #bitcoin-core-dev
146 2018-07-23T10:09:46  *** AaronvanW has joined #bitcoin-core-dev
147 2018-07-23T10:10:57  *** ken2812221 has joined #bitcoin-core-dev
148 2018-07-23T10:13:21  *** rex4539 has quit IRC
149 2018-07-23T10:14:12  *** rex4539 has joined #bitcoin-core-dev
150 2018-07-23T10:14:27  *** jtimon has quit IRC
151 2018-07-23T10:14:55  *** bitconner has joined #bitcoin-core-dev
152 2018-07-23T10:17:05  *** vicenteH has quit IRC
153 2018-07-23T10:17:40  *** vicenteH has joined #bitcoin-core-dev
154 2018-07-23T10:17:57  *** Aaronvan_ has joined #bitcoin-core-dev
155 2018-07-23T10:19:53  *** rex4539 has quit IRC
156 2018-07-23T10:20:08  *** jtimon has joined #bitcoin-core-dev
157 2018-07-23T10:21:11  *** AaronvanW has quit IRC
158 2018-07-23T10:23:24  *** Krellan has quit IRC
159 2018-07-23T10:33:33  *** Krellan has joined #bitcoin-core-dev
160 2018-07-23T10:33:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a34593ddb7a...d2186b3db61a
161 2018-07-23T10:33:33  <bitcoin-git> bitcoin/master fa45151 MarcoFalke: doc: Adjust bitcoincore.org links
162 2018-07-23T10:33:34  <bitcoin-git> bitcoin/master d2186b3 Wladimir J. van der Laan: Merge #13742: doc: Adjust bitcoincore.org links...
163 2018-07-23T10:34:35  <bitcoin-git> [bitcoin] laanwj closed pull request #13742: doc: Adjust bitcoincore.org links (master...Mf1807-docBitcoinCore) https://github.com/bitcoin/bitcoin/pull/13742
164 2018-07-23T10:35:59  *** IGHOR has joined #bitcoin-core-dev
165 2018-07-23T10:37:50  *** bitconner has quit IRC
166 2018-07-23T10:39:43  *** bitconner has joined #bitcoin-core-dev
167 2018-07-23T10:42:22  *** _flow_ has joined #bitcoin-core-dev
168 2018-07-23T10:44:34  *** bitconner has quit IRC
169 2018-07-23T10:47:37  *** bitconner has joined #bitcoin-core-dev
170 2018-07-23T10:52:27  *** bitconner has quit IRC
171 2018-07-23T10:53:22  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d2186b3db61a...c0a47da72505
172 2018-07-23T10:53:22  <bitcoin-git> bitcoin/master 84547fa Pieter Wuille: Avoid creating a temporary vector for size-prefixed elements
173 2018-07-23T10:53:23  <bitcoin-git> bitcoin/master c0a47da Wladimir J. van der Laan: Merge #13719: Avoid creating a temporary vector for size-prefixed elements...
174 2018-07-23T10:54:20  <bitcoin-git> [bitcoin] laanwj closed pull request #13719: Avoid creating a temporary vector for size-prefixed elements (master...201807_psbt_no_vec_serialize) https://github.com/bitcoin/bitcoin/pull/13719
175 2018-07-23T10:56:26  <promag> fanquake asked #13529 for 0.17, does it make sense?
176 2018-07-23T10:56:29  <gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
177 2018-07-23T10:57:14  <luke-jr> promag: depends on the oldest Qt version we support I guess
178 2018-07-23T10:57:22  <promag> btw, it should be ready for review
179 2018-07-23T10:58:32  *** Krellan has quit IRC
180 2018-07-23T10:59:08  *** Krellan has joined #bitcoin-core-dev
181 2018-07-23T10:59:47  <promag> luke-jr: at least 5.2, see #13478
182 2018-07-23T10:59:48  <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
183 2018-07-23T11:01:16  *** Emcy has quit IRC
184 2018-07-23T11:03:09  *** belcher has joined #bitcoin-core-dev
185 2018-07-23T11:03:53  *** grafcaps has quit IRC
186 2018-07-23T11:10:56  *** goatpig has joined #bitcoin-core-dev
187 2018-07-23T11:18:42  *** Krellan has quit IRC
188 2018-07-23T11:22:18  <wumpus> luke-jr: 13529 does not change the minimum supported qt version as far as I know
189 2018-07-23T11:22:39  <wumpus> luke-jr: he does not use the particular syntax that requires 5.7
190 2018-07-23T11:23:48  <wumpus> (I might be wrong though)
191 2018-07-23T11:24:27  *** Krellan has joined #bitcoin-core-dev
192 2018-07-23T11:27:27  *** vicenteH has quit IRC
193 2018-07-23T11:29:26  <promag> right, 13529 just requires a qt5, in 5.7 there is a useful template function to make some connects prettier
194 2018-07-23T11:31:20  <wumpus> exactly, we with regard to requiring qt5 we have already crossed that river
195 2018-07-23T11:32:25  <wumpus> promag: I don't have a strong opionion either way, what do you think the risk is that this breaks some connections? can we realistically test this?
196 2018-07-23T11:33:01  <promag> since qt5 supports SIGNAL()/SLOT() macros I don't think there is a rush
197 2018-07-23T11:33:02  <wumpus> we've had some UI behavior silently breaking in the past it would not be great to do that just before a release, though it'd probably be caught in rc
198 2018-07-23T11:33:24  *** Guyver2 has joined #bitcoin-core-dev
199 2018-07-23T11:33:40  *** HoMM has joined #bitcoin-core-dev
200 2018-07-23T11:33:42  *** Krellan has quit IRC
201 2018-07-23T11:33:57  <promag> actually this syntax is better in that case
202 2018-07-23T11:34:31  <wumpus> that is true
203 2018-07-23T11:34:57  <promag> either it compiles (and signal and slot are compatible) or it fails
204 2018-07-23T11:35:00  <wumpus> it is no longer string-based at runtime
205 2018-07-23T11:35:04  <promag> right
206 2018-07-23T11:35:19  <wumpus> to be clear I agree that the new method is much better
207 2018-07-23T11:35:43  <promag> yeah, but could go right after 0.17 IMO
208 2018-07-23T11:36:14  <promag> so we could have a release cycle to make some adjustments
209 2018-07-23T11:38:56  *** Krellan has joined #bitcoin-core-dev
210 2018-07-23T11:43:39  <wumpus> agree-added 0.18 milestone
211 2018-07-23T11:48:11  *** Emcy has joined #bitcoin-core-dev
212 2018-07-23T11:50:02  *** vicenteH has joined #bitcoin-core-dev
213 2018-07-23T11:58:13  *** bitconner has joined #bitcoin-core-dev
214 2018-07-23T12:00:24  *** Sinclair6 has joined #bitcoin-core-dev
215 2018-07-23T12:02:41  *** bitconner has quit IRC
216 2018-07-23T12:03:40  *** HoMM has quit IRC
217 2018-07-23T12:06:58  <MarcoFalke> [21:51] <fanquake> MarcoFalke I forgot to ask yesterday, why would the bot be editing PR descriptions/bodies? Or does that happen for some reason when it open/closes PRs?
218 2018-07-23T12:07:10  <MarcoFalke> I believe this happens everytime you edit an issue: https://developer.github.com/v3/issues/#edit-an-issue
219 2018-07-23T12:09:40  *** promag has quit IRC
220 2018-07-23T12:09:42  *** belcher has quit IRC
221 2018-07-23T12:14:34  *** dqx_ has quit IRC
222 2018-07-23T12:15:57  *** copumpkin has joined #bitcoin-core-dev
223 2018-07-23T12:27:54  <wumpus> wouldn't the travis API have a way to trigger a new test run, instead of relying on closing/opening
224 2018-07-23T12:28:13  <wumpus> it's somewhat ham handed
225 2018-07-23T12:28:46  *** Krellan has quit IRC
226 2018-07-23T12:34:12  *** Krellan has joined #bitcoin-core-dev
227 2018-07-23T12:44:09  *** m8tion has joined #bitcoin-core-dev
228 2018-07-23T12:45:53  *** Sinclair6 has quit IRC
229 2018-07-23T12:47:27  <bitcoin-git> [bitcoin] domob1812 opened pull request #13747: tests: Skip P2PConnection's is_closing() check when not available (master...skip-isclosing) https://github.com/bitcoin/bitcoin/pull/13747
230 2018-07-23T13:00:08  *** grafcaps has joined #bitcoin-core-dev
231 2018-07-23T13:05:15  *** SopaXT has quit IRC
232 2018-07-23T13:07:49  *** SopaXT has joined #bitcoin-core-dev
233 2018-07-23T13:15:04  *** ctrlbreak has quit IRC
234 2018-07-23T13:18:44  *** bitconner has joined #bitcoin-core-dev
235 2018-07-23T13:23:17  *** bitconner has quit IRC
236 2018-07-23T13:24:16  *** dqx_ has joined #bitcoin-core-dev
237 2018-07-23T13:24:48  *** promag has joined #bitcoin-core-dev
238 2018-07-23T13:32:04  *** masonicboom has joined #bitcoin-core-dev
239 2018-07-23T13:32:33  *** dqx_ has quit IRC
240 2018-07-23T13:36:22  *** masonicboom has quit IRC
241 2018-07-23T13:36:37  *** dqx_ has joined #bitcoin-core-dev
242 2018-07-23T13:42:57  *** dqx_ has quit IRC
243 2018-07-23T13:48:08  *** shesek has joined #bitcoin-core-dev
244 2018-07-23T13:48:09  *** shesek has quit IRC
245 2018-07-23T13:48:09  *** shesek has joined #bitcoin-core-dev
246 2018-07-23T13:49:22  *** grafcaps has quit IRC
247 2018-07-23T13:50:20  *** bitconner has joined #bitcoin-core-dev
248 2018-07-23T13:53:30  *** Deadhand has quit IRC
249 2018-07-23T13:53:53  *** Deadhandd has joined #bitcoin-core-dev
250 2018-07-23T13:55:05  *** bitconner has quit IRC
251 2018-07-23T13:55:29  *** dqx_ has joined #bitcoin-core-dev
252 2018-07-23T13:59:14  *** Krellan has quit IRC
253 2018-07-23T14:00:30  *** bitconner has joined #bitcoin-core-dev
254 2018-07-23T14:00:36  <wumpus> kallewoof: will take a look at #12257, I agree it would be nice to get it in
255 2018-07-23T14:00:43  <gribble> https://github.com/bitcoin/bitcoin/issues/12257 | [wallet] Use destination groups instead of coins in coin select by kallewoof · Pull Request #12257 · bitcoin/bitcoin · GitHub
256 2018-07-23T14:04:04  *** dqx_ has quit IRC
257 2018-07-23T14:04:35  *** Krellan has joined #bitcoin-core-dev
258 2018-07-23T14:04:59  *** dqx_ has joined #bitcoin-core-dev
259 2018-07-23T14:04:59  *** rex4539 has joined #bitcoin-core-dev
260 2018-07-23T14:05:13  *** bitconner has quit IRC
261 2018-07-23T14:05:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c0a47da72505...ab28b5b52702
262 2018-07-23T14:05:51  <bitcoin-git> bitcoin/master 64b9f27 Daniel Kraft: Skip is_closing() check when not available....
263 2018-07-23T14:05:52  <bitcoin-git> bitcoin/master ab28b5b MarcoFalke: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available...
264 2018-07-23T14:06:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13747: tests: Skip P2PConnection's is_closing() check when not available (master...skip-isclosing) https://github.com/bitcoin/bitcoin/pull/13747
265 2018-07-23T14:07:07  *** EpicBaldGuy has joined #bitcoin-core-dev
266 2018-07-23T14:11:24  *** SopaXT has quit IRC
267 2018-07-23T14:16:36  *** grafcaps has joined #bitcoin-core-dev
268 2018-07-23T14:19:43  *** Emcy has quit IRC
269 2018-07-23T14:20:14  *** Emcy has joined #bitcoin-core-dev
270 2018-07-23T14:22:29  *** SopaXorzTaker has joined #bitcoin-core-dev
271 2018-07-23T14:26:56  *** SopaXT has joined #bitcoin-core-dev
272 2018-07-23T14:27:15  *** SopaXT has quit IRC
273 2018-07-23T14:28:23  *** SopaXorzTaker has quit IRC
274 2018-07-23T14:28:49  *** SopaXT has joined #bitcoin-core-dev
275 2018-07-23T14:30:03  *** SopaXT has quit IRC
276 2018-07-23T14:31:43  *** SopaXorzTaker has joined #bitcoin-core-dev
277 2018-07-23T14:31:49  *** grafcaps has quit IRC
278 2018-07-23T14:44:24  *** EpicBaldGuy has quit IRC
279 2018-07-23T14:47:15  *** SopaXorzTaker has quit IRC
280 2018-07-23T14:50:33  *** SopaXorzTaker has joined #bitcoin-core-dev
281 2018-07-23T14:53:41  *** SopaXT has joined #bitcoin-core-dev
282 2018-07-23T14:55:00  *** SopaXorzTaker has quit IRC
283 2018-07-23T14:55:19  *** bitconner has joined #bitcoin-core-dev
284 2018-07-23T14:55:30  *** SopaAlt has joined #bitcoin-core-dev
285 2018-07-23T14:58:05  *** SopaXT has quit IRC
286 2018-07-23T14:58:25  *** SopaXorzTaker has joined #bitcoin-core-dev
287 2018-07-23T14:58:28  *** SopaAlt has quit IRC
288 2018-07-23T15:00:22  *** bitconner has quit IRC
289 2018-07-23T15:00:39  *** ken2812221 has quit IRC
290 2018-07-23T15:01:55  *** ExtraCrispy has joined #bitcoin-core-dev
291 2018-07-23T15:12:59  *** bitconner has joined #bitcoin-core-dev
292 2018-07-23T15:16:03  *** SopaXorzTaker has quit IRC
293 2018-07-23T15:16:48  *** SopaXorzTaker has joined #bitcoin-core-dev
294 2018-07-23T15:17:46  *** bitconner has quit IRC
295 2018-07-23T15:18:47  *** games_ has quit IRC
296 2018-07-23T15:19:21  *** skeees has quit IRC
297 2018-07-23T15:19:21  *** jl2012 has quit IRC
298 2018-07-23T15:19:21  *** ibrightly has quit IRC
299 2018-07-23T15:19:21  *** CodeShark_ has quit IRC
300 2018-07-23T15:19:21  *** nejon has quit IRC
301 2018-07-23T15:19:43  *** jl2012 has joined #bitcoin-core-dev
302 2018-07-23T15:19:54  *** nOgAnOo_ has quit IRC
303 2018-07-23T15:19:55  *** Varunram has quit IRC
304 2018-07-23T15:19:55  *** Liliaceae has quit IRC
305 2018-07-23T15:20:14  *** jl2012 has quit IRC
306 2018-07-23T15:20:14  *** jl2012 has joined #bitcoin-core-dev
307 2018-07-23T15:20:14  *** jl2012 has joined #bitcoin-core-dev
308 2018-07-23T15:20:29  *** infernix has quit IRC
309 2018-07-23T15:20:29  *** barq has quit IRC
310 2018-07-23T15:20:29  *** fronti has quit IRC
311 2018-07-23T15:20:42  *** masonicboom has joined #bitcoin-core-dev
312 2018-07-23T15:21:02  *** luke-jr has quit IRC
313 2018-07-23T15:21:31  *** games_ has joined #bitcoin-core-dev
314 2018-07-23T15:21:31  *** nejon has joined #bitcoin-core-dev
315 2018-07-23T15:21:35  *** CodeShark_ has joined #bitcoin-core-dev
316 2018-07-23T15:21:42  *** skeees has joined #bitcoin-core-dev
317 2018-07-23T15:21:45  *** Varunram has joined #bitcoin-core-dev
318 2018-07-23T15:21:51  *** ibrightly has joined #bitcoin-core-dev
319 2018-07-23T15:22:02  *** fronti has joined #bitcoin-core-dev
320 2018-07-23T15:22:14  *** rev_strangehope has quit IRC
321 2018-07-23T15:23:12  *** Liliaceae has joined #bitcoin-core-dev
322 2018-07-23T15:23:16  *** nOgAnOo_ has joined #bitcoin-core-dev
323 2018-07-23T15:23:19  *** barq has joined #bitcoin-core-dev
324 2018-07-23T15:23:22  *** Varunram has quit IRC
325 2018-07-23T15:23:22  *** Varunram has joined #bitcoin-core-dev
326 2018-07-23T15:23:22  *** Varunram has joined #bitcoin-core-dev
327 2018-07-23T15:24:17  *** barq has quit IRC
328 2018-07-23T15:24:18  *** barq has joined #bitcoin-core-dev
329 2018-07-23T15:24:18  *** barq has joined #bitcoin-core-dev
330 2018-07-23T15:25:37  *** masonicboom has quit IRC
331 2018-07-23T15:25:42  *** luke-jr has joined #bitcoin-core-dev
332 2018-07-23T15:26:12  *** luke-jr has quit IRC
333 2018-07-23T15:26:12  *** luke-jr has joined #bitcoin-core-dev
334 2018-07-23T15:26:25  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/7ebd8c6385253bfa30175169a22f93474d8ddfaf
335 2018-07-23T15:26:26  <bitcoin-git> bitcoin/master 7ebd8c6 Wladimir J. van der Laan: qt: Update translation source messages...
336 2018-07-23T15:28:57  *** rev_strangehope has joined #bitcoin-core-dev
337 2018-07-23T15:29:31  *** infernix has joined #bitcoin-core-dev
338 2018-07-23T15:29:32  *** dqx_ has quit IRC
339 2018-07-23T15:29:38  *** bitconner has joined #bitcoin-core-dev
340 2018-07-23T15:31:06  <ossifrage> Has anyone noticed a large uptick in "ERROR: AcceptBlockHeader: prev block not found" messages? Any idea which fork they are coming from?
341 2018-07-23T15:34:38  *** bitconner has quit IRC
342 2018-07-23T15:40:14  *** dqx_ has joined #bitcoin-core-dev
343 2018-07-23T15:48:55  *** dqx_ has quit IRC
344 2018-07-23T15:52:55  *** dqx_ has joined #bitcoin-core-dev
345 2018-07-23T15:58:46  *** AhNo1 has joined #bitcoin-core-dev
346 2018-07-23T16:01:33  *** Kaizen_ has joined #bitcoin-core-dev
347 2018-07-23T16:02:34  *** setpill has quit IRC
348 2018-07-23T16:05:09  *** Kaizen_ has quit IRC
349 2018-07-23T16:10:15  *** masonicboom has joined #bitcoin-core-dev
350 2018-07-23T16:27:51  <wumpus> ossifrage: I see the message in the log of every node I've checked, but don't see a clear uptick recently
351 2018-07-23T16:28:16  <wumpus> --haven't plotted or done any statistics though
352 2018-07-23T16:29:14  <ossifrage> yeah, my statistics where just grep and wc
353 2018-07-23T16:31:23  *** bitconner has joined #bitcoin-core-dev
354 2018-07-23T16:31:25  *** Victorsueca has quit IRC
355 2018-07-23T16:32:40  *** Victorsueca has joined #bitcoin-core-dev
356 2018-07-23T16:35:57  *** bitconner has quit IRC
357 2018-07-23T16:36:31  *** dqx_ has quit IRC
358 2018-07-23T16:37:10  *** dqx_ has joined #bitcoin-core-dev
359 2018-07-23T16:44:54  *** dqx_ has quit IRC
360 2018-07-23T16:48:01  *** dqx_ has joined #bitcoin-core-dev
361 2018-07-23T16:52:57  *** dqx_ has quit IRC
362 2018-07-23T16:53:41  <harding> ossifrage: I see an uptick here too, but not one that looks significant to me: https://imgur.com/a/jxithRY
363 2018-07-23T17:01:06  *** csknk has quit IRC
364 2018-07-23T17:02:00  *** bitconner has joined #bitcoin-core-dev
365 2018-07-23T17:07:00  *** bitconner has quit IRC
366 2018-07-23T17:10:09  *** lnostdal has quit IRC
367 2018-07-23T17:10:25  *** shesek has quit IRC
368 2018-07-23T17:12:29  *** vicenteH has quit IRC
369 2018-07-23T17:13:07  *** dqx_ has joined #bitcoin-core-dev
370 2018-07-23T17:13:16  *** vicenteH has joined #bitcoin-core-dev
371 2018-07-23T17:17:23  *** bitconner has joined #bitcoin-core-dev
372 2018-07-23T17:22:25  *** bitconner has quit IRC
373 2018-07-23T17:23:25  <cfields> jonasschnelli / wumpus: I didn't get around to reviewing #9502 after the meeting as promised last week. Still possible to get that in? I'm going through it right now. I'd hate to see it missed for 0.17 because I forgot about it :(
374 2018-07-23T17:23:28  <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
375 2018-07-23T17:23:34  *** lnostdal has joined #bitcoin-core-dev
376 2018-07-23T17:24:31  *** shesek has joined #bitcoin-core-dev
377 2018-07-23T17:25:24  <ossifrage> harding, in my case I think it is just that my node has been up for a while and the connection count is wandering up and with it the non-bitcoin nodes (recently lost my old ip address thanks to verizon-quality)
378 2018-07-23T17:25:28  <cfields> ossifrage: Are you running master? If so, I'd guess it's from #11637.
379 2018-07-23T17:25:30  <gribble> https://github.com/bitcoin/bitcoin/issues/11637 | p2p: Remove dead service bits code by MarcoFalke · Pull Request #11637 · bitcoin/bitcoin · GitHubAsset 1Asset 1
380 2018-07-23T17:26:39  <ossifrage> I'm running b330f3fdd56b2dccc106154575af46ebb53e1ad9 from Fri Jun 29 10:08:52 2018
381 2018-07-23T17:41:08  *** bitconner has joined #bitcoin-core-dev
382 2018-07-23T17:43:13  *** ken2812221 has joined #bitcoin-core-dev
383 2018-07-23T17:45:45  *** bitconner has quit IRC
384 2018-07-23T17:51:53  *** Krellan has quit IRC
385 2018-07-23T17:52:59  *** vicenteH has quit IRC
386 2018-07-23T17:55:43  *** bitconner has joined #bitcoin-core-dev
387 2018-07-23T17:56:52  <bitcoin-git> [bitcoin] jnewbery closed pull request #10160: Add updatepeer RPC (master...updatepeer) https://github.com/bitcoin/bitcoin/pull/10160
388 2018-07-23T17:58:23  *** polydin has quit IRC
389 2018-07-23T17:59:00  <jonasschnelli> wumpus: I think we can postpone #9502 to 0.18
390 2018-07-23T17:59:04  <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
391 2018-07-23T17:59:37  <jonasschnelli> I didn't had the time to check if there are rebase issues (since it quite old now)
392 2018-07-23T18:00:23  *** bitconner has quit IRC
393 2018-07-23T18:00:36  *** polydin has joined #bitcoin-core-dev
394 2018-07-23T18:02:06  *** bmoo0 has joined #bitcoin-core-dev
395 2018-07-23T18:03:58  *** Urgo_ has joined #bitcoin-core-dev
396 2018-07-23T18:03:59  *** Urgo has quit IRC
397 2018-07-23T18:04:03  *** Urgo_ is now known as Urgo
398 2018-07-23T18:05:15  <cfields> jonasschnelli: you sure?
399 2018-07-23T18:05:36  *** Kaizen_ has joined #bitcoin-core-dev
400 2018-07-23T18:10:31  *** Kaizen_ has quit IRC
401 2018-07-23T18:12:17  *** dqx_ has quit IRC
402 2018-07-23T18:14:41  *** bitconner has joined #bitcoin-core-dev
403 2018-07-23T18:16:05  *** dqx_ has joined #bitcoin-core-dev
404 2018-07-23T18:19:24  *** grafcaps has joined #bitcoin-core-dev
405 2018-07-23T18:24:38  *** bitconner has quit IRC
406 2018-07-23T18:27:38  *** bitconner has joined #bitcoin-core-dev
407 2018-07-23T18:29:46  *** SopaXT has joined #bitcoin-core-dev
408 2018-07-23T18:31:48  *** SopaXT has quit IRC
409 2018-07-23T18:32:00  *** SopaXorzTaker has quit IRC
410 2018-07-23T18:32:46  *** bitconner has quit IRC
411 2018-07-23T18:33:29  *** polydin has quit IRC
412 2018-07-23T18:37:22  *** polydin has joined #bitcoin-core-dev
413 2018-07-23T18:52:37  *** bitconner has joined #bitcoin-core-dev
414 2018-07-23T18:53:55  *** m8tion has quit IRC
415 2018-07-23T18:54:02  *** booyah has quit IRC
416 2018-07-23T18:59:44  *** owowo has joined #bitcoin-core-dev
417 2018-07-23T19:21:48  <wumpus> jonasschnelli: ok, yes, makes sense
418 2018-07-23T19:24:43  <wumpus> cfields: yes, it's unfortunate, it's an old PR and it's too bad it got too little review
419 2018-07-23T19:25:07  <wumpus> cfields: but it's not your fault.
420 2018-07-23T19:38:09  *** bmoo0 has quit IRC
421 2018-07-23T19:48:33  <jonasschnelli> wumpus: I think we can postpone #9502 to 0.18
422 2018-07-23T19:48:36  <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
423 2018-07-23T19:48:46  <jonasschnelli> sry... misstype
424 2018-07-23T19:49:44  <jonasschnelli> cfields: no hurry with that PR. The main reason why I'd like to get it merged at some point is that it helps with an potential SPV mode
425 2018-07-23T20:03:22  *** tryphe_ has joined #bitcoin-core-dev
426 2018-07-23T20:05:44  *** tryphe has quit IRC
427 2018-07-23T20:21:02  *** d9b4bef9 has quit IRC
428 2018-07-23T20:22:08  *** d9b4bef9 has joined #bitcoin-core-dev
429 2018-07-23T20:28:41  *** Randolf has joined #bitcoin-core-dev
430 2018-07-23T20:47:09  *** timothy has quit IRC
431 2018-07-23T20:48:46  *** vicenteH has joined #bitcoin-core-dev
432 2018-07-23T20:50:57  *** un1c0d3r has joined #bitcoin-core-dev
433 2018-07-23T20:51:46  *** masonicboom has quit IRC
434 2018-07-23T20:54:39  *** polydin has quit IRC
435 2018-07-23T20:58:35  *** masonicboom has joined #bitcoin-core-dev
436 2018-07-23T21:05:56  *** Kaizen_ has joined #bitcoin-core-dev
437 2018-07-23T21:10:47  *** Kaizen_ has quit IRC
438 2018-07-23T21:11:39  *** CubicEarth has quit IRC
439 2018-07-23T21:14:12  *** CubicEarth has joined #bitcoin-core-dev
440 2018-07-23T21:15:05  *** bitconner has quit IRC
441 2018-07-23T21:18:50  *** booyah has joined #bitcoin-core-dev
442 2018-07-23T21:35:26  *** Sinclair6 has joined #bitcoin-core-dev
443 2018-07-23T21:38:09  *** CubicEarth has quit IRC
444 2018-07-23T21:40:04  *** Victorsueca has quit IRC
445 2018-07-23T21:40:08  *** Sinclair_ has joined #bitcoin-core-dev
446 2018-07-23T21:40:44  *** CubicEarth has joined #bitcoin-core-dev
447 2018-07-23T21:41:32  *** Victorsueca has joined #bitcoin-core-dev
448 2018-07-23T21:43:39  *** Sinclair6 has quit IRC
449 2018-07-23T21:45:43  *** bitconner has joined #bitcoin-core-dev
450 2018-07-23T21:50:22  *** rafalcpp_ has joined #bitcoin-core-dev
451 2018-07-23T21:50:39  *** rafalcpp has quit IRC
452 2018-07-23T21:53:34  *** hospes_ has joined #bitcoin-core-dev
453 2018-07-23T21:55:22  *** Guyver2 has quit IRC
454 2018-07-23T21:57:36  *** hospes_ has quit IRC
455 2018-07-23T21:58:23  *** bmoo0 has joined #bitcoin-core-dev
456 2018-07-23T22:03:00  *** Randolf has quit IRC
457 2018-07-23T22:11:45  *** booyah has quit IRC
458 2018-07-23T22:13:08  *** rex4539 has quit IRC
459 2018-07-23T22:41:10  *** ExtraCrispy has quit IRC
460 2018-07-23T22:47:10  *** un1c0d3r has quit IRC
461 2018-07-23T22:54:50  *** rafalcpp_ has quit IRC
462 2018-07-23T22:55:54  *** rafalcpp_ has joined #bitcoin-core-dev
463 2018-07-23T22:58:35  *** masonicboom has quit IRC
464 2018-07-23T23:07:09  *** bmoo0 has quit IRC
465 2018-07-23T23:16:56  *** dqx_ has quit IRC
466 2018-07-23T23:23:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
467 2018-07-23T23:36:29  *** masonicboom has joined #bitcoin-core-dev
468 2018-07-23T23:41:07  *** masonicboom has quit IRC
469 2018-07-23T23:52:44  *** vicenteH has quit IRC
470 2018-07-23T23:57:02  *** d9b4bef9 has quit IRC
471 2018-07-23T23:58:08  *** d9b4bef9 has joined #bitcoin-core-dev
472 2018-07-23T23:58:33  *** vicenteH has joined #bitcoin-core-dev
473 2018-07-23T23:59:01  *** d9b4bef9 has quit IRC