1 2018-09-07T00:02:29  *** miknotauro has joined #bitcoin-core-dev
  2 2018-09-07T00:08:02  *** promag has joined #bitcoin-core-dev
  3 2018-09-07T00:14:08  *** drexl has quit IRC
  4 2018-09-07T00:20:47  *** Chris_Stewart_5 has quit IRC
  5 2018-09-07T00:22:00  *** jcorgan has joined #bitcoin-core-dev
  6 2018-09-07T00:42:32  *** spinza has quit IRC
  7 2018-09-07T00:46:19  *** AaronvanW has quit IRC
  8 2018-09-07T00:49:52  *** esotericnonsens_ has joined #bitcoin-core-dev
  9 2018-09-07T00:49:54  *** esotericnonsense has quit IRC
 10 2018-09-07T00:49:56  *** esotericnonsens_ is now known as esotericnonsense
 11 2018-09-07T00:55:58  *** promag has quit IRC
 12 2018-09-07T01:06:51  *** profmac has joined #bitcoin-core-dev
 13 2018-09-07T01:24:52  <phantomcircuit> LogPrintf is deprecated right?
 14 2018-09-07T01:26:04  <aj> it is?
 15 2018-09-07T01:26:32  *** promag has joined #bitcoin-core-dev
 16 2018-09-07T01:30:18  *** spinza has joined #bitcoin-core-dev
 17 2018-09-07T01:31:12  *** promag has quit IRC
 18 2018-09-07T01:44:18  *** promag has joined #bitcoin-core-dev
 19 2018-09-07T01:46:28  <phantomcircuit> aj, seems like it should be ?
 20 2018-09-07T01:48:22  *** spinza has quit IRC
 21 2018-09-07T01:49:02  *** promag has quit IRC
 22 2018-09-07T01:53:40  <sipa> phantomcircuit: why would it be?
 23 2018-09-07T01:53:46  <sipa> or rather, what else would you use?
 24 2018-09-07T01:55:16  <phantomcircuit> LogPrint ?
 25 2018-09-07T01:56:13  <sipa> one is for messages that are always to be printed, the other only conditionally
 26 2018-09-07T01:59:31  *** Krellan has quit IRC
 27 2018-09-07T02:20:27  *** promag has joined #bitcoin-core-dev
 28 2018-09-07T02:25:28  *** promag has quit IRC
 29 2018-09-07T02:40:46  *** promag has joined #bitcoin-core-dev
 30 2018-09-07T02:45:27  *** promag has quit IRC
 31 2018-09-07T02:47:40  *** spinza has joined #bitcoin-core-dev
 32 2018-09-07T02:49:16  *** esotericnonsense has quit IRC
 33 2018-09-07T02:59:26  *** esotericnonsense has joined #bitcoin-core-dev
 34 2018-09-07T03:02:06  *** promag has joined #bitcoin-core-dev
 35 2018-09-07T03:06:27  *** promag has quit IRC
 36 2018-09-07T03:36:32  *** promag has joined #bitcoin-core-dev
 37 2018-09-07T03:41:33  *** promag has quit IRC
 38 2018-09-07T03:47:59  *** AaronvanW has joined #bitcoin-core-dev
 39 2018-09-07T03:53:39  *** AaronvanW has quit IRC
 40 2018-09-07T03:57:32  *** promag has joined #bitcoin-core-dev
 41 2018-09-07T04:01:47  *** promag has quit IRC
 42 2018-09-07T04:19:12  *** promag has joined #bitcoin-core-dev
 43 2018-09-07T04:23:25  *** promag has quit IRC
 44 2018-09-07T04:49:21  *** promag has joined #bitcoin-core-dev
 45 2018-09-07T04:53:48  *** promag has quit IRC
 46 2018-09-07T05:13:20  *** promag has joined #bitcoin-core-dev
 47 2018-09-07T05:17:46  *** promag has quit IRC
 48 2018-09-07T05:44:59  *** promag has joined #bitcoin-core-dev
 49 2018-09-07T05:47:03  *** ppaqmj has joined #bitcoin-core-dev
 50 2018-09-07T05:49:38  *** promag has quit IRC
 51 2018-09-07T05:52:24  *** morcos has quit IRC
 52 2018-09-07T05:53:56  *** morcos has joined #bitcoin-core-dev
 53 2018-09-07T05:58:15  *** promag has joined #bitcoin-core-dev
 54 2018-09-07T06:03:06  *** promag has quit IRC
 55 2018-09-07T06:19:17  *** RubenSomsen has joined #bitcoin-core-dev
 56 2018-09-07T06:19:46  *** spinza has quit IRC
 57 2018-09-07T06:34:50  *** promag has joined #bitcoin-core-dev
 58 2018-09-07T06:35:05  *** waxwing has quit IRC
 59 2018-09-07T06:35:56  *** Krellan has joined #bitcoin-core-dev
 60 2018-09-07T06:37:58  *** Krellan has joined #bitcoin-core-dev
 61 2018-09-07T06:39:07  *** promag has quit IRC
 62 2018-09-07T06:43:14  *** promag has joined #bitcoin-core-dev
 63 2018-09-07T06:47:33  *** promag has quit IRC
 64 2018-09-07T06:55:00  *** jhfrontz has quit IRC
 65 2018-09-07T06:59:05  *** promag has joined #bitcoin-core-dev
 66 2018-09-07T07:01:04  *** spinza has joined #bitcoin-core-dev
 67 2018-09-07T07:03:48  *** promag has quit IRC
 68 2018-09-07T07:10:56  *** setpill has joined #bitcoin-core-dev
 69 2018-09-07T07:21:17  *** setpill has quit IRC
 70 2018-09-07T07:23:51  *** setpill has joined #bitcoin-core-dev
 71 2018-09-07T07:26:17  *** JackH has quit IRC
 72 2018-09-07T07:26:27  *** spinza has quit IRC
 73 2018-09-07T07:30:37  *** kabaum has joined #bitcoin-core-dev
 74 2018-09-07T07:36:00  *** promag has joined #bitcoin-core-dev
 75 2018-09-07T07:40:28  *** promag has quit IRC
 76 2018-09-07T07:45:50  *** promag has joined #bitcoin-core-dev
 77 2018-09-07T07:45:53  *** Jackielove4u has joined #bitcoin-core-dev
 78 2018-09-07T07:50:04  *** spinza has joined #bitcoin-core-dev
 79 2018-09-07T07:50:04  *** promag has quit IRC
 80 2018-09-07T08:04:26  *** ppaqmj has left #bitcoin-core-dev
 81 2018-09-07T08:12:36  *** waxwing has joined #bitcoin-core-dev
 82 2018-09-07T08:13:00  *** giaki3003 has joined #bitcoin-core-dev
 83 2018-09-07T08:13:57  <giaki3003> Hello! I would like to have some more info on the debug executables Gitian spits out at the end of each build. How are they used?
 84 2018-09-07T08:35:43  *** AaronvanW has joined #bitcoin-core-dev
 85 2018-09-07T08:46:55  <jonasschnelli> giaki3003: they are compiled with debug flags...
 86 2018-09-07T08:47:02  *** kabaum has left #bitcoin-core-dev
 87 2018-09-07T08:47:59  <jonasschnelli> giaki3003: sorry,... more specific: the symbols are available there... gitian compiles with -O2 -g
 88 2018-09-07T08:48:14  <jonasschnelli> The non debug binaries go though contrib/devtools/split-debug.sh
 89 2018-09-07T08:49:34  <giaki3003> Okay, so are they meant to be used with the visual studio debugger? Or something like gdb?
 90 2018-09-07T08:49:52  <jonasschnelli> I'm not familiar with visual studio... but gdb, yes.
 91 2018-09-07T08:50:18  <jonasschnelli> I guess you can also symbolicate a stack trace with the non-debug version if you have the deterministic built debug version of the same build
 92 2018-09-07T08:51:22  <giaki3003> Great, because reading around I saw dbg files popped up as visual studio debugger files
 93 2018-09-07T09:25:17  *** SopaXorzTaker has joined #bitcoin-core-dev
 94 2018-09-07T09:49:52  *** Aaronvan_ has joined #bitcoin-core-dev
 95 2018-09-07T09:52:46  *** AaronvanW has quit IRC
 96 2018-09-07T10:04:40  <luke-jr> I doubt Visual Studio can use them
 97 2018-09-07T10:20:06  *** fanquake has joined #bitcoin-core-dev
 98 2018-09-07T10:20:23  <fanquake> wumpus can you have a look at https://github.com/bitcoin-core/univalue/pull/11
 99 2018-09-07T10:21:19  <giaki3003> Thanks for the info
100 2018-09-07T10:22:24  <giaki3003> Gdb complains about the .dbg files not being executable, already set 775 perms so not sure what is wrong
101 2018-09-07T10:22:34  <giaki3003> What do you usually use for debugging?
102 2018-09-07T10:24:48  *** belcher_ has joined #bitcoin-core-dev
103 2018-09-07T10:34:51  *** Aaronvan_ is now known as AaronvanW
104 2018-09-07T10:38:23  <wumpus> phantomcircuit: no, LogPrintf is not deprecated.
105 2018-09-07T10:38:43  <wumpus> please, don't do so, either
106 2018-09-07T10:40:17  * wumpus still remembers in the old bitcoin source, satoshi had remapped 'printf' with a macro, now that was confusing, but we should make a habit of switching around log function names that just adds to cognitive load
107 2018-09-07T10:41:22  <wumpus> fanquake: yep!
108 2018-09-07T10:46:06  *** belcher_ has quit IRC
109 2018-09-07T10:49:57  *** Sentineo has joined #bitcoin-core-dev
110 2018-09-07T10:52:40  <_flow_> wumpus: jonasschnelli: regarding https://github.com/bitcoin/bitcoin/pull/13621 again: I looked into adding further tests for this, but the tests that I already re-enabled (https://github.com/bitcoin/bitcoin/pull/13621/files#diff-2a344479dbbded9df5d6a4abde2cd48cL60) are exaclty what my PR tries to fix. The issue the PR addresses was the reason those tests got disabled in the first place. Anything
111 2018-09-07T10:52:43  <_flow_> else I could do to help getting the PR merged?
112 2018-09-07T10:53:12  *** Krellan has quit IRC
113 2018-09-07T10:53:52  *** Krellan has joined #bitcoin-core-dev
114 2018-09-07T10:59:07  *** giaki3003 has quit IRC
115 2018-09-07T10:59:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
116 2018-09-07T11:00:18  <wumpus> _flow_: will have a look
117 2018-09-07T11:01:24  <wumpus> yes, I'm somewhat scared of that one
118 2018-09-07T11:02:42  <_flow_> wumpus: Since I have looked at how bitcoind assembles its configuration and touched the code, I fully understand
119 2018-09-07T11:03:11  <_flow_> The main issue is that the configuration is not assembled first and then validated, some things happen here and there
120 2018-09-07T11:03:24  <wumpus> so as I've probably said in the PR, the reason no one dares to touch this stuff is because there are no exhaustive tests for all cases users might be relying on in practice
121 2018-09-07T11:03:30  *** timothy has joined #bitcoin-core-dev
122 2018-09-07T11:03:55  <wumpus> if there were it would be easier to say that something is correct
123 2018-09-07T11:04:39  <_flow_> yep, I hoped that re-activating previously disabled tests would be enough to green light my PR…
124 2018-09-07T11:04:40  <wumpus> so in absence of me being truly convinced that this won't come back to haunt me later because someone's use-case broke, I'm kind of scared to touch it
125 2018-09-07T11:05:29  <wumpus> I'm sorry to have to be like this, I really hate it too, but I want to be honest about it
126 2018-09-07T11:05:58  <wumpus> yes, that does help !
127 2018-09-07T11:06:44  <_flow_> no worries :)
128 2018-09-07T11:07:22  <wumpus> and if everyone else agrees this is an improvement I'm willing to merge it of course, but I just haven't been able to look at it in detail and I'm not, myself, convinced I can think through all impilcations of it now
129 2018-09-07T11:09:12  <_flow_> wumpus: MarcoFalke disabled the tests, would surely be interesting to hear his thoughts
130 2018-09-07T11:09:47  <wumpus> yes!
131 2018-09-07T11:12:53  *** jhfrontz has joined #bitcoin-core-dev
132 2018-09-07T11:13:19  <_flow_> I've pinged him in the PR. We'll see what happens.
133 2018-09-07T11:13:29  *** hashist has joined #bitcoin-core-dev
134 2018-09-07T11:13:58  <wumpus> hopefully we can get this in soon, would be good to have the behavior fixed (without breaking anything else :-) )
135 2018-09-07T11:18:47  *** belcher_ has joined #bitcoin-core-dev
136 2018-09-07T11:32:34  *** promag has joined #bitcoin-core-dev
137 2018-09-07T11:35:30  *** Guyver2 has joined #bitcoin-core-dev
138 2018-09-07T11:36:57  *** promag has quit IRC
139 2018-09-07T12:20:41  *** drexl has joined #bitcoin-core-dev
140 2018-09-07T12:20:57  *** Chris_Stewart_5 has quit IRC
141 2018-09-07T12:26:08  *** ExtraCrispy has quit IRC
142 2018-09-07T12:28:15  *** ExtraCrispy has joined #bitcoin-core-dev
143 2018-09-07T12:48:07  *** dlb76 has quit IRC
144 2018-09-07T12:51:25  *** AaronvanW has quit IRC
145 2018-09-07T12:51:39  *** dlb76 has joined #bitcoin-core-dev
146 2018-09-07T12:52:29  *** AaronvanW has joined #bitcoin-core-dev
147 2018-09-07T12:59:38  *** miknotauro has quit IRC
148 2018-09-07T13:21:51  *** Rootsudo has quit IRC
149 2018-09-07T13:28:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
150 2018-09-07T13:56:21  *** JackH has joined #bitcoin-core-dev
151 2018-09-07T14:03:16  *** RubenSomsen has quit IRC
152 2018-09-07T14:22:28  <BlueMatt> github support mailed back last night and said they've fixed the 500 issues
153 2018-09-07T14:22:37  <BlueMatt> so folks should probably email them again if you still see them anywhere
154 2018-09-07T14:23:40  <provoostenator> They mailed me as well and mine works again.
155 2018-09-07T14:28:52  *** farmerwampum has quit IRC
156 2018-09-07T14:48:14  <ken2812221> Hope that someone can review #14009, functional tests for Windows are enabled on Appveyor.
157 2018-09-07T14:48:16  <gribble> https://github.com/bitcoin/bitcoin/issues/14009 | Simple refactoring: Common code for decoding of hex "objects" by domob1812 · Pull Request #14009 · bitcoin/bitcoin · GitHubAsset 1Asset 1
158 2018-09-07T14:48:50  <ken2812221> wrong PR. should be #14007
159 2018-09-07T14:48:52  <gribble> https://github.com/bitcoin/bitcoin/issues/14007 | tests: Run functional test on Windows and enable it on Appveyor by ken2812221 · Pull Request #14007 · bitcoin/bitcoin · GitHub
160 2018-09-07T14:51:07  <phantomcircuit> wumpus, indeed
161 2018-09-07T15:04:41  *** hashist has left #bitcoin-core-dev
162 2018-09-07T15:09:34  *** Krellan has quit IRC
163 2018-09-07T15:10:24  *** Krellan has joined #bitcoin-core-dev
164 2018-09-07T15:14:26  *** fanquake has quit IRC
165 2018-09-07T15:19:25  *** timothy has quit IRC
166 2018-09-07T16:01:11  *** romanz has joined #bitcoin-core-dev
167 2018-09-07T16:04:36  *** romanz has quit IRC
168 2018-09-07T16:04:52  *** Krellan has quit IRC
169 2018-09-07T16:09:05  *** romanz has joined #bitcoin-core-dev
170 2018-09-07T16:11:25  *** Chris_Stewart_5 has quit IRC
171 2018-09-07T16:13:27  *** romanz has quit IRC
172 2018-09-07T16:14:24  *** romanz has joined #bitcoin-core-dev
173 2018-09-07T16:14:49  *** romanz has joined #bitcoin-core-dev
174 2018-09-07T16:18:28  *** promag has joined #bitcoin-core-dev
175 2018-09-07T16:21:13  *** grubles_ has joined #bitcoin-core-dev
176 2018-09-07T16:21:18  *** romanz has joined #bitcoin-core-dev
177 2018-09-07T16:22:43  *** promag has quit IRC
178 2018-09-07T16:26:41  *** Krellan has joined #bitcoin-core-dev
179 2018-09-07T16:27:21  *** owowo has quit IRC
180 2018-09-07T16:32:21  *** owowo has joined #bitcoin-core-dev
181 2018-09-07T16:33:24  *** Victorsueca has quit IRC
182 2018-09-07T16:34:40  *** Victorsueca has joined #bitcoin-core-dev
183 2018-09-07T16:37:47  *** romanz has quit IRC
184 2018-09-07T16:38:29  *** romanz has joined #bitcoin-core-dev
185 2018-09-07T16:40:07  *** Zenton has quit IRC
186 2018-09-07T16:40:09  *** romanz has joined #bitcoin-core-dev
187 2018-09-07T16:41:26  *** Zenton has joined #bitcoin-core-dev
188 2018-09-07T16:59:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
189 2018-09-07T17:06:01  *** RubenSomsen has joined #bitcoin-core-dev
190 2018-09-07T17:07:22  *** timothy has joined #bitcoin-core-dev
191 2018-09-07T17:25:56  *** SopaXorzTaker has quit IRC
192 2018-09-07T17:26:17  *** SopaXorzTaker has joined #bitcoin-core-dev
193 2018-09-07T17:27:17  *** SopaXorzTaker has quit IRC
194 2018-09-07T17:36:40  *** ExtraCrispy has quit IRC
195 2018-09-07T17:37:34  *** grubles_ has quit IRC
196 2018-09-07T17:49:34  *** Krellan has quit IRC
197 2018-09-07T17:54:04  *** promag has joined #bitcoin-core-dev
198 2018-09-07T17:58:27  *** jcorgan has quit IRC
199 2018-09-07T18:14:04  *** polydin has quit IRC
200 2018-09-07T18:16:27  *** promag has quit IRC
201 2018-09-07T18:21:06  *** grubles has joined #bitcoin-core-dev
202 2018-09-07T18:40:34  *** owowo has quit IRC
203 2018-09-07T18:42:44  <cfields> jonasschnelli: gentle detached sig reminder for 0.17.0rc3
204 2018-09-07T18:43:13  <jonasschnelli> cfields: thanks.. will submit in a couple mins
205 2018-09-07T18:44:02  <provoostenator> *SSHing into Gitian machine, fingers above enter key...*
206 2018-09-07T18:45:00  * provoostenator bangs head on table
207 2018-09-07T18:45:34  *** owowo has joined #bitcoin-core-dev
208 2018-09-07T18:46:21  <cfields> jonasschnelli: no rush. I've already pushed mine. I have to head out soon, so feel free to merge and tag if you're comfortable. Otherwise I'll check later tonight.
209 2018-09-07T18:46:45  *** hebasto has joined #bitcoin-core-dev
210 2018-09-07T18:48:57  <jonasschnelli> cfields: https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/12
211 2018-09-07T18:52:49  <cfields> jonasschnelli: thanks!
212 2018-09-07T18:59:34  <cfields> gitian builders: v0.17.0rc3 detached sigs are pushed
213 2018-09-07T19:11:33  *** Guyver2 has quit IRC
214 2018-09-07T19:18:21  *** plankers has joined #bitcoin-core-dev
215 2018-09-07T19:22:45  <jl2012> is there a reason why it uses "!!" here?: https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L1106
216 2018-09-07T19:23:35  <sipa> jl2012: no
217 2018-09-07T19:24:40  <jl2012> sipa: I assume you wrote this?
218 2018-09-07T19:25:11  <sipa> i believe i did
219 2018-09-07T19:25:24  <sipa> i guess it was to make the conversion to a bool explicit
220 2018-09-07T19:27:10  <jl2012> I see.....
221 2018-09-07T19:27:17  <provoostenator> https://github.com/bitcoin/bitcoin/commit/f5857e5cb5fb03bee9c05d1dd6ba2621cac49179
222 2018-09-07T19:29:49  *** Krellan has joined #bitcoin-core-dev
223 2018-09-07T19:30:46  *** Krellan has joined #bitcoin-core-dev
224 2018-09-07T19:47:07  *** setpill has quit IRC
225 2018-09-07T19:53:16  *** RubenSomsen has quit IRC
226 2018-09-07T20:29:54  *** promag has joined #bitcoin-core-dev
227 2018-09-07T20:35:23  *** AaronvanW has quit IRC
228 2018-09-07T20:49:41  *** miknotauro has joined #bitcoin-core-dev
229 2018-09-07T21:06:51  *** hebasto has quit IRC
230 2018-09-07T21:38:35  *** masonicboom has joined #bitcoin-core-dev
231 2018-09-07T21:44:31  *** schmidty has quit IRC
232 2018-09-07T21:51:30  *** promag has quit IRC
233 2018-09-07T22:20:31  *** belcher_ has quit IRC
234 2018-09-07T22:37:31  *** Victorsueca has quit IRC
235 2018-09-07T22:38:27  *** miknotauro has quit IRC
236 2018-09-07T22:38:41  *** Victorsueca has joined #bitcoin-core-dev
237 2018-09-07T22:45:27  *** jhfrontz has quit IRC
238 2018-09-07T22:49:18  *** jhfrontz has joined #bitcoin-core-dev
239 2018-09-07T23:06:03  *** plankers has quit IRC
240 2018-09-07T23:18:42  *** miknotauro has joined #bitcoin-core-dev
241 2018-09-07T23:25:21  *** profmac has quit IRC
242 2018-09-07T23:33:06  *** Chris_Stewart_5 has quit IRC
243 2018-09-07T23:41:23  *** jrayhawk has quit IRC
244 2018-09-07T23:57:36  *** miknotauro has quit IRC
245 2018-09-07T23:59:56  *** profmac has joined #bitcoin-core-dev