1 2018-09-26T00:11:19  *** Murch has quit IRC
  2 2018-09-26T00:17:51  *** proletesseract has joined #bitcoin-core-dev
  3 2018-09-26T00:31:27  *** dqx has quit IRC
  4 2018-09-26T00:32:30  *** promag has quit IRC
  5 2018-09-26T00:35:52  *** jarthur has joined #bitcoin-core-dev
  6 2018-09-26T00:39:17  <jarthur> MarcoFalke: on #14305 I agree about the functional test ought to have been failing prior to fixing the bad attributes. Would you want to see that addressed in the same PR or a separate one?
  7 2018-09-26T00:39:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14305 | Tests: enforce critical class instance attributes in functional tests by JustinTArthur · Pull Request #14305 · bitcoin/bitcoin · GitHubAsset 1Asset 1
  8 2018-09-26T00:57:15  <michagogo> I seem to have lost the 0.15.2 unsigned bundles :-/
  9 2018-09-26T00:57:46  <michagogo> Looks like the input file name is always the same, uncersionrd
 10 2018-09-26T00:57:51  <michagogo> Unversioned
 11 2018-09-26T00:58:19  <michagogo> And my script `mv`s the output to that input file
 12 2018-09-26T01:03:15  *** promag has joined #bitcoin-core-dev
 13 2018-09-26T01:05:12  <achow101> michagogo: I noticed that too. I'm working on a solution
 14 2018-09-26T01:07:47  *** promag has quit IRC
 15 2018-09-26T01:09:46  *** proletesseract has quit IRC
 16 2018-09-26T01:15:29  *** promag has joined #bitcoin-core-dev
 17 2018-09-26T01:19:52  *** promag has quit IRC
 18 2018-09-26T01:21:21  *** gnusha has joined #bitcoin-core-dev
 19 2018-09-26T01:25:48  *** jpe__ has joined #bitcoin-core-dev
 20 2018-09-26T01:27:41  *** promag has joined #bitcoin-core-dev
 21 2018-09-26T01:28:21  *** jpe_ has quit IRC
 22 2018-09-26T01:32:15  *** promag has quit IRC
 23 2018-09-26T01:40:06  *** promag has joined #bitcoin-core-dev
 24 2018-09-26T01:45:14  *** promag has quit IRC
 25 2018-09-26T01:49:47  *** Zenton has quit IRC
 26 2018-09-26T01:50:21  *** Zenton has joined #bitcoin-core-dev
 27 2018-09-26T01:57:54  *** promag has joined #bitcoin-core-dev
 28 2018-09-26T01:58:26  *** grafcaps has quit IRC
 29 2018-09-26T02:02:17  *** promag has quit IRC
 30 2018-09-26T02:08:12  *** promag has joined #bitcoin-core-dev
 31 2018-09-26T02:10:32  *** Sinclair_ has quit IRC
 32 2018-09-26T02:17:32  *** promag has quit IRC
 33 2018-09-26T02:32:21  *** Zenton has quit IRC
 34 2018-09-26T02:32:29  *** Zenton has joined #bitcoin-core-dev
 35 2018-09-26T02:36:32  *** Chris_Stewart_5 has quit IRC
 36 2018-09-26T02:46:14  *** RubenSomsen has joined #bitcoin-core-dev
 37 2018-09-26T02:50:30  *** promag has joined #bitcoin-core-dev
 38 2018-09-26T02:55:15  *** promag has quit IRC
 39 2018-09-26T03:04:13  *** Emcy has quit IRC
 40 2018-09-26T03:06:18  *** Zenton has quit IRC
 41 2018-09-26T03:07:04  *** Zenton has joined #bitcoin-core-dev
 42 2018-09-26T03:17:00  *** gnusha has quit IRC
 43 2018-09-26T03:18:55  *** gnusha has joined #bitcoin-core-dev
 44 2018-09-26T03:21:45  *** promag has joined #bitcoin-core-dev
 45 2018-09-26T03:23:34  *** bsm117532 has quit IRC
 46 2018-09-26T03:26:06  *** promag has quit IRC
 47 2018-09-26T03:29:41  *** proletesseract has joined #bitcoin-core-dev
 48 2018-09-26T03:58:14  *** promag has joined #bitcoin-core-dev
 49 2018-09-26T04:02:57  *** promag has quit IRC
 50 2018-09-26T04:18:01  *** rh0nj has quit IRC
 51 2018-09-26T04:19:08  *** rh0nj has joined #bitcoin-core-dev
 52 2018-09-26T04:20:46  *** VanCo has joined #bitcoin-core-dev
 53 2018-09-26T04:26:05  *** promag has joined #bitcoin-core-dev
 54 2018-09-26T04:30:34  *** promag has quit IRC
 55 2018-09-26T04:35:37  *** VanCo has left #bitcoin-core-dev
 56 2018-09-26T04:47:52  *** spinza has quit IRC
 57 2018-09-26T05:00:53  *** spinza has joined #bitcoin-core-dev
 58 2018-09-26T05:01:02  *** rex4539 has quit IRC
 59 2018-09-26T05:13:01  *** proletesseract has quit IRC
 60 2018-09-26T05:22:25  *** proletesseract has joined #bitcoin-core-dev
 61 2018-09-26T05:24:02  *** proletesseract has quit IRC
 62 2018-09-26T05:24:10  *** proletesseract has joined #bitcoin-core-dev
 63 2018-09-26T05:24:56  *** gribble has quit IRC
 64 2018-09-26T05:35:29  *** hebasto has joined #bitcoin-core-dev
 65 2018-09-26T05:39:02  *** warren_ is now known as warren
 66 2018-09-26T05:39:07  *** gribble has joined #bitcoin-core-dev
 67 2018-09-26T05:39:26  *** ppaqmj has quit IRC
 68 2018-09-26T05:48:31  *** profmac has quit IRC
 69 2018-09-26T05:50:44  *** promag has joined #bitcoin-core-dev
 70 2018-09-26T05:55:29  *** promag has quit IRC
 71 2018-09-26T06:04:22  *** proletesseract has quit IRC
 72 2018-09-26T06:09:31  *** promag has joined #bitcoin-core-dev
 73 2018-09-26T06:14:11  *** promag has quit IRC
 74 2018-09-26T06:17:14  *** promag has joined #bitcoin-core-dev
 75 2018-09-26T06:22:00  *** promag has quit IRC
 76 2018-09-26T06:35:52  *** promag has joined #bitcoin-core-dev
 77 2018-09-26T06:40:04  *** promag has quit IRC
 78 2018-09-26T06:43:07  *** jarthur has quit IRC
 79 2018-09-26T06:43:45  *** jarthur has joined #bitcoin-core-dev
 80 2018-09-26T06:44:53  *** hebasto has quit IRC
 81 2018-09-26T06:46:06  *** hebasto has joined #bitcoin-core-dev
 82 2018-09-26T06:46:32  *** Krellan has joined #bitcoin-core-dev
 83 2018-09-26T06:49:38  *** promag has joined #bitcoin-core-dev
 84 2018-09-26T06:51:55  *** proletesseract has joined #bitcoin-core-dev
 85 2018-09-26T06:54:26  *** promag has quit IRC
 86 2018-09-26T07:01:47  *** Zenton has quit IRC
 87 2018-09-26T07:27:11  *** Sinclair6 has joined #bitcoin-core-dev
 88 2018-09-26T07:28:59  *** nullptr| has quit IRC
 89 2018-09-26T07:33:06  *** nullptr| has joined #bitcoin-core-dev
 90 2018-09-26T07:41:06  *** SopaXorzTaker has joined #bitcoin-core-dev
 91 2018-09-26T07:41:24  *** proletesseract has quit IRC
 92 2018-09-26T07:48:04  *** proletesseract has joined #bitcoin-core-dev
 93 2018-09-26T08:00:05  *** nullptr| has quit IRC
 94 2018-09-26T08:01:09  *** josephnicholas has joined #bitcoin-core-dev
 95 2018-09-26T08:01:39  *** setpill has joined #bitcoin-core-dev
 96 2018-09-26T08:07:15  *** timothy has joined #bitcoin-core-dev
 97 2018-09-26T08:09:06  *** prometheus_falli has joined #bitcoin-core-dev
 98 2018-09-26T08:12:13  *** t0adst00l has quit IRC
 99 2018-09-26T08:14:46  *** josephnicholas has quit IRC
100 2018-09-26T08:17:59  <wumpus> [back home from Riga, will probably need to catch up on a lot of things]
101 2018-09-26T08:22:10  <wumpus> did anything come in preventing us from tagging 0.17.0 final?
102 2018-09-26T08:23:34  <sipa> wumpus: i'd like to make sure #14289 is not a regression
103 2018-09-26T08:23:35  <gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
104 2018-09-26T08:24:31  <wumpus> okay
105 2018-09-26T08:25:20  <wumpus> yes that one is fairly nasty
106 2018-09-26T08:25:29  <sipa> provoostenator said he was going to retry with 0.16 tomorrow
107 2018-09-26T08:25:50  <sipa> i guess today
108 2018-09-26T08:29:11  *** promag has joined #bitcoin-core-dev
109 2018-09-26T08:30:01  <gmaxwell> even if its not a regression (... I'm pretty sure it is, just maybe not vs 0.16), we still need to do something about it, something could be a release note that just says you can't upgrade from pre-0.13
110 2018-09-26T08:40:13  <wumpus> breaking backwards compatibility, even temporarily, is kind of a bummer — though they could always reindex
111 2018-09-26T08:40:51  <wumpus> would it be possible to detect this scenario and bail out? people might read over it in the release notes, which are huge for major releases
112 2018-09-26T08:41:25  <gmaxwell> we could easily add an exit in that rewind code. though at that point, it might make sense to just fix the problem.
113 2018-09-26T08:43:37  *** Zenton has joined #bitcoin-core-dev
114 2018-09-26T08:48:28  <wumpus> also depends on the risk of the change, e.g. queue limited naively at least could introduce deadlocks
115 2018-09-26T08:49:48  <gmaxwell> yea, obviously not that.
116 2018-09-26T08:55:52  *** SopaXorzTaker has quit IRC
117 2018-09-26T09:12:38  <wumpus> right, that was just an example, but I mean, for master we obviously want a proper long-term solution, for 0.17 it might be safer to prevent it from happening w/ a smaller patch
118 2018-09-26T09:19:14  *** AaronvanW has joined #bitcoin-core-dev
119 2018-09-26T09:36:00  *** nullptr| has joined #bitcoin-core-dev
120 2018-09-26T09:37:05  *** phwalkr has joined #bitcoin-core-dev
121 2018-09-26T10:00:38  *** Victorsueca has quit IRC
122 2018-09-26T10:01:56  *** Victorsueca has joined #bitcoin-core-dev
123 2018-09-26T10:12:14  *** belcher has joined #bitcoin-core-dev
124 2018-09-26T10:13:29  *** intcat has quit IRC
125 2018-09-26T10:15:23  *** intcat has joined #bitcoin-core-dev
126 2018-09-26T10:24:39  *** Krellan has quit IRC
127 2018-09-26T10:25:41  *** Krellan has joined #bitcoin-core-dev
128 2018-09-26T10:27:21  *** Zenton has quit IRC
129 2018-09-26T10:27:42  *** Zenton has joined #bitcoin-core-dev
130 2018-09-26T10:37:06  *** proletesseract has quit IRC
131 2018-09-26T10:44:47  *** reallll has joined #bitcoin-core-dev
132 2018-09-26T10:47:58  *** belcher has quit IRC
133 2018-09-26T10:58:10  *** belcher has joined #bitcoin-core-dev
134 2018-09-26T11:10:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
135 2018-09-26T11:13:34  *** phwalkr has quit IRC
136 2018-09-26T11:14:08  *** phwalkr has joined #bitcoin-core-dev
137 2018-09-26T11:18:40  *** phwalkr has quit IRC
138 2018-09-26T11:24:34  *** Krellan has quit IRC
139 2018-09-26T11:25:23  *** Guyver2 has joined #bitcoin-core-dev
140 2018-09-26T11:25:34  *** Krellan has joined #bitcoin-core-dev
141 2018-09-26T11:26:42  *** karelb has joined #bitcoin-core-dev
142 2018-09-26T11:33:08  <karelb> Hello. I have been thinking about changing the RPC doc format slightly, so it is better parseable to something better looking than this - https://bitcoincore.org/en/doc/0.16.2/rpc/wallet/sendmany/
143 2018-09-26T11:34:16  <karelb> I have tried to write something like a proposal for unified formatting that would help with parsing... I wrote it here
144 2018-09-26T11:34:23  <karelb> https://gist.github.com/karel-3d/1490786786525b0365ea8f459a9fc683
145 2018-09-26T11:34:31  <karelb> this is like draft 0
146 2018-09-26T11:34:41  <karelb> do you think it's a good idea?
147 2018-09-26T11:35:50  <karelb> It requires some small changes to current documentation
148 2018-09-26T11:37:34  *** Emcy has joined #bitcoin-core-dev
149 2018-09-26T11:44:37  *** Emcy has quit IRC
150 2018-09-26T11:47:54  *** Emcy has joined #bitcoin-core-dev
151 2018-09-26T11:55:21  *** promag has quit IRC
152 2018-09-26T11:58:06  <wumpus> the idea to have machine-parseable documentation format that is formatted on the fly has been floated before, at least
153 2018-09-26T12:00:00  <wumpus> I remember one of the dividing issues was whether to have the documentation at the point where the RPC function is implemented (like now) versus in an external, say JSON, file that is embedded at compile time
154 2018-09-26T12:00:27  <wumpus> all in all though it'd certainly be an improvement, the manual space-pushing that has to be done now is silly
155 2018-09-26T12:01:02  <wumpus> and it's also hard to keep things (such as type names) consistent
156 2018-09-26T12:02:55  <wumpus> I think your proposal has the same drawback: it's based on precise text formatting within strings, instead of something more structured; I *guess* it could be enforced by (sigh) another linter, but...
157 2018-09-26T12:04:19  <karelb> I tried to make the current proposal close to the current format
158 2018-09-26T12:05:02  <harding> In a prior discussion, an option was starting with a linter to get things into a uniform structure and then developing the tooling to make adhearing to that structure easy (e.g. the external JSON file).
159 2018-09-26T12:06:03  <karelb> I think external JSON would get outdated soon and people would forget to update
160 2018-09-26T12:08:05  *** Chris_Stewart_5 has quit IRC
161 2018-09-26T12:09:47  <harding> karelb: although that's a risk, the project seems to have an abundance of people willing to PR minor string updates at the moment, so I wouldn't be too worried.
162 2018-09-26T12:09:49  <wumpus> harding: yes, might be the best option in this case, fairly easy in most cases where the text is one text blob in "" (it's mostly the \ escaping of quotes inside that that makes horizontal alignment annoying to do)
163 2018-09-26T12:11:00  <wumpus> right, in the case of an external file, *should* add a comment to each function where it's documented...
164 2018-09-26T12:11:01  <karelb> the proposal I wrote comes from the viewpoint "let's make small changes to current format to make it parseable"... I did not think about lint-ablitiy
165 2018-09-26T12:12:17  <harding> karelb: if it's not linted, then it'll be up to you to either hassle people to use the correct format or to PR lots of minor whitespace changes yourself, neither of which sounds very fun.  :-)
166 2018-09-26T12:14:08  <wumpus> so if you create a format that's consistent ehough to be machine-parseable, for say, generation of formatted web docs, linting is the same process I'd say?
167 2018-09-26T12:14:14  <karelb> the biggest changes are the Markdown stuff which would force backticks, and also would force to add spaces somewhere, so the "description" of the argument don't fall into "pseudocode" on the left
168 2018-09-26T12:14:19  <karelb> wumpus: I guess so!
169 2018-09-26T12:14:26  <wumpus> it doesn't even have to lint on the source code BTW - it could simply call the RPC server, request help, lint that
170 2018-09-26T12:15:40  <harding> karelb: an alternative approach is to maintain your own diff between the `bitcoin-cli help` in its current inconsistent format and the idealized consistent format you suggest, which shouldn't be too much work as the current help is pretty stable, then develop your tooling around that, proving its worth.  Then you'll not only have stronger evidence that it's externally useful, but you'll also have the parsing tools to help create
171 2018-09-26T12:15:40  <harding> the linted and a list of changes that actually need to be made.
172 2018-09-26T12:15:41  <wumpus> (FWIW this is how the manual page generation also works; it calls bitcoind &c --help and generates from that)
173 2018-09-26T12:16:39  <wumpus> in any case work on improving the docs is always welcome, thanks for thinking about this
174 2018-09-26T12:16:43  <karelb> harding: good idea
175 2018-09-26T12:17:35  <karelb> wumpus: I am basically scratching my own itch :D the same with this issue
176 2018-09-26T12:17:35  <karelb> https://github.com/achow101/btcinformation.org/issues/23
177 2018-09-26T12:18:38  <karelb> just today I was trying to google "what is a sighash again?" (since when I do not work on bitcoin for a while I keep forgetting its terminology) and I keep ending up at bitcoin.org developer docs
178 2018-09-26T12:23:30  *** panako has joined #bitcoin-core-dev
179 2018-09-26T12:35:51  <wumpus> I never forget what a sighash is, but I must admit I forget what are the different combinations for it sometimes
180 2018-09-26T12:38:24  *** elichai2 has joined #bitcoin-core-dev
181 2018-09-26T12:40:21  *** Krellan has quit IRC
182 2018-09-26T12:40:58  *** Krellan has joined #bitcoin-core-dev
183 2018-09-26T12:42:31  *** setpill has quit IRC
184 2018-09-26T12:48:30  *** phwalkr has joined #bitcoin-core-dev
185 2018-09-26T12:51:35  <provoostenator> It's that time of the year again where a the new macOS breaks stuff #14327. QT from homebrew doesn't work, depends building is also broken.
186 2018-09-26T12:51:36  <gribble> https://github.com/bitcoin/bitcoin/issues/14327 | macOS Mojave QT 5.11 compilation fails · Issue #14327 · bitcoin/bitcoin · GitHub
187 2018-09-26T12:52:58  *** phwalkr has quit IRC
188 2018-09-26T12:53:15  <provoostenator> Maybe when I buy a new laptop I'll keep the old one around to test beta releases, so we get a few months heads up.
189 2018-09-26T12:56:50  *** jungly has joined #bitcoin-core-dev
190 2018-09-26T13:03:04  *** csknk has joined #bitcoin-core-dev
191 2018-09-26T13:15:56  *** baldur has quit IRC
192 2018-09-26T13:26:56  *** gertjaap has quit IRC
193 2018-09-26T13:27:01  *** rh0nj has quit IRC
194 2018-09-26T13:28:07  *** rh0nj has joined #bitcoin-core-dev
195 2018-09-26T13:33:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
196 2018-09-26T13:35:17  <wumpus> why doesn't travis catch this?
197 2018-09-26T13:35:40  <wumpus> oh, it's a build *on* mac not for mac
198 2018-09-26T13:35:59  <provoostenator> I haven't tried a cross compile to the latest macOS SDK; we build for a much older version afaik.
199 2018-09-26T13:36:24  <wumpus> that would be one of the most difficult things to automate unless there's something like Appveyor for windows for macs
200 2018-09-26T13:36:56  <provoostenator> Perhaps trying to cross-compile to a beta release (~ June / July / August) might also help catch this.
201 2018-09-26T14:02:28  *** baldur has joined #bitcoin-core-dev
202 2018-09-26T14:11:18  *** baldur has quit IRC
203 2018-09-26T14:12:22  *** michaelsdunn1 has joined #bitcoin-core-dev
204 2018-09-26T14:12:31  *** jarthur has quit IRC
205 2018-09-26T14:16:24  *** baldur has joined #bitcoin-core-dev
206 2018-09-26T14:19:46  *** promag has joined #bitcoin-core-dev
207 2018-09-26T14:20:01  <promag> achow101: do you plan to fix #14019 nits?
208 2018-09-26T14:20:04  <gribble> https://github.com/bitcoin/bitcoin/issues/14019 | Import pubkeys when importing p2sh with importmulti by achow101 · Pull Request #14019 · bitcoin/bitcoin · GitHub
209 2018-09-26T14:20:28  <promag> I can push those fixes if you want
210 2018-09-26T14:20:40  <provoostenator> sipa: looks like 0.16.3 memory explodes just as bad during rollback. I'll update the ticket in a bit. Perhaps the easiest solution is to disable it if there's more than ~1000 blocks since SegWit.
211 2018-09-26T14:20:55  <provoostenator> I'll try 0.15.2 later today too.
212 2018-09-26T14:21:13  *** SopaXorzTaker has joined #bitcoin-core-dev
213 2018-09-26T14:23:54  <provoostenator> Speaking of 0.15.2 I'm having a hard time signing the code-signed Windows gitian binary.  macOS worked fine. v0.14.3 worked fine too. I'm using a Debian VM. Is it picky about the gitian-build.sh version?
214 2018-09-26T14:24:08  *** twistedline has quit IRC
215 2018-09-26T14:24:18  <provoostenator> Getting "failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)"
216 2018-09-26T14:32:58  *** SopaXorzTaker has quit IRC
217 2018-09-26T14:35:21  *** irc_viewer_test has joined #bitcoin-core-dev
218 2018-09-26T14:37:21  *** twistedline has joined #bitcoin-core-dev
219 2018-09-26T14:42:03  *** irc_viewer_test has quit IRC
220 2018-09-26T14:44:21  *** rex4539 has joined #bitcoin-core-dev
221 2018-09-26T15:05:10  *** Krellan has quit IRC
222 2018-09-26T15:09:07  *** Krellan has joined #bitcoin-core-dev
223 2018-09-26T15:09:35  <achow101> promag: oh, I didn't see those. I'll fix them later today
224 2018-09-26T15:10:27  <promag> achow101: no problem
225 2018-09-26T15:18:47  *** Krellan has quit IRC
226 2018-09-26T15:37:58  *** proletesseract has joined #bitcoin-core-dev
227 2018-09-26T15:39:27  *** Krellan has joined #bitcoin-core-dev
228 2018-09-26T15:42:24  *** proletesseract has quit IRC
229 2018-09-26T15:43:52  *** Krellan has quit IRC
230 2018-09-26T15:49:09  *** Krellan has joined #bitcoin-core-dev
231 2018-09-26T15:54:01  *** Krellan has quit IRC
232 2018-09-26T15:54:40  *** Krellan has joined #bitcoin-core-dev
233 2018-09-26T15:59:02  *** Krellan has quit IRC
234 2018-09-26T16:00:09  *** Krellan has joined #bitcoin-core-dev
235 2018-09-26T16:20:12  *** Murch has joined #bitcoin-core-dev
236 2018-09-26T16:23:27  *** bralyclow has joined #bitcoin-core-dev
237 2018-09-26T16:25:07  <provoostenator> (fixed Gitian by deleting images from gitian-builder and rebuilding using the v0.16 gitan script)
238 2018-09-26T16:30:27  *** Zenton has quit IRC
239 2018-09-26T16:32:13  *** Chris_Stewart_5 has quit IRC
240 2018-09-26T16:32:42  <andytoshi> achow101: i have a question about psbt BIP 174
241 2018-09-26T16:32:53  <andytoshi> what's the expected behaviour regarding uncompressed ECDSA keys
242 2018-09-26T16:33:01  <andytoshi> the spec doesn't mention this at all and the test vectors only have compressed keys in them
243 2018-09-26T16:34:03  *** morcos has quit IRC
244 2018-09-26T16:34:20  *** morcos has joined #bitcoin-core-dev
245 2018-09-26T16:38:46  <sipa> provoostenator: thanks, so it's an earlier regression
246 2018-09-26T16:39:11  <sipa> provoostenator:, gmaxwell, wumpus: agree with just listing in the release notes that upgrading from 0.13 may not be practical
247 2018-09-26T16:53:30  *** phwalkr has joined #bitcoin-core-dev
248 2018-09-26T16:54:24  *** nehan_ has joined #bitcoin-core-dev
249 2018-09-26T16:55:05  *** nehan_ has quit IRC
250 2018-09-26T16:55:58  *** owowo has quit IRC
251 2018-09-26T16:57:56  *** phwalkr has quit IRC
252 2018-09-26T16:58:25  *** belcher has quit IRC
253 2018-09-26T17:01:04  *** phwalkr has joined #bitcoin-core-dev
254 2018-09-26T17:02:04  <achow101> andytoshi: the same as compressed keys
255 2018-09-26T17:02:33  *** irc_viewer_test has joined #bitcoin-core-dev
256 2018-09-26T17:02:39  <achow101> bip32 is defined for compressed keys only though, so you should only use compressed keys in the bip32 derivs
257 2018-09-26T17:04:05  <dongcarl> ARGHGGHHGHGHGHGHHGHGHHGHHHHGGHHHH
258 2018-09-26T17:04:21  <dongcarl> k
259 2018-09-26T17:04:46  <sipa> achow101: probably worth pointing that out in the bip
260 2018-09-26T17:05:04  <sipa> it's also not all that clear in bip32... it just only talks about serialization using compressed form
261 2018-09-26T17:06:11  <sipa> andytoshi: my view is that compressed and uncompressed are both legal inside bip174, but it's up to each signer/updater/... to choose what they support anyway; some may only support compressed keys
262 2018-09-26T17:07:06  *** Krellan has quit IRC
263 2018-09-26T17:07:07  <andytoshi> ok. the issue is that in rust-bitcoin, we don't store whether a pubkey is compressed or uncompressed, it's just a libsecp secp256k1_pubkey. (our Address and Privkey have this extra info ofc, but the raw ecdsa pubkey type does not)
264 2018-09-26T17:07:36  <sipa> andytoshi: that sounds like it'd make your life hard :)
265 2018-09-26T17:07:37  <andytoshi> so we'll need to do something ad-hoc when parsing public keys to preserve the fact that they were uncompressed (and i think we're just gonna reject hybrid keys)
266 2018-09-26T17:07:43  <sipa> if you want to support uncompressed keys at all
267 2018-09-26T17:08:13  *** Krellan has joined #bitcoin-core-dev
268 2018-09-26T17:08:35  <andytoshi> we haven't had trouble thus far having the compressed/uncompressed distinction only exist as part of bitcoin Privkeys that correspond to bitcoin addresses
269 2018-09-26T17:08:46  <andytoshi> so yeah.. we're basically only supporting uncompressed keys for that one specific use case
270 2018-09-26T17:08:49  <andytoshi> and nowhere else
271 2018-09-26T17:09:10  <achow101> i don't follow what the problem is
272 2018-09-26T17:09:56  <sipa> achow101: i assume the difficulty is that if they're deserializing and reserializing a psbt with uncompressed keys, the uncompressedness information would be lost
273 2018-09-26T17:10:08  <sipa> as the internal type for pubkeys does not store this
274 2018-09-26T17:10:13  <andytoshi> yep
275 2018-09-26T17:11:26  <andytoshi> so if we wrote a combiner with this lib, and it was used in some multiparty protocol where somebody was giving us uncompressed keys, we'd wind up compressing them as a side-effect of combining, and confuse everyone else
276 2018-09-26T17:11:51  *** dqx has joined #bitcoin-core-dev
277 2018-09-26T17:12:16  <sipa> yeah, i think the correct thing to do is to treat a bitcoin-pubkey as a pair of (ec-pubkey, compressedness), as from bitcoin's perspective they're really different things
278 2018-09-26T17:12:34  <sipa> hash is different, p2pkh spend is different, address is different, ...
279 2018-09-26T17:13:06  <andytoshi> yeah
280 2018-09-26T17:13:50  <sipa> but i also think it's more efficient to keep pubkeys in serialized form, and only convert to secp when signing
281 2018-09-26T17:14:07  <sipa> because most operations care about its serialization and not its EC identity
282 2018-09-26T17:14:22  <achow101> andytoshi can't you just copy the bytes instead of parsing it?
283 2018-09-26T17:14:57  <achow101> in many cases, you don't need to know that it's a pubkey, you just need to compare the bytes.
284 2018-09-26T17:15:07  <andytoshi> sipa: verification and bip32 operations all care about the EC identity
285 2018-09-26T17:15:34  *** irc_viewer_test has quit IRC
286 2018-09-26T17:15:35  <sipa> andytoshi: sure, but computing a hash or lookup don't
287 2018-09-26T17:15:53  <andytoshi> sipa: you never hash a public key directly, only scriptpubkeys containing public keys
288 2018-09-26T17:16:07  <sipa> andytoshi: eh, no :)
289 2018-09-26T17:16:11  <andytoshi> achow101: (a) i don't want to do this for type-safety reasons, it's very hard to reason about data structures that might have invalid data in them; (b) i'm pretty sure i need the EC identity in more cases than i need the serialization
290 2018-09-26T17:16:12  <sipa> P2PKH addresses
291 2018-09-26T17:16:18  <andytoshi> oh right
292 2018-09-26T17:16:50  <sipa> andytoshi: but all things that care about EC identity tend to be one-off things; you load an sPK and a witness, convert to secp structures, and verify, and done
293 2018-09-26T17:17:00  <sipa> so you already have the deserialization cost anyway
294 2018-09-26T17:17:04  *** Krellan has quit IRC
295 2018-09-26T17:17:46  *** Krellan has joined #bitcoin-core-dev
296 2018-09-26T17:18:10  <sipa> type safety is a good argument, but you can have a pubkey type that just stores the bytes, but still can only be filled with sensible things (starts with 02, 03, 04, length 33/65, ...)
297 2018-09-26T17:18:33  <andytoshi> then i might as well use a (compressedness, secp pubkey) pair
298 2018-09-26T17:18:50  <sipa> that's expensive :)
299 2018-09-26T17:19:08  <sipa> converting a compressed serialization to that format requires deserialization
300 2018-09-26T17:19:14  <andytoshi> i'm still not convinced that EC operations are "one off things" when i need them to verify signatures and derive public keys, which i do all the time, vs serialization which is only needed when converting to scriptpubkeys or doing network communication
301 2018-09-26T17:19:44  <sipa> the things you do all the time are looking up "does this pubkey belong to me"
302 2018-09-26T17:20:01  <andytoshi> in Core maybe
303 2018-09-26T17:20:15  <sipa> fair, in a library it's less clear what the usage pattern is
304 2018-09-26T17:20:36  <andytoshi> right.. this isn't the case in liquid for example where we spend a lot of time doing p2c derivations and verifying other peoples' signatures
305 2018-09-26T17:20:58  <sipa> but "all the time" isn't what matters; the question is what kind of operations do you do on a pubkey in one batch
306 2018-09-26T17:21:07  <andytoshi> or in a generic PSBT validator where you're really just checking sigs and doing derivations and never really interacting whith the blockchain
307 2018-09-26T17:21:29  <andytoshi> does libsecp expose a way to determine that a pubkey is valid or not without decompressing it?
308 2018-09-26T17:22:14  *** Krellan has quit IRC
309 2018-09-26T17:22:15  <sipa> i don't think so
310 2018-09-26T17:22:30  <andytoshi> yeah..doesn't look like it
311 2018-09-26T17:22:33  <sipa> but whether a pubkey is valid only matters when doing validation
312 2018-09-26T17:22:49  <sipa> or signing
313 2018-09-26T17:22:51  *** owowo has joined #bitcoin-core-dev
314 2018-09-26T17:22:58  <andytoshi> or deriving child keys
315 2018-09-26T17:23:02  <sipa> right
316 2018-09-26T17:23:10  <sipa> all cases where you need to convert to the secp type anyway
317 2018-09-26T17:23:39  <andytoshi> right, but it would be much nicer if i caught invalid data when i received it
318 2018-09-26T17:24:09  <sipa> andytoshi: concrete example: a PSBT signer is more efficient if it doesn't need to deserialize all pubkeys listed in the PSBT file before knowing which ones it can sign with
319 2018-09-26T17:24:32  <sipa> but checking which ones you can sign with is something you can totally do on the byte representation
320 2018-09-26T17:24:34  <andytoshi> hmm, this is true
321 2018-09-26T17:26:12  <sipa> maybe it also doesn't matter; i think we can decompress 200000 keys per second
322 2018-09-26T17:26:50  *** jarthur has joined #bitcoin-core-dev
323 2018-09-26T17:26:59  <andytoshi> it would plausibly matter for an HSM
324 2018-09-26T17:27:11  <sipa> possibly
325 2018-09-26T17:27:21  *** Krellan has joined #bitcoin-core-dev
326 2018-09-26T17:27:21  <andytoshi> in any case I think for the purposes of rust-bitcoin we're not too concerned about that
327 2018-09-26T17:32:16  *** timothy has quit IRC
328 2018-09-26T17:33:02  *** irc_viewer_test has joined #bitcoin-core-dev
329 2018-09-26T17:34:19  *** Zenton has joined #bitcoin-core-dev
330 2018-09-26T17:44:31  *** jarthur has quit IRC
331 2018-09-26T17:45:07  *** Zenton has quit IRC
332 2018-09-26T17:45:28  *** jarthur has joined #bitcoin-core-dev
333 2018-09-26T17:46:26  *** irc_viewer_test has quit IRC
334 2018-09-26T17:56:12  *** phwalkr has joined #bitcoin-core-dev
335 2018-09-26T18:18:37  *** phwalkr has quit IRC
336 2018-09-26T18:28:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
337 2018-09-26T18:39:19  *** jarthur has quit IRC
338 2018-09-26T18:42:20  <provoostenator> sipa: v0.15.2 doesn't have the issue, so it was introduces somewhere in 0.16
339 2018-09-26T18:43:13  <sipa> provoostenator: interesting, thanks!
340 2018-09-26T18:45:18  <provoostenator> I might be able to do a (partial) bisect tomorrow if you're really at a loss where this bug started.
341 2018-09-26T18:45:54  <sipa> i'm sure i can guess by looking at the PR list :)
342 2018-09-26T18:56:47  *** Victorsueca has quit IRC
343 2018-09-26T18:58:04  *** Victorsueca has joined #bitcoin-core-dev
344 2018-09-26T19:36:14  *** dqx has quit IRC
345 2018-09-26T19:36:53  *** dqx has joined #bitcoin-core-dev
346 2018-09-26T19:42:33  <promag> someone willing to spend a minute in #14148?
347 2018-09-26T19:42:33  <gribble> https://github.com/bitcoin/bitcoin/issues/14148 | abandontransaction needed after spending orphaned block reward · Issue #14148 · bitcoin/bitcoin · GitHub
348 2018-09-26T19:46:21  *** Murch has quit IRC
349 2018-09-26T19:57:16  *** proletesseract has joined #bitcoin-core-dev
350 2018-09-26T19:58:01  <gmaxwell> sipa: see, I said it wasn't always there.
351 2018-09-26T19:58:22  *** Zenton has joined #bitcoin-core-dev
352 2018-09-26T20:20:07  *** proletesseract has quit IRC
353 2018-09-26T20:36:51  *** Chris_Stewart_5 has quit IRC
354 2018-09-26T20:41:21  *** Murch has joined #bitcoin-core-dev
355 2018-09-26T20:45:12  *** Murch has quit IRC
356 2018-09-26T20:52:55  *** csknk has quit IRC
357 2018-09-26T20:54:50  *** hebasto has quit IRC
358 2018-09-26T20:59:09  *** proletesseract has joined #bitcoin-core-dev
359 2018-09-26T21:00:32  *** proletesseract has quit IRC
360 2018-09-26T21:00:41  *** proletesseract has joined #bitcoin-core-dev
361 2018-09-26T21:01:14  *** Murch has joined #bitcoin-core-dev
362 2018-09-26T21:01:45  *** proletesseract has quit IRC
363 2018-09-26T21:03:15  *** proletesseract has joined #bitcoin-core-dev
364 2018-09-26T21:04:04  *** jpe__ has quit IRC
365 2018-09-26T21:25:39  *** TheCharlatan has quit IRC
366 2018-09-26T21:28:58  *** Guyver2 has quit IRC
367 2018-09-26T21:29:46  *** irc_viewer_test has joined #bitcoin-core-dev
368 2018-09-26T21:32:03  *** proletesseract has quit IRC
369 2018-09-26T21:32:10  <phantomcircuit> gmaxwell, i simplified the ThreadSocketHandler cleanup in #14335
370 2018-09-26T21:32:12  <gribble> https://github.com/bitcoin/bitcoin/issues/14335 | net: refactor: cleanup ThreadSocketHandler by pstratem · Pull Request #14335 · bitcoin/bitcoin · GitHub
371 2018-09-26T21:34:58  <gmaxwell> phantomcircuit: sweet.
372 2018-09-26T21:42:28  <promag> rfc: sounds good a bool CWallet::IsExternal() const? which returns false if wallet path is in -walletdir ?
373 2018-09-26T21:42:48  <promag> jnewbery: ^
374 2018-09-26T21:43:30  *** tryphe has quit IRC
375 2018-09-26T22:04:00  *** dqx_ has joined #bitcoin-core-dev
376 2018-09-26T22:04:45  *** dqx_ has quit IRC
377 2018-09-26T22:05:23  *** dqx_ has joined #bitcoin-core-dev
378 2018-09-26T22:06:18  *** dqx has quit IRC
379 2018-09-26T22:14:03  *** elichai2 has quit IRC
380 2018-09-26T22:19:26  *** commavir has quit IRC
381 2018-09-26T22:20:48  *** commavir has joined #bitcoin-core-dev
382 2018-09-26T22:37:23  <phantomcircuit> gmaxwell, and #14336 actually implements poll()
383 2018-09-26T22:37:24  <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
384 2018-09-26T22:37:29  *** michaelsdunn1 has quit IRC
385 2018-09-26T22:37:36  <phantomcircuit> im still not sure how to detect whether the poll() available is functional or not
386 2018-09-26T22:38:03  <phantomcircuit> apparently it's broken on OS X <= 10.4
387 2018-09-26T22:38:32  <gmaxwell> the 'brokenness' I saw reported seems irrelevant to us (or at least has a trivial workaround)
388 2018-09-26T22:38:53  <gmaxwell> the brokenness I saw was that when called with an empty fd set it didn't sleep, and instead busylooped.
389 2018-09-26T22:39:45  <phantomcircuit> ah
390 2018-09-26T22:39:48  <phantomcircuit> hmm
391 2018-09-26T22:40:13  <phantomcircuit> well it is possible for us to have no peers but is definitely extremely unusual
392 2018-09-26T22:43:21  <gmaxwell> yes, sure but just add a check if there is an empty fdset, sleep instead of calling poll.
393 2018-09-26T22:43:34  <gmaxwell> which is a perfectly reasonable thing to do.
394 2018-09-26T22:52:31  <phantomcircuit> right
395 2018-09-26T22:52:43  <phantomcircuit> should probably do the same for select() actually
396 2018-09-26T22:55:07  <gmaxwell> yea, it would be a simple thing to do.
397 2018-09-26T22:55:26  <gmaxwell> I mean, absent bugs, pool/select are a perfectly reasonable way to sleep.
398 2018-09-26T23:00:26  <phantomcircuit> gmaxwell, yeah but bugs lol
399 2018-09-26T23:00:52  <phantomcircuit> iirc the boost implementation actually uses them in certain cases but as like th absolute final thing it tries
400 2018-09-26T23:01:35  *** dqx_ has quit IRC
401 2018-09-26T23:02:11  <gmaxwell> poll*
402 2018-09-26T23:08:00  <TD-Linux> bitcoin runs on os x 10.4?
403 2018-09-26T23:09:36  <gmaxwell> I think in the prior discussion we concluded that it didn't but then there was some comment that someone somewhere said OSX brought the bug back.
404 2018-09-26T23:18:04  <sdaftuar> fyi - someone seems to have mined an invalid block on testnet, exploiting the duplicate-input issue
405 2018-09-26T23:18:38  <gmaxwell> If someone wants a lot of sweet sweet testnet coins, they should start mining with a fixed node. :P
406 2018-09-26T23:18:45  <sdaftuar> it's currently the most work chain, though there appears to be a competing chain that is not too far behind
407 2018-09-26T23:19:59  <BlueMatt> heh, I mean if you timewarp it it takes seconds to mine a few blocks
408 2018-09-26T23:20:50  <gmaxwell> When the fixed chain catches up, all the vulnerable nodes will shut off, as disconnecting the inflation will trigger an assertion.
409 2018-09-26T23:22:03  *** rockhouse has quit IRC
410 2018-09-26T23:22:13  <phantomcircuit> gmaxwell, also http://www.greenend.org.uk/rjk/tech/poll.html
411 2018-09-26T23:22:13  *** murrayn has quit IRC
412 2018-09-26T23:22:26  <phantomcircuit> doesn't actually matter for us since we do the same thing for IN/HUP/ERR
413 2018-09-26T23:22:27  *** rockhouse has joined #bitcoin-core-dev
414 2018-09-26T23:22:32  <phantomcircuit> but none the less something to keep in mind
415 2018-09-26T23:23:01  <BlueMatt> phantomcircuit: dont you have an asic lying around? plz timewarp testnet
416 2018-09-26T23:23:35  *** murrayn has joined #bitcoin-core-dev
417 2018-09-26T23:23:54  <phantomcircuit> BlueMatt, effort
418 2018-09-26T23:52:22  *** DougieBot5000_ has joined #bitcoin-core-dev
419 2018-09-26T23:53:22  *** DougieBot5000 has quit IRC
420 2018-09-26T23:53:22  *** DougieBot5000_ is now known as DougieBot5000
421 2018-09-26T23:57:18  *** Murch has quit IRC