1 2018-10-02T00:49:03  *** ghost43 has quit IRC
  2 2018-10-02T00:53:33  *** ghost43 has joined #bitcoin-core-dev
  3 2018-10-02T01:27:26  *** Chris_Stewart_5 has quit IRC
  4 2018-10-02T02:15:02  *** rh0nj has quit IRC
  5 2018-10-02T02:16:07  *** rh0nj has joined #bitcoin-core-dev
  6 2018-10-02T02:16:28  *** Krellan has quit IRC
  7 2018-10-02T02:17:39  *** Krellan has joined #bitcoin-core-dev
  8 2018-10-02T02:28:15  *** Victor_sueca has quit IRC
  9 2018-10-02T02:29:25  *** Victor_sueca has joined #bitcoin-core-dev
 10 2018-10-02T02:37:25  *** Murch has quit IRC
 11 2018-10-02T02:50:39  *** rex4539 has quit IRC
 12 2018-10-02T04:04:20  *** ghost43 has quit IRC
 13 2018-10-02T04:04:35  *** ghost43 has joined #bitcoin-core-dev
 14 2018-10-02T04:14:44  *** jarthur has quit IRC
 15 2018-10-02T04:27:11  *** murrayn has quit IRC
 16 2018-10-02T04:40:41  *** gribble has quit IRC
 17 2018-10-02T04:42:28  *** dbnoch has quit IRC
 18 2018-10-02T04:47:37  *** intcat has quit IRC
 19 2018-10-02T04:50:04  *** intcat has joined #bitcoin-core-dev
 20 2018-10-02T04:53:13  *** gribble has joined #bitcoin-core-dev
 21 2018-10-02T05:18:38  *** Emcy has quit IRC
 22 2018-10-02T05:19:15  *** Emcy has joined #bitcoin-core-dev
 23 2018-10-02T06:13:32  <gwillen> achow101: is it intended to be the case that PSBTs always end with 0x00 (separator after the last map), or that it is always omitted, or that it is optional?
 24 2018-10-02T06:13:46  <gwillen> the BIP reads like it should be mandatory, but I noticed Core is inconsistent about it
 25 2018-10-02T06:14:15  <gwillen> (or sipa or whoever else has an opinion :-) )
 26 2018-10-02T06:51:05  *** hebasto has joined #bitcoin-core-dev
 27 2018-10-02T07:01:18  *** ken2812221 has quit IRC
 28 2018-10-02T07:04:30  *** reardencode has quit IRC
 29 2018-10-02T07:26:26  <jonasschnelli> cfields. macOS 0.17.0 detached signature is available https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/17
 30 2018-10-02T07:35:06  *** murrayn has joined #bitcoin-core-dev
 31 2018-10-02T08:01:42  *** setpill has joined #bitcoin-core-dev
 32 2018-10-02T08:01:56  *** StopAndDecrypt has quit IRC
 33 2018-10-02T08:04:12  *** StopAndDecrypt has joined #bitcoin-core-dev
 34 2018-10-02T08:06:36  *** timothy has joined #bitcoin-core-dev
 35 2018-10-02T08:13:14  <wumpus> gwillen: good question; some people are travelling, if you don't get a response here, please create an issue
 36 2018-10-02T08:14:03  <wumpus> jonasschnelli yay
 37 2018-10-02T08:18:27  *** SopaXorzTaker has joined #bitcoin-core-dev
 38 2018-10-02T08:20:51  *** SopaXorzTaker has quit IRC
 39 2018-10-02T08:27:31  *** Krellan has quit IRC
 40 2018-10-02T08:32:36  <wumpus> and yes, the tests are sort of heavy, if you find that many functional tests fail on your system (esp. related to timeouts) it's a good suggestion to run with parallelism of one
 41 2018-10-02T08:34:47  <sipa> gwillen: no strong opinion, but agree it should be clear and consistent
 42 2018-10-02T08:36:26  *** promag has joined #bitcoin-core-dev
 43 2018-10-02T09:03:10  *** phwalkr has joined #bitcoin-core-dev
 44 2018-10-02T09:05:57  *** SopaXorzTaker has joined #bitcoin-core-dev
 45 2018-10-02T09:06:22  <jonasschnelli> promag: sorry,.. haven't followed the discussion... what needs update there: https://github.com/bitcoin/bitcoin/pull/12653#issuecomment-426202288?
 46 2018-10-02T09:07:06  <promag> IIUC block index is not affected by -blocksdir
 47 2018-10-02T09:09:02  <promag> jonasschnelli: gArgs.IsArgSet("-blocksdir") ? GetDataDir() / "blocks" / "index" : GetBlocksDir() / "index"
 48 2018-10-02T09:11:09  <jonasschnelli> promag: I see. Done. thanks.-
 49 2018-10-02T09:11:23  <promag> np
 50 2018-10-02T09:11:26  <promag> ty
 51 2018-10-02T09:51:40  *** hebasto_ has joined #bitcoin-core-dev
 52 2018-10-02T09:54:41  *** Victor_sueca is now known as Victorsueca
 53 2018-10-02T10:55:14  *** phwalkr has quit IRC
 54 2018-10-02T10:55:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 55 2018-10-02T11:05:00  *** setpill has quit IRC
 56 2018-10-02T11:07:28  *** setpill has joined #bitcoin-core-dev
 57 2018-10-02T11:45:14  *** Chris_Stewart_5 has quit IRC
 58 2018-10-02T11:56:15  *** promag has quit IRC
 59 2018-10-02T12:11:55  *** shesek has quit IRC
 60 2018-10-02T12:31:59  *** panako has quit IRC
 61 2018-10-02T13:08:01  *** SopaXorzTaker has quit IRC
 62 2018-10-02T13:11:34  *** Guyver2 has joined #bitcoin-core-dev
 63 2018-10-02T13:31:10  <andytoshi> gwillen: it should end in a 0x00. that was also my read of the BIP, and it's also the only way to unambiguously parse a PSBT from a stream that might have other data coming down the line
 64 2018-10-02T13:32:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 65 2018-10-02T13:35:31  *** promag has joined #bitcoin-core-dev
 66 2018-10-02T13:44:30  *** ken2812221 has joined #bitcoin-core-dev
 67 2018-10-02T13:52:12  <achow101> gwillen: it should end in 0x00
 68 2018-10-02T13:52:29  <achow101> how is core inconsistent about it?
 69 2018-10-02T13:52:45  <achow101> I believe there's even a test vector for this. a parser should reject a psbt if it doesn't end in 0x00
 70 2018-10-02T14:19:35  *** belcher_ has joined #bitcoin-core-dev
 71 2018-10-02T14:20:56  *** michaelsdunn1 has joined #bitcoin-core-dev
 72 2018-10-02T14:25:21  *** promag has quit IRC
 73 2018-10-02T14:54:14  *** Lauda has quit IRC
 74 2018-10-02T14:54:53  *** Lauda has joined #bitcoin-core-dev
 75 2018-10-02T14:58:59  *** profmac has quit IRC
 76 2018-10-02T15:12:30  *** profmac has joined #bitcoin-core-dev
 77 2018-10-02T15:43:21  <cfields> jonasschnelli: thanks!
 78 2018-10-02T15:43:30  <cfields> gitian builders: detached sigs for v0.17.0 are pushed
 79 2018-10-02T16:00:16  *** Krellan has joined #bitcoin-core-dev
 80 2018-10-02T16:04:30  *** Krellan has quit IRC
 81 2018-10-02T16:11:43  *** owowo has quit IRC
 82 2018-10-02T16:11:53  *** shinohai has joined #bitcoin-core-dev
 83 2018-10-02T16:19:15  *** owowo has joined #bitcoin-core-dev
 84 2018-10-02T16:26:25  *** promag has joined #bitcoin-core-dev
 85 2018-10-02T17:03:29  *** Murch has joined #bitcoin-core-dev
 86 2018-10-02T17:13:01  *** promag has quit IRC
 87 2018-10-02T17:32:20  *** W4RL0RD__ has joined #bitcoin-core-dev
 88 2018-10-02T17:35:55  *** Lauda has quit IRC
 89 2018-10-02T17:36:25  *** Lauda has joined #bitcoin-core-dev
 90 2018-10-02T17:43:47  *** Krellan has joined #bitcoin-core-dev
 91 2018-10-02T17:44:34  *** ken2812221_ has joined #bitcoin-core-dev
 92 2018-10-02T17:46:21  *** ken2812221 has quit IRC
 93 2018-10-02T17:46:27  *** ken2812221_ is now known as ken2812221
 94 2018-10-02T17:51:56  *** Krellan has quit IRC
 95 2018-10-02T17:55:03  *** CubicEarth has quit IRC
 96 2018-10-02T17:57:21  *** CubicEarth has joined #bitcoin-core-dev
 97 2018-10-02T18:18:36  <phantomcircuit> wumpus, lots of the tests seem to be racey
 98 2018-10-02T18:18:43  <phantomcircuit> the zmq ones especially
 99 2018-10-02T18:20:08  *** Zenton has quit IRC
100 2018-10-02T18:20:17  *** Zenton has joined #bitcoin-core-dev
101 2018-10-02T18:22:25  <wumpus> phantomcircuit: yes i's true
102 2018-10-02T18:23:01  <wumpus> although I think that has improved
103 2018-10-02T18:23:45  <wumpus> there's one test that simply fails on very slow systems but I don't remember which one right now, but the others pass even under very crappy circumstances
104 2018-10-02T18:24:00  <wumpus> (counting only the non-extended tests)
105 2018-10-02T18:33:54  <phantomcircuit> wumpus, running "test_runner.py" with small changes to the timing of networking logic makes them fail randomly
106 2018-10-02T18:35:35  <gwillen> andytoshi: achow101: ok, let me double-check and then try to create a minimal example of when core creates one that does not end in 0x00
107 2018-10-02T18:38:06  <gwillen> crap, okay, what happened is that I dropped a character from the end of a PSBT string while copy-pasting
108 2018-10-02T18:38:15  <gwillen> and decodepsbt still accepted it
109 2018-10-02T18:39:30  <gwillen> as does finalizepsbt
110 2018-10-02T18:51:41  *** W4RL0RD__ has quit IRC
111 2018-10-02T18:52:04  *** W4RL0RD__ has joined #bitcoin-core-dev
112 2018-10-02T18:55:46  *** mthiel_ has joined #bitcoin-core-dev
113 2018-10-02T18:57:33  *** mthiel has quit IRC
114 2018-10-02T19:00:55  *** W4RL0RD__ has quit IRC
115 2018-10-02T19:02:40  *** ExtraCrispy has joined #bitcoin-core-dev
116 2018-10-02T19:40:16  *** dqx has joined #bitcoin-core-dev
117 2018-10-02T19:44:21  <andytoshi> does core have a fuzz-testing harness? might be worthwhile to try round-tripping these
118 2018-10-02T19:47:19  <wumpus> andytoshi: yes, test_bitcoin_fuzzy.cpp
119 2018-10-02T19:48:16  <wumpus> phantomcircuit: ok... any idea which specific messages cause the problem? what kind of failures?
120 2018-10-02T19:48:49  <phantomcircuit> wumpus, the zmq ones especially fail
121 2018-10-02T19:49:03  <phantomcircuit> the getzmqnotifications fails
122 2018-10-02T19:49:26  <phantomcircuit> which im sure is just a race
123 2018-10-02T19:49:48  <phantomcircuit> it's hard to diagnose cause they tend to work on my laptop but not on travis
124 2018-10-02T19:49:53  <phantomcircuit> maybe i need a slower test system
125 2018-10-02T20:00:37  *** brianhoffman has quit IRC
126 2018-10-02T20:06:05  <wumpus> if it's just zmq I'm not *too* worried
127 2018-10-02T20:07:06  <phantomcircuit> and apparently, feature_notifications
128 2018-10-02T20:07:36  <phantomcircuit> with too much parallelism everything explodes cause we run out of local ports to bind to but that's not really something to easily fix
129 2018-10-02T20:08:29  <achow101> gwillen: base64 has some padding characters at the end of the string if it isn't some specifc length (a multiple of some number I can't remember). Core's implementation of base64 drops those padding characters and then decodes. you're probably dropping a padding char which is thus being ignored
130 2018-10-02T20:08:58  <achow101> the padding is the = characters you see at the end of base64 strings.
131 2018-10-02T20:11:32  <gwillen> achow101: the character in question is an A, which is 0, so while it's not padding I can imagine there could be ambiguity
132 2018-10-02T20:12:17  <achow101> hmm. can you give me a psbt that should be wrong but decodes fine?
133 2018-10-02T20:12:21  <gwillen> if we're using padding consistently, we should possibly refuse to decode truncated base64
134 2018-10-02T20:12:28  <gwillen> i.e. base64 that's not a multiple of four bytes
135 2018-10-02T20:12:37  <gwillen> achow101: cHNidP8BAHMCAAAAAbiWoY6pOQepFsEGhUPXaulX9rvye2NH+NrdlAHg+WgpAQAAAAD/////AkBLTAAAAAAAF6kUqWwXCcLM5BN2zoNqMNT5qMlIi7+HQEtMAAAAAAAXqRSVF/in2XNxAlN1OSxkyp0z+Wtg2YcAAAAAAAEBIBNssgAAAAAAF6kUamsvautR8hRlMRY6OKNTx03DK96HAQcXFgAUo8u1LWpHprjt/uENAwBpGZD0UH0BCGsCRzBEAiAONfH3DYiw67ZbylrsxCF/XXpVwyWBRgofyRbPslzvwgIgIKCsWw5sHSIPh1icNvcVLZLHWj6NA7Dk+4Os2pOnMbQBIQPGStfYHPtyhpV7zIWtn0Q4GXv5gK1zy/tnJ+cBXu4iiwABABYAFMwmJQEz+HDpBEEabxJ5PogPsqZRAAEAFg
136 2018-10-02T20:12:46  <gwillen> er, sorry, cHNidP8BAHMCAAAAAbiWoY6pOQepFsEGhUPXaulX9rvye2NH+NrdlAHg+WgpAQAAAAD/////AkBLTAAAAAAAF6kUqWwXCcLM5BN2zoNqMNT5qMlIi7+HQEtMAAAAAAAXqRSVF/in2XNxAlN1OSxkyp0z+Wtg2YcAAAAAAAEBIBNssgAAAAAAF6kUamsvautR8hRlMRY6OKNTx03DK96HAQcXFgAUo8u1LWpHprjt/uENAwBpGZD0UH0BCGsCRzBEAiAONfH3DYiw67ZbylrsxCF/XXpVwyWBRgofyRbPslzvwgIgIKCsWw5sHSIPh1icNvcVLZLHWj6NA7Dk+4Os2pOnMbQBIQPGStfYHPtyhpV7zIWtn0Q4GXv5gK1zy/tnJ+cBXu4iiwABABYAFMwmJQEz+HDpBEEabxJ5PogPsqZRAAEAF
137 2018-10-02T20:13:00  <gwillen> hm, that may be too long for IRC
138 2018-10-02T20:13:30  <achow101> probably
139 2018-10-02T20:13:34  <gwillen> achow101: https://0bin.net/paste/e70Ze5n2HJSSHuF1#tPS6iIwRHdEOmHx85Yo3Ueaos6ERjdrHbLUFW8Z63Dg
140 2018-10-02T20:13:38  <gwillen> decodes with or without the final A
141 2018-10-02T20:13:56  <gwillen> without, it's technically invalid if you want a properly-padded base64 string
142 2018-10-02T20:14:07  <gwillen> but if I add an = for padding it still decodes even though it should be missing the 0 at the end
143 2018-10-02T20:14:19  <achow101> ok, i'll take a look
144 2018-10-02T20:16:46  <achow101> yeah, i see why that happens. can I use this psbt as a test vector?
145 2018-10-02T20:18:01  <wumpus> phantomcircuit: supporting UNIX sockets would be nice, I had PRs for that once
146 2018-10-02T20:19:27  <wumpus> it made the tests do RPC over UNIX sockets
147 2018-10-02T20:20:16  <wumpus> idea was to do the same for the P2P connections between the nodes, which would make the tests completely self-contained
148 2018-10-02T20:20:36  <wumpus> but... just one of the many of my projects I lost track of
149 2018-10-02T20:21:31  <wumpus> wouldn't even need any TCP ports anymore, besides for network binding specific tests
150 2018-10-02T20:24:05  *** Guyver2 has quit IRC
151 2018-10-02T20:24:10  *** rex4539 has joined #bitcoin-core-dev
152 2018-10-02T20:41:34  *** timothy has quit IRC
153 2018-10-02T21:00:03  *** Chris_Stewart_5 has quit IRC
154 2018-10-02T21:10:24  <phantomcircuit> wumpus, indeed that would be an improvement here
155 2018-10-02T21:10:29  <phantomcircuit> a pretty significant one actually
156 2018-10-02T21:10:33  <phantomcircuit> but yeah priorities
157 2018-10-02T21:11:34  <sipa> achow101: hmm, we accept base64 with the == at the end missing?
158 2018-10-02T21:22:12  <gwillen> achow101: yes, you can use it as a test vector, it's tesnet with coins from some random faucet and freshly-generated addresses
159 2018-10-02T21:22:36  <gwillen> sipa: it seems so, I think it would make sense to not
160 2018-10-02T21:22:51  <gwillen> in which case there are two separate issues here
161 2018-10-02T21:23:56  <sipa> gwillen: agree; the RFC cited says padding is required; i tgink we should require it
162 2018-10-02T21:37:06  *** owowo has quit IRC
163 2018-10-02T21:37:54  <gwillen> hm, is there someone in here who is familiar with the QT stuff and QT Creator / QT Designer? Particularly on a mac?
164 2018-10-02T21:38:39  <gwillen> I followed the intstructions in the OS X build docs for opening the project in QT Creator, but by default it was unable to see a bunch of headers and I had to add some lines to bitcoin-qt.include to make it avoid drowning everything in red squiggly underlines
165 2018-10-02T21:41:14  <phantomcircuit> sipa, lots of things accept base64 without the padding
166 2018-10-02T21:41:46  *** owowo has joined #bitcoin-core-dev
167 2018-10-02T21:42:03  <wumpus> gwillen: I don't think anyone opens the project in qt creator anymore
168 2018-10-02T21:42:34  <gwillen> ha, ok, the build instructions still suggest it
169 2018-10-02T21:42:42  <gwillen> I assume QT Designer is still necessary to edit the forms
170 2018-10-02T21:42:43  <wumpus> (besides for editing the gui forms)
171 2018-10-02T21:42:46  <gwillen> but I guess you can use it standalone?
172 2018-10-02T21:42:47  <gwillen> *nods*
173 2018-10-02T21:42:58  <gwillen> the fact that I need to edit the gui forms is the only reason I bothered
174 2018-10-02T21:43:28  <wumpus> correct, you can use qt designer standalone
175 2018-10-02T21:45:47  *** promag has joined #bitcoin-core-dev
176 2018-10-02T21:50:05  *** rex4539 has quit IRC
177 2018-10-02T21:52:18  <sipa> phantomcircuit: there are multiple base64, some with padding, some without, some mandatory; i wouldn't mind having picked another spec,but the BIP chose one, so we should stick to it
178 2018-10-02T21:52:28  *** dqx has quit IRC
179 2018-10-02T21:53:22  <phantomcircuit> sipa, ah interesting
180 2018-10-02T21:53:34  <phantomcircuit> yeah it doesn't really matter to me and that seems logical
181 2018-10-02T21:54:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
182 2018-10-02T22:00:10  <phantomcircuit> lol 0.16.3 installed on windows is stuck at "done loading"
183 2018-10-02T22:03:30  <sipa> hmm, rfc 3548 does not require padding at decode time, only when encoding
184 2018-10-02T22:18:55  *** hebasto has quit IRC
185 2018-10-02T22:19:39  *** Chris_Stewart_5 has quit IRC
186 2018-10-02T22:41:59  *** michaelsdunn1 has quit IRC
187 2018-10-02T22:55:37  *** promag has quit IRC
188 2018-10-02T23:02:28  *** reallll has joined #bitcoin-core-dev
189 2018-10-02T23:05:53  *** belcher_ has quit IRC
190 2018-10-02T23:11:13  <phantomcircuit> wumpus, like i cant explain how the last commit on #14336 would fix the previous ci failures
191 2018-10-02T23:11:15  <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
192 2018-10-02T23:14:07  *** Zenton has quit IRC
193 2018-10-02T23:14:15  *** Zenton has joined #bitcoin-core-dev
194 2018-10-02T23:39:17  *** wullon has joined #bitcoin-core-dev
195 2018-10-02T23:42:05  *** promag has joined #bitcoin-core-dev
196 2018-10-02T23:45:11  *** drexl has quit IRC
197 2018-10-02T23:53:27  *** esotericnonsense has quit IRC
198 2018-10-02T23:53:52  *** esotericnonsense has joined #bitcoin-core-dev
199 2018-10-02T23:55:51  *** Zenton has quit IRC
200 2018-10-02T23:58:43  *** Zenton has joined #bitcoin-core-dev