1 2018-10-06T00:02:06  *** hebasto has quit IRC
  2 2018-10-06T00:30:21  *** hebasto_ has quit IRC
  3 2018-10-06T00:30:21  *** Victor_sueca has quit IRC
  4 2018-10-06T00:31:12  *** IGHOR has quit IRC
  5 2018-10-06T00:31:40  *** Victor_sueca has joined #bitcoin-core-dev
  6 2018-10-06T00:37:07  <gmaxwell> Do other people think that it would be reasonable if setting the upload limiter to a low value (e.g. below 500 MB/day) set the service flags towards non-whitelisted connections to be the pruned flags?
  7 2018-10-06T00:37:38  <gmaxwell> e.g. have a -limitednode  that defaults to false and gets softset to true if a low limiter is set.
  8 2018-10-06T00:38:17  <gmaxwell> I didn't propose this previously because we didn't have NODE_LIMITED yet... but we do now, and its widely deployed.
  9 2018-10-06T00:38:26  *** IGHOR has joined #bitcoin-core-dev
 10 2018-10-06T00:56:59  *** escrivner has joined #bitcoin-core-dev
 11 2018-10-06T00:57:31  *** AaronvanW has joined #bitcoin-core-dev
 12 2018-10-06T01:24:36  <luke-jr> gmaxwell: maybe a tri-state so users can disable sending any blocks at all?
 13 2018-10-06T01:28:25  <gmaxwell> Is it really interesting to support that?
 14 2018-10-06T01:28:47  <gmaxwell> luke-jr: that would be more a -clientmode than really a tristate on limited.
 15 2018-10-06T01:29:07  *** AaronvanW has quit IRC
 16 2018-10-06T01:38:20  <luke-jr> gmaxwell: unsure
 17 2018-10-06T01:39:24  *** murrayn has quit IRC
 18 2018-10-06T02:07:59  *** farmerwampum_ has joined #bitcoin-core-dev
 19 2018-10-06T02:09:45  *** farmerwampum has quit IRC
 20 2018-10-06T02:09:47  *** farmerwampum_ is now known as farmerwampum
 21 2018-10-06T02:25:01  *** jeremyrubin has joined #bitcoin-core-dev
 22 2018-10-06T02:31:57  *** Krellan has quit IRC
 23 2018-10-06T02:32:40  *** Krellan has joined #bitcoin-core-dev
 24 2018-10-06T02:38:44  *** unholymachine has quit IRC
 25 2018-10-06T02:41:22  *** jeremyrubin has quit IRC
 26 2018-10-06T03:02:06  *** ken2812221_ has joined #bitcoin-core-dev
 27 2018-10-06T03:02:54  *** jarthur has joined #bitcoin-core-dev
 28 2018-10-06T03:04:56  <ken2812221_> When would the RPC server send back 503 Service Unavailable? It happened occassionally on feature_uacomment.py on Appveyor. https://ci.appveyor.com/project/DrahtBot/bitcoin/build/master.2001
 29 2018-10-06T03:06:08  <echeveria> ken2812221_: startup?
 30 2018-10-06T03:07:02  <ken2812221_> I think so. But it never fail with 503 on Linux.
 31 2018-10-06T03:08:50  <ken2812221_> I think we should have an extra check for 503 on wait_for_rpc_connection?
 32 2018-10-06T03:15:06  *** ken2812221_ has quit IRC
 33 2018-10-06T03:15:48  <phantomcircuit> ken2812221, i think it's a timing issue
 34 2018-10-06T03:15:53  <phantomcircuit> lol damn
 35 2018-10-06T03:16:18  <echeveria> unlucky.
 36 2018-10-06T03:19:33  *** ken2812221_ has joined #bitcoin-core-dev
 37 2018-10-06T03:20:02  <ken2812221_> What do you mean timing issue?
 38 2018-10-06T03:21:00  <ken2812221_> Connectting from mobile, sry.
 39 2018-10-06T03:22:48  *** andytoshi has quit IRC
 40 2018-10-06T03:32:28  *** ken2812221_ has quit IRC
 41 2018-10-06T03:33:04  *** wallet42 has joined #bitcoin-core-dev
 42 2018-10-06T03:51:53  <phantomcircuit> ken2812221, i mean it's got race condition issues
 43 2018-10-06T03:53:01  *** rh0nj has quit IRC
 44 2018-10-06T03:54:20  <ken2812221> Hmm, I hate race condition. Going to figure it out.
 45 2018-10-06T03:56:06  *** dqx_ has joined #bitcoin-core-dev
 46 2018-10-06T03:56:07  *** rh0nj has joined #bitcoin-core-dev
 47 2018-10-06T03:59:45  *** dqx has quit IRC
 48 2018-10-06T04:03:32  *** murrayn has joined #bitcoin-core-dev
 49 2018-10-06T04:06:52  *** owowo has quit IRC
 50 2018-10-06T04:07:47  *** owowo has joined #bitcoin-core-dev
 51 2018-10-06T04:13:54  *** sipa_ has joined #bitcoin-core-dev
 52 2018-10-06T04:18:19  *** sipa has quit IRC
 53 2018-10-06T04:42:21  *** escrivner has quit IRC
 54 2018-10-06T04:43:40  *** jb55 has quit IRC
 55 2018-10-06T04:44:55  *** escrivner has joined #bitcoin-core-dev
 56 2018-10-06T04:49:48  *** escrivner has quit IRC
 57 2018-10-06T04:55:57  *** jarthur has quit IRC
 58 2018-10-06T04:56:33  *** jarthur has joined #bitcoin-core-dev
 59 2018-10-06T05:15:37  *** escrivner has joined #bitcoin-core-dev
 60 2018-10-06T05:20:27  *** escrivner has quit IRC
 61 2018-10-06T05:23:24  *** escrivner has joined #bitcoin-core-dev
 62 2018-10-06T05:28:16  *** escrivner has quit IRC
 63 2018-10-06T05:30:58  *** sipa_ is now known as sipa
 64 2018-10-06T05:45:43  <dongcarl> Is the "Bitcoin Core Sponsorship Programme" still going on?
 65 2018-10-06T05:47:23  <karelb> I asked on GitHub and nobody knows
 66 2018-10-06T05:47:26  <karelb> https://github.com/bitcoin-core/bitcoincore.org/issues/607
 67 2018-10-06T05:47:35  <karelb> I would think it's probably not
 68 2018-10-06T05:50:37  *** escrivner has joined #bitcoin-core-dev
 69 2018-10-06T05:54:40  *** escrivner has quit IRC
 70 2018-10-06T05:55:14  *** escrivner has joined #bitcoin-core-dev
 71 2018-10-06T05:59:19  <dongcarl> That is a shame, I'm also not sure if it should be discussed in this channel as this is not a dev topic
 72 2018-10-06T05:59:43  *** escrivner has quit IRC
 73 2018-10-06T05:59:51  *** jb55 has joined #bitcoin-core-dev
 74 2018-10-06T06:14:47  *** escrivner has joined #bitcoin-core-dev
 75 2018-10-06T06:19:04  *** escrivner has quit IRC
 76 2018-10-06T06:23:50  *** escrivner has joined #bitcoin-core-dev
 77 2018-10-06T06:28:26  *** escrivner has quit IRC
 78 2018-10-06T06:32:29  *** escrivner has joined #bitcoin-core-dev
 79 2018-10-06T06:36:43  *** escrivner has quit IRC
 80 2018-10-06T06:36:54  *** dqx_ has quit IRC
 81 2018-10-06T06:37:19  *** escrivner has joined #bitcoin-core-dev
 82 2018-10-06T06:41:34  *** escrivner has quit IRC
 83 2018-10-06T06:44:52  *** rex4539 has joined #bitcoin-core-dev
 84 2018-10-06T06:49:54  *** escrivner has joined #bitcoin-core-dev
 85 2018-10-06T06:54:13  *** escrivner has quit IRC
 86 2018-10-06T07:02:27  *** escrivner has joined #bitcoin-core-dev
 87 2018-10-06T07:03:20  *** jarthur has quit IRC
 88 2018-10-06T07:06:46  <gwillen> is there a good way to ask the wallet to do coin selection including watch-only coins (for offline signing)?
 89 2018-10-06T07:07:00  *** escrivner has quit IRC
 90 2018-10-06T07:09:10  <gwillen> I tried just setting the fAllowWatchOnly flag on CCoinControl
 91 2018-10-06T07:09:22  <gwillen> but various bits of machinery do not want to include watch-only coins even with that flag set
 92 2018-10-06T07:11:03  <gwillen> in particular in CWallet::GetAvailableBalance we check COutput::fSpendable on the coins before we count them, even if the fAllowWatchOnly flag is set
 93 2018-10-06T07:21:56  <luke-jr> gwillen: I thought fundrawtransaction could do it
 94 2018-10-06T07:26:05  *** Murch has joined #bitcoin-core-dev
 95 2018-10-06T07:26:58  <achow101> gwillen: fundrawtransaction should be able to select watch only coins
 96 2018-10-06T07:28:08  <achow101> gwillen: spendable in that case means solvable. the private key does not necessarily need to be in the wallet, but the pubkey and any related scripts do
 97 2018-10-06T07:29:31  <gwillen> hmmmmmmmm
 98 2018-10-06T07:30:00  *** Murch has quit IRC
 99 2018-10-06T07:32:00  <gwillen> I feel dumb asking this but why is solvability necessary
100 2018-10-06T07:32:13  <jnewbery> phantomcircuit: do you have a log from a failing rpc_zmq.py test for #14336? Or a link to travis for a failing build?
101 2018-10-06T07:32:15  <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
102 2018-10-06T07:32:17  <gwillen> it's enough to be able to find the utxos in order to build a transaction, right? as long as the offline signer can solve it?
103 2018-10-06T07:32:32  <achow101> gwillen: solvability is required for fee estimation
104 2018-10-06T07:33:12  <gwillen> ahhhhhhh hmmm
105 2018-10-06T07:33:46  <gwillen> ok, then I have another dumb question
106 2018-10-06T07:34:12  <gwillen> assuming that using importpubkey instead of importaddress will get me a solvable watch-only key, how do I _get_ a pubkey that I can import with importpubkey?
107 2018-10-06T07:34:17  <gwillen> validateaddress only gives the scriptpubkey
108 2018-10-06T07:34:39  <gwillen> (I mean, starting from a wallet that does know the privkey, how do I export the pubkey so I can then import it elsewhere)
109 2018-10-06T07:34:50  <sipa> use getaddressinfo
110 2018-10-06T07:35:16  <sipa> validateaddress is turning into a non-wallet RPC
111 2018-10-06T07:35:31  <gwillen> aha, thanks
112 2018-10-06T07:35:49  *** escrivner has joined #bitcoin-core-dev
113 2018-10-06T07:36:09  <midnightmagic> gwillen: consider writing up a howto after getting your offline signing going..?
114 2018-10-06T07:36:47  <gwillen> midnightmagic: the goal here is not merely to write a howto, it's to write a GUI :-)
115 2018-10-06T07:37:06  <gwillen> but a howto is not a bad idea as an intermediate step
116 2018-10-06T07:37:07  <midnightmagic> including the offline component?
117 2018-10-06T07:37:11  <gwillen> yeah
118 2018-10-06T07:37:15  <midnightmagic> oh, nice.
119 2018-10-06T07:37:19  <midnightmagic> nvm me then.
120 2018-10-06T07:37:44  <gwillen> I mean, a gui will take awhile to get in, a real offline signing howto isn't a bad idea at all, I keep referring to greg's version but it doesn't use the wallet for coin selection, it just does it by hand
121 2018-10-06T07:40:39  *** escrivner has quit IRC
122 2018-10-06T07:48:25  *** escrivner has joined #bitcoin-core-dev
123 2018-10-06T07:53:18  *** escrivner has quit IRC
124 2018-10-06T07:54:30  <gwillen> ah, dangit, I'm hitting https://github.com/bitcoin/bitcoin/issues/12253
125 2018-10-06T07:54:33  <gwillen> you can't actually do this
126 2018-10-06T07:55:48  <gmaxwell> well, thats a recently introduced bug unfortunately.
127 2018-10-06T07:56:31  <gmaxwell> oh no
128 2018-10-06T07:57:31  <gwillen> it seems like importing a segwit address solvably was just not yet implemented
129 2018-10-06T07:58:12  <achow101> gwillen: if you import the pubkey using importmulti, you will get all of the segwit stuff too
130 2018-10-06T07:58:22  <gwillen> no, see the bug, doesn't work
131 2018-10-06T07:58:45  <gwillen> unless I'm misunderstanding what's happening, you cannot get "solvable": true for a segwit address
132 2018-10-06T07:58:46  <gmaxwell> gwillen: I think 12253 is just outdated, and doesn't reflect the full segwit support or 0.16.
133 2018-10-06T07:58:49  <achow101> gwillen: you specify the p2pkh address, then give a pubkey array with the pubkey
134 2018-10-06T07:58:50  <gwillen> oh hm okay
135 2018-10-06T07:59:02  <gwillen> I already did that though, I provided the redeemscript and the pubkey
136 2018-10-06T07:59:03  <achow101> you end up with the pubkey being imported. the address is ignored
137 2018-10-06T07:59:05  <gwillen> but it's still not solvable
138 2018-10-06T07:59:19  <gwillen> I may be doing it wrong, it did accept it
139 2018-10-06T07:59:26  <achow101> don't give the redeemScript
140 2018-10-06T07:59:35  <achow101> also don't give a bech32 address or p2sh address
141 2018-10-06T07:59:51  <gwillen> erm, how do I get a p2pkh address
142 2018-10-06T08:00:36  <achow101> there's a way using getaddressinfo and then decodescript
143 2018-10-06T08:00:59  *** escrivner has joined #bitcoin-core-dev
144 2018-10-06T08:01:18  <gmaxwell> gwillen: for testing purpose, lol http://gobittest.appspot.com/Address
145 2018-10-06T08:02:23  <gwillen> hahaha
146 2018-10-06T08:02:46  <gwillen> I need testnet though
147 2018-10-06T08:03:26  <gwillen> also it feels a little bad to me that there's no permutation of the stuff that comes out of getaddressinfo that can go into importmulti and work :-P
148 2018-10-06T08:03:57  <sipa> gwillen: yeah, importmulti and segwit is only accidental to the extent that it works
149 2018-10-06T08:03:58  <achow101> there was some method I found a while ago, but I can't remember it
150 2018-10-06T08:04:10  <sipa> we should have prioritized that for 0.17...
151 2018-10-06T08:04:24  <gwillen> sipa: is https://github.com/bitcoin/bitcoin/issues/12253 still current? gmaxwell was saying he thought it was outdated.
152 2018-10-06T08:04:33  <sipa> i think it's current?
153 2018-10-06T08:04:43  <sipa> it was a known missing part in 0.16
154 2018-10-06T08:04:57  <sipa> and we didn't improve upon it in 0.17 afaik
155 2018-10-06T08:05:46  *** escrivner has quit IRC
156 2018-10-06T08:05:56  <gwillen> does the crazy shit achow101 proposed above function as a workaround to get a segwit address imported, or does it just import it as a non-segwit address and happen to work?
157 2018-10-06T08:09:32  <gmaxwell> The wallet works much more like "bag of pubkeys which get interperted many ways" than we'd like, but changing it is slow going due to compatbility needs.
158 2018-10-06T08:10:10  <gwillen> will just doing importpubkey do the right thing, and interpret the pubkey many ways?
159 2018-10-06T08:10:25  <gwillen> I had thought I couldn't do that because of rescanning but achow pointed out that I can just rescan manually
160 2018-10-06T08:11:06  *** bralyclow has quit IRC
161 2018-10-06T08:13:22  *** escrivner has joined #bitcoin-core-dev
162 2018-10-06T08:14:10  *** phwalkr has joined #bitcoin-core-dev
163 2018-10-06T08:15:26  *** hebasto has joined #bitcoin-core-dev
164 2018-10-06T08:16:12  <gwillen> yesss okay that works
165 2018-10-06T08:18:11  *** thedrs has joined #bitcoin-core-dev
166 2018-10-06T08:18:30  *** phwalkr has quit IRC
167 2018-10-06T08:18:38  *** escrivner has quit IRC
168 2018-10-06T08:19:04  <thedrs> hi, sorry to bug you guys, bitcoin 0.17 installer is identified as maleware by MBAM, is this known ?
169 2018-10-06T08:25:51  *** escrivner has joined #bitcoin-core-dev
170 2018-10-06T08:27:46  <Lauda> ^false positive. #bitcoin
171 2018-10-06T08:28:02  *** rh0nj has quit IRC
172 2018-10-06T08:28:13  <thedrs> yep though so
173 2018-10-06T08:28:28  <thedrs> but no google info about it. i reported it to MBAM
174 2018-10-06T08:29:08  *** rh0nj has joined #bitcoin-core-dev
175 2018-10-06T08:29:50  <luke-jr> thedrs: check the PGP signatures
176 2018-10-06T08:30:04  *** escrivner has quit IRC
177 2018-10-06T08:31:46  *** csknk has joined #bitcoin-core-dev
178 2018-10-06T08:36:44  *** phwalkr has joined #bitcoin-core-dev
179 2018-10-06T08:38:17  *** escrivner has joined #bitcoin-core-dev
180 2018-10-06T08:43:02  *** JackH has joined #bitcoin-core-dev
181 2018-10-06T08:43:06  *** escrivner has quit IRC
182 2018-10-06T08:50:44  *** escrivner has joined #bitcoin-core-dev
183 2018-10-06T08:55:22  *** escrivner has quit IRC
184 2018-10-06T09:03:21  *** nullptr| has quit IRC
185 2018-10-06T09:10:02  *** nullptr| has joined #bitcoin-core-dev
186 2018-10-06T09:15:34  *** escrivner has joined #bitcoin-core-dev
187 2018-10-06T09:20:03  *** escrivner has quit IRC
188 2018-10-06T09:20:55  *** sipa has quit IRC
189 2018-10-06T09:22:28  *** sipa has joined #bitcoin-core-dev
190 2018-10-06T09:28:00  *** escrivner has joined #bitcoin-core-dev
191 2018-10-06T09:29:50  *** booyah_ is now known as booyah
192 2018-10-06T09:32:04  *** escrivner has quit IRC
193 2018-10-06T09:32:35  *** promag has joined #bitcoin-core-dev
194 2018-10-06T09:40:07  *** escrivner has joined #bitcoin-core-dev
195 2018-10-06T09:44:28  *** escrivner has quit IRC
196 2018-10-06T09:46:23  *** promag has quit IRC
197 2018-10-06T09:52:56  *** escrivner has joined #bitcoin-core-dev
198 2018-10-06T09:58:04  *** escrivner has quit IRC
199 2018-10-06T10:05:18  <jonasschnelli> The wallets watch-only capabilities is a mess!
200 2018-10-06T10:05:19  *** escrivner has joined #bitcoin-core-dev
201 2018-10-06T10:06:00  <jonasschnelli> The only way how to import a watch only multisig is by importing the outer script, the readme-script and all it's pubkeys (via importpubkey)
202 2018-10-06T10:06:30  <sipa> you don't need the pubkeys for multisig
203 2018-10-06T10:06:34  <sipa> only for p2pkh
204 2018-10-06T10:06:51  <jonasschnelli> sipa:If you don't import the pubkey they are non-solvable and not useable in fundraw
205 2018-10-06T10:07:07  <jonasschnelli> So you need to import via importpubkey (and import all possible scripts!)
206 2018-10-06T10:07:28  <sipa> jonasschnelli: that makes no sense
207 2018-10-06T10:07:31  <jonasschnelli> GetScriptForRawPubKey will then lead to extract the pubKey and place them mapWatchKeys
208 2018-10-06T10:07:43  <jonasschnelli> Agree it makes no sense...
209 2018-10-06T10:07:55  <sipa> importing a pubkey is so that the signing code can find the pubkey based on the hash of the key
210 2018-10-06T10:08:03  <sipa> in a multisig there are no key hashes involved
211 2018-10-06T10:08:13  <sipa> just the redeemscript should be enough for multisig
212 2018-10-06T10:08:39  <sipa> plus importaddress of the toplevel thing
213 2018-10-06T10:08:43  <jonasschnelli> Yes. But following isSolvable, it will require to find the pubkey in oder to flag it solveable
214 2018-10-06T10:09:00  <sipa> it has the pubkey; it's in the redeemscript
215 2018-10-06T10:09:06  <sipa> i'm very skeptical :)
216 2018-10-06T10:09:11  <jonasschnelli> but it won't find it...
217 2018-10-06T10:09:19  <sipa> have you tried this?
218 2018-10-06T10:09:30  <jonasschnelli> Yes
219 2018-10-06T10:09:32  <sipa> i find this very hard to believe
220 2018-10-06T10:09:37  <jonasschnelli> mapWatchKeys gets only touched by AddWatchOnly
221 2018-10-06T10:09:44  <jonasschnelli> Try yourself... with the following steps:
222 2018-10-06T10:09:49  <jonasschnelli> 1. createwallet "dummy" true
223 2018-10-06T10:09:53  <sipa> what do you need mapWatchKeys for in multisig?
224 2018-10-06T10:09:54  *** escrivner has quit IRC
225 2018-10-06T10:10:37  <jonasschnelli> sipa: pure watching no,.. but if you want to use them for watchOnly coinselection via fundraw, yes, you need it with the corrent code
226 2018-10-06T10:10:47  <sipa> that makes no sense :)
227 2018-10-06T10:10:55  <sipa> if you say so, i believe you
228 2018-10-06T10:11:01  <sipa> bit i don't know what that is the case
229 2018-10-06T10:11:03  <jonasschnelli> Try it youself. :)
230 2018-10-06T10:11:09  <sipa> i can't right now
231 2018-10-06T10:11:16  <jonasschnelli> Sure. No hurry...
232 2018-10-06T10:11:24  <jonasschnelli> the use case: decouple the keys from the wallet
233 2018-10-06T10:11:44  <jonasschnelli> (via importing scripts and using fundrawtransaction)
234 2018-10-06T10:11:44  <sipa> yes not claiming this isn't important!
235 2018-10-06T10:11:57  <sipa> i'm just not understanding why you need to import the pubkeys
236 2018-10-06T10:12:06  <sipa> they are in the redeemscript
237 2018-10-06T10:12:28  <sipa> the signing code doesn't need to look up any pubkeys
238 2018-10-06T10:12:45  <jonasschnelli> Because: fundraw takes only solvable imputs. isSolveable requires to find the pubKey in the keystore.
239 2018-10-06T10:12:53  <jonasschnelli> But it's fixable IMO
240 2018-10-06T10:12:54  <sipa> why?
241 2018-10-06T10:13:24  <jonasschnelli> isSolveable _currently_ requires to find the pubKey... its just coded that way...
242 2018-10-06T10:13:50  <sipa> can you point me to the code?
243 2018-10-06T10:14:01  <jonasschnelli> 1s..
244 2018-10-06T10:14:49  <jonasschnelli> code part 1: https://github.com/bitcoin/bitcoin/blob/master/src/script/sign.cpp#L141
245 2018-10-06T10:15:36  <sipa> sure, but that doesn't need the pubkey imported, only the redeemscript
246 2018-10-06T10:16:25  <jonasschnelli> code part 2: https://github.com/bitcoin/bitcoin/blob/aa39ca764578a9017e03796b554955796022eb0d/src/script/sign.cpp#L84
247 2018-10-06T10:16:31  <jonasschnelli> (GetPubKey(provider, sigdata, keyid, pubkey);)
248 2018-10-06T10:16:46  <jonasschnelli> Goes into: bool CCryptoKeyStore::GetPubKey(const CKeyID &address, CPubKey& vchPubKeyOut) const
249 2018-10-06T10:16:51  <sipa> oh
250 2018-10-06T10:16:55  <sipa> you're right
251 2018-10-06T10:16:56  *** phwalkr has quit IRC
252 2018-10-06T10:17:03  <sipa> that's stupid :)
253 2018-10-06T10:17:08  <jonasschnelli> yes... it's a mess
254 2018-10-06T10:17:30  * sipa quietly mentions descriptors again
255 2018-10-06T10:17:44  <jonasschnelli> Indeed!
256 2018-10-06T10:17:47  *** escrivner has joined #bitcoin-core-dev
257 2018-10-06T10:18:23  <jonasschnelli> You can bypass that problem by importpubkey all the multisigs pubkeys because it will generate a RawPubKeyScript where the pubkeys gets extracted and added to the keystore. :/
258 2018-10-06T10:18:36  <jonasschnelli> (with an overhead of a couple of unused scripts)
259 2018-10-06T10:18:48  <sipa> yeah
260 2018-10-06T10:18:56  <sipa> but that's pretty ridiculous
261 2018-10-06T10:19:34  <jonasschnelli> Which you have to do anyways for P2SH(P2WPKH) scripts to flag them solvable since importmulti can't handle it...
262 2018-10-06T10:19:44  <jonasschnelli> or for native P2WPKH
263 2018-10-06T10:20:30  <jonasschnelli> because importmulti compare the scriptPubKey with the P2PKH(pubkey) and refuse to insert the pubkey if no match. :/
264 2018-10-06T10:22:11  *** escrivner has quit IRC
265 2018-10-06T10:26:53  <sipa> jonasschnelli: fixing
266 2018-10-06T10:27:01  <jonasschnelli> sipa: \o/
267 2018-10-06T10:27:35  *** phwalkr has joined #bitcoin-core-dev
268 2018-10-06T10:30:09  <sipa> jonasschnelli: i wonder if this was a regression in 0.17?
269 2018-10-06T10:30:14  *** escrivner has joined #bitcoin-core-dev
270 2018-10-06T10:30:26  <jonasschnelli> sipa: possible... I haven't checked that.
271 2018-10-06T10:30:32  <jonasschnelli> (will do now)
272 2018-10-06T10:32:05  <sipa> jonasschnelli: thanks!
273 2018-10-06T10:34:19  <sipa> jonasschnelli: i need to run, but this may fix it: https://github.com/sipa/bitcoin/tree/201810_importpubkeylol (it fails a bip174 test, need to investigate)
274 2018-10-06T10:34:32  <jonasschnelli> thanks.. no hurry
275 2018-10-06T10:34:39  *** escrivner has quit IRC
276 2018-10-06T10:36:51  *** rex4539 has quit IRC
277 2018-10-06T10:42:39  *** escrivner has joined #bitcoin-core-dev
278 2018-10-06T10:47:21  *** escrivner has quit IRC
279 2018-10-06T10:47:52  <jonasschnelli> sipa: looks like a 0.17 regression
280 2018-10-06T10:54:52  <thedrs> luke-jr, i verified it
281 2018-10-06T10:54:55  <thedrs>  >sha256sum /c/bitcoin-0.17.0-win64-setup.exe b37f738ab17a93e24028fa74280b74c353653cf03fc2fb7da6ead8669e440b1a */c/bitcoin-0.17.0-win64-setup.exe /c/Users/ichi >certUtil -hashfile /c/bitcoin-0.17.0-win64-setup.exe SHA256 SHA256 hash of file C:/bitcoin-0.17.0-win64-setup.exe: b3 7f 73 8a b1 7a 93 e2 40 28 fa 74 28 0b 74 c3 53 65 3c f0 3f c2 fb 7d a6 ea d8 66 9e 44 0b 1a
282 2018-10-06T10:55:03  <thedrs> looks ok
283 2018-10-06T10:55:09  *** escrivner has joined #bitcoin-core-dev
284 2018-10-06T10:56:00  <thedrs> ran it via virustotal, and strangley, MBAM passes it there. Although i 7/67 negativ results
285 2018-10-06T10:59:45  *** escrivner has quit IRC
286 2018-10-06T11:07:32  *** escrivner has joined #bitcoin-core-dev
287 2018-10-06T11:12:18  *** escrivner has quit IRC
288 2018-10-06T11:14:42  <echeveria> thedrs: virustotal tells you literally nothing about the safety of running a binary, sorry.
289 2018-10-06T11:20:21  *** escrivner has joined #bitcoin-core-dev
290 2018-10-06T11:25:02  *** escrivner has quit IRC
291 2018-10-06T11:32:48  *** escrivner has joined #bitcoin-core-dev
292 2018-10-06T11:33:33  *** thedrs has quit IRC
293 2018-10-06T11:37:06  *** rex4539 has joined #bitcoin-core-dev
294 2018-10-06T11:37:31  *** escrivner has quit IRC
295 2018-10-06T11:44:54  *** escrivner has joined #bitcoin-core-dev
296 2018-10-06T11:49:32  *** escrivner has quit IRC
297 2018-10-06T11:57:19  *** escrivner has joined #bitcoin-core-dev
298 2018-10-06T12:00:13  *** phwalkr has quit IRC
299 2018-10-06T12:02:18  *** escrivner has quit IRC
300 2018-10-06T12:09:44  *** escrivner has joined #bitcoin-core-dev
301 2018-10-06T12:14:13  *** escrivner has quit IRC
302 2018-10-06T12:26:00  *** ken2812221 has quit IRC
303 2018-10-06T12:26:22  *** ken2812221 has joined #bitcoin-core-dev
304 2018-10-06T12:30:02  *** rh0nj has quit IRC
305 2018-10-06T12:31:07  *** rh0nj has joined #bitcoin-core-dev
306 2018-10-06T12:37:55  *** Victor_sueca has quit IRC
307 2018-10-06T12:39:14  *** Victor_sueca has joined #bitcoin-core-dev
308 2018-10-06T13:04:34  *** reallll has joined #bitcoin-core-dev
309 2018-10-06T13:05:28  *** no_input_found has quit IRC
310 2018-10-06T13:06:19  *** no_input_found has joined #bitcoin-core-dev
311 2018-10-06T13:07:54  *** belcher_ has quit IRC
312 2018-10-06T13:16:28  <gwillen> jonasschnelli: sipa: so it seems kind of weird to me actually that you need keys to be solvable for fundraw and such to work
313 2018-10-06T13:17:00  <gwillen> achow101 said it was for fee estimation (I guess so you know the signature size), which makes sense, but ... the various signatures are not that different in size, you could easily make a conservative estimate without needing issolvable to be true
314 2018-10-06T13:17:24  <gwillen> you might overpay a little but in a lot of cases that's fine
315 2018-10-06T13:17:47  <jonasschnelli> gwillen: Yes. probably. for P2PKH, you could assume key is always compressed...
316 2018-10-06T13:18:03  <jonasschnelli> or overpay always by assuming its uncompressed
317 2018-10-06T13:18:25  <jonasschnelli> maybe make it even configurable
318 2018-10-06T13:23:58  *** Guyver2 has joined #bitcoin-core-dev
319 2018-10-06T13:27:31  <gwillen> *nods*
320 2018-10-06T13:27:40  <gwillen> better to overpay I think, if you're being sloppy
321 2018-10-06T13:27:49  <gwillen> although I guess with RBF it's not so bad anymore
322 2018-10-06T13:33:22  <jonasschnelli> yes. better overpay.
323 2018-10-06T13:33:39  <jonasschnelli> but who uses uncompressed keys anymore?!
324 2018-10-06T13:34:37  *** unifiedh has joined #bitcoin-core-dev
325 2018-10-06T13:50:15  *** Krellan has quit IRC
326 2018-10-06T13:50:59  *** Krellan has joined #bitcoin-core-dev
327 2018-10-06T13:59:23  <sipa> jonasschnelli: gemini
328 2018-10-06T14:02:04  <jonasschnelli> I need to test later, but do we even require the pubkey for fee estimation with P2WPKH inputs?
329 2018-10-06T14:02:36  <jonasschnelli> I hope not but fear we do
330 2018-10-06T14:02:50  <sipa> yes i'm sure we do
331 2018-10-06T14:03:10  <sipa> solvability is defined as "can you sign, ignoring lack of private keys"
332 2018-10-06T14:03:21  <sipa> you can't sign for a P2WPKH without knowing the pubkey
333 2018-10-06T14:21:46  <jonasschnelli> shouldn't we split solvability from signability?
334 2018-10-06T14:26:36  <sipa> i don't think so
335 2018-10-06T14:27:15  <sipa> it's an interesting special case that indeed for P2WPKH you don't actually need to know the pubkey
336 2018-10-06T14:27:51  <sipa> but i think that the fact that you don't have it now is more a side effect of it being annoying to pass in, rather than not knowing it at all
337 2018-10-06T14:43:02  <jonasschnelli> but in order to run fundraw with watch-only, you only want to calculate the fee. If you use P2WPKS or P2SH(P2WPKH) or P2WSH(multisig)... you can calculate the fee when you have the scriptPubKey and optionally the redeem script.. right?
338 2018-10-06T14:44:16  <jonasschnelli> Maybe I get it wrong, but IMHO, the dummysigner is for fee calculation
339 2018-10-06T14:45:25  *** ken2812221 has quit IRC
340 2018-10-06T14:45:55  *** ken2812221 has joined #bitcoin-core-dev
341 2018-10-06T14:56:35  <sipa> jonasschnelli: yes, my point is that generally when you need to use fundraw, you know the redeemScript/pubkeys involved
342 2018-10-06T14:57:10  <sipa> and it's only because it's annoying to import them that we're talkijg about the few edge cases (like p2wpkh) where you can indeed estimate the fee correctly without knowing the pubkey
343 2018-10-06T15:25:36  *** bralyclow has joined #bitcoin-core-dev
344 2018-10-06T16:17:04  *** unifiedh has quit IRC
345 2018-10-06T16:23:46  *** harding has quit IRC
346 2018-10-06T16:24:49  *** harding has joined #bitcoin-core-dev
347 2018-10-06T16:31:36  *** owowo has quit IRC
348 2018-10-06T16:39:42  *** phwalkr has joined #bitcoin-core-dev
349 2018-10-06T16:48:49  *** tryphe_ has quit IRC
350 2018-10-06T16:49:16  *** tryphe_ has joined #bitcoin-core-dev
351 2018-10-06T17:07:30  *** owowo has joined #bitcoin-core-dev
352 2018-10-06T17:12:00  *** owowo has quit IRC
353 2018-10-06T17:13:00  *** owowo has joined #bitcoin-core-dev
354 2018-10-06T17:28:15  *** a5m0_ has quit IRC
355 2018-10-06T17:30:44  *** a5m0 has joined #bitcoin-core-dev
356 2018-10-06T17:33:05  *** reallll is now known as belcher_
357 2018-10-06T17:35:55  *** phwalkr has quit IRC
358 2018-10-06T17:38:49  *** phwalkr has joined #bitcoin-core-dev
359 2018-10-06T17:39:48  *** phwalkr has quit IRC
360 2018-10-06T17:42:09  *** phwalkr has joined #bitcoin-core-dev
361 2018-10-06T17:45:42  *** phwalkr has quit IRC
362 2018-10-06T18:04:53  *** smaho has joined #bitcoin-core-dev
363 2018-10-06T18:05:54  *** ExtraCrispy has quit IRC
364 2018-10-06T18:08:41  *** smaho has quit IRC
365 2018-10-06T18:14:04  *** ExtraCrispy has joined #bitcoin-core-dev
366 2018-10-06T18:14:34  *** ExtraCrispy has quit IRC
367 2018-10-06T18:21:08  *** Krellan has quit IRC
368 2018-10-06T18:21:50  *** Krellan has joined #bitcoin-core-dev
369 2018-10-06T18:23:06  *** booyah has quit IRC
370 2018-10-06T18:24:16  *** booyah has joined #bitcoin-core-dev
371 2018-10-06T18:31:07  *** SopaXorzTaker has joined #bitcoin-core-dev
372 2018-10-06T18:35:56  *** bitbee has quit IRC
373 2018-10-06T18:39:11  *** cryptocat has joined #bitcoin-core-dev
374 2018-10-06T18:41:54  *** SopaXorzTaker has quit IRC
375 2018-10-06T18:42:45  *** schnerchi has joined #bitcoin-core-dev
376 2018-10-06T18:54:32  *** ekrok has joined #bitcoin-core-dev
377 2018-10-06T18:58:59  <phantomcircuit> jnewbery, i do not
378 2018-10-06T19:24:13  *** ken2812221_ has joined #bitcoin-core-dev
379 2018-10-06T19:28:04  *** ken2812221 has quit IRC
380 2018-10-06T19:40:49  *** hebasto has quit IRC
381 2018-10-06T20:08:52  *** rex4539 has quit IRC
382 2018-10-06T20:11:21  *** rex4539 has joined #bitcoin-core-dev
383 2018-10-06T20:41:39  *** csknk has quit IRC
384 2018-10-06T20:58:06  *** ekrok has quit IRC
385 2018-10-06T22:25:15  *** booyah has quit IRC
386 2018-10-06T22:27:06  *** booyah has joined #bitcoin-core-dev
387 2018-10-06T22:49:28  *** Guyver2 has quit IRC
388 2018-10-06T22:57:02  *** rh0nj has quit IRC
389 2018-10-06T22:58:07  *** rh0nj has joined #bitcoin-core-dev
390 2018-10-06T23:03:25  *** Zenton has quit IRC
391 2018-10-06T23:14:01  *** Zenton has joined #bitcoin-core-dev
392 2018-10-06T23:41:04  <jnewbery> ok, if you see the failure again, please paste logs/link into the PR and I'll try to work out why it's failing
393 2018-10-06T23:41:29  *** promag has joined #bitcoin-core-dev
394 2018-10-06T23:48:52  <jnewbery> If it's rpc_zmq.py L31 then I suspect some race between the ZMQNotificationInterface initialization and the test framework sending the getzmqnotifications RPC. Logs would prove that
395 2018-10-06T23:52:18  <jnewbery> The ZMQ rpc test is pretty useless. I don't know why that rpc isn't just tested in the interface_zmq.py test
396 2018-10-06T23:53:10  <phantomcircuit> jnewbery, it's the getzmqnotifications call on line 30/31
397 2018-10-06T23:53:22  <phantomcircuit> im pretty sure it's just a race as you said
398 2018-10-06T23:53:42  *** no_input_found has quit IRC
399 2018-10-06T23:54:03  *** no_input_found has joined #bitcoin-core-dev
400 2018-10-06T23:54:27  *** ken2812221_ has quit IRC