1 2018-10-15T00:02:10  *** leishman has joined #bitcoin-core-dev
  2 2018-10-15T00:03:48  <luke-jr> gmaxwell: "new"? didn't we merely just remove a long-deprecated way?
  3 2018-10-15T00:05:22  <sipa> luke-jr: to many people it seems new :)
  4 2018-10-15T00:06:55  *** esotericnonsense has quit IRC
  5 2018-10-15T00:09:05  *** promag has quit IRC
  6 2018-10-15T00:11:43  *** esotericnonsense has joined #bitcoin-core-dev
  7 2018-10-15T00:15:18  *** proletesseract has quit IRC
  8 2018-10-15T00:17:05  *** proletesseract has joined #bitcoin-core-dev
  9 2018-10-15T00:24:38  <sipa> perhaps instead of "It is recommended to use a new receiving address for each transaction" it should say "Use the request payment button in the receive tab to create new addresses."
 10 2018-10-15T00:26:13  *** leishman has quit IRC
 11 2018-10-15T00:35:56  *** leishman has joined #bitcoin-core-dev
 12 2018-10-15T00:40:23  *** dviola has quit IRC
 13 2018-10-15T00:40:39  *** esotericnonsense has quit IRC
 14 2018-10-15T00:43:32  *** esotericnonsense has joined #bitcoin-core-dev
 15 2018-10-15T00:46:24  *** promag has joined #bitcoin-core-dev
 16 2018-10-15T00:50:19  <meshcollider> yep and these are good hacktoberfest tag issues :)
 17 2018-10-15T00:50:38  *** bralyclow has quit IRC
 18 2018-10-15T00:51:03  *** promag has quit IRC
 19 2018-10-15T00:51:18  *** bralyclow has joined #bitcoin-core-dev
 20 2018-10-15T00:58:48  *** AaronvanW has joined #bitcoin-core-dev
 21 2018-10-15T01:03:13  *** AaronvanW has quit IRC
 22 2018-10-15T01:18:47  *** Deacyde has quit IRC
 23 2018-10-15T01:26:35  <gmaxwell> luke-jr: "new address" process, not new "address process"
 24 2018-10-15T01:27:29  *** IceHard has quit IRC
 25 2018-10-15T01:37:54  *** esotericnonsense has quit IRC
 26 2018-10-15T01:39:11  *** esotericnonsense has joined #bitcoin-core-dev
 27 2018-10-15T02:04:27  *** Deacyde has joined #bitcoin-core-dev
 28 2018-10-15T02:05:25  *** leishman has quit IRC
 29 2018-10-15T02:05:32  *** leishman has joined #bitcoin-core-dev
 30 2018-10-15T02:06:37  *** promag has joined #bitcoin-core-dev
 31 2018-10-15T02:11:08  *** promag has quit IRC
 32 2018-10-15T02:14:23  *** IceHard has joined #bitcoin-core-dev
 33 2018-10-15T02:23:17  *** bitcoin-git has joined #bitcoin-core-dev
 34 2018-10-15T02:23:17  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14480: refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread (master...drop-boost-thread-import) https://github.com/bitcoin/bitcoin/pull/14480
 35 2018-10-15T02:23:17  *** bitcoin-git has left #bitcoin-core-dev
 36 2018-10-15T02:34:36  *** esotericnonsense has quit IRC
 37 2018-10-15T02:38:02  *** rh0nj has quit IRC
 38 2018-10-15T02:39:07  *** rh0nj has joined #bitcoin-core-dev
 39 2018-10-15T02:40:03  *** esotericnonsense has joined #bitcoin-core-dev
 40 2018-10-15T02:41:20  *** owowo has quit IRC
 41 2018-10-15T02:43:20  *** promag has joined #bitcoin-core-dev
 42 2018-10-15T02:47:33  *** promag has quit IRC
 43 2018-10-15T02:47:33  *** owowo has joined #bitcoin-core-dev
 44 2018-10-15T03:03:29  *** schnerchi has joined #bitcoin-core-dev
 45 2018-10-15T03:06:38  *** schnerch_ has quit IRC
 46 2018-10-15T03:19:02  *** esotericnonsense has quit IRC
 47 2018-10-15T03:26:50  *** Krellan has quit IRC
 48 2018-10-15T03:30:48  *** esotericnonsense has joined #bitcoin-core-dev
 49 2018-10-15T04:05:46  *** leishman has quit IRC
 50 2018-10-15T04:06:01  *** leishman has joined #bitcoin-core-dev
 51 2018-10-15T04:13:48  *** unholymachine has quit IRC
 52 2018-10-15T04:21:11  *** Krellan has joined #bitcoin-core-dev
 53 2018-10-15T04:27:43  *** Krellan has quit IRC
 54 2018-10-15T04:45:36  *** Jai has joined #bitcoin-core-dev
 55 2018-10-15T04:49:01  *** chjj has quit IRC
 56 2018-10-15T04:52:15  *** chjj has joined #bitcoin-core-dev
 57 2018-10-15T05:00:16  *** AaronvanW has joined #bitcoin-core-dev
 58 2018-10-15T05:01:34  *** rex4539 has quit IRC
 59 2018-10-15T05:02:08  *** Krellan has joined #bitcoin-core-dev
 60 2018-10-15T05:04:39  *** AaronvanW has quit IRC
 61 2018-10-15T05:11:25  *** proletesseract has quit IRC
 62 2018-10-15T05:31:06  *** luke-jr has quit IRC
 63 2018-10-15T05:31:35  *** luke-jr has joined #bitcoin-core-dev
 64 2018-10-15T05:34:07  *** luke-jr has quit IRC
 65 2018-10-15T05:34:51  *** luke-jr has joined #bitcoin-core-dev
 66 2018-10-15T05:46:11  *** proletesseract has joined #bitcoin-core-dev
 67 2018-10-15T05:49:25  *** bitcoin-git has joined #bitcoin-core-dev
 68 2018-10-15T05:49:26  <bitcoin-git> [bitcoin] MeshCollider opened pull request #14481: Add P2SH-P2WSH support to listunspent RPC (master...201810_listunspent_wsh) https://github.com/bitcoin/bitcoin/pull/14481
 69 2018-10-15T05:49:26  *** bitcoin-git has left #bitcoin-core-dev
 70 2018-10-15T05:49:36  *** bitcoin-git has joined #bitcoin-core-dev
 71 2018-10-15T05:49:36  <bitcoin-git> [bitcoin] MeshCollider closed pull request #11708: Add P2SH-P2WSH support to signrawtransaction and listunspent RPC (master...201711_signrawtransaction_wsh) https://github.com/bitcoin/bitcoin/pull/11708
 72 2018-10-15T05:49:36  *** bitcoin-git has left #bitcoin-core-dev
 73 2018-10-15T05:50:20  *** Giszmo has quit IRC
 74 2018-10-15T05:50:29  *** proletesseract has quit IRC
 75 2018-10-15T06:06:08  *** leishman has quit IRC
 76 2018-10-15T06:06:22  *** leishman has joined #bitcoin-core-dev
 77 2018-10-15T06:07:08  *** hebasto has joined #bitcoin-core-dev
 78 2018-10-15T06:17:59  *** Giszmo has joined #bitcoin-core-dev
 79 2018-10-15T06:39:09  *** echonaut has quit IRC
 80 2018-10-15T06:39:14  *** echonaut13 has joined #bitcoin-core-dev
 81 2018-10-15T06:41:30  *** promag has joined #bitcoin-core-dev
 82 2018-10-15T06:46:10  *** promag has quit IRC
 83 2018-10-15T06:51:44  *** proletesseract has joined #bitcoin-core-dev
 84 2018-10-15T06:52:53  *** leishman has quit IRC
 85 2018-10-15T07:00:57  *** AaronvanW has joined #bitcoin-core-dev
 86 2018-10-15T07:03:50  *** leishman has joined #bitcoin-core-dev
 87 2018-10-15T07:05:24  *** AaronvanW has quit IRC
 88 2018-10-15T07:08:03  *** leishman has quit IRC
 89 2018-10-15T07:14:23  *** Krellan has quit IRC
 90 2018-10-15T07:15:34  *** Krellan has joined #bitcoin-core-dev
 91 2018-10-15T07:52:39  *** schnerch_ has joined #bitcoin-core-dev
 92 2018-10-15T07:54:20  *** jungly has joined #bitcoin-core-dev
 93 2018-10-15T07:56:15  *** schnerchi has quit IRC
 94 2018-10-15T07:57:58  *** promag has joined #bitcoin-core-dev
 95 2018-10-15T08:01:27  *** Timmy has joined #bitcoin-core-dev
 96 2018-10-15T08:04:41  *** harrymurata has joined #bitcoin-core-dev
 97 2018-10-15T08:05:59  *** harrymurata has joined #bitcoin-core-dev
 98 2018-10-15T08:06:17  *** setpill has joined #bitcoin-core-dev
 99 2018-10-15T08:07:02  *** harrymurata has quit IRC
100 2018-10-15T08:10:13  *** Timmy has quit IRC
101 2018-10-15T08:12:45  *** bralyclo_ has joined #bitcoin-core-dev
102 2018-10-15T08:14:28  *** bralyclow has quit IRC
103 2018-10-15T08:30:54  *** proletesseract has quit IRC
104 2018-10-15T08:35:21  *** Zenton has joined #bitcoin-core-dev
105 2018-10-15T08:44:19  *** ExtraCrispy has quit IRC
106 2018-10-15T08:53:03  *** vah13 has joined #bitcoin-core-dev
107 2018-10-15T08:53:33  *** ExtraCrispy has joined #bitcoin-core-dev
108 2018-10-15T08:55:10  *** vah13 has quit IRC
109 2018-10-15T08:56:20  *** lnostdal has quit IRC
110 2018-10-15T09:01:26  <karelb> Is there some linter on bitcoin core that looks for line length?
111 2018-10-15T09:01:49  *** AaronvanW has joined #bitcoin-core-dev
112 2018-10-15T09:02:06  *** fanquake has joined #bitcoin-core-dev
113 2018-10-15T09:02:13  <luke-jr> karelb: hopefully not, as there is no line length limit? :p
114 2018-10-15T09:03:01  <karelb> :) ok. Some linters say "ok lines should not be longer than 80 characters" etc
115 2018-10-15T09:03:14  <karelb> s/some linters/some best practices/
116 2018-10-15T09:03:33  <luke-jr> in practice, we do have some hard wrapping in the codebase, but IMO it's a bad idea
117 2018-10-15T09:03:41  <sipa> we have plenty of lines that are longer :)
118 2018-10-15T09:03:42  <luke-jr> everyone's editor is a different width, and can soft-wrap as needed
119 2018-10-15T09:04:06  <sipa> and we do have a suggested coding style defined by the clang formatter config in the repo
120 2018-10-15T09:04:35  <karelb> ok, just asking. :D I am now refactoring the RPC doc stuff in this vein - https://gist.github.com/karel-3d/5847ea0172350368dead323211893faa#file-rpc_doc-cpp-L244 - so I am thinking if I should also add some line length limit
121 2018-10-15T09:04:53  <sipa> but it's not really possible to enforce a strict style without making people waste time dealing with every tiny nit
122 2018-10-15T09:05:54  <sipa> karelb: make sure you follow conventions for variable/class/... names in new code
123 2018-10-15T09:06:08  <meshcollider> karelb: is this related/the same/similar to what  achow101 is working on
124 2018-10-15T09:06:18  *** AaronvanW has quit IRC
125 2018-10-15T09:06:23  <sipa> (see developer-notes.md)
126 2018-10-15T09:06:41  <meshcollider> that is, do both of you know what the other is working on to make sure it doesn't overlap
127 2018-10-15T09:07:07  <karelb> meshcollider: I think it is slightly different. I have saw his repo and I did not really understand it all that much, but it seemed complementary
128 2018-10-15T09:07:37  <meshcollider> ok, as long as you're aware of it :)
129 2018-10-15T09:08:04  <karelb> I am, I just don't really understand the code :(
130 2018-10-15T09:08:07  <karelb> https://github.com/achow101/bitcoin/commit/e7dcff0a571866a9487111dc087b4a6e0e9ad5b6
131 2018-10-15T09:08:40  <meshcollider> achow101: ping
132 2018-10-15T09:08:42  <karelb> Hm it seems it is actually similar to what I did, but using univalue
133 2018-10-15T09:13:30  <karelb> sipa: thanks for the link to dev-notes. I will use that
134 2018-10-15T09:15:37  <karelb> (I did not write any big c++ code in years, I am surprised it works)
135 2018-10-15T09:18:48  <meshcollider> lol
136 2018-10-15T09:22:46  * sipa learned c++ from the bitcoin codebase
137 2018-10-15T09:22:57  <sipa> i guess it explains some things...
138 2018-10-15T09:23:00  <karelb> :D
139 2018-10-15T09:23:46  <karelb> "Class member variables have a m_ prefix" - I don't see that in many class variables in bitcoin codebase?
140 2018-10-15T09:24:11  <luke-jr> karelb: old code isn't changed, just new code is expected to follow these
141 2018-10-15T09:24:17  <karelb> oh ok
142 2018-10-15T09:24:31  <karelb> so it's not a good idea to look at existing code for reference
143 2018-10-15T09:25:18  <meshcollider> no there are so many styles everywhere it is very inconsistent
144 2018-10-15T09:26:20  <karelb> ooooh ok
145 2018-10-15T09:27:04  <meshcollider> e.g. new class naming convention is to not start the class name with C iirc, but most existing classes start with C like CWallet
146 2018-10-15T09:27:41  <sipa> karelb: read the first parafraph
147 2018-10-15T09:27:45  <sipa> *paragraph
148 2018-10-15T09:28:39  <karelb> Oooooh ok. Hmm, looking in github on src/ history, it's interesting how little is there new classes added and mostly it's fixes of existing code. Well not that surprising actually.
149 2018-10-15T09:29:15  <sipa> yeah :)
150 2018-10-15T09:29:51  <sipa> karelb: also, new code is often written in new files
151 2018-10-15T09:34:43  <karelb> Also - how much does bitcoin (at least new code) use all the const correctness stuff? I never know how to write it correctly and where to add `const`
152 2018-10-15T09:34:49  *** AaronvanW has joined #bitcoin-core-dev
153 2018-10-15T09:50:11  *** bitcoin-git has joined #bitcoin-core-dev
154 2018-10-15T09:50:11  <bitcoin-git> [bitcoin] HatboyWonder opened pull request #14484: changed request payment button text and tab description (master...master) https://github.com/bitcoin/bitcoin/pull/14484
155 2018-10-15T09:50:11  *** bitcoin-git has left #bitcoin-core-dev
156 2018-10-15T10:00:00  <sipa> karelb: const correctness is easy, never add a const cast
157 2018-10-15T10:00:08  <sipa> if it compiles, you're good
158 2018-10-15T10:00:10  <sipa> :)
159 2018-10-15T10:00:47  <sipa> and there are some small parts of the code that are not const correct, but mostly, yes
160 2018-10-15T10:03:02  <sipa> (in particular the serialization code does some hairy stuff)
161 2018-10-15T10:07:52  *** proletesseract has joined #bitcoin-core-dev
162 2018-10-15T10:14:44  <meshcollider> sipa: I was thinking about the import descriptor thing internally converting to old structures
163 2018-10-15T10:14:57  <meshcollider> for ranges, how would that work
164 2018-10-15T10:15:04  <meshcollider> surely not cover the whole 2^31-1 range or whatever?
165 2018-10-15T10:15:21  <meshcollider> or is that ok
166 2018-10-15T10:17:47  <meshcollider> or just not support ranges for now
167 2018-10-15T10:22:57  <sipa> meshcollider: you'd specify the range along with the import
168 2018-10-15T10:23:29  <sipa> if you specify a billion, you're importing a billion addresses, and the wallet file will likely catch fire and explode
169 2018-10-15T10:24:27  <meshcollider> only one wildcard is allowed in the path eh? No ambiguity if only a single number is used to specify the range?
170 2018-10-15T10:26:34  <sipa> you can have multiple hd paths that end with * in a descriptor
171 2018-10-15T10:26:46  <sipa> but they're always combined pairwise
172 2018-10-15T10:27:11  <sipa> or in other words, all *s are replaced with the same number in an expansion
173 2018-10-15T10:27:42  <meshcollider> ah I see, yep
174 2018-10-15T10:28:01  <meshcollider> and does a range always start from 0
175 2018-10-15T10:28:19  <meshcollider> or should it be a start, end pair
176 2018-10-15T10:30:51  *** ExtraCrispy has quit IRC
177 2018-10-15T10:31:23  <sipa> that's up to the application
178 2018-10-15T10:31:45  <sipa> the descriptor is really just a list of addresses
179 2018-10-15T10:32:21  <sipa> the application chooses to evaluate it at certain positions of the list
180 2018-10-15T10:38:21  *** Guyver2 has joined #bitcoin-core-dev
181 2018-10-15T10:38:22  *** Guyver2_ has joined #bitcoin-core-dev
182 2018-10-15T10:39:47  *** Guyver2_ has quit IRC
183 2018-10-15T10:41:07  *** shesek has quit IRC
184 2018-10-15T10:41:39  *** ExtraCrispy has joined #bitcoin-core-dev
185 2018-10-15T10:46:13  *** xHire is now known as SunbeamMajesty
186 2018-10-15T10:50:37  *** bitcoin-git has joined #bitcoin-core-dev
187 2018-10-15T10:50:38  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/be992701b018...2a2cac787360
188 2018-10-15T10:50:39  <bitcoin-git> bitcoin/master 2f6b466 Pieter Wuille: Stop requiring imported pubkey to sign non-PKH schemes
189 2018-10-15T10:50:39  <bitcoin-git> bitcoin/master 2a2cac7 Jonas Schnelli: Merge #14424: Stop requiring imported pubkey to sign non-PKH schemes...
190 2018-10-15T10:50:40  *** bitcoin-git has left #bitcoin-core-dev
191 2018-10-15T10:51:42  *** bitcoin-git has joined #bitcoin-core-dev
192 2018-10-15T10:51:42  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14424: Stop requiring imported pubkey to sign non-PKH schemes (master...201810_importpubkeylol) https://github.com/bitcoin/bitcoin/pull/14424
193 2018-10-15T10:51:42  *** bitcoin-git has left #bitcoin-core-dev
194 2018-10-15T10:54:17  *** SunbeamMajesty is now known as xHire
195 2018-10-15T11:03:02  *** rex4539 has joined #bitcoin-core-dev
196 2018-10-15T11:06:32  *** reallll has joined #bitcoin-core-dev
197 2018-10-15T11:09:16  *** belcher_ has quit IRC
198 2018-10-15T11:36:35  <luke-jr> MarcoFalke: why'd you close #14080 ?
199 2018-10-15T11:36:37  <gribble> https://github.com/bitcoin/bitcoin/issues/14080 | travis: Run unit tests --with-sanitizers=thread by MarcoFalke · Pull Request #14080 · bitcoin/bitcoin · GitHub
200 2018-10-15T11:41:22  *** Deacyde has quit IRC
201 2018-10-15T11:41:48  *** Deacyde has joined #bitcoin-core-dev
202 2018-10-15T11:44:26  *** proletesseract has quit IRC
203 2018-10-15T11:45:04  *** promag has quit IRC
204 2018-10-15T12:01:42  <jonasschnelli> sipa: what is the status of Bech32X (26 char checksum BCH)?
205 2018-10-15T12:08:16  *** reallll is now known as belcher
206 2018-10-15T12:13:01  *** rh0nj has quit IRC
207 2018-10-15T12:14:08  *** rh0nj has joined #bitcoin-core-dev
208 2018-10-15T12:20:09  *** bitcoin-git has joined #bitcoin-core-dev
209 2018-10-15T12:20:10  <bitcoin-git> [bitcoin] luke-jr opened pull request #14485: Try to use posix_fadvise with CBufferedFile (master...fadvise) https://github.com/bitcoin/bitcoin/pull/14485
210 2018-10-15T12:20:10  *** bitcoin-git has left #bitcoin-core-dev
211 2018-10-15T12:27:47  *** SopaXorzTaker has joined #bitcoin-core-dev
212 2018-10-15T12:39:01  *** promag has joined #bitcoin-core-dev
213 2018-10-15T12:44:24  *** rex4539 has quit IRC
214 2018-10-15T12:50:12  *** bitcoin-git has joined #bitcoin-core-dev
215 2018-10-15T12:50:12  <bitcoin-git> [bitcoin] mrwhythat closed pull request #14476: RPC method 'encodescript' (master...encodescript-rpc) https://github.com/bitcoin/bitcoin/pull/14476
216 2018-10-15T12:50:12  *** bitcoin-git has left #bitcoin-core-dev
217 2018-10-15T12:57:13  *** dviola has joined #bitcoin-core-dev
218 2018-10-15T12:59:46  *** rex4539 has joined #bitcoin-core-dev
219 2018-10-15T13:03:44  *** leishman has joined #bitcoin-core-dev
220 2018-10-15T13:08:06  *** leishman has quit IRC
221 2018-10-15T13:10:17  *** vamp111 has joined #bitcoin-core-dev
222 2018-10-15T13:10:35  <vamp111> Hi, where can i write to support, i have some issues with my full node
223 2018-10-15T13:11:03  <belcher> vamp111 #bitcoin is best
224 2018-10-15T13:11:10  <meshcollider> vamp111: either #bitcoin or use the stack exchange, bitcoin.stackexchange.com
225 2018-10-15T13:11:59  *** vamp111 has left #bitcoin-core-dev
226 2018-10-15T13:21:29  *** promag has quit IRC
227 2018-10-15T13:26:54  *** fanquake has quit IRC
228 2018-10-15T13:28:25  <meshcollider> sipa: how does something like this look https://github.com/MeshCollider/bitcoin/tree/201810_importmulti_desc
229 2018-10-15T13:29:02  <meshcollider> Maybe just look at the test case rather than the whole diff for a concept ack
230 2018-10-15T13:29:07  <meshcollider> I'll open a PR
231 2018-10-15T13:42:25  *** esotericnonsense has quit IRC
232 2018-10-15T13:45:08  *** esotericnonsense has joined #bitcoin-core-dev
233 2018-10-15T13:48:33  *** dviola has quit IRC
234 2018-10-15T13:48:45  *** bitcoin-git has joined #bitcoin-core-dev
235 2018-10-15T13:48:45  <bitcoin-git> [bitcoin] DesWurstes opened pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
236 2018-10-15T13:48:45  *** bitcoin-git has left #bitcoin-core-dev
237 2018-10-15T14:00:24  *** setpill has quit IRC
238 2018-10-15T14:01:12  *** Krellan has quit IRC
239 2018-10-15T14:02:02  *** Krellan has joined #bitcoin-core-dev
240 2018-10-15T14:05:04  *** dviola has joined #bitcoin-core-dev
241 2018-10-15T14:10:15  *** bitcoin-git has joined #bitcoin-core-dev
242 2018-10-15T14:10:15  <bitcoin-git> [bitcoin] DesWurstes opened pull request #14487: Constexpr Everything Part 1: Constants (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14487
243 2018-10-15T14:10:15  *** bitcoin-git has left #bitcoin-core-dev
244 2018-10-15T14:12:56  *** pkx1 has joined #bitcoin-core-dev
245 2018-10-15T14:13:22  <instagibbs> meshcollider, oh did you start on the importmulti for descriptors? I already had, but feel free to do it :)
246 2018-10-15T14:26:12  *** pkx1 has quit IRC
247 2018-10-15T14:27:01  *** windsok_ has quit IRC
248 2018-10-15T14:27:17  *** windsok has joined #bitcoin-core-dev
249 2018-10-15T14:27:17  *** windsok has joined #bitcoin-core-dev
250 2018-10-15T14:27:46  *** jrayhawk has quit IRC
251 2018-10-15T14:29:29  *** jrayhawk has joined #bitcoin-core-dev
252 2018-10-15T14:40:45  *** leishman has joined #bitcoin-core-dev
253 2018-10-15T14:42:01  *** rex4539 has joined #bitcoin-core-dev
254 2018-10-15T14:43:55  *** shesek has joined #bitcoin-core-dev
255 2018-10-15T14:43:55  *** shesek has joined #bitcoin-core-dev
256 2018-10-15T14:45:27  <echeveria> that's binance out of tether.
257 2018-10-15T14:45:35  <echeveria> they've disabled their tether wallet.
258 2018-10-15T14:50:28  *** leishman has quit IRC
259 2018-10-15T14:53:57  *** Giszmo has quit IRC
260 2018-10-15T14:54:30  *** leishman has joined #bitcoin-core-dev
261 2018-10-15T14:54:45  *** promag has joined #bitcoin-core-dev
262 2018-10-15T14:56:42  <waxwing> sipa, is this comment actually valid as of now? https://github.com/bitcoin/bitcoin/blob/0.17/src/script/sign.cpp#L252-L255
263 2018-10-15T14:56:58  <waxwing> i ask because FillPSBT won't allow both as per https://github.com/bitcoin/bitcoin/blob/0.17/src/wallet/rpcwallet.cpp#L4528-L4534
264 2018-10-15T14:57:19  <waxwing> and non-wallet inputs would be covered by the deserialization checking sanity (as i think it says in the comment)
265 2018-10-15T15:01:08  <promag> jnewbery: can you review #14291?
266 2018-10-15T15:01:11  <gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
267 2018-10-15T15:02:31  *** kabaum_ has joined #bitcoin-core-dev
268 2018-10-15T15:03:11  <sipa> waxwing: not valid anymore, right
269 2018-10-15T15:03:26  <sipa> the code in rpcwallet you quote is more recent
270 2018-10-15T15:06:36  <waxwing> sipa, thx
271 2018-10-15T15:10:44  *** Giszmo has joined #bitcoin-core-dev
272 2018-10-15T15:11:07  *** dviola has quit IRC
273 2018-10-15T15:27:11  *** leishman has quit IRC
274 2018-10-15T15:32:58  *** cryptapus has quit IRC
275 2018-10-15T15:35:41  *** windsok has quit IRC
276 2018-10-15T15:36:00  *** windsok has joined #bitcoin-core-dev
277 2018-10-15T15:36:00  *** windsok has joined #bitcoin-core-dev
278 2018-10-15T15:43:56  *** leishman has joined #bitcoin-core-dev
279 2018-10-15T15:46:54  *** leishman has quit IRC
280 2018-10-15T15:47:38  *** leishman has joined #bitcoin-core-dev
281 2018-10-15T15:49:09  *** bralyclo_ has quit IRC
282 2018-10-15T15:49:26  *** bralyclow has joined #bitcoin-core-dev
283 2018-10-15T15:52:01  *** leishman has quit IRC
284 2018-10-15T15:54:55  *** leishman has joined #bitcoin-core-dev
285 2018-10-15T15:58:20  *** e4xit has quit IRC
286 2018-10-15T16:01:23  *** promag has quit IRC
287 2018-10-15T16:04:44  *** Krellan has quit IRC
288 2018-10-15T16:05:48  *** rex4539 has quit IRC
289 2018-10-15T16:09:15  *** leishman has quit IRC
290 2018-10-15T16:10:30  *** irc_viewer_test has joined #bitcoin-core-dev
291 2018-10-15T16:12:38  *** leishman has joined #bitcoin-core-dev
292 2018-10-15T16:13:58  *** luke-jr has quit IRC
293 2018-10-15T16:15:02  *** luke-jr has joined #bitcoin-core-dev
294 2018-10-15T16:16:45  *** jarthur has joined #bitcoin-core-dev
295 2018-10-15T16:17:42  *** Murch has joined #bitcoin-core-dev
296 2018-10-15T16:25:30  *** Krellan has joined #bitcoin-core-dev
297 2018-10-15T16:35:24  *** irc_viewer_test1 has joined #bitcoin-core-dev
298 2018-10-15T16:37:52  *** irc_viewer_test has quit IRC
299 2018-10-15T16:39:24  *** irc_viewer_test1 has quit IRC
300 2018-10-15T16:40:22  *** promag has joined #bitcoin-core-dev
301 2018-10-15T16:42:58  *** esotericnonsense has quit IRC
302 2018-10-15T16:44:18  *** esotericnonsense has joined #bitcoin-core-dev
303 2018-10-15T16:45:07  *** promag has quit IRC
304 2018-10-15T16:50:10  *** michaelsdunn1 has joined #bitcoin-core-dev
305 2018-10-15T16:53:42  *** leishman has quit IRC
306 2018-10-15T16:55:05  *** leishman has joined #bitcoin-core-dev
307 2018-10-15T16:55:32  *** michaelsdunn1 has quit IRC
308 2018-10-15T16:57:16  *** michaelsdunn1 has joined #bitcoin-core-dev
309 2018-10-15T16:59:13  *** leishman has quit IRC
310 2018-10-15T17:00:49  *** leishman has joined #bitcoin-core-dev
311 2018-10-15T17:04:43  *** leishman has joined #bitcoin-core-dev
312 2018-10-15T17:30:25  *** hebasto has quit IRC
313 2018-10-15T17:30:37  *** meshcollider_ has joined #bitcoin-core-dev
314 2018-10-15T17:31:26  *** jarthur has quit IRC
315 2018-10-15T17:33:08  *** jungly has quit IRC
316 2018-10-15T17:33:48  *** shesek has quit IRC
317 2018-10-15T17:41:34  *** Zenton has quit IRC
318 2018-10-15T17:42:58  *** Krellan has quit IRC
319 2018-10-15T17:53:14  *** str4d has joined #bitcoin-core-dev
320 2018-10-15T18:02:28  *** esotericnonsense has quit IRC
321 2018-10-15T18:11:29  *** owowo has quit IRC
322 2018-10-15T18:16:46  *** owowo has joined #bitcoin-core-dev
323 2018-10-15T18:29:15  *** esotericnonsense has joined #bitcoin-core-dev
324 2018-10-15T18:33:40  *** leishman has quit IRC
325 2018-10-15T18:35:32  *** leishman has joined #bitcoin-core-dev
326 2018-10-15T18:40:43  *** SopaXorzTaker has quit IRC
327 2018-10-15T18:43:44  *** ghost43 has quit IRC
328 2018-10-15T18:43:57  *** ghost43 has joined #bitcoin-core-dev
329 2018-10-15T18:55:09  *** Victorsueca has joined #bitcoin-core-dev
330 2018-10-15T19:21:19  *** leishman has quit IRC
331 2018-10-15T19:21:41  *** luke-jr has quit IRC
332 2018-10-15T19:22:03  *** luke-jr has joined #bitcoin-core-dev
333 2018-10-15T19:23:28  *** leishman has joined #bitcoin-core-dev
334 2018-10-15T19:27:48  *** Zenton has joined #bitcoin-core-dev
335 2018-10-15T19:30:24  *** leishman has quit IRC
336 2018-10-15T19:35:21  *** Krellan has joined #bitcoin-core-dev
337 2018-10-15T19:40:24  *** meshcollider_ has quit IRC
338 2018-10-15T19:43:57  *** rex4539 has joined #bitcoin-core-dev
339 2018-10-15T19:56:41  *** leishman has joined #bitcoin-core-dev
340 2018-10-15T20:11:35  *** Guyver2 has quit IRC
341 2018-10-15T20:28:13  *** promag has joined #bitcoin-core-dev
342 2018-10-15T20:32:43  *** draptomano4 has joined #bitcoin-core-dev
343 2018-10-15T20:32:57  *** leishman has quit IRC
344 2018-10-15T20:33:43  *** draptomano4 has quit IRC
345 2018-10-15T20:39:56  *** leishman has joined #bitcoin-core-dev
346 2018-10-15T20:50:08  <sipa> achow101, meshcollider: looking back at your PRs #14454 and #14019, i'm confused why we need to import the raw pubkey scripts when doing an importmulti
347 2018-10-15T20:50:10  <gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
348 2018-10-15T20:50:12  <gribble> https://github.com/bitcoin/bitcoin/issues/14019 | Import pubkeys when importing p2sh with importmulti by achow101 · Pull Request #14019 · bitcoin/bitcoin · GitHub
349 2018-10-15T20:50:38  <sipa> i understand you may want to add a key to mapKeyMetaData in order to have hd path information etc, but that's not what's happening
350 2018-10-15T20:51:35  <sipa> and since #14424 having the pubkey itself imported should only be needed to P2PKH and P2WPKH
351 2018-10-15T20:51:37  <gribble> https://github.com/bitcoin/bitcoin/issues/14424 | Stop requiring imported pubkey to sign non-PKH schemes by sipa · Pull Request #14424 · bitcoin/bitcoin · GitHub
352 2018-10-15T20:54:56  <achow101> sipa: 14019 as needed as a precursor to #14021 which does the hd path import stuff.
353 2018-10-15T20:54:58  <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
354 2018-10-15T20:55:42  <achow101> I separated that into 2 PRs because the importing of pubkeys in a p2sh seemed to be orthogonal to the end goal
355 2018-10-15T20:56:07  <sipa> but why do you need the pubkey itself imported?
356 2018-10-15T20:56:22  <sipa> i think you just need a mapKeyMetadata entry
357 2018-10-15T20:57:05  <achow101> so that GetPubKey and/or CreateSig work
358 2018-10-15T20:57:25  <sipa> GetPubKey should only be needed for PKH schemes
359 2018-10-15T20:57:36  <sipa> since 14424
360 2018-10-15T20:58:39  <sipa> i'd really like to avoid making unrelated things watched; for multisig that's even dangerous as someone can trick you into thinking you're being paid by paying to one of the constituent pubkeys rather than the multisig script
361 2018-10-15T20:59:55  <sipa> oh, CreateSig also takes a CKeyID as input?
362 2018-10-15T21:01:02  *** Victorsueca has quit IRC
363 2018-10-15T21:01:30  <sipa> oh, no
364 2018-10-15T21:01:46  <sipa> not anymore
365 2018-10-15T21:01:56  <sipa> achow101: can you please test if this is still needed since 14424?
366 2018-10-15T21:02:15  <achow101> with 14424, I don't think that importing pubkeys with p2sh is necessary anymore
367 2018-10-15T21:02:28  <sipa> okay!
368 2018-10-15T21:02:35  <achow101> unless we support signing with arbitrary scripts which may contain pubkey hashes
369 2018-10-15T21:02:46  <achow101> (this has been requested by someone and I said I would look into it)
370 2018-10-15T21:03:01  <sipa> that's not supported anyway right now
371 2018-10-15T21:03:38  <sipa> and with descriptors that would become possible without making payments to those pubkeys themselves treated as ismine
372 2018-10-15T21:03:54  <achow101> eh, the request was actually signing arbitrary scripts in a psbt, so importing pubkeys probably wouldn't be necessary
373 2018-10-15T21:04:23  <achow101> It could probably be done by bypassing ProduceSignature and doing a simple signer instead for psbts
374 2018-10-15T21:04:35  <sipa> right
375 2018-10-15T21:06:40  *** bitcoin-git has joined #bitcoin-core-dev
376 2018-10-15T21:06:40  <bitcoin-git> [bitcoin] achow101 closed pull request #14019: Import pubkeys when importing p2sh with importmulti (master...import-multi-pubkeys) https://github.com/bitcoin/bitcoin/pull/14019
377 2018-10-15T21:06:40  *** bitcoin-git has left #bitcoin-core-dev
378 2018-10-15T21:08:28  *** jarthur has joined #bitcoin-core-dev
379 2018-10-15T21:17:01  *** michaelsdunn1 has quit IRC
380 2018-10-15T21:21:23  *** ExtraCrispy has quit IRC
381 2018-10-15T21:24:14  *** leishman has quit IRC
382 2018-10-15T21:24:24  *** ExtraCrispy has joined #bitcoin-core-dev
383 2018-10-15T21:24:39  *** leishman has joined #bitcoin-core-dev
384 2018-10-15T21:32:48  *** leishman has quit IRC
385 2018-10-15T21:37:46  *** leishman has joined #bitcoin-core-dev
386 2018-10-15T21:45:32  <meshcollider> sipa: in that case, it looks like I can just delete the entire "// Import public keys." block of code?
387 2018-10-15T21:45:55  <meshcollider> Because the case of single key addresses P2PK, P2PKH, P2WPKH is already covered above
388 2018-10-15T21:46:34  <meshcollider> Well, I just need to move the actual import to there
389 2018-10-15T21:46:40  *** lnostdal has joined #bitcoin-core-dev
390 2018-10-15T21:51:49  <sipa> meshcollider: i haven't looked in detail at the implementation
391 2018-10-15T21:52:30  <meshcollider> I mean, is the only case where we need to import a public key is for a P2PKH/P2WPKH without the private key?
392 2018-10-15T21:52:59  <sipa> right, and P2SH-P2WPKH
393 2018-10-15T21:54:06  *** bitconner has joined #bitcoin-core-dev
394 2018-10-15T21:54:17  *** lnostdal has quit IRC
395 2018-10-15T21:56:07  *** lnostdal has joined #bitcoin-core-dev
396 2018-10-15T22:00:47  *** newhere1111 has joined #bitcoin-core-dev
397 2018-10-15T22:02:27  *** newhere1111 has quit IRC
398 2018-10-15T22:09:40  *** proletesseract has joined #bitcoin-core-dev
399 2018-10-15T22:29:17  *** proletesseract has quit IRC
400 2018-10-15T22:33:45  *** Victorsueca has joined #bitcoin-core-dev
401 2018-10-15T22:36:42  *** proletesseract has joined #bitcoin-core-dev
402 2018-10-15T22:38:34  *** jb55 has quit IRC
403 2018-10-15T22:41:01  *** proletesseract has quit IRC
404 2018-10-15T22:46:13  *** laurentmt has joined #bitcoin-core-dev
405 2018-10-15T22:54:29  *** ExtraCrispy_ has joined #bitcoin-core-dev
406 2018-10-15T22:56:50  *** leishman has quit IRC
407 2018-10-15T22:58:17  *** ExtraCrispy has quit IRC
408 2018-10-15T23:00:35  *** leishman has joined #bitcoin-core-dev
409 2018-10-15T23:02:27  *** proletesseract has joined #bitcoin-core-dev
410 2018-10-15T23:04:12  *** laurentmt has quit IRC
411 2018-10-15T23:04:20  *** leishman has quit IRC
412 2018-10-15T23:06:37  *** leishman has joined #bitcoin-core-dev
413 2018-10-15T23:07:25  *** bitcoin-git has joined #bitcoin-core-dev
414 2018-10-15T23:07:25  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14489: refactor: Drop boost::thread and boost::chrono (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/14489
415 2018-10-15T23:07:25  *** bitcoin-git has left #bitcoin-core-dev
416 2018-10-15T23:20:11  *** unholymachine has joined #bitcoin-core-dev
417 2018-10-15T23:20:30  *** jarthur has quit IRC
418 2018-10-15T23:39:42  *** qrestlove has quit IRC
419 2018-10-15T23:43:20  *** dongcarl_ has joined #bitcoin-core-dev
420 2018-10-15T23:49:35  *** qrestlove has joined #bitcoin-core-dev
421 2018-10-15T23:50:04  *** leishman has quit IRC
422 2018-10-15T23:59:22  *** dongcarl_ has quit IRC