1 2018-10-23T00:17:45  *** hebasto_ has quit IRC
  2 2018-10-23T00:18:08  *** hebasto_ has joined #bitcoin-core-dev
  3 2018-10-23T00:37:13  *** bitcoin-git has joined #bitcoin-core-dev
  4 2018-10-23T00:37:13  <bitcoin-git> [bitcoin] charlesrocket closed pull request #14539: add Apple SDK download to gitian-build.py (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539
  5 2018-10-23T00:37:13  *** bitcoin-git has left #bitcoin-core-dev
  6 2018-10-23T00:40:18  *** AaronvanW has joined #bitcoin-core-dev
  7 2018-10-23T00:51:13  *** ken2812221 has joined #bitcoin-core-dev
  8 2018-10-23T01:01:01  *** rh0nj has quit IRC
  9 2018-10-23T01:02:08  *** rh0nj has joined #bitcoin-core-dev
 10 2018-10-23T01:13:35  *** AaronvanW has quit IRC
 11 2018-10-23T01:17:41  *** spinza has quit IRC
 12 2018-10-23T01:21:02  *** Krellan has joined #bitcoin-core-dev
 13 2018-10-23T01:27:36  *** spinza has joined #bitcoin-core-dev
 14 2018-10-23T01:30:08  *** cubancorona has joined #bitcoin-core-dev
 15 2018-10-23T01:30:54  *** cubancorona has quit IRC
 16 2018-10-23T01:32:54  *** Krellan has quit IRC
 17 2018-10-23T01:32:59  *** Randolf has joined #bitcoin-core-dev
 18 2018-10-23T01:34:04  *** rafalcpp_ has quit IRC
 19 2018-10-23T01:34:30  *** rafalcpp_ has joined #bitcoin-core-dev
 20 2018-10-23T01:43:33  *** bitcoin-git has joined #bitcoin-core-dev
 21 2018-10-23T01:43:34  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8f519a0626...b3f377daaa86
 22 2018-10-23T01:43:34  <bitcoin-git> bitcoin/master 5918204 Martin Erlandsson: Removed explicit mention of storage requirement (squashed)...
 23 2018-10-23T01:43:35  <bitcoin-git> bitcoin/master b3f377d Pieter Wuille: Merge #14511: doc: Remove explicit storage requirement from README.md...
 24 2018-10-23T01:43:35  *** bitcoin-git has left #bitcoin-core-dev
 25 2018-10-23T01:44:38  *** bitcoin-git has joined #bitcoin-core-dev
 26 2018-10-23T01:44:38  <bitcoin-git> [bitcoin] sipa closed pull request #14511: doc: Remove explicit storage requirement from README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
 27 2018-10-23T01:44:38  *** bitcoin-git has left #bitcoin-core-dev
 28 2018-10-23T02:05:24  *** mr_paz has joined #bitcoin-core-dev
 29 2018-10-23T02:25:44  *** Murch has quit IRC
 30 2018-10-23T02:33:05  *** ken2812221 has quit IRC
 31 2018-10-23T02:33:14  *** sanket1729_ has joined #bitcoin-core-dev
 32 2018-10-23T02:37:40  *** sanket1729_ has quit IRC
 33 2018-10-23T03:00:12  <sipa> status.github.com reports everything operating normally again, since 4 hours ago
 34 2018-10-23T03:00:29  <sipa> the whole incident lasted 23h54m ...
 35 2018-10-23T03:12:12  *** spinza has quit IRC
 36 2018-10-23T03:17:37  *** Guest74867 is now known as iphelix
 37 2018-10-23T03:17:38  *** iphelix has joined #bitcoin-core-dev
 38 2018-10-23T03:26:58  <meshcollider> Ouch
 39 2018-10-23T03:40:27  *** Randolf has quit IRC
 40 2018-10-23T03:41:14  *** Randolf has joined #bitcoin-core-dev
 41 2018-10-23T03:53:07  *** schnerchi has joined #bitcoin-core-dev
 42 2018-10-23T03:56:40  *** schnerch_ has quit IRC
 43 2018-10-23T04:16:18  *** sanket1729 has joined #bitcoin-core-dev
 44 2018-10-23T04:19:29  *** spinza has joined #bitcoin-core-dev
 45 2018-10-23T04:26:05  *** AaronvanW has joined #bitcoin-core-dev
 46 2018-10-23T04:31:33  *** AaronvanW has quit IRC
 47 2018-10-23T04:55:25  *** Tralfaz has quit IRC
 48 2018-10-23T04:58:53  *** bitcoin-git has joined #bitcoin-core-dev
 49 2018-10-23T04:58:54  <bitcoin-git> [bitcoin] preserveddarnell opened pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
 50 2018-10-23T04:58:54  *** bitcoin-git has left #bitcoin-core-dev
 51 2018-10-23T05:01:42  *** bitcoin-git has joined #bitcoin-core-dev
 52 2018-10-23T05:01:42  <bitcoin-git> [bitcoin] fanquake closed pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
 53 2018-10-23T05:01:42  *** bitcoin-git has left #bitcoin-core-dev
 54 2018-10-23T05:05:47  *** bitcoin-git has joined #bitcoin-core-dev
 55 2018-10-23T05:05:47  <bitcoin-git> [bitcoin] preserveddarnell opened pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
 56 2018-10-23T05:05:47  *** bitcoin-git has left #bitcoin-core-dev
 57 2018-10-23T05:22:52  *** bitconner has quit IRC
 58 2018-10-23T05:49:18  *** Tralfaz has joined #bitcoin-core-dev
 59 2018-10-23T05:57:24  *** AaronvanW has joined #bitcoin-core-dev
 60 2018-10-23T05:57:40  *** Tralfaz has quit IRC
 61 2018-10-23T06:00:13  *** Tralfaz has joined #bitcoin-core-dev
 62 2018-10-23T06:08:02  *** rh0nj has quit IRC
 63 2018-10-23T06:09:07  *** rh0nj has joined #bitcoin-core-dev
 64 2018-10-23T06:32:58  *** panako has joined #bitcoin-core-dev
 65 2018-10-23T06:40:33  *** martinus__ has joined #bitcoin-core-dev
 66 2018-10-23T06:44:35  *** martinus_ has quit IRC
 67 2018-10-23T06:46:26  *** AaronvanW has quit IRC
 68 2018-10-23T06:56:46  *** AaronvanW has joined #bitcoin-core-dev
 69 2018-10-23T06:58:47  *** josephnicholas has joined #bitcoin-core-dev
 70 2018-10-23T07:01:41  *** AaronvanW has quit IRC
 71 2018-10-23T07:04:20  *** setpill has joined #bitcoin-core-dev
 72 2018-10-23T07:10:23  *** Hassaan121 has joined #bitcoin-core-dev
 73 2018-10-23T07:10:47  *** Hassaan121 has left #bitcoin-core-dev
 74 2018-10-23T07:12:41  *** bitcoin-git has joined #bitcoin-core-dev
 75 2018-10-23T07:12:41  <bitcoin-git> [bitcoin] laanwj closed pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
 76 2018-10-23T07:12:41  *** bitcoin-git has left #bitcoin-core-dev
 77 2018-10-23T07:18:43  *** jungly has joined #bitcoin-core-dev
 78 2018-10-23T07:18:44  *** gribble has quit IRC
 79 2018-10-23T07:20:51  *** josephni_ has joined #bitcoin-core-dev
 80 2018-10-23T07:22:16  *** josephnicholas has quit IRC
 81 2018-10-23T07:23:16  *** sanket1729 has quit IRC
 82 2018-10-23T07:28:37  *** gribble has joined #bitcoin-core-dev
 83 2018-10-23T07:40:50  *** Krellan has joined #bitcoin-core-dev
 84 2018-10-23T07:41:40  *** Krellan_ has joined #bitcoin-core-dev
 85 2018-10-23T07:43:42  *** michaelfolkson has joined #bitcoin-core-dev
 86 2018-10-23T07:45:40  *** Krellan has quit IRC
 87 2018-10-23T07:58:05  *** AaronvanW has joined #bitcoin-core-dev
 88 2018-10-23T08:00:07  *** bitcoin-git has joined #bitcoin-core-dev
 89 2018-10-23T08:00:07  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14552: wallet: throw an error if user load the wallet file by different ways (master...default-wallet-fix) https://github.com/bitcoin/bitcoin/pull/14552
 90 2018-10-23T08:00:07  *** bitcoin-git has left #bitcoin-core-dev
 91 2018-10-23T08:03:07  *** AaronvanW has quit IRC
 92 2018-10-23T08:16:47  *** josephni_ has quit IRC
 93 2018-10-23T08:18:17  *** laurentmt has joined #bitcoin-core-dev
 94 2018-10-23T08:21:57  *** laurentmt has quit IRC
 95 2018-10-23T08:24:00  *** timothy has joined #bitcoin-core-dev
 96 2018-10-23T08:37:47  *** Randolf has quit IRC
 97 2018-10-23T08:38:53  *** Randolf has joined #bitcoin-core-dev
 98 2018-10-23T08:44:55  *** AaronvanW has joined #bitcoin-core-dev
 99 2018-10-23T08:48:11  *** OzPac has joined #bitcoin-core-dev
100 2018-10-23T08:50:56  *** panako has quit IRC
101 2018-10-23T09:07:58  *** josephnicholas has joined #bitcoin-core-dev
102 2018-10-23T09:12:07  *** josephnicholas has quit IRC
103 2018-10-23T09:21:16  *** josephnicholas has joined #bitcoin-core-dev
104 2018-10-23T09:23:11  *** michaelfolkson has quit IRC
105 2018-10-23T09:45:19  *** josephnicholas has quit IRC
106 2018-10-23T09:45:53  *** josephnicholas has joined #bitcoin-core-dev
107 2018-10-23T09:46:23  *** michaelfolkson has joined #bitcoin-core-dev
108 2018-10-23T09:49:37  *** laurentmt has joined #bitcoin-core-dev
109 2018-10-23T09:50:07  *** josephnicholas has quit IRC
110 2018-10-23T09:53:53  *** ap4lmtree has joined #bitcoin-core-dev
111 2018-10-23T10:11:19  *** spinza has quit IRC
112 2018-10-23T10:18:23  *** b77 has joined #bitcoin-core-dev
113 2018-10-23T10:18:51  *** b77 has quit IRC
114 2018-10-23T10:22:52  *** klot has joined #bitcoin-core-dev
115 2018-10-23T10:23:37  *** bitconner has joined #bitcoin-core-dev
116 2018-10-23T10:23:43  *** spinza has joined #bitcoin-core-dev
117 2018-10-23T10:23:43  *** klot has quit IRC
118 2018-10-23T10:24:08  *** klot has joined #bitcoin-core-dev
119 2018-10-23T10:24:41  *** laurentmt has quit IRC
120 2018-10-23T10:25:13  *** klot has quit IRC
121 2018-10-23T10:25:38  *** klot has joined #bitcoin-core-dev
122 2018-10-23T10:26:43  *** klot has quit IRC
123 2018-10-23T10:27:12  *** klot has joined #bitcoin-core-dev
124 2018-10-23T10:28:21  *** bitconner has quit IRC
125 2018-10-23T10:38:07  *** shesek has quit IRC
126 2018-10-23T10:43:03  *** sakalli_ has joined #bitcoin-core-dev
127 2018-10-23T10:45:27  *** sakalli_ has quit IRC
128 2018-10-23T10:52:45  *** josephnicholas has joined #bitcoin-core-dev
129 2018-10-23T10:57:09  *** josephnicholas has quit IRC
130 2018-10-23T11:18:26  *** Guyver2 has joined #bitcoin-core-dev
131 2018-10-23T11:31:57  *** josephnicholas has joined #bitcoin-core-dev
132 2018-10-23T11:36:37  *** michaelfolkson has quit IRC
133 2018-10-23T11:47:32  *** josephnicholas_ has joined #bitcoin-core-dev
134 2018-10-23T11:48:07  *** josephnicholas has quit IRC
135 2018-10-23T11:48:25  <josephnicholas_> Hello all
136 2018-10-23T11:55:23  *** michaelfolkson has joined #bitcoin-core-dev
137 2018-10-23T11:57:24  *** Krellan_ has quit IRC
138 2018-10-23T11:57:50  *** ken2812221 has joined #bitcoin-core-dev
139 2018-10-23T11:58:28  *** Krellan has joined #bitcoin-core-dev
140 2018-10-23T12:00:09  *** intcat has quit IRC
141 2018-10-23T12:02:28  *** intcat has joined #bitcoin-core-dev
142 2018-10-23T12:05:14  *** michaelfolkson has quit IRC
143 2018-10-23T12:06:10  *** michaelfolkson has joined #bitcoin-core-dev
144 2018-10-23T12:17:15  *** josephnicholas_ has quit IRC
145 2018-10-23T12:18:33  *** michaelfolkson has quit IRC
146 2018-10-23T12:22:50  *** michaelfolkson has joined #bitcoin-core-dev
147 2018-10-23T12:23:52  *** bitconner has joined #bitcoin-core-dev
148 2018-10-23T12:28:16  *** bitconner has quit IRC
149 2018-10-23T12:32:23  *** IGHOR has quit IRC
150 2018-10-23T12:49:43  *** ken2812221 has quit IRC
151 2018-10-23T12:50:59  *** map has joined #bitcoin-core-dev
152 2018-10-23T12:51:24  *** map is now known as Guest8103
153 2018-10-23T12:52:08  *** Guest8103 has quit IRC
154 2018-10-23T12:53:22  *** panako has joined #bitcoin-core-dev
155 2018-10-23T12:58:35  *** ghost43 has quit IRC
156 2018-10-23T12:58:52  *** ghost43 has joined #bitcoin-core-dev
157 2018-10-23T13:03:31  *** setpill has quit IRC
158 2018-10-23T13:06:28  *** klot has quit IRC
159 2018-10-23T13:07:13  *** klot has joined #bitcoin-core-dev
160 2018-10-23T13:08:15  *** unifiedh has joined #bitcoin-core-dev
161 2018-10-23T13:08:24  *** klot has quit IRC
162 2018-10-23T13:08:55  *** klot has joined #bitcoin-core-dev
163 2018-10-23T13:09:52  *** bitcoin-git has joined #bitcoin-core-dev
164 2018-10-23T13:09:53  <bitcoin-git> [bitcoin] merland opened pull request #14553: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
165 2018-10-23T13:09:53  *** bitcoin-git has left #bitcoin-core-dev
166 2018-10-23T13:09:55  *** spinza has quit IRC
167 2018-10-23T13:10:44  *** zautomata has joined #bitcoin-core-dev
168 2018-10-23T13:10:55  *** zautomata has joined #bitcoin-core-dev
169 2018-10-23T13:12:04  *** Randolf has quit IRC
170 2018-10-23T13:12:16  *** zautomata has left #bitcoin-core-dev
171 2018-10-23T13:15:23  *** Randolf has joined #bitcoin-core-dev
172 2018-10-23T13:31:33  *** spinza has joined #bitcoin-core-dev
173 2018-10-23T13:33:48  *** michaelfolkson has quit IRC
174 2018-10-23T13:41:51  *** michaelfolkson has joined #bitcoin-core-dev
175 2018-10-23T14:08:11  *** Krellan has quit IRC
176 2018-10-23T14:09:09  *** michaelfolkson has quit IRC
177 2018-10-23T14:09:40  *** Krellan has joined #bitcoin-core-dev
178 2018-10-23T14:24:07  *** bitconner has joined #bitcoin-core-dev
179 2018-10-23T14:26:25  *** kihjhgzh has joined #bitcoin-core-dev
180 2018-10-23T14:27:56  *** kihjhgzh has quit IRC
181 2018-10-23T14:28:52  *** bitconner has quit IRC
182 2018-10-23T14:36:31  *** michaelsdunn1 has joined #bitcoin-core-dev
183 2018-10-23T14:45:36  *** bitcoin-git has joined #bitcoin-core-dev
184 2018-10-23T14:45:36  <bitcoin-git> [bitcoin] hebasto opened pull request #14554: qt: Remove unused `adjustedTime` parameter (master...20181023-unused-adjustedtime) https://github.com/bitcoin/bitcoin/pull/14554
185 2018-10-23T14:45:36  *** bitcoin-git has left #bitcoin-core-dev
186 2018-10-23T14:48:23  *** IGHOR has joined #bitcoin-core-dev
187 2018-10-23T14:49:47  *** hebasto_ has quit IRC
188 2018-10-23T14:50:22  *** hebasto has joined #bitcoin-core-dev
189 2018-10-23T14:55:39  *** michaelfolkson has joined #bitcoin-core-dev
190 2018-10-23T14:59:26  *** unifiedh has quit IRC
191 2018-10-23T15:03:31  *** michaelfolkson has quit IRC
192 2018-10-23T15:16:18  *** Sinclair6 has joined #bitcoin-core-dev
193 2018-10-23T15:18:56  *** atroxes_ has joined #bitcoin-core-dev
194 2018-10-23T15:19:45  *** jarthur has joined #bitcoin-core-dev
195 2018-10-23T15:20:25  *** atroxes has quit IRC
196 2018-10-23T15:20:26  *** atroxes_ is now known as atroxes
197 2018-10-23T15:32:46  *** klot has quit IRC
198 2018-10-23T15:33:30  *** promag has quit IRC
199 2018-10-23T15:34:59  *** klot has joined #bitcoin-core-dev
200 2018-10-23T15:36:07  *** klot has quit IRC
201 2018-10-23T15:36:35  *** klot has joined #bitcoin-core-dev
202 2018-10-23T15:37:37  *** klot has quit IRC
203 2018-10-23T15:38:02  *** klot has joined #bitcoin-core-dev
204 2018-10-23T15:39:07  *** klot has quit IRC
205 2018-10-23T15:39:33  *** klot has joined #bitcoin-core-dev
206 2018-10-23T15:40:37  *** klot has quit IRC
207 2018-10-23T15:40:52  *** timothy has quit IRC
208 2018-10-23T15:41:02  *** klot has joined #bitcoin-core-dev
209 2018-10-23T15:42:04  *** Randolf has quit IRC
210 2018-10-23T15:42:07  *** klot has quit IRC
211 2018-10-23T15:42:34  *** klot has joined #bitcoin-core-dev
212 2018-10-23T15:43:00  *** panako has quit IRC
213 2018-10-23T15:43:37  *** klot has quit IRC
214 2018-10-23T15:44:02  *** klot has joined #bitcoin-core-dev
215 2018-10-23T15:44:15  *** justan0theruser has quit IRC
216 2018-10-23T15:45:07  *** klot has quit IRC
217 2018-10-23T15:45:43  *** klot has joined #bitcoin-core-dev
218 2018-10-23T15:58:30  *** Mutter has joined #bitcoin-core-dev
219 2018-10-23T15:59:19  <Mutter> Hi
220 2018-10-23T16:03:40  *** Mutter has quit IRC
221 2018-10-23T16:05:42  *** Krellan has quit IRC
222 2018-10-23T16:08:44  *** wumpus has quit IRC
223 2018-10-23T16:09:10  *** promag has joined #bitcoin-core-dev
224 2018-10-23T16:10:39  *** laurentmt has joined #bitcoin-core-dev
225 2018-10-23T16:13:01  *** laurentmt has quit IRC
226 2018-10-23T16:14:01  *** sipa has quit IRC
227 2018-10-23T16:14:17  *** justan0theruser has joined #bitcoin-core-dev
228 2018-10-23T16:14:22  *** ircclient has joined #bitcoin-core-dev
229 2018-10-23T16:20:18  *** Krellan has joined #bitcoin-core-dev
230 2018-10-23T16:24:21  *** bitconner has joined #bitcoin-core-dev
231 2018-10-23T16:24:27  *** sipa has joined #bitcoin-core-dev
232 2018-10-23T16:28:36  *** bitconner has quit IRC
233 2018-10-23T16:33:11  *** promag has quit IRC
234 2018-10-23T16:33:54  *** mr_paz has quit IRC
235 2018-10-23T16:34:12  *** HASAN_K has joined #bitcoin-core-dev
236 2018-10-23T16:38:18  *** promag has joined #bitcoin-core-dev
237 2018-10-23T16:38:27  *** HASAN_K has quit IRC
238 2018-10-23T16:43:01  *** Murch has joined #bitcoin-core-dev
239 2018-10-23T16:44:23  *** Murch has quit IRC
240 2018-10-23T16:47:28  *** ircclient has quit IRC
241 2018-10-23T16:51:38  *** Murch has joined #bitcoin-core-dev
242 2018-10-23T16:57:08  *** ircclient has joined #bitcoin-core-dev
243 2018-10-23T16:57:22  <promag> wumpus not around?
244 2018-10-23T16:57:38  <ircclient> just messing with my IRC client
245 2018-10-23T16:57:47  *** ircclient is now known as wumpus
246 2018-10-23T16:57:47  <promag> kallewoof: I'd love some feedback on #14531
247 2018-10-23T16:57:49  <gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub
248 2018-10-23T16:57:52  <promag> :D
249 2018-10-23T16:58:04  <promag> please replace my PR on HP with 14531
250 2018-10-23T16:58:17  <promag> I think is more important to fix something first
251 2018-10-23T16:59:21  <wumpus> added
252 2018-10-23T17:00:58  *** jungly has quit IRC
253 2018-10-23T17:05:17  <promag> thanks
254 2018-10-23T17:06:02  <promag> also see #12842 (2 lines change) and #14518 (small change)
255 2018-10-23T17:06:05  <gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub
256 2018-10-23T17:06:06  <gribble> https://github.com/bitcoin/bitcoin/issues/14518 | rpc: Always throw in getblockstats if -txindex is required by promag · Pull Request #14518 · bitcoin/bitcoin · GitHub
257 2018-10-23T17:08:43  *** klot has quit IRC
258 2018-10-23T17:09:42  *** klot has joined #bitcoin-core-dev
259 2018-10-23T17:10:45  *** klot has quit IRC
260 2018-10-23T17:11:09  *** klot has joined #bitcoin-core-dev
261 2018-10-23T17:12:09  *** promag has quit IRC
262 2018-10-23T17:12:15  *** klot has quit IRC
263 2018-10-23T17:12:40  *** klot has joined #bitcoin-core-dev
264 2018-10-23T17:13:26  *** bitcoin-git has joined #bitcoin-core-dev
265 2018-10-23T17:13:26  <bitcoin-git> [bitcoin] jimpo opened pull request #14555: Move util files to directory (master...util-cleanup) https://github.com/bitcoin/bitcoin/pull/14555
266 2018-10-23T17:13:26  *** bitcoin-git has left #bitcoin-core-dev
267 2018-10-23T17:13:45  *** klot has quit IRC
268 2018-10-23T17:14:14  *** klot has joined #bitcoin-core-dev
269 2018-10-23T17:15:15  *** klot has quit IRC
270 2018-10-23T17:15:44  *** klot has joined #bitcoin-core-dev
271 2018-10-23T17:16:45  *** klot has quit IRC
272 2018-10-23T17:17:13  *** klot has joined #bitcoin-core-dev
273 2018-10-23T17:18:15  *** klot has quit IRC
274 2018-10-23T17:18:43  *** klot has joined #bitcoin-core-dev
275 2018-10-23T17:19:42  *** bitconner has joined #bitcoin-core-dev
276 2018-10-23T17:19:45  *** klot has quit IRC
277 2018-10-23T17:20:09  *** klot has joined #bitcoin-core-dev
278 2018-10-23T17:21:15  *** klot has quit IRC
279 2018-10-23T17:21:39  *** klot has joined #bitcoin-core-dev
280 2018-10-23T17:22:45  *** klot has quit IRC
281 2018-10-23T17:23:13  *** klot has joined #bitcoin-core-dev
282 2018-10-23T17:24:09  *** bitconner has quit IRC
283 2018-10-23T17:24:15  *** klot has quit IRC
284 2018-10-23T17:24:44  *** klot has joined #bitcoin-core-dev
285 2018-10-23T17:25:45  *** klot has quit IRC
286 2018-10-23T17:26:12  *** klot has joined #bitcoin-core-dev
287 2018-10-23T17:27:15  *** klot has quit IRC
288 2018-10-23T17:27:42  *** klot has joined #bitcoin-core-dev
289 2018-10-23T17:28:43  *** Sinclai__ has joined #bitcoin-core-dev
290 2018-10-23T17:28:45  *** klot has quit IRC
291 2018-10-23T17:29:09  *** klot has joined #bitcoin-core-dev
292 2018-10-23T17:30:15  *** klot has quit IRC
293 2018-10-23T17:30:43  *** klot has joined #bitcoin-core-dev
294 2018-10-23T17:31:21  *** Sinclair6 has quit IRC
295 2018-10-23T17:31:45  *** klot has quit IRC
296 2018-10-23T17:32:12  *** klot has joined #bitcoin-core-dev
297 2018-10-23T17:33:15  *** klot has quit IRC
298 2018-10-23T17:33:21  *** Murch has quit IRC
299 2018-10-23T17:33:42  *** klot has joined #bitcoin-core-dev
300 2018-10-23T17:37:08  *** Krellan has quit IRC
301 2018-10-23T17:42:10  *** Murch has joined #bitcoin-core-dev
302 2018-10-23T17:49:12  *** rafalcpp_ is now known as rafalcpp
303 2018-10-23T18:15:32  *** bitconner has joined #bitcoin-core-dev
304 2018-10-23T18:20:28  *** bitconner has quit IRC
305 2018-10-23T18:27:21  <stevenroose> Anyone here any experience with the Travis tests? We copied them for Elements and the one with NOWALLET=1 times out consistently. Could anyone tell what the NOWALLET=1 exactly involves?
306 2018-10-23T18:28:33  *** owowo has quit IRC
307 2018-10-23T18:34:18  *** owowo has joined #bitcoin-core-dev
308 2018-10-23T18:58:04  *** zxzzt has joined #bitcoin-core-dev
309 2018-10-23T19:06:20  *** Aaronvan_ has joined #bitcoin-core-dev
310 2018-10-23T19:09:07  *** AaronvanW has quit IRC
311 2018-10-23T19:11:33  *** klot has quit IRC
312 2018-10-23T19:11:36  <jamesob> when's the last time someone proposed a "trace"-level logger that wouldn't ever be enabled for production, but might be useful during testing/debugging
313 2018-10-23T19:11:47  *** klot has joined #bitcoin-core-dev
314 2018-10-23T19:15:46  *** reallll has joined #bitcoin-core-dev
315 2018-10-23T19:16:19  *** klot has quit IRC
316 2018-10-23T19:19:16  *** belcher_ has quit IRC
317 2018-10-23T19:28:43  *** hebasto has quit IRC
318 2018-10-23T19:28:58  *** reallll is now known as belcher_
319 2018-10-23T19:29:04  *** hebasto has joined #bitcoin-core-dev
320 2018-10-23T19:29:55  *** bitcoin-git has joined #bitcoin-core-dev
321 2018-10-23T19:29:55  <bitcoin-git> [bitcoin] hebasto opened pull request #14556: qt: Fix bug #13299 (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
322 2018-10-23T19:29:55  *** bitcoin-git has left #bitcoin-core-dev
323 2018-10-23T19:30:19  <BlueMatt> jamesob: isnt that kinda what -debug=1 means?
324 2018-10-23T19:30:27  <BlueMatt> I mean it prints all your inbound/outbound messages...
325 2018-10-23T19:40:11  <jamesob> yeah, suppose so - but we're missing a lot of logging around tx validation and peer treatment
326 2018-10-23T19:41:31  <BlueMatt> fair enough, probably worth adding? Could add another debug category if its too voluminous
327 2018-10-23T19:58:54  *** dqx_ has joined #bitcoin-core-dev
328 2018-10-23T20:02:54  *** OzPac has quit IRC
329 2018-10-23T20:03:22  *** bitconner has joined #bitcoin-core-dev
330 2018-10-23T20:08:28  *** bitconner has quit IRC
331 2018-10-23T20:14:36  <jamesob> yup, sounds good
332 2018-10-23T20:14:48  <phantomcircuit> jamesob, there could certainly be many more log lines
333 2018-10-23T20:15:03  <phantomcircuit> but not that even when you're not logging things the LogPrint function takes some time
334 2018-10-23T20:18:59  <sipa> phantomcircuit: note that LogPrintf doesn't serialize its arguments when the debug category it's on is not enabled
335 2018-10-23T20:19:03  <sipa> but the argument are evaluated
336 2018-10-23T20:23:52  <wumpus> there's intentionally little/no debug logging around transaction validation, it would just be too spammy and confusing for users as it'd log for every transaction received from the network
337 2018-10-23T20:23:56  *** shesek has joined #bitcoin-core-dev
338 2018-10-23T20:24:10  <wumpus> but yes I guess it'd work as a separate category…
339 2018-10-23T20:26:03  <phantomcircuit> sipa, yeah it's very fast, but putting it in a tight loop would be a mistake
340 2018-10-23T20:26:52  <gmaxwell> Anyone attempting that should be prepared to prove the change doesn't substantially lower performance when not in use.
341 2018-10-23T20:29:42  <phantomcircuit> i wonder if checking for the category TRACE and then exiting unless compile time option was set would allow optimization out completely
342 2018-10-23T20:34:23  *** mr_paz has joined #bitcoin-core-dev
343 2018-10-23T20:37:18  <sipa> phantomcircuit: yeah certainly
344 2018-10-23T20:46:18  <jamesob> phantomcircuit: that's what I had in mind
345 2018-10-23T20:46:33  *** Victorsueca has quit IRC
346 2018-10-23T20:47:24  <jamesob> TraceLogPrintf as a macro that gets expanded or not based on configure options
347 2018-10-23T20:47:49  *** Victorsueca has joined #bitcoin-core-dev
348 2018-10-23T20:49:14  <sipa> jamesob: we kindof have that, due to the templated approach that forwards the arguments
349 2018-10-23T20:49:35  <sipa> though it would require inlining the function to guarantee the arguments aren't evaluated when needed
350 2018-10-23T20:50:14  <luke-jr> #define LogTrace(…) if (unlikely(g_trace)) { LogPrintf(__VA_ARGS__); }
351 2018-10-23T20:50:16  <luke-jr> maybe
352 2018-10-23T20:54:41  <sipa> that has the risk of removing statements with side effects, though
353 2018-10-23T20:55:14  <sipa> marking LogPrintf as __attribute__((always_inline)) where permitted is probably safer
354 2018-10-23T20:55:23  <sipa> (or whatever the syntax is)
355 2018-10-23T20:58:36  *** promag has joined #bitcoin-core-dev
356 2018-10-23T21:03:27  *** hebasto has quit IRC
357 2018-10-23T21:04:09  *** hebasto has joined #bitcoin-core-dev
358 2018-10-23T21:12:05  *** intcat has quit IRC
359 2018-10-23T21:15:53  *** intcat has joined #bitcoin-core-dev
360 2018-10-23T21:52:26  <luke-jr> sipa: hopefully nobody would use these new things with side-effect stuff.. especially if it's disabled by default
361 2018-10-23T21:52:51  <luke-jr> would always_inline actually avoid evaluating the arguments?
362 2018-10-23T21:53:27  <sipa> sometimes, sure
363 2018-10-23T21:53:50  <sipa> it'd enable the compiler to optimize it out when it provably has no side effectd
364 2018-10-23T21:55:38  <luke-jr> proving no side effects can be hard for C++
365 2018-10-23T21:55:55  <luke-jr> eg, a copy constructor might have side effects
366 2018-10-23T21:56:16  <luke-jr> but maybe the variadic argument situation is better, dunno
367 2018-10-23T21:58:21  <sipa> luke-jr: a c++ compiler is allowed to elide copy constructors even if they have side effects :)
368 2018-10-23T21:58:27  <luke-jr> interesting
369 2018-10-23T21:58:45  <sipa> https://en.cppreference.com/w/cpp/language/copy_elision
370 2018-10-23T21:58:46  * luke-jr ponders if there's any way to abuse that for something useful
371 2018-10-23T21:59:03  <sipa> since c++17 it's mandatory that where possible, that elision must happen
372 2018-10-23T21:59:21  *** hebasto has quit IRC
373 2018-10-23T21:59:34  <sipa> before, it was optional, and thus could result in different behaviour depending on the compiler's choice
374 2018-10-23T22:00:03  <sipa> i believe it's the only exception to the rule that optimizations are only allowed when they don't change observable behavior
375 2018-10-23T22:01:04  <gmaxwell> this sort of stuff where side effects vanish presents the same kind of risk as the assert macro with -UDEBUG.
376 2018-10-23T22:01:21  <gmaxwell> (refering to the trace discussion, not copy constructors)
377 2018-10-23T22:01:33  *** hebasto has joined #bitcoin-core-dev
378 2018-10-23T22:02:24  *** spinza has quit IRC
379 2018-10-23T22:02:50  <sipa> actually i expect that log statements have a relatively low chance of accidentally having side effects
380 2018-10-23T22:03:19  <sipa> things like assert(OperationIsSuccessful(bla)); isn't too crazy however
381 2018-10-23T22:03:21  *** rodarmor has joined #bitcoin-core-dev
382 2018-10-23T22:09:16  *** Guyver2 has quit IRC
383 2018-10-23T22:17:35  *** bitcoin-git has joined #bitcoin-core-dev
384 2018-10-23T22:17:35  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3f377daaa86...3668bb335c6a
385 2018-10-23T22:17:36  <bitcoin-git> bitcoin/master c269209 John Newbery: [tests] Small fixups before deprecating generate...
386 2018-10-23T22:17:36  <bitcoin-git> bitcoin/master aab8172 John Newbery: [tests] Add generate method to TestNode...
387 2018-10-23T22:17:37  <bitcoin-git> bitcoin/master c9f0295 John Newbery: [wallet] Deprecate the generate RPC method
388 2018-10-23T22:17:37  *** bitcoin-git has left #bitcoin-core-dev
389 2018-10-23T22:18:57  *** bitcoin-git has joined #bitcoin-core-dev
390 2018-10-23T22:18:57  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14468: [wallet] Deprecate generate RPC method (master...deprecate_generate) https://github.com/bitcoin/bitcoin/pull/14468
391 2018-10-23T22:18:57  *** bitcoin-git has left #bitcoin-core-dev
392 2018-10-23T22:18:57  *** justan0theruser has quit IRC
393 2018-10-23T22:24:18  *** spinza has joined #bitcoin-core-dev
394 2018-10-23T22:27:01  *** justanotheruser has joined #bitcoin-core-dev
395 2018-10-23T22:28:22  <gmaxwell> sipa: do you think that log statements and asserts are really a lot different there?
396 2018-10-23T22:28:57  <gmaxwell> LogPrint("tx: %s Valid: %d\n", tx.hash(), ProcessTx(tx));
397 2018-10-23T22:32:18  *** Sinclair6 has joined #bitcoin-core-dev
398 2018-10-23T22:32:26  *** michaelsdunn1 has quit IRC
399 2018-10-23T22:32:58  <sipa> gmaxwell: hmm, i guess i've just encountered those less
400 2018-10-23T22:33:06  <sipa> it depends a lot on developer culture i guess
401 2018-10-23T22:33:19  <gmaxwell> well that's /the/ assert mistake.
402 2018-10-23T22:35:59  *** Sinclai__ has quit IRC
403 2018-10-23T22:38:45  *** Aaronvan_ has quit IRC
404 2018-10-23T22:39:10  *** spinza has quit IRC
405 2018-10-23T22:45:40  *** hebasto has quit IRC
406 2018-10-23T22:48:10  *** Murch has quit IRC
407 2018-10-23T22:55:55  *** AaronvanW has joined #bitcoin-core-dev
408 2018-10-23T23:05:47  *** bitcoin-git has joined #bitcoin-core-dev
409 2018-10-23T23:05:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3668bb335c6a...94cf1ec94821
410 2018-10-23T23:05:48  <bitcoin-git> bitcoin/master d4d70ed Eric Scrivner: Fix listreceivedbyaddress not taking address as a string...
411 2018-10-23T23:05:49  <bitcoin-git> bitcoin/master 94cf1ec MarcoFalke: Merge #14417: Fix listreceivedbyaddress not taking address as a string...
412 2018-10-23T23:05:49  *** bitcoin-git has left #bitcoin-core-dev
413 2018-10-23T23:06:48  *** bitcoin-git has joined #bitcoin-core-dev
414 2018-10-23T23:06:48  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14417: Fix listreceivedbyaddress not taking address as a string (master...fix-rpc-calls-not-taking-valid-strings) https://github.com/bitcoin/bitcoin/pull/14417
415 2018-10-23T23:06:48  *** bitcoin-git has left #bitcoin-core-dev
416 2018-10-23T23:08:03  *** spinza has joined #bitcoin-core-dev
417 2018-10-23T23:19:01  *** intcat has quit IRC
418 2018-10-23T23:21:25  *** intcat has joined #bitcoin-core-dev
419 2018-10-23T23:31:12  *** bitconner has joined #bitcoin-core-dev
420 2018-10-23T23:33:27  *** jarthur_ has joined #bitcoin-core-dev
421 2018-10-23T23:37:01  *** Squidicuz has quit IRC
422 2018-10-23T23:37:03  *** jarthur has quit IRC
423 2018-10-23T23:37:14  *** Squidicuz has joined #bitcoin-core-dev
424 2018-10-23T23:38:09  *** jarthur_ has quit IRC
425 2018-10-23T23:38:51  *** intcat has quit IRC
426 2018-10-23T23:42:50  *** intcat has joined #bitcoin-core-dev
427 2018-10-23T23:43:20  *** Emcy_ has joined #bitcoin-core-dev
428 2018-10-23T23:44:31  *** Emcy has quit IRC
429 2018-10-23T23:48:42  *** jarthur has joined #bitcoin-core-dev
430 2018-10-23T23:49:42  *** bitconner has quit IRC