12018-11-01T00:02:11  *** jarthur has joined #bitcoin-core-dev
  22018-11-01T00:06:41  *** laurentmt has quit IRC
  32018-11-01T00:13:15  *** jarthur has quit IRC
  42018-11-01T00:14:32  *** jarthur has joined #bitcoin-core-dev
  52018-11-01T00:25:37  *** bitcoin-git has joined #bitcoin-core-dev
  62018-11-01T00:25:38  <bitcoin-git> [bitcoin] dongcarl opened pull request #14625: Make clear function argument case in dev notes (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14625
  72018-11-01T00:25:38  *** bitcoin-git has left #bitcoin-core-dev
  82018-11-01T00:26:36  *** jarthur has quit IRC
  92018-11-01T00:28:44  <sipa> dongcarl: not just because nobody has gotten around to fix them; PRs which only change style are not permitted
 102018-11-01T00:29:23  <sipa> more because that code hasn't been rewritten since
 112018-11-01T00:29:49  <dongcarl> sipa: good to know! So usually style changes are packaged with actual changes?
 122018-11-01T00:30:11  <sipa> yes
 132018-11-01T00:30:16  <sipa> dongcarl: it's in the developer notes :)
 142018-11-01T00:30:49  <sipa> Various coding styles have been used during the history of the codebase, and the result is not very consistent. However, we're now trying to converge to a single style, which is specified below. When writing patches, favor the new style over attempting to mimic the surrounding style, except for move-only commits.
 152018-11-01T00:30:55  <sipa> Do not submit patches solely to modify the style of existing code.
 162018-11-01T00:31:52  <dongcarl> Haha k I might bundle in some style changes for the files I’ve touched for Banman
 172018-11-01T00:32:31  <sipa> don't "bundle"
 182018-11-01T00:32:37  <sipa> just use the new style when writing new code
 192018-11-01T00:33:59  <dongcarl> Right, okay, in that case what I have now should be sufficient
 202018-11-01T00:34:56  <sipa> dongcarl: first line in your patch already violates it :p
 212018-11-01T00:35:46  <sipa> seems that's also almost the only one
 222018-11-01T00:35:51  * dongcarl is ashamed
 232018-11-01T00:39:32  <sipa> :p
 242018-11-01T00:40:32  *** bitcoin-git has joined #bitcoin-core-dev
 252018-11-01T00:40:33  <bitcoin-git> [bitcoin] sipa opened pull request #14626: Select orphan transaction uniformly for eviction (master...201810_uniform_orphan_eviction) https://github.com/bitcoin/bitcoin/pull/14626
 262018-11-01T00:40:33  *** bitcoin-git has left #bitcoin-core-dev
 272018-11-01T00:45:01  <gwillen> sipa: any suggestions for how I should proceed with https://github.com/bitcoin/bitcoin/pull/14588 ?
 282018-11-01T00:48:12  <sipa> gwillen: will review soon
 292018-11-01T00:49:14  <gwillen> ok, thanks! :-)
 302018-11-01T00:59:35  *** dviola has quit IRC
 312018-11-01T01:06:20  *** Ga1aCt1Cz00_ has quit IRC
 322018-11-01T01:06:45  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
 332018-11-01T01:22:42  *** Tralfaz has quit IRC
 342018-11-01T01:27:40  *** zrc has joined #bitcoin-core-dev
 352018-11-01T02:03:26  *** justanotheruser has joined #bitcoin-core-dev
 362018-11-01T02:06:25  *** lukedashjr has joined #bitcoin-core-dev
 372018-11-01T02:06:41  *** zrc has quit IRC
 382018-11-01T02:07:26  *** AaronvanW has quit IRC
 392018-11-01T02:07:43  *** luke-jr has quit IRC
 402018-11-01T02:11:05  *** lukedashjr is now known as luke-jr
 412018-11-01T02:17:52  *** AaronvanW has joined #bitcoin-core-dev
 422018-11-01T02:22:54  *** AaronvanW has quit IRC
 432018-11-01T02:38:34  <warren> sipa: "<sipa> warren: BIP150/BIP151 just need a bit of entropy at connect time" ... but connect time is an event triggered by arbitrary network connections.
 442018-11-01T02:46:29  <sipa> warren: accepting a connection already requires orders of magnitude more work than generating a random number, even with a ridiculously slow RNG
 452018-11-01T02:47:29  <sipa> warren: stop freaking out; all i meant to say was that our RNG isn't fast compared to what is possible on state of the art, but it's more than enough for what we need, even taking things like encrypted connections into account
 462018-11-01T02:48:17  *** zrc has joined #bitcoin-core-dev
 472018-11-01T03:12:37  *** zrc has quit IRC
 482018-11-01T03:39:57  <warren> OK.
 492018-11-01T04:14:27  *** justanotheruser has quit IRC
 502018-11-01T04:22:05  *** bralyclow has quit IRC
 512018-11-01T04:23:11  *** justanotheruser has joined #bitcoin-core-dev
 522018-11-01T04:41:53  *** bitconner has quit IRC
 532018-11-01T04:43:47  *** schnerch_ has joined #bitcoin-core-dev
 542018-11-01T04:45:02  *** AaronvanW has joined #bitcoin-core-dev
 552018-11-01T04:46:27  *** schnerchi has quit IRC
 562018-11-01T04:49:45  *** AaronvanW has quit IRC
 572018-11-01T04:55:04  *** bitconner has joined #bitcoin-core-dev
 582018-11-01T05:00:27  *** pinkdragon has joined #bitcoin-core-dev
 592018-11-01T05:06:26  *** Victorsueca has quit IRC
 602018-11-01T05:07:37  *** Victorsueca has joined #bitcoin-core-dev
 612018-11-01T05:18:41  *** pinkdragon has quit IRC
 622018-11-01T05:52:35  *** josephni_ has joined #bitcoin-core-dev
 632018-11-01T06:05:16  *** josephnicholas has joined #bitcoin-core-dev
 642018-11-01T06:08:57  *** josephni_ has quit IRC
 652018-11-01T06:12:41  *** bitconner has quit IRC
 662018-11-01T06:38:02  *** rh0nj has quit IRC
 672018-11-01T06:38:20  *** tripleslash has quit IRC
 682018-11-01T06:42:40  *** tripleslash has joined #bitcoin-core-dev
 692018-11-01T06:46:28  *** AaronvanW has joined #bitcoin-core-dev
 702018-11-01T06:51:20  *** Guest52531 is now known as iphelix
 712018-11-01T06:51:21  *** iphelix has joined #bitcoin-core-dev
 722018-11-01T06:51:46  *** AaronvanW has quit IRC
 732018-11-01T06:53:33  *** josephnicholas has quit IRC
 742018-11-01T07:01:07  *** josephnicholas has joined #bitcoin-core-dev
 752018-11-01T07:02:13  *** IGHOR has quit IRC
 762018-11-01T07:04:11  *** josephnicholas has quit IRC
 772018-11-01T07:20:58  *** hebasto has joined #bitcoin-core-dev
 782018-11-01T07:57:07  *** ezzzy has joined #bitcoin-core-dev
 792018-11-01T08:02:08  *** IGHOR has joined #bitcoin-core-dev
 802018-11-01T08:02:58  *** Cory has quit IRC
 812018-11-01T08:05:30  *** setpill has joined #bitcoin-core-dev
 822018-11-01T08:06:51  *** josephnicholas has joined #bitcoin-core-dev
 832018-11-01T08:08:29  *** bitconner has joined #bitcoin-core-dev
 842018-11-01T08:09:42  *** Cory has joined #bitcoin-core-dev
 852018-11-01T08:13:24  *** bitconner has quit IRC
 862018-11-01T08:24:21  *** rex4539 has quit IRC
 872018-11-01T08:36:34  *** rhavar has quit IRC
 882018-11-01T08:40:14  *** Victorsueca has quit IRC
 892018-11-01T08:41:24  *** Victorsueca has joined #bitcoin-core-dev
 902018-11-01T08:41:41  *** spinza has quit IRC
 912018-11-01T08:49:39  *** IGHOR has quit IRC
 922018-11-01T08:55:51  *** AaronvanW has joined #bitcoin-core-dev
 932018-11-01T08:56:44  *** spinza has joined #bitcoin-core-dev
 942018-11-01T08:57:07  *** rh0nj has joined #bitcoin-core-dev
 952018-11-01T08:57:57  *** bitcoin-git has joined #bitcoin-core-dev
 962018-11-01T08:57:58  <bitcoin-git> [bitcoin] merland closed pull request #14553: [wip] qt: Fix wrong unit on hourly progress increase (master...progress-increase-per-h) https://github.com/bitcoin/bitcoin/pull/14553
 972018-11-01T08:57:58  *** bitcoin-git has left #bitcoin-core-dev
 982018-11-01T09:29:22  *** bitcoin-git has joined #bitcoin-core-dev
 992018-11-01T09:29:23  <bitcoin-git> [bitcoin] murrayn opened pull request #14628: Trivial: Rename misleading 'defaultPort' to 'rpc_port' (master...rpc_port) https://github.com/bitcoin/bitcoin/pull/14628
1002018-11-01T09:29:23  *** bitcoin-git has left #bitcoin-core-dev
1012018-11-01T09:31:25  *** josephnicholas has quit IRC
1022018-11-01T09:52:32  *** josephnicholas has joined #bitcoin-core-dev
1032018-11-01T09:58:27  *** josephnicholas has quit IRC
1042018-11-01T10:07:27  *** rex4539 has joined #bitcoin-core-dev
1052018-11-01T10:08:38  *** bitconner has joined #bitcoin-core-dev
1062018-11-01T10:08:54  <wumpus> phantomcircuit: looking at it
1072018-11-01T10:13:09  *** bitconner has quit IRC
1082018-11-01T10:19:02  *** josephnicholas has joined #bitcoin-core-dev
1092018-11-01T10:30:31  *** rex4539 has quit IRC
1102018-11-01T10:39:50  *** spinza has quit IRC
1112018-11-01T10:50:08  *** spinza has joined #bitcoin-core-dev
1122018-11-01T11:01:13  *** wxss has joined #bitcoin-core-dev
1132018-11-01T11:14:38  *** owowo has joined #bitcoin-core-dev
1142018-11-01T11:50:28  *** justanotheruser has quit IRC
1152018-11-01T12:03:23  *** phwalkr has joined #bitcoin-core-dev
1162018-11-01T12:03:42  *** phwalkr has joined #bitcoin-core-dev
1172018-11-01T12:08:54  *** bitconner has joined #bitcoin-core-dev
1182018-11-01T12:12:29  *** shesek has joined #bitcoin-core-dev
1192018-11-01T12:13:07  *** bitconner has quit IRC
1202018-11-01T12:15:35  *** josephnicholas has quit IRC
1212018-11-01T12:17:29  *** Victorsueca has quit IRC
1222018-11-01T12:18:39  *** Victorsueca has joined #bitcoin-core-dev
1232018-11-01T12:31:12  *** AaronvanW has quit IRC
1242018-11-01T12:34:05  *** Jack_ has joined #bitcoin-core-dev
1252018-11-01T12:54:12  *** lightningbot has joined #bitcoin-core-dev
1262018-11-01T12:56:51  *** shesek has quit IRC
1272018-11-01T12:57:38  *** shesek has joined #bitcoin-core-dev
1282018-11-01T12:58:47  *** rh0nj has quit IRC
1292018-11-01T12:59:53  *** rh0nj has joined #bitcoin-core-dev
1302018-11-01T13:02:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1312018-11-01T13:07:54  *** owowo has quit IRC
1322018-11-01T13:12:22  *** echonaut15 has joined #bitcoin-core-dev
1332018-11-01T13:13:11  *** echonaut has quit IRC
1342018-11-01T13:14:00  *** josephnicholas has quit IRC
1352018-11-01T13:14:15  *** josephnicholas has joined #bitcoin-core-dev
1362018-11-01T13:14:17  <wumpus> can we get some reviews for #14532? at one point everyone seemed concerned about this issue, and not it just lingers
1372018-11-01T13:14:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
1382018-11-01T13:14:32  <wumpus> now*
1392018-11-01T13:14:36  *** owowo has joined #bitcoin-core-dev
1402018-11-01T13:24:14  *** wxss has quit IRC
1412018-11-01T13:25:05  *** josephnicholas has quit IRC
1422018-11-01T13:25:24  *** wxss has joined #bitcoin-core-dev
1432018-11-01T13:26:29  *** bitcoin-git has joined #bitcoin-core-dev
1442018-11-01T13:26:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b312579c69f1...d38a5092f17f
1452018-11-01T13:26:30  <bitcoin-git> bitcoin/master 0e6de3a Martin Erlandsson: added details about commit messages
1462018-11-01T13:26:31  <bitcoin-git> bitcoin/master d38a509 Wladimir J. van der Laan: Merge #14600: docs: Clarify commit message guidelines...
1472018-11-01T13:26:31  *** bitcoin-git has left #bitcoin-core-dev
1482018-11-01T13:27:47  *** bitcoin-git has joined #bitcoin-core-dev
1492018-11-01T13:27:47  <bitcoin-git> [bitcoin] laanwj closed pull request #14600: docs: Clarify commit message guidelines (master...update-contrib) https://github.com/bitcoin/bitcoin/pull/14600
1502018-11-01T13:27:47  *** bitcoin-git has left #bitcoin-core-dev
1512018-11-01T13:28:32  *** josephnicholas has joined #bitcoin-core-dev
1522018-11-01T13:29:44  *** josephnicholas has joined #bitcoin-core-dev
1532018-11-01T13:29:47  *** bitcoin-git has joined #bitcoin-core-dev
1542018-11-01T13:29:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d38a5092f17f...08a57d51e90c
1552018-11-01T13:29:48  <bitcoin-git> bitcoin/master cf2f430 fanquake: gui: explicitly disable "Dark Mode" appearance on macOS
1562018-11-01T13:29:49  <bitcoin-git> bitcoin/master 08a57d5 Wladimir J. van der Laan: Merge #14593: gui: explicitly disable "Dark Mode" appearance on macOS...
1572018-11-01T13:29:49  *** bitcoin-git has left #bitcoin-core-dev
1582018-11-01T13:30:53  *** bitcoin-git has joined #bitcoin-core-dev
1592018-11-01T13:30:53  <bitcoin-git> [bitcoin] laanwj closed pull request #14593: gui: explicitly disable "Dark Mode" appearance on macOS (master...macos-disable-darkmode) https://github.com/bitcoin/bitcoin/pull/14593
1602018-11-01T13:30:53  *** bitcoin-git has left #bitcoin-core-dev
1612018-11-01T13:33:27  *** josephnicholas has quit IRC
1622018-11-01T13:36:53  *** lnostdal has joined #bitcoin-core-dev
1632018-11-01T13:53:39  *** spinza has quit IRC
1642018-11-01T13:53:41  *** phwalkr has quit IRC
1652018-11-01T13:58:44  *** spinza has joined #bitcoin-core-dev
1662018-11-01T14:08:22  *** booyah has quit IRC
1672018-11-01T14:09:00  *** josephnicholas has joined #bitcoin-core-dev
1682018-11-01T14:09:04  *** booyah has joined #bitcoin-core-dev
1692018-11-01T14:09:10  *** bitconner has joined #bitcoin-core-dev
1702018-11-01T14:14:04  *** bitconner has quit IRC
1712018-11-01T14:14:05  *** josephnicholas has quit IRC
1722018-11-01T14:14:21  *** promag has joined #bitcoin-core-dev
1732018-11-01T14:18:27  *** promag has quit IRC
1742018-11-01T14:35:37  *** michaelsdunn1 has joined #bitcoin-core-dev
1752018-11-01T14:43:48  *** bitcoin-git has joined #bitcoin-core-dev
1762018-11-01T14:43:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/08a57d51e90c...6a095bc5f239
1772018-11-01T14:43:49  <bitcoin-git> bitcoin/master 4bd125f Chun Kuan Lee: tests: Print dots by default
1782018-11-01T14:43:50  <bitcoin-git> bitcoin/master 6a095bc MarcoFalke: Merge #14569: tests: Print dots by default in functional tests...
1792018-11-01T14:43:50  *** bitcoin-git has left #bitcoin-core-dev
1802018-11-01T14:45:02  *** bitcoin-git has joined #bitcoin-core-dev
1812018-11-01T14:45:03  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14569: tests: Print dots by default in functional tests (master...travis-avoid-timeout) https://github.com/bitcoin/bitcoin/pull/14569
1822018-11-01T14:45:03  *** bitcoin-git has left #bitcoin-core-dev
1832018-11-01T14:54:58  *** justanotheruser has joined #bitcoin-core-dev
1842018-11-01T14:59:25  *** bitcoin-git has joined #bitcoin-core-dev
1852018-11-01T14:59:26  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14630: test_runner: Remove travis specific code (master...Mf1811-testNoTravis) https://github.com/bitcoin/bitcoin/pull/14630
1862018-11-01T14:59:26  *** bitcoin-git has left #bitcoin-core-dev
1872018-11-01T15:03:20  *** setpill has quit IRC
1882018-11-01T15:05:32  *** bitcoin-git has joined #bitcoin-core-dev
1892018-11-01T15:05:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a095bc5f239...9899e65d84e7
1902018-11-01T15:05:34  <bitcoin-git> bitcoin/master 0a04667 Murray Nesbitt: FreeBSD: Document Python 3 requirement for 'gmake check'
1912018-11-01T15:05:34  <bitcoin-git> bitcoin/master 9899e65 Wladimir J. van der Laan: Merge #14617: FreeBSD: Document Python 3 requirement for 'gmake check'...
1922018-11-01T15:05:35  *** bitcoin-git has left #bitcoin-core-dev
1932018-11-01T15:07:04  *** bitcoin-git has joined #bitcoin-core-dev
1942018-11-01T15:07:04  <bitcoin-git> [bitcoin] laanwj closed pull request #14617: FreeBSD: Document Python 3 requirement for 'gmake check' (master...freebsd-test-doc) https://github.com/bitcoin/bitcoin/pull/14617
1952018-11-01T15:07:04  *** bitcoin-git has left #bitcoin-core-dev
1962018-11-01T15:10:30  *** bitcoin-git has joined #bitcoin-core-dev
1972018-11-01T15:10:30  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9899e65d84e7...f6df989842a1
1982018-11-01T15:10:31  <bitcoin-git> bitcoin/master f8c1714 Andrew Chow: Convert non-witness UTXOs to witness if witness sig created...
1992018-11-01T15:10:31  <bitcoin-git> bitcoin/master 862d159 Pieter Wuille: Add test for conversion from non-witness to witness UTXO
2002018-11-01T15:10:32  <bitcoin-git> bitcoin/master f6df989 Wladimir J. van der Laan: Merge #14197: [psbt] Convert non-witness UTXOs to witness if witness sig created...
2012018-11-01T15:10:32  *** bitcoin-git has left #bitcoin-core-dev
2022018-11-01T15:11:27  *** bitcoin-git has joined #bitcoin-core-dev
2032018-11-01T15:11:28  <bitcoin-git> [bitcoin] laanwj closed pull request #14197: [psbt] Convert non-witness UTXOs to witness if witness sig created (master...psbt-utxos) https://github.com/bitcoin/bitcoin/pull/14197
2042018-11-01T15:11:28  *** bitcoin-git has left #bitcoin-core-dev
2052018-11-01T15:12:27  *** bitcoin-git has joined #bitcoin-core-dev
2062018-11-01T15:12:28  <bitcoin-git> [bitcoin] jnewbery opened pull request #14631: [tests] Move deterministic address import to setup_nodes (master...deprecate_generate2) https://github.com/bitcoin/bitcoin/pull/14631
2072018-11-01T15:12:28  *** bitcoin-git has left #bitcoin-core-dev
2082018-11-01T15:18:02  *** bitcoin-git has joined #bitcoin-core-dev
2092018-11-01T15:18:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6df989842a1...f69d92299dea
2102018-11-01T15:18:04  <bitcoin-git> bitcoin/master fa77aaa MarcoFalke: doc: Add external interface consistency guarantees
2112018-11-01T15:18:04  <bitcoin-git> bitcoin/master f69d922 Wladimir J. van der Laan: Merge #14592: doc: Add external interface consistency guarantees...
2122018-11-01T15:18:05  *** bitcoin-git has left #bitcoin-core-dev
2132018-11-01T15:19:29  *** bitcoin-git has joined #bitcoin-core-dev
2142018-11-01T15:19:29  <bitcoin-git> [bitcoin] laanwj closed pull request #14592: doc: Add external interface consistency guarantees (master...Mf1810-docCon) https://github.com/bitcoin/bitcoin/pull/14592
2152018-11-01T15:19:29  *** bitcoin-git has left #bitcoin-core-dev
2162018-11-01T15:21:05  *** AaronvanW has quit IRC
2172018-11-01T15:26:42  *** bitcoin-git has joined #bitcoin-core-dev
2182018-11-01T15:26:43  <bitcoin-git> [bitcoin] fridokus opened pull request #14632: Tests: Fix a comment (master...typo_fix) https://github.com/bitcoin/bitcoin/pull/14632
2192018-11-01T15:26:43  *** bitcoin-git has left #bitcoin-core-dev
2202018-11-01T15:31:47  *** bitcoin-git has joined #bitcoin-core-dev
2212018-11-01T15:31:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f69d92299dea...5049f7f7a9e7
2222018-11-01T15:31:49  <bitcoin-git> bitcoin/master 9605bbd Carl Dong: Make clear function argument case in dev notes
2232018-11-01T15:31:50  <bitcoin-git> bitcoin/master 5049f7f Wladimir J. van der Laan: Merge #14625: Make clear function argument case in dev notes...
2242018-11-01T15:31:50  *** bitcoin-git has left #bitcoin-core-dev
2252018-11-01T15:33:29  *** bitcoin-git has joined #bitcoin-core-dev
2262018-11-01T15:33:29  <bitcoin-git> [bitcoin] laanwj closed pull request #14625: Make clear function argument case in dev notes (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14625
2272018-11-01T15:33:29  *** bitcoin-git has left #bitcoin-core-dev
2282018-11-01T15:34:09  <achow101> that's a lot of merges
2292018-11-01T15:36:05  <wumpus> yeh
2302018-11-01T15:44:42  *** AaronvanW has joined #bitcoin-core-dev
2312018-11-01T15:45:17  <achow101> wumpus: while you're at it, merge #14377?
2322018-11-01T15:45:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14377 | check that a separator is found for psbt inputs, outputs, and global map by achow101 · Pull Request #14377 · bitcoin/bitcoin · GitHub
2332018-11-01T16:08:22  *** ezzzy has quit IRC
2342018-11-01T16:09:20  *** bitconner has joined #bitcoin-core-dev
2352018-11-01T16:09:23  *** ExtraCrispy has joined #bitcoin-core-dev
2362018-11-01T16:13:04  *** IGHOR has joined #bitcoin-core-dev
2372018-11-01T16:13:57  *** bitconner has quit IRC
2382018-11-01T16:18:07  *** bralyclow has joined #bitcoin-core-dev
2392018-11-01T16:20:38  *** rhavar has joined #bitcoin-core-dev
2402018-11-01T16:21:06  *** shesek has quit IRC
2412018-11-01T16:25:12  *** Evel-Knievel has joined #bitcoin-core-dev
2422018-11-01T16:26:32  <sipa> MarcoFalke: idea for the conflict checker... have DrahtBot post a dummy comment on every PR as soon as it's opened, and then update that comment whenever needed
2432018-11-01T16:27:20  *** jarthur has joined #bitcoin-core-dev
2442018-11-01T16:35:46  <wumpus> that... sounds like a good idea
2452018-11-01T16:35:50  <wumpus> achow101: ok
2462018-11-01T16:36:13  <wumpus> could keep updating the same post instead of posting new ones would save on some mail
2472018-11-01T16:53:25  <luke-jr> sipa: that will break the email notifications :/
2482018-11-01T16:53:45  <luke-jr> (updating it sounds fine though)
2492018-11-01T16:54:56  <sipa> luke-jr: i don't think the email notifications are useful (they mostly mess up my workflow in trying to find recently updated PRs to review... and then realize that they haven't been touched in 2 months, but someone just opened a tiny refactor that conflicts with it)
2502018-11-01T16:55:11  <sipa> the "needs rebase" messages are kinda useful, i think
2512018-11-01T16:56:42  *** bitcoin-git has joined #bitcoin-core-dev
2522018-11-01T16:56:43  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5049f7f7a9e7...51e5ef3971c7
2532018-11-01T16:56:43  <bitcoin-git> bitcoin/master 4fb3388 Andrew Chow: check that a separator is found for psbt inputs, outputs, and global map
2542018-11-01T16:56:44  <bitcoin-git> bitcoin/master 51e5ef3 Wladimir J. van der Laan: Merge #14377: check that a separator is found for psbt inputs, outputs, and global map...
2552018-11-01T16:56:44  *** bitcoin-git has left #bitcoin-core-dev
2562018-11-01T16:57:42  *** bitcoin-git has joined #bitcoin-core-dev
2572018-11-01T16:57:42  <bitcoin-git> [bitcoin] laanwj closed pull request #14377: check that a separator is found for psbt inputs, outputs, and global map (master...fix-psbt-seps) https://github.com/bitcoin/bitcoin/pull/14377
2582018-11-01T16:57:42  *** bitcoin-git has left #bitcoin-core-dev
2592018-11-01T17:00:01  *** rh0nj has quit IRC
2602018-11-01T17:01:08  *** rh0nj has joined #bitcoin-core-dev
2612018-11-01T17:03:23  *** bralyclow has quit IRC
2622018-11-01T17:06:04  <luke-jr> sipa: I think the initial notification after opening might be useful to get the content emailed, I mean
2632018-11-01T17:06:34  <luke-jr> ie, just skip the dummy post
2642018-11-01T17:07:29  <wumpus> I don't think the email notifications for the bot are useful either
2652018-11-01T17:07:55  <wumpus> sure, the 'needs rebase' mail is useful for the author of the PR but not others subscribing to it
2662018-11-01T17:08:51  <wumpus> I think that's the crux, most of the information is aimed at the author but everyone somehow involved will get the mail, I get so much github notifications I can't pay much attention to them
2672018-11-01T17:09:12  <wumpus> (though I have notifications specifically tagging me sorted differently)
2682018-11-01T17:09:51  <sipa> i don't generally use the notifications at all; but at least "sort by recently updated" was useful before the bot :)
2692018-11-01T17:10:05  <luke-jr> hmm
2702018-11-01T17:10:18  <luke-jr> maybe the bot should hook in like Travis
2712018-11-01T17:10:37  *** bralyclow has joined #bitcoin-core-dev
2722018-11-01T17:11:20  <gmaxwell> breaking sort by recently updated has probably reduced the amount of review I do by 80%, FWIW.
2732018-11-01T17:11:41  <gmaxwell> as I'd typical go and sort by updated and check in on all the active PRs.
2742018-11-01T17:12:32  <wumpus> luke-jr: yes that would be preferable, but I do not know if github provides that functionality to random developers, lacking that, sipa's idea to post once then update is a good idea
2752018-11-01T17:13:18  <sipa> actually, a top comment that gets updated may not be enough to un-break it; the PRs that get newly referenced by another post's "conflicts with" will still be marked as recently updated
2762018-11-01T17:16:40  <gmaxwell> another alternative would be to just post some external thing with the real recently updated data.
2772018-11-01T17:16:52  <gmaxwell> e.g. go scrap github or new commits every couple hours and post a report somewhere.
2782018-11-01T17:17:07  <gmaxwell> scrape*
2792018-11-01T17:18:16  *** Chris_Stewart_5 has quit IRC
2802018-11-01T17:18:29  *** bralyclow has quit IRC
2812018-11-01T17:19:05  *** bralyclow has joined #bitcoin-core-dev
2822018-11-01T17:21:42  <wumpus> gmaxwell: ah yes kind of what bitcoinacks.com does
2832018-11-01T17:33:11  * gmaxwell quietly leaves https://www.silasreinagel.com/blog/2018/10/30/indirection-is-not-abstraction/ here
2842018-11-01T17:43:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2852018-11-01T17:46:19  *** jungly has quit IRC
2862018-11-01T17:47:36  <phantomcircuit> wumpus, thanks for reviewing
2872018-11-01T17:48:19  <wumpus> gmaxwell: looks interesting!
2882018-11-01T17:49:57  <MarcoFalke> hmm, just catching up on the bot review.
2892018-11-01T17:50:15  <MarcoFalke> I wasn't aware that people actually used the github sort by most recent change
2902018-11-01T17:50:25  <MarcoFalke> *update
2912018-11-01T17:51:16  <sipa> MarcoFalke: it's the only thing i use :)
2922018-11-01T17:51:42  *** ezzzy has joined #bitcoin-core-dev
2932018-11-01T17:51:47  <sipa> (but maybe others have different workflows)
2942018-11-01T17:51:48  <ryanofsky> posted feature request for bitcoin-acks: https://github.com/PierreRochard/bitcoin-acks/issues/78
2952018-11-01T17:52:06  <MarcoFalke> By moving the content somewhere else, I am worried no one will look at it.
2962018-11-01T17:52:28  <sipa> MarcoFalke: agree
2972018-11-01T17:52:42  <gmaxwell> it sounds like even without the bot the most recent update is kinda broken
2982018-11-01T17:52:52  <gmaxwell> the bot just makes it much worse.
2992018-11-01T17:52:55  <sipa> gmaxwell: how so?
3002018-11-01T17:53:15  <gmaxwell> you were saying above that it moves PRs to the top when they're mentioned in other PRs.
3012018-11-01T17:53:39  <MarcoFalke> I can definetly break the links with a url like https://drahtbot.github.io/bitcoin_issue_redirect/1111
3022018-11-01T17:53:39  <sipa> yeah, but that used to be pretty rare
3032018-11-01T17:53:44  <gmaxwell> (I don't recall that but I figure I wouldn't have noticed because it would have been infrequent)
3042018-11-01T17:54:09  <sipa> MarcoFalke: i think that would be useful if it's not too much work
3052018-11-01T17:54:36  <MarcoFalke> Should be ~zero work. Static html should be sufficient
3062018-11-01T17:55:13  <sipa> this is obviously some strange usage of the word zero that i wasn't previously aware of :)
3072018-11-01T17:55:42  <MarcoFalke> ~zero == about zero == little
3082018-11-01T17:58:23  <MarcoFalke> ryanofsky actually brought up the idea to have one comment per pull request that gets updated. That would be a bit more work, depending on how much I want to solve edit conflicts. (The bot runs in multiple processes)
3092018-11-01T17:58:47  <MarcoFalke> Also it'd mean more empty comments
3102018-11-01T17:59:13  <sipa> just one per PR
3112018-11-01T18:00:20  *** bitconner has joined #bitcoin-core-dev
3122018-11-01T18:01:36  <ryanofsky> i think it'd be nice if draftbot just claimed and kept updating the first comment in every pr. especially if it could tell you useful status information, like how many acks the pr has
3132018-11-01T18:02:37  <sipa> that would be great
3142018-11-01T18:02:45  <sipa> (but quite a bit of work i imagine)
3152018-11-01T18:03:49  <sipa> some review on #13501 would be welcome; it may fix some of the appveyor spurious failures
3162018-11-01T18:03:51  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
3172018-11-01T18:04:38  *** bitconner has quit IRC
3182018-11-01T18:09:24  *** bitconner has joined #bitcoin-core-dev
3192018-11-01T18:12:31  <jnewbery> MarcoFalke: sort-by-most-recent-change used to be the only thing I used, but it's mostly not very helpful now
3202018-11-01T18:13:27  *** bitconner has quit IRC
3212018-11-01T18:21:44  *** bitcoin-git has joined #bitcoin-core-dev
3222018-11-01T18:21:44  <bitcoin-git> [bitcoin] kostyantyn opened pull request #14633: Fix height serialization inside script of coinbase input (master...fix_height_serialization_in_coinbase) https://github.com/bitcoin/bitcoin/pull/14633
3232018-11-01T18:21:44  *** bitcoin-git has left #bitcoin-core-dev
3242018-11-01T18:27:34  <pierre_rochard> ryanofsky I added a question on the GH issue, for potential or current users of bitcoinacks: is "most-recent-change" preference to be the PR comment thread (excluding bots) or to the actual PR code?
3252018-11-01T18:27:56  *** lnostdal has quit IRC
3262018-11-01T18:28:27  *** rhavar has quit IRC
3272018-11-01T18:28:29  <pierre_rochard> I can do both, I just want to avoid making the table wider than it already is if one is clearly more useful for reviewers
3282018-11-01T18:28:39  *** promag has joined #bitcoin-core-dev
3292018-11-01T18:34:30  *** laurentmt has joined #bitcoin-core-dev
3302018-11-01T18:36:46  *** Tralfaz has joined #bitcoin-core-dev
3312018-11-01T18:37:29  *** Tralfaz has quit IRC
3322018-11-01T18:37:56  *** Tralfaz has joined #bitcoin-core-dev
3332018-11-01T18:38:26  *** laurentmt has quit IRC
3342018-11-01T18:38:58  *** grubles has quit IRC
3352018-11-01T18:41:52  *** bitcoin-git has joined #bitcoin-core-dev
3362018-11-01T18:41:53  <bitcoin-git> [bitcoin] JBaczuk closed pull request #14610: Docs: correction to test readme compile instructions (master...fix_test_readme_compile_instructions) https://github.com/bitcoin/bitcoin/pull/14610
3372018-11-01T18:41:53  *** bitcoin-git has left #bitcoin-core-dev
3382018-11-01T18:53:18  <MarcoFalke> See for example https://github.com/bitcoin/bitcoin/pull/14630#issuecomment-435107340 with the new redirect url
3392018-11-01T18:53:25  <MarcoFalke> Let me know if it doesn't work for anyone
3402018-11-01T18:56:36  *** bralyclo_ has joined #bitcoin-core-dev
3412018-11-01T18:59:16  <provoostenator> Ok, so I can confirm the meeting time sucks for Asia :-) But we already tried the poll thing. Back in Europe now.
3422018-11-01T19:00:03  <MarcoFalke> huh, though I wonder if GitHub will update the "last-updated" when I edit (the first) or any comment
3432018-11-01T19:00:54  *** bralyclow has quit IRC
3442018-11-01T19:00:55  <MarcoFalke> meat thing?
3452018-11-01T19:01:26  <jnewbery> wumpus ^
3462018-11-01T19:01:42  <achow101> meat?
3472018-11-01T19:01:44  <jnewbery> summer time is over
3482018-11-01T19:01:47  <MarcoFalke> https://www.google.com/search?q=time+in+rejkjavik
3492018-11-01T19:01:49  <MarcoFalke> 7pm
3502018-11-01T19:01:53  <jnewbery> (in europe)
3512018-11-01T19:02:58  <provoostenator> Summer time might even be permanently over in some parts of Europe
3522018-11-01T19:03:10  <achow101> when does dst end in the us?
3532018-11-01T19:03:15  <jnewbery> this sunday
3542018-11-01T19:03:53  <jcorgan> in some parts of europe the idea of summer is merely a theoretical construct anyway
3552018-11-01T19:04:17  <sipa> #startmeeting
3562018-11-01T19:04:17  <lightningbot> Meeting started Thu Nov  1 19:04:17 2018 UTC.  The chair is sipa. Information about MeetBot at http://wiki.debian.org/MeetBot.
3572018-11-01T19:04:17  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3582018-11-01T19:04:30  <instagibbs> hi
3592018-11-01T19:04:33  <sipa> topics?
3602018-11-01T19:04:35  <MarcoFalke> hi
3612018-11-01T19:04:41  <jnewbery> hi
3622018-11-01T19:04:49  <luke-jr> suggested topic: do we have a way to test non-HD wallet code paths at this point? :/
3632018-11-01T19:04:50  <MarcoFalke> Could someone do the ping string?
3642018-11-01T19:05:05  <jnewbery> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
3652018-11-01T19:05:08  <MarcoFalke> suggested topic: High priority for review
3662018-11-01T19:05:08  <provoostenator> Topic suggesiton: wallet refactor progress
3672018-11-01T19:05:09  <MarcoFalke> thx
3682018-11-01T19:05:10  <jnewbery> that one?
3692018-11-01T19:05:14  <sipa> thanks jnewbery
3702018-11-01T19:05:27  <sipa> #topic high priority for review
3712018-11-01T19:05:31  <sipa> let's start with that one
3722018-11-01T19:05:44  <achow101> we should make a gribble command for the meeting ping
3732018-11-01T19:06:05  <sipa> on the list are #14532 #14350 #14046
3742018-11-01T19:06:07  <gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
3752018-11-01T19:06:09  <gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub
3762018-11-01T19:06:13  <gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub
3772018-11-01T19:06:54  <sipa> anyone wants to add/remove something?
3782018-11-01T19:06:56  <meshcollider> Hi
3792018-11-01T19:07:00  <kanzure> hi.
3802018-11-01T19:07:11  <achow101> can I get #13932 on hi prio?
3812018-11-01T19:07:13  <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
3822018-11-01T19:07:16  <achow101> I'll rebase it today
3832018-11-01T19:07:56  <phantomcircuit> hello
3842018-11-01T19:07:58  <luke-jr> usually hi-prio requires up-to-date-base before being added, but no reason it needs to be added during meetings
3852018-11-01T19:08:09  <sipa> achow101: yeah, ping me when rebased
3862018-11-01T19:08:14  <MarcoFalke> I'd like to propose #14437 if ryanofsky commits to rebasing it
3872018-11-01T19:08:18  <gribble> https://github.com/bitcoin/bitcoin/issues/14437 | Refactor: Start to separate wallet from node by ryanofsky · Pull Request #14437 · bitcoin/bitcoin · GitHub
3882018-11-01T19:08:59  <provoostenator> ^ good idea, this new PR is much smaller than the original and a good start
3892018-11-01T19:09:25  <sipa> i'd like to add #14477
3902018-11-01T19:09:27  <gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
3912018-11-01T19:09:54  <provoostenator> ^ works for me
3922018-11-01T19:10:11  <phantomcircuit> i believe #14336 is done and needs more eyeballs
3932018-11-01T19:10:13  <sipa> done
3942018-11-01T19:10:14  <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
3952018-11-01T19:10:24  <sipa> ryanofsky: happy to put on the list if up to date
3962018-11-01T19:10:28  <sipa> phantomcircuit: ack
3972018-11-01T19:10:44  <provoostenator> It also needs a more appealing description.
3982018-11-01T19:10:56  <phantomcircuit> provoostenator, true
3992018-11-01T19:10:59  <sipa> agree, but let's not do review in this meeting
4002018-11-01T19:11:13  <MarcoFalke> Added #14437 and #14477
4012018-11-01T19:11:15  <gribble> https://github.com/bitcoin/bitcoin/issues/14437 | Refactor: Start to separate wallet from node by ryanofsky · Pull Request #14437 · bitcoin/bitcoin · GitHub
4022018-11-01T19:11:16  <achow101> sipa: rebased it
4032018-11-01T19:11:17  <gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub
4042018-11-01T19:11:20  <provoostenator> No, that was more a general suggestion, some PR's have quite poor descriptions.
4052018-11-01T19:11:50  <sipa> phantomcircuit: added to the list
4062018-11-01T19:12:34  <sipa> achow101: done
4072018-11-01T19:12:38  <sipa> ok
4082018-11-01T19:12:45  <meshcollider> sipa: btw I realise 14477 duplicates the addition of solvable to getaddressinfo
4092018-11-01T19:12:47  <luke-jr> provoostenator: more annoying is the intentionally confusing titles IMO :/
4102018-11-01T19:12:52  <sipa> #topic do we have a way to test non-HD wallet code paths at this point?
4112018-11-01T19:13:04  *** phwalkr has joined #bitcoin-core-dev
4122018-11-01T19:13:06  <sipa> luke-jr: ^
4132018-11-01T19:13:07  *** phwalkr has quit IRC
4142018-11-01T19:13:21  <luke-jr> yeah, it looks like -usehd removal just removed the tests :/
4152018-11-01T19:13:33  <luke-jr> and I think it should get tested
4162018-11-01T19:13:49  <provoostenator> Easiest solution might be just add a legacy wallet payload to the functional test suite and then load that.
4172018-11-01T19:13:53  <achow101> there's no way to create a non-hd wallet, so they can't be tested unless a non-hd wallet is put into the test data
4182018-11-01T19:14:02  <sipa> phantomcircuit: seems reasonable to me
4192018-11-01T19:14:06  <MarcoFalke> sipa: Any reason why you added 13932 to "For backport" in high priority?
4202018-11-01T19:14:06  <sipa> eh, provoostenator ^
4212018-11-01T19:14:17  <MarcoFalke> It is tagged with 0.18.0
4222018-11-01T19:14:18  <luke-jr> good idea, didn't think of that
4232018-11-01T19:14:36  <provoostenator> Dynamic wallet loading feature is quite handy.
4242018-11-01T19:14:38  <sipa> MarcoFalke: did i?
4252018-11-01T19:14:50  <sipa> oh, indeed; fixed
4262018-11-01T19:15:07  <luke-jr> or github did and attributed it to you? XD
4272018-11-01T19:15:09  <gwillen> I would love for #14588 to get looked at, I don't know what the criteria for high priority are. :-) I did just rebase it.
4282018-11-01T19:15:10  <gribble> https://github.com/bitcoin/bitcoin/issues/14588 | Refactor PSBT signing logic to enforce invariant and fix signing bug by gwillen · Pull Request #14588 · bitcoin/bitcoin · GitHub
4292018-11-01T19:15:35  <MarcoFalke> on topic: The way to test legacy wallet paths is #14536
4302018-11-01T19:15:35  <gribble> https://github.com/bitcoin/bitcoin/issues/14536 | functional test with ancient wallet.dat (upgrade test) · Issue #14536 · bitcoin/bitcoin · GitHub
4312018-11-01T19:15:44  <sipa> gwillen: every active contributor gets to nominate one PR they want to encourage others to look at, because it is blocking their own work
4322018-11-01T19:15:56  <jnewbery> lukejr: see also https://github.com/bitcoin/bitcoin/pull/12134#issuecomment-430107394 . Having some different version wallet payloads in the test framework would be generally useful
4332018-11-01T19:16:10  <sipa> yes, i agree
4342018-11-01T19:16:38  <sipa> we do not care about the ability to create such wallets anymore, but as long as they're supported we should test them - especially we should test upgrade scenarios
4352018-11-01T19:16:38  <jnewbery> ah, thanks Marco. I'll take a look at that
4362018-11-01T19:16:51  <luke-jr> hmm
4372018-11-01T19:17:02  <luke-jr> so we might actually want to run the wallet tests against N different wallets
4382018-11-01T19:17:54  <sipa> i guess we may want to discuss different approaches on #14536?
4392018-11-01T19:17:57  <gribble> https://github.com/bitcoin/bitcoin/issues/14536 | functional test with ancient wallet.dat (upgrade test) · Issue #14536 · bitcoin/bitcoin · GitHub
4402018-11-01T19:21:07  <luke-jr> sgtm
4412018-11-01T19:21:09  <sipa> anything more on this topic?
4422018-11-01T19:21:30  <sipa> #topic wallet refactor progress
4432018-11-01T19:21:33  <sipa> provoostenator: ^
4442018-11-01T19:22:08  <provoostenator> sipa: you've been adding a lot of descriptor magic, which is great
4452018-11-01T19:22:14  <provoostenator> What's next?
4462018-11-01T19:22:25  <provoostenator> And do we want to have a seperate recurring wallet-refactor meeting?
4472018-11-01T19:22:27  <sipa> provoostenator: tomorrow's wallet meeting (DING DING reminder)
4482018-11-01T19:22:37  <provoostenator> TIL, nice
4492018-11-01T19:22:38  <sipa> provoostenator: yes, we had the first one 2 weeks ago
4502018-11-01T19:22:40  <instagibbs> waiting for review go ahead for #14565
4512018-11-01T19:22:41  <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
4522018-11-01T19:22:54  <instagibbs> in prep for importmulti descriptor..
4532018-11-01T19:22:57  <provoostenator> What time?
4542018-11-01T19:23:14  <sipa> provoostenator: same time as this meeting, but a day later, and only every 2 weeks
4552018-11-01T19:24:08  <sipa> more concretely what's next: * the current "old style" descriptor import (which downconverts the descriptor to the existing wallet structures)
4562018-11-01T19:24:11  <achow101> #14491 implements descriptor import for importmulti, although that should probably be rebased onto #14565
4572018-11-01T19:24:14  <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
4582018-11-01T19:24:15  <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
4592018-11-01T19:24:26  <sipa> yup, that
4602018-11-01T19:24:49  <sipa> then some preparation work for being able to use descriptors instead of keypools (which requires logic for caching pubkeys etc), i plan to work on that
4612018-11-01T19:25:02  <meshcollider> Yep I'll rebase it as soon as 14565 is in
4622018-11-01T19:25:17  <provoostenator> Sweet, that should make achow101's hardware wallet stuff easier too.
4632018-11-01T19:25:49  <provoostenator> Feel free to tag me on those PRs, in case I miss them.
4642018-11-01T19:25:53  <sipa> with follow up some refactoring to move the existing keypool/ismine logic behind an abstraction that can be instantiated with the old logic, or descriptors (so we can natively import descriptors)
4652018-11-01T19:25:57  <achow101> provoostenator: instagibbs: the plan is to make hwi do things with descriptors instead of the different pubkey stuff I was doing earlier
4662018-11-01T19:26:15  <sipa> and i think independently there is also a possibility for a few more RPCs now, like PSBT signing that takes descriptors as inpit
4672018-11-01T19:26:17  <instagibbs> achow101, That was my assumption
4682018-11-01T19:26:52  <achow101> so i'll have to rebase #14075 on top of 14491
4692018-11-01T19:26:54  <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
4702018-11-01T19:26:55  <achow101> probably
4712018-11-01T19:27:27  <instagibbs> should be simply
4722018-11-01T19:27:58  <sipa> there are other wallet related topics, like ryanofsky's wallet separation
4732018-11-01T19:28:01  <sipa> ryanofsky: here?
4742018-11-01T19:28:10  <ryanofsky> yes sir
4752018-11-01T19:28:16  <sipa> or maybe we can bring that up in tomorrow's meeting
4762018-11-01T19:28:33  <provoostenator> Thanks for the quick overview, happy to wait until tomorrow for more details.
4772018-11-01T19:28:40  <sipa> it's on high priority too, so hopefully it can get some more attention
4782018-11-01T19:28:59  <sipa> if that's enough for this topic, i have another one myself: appveyor failures
4792018-11-01T19:29:21  <phantomcircuit> sipa, the wallet stuff seems to be sort of a specialized thing
4802018-11-01T19:29:37  *** clarkmoody has joined #bitcoin-core-dev
4812018-11-01T19:29:39  <phantomcircuit> it's pretty difficult to maintain any idea of how it's working unless you're spending a lot of time looking at it
4822018-11-01T19:30:04  <provoostenator> The refactoring seems to be taking it to a place where it's easier to understand.
4832018-11-01T19:30:11  <sipa> phantomcircuit: yeah... i hope it will improve in the future
4842018-11-01T19:30:18  <provoostenator> I generally find the "after" code a lot more readable than the "before" code.
4852018-11-01T19:30:41  <provoostenator> And descriptors are very useful.
4862018-11-01T19:31:11  <luke-jr> they even do the dishes
4872018-11-01T19:31:44  <sipa> ha
4882018-11-01T19:32:34  <sipa> #topic appveyor failures
4892018-11-01T19:32:56  <sipa> i find it pretty annoying that appveyor currently spuriously fails quite frequently
4902018-11-01T19:33:04  <jnewbery> they're annoying
4912018-11-01T19:33:08  <meshcollider> Indeed
4922018-11-01T19:33:18  <sipa> there's an open issue (#14446)
4932018-11-01T19:33:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14446 | tests: Some issue about running functional tests on Windows · Issue #14446 · bitcoin/bitcoin · GitHub
4942018-11-01T19:33:23  <provoostenator> Is it fixable or is there an alternative platform?
4952018-11-01T19:33:37  <provoostenator> Because ignoring Windows may be less annoying, but not a good idea :-)
4962018-11-01T19:33:41  <sipa> and one alleged improvement to it, #13501, which i think should urgently get some attention
4972018-11-01T19:33:43  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
4982018-11-01T19:33:58  <sipa> provoostenator: it's doing MSVC builds and MinGW on windows, which aren't used for any production binaries
4992018-11-01T19:34:26  <sipa> so they're useful in likely testing for other types of issues by means of platform variety, but they're not necessarily issues that affect real production deployments
5002018-11-01T19:34:48  <luke-jr> sipa: well, we don't test Windows binaries when built on gitian/Linux, right?
5012018-11-01T19:34:53  <luke-jr> with CI I mean
5022018-11-01T19:35:00  <sipa> luke-jr: that's fair!
5032018-11-01T19:35:44  <sipa> anyway, i'd just very much like to get some attention to improving this, as continuously seeing red crosses in travis is pretty annoying
5042018-11-01T19:36:31  <luke-jr> for now I just ignore the appveyor failures on my PRs
5052018-11-01T19:37:46  <sipa> anyone have other topics?
5062018-11-01T19:38:31  <meshcollider> It is quite easy to restart appveyor in the same way to restart Travis btw, if it fails
5072018-11-01T19:38:45  <sipa> meshcollider: yes, i've restarted dozens of appveyor failures the past days...
5082018-11-01T19:40:14  <sipa> #topic open floor: what are people working on?
5092018-11-01T19:40:23  <jarthur> I'd bring up unix socket RPC topic again, but haven't had time to think about it. It sounded like folks are ok if it needs to go forward on bitcoind even if cli only has TCP, provided there are thorough tests.
5102018-11-01T19:40:26  <luke-jr> rebasing all my PRs :x
5112018-11-01T19:41:22  <sipa> jarthur: i personally am ok with that, especially since we have an option to use a different HTTP implementation in bitcoin-cli
5122018-11-01T19:41:22  <achow101> psbt + hww stuff ..... and taking lots of exams
5132018-11-01T19:41:29  <jnewbery> sipa: still not enough, but hoping to spend much more time reviewing wallet PRs before the end of the year
5142018-11-01T19:41:31  <sipa> achow101: good luck!
5152018-11-01T19:43:17  <sipa> i've picked up looking at private authentication again (being able to tell a peer is one of multiple acceptable peers who pubkey you know, but they don't learn who you were looking for, and you don't learn who they are, just that they're part of your acceptable set)... this is probably too novel to deploy, but it's a fun exercise
5162018-11-01T19:43:51  <sipa> jnewbery: cool :)
5172018-11-01T19:44:11  <instagibbs> jnewbery, same, as well as HWI assistance
5182018-11-01T19:45:00  *** bitconner has joined #bitcoin-core-dev
5192018-11-01T19:45:10  <meshcollider> I want to continue focusing on the wallet rework and everything mainly and reviewing wallet stuff like jnewbery
5202018-11-01T19:45:35  <meshcollider> And exams like achow101 xD
5212018-11-01T19:46:04  <sipa> perhaps you guys should collaborate on the exam thing? :p
5222018-11-01T19:46:31  <sipa> ok, any more topics?
5232018-11-01T19:47:01  <meshcollider> sipa: lol, he can write it and I'll review :)
5242018-11-01T19:47:47  <luke-jr> LOL
5252018-11-01T19:47:52  <luke-jr> open source exam answers
5262018-11-01T19:48:24  <sipa> #endmeeting
5272018-11-01T19:48:24  <lightningbot> Meeting ended Thu Nov  1 19:48:24 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5282018-11-01T19:48:24  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-01-19.04.html
5292018-11-01T19:48:24  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-01-19.04.txt
5302018-11-01T19:48:24  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-01-19.04.log.html
5312018-11-01T19:48:44  <sipa> thanks all
5322018-11-01T19:50:41  <wumpus> oh crap I missed the meeting due to daylight saving difference, sorry
5332018-11-01T19:51:09  <achow101> wumpus: don't worry, all of us in the US will do the same next week
5342018-11-01T19:51:20  * wumpus wants to move to iceland...
5352018-11-01T19:51:50  <luke-jr> achow101: not those of us who use Tonal
5362018-11-01T19:52:35  *** ExtraCrispy has quit IRC
5372018-11-01T19:53:25  <sipa> wumpus: isn't the EU going to abolish DST?
5382018-11-01T19:53:57  <provoostenator> EU in bureaucratic tradition decided to make it up to individual countries.
5392018-11-01T19:54:26  <sipa> so reminder: the meeting time next week will be 11am west coast, 2pm east coast, 20:00 central european
5402018-11-01T19:54:28  <provoostenator> Some of which think it's a good idea to make DST permanent.
5412018-11-01T19:54:48  <sipa> provoostenator: yeah, i saw that - making the netherlands and belgium generally 2 hours off solar time
5422018-11-01T19:54:55  <sipa> or 1:40 at least
5432018-11-01T19:55:01  <provoostenator> With sunrise in winter at 9:50am
5442018-11-01T19:55:33  <luke-jr> what is solar time?
5452018-11-01T19:55:44  <provoostenator> 12:00 should be when the sun is directly overhead
5462018-11-01T19:55:57  <provoostenator> which in my opinion should be done per city :-)
5472018-11-01T19:55:58  <luke-jr> ah
5482018-11-01T19:56:03  <sipa> provoostenator: the sun is never directly overhead unless you're between the tropics
5492018-11-01T19:56:16  <sipa> you mean having the sun at its highest point at 12:00
5502018-11-01T19:56:22  <provoostenator> Yes
5512018-11-01T19:56:27  <luke-jr> usually I have a roof between me and the sun
5522018-11-01T19:56:37  * sipa is in favor of 1 timezone per continent
5532018-11-01T19:57:16  * luke-jr is in favour of 1 timezone period and everyone just gets used to what times the sun rises and falls in their own region
5542018-11-01T19:57:39  <wumpus> sipa: I hope they will, I really do
5552018-11-01T19:58:22  <provoostenator> Gondwana time?
5562018-11-01T19:58:42  <luke-jr> ?
5572018-11-01T19:59:05  <provoostenator> https://en.wikipedia.org/wiki/Gondwana
5582018-11-01T19:59:09  <luke-jr> provoostenator: https://en.wikipedia.org/wiki/File:Hexadecimal_Clock_by_Nystrom.jpg
5592018-11-01T19:59:15  *** Tralfaz has quit IRC
5602018-11-01T20:03:02  <phantomcircuit> sipa, appveyor failed on 14336...
5612018-11-01T20:03:14  <phantomcircuit> (i added a comment and now it fails
5622018-11-01T20:09:05  <wumpus> wasn't that just a random failure?
5632018-11-01T20:14:06  *** clarkmoo_ has joined #bitcoin-core-dev
5642018-11-01T20:14:06  *** lnostdal has joined #bitcoin-core-dev
5652018-11-01T20:17:22  *** clarkmoody has quit IRC
5662018-11-01T20:17:23  <phantomcircuit> wumpus, yes he's been resetting them
5672018-11-01T20:17:28  <phantomcircuit> obviously not a long term solution
5682018-11-01T20:23:56  <MarcoFalke> agree. I wasn't expecting we see so much failures nor that it takes so long to fix them.
5692018-11-01T20:24:10  <MarcoFalke> Might want to disable most of the functional tests for now on windows.
5702018-11-01T20:24:25  <MarcoFalke> And make it a target to fix them until 0.18.0?
5712018-11-01T20:24:36  <sipa> well let's see how things improve with #13501 first?
5722018-11-01T20:24:38  <gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub
5732018-11-01T20:26:21  <MarcoFalke> yeah, fine. I am not fluent in libevent, so at least I can't review it apart from Concept ACK
5742018-11-01T20:29:38  <wumpus> phantomcircuit: appveyor has been kind of flakey since the beginning, I don't put as much weight in its result as travis'
5752018-11-01T20:29:57  <wumpus> it's useful to see what the windows build does, but not a merge blocker for me
5762018-11-01T20:30:20  <esotericnonsense> the worst thing about the EU DST thing is brexit.
5772018-11-01T20:30:31  <esotericnonsense> it could have been glorious. i could be in UTC _forever_.
5782018-11-01T20:30:37  <esotericnonsense> this is so much worse than mass deportations etc.
5792018-11-01T20:33:36  <esotericnonsense> (ok technically I'd be in GMT, but whatever).
5802018-11-01T20:35:15  *** ezzzy has quit IRC
5812018-11-01T20:42:42  <sipa> wumpus: i wish there was a way to have it report its status without changing the PR's "CI passed" status
5822018-11-01T20:43:31  <wumpus> sipa: agree that would be useful
5832018-11-01T20:44:12  *** rex4539 has joined #bitcoin-core-dev
5842018-11-01T20:50:16  <wumpus> provoostenator: heh I'd never heard of Gondwana, just Pangaea
5852018-11-01T21:02:28  *** jarthur has quit IRC
5862018-11-01T21:08:23  *** Tralfaz has joined #bitcoin-core-dev
5872018-11-01T21:14:30  *** ken2812221_ has joined #bitcoin-core-dev
5882018-11-01T21:17:24  *** nejon has joined #bitcoin-core-dev
5892018-11-01T21:17:28  *** ken2812221 has quit IRC
5902018-11-01T21:17:34  *** clarkmoo_ has quit IRC
5912018-11-01T21:18:06  *** clarkmoody has joined #bitcoin-core-dev
5922018-11-01T21:19:12  *** bitcoin-git has joined #bitcoin-core-dev
5932018-11-01T21:19:13  <bitcoin-git> [bitcoin] ryanofsky opened pull request #14635: developer-notes: allow lowerCamelCase (master...pr/camelow) https://github.com/bitcoin/bitcoin/pull/14635
5942018-11-01T21:19:13  *** bitcoin-git has left #bitcoin-core-dev
5952018-11-01T21:26:12  *** bitcoin-git has joined #bitcoin-core-dev
5962018-11-01T21:26:13  <bitcoin-git> [bitcoin] ryanofsky opened pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636
5972018-11-01T21:26:13  *** bitcoin-git has left #bitcoin-core-dev
5982018-11-01T21:32:24  *** josephnicholas has joined #bitcoin-core-dev
5992018-11-01T21:36:48  *** josephnicholas has quit IRC
6002018-11-01T21:40:06  *** Chris_Stewart_5 has quit IRC
6012018-11-01T21:41:27  *** dgenr8 has quit IRC
6022018-11-01T21:43:34  *** dgenr8 has joined #bitcoin-core-dev
6032018-11-01T21:44:34  *** Murch has joined #bitcoin-core-dev
6042018-11-01T21:57:40  *** Murch has quit IRC
6052018-11-01T22:14:29  *** Murch has joined #bitcoin-core-dev
6062018-11-01T22:16:23  *** mrush has joined #bitcoin-core-dev
6072018-11-01T22:21:44  *** mrush has quit IRC
6082018-11-01T22:26:05  *** mrush has joined #bitcoin-core-dev
6092018-11-01T22:27:12  *** mrush has quit IRC
6102018-11-01T22:28:26  *** mrush has joined #bitcoin-core-dev
6112018-11-01T22:31:06  *** mrush has joined #bitcoin-core-dev
6122018-11-01T22:32:32  *** mrush has quit IRC
6132018-11-01T22:33:09  *** mrush has joined #bitcoin-core-dev
6142018-11-01T22:34:10  *** michaelsdunn1 has quit IRC
6152018-11-01T22:35:07  *** cubancorona has joined #bitcoin-core-dev
6162018-11-01T22:41:06  *** Murch has quit IRC
6172018-11-01T22:45:03  *** spinza has quit IRC
6182018-11-01T22:46:00  *** mrush has left #bitcoin-core-dev
6192018-11-01T22:51:20  *** lukedashjr has joined #bitcoin-core-dev
6202018-11-01T22:53:15  *** luke-jr has quit IRC
6212018-11-01T22:55:52  *** lukedashjr is now known as luke-jr
6222018-11-01T22:59:11  *** spinza has joined #bitcoin-core-dev
6232018-11-01T23:09:15  *** booyah has quit IRC
6242018-11-01T23:10:11  *** morcos has quit IRC
6252018-11-01T23:10:18  *** booyah has joined #bitcoin-core-dev
6262018-11-01T23:16:35  *** morcos has joined #bitcoin-core-dev
6272018-11-01T23:22:06  *** morcos has quit IRC
6282018-11-01T23:22:40  *** sipa has quit IRC
6292018-11-01T23:24:18  *** sipa has joined #bitcoin-core-dev
6302018-11-01T23:26:05  *** Victorsueca has quit IRC
6312018-11-01T23:26:32  *** teardown has joined #bitcoin-core-dev
6322018-11-01T23:27:18  *** Victorsueca has joined #bitcoin-core-dev
6332018-11-01T23:27:49  *** morcos has joined #bitcoin-core-dev
6342018-11-01T23:30:51  *** wxss has quit IRC
6352018-11-01T23:35:20  *** hebasto has quit IRC
6362018-11-01T23:38:08  *** teardown has quit IRC
6372018-11-01T23:44:13  *** teardown has joined #bitcoin-core-dev
6382018-11-01T23:48:40  *** Tralfaz has quit IRC
6392018-11-01T23:48:44  *** shesek has joined #bitcoin-core-dev
6402018-11-01T23:51:35  *** shesek has quit IRC
6412018-11-01T23:52:51  *** shesek has joined #bitcoin-core-dev
6422018-11-01T23:54:32  <meshcollider> maybe appveyor could call drahtbot in a build_failure webhook and then report success anyway
6432018-11-01T23:54:36  *** shesek has quit IRC
6442018-11-01T23:54:40  <meshcollider> then drahtbot could just comment or something
6452018-11-01T23:55:55  *** shesek has joined #bitcoin-core-dev
6462018-11-01T23:59:16  *** Tralfaz has joined #bitcoin-core-dev