1 2018-11-07T00:09:21  *** bitcoin-git has joined #bitcoin-core-dev
  2 2018-11-07T00:09:22  <bitcoin-git> [bitcoin] rodasmith opened pull request #14674: Let systemd bitcoind write to /etc/bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14674
  3 2018-11-07T00:09:22  *** bitcoin-git has left #bitcoin-core-dev
  4 2018-11-07T00:32:29  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
  5 2018-11-07T00:35:30  *** Ga1aCt1Cz00__ has quit IRC
  6 2018-11-07T00:50:36  *** spinza has quit IRC
  7 2018-11-07T00:55:46  *** spinza has joined #bitcoin-core-dev
  8 2018-11-07T00:57:27  *** ossifrage has joined #bitcoin-core-dev
  9 2018-11-07T01:09:13  *** ossifrage has quit IRC
 10 2018-11-07T01:09:44  *** ossifrage has joined #bitcoin-core-dev
 11 2018-11-07T01:21:53  *** murrayn_ has joined #bitcoin-core-dev
 12 2018-11-07T01:25:28  *** murrayn has quit IRC
 13 2018-11-07T01:29:14  *** Krellan has joined #bitcoin-core-dev
 14 2018-11-07T01:32:05  *** Krellan has joined #bitcoin-core-dev
 15 2018-11-07T01:36:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 16 2018-11-07T01:38:04  *** kabaum has quit IRC
 17 2018-11-07T01:38:37  *** rex4539 has joined #bitcoin-core-dev
 18 2018-11-07T01:40:42  *** kabaum has joined #bitcoin-core-dev
 19 2018-11-07T01:47:19  *** kabaum has quit IRC
 20 2018-11-07T01:52:46  *** kabaum has joined #bitcoin-core-dev
 21 2018-11-07T01:55:59  *** ghost43 has quit IRC
 22 2018-11-07T01:56:11  *** ghost43 has joined #bitcoin-core-dev
 23 2018-11-07T02:03:31  *** Chris_Stewart_5 has quit IRC
 24 2018-11-07T02:12:04  *** Murch has quit IRC
 25 2018-11-07T02:51:49  *** Krellan_ has joined #bitcoin-core-dev
 26 2018-11-07T02:52:32  *** instagibbs has quit IRC
 27 2018-11-07T02:54:52  *** Krellan_ has quit IRC
 28 2018-11-07T02:55:56  *** Krellan has quit IRC
 29 2018-11-07T03:00:07  *** ricardobessa has quit IRC
 30 2018-11-07T03:00:59  *** bitcoin-git has joined #bitcoin-core-dev
 31 2018-11-07T03:00:59  <bitcoin-git> [bitcoin] ken2812221 closed pull request #14655: qt: remove unused SECURE style (master...qt-unused-secure) https://github.com/bitcoin/bitcoin/pull/14655
 32 2018-11-07T03:00:59  *** bitcoin-git has left #bitcoin-core-dev
 33 2018-11-07T03:01:35  *** grubles has quit IRC
 34 2018-11-07T03:02:03  *** grubles has joined #bitcoin-core-dev
 35 2018-11-07T03:11:54  <promag> jamesob: https://travis-ci.org/bitcoin/bitcoin/jobs/451688699
 36 2018-11-07T03:33:21  *** owowo has joined #bitcoin-core-dev
 37 2018-11-07T03:33:43  *** promag has quit IRC
 38 2018-11-07T03:38:17  *** instagibbs has joined #bitcoin-core-dev
 39 2018-11-07T03:45:21  *** Aaronvan_ has quit IRC
 40 2018-11-07T03:45:59  *** AaronvanW has joined #bitcoin-core-dev
 41 2018-11-07T03:50:01  *** AaronvanW has quit IRC
 42 2018-11-07T03:51:39  *** murrayn_ has quit IRC
 43 2018-11-07T03:51:58  *** murrayn has joined #bitcoin-core-dev
 44 2018-11-07T03:55:59  *** AaronvanW has joined #bitcoin-core-dev
 45 2018-11-07T04:00:28  *** AaronvanW has quit IRC
 46 2018-11-07T04:16:18  *** bitconner has quit IRC
 47 2018-11-07T04:16:59  *** bitconner has joined #bitcoin-core-dev
 48 2018-11-07T04:21:39  *** bitconner has quit IRC
 49 2018-11-07T04:27:46  *** bitcoin-git has joined #bitcoin-core-dev
 50 2018-11-07T04:27:46  <bitcoin-git> [bitcoin] rodasmith closed pull request #14674: Let systemd bitcoind write to /etc/bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14674
 51 2018-11-07T04:27:46  *** bitcoin-git has left #bitcoin-core-dev
 52 2018-11-07T05:21:27  *** bralyclow has quit IRC
 53 2018-11-07T05:28:33  *** bitconner has joined #bitcoin-core-dev
 54 2018-11-07T05:30:08  *** bralyclow has joined #bitcoin-core-dev
 55 2018-11-07T05:31:12  *** bralyclow has quit IRC
 56 2018-11-07T05:32:21  *** altcoin has joined #bitcoin-core-dev
 57 2018-11-07T05:34:51  *** altcoin has quit IRC
 58 2018-11-07T06:06:09  *** bitconner has quit IRC
 59 2018-11-07T06:10:01  *** rh0nj has quit IRC
 60 2018-11-07T06:11:07  *** rh0nj has joined #bitcoin-core-dev
 61 2018-11-07T06:50:58  *** Bullitje has joined #bitcoin-core-dev
 62 2018-11-07T06:54:28  *** Bullit has quit IRC
 63 2018-11-07T06:58:11  *** AaronvanW has joined #bitcoin-core-dev
 64 2018-11-07T07:03:13  *** AaronvanW has quit IRC
 65 2018-11-07T07:05:12  <warren> dongcarl: huzzah
 66 2018-11-07T07:12:01  *** martinus has joined #bitcoin-core-dev
 67 2018-11-07T07:19:15  <hebasto> wumpus: MarcoFalke: ethic/testing/QA question. If one's PR (e.g., #14123) contains cherry-picked commits from my PR should I avoid ACKing such PR?
 68 2018-11-07T07:19:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14123 | gui: Add GUIUtil::bringToFront by promag · Pull Request #14123 · bitcoin/bitcoin · GitHub
 69 2018-11-07T07:30:07  *** martinus has quit IRC
 70 2018-11-07T08:05:23  *** ezzzy has joined #bitcoin-core-dev
 71 2018-11-07T08:08:12  *** setpill has joined #bitcoin-core-dev
 72 2018-11-07T08:12:17  <sipa> hebasto: feel free to ack
 73 2018-11-07T08:13:10  *** Krellan_ has joined #bitcoin-core-dev
 74 2018-11-07T08:14:17  <hebasto> sipa: ty
 75 2018-11-07T08:24:05  <wumpus> esotericnonsense: nice!
 76 2018-11-07T08:24:45  <wumpus> hebasto: no, you can still review the rest, you could say you haven't reviewed commit XXX because it's your own
 77 2018-11-07T08:44:28  *** phwalkr has joined #bitcoin-core-dev
 78 2018-11-07T08:47:01  <hebasto> wumpus: ok
 79 2018-11-07T08:53:53  <luke-jr> someone looking for help with -rpcallowip in #bitcoin right now FYI
 80 2018-11-07T08:59:11  *** todd has joined #bitcoin-core-dev
 81 2018-11-07T09:05:33  *** promag has joined #bitcoin-core-dev
 82 2018-11-07T09:34:57  <promag> wumpus: could you look at #14670, esp the PR description. I think this is it XD
 83 2018-11-07T09:34:59  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
 84 2018-11-07T09:35:45  *** promag has quit IRC
 85 2018-11-07T09:36:59  *** timothy has joined #bitcoin-core-dev
 86 2018-11-07T09:42:07  *** DougieBot5000 has quit IRC
 87 2018-11-07T09:42:37  *** DougieBot5000 has joined #bitcoin-core-dev
 88 2018-11-07T09:44:47  *** jungly has quit IRC
 89 2018-11-07T09:45:05  *** dqx has joined #bitcoin-core-dev
 90 2018-11-07T09:45:58  *** jungly has joined #bitcoin-core-dev
 91 2018-11-07T09:53:56  *** vishwas has joined #bitcoin-core-dev
 92 2018-11-07T09:55:01  <vishwas> hi
 93 2018-11-07T10:00:12  *** Krellan_ has quit IRC
 94 2018-11-07T10:02:53  *** spinza has quit IRC
 95 2018-11-07T10:06:31  *** promag has joined #bitcoin-core-dev
 96 2018-11-07T10:08:01  *** spinza has joined #bitcoin-core-dev
 97 2018-11-07T10:08:13  *** shesek has quit IRC
 98 2018-11-07T10:08:45  *** shesek has joined #bitcoin-core-dev
 99 2018-11-07T10:11:34  <vishwas> hey can some help me with this https://bitcoin.stackexchange.com/questions/80782/converting-raw-scriptpubkey-to-readable-format ?  thanks!
100 2018-11-07T10:16:36  *** shesek has quit IRC
101 2018-11-07T10:17:02  *** shesek has joined #bitcoin-core-dev
102 2018-11-07T10:17:30  <gwillen> vishwas: you should try to get your debugger to print it as a hex string
103 2018-11-07T10:17:38  <gwillen> if you get that you can pass it to the "decodescript" RPC
104 2018-11-07T10:18:58  <gwillen> note that scriptPubKey in the structure there is a C++ vector object, you really can't do much by poking around inside it
105 2018-11-07T10:18:59  *** todd has quit IRC
106 2018-11-07T10:19:20  <gwillen> all that "direct" and "indirect" stuff is internal implementation details of C++ vectors
107 2018-11-07T10:22:17  <vishwas> thanks gwillen let me try that.
108 2018-11-07T10:30:57  *** shesek has quit IRC
109 2018-11-07T10:31:30  *** shesek has joined #bitcoin-core-dev
110 2018-11-07T10:31:30  *** shesek has joined #bitcoin-core-dev
111 2018-11-07T10:35:48  <vishwas> @gwillen ; one question, so when the UTXO finally gets stored in to the block, this vector object should get transformed into string ?
112 2018-11-07T10:36:34  <vishwas> or its gets stored in this form only.?
113 2018-11-07T10:37:21  *** shesek has quit IRC
114 2018-11-07T10:37:53  *** shesek has joined #bitcoin-core-dev
115 2018-11-07T10:37:53  *** shesek has joined #bitcoin-core-dev
116 2018-11-07T10:46:13  *** shesek has quit IRC
117 2018-11-07T10:47:23  *** shesek has joined #bitcoin-core-dev
118 2018-11-07T11:00:55  *** AaronvanW has joined #bitcoin-core-dev
119 2018-11-07T11:03:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
120 2018-11-07T11:05:02  *** rh0nj has quit IRC
121 2018-11-07T11:05:32  *** AaronvanW has quit IRC
122 2018-11-07T11:06:08  *** rh0nj has joined #bitcoin-core-dev
123 2018-11-07T11:16:02  *** Guyver2 has joined #bitcoin-core-dev
124 2018-11-07T11:29:27  *** Chris_Stewart_5 has quit IRC
125 2018-11-07T11:42:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
126 2018-11-07T11:42:59  *** phwalkr has quit IRC
127 2018-11-07T12:27:01  *** josephnicholas has joined #bitcoin-core-dev
128 2018-11-07T12:30:08  *** josephnicholas has quit IRC
129 2018-11-07T12:30:46  *** josephnicholas has joined #bitcoin-core-dev
130 2018-11-07T12:30:46  <setpill> hrm. does the gitian build process check the integrity of the osslsigncode tarfile downloaded from sourceforge in any way?
131 2018-11-07T12:31:10  <setpill> or the patch downloaded from bitcoincore.org for that matter...
132 2018-11-07T12:33:11  *** bralyclow has joined #bitcoin-core-dev
133 2018-11-07T12:39:55  <gmaxwell> setpill: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-win-signer.yml#L23
134 2018-11-07T12:43:57  <setpill> ah, expected them in the script that downloads them, thanks
135 2018-11-07T12:44:09  *** spinza has quit IRC
136 2018-11-07T12:51:17  *** goosie has joined #bitcoin-core-dev
137 2018-11-07T12:56:31  *** vishwas has quit IRC
138 2018-11-07T12:58:19  *** rafalcpp has joined #bitcoin-core-dev
139 2018-11-07T13:01:40  *** AaronvanW has joined #bitcoin-core-dev
140 2018-11-07T13:01:42  *** shesek has quit IRC
141 2018-11-07T13:02:45  *** shesek has joined #bitcoin-core-dev
142 2018-11-07T13:04:15  *** shesek has quit IRC
143 2018-11-07T13:04:35  *** Chris_Stewart_5 has quit IRC
144 2018-11-07T13:05:55  *** AaronvanW has quit IRC
145 2018-11-07T13:07:08  *** shesek has joined #bitcoin-core-dev
146 2018-11-07T13:10:15  *** spinza has joined #bitcoin-core-dev
147 2018-11-07T13:10:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
148 2018-11-07T13:24:31  *** Chris_Stewart_5 has quit IRC
149 2018-11-07T13:25:30  *** AaronvanW has joined #bitcoin-core-dev
150 2018-11-07T13:31:26  *** AaronvanW has quit IRC
151 2018-11-07T13:32:16  *** AaronvanW has joined #bitcoin-core-dev
152 2018-11-07T13:39:13  *** promag has quit IRC
153 2018-11-07T13:43:56  *** watchtower has joined #bitcoin-core-dev
154 2018-11-07T13:48:12  *** belcher has joined #bitcoin-core-dev
155 2018-11-07T13:48:39  *** watchtower has quit IRC
156 2018-11-07T13:50:59  *** ott0disk has joined #bitcoin-core-dev
157 2018-11-07T13:51:48  *** JackH has joined #bitcoin-core-dev
158 2018-11-07T14:00:22  *** setpill has quit IRC
159 2018-11-07T14:04:14  *** Tralfaz has joined #bitcoin-core-dev
160 2018-11-07T14:04:23  *** watchtower has joined #bitcoin-core-dev
161 2018-11-07T14:10:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
162 2018-11-07T14:22:48  *** ott0disk has quit IRC
163 2018-11-07T14:23:16  *** bralyclow has quit IRC
164 2018-11-07T14:26:50  *** promag has joined #bitcoin-core-dev
165 2018-11-07T14:27:26  *** bralyclow has joined #bitcoin-core-dev
166 2018-11-07T14:27:28  *** YSqTU2XbB has joined #bitcoin-core-dev
167 2018-11-07T14:36:11  *** YSqTU2XbB has quit IRC
168 2018-11-07T14:45:56  *** watchtower has quit IRC
169 2018-11-07T14:47:11  *** CodeBlue1776 has quit IRC
170 2018-11-07T14:49:09  *** CodeBlue1776 has joined #bitcoin-core-dev
171 2018-11-07T15:01:03  *** phwalkr has joined #bitcoin-core-dev
172 2018-11-07T15:21:03  *** watchtower has joined #bitcoin-core-dev
173 2018-11-07T15:27:25  *** Scipio has joined #bitcoin-core-dev
174 2018-11-07T15:27:31  <instagibbs> in functional tests is there a nice way to send coinbase outputs to p2pk as per `generate`?
175 2018-11-07T15:27:37  <instagibbs> now that generate is gone
176 2018-11-07T15:28:38  <instagibbs> I guess s/functional tests/rpc/
177 2018-11-07T15:34:56  <provoostenator> Can someone elaborate on the difference between a FlatSigningProvider and a HidingSigningProvider and why only the latter has a working GetKeyOrigin?
178 2018-11-07T15:36:13  <sipa> provoostenator: FlatSigningProvider provides the data stored in fields in the object itself
179 2018-11-07T15:36:52  <sipa> it's what you use if you just have a bunch of keys, pubkeys, scripts, and origins, and want to make it available to the signing code
180 2018-11-07T15:37:39  <sipa> HidingSigningProvider takes as input *another* signingprovider, but hides certain information from it (in particular, private keys)
181 2018-11-07T15:38:23  *** phwalkr has quit IRC
182 2018-11-07T15:38:49  <sipa> and what do you mean with "no working GetKeyOrigin" ?
183 2018-11-07T15:39:09  *** michaelsdunn1 has joined #bitcoin-core-dev
184 2018-11-07T15:40:25  <provoostenator> sipa: in the WIP hardware wallet support branch I find that walletcreatefundedpbst no longer adds origin info. Trying to triangulate why: https://github.com/achow101/bitcoin/tree/hww
185 2018-11-07T15:41:23  <sipa> provoostenator: you're setting the flag for hd paths to true, right?
186 2018-11-07T15:41:47  <provoostenator> This in the case of a wallet with no private keys. Yes, the bip32 bool at the end is true
187 2018-11-07T15:43:28  <provoostenator> I find that only HidingSigningProvider::GetKeyOrigin is called, which afaik can only return false and doesn't actual set the info field.
188 2018-11-07T15:43:45  <sipa> huh
189 2018-11-07T15:44:19  <sipa> why do you think so?
190 2018-11-07T15:45:18  <jamesob> merge beg: https://github.com/bitcoin/bitcoin/pull/14457
191 2018-11-07T15:56:18  *** bitcoin-git has joined #bitcoin-core-dev
192 2018-11-07T15:56:18  <bitcoin-git> [bitcoin] instagibbs opened pull request #14678: remove redundant KeyOriginInfo access, already done in CreateSig (master...redundant_keypath) https://github.com/bitcoin/bitcoin/pull/14678
193 2018-11-07T15:56:18  *** bitcoin-git has left #bitcoin-core-dev
194 2018-11-07T15:56:32  *** ezzzy has quit IRC
195 2018-11-07T15:59:43  <provoostenator> sipa: I set log statements on both HidingSigningProvider::GetKeyOrigin and FlatSigningProvider::GetKeyOrigin and only the former is called.
196 2018-11-07T16:01:09  <instagibbs> provoostenator, the underlying m_provider is CWallet though?
197 2018-11-07T16:01:31  <provoostenator> Oh, I assemed it referred to the base class, n00b...
198 2018-11-07T16:02:08  <instagibbs> It "wraps" CWallet to "hide" stuff. Honestly they should have documentation :)
199 2018-11-07T16:04:04  *** bitcoin-git has joined #bitcoin-core-dev
200 2018-11-07T16:04:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d864e45730be...4e6dc7a0ef22
201 2018-11-07T16:04:05  <bitcoin-git> bitcoin/master 99d33a6 Chun Kuan Lee: appveyor: Script improvement part II
202 2018-11-07T16:04:06  <bitcoin-git> bitcoin/master 4e6dc7a MarcoFalke: Merge #14665: appveyor: Script improvement part II...
203 2018-11-07T16:04:06  *** bitcoin-git has left #bitcoin-core-dev
204 2018-11-07T16:04:17  *** watchtower has quit IRC
205 2018-11-07T16:05:31  *** bitcoin-git has joined #bitcoin-core-dev
206 2018-11-07T16:05:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14665: appveyor: Script improvement part II (master...appveyor-quiet) https://github.com/bitcoin/bitcoin/pull/14665
207 2018-11-07T16:05:31  *** bitcoin-git has left #bitcoin-core-dev
208 2018-11-07T16:07:31  *** bitcoin-git has joined #bitcoin-core-dev
209 2018-11-07T16:07:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e6dc7a0ef22...66c70249f9e6
210 2018-11-07T16:07:32  <bitcoin-git> bitcoin/master 053b6f4 Harry Moreno: align items in contrib init
211 2018-11-07T16:07:33  <bitcoin-git> bitcoin/master 66c7024 MarcoFalke: Merge #14611: docs: align items in contrib init...
212 2018-11-07T16:07:33  *** bitcoin-git has left #bitcoin-core-dev
213 2018-11-07T16:08:16  *** watchtower has joined #bitcoin-core-dev
214 2018-11-07T16:08:46  *** bitcoin-git has joined #bitcoin-core-dev
215 2018-11-07T16:08:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14611: docs: align items in contrib init (master...morenoh149-patch-1) https://github.com/bitcoin/bitcoin/pull/14611
216 2018-11-07T16:08:46  *** bitcoin-git has left #bitcoin-core-dev
217 2018-11-07T16:12:43  *** watchtower has quit IRC
218 2018-11-07T16:14:16  *** watchtower has joined #bitcoin-core-dev
219 2018-11-07T16:16:37  *** watchtower has quit IRC
220 2018-11-07T16:17:10  *** bitcoin-git has joined #bitcoin-core-dev
221 2018-11-07T16:17:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/66c70249f9e6...e8d490f27e69
222 2018-11-07T16:17:11  <bitcoin-git> bitcoin/master e4dc39b Hennadii Stepanov: Replace platform dependent type with proper const
223 2018-11-07T16:17:11  <bitcoin-git> bitcoin/master bafb921 Hennadii Stepanov: Remove duplicated code...
224 2018-11-07T16:17:12  <bitcoin-git> bitcoin/master 5352030 Russell Yanofsky: Avoid using numeric_limits for sequence numbers and lock times...
225 2018-11-07T16:17:12  *** bitcoin-git has left #bitcoin-core-dev
226 2018-11-07T16:18:19  *** bitcoin-git has joined #bitcoin-core-dev
227 2018-11-07T16:18:19  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14636: Avoid using numeric_limits for sequence numbers and lock times (master...pr/climit) https://github.com/bitcoin/bitcoin/pull/14636
228 2018-11-07T16:18:19  *** bitcoin-git has left #bitcoin-core-dev
229 2018-11-07T16:18:30  *** jarthur has joined #bitcoin-core-dev
230 2018-11-07T16:20:31  *** bitcoin-git has joined #bitcoin-core-dev
231 2018-11-07T16:20:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13677: Remind developers that disablewallet=1 should always work (master...2018/07/disable-wallet) https://github.com/bitcoin/bitcoin/pull/13677
232 2018-11-07T16:20:31  *** bitcoin-git has left #bitcoin-core-dev
233 2018-11-07T16:27:29  *** bitcoin-git has joined #bitcoin-core-dev
234 2018-11-07T16:27:29  <bitcoin-git> [bitcoin] instagibbs opened pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
235 2018-11-07T16:27:29  *** bitcoin-git has left #bitcoin-core-dev
236 2018-11-07T16:29:31  *** jarthur has quit IRC
237 2018-11-07T16:34:01  *** rh0nj has quit IRC
238 2018-11-07T16:35:08  *** rh0nj has joined #bitcoin-core-dev
239 2018-11-07T16:52:02  *** ezzzy has joined #bitcoin-core-dev
240 2018-11-07T16:58:32  *** promag has quit IRC
241 2018-11-07T17:01:02  *** Krellan has joined #bitcoin-core-dev
242 2018-11-07T17:02:38  <provoostenator> Any one-liner to serialize a KeyOriginInfo object to std::string (for debugging)?
243 2018-11-07T17:03:11  <provoostenator> (or to char *)
244 2018-11-07T17:03:48  <sipa> provoostenator: decodepsbt has code for that
245 2018-11-07T17:04:02  <sipa> oh, it does it in 2 separate json fields
246 2018-11-07T17:04:51  <provoostenator> sipa: got it, that should be easy to reuse
247 2018-11-07T17:07:29  *** Aaronvan_ has joined #bitcoin-core-dev
248 2018-11-07T17:08:51  <MarcoFalke> https://github.com/bitcoin/bitcoin/issues/14675#issuecomment-436689585
249 2018-11-07T17:08:57  <MarcoFalke> 0.17.0.2 ?
250 2018-11-07T17:10:24  *** Murch has joined #bitcoin-core-dev
251 2018-11-07T17:10:27  *** AaronvanW has quit IRC
252 2018-11-07T17:11:27  *** XtuDe has quit IRC
253 2018-11-07T17:11:59  *** bitcoin-git has joined #bitcoin-core-dev
254 2018-11-07T17:11:59  <bitcoin-git> [bitcoin] jamesob opened pull request #14683: tests: better combine_logs.py behavior (master...2018-11-better-cons-log) https://github.com/bitcoin/bitcoin/pull/14683
255 2018-11-07T17:11:59  *** bitcoin-git has left #bitcoin-core-dev
256 2018-11-07T17:23:08  *** bitcoin-git has joined #bitcoin-core-dev
257 2018-11-07T17:23:08  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8d490f27e69...d26d15c6c89a
258 2018-11-07T17:23:09  <bitcoin-git> bitcoin/master 590a57f practicalswift: tests: Remove unused testing code
259 2018-11-07T17:23:09  <bitcoin-git> bitcoin/master c82190c practicalswift: tests: Add Python dead code linter (vulture)
260 2018-11-07T17:23:10  <bitcoin-git> bitcoin/master d26d15c MarcoFalke: Merge #14365: tests: Add Python dead code linter (vulture) to Travis...
261 2018-11-07T17:23:10  *** bitcoin-git has left #bitcoin-core-dev
262 2018-11-07T17:24:03  *** bitcoin-git has joined #bitcoin-core-dev
263 2018-11-07T17:24:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14365:  tests: Add Python dead code linter (vulture) to Travis (master...lint-python-dead-code) https://github.com/bitcoin/bitcoin/pull/14365
264 2018-11-07T17:24:04  *** bitcoin-git has left #bitcoin-core-dev
265 2018-11-07T17:24:24  <esotericnonsense> wumpus: :) when I get bored of bashing JS libraries into submission I'll add some more stuff. need to get away from this chart distraction and add some actually useful API bits. :p\
266 2018-11-07T17:33:07  *** JackH has quit IRC
267 2018-11-07T17:35:34  *** XtXe has joined #bitcoin-core-dev
268 2018-11-07T17:37:27  *** XtXe has quit IRC
269 2018-11-07T17:42:57  *** bitcoin-git has joined #bitcoin-core-dev
270 2018-11-07T17:42:57  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14684: [doc] conf: Remove deprecated options from docs, Other cleanup (master...Mf1609-trivialPre14) https://github.com/bitcoin/bitcoin/pull/14684
271 2018-11-07T17:42:57  *** bitcoin-git has left #bitcoin-core-dev
272 2018-11-07T17:44:22  <provoostenator> (mystery solved, the older version of achow101's hww PR would write "h" into meta.hdKeypath, which trips up ParseHDKeypath. The new version always uses '.
273 2018-11-07T17:47:47  *** XtXe has joined #bitcoin-core-dev
274 2018-11-07T17:50:44  *** dstadulis has joined #bitcoin-core-dev
275 2018-11-07T17:53:07  *** dstadulis has quit IRC
276 2018-11-07T17:57:01  *** ExtraCrispy has joined #bitcoin-core-dev
277 2018-11-07T18:02:08  <sipa> provoostenator: ha, nice find
278 2018-11-07T18:02:18  <provoostenator> Hardware wallet fun in ##hww
279 2018-11-07T18:02:24  <instagibbs> achow101, ^
280 2018-11-07T18:02:25  <provoostenator> ##hwi
281 2018-11-07T18:03:43  *** XtXe has quit IRC
282 2018-11-07T18:04:13  *** XtXe has joined #bitcoin-core-dev
283 2018-11-07T18:04:56  *** XtXe has joined #bitcoin-core-dev
284 2018-11-07T18:09:16  *** XtXe has quit IRC
285 2018-11-07T18:19:57  *** ricardobessa has joined #bitcoin-core-dev
286 2018-11-07T18:36:54  *** Chris_Stewart_5 has quit IRC
287 2018-11-07T18:49:13  *** rex4539 has quit IRC
288 2018-11-07T18:51:54  *** timothy has quit IRC
289 2018-11-07T19:07:04  *** ExtraCrispy has quit IRC
290 2018-11-07T19:14:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
291 2018-11-07T19:16:49  *** belcher has quit IRC
292 2018-11-07T19:17:34  *** belcher has joined #bitcoin-core-dev
293 2018-11-07T19:33:55  *** esotericnonsense has quit IRC
294 2018-11-07T19:36:02  *** esotericnonsense has joined #bitcoin-core-dev
295 2018-11-07T19:36:55  *** mistergold has joined #bitcoin-core-dev
296 2018-11-07T19:37:48  *** AaronvanW has joined #bitcoin-core-dev
297 2018-11-07T19:38:01  *** Aaronvan_ has quit IRC
298 2018-11-07T19:38:15  *** jarthur has joined #bitcoin-core-dev
299 2018-11-07T19:40:10  *** rex4539 has joined #bitcoin-core-dev
300 2018-11-07T19:45:06  *** schmidty has joined #bitcoin-core-dev
301 2018-11-07T19:45:07  *** schmidty has joined #bitcoin-core-dev
302 2018-11-07T19:58:23  *** promag has joined #bitcoin-core-dev
303 2018-11-07T20:01:24  *** bitcoin-git has joined #bitcoin-core-dev
304 2018-11-07T20:01:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d26d15c6c89a...11e1ac3ae085
305 2018-11-07T20:01:25  <bitcoin-git> bitcoin/master b191c7d James O'Beirne: doc: add comment explaining recentRejects-DoS behavior...
306 2018-11-07T20:01:26  <bitcoin-git> bitcoin/master 11e1ac3 MarcoFalke: Merge #14436: doc: add comment explaining recentRejects-DoS behavior...
307 2018-11-07T20:01:26  *** bitcoin-git has left #bitcoin-core-dev
308 2018-11-07T20:12:53  *** ricardobessa has quit IRC
309 2018-11-07T20:29:36  <jnewbery> instagibbs: re generate to P2PK, I don't think so - is there a reason you can't use P2PKH or P2WPKH?
310 2018-11-07T20:31:25  <instagibbs> I used multisig to test my hypothesis instead, thanks anyways
311 2018-11-07T20:32:13  <instagibbs> https://github.com/bitcoin/bitcoin/pull/14678 turns out it was just redundancy, not a bug
312 2018-11-07T20:32:14  *** promag has quit IRC
313 2018-11-07T20:36:21  <ezzzy> are there any up-to-date resources documenting the bitcoin protocol, except of en.bitcoin.it/wiki/Protocol_documentation?
314 2018-11-07T20:47:26  *** jamesob has quit IRC
315 2018-11-07T20:47:43  *** rodarmor has quit IRC
316 2018-11-07T20:47:43  *** Jackielove4u has quit IRC
317 2018-11-07T20:47:51  *** jamesob has joined #bitcoin-core-dev
318 2018-11-07T20:48:03  *** Jackielove4u has joined #bitcoin-core-dev
319 2018-11-07T20:48:14  *** rodarmor has joined #bitcoin-core-dev
320 2018-11-07T21:02:49  *** Guest34309 has quit IRC
321 2018-11-07T21:03:14  *** iphelix has joined #bitcoin-core-dev
322 2018-11-07T21:03:36  *** iphelix is now known as Guest83806
323 2018-11-07T21:06:04  *** BashCo_ has quit IRC
324 2018-11-07T21:09:31  *** Scipio has quit IRC
325 2018-11-07T21:10:54  *** dondreyt has joined #bitcoin-core-dev
326 2018-11-07T21:13:41  <dondreyt> I'm currently in the process of doing some debugging of Bitcoin Core. Is there a way to output a CScript to console, in particular a public key signature as a string representation of hexadecimal?
327 2018-11-07T21:26:40  *** ken2812221 has quit IRC
328 2018-11-07T21:27:32  <phantomcircuit> dondreyt, iirc there's a descodescript rpc call
329 2018-11-07T21:27:36  <phantomcircuit> if that's what you mean
330 2018-11-07T21:27:55  <meshcollider> dondreyt: HexStr(script.begin(), script.end())
331 2018-11-07T21:28:48  <dondreyt> Ah yeah, HexStr is what I'm looking for for. Do you pass in the CScript as a third parameter into that?
332 2018-11-07T21:29:11  <meshcollider> No I'm assuming the CScript is called script
333 2018-11-07T21:29:17  <meshcollider> It returns the string
334 2018-11-07T21:29:36  <dondreyt> meshcollider: I see
335 2018-11-07T21:31:06  <dondreyt> meshcollider: To view the output of this when you call "submitblock" from the console, is there a function I should use?  I see LogPrintf scattered throughout, but I wasn't sure where the outputted to.
336 2018-11-07T21:32:20  <dondreyt> phanetomcircuit: Thanks, I'll check out descodescript as well. Didn't know there was an RPC for that.
337 2018-11-07T21:35:19  <meshcollider> dondreyt: logprintf prints to the debug.log file
338 2018-11-07T21:35:48  <dondreyt> meshcollider: Ahhh okay, makes perfect sense. Thanks
339 2018-11-07T21:36:27  <meshcollider> np
340 2018-11-07T21:37:19  <phantomcircuit> dondreyt, wait what are you trying to do exactly?
341 2018-11-07T21:38:19  <dondreyt> phantomcircuit: Just in the learning phase of seeing how data is represented and passed around. I submitted a block via RPC and have been following it through the validation path.
342 2018-11-07T21:40:04  <phantomcircuit> dondreyt, oh ok, might want to add a bunch of LogPrint statements then using HexStr like meshcollider suggested
343 2018-11-07T21:40:10  <phantomcircuit> then you can decodescript the hexstrings
344 2018-11-07T21:41:06  <dondreyt> phantomcircuit: Okay, I'm going to go ahead and do that.
345 2018-11-07T21:45:11  *** mistergold has quit IRC
346 2018-11-07T21:47:06  *** promag has joined #bitcoin-core-dev
347 2018-11-07T21:52:36  <jamesob> anyone know if jimpo_'s still working on #14121? if not, I'd like to rebase it
348 2018-11-07T21:52:39  <gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
349 2018-11-07T21:56:06  *** bsm117532 has joined #bitcoin-core-dev
350 2018-11-07T22:04:11  *** Murch has quit IRC
351 2018-11-07T22:05:30  *** BashCo1 has joined #bitcoin-core-dev
352 2018-11-07T22:07:34  *** BashCo has joined #bitcoin-core-dev
353 2018-11-07T22:07:49  *** spinza has quit IRC
354 2018-11-07T22:08:50  *** Murch has joined #bitcoin-core-dev
355 2018-11-07T22:09:46  *** BashCo1 has quit IRC
356 2018-11-07T22:11:57  *** BashCo has quit IRC
357 2018-11-07T22:13:16  *** bsm117532 has quit IRC
358 2018-11-07T22:17:51  *** BashCo has joined #bitcoin-core-dev
359 2018-11-07T22:19:06  *** belcher has quit IRC
360 2018-11-07T22:19:47  *** dondreyt has quit IRC
361 2018-11-07T22:20:21  *** Guyver2 has quit IRC
362 2018-11-07T22:22:19  *** BashCo has quit IRC
363 2018-11-07T22:23:06  *** BashCo has joined #bitcoin-core-dev
364 2018-11-07T22:25:05  *** BashCo1 has joined #bitcoin-core-dev
365 2018-11-07T22:27:49  *** BashCo has quit IRC
366 2018-11-07T22:27:58  *** spinza has joined #bitcoin-core-dev
367 2018-11-07T22:29:32  *** penthief12 has joined #bitcoin-core-dev
368 2018-11-07T22:33:25  *** josephnicholas has quit IRC
369 2018-11-07T22:34:01  *** josephnicholas has joined #bitcoin-core-dev
370 2018-11-07T22:34:30  *** penthief12 has quit IRC
371 2018-11-07T22:37:16  *** mika_ has joined #bitcoin-core-dev
372 2018-11-07T22:38:16  *** josephnicholas has quit IRC
373 2018-11-07T22:38:32  *** bralyclow has quit IRC
374 2018-11-07T22:39:19  *** Aaronvan_ has joined #bitcoin-core-dev
375 2018-11-07T22:39:48  *** Murch has quit IRC
376 2018-11-07T22:40:54  *** michaelsdunn1 has quit IRC
377 2018-11-07T22:42:24  *** AaronvanW has quit IRC
378 2018-11-07T22:42:46  *** ezzzy has quit IRC
379 2018-11-07T22:43:24  *** ezzzy has joined #bitcoin-core-dev
380 2018-11-07T22:43:48  *** bralyclow has joined #bitcoin-core-dev
381 2018-11-07T22:44:42  *** BashCo1 has quit IRC
382 2018-11-07T22:46:06  *** Chris_Stewart_5 has quit IRC
383 2018-11-07T22:47:57  *** ezzzy has quit IRC
384 2018-11-07T22:55:33  *** bitconner has joined #bitcoin-core-dev
385 2018-11-07T23:03:05  *** recover has joined #bitcoin-core-dev
386 2018-11-07T23:04:05  *** Murch has joined #bitcoin-core-dev
387 2018-11-07T23:13:03  *** mika_ has quit IRC
388 2018-11-07T23:13:03  *** ezzzy has joined #bitcoin-core-dev
389 2018-11-07T23:17:16  *** ezzzy has quit IRC
390 2018-11-07T23:22:19  *** arubi has quit IRC
391 2018-11-07T23:22:55  *** arubi has joined #bitcoin-core-dev
392 2018-11-07T23:29:02  *** recover_ has joined #bitcoin-core-dev
393 2018-11-07T23:33:17  *** recover__ has joined #bitcoin-core-dev
394 2018-11-07T23:33:18  *** josephnicholas has joined #bitcoin-core-dev
395 2018-11-07T23:34:44  *** spinza has quit IRC
396 2018-11-07T23:38:18  *** josephnicholas has quit IRC
397 2018-11-07T23:38:26  *** spinza has joined #bitcoin-core-dev
398 2018-11-07T23:39:35  *** deaunapaul has joined #bitcoin-core-dev
399 2018-11-07T23:46:09  *** AaronvanW has joined #bitcoin-core-dev
400 2018-11-07T23:49:46  *** Aaronvan_ has quit IRC
401 2018-11-07T23:56:19  *** spinza has quit IRC