1 2018-11-13T00:11:17  *** Krellan has joined #bitcoin-core-dev
  2 2018-11-13T00:12:04  *** michaelsdunn1 has quit IRC
  3 2018-11-13T00:14:28  *** Murch has quit IRC
  4 2018-11-13T00:23:11  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
  5 2018-11-13T00:26:15  *** Ga1aCt1Cz00__ has quit IRC
  6 2018-11-13T00:30:28  *** booyah has quit IRC
  7 2018-11-13T00:30:30  *** booyah_ has joined #bitcoin-core-dev
  8 2018-11-13T00:31:33  *** promag has quit IRC
  9 2018-11-13T00:32:21  <phantomcircuit> sipa, hmm actually just a bad measurement from perf it seems
 10 2018-11-13T00:34:07  *** shesek has joined #bitcoin-core-dev
 11 2018-11-13T00:34:07  *** shesek has joined #bitcoin-core-dev
 12 2018-11-13T00:57:30  *** khush has joined #bitcoin-core-dev
 13 2018-11-13T01:02:11  *** Mutter has joined #bitcoin-core-dev
 14 2018-11-13T01:03:02  *** khush has quit IRC
 15 2018-11-13T01:07:58  *** millerti has quit IRC
 16 2018-11-13T01:10:12  *** Mutter has quit IRC
 17 2018-11-13T01:14:23  <esotericnonsense> sipa: yes!
 18 2018-11-13T01:14:35  <esotericnonsense> 2**90. :o.
 19 2018-11-13T01:50:30  *** dviola has quit IRC
 20 2018-11-13T01:53:16  *** _cryptosignal_me has joined #bitcoin-core-dev
 21 2018-11-13T02:23:23  *** Krellan has quit IRC
 22 2018-11-13T02:36:01  *** rh0nj has quit IRC
 23 2018-11-13T02:37:08  *** rh0nj has joined #bitcoin-core-dev
 24 2018-11-13T03:08:47  *** AaronvanW has quit IRC
 25 2018-11-13T03:11:05  *** timopaulin has joined #bitcoin-core-dev
 26 2018-11-13T03:15:15  *** timopaulin has quit IRC
 27 2018-11-13T03:21:37  *** Giszmo has quit IRC
 28 2018-11-13T03:35:53  *** ken2812221 has quit IRC
 29 2018-11-13T03:46:59  *** grubles_ has joined #bitcoin-core-dev
 30 2018-11-13T03:49:29  *** grubles has quit IRC
 31 2018-11-13T03:58:45  *** promag has joined #bitcoin-core-dev
 32 2018-11-13T04:05:12  *** promag has quit IRC
 33 2018-11-13T04:06:31  *** Roybent has joined #bitcoin-core-dev
 34 2018-11-13T04:09:52  *** Roybent has quit IRC
 35 2018-11-13T04:14:37  *** teardown has quit IRC
 36 2018-11-13T04:17:25  *** grubles__ has joined #bitcoin-core-dev
 37 2018-11-13T04:19:55  *** grubles_ has quit IRC
 38 2018-11-13T05:13:03  *** Roybent has joined #bitcoin-core-dev
 39 2018-11-13T05:14:52  <Roybent> (silicone, saline, string) implants
 40 2018-11-13T05:16:39  *** Roybent has left #bitcoin-core-dev
 41 2018-11-13T06:38:02  *** rh0nj has quit IRC
 42 2018-11-13T06:39:07  *** rh0nj has joined #bitcoin-core-dev
 43 2018-11-13T07:02:47  *** murrayn has joined #bitcoin-core-dev
 44 2018-11-13T07:02:48  *** murrayn has joined #bitcoin-core-dev
 45 2018-11-13T07:06:45  *** state_bits has joined #bitcoin-core-dev
 46 2018-11-13T07:15:56  *** rafalcpp has quit IRC
 47 2018-11-13T07:17:14  *** rafalcpp has joined #bitcoin-core-dev
 48 2018-11-13T07:39:51  *** tryphe_ is now known as tryphe
 49 2018-11-13T07:41:13  *** bitcoin-git has joined #bitcoin-core-dev
 50 2018-11-13T07:41:14  <bitcoin-git> [bitcoin] 1Il1 opened pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
 51 2018-11-13T07:41:14  *** bitcoin-git has left #bitcoin-core-dev
 52 2018-11-13T07:50:53  *** bitcoin-git has joined #bitcoin-core-dev
 53 2018-11-13T07:50:54  <bitcoin-git> [bitcoin] 1Il1 opened pull request #14714: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
 54 2018-11-13T07:50:54  *** bitcoin-git has left #bitcoin-core-dev
 55 2018-11-13T07:52:03  *** Murch has joined #bitcoin-core-dev
 56 2018-11-13T07:52:33  *** bitcoin-git has joined #bitcoin-core-dev
 57 2018-11-13T07:52:34  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47ed24cf8aa7...b60f4e3f0951
 58 2018-11-13T07:52:35  <bitcoin-git> bitcoin/master a6b5ec1 marcoagner: rpc: creates possibility to preserve labels on importprivkey...
 59 2018-11-13T07:52:35  <bitcoin-git> bitcoin/master b60f4e3 Jonas Schnelli: Merge #13381: RPC: creates possibility to preserve labels on importprivkey...
 60 2018-11-13T07:52:36  *** bitcoin-git has left #bitcoin-core-dev
 61 2018-11-13T07:53:04  *** bitcoin-git has joined #bitcoin-core-dev
 62 2018-11-13T07:53:04  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #13381: RPC: creates possibility to preserve labels on importprivkey (master...feature_preserve_labels_on_import) https://github.com/bitcoin/bitcoin/pull/13381
 63 2018-11-13T07:53:04  *** bitcoin-git has left #bitcoin-core-dev
 64 2018-11-13T07:56:56  *** Murch has quit IRC
 65 2018-11-13T08:06:13  *** setpill has joined #bitcoin-core-dev
 66 2018-11-13T08:10:25  *** GoatzMilk has quit IRC
 67 2018-11-13T08:10:44  *** GoatzMilk has joined #bitcoin-core-dev
 68 2018-11-13T08:19:48  *** queip has quit IRC
 69 2018-11-13T08:21:12  *** GoatzMilk has quit IRC
 70 2018-11-13T08:21:18  *** rafalcpp has quit IRC
 71 2018-11-13T08:22:27  *** JackH has quit IRC
 72 2018-11-13T08:23:26  *** GoatzMilk has joined #bitcoin-core-dev
 73 2018-11-13T08:27:20  *** rafalcpp has joined #bitcoin-core-dev
 74 2018-11-13T08:30:20  *** really_cool_dj_n has joined #bitcoin-core-dev
 75 2018-11-13T08:30:26  *** GoatzMilk has quit IRC
 76 2018-11-13T08:31:08  *** queip has joined #bitcoin-core-dev
 77 2018-11-13T08:33:27  *** jungly has joined #bitcoin-core-dev
 78 2018-11-13T08:35:45  *** really_cool_dj_n has quit IRC
 79 2018-11-13T08:36:40  *** GoatzMilk has joined #bitcoin-core-dev
 80 2018-11-13T08:38:14  *** bitcoin-git has joined #bitcoin-core-dev
 81 2018-11-13T08:38:14  <bitcoin-git> [bitcoin] 1Il1 closed pull request #14713: clang-format: do not sort include calls (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14713
 82 2018-11-13T08:38:14  *** bitcoin-git has left #bitcoin-core-dev
 83 2018-11-13T08:41:24  *** timothy has joined #bitcoin-core-dev
 84 2018-11-13T08:41:30  *** GoatzMilk has quit IRC
 85 2018-11-13T08:42:11  *** GoatzMilk has joined #bitcoin-core-dev
 86 2018-11-13T08:44:46  *** bitcoin-git has joined #bitcoin-core-dev
 87 2018-11-13T08:44:47  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b60f4e3f0951...083f53547092
 88 2018-11-13T08:44:47  <bitcoin-git> bitcoin/master 8711cc0 Hennadii Stepanov: qt: Improve BitcoinAmountField class...
 89 2018-11-13T08:44:48  <bitcoin-git> bitcoin/master a16f44c Hennadii Stepanov: qt: Remove "Pay only required fee" checkbox...
 90 2018-11-13T08:44:48  <bitcoin-git> bitcoin/master 083f535 Jonas Schnelli: Merge #14608: qt: Remove the "Pay only required fee..." checkbox...
 91 2018-11-13T08:44:49  *** bitcoin-git has left #bitcoin-core-dev
 92 2018-11-13T08:45:45  *** bitcoin-git has joined #bitcoin-core-dev
 93 2018-11-13T08:45:46  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14608: qt: Remove the "Pay only required fee..." checkbox (master...20181030-remove-payonlyrequiredfee) https://github.com/bitcoin/bitcoin/pull/14608
 94 2018-11-13T08:45:46  *** bitcoin-git has left #bitcoin-core-dev
 95 2018-11-13T08:52:16  *** GoatzMilk has quit IRC
 96 2018-11-13T08:54:25  *** GoatzMilk has joined #bitcoin-core-dev
 97 2018-11-13T09:06:28  *** Victorsueca has quit IRC
 98 2018-11-13T09:06:54  *** phwalkr has joined #bitcoin-core-dev
 99 2018-11-13T09:07:43  *** Victorsueca has joined #bitcoin-core-dev
100 2018-11-13T09:12:21  *** JackH has joined #bitcoin-core-dev
101 2018-11-13T09:28:03  *** wxss has joined #bitcoin-core-dev
102 2018-11-13T09:30:53  *** bitcoin-git has joined #bitcoin-core-dev
103 2018-11-13T09:30:53  <bitcoin-git> [bitcoin] Empact opened pull request #14715: Drop defunct prevector compat handling (master...trivial-prevector) https://github.com/bitcoin/bitcoin/pull/14715
104 2018-11-13T09:30:53  *** bitcoin-git has left #bitcoin-core-dev
105 2018-11-13T09:39:52  *** bitcoin-git has joined #bitcoin-core-dev
106 2018-11-13T09:39:53  <bitcoin-git> [bitcoin] Empact opened pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
107 2018-11-13T09:39:53  *** bitcoin-git has left #bitcoin-core-dev
108 2018-11-13T09:43:42  *** promag has joined #bitcoin-core-dev
109 2018-11-13T09:52:48  *** tryphe_ has joined #bitcoin-core-dev
110 2018-11-13T09:53:47  *** tryphe has quit IRC
111 2018-11-13T10:07:21  <promag> saw this travis error https://pasteboard.co/HMXvxSX.png
112 2018-11-13T10:14:56  <meshcollider> #14690 looks RTM
113 2018-11-13T10:14:57  <gribble> https://github.com/bitcoin/bitcoin/issues/14690 | Throw error if CPubKey is invalid during PSBT keypath serialization by instagibbs · Pull Request #14690 · bitcoin/bitcoin · GitHub
114 2018-11-13T10:21:28  *** spinza has quit IRC
115 2018-11-13T10:30:02  *** cubancorona has quit IRC
116 2018-11-13T10:30:22  *** cubancorona has joined #bitcoin-core-dev
117 2018-11-13T10:31:20  *** booyah has joined #bitcoin-core-dev
118 2018-11-13T10:32:00  *** booyah_ has quit IRC
119 2018-11-13T10:35:07  *** spinza has joined #bitcoin-core-dev
120 2018-11-13T10:40:02  *** rh0nj has quit IRC
121 2018-11-13T10:41:08  *** rh0nj has joined #bitcoin-core-dev
122 2018-11-13T10:41:09  *** _flow_ has quit IRC
123 2018-11-13T10:51:39  *** CodeBlue1776 has quit IRC
124 2018-11-13T10:52:29  *** CodeBlue1776 has joined #bitcoin-core-dev
125 2018-11-13T10:52:49  *** mistergold has joined #bitcoin-core-dev
126 2018-11-13T10:54:37  *** _flow_ has joined #bitcoin-core-dev
127 2018-11-13T11:01:41  *** JackH has quit IRC
128 2018-11-13T11:07:41  *** ExtraCrispy has quit IRC
129 2018-11-13T11:08:10  *** ExtraCrispy has joined #bitcoin-core-dev
130 2018-11-13T11:19:29  *** booyah_ has joined #bitcoin-core-dev
131 2018-11-13T11:21:09  *** booyah has quit IRC
132 2018-11-13T11:30:59  *** AaronvanW has joined #bitcoin-core-dev
133 2018-11-13T11:37:17  *** Aaronvan_ has joined #bitcoin-core-dev
134 2018-11-13T11:40:22  *** AaronvanW has quit IRC
135 2018-11-13T11:40:30  *** josephnicholas has joined #bitcoin-core-dev
136 2018-11-13T11:47:21  *** karoofish27 has joined #bitcoin-core-dev
137 2018-11-13T11:50:39  *** phwalkr has quit IRC
138 2018-11-13T11:51:14  *** phwalkr has joined #bitcoin-core-dev
139 2018-11-13T11:53:17  *** belcher has joined #bitcoin-core-dev
140 2018-11-13T11:55:28  *** phwalkr has quit IRC
141 2018-11-13T12:05:15  *** timothy has quit IRC
142 2018-11-13T12:09:10  *** timothy has joined #bitcoin-core-dev
143 2018-11-13T12:20:32  *** ken2812221 has joined #bitcoin-core-dev
144 2018-11-13T12:21:46  *** shesek has quit IRC
145 2018-11-13T12:22:48  *** shesek has joined #bitcoin-core-dev
146 2018-11-13T12:28:09  *** Deinogalerix21 has joined #bitcoin-core-dev
147 2018-11-13T12:44:39  *** bitcoin-git has joined #bitcoin-core-dev
148 2018-11-13T12:44:40  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/083f53547092...ce7fcc356909
149 2018-11-13T12:44:41  <bitcoin-git> bitcoin/master 4e4de10 Gregory Sanders: Throw error if CPubKey is invalid during PSBT keypath serialization
150 2018-11-13T12:44:41  <bitcoin-git> bitcoin/master ce7fcc3 Wladimir J. van der Laan: Merge #14690: Throw error if CPubKey is invalid during PSBT keypath serialization...
151 2018-11-13T12:44:42  *** bitcoin-git has left #bitcoin-core-dev
152 2018-11-13T12:45:46  *** bitcoin-git has joined #bitcoin-core-dev
153 2018-11-13T12:45:46  <bitcoin-git> [bitcoin] laanwj closed pull request #14690: Throw error if CPubKey is invalid during PSBT keypath serialization (master...check_psbt_pubkey) https://github.com/bitcoin/bitcoin/pull/14690
154 2018-11-13T12:45:46  *** bitcoin-git has left #bitcoin-core-dev
155 2018-11-13T12:46:27  <wumpus> achow101: I've also heard that; only "webhooks" remain :(
156 2018-11-13T12:46:37  *** phwalkr has joined #bitcoin-core-dev
157 2018-11-13T12:49:27  <wumpus> why does microsoft hate IRC :-(((( (no, kidding, this was already planned before the takeover)
158 2018-11-13T12:49:39  *** Deinogalerix21 has quit IRC
159 2018-11-13T12:51:08  *** phwalkr has quit IRC
160 2018-11-13T12:52:57  <wumpus> would be fairly straightforward to make an IRC bot that listens to github events, very similar to the twitter/mastodon bot, but it's yet another moving part it was nice that github handled this
161 2018-11-13T12:55:37  *** bitcoin-git has joined #bitcoin-core-dev
162 2018-11-13T12:55:38  <bitcoin-git> [bitcoin] murrayn opened pull request #14718: Remove unreferenced boost headers and quieten remaining clang warnings (master...clang_warnings) https://github.com/bitcoin/bitcoin/pull/14718
163 2018-11-13T12:55:38  *** bitcoin-git has left #bitcoin-core-dev
164 2018-11-13T13:01:21  *** promag has quit IRC
165 2018-11-13T13:14:13  *** phwalkr has joined #bitcoin-core-dev
166 2018-11-13T13:16:01  *** phwalkr has quit IRC
167 2018-11-13T13:16:13  *** phwalkr has joined #bitcoin-core-dev
168 2018-11-13T13:20:48  *** promag has joined #bitcoin-core-dev
169 2018-11-13T13:35:25  *** Murch has joined #bitcoin-core-dev
170 2018-11-13T13:35:50  *** Murch has quit IRC
171 2018-11-13T13:38:30  *** promag has quit IRC
172 2018-11-13T13:47:22  *** Murch has joined #bitcoin-core-dev
173 2018-11-13T13:52:50  *** bitcoin-git has joined #bitcoin-core-dev
174 2018-11-13T13:52:50  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce7fcc356909...c51e1516a930
175 2018-11-13T13:52:51  <bitcoin-git> bitcoin/master 27154ce 1Il1: util.h: explicitly include required QString header
176 2018-11-13T13:52:51  <bitcoin-git> bitcoin/master c51e151 Wladimir J. van der Laan: Merge #14714: util.h: explicitly include required QString header...
177 2018-11-13T13:52:52  *** bitcoin-git has left #bitcoin-core-dev
178 2018-11-13T13:53:59  *** bitcoin-git has joined #bitcoin-core-dev
179 2018-11-13T13:53:59  <bitcoin-git> [bitcoin] laanwj closed pull request #14714: tests: util.h: explicitly include required QString header (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14714
180 2018-11-13T13:53:59  *** bitcoin-git has left #bitcoin-core-dev
181 2018-11-13T13:57:12  *** promag has joined #bitcoin-core-dev
182 2018-11-13T14:00:09  *** phwalkr has quit IRC
183 2018-11-13T14:15:56  *** Murch has quit IRC
184 2018-11-13T14:20:16  *** Murch has joined #bitcoin-core-dev
185 2018-11-13T14:22:03  *** Guyver2 has joined #bitcoin-core-dev
186 2018-11-13T14:24:08  *** Murch has quit IRC
187 2018-11-13T14:27:02  *** Murch has joined #bitcoin-core-dev
188 2018-11-13T14:33:46  *** Murch has quit IRC
189 2018-11-13T14:36:47  *** CodeBlue1776 has quit IRC
190 2018-11-13T14:37:11  *** CodeBlue1776 has joined #bitcoin-core-dev
191 2018-11-13T14:39:39  *** timothy has quit IRC
192 2018-11-13T14:41:18  *** reardencode has joined #bitcoin-core-dev
193 2018-11-13T14:42:03  *** timothy has joined #bitcoin-core-dev
194 2018-11-13T14:44:13  *** ccook has quit IRC
195 2018-11-13T15:06:11  *** setpill has quit IRC
196 2018-11-13T15:10:22  *** lnostdal_ has joined #bitcoin-core-dev
197 2018-11-13T15:10:46  *** lnostdal has quit IRC
198 2018-11-13T15:11:04  *** lnostdal has joined #bitcoin-core-dev
199 2018-11-13T15:19:22  *** ossifrage has quit IRC
200 2018-11-13T15:26:55  *** bitcoin-git has joined #bitcoin-core-dev
201 2018-11-13T15:26:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c51e1516a930...5d605b27457d
202 2018-11-13T15:26:56  <bitcoin-git> bitcoin/master 6c787d3 MarcoFalke: tests: Make feature_block pass on centos
203 2018-11-13T15:26:56  <bitcoin-git> bitcoin/master fa21568 MarcoFalke: qa: Avoid race in p2p_invalid_block by waiting for the block request
204 2018-11-13T15:26:57  <bitcoin-git> bitcoin/master 5d605b2 MarcoFalke: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request...
205 2018-11-13T15:26:57  *** bitcoin-git has left #bitcoin-core-dev
206 2018-11-13T15:28:09  *** bitcoin-git has joined #bitcoin-core-dev
207 2018-11-13T15:28:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request (master...Mf1811-qaPassOnCentOs) https://github.com/bitcoin/bitcoin/pull/14700
208 2018-11-13T15:28:09  *** bitcoin-git has left #bitcoin-core-dev
209 2018-11-13T15:36:13  *** ossifrage has joined #bitcoin-core-dev
210 2018-11-13T15:37:44  *** michaelsdunn1 has joined #bitcoin-core-dev
211 2018-11-13T15:40:42  <instagibbs> wumpus, would you mind if i made the sigdata const before you consider merging in #14678 ? Or would that "reset" the review? I think it would make intent of function more clear
212 2018-11-13T15:40:44  <gribble> https://github.com/bitcoin/bitcoin/issues/14678 | [wallet] remove redundant KeyOriginInfo access, already done in CreateSig by instagibbs · Pull Request #14678 · bitcoin/bitcoin · GitHub
213 2018-11-13T15:40:58  <wumpus> instagibbs: I don't mind
214 2018-11-13T15:42:04  <wumpus> better to just do it the best way possible than put in a fixup PR just after it's merged, that's frustrating! I think "resetting review" is more of a concern for complex changes
215 2018-11-13T15:43:57  <instagibbs> yep, just making sure
216 2018-11-13T15:53:26  <wumpus>  right
217 2018-11-13T15:57:37  *** josephnicholas has quit IRC
218 2018-11-13T15:58:04  *** josephnicholas has joined #bitcoin-core-dev
219 2018-11-13T16:02:55  *** josephnicholas has quit IRC
220 2018-11-13T16:05:07  *** queip has quit IRC
221 2018-11-13T16:07:51  <phantomcircuit> hmm sipa is definitely right that a sorted vector would be fast
222 2018-11-13T16:07:57  *** rafalcpp has quit IRC
223 2018-11-13T16:09:37  *** rafalcpp has joined #bitcoin-core-dev
224 2018-11-13T16:16:36  *** bitcoin-git has joined #bitcoin-core-dev
225 2018-11-13T16:16:37  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14719: qa: Check specific reject reasons in feature_block (master...Mf1811-qaRejectBlock) https://github.com/bitcoin/bitcoin/pull/14719
226 2018-11-13T16:16:37  *** bitcoin-git has left #bitcoin-core-dev
227 2018-11-13T16:19:48  *** queip has joined #bitcoin-core-dev
228 2018-11-13T16:20:26  *** queip has quit IRC
229 2018-11-13T16:21:36  *** josephnicholas has joined #bitcoin-core-dev
230 2018-11-13T16:22:16  *** gloata has joined #bitcoin-core-dev
231 2018-11-13T16:26:44  *** jarthur has joined #bitcoin-core-dev
232 2018-11-13T16:27:28  *** queip has joined #bitcoin-core-dev
233 2018-11-13T16:28:28  *** promag has quit IRC
234 2018-11-13T16:31:15  *** gloata has quit IRC
235 2018-11-13T16:35:39  *** cubancorona has quit IRC
236 2018-11-13T16:41:39  *** agnjunio has joined #bitcoin-core-dev
237 2018-11-13T16:42:14  *** grubles__ is now known as grubles
238 2018-11-13T16:47:45  *** josephnicholas has quit IRC
239 2018-11-13T16:54:34  *** emilr has joined #bitcoin-core-dev
240 2018-11-13T16:55:43  *** josephnicholas has joined #bitcoin-core-dev
241 2018-11-13T16:55:59  <luke-jr> wumpus: unfortunately, it looks like the existing plugin for github stuff doesn't work with my ljrbot :<
242 2018-11-13T16:56:47  <luke-jr> (and last time I tried to update it to the Limnoria fork, it was a mess)
243 2018-11-13T16:58:09  *** josephnicholas has quit IRC
244 2018-11-13T17:07:57  *** josephnicholas has joined #bitcoin-core-dev
245 2018-11-13T17:08:32  <wumpus> luke-jr: oh too bad
246 2018-11-13T17:12:45  *** josephni_ has joined #bitcoin-core-dev
247 2018-11-13T17:13:35  <luke-jr> although, now that #anime has their own bot, maybe I can delete all the problematic aliases they added and try again, but ... time... :x
248 2018-11-13T17:16:55  *** josephnicholas has quit IRC
249 2018-11-13T17:17:13  *** josephni_ has quit IRC
250 2018-11-13T17:23:37  *** grafcaps has quit IRC
251 2018-11-13T17:26:45  *** grafcaps has joined #bitcoin-core-dev
252 2018-11-13T17:27:25  *** bitcoin-git has joined #bitcoin-core-dev
253 2018-11-13T17:27:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5d605b27457d...e0c6bb782308
254 2018-11-13T17:27:26  <bitcoin-git> bitcoin/master fa3df02 MarcoFalke: travis: Avoid timeout on verify-commits check
255 2018-11-13T17:27:26  <bitcoin-git> bitcoin/master fa5a6ce MarcoFalke: qa: Raise ci test_runner timeout to 40 mins
256 2018-11-13T17:27:27  <bitcoin-git> bitcoin/master e0c6bb7 MarcoFalke: Merge #14705: travis: Avoid timeout on verify-commits check...
257 2018-11-13T17:27:27  *** bitcoin-git has left #bitcoin-core-dev
258 2018-11-13T17:28:34  *** bitcoin-git has joined #bitcoin-core-dev
259 2018-11-13T17:28:35  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14705: travis: Avoid timeout on verify-commits check (master...Mf1811-travisVerifyCommits) https://github.com/bitcoin/bitcoin/pull/14705
260 2018-11-13T17:28:35  *** bitcoin-git has left #bitcoin-core-dev
261 2018-11-13T17:36:56  *** bitcoin-git has joined #bitcoin-core-dev
262 2018-11-13T17:36:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e0c6bb782308...c651265c934c
263 2018-11-13T17:36:57  <bitcoin-git> bitcoin/master fa0d36f MarcoFalke: rpc: Include rpc/util.h where needed for RPCHelpMan...
264 2018-11-13T17:36:57  <bitcoin-git> bitcoin/master fa483e1 MarcoFalke: rpc: Add RPCHelpMan for machine-generated help
265 2018-11-13T17:36:58  <bitcoin-git> bitcoin/master c651265 MarcoFalke: Merge #14530: Use RPCHelpMan to generate RPC doc strings...
266 2018-11-13T17:36:58  *** bitcoin-git has left #bitcoin-core-dev
267 2018-11-13T17:37:54  *** bitcoin-git has joined #bitcoin-core-dev
268 2018-11-13T17:37:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14530: Use RPCHelpMan to generate RPC doc strings (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14530
269 2018-11-13T17:37:54  *** bitcoin-git has left #bitcoin-core-dev
270 2018-11-13T17:38:24  *** cubancorona has joined #bitcoin-core-dev
271 2018-11-13T17:38:30  *** promag has joined #bitcoin-core-dev
272 2018-11-13T17:39:01  *** rh0nj has quit IRC
273 2018-11-13T17:41:19  *** hebasto has joined #bitcoin-core-dev
274 2018-11-13T17:41:59  *** queip has quit IRC
275 2018-11-13T17:42:18  *** go1111111 has quit IRC
276 2018-11-13T17:44:21  *** go1111111 has joined #bitcoin-core-dev
277 2018-11-13T17:46:06  *** ken2812221 has quit IRC
278 2018-11-13T17:49:05  *** queip has joined #bitcoin-core-dev
279 2018-11-13T17:56:27  *** bitcoin-git has joined #bitcoin-core-dev
280 2018-11-13T17:56:27  <bitcoin-git> [bitcoin] Empact closed pull request #14716: Drop unnecessary merkle mutation checks (master...unnecessary-merkle-mutation-checks) https://github.com/bitcoin/bitcoin/pull/14716
281 2018-11-13T17:56:27  *** bitcoin-git has left #bitcoin-core-dev
282 2018-11-13T18:04:36  *** owowo has quit IRC
283 2018-11-13T18:10:10  *** promag has quit IRC
284 2018-11-13T18:10:43  *** owowo has joined #bitcoin-core-dev
285 2018-11-13T18:11:40  *** promag_ has joined #bitcoin-core-dev
286 2018-11-13T18:16:35  *** promag_ has quit IRC
287 2018-11-13T18:17:28  *** grafcaps has quit IRC
288 2018-11-13T18:30:05  *** josephnicholas has joined #bitcoin-core-dev
289 2018-11-13T18:36:40  *** grafcaps has joined #bitcoin-core-dev
290 2018-11-13T18:42:02  *** queip has quit IRC
291 2018-11-13T18:45:52  *** bitconner has joined #bitcoin-core-dev
292 2018-11-13T18:48:38  *** tryphe_ is now known as tryphe
293 2018-11-13T18:53:13  *** queip has joined #bitcoin-core-dev
294 2018-11-13T19:04:55  *** Krellan has joined #bitcoin-core-dev
295 2018-11-13T19:05:28  *** grafcaps has quit IRC
296 2018-11-13T19:07:22  *** timothy has quit IRC
297 2018-11-13T19:09:49  <stevenroose> SendMoney (in rpcwallet) takes a CTxDestination
298 2018-11-13T19:10:04  <stevenroose> Is that somehow compatible with OP_RETURN?
299 2018-11-13T19:10:17  <stevenroose> Doesn't seem to support it.. Is there a workaround?
300 2018-11-13T19:10:24  <stevenroose> sipa: ^?
301 2018-11-13T19:10:44  *** ExtraCrispy has quit IRC
302 2018-11-13T19:10:49  <stevenroose> Or would I need an extra variant for that?
303 2018-11-13T19:11:13  *** ExtraCrispy has joined #bitcoin-core-dev
304 2018-11-13T19:13:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
305 2018-11-13T19:14:54  *** josephnicholas has quit IRC
306 2018-11-13T19:15:41  <stevenroose> hmm, nvm
307 2018-11-13T19:19:24  *** bitcoin-git has joined #bitcoin-core-dev
308 2018-11-13T19:19:24  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
309 2018-11-13T19:19:24  *** bitcoin-git has left #bitcoin-core-dev
310 2018-11-13T19:24:42  *** josephnicholas has joined #bitcoin-core-dev
311 2018-11-13T19:28:45  <wumpus> no, CTxDestination doesn't support send-money-into-the-void destination
312 2018-11-13T19:29:28  *** josephnicholas has quit IRC
313 2018-11-13T19:32:15  <wumpus> could add an extra variant for that, but as there's no address type nor standard representation for that, it's not clear how to fit it in
314 2018-11-13T19:34:46  <wumpus> there's CNoDestination but it's used to signal errors
315 2018-11-13T19:37:33  *** spinza has quit IRC
316 2018-11-13T19:38:11  *** grafcaps has joined #bitcoin-core-dev
317 2018-11-13T19:41:12  *** josephnicholas has joined #bitcoin-core-dev
318 2018-11-13T19:43:17  *** spinza has joined #bitcoin-core-dev
319 2018-11-13T19:46:26  *** josephnicholas has quit IRC
320 2018-11-13T19:49:31  *** booyah_ is now known as booyah
321 2018-11-13T19:54:58  <wumpus> would probably make sense to move reverse_iterator.h and reverselock.h under util/
322 2018-11-13T19:55:44  <sipa> agree
323 2018-11-13T19:55:53  <wumpus> and sync.h maybe
324 2018-11-13T19:59:03  <sipa> what about prevector and limitedmap?
325 2018-11-13T20:01:46  *** josephnicholas has joined #bitcoin-core-dev
326 2018-11-13T20:03:15  <wumpus> those qualify as util too imo
327 2018-11-13T20:05:25  <sipa> oh and indirectmap
328 2018-11-13T20:05:36  <sipa> cuckoocache too
329 2018-11-13T20:05:50  <sipa> they're all completely standalone things
330 2018-11-13T20:07:46  *** Aaronvan_ has quit IRC
331 2018-11-13T20:08:05  <wumpus> yes!
332 2018-11-13T20:08:55  *** AaronvanW has joined #bitcoin-core-dev
333 2018-11-13T20:09:28  <sipa> in a way, things like logging and cmdline parsing are far more application specific than all those things
334 2018-11-13T20:09:58  *** AaronvanW has quit IRC
335 2018-11-13T20:11:12  <wumpus> it would almost warrant a separate 'types' directory for data types which are otherwise independent of the OS and application
336 2018-11-13T20:11:42  <wumpus> though as we already have 'compat', 'support' and 'util' for util-ish things it'd be kinda overkill
337 2018-11-13T20:12:06  <sipa> oh, and span
338 2018-11-13T20:12:07  <wumpus> would make sense to have a clear guideline there first
339 2018-11-13T20:12:24  <sipa> and memusage :)
340 2018-11-13T20:12:39  <sipa> the last one isn't a type definition, but it is completely independent
341 2018-11-13T20:13:21  <sipa> perhaps a directory for all "things that totally could be part of the c++ standard library"
342 2018-11-13T20:13:56  *** josephnicholas has quit IRC
343 2018-11-13T20:14:12  <wumpus> that would include fs.h too
344 2018-11-13T20:14:25  *** josephnicholas has joined #bitcoin-core-dev
345 2018-11-13T20:14:28  <sipa> ah yes
346 2018-11-13T20:14:38  <sipa> utilstrencodings too
347 2018-11-13T20:14:53  <wumpus> it's very much different from the data structure ones though as it pulls in a large part of the OS
348 2018-11-13T20:15:14  <sipa> and utiltime maybe, if we see it as a simpler std::chrono kind of thing
349 2018-11-13T20:15:19  <wumpus> it's more similar to the stuff in compat/ in that regard
350 2018-11-13T20:16:20  <wumpus> but all util* just moved to util/, let's not move them so soon again :)
351 2018-11-13T20:16:32  <sipa> sure
352 2018-11-13T20:16:48  <sipa> but it may make sense for someone to write a proposal for "what things should be in what directory"
353 2018-11-13T20:16:54  <sipa> and then do it all at once
354 2018-11-13T20:17:06  <wumpus> I don't think that ever works in practice for us
355 2018-11-13T20:17:10  <sipa> haha
356 2018-11-13T20:17:13  <sipa> perhaps not
357 2018-11-13T20:17:39  <sipa> but i very much agree we shouldn't "i think these things belong more here, here is a PR to just move that"
358 2018-11-13T20:17:47  <sipa> that ends up going back and forth
359 2018-11-13T20:17:54  <wumpus> I was suprised how quickly people agreed on the util/ move, let's not pushit too far
360 2018-11-13T20:19:27  *** josephnicholas has quit IRC
361 2018-11-13T20:19:54  <wumpus> also true
362 2018-11-13T20:20:25  <wumpus> was just surprised how many utilities there are inthe bare /src/ directory, it really doesnt matter that much
363 2018-11-13T20:20:38  *** AaronvanW has joined #bitcoin-core-dev
364 2018-11-13T20:20:54  <wumpus> certainly not going to open a PR for it :)
365 2018-11-13T20:25:03  *** AaronvanW has quit IRC
366 2018-11-13T20:25:36  <instagibbs> #14679 probably also ready for merge
367 2018-11-13T20:25:38  <gribble> https://github.com/bitcoin/bitcoin/issues/14679 | importmulti: Dont add internal addresses to address book by instagibbs · Pull Request #14679 · bitcoin/bitcoin · GitHub
368 2018-11-13T20:35:20  *** bitcoin-git has joined #bitcoin-core-dev
369 2018-11-13T20:35:20  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c651265c934c...f617e05c38c9
370 2018-11-13T20:35:21  <bitcoin-git> bitcoin/master 7afddfa Gregory Sanders: importmulti: Don't add internal addresses to address book
371 2018-11-13T20:35:21  <bitcoin-git> bitcoin/master f617e05 Wladimir J. van der Laan: Merge #14679: importmulti: Don't add internal addresses to address book...
372 2018-11-13T20:35:22  *** bitcoin-git has left #bitcoin-core-dev
373 2018-11-13T20:36:24  *** bitcoin-git has joined #bitcoin-core-dev
374 2018-11-13T20:36:24  <bitcoin-git> [bitcoin] laanwj closed pull request #14679: importmulti: Don't add internal addresses to address book (master...importmulti_internal_fix) https://github.com/bitcoin/bitcoin/pull/14679
375 2018-11-13T20:36:24  *** bitcoin-git has left #bitcoin-core-dev
376 2018-11-13T20:38:25  *** Tralfaz has joined #bitcoin-core-dev
377 2018-11-13T20:41:48  *** keer4n has quit IRC
378 2018-11-13T20:41:58  *** queip has quit IRC
379 2018-11-13T20:42:04  *** keer4n has joined #bitcoin-core-dev
380 2018-11-13T20:42:04  *** Bullitje_enable has joined #bitcoin-core-dev
381 2018-11-13T20:45:59  *** Bullitje has quit IRC
382 2018-11-13T20:51:54  *** queip has joined #bitcoin-core-dev
383 2018-11-13T21:06:23  *** josephnicholas has joined #bitcoin-core-dev
384 2018-11-13T21:08:27  <MarcoFalke> Moved the discussion into an issue, so we don't loose track of that: #14721
385 2018-11-13T21:08:29  <gribble> https://github.com/bitcoin/bitcoin/issues/14721 | developer doc: Source code organization for standalone (util) functions · Issue #14721 · bitcoin/bitcoin · GitHub
386 2018-11-13T21:11:36  *** Guyver2 has quit IRC
387 2018-11-13T21:21:27  *** AaronvanW has joined #bitcoin-core-dev
388 2018-11-13T21:26:19  *** Aaronvan_ has joined #bitcoin-core-dev
389 2018-11-13T21:30:59  *** AaronvanW has quit IRC
390 2018-11-13T21:40:07  *** rh0nj has joined #bitcoin-core-dev
391 2018-11-13T21:41:42  *** bitcoin-git has joined #bitcoin-core-dev
392 2018-11-13T21:41:42  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14712: wallet: Require a start block in ScanForWalletTransactions (master...Mf1811-walletCrashScan) https://github.com/bitcoin/bitcoin/pull/14712
393 2018-11-13T21:41:42  *** bitcoin-git has left #bitcoin-core-dev
394 2018-11-13T21:41:55  *** queip has quit IRC
395 2018-11-13T21:44:15  *** promag has joined #bitcoin-core-dev
396 2018-11-13T21:47:34  *** Murch has joined #bitcoin-core-dev
397 2018-11-13T21:49:01  *** queip has joined #bitcoin-core-dev
398 2018-11-13T21:51:31  *** bitcoin-git has joined #bitcoin-core-dev
399 2018-11-13T21:51:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f617e05c38c9...8c59bb85f979
400 2018-11-13T21:51:32  <bitcoin-git> bitcoin/master fa0815c Jon Layton: rpc: Correctly name arguments
401 2018-11-13T21:51:33  <bitcoin-git> bitcoin/master 8c59bb8 MarcoFalke: Merge #14720: rpc: Correctly name arguments...
402 2018-11-13T21:51:33  *** bitcoin-git has left #bitcoin-core-dev
403 2018-11-13T21:51:50  *** bitconner has quit IRC
404 2018-11-13T21:52:52  *** bitcoin-git has joined #bitcoin-core-dev
405 2018-11-13T21:52:52  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14720: rpc: Correctly name arguments (master...Mf1811-rpcNameArguments) https://github.com/bitcoin/bitcoin/pull/14720
406 2018-11-13T21:52:52  *** bitcoin-git has left #bitcoin-core-dev
407 2018-11-13T21:53:43  *** bitconner has joined #bitcoin-core-dev
408 2018-11-13T21:58:17  *** mistergold has quit IRC
409 2018-11-13T22:05:54  *** keer4n has quit IRC
410 2018-11-13T22:06:10  *** keer4n has joined #bitcoin-core-dev
411 2018-11-13T22:08:59  *** spinza has quit IRC
412 2018-11-13T22:12:25  *** spinza has joined #bitcoin-core-dev
413 2018-11-13T22:19:42  *** spinza has quit IRC
414 2018-11-13T22:19:43  *** Soligor has quit IRC
415 2018-11-13T22:20:59  *** rhyslindmark has joined #bitcoin-core-dev
416 2018-11-13T22:22:33  *** rhyslindmark has quit IRC
417 2018-11-13T22:28:32  *** spinza has joined #bitcoin-core-dev
418 2018-11-13T22:28:56  *** promag has quit IRC
419 2018-11-13T22:31:08  *** Soligor has joined #bitcoin-core-dev
420 2018-11-13T22:33:35  *** josephnicholas has quit IRC
421 2018-11-13T22:34:03  *** josephnicholas has joined #bitcoin-core-dev
422 2018-11-13T22:35:30  *** Chris_Stewart_5 has quit IRC
423 2018-11-13T22:36:54  *** drexl_ has joined #bitcoin-core-dev
424 2018-11-13T22:37:18  *** murrayn_ has joined #bitcoin-core-dev
425 2018-11-13T22:37:32  *** drexl has quit IRC
426 2018-11-13T22:39:04  *** josephnicholas has quit IRC
427 2018-11-13T22:40:40  *** murrayn has quit IRC
428 2018-11-13T22:41:58  *** queip has quit IRC
429 2018-11-13T22:43:35  *** Mutter has joined #bitcoin-core-dev
430 2018-11-13T22:46:18  *** Murch has quit IRC
431 2018-11-13T22:46:23  *** Mutter has quit IRC
432 2018-11-13T22:48:40  *** queip has joined #bitcoin-core-dev
433 2018-11-13T22:51:43  *** go1111111 has quit IRC
434 2018-11-13T23:04:07  *** bralyclow has joined #bitcoin-core-dev
435 2018-11-13T23:04:13  *** go1111111 has joined #bitcoin-core-dev
436 2018-11-13T23:09:35  <bralyclow> anyone around, posting a question I need your help with...question everyone, I have a bitcoin core full node and wallet, I tried sending a transaction today from a wallet on the node that spent all the BTC in all associated addresses at 1 satoshi per byte and the transaction has been unconfirmed now for over 8 hours which it should have been picked up by this 8 hour timeframe, my question is how can I increase the fee when ther
437 2018-11-13T23:09:36  <bralyclow> e is no BTC left in the wallet and associated addresses and when I try I get this error, "Increasing transaction fee failed (Transaction does not have a change output)" Can I simply deposit 10000 satoshi to an address in that wallet and then try to increase the fee to get it sent, or what can be done and how?
438 2018-11-13T23:10:41  *** ExtraCrispy has quit IRC
439 2018-11-13T23:10:45  <jarthur> Was it all truly spent, or did you get some back in change? And did you opt for a replaceable/RBF transaction?
440 2018-11-13T23:11:04  <jarthur> Also, this is the development channel. #bitcoin is the place to ask general network usage questions.
441 2018-11-13T23:11:11  *** ExtraCrispy has joined #bitcoin-core-dev
442 2018-11-13T23:15:31  <bralyclow> sorry about asking in here, but yes, all spent, no change or change address created as the fee was to be taken from the total left in that wallet, I did mark the transaction as enable RBF
443 2018-11-13T23:21:45  *** promag has joined #bitcoin-core-dev
444 2018-11-13T23:33:27  *** TheRec has quit IRC
445 2018-11-13T23:34:10  *** TheRec has joined #bitcoin-core-dev
446 2018-11-13T23:34:11  *** TheRec has joined #bitcoin-core-dev
447 2018-11-13T23:37:39  *** bitcoin-git has joined #bitcoin-core-dev
448 2018-11-13T23:37:39  <bitcoin-git> [bitcoin] hebasto opened pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
449 2018-11-13T23:37:39  *** bitcoin-git has left #bitcoin-core-dev
450 2018-11-13T23:42:01  *** queip has quit IRC
451 2018-11-13T23:44:03  *** murrayn has joined #bitcoin-core-dev
452 2018-11-13T23:44:09  *** murrayn_ has quit IRC
453 2018-11-13T23:51:15  *** queip has joined #bitcoin-core-dev
454 2018-11-13T23:54:00  *** josephnicholas has joined #bitcoin-core-dev
455 2018-11-13T23:58:31  *** josephnicholas has quit IRC