1 2018-11-14T00:07:24  *** ken2812221 has joined #bitcoin-core-dev
  2 2018-11-14T00:09:52  <esotericnonsense> what's the recommended way to construct transactions via RPC if you want to confirm the amounts involved before sending?
  3 2018-11-14T00:10:00  <esotericnonsense> createrawtransaction, decoderawtransaction?
  4 2018-11-14T00:11:28  *** jarthur_ has joined #bitcoin-core-dev
  5 2018-11-14T00:12:59  *** hebasto has quit IRC
  6 2018-11-14T00:15:26  *** jarthur has quit IRC
  7 2018-11-14T00:16:15  *** jarthur_ has quit IRC
  8 2018-11-14T00:16:53  *** promag_ has joined #bitcoin-core-dev
  9 2018-11-14T00:17:03  <sipa> esotericnonsense: createraw, fundraw, signraw, sendraw
 10 2018-11-14T00:17:31  <luke-jr> It's pretty fun to draw transactions.
 11 2018-11-14T00:17:42  <sipa> esotericnonsense: or (at your own risk, there are some kinks), walletcreatefundedpsbt, decodepsbt, walletprocesspsbt, finalizepsbt, sendrawtransaction
 12 2018-11-14T00:18:02  <sipa> decodepsbt will also show things like fee
 13 2018-11-14T00:18:16  *** promag has quit IRC
 14 2018-11-14T00:24:15  *** dviola has joined #bitcoin-core-dev
 15 2018-11-14T00:26:18  <esotericnonsense> hm. so when createrawtransaction states that inputs are required, it actually just means the parameter
 16 2018-11-14T00:26:30  <esotericnonsense> e.g. it's reasonable to "createrawtransaction [] ..." and then fund it
 17 2018-11-14T00:29:48  <sipa> esotericnonsense: probably move to #bitcoin
 18 2018-11-14T00:39:18  *** promag_ has quit IRC
 19 2018-11-14T00:40:47  *** intcat has quit IRC
 20 2018-11-14T00:42:01  *** queip has quit IRC
 21 2018-11-14T00:42:42  *** intcat has joined #bitcoin-core-dev
 22 2018-11-14T00:44:42  *** josephnicholas has joined #bitcoin-core-dev
 23 2018-11-14T00:49:49  *** josephnicholas has quit IRC
 24 2018-11-14T00:52:55  *** michaelsdunn1 has quit IRC
 25 2018-11-14T00:53:20  *** queip has joined #bitcoin-core-dev
 26 2018-11-14T01:03:16  *** dviola has quit IRC
 27 2018-11-14T01:10:07  *** cubancorona has quit IRC
 28 2018-11-14T01:10:29  *** cubancorona has joined #bitcoin-core-dev
 29 2018-11-14T01:14:44  *** dviola has joined #bitcoin-core-dev
 30 2018-11-14T01:14:59  *** dviola has joined #bitcoin-core-dev
 31 2018-11-14T01:41:13  *** ccook has joined #bitcoin-core-dev
 32 2018-11-14T01:42:02  *** queip has quit IRC
 33 2018-11-14T01:42:04  *** Tralfaz has quit IRC
 34 2018-11-14T01:42:43  *** Tralfaz has joined #bitcoin-core-dev
 35 2018-11-14T01:42:58  *** agnjunio has quit IRC
 36 2018-11-14T01:45:51  *** josephnicholas has joined #bitcoin-core-dev
 37 2018-11-14T01:46:49  *** Tralfaz has quit IRC
 38 2018-11-14T01:47:59  *** bralyclo_ has joined #bitcoin-core-dev
 39 2018-11-14T01:48:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 40 2018-11-14T01:48:56  *** queip has joined #bitcoin-core-dev
 41 2018-11-14T01:50:14  *** josephnicholas has quit IRC
 42 2018-11-14T01:50:37  *** bralyclow has quit IRC
 43 2018-11-14T02:04:52  *** zhangzf has joined #bitcoin-core-dev
 44 2018-11-14T02:07:58  <zhangzf> Hi everybody! Bitcoin core can run  on Android?
 45 2018-11-14T02:08:28  <phantomcircuit> zhangzf, https://github.com/greenaddress/abcore
 46 2018-11-14T02:09:08  <zhangzf> phantomcircuit, Thanks
 47 2018-11-14T02:09:14  *** bitcoin-git has joined #bitcoin-core-dev
 48 2018-11-14T02:09:15  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14726: Use RPCHelpMan for all RPCs (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14726
 49 2018-11-14T02:09:15  *** bitcoin-git has left #bitcoin-core-dev
 50 2018-11-14T02:14:29  *** kexkey has joined #bitcoin-core-dev
 51 2018-11-14T02:15:22  *** dviola has quit IRC
 52 2018-11-14T02:17:06  <zhangzf> #bitcoin
 53 2018-11-14T02:17:59  *** michaelsdunn1 has joined #bitcoin-core-dev
 54 2018-11-14T02:20:53  *** Chris_Stewart_5 has quit IRC
 55 2018-11-14T02:33:24  *** Victorsueca has quit IRC
 56 2018-11-14T02:34:33  *** Victorsueca has joined #bitcoin-core-dev
 57 2018-11-14T02:41:55  *** queip has quit IRC
 58 2018-11-14T02:42:23  *** zrc has joined #bitcoin-core-dev
 59 2018-11-14T02:52:05  *** queip has joined #bitcoin-core-dev
 60 2018-11-14T02:59:54  *** michaelsdunn1 has quit IRC
 61 2018-11-14T03:03:00  *** michaelsdunn1 has joined #bitcoin-core-dev
 62 2018-11-14T03:05:01  *** rh0nj has quit IRC
 63 2018-11-14T03:06:09  *** rh0nj has joined #bitcoin-core-dev
 64 2018-11-14T03:07:47  *** michaelsdunn1 has quit IRC
 65 2018-11-14T03:13:05  *** michaelsdunn1 has joined #bitcoin-core-dev
 66 2018-11-14T03:16:11  *** face has joined #bitcoin-core-dev
 67 2018-11-14T03:18:03  *** Krellan has quit IRC
 68 2018-11-14T03:18:10  *** michaelsdunn1 has quit IRC
 69 2018-11-14T03:19:00  *** michaelsdunn1 has joined #bitcoin-core-dev
 70 2018-11-14T03:24:21  *** michaelsdunn1 has quit IRC
 71 2018-11-14T03:33:28  <zhangzf> The ABCore download all the blocks and cann't run on 3G or 4G networks
 72 2018-11-14T03:33:49  <zhangzf> Can I set it run as a spv node?
 73 2018-11-14T03:34:26  <sipa> zhangzf: no, Bitcoin Core always runs as a full node
 74 2018-11-14T03:36:27  <zhangzf> sipa, Thanks.
 75 2018-11-14T03:36:28  <gmaxwell> zhangzf: it can run on 3g/4g networks fine, though it transfers a lot of data for the initial sync to it would probably be best to do that over wifi.
 76 2018-11-14T03:38:43  <zhangzf> Where is a wallet it can run as spv node, it do not download all the blocks, it just connect a server get the data.
 77 2018-11-14T03:42:09  *** queip has quit IRC
 78 2018-11-14T03:46:13  *** tryphe has quit IRC
 79 2018-11-14T03:46:36  *** tryphe has joined #bitcoin-core-dev
 80 2018-11-14T03:50:41  *** queip has joined #bitcoin-core-dev
 81 2018-11-14T03:54:16  *** michaelsdunn1 has joined #bitcoin-core-dev
 82 2018-11-14T03:59:45  <booyah> zhangzf: electrum is popular wallet, works on androids too
 83 2018-11-14T04:02:59  <zhangzf> booyah, Thanks.
 84 2018-11-14T04:03:38  *** jarthur has joined #bitcoin-core-dev
 85 2018-11-14T04:06:15  <booyah> zhangzf: also, with such usage questions come to #bitcoin - there are more users to help. Also this channel here is only for developers of bitcoin itself so it's not good to ask here
 86 2018-11-14T04:08:28  <zhangzf> booyah, Ok. I got it.
 87 2018-11-14T04:16:09  *** zrc has quit IRC
 88 2018-11-14T04:17:09  *** spinza has quit IRC
 89 2018-11-14T04:27:04  *** Aaronvan_ has quit IRC
 90 2018-11-14T04:29:50  *** grubles has quit IRC
 91 2018-11-14T04:30:37  *** michaelsdunn1 has quit IRC
 92 2018-11-14T04:35:26  *** spinza has joined #bitcoin-core-dev
 93 2018-11-14T04:37:27  *** AaronvanW has joined #bitcoin-core-dev
 94 2018-11-14T04:42:00  *** queip has quit IRC
 95 2018-11-14T04:42:03  *** AaronvanW has quit IRC
 96 2018-11-14T04:50:54  *** Krellan has joined #bitcoin-core-dev
 97 2018-11-14T04:51:25  *** Krellan has joined #bitcoin-core-dev
 98 2018-11-14T04:52:47  *** queip has joined #bitcoin-core-dev
 99 2018-11-14T05:07:38  *** bralyclo_ has quit IRC
100 2018-11-14T05:08:06  *** bralyclow has joined #bitcoin-core-dev
101 2018-11-14T05:21:21  *** grubles has joined #bitcoin-core-dev
102 2018-11-14T05:36:15  *** Ga1aCt1Cz00__ has joined #bitcoin-core-dev
103 2018-11-14T05:36:52  *** ppisati has quit IRC
104 2018-11-14T05:38:52  *** AaronvanW has joined #bitcoin-core-dev
105 2018-11-14T05:39:15  *** Ga1aCt1Cz00_ has quit IRC
106 2018-11-14T05:43:34  *** ppisati has joined #bitcoin-core-dev
107 2018-11-14T05:44:20  *** AaronvanW has quit IRC
108 2018-11-14T05:46:22  *** drexl_ has quit IRC
109 2018-11-14T06:02:59  *** ctrlbreak has quit IRC
110 2018-11-14T06:13:06  *** jarthur has quit IRC
111 2018-11-14T06:13:45  *** jarthur has joined #bitcoin-core-dev
112 2018-11-14T06:27:45  *** michaelsdunn1 has joined #bitcoin-core-dev
113 2018-11-14T06:29:11  *** _cryptosignal_me has quit IRC
114 2018-11-14T06:29:29  *** _cryptosignal_me has joined #bitcoin-core-dev
115 2018-11-14T06:32:17  *** Krellan has quit IRC
116 2018-11-14T06:32:40  *** Krellan has joined #bitcoin-core-dev
117 2018-11-14T06:46:02  *** rh0nj has quit IRC
118 2018-11-14T06:47:07  *** rh0nj has joined #bitcoin-core-dev
119 2018-11-14T07:03:05  *** jarthur has quit IRC
120 2018-11-14T07:06:23  *** jarthur has joined #bitcoin-core-dev
121 2018-11-14T07:10:39  *** michaelsdunn1 has quit IRC
122 2018-11-14T07:14:20  *** jarthur has quit IRC
123 2018-11-14T07:20:54  *** zrc has joined #bitcoin-core-dev
124 2018-11-14T07:24:23  *** zrc has quit IRC
125 2018-11-14T07:25:39  *** bitconner has quit IRC
126 2018-11-14T07:27:27  *** CodeBlue1776 has quit IRC
127 2018-11-14T07:27:49  *** CodeBlue1776 has joined #bitcoin-core-dev
128 2018-11-14T07:37:58  *** shanmugam has joined #bitcoin-core-dev
129 2018-11-14T07:38:08  <shanmugam> Ho
130 2018-11-14T07:38:31  <shanmugam> any  BTC Testnet wallet accessable online
131 2018-11-14T07:38:40  *** shanmugam has quit IRC
132 2018-11-14T07:39:19  *** shanmugam has joined #bitcoin-core-dev
133 2018-11-14T07:39:24  <shanmugam> any  BTC Testnet wallet accessable online
134 2018-11-14T07:40:27  *** zrc has joined #bitcoin-core-dev
135 2018-11-14T07:41:59  *** queip has quit IRC
136 2018-11-14T07:45:42  *** hebasto has joined #bitcoin-core-dev
137 2018-11-14T07:57:10  *** queip has joined #bitcoin-core-dev
138 2018-11-14T07:59:15  *** zrc has quit IRC
139 2018-11-14T08:00:05  *** zrc has joined #bitcoin-core-dev
140 2018-11-14T08:00:11  *** bitconner has joined #bitcoin-core-dev
141 2018-11-14T08:00:18  *** Krellan has quit IRC
142 2018-11-14T08:04:33  *** shanmugam has quit IRC
143 2018-11-14T08:30:04  *** zrc has quit IRC
144 2018-11-14T08:42:05  *** queip has quit IRC
145 2018-11-14T08:44:08  *** Murch has joined #bitcoin-core-dev
146 2018-11-14T08:45:59  *** Murch has quit IRC
147 2018-11-14T08:52:16  *** queip has joined #bitcoin-core-dev
148 2018-11-14T08:52:50  <wumpus> not sure how you mean that, but if you need testnet coins just say so and someone will send you some
149 2018-11-14T09:03:43  *** phwalkr has joined #bitcoin-core-dev
150 2018-11-14T09:03:56  *** setpill has joined #bitcoin-core-dev
151 2018-11-14T09:07:33  *** michaelsdunn1 has joined #bitcoin-core-dev
152 2018-11-14T09:15:03  *** michaelsdunn1 has quit IRC
153 2018-11-14T09:16:42  *** AaronvanW has joined #bitcoin-core-dev
154 2018-11-14T09:17:37  *** booyah has quit IRC
155 2018-11-14T09:18:33  *** booyah has joined #bitcoin-core-dev
156 2018-11-14T09:21:15  *** AaronvanW has quit IRC
157 2018-11-14T09:24:46  *** AaronvanW has joined #bitcoin-core-dev
158 2018-11-14T09:29:24  *** AaronvanW has quit IRC
159 2018-11-14T09:32:57  *** IGHOR has quit IRC
160 2018-11-14T09:41:59  *** queip has quit IRC
161 2018-11-14T09:45:17  *** murrayn has quit IRC
162 2018-11-14T09:47:00  *** Guyver2 has joined #bitcoin-core-dev
163 2018-11-14T09:52:22  *** queip has joined #bitcoin-core-dev
164 2018-11-14T10:01:51  *** Krellan has joined #bitcoin-core-dev
165 2018-11-14T10:05:14  *** kexkey has quit IRC
166 2018-11-14T10:05:33  *** promag has joined #bitcoin-core-dev
167 2018-11-14T10:07:50  *** ap4lmtree has quit IRC
168 2018-11-14T10:10:35  *** murrayn has joined #bitcoin-core-dev
169 2018-11-14T10:10:35  *** murrayn has joined #bitcoin-core-dev
170 2018-11-14T10:14:47  <wumpus> MarcoFalke: thanks
171 2018-11-14T10:16:10  *** josephnicholas has joined #bitcoin-core-dev
172 2018-11-14T10:19:16  *** Krellan has quit IRC
173 2018-11-14T10:33:24  *** timothy has joined #bitcoin-core-dev
174 2018-11-14T10:39:08  *** zhangzf has quit IRC
175 2018-11-14T10:41:56  *** queip has quit IRC
176 2018-11-14T10:47:12  *** fanquake has joined #bitcoin-core-dev
177 2018-11-14T10:49:27  *** queip has joined #bitcoin-core-dev
178 2018-11-14T10:52:08  *** spinza has quit IRC
179 2018-11-14T10:55:45  *** fanquake has quit IRC
180 2018-11-14T10:55:50  *** josephnicholas has joined #bitcoin-core-dev
181 2018-11-14T10:57:17  *** fanquake has joined #bitcoin-core-dev
182 2018-11-14T10:58:51  *** josephnicholas has quit IRC
183 2018-11-14T11:00:16  *** spinza has joined #bitcoin-core-dev
184 2018-11-14T11:12:18  *** michaelsdunn1 has joined #bitcoin-core-dev
185 2018-11-14T11:12:18  *** michaelsdunn1 has quit IRC
186 2018-11-14T11:12:18  *** michaelsdunn1 has joined #bitcoin-core-dev
187 2018-11-14T11:12:51  *** drexl_ has joined #bitcoin-core-dev
188 2018-11-14T11:18:01  *** Murch has joined #bitcoin-core-dev
189 2018-11-14T11:19:37  <meshcollider> wumpus: #14698 looks RTM
190 2018-11-14T11:19:39  <gribble> https://github.com/bitcoin/bitcoin/issues/14698 | build: Add bitcoin-tx.exe into Windows installer by ken2812221 · Pull Request #14698 · bitcoin/bitcoin · GitHub
191 2018-11-14T11:22:59  *** AaronvanW has joined #bitcoin-core-dev
192 2018-11-14T11:24:00  *** mistergold has joined #bitcoin-core-dev
193 2018-11-14T11:24:31  *** ghost43 has quit IRC
194 2018-11-14T11:24:59  *** ghost43 has joined #bitcoin-core-dev
195 2018-11-14T11:28:19  *** Murch has quit IRC
196 2018-11-14T11:39:23  <wumpus> has anyone used the python type-annotation stuff yet? just curious about it
197 2018-11-14T11:39:34  <wumpus> meshcollider: thanks
198 2018-11-14T11:41:56  *** queip has quit IRC
199 2018-11-14T11:42:15  <wumpus> (I mean PEP 484/526 "type hinting")
200 2018-11-14T11:42:49  *** bitcoin-git has joined #bitcoin-core-dev
201 2018-11-14T11:42:50  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c59bb85f979...33cd94279cd6
202 2018-11-14T11:42:51  <bitcoin-git> bitcoin/master 5c5902a Chun Kuan Lee: build: Add bitcoin-tx.exe into Windows installer
203 2018-11-14T11:42:51  <bitcoin-git> bitcoin/master 33cd942 Wladimir J. van der Laan: Merge #14698: build: Add bitcoin-tx.exe into Windows installer...
204 2018-11-14T11:42:51  *** bitcoin-git has left #bitcoin-core-dev
205 2018-11-14T11:43:57  *** bitcoin-git has joined #bitcoin-core-dev
206 2018-11-14T11:43:57  <bitcoin-git> [bitcoin] laanwj closed pull request #14698: build: Add bitcoin-tx.exe into Windows installer (master...win-bitcoin-tx) https://github.com/bitcoin/bitcoin/pull/14698
207 2018-11-14T11:43:57  *** bitcoin-git has left #bitcoin-core-dev
208 2018-11-14T11:44:51  <fanquake> wumpus a little, although not on anything btc related
209 2018-11-14T11:46:10  <fanquake> Hopefully something that'll end up in the test framework
210 2018-11-14T11:46:11  <wumpus> fanquake: yes I was asking in general, not so much btc related, does it help catch mistakes at 'compile' time?
211 2018-11-14T11:46:43  <wumpus> (e.g. before the program even runs?)
212 2018-11-14T11:47:39  <fanquake> wumpus you add the "type hints", then can use something like http://mypy-lang.org/, to do the checking
213 2018-11-14T11:47:48  <wumpus> or well.. guess linters use the information for a kind of static checking?
214 2018-11-14T11:47:50  <wumpus> right
215 2018-11-14T11:48:22  <fanquake> As soon as we require Python >3.5, we could probably start using it in some capacity https://docs.python.org/3/library/typing.html
216 2018-11-14T11:48:24  <wumpus> so that part isn't integrated into python 3.5+, just the type annotation module
217 2018-11-14T11:48:43  <wumpus> yes, exactly
218 2018-11-14T11:48:44  <fanquake> Correct, mypy is an external tool
219 2018-11-14T11:51:06  *** queip has joined #bitcoin-core-dev
220 2018-11-14T11:51:15  *** bitconner has quit IRC
221 2018-11-14T11:51:17  <wumpus> thanks, that's kind of what I wanted to know! I see we require python 3.4 at the moment, so it's just one minor version away
222 2018-11-14T11:53:20  <fanquake> wumpus np
223 2018-11-14T11:56:36  <wumpus> ___llvm_gcov_writeout?!
224 2018-11-14T11:56:43  <wumpus> (#14727)
225 2018-11-14T11:56:44  <gribble> https://github.com/bitcoin/bitcoin/issues/14727 | Mac OSX High Sierra 10.13.6 Build error · Issue #14727 · bitcoin/bitcoin · GitHub
226 2018-11-14T11:57:22  <wumpus> looks like they inadvertently enable a coverage checker (but no such mention in the build steps)
227 2018-11-14T11:57:57  <wumpus> then don't link against its runtime
228 2018-11-14T11:58:19  <fanquake> Looks like it doesn't even finish compiling?
229 2018-11-14T11:59:06  *** shesek has quit IRC
230 2018-11-14T11:59:35  <wumpus> it fails during link of bitcoind
231 2018-11-14T12:00:04  <fanquake> ah yea
232 2018-11-14T12:00:12  *** shesek has joined #bitcoin-core-dev
233 2018-11-14T12:01:03  *** Victorsueca has quit IRC
234 2018-11-14T12:02:15  *** Victorsueca has joined #bitcoin-core-dev
235 2018-11-14T12:03:11  <fanquake> #14723 I don't think we've ever (even tried) to support the official Qt installed binaries. At least, we call it out as not working on macOS
236 2018-11-14T12:03:12  <gribble> https://github.com/bitcoin/bitcoin/issues/14723 | Build with official Qt binary installer fails · Issue #14723 · bitcoin/bitcoin · GitHub
237 2018-11-14T12:05:32  *** phwalkr has quit IRC
238 2018-11-14T12:05:55  <wumpus> no, I don't think so either, just the homebrew
239 2018-11-14T12:06:21  *** phwalkr has joined #bitcoin-core-dev
240 2018-11-14T12:08:07  <wumpus> we document that in the build instructions as far as I know, if people try unsupported stuff that's fine but it probably doesn't warrant an issue
241 2018-11-14T12:08:41  *** bitconner has joined #bitcoin-core-dev
242 2018-11-14T12:11:45  *** phwalkr has quit IRC
243 2018-11-14T12:11:55  <fanquake> wumpus I think 14725 is ok to merge
244 2018-11-14T12:12:50  <wumpus> yes
245 2018-11-14T12:13:13  <fanquake> Release notes, and possibly a further bump?, can come later on
246 2018-11-14T12:13:26  *** bitconner has quit IRC
247 2018-11-14T12:13:53  *** bitcoin-git has joined #bitcoin-core-dev
248 2018-11-14T12:13:54  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/33cd94279cd6...74213fa4d13e
249 2018-11-14T12:13:54  <bitcoin-git> bitcoin/master 2bc3f11 Hennadii Stepanov: Bump the minimum Qt version to 5.2
250 2018-11-14T12:13:55  <bitcoin-git> bitcoin/master 74213fa Wladimir J. van der Laan: Merge #14725: qt: Bump the minimum Qt version to 5.2...
251 2018-11-14T12:13:55  *** bitcoin-git has left #bitcoin-core-dev
252 2018-11-14T12:14:53  *** bitcoin-git has joined #bitcoin-core-dev
253 2018-11-14T12:14:54  <bitcoin-git> [bitcoin] laanwj closed pull request #14725: qt: Bump the minimum Qt version to 5.2 (master...20181113-bump-qt52) https://github.com/bitcoin/bitcoin/pull/14725
254 2018-11-14T12:14:54  *** bitcoin-git has left #bitcoin-core-dev
255 2018-11-14T12:16:17  <wumpus> well at least this is is non-controversial, 5.2 is old as the hills
256 2018-11-14T12:17:26  <murrayn> lol
257 2018-11-14T12:18:19  <fanquake> wumpus I've updated 13478 and added a release notes tag as a reminder
258 2018-11-14T12:19:01  <fanquake> Just realised that pr should have bump qt in dependencies.md heh
259 2018-11-14T12:19:11  <wumpus> discussion in #13478 was mostly agreeing on 5.4/5.5 until someone came and apparently screamed that 5.2.1 is LTS and offered to pay for longer term support, now everyone is just confused
260 2018-11-14T12:19:13  <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
261 2018-11-14T12:19:51  <fanquake> I can't imagine we'll stick with 5.2.1, no pay for any support
262 2018-11-14T12:19:53  <fanquake> *nor
263 2018-11-14T12:23:30  <wumpus> personally I think in the case of the GUI (moreso than say, boost) it would make sense to narrow down the supported versions and make sure things work *really well* with them, instead of having a long range of supported versions which probably no one really checks
264 2018-11-14T12:23:56  <wumpus> e.g., as automated testing is more or less out of the question, and there is tons of so-so workarounds
265 2018-11-14T12:26:21  <murrayn> yes, agreed
266 2018-11-14T12:26:24  <wumpus> there's so many interactions between operating systems and UI, say newer features such as HiDPY, environments that may or may not support tray icons, and so on
267 2018-11-14T12:27:07  *** bitconner has joined #bitcoin-core-dev
268 2018-11-14T12:27:21  <fanquake> wumpus Last two LTS versions would be 5.6 and 5.9, so should we make the minimum 5.6 in 0.18.0?
269 2018-11-14T12:27:28  <wumpus> I guess it will be even worse for MacOSX once Qt supports the dark mode properly, and we signal support for it in the descriptor, that will pretty much mean there's only one supported version
270 2018-11-14T12:27:33  <fanquake> However, 5.12 LTS will be released befoer 0.18.0, so could make it 5.9+?
271 2018-11-14T12:27:50  <fanquake> Yea that'll start to get a bit messy
272 2018-11-14T12:28:11  <fanquake> and use 5.12 in depends etc
273 2018-11-14T12:28:16  <wumpus> (luckily that iis irrelevalt for other platforms...)
274 2018-11-14T12:29:09  <wumpus> fanquake: hehe, that's yet another proposal
275 2018-11-14T12:29:21  <wumpus> fanquake: would make sense to me though
276 2018-11-14T12:29:36  <wumpus> maybe hebasto can tell us what he's using 5.2.1 for and why
277 2018-11-14T12:31:15  <wumpus> anyhow this is an endless discussion, glad we got agreed on at least 5.2 ;-)
278 2018-11-14T12:31:59  <fanquake> heh
279 2018-11-14T12:32:10  *** bitconner has quit IRC
280 2018-11-14T12:32:17  <fanquake> wumpus #14701 is a trvial change, but one that fixes some user confusion
281 2018-11-14T12:32:20  <gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
282 2018-11-14T12:33:12  <wumpus> fanquake: would you want to add the RC as well?
283 2018-11-14T12:34:04  <wumpus> or wait, didn't we merge something that keeps track of RCs in configure.ac?
284 2018-11-14T12:34:53  <wumpus> oh that's  #14612
285 2018-11-14T12:34:55  <gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
286 2018-11-14T12:34:58  <wumpus> might want to hold it off until that's merged
287 2018-11-14T12:38:04  *** Murch has joined #bitcoin-core-dev
288 2018-11-14T12:38:38  *** bitconner has joined #bitcoin-core-dev
289 2018-11-14T12:38:44  <fanquake> wumpus makes sense
290 2018-11-14T12:39:37  <fanquake> I think #14704 is ok to go as well
291 2018-11-14T12:39:43  <gribble> https://github.com/bitcoin/bitcoin/issues/14704 | doc: add detached release notes for #14060 by mruddy · Pull Request #14704 · bitcoin/bitcoin · GitHub
292 2018-11-14T12:40:46  *** promag has quit IRC
293 2018-11-14T12:41:24  <fanquake> Also #14688
294 2018-11-14T12:41:26  <gribble> https://github.com/bitcoin/bitcoin/issues/14688 | Doc: update release notes for changes since 0.17.0 branch by harding · Pull Request #14688 · bitcoin/bitcoin · GitHub
295 2018-11-14T12:42:05  *** queip has quit IRC
296 2018-11-14T12:42:10  *** Murch has quit IRC
297 2018-11-14T12:43:19  *** bitcoin-git has joined #bitcoin-core-dev
298 2018-11-14T12:43:19  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/74213fa4d13e...99a3e6f0b1ab
299 2018-11-14T12:43:20  <bitcoin-git> bitcoin/master 6062f0e David A. Harding: Release notes: update notes through to 11e1ac3ae08
300 2018-11-14T12:43:20  <bitcoin-git> bitcoin/master ba8f0c6 David A. Harding: Release notes: integrate detached release notes
301 2018-11-14T12:43:21  <bitcoin-git> bitcoin/master 99a3e6f Wladimir J. van der Laan: Merge #14688: Doc: update release notes for changes since 0.17.0 branch...
302 2018-11-14T12:43:21  *** bitcoin-git has left #bitcoin-core-dev
303 2018-11-14T12:44:19  *** bitcoin-git has joined #bitcoin-core-dev
304 2018-11-14T12:44:20  <bitcoin-git> [bitcoin] laanwj closed pull request #14688: Doc: update release notes for changes since 0.17.0 branch (master...2018-11-release-notes) https://github.com/bitcoin/bitcoin/pull/14688
305 2018-11-14T12:44:20  *** bitcoin-git has left #bitcoin-core-dev
306 2018-11-14T12:44:30  *** bitcoin-git has joined #bitcoin-core-dev
307 2018-11-14T12:44:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99a3e6f0b1ab...2e8f9dc2bbb1
308 2018-11-14T12:44:31  <bitcoin-git> bitcoin/master 86cddf0 mruddy: doc: add detached release notes for #14060
309 2018-11-14T12:44:31  <bitcoin-git> bitcoin/master 2e8f9dc Wladimir J. van der Laan: Merge #14704: doc: add detached release notes for #14060...
310 2018-11-14T12:44:32  *** bitcoin-git has left #bitcoin-core-dev
311 2018-11-14T12:45:29  *** bitcoin-git has joined #bitcoin-core-dev
312 2018-11-14T12:45:30  <bitcoin-git> [bitcoin] laanwj closed pull request #14704: doc: add detached release notes for #14060 (master...zmq-release-notes) https://github.com/bitcoin/bitcoin/pull/14704
313 2018-11-14T12:45:30  *** bitcoin-git has left #bitcoin-core-dev
314 2018-11-14T12:47:51  <wumpus> kind of forgot that the plist is programatically generated, so once dark mode support lands in qt it could set NSRequiresAquaSystemAppearance based on the qt version built against; that won't avoid having to add a very recent Qt into depends but at least it doesn't  have to restrict the supported versions
315 2018-11-14T12:48:28  *** bitconner has quit IRC
316 2018-11-14T12:50:12  *** queip has joined #bitcoin-core-dev
317 2018-11-14T12:50:38  *** bitconner has joined #bitcoin-core-dev
318 2018-11-14T12:51:59  <fanquake> Looks like any accessibility concerns are addressed in #14577. ACK from jonass as well
319 2018-11-14T12:52:02  <gribble> https://github.com/bitcoin/bitcoin/issues/14577 | qt: Cleanup `textInteractionFlags` for `QLabel` by hebasto · Pull Request #14577 · bitcoin/bitcoin · GitHub
320 2018-11-14T12:52:57  *** promag has joined #bitcoin-core-dev
321 2018-11-14T12:54:11  <wumpus> yea, I still think "ripping out partial accessibility support with the idea (but not promise) to add it back in fully later" is kinda lousy, but ok...
322 2018-11-14T12:55:42  <wumpus> especially as the whole PR only about asthetic concerns
323 2018-11-14T12:56:07  *** bitconner has quit IRC
324 2018-11-14T12:56:30  <wumpus> but Jonas is GUI maintainer he can merge if he wants
325 2018-11-14T12:56:50  <fanquake> #14594 😬
326 2018-11-14T12:57:07  <gribble> https://github.com/bitcoin/bitcoin/issues/14594 | qt: Fix minimized window bug on Linux by hebasto · Pull Request #14594 · bitcoin/bitcoin · GitHub
327 2018-11-14T12:57:27  <wumpus> AHHH
328 2018-11-14T12:57:42  *** bitconner has joined #bitcoin-core-dev
329 2018-11-14T12:57:45  <wumpus> I'm not going into that, sorry
330 2018-11-14T12:58:06  <wumpus> "it's broken, have you tried toggling window visibility to hidden and back to show?"
331 2018-11-14T12:58:27  <gmaxwell> Groundhog day: IRC edition
332 2018-11-14T12:58:30  <fanquake> I downloaded a mint vm, and will test, but can't be sure nothing else breaks.
333 2018-11-14T13:00:17  <fanquake> gmaxwell, while you are here, was wondering if you could give any pointers/guidance for testing #14624? Seems like it's be nit-picked to death already.
334 2018-11-14T13:00:20  <gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub
335 2018-11-14T13:02:01  *** rh0nj has quit IRC
336 2018-11-14T13:03:06  *** rh0nj has joined #bitcoin-core-dev
337 2018-11-14T13:03:30  *** bitconner has quit IRC
338 2018-11-14T13:16:01  *** _cryptosignal_me has quit IRC
339 2018-11-14T13:19:31  *** rabidus has quit IRC
340 2018-11-14T13:24:53  *** zhangzf has joined #bitcoin-core-dev
341 2018-11-14T13:26:22  *** ctrlbreak has joined #bitcoin-core-dev
342 2018-11-14T13:26:31  *** arubi has quit IRC
343 2018-11-14T13:27:07  *** arubi has joined #bitcoin-core-dev
344 2018-11-14T13:33:26  *** TheRec has quit IRC
345 2018-11-14T13:33:39  *** Guyver2 has quit IRC
346 2018-11-14T13:34:15  *** michaelsdunn1 has quit IRC
347 2018-11-14T13:35:18  *** phwalkr has joined #bitcoin-core-dev
348 2018-11-14T13:35:46  *** owowo has quit IRC
349 2018-11-14T13:37:20  *** phwalkr has quit IRC
350 2018-11-14T13:37:33  *** phwalkr has joined #bitcoin-core-dev
351 2018-11-14T13:40:44  *** JackH has joined #bitcoin-core-dev
352 2018-11-14T13:41:59  *** queip has quit IRC
353 2018-11-14T13:42:59  <wumpus> travis failing badly, but seems a problem on their side (problems downloading packages!)
354 2018-11-14T13:43:31  *** promag has quit IRC
355 2018-11-14T13:50:19  *** queip has joined #bitcoin-core-dev
356 2018-11-14T13:55:18  *** promag has joined #bitcoin-core-dev
357 2018-11-14T14:00:02  *** Murch has joined #bitcoin-core-dev
358 2018-11-14T14:04:14  *** rabidus has joined #bitcoin-core-dev
359 2018-11-14T14:09:03  *** promag has quit IRC
360 2018-11-14T14:11:08  *** fanquake has quit IRC
361 2018-11-14T14:19:35  *** TheRec has joined #bitcoin-core-dev
362 2018-11-14T14:19:36  *** TheRec has joined #bitcoin-core-dev
363 2018-11-14T14:20:31  *** promag has joined #bitcoin-core-dev
364 2018-11-14T14:25:17  *** dviola has joined #bitcoin-core-dev
365 2018-11-14T14:32:22  *** phwalkr has quit IRC
366 2018-11-14T14:33:51  *** phwalkr has joined #bitcoin-core-dev
367 2018-11-14T14:35:36  *** Murch has quit IRC
368 2018-11-14T14:42:01  *** queip has quit IRC
369 2018-11-14T14:52:53  *** queip has joined #bitcoin-core-dev
370 2018-11-14T14:53:29  *** bitconner has joined #bitcoin-core-dev
371 2018-11-14T14:55:07  *** jungly has quit IRC
372 2018-11-14T14:58:12  *** bitconner has quit IRC
373 2018-11-14T14:58:23  *** shesek has quit IRC
374 2018-11-14T14:58:51  *** shesek has joined #bitcoin-core-dev
375 2018-11-14T15:03:28  *** simondodsley_ has joined #bitcoin-core-dev
376 2018-11-14T15:03:28  <simondodsley_> /!\ ATᎢN: Thіѕ chаᥒᥒᥱl haѕ movеd to ⅰrс.frᥱenode.ᥒet #/joіᥒ /ǃ⧹
377 2018-11-14T15:03:29  <simondodsley_> Ꮤіth our IᏒC ɑd sᥱrviϲᥱ yоᥙ ⅽaᥒ reɑϲh а ɡⅼobaⅼ аᥙdіеnce of ᥱntreрrеᥒe∪rѕ аnd fеntanyl adԁictѕ wⅰth extraοrdiᥒary enɡageⅿᥱnt ratеsⵑ httрs://ᴡіⅼⅼiaⅿpіtcoⅽk.coⅿ/
378 2018-11-14T15:03:30  <simondodsley_> І tһo∪ght yoᥙ guyѕ ⅿight bе intеrestᥱԁ in thіѕ bⅼoɡ by freеnഠԁe staff ⅿember Brỿɑᥒ kⅼoеrі Ostergɑɑrd httрs:/∕brỿanoѕterɡɑɑrⅾ.coⅿ/
379 2018-11-14T15:03:36  <simondodsley_> Rеɑd ᴡhаt IᏒC іnveѕtigɑtⅰve ϳourᥒaⅼⅰsts hɑvе unco∨ered on tһе frеeᥒode pedoрһіlia ѕⅽandaⅼ https://ᥱncусlⲟpеԁiadrɑmɑtіⅽa.rѕ/Freenⲟԁеɡаtе
380 2018-11-14T15:03:37  *** simondodsley_ has quit IRC
381 2018-11-14T15:20:54  *** zhangzf has quit IRC
382 2018-11-14T15:21:27  *** setpill has quit IRC
383 2018-11-14T15:22:50  *** zhangzf has joined #bitcoin-core-dev
384 2018-11-14T15:23:00  *** Victorsueca has quit IRC
385 2018-11-14T15:24:16  *** Victorsueca has joined #bitcoin-core-dev
386 2018-11-14T15:29:14  *** dviola has quit IRC
387 2018-11-14T15:33:11  *** zhangzf has quit IRC
388 2018-11-14T15:34:01  *** dviola has joined #bitcoin-core-dev
389 2018-11-14T15:36:15  *** zhangzf has joined #bitcoin-core-dev
390 2018-11-14T15:39:19  *** AaronvanW has quit IRC
391 2018-11-14T15:41:55  *** queip has quit IRC
392 2018-11-14T15:49:00  *** phwalkr has quit IRC
393 2018-11-14T15:49:36  *** phwalkr has joined #bitcoin-core-dev
394 2018-11-14T15:49:57  *** AaronvanW has joined #bitcoin-core-dev
395 2018-11-14T15:52:10  *** phwalkr has quit IRC
396 2018-11-14T15:52:23  *** phwalkr has joined #bitcoin-core-dev
397 2018-11-14T15:52:24  *** michaelsdunn1 has joined #bitcoin-core-dev
398 2018-11-14T15:54:30  *** AaronvanW has quit IRC
399 2018-11-14T15:54:31  *** queip has joined #bitcoin-core-dev
400 2018-11-14T15:57:15  *** phwalkr has quit IRC
401 2018-11-14T15:59:18  *** grafcaps has quit IRC
402 2018-11-14T16:00:10  *** zhangzf_ has joined #bitcoin-core-dev
403 2018-11-14T16:00:18  *** Guyver2 has joined #bitcoin-core-dev
404 2018-11-14T16:01:39  *** zhangzf has quit IRC
405 2018-11-14T16:02:15  *** Guyver2 has quit IRC
406 2018-11-14T16:02:25  *** Guyver2 has joined #bitcoin-core-dev
407 2018-11-14T16:11:01  *** AaronvanW has joined #bitcoin-core-dev
408 2018-11-14T16:14:29  *** shesek has quit IRC
409 2018-11-14T16:15:05  *** shesek has joined #bitcoin-core-dev
410 2018-11-14T16:15:45  *** phwalkr has joined #bitcoin-core-dev
411 2018-11-14T16:20:43  *** phwalkr has quit IRC
412 2018-11-14T16:27:51  *** bitcoin-git has joined #bitcoin-core-dev
413 2018-11-14T16:27:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e8f9dc2bbb1...c7366d2399e2
414 2018-11-14T16:27:52  <bitcoin-git> bitcoin/master b4f6e58 MeshCollider: Better error message for user when corrupt wallet unlock fails
415 2018-11-14T16:27:53  <bitcoin-git> bitcoin/master c7366d2 MarcoFalke: Merge #14478: Show error to user when corrupt wallet unlock fails...
416 2018-11-14T16:27:53  *** bitcoin-git has left #bitcoin-core-dev
417 2018-11-14T16:29:14  *** bitcoin-git has joined #bitcoin-core-dev
418 2018-11-14T16:29:15  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14478: Show error to user when corrupt wallet unlock fails (master...201810_wallet_corruption_error) https://github.com/bitcoin/bitcoin/pull/14478
419 2018-11-14T16:29:15  *** bitcoin-git has left #bitcoin-core-dev
420 2018-11-14T16:32:10  *** Victorsueca has quit IRC
421 2018-11-14T16:34:56  *** klot has joined #bitcoin-core-dev
422 2018-11-14T16:35:11  *** agnjunio has joined #bitcoin-core-dev
423 2018-11-14T16:35:59  *** klot has quit IRC
424 2018-11-14T16:36:23  *** klot has joined #bitcoin-core-dev
425 2018-11-14T16:37:29  *** klot has quit IRC
426 2018-11-14T16:37:57  *** klot has joined #bitcoin-core-dev
427 2018-11-14T16:38:59  *** klot has quit IRC
428 2018-11-14T16:39:23  *** klot has joined #bitcoin-core-dev
429 2018-11-14T16:40:29  *** klot has quit IRC
430 2018-11-14T16:40:41  *** shesek has quit IRC
431 2018-11-14T16:40:58  *** klot has joined #bitcoin-core-dev
432 2018-11-14T16:41:30  *** shesek has joined #bitcoin-core-dev
433 2018-11-14T16:41:46  *** Murch has joined #bitcoin-core-dev
434 2018-11-14T16:41:55  *** queip has quit IRC
435 2018-11-14T16:41:59  *** klot has quit IRC
436 2018-11-14T16:42:00  *** Deinogalerix21 has joined #bitcoin-core-dev
437 2018-11-14T16:42:27  *** klot has joined #bitcoin-core-dev
438 2018-11-14T16:43:29  *** klot has quit IRC
439 2018-11-14T16:43:57  *** klot has joined #bitcoin-core-dev
440 2018-11-14T16:44:59  *** klot has quit IRC
441 2018-11-14T16:45:23  *** klot has joined #bitcoin-core-dev
442 2018-11-14T16:46:10  *** irc_viewer_test has joined #bitcoin-core-dev
443 2018-11-14T16:46:12  *** shesek has quit IRC
444 2018-11-14T16:46:29  *** klot has quit IRC
445 2018-11-14T16:46:41  *** queip has joined #bitcoin-core-dev
446 2018-11-14T16:46:58  *** klot has joined #bitcoin-core-dev
447 2018-11-14T16:47:25  *** shesek has joined #bitcoin-core-dev
448 2018-11-14T16:47:59  *** klot has quit IRC
449 2018-11-14T16:48:27  *** klot has joined #bitcoin-core-dev
450 2018-11-14T16:49:29  *** klot has quit IRC
451 2018-11-14T16:49:57  *** klot has joined #bitcoin-core-dev
452 2018-11-14T16:50:59  *** klot has quit IRC
453 2018-11-14T16:51:27  *** klot has joined #bitcoin-core-dev
454 2018-11-14T16:51:54  *** irc_viewer_test has quit IRC
455 2018-11-14T16:52:31  *** klot has quit IRC
456 2018-11-14T16:52:57  *** klot has joined #bitcoin-core-dev
457 2018-11-14T16:54:01  *** klot has quit IRC
458 2018-11-14T16:54:27  *** klot has joined #bitcoin-core-dev
459 2018-11-14T16:55:31  *** klot has quit IRC
460 2018-11-14T16:55:56  *** klot has joined #bitcoin-core-dev
461 2018-11-14T16:57:01  *** klot has quit IRC
462 2018-11-14T16:57:28  *** klot has joined #bitcoin-core-dev
463 2018-11-14T16:58:31  *** klot has quit IRC
464 2018-11-14T16:58:43  *** phwalkr has joined #bitcoin-core-dev
465 2018-11-14T16:59:01  *** klot has joined #bitcoin-core-dev
466 2018-11-14T17:00:38  *** bitcoin-git has joined #bitcoin-core-dev
467 2018-11-14T17:00:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7366d2399e2...e74649e95122
468 2018-11-14T17:00:39  <bitcoin-git> bitcoin/master 65b740f Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label...
469 2018-11-14T17:00:40  <bitcoin-git> bitcoin/master da427db Russell Yanofsky: Rename ListTransactions filter variable...
470 2018-11-14T17:00:40  <bitcoin-git> bitcoin/master e74649e MarcoFalke: Merge #14411: [wallet] Restore ability to list incoming transactions by label...
471 2018-11-14T17:00:41  *** bitcoin-git has left #bitcoin-core-dev
472 2018-11-14T17:01:13  *** spinza has quit IRC
473 2018-11-14T17:01:34  *** bitcoin-git has joined #bitcoin-core-dev
474 2018-11-14T17:01:34  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14411: [wallet] Restore ability to list incoming transactions by label (master...pr/list-label) https://github.com/bitcoin/bitcoin/pull/14411
475 2018-11-14T17:01:34  *** bitcoin-git has left #bitcoin-core-dev
476 2018-11-14T17:03:10  *** phwalkr has quit IRC
477 2018-11-14T17:04:02  *** rh0nj has quit IRC
478 2018-11-14T17:04:43  *** shesek has quit IRC
479 2018-11-14T17:05:08  *** rh0nj has joined #bitcoin-core-dev
480 2018-11-14T17:05:29  *** shesek has joined #bitcoin-core-dev
481 2018-11-14T17:05:54  *** spinza has joined #bitcoin-core-dev
482 2018-11-14T17:12:28  *** dviola has quit IRC
483 2018-11-14T17:17:08  *** JackH has quit IRC
484 2018-11-14T17:18:10  *** zhangzf_ has quit IRC
485 2018-11-14T17:21:31  *** profmac has quit IRC
486 2018-11-14T17:25:22  *** phwalkr has joined #bitcoin-core-dev
487 2018-11-14T17:31:47  *** Deinogalerix21 has quit IRC
488 2018-11-14T17:42:02  *** queip has quit IRC
489 2018-11-14T17:43:37  *** phwalkr has quit IRC
490 2018-11-14T17:44:09  *** phwalkr has joined #bitcoin-core-dev
491 2018-11-14T17:46:32  *** millerti has joined #bitcoin-core-dev
492 2018-11-14T17:47:23  *** phwalkr has quit IRC
493 2018-11-14T17:47:37  *** phwalkr has joined #bitcoin-core-dev
494 2018-11-14T17:48:31  *** AaronvanW has quit IRC
495 2018-11-14T17:48:44  *** queip has joined #bitcoin-core-dev
496 2018-11-14T17:51:17  *** owowo has joined #bitcoin-core-dev
497 2018-11-14T17:57:28  *** JackH has joined #bitcoin-core-dev
498 2018-11-14T17:59:13  *** AaronvanW has joined #bitcoin-core-dev
499 2018-11-14T18:00:52  *** riemann has joined #bitcoin-core-dev
500 2018-11-14T18:03:52  *** shesek has quit IRC
501 2018-11-14T18:04:02  *** timothy has quit IRC
502 2018-11-14T18:04:06  *** AaronvanW has quit IRC
503 2018-11-14T18:04:46  *** shesek has joined #bitcoin-core-dev
504 2018-11-14T18:04:46  *** shesek has joined #bitcoin-core-dev
505 2018-11-14T18:08:21  *** bitconner has joined #bitcoin-core-dev
506 2018-11-14T18:13:26  *** bitconner has quit IRC
507 2018-11-14T18:41:58  *** queip has quit IRC
508 2018-11-14T18:44:42  *** phwalkr has quit IRC
509 2018-11-14T18:45:15  *** phwalkr has joined #bitcoin-core-dev
510 2018-11-14T18:46:45  *** shesek has quit IRC
511 2018-11-14T18:47:43  *** core_ has joined #bitcoin-core-dev
512 2018-11-14T18:47:44  *** shesek has joined #bitcoin-core-dev
513 2018-11-14T18:49:12  *** AaronvanW has joined #bitcoin-core-dev
514 2018-11-14T18:49:13  <core_> i am just starting with bitcoin core and I'm a little confused with the architecture
515 2018-11-14T18:49:52  *** phwalkr has quit IRC
516 2018-11-14T18:49:55  <core_> specifically how the client wallet fits in and connects to what pieces of the system (as shown in mastering bitcoin architecture diagram)
517 2018-11-14T18:50:51  *** core_ has quit IRC
518 2018-11-14T18:50:59  <phantomcircuit> core_, mastering bitcoin is basically just a copy of the wiki
519 2018-11-14T18:51:07  <phantomcircuit> and is randomly completely wrong
520 2018-11-14T18:53:25  *** Murch has quit IRC
521 2018-11-14T18:54:01  *** shesek has quit IRC
522 2018-11-14T18:54:41  *** shesek has joined #bitcoin-core-dev
523 2018-11-14T18:54:41  *** shesek has joined #bitcoin-core-dev
524 2018-11-14T18:56:25  *** queip has joined #bitcoin-core-dev
525 2018-11-14T18:58:06  *** AaronvanW has quit IRC
526 2018-11-14T18:58:25  <instagibbs> sipa, is SignatureData still the "supported" way to carry around signature data internally, or is there thought of moving to PSBT long-term?
527 2018-11-14T18:58:48  <instagibbs> Some stuff connected to SignatureData have dire warnings about extending them, so thought I'd ask for clarity :)
528 2018-11-14T19:00:24  <phantomcircuit> sipa, also, using std::swap for a single call to std::swap?
529 2018-11-14T19:00:27  <phantomcircuit> but why
530 2018-11-14T19:02:44  <sipa> instagibbs: where?
531 2018-11-14T19:02:45  *** CodeBlue1776 has quit IRC
532 2018-11-14T19:03:05  <instagibbs> sipa, DataFromTransaction, but this might be the only thing with the dire warning
533 2018-11-14T19:03:17  *** CodeBlue1776 has joined #bitcoin-core-dev
534 2018-11-14T19:03:21  <instagibbs> ripping out sigs from standing transactions, combining, etc
535 2018-11-14T19:04:44  <sipa> instagibbs: SignatureData is perfectly supported, but is an internal structure (it's not specific to transactions)
536 2018-11-14T19:05:12  <sipa> DataFromTransaction does something crazy, it tries to figure out partially signed data from a transaction
537 2018-11-14T19:05:16  <instagibbs> Exactly what I wanted to hear, thanks
538 2018-11-14T19:05:23  <sipa> which shouldn't be ever needed in a post-PSBT world
539 2018-11-14T19:05:49  <sipa> in PSBT land, you never put signatures in a transaction until they're all valid
540 2018-11-14T19:08:48  *** AaronvanW has joined #bitcoin-core-dev
541 2018-11-14T19:09:30  <gwillen> instagibbs: PSBT makes use of SignatureData heavily in the signing path
542 2018-11-14T19:10:04  <gwillen> (the actual way by which this happens feels quite convoluted to me, I dug into it to make sure I understood what was happening in Finalize)
543 2018-11-14T19:10:08  *** bitconner has joined #bitcoin-core-dev
544 2018-11-14T19:11:13  *** AaronvanW has quit IRC
545 2018-11-14T19:11:28  *** AaronvanW has joined #bitcoin-core-dev
546 2018-11-14T19:11:56  <sipa> i think you can see SignatureData as the internal non-transaction-specific way of representing things, while PSBT is the transaction-specific interchangeable way
547 2018-11-14T19:15:03  *** bitconner has quit IRC
548 2018-11-14T19:17:13  *** AaronvanW has quit IRC
549 2018-11-14T19:18:32  *** bralyclo_ has joined #bitcoin-core-dev
550 2018-11-14T19:18:38  *** shesek has quit IRC
551 2018-11-14T19:18:52  *** bralyclo_ has quit IRC
552 2018-11-14T19:19:04  *** shesek has joined #bitcoin-core-dev
553 2018-11-14T19:19:04  *** shesek has joined #bitcoin-core-dev
554 2018-11-14T19:19:09  *** bralyclo_ has joined #bitcoin-core-dev
555 2018-11-14T19:19:09  *** bralyclo_ has quit IRC
556 2018-11-14T19:20:06  *** bralyclow has quit IRC
557 2018-11-14T19:20:13  *** shesek has quit IRC
558 2018-11-14T19:20:22  *** bralyclow has joined #bitcoin-core-dev
559 2018-11-14T19:20:46  *** shesek has joined #bitcoin-core-dev
560 2018-11-14T19:20:46  *** shesek has joined #bitcoin-core-dev
561 2018-11-14T19:22:40  *** phwalkr has joined #bitcoin-core-dev
562 2018-11-14T19:22:47  *** ExtraCrispy has quit IRC
563 2018-11-14T19:27:00  *** phwalkr has quit IRC
564 2018-11-14T19:27:56  *** AaronvanW has joined #bitcoin-core-dev
565 2018-11-14T19:28:46  *** hebasto has quit IRC
566 2018-11-14T19:32:46  *** AaronvanW has quit IRC
567 2018-11-14T19:36:35  *** dviola has joined #bitcoin-core-dev
568 2018-11-14T19:41:59  *** queip has quit IRC
569 2018-11-14T19:43:12  *** profmac has joined #bitcoin-core-dev
570 2018-11-14T19:50:28  *** queip has joined #bitcoin-core-dev
571 2018-11-14T19:58:49  *** AaronvanW has joined #bitcoin-core-dev
572 2018-11-14T20:03:40  *** AaronvanW has quit IRC
573 2018-11-14T20:11:21  *** ken2812221 has quit IRC
574 2018-11-14T20:17:19  *** michaelsdunn1 has quit IRC
575 2018-11-14T20:22:30  *** phwalkr has joined #bitcoin-core-dev
576 2018-11-14T20:24:26  *** phwalkr has quit IRC
577 2018-11-14T20:24:39  *** phwalkr has joined #bitcoin-core-dev
578 2018-11-14T20:29:09  *** michaelsdunn1 has joined #bitcoin-core-dev
579 2018-11-14T20:37:05  *** Krellan has joined #bitcoin-core-dev
580 2018-11-14T20:39:43  *** klot has quit IRC
581 2018-11-14T20:43:40  *** phwalkr has quit IRC
582 2018-11-14T20:51:23  *** jhfrontz has joined #bitcoin-core-dev
583 2018-11-14T21:05:16  *** dviola has quit IRC
584 2018-11-14T21:06:02  *** rh0nj has quit IRC
585 2018-11-14T21:07:07  *** rh0nj has joined #bitcoin-core-dev
586 2018-11-14T21:17:45  *** agnjunio has quit IRC
587 2018-11-14T21:22:50  *** michaelsdunn1 has quit IRC
588 2018-11-14T21:25:03  *** dviola has joined #bitcoin-core-dev
589 2018-11-14T21:27:00  *** phwalkr has joined #bitcoin-core-dev
590 2018-11-14T21:27:19  *** michaelsdunn1 has joined #bitcoin-core-dev
591 2018-11-14T21:33:00  *** ap4lmtree has joined #bitcoin-core-dev
592 2018-11-14T21:37:18  *** Guyver2 has quit IRC
593 2018-11-14T21:44:54  *** zivl has joined #bitcoin-core-dev
594 2018-11-14T21:54:41  *** AaronvanW has joined #bitcoin-core-dev
595 2018-11-14T21:55:46  *** spinza has quit IRC
596 2018-11-14T21:56:44  *** michaelsdunn1 has quit IRC
597 2018-11-14T21:58:43  *** michaelsdunn1 has joined #bitcoin-core-dev
598 2018-11-14T21:58:43  *** michaelsdunn1 has quit IRC
599 2018-11-14T21:58:43  *** michaelsdunn1 has joined #bitcoin-core-dev
600 2018-11-14T22:13:09  *** spinza has joined #bitcoin-core-dev
601 2018-11-14T22:17:11  *** bitconner has joined #bitcoin-core-dev
602 2018-11-14T22:19:36  *** Sinclair6 has joined #bitcoin-core-dev
603 2018-11-14T22:22:26  *** bitconner has quit IRC
604 2018-11-14T22:41:58  *** queip has quit IRC
605 2018-11-14T22:44:49  *** mistergo1d has joined #bitcoin-core-dev
606 2018-11-14T22:46:02  *** mistergold has quit IRC
607 2018-11-14T22:47:05  *** phwalkr has quit IRC
608 2018-11-14T22:47:38  *** phwalkr has joined #bitcoin-core-dev
609 2018-11-14T22:51:14  *** bitconner has joined #bitcoin-core-dev
610 2018-11-14T22:52:20  *** queip has joined #bitcoin-core-dev
611 2018-11-14T22:52:58  *** phwalkr has quit IRC
612 2018-11-14T22:53:53  *** bitcoin-git has joined #bitcoin-core-dev
613 2018-11-14T22:53:53  <bitcoin-git> [bitcoin] kazcw opened pull request #14728: fix uninitialized read when stringifying an addrLocal (master...uninit-scopeid) https://github.com/bitcoin/bitcoin/pull/14728
614 2018-11-14T22:53:53  *** bitcoin-git has left #bitcoin-core-dev
615 2018-11-14T22:55:53  *** bitconner has quit IRC
616 2018-11-14T22:57:22  *** michaelsdunn1 has quit IRC
617 2018-11-14T23:08:43  *** mistergold has joined #bitcoin-core-dev
618 2018-11-14T23:10:34  *** bralyclow has quit IRC
619 2018-11-14T23:12:33  *** mistergo1d has quit IRC
620 2018-11-14T23:20:21  *** sipa has quit IRC
621 2018-11-14T23:20:46  *** Pat_Boy is now known as PatBoy
622 2018-11-14T23:21:21  *** sipa has joined #bitcoin-core-dev
623 2018-11-14T23:24:48  *** booyah_ has joined #bitcoin-core-dev
624 2018-11-14T23:27:43  *** booyah has quit IRC
625 2018-11-14T23:28:16  *** shesek has quit IRC
626 2018-11-14T23:29:50  *** shesek has joined #bitcoin-core-dev
627 2018-11-14T23:29:50  *** shesek has joined #bitcoin-core-dev
628 2018-11-14T23:38:48  *** bitconner has joined #bitcoin-core-dev
629 2018-11-14T23:39:24  *** Murch has joined #bitcoin-core-dev
630 2018-11-14T23:42:06  *** queip has quit IRC
631 2018-11-14T23:45:38  *** michaelsdunn1 has joined #bitcoin-core-dev
632 2018-11-14T23:48:23  *** queip has joined #bitcoin-core-dev
633 2018-11-14T23:49:47  *** michaelsdunn1 has quit IRC
634 2018-11-14T23:50:18  *** bitconner has quit IRC
635 2018-11-14T23:52:36  *** bitconner has joined #bitcoin-core-dev
636 2018-11-14T23:54:43  *** Inv1s1ble has joined #bitcoin-core-dev
637 2018-11-14T23:55:01  *** spinza has quit IRC