1 2018-11-15T00:05:04  *** cubancorona has quit IRC
  2 2018-11-15T00:06:24  *** bralyclow has joined #bitcoin-core-dev
  3 2018-11-15T00:13:53  *** spinza has joined #bitcoin-core-dev
  4 2018-11-15T00:16:39  *** TheRec has quit IRC
  5 2018-11-15T00:16:43  *** shesek has quit IRC
  6 2018-11-15T00:17:19  *** shesek has joined #bitcoin-core-dev
  7 2018-11-15T00:17:19  *** shesek has joined #bitcoin-core-dev
  8 2018-11-15T00:17:33  *** owowo has quit IRC
  9 2018-11-15T00:21:56  *** TheRec has joined #bitcoin-core-dev
 10 2018-11-15T00:21:56  *** TheRec has joined #bitcoin-core-dev
 11 2018-11-15T00:23:03  *** owowo has joined #bitcoin-core-dev
 12 2018-11-15T00:26:11  *** shesek has quit IRC
 13 2018-11-15T00:26:40  *** shesek has joined #bitcoin-core-dev
 14 2018-11-15T00:26:40  *** shesek has joined #bitcoin-core-dev
 15 2018-11-15T00:41:55  *** queip has quit IRC
 16 2018-11-15T00:46:49  *** mistergold has quit IRC
 17 2018-11-15T00:51:34  *** queip has joined #bitcoin-core-dev
 18 2018-11-15T00:56:04  *** zhangzf has joined #bitcoin-core-dev
 19 2018-11-15T01:03:12  *** shesek has quit IRC
 20 2018-11-15T01:04:08  *** shesek has joined #bitcoin-core-dev
 21 2018-11-15T01:04:57  *** lnostdal has quit IRC
 22 2018-11-15T01:08:11  *** lnostdal has joined #bitcoin-core-dev
 23 2018-11-15T01:11:16  *** shesek has quit IRC
 24 2018-11-15T01:11:29  *** Murch has quit IRC
 25 2018-11-15T01:12:00  *** shesek has joined #bitcoin-core-dev
 26 2018-11-15T01:12:00  *** shesek has joined #bitcoin-core-dev
 27 2018-11-15T01:14:55  *** shesek has quit IRC
 28 2018-11-15T01:15:21  *** shesek has joined #bitcoin-core-dev
 29 2018-11-15T01:15:29  *** shesek has quit IRC
 30 2018-11-15T01:15:29  *** shesek has joined #bitcoin-core-dev
 31 2018-11-15T01:20:52  *** shesek has quit IRC
 32 2018-11-15T01:21:48  *** shesek has joined #bitcoin-core-dev
 33 2018-11-15T01:38:15  *** shesek has quit IRC
 34 2018-11-15T01:38:40  *** shesek has joined #bitcoin-core-dev
 35 2018-11-15T01:41:57  *** queip has quit IRC
 36 2018-11-15T01:45:35  *** instagibbs has quit IRC
 37 2018-11-15T01:46:41  *** queip has joined #bitcoin-core-dev
 38 2018-11-15T01:54:06  *** Sinclai__ has joined #bitcoin-core-dev
 39 2018-11-15T01:57:11  *** Sinclair6 has quit IRC
 40 2018-11-15T02:08:37  *** promag has quit IRC
 41 2018-11-15T02:18:43  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
 42 2018-11-15T02:21:50  *** Ga1aCt1Cz00__ has quit IRC
 43 2018-11-15T02:22:51  *** instagibbs has joined #bitcoin-core-dev
 44 2018-11-15T02:23:09  <esotericnonsense> is it expected behaviour that repeated calls to fundrawtransaction will result in new change addresses being used even if the set of inputs is identical?
 45 2018-11-15T02:25:06  <sipa> define "set of inputs is identical" ?
 46 2018-11-15T02:25:42  <sipa> ah, you're calling fundrawtransaction with the same input multiple times?
 47 2018-11-15T02:26:06  <esotericnonsense> yes, basically it'll use the exact same coins as inputs each time (unless the algo was non-deterministic, why wouldn't it)
 48 2018-11-15T02:26:09  <sipa> yes, those change addresses are marked in use by the fundrawtransaction RPC, regardless of whether the resulting transaction is broadcast or not
 49 2018-11-15T02:26:12  <esotericnonsense> and then just burn through change addresses
 50 2018-11-15T02:26:34  <esotericnonsense> hm. okay. I guess I need to getnewaddress and handle that manually.
 51 2018-11-15T02:27:05  <sipa> use getrawchangeaddress instead
 52 2018-11-15T02:27:29  <esotericnonsense> aha.
 53 2018-11-15T02:31:06  <esotericnonsense> so you end up with a workflow a bit like this then; getrawchangeaddress (store this in a DB or whatever); do a bunch of fundrawtransactions with that change address; once you're happy, do "ismine" checks (e.g. look at getaddressinfo, listreceivedbyaddress) immediately prior to signing
 54 2018-11-15T02:31:52  <sipa> or you can use PSBT
 55 2018-11-15T02:32:32  <sipa> https://github.com/bitcoin/bitcoin/blob/master/doc/psbt.md
 56 2018-11-15T02:33:19  <esotericnonsense> it seems that PSBT doesn't really add anything for the single-signature case
 57 2018-11-15T02:33:46  <sipa> decodepsbt will tell you the fee explicitly, for example
 58 2018-11-15T02:33:54  <sipa> something that decoderawtransaction can't do
 59 2018-11-15T02:34:38  <sipa> but fair, its advantages are more relevant in multiparty or at least multi-device settings
 60 2018-11-15T02:35:23  <esotericnonsense> yeah, though maybe it makes sense to just use it, walletcreatefundedpsbt seems to do basically what I'm after in one step
 61 2018-11-15T02:36:02  *** dqx_ has joined #bitcoin-core-dev
 62 2018-11-15T02:37:03  <esotericnonsense> i'm just trying to avoid reinventing the wheel since it feels like holding this change address around is a bit silly; I almost want a transaction that has a dummy change address in it that's invalid but otherwise would have the same fee, so that bitcoind could just swap out the dummy for a real change address immediately prior to signing, then there's no external state
 63 2018-11-15T02:41:58  *** queip has quit IRC
 64 2018-11-15T02:42:19  *** lnostdal has quit IRC
 65 2018-11-15T02:46:08  *** crrod has joined #bitcoin-core-dev
 66 2018-11-15T02:46:31  *** crrod has quit IRC
 67 2018-11-15T02:47:27  *** millerti has quit IRC
 68 2018-11-15T02:48:29  *** crrod has joined #bitcoin-core-dev
 69 2018-11-15T02:50:16  *** queip has joined #bitcoin-core-dev
 70 2018-11-15T02:50:55  *** crrod has quit IRC
 71 2018-11-15T02:51:20  *** crrod has joined #bitcoin-core-dev
 72 2018-11-15T02:52:13  *** crrod has quit IRC
 73 2018-11-15T02:53:10  *** crrod has joined #bitcoin-core-dev
 74 2018-11-15T02:53:44  *** crrod has quit IRC
 75 2018-11-15T02:55:51  *** crrod has joined #bitcoin-core-dev
 76 2018-11-15T02:55:57  *** AaronvanW has quit IRC
 77 2018-11-15T02:58:54  *** dviola has quit IRC
 78 2018-11-15T03:11:48  *** rhavar has joined #bitcoin-core-dev
 79 2018-11-15T03:24:53  *** crrod has quit IRC
 80 2018-11-15T03:26:16  *** crrod has joined #bitcoin-core-dev
 81 2018-11-15T03:28:27  *** unusuario has joined #bitcoin-core-dev
 82 2018-11-15T03:30:46  *** crrod has quit IRC
 83 2018-11-15T03:35:00  *** drexl_ has quit IRC
 84 2018-11-15T03:41:56  *** queip has quit IRC
 85 2018-11-15T03:53:23  *** queip has joined #bitcoin-core-dev
 86 2018-11-15T04:06:28  *** bitcoin-git has joined #bitcoin-core-dev
 87 2018-11-15T04:06:28  <bitcoin-git> [bitcoin] qubenix opened pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
 88 2018-11-15T04:06:28  *** bitcoin-git has left #bitcoin-core-dev
 89 2018-11-15T04:07:51  *** unusuario has left #bitcoin-core-dev
 90 2018-11-15T04:09:12  *** klot has joined #bitcoin-core-dev
 91 2018-11-15T04:09:59  *** klot has quit IRC
 92 2018-11-15T04:10:29  *** klot has joined #bitcoin-core-dev
 93 2018-11-15T04:11:30  *** klot has quit IRC
 94 2018-11-15T04:11:55  *** klot has joined #bitcoin-core-dev
 95 2018-11-15T04:13:00  *** klot has quit IRC
 96 2018-11-15T04:14:06  *** shesek has quit IRC
 97 2018-11-15T04:14:45  *** shesek has joined #bitcoin-core-dev
 98 2018-11-15T04:14:45  *** shesek has joined #bitcoin-core-dev
 99 2018-11-15T04:22:58  *** instagibbs has quit IRC
100 2018-11-15T04:31:13  *** instagibbs has joined #bitcoin-core-dev
101 2018-11-15T04:59:21  *** phwalkr has joined #bitcoin-core-dev
102 2018-11-15T05:03:45  *** phwalkr has quit IRC
103 2018-11-15T05:42:03  *** queip has quit IRC
104 2018-11-15T05:44:09  *** shesek has quit IRC
105 2018-11-15T05:44:56  *** shesek has joined #bitcoin-core-dev
106 2018-11-15T05:44:56  *** shesek has joined #bitcoin-core-dev
107 2018-11-15T05:55:02  *** rh0nj has quit IRC
108 2018-11-15T05:55:04  *** queip has joined #bitcoin-core-dev
109 2018-11-15T05:56:08  *** rh0nj has joined #bitcoin-core-dev
110 2018-11-15T05:59:16  *** warren has quit IRC
111 2018-11-15T05:59:16  *** BlueMatt has quit IRC
112 2018-11-15T05:59:26  *** takinbo has quit IRC
113 2018-11-15T05:59:45  *** vaishali_ has joined #bitcoin-core-dev
114 2018-11-15T05:59:51  *** dqx has quit IRC
115 2018-11-15T05:59:59  *** vaishali_ has quit IRC
116 2018-11-15T06:00:14  *** ryanofsky_ has joined #bitcoin-core-dev
117 2018-11-15T06:00:18  *** mariorz has quit IRC
118 2018-11-15T06:00:25  *** warren has joined #bitcoin-core-dev
119 2018-11-15T06:00:26  *** jrayhawk has quit IRC
120 2018-11-15T06:00:29  *** warren has quit IRC
121 2018-11-15T06:00:29  *** warren has joined #bitcoin-core-dev
122 2018-11-15T06:00:38  *** takinbo has joined #bitcoin-core-dev
123 2018-11-15T06:00:42  *** jrayhawk has joined #bitcoin-core-dev
124 2018-11-15T06:00:50  *** dqx has joined #bitcoin-core-dev
125 2018-11-15T06:00:52  *** mariorz has joined #bitcoin-core-dev
126 2018-11-15T06:00:57  *** ryanofsky has quit IRC
127 2018-11-15T06:01:34  *** BlueMatt has joined #bitcoin-core-dev
128 2018-11-15T06:01:35  *** bralyclow has quit IRC
129 2018-11-15T06:02:29  *** bralyclow has joined #bitcoin-core-dev
130 2018-11-15T06:36:41  *** jhfrontz has quit IRC
131 2018-11-15T06:41:56  *** queip has quit IRC
132 2018-11-15T06:53:13  *** queip has joined #bitcoin-core-dev
133 2018-11-15T07:02:08  *** wpaulino has quit IRC
134 2018-11-15T07:02:18  *** bitconner has quit IRC
135 2018-11-15T07:02:25  *** wpaulino has joined #bitcoin-core-dev
136 2018-11-15T07:08:00  *** JustTesting has joined #bitcoin-core-dev
137 2018-11-15T07:12:19  *** JustTesting has quit IRC
138 2018-11-15T07:18:00  *** promag has joined #bitcoin-core-dev
139 2018-11-15T07:18:10  *** promag has quit IRC
140 2018-11-15T07:19:27  *** jhfrontz has joined #bitcoin-core-dev
141 2018-11-15T07:26:23  *** Guest64655 is now known as iphelix
142 2018-11-15T07:26:23  *** iphelix has joined #bitcoin-core-dev
143 2018-11-15T07:30:38  *** promag has joined #bitcoin-core-dev
144 2018-11-15T07:38:01  *** Guyver2 has joined #bitcoin-core-dev
145 2018-11-15T07:41:16  *** jkjk has joined #bitcoin-core-dev
146 2018-11-15T07:41:26  <jkjk> hi
147 2018-11-15T07:41:58  *** queip has quit IRC
148 2018-11-15T07:42:57  *** jkjk has quit IRC
149 2018-11-15T07:47:18  <sipa> hi
150 2018-11-15T07:48:06  <gmaxwell> hi
151 2018-11-15T07:48:16  <gmaxwell> is it time for the new midnight meeting?
152 2018-11-15T07:51:27  *** promag has quit IRC
153 2018-11-15T07:54:20  *** queip has joined #bitcoin-core-dev
154 2018-11-15T07:55:24  *** fanquake has joined #bitcoin-core-dev
155 2018-11-15T07:55:47  <gwillen> gmaxwell: it seems like midnightmagic would need to moderate, for reasons of nominative determinism
156 2018-11-15T07:56:36  *** bitconner has joined #bitcoin-core-dev
157 2018-11-15T07:58:39  *** Skizzerz5 has joined #bitcoin-core-dev
158 2018-11-15T08:01:38  *** setpill has joined #bitcoin-core-dev
159 2018-11-15T08:01:45  *** bitconner has quit IRC
160 2018-11-15T08:04:25  *** setpill has quit IRC
161 2018-11-15T08:04:28  *** Skizzerz5 has quit IRC
162 2018-11-15T08:05:31  *** shesek has quit IRC
163 2018-11-15T08:06:09  *** setpill has joined #bitcoin-core-dev
164 2018-11-15T08:06:12  *** shesek has joined #bitcoin-core-dev
165 2018-11-15T08:06:12  *** shesek has joined #bitcoin-core-dev
166 2018-11-15T08:18:15  *** wpaulino has quit IRC
167 2018-11-15T08:18:15  *** wpaulino has joined #bitcoin-core-dev
168 2018-11-15T08:25:44  *** shesek has quit IRC
169 2018-11-15T08:26:10  *** shesek has joined #bitcoin-core-dev
170 2018-11-15T08:27:11  *** shesek has joined #bitcoin-core-dev
171 2018-11-15T08:27:36  *** phwalkr has joined #bitcoin-core-dev
172 2018-11-15T08:32:08  *** jungly has joined #bitcoin-core-dev
173 2018-11-15T08:37:45  *** Murch has joined #bitcoin-core-dev
174 2018-11-15T08:41:55  *** queip has quit IRC
175 2018-11-15T08:52:56  *** queip has joined #bitcoin-core-dev
176 2018-11-15T08:57:47  *** spinza has quit IRC
177 2018-11-15T09:04:16  *** nameeee has joined #bitcoin-core-dev
178 2018-11-15T09:08:00  *** spinza has joined #bitcoin-core-dev
179 2018-11-15T09:14:27  *** booyah_ is now known as booyah
180 2018-11-15T09:17:09  <esotericnonsense> sipa: thanks for the help earlier. i have it working now (ignoring the change address issues). think i'll deal with that later on since i don't care about bloating a testnet wallet
181 2018-11-15T09:23:47  *** phwalkr has quit IRC
182 2018-11-15T09:27:51  *** Murch has quit IRC
183 2018-11-15T09:28:03  *** phwalkr has joined #bitcoin-core-dev
184 2018-11-15T09:28:48  *** cjd has joined #bitcoin-core-dev
185 2018-11-15T09:39:51  *** timothy has joined #bitcoin-core-dev
186 2018-11-15T09:42:01  *** queip has quit IRC
187 2018-11-15T09:47:04  *** phwalkr has quit IRC
188 2018-11-15T09:47:54  *** phwalkr has joined #bitcoin-core-dev
189 2018-11-15T09:52:08  *** phwalkr has quit IRC
190 2018-11-15T09:55:01  *** queip has joined #bitcoin-core-dev
191 2018-11-15T10:03:37  *** hebasto has joined #bitcoin-core-dev
192 2018-11-15T10:05:01  *** rh0nj has quit IRC
193 2018-11-15T10:05:09  *** phwalkr has joined #bitcoin-core-dev
194 2018-11-15T10:05:13  *** Victorsueca has joined #bitcoin-core-dev
195 2018-11-15T10:06:07  *** rh0nj has joined #bitcoin-core-dev
196 2018-11-15T10:09:50  *** JackH has quit IRC
197 2018-11-15T10:09:53  *** phwalkr has quit IRC
198 2018-11-15T10:10:31  *** promag has joined #bitcoin-core-dev
199 2018-11-15T10:10:35  *** Guyver2 has quit IRC
200 2018-11-15T10:11:40  *** state_bits has quit IRC
201 2018-11-15T10:13:22  *** state_bits has joined #bitcoin-core-dev
202 2018-11-15T10:21:25  *** rhavar has quit IRC
203 2018-11-15T10:24:29  *** spinza has quit IRC
204 2018-11-15T10:27:41  *** spinza has joined #bitcoin-core-dev
205 2018-11-15T10:42:05  *** queip has quit IRC
206 2018-11-15T10:47:41  *** JackH has joined #bitcoin-core-dev
207 2018-11-15T10:48:07  *** zhangzf has quit IRC
208 2018-11-15T10:48:08  *** queip has joined #bitcoin-core-dev
209 2018-11-15T10:51:40  <promag> does appveyor merges with master before build and test?
210 2018-11-15T10:59:09  *** bitconner has joined #bitcoin-core-dev
211 2018-11-15T11:03:17  *** dqx_ has quit IRC
212 2018-11-15T11:04:35  *** bitconner has quit IRC
213 2018-11-15T11:10:32  *** AaronvanW has joined #bitcoin-core-dev
214 2018-11-15T11:13:22  *** shesek has quit IRC
215 2018-11-15T11:14:10  *** shesek has joined #bitcoin-core-dev
216 2018-11-15T11:27:50  *** shesek has quit IRC
217 2018-11-15T11:28:45  *** shesek has joined #bitcoin-core-dev
218 2018-11-15T11:28:45  *** shesek has joined #bitcoin-core-dev
219 2018-11-15T11:29:14  *** Victorsueca has quit IRC
220 2018-11-15T11:30:35  *** Victorsueca has joined #bitcoin-core-dev
221 2018-11-15T11:37:17  *** shesek has quit IRC
222 2018-11-15T11:37:57  *** shesek has joined #bitcoin-core-dev
223 2018-11-15T11:39:27  *** shesek has joined #bitcoin-core-dev
224 2018-11-15T11:39:27  *** shesek has joined #bitcoin-core-dev
225 2018-11-15T11:41:59  *** queip has quit IRC
226 2018-11-15T11:44:29  *** Victorsueca has quit IRC
227 2018-11-15T11:45:48  *** Victorsueca has joined #bitcoin-core-dev
228 2018-11-15T11:54:26  *** spinza has quit IRC
229 2018-11-15T11:54:44  *** queip has joined #bitcoin-core-dev
230 2018-11-15T11:55:33  *** shesek has quit IRC
231 2018-11-15T11:56:06  *** shesek has joined #bitcoin-core-dev
232 2018-11-15T11:56:06  *** shesek has joined #bitcoin-core-dev
233 2018-11-15T11:59:09  *** spinza has joined #bitcoin-core-dev
234 2018-11-15T12:17:15  *** fabianfabian has joined #bitcoin-core-dev
235 2018-11-15T12:21:20  *** drexl has joined #bitcoin-core-dev
236 2018-11-15T12:42:01  *** queip has quit IRC
237 2018-11-15T12:43:33  *** murr4y has joined #bitcoin-core-dev
238 2018-11-15T12:52:19  *** queip has joined #bitcoin-core-dev
239 2018-11-15T12:59:23  *** bitconner has joined #bitcoin-core-dev
240 2018-11-15T13:03:27  *** bitconner has quit IRC
241 2018-11-15T13:12:01  *** riemann_ has joined #bitcoin-core-dev
242 2018-11-15T13:14:38  *** riemann has quit IRC
243 2018-11-15T13:16:54  *** cubancorona has joined #bitcoin-core-dev
244 2018-11-15T13:19:02  *** emilr has quit IRC
245 2018-11-15T13:21:19  *** TX1683 has joined #bitcoin-core-dev
246 2018-11-15T13:35:08  *** IGHOR has joined #bitcoin-core-dev
247 2018-11-15T13:39:43  *** Murch has joined #bitcoin-core-dev
248 2018-11-15T13:41:59  *** queip has quit IRC
249 2018-11-15T13:43:13  *** shesek has quit IRC
250 2018-11-15T13:43:43  *** shesek has joined #bitcoin-core-dev
251 2018-11-15T13:43:43  *** shesek has joined #bitcoin-core-dev
252 2018-11-15T13:46:21  *** Murch has quit IRC
253 2018-11-15T13:47:57  *** Murch has joined #bitcoin-core-dev
254 2018-11-15T13:48:58  *** queip has joined #bitcoin-core-dev
255 2018-11-15T13:50:25  *** shesek has quit IRC
256 2018-11-15T13:51:02  *** shesek has joined #bitcoin-core-dev
257 2018-11-15T13:51:02  *** shesek has joined #bitcoin-core-dev
258 2018-11-15T13:52:14  *** Murch has quit IRC
259 2018-11-15T13:53:48  *** shesek has quit IRC
260 2018-11-15T13:54:03  *** Murch has joined #bitcoin-core-dev
261 2018-11-15T13:54:06  *** fanquake has quit IRC
262 2018-11-15T13:54:46  *** shesek has joined #bitcoin-core-dev
263 2018-11-15T13:54:46  *** shesek has joined #bitcoin-core-dev
264 2018-11-15T14:02:08  *** owowo has quit IRC
265 2018-11-15T14:04:07  *** Murch has quit IRC
266 2018-11-15T14:05:18  *** promag has quit IRC
267 2018-11-15T14:07:20  *** owowo has joined #bitcoin-core-dev
268 2018-11-15T14:20:45  <cjd> Does anybody happen to know what was the largest (in number of bytes) transaction ever created ?
269 2018-11-15T14:28:42  <timothy> cjd: iirc https://blockstream.info/tx/bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08
270 2018-11-15T14:29:51  <cjd> oh wow, thank you
271 2018-11-15T14:35:13  *** zhangzf has joined #bitcoin-core-dev
272 2018-11-15T14:41:19  <hebasto> promag: it seems so; https://github.com/bitcoin/bitcoin/commit/affc245f0199a9f7a2dadaa555024820a17ffc2a
273 2018-11-15T14:49:03  *** dady_ has joined #bitcoin-core-dev
274 2018-11-15T14:51:37  *** dady_ has quit IRC
275 2018-11-15T14:59:39  *** bitconner has joined #bitcoin-core-dev
276 2018-11-15T14:59:51  *** shesek has quit IRC
277 2018-11-15T15:00:24  *** shesek has joined #bitcoin-core-dev
278 2018-11-15T15:00:29  *** shesek has quit IRC
279 2018-11-15T15:00:30  *** shesek has joined #bitcoin-core-dev
280 2018-11-15T15:04:20  *** bitconner has quit IRC
281 2018-11-15T15:23:26  *** jarthur has joined #bitcoin-core-dev
282 2018-11-15T15:27:52  *** Murch has joined #bitcoin-core-dev
283 2018-11-15T15:36:51  *** zhangzf_ has joined #bitcoin-core-dev
284 2018-11-15T15:37:27  *** zhangzf has quit IRC
285 2018-11-15T15:41:56  *** queip has quit IRC
286 2018-11-15T15:48:58  *** michaelsdunn1 has joined #bitcoin-core-dev
287 2018-11-15T15:50:08  *** queip has joined #bitcoin-core-dev
288 2018-11-15T15:53:18  *** michaelsdunn1 has quit IRC
289 2018-11-15T15:57:17  *** michaelsdunn1 has joined #bitcoin-core-dev
290 2018-11-15T16:02:42  *** zhangzf_ has quit IRC
291 2018-11-15T16:19:00  *** shesek has quit IRC
292 2018-11-15T16:19:28  *** shesek has joined #bitcoin-core-dev
293 2018-11-15T16:19:28  *** shesek has joined #bitcoin-core-dev
294 2018-11-15T16:24:48  *** millerti has joined #bitcoin-core-dev
295 2018-11-15T16:28:30  *** setpill has quit IRC
296 2018-11-15T16:31:17  *** dviola has joined #bitcoin-core-dev
297 2018-11-15T16:35:31  *** Murch has quit IRC
298 2018-11-15T16:37:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
299 2018-11-15T16:40:45  *** oneark has joined #bitcoin-core-dev
300 2018-11-15T16:41:55  *** queip has quit IRC
301 2018-11-15T16:49:07  *** shesek has quit IRC
302 2018-11-15T16:49:36  *** shesek has joined #bitcoin-core-dev
303 2018-11-15T16:52:15  *** queip has joined #bitcoin-core-dev
304 2018-11-15T16:52:34  *** bitcoin-git has joined #bitcoin-core-dev
305 2018-11-15T16:52:34  <bitcoin-git> [bitcoin] dongcarl opened pull request #14731: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
306 2018-11-15T16:52:34  *** bitcoin-git has left #bitcoin-core-dev
307 2018-11-15T16:59:54  *** ghost43_ has joined #bitcoin-core-dev
308 2018-11-15T17:00:42  *** rhavar has joined #bitcoin-core-dev
309 2018-11-15T17:01:01  *** ghost43 has quit IRC
310 2018-11-15T17:13:47  *** JackH has quit IRC
311 2018-11-15T17:15:10  *** ghost43_ is now known as ghost43
312 2018-11-15T17:15:26  *** shesek has quit IRC
313 2018-11-15T17:16:21  *** shesek has joined #bitcoin-core-dev
314 2018-11-15T17:32:06  *** promag has joined #bitcoin-core-dev
315 2018-11-15T17:41:56  *** queip has quit IRC
316 2018-11-15T17:43:22  *** riemann has joined #bitcoin-core-dev
317 2018-11-15T17:45:02  *** hbdgr__ has joined #bitcoin-core-dev
318 2018-11-15T17:45:40  *** riemann_ has quit IRC
319 2018-11-15T17:46:18  <promag>  hebasto: thanks, I wonder if it's possible to rebase with a different branch
320 2018-11-15T17:47:52  *** queip has joined #bitcoin-core-dev
321 2018-11-15T17:48:21  <esotericnonsense> sipa: in case you were interested, the results of the psbt stuff from yesterday...
322 2018-11-15T17:48:24  <esotericnonsense> https://files.esotericnonsense.com/public/bitcoin-top-wallet-send.jpg
323 2018-11-15T17:48:24  *** riemann has quit IRC
324 2018-11-15T17:48:34  <esotericnonsense> (the gray box is a javascript QR scanner)\
325 2018-11-15T17:48:52  <esotericnonsense> so this is all self hosted using bitcoind rpc, very much testnet stuff atm though
326 2018-11-15T17:49:16  *** shesek has quit IRC
327 2018-11-15T17:49:17  <promag> "omg send"? :D
328 2018-11-15T17:49:19  <esotericnonsense> the gray box is using decodepsbt
329 2018-11-15T17:49:34  <esotericnonsense> promag: i have a really bad habit of using stupid names for everything all over my code
330 2018-11-15T17:49:40  *** shesek has joined #bitcoin-core-dev
331 2018-11-15T17:49:40  *** shesek has joined #bitcoin-core-dev
332 2018-11-15T17:49:51  <promag> lgtm :D
333 2018-11-15T17:49:57  <esotericnonsense> not "unsensible variable names", but rather stuff like panic!("omg it's all gone terribly wrong NOOOOOOOOOO")
334 2018-11-15T17:55:01  *** shesek has quit IRC
335 2018-11-15T17:56:29  *** shesek has joined #bitcoin-core-dev
336 2018-11-15T17:56:29  *** shesek has joined #bitcoin-core-dev
337 2018-11-15T18:07:01  *** JackH has joined #bitcoin-core-dev
338 2018-11-15T18:13:16  *** promag has quit IRC
339 2018-11-15T18:17:25  <instagibbs> in functional tests how do i set up nodes with no connections to peers?
340 2018-11-15T18:18:10  *** mistergold has joined #bitcoin-core-dev
341 2018-11-15T18:18:28  *** ezzzy has joined #bitcoin-core-dev
342 2018-11-15T18:19:54  *** Victorsueca has quit IRC
343 2018-11-15T18:21:03  *** Victorsueca has joined #bitcoin-core-dev
344 2018-11-15T18:25:30  *** lnostdal has joined #bitcoin-core-dev
345 2018-11-15T18:25:31  <instagibbs> got it, override setup_network
346 2018-11-15T18:30:57  *** hbdgr__ has quit IRC
347 2018-11-15T18:31:15  *** riemann has joined #bitcoin-core-dev
348 2018-11-15T18:38:28  *** Chris_Stewart_5 has quit IRC
349 2018-11-15T18:45:22  *** niiil has joined #bitcoin-core-dev
350 2018-11-15T18:52:53  *** promag has joined #bitcoin-core-dev
351 2018-11-15T18:52:53  *** dviola has quit IRC
352 2018-11-15T18:56:20  *** shesek has quit IRC
353 2018-11-15T18:57:09  *** shesek has joined #bitcoin-core-dev
354 2018-11-15T18:57:09  *** shesek has joined #bitcoin-core-dev
355 2018-11-15T18:58:31  *** Krellan has quit IRC
356 2018-11-15T18:59:42  *** bitconner has joined #bitcoin-core-dev
357 2018-11-15T18:59:50  <MarcoFalke> 6:59 PM
358 2018-11-15T19:00:04  <wumpus> #startmeeting
359 2018-11-15T19:00:04  <lightningbot> Meeting started Thu Nov 15 19:00:04 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
360 2018-11-15T19:00:04  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
361 2018-11-15T19:00:07  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
362 2018-11-15T19:00:18  <provoostenator> hi
363 2018-11-15T19:00:20  <meshcollider> hi
364 2018-11-15T19:00:36  <promag> hi
365 2018-11-15T19:00:37  <kanzure> hi.
366 2018-11-15T19:00:57  <wumpus> proposed topics?
367 2018-11-15T19:01:33  *** ezzzy has quit IRC
368 2018-11-15T19:02:38  <wumpus> #topic high priority for review
369 2018-11-15T19:02:40  <sipa> hi.
370 2018-11-15T19:03:07  <phantomcircuit> hi
371 2018-11-15T19:03:14  <wumpus> https://github.com/bitcoin/bitcoin/projects/8  current high priority PRs are by luke-jr promag achow101 phantomcircuit sipa
372 2018-11-15T19:03:32  <meshcollider> Maybe #14552
373 2018-11-15T19:03:34  <wumpus> anything to add or remove for this week?
374 2018-11-15T19:03:35  <gribble> https://github.com/bitcoin/bitcoin/issues/14552 | wallet: detecting duplicate wallet by comparing the db filename. by ken2812221 · Pull Request #14552 · bitcoin/bitcoin · GitHub
375 2018-11-15T19:03:48  <instagibbs> hi
376 2018-11-15T19:04:07  *** bitconner has quit IRC
377 2018-11-15T19:04:09  <wumpus> meshcollider: added
378 2018-11-15T19:04:15  <meshcollider> Thanks
379 2018-11-15T19:04:39  <promag> regarding #14670, it is possible to have appveyor rebase on that instead of master?
380 2018-11-15T19:04:41  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
381 2018-11-15T19:04:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
382 2018-11-15T19:04:48  *** ezzzy has joined #bitcoin-core-dev
383 2018-11-15T19:04:49  *** clarkmoody has joined #bitcoin-core-dev
384 2018-11-15T19:05:00  <wumpus> luke-jr: please rebase #14532
385 2018-11-15T19:05:02  <gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
386 2018-11-15T19:05:18  <wumpus> (should be a small change)
387 2018-11-15T19:05:40  <provoostenator> I like to nominate #11082
388 2018-11-15T19:05:43  <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
389 2018-11-15T19:05:51  <promag> I saw several connection problems in some PR's in appveyor and I think 14670 fixes that
390 2018-11-15T19:05:52  <provoostenator> Since I have PR that depends on that.
391 2018-11-15T19:05:58  <wumpus> provoostenator: I don't know anything about appveyor
392 2018-11-15T19:06:06  <MarcoFalke> promag: You'd have to fixup the appveyor yaml, I'd presume
393 2018-11-15T19:06:07  <wumpus> provoostenator: luke-jr already has a PR
394 2018-11-15T19:06:42  <wumpus> really, let's try to get the INADDR_ANY in, it's silly that it takes so long
395 2018-11-15T19:06:46  *** shesek has quit IRC
396 2018-11-15T19:06:57  <wumpus> it's an important security issue in a way
397 2018-11-15T19:07:37  <wumpus> buut I'm fine with adding the _rw one as well if others agree...
398 2018-11-15T19:07:44  <promag> MarcoFalke: you mean manually rebase? because from https://www.appveyor.com/docs/appveyor-yml/ I don't see that's possible out of the box
399 2018-11-15T19:08:10  *** shesek has joined #bitcoin-core-dev
400 2018-11-15T19:08:10  *** shesek has joined #bitcoin-core-dev
401 2018-11-15T19:09:07  <MarcoFalke> Git should be installed on the machine, so you could do "git fetch https://github.com/promag/bitcoin branch && git merge FETCH_HEAD" before compiling?
402 2018-11-15T19:10:11  <promag> MarcoFalke: do you think that could go to master temporally?
403 2018-11-15T19:11:34  <provoostenator> wumpus: I'm fine with waiting until this more urgent PR is done, I'll try to help with review
404 2018-11-15T19:11:42  <sipa> i think merging it is preferable
405 2018-11-15T19:11:48  <sipa> (after review, of course)
406 2018-11-15T19:12:01  <wumpus> merging it is certainly preferable, if we can be confident of it
407 2018-11-15T19:12:47  <promag> ok then
408 2018-11-15T19:13:08  <phantomcircuit> wumpus, im reviewing that one now
409 2018-11-15T19:13:15  <MarcoFalke> phantomcircuit: Thx
410 2018-11-15T19:13:18  <wumpus> it's the so-manieth time that particular part of the code was fixed, so I certainly understand people are a bit skeptical, you'll need very good tests
411 2018-11-15T19:13:21  <phantomcircuit> the IsBindAny looks wrong actually...
412 2018-11-15T19:15:03  <phantomcircuit> unless GetByte does some magic
413 2018-11-15T19:15:13  <wumpus> let's review in the PR :)
414 2018-11-15T19:15:22  <wumpus> any other topics?
415 2018-11-15T19:15:26  <phantomcircuit> true sorry
416 2018-11-15T19:16:00  <sipa> short reminder: wallet meeting tomorrow, same time
417 2018-11-15T19:16:34  <wumpus> #action wallet meeting tomorrow, same time (friday 19:00 UTC)
418 2018-11-15T19:18:44  <wumpus> this is a short meeting I suppose!
419 2018-11-15T19:19:11  <sipa> seems so
420 2018-11-15T19:19:58  <wumpus> #endmeeting
421 2018-11-15T19:19:58  <lightningbot> Meeting ended Thu Nov 15 19:19:58 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
422 2018-11-15T19:19:58  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.html
423 2018-11-15T19:19:58  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.txt
424 2018-11-15T19:19:58  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.log.html
425 2018-11-15T19:20:41  <meshcollider> Very short :)
426 2018-11-15T19:21:09  <provoostenator> Sorry, a bit distracted by a certain fork.
427 2018-11-15T19:22:57  *** laptop__ has joined #bitcoin-core-dev
428 2018-11-15T19:23:36  *** laptop__ has quit IRC
429 2018-11-15T19:23:57  *** laptop__ has joined #bitcoin-core-dev
430 2018-11-15T19:25:09  *** clarkmoody has quit IRC
431 2018-11-15T19:26:27  *** JackH has quit IRC
432 2018-11-15T19:26:30  *** shesek has quit IRC
433 2018-11-15T19:27:30  *** shesek has joined #bitcoin-core-dev
434 2018-11-15T19:27:30  *** shesek has joined #bitcoin-core-dev
435 2018-11-15T19:27:35  *** fabianfabian has quit IRC
436 2018-11-15T19:27:42  *** atroxes has quit IRC
437 2018-11-15T19:28:34  *** atroxes has joined #bitcoin-core-dev
438 2018-11-15T19:29:48  *** atroxes has quit IRC
439 2018-11-15T19:32:39  *** GoatzMilk has quit IRC
440 2018-11-15T19:34:49  *** promag has quit IRC
441 2018-11-15T19:36:09  *** conekins13 has joined #bitcoin-core-dev
442 2018-11-15T19:36:24  *** shesek has quit IRC
443 2018-11-15T19:36:42  *** conekins13 has quit IRC
444 2018-11-15T19:37:29  *** shesek has joined #bitcoin-core-dev
445 2018-11-15T19:39:10  *** jarthur has quit IRC
446 2018-11-15T19:40:04  *** oneark has quit IRC
447 2018-11-15T19:40:30  *** bitcoin-git has joined #bitcoin-core-dev
448 2018-11-15T19:40:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/e74649e95122...384967f311b4
449 2018-11-15T19:40:31  <bitcoin-git> bitcoin/master 7c5bc2a practicalswift: miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee
450 2018-11-15T19:40:31  <bitcoin-git> bitcoin/master 145fe95 practicalswift: tests: Check return value of ParseParameters(...)
451 2018-11-15T19:40:32  <bitcoin-git> bitcoin/master 579497e practicalswift: tests: Explicitly ignore the return value of DecodeBase58(...)
452 2018-11-15T19:40:32  *** bitcoin-git has left #bitcoin-core-dev
453 2018-11-15T19:41:04  *** bitcoin-git has joined #bitcoin-core-dev
454 2018-11-15T19:41:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
455 2018-11-15T19:41:04  *** bitcoin-git has left #bitcoin-core-dev
456 2018-11-15T19:41:58  *** queip has quit IRC
457 2018-11-15T19:48:41  *** shesek has quit IRC
458 2018-11-15T19:49:14  *** shesek has joined #bitcoin-core-dev
459 2018-11-15T19:49:14  *** shesek has joined #bitcoin-core-dev
460 2018-11-15T19:50:48  *** Guyver2 has joined #bitcoin-core-dev
461 2018-11-15T19:51:25  *** ezzzy has quit IRC
462 2018-11-15T19:52:07  *** queip has joined #bitcoin-core-dev
463 2018-11-15T19:54:03  *** ezzzy has joined #bitcoin-core-dev
464 2018-11-15T19:57:44  <phantomcircuit> sipa, had any issues with the poll server?
465 2018-11-15T19:58:27  <sipa> phantomcircuit: no
466 2018-11-15T19:58:52  <sipa> currently running with 160 connections
467 2018-11-15T20:00:26  <phantomcircuit> sipa, do we have anything that will exercise the performance?
468 2018-11-15T20:00:36  <phantomcircuit> like try to do ibd or something
469 2018-11-15T20:00:40  *** Murch has joined #bitcoin-core-dev
470 2018-11-15T20:00:47  <phantomcircuit> but x100 nodes
471 2018-11-15T20:00:52  *** shesek has quit IRC
472 2018-11-15T20:01:30  <sipa> jamesob: ^
473 2018-11-15T20:05:13  *** ezzzy has quit IRC
474 2018-11-15T20:05:43  *** grubles has quit IRC
475 2018-11-15T20:07:38  *** ezzzy has joined #bitcoin-core-dev
476 2018-11-15T20:09:46  *** shesek has joined #bitcoin-core-dev
477 2018-11-15T20:09:46  *** shesek has joined #bitcoin-core-dev
478 2018-11-15T20:11:04  *** Murchone has joined #bitcoin-core-dev
479 2018-11-15T20:12:19  *** shesek has quit IRC
480 2018-11-15T20:13:44  *** Murch has quit IRC
481 2018-11-15T20:14:44  *** bitconner has joined #bitcoin-core-dev
482 2018-11-15T20:24:30  *** Murchone has quit IRC
483 2018-11-15T20:26:00  *** ezzzy has quit IRC
484 2018-11-15T20:27:21  *** timothy has quit IRC
485 2018-11-15T20:29:12  *** rex4539 has quit IRC
486 2018-11-15T20:33:28  *** Murch has joined #bitcoin-core-dev
487 2018-11-15T20:34:51  *** fabianfabian has joined #bitcoin-core-dev
488 2018-11-15T20:36:20  *** grubles has joined #bitcoin-core-dev
489 2018-11-15T20:41:57  *** queip has quit IRC
490 2018-11-15T20:42:51  *** Murch has quit IRC
491 2018-11-15T20:53:10  *** queip has joined #bitcoin-core-dev
492 2018-11-15T20:57:28  *** Murch has joined #bitcoin-core-dev
493 2018-11-15T21:01:42  *** hebasto has quit IRC
494 2018-11-15T21:08:05  *** bitconner has quit IRC
495 2018-11-15T21:08:53  *** Murch has quit IRC
496 2018-11-15T21:12:22  <stevenroose> who is maintaining the gnusha.org logs? Are they open to adding more channels? We were thinging we'd love one for #rust-bitcoin
497 2018-11-15T21:12:28  <stevenroose> dongcarl: ^ there, I asked ;)
498 2018-11-15T21:12:29  *** mistergold has quit IRC
499 2018-11-15T21:12:50  <luke-jr> wumpus: unable to do so at the moment, and too tied up with other work to fix :/
500 2018-11-15T21:12:56  <dongcarl> stevenroose: ah, I got the answer, it's kanzure
501 2018-11-15T21:13:20  <luke-jr> re bitcoin_rw, reminder that things *don't* have to be high-prio for review, to be reviewed
502 2018-11-15T21:15:52  <stevenroose> dongcarl: ah oops
503 2018-11-15T21:18:05  *** jimmy has joined #bitcoin-core-dev
504 2018-11-15T21:24:43  *** rex4539 has joined #bitcoin-core-dev
505 2018-11-15T21:27:30  *** n1bor has joined #bitcoin-core-dev
506 2018-11-15T21:37:49  *** Vita has joined #bitcoin-core-dev
507 2018-11-15T21:38:40  <Vita> Zk proof of identity + POS or PoW with a hashing/staking hardcap.
508 2018-11-15T21:38:47  <Vita> 1 - Prevents recentralization
509 2018-11-15T21:40:27  <Vita> 2 - Allows and motivates scalability (implement a variable cap with formula Cap(throughput))
510 2018-11-15T21:40:29  <sipa> Vita: #bitcoin-wizards or so, off topic here
511 2018-11-15T21:40:57  <Vita> 3 - Conserves security
512 2018-11-15T21:41:26  *** bralyclow has quit IRC
513 2018-11-15T21:41:56  *** queip has quit IRC
514 2018-11-15T21:42:02  *** Vita has quit IRC
515 2018-11-15T21:45:17  *** bralyclow has joined #bitcoin-core-dev
516 2018-11-15T21:46:51  *** queip has joined #bitcoin-core-dev
517 2018-11-15T21:54:07  *** dqx_ has joined #bitcoin-core-dev
518 2018-11-15T21:57:23  *** bitconner has joined #bitcoin-core-dev
519 2018-11-15T22:01:48  *** michaelfolkson has joined #bitcoin-core-dev
520 2018-11-15T22:07:13  *** niiil has quit IRC
521 2018-11-15T22:11:01  *** promag has joined #bitcoin-core-dev
522 2018-11-15T22:12:02  *** Guyver2 has quit IRC
523 2018-11-15T22:16:39  *** shesek has joined #bitcoin-core-dev
524 2018-11-15T22:19:52  *** justanotheruser has quit IRC
525 2018-11-15T22:22:24  *** Murch has joined #bitcoin-core-dev
526 2018-11-15T22:24:52  *** jarthur has joined #bitcoin-core-dev
527 2018-11-15T22:25:57  *** michaelsdunn1 has quit IRC
528 2018-11-15T22:27:07  *** dqx_ has quit IRC
529 2018-11-15T22:27:07  *** face has quit IRC
530 2018-11-15T22:27:21  *** dqx_ has joined #bitcoin-core-dev
531 2018-11-15T22:38:15  *** shesek has quit IRC
532 2018-11-15T22:38:56  *** shesek has joined #bitcoin-core-dev
533 2018-11-15T22:41:56  *** spinza has quit IRC
534 2018-11-15T22:42:00  *** queip has quit IRC
535 2018-11-15T22:43:23  *** instagibbs has quit IRC
536 2018-11-15T22:44:25  *** morcos has quit IRC
537 2018-11-15T22:45:19  *** spinza has joined #bitcoin-core-dev
538 2018-11-15T22:46:03  *** millerti has quit IRC
539 2018-11-15T22:47:31  *** instagibbs has joined #bitcoin-core-dev
540 2018-11-15T22:48:53  <phantomcircuit> sipa, is there a sorted_vector class i can just use?
541 2018-11-15T22:49:18  <phantomcircuit> i dont think the performance gain is worth making the code more complex
542 2018-11-15T22:49:34  *** morcos has joined #bitcoin-core-dev
543 2018-11-15T22:49:36  <phantomcircuit> the only real solution to it is ultimately to register for and release events
544 2018-11-15T22:49:46  <sipa> just add stuff to a vector, and call std::sort(v.begin(), v.end()); before returning it
545 2018-11-15T22:49:48  <phantomcircuit> (which would make a switch to libevent easier)
546 2018-11-15T22:50:03  <phantomcircuit> but that's way harder to get right
547 2018-11-15T22:50:11  <sipa> but a wrapper would be neat, which exposes an efficient find
548 2018-11-15T22:50:30  <sipa> like frozenset in python
549 2018-11-15T22:50:45  *** Emcy has left #bitcoin-core-dev
550 2018-11-15T22:51:04  <phantomcircuit> hmm i guess that cant have duplicated entries either so it doesn't need to check for inclusion first
551 2018-11-15T22:51:15  <sipa> indeed
552 2018-11-15T22:51:53  *** queip has joined #bitcoin-core-dev
553 2018-11-15T22:52:25  <sipa> phantomcircuit: i think it's not worth the code complexity in your PR though
554 2018-11-15T22:52:47  <phantomcircuit> with ~100 connections SocketEvents is using 15x the cpu time though
555 2018-11-15T22:53:05  <phantomcircuit> so im not sure any change to the select set logic is worth it
556 2018-11-15T22:53:25  <sipa> 15x compared to what?
557 2018-11-15T22:53:35  *** hex17or has joined #bitcoin-core-dev
558 2018-11-15T22:54:10  <phantomcircuit> sipa, compared to GenerateSelectSets
559 2018-11-15T23:04:04  *** booyah has quit IRC
560 2018-11-15T23:05:16  *** booyah has joined #bitcoin-core-dev
561 2018-11-15T23:09:24  *** fabianfabian has quit IRC
562 2018-11-15T23:19:23  *** hex17or has quit IRC
563 2018-11-15T23:29:54  <phantomcircuit> sipa, im not sure how to make the socketevents method faster without having duplicate pollfd entries
564 2018-11-15T23:30:03  <phantomcircuit> which seem to cause problems (at least on os x)
565 2018-11-15T23:30:55  <sipa> phantomcircuit: how does allowing duplicates make it faster?
566 2018-11-15T23:31:29  *** cubancorona has quit IRC
567 2018-11-15T23:32:47  *** promag has quit IRC
568 2018-11-15T23:40:37  *** Victorsueca has quit IRC
569 2018-11-15T23:41:48  *** Victorsueca has joined #bitcoin-core-dev
570 2018-11-15T23:41:57  <phantomcircuit> sipa, currently i have a map and that needs to be converted to a vector for the actual poll() call
571 2018-11-15T23:41:57  *** queip has quit IRC
572 2018-11-15T23:42:24  *** Zenton has quit IRC
573 2018-11-15T23:42:24  *** michaelfolkson has quit IRC
574 2018-11-15T23:42:41  <phantomcircuit> the map lookup/change is slower than the vector push_back
575 2018-11-15T23:42:59  *** bitcoin-git has joined #bitcoin-core-dev
576 2018-11-15T23:42:59  <bitcoin-git> [bitcoin] zallarak opened pull request #14733: p2p: allow p2ptimeout to be configurable, speed up slow test (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
577 2018-11-15T23:42:59  *** bitcoin-git has left #bitcoin-core-dev
578 2018-11-15T23:43:06  <phantomcircuit> there's some optimization i can do but i doubt it'll have a huge impact
579 2018-11-15T23:43:23  <sipa> phantomcircuit: can you show me the code you have with the map?
580 2018-11-15T23:43:55  <phantomcircuit> sipa, https://github.com/bitcoin/bitcoin/pull/14336/commits/47526062bae7af5309156ef4ab9c2b25310f5c35#diff-9a82240fe7dfe86564178691cc57f2f1R1324
581 2018-11-15T23:45:29  <sipa> phantomcircuit: start by using an unordered_map ?
582 2018-11-15T23:47:11  <phantomcircuit> sipa, will do
583 2018-11-15T23:47:17  <phantomcircuit> i guess i'll do the rest to one sec
584 2018-11-15T23:47:20  *** shesek has quit IRC
585 2018-11-15T23:47:57  *** Chris_Stewart_5 has quit IRC
586 2018-11-15T23:48:35  *** queip has joined #bitcoin-core-dev
587 2018-11-15T23:48:49  *** shesek has joined #bitcoin-core-dev
588 2018-11-15T23:49:01  *** rh0nj has quit IRC
589 2018-11-15T23:50:08  *** rh0nj has joined #bitcoin-core-dev
590 2018-11-15T23:50:57  *** hex17or has joined #bitcoin-core-dev
591 2018-11-15T23:51:03  <phantomcircuit> sipa, actually the other one is super annoying
592 2018-11-15T23:51:27  <phantomcircuit> setting the fd and the events bitfield that way does two lookups when i only have to do one
593 2018-11-15T23:54:28  *** murrayn has quit IRC
594 2018-11-15T23:55:29  <sipa> phantomcircuit: do you hate template magic?
595 2018-11-15T23:56:25  <sipa> we could make GenerateSelectSets a templated function that takes as input a callback for each thing to listen to, which will be different for the select and the poll based implementation
596 2018-11-15T23:56:35  *** michaelsdunn1 has joined #bitcoin-core-dev
597 2018-11-15T23:56:44  <sipa> and by using a template that won't be a runtime function pointer, but an inlinable piece of code
598 2018-11-15T23:57:31  *** hex17or has quit IRC
599 2018-11-15T23:57:49  *** Krellan has joined #bitcoin-core-dev