12018-11-17T00:08:30  *** shesek has quit IRC
  22018-11-17T00:09:36  *** shesek has joined #bitcoin-core-dev
  32018-11-17T00:09:36  *** shesek has joined #bitcoin-core-dev
  42018-11-17T00:11:32  *** promag has joined #bitcoin-core-dev
  52018-11-17T00:12:06  *** shesek has quit IRC
  62018-11-17T00:14:29  *** shesek has joined #bitcoin-core-dev
  72018-11-17T00:14:29  *** shesek has joined #bitcoin-core-dev
  82018-11-17T00:21:29  *** shesek has quit IRC
  92018-11-17T00:24:26  *** shesek has joined #bitcoin-core-dev
 102018-11-17T00:24:26  *** shesek has joined #bitcoin-core-dev
 112018-11-17T00:27:14  *** michaelsdunn1 has joined #bitcoin-core-dev
 122018-11-17T00:31:56  *** michaelsdunn1 has quit IRC
 132018-11-17T00:38:24  *** spinza has quit IRC
 142018-11-17T00:41:55  *** queip has quit IRC
 152018-11-17T00:42:02  *** spinza has joined #bitcoin-core-dev
 162018-11-17T00:43:10  *** queip has joined #bitcoin-core-dev
 172018-11-17T01:01:27  *** harrymm has quit IRC
 182018-11-17T01:05:06  *** promag has quit IRC
 192018-11-17T01:18:20  *** shesek has quit IRC
 202018-11-17T01:19:01  *** shesek has joined #bitcoin-core-dev
 212018-11-17T01:22:34  *** Dizzle has joined #bitcoin-core-dev
 222018-11-17T01:29:15  *** bitconner has joined #bitcoin-core-dev
 232018-11-17T01:30:36  *** mck_ has quit IRC
 242018-11-17T01:30:45  *** IGHOR has quit IRC
 252018-11-17T01:34:06  *** bitconner has quit IRC
 262018-11-17T01:35:41  *** IGHOR has joined #bitcoin-core-dev
 272018-11-17T01:36:05  *** bitconner has joined #bitcoin-core-dev
 282018-11-17T01:53:43  *** Zenton has quit IRC
 292018-11-17T01:56:05  *** Zenton has joined #bitcoin-core-dev
 302018-11-17T02:00:40  *** zivl_ has quit IRC
 312018-11-17T02:01:54  *** Zenton has quit IRC
 322018-11-17T02:03:09  *** AaronvanW has joined #bitcoin-core-dev
 332018-11-17T02:03:13  *** bitcoin-git has joined #bitcoin-core-dev
 342018-11-17T02:03:13  <bitcoin-git> [bitcoin] dongcarl opened pull request #14741: Indicate -rpcauth option password hashing alg (master...2018-11-improve-rpcauth-help) https://github.com/bitcoin/bitcoin/pull/14741
 352018-11-17T02:03:13  *** bitcoin-git has left #bitcoin-core-dev
 362018-11-17T02:03:44  *** Zenton has joined #bitcoin-core-dev
 372018-11-17T02:08:07  *** Zenton has quit IRC
 382018-11-17T02:08:14  *** AaronvanW has quit IRC
 392018-11-17T02:08:40  *** Zenton has joined #bitcoin-core-dev
 402018-11-17T02:12:30  *** Krellan has quit IRC
 412018-11-17T02:18:55  <meshcollider> Ooh GitHub now has force-push notifications
 422018-11-17T02:18:58  <meshcollider> That's useful
 432018-11-17T02:19:35  <meshcollider> See e.g. #14733
 442018-11-17T02:19:37  <gribble> https://github.com/bitcoin/bitcoin/issues/14733 | p2p: allow p2ptimeout to be configurable, speed up slow test by zallarak · Pull Request #14733 · bitcoin/bitcoin · GitHub
 452018-11-17T02:50:27  *** shesek has quit IRC
 462018-11-17T02:53:59  *** _cryptosignal_me has joined #bitcoin-core-dev
 472018-11-17T03:01:30  *** bitconner has quit IRC
 482018-11-17T03:09:51  *** bitconner has joined #bitcoin-core-dev
 492018-11-17T03:15:23  *** bitconner has quit IRC
 502018-11-17T03:19:13  *** bitconner has joined #bitcoin-core-dev
 512018-11-17T03:22:05  *** henry_ma has joined #bitcoin-core-dev
 522018-11-17T03:23:49  *** bitconner has quit IRC
 532018-11-17T03:26:35  *** henry_ma has quit IRC
 542018-11-17T03:27:47  *** _cryptosignal_me has quit IRC
 552018-11-17T03:37:53  *** fabianfabian has quit IRC
 562018-11-17T03:38:45  *** bitconner has joined #bitcoin-core-dev
 572018-11-17T03:42:00  *** queip has quit IRC
 582018-11-17T03:42:48  *** queip has joined #bitcoin-core-dev
 592018-11-17T03:43:17  *** bitconner has quit IRC
 602018-11-17T03:46:29  *** bitconner has joined #bitcoin-core-dev
 612018-11-17T03:51:25  *** bitconner has quit IRC
 622018-11-17T03:54:28  *** jarthur has joined #bitcoin-core-dev
 632018-11-17T03:59:44  *** ryanofsky_ is now known as ryanofsky
 642018-11-17T04:01:55  *** bitconner has joined #bitcoin-core-dev
 652018-11-17T04:04:03  *** AaronvanW has joined #bitcoin-core-dev
 662018-11-17T04:06:49  *** bitconner has quit IRC
 672018-11-17T04:08:07  *** AaronvanW has quit IRC
 682018-11-17T04:13:39  *** dviola has quit IRC
 692018-11-17T04:17:40  *** bitconner has joined #bitcoin-core-dev
 702018-11-17T04:18:10  *** jhfrontz has quit IRC
 712018-11-17T04:22:06  *** michaelsdunn1 has joined #bitcoin-core-dev
 722018-11-17T04:22:33  *** bitconner has quit IRC
 732018-11-17T04:26:07  *** michaelsdunn1 has quit IRC
 742018-11-17T04:42:02  *** queip has quit IRC
 752018-11-17T04:45:18  *** queip has joined #bitcoin-core-dev
 762018-11-17T04:49:49  *** morcos has quit IRC
 772018-11-17T04:50:24  *** ghost43 has quit IRC
 782018-11-17T04:54:48  *** morcos has joined #bitcoin-core-dev
 792018-11-17T04:55:24  *** michaelfolkson has joined #bitcoin-core-dev
 802018-11-17T04:55:55  *** ghost43 has joined #bitcoin-core-dev
 812018-11-17T05:02:20  *** niiil has joined #bitcoin-core-dev
 822018-11-17T05:05:55  *** michaelfolkson has quit IRC
 832018-11-17T05:06:45  *** niiil has quit IRC
 842018-11-17T05:27:22  *** bitconner has joined #bitcoin-core-dev
 852018-11-17T05:32:21  *** bitconner has quit IRC
 862018-11-17T05:42:03  *** queip has quit IRC
 872018-11-17T05:43:17  *** queip has joined #bitcoin-core-dev
 882018-11-17T05:59:33  *** bitconner has joined #bitcoin-core-dev
 892018-11-17T06:00:07  *** keer4n has quit IRC
 902018-11-17T06:04:43  *** AaronvanW has joined #bitcoin-core-dev
 912018-11-17T06:08:47  *** AaronvanW has quit IRC
 922018-11-17T06:14:01  *** rh0nj has quit IRC
 932018-11-17T06:15:07  *** rh0nj has joined #bitcoin-core-dev
 942018-11-17T06:16:08  *** bitconner has quit IRC
 952018-11-17T06:23:23  *** bitconner has joined #bitcoin-core-dev
 962018-11-17T06:26:56  *** shesek has joined #bitcoin-core-dev
 972018-11-17T06:26:56  *** shesek has joined #bitcoin-core-dev
 982018-11-17T06:35:35  *** rex4539 has joined #bitcoin-core-dev
 992018-11-17T06:36:29  *** bitconner has quit IRC
1002018-11-17T06:40:47  *** shesek has quit IRC
1012018-11-17T06:41:19  *** shesek has joined #bitcoin-core-dev
1022018-11-17T06:41:56  *** queip has quit IRC
1032018-11-17T06:42:29  <dongcarl> Any reason why `bitcoin/share/rpcauth/rpcauth.py` generates a 16 byte salt instead of a 32 byte salt? I believe RFC 2104 recommends the key length to be larger than or equal to the hash output length: https://tools.ietf.org/html/rfc2104#section-3
1042018-11-17T06:42:37  *** queip has joined #bitcoin-core-dev
1052018-11-17T06:44:28  *** bitconner has joined #bitcoin-core-dev
1062018-11-17T06:46:30  <dongcarl> It also seems that the format string will only output one character if the randomly generated byte is below 0x10, which I don't think is the expected behavior...
1072018-11-17T06:47:54  <sipa> dongcarl: you don't need an HMAC here
1082018-11-17T06:48:04  <sipa> or ratherx you don't actually need a MAC here
1092018-11-17T06:48:22  <sipa> just a hash with some protection against dictionaries
1102018-11-17T06:48:44  <sipa> so making the salt large enough to make a dictionary attack infeasible is enough
1112018-11-17T06:48:49  <sipa> 64 bits probably suffices
1122018-11-17T06:50:25  <dongcarl> sipa: right, but it wouldn't hurt to have a few more bits of entropy and conform to the spec?
1132018-11-17T06:50:42  <dongcarl> Also with the format string bug we have less than 64 bits at times
1142018-11-17T06:50:58  <sipa> dongcarl: link to code?
1152018-11-17T06:51:17  <dongcarl> sipa: https://github.com/bitcoin/bitcoin/blob/master/share/rpcauth/rpcauth.py#L18
1162018-11-17T06:51:54  *** bitconner has quit IRC
1172018-11-17T06:52:02  <dongcarl> That format string will only output 1 character if the r in salt_sequence is less than 0x10
1182018-11-17T06:52:11  <sipa> nice catch
1192018-11-17T06:52:48  <sipa> but it's not a problem; the set of encoded salts still has 128 bits of entropy
1202018-11-17T06:53:01  <sipa> oh, no!
1212018-11-17T06:53:03  <sipa> slightly less
1222018-11-17T06:53:09  <dongcarl> Right
1232018-11-17T06:53:10  <sipa> there are collisions
1242018-11-17T06:53:42  <dongcarl> I'll PR to fix it to make it according to normal expectations
1252018-11-17T06:54:10  <sipa> dongcarl: i don't think "comforming to the spec" matters here; the spec is to satsify the requirements of a secure MAaC; we don't need a secure MAC
1262018-11-17T06:54:24  <sipa> but yes, please fix the formatting issue
1272018-11-17T06:54:59  <dongcarl> Okay gotcha
1282018-11-17T06:57:28  *** shesek has quit IRC
1292018-11-17T06:57:30  *** Krellan has joined #bitcoin-core-dev
1302018-11-17T07:10:51  *** satwo has quit IRC
1312018-11-17T07:13:40  <jarthur> Wait, why slightly less than 128? If r is more than 0x10, don't we get more than 1 character?
1322018-11-17T07:17:41  <sipa> the number of characters doesn't matter
1332018-11-17T07:17:47  <sipa> the number of combinations matters
1342018-11-17T07:19:23  <sipa> but given that there are distinct inputs that map to the same salt string (e.g. (0x1, 0x23, 0x45) and (0x12, 0x34, 0x5) both map to 12345)
1352018-11-17T07:19:56  <jarthur> Makes sense now. Thanks :)
1362018-11-17T07:24:16  *** satwo has joined #bitcoin-core-dev
1372018-11-17T07:24:52  *** satwo has quit IRC
1382018-11-17T07:32:00  <jarthur> The format line could just be replaced by using binascii.hexlify, that way we'll get two-digit hexes as ASCII bytes and won't need the later UTF-8 encodes. Would just need to use salt.decode('ascii') in the printed string.
1392018-11-17T07:32:19  <dongcarl> jarthur: I just did os.random(16).hex()
1402018-11-17T07:32:21  <dongcarl> works fine
1412018-11-17T07:32:38  <jarthur> I like that even better
1422018-11-17T07:32:40  <jarthur> nice
1432018-11-17T07:34:10  *** bitcoin-git has joined #bitcoin-core-dev
1442018-11-17T07:34:10  <bitcoin-git> [bitcoin] dongcarl opened pull request #14742: Properly generate salt in rpcauth.py (master...2018-11-fix-rpcauth-salt) https://github.com/bitcoin/bitcoin/pull/14742
1452018-11-17T07:34:10  *** bitcoin-git has left #bitcoin-core-dev
1462018-11-17T07:41:03  <sipa> dongcarl: do we require python 3.6?
1472018-11-17T07:41:56  *** queip has quit IRC
1482018-11-17T07:42:53  <dongcarl> sipa: I think we require python at least
1492018-11-17T07:42:56  <dongcarl> python3
1502018-11-17T07:43:44  <jarthur> bytes.hex was introduced in Python 3.5
1512018-11-17T07:43:44  <dongcarl> we require python 3.4 for tests according to https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md
1522018-11-17T07:44:10  *** queip has joined #bitcoin-core-dev
1532018-11-17T07:44:31  <dongcarl> jarthur: link?
1542018-11-17T07:44:39  <jarthur> https://docs.python.org/3/library/stdtypes.html#bytes.hex
1552018-11-17T07:45:14  <dongcarl> Ooof
1562018-11-17T07:45:54  <sipa> because python 3.6 has the "secret" module
1572018-11-17T07:46:09  <sipa> for generating cryptographic strength randomness
1582018-11-17T07:47:20  <luke-jr> RHEL seems to be at Python 3.4 (w/ EPEL)
1592018-11-17T07:50:06  <dongcarl> Okay guess I'll conform to python 3.4...
1602018-11-17T07:50:15  <dongcarl> :-(
1612018-11-17T07:51:19  * luke-jr guesses he should probably reinstall Py3.4 for this purpose
1622018-11-17T07:51:31  <jarthur> Too bad. Python 3.6 was one of the best Python releases to date, features-wise.
1632018-11-17T07:52:02  <dongcarl> Yeah I think 3.6 was optional types as well?
1642018-11-17T07:52:13  <luke-jr> jarthur: we'll get there eventually
1652018-11-17T07:52:44  <luke-jr> it tends to be RHEL holding things back, and RHEL 8 is supposedly due this year
1662018-11-17T07:53:44  <luke-jr> with 3.6 apparently: https://developers.redhat.com/blog/2018/11/14/python-in-rhel-8/
1672018-11-17T07:54:14  <Dizzle> Cool, I'm not worried, just wishful
1682018-11-17T07:54:19  <luke-jr> although Debian stable is only 3.5
1692018-11-17T07:54:44  <luke-jr> and next not due until 2019
1702018-11-17T07:55:50  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
1712018-11-17T07:57:46  *** zivl has joined #bitcoin-core-dev
1722018-11-17T07:59:28  *** Ga1aCt1Cz00__ has quit IRC
1732018-11-17T08:00:42  *** rex4539 has quit IRC
1742018-11-17T08:01:12  <jarthur> dongcarl: yea, though I'm kind of lumping 3.5 and 3.6 together since the latter polished a lot of the 3.5 stuff. f-strings, async iteration and generation, optional typing, efficient dicts, path-like objects
1752018-11-17T08:01:55  *** rex4539 has joined #bitcoin-core-dev
1762018-11-17T08:02:13  <meshcollider> sipa: if it's secret, how do you know about it
1772018-11-17T08:05:02  <dongcarl> meshcollider: the sipa knows all, don't you know? https://cryptopop.files.wordpress.com/2017/12/pieter_wuille_v2.png?w=768
1782018-11-17T08:05:27  *** AaronvanW has joined #bitcoin-core-dev
1792018-11-17T08:09:55  *** AaronvanW has quit IRC
1802018-11-17T08:12:32  <luke-jr> XD
1812018-11-17T08:13:07  <luke-jr> dongcarl: is he a gardener?
1822018-11-17T08:14:54  <dongcarl> Gunna stop this digression from development discussion here, but luke-jr here's the source: https://twitter.com/coindesk/status/947699170353340416
1832018-11-17T08:17:49  *** shesek has joined #bitcoin-core-dev
1842018-11-17T08:17:49  *** shesek has joined #bitcoin-core-dev
1852018-11-17T08:23:18  *** jarthur has quit IRC
1862018-11-17T08:23:19  *** Dizzle has quit IRC
1872018-11-17T08:25:21  *** twoflower has joined #bitcoin-core-dev
1882018-11-17T08:27:27  *** Murch has joined #bitcoin-core-dev
1892018-11-17T08:29:09  *** emilr has joined #bitcoin-core-dev
1902018-11-17T08:30:06  *** Murch has quit IRC
1912018-11-17T08:38:49  *** twoflower has quit IRC
1922018-11-17T08:42:00  *** queip has quit IRC
1932018-11-17T08:42:12  *** AaronvanW has joined #bitcoin-core-dev
1942018-11-17T08:42:38  *** queip has joined #bitcoin-core-dev
1952018-11-17T08:46:42  *** AaronvanW has quit IRC
1962018-11-17T08:47:06  *** ExtraCrispy has joined #bitcoin-core-dev
1972018-11-17T08:49:13  *** shesek has quit IRC
1982018-11-17T09:13:29  *** Krellan has quit IRC
1992018-11-17T09:32:27  *** Guyver2 has joined #bitcoin-core-dev
2002018-11-17T09:34:39  *** lukedashjr has joined #bitcoin-core-dev
2012018-11-17T09:35:03  *** luke-jr has quit IRC
2022018-11-17T09:40:43  *** lukedashjr is now known as luke-jr
2032018-11-17T09:41:56  *** queip has quit IRC
2042018-11-17T09:43:33  *** queip has joined #bitcoin-core-dev
2052018-11-17T09:44:07  *** justanotheruser has quit IRC
2062018-11-17T09:44:38  *** AaronvanW has joined #bitcoin-core-dev
2072018-11-17T09:49:05  *** AaronvanW has quit IRC
2082018-11-17T09:50:25  *** Krellan has joined #bitcoin-core-dev
2092018-11-17T09:55:33  *** AaronvanW has joined #bitcoin-core-dev
2102018-11-17T10:00:12  *** AaronvanW has quit IRC
2112018-11-17T10:02:02  *** justanotheruser has joined #bitcoin-core-dev
2122018-11-17T10:02:58  *** kexkey has quit IRC
2132018-11-17T10:07:50  *** rex4539 has quit IRC
2142018-11-17T10:13:24  *** spinza has quit IRC
2152018-11-17T10:14:02  *** rh0nj has quit IRC
2162018-11-17T10:14:37  *** fabianfabian has joined #bitcoin-core-dev
2172018-11-17T10:15:08  *** rh0nj has joined #bitcoin-core-dev
2182018-11-17T10:22:05  *** spinza has joined #bitcoin-core-dev
2192018-11-17T10:27:19  *** hex17or has joined #bitcoin-core-dev
2202018-11-17T10:37:48  *** rex4539 has joined #bitcoin-core-dev
2212018-11-17T10:42:00  *** queip has quit IRC
2222018-11-17T10:42:42  *** queip has joined #bitcoin-core-dev
2232018-11-17T10:42:54  *** hex17or has quit IRC
2242018-11-17T10:44:43  *** CodeBlue1776 has quit IRC
2252018-11-17T10:45:00  *** CodeBlue1776 has joined #bitcoin-core-dev
2262018-11-17T11:03:26  *** Guest22 has joined #bitcoin-core-dev
2272018-11-17T11:11:24  *** hex17or has joined #bitcoin-core-dev
2282018-11-17T11:20:44  *** rex4539 has quit IRC
2292018-11-17T11:26:29  *** hex17or has quit IRC
2302018-11-17T11:27:24  *** AaronvanW has joined #bitcoin-core-dev
2312018-11-17T11:31:54  *** AaronvanW has quit IRC
2322018-11-17T11:41:58  *** queip has quit IRC
2332018-11-17T11:43:14  *** queip has joined #bitcoin-core-dev
2342018-11-17T11:46:04  *** hex17or has joined #bitcoin-core-dev
2352018-11-17T11:53:23  *** AaronvanW has joined #bitcoin-core-dev
2362018-11-17T12:05:28  *** justanotheruser has quit IRC
2372018-11-17T12:12:47  *** spinza has quit IRC
2382018-11-17T12:17:40  *** hex17or has quit IRC
2392018-11-17T12:42:09  *** queip has quit IRC
2402018-11-17T12:44:31  *** spinza has joined #bitcoin-core-dev
2412018-11-17T12:44:47  *** queip has joined #bitcoin-core-dev
2422018-11-17T12:58:02  *** ken2812221 has joined #bitcoin-core-dev
2432018-11-17T12:59:19  *** riemann_ has quit IRC
2442018-11-17T13:00:57  *** bitcoin-git has joined #bitcoin-core-dev
2452018-11-17T13:00:58  <bitcoin-git> [bitcoin] LucianaMarques opened pull request #14744: [Docs] Added NSIS install steps to build-windows.md (master...windows-doc) https://github.com/bitcoin/bitcoin/pull/14744
2462018-11-17T13:00:58  *** bitcoin-git has left #bitcoin-core-dev
2472018-11-17T13:10:16  *** booyah has quit IRC
2482018-11-17T13:40:56  *** rex4539 has joined #bitcoin-core-dev
2492018-11-17T13:41:57  *** queip has quit IRC
2502018-11-17T13:44:19  *** queip has joined #bitcoin-core-dev
2512018-11-17T14:03:52  *** Aaronvan_ has joined #bitcoin-core-dev
2522018-11-17T14:06:54  *** AaronvanW has quit IRC
2532018-11-17T14:13:51  *** bitcoin-git has joined #bitcoin-core-dev
2542018-11-17T14:13:51  <bitcoin-git> [bitcoin] IPGlider opened pull request #14746: Check for invalid prefixes in config file (master...check_invalid_prefixes_in_config_file) https://github.com/bitcoin/bitcoin/pull/14746
2552018-11-17T14:13:51  *** bitcoin-git has left #bitcoin-core-dev
2562018-11-17T14:15:47  *** bitcoin-git has joined #bitcoin-core-dev
2572018-11-17T14:15:47  <bitcoin-git> [bitcoin] IPGlider closed pull request #14746: Check for invalid prefixes in config file (master...check_invalid_prefixes_in_config_file) https://github.com/bitcoin/bitcoin/pull/14746
2582018-11-17T14:15:47  *** bitcoin-git has left #bitcoin-core-dev
2592018-11-17T14:16:01  *** rh0nj has quit IRC
2602018-11-17T14:17:03  *** michaelfolkson has joined #bitcoin-core-dev
2612018-11-17T14:17:11  *** rh0nj has joined #bitcoin-core-dev
2622018-11-17T14:21:10  *** booyah has joined #bitcoin-core-dev
2632018-11-17T14:21:49  *** rex4539 has quit IRC
2642018-11-17T14:23:46  *** asoltys has quit IRC
2652018-11-17T14:24:04  *** asoltys has joined #bitcoin-core-dev
2662018-11-17T14:24:56  *** sdaftuar has quit IRC
2672018-11-17T14:25:12  *** sdaftuar has joined #bitcoin-core-dev
2682018-11-17T14:29:48  *** michaelfolkson has quit IRC
2692018-11-17T14:36:47  *** drexl_ has joined #bitcoin-core-dev
2702018-11-17T14:38:58  *** hex17or has joined #bitcoin-core-dev
2712018-11-17T14:40:06  *** drexl has quit IRC
2722018-11-17T14:42:02  *** queip has quit IRC
2732018-11-17T14:43:14  *** queip has joined #bitcoin-core-dev
2742018-11-17T14:46:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2752018-11-17T14:50:29  *** mistergold has joined #bitcoin-core-dev
2762018-11-17T15:15:08  *** hex17or has quit IRC
2772018-11-17T15:18:06  *** rex4539 has joined #bitcoin-core-dev
2782018-11-17T15:22:21  *** dramstroker has joined #bitcoin-core-dev
2792018-11-17T15:27:50  *** hex17or has joined #bitcoin-core-dev
2802018-11-17T15:35:47  *** dramstroker has quit IRC
2812018-11-17T15:42:04  *** queip has quit IRC
2822018-11-17T15:56:49  *** queip has joined #bitcoin-core-dev
2832018-11-17T16:01:52  *** hex17or has quit IRC
2842018-11-17T16:16:57  *** bitcoin-git has joined #bitcoin-core-dev
2852018-11-17T16:16:58  <bitcoin-git> [bitcoin] Empact opened pull request #14747: build: Drop AC_CHECK_DECLS for unused __builtin_clz (master...builtin-clz) https://github.com/bitcoin/bitcoin/pull/14747
2862018-11-17T16:16:58  *** bitcoin-git has left #bitcoin-core-dev
2872018-11-17T16:26:10  *** hex17or has joined #bitcoin-core-dev
2882018-11-17T16:30:31  *** hex17or has quit IRC
2892018-11-17T16:34:02  *** Chris_Stewart_5 has quit IRC
2902018-11-17T16:37:15  *** rockstarjack has quit IRC
2912018-11-17T16:41:54  *** hex17or has joined #bitcoin-core-dev
2922018-11-17T16:42:00  *** queip has quit IRC
2932018-11-17T16:49:52  *** hex17or has quit IRC
2942018-11-17T16:50:56  *** queip has joined #bitcoin-core-dev
2952018-11-17T16:57:35  *** laurentmt has joined #bitcoin-core-dev
2962018-11-17T16:59:02  *** laurentmt has quit IRC
2972018-11-17T17:12:12  *** opdenkamp has joined #bitcoin-core-dev
2982018-11-17T17:27:00  *** morcos has quit IRC
2992018-11-17T17:27:21  *** morcos has joined #bitcoin-core-dev
3002018-11-17T17:34:27  *** justanotheruser has joined #bitcoin-core-dev
3012018-11-17T17:41:57  *** queip has quit IRC
3022018-11-17T17:48:03  *** queip has joined #bitcoin-core-dev
3032018-11-17T17:56:56  *** ExtraCrispy has quit IRC
3042018-11-17T18:12:47  <dongcarl> Would it be possible to block a user from bitcoin/bitcoin? This guy's been spamming: https://github.com/bitcoin/bitcoin/pull/14742#issuecomment-439635586
3052018-11-17T18:18:01  *** rh0nj has quit IRC
3062018-11-17T18:19:07  *** rh0nj has joined #bitcoin-core-dev
3072018-11-17T18:40:03  *** drexl__ has joined #bitcoin-core-dev
3082018-11-17T18:40:27  *** drexl_ has quit IRC
3092018-11-17T18:41:57  *** queip has quit IRC
3102018-11-17T18:44:01  *** Aaronvan_ has quit IRC
3112018-11-17T18:54:23  *** AaronvanW has joined #bitcoin-core-dev
3122018-11-17T18:56:43  *** queip has joined #bitcoin-core-dev
3132018-11-17T18:58:39  *** JackH has joined #bitcoin-core-dev
3142018-11-17T18:59:00  *** AaronvanW has quit IRC
3152018-11-17T19:02:02  *** dviola has joined #bitcoin-core-dev
3162018-11-17T19:05:03  *** hex17or has joined #bitcoin-core-dev
3172018-11-17T19:07:06  *** yzT4 has joined #bitcoin-core-dev
3182018-11-17T19:13:41  *** mistergold has quit IRC
3192018-11-17T19:14:07  *** jhfrontz has joined #bitcoin-core-dev
3202018-11-17T19:33:33  *** cjd has quit IRC
3212018-11-17T19:33:42  *** cjd has joined #bitcoin-core-dev
3222018-11-17T19:35:39  *** teardown has joined #bitcoin-core-dev
3232018-11-17T19:51:38  *** hex17or has quit IRC
3242018-11-17T19:55:26  *** AaronvanW has joined #bitcoin-core-dev
3252018-11-17T19:57:45  *** EagleTM has joined #bitcoin-core-dev
3262018-11-17T19:59:38  *** AaronvanW has quit IRC
3272018-11-17T20:20:47  *** bitcoin-git has joined #bitcoin-core-dev
3282018-11-17T20:20:48  <bitcoin-git> [bitcoin] vim88 opened pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
3292018-11-17T20:20:48  *** bitcoin-git has left #bitcoin-core-dev
3302018-11-17T20:27:43  *** emilr has quit IRC
3312018-11-17T20:32:51  *** mistergold has joined #bitcoin-core-dev
3322018-11-17T20:41:58  *** queip has quit IRC
3332018-11-17T20:45:56  *** hex17or has joined #bitcoin-core-dev
3342018-11-17T20:46:45  *** hex17or has quit IRC
3352018-11-17T20:50:22  *** zallarak has joined #bitcoin-core-dev
3362018-11-17T20:51:33  *** bitcoin-git has joined #bitcoin-core-dev
3372018-11-17T20:51:33  <bitcoin-git> [bitcoin] vim88 closed pull request #14749: Refactor: Changes postincrement to preincrement in for loop in src/consensus files (master...postincrement_to_preincrement_src_consensus) https://github.com/bitcoin/bitcoin/pull/14749
3382018-11-17T20:51:33  *** bitcoin-git has left #bitcoin-core-dev
3392018-11-17T20:52:44  <zallarak> Thank you to those that left feedback on my PR. Does anyone else have thoughts? (https://github.com/bitcoin/bitcoin/pull/14733)
3402018-11-17T20:56:58  *** queip has joined #bitcoin-core-dev
3412018-11-17T21:01:47  *** mistergo1d has joined #bitcoin-core-dev
3422018-11-17T21:02:56  *** Krellan has quit IRC
3432018-11-17T21:03:31  *** Krellan has joined #bitcoin-core-dev
3442018-11-17T21:03:44  *** AaronvanW has joined #bitcoin-core-dev
3452018-11-17T21:04:17  *** Krellan_ has joined #bitcoin-core-dev
3462018-11-17T21:05:27  *** mistergold has quit IRC
3472018-11-17T21:08:28  *** Krellan has quit IRC
3482018-11-17T21:09:11  *** Krellan_ has quit IRC
3492018-11-17T21:17:50  *** Krellan__ has joined #bitcoin-core-dev
3502018-11-17T21:22:18  *** Krellan__ has quit IRC
3512018-11-17T21:23:54  *** Krellan has joined #bitcoin-core-dev
3522018-11-17T21:24:31  *** Krellan has quit IRC
3532018-11-17T21:27:10  *** Krellan_ has joined #bitcoin-core-dev
3542018-11-17T21:28:02  *** Krellan__ has joined #bitcoin-core-dev
3552018-11-17T21:28:03  *** Krellan_ has quit IRC
3562018-11-17T21:32:42  *** Krellan__ has quit IRC
3572018-11-17T21:34:17  *** Krellan_ has joined #bitcoin-core-dev
3582018-11-17T21:40:38  *** EagleTM has quit IRC
3592018-11-17T21:40:38  *** EagleTM has joined #bitcoin-core-dev
3602018-11-17T21:45:17  *** Krellan has joined #bitcoin-core-dev
3612018-11-17T21:47:55  *** Krellan_ has quit IRC
3622018-11-17T21:48:12  *** coolpup has quit IRC
3632018-11-17T21:48:22  *** Krellan_ has joined #bitcoin-core-dev
3642018-11-17T21:49:38  *** Krella___ has joined #bitcoin-core-dev
3652018-11-17T21:49:56  *** coolpup has joined #bitcoin-core-dev
3662018-11-17T21:50:15  *** coolpup has joined #bitcoin-core-dev
3672018-11-17T21:50:28  *** Krellan has quit IRC
3682018-11-17T21:50:35  *** coolpup has joined #bitcoin-core-dev
3692018-11-17T21:50:50  *** coolpup has joined #bitcoin-core-dev
3702018-11-17T21:51:10  *** coolpup has joined #bitcoin-core-dev
3712018-11-17T21:51:28  *** coolpup has joined #bitcoin-core-dev
3722018-11-17T21:53:21  *** Krellan_ has quit IRC
3732018-11-17T21:54:06  *** Krella___ has quit IRC
3742018-11-17T21:58:50  *** Krellan has joined #bitcoin-core-dev
3752018-11-17T22:02:58  *** Krellan__ has joined #bitcoin-core-dev
3762018-11-17T22:03:44  *** Krellan has quit IRC
3772018-11-17T22:04:59  *** Krellan_ has joined #bitcoin-core-dev
3782018-11-17T22:10:06  *** Krellan_ has quit IRC
3792018-11-17T22:14:32  *** Krellan has joined #bitcoin-core-dev
3802018-11-17T22:15:13  *** Krellan has quit IRC
3812018-11-17T22:15:34  *** Krellan has joined #bitcoin-core-dev
3822018-11-17T22:18:31  *** Krellan_ has joined #bitcoin-core-dev
3832018-11-17T22:19:37  *** Krellan__ has joined #bitcoin-core-dev
3842018-11-17T22:20:01  *** rh0nj has quit IRC
3852018-11-17T22:20:28  *** Krellan has quit IRC
3862018-11-17T22:23:08  *** rh0nj has joined #bitcoin-core-dev
3872018-11-17T22:23:19  *** Krellan_ has quit IRC
3882018-11-17T22:24:21  *** Krellan__ has quit IRC
3892018-11-17T22:27:46  *** spinza has quit IRC
3902018-11-17T22:30:08  *** Krellan has joined #bitcoin-core-dev
3912018-11-17T22:31:12  *** jb55 has joined #bitcoin-core-dev
3922018-11-17T22:33:38  *** rex4539 has quit IRC
3932018-11-17T22:34:24  *** spinza has joined #bitcoin-core-dev
3942018-11-17T22:34:48  *** Krellan has quit IRC
3952018-11-17T22:35:19  *** Krellan has joined #bitcoin-core-dev
3962018-11-17T22:36:01  *** Krellan_ has joined #bitcoin-core-dev
3972018-11-17T22:40:16  *** Krellan has quit IRC
3982018-11-17T22:40:46  *** Krellan_ has quit IRC
3992018-11-17T22:41:57  *** queip has quit IRC
4002018-11-17T22:43:45  *** drexl___ has joined #bitcoin-core-dev
4012018-11-17T22:43:48  *** drexl__ has quit IRC
4022018-11-17T22:45:08  *** mistergo1d has quit IRC
4032018-11-17T22:45:17  *** mistergold has joined #bitcoin-core-dev
4042018-11-17T22:46:10  *** hex17or has joined #bitcoin-core-dev
4052018-11-17T22:46:29  *** Krellan has joined #bitcoin-core-dev
4062018-11-17T22:47:34  *** Krellan_ has joined #bitcoin-core-dev
4072018-11-17T22:49:39  *** Krellan__ has joined #bitcoin-core-dev
4082018-11-17T22:50:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4092018-11-17T22:50:39  *** Krella___ has joined #bitcoin-core-dev
4102018-11-17T22:51:40  *** Krellan has quit IRC
4112018-11-17T22:52:08  *** queip has joined #bitcoin-core-dev
4122018-11-17T22:52:26  *** Krellan_ has quit IRC
4132018-11-17T22:54:03  *** Krellan__ has quit IRC
4142018-11-17T22:54:15  *** lnostdal has quit IRC
4152018-11-17T22:55:45  *** Krella___ has quit IRC
4162018-11-17T23:00:01  *** Krellan has joined #bitcoin-core-dev
4172018-11-17T23:00:55  *** Krellan_ has joined #bitcoin-core-dev
4182018-11-17T23:02:08  *** Krellan has joined #bitcoin-core-dev
4192018-11-17T23:03:24  *** booyah_ has joined #bitcoin-core-dev
4202018-11-17T23:03:25  *** booyah has quit IRC
4212018-11-17T23:05:12  *** Krella___ has joined #bitcoin-core-dev
4222018-11-17T23:05:51  *** Krellan_ has quit IRC
4232018-11-17T23:06:15  *** Krellan_ has joined #bitcoin-core-dev
4242018-11-17T23:06:42  *** Krellan has quit IRC
4252018-11-17T23:10:16  *** Krella___ has quit IRC
4262018-11-17T23:10:32  *** mistergold has quit IRC
4272018-11-17T23:10:41  *** Krellan_ has quit IRC
4282018-11-17T23:14:29  *** booyah_ is now known as booyah
4292018-11-17T23:15:34  *** Krellan has joined #bitcoin-core-dev
4302018-11-17T23:16:31  *** Krellan_ has joined #bitcoin-core-dev
4312018-11-17T23:17:37  *** Krellan has joined #bitcoin-core-dev
4322018-11-17T23:20:37  *** Krellan__ has joined #bitcoin-core-dev
4332018-11-17T23:21:40  *** Krellan_ has quit IRC
4342018-11-17T23:21:57  *** Krellan has quit IRC
4352018-11-17T23:25:41  *** Krellan__ has quit IRC
4362018-11-17T23:29:02  *** Krellan has joined #bitcoin-core-dev
4372018-11-17T23:31:07  *** Krellan_ has joined #bitcoin-core-dev
4382018-11-17T23:32:59  *** Krellan__ has joined #bitcoin-core-dev
4392018-11-17T23:33:00  *** Krellan_ has quit IRC
4402018-11-17T23:33:27  *** phwalkr has joined #bitcoin-core-dev
4412018-11-17T23:33:39  *** Krellan has quit IRC
4422018-11-17T23:34:10  *** Krellan has joined #bitcoin-core-dev
4432018-11-17T23:37:56  *** Krellan__ has quit IRC
4442018-11-17T23:38:27  *** Guyver2 has quit IRC
4452018-11-17T23:38:36  *** Krellan has quit IRC
4462018-11-17T23:39:27  *** Krellan has joined #bitcoin-core-dev
4472018-11-17T23:41:13  *** Krellan has quit IRC
4482018-11-17T23:41:58  *** queip has quit IRC
4492018-11-17T23:42:42  *** Krellan has joined #bitcoin-core-dev
4502018-11-17T23:44:42  *** Krellan_ has joined #bitcoin-core-dev
4512018-11-17T23:45:03  *** lnostdal has joined #bitcoin-core-dev
4522018-11-17T23:47:07  *** Krellan has quit IRC
4532018-11-17T23:48:56  *** phwalkr has quit IRC
4542018-11-17T23:49:03  *** Krellan_ has quit IRC
4552018-11-17T23:53:46  *** queip has joined #bitcoin-core-dev
4562018-11-17T23:55:53  *** Krellan has joined #bitcoin-core-dev
4572018-11-17T23:58:33  *** rex4539 has joined #bitcoin-core-dev