1 2018-11-27T00:00:30  *** michaelsdunn1 has joined #bitcoin-core-dev
  2 2018-11-27T00:06:02  *** Guest77842 has joined #bitcoin-core-dev
  3 2018-11-27T00:07:06  *** schnerchi has quit IRC
  4 2018-11-27T00:07:35  *** spinza has quit IRC
  5 2018-11-27T00:12:40  *** spinza has joined #bitcoin-core-dev
  6 2018-11-27T00:13:04  *** schnerchi has joined #bitcoin-core-dev
  7 2018-11-27T00:19:18  *** n1bor has quit IRC
  8 2018-11-27T00:19:29  *** Victorsueca has quit IRC
  9 2018-11-27T00:20:04  *** n1bor has joined #bitcoin-core-dev
 10 2018-11-27T00:28:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 11 2018-11-27T00:28:36  *** Isthmus has joined #bitcoin-core-dev
 12 2018-11-27T00:33:32  *** Guest77842 has quit IRC
 13 2018-11-27T00:35:07  *** michaelsdunn1 has quit IRC
 14 2018-11-27T00:36:45  *** Guest77842 has joined #bitcoin-core-dev
 15 2018-11-27T00:36:49  *** Guest77842 has quit IRC
 16 2018-11-27T00:37:56  *** TheHoliestRoger has quit IRC
 17 2018-11-27T00:38:32  *** michaelsdunn1 has joined #bitcoin-core-dev
 18 2018-11-27T00:40:15  *** michaelsdunn1 has quit IRC
 19 2018-11-27T00:45:42  *** TheHoliestRoger has joined #bitcoin-core-dev
 20 2018-11-27T00:46:44  *** promag has quit IRC
 21 2018-11-27T00:47:21  *** promag has joined #bitcoin-core-dev
 22 2018-11-27T00:53:29  *** lnostdal has quit IRC
 23 2018-11-27T00:57:30  *** go1111111 has joined #bitcoin-core-dev
 24 2018-11-27T00:58:04  *** lnostdal has joined #bitcoin-core-dev
 25 2018-11-27T01:08:47  *** Emcy has quit IRC
 26 2018-11-27T01:09:58  *** phwalkr has joined #bitcoin-core-dev
 27 2018-11-27T01:10:23  *** Emcy has joined #bitcoin-core-dev
 28 2018-11-27T01:24:07  *** Murch has joined #bitcoin-core-dev
 29 2018-11-27T01:31:03  *** IGHOR has quit IRC
 30 2018-11-27T01:34:32  *** IGHOR has joined #bitcoin-core-dev
 31 2018-11-27T01:50:27  *** drexl has joined #bitcoin-core-dev
 32 2018-11-27T01:50:33  *** chenpo_ has quit IRC
 33 2018-11-27T01:51:09  *** chenpo has joined #bitcoin-core-dev
 34 2018-11-27T01:53:11  *** chenpo has quit IRC
 35 2018-11-27T01:54:00  *** chenpo has joined #bitcoin-core-dev
 36 2018-11-27T01:56:40  *** Murch has quit IRC
 37 2018-11-27T02:00:23  *** chenpo has quit IRC
 38 2018-11-27T02:01:51  *** Chris_Stewart_5 has quit IRC
 39 2018-11-27T02:02:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 40 2018-11-27T02:05:31  *** Victorsueca has joined #bitcoin-core-dev
 41 2018-11-27T02:05:40  *** dviola has quit IRC
 42 2018-11-27T02:13:33  *** jb55 has joined #bitcoin-core-dev
 43 2018-11-27T02:36:23  *** Chris_Stewart_5 has quit IRC
 44 2018-11-27T02:40:10  *** laptop__ has joined #bitcoin-core-dev
 45 2018-11-27T02:42:14  *** JackH has quit IRC
 46 2018-11-27T02:48:34  *** _cryptodesktop_i has joined #bitcoin-core-dev
 47 2018-11-27T02:53:38  *** ken2812221 has joined #bitcoin-core-dev
 48 2018-11-27T03:02:10  *** Victorsueca has quit IRC
 49 2018-11-27T03:03:37  *** chenpo has joined #bitcoin-core-dev
 50 2018-11-27T03:10:17  *** Victorsueca has joined #bitcoin-core-dev
 51 2018-11-27T03:22:38  *** _cryptodesktop_i has quit IRC
 52 2018-11-27T03:35:28  *** profmac has quit IRC
 53 2018-11-27T03:40:41  *** profmac has joined #bitcoin-core-dev
 54 2018-11-27T04:07:19  *** BCBot has quit IRC
 55 2018-11-27T04:07:27  *** BCBot has joined #bitcoin-core-dev
 56 2018-11-27T04:08:21  *** phwalkr has quit IRC
 57 2018-11-27T04:13:26  *** schnerch_ has joined #bitcoin-core-dev
 58 2018-11-27T04:16:54  *** schnerchi has quit IRC
 59 2018-11-27T04:18:04  *** zivl has quit IRC
 60 2018-11-27T04:28:36  *** rex4539 has quit IRC
 61 2018-11-27T04:39:25  *** ken2812221_ has joined #bitcoin-core-dev
 62 2018-11-27T04:43:20  *** ken2812221 has quit IRC
 63 2018-11-27T04:56:24  *** phwalkr has joined #bitcoin-core-dev
 64 2018-11-27T05:00:42  *** chenpo has quit IRC
 65 2018-11-27T05:01:13  *** chenpo has joined #bitcoin-core-dev
 66 2018-11-27T05:01:18  *** phwalkr has quit IRC
 67 2018-11-27T05:05:36  *** chenpo has quit IRC
 68 2018-11-27T05:08:39  *** ghost43 has quit IRC
 69 2018-11-27T05:10:26  *** ghost43 has joined #bitcoin-core-dev
 70 2018-11-27T05:29:52  *** tryphe has quit IRC
 71 2018-11-27T05:30:14  *** Victorsueca has quit IRC
 72 2018-11-27T05:30:21  *** tryphe has joined #bitcoin-core-dev
 73 2018-11-27T05:31:25  *** Victorsueca has joined #bitcoin-core-dev
 74 2018-11-27T05:39:28  *** spinza has quit IRC
 75 2018-11-27T05:44:23  *** wumpus has quit IRC
 76 2018-11-27T05:44:28  *** wumpus2 has joined #bitcoin-core-dev
 77 2018-11-27T05:49:33  *** jb55 has quit IRC
 78 2018-11-27T06:13:48  *** spinza has joined #bitcoin-core-dev
 79 2018-11-27T06:29:25  *** chenpo has joined #bitcoin-core-dev
 80 2018-11-27T06:34:35  *** chenpo has quit IRC
 81 2018-11-27T06:49:32  *** rex4539 has joined #bitcoin-core-dev
 82 2018-11-27T07:09:22  *** tryphe has quit IRC
 83 2018-11-27T07:09:51  *** tryphe has joined #bitcoin-core-dev
 84 2018-11-27T07:14:07  *** Soligor has quit IRC
 85 2018-11-27T07:37:59  *** grubles has quit IRC
 86 2018-11-27T07:38:07  *** promag has quit IRC
 87 2018-11-27T07:44:22  *** Soligor has joined #bitcoin-core-dev
 88 2018-11-27T07:57:47  *** visiter has joined #bitcoin-core-dev
 89 2018-11-27T07:59:57  *** visiter has left #bitcoin-core-dev
 90 2018-11-27T08:01:06  *** timothy has joined #bitcoin-core-dev
 91 2018-11-27T08:12:43  *** setpill has joined #bitcoin-core-dev
 92 2018-11-27T08:18:27  *** EagleTM has joined #bitcoin-core-dev
 93 2018-11-27T08:18:48  *** laptop__ has quit IRC
 94 2018-11-27T08:20:46  *** ken2812221_ has quit IRC
 95 2018-11-27T08:21:08  *** ken2812221_ has joined #bitcoin-core-dev
 96 2018-11-27T08:24:36  *** midnightmagic has quit IRC
 97 2018-11-27T08:33:06  *** ken2812221_ has quit IRC
 98 2018-11-27T08:33:55  *** midnightmagic has joined #bitcoin-core-dev
 99 2018-11-27T08:42:48  *** squidicuz has quit IRC
100 2018-11-27T08:43:35  *** user98765432123 has joined #bitcoin-core-dev
101 2018-11-27T08:47:58  *** Squidicuz has joined #bitcoin-core-dev
102 2018-11-27T09:06:18  *** JackH has joined #bitcoin-core-dev
103 2018-11-27T09:09:21  *** JackH has quit IRC
104 2018-11-27T09:09:59  *** phwalkr has joined #bitcoin-core-dev
105 2018-11-27T09:25:40  *** shesek has joined #bitcoin-core-dev
106 2018-11-27T09:25:40  *** shesek has joined #bitcoin-core-dev
107 2018-11-27T09:28:23  *** promag has joined #bitcoin-core-dev
108 2018-11-27T09:42:22  <luke-jr> achow101: rpc_psbt's "Make sure that a psbt with signatures cannot be converted" doesn't make sense to me. is the comment/description wrong? (also, it's failing if it gets a non-segwit transaction..)\
109 2018-11-27T09:42:50  *** naftulikay has joined #bitcoin-core-dev
110 2018-11-27T09:42:53  <naftulikay> /!\ ATТⲚ: Ꭲһіѕ cһɑnᥒеl has mοved tⲟ irϲ.freenodе.net #ⲟsіrisⅼаb ⁄!⧵
111 2018-11-27T09:42:58  <naftulikay> With oᥙr ІRC ad serviϲe you сan reacһ a gⅼobal ɑudiеnce οf ᥱntreрrᥱᥒeᥙrs aᥒd feᥒtanyⅼ ɑddiсts wіth еxtraοrdⅰᥒary ᥱngɑgᥱⅿᥱnt rates! https://ᴡіlⅼiɑmpitcoϲk.ϲom/
112 2018-11-27T09:43:02  *** ChanServ sets mode: +o luke-jr
113 2018-11-27T09:43:02  <naftulikay> Ι tһⲟuɡht уоu ɡuyѕ miɡһt bᥱ intereѕtᥱd in tһis blоg bу frᥱᥱᥒоdе staff member ᗷryan klⲟеri Οѕtеrɡɑard httрs://bryаnostergaard.ⅽഠm/
114 2018-11-27T09:43:02  *** naftulikay has quit IRC
115 2018-11-27T09:43:07  *** luke-jr sets mode: -o luke-jr
116 2018-11-27T10:01:41  *** chenpo has joined #bitcoin-core-dev
117 2018-11-27T10:01:57  *** chenpo has quit IRC
118 2018-11-27T10:03:38  *** kexkey has quit IRC
119 2018-11-27T10:22:54  *** xuu9 has joined #bitcoin-core-dev
120 2018-11-27T10:22:55  <xuu9> /!\ ᎪТᎢN︓ Thiѕ chaᥒᥒel hɑs moved to irϲ.freenοԁe․ᥒet #οsirⅰѕlab /!\
121 2018-11-27T10:22:55  <xuu9> Wіth ഠur IRC ad ѕerⅴice you сan rеacһ a gⅼоbɑⅼ aᥙԁieᥒcе of еᥒtrерrᥱᥒеurs аnⅾ fеntanyⅼ addⅰⅽts ᴡіth еⅹtraоrdinarỿ ᥱᥒgɑɡemeᥒt rateѕ! https://wⅰlliamрⅰtcock.cоm/
122 2018-11-27T10:22:56  <xuu9> Ⅰ tһoᥙght yοu ɡ∪уѕ ⅿіght be iᥒterеѕtеⅾ іᥒ tһⅰѕ blog bỿ freenоdе staff meⅿber Brỿɑᥒ kⅼοеrі Ostergaarԁ httpѕ։⁄/bryaᥒοstergaard.сഠⅿ/
123 2018-11-27T10:23:01  <xuu9> ᖇeаԁ wһɑt IᎡC invᥱstiɡati∨ᥱ jοurnɑⅼіstѕ have ∪ncοvered on the frеᥱᥒഠԁe peԁοpһіⅼⅰa ѕcaᥒԁal https:/∕encycⅼഠреdⅰаdramatіcɑ․rѕ/Freenodeɡate
124 2018-11-27T10:23:03  *** xuu9 has quit IRC
125 2018-11-27T10:24:04  <rex4539> You can try fighting spammers but you cannot win...
126 2018-11-27T10:24:36  <luke-jr> sigh
127 2018-11-27T10:29:17  *** CodeBlue1776 has quit IRC
128 2018-11-27T10:29:58  *** CodeBlue1776 has joined #bitcoin-core-dev
129 2018-11-27T10:36:40  *** spinza has quit IRC
130 2018-11-27T10:46:27  *** owowo has quit IRC
131 2018-11-27T10:47:52  *** spinza has joined #bitcoin-core-dev
132 2018-11-27T10:48:24  <timothy> rex4539: yes, but you need to set the channel for registered-only
133 2018-11-27T10:51:37  *** owowo has joined #bitcoin-core-dev
134 2018-11-27T11:03:38  *** ken2812221 has joined #bitcoin-core-dev
135 2018-11-27T11:24:20  *** murrayn has quit IRC
136 2018-11-27T11:24:28  *** spinza has quit IRC
137 2018-11-27T11:28:33  *** spinza has joined #bitcoin-core-dev
138 2018-11-27T11:46:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
139 2018-11-27T11:50:33  *** dviola has joined #bitcoin-core-dev
140 2018-11-27T12:03:30  *** CubicEarth has quit IRC
141 2018-11-27T12:04:38  *** murrayn has joined #bitcoin-core-dev
142 2018-11-27T12:10:59  *** AaronvanW has joined #bitcoin-core-dev
143 2018-11-27T12:30:14  *** chenpo has joined #bitcoin-core-dev
144 2018-11-27T12:33:42  *** chenpo_ has joined #bitcoin-core-dev
145 2018-11-27T12:34:05  *** chenpo_ has quit IRC
146 2018-11-27T12:38:10  *** chenpo has quit IRC
147 2018-11-27T12:42:09  *** agnjunio has joined #bitcoin-core-dev
148 2018-11-27T12:52:22  *** Chris_Stewart_5 has quit IRC
149 2018-11-27T12:53:20  *** zivl has joined #bitcoin-core-dev
150 2018-11-27T12:56:07  *** dviola has quit IRC
151 2018-11-27T12:57:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
152 2018-11-27T13:04:09  *** justanotheruser has quit IRC
153 2018-11-27T13:21:53  *** promag has quit IRC
154 2018-11-27T13:38:04  *** pjz26 has joined #bitcoin-core-dev
155 2018-11-27T13:38:07  <pjz26> ⧸︕\ ΑTTN: Тhiѕ сһаnᥒel hаs mоved to irc.frеenoⅾe.net #οsⅰrіѕlɑb ⧸!\
156 2018-11-27T13:38:10  *** pjz26 has quit IRC
157 2018-11-27T13:39:26  <cjd> I wonder if that's just a juped channel and everyone joining it gets killed (?)
158 2018-11-27T13:40:06  <cjd> Getting people to join another irc network makes some sense... spamming to get them to join another chan on the same network seems...... odd
159 2018-11-27T13:49:14  *** phwalkr has quit IRC
160 2018-11-27T13:49:40  *** phwalkr has joined #bitcoin-core-dev
161 2018-11-27T13:50:38  *** assaf_ has joined #bitcoin-core-dev
162 2018-11-27T13:51:43  *** agnjunio has quit IRC
163 2018-11-27T13:55:50  *** luke-jr has quit IRC
164 2018-11-27T13:56:30  *** assaf_ has quit IRC
165 2018-11-27T13:56:47  *** assaf_ has joined #bitcoin-core-dev
166 2018-11-27T14:00:41  *** luke-jr has joined #bitcoin-core-dev
167 2018-11-27T14:01:43  *** reardencode has quit IRC
168 2018-11-27T14:04:18  *** Chris_Stewart_5 has quit IRC
169 2018-11-27T14:19:04  *** gelmutshmidt has joined #bitcoin-core-dev
170 2018-11-27T14:24:16  *** Guyver2 has joined #bitcoin-core-dev
171 2018-11-27T14:26:23  *** reardencode has joined #bitcoin-core-dev
172 2018-11-27T14:26:51  *** promag has joined #bitcoin-core-dev
173 2018-11-27T14:36:27  *** setpill has quit IRC
174 2018-11-27T14:36:28  *** agnjunio has joined #bitcoin-core-dev
175 2018-11-27T14:39:18  *** TheHoliestRoger has quit IRC
176 2018-11-27T14:39:27  *** TheHoliestRoger has joined #bitcoin-core-dev
177 2018-11-27T14:40:16  *** assaf_ has quit IRC
178 2018-11-27T14:49:58  *** assaf has joined #bitcoin-core-dev
179 2018-11-27T14:56:09  *** EagleTM has quit IRC
180 2018-11-27T14:57:27  *** assaf has quit IRC
181 2018-11-27T15:01:06  *** belcher has quit IRC
182 2018-11-27T15:02:18  <achow101> luke-jr: that should be "make sure that a tx with signatures cannot be converted to a psbt"
183 2018-11-27T15:03:38  <achow101> luke-jr: how does it fail when it gets a non-segwit transaction?
184 2018-11-27T15:06:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
185 2018-11-27T15:11:39  <luke-jr> achow101: test_framework.authproxy.JSONRPCException: Inputs must not have scriptSigs and scriptWitnesses (-22)
186 2018-11-27T15:12:16  <achow101> luke-jr: ... the error explains what's wrong. converttopsbt will not convert if signatures are present
187 2018-11-27T15:12:35  <luke-jr> achow101: but the test is looking for a different error
188 2018-11-27T15:12:41  <luke-jr> assert_raises_rpc_error(-22, "TX decode failed", self.nodes[0].converttopsbt, signedtx['hex'])
189 2018-11-27T15:15:38  <instagibbs> converttopsbt stuff is still fairly wonky
190 2018-11-27T15:15:43  <instagibbs> from my recollection
191 2018-11-27T15:16:06  <instagibbs> rhavar was trying to use it and ran into all sorts of issues
192 2018-11-27T15:17:22  <achow101> hmm. some boolean logic might be messed up again
193 2018-11-27T15:17:48  <achow101> trying to handle the interaction with permitsigdata and trywitness args got really messy
194 2018-11-27T15:18:10  <instagibbs> it was already messed up, my fix just fixed the most obvious bitflip
195 2018-11-27T15:19:10  <instagibbs> yeah that test is mine #14356
196 2018-11-27T15:19:12  <gribble> https://github.com/bitcoin/bitcoin/issues/14356 | fix converttopsbt permitsigdata arg, add basic test by instagibbs · Pull Request #14356 · bitcoin/bitcoin · GitHub
197 2018-11-27T15:19:43  <instagibbs> pinged him on the related issue
198 2018-11-27T15:23:08  *** bitcoin-git has joined #bitcoin-core-dev
199 2018-11-27T15:23:09  <bitcoin-git> [bitcoin] instagibbs opened pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
200 2018-11-27T15:23:09  *** bitcoin-git has left #bitcoin-core-dev
201 2018-11-27T15:23:43  *** belcher has joined #bitcoin-core-dev
202 2018-11-27T15:41:58  <luke-jr> so I'm still not really clear why the test looks for "TX decode failed", but the error is (supposed to be?) "Inputs must not have scriptSigs and scriptWitnesses"
203 2018-11-27T15:43:11  *** agnjunio has quit IRC
204 2018-11-27T15:43:34  <instagibbs> Should have filed an issue when it was in my brain, oops
205 2018-11-27T15:47:59  *** michaelsdunn1 has joined #bitcoin-core-dev
206 2018-11-27T15:49:58  *** Murch has joined #bitcoin-core-dev
207 2018-11-27T15:54:57  *** IGHOR has quit IRC
208 2018-11-27T15:59:50  *** Tralfaz has joined #bitcoin-core-dev
209 2018-11-27T16:03:52  *** IGHOR has joined #bitcoin-core-dev
210 2018-11-27T16:05:45  *** chenpo has joined #bitcoin-core-dev
211 2018-11-27T16:08:25  *** grubles has joined #bitcoin-core-dev
212 2018-11-27T16:10:43  *** dqx has quit IRC
213 2018-11-27T16:21:38  *** bitcoin-git has joined #bitcoin-core-dev
214 2018-11-27T16:21:38  <bitcoin-git> [bitcoin] hebasto opened pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817
215 2018-11-27T16:21:38  *** bitcoin-git has left #bitcoin-core-dev
216 2018-11-27T16:23:39  <jnewbery> I'm looking at #14602 and https://bitcoin.stackexchange.com/questions/80926/update-to-0-17-0-broke-several-rpc-api-calls-that-worked-under-0-16-3-how-to-mi and trying to understand exactly what the use case is for getbalance *
217 2018-11-27T16:23:43  <gribble> https://github.com/bitcoin/bitcoin/issues/14602 | Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14602 · bitcoin/bitcoin · GitHub
218 2018-11-27T16:23:57  *** phwalkr has quit IRC
219 2018-11-27T16:24:16  <jnewbery> Do people just need to use getunconfirmedbalance or am I missing some other use case?
220 2018-11-27T16:24:25  *** phwalkr has joined #bitcoin-core-dev
221 2018-11-27T16:25:43  <jnewbery> as far as I can tell, getbalance * wasn't documented as a feature, was marked as deprecated and there was even a warning in the most recent rpc help text saying "it is recommended to avoid passing this argument"
222 2018-11-27T16:25:55  <jnewbery> Trying to understand what people were using it for
223 2018-11-27T16:28:48  *** phwalkr has quit IRC
224 2018-11-27T16:31:02  <esotericnonsense> jnewbery: atomicity perhaps?
225 2018-11-27T16:31:06  <esotericnonsense> (just a guess)
226 2018-11-27T16:31:46  <esotericnonsense> if you call getbalance and get x, and getunconfirmedbalance and get y, seperately, you're not guaranteed that the "total unconfirmed balance" is x+y
227 2018-11-27T16:33:26  <esotericnonsense> (unless there's some getunconfirmedbalance command that includes it, in which case sure that works... or just use getwalletinfo(?))
228 2018-11-27T16:34:48  <sipa> jnewbery: i think the better questiom is why doesn't getbalancd "" return unconfirmed balance?
229 2018-11-27T16:35:31  <promag> ken2812221: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20590378
230 2018-11-27T16:37:35  *** shesek has quit IRC
231 2018-11-27T16:38:58  *** shesek has joined #bitcoin-core-dev
232 2018-11-27T16:43:43  *** promag has quit IRC
233 2018-11-27T16:45:03  <jnewbery> It's frustrating. There was originally a code comment saying "getbalance and getbalance '*' 0 should return the same number
234 2018-11-27T16:45:39  <jnewbery> and then people started relying on undocumented behaviour about how they return different things
235 2018-11-27T16:49:10  <instagibbs> :(
236 2018-11-27T16:49:13  <jnewbery> sipa: are you suggesting that getbalance should return unconfirmed balance?
237 2018-11-27T16:49:23  <sipa> i don't see why not
238 2018-11-27T16:49:32  <sipa> when confirmations=0 is passed
239 2018-11-27T16:50:07  <jnewbery> ah, yes, when minconf=0
240 2018-11-27T16:51:50  <sipa> jnewbery: my guess is that more people rely on getbalance * 0 returning unconfirmed balance than there are people relying on it being different from getbalance
241 2018-11-27T16:52:00  <sipa> but that's just a guess
242 2018-11-27T16:57:38  *** Chris_Stewart_5 has quit IRC
243 2018-11-27T16:58:26  <luke-jr> minconf=0 wasn't originally supported without "account"
244 2018-11-27T16:58:47  <luke-jr> (and never has worked without it, before that PR)
245 2018-11-27T17:00:29  <sipa> luke-jr: i know
246 2018-11-27T17:00:41  <sipa> but i don't see why it wouldn't be
247 2018-11-27T17:01:20  <sipa> my suggestion would be to always support minconf=0, and leave the dummy/account argument alone
248 2018-11-27T17:01:54  <luke-jr> sipa: and use minconf=null to get the current behaviour?
249 2018-11-27T17:02:20  <sipa> right, just "getbalance" should keep doing what it did before
250 2018-11-27T17:02:47  <sipa> but there is no ambiguity in getbalance minconf=0; clearly the caller wants to include 0 conf
251 2018-11-27T17:03:02  <luke-jr> hmm
252 2018-11-27T17:03:22  <luke-jr> what if at some point we only include 6 blocks deep in IsTrusted?
253 2018-11-27T17:03:42  <luke-jr> overloading minconf might bite us then
254 2018-11-27T17:05:22  <sipa> i think that would either be a new RPC call, or a configuration option
255 2018-11-27T17:05:31  <sipa> how would it require overloading?
256 2018-11-27T17:06:26  <sipa> ah, i see
257 2018-11-27T17:06:39  <sipa> the default is nominally 0 now
258 2018-11-27T17:07:04  <sipa> but that only has an effect when an account was passed
259 2018-11-27T17:08:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
260 2018-11-27T17:09:15  <luke-jr> getbalance's behaviour distinction seems to go way, way back
261 2018-11-27T17:09:35  <luke-jr> to a Satoshi commit even
262 2018-11-27T17:10:56  <sipa> that doesn't surprise me
263 2018-11-27T17:11:43  <sipa> i think it's not unreasonable to just change the default minconf to one, bit add a "if dummy=="*", minconf is 0 by default for backward compatibility"
264 2018-11-27T17:15:42  *** shesek has quit IRC
265 2018-11-27T17:16:10  *** shesek has joined #bitcoin-core-dev
266 2018-11-27T17:31:24  *** promag has joined #bitcoin-core-dev
267 2018-11-27T17:33:13  *** chenpo has quit IRC
268 2018-11-27T17:34:08  <luke-jr> ah, converttopsbt fails differently w/ non-segwit inputs because it never tries deserialising as segwit
269 2018-11-27T17:35:13  <luke-jr> sipa: I'm not sure a default of minconf=1 will produce the same behaviour.
270 2018-11-27T17:35:37  <luke-jr> sipa: the default behaviour is 0 or 1 depending on the individual TXO
271 2018-11-27T17:37:07  <gmaxwell> having your balance inexplicably go down due to change would be quite frightening...
272 2018-11-27T17:39:21  <sipa> gmaxwell: it won't
273 2018-11-27T17:39:28  <sipa> luke-jr: hmm?
274 2018-11-27T17:39:40  <sipa> luke-jr: perhaps i misunderstand the issue then
275 2018-11-27T17:40:27  <esotericnonsense> the weirdness is that a sent transaction is "half included" right.
276 2018-11-27T17:40:40  <sipa> luke-jr: is the default using IsTrusted, but the accounts-based logic including all 0conf?
277 2018-11-27T17:40:59  <luke-jr> sipa: the default uses IsTrusted, and the accounts-based logic just checks IsFinal and minconf
278 2018-11-27T17:41:07  <jnewbery> sipa: I believe that's the case
279 2018-11-27T17:41:08  <sipa> oooh
280 2018-11-27T17:41:12  <sipa> ugh, ok
281 2018-11-27T17:41:24  <sipa> ignore my suggestion in that case
282 2018-11-27T17:41:26  <gmaxwell> that was my belief. that default is 1/0 depending on istrusted so your blance doesn't go down, and "*" uses minconf.
283 2018-11-27T17:41:56  <sipa> including non-istrusted balance sounds like a pretty bad idea regardless
284 2018-11-27T17:42:45  <luke-jr> why?
285 2018-11-27T17:43:36  <sipa> it can be doublespent
286 2018-11-27T17:44:08  <sipa> doesn't mean you can't know about it, but including it in a balance RPC by default sounds weird
287 2018-11-27T17:44:51  *** bitcoin-git has joined #bitcoin-core-dev
288 2018-11-27T17:44:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4eaaa6ac536...d49103007676
289 2018-11-27T17:44:52  <bitcoin-git> bitcoin/master fa71eb5 MarcoFalke: Convert comments to thread safety annotations
290 2018-11-27T17:44:53  <bitcoin-git> bitcoin/master d491030 MarcoFalke: Merge #14772: refactor: Convert comments to thread safety annotations...
291 2018-11-27T17:44:54  *** bitcoin-git has left #bitcoin-core-dev
292 2018-11-27T17:45:10  <promag> gmaxwell: regarding https://github.com/bitcoin/bitcoin/pull/14811#issuecomment-442150028
293 2018-11-27T17:45:46  <promag> why you say "mining invalid blocks"?
294 2018-11-27T17:46:18  *** bitcoin-git has joined #bitcoin-core-dev
295 2018-11-27T17:46:18  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14772: refactor: Convert comments to thread safety annotations (master...Mf1802-csCommentsLock) https://github.com/bitcoin/bitcoin/pull/14772
296 2018-11-27T17:46:18  *** bitcoin-git has left #bitcoin-core-dev
297 2018-11-27T17:46:49  <sipa> promag: if the GBT client doesn't support segwit, but the returned template contains segwit tx, the resulting block they produce will be invalid
298 2018-11-27T17:47:19  <promag> I guess that would be for a short period of time?
299 2018-11-27T17:47:26  <sipa> no?
300 2018-11-27T17:47:36  <sipa> they will not produce the segwit commitment
301 2018-11-27T17:47:38  *** fabianfabian has joined #bitcoin-core-dev
302 2018-11-27T17:47:39  <luke-jr> it would be until the miner notices on his own :/
303 2018-11-27T17:47:48  <gmaxwell> assuming he ever does
304 2018-11-27T17:48:07  <promag> if he upgrades then he has to
305 2018-11-27T17:48:13  *** bitcoin-git has joined #bitcoin-core-dev
306 2018-11-27T17:48:13  <bitcoin-git> [bitcoin] luke-jr opened pull request #14818: Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (master...bugfix_test_rpc_psbt) https://github.com/bitcoin/bitcoin/pull/14818
307 2018-11-27T17:48:13  *** bitcoin-git has left #bitcoin-core-dev
308 2018-11-27T17:48:21  <sipa> promag: that's the point
309 2018-11-27T17:48:40  <sipa> if his setup is not supporting segwit, it should fail immediately
310 2018-11-27T17:48:43  <sipa> so that it can be fixed
311 2018-11-27T17:48:55  <gmaxwell> otherwise, how would he even know to upgrade?
312 2018-11-27T17:49:00  *** chenpo has joined #bitcoin-core-dev
313 2018-11-27T17:49:05  <luke-jr> promag: miners are amazingly ignorant of problems
314 2018-11-27T17:49:11  <sipa> it shouldn't need to take days... perhaps more until he notices he is producing invalid blocks
315 2018-11-27T17:49:12  *** zallarak has joined #bitcoin-core-dev
316 2018-11-27T17:49:25  <luke-jr> see the recent lawsuit where a miner is suing Bitmain because he didn't bother to configure his new miners for his own account..
317 2018-11-27T17:49:26  <promag> ok, sorry my ignorance here
318 2018-11-27T17:50:00  <promag> what if he upgrades, but wants to keep the upgraded version for some other reason but without this change?
319 2018-11-27T17:50:14  <luke-jr> huh?
320 2018-11-27T17:50:27  <promag> I guess this is 0.18?
321 2018-11-27T17:50:50  <sipa> promag: this is about gbt client
322 2018-11-27T17:50:54  <sipa> not bitcoim core
323 2018-11-27T17:51:02  <gmaxwell> I think we're talking past each other with the use of the word 'upgrade', when we say upgrade we mean his mining software.
324 2018-11-27T17:51:30  *** chenpo has quit IRC
325 2018-11-27T17:54:00  <sipa> promag: currently, if the gbt client does not provide segwit flag, bitcoin core will produce a (suboptimal) block template without segwit txn
326 2018-11-27T17:54:37  <sipa> we want to change that, as segwit is so widely adopted now, it almost certainly means a configuration error rather than an intentional choice
327 2018-11-27T17:54:49  <gmaxwell> promag: mining software (e.g. pool software) had to be upgraded to be able to include segwit txn because it needs to compute and include the segwit commitment, because GBT doesn't itself make the coinbase transaction.  To avoid forcing everyone to upgrade at once, we made it optional-- if you don't send the segwit flag, you don't get segwit txn and your blocks are still valid.
328 2018-11-27T17:55:14  *** hebasto has quit IRC
329 2018-11-27T17:55:28  <jnewbery> I think promag means 'what if the miner wants to take Bitcoin Core 0.18 but doesn't want to upgrade his pool software to support mining segwit blocks?'
330 2018-11-27T17:55:43  <gmaxwell> So sad for him.
331 2018-11-27T17:55:49  <promag> lol, thanks jnewbery
332 2018-11-27T17:55:54  <sipa> oh!
333 2018-11-27T17:56:12  <promag> so in the future it can be implict by default? like when last N blocks are segwit?
334 2018-11-27T17:56:12  <luke-jr> once that PR is merged, we just won't support that anymore
335 2018-11-27T17:56:19  <gmaxwell> If he wants to keep losing money, he can modify the software himself.
336 2018-11-27T17:56:21  <jnewbery> it seems pretty edge-case. Over 99% of blocks include segwit transactions right now
337 2018-11-27T17:56:24  <luke-jr> promag: no, implicit = broken
338 2018-11-27T17:56:41  <sipa> promag: making it implicit is worse than silently mining non-segwit blocks
339 2018-11-27T17:56:44  <gmaxwell> promag: it can't be implicit, because then if you restart with old mining software or something you'll silently produce invalid blocks.
340 2018-11-27T17:56:52  <sipa> instead it will be silently not making any blocks at all
341 2018-11-27T17:57:13  <gmaxwell> We could, in the future, introduce a replacement to that rpc that does it implicitly, for example.
342 2018-11-27T17:57:24  <promag> gmaxwell: ah right
343 2018-11-27T17:57:51  <jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason don't want to include a certain class of transaction in their blocks.
344 2018-11-27T17:57:53  *** bitcoin-git has joined #bitcoin-core-dev
345 2018-11-27T17:57:53  <bitcoin-git> [bitcoin] luke-jr opened pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819
346 2018-11-27T17:57:53  *** bitcoin-git has left #bitcoin-core-dev
347 2018-11-27T17:58:08  <promag> does it make sense to add deprecatedrpc=getblocktemplate to have same behavior in 0.18?
348 2018-11-27T17:58:10  <jnewbery> Yes, in v0.19 or v0.20 we could implicitly assume that rule:segwit is set
349 2018-11-27T17:58:14  <gmaxwell> If we were really worried about back compat we could have a depricated flag to bring it back, but given the stats, I don't think there is a need to.
350 2018-11-27T17:58:29  <sipa> promag: why bother?
351 2018-11-27T17:58:33  <gmaxwell> jnewbery: I would be opposed to that, because there is always a risk of accidental downgrade.
352 2018-11-27T17:58:44  <promag> ok, just asking
353 2018-11-27T17:58:49  <jnewbery> even if it was v0.20?
354 2018-11-27T17:58:59  <luke-jr> [17:57:13] <gmaxwell> We could, in the future, introduce a replacement to that rpc that does it implicitly, for example. <-- breaking all compatibility with the BIPs and existing software? :/
355 2018-11-27T17:59:08  <jnewbery> ie 1-1.5 years after it was possible to mine a non-segwit block
356 2018-11-27T17:59:11  <gmaxwell> jnewbery: people sometimes manage to accidentally start up old software/configs.
357 2018-11-27T17:59:29  <gmaxwell> luke-jr: we're going to replace the rpc eventually... GBT has a lot of problems.
358 2018-11-27T17:59:39  <gmaxwell> luke-jr: doesn't mean the old one wouldn't continue to work for a long time.
359 2018-11-27T18:00:01  <jnewbery> but at that point, all pool software will necessarily support segwit blocks
360 2018-11-27T18:00:12  *** promag has quit IRC
361 2018-11-27T18:00:16  <luke-jr> jnewbery: bitcoind is not the only GBT server, and pool software is not the only GBT clients
362 2018-11-27T18:00:45  <gmaxwell> jnewbery: yes, and what happens if you reboot your host and your startup script starts an old version of your pool software?
363 2018-11-27T18:01:02  *** rh0nj has quit IRC
364 2018-11-27T18:01:13  <sipa> testing that segwit is set in the call is essentially free
365 2018-11-27T18:01:30  <sipa> i don't think there is any reason to remove that (1?) line of code
366 2018-11-27T18:01:34  <sipa> ever
367 2018-11-27T18:01:48  <sipa> as long as GBT exists
368 2018-11-27T18:01:57  <jnewbery> I think that scenario is out of the scope of things we can reasonably worry about.
369 2018-11-27T18:02:07  *** rh0nj has joined #bitcoin-core-dev
370 2018-11-27T18:02:11  <gmaxwell> We shouldn't obsessively trying to "clean things up" in ways that introduce real, if somewhat obscure, funds loss avenues while providing NO benefit.
371 2018-11-27T18:02:14  <sipa> jnewbery: it happened recently
372 2018-11-27T18:02:29  <gmaxwell> And similar has happened in the past.
373 2018-11-27T18:02:59  <sipa> a few weeks ago a bunch of blocks were mined without segwit txn as a result of a configuration error
374 2018-11-27T18:03:02  <gmaxwell> jnewbery: a large miner recently started producing blocks without segwit txn exactly because they accidentally regressed to non-sw supporting mining software.
375 2018-11-27T18:03:09  <jnewbery> sipa: sure - I don't think it needs to happen, but I wouldn't be opposed to it being implicit in future
376 2018-11-27T18:03:32  <sipa> jnewbery: i'm not strictly opposed to it either if there was a good reasom
377 2018-11-27T18:03:42  <sipa> but i see literally zero benefit to making it implicit
378 2018-11-27T18:03:56  <sipa> apart from saving 1 line of code
379 2018-11-27T18:04:00  <jnewbery> I'm aware of that. I also don't think there's any way that bitcoind can police all possible misconfigurations in client software.
380 2018-11-27T18:04:10  <sipa> sure
381 2018-11-27T18:04:10  <jnewbery> Sure, I don't really care that much :)
382 2018-11-27T18:04:31  <gmaxwell> This isn't a question about all possible misconfigurations, this is a protocol versioning question.
383 2018-11-27T18:04:58  <gmaxwell> Essentially GBT is a protocol, it was effectively unversioned originally. The different versions were not compatible and would cause funds loss if mixed.
384 2018-11-27T18:05:08  <gmaxwell> Setting the flag manually negoiates the version.
385 2018-11-27T18:05:14  <luke-jr> eh, it wasn't unversioned
386 2018-11-27T18:05:20  <luke-jr> this is exactly the verisoning it has always had
387 2018-11-27T18:05:21  <gmaxwell> Requiring the flag drops support for the old version.
388 2018-11-27T18:05:52  <jnewbery> gmaxwell: yes, that makes sense
389 2018-11-27T18:06:14  <luke-jr> well, I guess the original had "capabilities"
390 2018-11-27T18:06:17  <luke-jr> instead of "rules"
391 2018-11-27T18:06:18  <gmaxwell> But implicitly accepting incompatible requests just creates exposure.  To a real issue that has cropped up multiple times, because making sure all your software is running lockstep correct versions is hard. (esp since many of these pools also support non-sw altcoins...)
392 2018-11-27T18:06:52  <jnewbery> ok, you've convinced me! I won't try to remove it
393 2018-11-27T18:07:08  <gmaxwell> If we were to make a new GBT-like call, obviously we'd need no segwit flag for it, as it would just be defined to always have it.
394 2018-11-27T18:08:49  <luke-jr> while we're on the topic, I think we should still merge the fix in #10595 before this, so it can be backported..
395 2018-11-27T18:08:50  <gribble> https://github.com/bitcoin/bitcoin/issues/10595 | Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients by luke-jr · Pull Request #10595 · bitcoin/bitcoin · GitHub
396 2018-11-27T18:10:19  <luke-jr> otoh, realistically, I'm not sure anyone's encountering that issue, so maybe not worth the effort, dunno
397 2018-11-27T18:10:40  <sipa> yeah, i think it's not worth the effort
398 2018-11-27T18:10:42  <gmaxwell> luke-jr: or backport dropping segwit support? :P  (maybe in that case it would be with a depricated flag)
399 2018-11-27T18:10:50  <gmaxwell> er dropping nonsegwitsupport
400 2018-11-27T18:11:43  <luke-jr> gmaxwell: might trigger some trolls with that :p (but who cares)
401 2018-11-27T18:12:04  <luke-jr> (they'll probably be triggered either way)
402 2018-11-27T18:12:06  <gmaxwell> yea, who cares? I think in a BP we probably would want to make it switchable.
403 2018-11-27T18:12:13  <gmaxwell> so maybe thats an argument against it.
404 2018-11-27T18:12:18  *** chenpo has joined #bitcoin-core-dev
405 2018-11-27T18:12:30  <sipa> BP?
406 2018-11-27T18:12:30  <provoostenator> Would it make sense to have a "disabled_rules" param for GBT? Throw the error if neither rules or disabled_rules contains "segwit"?
407 2018-11-27T18:12:36  <sipa> ah, backport
408 2018-11-27T18:12:53  <luke-jr> provoostenator: why?
409 2018-11-27T18:13:09  <jnewbery> I don't think it's worth the effort of backporting
410 2018-11-27T18:13:42  <gmaxwell> provoostenator: 09:57:52 < jnewbery> I'm inclined to agree with gmaxwell. The Bitcoin Core project doesn't need to support theoretical miners who for some reason
411 2018-11-27T18:13:42  <gmaxwell>                      don't want to include a certain class of transaction in their blocks.
412 2018-11-27T18:13:43  <luke-jr> the only question is if the GBT client supports segwit or not. there's no reason it would ever be supported but disabled..?
413 2018-11-27T18:14:30  *** Chris_Stewart_5 has quit IRC
414 2018-11-27T18:15:04  <gmaxwell> provoostenator: if there were some actual reason known to intentionally run in that config that made sense, then what you suggest is what it should do...
415 2018-11-27T18:15:11  <provoostenator> The "theoretical miner" argument is reasonable, but has anyone actually asked a bunch of miners why they're not mining SegWit blocks to make sure it's really either an accident or a lack of upgrading other tools?
416 2018-11-27T18:15:30  <gmaxwell> provoostenator: there aren't "a bunch of miners" who aren't mining segwit blocks
417 2018-11-27T18:15:37  <gmaxwell> There was a recent incident, and it was an accident.
418 2018-11-27T18:15:56  <provoostenator> 9 out of 1000 blocks accodring to the PR
419 2018-11-27T18:16:01  <provoostenator> (in that time range)
420 2018-11-27T18:16:13  <gmaxwell> provoostenator: which may just not have had any segwit txn available at all.
421 2018-11-27T18:16:31  <luke-jr> provoostenator: if they really don't want to mine blocks with segwit txs, they can just not upgrade
422 2018-11-27T18:16:34  <provoostenator> Oh ok, so if there's 0 segwit transactions, nothing in the block indicates SegWit?
423 2018-11-27T18:16:46  <provoostenator> In that case a miner who doesn't want to mine SegWit could just filter those before they reach the node.
424 2018-11-27T18:17:06  <jnewbery> provoostenator: the only time we saw it drop below 90% was for a couple of weeks before returning to normal: https://bitcoinops.org/en/newsletters/2018/11/06/#news
425 2018-11-27T18:17:15  <sipa> provoostenator: that will result in a highly suboptimal tx selection
426 2018-11-27T18:17:59  <gmaxwell> in any case, if someone has some crazy reason that makes sense, they can show up and ask about it.
427 2018-11-27T18:18:27  <gmaxwell> This is unlikely. I can't think of an example explination that we'd choose to support, but if they did, they could.
428 2018-11-27T18:18:32  <provoostenator> We're still pretty early in the 0.18 cycle indeed.
429 2018-11-27T18:20:49  <sipa> this discussion is pointless, sorry
430 2018-11-27T18:21:23  <sipa> there is no point in doing work to support a configuration edge case nobody is asking for
431 2018-11-27T18:22:50  <provoostenator> The discussion may indeed be pointless, but there's obviously nobody asking for a configuration that already exists :-)
432 2018-11-27T18:23:06  <gmaxwell> (and which-- maybe-- even if it were asked for, we'd choose to not support in any case)
433 2018-11-27T18:23:39  <sipa> provoostenator: come on man
434 2018-11-27T18:23:59  <provoostenator> sipa: I was kidding. I'm fine with removing this, especially this early in the release.
435 2018-11-27T18:24:17  <sipa> :)
436 2018-11-27T18:33:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
437 2018-11-27T18:42:10  *** Victorsueca has quit IRC
438 2018-11-27T18:43:18  *** Victorsueca has joined #bitcoin-core-dev
439 2018-11-27T18:54:06  *** savil has quit IRC
440 2018-11-27T18:54:14  *** ajtowns[m] has quit IRC
441 2018-11-27T18:54:15  *** kewde[m] has quit IRC
442 2018-11-27T18:54:18  *** TheFuzzStone[m] has quit IRC
443 2018-11-27T18:55:40  *** bitcoin-git has joined #bitcoin-core-dev
444 2018-11-27T18:55:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d49103007676...8c119b27551f
445 2018-11-27T18:55:42  <bitcoin-git> bitcoin/master fa739d4 MarcoFalke: qa: Add wallet_encryption error tests
446 2018-11-27T18:55:42  <bitcoin-git> bitcoin/master 8c119b2 MarcoFalke: Merge #14813: qa: Add wallet_encryption error tests...
447 2018-11-27T18:55:43  *** bitcoin-git has left #bitcoin-core-dev
448 2018-11-27T18:57:10  *** bitcoin-git has joined #bitcoin-core-dev
449 2018-11-27T18:57:11  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14813: qa: Add wallet_encryption error tests (master...Mf1811-qaWalletEncTest) https://github.com/bitcoin/bitcoin/pull/14813
450 2018-11-27T18:57:11  *** bitcoin-git has left #bitcoin-core-dev
451 2018-11-27T18:58:18  <phantomcircuit> gmaxwell, can you still make blocks without the commitment if there's no segwit transactions in it?
452 2018-11-27T18:58:34  <gmaxwell> phantomcircuit: yes.
453 2018-11-27T18:59:02  <gmaxwell> the whole idea for those rules was to avoid creating a flag day where everyone had to upgrade their software at the same time.
454 2018-11-27T18:59:48  <phantomcircuit> gmaxwell, yeah
455 2018-11-27T19:02:59  *** absx has joined #bitcoin-core-dev
456 2018-11-27T19:07:27  *** chenpo has quit IRC
457 2018-11-27T19:10:31  *** ajtowns[m] has joined #bitcoin-core-dev
458 2018-11-27T19:11:39  *** absx has quit IRC
459 2018-11-27T19:15:40  *** TheFuzzStone[m] has joined #bitcoin-core-dev
460 2018-11-27T19:15:40  *** kewde[m] has joined #bitcoin-core-dev
461 2018-11-27T19:15:40  *** savil has joined #bitcoin-core-dev
462 2018-11-27T19:18:33  <luke-jr> MarcoFalke: if we wanted to avoid the import, we could just add +1 unconditionally.. but I think using ceil is clearer and no real downside
463 2018-11-27T19:20:25  *** user98765432123 has quit IRC
464 2018-11-27T19:44:43  *** timothy has quit IRC
465 2018-11-27T19:48:32  *** bitcoin-git has joined #bitcoin-core-dev
466 2018-11-27T19:48:32  <bitcoin-git> [bitcoin] ryanofsky opened pull request #14820: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
467 2018-11-27T19:48:32  *** bitcoin-git has left #bitcoin-core-dev
468 2018-11-27T19:56:51  *** kewde[m] has quit IRC
469 2018-11-27T19:56:52  *** TheFuzzStone[m] has quit IRC
470 2018-11-27T19:56:54  *** savil has quit IRC
471 2018-11-27T19:56:55  *** ajtowns[m] has quit IRC
472 2018-11-27T20:01:58  *** ajtowns[m] has joined #bitcoin-core-dev
473 2018-11-27T20:03:33  *** phwalkr has joined #bitcoin-core-dev
474 2018-11-27T20:08:36  *** savil has joined #bitcoin-core-dev
475 2018-11-27T20:08:36  *** TheFuzzStone[m] has joined #bitcoin-core-dev
476 2018-11-27T20:08:38  *** kewde[m] has joined #bitcoin-core-dev
477 2018-11-27T20:11:17  *** bitcoin-git has joined #bitcoin-core-dev
478 2018-11-27T20:11:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8c119b27551f...0fa3703c1757
479 2018-11-27T20:11:18  <bitcoin-git> bitcoin/master c77f092 Russell Yanofsky: Fix descriptor_tests not checking ToString output of public descriptors
480 2018-11-27T20:11:19  <bitcoin-git> bitcoin/master 0fa3703 MarcoFalke: Merge #14820: test: Fix descriptor_tests not checking ToString output of public descriptors...
481 2018-11-27T20:11:19  *** bitcoin-git has left #bitcoin-core-dev
482 2018-11-27T20:12:28  *** bitcoin-git has joined #bitcoin-core-dev
483 2018-11-27T20:12:29  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14820: test: Fix descriptor_tests not checking ToString output of public descriptors (master...pr/descstr) https://github.com/bitcoin/bitcoin/pull/14820
484 2018-11-27T20:12:29  *** bitcoin-git has left #bitcoin-core-dev
485 2018-11-27T20:23:12  *** bitcoin-git has joined #bitcoin-core-dev
486 2018-11-27T20:23:12  <bitcoin-git> [bitcoin] sipa pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/0fa3703c1757...fdf146f3293c
487 2018-11-27T20:23:13  <bitcoin-git> bitcoin/master 4d78bd9 Pieter Wuille: Add support for inferring descriptors from scripts
488 2018-11-27T20:23:13  <bitcoin-git> bitcoin/master 225bf3e Pieter Wuille: Add Descriptor::IsSolvable() to distinguish addr/raw from others
489 2018-11-27T20:23:14  <bitcoin-git> bitcoin/master 9b2a25b Pieter Wuille: Add tests for InferDescriptor and Descriptor::IsSolvable
490 2018-11-27T20:23:14  *** bitcoin-git has left #bitcoin-core-dev
491 2018-11-27T20:23:33  <MarcoFalke> luke-jr: Lol, its fine either way. with the import or +1
492 2018-11-27T20:23:59  *** bitcoin-git has joined #bitcoin-core-dev
493 2018-11-27T20:23:59  <bitcoin-git> [bitcoin] sipa closed pull request #14477: Add ability to convert solvability info to descriptor (master...201810_inferdescript) https://github.com/bitcoin/bitcoin/pull/14477
494 2018-11-27T20:23:59  *** bitcoin-git has left #bitcoin-core-dev
495 2018-11-27T20:25:11  <meshcollider> Yay \o/
496 2018-11-27T20:25:17  <meshcollider> Time to rebase mine now
497 2018-11-27T20:26:03  <meshcollider> Oh wait no I still need #14565
498 2018-11-27T20:26:04  *** assaf_ has joined #bitcoin-core-dev
499 2018-11-27T20:26:09  <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
500 2018-11-27T20:31:08  *** bitcoin-git has joined #bitcoin-core-dev
501 2018-11-27T20:31:09  <bitcoin-git> [bitcoin] sipa opened pull request #14821: Replace CAffectedKeysVisitor with descriptor based logic (master...201810_die_caffectedkeysvisitor_die) https://github.com/bitcoin/bitcoin/pull/14821
502 2018-11-27T20:31:09  *** bitcoin-git has left #bitcoin-core-dev
503 2018-11-27T20:45:37  *** promag has joined #bitcoin-core-dev
504 2018-11-27T20:56:43  *** promag has quit IRC
505 2018-11-27T20:56:58  *** promag has joined #bitcoin-core-dev
506 2018-11-27T21:03:10  *** dviola has joined #bitcoin-core-dev
507 2018-11-27T21:10:24  *** ibispi has joined #bitcoin-core-dev
508 2018-11-27T21:18:48  *** assaf_ has quit IRC
509 2018-11-27T21:27:36  *** grubles has quit IRC
510 2018-11-27T21:32:00  *** bitcoin-git has joined #bitcoin-core-dev
511 2018-11-27T21:32:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fdf146f3293c...600b85bb4172
512 2018-11-27T21:32:01  <bitcoin-git> bitcoin/master ebd3bf2 practicalswift: Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase
513 2018-11-27T21:32:01  <bitcoin-git> bitcoin/master ff7212e practicalswift: Add ASan Travis build
514 2018-11-27T21:32:02  <bitcoin-git> bitcoin/master 6541d59 practicalswift: Add LSan suppression warnings
515 2018-11-27T21:32:02  *** bitcoin-git has left #bitcoin-core-dev
516 2018-11-27T21:33:13  *** bitcoin-git has joined #bitcoin-core-dev
517 2018-11-27T21:33:14  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14794: tests: Add AddressSanitizer (ASan) Travis build (master...asan-in-travis) https://github.com/bitcoin/bitcoin/pull/14794
518 2018-11-27T21:33:14  *** bitcoin-git has left #bitcoin-core-dev
519 2018-11-27T21:50:39  *** morcos has quit IRC
520 2018-11-27T21:50:56  *** morcos has joined #bitcoin-core-dev
521 2018-11-27T21:52:20  *** grubles has joined #bitcoin-core-dev
522 2018-11-27T21:55:31  *** bitcoin-git has joined #bitcoin-core-dev
523 2018-11-27T21:55:31  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14822: bench: Destroy wallet txs instead of leaking their memory (master...Mf1811-benchWalletTxs) https://github.com/bitcoin/bitcoin/pull/14822
524 2018-11-27T21:55:31  *** bitcoin-git has left #bitcoin-core-dev
525 2018-11-27T21:56:00  <jnewbery> I'm trying to work out how fAvailableCreditCached in WalletTx is supposed to work. If the spentness of any of the outputs changes, the cache doesn't get cleared and subsequent calls to GetAvailableCredit() will return the cached value. Am I missing something?
526 2018-11-27T22:08:25  *** harrigan has quit IRC
527 2018-11-27T22:10:35  *** Guyver2 has quit IRC
528 2018-11-27T22:12:58  <meshcollider> jnewbery: not sure exactly where you're looking, but does it call MarkDirty?
529 2018-11-27T22:13:14  <meshcollider> MarkDirty will set fAvailableCreditCached to false so it won't return the cached value
530 2018-11-27T22:17:04  <jnewbery> meshcollider: yes, you're right. Thanks!
531 2018-11-27T22:17:20  *** harrigan has joined #bitcoin-core-dev
532 2018-11-27T22:19:02  *** spinza has quit IRC
533 2018-11-27T22:20:23  *** Chris_Stewart_5 has quit IRC
534 2018-11-27T22:38:15  *** spinza has joined #bitcoin-core-dev
535 2018-11-27T22:49:28  *** fabianfabian has quit IRC
536 2018-11-27T22:58:56  *** ken2812221_ has joined #bitcoin-core-dev
537 2018-11-27T23:01:00  *** ken2812221 has quit IRC
538 2018-11-27T23:05:16  *** Bullitje has joined #bitcoin-core-dev
539 2018-11-27T23:08:27  *** Bullit has quit IRC
540 2018-11-27T23:24:25  *** gelmutshmidt has quit IRC
541 2018-11-27T23:24:26  <luke-jr> jnewbery: making it impossible to get the current balance (ie, with untrusted txs included) is IMO not acceptable
542 2018-11-27T23:27:01  *** flyingkiwi has joined #bitcoin-core-dev
543 2018-11-27T23:27:31  *** flyingkiwi has quit IRC
544 2018-11-27T23:29:03  *** michaelsdunn1 has quit IRC
545 2018-11-27T23:41:06  *** justanotheruser has joined #bitcoin-core-dev
546 2018-11-27T23:41:37  *** justan0theruser has joined #bitcoin-core-dev
547 2018-11-27T23:45:27  *** justanotheruser has quit IRC
548 2018-11-27T23:56:09  *** Boniche0 has joined #bitcoin-core-dev