1 2018-12-04T00:06:56  *** _cryptodesktop_i has joined #bitcoin-core-dev
  2 2018-12-04T00:09:02  *** mr_paz has quit IRC
  3 2018-12-04T00:37:27  *** justanotheruser has quit IRC
  4 2018-12-04T00:37:44  *** justanotheruser has joined #bitcoin-core-dev
  5 2018-12-04T00:40:40  *** _cryptodesktop_i has quit IRC
  6 2018-12-04T00:50:35  *** bralyclow2 has joined #bitcoin-core-dev
  7 2018-12-04T00:50:49  *** bralyclow2 has quit IRC
  8 2018-12-04T00:51:06  *** bralyclow2 has joined #bitcoin-core-dev
  9 2018-12-04T00:51:12  *** bralyclow2 has quit IRC
 10 2018-12-04T01:45:08  *** promag has quit IRC
 11 2018-12-04T01:50:26  *** joltman2 has joined #bitcoin-core-dev
 12 2018-12-04T01:54:46  *** joltman2 has quit IRC
 13 2018-12-04T02:11:18  *** CubicEarth has quit IRC
 14 2018-12-04T02:16:19  *** promag has joined #bitcoin-core-dev
 15 2018-12-04T02:17:51  *** jarthur_ has joined #bitcoin-core-dev
 16 2018-12-04T02:19:09  *** libsci1 has joined #bitcoin-core-dev
 17 2018-12-04T02:19:31  *** libsci1 has quit IRC
 18 2018-12-04T02:20:53  *** promag has quit IRC
 19 2018-12-04T02:21:06  *** jarthur has quit IRC
 20 2018-12-04T02:22:37  *** jarthur_ has quit IRC
 21 2018-12-04T02:24:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 22 2018-12-04T02:32:28  *** Chris_Stewart_5 has quit IRC
 23 2018-12-04T02:36:12  <gwillen> is there a document or a cohesive policy on how exceptions are used in Core? I am refactoring stuff out of RPC handlers so it can be used in the GUI, and it throws exceptions with descriptive text for the RPC server to return.
 24 2018-12-04T02:36:32  <gwillen> and I'm not sure what to do with them. I can convert them to more generic exceptions, but I assume throwing exceptions out into UI code would do something bad.
 25 2018-12-04T02:36:35  *** CubicEarth has joined #bitcoin-core-dev
 26 2018-12-04T02:43:17  <mryandao> bitcoind uses whatever libsnappy that's provided through the host system yes?
 27 2018-12-04T02:43:38  <mryandao> libsnappy being a dependency of leveldb.
 28 2018-12-04T02:45:00  <gmaxwell> bitcoind doesn't use libsnappy at all.
 29 2018-12-04T02:48:07  <sipa> mryandao: no, our own fork of leveldb has libsnappy support disabled to simplify dependencies
 30 2018-12-04T02:48:33  <sipa> if you build against system leveldb, it will still disable libsnappy at runtime
 31 2018-12-04T02:48:55  <gmaxwell> (also because libsnappy hurt performance for us IIRC)
 32 2018-12-04T02:49:08  <mryandao> ah thank you for that.
 33 2018-12-04T02:57:03  *** hrofu has joined #bitcoin-core-dev
 34 2018-12-04T03:01:18  *** jarthur has joined #bitcoin-core-dev
 35 2018-12-04T03:04:24  *** justan0theruser has joined #bitcoin-core-dev
 36 2018-12-04T03:05:50  *** justanotheruser has quit IRC
 37 2018-12-04T03:13:02  *** phwalkr has quit IRC
 38 2018-12-04T03:17:25  *** jarthur has quit IRC
 39 2018-12-04T03:23:18  *** phwalkr has joined #bitcoin-core-dev
 40 2018-12-04T03:24:54  *** promag has joined #bitcoin-core-dev
 41 2018-12-04T03:27:27  *** phwalkr has quit IRC
 42 2018-12-04T03:29:36  *** promag has quit IRC
 43 2018-12-04T03:43:33  *** profmac has quit IRC
 44 2018-12-04T03:47:15  *** hrofu has quit IRC
 45 2018-12-04T03:56:37  *** profmac has joined #bitcoin-core-dev
 46 2018-12-04T03:58:46  *** Murch has quit IRC
 47 2018-12-04T04:01:36  *** crondog has joined #bitcoin-core-dev
 48 2018-12-04T04:01:54  *** crondog has quit IRC
 49 2018-12-04T04:13:57  *** spinza has quit IRC
 50 2018-12-04T04:17:14  *** schnerch_ has joined #bitcoin-core-dev
 51 2018-12-04T04:18:55  *** jarthur has joined #bitcoin-core-dev
 52 2018-12-04T04:19:57  *** schnerchi has quit IRC
 53 2018-12-04T04:22:05  *** jarthur has quit IRC
 54 2018-12-04T04:24:00  *** jarthur has joined #bitcoin-core-dev
 55 2018-12-04T04:27:29  *** spinza has joined #bitcoin-core-dev
 56 2018-12-04T04:28:07  *** indistylo has joined #bitcoin-core-dev
 57 2018-12-04T04:31:40  *** AaronvanW has quit IRC
 58 2018-12-04T04:36:26  *** indistylo has quit IRC
 59 2018-12-04T04:36:52  *** indistylo has joined #bitcoin-core-dev
 60 2018-12-04T04:38:39  *** bitcoin-git has joined #bitcoin-core-dev
 61 2018-12-04T04:38:39  <bitcoin-git> [bitcoin] dongcarl opened pull request #14864: test: Run scripted-diff in subshell (master...2018-12-unset-commit-script-check) https://github.com/bitcoin/bitcoin/pull/14864
 62 2018-12-04T04:38:39  *** bitcoin-git has left #bitcoin-core-dev
 63 2018-12-04T04:41:58  *** AaronvanW has joined #bitcoin-core-dev
 64 2018-12-04T04:43:16  <dongcarl> Looking at our shell scripts... I see a lot of fragile syntax that shellcheck would pick up on. Is it an acceptable PR to refactor those scripts to conform to shell script best pratices?
 65 2018-12-04T04:46:27  *** AaronvanW has quit IRC
 66 2018-12-04T04:53:26  <gwillen> dongcarl: maybe step 1 is to propose a change to the coding guidelines to use shellcheck as a linter for shell scripts?
 67 2018-12-04T04:56:36  <dongcarl> Seems like lint-shell.sh already does so
 68 2018-12-04T04:57:11  <dongcarl> Just some warnings are disabled
 69 2018-12-04T05:07:34  *** djoot22 has joined #bitcoin-core-dev
 70 2018-12-04T05:11:30  *** phwalkr has joined #bitcoin-core-dev
 71 2018-12-04T05:15:57  *** phwalkr has quit IRC
 72 2018-12-04T05:16:54  *** Java has joined #bitcoin-core-dev
 73 2018-12-04T05:27:52  *** ppisati has quit IRC
 74 2018-12-04T05:34:27  *** ppisati has joined #bitcoin-core-dev
 75 2018-12-04T05:52:47  *** Java has quit IRC
 76 2018-12-04T06:12:24  *** bgibson has joined #bitcoin-core-dev
 77 2018-12-04T06:35:27  <gleb> What currently happens if I get tx INV, send GETDATA and never hear a TX back from that peer?
 78 2018-12-04T06:36:49  <sipa> who is 'i'?
 79 2018-12-04T06:37:00  <gleb> A Bitcoin core node :)
 80 2018-12-04T06:39:02  <sipa> you mean what does bitcoin core do if it doesn't hear back from a tx getdata request?
 81 2018-12-04T06:39:24  <gleb> Yeah, I'm missing the part of code where waiting for a TX message time-outs or something
 82 2018-12-04T06:40:42  <sipa> there is a 2 minute timeout, and then permit asking another peer afaik
 83 2018-12-04T06:41:41  <gmaxwell> gleb: see the logic at the bottom of void CNode::AskFor(const CInv& inv)
 84 2018-12-04T06:41:49  <gmaxwell> lol bottom of void.
 85 2018-12-04T06:43:25  <gleb> Got it, for some reason I thought that if a node sends one GETDATA, it won't send the second one after the same INV from another peer.
 86 2018-12-04T06:43:47  <gleb> That would be highly susceptible :)
 87 2018-12-04T06:44:11  <gmaxwell> right there is a delay... the logic is a bit dumb but sufficient.
 88 2018-12-04T06:44:48  <gmaxwell> e.g. it can't handle the case that it asks and gets disconnected except by waiting for the timeout...
 89 2018-12-04T06:45:21  <gleb> gmaxwell: wait, but if a node gets 2 INVs at the same, it will send 2 GETDATAs, right? (from different peers)
 90 2018-12-04T06:45:40  *** midnightmagic has quit IRC
 91 2018-12-04T06:46:31  <gleb> 2 INVs with the same hash at the same time*
 92 2018-12-04T06:47:12  *** murrayn_ has joined #bitcoin-core-dev
 93 2018-12-04T06:47:24  *** murrayn has quit IRC
 94 2018-12-04T06:50:44  <gmaxwell> gleb: no.
 95 2018-12-04T06:50:51  <gmaxwell> well depending on what you mean at the same time.
 96 2018-12-04T06:51:16  <gmaxwell> the will only send one getdata unless someone times out.
 97 2018-12-04T06:51:31  <gmaxwell> which of the two peer gets it depends whos inv the node processed first.
 98 2018-12-04T06:52:54  <gleb> I can censor propagation of your txs then? Once I see your tx in the network, I can start INVing everybody about it and not give TX.
 99 2018-12-04T06:53:11  *** midnightmagic has joined #bitcoin-core-dev
100 2018-12-04T06:53:17  <gmaxwell> gleb: for two minutes
101 2018-12-04T06:53:33  <gleb> And if I have 2 IPs then for 4 minutes?
102 2018-12-04T06:53:54  <gmaxwell> potentially.
103 2018-12-04T06:54:21  <gmaxwell> (another way the handling is dumb, after timeout the available offers should be considered in random order.
104 2018-12-04T06:54:23  <gmaxwell> )
105 2018-12-04T06:58:32  <gleb> gmaxwell: If I start attacking early enough, that won't significantly increase the cost of an attack, because only few nodes will be INVing it along with me.  You can think that relay happens "in waves" (just as bitconnect)
106 2018-12-04T07:01:54  <gwillen> hmm, that's kind of bad for lightning unilateral channel closes, isn't it?
107 2018-12-04T07:02:05  <gwillen> the attacker already knows the txid before you ever start broadcasting it
108 2018-12-04T07:02:25  <gwillen> so they can start poisoning the network before they even start the attack
109 2018-12-04T07:02:45  <gwillen> (it still seems like a nearly-infeasible amount of broadcast spam, which would be detected immediately and network-wide)
110 2018-12-04T07:03:09  <gleb> If a botnet is 10k nodes and starts before 10% of the nodes knew about a tx, I expect us easily to get 10 minutes delay. It's a very cheap attack in terms of traffic, and requires very trivial mimicking of BTC protocol
111 2018-12-04T07:03:37  *** ujjwalt_ has joined #bitcoin-core-dev
112 2018-12-04T07:04:20  <gleb> I'm saying even IF we implement the trick gmaxwell mentioned (random selection of next peer). If not, it's cheap to delay a transaction forever.
113 2018-12-04T07:05:13  *** ujjwalt_ has left #bitcoin-core-dev
114 2018-12-04T07:05:27  *** Cory has quit IRC
115 2018-12-04T07:07:56  <gwillen> but since such an attack would be very obvious to everyone, it wouldn't be hard to get consensus to fix it permanently soon after. So it would really only work once.
116 2018-12-04T07:08:19  <gwillen> (And there are probably more profitable things you can do with a 10k node botnet.)
117 2018-12-04T07:08:45  *** kmels has quit IRC
118 2018-12-04T07:09:13  *** kmels has joined #bitcoin-core-dev
119 2018-12-04T07:12:50  *** Cory has joined #bitcoin-core-dev
120 2018-12-04T07:14:01  *** ujjwalt has joined #bitcoin-core-dev
121 2018-12-04T07:15:04  *** lnostdal has quit IRC
122 2018-12-04T07:15:07  <ujjwalt> Hey, I’m new here and I want to start developing Bitcoin apps. I have basic idea about the protocol - enough to understand how the system largely works (keys, basic crypto etc) but where and how do I start if I want to make an app around this. I have a full node running now.
123 2018-12-04T07:22:38  <NicolasDorier> harding: " I suggested connecting over SPV to a single node that the user trusted."... Then if your trusted node go down, your service go down with it. And what is the advantage of doing it at all? If you have a trusted node, just run getutxosetinfo on both side and you have proof my utxoset has the same UTXOs as your trusted node
124 2018-12-04T07:33:14  *** hebasto has joined #bitcoin-core-dev
125 2018-12-04T07:35:01  <gleb> This no TX timeout thing also may cause topology inference attacks (similar to "doublespending topology inference" from FC18).
126 2018-12-04T07:39:55  <gleb> I acknowledge that alternative solutions might be more harmful than the issue I'm bringing up, just thought it's worth mentioning here.
127 2018-12-04T07:43:11  *** murrayn_ has quit IRC
128 2018-12-04T07:43:14  *** jarthur has quit IRC
129 2018-12-04T07:43:29  *** murrayn has joined #bitcoin-core-dev
130 2018-12-04T07:45:44  *** ken2812221__ has joined #bitcoin-core-dev
131 2018-12-04T07:48:59  *** ken2812221_ has quit IRC
132 2018-12-04T07:56:07  *** indistylo has quit IRC
133 2018-12-04T07:56:32  *** indistylo has joined #bitcoin-core-dev
134 2018-12-04T07:58:43  *** morcos has quit IRC
135 2018-12-04T07:59:04  *** morcos has joined #bitcoin-core-dev
136 2018-12-04T07:59:20  *** zivl has quit IRC
137 2018-12-04T08:00:16  *** zivl has joined #bitcoin-core-dev
138 2018-12-04T08:02:36  *** ujjwalt has left #bitcoin-core-dev
139 2018-12-04T08:02:40  *** indistylo has quit IRC
140 2018-12-04T08:13:50  *** indistylo has joined #bitcoin-core-dev
141 2018-12-04T08:19:47  *** indistylo has quit IRC
142 2018-12-04T08:20:32  *** bitcoin-git has joined #bitcoin-core-dev
143 2018-12-04T08:20:33  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c62b15118997...64fc7c0c1b17
144 2018-12-04T08:20:33  <bitcoin-git> bitcoin/master 1c28feb João Barbosa: qt: Remove hidden columns in coin control dialog
145 2018-12-04T08:20:34  <bitcoin-git> bitcoin/master 64fc7c0 Jonas Schnelli: Merge #14828: qt: Remove hidden columns in coin control dialog...
146 2018-12-04T08:20:34  *** bitcoin-git has left #bitcoin-core-dev
147 2018-12-04T08:21:37  *** bitcoin-git has joined #bitcoin-core-dev
148 2018-12-04T08:21:38  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14828: qt: Remove hidden columns in coin control dialog (master...2018-11-coincontroldialog) https://github.com/bitcoin/bitcoin/pull/14828
149 2018-12-04T08:21:38  *** bitcoin-git has left #bitcoin-core-dev
150 2018-12-04T08:24:12  *** promag has joined #bitcoin-core-dev
151 2018-12-04T08:28:40  *** promag has quit IRC
152 2018-12-04T08:40:53  *** lnostdal has joined #bitcoin-core-dev
153 2018-12-04T08:50:47  *** IGHOR has quit IRC
154 2018-12-04T08:51:24  *** IGHOR has joined #bitcoin-core-dev
155 2018-12-04T09:01:24  *** jhfrontz has joined #bitcoin-core-dev
156 2018-12-04T09:16:40  *** indistylo has joined #bitcoin-core-dev
157 2018-12-04T09:19:05  *** timothy has joined #bitcoin-core-dev
158 2018-12-04T09:26:04  <gmaxwell> gleb: you can't get forever even without what I suggested.
159 2018-12-04T09:26:21  <gmaxwell> you can get two minutes per dishonest peer, at any hop.
160 2018-12-04T09:30:06  <stevenroose> kallewoof: around?
161 2018-12-04T09:56:08  <stevenroose> Why do the wallet signal handlers need the main lock?
162 2018-12-04T09:56:15  <stevenroose> ryanofsky: ^ any idea?
163 2018-12-04T09:57:18  <kallewoof> stevenroose: I sent you DM's FYI.
164 2018-12-04T10:00:44  *** AaronvanW has joined #bitcoin-core-dev
165 2018-12-04T10:03:47  *** bitcoin-git has joined #bitcoin-core-dev
166 2018-12-04T10:03:47  <bitcoin-git> [bitcoin] AkioNak opened pull request #14866: Improve property evaluation way in bitcoin.conf (master...includeconf_eval_at_its_position) https://github.com/bitcoin/bitcoin/pull/14866
167 2018-12-04T10:03:47  *** bitcoin-git has left #bitcoin-core-dev
168 2018-12-04T10:05:21  *** AaronvanW has quit IRC
169 2018-12-04T10:15:54  *** spinza has quit IRC
170 2018-12-04T10:21:26  *** spinza has joined #bitcoin-core-dev
171 2018-12-04T10:29:35  *** bitcoin-git has joined #bitcoin-core-dev
172 2018-12-04T10:29:36  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64fc7c0c1b17...0257062e50ca
173 2018-12-04T10:29:36  <bitcoin-git> bitcoin/master 2012d4d Gregory Sanders: Add CScriptNum decode python implementation in functional suite
174 2018-12-04T10:29:37  <bitcoin-git> bitcoin/master 0257062 Wladimir J. van der Laan: Merge #14816: Add CScriptNum decode python implementation in functional suite...
175 2018-12-04T10:29:37  *** bitcoin-git has left #bitcoin-core-dev
176 2018-12-04T10:29:38  *** rh0nj has quit IRC
177 2018-12-04T10:30:42  *** bitcoin-git has joined #bitcoin-core-dev
178 2018-12-04T10:30:43  <bitcoin-git> [bitcoin] laanwj closed pull request #14816: Add CScriptNum decode python implementation in functional suite (master...functional_cscriptnum_decode) https://github.com/bitcoin/bitcoin/pull/14816
179 2018-12-04T10:30:43  *** bitcoin-git has left #bitcoin-core-dev
180 2018-12-04T10:31:02  *** bitcoin-git has joined #bitcoin-core-dev
181 2018-12-04T10:31:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0257062e50ca...8f1753b298f1
182 2018-12-04T10:31:03  <bitcoin-git> bitcoin/master 6c6ee8a Chakib Benziane: Less confusing documentation for `torpassword`...
183 2018-12-04T10:31:04  <bitcoin-git> bitcoin/master 8f1753b Wladimir J. van der Laan: Merge #14804: docs: Less confusing documentation for `torpassword`...
184 2018-12-04T10:31:04  *** bitcoin-git has left #bitcoin-core-dev
185 2018-12-04T10:31:59  *** bitcoin-git has joined #bitcoin-core-dev
186 2018-12-04T10:31:59  <bitcoin-git> [bitcoin] laanwj closed pull request #14804: docs: Less confusing documentation for `torpassword` (master...rebased-squashed-14609) https://github.com/bitcoin/bitcoin/pull/14804
187 2018-12-04T10:31:59  *** bitcoin-git has left #bitcoin-core-dev
188 2018-12-04T10:35:12  *** bitcoin-git has joined #bitcoin-core-dev
189 2018-12-04T10:35:13  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8f1753b298f1...c789add6fcc9
190 2018-12-04T10:35:13  <bitcoin-git> bitcoin/master 4674610 João Barbosa: Log env path in BerkeleyEnvironment::Flush
191 2018-12-04T10:35:14  <bitcoin-git> bitcoin/master c789add Wladimir J. van der Laan: Merge #14760: Log env path in BerkeleyEnvironment::Flush...
192 2018-12-04T10:35:14  *** bitcoin-git has left #bitcoin-core-dev
193 2018-12-04T10:36:00  <stevenroose> sipa, meshcollider, perhaps
194 2018-12-04T10:36:07  *** bitcoin-git has joined #bitcoin-core-dev
195 2018-12-04T10:36:08  <bitcoin-git> [bitcoin] laanwj closed pull request #14760: Log env path in BerkeleyEnvironment::Flush (master...2018-11-logmultienvflush) https://github.com/bitcoin/bitcoin/pull/14760
196 2018-12-04T10:36:08  *** bitcoin-git has left #bitcoin-core-dev
197 2018-12-04T10:42:00  <meshcollider> stevenroose: can you point me to an example of what you mean
198 2018-12-04T10:42:45  *** phwalkr has joined #bitcoin-core-dev
199 2018-12-04T10:43:07  *** rh0nj has joined #bitcoin-core-dev
200 2018-12-04T10:45:10  *** AaronvanW has joined #bitcoin-core-dev
201 2018-12-04T10:47:19  *** bitcoin-git has joined #bitcoin-core-dev
202 2018-12-04T10:47:20  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c789add6fcc9...42653570373d
203 2018-12-04T10:47:20  <bitcoin-git> bitcoin/master af1ed20 Craig Younkins: Fix broken Gmane URLs
204 2018-12-04T10:47:21  <bitcoin-git> bitcoin/master 4265357 Wladimir J. van der Laan: Merge #14848: docs: Fix broken Gmane URL in security-check.py...
205 2018-12-04T10:47:21  *** bitcoin-git has left #bitcoin-core-dev
206 2018-12-04T10:48:21  *** bitcoin-git has joined #bitcoin-core-dev
207 2018-12-04T10:48:22  <bitcoin-git> [bitcoin] laanwj closed pull request #14848: docs: Fix broken Gmane URL in security-check.py (master...fix-gmane-urls) https://github.com/bitcoin/bitcoin/pull/14848
208 2018-12-04T10:48:22  *** bitcoin-git has left #bitcoin-core-dev
209 2018-12-04T10:49:43  *** AaronvanW has quit IRC
210 2018-12-04T10:50:03  *** indistylo has quit IRC
211 2018-12-04T11:00:39  *** osue has quit IRC
212 2018-12-04T11:04:26  *** AaronvanW has joined #bitcoin-core-dev
213 2018-12-04T11:08:54  *** AaronvanW has quit IRC
214 2018-12-04T11:11:24  *** CodeBlue1776 has quit IRC
215 2018-12-04T11:12:02  *** CodeBlue1776 has joined #bitcoin-core-dev
216 2018-12-04T11:22:31  *** arubi has quit IRC
217 2018-12-04T11:23:25  *** setpill has joined #bitcoin-core-dev
218 2018-12-04T11:26:27  <stevenroose> kanzure: you here?
219 2018-12-04T11:26:42  <stevenroose> we have a wallet question and I hear you use the wallet a lot :)
220 2018-12-04T11:27:07  <stevenroose> Does Core's wallet (officially) support using it from a multi-threaded user?
221 2018-12-04T11:27:38  *** setpill has quit IRC
222 2018-12-04T11:29:46  *** setpill has joined #bitcoin-core-dev
223 2018-12-04T11:36:38  <phwalkr> Where can I find a multi input tx building example? I have tried libbitcoin and bitcoin core and found nothing.
224 2018-12-04T11:47:56  *** hrest has joined #bitcoin-core-dev
225 2018-12-04T11:49:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
226 2018-12-04T11:51:22  <stevenroose> phwalkr: with the RPC?
227 2018-12-04T11:51:41  *** hrest has quit IRC
228 2018-12-04T11:55:43  *** epochwolf has joined #bitcoin-core-dev
229 2018-12-04T11:58:33  *** bitcoin-git has joined #bitcoin-core-dev
230 2018-12-04T11:58:33  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/42653570373d...88445889f1b3
231 2018-12-04T11:58:34  <bitcoin-git> bitcoin/master 8042bbf Zain Iqbal Allarakhia: p2p: allow p2ptimeout to be configurable, speed up slow test
232 2018-12-04T11:58:34  <bitcoin-git> bitcoin/master 48b37db Zain Iqbal Allarakhia: make peertimeout a debug argument, remove error message translation
233 2018-12-04T11:58:35  <bitcoin-git> bitcoin/master 8844588 Wladimir J. van der Laan: Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested....
234 2018-12-04T11:58:35  *** bitcoin-git has left #bitcoin-core-dev
235 2018-12-04T11:59:27  *** bitcoin-git has joined #bitcoin-core-dev
236 2018-12-04T11:59:27  <bitcoin-git> [bitcoin] laanwj closed pull request #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
237 2018-12-04T11:59:27  *** bitcoin-git has left #bitcoin-core-dev
238 2018-12-04T12:00:40  *** epochwolf has quit IRC
239 2018-12-04T12:08:09  *** bitcoin-git has joined #bitcoin-core-dev
240 2018-12-04T12:08:10  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88445889f1b3...abbf4be181e0
241 2018-12-04T12:08:10  <bitcoin-git> bitcoin/master f3cf95f Carl Dong: tests: Modify rpc_bind to conform to #14532 behaviour....
242 2018-12-04T12:08:11  <bitcoin-git> bitcoin/master abbf4be Wladimir J. van der Laan: Merge #14861: tests: Modify rpc_bind to conform to #14532 behaviour....
243 2018-12-04T12:08:11  *** bitcoin-git has left #bitcoin-core-dev
244 2018-12-04T12:09:09  *** bitcoin-git has joined #bitcoin-core-dev
245 2018-12-04T12:09:09  <bitcoin-git> [bitcoin] laanwj closed pull request #14861: tests: Modify rpc_bind to conform to #14532 behaviour. (master...2018-12-fix-rpc-bind-tests) https://github.com/bitcoin/bitcoin/pull/14861
246 2018-12-04T12:09:09  *** bitcoin-git has left #bitcoin-core-dev
247 2018-12-04T12:09:12  *** AaronvanW has joined #bitcoin-core-dev
248 2018-12-04T12:17:01  <phwalkr> stevenroose: found it here: https://github.com/libbitcoin/libbitcoin/wiki/Sighash-and-TX-Signing Thanks anyway
249 2018-12-04T12:23:51  *** gelmutshmidt has joined #bitcoin-core-dev
250 2018-12-04T12:26:07  *** indistylo has joined #bitcoin-core-dev
251 2018-12-04T12:34:48  *** Chris_Stewart_5 has quit IRC
252 2018-12-04T12:40:02  *** bitcoin-git has joined #bitcoin-core-dev
253 2018-12-04T12:40:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/abbf4be181e0...86ff0413bb8f
254 2018-12-04T12:40:04  <bitcoin-git> bitcoin/master b14948e Amir Abrams: Remove duplicate libconsensus linking in test make...
255 2018-12-04T12:40:04  <bitcoin-git> bitcoin/master 86ff041 Wladimir J. van der Laan: Merge #14840: Remove duplicate libconsensus linking in test make...
256 2018-12-04T12:40:05  *** bitcoin-git has left #bitcoin-core-dev
257 2018-12-04T12:40:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
258 2018-12-04T12:41:10  *** bitcoin-git has joined #bitcoin-core-dev
259 2018-12-04T12:41:10  <bitcoin-git> [bitcoin] laanwj closed pull request #14840: Remove duplicate libconsensus linking in test make (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14840
260 2018-12-04T12:41:10  *** bitcoin-git has left #bitcoin-core-dev
261 2018-12-04T12:53:24  *** spinza has quit IRC
262 2018-12-04T12:53:33  *** justan0theruser has quit IRC
263 2018-12-04T12:54:51  *** bitcoin-git has joined #bitcoin-core-dev
264 2018-12-04T12:54:52  <bitcoin-git> [bitcoin] laanwj opened pull request #14869: scripts: Add trusted key for Samuel Dobson (master...2018_12_meshcollider) https://github.com/bitcoin/bitcoin/pull/14869
265 2018-12-04T12:54:52  *** bitcoin-git has left #bitcoin-core-dev
266 2018-12-04T12:56:48  *** hrofu has joined #bitcoin-core-dev
267 2018-12-04T13:02:32  *** indistylo has quit IRC
268 2018-12-04T13:08:07  *** justan0theruser has joined #bitcoin-core-dev
269 2018-12-04T13:12:55  *** spinza has joined #bitcoin-core-dev
270 2018-12-04T13:21:51  *** chenpo has joined #bitcoin-core-dev
271 2018-12-04T13:37:21  *** rafalcpp has quit IRC
272 2018-12-04T13:39:27  *** queip has quit IRC
273 2018-12-04T13:48:51  *** indistylo has joined #bitcoin-core-dev
274 2018-12-04T13:54:02  <kanzure> stevenroose: i'm actually not sure.
275 2018-12-04T13:54:33  <kanzure> stevenroose: are you asking "can i make multiple rpc requests from other processes and threads?"
276 2018-12-04T13:56:11  *** queip has joined #bitcoin-core-dev
277 2018-12-04T14:00:35  <stevenroose> kanzure: yes
278 2018-12-04T14:01:09  <stevenroose> well, individual calls are obvious, if you do createrawtransaction and before you can fund, sign and send it, another thread does the same, of course that will fail
279 2018-12-04T14:01:40  <stevenroose> but more like, f.e. if you fire two sendtoaddress calls at the same time, will they try to spend the same utxos?
280 2018-12-04T14:01:49  <stevenroose> it appears that sendtoaddress is doing this safely
281 2018-12-04T14:02:04  <stevenroose> so question would be if the interface claims to be safe for this in all calls
282 2018-12-04T14:02:13  <stevenroose> or if it says you should not use it concurrently
283 2018-12-04T14:02:46  *** Chris_Stewart_5 has quit IRC
284 2018-12-04T14:14:04  *** hrofu has quit IRC
285 2018-12-04T14:17:04  <kanzure> stevenroose: i wouldn't expect concurrent use to work. for createrawtransaction/fundrawtransaction if you're planning multiple transactions then usually i've found i need to plan them separately outside of bitcoind.
286 2018-12-04T14:17:13  *** rafalcpp has joined #bitcoin-core-dev
287 2018-12-04T14:20:08  *** crmaurei8 has joined #bitcoin-core-dev
288 2018-12-04T14:24:53  *** crmaurei8 has quit IRC
289 2018-12-04T14:26:43  *** jarthur has joined #bitcoin-core-dev
290 2018-12-04T14:28:12  <stevenroose> yeah for createraw/fundraw/signraw/sendraw I understand
291 2018-12-04T14:28:47  <stevenroose> but ok we fixed our issue in elements and have an approach similar to sendaddress, so we should be at least as concurrency-safe as sendtoaddress which is enough :)
292 2018-12-04T14:34:37  *** promag has joined #bitcoin-core-dev
293 2018-12-04T14:40:26  <promag> hebasto: ping
294 2018-12-04T14:42:50  <promag> regarding #14854, can you detail your steps to see if I can reproduce?
295 2018-12-04T14:42:52  <gribble> https://github.com/bitcoin/bitcoin/issues/14854 | qt: Cleanup SplashScreen class by hebasto · Pull Request #14854 · bitcoin/bitcoin · GitHub
296 2018-12-04T14:49:07  *** Guyver2 has joined #bitcoin-core-dev
297 2018-12-04T14:51:03  <gleb> gmaxwell: Yes, 2 minutes per dishonest hop, but adding a new peer to a node is trivial and cheap. Anyway, perhaps I should allocate some time and try inferring the topology  :)
298 2018-12-04T14:59:59  *** jarthur has quit IRC
299 2018-12-04T15:01:27  *** kexkey has joined #bitcoin-core-dev
300 2018-12-04T15:06:59  *** s0lucien has joined #bitcoin-core-dev
301 2018-12-04T15:07:17  *** s0lucien has quit IRC
302 2018-12-04T15:10:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
303 2018-12-04T15:17:04  *** wxss has quit IRC
304 2018-12-04T15:21:29  *** indistylo has quit IRC
305 2018-12-04T15:21:33  *** CodeBlue1776 has quit IRC
306 2018-12-04T15:22:15  *** CodeBlue1776 has joined #bitcoin-core-dev
307 2018-12-04T15:23:42  *** hrofu has joined #bitcoin-core-dev
308 2018-12-04T15:34:59  *** michaelsdunn1 has joined #bitcoin-core-dev
309 2018-12-04T15:40:27  *** jarthur has joined #bitcoin-core-dev
310 2018-12-04T15:49:51  <promag> https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20762709
311 2018-12-04T15:49:55  <promag> another connection problem
312 2018-12-04T16:05:00  *** setpill has quit IRC
313 2018-12-04T16:10:17  *** shesek has joined #bitcoin-core-dev
314 2018-12-04T16:12:43  *** promag has quit IRC
315 2018-12-04T16:14:44  *** shesek has quit IRC
316 2018-12-04T16:16:26  *** shesek has joined #bitcoin-core-dev
317 2018-12-04T16:16:26  *** shesek has joined #bitcoin-core-dev
318 2018-12-04T16:24:21  *** Murch has joined #bitcoin-core-dev
319 2018-12-04T16:36:21  *** adiabat has quit IRC
320 2018-12-04T16:37:54  *** adiabat has joined #bitcoin-core-dev
321 2018-12-04T16:38:13  *** arubi has joined #bitcoin-core-dev
322 2018-12-04T16:39:01  *** phwalkr has quit IRC
323 2018-12-04T16:44:34  *** michaelsdunn1 has quit IRC
324 2018-12-04T16:46:39  *** michaelsdunn1 has joined #bitcoin-core-dev
325 2018-12-04T16:54:44  <sipa> stevenroose: you can ask fundrawtx to lock the selected utxos
326 2018-12-04T16:58:33  <stevenroose> sipa: oooh
327 2018-12-04T16:59:44  <stevenroose> that's cool
328 2018-12-04T17:00:37  <sipa> there is also lockunspent that control the set of locked utxos
329 2018-12-04T17:08:01  *** rh0nj has quit IRC
330 2018-12-04T17:09:07  *** rh0nj has joined #bitcoin-core-dev
331 2018-12-04T17:09:10  *** shesek has quit IRC
332 2018-12-04T17:09:42  *** shesek has joined #bitcoin-core-dev
333 2018-12-04T17:10:02  *** rh0nj has quit IRC
334 2018-12-04T17:11:07  *** rh0nj has joined #bitcoin-core-dev
335 2018-12-04T17:15:12  *** bustd_soket has joined #bitcoin-core-dev
336 2018-12-04T17:15:12  *** bustd_soket has joined #bitcoin-core-dev
337 2018-12-04T17:15:19  *** bustd_soket has left #bitcoin-core-dev
338 2018-12-04T17:20:37  *** shesek has quit IRC
339 2018-12-04T17:21:07  *** shesek has joined #bitcoin-core-dev
340 2018-12-04T17:21:07  *** shesek has joined #bitcoin-core-dev
341 2018-12-04T17:26:36  *** michaelsdunn1 has quit IRC
342 2018-12-04T17:28:43  *** michaelsdunn1 has joined #bitcoin-core-dev
343 2018-12-04T17:29:34  *** shesek has quit IRC
344 2018-12-04T17:30:45  *** shesek has joined #bitcoin-core-dev
345 2018-12-04T17:31:53  <hebasto> promag: here
346 2018-12-04T17:33:14  <hebasto> promag: my steps are the same as described in #7718
347 2018-12-04T17:33:16  <gribble> https://github.com/bitcoin/bitcoin/issues/7718 | Verifying blocks window stays open after the main GUI appears · Issue #7718 · bitcoin/bitcoin · GitHub
348 2018-12-04T17:34:20  *** shesek has quit IRC
349 2018-12-04T17:35:18  *** shesek has joined #bitcoin-core-dev
350 2018-12-04T17:36:35  <hebasto> promag: similar is here https://stackoverflow.com/questions/44286102/minimize-to-tray-on-macosx
351 2018-12-04T17:42:35  *** shesek has quit IRC
352 2018-12-04T17:43:17  *** shesek has joined #bitcoin-core-dev
353 2018-12-04T17:43:17  *** shesek has joined #bitcoin-core-dev
354 2018-12-04T17:46:41  *** shesek has quit IRC
355 2018-12-04T17:49:51  *** shesek has joined #bitcoin-core-dev
356 2018-12-04T17:51:51  *** shesek has quit IRC
357 2018-12-04T17:52:24  *** phwalkr has joined #bitcoin-core-dev
358 2018-12-04T17:52:55  *** shesek has joined #bitcoin-core-dev
359 2018-12-04T17:52:55  *** shesek has joined #bitcoin-core-dev
360 2018-12-04T17:57:16  *** phwalkr has quit IRC
361 2018-12-04T18:03:24  *** chenpo has quit IRC
362 2018-12-04T18:03:57  *** chenpo has joined #bitcoin-core-dev
363 2018-12-04T18:08:28  *** chenpo has quit IRC
364 2018-12-04T18:09:38  *** Chris_Stewart_5 has quit IRC
365 2018-12-04T18:21:03  *** shesek has quit IRC
366 2018-12-04T18:22:23  *** shesek has joined #bitcoin-core-dev
367 2018-12-04T18:23:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
368 2018-12-04T18:24:58  *** timothy has quit IRC
369 2018-12-04T18:25:01  *** shesek has quit IRC
370 2018-12-04T18:26:04  *** shesek has joined #bitcoin-core-dev
371 2018-12-04T18:26:04  *** shesek has joined #bitcoin-core-dev
372 2018-12-04T18:29:28  *** shesek has quit IRC
373 2018-12-04T18:32:09  *** shesek has joined #bitcoin-core-dev
374 2018-12-04T18:32:09  *** shesek has joined #bitcoin-core-dev
375 2018-12-04T18:35:51  *** rex4539 has joined #bitcoin-core-dev
376 2018-12-04T18:43:08  *** shesek has quit IRC
377 2018-12-04T18:44:26  *** shesek has joined #bitcoin-core-dev
378 2018-12-04T18:44:26  *** shesek has joined #bitcoin-core-dev
379 2018-12-04T19:00:20  *** shesek has quit IRC
380 2018-12-04T19:01:52  *** shesek has joined #bitcoin-core-dev
381 2018-12-04T19:02:05  *** Aaronvan_ has joined #bitcoin-core-dev
382 2018-12-04T19:04:34  *** shesek has quit IRC
383 2018-12-04T19:05:13  *** shesek has joined #bitcoin-core-dev
384 2018-12-04T19:05:38  *** shesek has quit IRC
385 2018-12-04T19:06:05  *** AaronvanW has quit IRC
386 2018-12-04T19:07:13  *** shesek has joined #bitcoin-core-dev
387 2018-12-04T19:07:13  *** shesek has joined #bitcoin-core-dev
388 2018-12-04T19:12:36  *** hebasto has quit IRC
389 2018-12-04T19:14:13  *** shesek has quit IRC
390 2018-12-04T19:20:05  *** shesek has joined #bitcoin-core-dev
391 2018-12-04T19:20:05  *** shesek has joined #bitcoin-core-dev
392 2018-12-04T19:29:31  *** shesek has quit IRC
393 2018-12-04T19:31:47  *** shesek has joined #bitcoin-core-dev
394 2018-12-04T19:31:56  *** asdf__ has joined #bitcoin-core-dev
395 2018-12-04T19:31:56  *** shesek has quit IRC
396 2018-12-04T19:33:12  *** shesek has joined #bitcoin-core-dev
397 2018-12-04T19:33:12  *** shesek has joined #bitcoin-core-dev
398 2018-12-04T19:38:19  *** asdf__ has quit IRC
399 2018-12-04T19:45:27  *** CubicEarth has quit IRC
400 2018-12-04T19:46:42  *** CubicEarth has joined #bitcoin-core-dev
401 2018-12-04T20:10:10  *** Murch has quit IRC
402 2018-12-04T20:10:35  *** Murch has joined #bitcoin-core-dev
403 2018-12-04T20:16:57  *** phwalkr has joined #bitcoin-core-dev
404 2018-12-04T20:21:10  *** shesek has quit IRC
405 2018-12-04T20:22:25  *** shesek has joined #bitcoin-core-dev
406 2018-12-04T20:22:25  *** shesek has joined #bitcoin-core-dev
407 2018-12-04T20:22:50  *** Murch has quit IRC
408 2018-12-04T20:23:07  *** shesek has quit IRC
409 2018-12-04T20:24:00  *** shesek has joined #bitcoin-core-dev
410 2018-12-04T20:24:17  *** Murch has joined #bitcoin-core-dev
411 2018-12-04T20:24:43  *** shesek has quit IRC
412 2018-12-04T20:27:59  *** shesek has joined #bitcoin-core-dev
413 2018-12-04T20:27:59  *** shesek has joined #bitcoin-core-dev
414 2018-12-04T20:29:02  *** Murch has quit IRC
415 2018-12-04T20:29:29  *** shesek has quit IRC
416 2018-12-04T20:31:54  *** shesek has joined #bitcoin-core-dev
417 2018-12-04T20:31:54  *** shesek has joined #bitcoin-core-dev
418 2018-12-04T20:33:33  *** shesek has quit IRC
419 2018-12-04T20:35:24  *** shesek has joined #bitcoin-core-dev
420 2018-12-04T20:37:44  *** shesek has quit IRC
421 2018-12-04T20:38:32  *** shesek has joined #bitcoin-core-dev
422 2018-12-04T20:38:32  *** shesek has joined #bitcoin-core-dev
423 2018-12-04T20:41:04  *** finman has joined #bitcoin-core-dev
424 2018-12-04T20:43:50  *** finman has quit IRC
425 2018-12-04T21:02:54  *** hrofu has quit IRC
426 2018-12-04T21:05:13  *** Th3Answer has joined #bitcoin-core-dev
427 2018-12-04T21:07:31  *** hrofu has joined #bitcoin-core-dev
428 2018-12-04T21:10:01  *** rh0nj has quit IRC
429 2018-12-04T21:11:08  *** rh0nj has joined #bitcoin-core-dev
430 2018-12-04T21:16:48  *** shesek has quit IRC
431 2018-12-04T21:17:15  *** shesek has joined #bitcoin-core-dev
432 2018-12-04T21:17:15  *** shesek has joined #bitcoin-core-dev
433 2018-12-04T21:23:47  *** shesek has quit IRC
434 2018-12-04T21:25:27  *** da2ce7 has quit IRC
435 2018-12-04T21:25:43  *** shesek has joined #bitcoin-core-dev
436 2018-12-04T21:27:05  *** da2ce7 has joined #bitcoin-core-dev
437 2018-12-04T21:27:11  *** Murch has joined #bitcoin-core-dev
438 2018-12-04T21:27:55  *** shesek has quit IRC
439 2018-12-04T21:29:32  *** shesek has joined #bitcoin-core-dev
440 2018-12-04T21:30:33  *** shesek has quit IRC
441 2018-12-04T21:35:34  *** shesek has joined #bitcoin-core-dev
442 2018-12-04T21:35:34  *** shesek has joined #bitcoin-core-dev
443 2018-12-04T21:35:47  *** shesek has quit IRC
444 2018-12-04T21:40:18  *** shesek has joined #bitcoin-core-dev
445 2018-12-04T21:42:03  *** spinza has quit IRC
446 2018-12-04T21:45:50  *** shesek has quit IRC
447 2018-12-04T21:47:48  *** spinza has joined #bitcoin-core-dev
448 2018-12-04T21:51:46  *** shesek has joined #bitcoin-core-dev
449 2018-12-04T21:55:05  *** mr_paz has joined #bitcoin-core-dev
450 2018-12-04T22:08:32  *** rex4539 has quit IRC
451 2018-12-04T22:18:39  *** spinza has quit IRC
452 2018-12-04T22:18:48  *** mr_paz has quit IRC
453 2018-12-04T22:23:57  *** EagleTM has joined #bitcoin-core-dev
454 2018-12-04T22:24:07  *** Chris_Stewart_5 has quit IRC
455 2018-12-04T22:24:13  *** shesek has quit IRC
456 2018-12-04T22:24:30  *** Soksuci has joined #bitcoin-core-dev
457 2018-12-04T22:25:00  *** cubancorona has quit IRC
458 2018-12-04T22:25:06  *** Soksuci has left #bitcoin-core-dev
459 2018-12-04T22:25:24  *** shesek has joined #bitcoin-core-dev
460 2018-12-04T22:27:19  *** Th3Answer has quit IRC
461 2018-12-04T22:31:56  *** shesek has quit IRC
462 2018-12-04T22:32:23  *** shesek has joined #bitcoin-core-dev
463 2018-12-04T22:32:23  *** shesek has joined #bitcoin-core-dev
464 2018-12-04T22:36:07  *** tlindi has joined #bitcoin-core-dev
465 2018-12-04T22:36:35  *** spinza has joined #bitcoin-core-dev
466 2018-12-04T22:36:47  *** shesek has quit IRC
467 2018-12-04T22:39:39  *** shesek has joined #bitcoin-core-dev
468 2018-12-04T22:41:11  *** hrofu has quit IRC
469 2018-12-04T22:43:51  *** hrofu has joined #bitcoin-core-dev
470 2018-12-04T22:49:18  *** shesek has quit IRC
471 2018-12-04T22:50:31  *** jhfrontz has quit IRC
472 2018-12-04T22:50:41  *** shesek has joined #bitcoin-core-dev
473 2018-12-04T22:54:35  *** hrofu has quit IRC
474 2018-12-04T22:56:24  *** hrofu has joined #bitcoin-core-dev
475 2018-12-04T22:57:27  *** drexl has quit IRC
476 2018-12-04T22:57:28  *** esotericnonsense has quit IRC
477 2018-12-04T22:57:56  *** drexl has joined #bitcoin-core-dev
478 2018-12-04T22:58:57  *** esotericnonsense has joined #bitcoin-core-dev
479 2018-12-04T23:03:03  *** promag has joined #bitcoin-core-dev
480 2018-12-04T23:03:08  *** EagleTM has quit IRC
481 2018-12-04T23:03:20  *** shesek has quit IRC
482 2018-12-04T23:04:08  *** shesek has joined #bitcoin-core-dev
483 2018-12-04T23:04:48  *** jhfrontz has joined #bitcoin-core-dev
484 2018-12-04T23:04:50  *** hrofu has quit IRC
485 2018-12-04T23:05:10  *** hrofu has joined #bitcoin-core-dev
486 2018-12-04T23:05:30  *** shesek has quit IRC
487 2018-12-04T23:05:49  *** hrofu has joined #bitcoin-core-dev
488 2018-12-04T23:06:22  *** shesek has joined #bitcoin-core-dev
489 2018-12-04T23:08:20  *** queip has quit IRC
490 2018-12-04T23:08:46  *** rafalcpp has quit IRC
491 2018-12-04T23:19:33  *** rafalcpp has joined #bitcoin-core-dev
492 2018-12-04T23:21:01  *** Guyver2 has quit IRC
493 2018-12-04T23:23:20  *** jhfrontz has quit IRC
494 2018-12-04T23:25:28  *** queip has joined #bitcoin-core-dev
495 2018-12-04T23:26:01  *** shesek has quit IRC
496 2018-12-04T23:27:07  *** shesek has joined #bitcoin-core-dev
497 2018-12-04T23:27:07  *** shesek has joined #bitcoin-core-dev
498 2018-12-04T23:27:24  *** jhfrontz has joined #bitcoin-core-dev
499 2018-12-04T23:28:40  *** tlindi has quit IRC
500 2018-12-04T23:34:49  *** michaelsdunn1 has quit IRC
501 2018-12-04T23:41:38  *** promag has quit IRC
502 2018-12-04T23:42:49  *** booyah_ has joined #bitcoin-core-dev
503 2018-12-04T23:44:57  *** shesek has quit IRC
504 2018-12-04T23:44:58  *** booyah has quit IRC
505 2018-12-04T23:45:27  *** shesek has joined #bitcoin-core-dev
506 2018-12-04T23:45:35  *** shesek has joined #bitcoin-core-dev
507 2018-12-04T23:48:26  *** shesek has quit IRC
508 2018-12-04T23:49:47  *** shesek has joined #bitcoin-core-dev