1 2018-12-11T00:00:38  *** rafalcpp has quit IRC
  2 2018-12-11T00:01:22  *** rafalcpp has joined #bitcoin-core-dev
  3 2018-12-11T00:22:52  *** dgenr8 has joined #bitcoin-core-dev
  4 2018-12-11T00:24:42  *** miknotauro has joined #bitcoin-core-dev
  5 2018-12-11T00:27:34  *** dgenr8 has quit IRC
  6 2018-12-11T00:30:47  *** dgenr8 has joined #bitcoin-core-dev
  7 2018-12-11T00:38:16  *** hex17or has quit IRC
  8 2018-12-11T00:45:18  *** hex17or has joined #bitcoin-core-dev
  9 2018-12-11T00:56:43  *** shesek has quit IRC
 10 2018-12-11T00:57:39  *** shesek has joined #bitcoin-core-dev
 11 2018-12-11T01:03:35  *** Murch has quit IRC
 12 2018-12-11T01:16:01  *** rh0nj has quit IRC
 13 2018-12-11T01:19:09  *** rh0nj has joined #bitcoin-core-dev
 14 2018-12-11T01:24:25  *** dviola has quit IRC
 15 2018-12-11T01:26:01  *** rh0nj has quit IRC
 16 2018-12-11T01:27:08  *** rh0nj has joined #bitcoin-core-dev
 17 2018-12-11T01:27:22  *** _cryptosignal_me has joined #bitcoin-core-dev
 18 2018-12-11T01:38:51  *** promag has quit IRC
 19 2018-12-11T02:01:07  *** _cryptosignal_me has quit IRC
 20 2018-12-11T02:21:58  *** bsm117532 has quit IRC
 21 2018-12-11T02:36:55  *** bitcoin-git has joined #bitcoin-core-dev
 22 2018-12-11T02:36:56  <bitcoin-git> [bitcoin] AkioNak opened pull request #14919: test: Prevent "Duplicate-wallet filename specified" (master...confirm_unloadwallet_done) https://github.com/bitcoin/bitcoin/pull/14919
 23 2018-12-11T02:36:56  *** bitcoin-git has left #bitcoin-core-dev
 24 2018-12-11T02:57:47  *** keymone has quit IRC
 25 2018-12-11T03:03:26  *** AaronvanW has quit IRC
 26 2018-12-11T03:11:39  *** ghost43 has quit IRC
 27 2018-12-11T03:18:52  *** ghost43 has joined #bitcoin-core-dev
 28 2018-12-11T03:23:17  *** phwalkr has joined #bitcoin-core-dev
 29 2018-12-11T03:35:54  *** keymone has joined #bitcoin-core-dev
 30 2018-12-11T03:56:18  *** keymone has quit IRC
 31 2018-12-11T04:01:22  *** keymone has joined #bitcoin-core-dev
 32 2018-12-11T04:22:27  *** phwalkr has quit IRC
 33 2018-12-11T04:47:53  *** phwalkr has joined #bitcoin-core-dev
 34 2018-12-11T04:50:15  <jimpo> thanks for the reviews, jamesob!
 35 2018-12-11T04:50:49  <jamesob> jimpo: more to come. I want me some block filters!
 36 2018-12-11T04:54:35  *** Krellan has quit IRC
 37 2018-12-11T05:20:28  *** spinza has quit IRC
 38 2018-12-11T05:28:01  *** rh0nj has quit IRC
 39 2018-12-11T05:29:07  *** rh0nj has joined #bitcoin-core-dev
 40 2018-12-11T05:35:24  *** spinza has joined #bitcoin-core-dev
 41 2018-12-11T06:00:15  *** earthling has joined #bitcoin-core-dev
 42 2018-12-11T06:01:11  *** bitcoin-git has joined #bitcoin-core-dev
 43 2018-12-11T06:01:11  <bitcoin-git> [bitcoin] Empact opened pull request #14920: Build: enable -Wdocumentation via isystem (master...isystem) https://github.com/bitcoin/bitcoin/pull/14920
 44 2018-12-11T06:01:11  *** bitcoin-git has left #bitcoin-core-dev
 45 2018-12-11T06:01:16  *** earthling has quit IRC
 46 2018-12-11T06:02:24  *** miknotauro has quit IRC
 47 2018-12-11T06:12:44  *** hebasto has joined #bitcoin-core-dev
 48 2018-12-11T06:33:06  *** miknotauro has joined #bitcoin-core-dev
 49 2018-12-11T06:38:06  *** state_bits has quit IRC
 50 2018-12-11T06:40:51  *** state_bits has joined #bitcoin-core-dev
 51 2018-12-11T06:54:02  *** Krellan has joined #bitcoin-core-dev
 52 2018-12-11T07:00:18  *** Krellan has quit IRC
 53 2018-12-11T07:42:06  *** Randolf has joined #bitcoin-core-dev
 54 2018-12-11T07:42:51  *** Urgo has joined #bitcoin-core-dev
 55 2018-12-11T08:00:13  *** Krellan has joined #bitcoin-core-dev
 56 2018-12-11T08:03:54  *** Cory has quit IRC
 57 2018-12-11T08:09:11  *** Pasha has joined #bitcoin-core-dev
 58 2018-12-11T08:12:22  *** Pasha is now known as Cory
 59 2018-12-11T08:19:27  *** bgibson has quit IRC
 60 2018-12-11T08:21:27  *** ChA1NsAw has joined #bitcoin-core-dev
 61 2018-12-11T08:28:42  *** AcTiVaTe9 has joined #bitcoin-core-dev
 62 2018-12-11T08:33:12  *** AcTiVaTe9 has quit IRC
 63 2018-12-11T08:37:14  *** opdenkamp has joined #bitcoin-core-dev
 64 2018-12-11T08:49:28  *** bgibson has joined #bitcoin-core-dev
 65 2018-12-11T08:55:41  *** murrayn has quit IRC
 66 2018-12-11T09:03:08  *** Victorsueca has quit IRC
 67 2018-12-11T09:04:20  *** Victorsueca has joined #bitcoin-core-dev
 68 2018-12-11T09:27:30  *** Persopolis has joined #bitcoin-core-dev
 69 2018-12-11T09:30:42  *** Persopolis has quit IRC
 70 2018-12-11T09:49:54  *** hebasto has quit IRC
 71 2018-12-11T10:04:38  *** kexkey has quit IRC
 72 2018-12-11T10:10:42  *** spinza has quit IRC
 73 2018-12-11T10:12:44  *** hebasto has joined #bitcoin-core-dev
 74 2018-12-11T10:21:01  *** spinza has joined #bitcoin-core-dev
 75 2018-12-11T10:32:45  *** timothy has joined #bitcoin-core-dev
 76 2018-12-11T10:33:40  *** Zenton has quit IRC
 77 2018-12-11T10:39:28  <meshcollider> provoostenator: would you mind re-reviewing #14646 if you have some time
 78 2018-12-11T10:39:31  <gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
 79 2018-12-11T10:43:55  *** Zenton has joined #bitcoin-core-dev
 80 2018-12-11T10:52:31  *** Zenton has quit IRC
 81 2018-12-11T10:56:21  <wumpus> rc1 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.17.1/test.rc1/
 82 2018-12-11T10:58:42  *** belcher has quit IRC
 83 2018-12-11T11:03:25  *** belcher has joined #bitcoin-core-dev
 84 2018-12-11T11:06:26  *** Zenton has joined #bitcoin-core-dev
 85 2018-12-11T11:09:40  *** fanquake has joined #bitcoin-core-dev
 86 2018-12-11T11:10:48  <fanquake> wumpus only 2 signed sigs? Or haven't you pushed yours up
 87 2018-12-11T11:11:29  <wumpus> yes, I still have to upload mine
 88 2018-12-11T11:11:36  <wumpus> thanks for remindingm e
 89 2018-12-11T11:13:16  <fanquake> np
 90 2018-12-11T11:21:07  *** miknotauro has quit IRC
 91 2018-12-11T11:23:24  <provoostenator> I'm rebuilding my unsigned ones first because it was complaining about "cp: cannot stat 'inputs/bitcoin-0.17.1rc1-win-unsigned.tar.gz"
 92 2018-12-11T11:23:37  <provoostenator> (just copied a neweer version of gitian-build.py
 93 2018-12-11T11:30:24  *** shesek has quit IRC
 94 2018-12-11T11:31:12  *** shesek has joined #bitcoin-core-dev
 95 2018-12-11T11:31:12  *** shesek has joined #bitcoin-core-dev
 96 2018-12-11T11:31:27  *** shesek has quit IRC
 97 2018-12-11T11:32:50  *** shesek has joined #bitcoin-core-dev
 98 2018-12-11T11:33:41  <provoostenator> Happy to review 13646 again. Can someone remind me of the git incantation to see what changed relative to my 94677cc utACK? (assuming I still have it locally)
 99 2018-12-11T11:35:45  *** promag has joined #bitcoin-core-dev
100 2018-12-11T11:36:02  <wumpus> if you just want to see the difference since then: git diff 94677cc
101 2018-12-11T11:38:28  <wumpus> this will work okay if either commits were added since then, or commits were squashed/reorganized in place. As it is the total diff that includes the difference in base commits it's not useful to review a rebase.
102 2018-12-11T11:38:43  <wumpus> for reviewing a rebase*
103 2018-12-11T11:48:16  *** AaronvanW has joined #bitcoin-core-dev
104 2018-12-11T11:57:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
105 2018-12-11T12:02:30  <fanquake> Chris_Stewart_5 is rapidcheck work essentially blocked on upstream?
106 2018-12-11T12:03:48  *** spinza has quit IRC
107 2018-12-11T12:09:07  <Chris_Stewart_5> fanquake: I haven't had time to track down the root cause. Does it appear that memory access violation is happening in rapidcheck?
108 2018-12-11T12:12:22  <fanquake> Chris_Stewart_5 Yes I think so. The bitcoin related test which is failing seems too simple? to be the cause.
109 2018-12-11T12:13:13  *** ppisati has quit IRC
110 2018-12-11T12:19:07  *** CodeBlue1776 has quit IRC
111 2018-12-11T12:20:01  *** CodeBlue1776 has joined #bitcoin-core-dev
112 2018-12-11T12:20:18  *** ppisati has joined #bitcoin-core-dev
113 2018-12-11T12:20:43  *** bitcoin-git has joined #bitcoin-core-dev
114 2018-12-11T12:20:44  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14922: windows: Set_WIN32_WINNT to 0x0601 (Windows 7) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14922
115 2018-12-11T12:20:44  *** bitcoin-git has left #bitcoin-core-dev
116 2018-12-11T12:21:13  *** fanquake has quit IRC
117 2018-12-11T12:23:08  <Chris_Stewart_5> Yes I think it must be. I guess i could remove the test  since all of the other ones seems to pass and we can merge that PR.
118 2018-12-11T12:23:29  *** spinza has joined #bitcoin-core-dev
119 2018-12-11T12:28:47  *** spinza has quit IRC
120 2018-12-11T12:33:31  *** fanquake has joined #bitcoin-core-dev
121 2018-12-11T12:38:36  <promag> Does it make sense dynamic maxtxfee?
122 2018-12-11T12:39:08  <promag> currently it requires a restart?
123 2018-12-11T12:45:03  <wumpus> do we still support windows vista or not? I'm confused (re: #14922)
124 2018-12-11T12:45:05  <gribble> https://github.com/bitcoin/bitcoin/issues/14922 | windows: Set _WIN32_WINNT to 0x0600 (Windows Vista) by ken2812221 · Pull Request #14922 · bitcoin/bitcoin · GitHub
125 2018-12-11T12:45:29  <wumpus> apparently Randolf removed mention of it from the compatibility notes in the release notes
126 2018-12-11T12:45:33  <wumpus> in #12546
127 2018-12-11T12:45:35  <gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility Notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub
128 2018-12-11T12:46:30  <wumpus> for lack of testing on that version I think it makes sense, but, well, I don't think we've ever discussed it
129 2018-12-11T12:47:00  <promag> vista is not supported by microsoft since april 2017
130 2018-12-11T12:47:08  *** Chris_Stewart_5 has quit IRC
131 2018-12-11T12:47:11  <wumpus> ok
132 2018-12-11T12:47:59  <wumpus> which suggests that we shouldn't either
133 2018-12-11T12:48:02  <fanquake> I'd be surprised if anyone is testing on vista at all.
134 2018-12-11T12:48:19  <promag> even win7?
135 2018-12-11T12:49:29  <fanquake> qt 5.12 will still support win7, so I think we should try and keep compat for now
136 2018-12-11T12:49:57  <promag> https://support.microsoft.com/en-us/help/13853/windows-lifecycle-fact-sheet
137 2018-12-11T12:50:16  <promag> yap
138 2018-12-11T12:50:34  <fanquake> So we should only support Windows 10?
139 2018-12-11T12:51:03  <fanquake> and essentially > 1709
140 2018-12-11T12:51:18  <wumpus> no, I'd say we should support win7
141 2018-12-11T12:51:23  <wumpus> many people are still using that
142 2018-12-11T12:52:01  <fanquake> Potentially larger issue is qts removal of support for "old" macOS versions. 5.12 is 10.12+
143 2018-12-11T12:52:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
144 2018-12-11T12:52:59  <promag> we are far from min qt 5.12
145 2018-12-11T12:53:21  <fanquake> It doesn't have to be min, just being able to use in depends
146 2018-12-11T12:53:34  *** shesek has quit IRC
147 2018-12-11T12:53:59  <fanquake> I'd like to try and use 5.12 (LTS) for 0.18.0
148 2018-12-11T12:54:23  <promag> it fixes some macos issues AFAIK
149 2018-12-11T12:54:36  <fanquake> and backport the last 5.9.x (LTS) point release to 0.17.x
150 2018-12-11T12:55:16  *** shesek has joined #bitcoin-core-dev
151 2018-12-11T12:56:12  <Chris_Stewart_5> fanquake: Sorry lost connection, thoughts on just removing that test for now? Like you said it is a very simple test
152 2018-12-11T12:56:52  <promag> provoostenator: added new screenshot to #14573
153 2018-12-11T12:56:54  <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
154 2018-12-11T12:57:24  <promag> provoostenator: I'll push in a bit
155 2018-12-11T12:57:41  *** shesek has quit IRC
156 2018-12-11T12:58:12  *** shesek has joined #bitcoin-core-dev
157 2018-12-11T12:58:15  <fanquake> Chris_Stewart_5 possibly, if you just want to be able to merge #14853 (assuming no other tests fail) in a similar way. I can test later tonight.
158 2018-12-11T12:58:17  <gribble> https://github.com/bitcoin/bitcoin/issues/14853 | [wip] depends: latest rapidcheck, enable property based tests on Travis by fanquake · Pull Request #14853 · bitcoin/bitcoin · GitHub
159 2018-12-11T12:59:02  <fanquake> When I tried compiling #14430 I ran into some other, potentially related, issues.
160 2018-12-11T12:59:05  <gribble> https://github.com/bitcoin/bitcoin/issues/14430 | Add more property based tests for basic bitcoin data structures by Christewart · Pull Request #14430 · bitcoin/bitcoin · GitHub
161 2018-12-11T13:10:02  *** rh0nj has quit IRC
162 2018-12-11T13:10:28  <Chris_Stewart_5> fanquake: I believe the issues with #14430 where from not having the EXTRAS module installed from rapidcheck? At least I believe that was MarcoFalke's problem with #14171
163 2018-12-11T13:10:31  <gribble> https://github.com/bitcoin/bitcoin/issues/14430 | Add more property based tests for basic bitcoin data structures by Christewart · Pull Request #14430 · bitcoin/bitcoin · GitHub
164 2018-12-11T13:10:32  <gribble> https://github.com/bitcoin/bitcoin/issues/14171 | travis: Run property based testing by MarcoFalke · Pull Request #14171 · bitcoin/bitcoin · GitHub
165 2018-12-11T13:11:38  <fanquake> Chris_Stewart_5 I've tried compiling ontop of the new PR, and was seeing compilation problems, some output here: https://github.com/bitcoin/bitcoin/pull/14430#issuecomment-443400827
166 2018-12-11T13:13:12  *** Randolf has quit IRC
167 2018-12-11T13:13:24  <Chris_Stewart_5> fanquake: Actually looking closer it appears there are two different properties failing between 14171 and 14430 'key_sign_symmetry' and 'key_set_symmetry'
168 2018-12-11T13:14:22  <Chris_Stewart_5> Interesting, i missed that comment
169 2018-12-11T13:15:17  <Chris_Stewart_5> did we bump to c++14?
170 2018-12-11T13:17:40  *** promag has quit IRC
171 2018-12-11T13:18:01  <wumpus> Chris_Stewart_5: no
172 2018-12-11T13:18:08  <fanquake> Chris_Stewart_5 No, maybe for 0.19.0 #13356
173 2018-12-11T13:18:09  <gribble> https://github.com/bitcoin/bitcoin/issues/13356 | RFC: C++14 Requirement · Issue #13356 · bitcoin/bitcoin · GitHub
174 2018-12-11T13:21:38  <fanquake> If anyones interested, while doing rc1 testing, I'll be adding bitcoin-core vm setups to a Vagrantfile here: https://github.com/fanquake/core-review/tree/master/vagrant
175 2018-12-11T13:22:06  <fanquake> A lot of my vm setup/testing had been pretty manual using virtualbox, so I've decided to try and automate it further.
176 2018-12-11T13:23:18  <fanquake> For ex, make it's fairly easy to github-merge a PR, then "spin up" an openBSD vm, with core dependencies/debugging tools already available, and have the code sitting inside.
177 2018-12-11T13:25:00  <Chris_Stewart_5> That can be used for more generalized testing, i.e. rapid check stuff right? Is there much of a difference between this and using docker?
178 2018-12-11T13:26:05  <provoostenator> wumpus: thanks. Indeed I want to review the rebase, which involves slightly more magic
179 2018-12-11T13:27:17  <fanquake> Chris_Stewart_5 Yea. I did use Docker directly to recreate Travis for the rapidcheck debugging, but decided to use vagrant here, as it sits "above" virtualbox, docker etc
180 2018-12-11T13:28:15  <Chris_Stewart_5> Interesting. I probably won't get around to testing until this weekend but I'll give it a try.
181 2018-12-11T13:30:47  <provoostenator> Stack Overflow to the rescue: git commit-tree HEAD^{tree} -p 94677cc -p HEAD~5 -m "Rebase changes since 94677cc" && git show
182 2018-12-11T13:30:57  <provoostenator> Where 5 is the number of commits in the PR
183 2018-12-11T13:34:17  *** shesek has quit IRC
184 2018-12-11T13:35:37  *** shesek has joined #bitcoin-core-dev
185 2018-12-11T13:36:50  *** jaibitcoin has joined #bitcoin-core-dev
186 2018-12-11T13:38:22  *** ap4lmtree has quit IRC
187 2018-12-11T13:38:55  <provoostenator> (neh, I don't think that worked, I'll leave a comment on the PR once I find it)
188 2018-12-11T13:39:50  *** shesek has quit IRC
189 2018-12-11T13:40:25  *** ap4lmtree has joined #bitcoin-core-dev
190 2018-12-11T13:41:38  *** shesek has joined #bitcoin-core-dev
191 2018-12-11T13:42:46  *** shesek has quit IRC
192 2018-12-11T13:43:22  <provoostenator> Ah, it's: git show ` git commit-tree ...`
193 2018-12-11T13:46:22  *** jaibitcoin has quit IRC
194 2018-12-11T13:49:30  *** shesek has joined #bitcoin-core-dev
195 2018-12-11T13:49:30  *** shesek has joined #bitcoin-core-dev
196 2018-12-11T13:54:12  *** Chris_Stewart_5 has quit IRC
197 2018-12-11T14:00:37  *** elichai2 has joined #bitcoin-core-dev
198 2018-12-11T14:07:34  *** Guyver2 has joined #bitcoin-core-dev
199 2018-12-11T14:30:22  <fanquake> Chris_Stewart_5 I've just pushed up a travis vm definition: https://github.com/fanquake/core-review/commit/26032d6bdcdf7e928f8ce22c97e29c9846b39d59
200 2018-12-11T14:31:29  <fanquake> If you do a github-merge 14853, then vagrant up travis-linux-no-depends-qt
201 2018-12-11T14:32:01  *** shesek has quit IRC
202 2018-12-11T14:32:04  <fanquake> At the end you can ssh into the box, and run gdb --args src/test/test_bitcoin --log_level=all --run_test=key_properties
203 2018-12-11T14:32:33  <fanquake> then "run", "thread apply bt all" and it'll give you the backtrace you're after
204 2018-12-11T14:32:43  *** shesek has joined #bitcoin-core-dev
205 2018-12-11T14:42:58  *** promag has joined #bitcoin-core-dev
206 2018-12-11T14:42:59  *** shesek has quit IRC
207 2018-12-11T14:43:53  *** shesek has joined #bitcoin-core-dev
208 2018-12-11T14:53:09  *** xdash has joined #bitcoin-core-dev
209 2018-12-11T14:55:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
210 2018-12-11T14:57:24  *** drexl has quit IRC
211 2018-12-11T14:59:22  *** promag has quit IRC
212 2018-12-11T15:13:25  *** promag has joined #bitcoin-core-dev
213 2018-12-11T15:17:36  *** shesek has quit IRC
214 2018-12-11T15:18:26  *** shesek has joined #bitcoin-core-dev
215 2018-12-11T15:18:26  *** shesek has joined #bitcoin-core-dev
216 2018-12-11T15:27:11  *** promag has quit IRC
217 2018-12-11T15:32:07  *** jarthur has joined #bitcoin-core-dev
218 2018-12-11T15:34:09  *** promag has joined #bitcoin-core-dev
219 2018-12-11T15:36:17  *** michaelsdunn1 has joined #bitcoin-core-dev
220 2018-12-11T15:36:34  *** promag has quit IRC
221 2018-12-11T15:50:40  *** Chris_Stewart_5 has quit IRC
222 2018-12-11T16:11:00  *** shesek has quit IRC
223 2018-12-11T16:13:32  *** dqx has quit IRC
224 2018-12-11T16:13:44  *** shesek has joined #bitcoin-core-dev
225 2018-12-11T16:15:07  *** miknotauro has joined #bitcoin-core-dev
226 2018-12-11T16:19:40  *** shesek has quit IRC
227 2018-12-11T16:20:24  *** shesek has joined #bitcoin-core-dev
228 2018-12-11T16:20:24  *** shesek has joined #bitcoin-core-dev
229 2018-12-11T16:24:15  <wumpus> fanquake: that seems very useful, I'm still mostly using manual testing in VMs too, can be a hassle sometimes especially when the VMs need to be upgraded, would be good to automate
230 2018-12-11T16:25:13  <wumpus> provoostenator: good to know
231 2018-12-11T16:26:19  <provoostenator> wumpus: actually that didn't work either. I left a git range-diff incantation on the PR, though the diff is too big to be useful.
232 2018-12-11T16:28:32  *** shesek has quit IRC
233 2018-12-11T16:28:52  <wumpus> provoostenator: what I usually do is manually repeat the rebase (on a temporary branch), then compare against the author's, it's a lot of hassle though especially the rebase doesn't go cleanup
234 2018-12-11T16:28:59  <wumpus> cleanly*
235 2018-12-11T16:29:08  *** shesek has joined #bitcoin-core-dev
236 2018-12-11T16:31:19  <wumpus> I'd hoped there was a cleaner/faster way but seems not
237 2018-12-11T16:33:19  *** shesek has quit IRC
238 2018-12-11T16:33:49  *** shesek has joined #bitcoin-core-dev
239 2018-12-11T16:36:58  <provoostenator> git range-diff `git merge-base --all HEAD 94677cc `... 94677cc HEAD~5...HEAD
240 2018-12-11T16:37:51  <provoostenator> Though it takes Matrix level reading skills to understand the result often.
241 2018-12-11T16:39:24  *** miknotauro has quit IRC
242 2018-12-11T16:40:07  *** rh0nj has joined #bitcoin-core-dev
243 2018-12-11T16:48:26  <fanquake> wumpus I added some example usage docs, https://github.com/fanquake/core-review/tree/master/vagrant#testing-pull-requests , will add more vms this week.
244 2018-12-11T16:55:38  *** fanquake has quit IRC
245 2018-12-11T17:02:09  <provoostenator> I annotated a range-diff for a simpler commit #14573, though I suspect there's a better way...
246 2018-12-11T17:02:11  <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
247 2018-12-11T17:04:35  *** Krellan has quit IRC
248 2018-12-11T17:15:49  *** shesek has quit IRC
249 2018-12-11T17:16:28  *** shesek has joined #bitcoin-core-dev
250 2018-12-11T17:17:24  *** shesek has quit IRC
251 2018-12-11T17:18:09  *** shesek has joined #bitcoin-core-dev
252 2018-12-11T17:20:09  *** Murch has joined #bitcoin-core-dev
253 2018-12-11T17:25:14  <meshcollider> If anyone has some time, #14886 review would be very appreciated so we can get it merged, a lot depends on it
254 2018-12-11T17:25:16  <gribble> https://github.com/bitcoin/bitcoin/issues/14886 | [tests] Refactor importmulti tests by jnewbery · Pull Request #14886 · bitcoin/bitcoin · GitHub
255 2018-12-11T17:30:05  *** promag has joined #bitcoin-core-dev
256 2018-12-11T17:39:55  *** shesek has quit IRC
257 2018-12-11T17:40:38  *** shesek has joined #bitcoin-core-dev
258 2018-12-11T17:46:53  <promag> can I have #14573 in HP?
259 2018-12-11T17:46:55  <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
260 2018-12-11T17:51:51  *** shesek has quit IRC
261 2018-12-11T17:54:01  *** shesek has joined #bitcoin-core-dev
262 2018-12-11T18:01:36  *** spinza has joined #bitcoin-core-dev
263 2018-12-11T18:04:25  *** shesek has quit IRC
264 2018-12-11T18:06:00  *** shesek has joined #bitcoin-core-dev
265 2018-12-11T18:06:00  *** shesek has joined #bitcoin-core-dev
266 2018-12-11T18:06:36  *** shesek has quit IRC
267 2018-12-11T18:07:07  *** shesek has joined #bitcoin-core-dev
268 2018-12-11T18:07:14  *** promag has quit IRC
269 2018-12-11T18:16:17  *** Aaronvan_ has joined #bitcoin-core-dev
270 2018-12-11T18:16:28  *** Urgo has quit IRC
271 2018-12-11T18:19:57  *** AaronvanW has quit IRC
272 2018-12-11T18:24:10  *** shesek has quit IRC
273 2018-12-11T18:24:50  *** shesek has joined #bitcoin-core-dev
274 2018-12-11T18:24:50  *** shesek has joined #bitcoin-core-dev
275 2018-12-11T18:24:58  *** bitcoin-git has joined #bitcoin-core-dev
276 2018-12-11T18:24:59  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14925: test: Correctly deserialize without witness (master...Mf1812-testWitnessDeser) https://github.com/bitcoin/bitcoin/pull/14925
277 2018-12-11T18:24:59  *** bitcoin-git has left #bitcoin-core-dev
278 2018-12-11T18:26:32  *** shesek has quit IRC
279 2018-12-11T18:27:19  *** shesek has joined #bitcoin-core-dev
280 2018-12-11T18:29:12  *** shesek has quit IRC
281 2018-12-11T18:29:20  *** spinza has quit IRC
282 2018-12-11T18:31:28  *** shesek has joined #bitcoin-core-dev
283 2018-12-11T18:31:28  *** shesek has joined #bitcoin-core-dev
284 2018-12-11T18:35:24  *** Krellan has joined #bitcoin-core-dev
285 2018-12-11T18:35:38  *** shesek has quit IRC
286 2018-12-11T18:36:39  *** rex4539 has quit IRC
287 2018-12-11T18:37:48  *** shesek has joined #bitcoin-core-dev
288 2018-12-11T18:37:57  *** bitcoin-git has joined #bitcoin-core-dev
289 2018-12-11T18:37:58  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14926: test: consensus: Check that final transactions are valid (master...Mf1812-testConsensusFinal) https://github.com/bitcoin/bitcoin/pull/14926
290 2018-12-11T18:37:58  *** bitcoin-git has left #bitcoin-core-dev
291 2018-12-11T18:41:22  *** spinza has joined #bitcoin-core-dev
292 2018-12-11T18:42:04  *** shesek has quit IRC
293 2018-12-11T18:43:14  *** shesek has joined #bitcoin-core-dev
294 2018-12-11T18:43:14  *** shesek has joined #bitcoin-core-dev
295 2018-12-11T18:44:06  *** Krellan has quit IRC
296 2018-12-11T18:44:10  *** bitcoin-git has joined #bitcoin-core-dev
297 2018-12-11T18:44:11  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5f23460c7e31...d680ef9381b4
298 2018-12-11T18:44:11  <bitcoin-git> bitcoin/master 522b80b qubenix: add `--retry 5` to curl opts in install_db4.sh
299 2018-12-11T18:44:12  <bitcoin-git> bitcoin/master d680ef9 MarcoFalke: Merge #14883: add `--retry 5` to curl opts in install_db4.sh...
300 2018-12-11T18:44:12  *** bitcoin-git has left #bitcoin-core-dev
301 2018-12-11T18:45:05  *** timothy has quit IRC
302 2018-12-11T18:45:09  *** bitcoin-git has joined #bitcoin-core-dev
303 2018-12-11T18:45:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14883: add `--retry 5` to curl opts in install_db4.sh (master...qubenix-curl-retry) https://github.com/bitcoin/bitcoin/pull/14883
304 2018-12-11T18:45:09  *** bitcoin-git has left #bitcoin-core-dev
305 2018-12-11T18:46:04  *** bitcoin-git has joined #bitcoin-core-dev
306 2018-12-11T18:46:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d680ef9381b4...7701b62561c4
307 2018-12-11T18:46:05  <bitcoin-git> bitcoin/master 0dcac51 Gregory Sanders: wallet_keypool_topup.py: Test for all keypool address types
308 2018-12-11T18:46:06  <bitcoin-git> bitcoin/master 7701b62 MarcoFalke: Merge #14857: wallet_keypool_topup.py: Test for all keypool address types...
309 2018-12-11T18:46:06  *** bitcoin-git has left #bitcoin-core-dev
310 2018-12-11T18:46:50  *** bitcoin-git has joined #bitcoin-core-dev
311 2018-12-11T18:46:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14857: wallet_keypool_topup.py: Test for all keypool address types (master...keypool_topup_addresstype) https://github.com/bitcoin/bitcoin/pull/14857
312 2018-12-11T18:46:50  *** bitcoin-git has left #bitcoin-core-dev
313 2018-12-11T18:49:12  *** miknotauro has joined #bitcoin-core-dev
314 2018-12-11T18:54:15  *** CodeBlue1776 has quit IRC
315 2018-12-11T18:54:32  *** CodeBlue1776 has joined #bitcoin-core-dev
316 2018-12-11T18:57:40  *** bitcoin-git has joined #bitcoin-core-dev
317 2018-12-11T18:57:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/7701b62561c4...f65bce858f26
318 2018-12-11T18:57:41  <bitcoin-git> bitcoin/master cb41ade John Newbery: [tests] fix flake8 warnings in wallet_importmulti.py
319 2018-12-11T18:57:42  <bitcoin-git> bitcoin/master e5a8ea8 John Newbery: [tests] tidy up imports in wallet_importmulti.py
320 2018-12-11T18:57:42  <bitcoin-git> bitcoin/master 7c99614 John Newbery: [tests] add get_key function to wallet_importmulti.py...
321 2018-12-11T18:57:43  *** bitcoin-git has left #bitcoin-core-dev
322 2018-12-11T18:58:14  *** bitcoin-git has joined #bitcoin-core-dev
323 2018-12-11T18:58:15  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14886: [tests] Refactor importmulti tests (master...importmulti_tests) https://github.com/bitcoin/bitcoin/pull/14886
324 2018-12-11T18:58:15  *** bitcoin-git has left #bitcoin-core-dev
325 2018-12-11T19:00:46  *** shesek has quit IRC
326 2018-12-11T19:01:40  *** shesek has joined #bitcoin-core-dev
327 2018-12-11T19:06:19  *** Victorsueca has quit IRC
328 2018-12-11T19:07:36  *** Victorsueca has joined #bitcoin-core-dev
329 2018-12-11T19:10:01  *** rex4539 has joined #bitcoin-core-dev
330 2018-12-11T19:24:09  *** xdash has quit IRC
331 2018-12-11T19:26:06  *** shesek has quit IRC
332 2018-12-11T19:27:03  *** shesek has joined #bitcoin-core-dev
333 2018-12-11T19:27:03  *** shesek has joined #bitcoin-core-dev
334 2018-12-11T19:28:50  *** miknotauro has quit IRC
335 2018-12-11T19:31:46  *** shesek has quit IRC
336 2018-12-11T19:32:51  *** shesek has joined #bitcoin-core-dev
337 2018-12-11T19:32:51  *** shesek has joined #bitcoin-core-dev
338 2018-12-11T19:38:33  *** michaelsdunn1 has quit IRC
339 2018-12-11T19:41:55  *** miknotauro has joined #bitcoin-core-dev
340 2018-12-11T19:42:17  *** michaelsdunn1 has joined #bitcoin-core-dev
341 2018-12-11T19:47:14  *** michaelsdunn1 has quit IRC
342 2018-12-11T19:49:20  *** michaelsdunn1 has joined #bitcoin-core-dev
343 2018-12-11T19:51:13  *** miknotauro has quit IRC
344 2018-12-11T19:52:09  *** elichai2 has quit IRC
345 2018-12-11T19:54:04  *** michaelsdunn1 has quit IRC
346 2018-12-11T19:54:36  *** shesek has quit IRC
347 2018-12-11T19:55:24  *** Krellan has joined #bitcoin-core-dev
348 2018-12-11T19:55:45  *** shesek has joined #bitcoin-core-dev
349 2018-12-11T19:55:54  *** michaelsdunn1 has joined #bitcoin-core-dev
350 2018-12-11T20:04:07  *** miknotauro has joined #bitcoin-core-dev
351 2018-12-11T20:08:16  *** michaels_ has joined #bitcoin-core-dev
352 2018-12-11T20:09:27  *** promag has joined #bitcoin-core-dev
353 2018-12-11T20:11:40  *** michaelsdunn1 has quit IRC
354 2018-12-11T20:16:11  *** Nazo has joined #bitcoin-core-dev
355 2018-12-11T20:16:39  *** miknotauro has quit IRC
356 2018-12-11T20:19:41  *** Nazo has quit IRC
357 2018-12-11T20:21:42  *** Aaronvan_ has quit IRC
358 2018-12-11T20:22:10  *** AaronvanW has joined #bitcoin-core-dev
359 2018-12-11T20:22:47  *** hebasto has quit IRC
360 2018-12-11T20:27:02  *** shesek has quit IRC
361 2018-12-11T20:28:23  *** shesek has joined #bitcoin-core-dev
362 2018-12-11T20:30:42  *** miknotauro has joined #bitcoin-core-dev
363 2018-12-11T20:32:32  *** michaels_ has quit IRC
364 2018-12-11T20:33:59  *** michaelsdunn1 has joined #bitcoin-core-dev
365 2018-12-11T20:35:45  *** Krellan has quit IRC
366 2018-12-11T20:36:20  *** Krellan has joined #bitcoin-core-dev
367 2018-12-11T20:37:33  *** Krellan has quit IRC
368 2018-12-11T20:38:10  *** Krellan has joined #bitcoin-core-dev
369 2018-12-11T20:38:31  *** shesek has quit IRC
370 2018-12-11T20:39:34  *** shesek has joined #bitcoin-core-dev
371 2018-12-11T20:39:34  *** shesek has joined #bitcoin-core-dev
372 2018-12-11T20:44:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
373 2018-12-11T20:56:36  *** michaelsdunn1 has quit IRC
374 2018-12-11T20:58:42  *** michaelsdunn1 has joined #bitcoin-core-dev
375 2018-12-11T20:58:42  *** michaelsdunn1 has quit IRC
376 2018-12-11T20:58:42  *** michaelsdunn1 has joined #bitcoin-core-dev
377 2018-12-11T21:05:48  *** shesek has quit IRC
378 2018-12-11T21:06:34  *** shesek has joined #bitcoin-core-dev
379 2018-12-11T21:08:07  *** promag has quit IRC
380 2018-12-11T21:11:32  *** luke-jr has quit IRC
381 2018-12-11T21:12:00  *** miknotauro has quit IRC
382 2018-12-11T21:13:01  *** shesek has quit IRC
383 2018-12-11T21:13:34  *** csknk has joined #bitcoin-core-dev
384 2018-12-11T21:14:41  *** bitcoin-git has joined #bitcoin-core-dev
385 2018-12-11T21:14:42  <bitcoin-git> [bitcoin] gmaxwell opened pull request #14929: Allow connections from misbehavior banned peers. (master...201812-softbanmisbehaving) https://github.com/bitcoin/bitcoin/pull/14929
386 2018-12-11T21:14:42  *** bitcoin-git has left #bitcoin-core-dev
387 2018-12-11T21:15:21  *** chubas has joined #bitcoin-core-dev
388 2018-12-11T21:15:34  *** shesek has joined #bitcoin-core-dev
389 2018-12-11T21:15:34  *** shesek has joined #bitcoin-core-dev
390 2018-12-11T21:16:52  *** csknk has quit IRC
391 2018-12-11T21:18:07  *** shesek has quit IRC
392 2018-12-11T21:19:49  *** shesek has joined #bitcoin-core-dev
393 2018-12-11T21:20:39  *** promag has joined #bitcoin-core-dev
394 2018-12-11T21:23:19  *** luke-jr has joined #bitcoin-core-dev
395 2018-12-11T21:31:44  *** Krellan has quit IRC
396 2018-12-11T21:39:49  *** Krellan has joined #bitcoin-core-dev
397 2018-12-11T21:41:01  *** Guyver2 has quit IRC
398 2018-12-11T21:41:10  *** chubas has quit IRC
399 2018-12-11T21:47:45  *** promag has quit IRC
400 2018-12-11T21:49:37  *** fabianfabian has joined #bitcoin-core-dev
401 2018-12-11T22:05:46  *** spinza has quit IRC
402 2018-12-11T22:08:44  *** spinza has joined #bitcoin-core-dev
403 2018-12-11T22:09:52  *** drexl has joined #bitcoin-core-dev
404 2018-12-11T22:15:43  *** shesek has quit IRC
405 2018-12-11T22:16:50  *** shesek has joined #bitcoin-core-dev
406 2018-12-11T22:16:50  *** shesek has joined #bitcoin-core-dev
407 2018-12-11T22:22:44  *** shesek has quit IRC
408 2018-12-11T22:23:58  *** shesek has joined #bitcoin-core-dev
409 2018-12-11T22:23:58  *** shesek has joined #bitcoin-core-dev
410 2018-12-11T22:24:54  <meshcollider> promag: done
411 2018-12-11T22:27:45  *** jarthur has quit IRC
412 2018-12-11T22:33:02  *** shesek has quit IRC
413 2018-12-11T22:34:31  *** shesek has joined #bitcoin-core-dev
414 2018-12-11T22:36:04  *** Krellan has quit IRC
415 2018-12-11T22:38:50  *** shesek has quit IRC
416 2018-12-11T22:39:51  *** shesek has joined #bitcoin-core-dev
417 2018-12-11T22:40:40  *** shesek has quit IRC
418 2018-12-11T22:41:48  *** shesek has joined #bitcoin-core-dev
419 2018-12-11T22:41:48  *** shesek has joined #bitcoin-core-dev
420 2018-12-11T22:42:17  *** qu4ku has joined #bitcoin-core-dev
421 2018-12-11T22:42:34  *** shesek has quit IRC
422 2018-12-11T22:43:53  *** shesek has joined #bitcoin-core-dev
423 2018-12-11T22:55:06  *** CubicEarth has quit IRC
424 2018-12-11T22:59:50  *** michaelsdunn1 has quit IRC
425 2018-12-11T23:02:36  *** state_bits has quit IRC
426 2018-12-11T23:02:44  *** state_bits has joined #bitcoin-core-dev
427 2018-12-11T23:04:50  *** promag has joined #bitcoin-core-dev
428 2018-12-11T23:17:48  *** owowo has quit IRC
429 2018-12-11T23:34:11  *** Emcy has quit IRC
430 2018-12-11T23:34:49  *** Emcy has joined #bitcoin-core-dev
431 2018-12-11T23:39:02  *** shesek has quit IRC
432 2018-12-11T23:42:38  *** shesek has joined #bitcoin-core-dev
433 2018-12-11T23:47:22  *** shesek has quit IRC
434 2018-12-11T23:50:45  *** kinlo has quit IRC
435 2018-12-11T23:50:47  *** Chris_Stewart_5 has quit IRC
436 2018-12-11T23:55:44  *** fabianfabian has quit IRC
437 2018-12-11T23:55:52  *** Krellan has joined #bitcoin-core-dev
438 2018-12-11T23:57:35  *** shesek has joined #bitcoin-core-dev
439 2018-12-11T23:58:03  <promag> thanks meshcollider