1 2018-12-12T00:00:21  *** miknotauro has joined #bitcoin-core-dev
  2 2018-12-12T00:05:44  *** ChA1NsAw has quit IRC
  3 2018-12-12T00:08:28  *** miknotauro has quit IRC
  4 2018-12-12T00:09:14  *** shesek has quit IRC
  5 2018-12-12T00:09:53  *** kinlo has joined #bitcoin-core-dev
  6 2018-12-12T00:11:00  *** bitcoin-git has joined #bitcoin-core-dev
  7 2018-12-12T00:11:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14930: test: pruning: Check that verifychain can be called when pruned (master...Mf1812-testPruneVerify) https://github.com/bitcoin/bitcoin/pull/14930
  8 2018-12-12T00:11:00  *** bitcoin-git has left #bitcoin-core-dev
  9 2018-12-12T00:12:40  *** shesek has joined #bitcoin-core-dev
 10 2018-12-12T00:12:40  *** shesek has quit IRC
 11 2018-12-12T00:12:40  *** shesek has joined #bitcoin-core-dev
 12 2018-12-12T00:18:06  <promag> MarcoFalke: I'd like that wallet :P
 13 2018-12-12T00:29:52  *** shesek has quit IRC
 14 2018-12-12T00:41:29  *** promag has quit IRC
 15 2018-12-12T00:41:39  *** dviola has joined #bitcoin-core-dev
 16 2018-12-12T00:59:36  *** Murch has quit IRC
 17 2018-12-12T01:11:15  *** Aaronvan_ has joined #bitcoin-core-dev
 18 2018-12-12T01:11:27  *** AaronvanW has quit IRC
 19 2018-12-12T01:24:13  *** qu4ku has quit IRC
 20 2018-12-12T01:35:27  *** Aaronvan_ has quit IRC
 21 2018-12-12T01:42:11  *** AaronvanW has joined #bitcoin-core-dev
 22 2018-12-12T01:43:35  *** AaronvanW has quit IRC
 23 2018-12-12T01:43:52  *** AaronvanW has joined #bitcoin-core-dev
 24 2018-12-12T01:46:01  *** rh0nj has quit IRC
 25 2018-12-12T01:48:38  *** bitcoin-git has joined #bitcoin-core-dev
 26 2018-12-12T01:48:38  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14931: test: mempool_persist: Verify prioritization is dumped correctly (master...Mf1812-testMempoolPrio) https://github.com/bitcoin/bitcoin/pull/14931
 27 2018-12-12T01:48:38  *** bitcoin-git has left #bitcoin-core-dev
 28 2018-12-12T01:49:07  *** rh0nj has joined #bitcoin-core-dev
 29 2018-12-12T02:04:55  *** ap4lmtree has quit IRC
 30 2018-12-12T02:09:01  *** ap4lmtree has joined #bitcoin-core-dev
 31 2018-12-12T02:34:58  *** shesek has joined #bitcoin-core-dev
 32 2018-12-12T02:38:18  *** shesek has quit IRC
 33 2018-12-12T02:39:14  *** shesek has joined #bitcoin-core-dev
 34 2018-12-12T02:41:53  *** shesek has joined #bitcoin-core-dev
 35 2018-12-12T02:53:03  *** bitcoin-git has joined #bitcoin-core-dev
 36 2018-12-12T02:53:03  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #14932: ui: Warn the user on file corruption in mempool.dat (master...Mf1812-testFileCorruption) https://github.com/bitcoin/bitcoin/pull/14932
 37 2018-12-12T02:53:03  *** bitcoin-git has left #bitcoin-core-dev
 38 2018-12-12T02:54:29  *** shesek has quit IRC
 39 2018-12-12T02:55:48  *** shesek has joined #bitcoin-core-dev
 40 2018-12-12T02:55:48  *** shesek has joined #bitcoin-core-dev
 41 2018-12-12T02:57:05  *** shesek has quit IRC
 42 2018-12-12T02:57:58  *** shesek has joined #bitcoin-core-dev
 43 2018-12-12T02:57:58  *** shesek has joined #bitcoin-core-dev
 44 2018-12-12T02:58:55  *** shesek has quit IRC
 45 2018-12-12T03:01:22  *** shesek has joined #bitcoin-core-dev
 46 2018-12-12T03:02:54  *** shesek has joined #bitcoin-core-dev
 47 2018-12-12T03:04:13  *** shesek has quit IRC
 48 2018-12-12T03:04:43  *** shesek has joined #bitcoin-core-dev
 49 2018-12-12T03:20:15  *** AaronvanW has quit IRC
 50 2018-12-12T03:21:54  *** Krellan has quit IRC
 51 2018-12-12T03:27:27  *** nelsonhb has joined #bitcoin-core-dev
 52 2018-12-12T03:30:51  *** murrayn has joined #bitcoin-core-dev
 53 2018-12-12T03:30:52  *** murrayn has joined #bitcoin-core-dev
 54 2018-12-12T03:35:40  *** comboy has joined #bitcoin-core-dev
 55 2018-12-12T03:36:59  *** _cryptodesktop_i has joined #bitcoin-core-dev
 56 2018-12-12T03:45:09  *** shesek has quit IRC
 57 2018-12-12T03:46:33  *** shesek has joined #bitcoin-core-dev
 58 2018-12-12T03:54:34  *** shesek has quit IRC
 59 2018-12-12T03:56:06  *** shesek has joined #bitcoin-core-dev
 60 2018-12-12T03:57:44  *** shesek has quit IRC
 61 2018-12-12T04:06:19  *** shesek has joined #bitcoin-core-dev
 62 2018-12-12T04:11:07  *** _cryptodesktop_i has quit IRC
 63 2018-12-12T04:11:15  *** shesek has quit IRC
 64 2018-12-12T04:15:48  *** Cory has quit IRC
 65 2018-12-12T04:17:16  *** shesek has joined #bitcoin-core-dev
 66 2018-12-12T04:19:34  *** shesek has quit IRC
 67 2018-12-12T04:20:59  *** shesek has joined #bitcoin-core-dev
 68 2018-12-12T04:21:30  *** shesek has quit IRC
 69 2018-12-12T04:22:31  *** Cory has joined #bitcoin-core-dev
 70 2018-12-12T04:23:43  *** shesek has joined #bitcoin-core-dev
 71 2018-12-12T04:24:59  *** shesek has joined #bitcoin-core-dev
 72 2018-12-12T04:26:09  *** bitcoin-git has joined #bitcoin-core-dev
 73 2018-12-12T04:26:10  <bitcoin-git> [bitcoin] MeshCollider pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/f65bce858f26...3fff1ab817e7
 74 2018-12-12T04:26:10  <bitcoin-git> bitcoin/master 6be0fb4 Pieter Wuille: [refactor] Add a base DescriptorImpl with most common logic
 75 2018-12-12T04:26:11  <bitcoin-git> bitcoin/master 24d3a7b Pieter Wuille: [refactor] Use DescriptorImpl internally, permitting access to new methods
 76 2018-12-12T04:26:11  <bitcoin-git> bitcoin/master 1eda33a Pieter Wuille: [refactor] Combine the ToString and ToPrivateString implementations
 77 2018-12-12T04:26:12  *** bitcoin-git has left #bitcoin-core-dev
 78 2018-12-12T04:26:54  *** bitcoin-git has joined #bitcoin-core-dev
 79 2018-12-12T04:26:54  <bitcoin-git> [bitcoin] MeshCollider closed pull request #14646: Add expansion cache functions to descriptors (unused for now) (master...201811_descriptcache) https://github.com/bitcoin/bitcoin/pull/14646
 80 2018-12-12T04:26:54  *** bitcoin-git has left #bitcoin-core-dev
 81 2018-12-12T04:29:53  *** spinza has quit IRC
 82 2018-12-12T04:32:50  *** spinza has joined #bitcoin-core-dev
 83 2018-12-12T04:33:09  *** shesek has quit IRC
 84 2018-12-12T04:33:44  *** shesek has joined #bitcoin-core-dev
 85 2018-12-12T04:33:44  *** shesek has joined #bitcoin-core-dev
 86 2018-12-12T04:34:07  *** shesek has quit IRC
 87 2018-12-12T04:34:48  *** shesek has joined #bitcoin-core-dev
 88 2018-12-12T04:37:05  *** shesek has quit IRC
 89 2018-12-12T04:39:22  *** shesek has joined #bitcoin-core-dev
 90 2018-12-12T05:01:40  *** bitcoin-git has joined #bitcoin-core-dev
 91 2018-12-12T05:01:41  <bitcoin-git> [bitcoin] MeshCollider pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fff1ab817e7...ed2a2cebd362
 92 2018-12-12T05:01:41  <bitcoin-git> bitcoin/master bb24d68 Ben Woosley: Make CWallet::ScanForWalletTransactions args and return value const
 93 2018-12-12T05:01:42  <bitcoin-git> bitcoin/master 3002d6c Ben Woosley: Return a status enum from ScanForWalletTransactions...
 94 2018-12-12T05:01:42  <bitcoin-git> bitcoin/master bd3b036 Ben Woosley: Add stop_block out arg to ScanForWalletTransactions...
 95 2018-12-12T05:01:43  *** shesek has quit IRC
 96 2018-12-12T05:01:43  *** bitcoin-git has left #bitcoin-core-dev
 97 2018-12-12T05:01:54  *** bitcoin-git has joined #bitcoin-core-dev
 98 2018-12-12T05:01:54  <bitcoin-git> [bitcoin] MeshCollider closed pull request #13076: Fix ScanForWalletTransactions to return an enum indicating scan result: success / failure / user_abort (master...scan-for-wallet-transactions-ret) https://github.com/bitcoin/bitcoin/pull/13076
 99 2018-12-12T05:01:54  *** bitcoin-git has left #bitcoin-core-dev
100 2018-12-12T05:02:15  *** shesek has joined #bitcoin-core-dev
101 2018-12-12T05:04:53  *** shesek has joined #bitcoin-core-dev
102 2018-12-12T05:04:53  *** shesek has joined #bitcoin-core-dev
103 2018-12-12T05:07:44  *** shesek has quit IRC
104 2018-12-12T05:08:44  *** shesek has joined #bitcoin-core-dev
105 2018-12-12T05:08:44  *** shesek has joined #bitcoin-core-dev
106 2018-12-12T05:09:00  <nelsonhb> The succession of these flame emperors, from Shennong, the first Yan Emperor, until the time of the last Yan Emperor's defeat by the Yellow
107 2018-12-12T05:09:00  <nelsonhb> Emperor, may have been some 500 years.
108 2018-12-12T05:14:45  *** shesek has quit IRC
109 2018-12-12T05:16:27  *** shesek has joined #bitcoin-core-dev
110 2018-12-12T05:17:26  *** murrayn has quit IRC
111 2018-12-12T05:17:40  *** tryphe has quit IRC
112 2018-12-12T05:17:49  *** murrayn has joined #bitcoin-core-dev
113 2018-12-12T05:17:49  *** murrayn has joined #bitcoin-core-dev
114 2018-12-12T05:18:28  *** tryphe has joined #bitcoin-core-dev
115 2018-12-12T05:18:49  *** TheRec has quit IRC
116 2018-12-12T05:19:05  *** shesek has joined #bitcoin-core-dev
117 2018-12-12T05:19:06  *** nelsonhb has quit IRC
118 2018-12-12T05:19:28  *** TheRec has joined #bitcoin-core-dev
119 2018-12-12T05:19:28  *** TheRec has joined #bitcoin-core-dev
120 2018-12-12T05:23:55  *** shesek has quit IRC
121 2018-12-12T05:25:11  *** shesek has joined #bitcoin-core-dev
122 2018-12-12T05:32:01  *** shesek has quit IRC
123 2018-12-12T05:33:26  *** shesek has joined #bitcoin-core-dev
124 2018-12-12T05:38:58  *** shesek has quit IRC
125 2018-12-12T05:40:42  *** shesek has joined #bitcoin-core-dev
126 2018-12-12T05:40:42  *** shesek has joined #bitcoin-core-dev
127 2018-12-12T05:41:06  *** helo has joined #bitcoin-core-dev
128 2018-12-12T05:41:37  *** shesek has quit IRC
129 2018-12-12T05:45:47  *** shesek has joined #bitcoin-core-dev
130 2018-12-12T05:47:58  *** shesek has quit IRC
131 2018-12-12T05:48:41  *** shesek has joined #bitcoin-core-dev
132 2018-12-12T05:49:46  *** shesek has quit IRC
133 2018-12-12T05:50:13  *** shesek has joined #bitcoin-core-dev
134 2018-12-12T05:53:11  *** shesek has joined #bitcoin-core-dev
135 2018-12-12T05:53:39  <ap4lmtree> qt is a popular interface gui huh
136 2018-12-12T05:53:50  <ap4lmtree> how did you guys learn that qt related programming
137 2018-12-12T06:20:41  *** miknotauro has joined #bitcoin-core-dev
138 2018-12-12T06:29:46  *** shesek has quit IRC
139 2018-12-12T06:30:40  *** shesek has joined #bitcoin-core-dev
140 2018-12-12T06:30:40  *** shesek has joined #bitcoin-core-dev
141 2018-12-12T06:33:06  *** shesek has quit IRC
142 2018-12-12T06:33:41  *** shesek has joined #bitcoin-core-dev
143 2018-12-12T06:36:52  *** schmidty_ has joined #bitcoin-core-dev
144 2018-12-12T06:37:54  *** schmidty has quit IRC
145 2018-12-12T06:38:02  *** shesek has quit IRC
146 2018-12-12T06:38:46  *** shesek has joined #bitcoin-core-dev
147 2018-12-12T06:42:24  *** shesek has quit IRC
148 2018-12-12T06:42:51  *** shesek has joined #bitcoin-core-dev
149 2018-12-12T06:52:11  *** shesek has quit IRC
150 2018-12-12T06:52:47  *** shesek has joined #bitcoin-core-dev
151 2018-12-12T06:52:47  *** shesek has joined #bitcoin-core-dev
152 2018-12-12T06:53:10  *** shesek has quit IRC
153 2018-12-12T06:54:51  *** shesek has joined #bitcoin-core-dev
154 2018-12-12T07:04:19  *** shesek has quit IRC
155 2018-12-12T07:08:00  *** shesek has joined #bitcoin-core-dev
156 2018-12-12T07:08:00  *** shesek has joined #bitcoin-core-dev
157 2018-12-12T07:09:44  *** shesek has quit IRC
158 2018-12-12T07:13:38  *** shesek has joined #bitcoin-core-dev
159 2018-12-12T07:13:38  *** shesek has joined #bitcoin-core-dev
160 2018-12-12T07:14:57  *** shesek has quit IRC
161 2018-12-12T07:16:10  *** shesek has joined #bitcoin-core-dev
162 2018-12-12T07:16:10  *** shesek has joined #bitcoin-core-dev
163 2018-12-12T07:29:28  *** promag has joined #bitcoin-core-dev
164 2018-12-12T07:30:40  *** shesek has quit IRC
165 2018-12-12T07:31:44  *** shesek has joined #bitcoin-core-dev
166 2018-12-12T07:32:36  *** shesek has quit IRC
167 2018-12-12T07:34:04  *** shesek has joined #bitcoin-core-dev
168 2018-12-12T07:35:39  *** promag has quit IRC
169 2018-12-12T07:39:57  *** dviola has quit IRC
170 2018-12-12T07:46:00  *** shesek has quit IRC
171 2018-12-12T07:46:28  *** shesek has joined #bitcoin-core-dev
172 2018-12-12T07:49:18  *** grubles has quit IRC
173 2018-12-12T07:51:02  *** shesek has quit IRC
174 2018-12-12T07:51:45  *** Murch has joined #bitcoin-core-dev
175 2018-12-12T07:51:47  *** shesek has joined #bitcoin-core-dev
176 2018-12-12T07:51:47  *** shesek has joined #bitcoin-core-dev
177 2018-12-12T07:53:45  *** sipa has quit IRC
178 2018-12-12T07:54:05  *** sipa has joined #bitcoin-core-dev
179 2018-12-12T07:59:52  <provoostenator> I found that for Gitian building 0.17.1 of the Windows signer binary it's necessary to use gitian-builder.py from the 0.17 branch, not from master. Or it starts complaining about file names.
180 2018-12-12T08:00:04  *** grubles has joined #bitcoin-core-dev
181 2018-12-12T08:02:35  <provoostenator> For signing stuff on your local machine (instead of inside the VM) and pushing to Github, this maybe useful: https://github.com/bitcoin-core/docs/issues/18#issue-292936112
182 2018-12-12T08:10:18  *** Murch has quit IRC
183 2018-12-12T08:15:08  *** Krellan has joined #bitcoin-core-dev
184 2018-12-12T08:18:16  *** shesek has quit IRC
185 2018-12-12T08:20:01  *** rh0nj has quit IRC
186 2018-12-12T08:20:15  *** shesek has joined #bitcoin-core-dev
187 2018-12-12T08:20:19  <wumpus> provoostenator: I think the idea  to use the gitian-builder from the branch you're building
188 2018-12-12T08:21:10  *** shesek has quit IRC
189 2018-12-12T08:22:28  <provoostenator> The currently instructions tell you to copy gitian-builder during the setup phase, but are unclear on what to do after. Always using the one from the release branch makes sense.
190 2018-12-12T08:23:37  <provoostenator> Maybe it should do a diff against bitcoin/contrib/gitian-builder.py after it checks out the branch and then prompt the user.
191 2018-12-12T08:24:09  *** bitcoin-git has joined #bitcoin-core-dev
192 2018-12-12T08:24:09  <bitcoin-git> [bitcoin] hebasto closed pull request #14905: scripted-diff: Replace deprecated C headers (master...20181209-replace-c-headers) https://github.com/bitcoin/bitcoin/pull/14905
193 2018-12-12T08:24:09  *** bitcoin-git has left #bitcoin-core-dev
194 2018-12-12T08:32:25  *** Zenton has quit IRC
195 2018-12-12T08:57:02  *** fanquake has joined #bitcoin-core-dev
196 2018-12-12T09:06:46  *** nelsonhb has joined #bitcoin-core-dev
197 2018-12-12T09:09:59  *** drexl has quit IRC
198 2018-12-12T09:09:59  *** bitcoin-git has joined #bitcoin-core-dev
199 2018-12-12T09:09:59  <bitcoin-git> [bitcoin] Sjors opened pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
200 2018-12-12T09:09:59  *** bitcoin-git has left #bitcoin-core-dev
201 2018-12-12T09:25:13  *** timothy has joined #bitcoin-core-dev
202 2018-12-12T09:45:55  *** promag has joined #bitcoin-core-dev
203 2018-12-12T09:47:56  *** hebasto has joined #bitcoin-core-dev
204 2018-12-12T09:49:31  <promag> hebasto: are you able to test #14573 in windows?
205 2018-12-12T09:49:33  <gribble> https://github.com/bitcoin/bitcoin/issues/14573 | qt: Add Window menu by promag · Pull Request #14573 · bitcoin/bitcoin · GitHub
206 2018-12-12T09:51:03  <hebasto> promag: unfortunately, no
207 2018-12-12T09:51:18  <promag> ok ty
208 2018-12-12T10:04:40  *** Zenton has joined #bitcoin-core-dev
209 2018-12-12T10:14:04  <meshcollider> promag: I can test it on windows tomorrow
210 2018-12-12T10:14:17  <promag> ok cool :)
211 2018-12-12T10:14:38  <fanquake> meshcollider which version/s?
212 2018-12-12T10:23:20  *** shesek has joined #bitcoin-core-dev
213 2018-12-12T10:23:20  *** shesek has joined #bitcoin-core-dev
214 2018-12-12T10:31:02  *** shesek` has joined #bitcoin-core-dev
215 2018-12-12T10:32:58  *** shesek has quit IRC
216 2018-12-12T10:33:01  *** shesek` has joined #bitcoin-core-dev
217 2018-12-12T10:36:41  *** shesek` has quit IRC
218 2018-12-12T10:37:38  *** shesek` has joined #bitcoin-core-dev
219 2018-12-12T10:39:02  <promag> well, regargding 14573, details on windows can be improved in a separate PR to avoid invalidating existing acks
220 2018-12-12T10:40:35  <meshcollider> fanquake: windows 10
221 2018-12-12T10:44:08  *** spinza has quit IRC
222 2018-12-12T10:50:36  *** spinza has joined #bitcoin-core-dev
223 2018-12-12T10:52:34  *** shesek` has quit IRC
224 2018-12-12T10:53:57  *** shesek` has joined #bitcoin-core-dev
225 2018-12-12T10:55:08  *** shesek` has quit IRC
226 2018-12-12T10:57:17  *** shesek has joined #bitcoin-core-dev
227 2018-12-12T10:57:17  *** shesek has joined #bitcoin-core-dev
228 2018-12-12T10:57:27  *** miknotauro has quit IRC
229 2018-12-12T11:21:45  *** shesek has quit IRC
230 2018-12-12T11:22:35  *** shesek has joined #bitcoin-core-dev
231 2018-12-12T11:28:59  <wumpus> what's with the appveyor failures?
232 2018-12-12T11:29:21  <wumpus> oh nm, it's only on some PRs
233 2018-12-12T11:29:30  <fanquake> more than usual?
234 2018-12-12T11:29:37  <wumpus> no, I don't think so :<
235 2018-12-12T11:29:52  <fanquake> Probably just need rebasing after a test fix?
236 2018-12-12T11:34:44  *** shesek has quit IRC
237 2018-12-12T11:35:47  *** shesek has joined #bitcoin-core-dev
238 2018-12-12T11:35:47  *** shesek has joined #bitcoin-core-dev
239 2018-12-12T11:53:11  *** shesek has quit IRC
240 2018-12-12T11:54:27  *** shesek has joined #bitcoin-core-dev
241 2018-12-12T12:02:09  *** rh0nj has joined #bitcoin-core-dev
242 2018-12-12T12:10:01  <promag> wumpus: nothing related with #14670 right?
243 2018-12-12T12:10:04  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
244 2018-12-12T12:10:20  *** shesek has quit IRC
245 2018-12-12T12:10:37  <wumpus> promag: nope
246 2018-12-12T12:10:39  *** shesek has joined #bitcoin-core-dev
247 2018-12-12T12:10:39  *** shesek has joined #bitcoin-core-dev
248 2018-12-12T12:15:17  *** shesek has quit IRC
249 2018-12-12T12:16:39  *** shesek has joined #bitcoin-core-dev
250 2018-12-12T12:21:35  *** shesek has quit IRC
251 2018-12-12T12:22:33  *** shesek has joined #bitcoin-core-dev
252 2018-12-12T12:25:24  *** shesek has quit IRC
253 2018-12-12T12:29:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
254 2018-12-12T12:30:11  *** shesek has joined #bitcoin-core-dev
255 2018-12-12T12:33:37  *** shesek has quit IRC
256 2018-12-12T12:34:33  *** shesek has joined #bitcoin-core-dev
257 2018-12-12T12:34:33  *** shesek has joined #bitcoin-core-dev
258 2018-12-12T12:35:42  *** AaronvanW has joined #bitcoin-core-dev
259 2018-12-12T12:38:33  *** shesek has quit IRC
260 2018-12-12T12:39:59  *** shesek has joined #bitcoin-core-dev
261 2018-12-12T12:39:59  *** shesek has joined #bitcoin-core-dev
262 2018-12-12T12:42:31  *** shesek has quit IRC
263 2018-12-12T12:43:25  *** shesek has joined #bitcoin-core-dev
264 2018-12-12T12:46:54  <fanquake> wumpus I'm happy for 14909 to just go in without the other additions
265 2018-12-12T12:47:55  *** shesek has quit IRC
266 2018-12-12T12:49:35  *** shesek has joined #bitcoin-core-dev
267 2018-12-12T12:49:35  *** shesek has joined #bitcoin-core-dev
268 2018-12-12T12:50:28  *** bitcoin-git has joined #bitcoin-core-dev
269 2018-12-12T12:50:29  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed2a2cebd362...96bde4f01f41
270 2018-12-12T12:50:29  <bitcoin-git> bitcoin/master b7bee6a fanquake: doc: Update minimum required qt
271 2018-12-12T12:50:30  <bitcoin-git> bitcoin/master 96bde4f Wladimir J. van der Laan: Merge #14909: doc: Update minimum required Qt...
272 2018-12-12T12:50:30  *** bitcoin-git has left #bitcoin-core-dev
273 2018-12-12T12:51:24  *** bitcoin-git has joined #bitcoin-core-dev
274 2018-12-12T12:51:25  <bitcoin-git> [bitcoin] laanwj closed pull request #14909: doc: Update minimum required Qt (master...doc-qt-minimum-52) https://github.com/bitcoin/bitcoin/pull/14909
275 2018-12-12T12:51:25  *** bitcoin-git has left #bitcoin-core-dev
276 2018-12-12T12:56:36  <fanquake> wumpus also happy for #14701 to go in as is
277 2018-12-12T12:56:38  <gribble> https://github.com/bitcoin/bitcoin/issues/14701 | build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString by fanquake · Pull Request #14701 · bitcoin/bitcoin · GitHub
278 2018-12-12T12:57:27  *** Chris_Stewart_5 has quit IRC
279 2018-12-12T13:01:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
280 2018-12-12T13:02:50  *** promag has quit IRC
281 2018-12-12T13:07:55  *** shesek has quit IRC
282 2018-12-12T13:09:52  *** shesek has joined #bitcoin-core-dev
283 2018-12-12T13:22:26  <fanquake> Would be interested to know if there are many/any? users running Bitcoin-Core on Windows Vista. Could use some more input in #14922.
284 2018-12-12T13:22:27  <gribble> https://github.com/bitcoin/bitcoin/issues/14922 | windows: Set _WIN32_WINNT to 0x0600 (Windows Vista) by ken2812221 · Pull Request #14922 · bitcoin/bitcoin · GitHub
285 2018-12-12T13:23:08  <fanquake> The 0.17.0.1 release binaries "seem" to work on Vista, but Qt dropped official support in 5.6, so I'd assume it's only a matter of time before they stop working.
286 2018-12-12T13:44:12  *** bitcoin-git has joined #bitcoin-core-dev
287 2018-12-12T13:44:12  <bitcoin-git> [bitcoin] practicalswift opened pull request #14935: tests: Test for expected return values when calling functions returning a success code (master...test-return-values) https://github.com/bitcoin/bitcoin/pull/14935
288 2018-12-12T13:44:12  *** bitcoin-git has left #bitcoin-core-dev
289 2018-12-12T13:47:41  *** promag has joined #bitcoin-core-dev
290 2018-12-12T13:48:48  *** spinza has quit IRC
291 2018-12-12T13:51:51  *** spinza has joined #bitcoin-core-dev
292 2018-12-12T13:55:10  *** shesek has quit IRC
293 2018-12-12T13:55:15  <timothy> fanquake: Microsoft deprecated support for Vista more than 1 years ago
294 2018-12-12T13:55:27  <timothy> do you REALLY want to run something like bitcoin on an unsupported OS?
295 2018-12-12T13:55:43  *** shesek has joined #bitcoin-core-dev
296 2018-12-12T13:56:11  *** tryphe has quit IRC
297 2018-12-12T13:56:35  *** tryphe has joined #bitcoin-core-dev
298 2018-12-12T13:58:33  <fanquake> timothy nope, which is why I've suggested we increase our minimum supported version of Windows to Windows 7 in 0.18.0
299 2018-12-12T14:00:29  *** nelsonhb has quit IRC
300 2018-12-12T14:02:55  *** shesek has quit IRC
301 2018-12-12T14:03:28  *** shesek has joined #bitcoin-core-dev
302 2018-12-12T14:09:02  *** shesek has quit IRC
303 2018-12-12T14:09:28  *** shesek has joined #bitcoin-core-dev
304 2018-12-12T14:17:57  *** ghost43 has quit IRC
305 2018-12-12T14:18:46  *** ghost43 has joined #bitcoin-core-dev
306 2018-12-12T14:22:01  *** shesek has quit IRC
307 2018-12-12T14:22:22  *** shesek has joined #bitcoin-core-dev
308 2018-12-12T14:30:14  *** Guyver2 has joined #bitcoin-core-dev
309 2018-12-12T14:30:46  *** Guyver2 has quit IRC
310 2018-12-12T14:30:58  *** Guyver2 has joined #bitcoin-core-dev
311 2018-12-12T14:36:47  *** wxss has joined #bitcoin-core-dev
312 2018-12-12T14:58:04  <promag> sipa: about #14565
313 2018-12-12T14:58:08  <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
314 2018-12-12T14:59:04  <promag> after this should it have support for "all or nothing" import?
315 2018-12-12T15:02:22  *** tripleslash has quit IRC
316 2018-12-12T15:04:07  *** tripleslash has joined #bitcoin-core-dev
317 2018-12-12T15:04:58  *** shesek has quit IRC
318 2018-12-12T15:10:49  <provoostenator> I suggested in the comments to have a warning==error option, which would have that effect, at least for stuff we can detect in advance.
319 2018-12-12T15:12:18  <provoostenator> No actually it would still be a per entry thing.
320 2018-12-12T15:14:09  <promag> right
321 2018-12-12T15:17:11  <promag> let me rephrase my question, after 14565, should we _add_ support for "all or nothing"?
322 2018-12-12T15:19:52  <wumpus> fanquake: probably better to ask on twitter or reddit, but no, I don't think anyone is still using vista, it was extremely unpopular even at the time
323 2018-12-12T15:20:15  <wumpus> +indeed, as timothy says, using an unsupported OS for bitcoin is kind of stupid
324 2018-12-12T15:21:03  <wumpus> windows 7 is still used intentionally by some people (that dislike windows 10) so setting that as the baseline supported version would make sense, imo
325 2018-12-12T15:22:21  <fanquake> wumpus fair enough. If you agree with my comments here, https://github.com/bitcoin/bitcoin/pull/14922#issuecomment-446585696, I'll add that to 0.18.0 and ask ken to update (including docs).
326 2018-12-12T15:25:39  *** bitcoin-git has joined #bitcoin-core-dev
327 2018-12-12T15:25:40  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96bde4f01f41...edc2822b9dc9
328 2018-12-12T15:25:40  <bitcoin-git> bitcoin/master 8e20934 fanquake: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString
329 2018-12-12T15:25:41  <bitcoin-git> bitcoin/master edc2822 Wladimir J. van der Laan: Merge #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString...
330 2018-12-12T15:25:41  *** bitcoin-git has left #bitcoin-core-dev
331 2018-12-12T15:26:10  <promag> looks like XP > vista
332 2018-12-12T15:26:37  *** bitcoin-git has joined #bitcoin-core-dev
333 2018-12-12T15:26:37  <bitcoin-git> [bitcoin] laanwj closed pull request #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (master...add-build-version-to-info-plist) https://github.com/bitcoin/bitcoin/pull/14701
334 2018-12-12T15:26:37  *** bitcoin-git has left #bitcoin-core-dev
335 2018-12-12T15:27:51  <wumpus> fanquake: I agree
336 2018-12-12T15:37:28  *** drexl has joined #bitcoin-core-dev
337 2018-12-12T15:40:25  *** drexl has quit IRC
338 2018-12-12T15:53:17  *** michaelsdunn1 has joined #bitcoin-core-dev
339 2018-12-12T16:03:01  *** rh0nj has quit IRC
340 2018-12-12T16:04:07  *** rh0nj has joined #bitcoin-core-dev
341 2018-12-12T16:17:18  <promag> IMO #14914 is ready
342 2018-12-12T16:17:21  <gribble> https://github.com/bitcoin/bitcoin/issues/14914 | Docs: Add nice table to files.md by emilengler · Pull Request #14914 · bitcoin/bitcoin · GitHub
343 2018-12-12T16:20:23  *** wxss_ has joined #bitcoin-core-dev
344 2018-12-12T16:23:20  *** wxss has quit IRC
345 2018-12-12T16:29:53  *** lopp has joined #bitcoin-core-dev
346 2018-12-12T16:30:31  *** Tralfaz has joined #bitcoin-core-dev
347 2018-12-12T16:31:10  *** Victorsueca has quit IRC
348 2018-12-12T16:31:34  *** Tralfaz has quit IRC
349 2018-12-12T16:33:15  *** Tralfaz has joined #bitcoin-core-dev
350 2018-12-12T16:36:27  *** shesek has joined #bitcoin-core-dev
351 2018-12-12T16:36:27  *** shesek has joined #bitcoin-core-dev
352 2018-12-12T16:36:35  *** Tralfaz has joined #bitcoin-core-dev
353 2018-12-12T16:45:47  *** Murch has joined #bitcoin-core-dev
354 2018-12-12T17:00:49  *** bitcoin-git has joined #bitcoin-core-dev
355 2018-12-12T17:00:49  <bitcoin-git> [bitcoin] ken2812221 opened pull request #14937: travis: fix travis would always be green even if it fail (master...travis-fix-save-cache-2) https://github.com/bitcoin/bitcoin/pull/14937
356 2018-12-12T17:00:49  *** bitcoin-git has left #bitcoin-core-dev
357 2018-12-12T17:02:48  *** bitcoin-git has joined #bitcoin-core-dev
358 2018-12-12T17:02:48  <bitcoin-git> [bitcoin] Sjors opened pull request #14938: Support creating an empty wallet (master...2018/12/create-empty-wallet) https://github.com/bitcoin/bitcoin/pull/14938
359 2018-12-12T17:02:48  *** bitcoin-git has left #bitcoin-core-dev
360 2018-12-12T17:03:13  *** drexl has joined #bitcoin-core-dev
361 2018-12-12T17:07:08  *** Tralfaz has quit IRC
362 2018-12-12T17:07:49  *** bitcoin-git has joined #bitcoin-core-dev
363 2018-12-12T17:07:50  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc2822b9dc9...38fb1b40dfb3
364 2018-12-12T17:07:50  <bitcoin-git> bitcoin/master 9b51b15 Emil Engler: Add nice table to files.md...
365 2018-12-12T17:07:51  <bitcoin-git> bitcoin/master 38fb1b4 Wladimir J. van der Laan: Merge #14914: Docs: Add nice table to files.md...
366 2018-12-12T17:07:51  *** bitcoin-git has left #bitcoin-core-dev
367 2018-12-12T17:07:57  *** Tralfaz has joined #bitcoin-core-dev
368 2018-12-12T17:08:54  *** bitcoin-git has joined #bitcoin-core-dev
369 2018-12-12T17:08:54  <bitcoin-git> [bitcoin] laanwj closed pull request #14914: Docs: Add nice table to files.md (master...add-nice-table) https://github.com/bitcoin/bitcoin/pull/14914
370 2018-12-12T17:08:54  *** bitcoin-git has left #bitcoin-core-dev
371 2018-12-12T17:19:52  *** Tralfaz has quit IRC
372 2018-12-12T17:20:40  *** Tralfaz has joined #bitcoin-core-dev
373 2018-12-12T17:27:27  *** Victorsueca has joined #bitcoin-core-dev
374 2018-12-12T17:35:24  *** bitcoin-git has joined #bitcoin-core-dev
375 2018-12-12T17:35:25  <bitcoin-git> [bitcoin] lontivero opened pull request #14939: rpc: Add test_accept_unsigned flag to testmempoolaccept (master...TestAcceptanceForUnsignedTransactions) https://github.com/bitcoin/bitcoin/pull/14939
376 2018-12-12T17:35:25  *** bitcoin-git has left #bitcoin-core-dev
377 2018-12-12T17:36:57  *** q-ask has joined #bitcoin-core-dev
378 2018-12-12T17:37:17  *** q-ask has left #bitcoin-core-dev
379 2018-12-12T17:48:18  *** Guest73299 has joined #bitcoin-core-dev
380 2018-12-12T17:48:48  *** Guest73299 has quit IRC
381 2018-12-12T17:49:14  *** Geekingfrog25 has joined #bitcoin-core-dev
382 2018-12-12T17:50:42  *** millerti has joined #bitcoin-core-dev
383 2018-12-12T17:53:38  *** bitcoin-git has joined #bitcoin-core-dev
384 2018-12-12T17:53:39  <bitcoin-git> [bitcoin] mrwhythat closed pull request #14476: RPC method 'encodescript' (master...encodescript-rpc) https://github.com/bitcoin/bitcoin/pull/14476
385 2018-12-12T17:53:39  *** bitcoin-git has left #bitcoin-core-dev
386 2018-12-12T18:03:51  *** fanquake has quit IRC
387 2018-12-12T18:22:30  *** Chris_Stewart_5 has quit IRC
388 2018-12-12T18:26:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
389 2018-12-12T18:46:53  *** wernie has joined #bitcoin-core-dev
390 2018-12-12T18:49:58  *** timothy has quit IRC
391 2018-12-12T18:50:42  *** shesek has quit IRC
392 2018-12-12T18:51:10  *** shesek has joined #bitcoin-core-dev
393 2018-12-12T18:53:07  *** shesek has joined #bitcoin-core-dev
394 2018-12-12T18:56:25  *** shesek has quit IRC
395 2018-12-12T18:58:23  *** miknotauro has joined #bitcoin-core-dev
396 2018-12-12T19:00:13  *** wernie has quit IRC
397 2018-12-12T19:01:45  *** shesek has joined #bitcoin-core-dev
398 2018-12-12T19:01:45  *** shesek has joined #bitcoin-core-dev
399 2018-12-12T19:03:20  *** shesek has quit IRC
400 2018-12-12T19:11:47  *** shesek has joined #bitcoin-core-dev
401 2018-12-12T19:11:48  *** shesek has quit IRC
402 2018-12-12T19:11:48  *** shesek has joined #bitcoin-core-dev
403 2018-12-12T19:15:36  *** shesek has quit IRC
404 2018-12-12T19:16:53  *** shesek has joined #bitcoin-core-dev
405 2018-12-12T19:54:29  *** hebasto has quit IRC
406 2018-12-12T20:03:02  *** rh0nj has quit IRC
407 2018-12-12T20:03:50  *** sturles has quit IRC
408 2018-12-12T20:04:57  *** sturles has joined #bitcoin-core-dev
409 2018-12-12T20:08:14  *** miknotauro has quit IRC
410 2018-12-12T20:10:08  *** rh0nj has joined #bitcoin-core-dev
411 2018-12-12T20:12:07  *** rh0nj has joined #bitcoin-core-dev
412 2018-12-12T20:25:12  *** AaronvanW has quit IRC
413 2018-12-12T20:25:43  *** AaronvanW has joined #bitcoin-core-dev
414 2018-12-12T20:30:27  *** jarthur has joined #bitcoin-core-dev
415 2018-12-12T20:49:56  *** shesek has quit IRC
416 2018-12-12T20:52:13  *** shesek has joined #bitcoin-core-dev
417 2018-12-12T20:54:25  *** miknotauro has joined #bitcoin-core-dev
418 2018-12-12T20:55:02  *** spinza has quit IRC
419 2018-12-12T21:08:27  *** spinza has joined #bitcoin-core-dev
420 2018-12-12T21:09:01  *** jarthur has quit IRC
421 2018-12-12T21:09:48  *** drexl has quit IRC
422 2018-12-12T21:29:20  *** bitcoinjunior has joined #bitcoin-core-dev
423 2018-12-12T21:30:24  *** miknotauro has quit IRC
424 2018-12-12T21:39:52  *** jarthur has joined #bitcoin-core-dev
425 2018-12-12T21:45:35  *** promag has quit IRC
426 2018-12-12T21:46:11  *** exekias6 has joined #bitcoin-core-dev
427 2018-12-12T21:49:33  *** wxss has joined #bitcoin-core-dev
428 2018-12-12T21:49:45  *** promag has joined #bitcoin-core-dev
429 2018-12-12T21:50:26  *** wxss_ has quit IRC
430 2018-12-12T22:00:39  *** wxss_ has joined #bitcoin-core-dev
431 2018-12-12T22:03:07  *** shesek has quit IRC
432 2018-12-12T22:03:30  *** wxss has quit IRC
433 2018-12-12T22:03:45  *** shesek has joined #bitcoin-core-dev
434 2018-12-12T22:07:00  *** shesek has joined #bitcoin-core-dev
435 2018-12-12T22:12:33  *** miknotauro has joined #bitcoin-core-dev
436 2018-12-12T22:15:31  *** wxss_ has quit IRC
437 2018-12-12T22:16:15  *** wxss has joined #bitcoin-core-dev
438 2018-12-12T22:19:52  *** spinza has quit IRC
439 2018-12-12T22:23:02  *** spinza has joined #bitcoin-core-dev
440 2018-12-12T22:23:06  *** karelb_ has joined #bitcoin-core-dev
441 2018-12-12T22:23:15  *** moneyball_ has joined #bitcoin-core-dev
442 2018-12-12T22:23:16  *** michaelsdunn1 has quit IRC
443 2018-12-12T22:23:26  *** Varunram_ has joined #bitcoin-core-dev
444 2018-12-12T22:23:42  *** michaelsdunn1 has joined #bitcoin-core-dev
445 2018-12-12T22:25:50  *** dlb76_ has joined #bitcoin-core-dev
446 2018-12-12T22:27:55  <andytoshi> sipa: i'm confused by https://github.com/bitcoin/bitcoin/pull/13191 ... it seems the new SHA256D64 does not append the sha256 length/padding anywhere, so how can `ComputeMerkleRoot` be consensus-compatible with the old code?
447 2018-12-12T22:28:09  <andytoshi> i assume i'm just being dumb/blind
448 2018-12-12T22:28:59  <gmaxwell> andytoshi: the length/padding is hardcoded into it.
449 2018-12-12T22:29:12  <gmaxwell> (because the length is fixed)
450 2018-12-12T22:29:26  *** Varunram has quit IRC
451 2018-12-12T22:29:26  *** karelb has quit IRC
452 2018-12-12T22:29:26  *** dlb76 has quit IRC
453 2018-12-12T22:29:29  *** belcher has quit IRC
454 2018-12-12T22:29:34  *** nsh has quit IRC
455 2018-12-12T22:29:34  *** moneyball has quit IRC
456 2018-12-12T22:29:34  *** rex4539 has quit IRC
457 2018-12-12T22:29:35  *** Varunram_ is now known as Varunram
458 2018-12-12T22:29:35  *** moneyball_ is now known as moneyball
459 2018-12-12T22:29:35  *** karelb_ is now known as karelb
460 2018-12-12T22:29:35  <andytoshi> isn't it 512 * `blocks` ?
461 2018-12-12T22:29:44  *** Randolf has joined #bitcoin-core-dev
462 2018-12-12T22:29:56  <sipa> andytoshi: it can only hash 64-byte inputs
463 2018-12-12T22:30:14  <gmaxwell> thats what the D64 means.
464 2018-12-12T22:30:24  <andytoshi> what does the `blocks` argument mean then?
465 2018-12-12T22:30:28  <sipa> andytoshi: the 'blocks' is how many double-SHA256-on-64-byte-inputs are being computed *in parallel*
466 2018-12-12T22:30:32  <andytoshi> ah!
467 2018-12-12T22:30:33  <andytoshi> thank yuo
468 2018-12-12T22:30:46  <andytoshi> ah yeah, suddenly the code makes sense :P
469 2018-12-12T22:31:41  *** belcher has joined #bitcoin-core-dev
470 2018-12-12T22:33:01  <gmaxwell> the speedup in this code over boring code comes mostly from hardcoding the lengths and padding, and in doing so elimiating the related expander rounds.
471 2018-12-12T22:33:28  <gmaxwell> (both from the 64 byte input and the 32byte inter-stage input)
472 2018-12-12T22:33:33  <sipa> and from using SSE4/AVX2 to compute 4 or 8 of them in parallel
473 2018-12-12T22:33:54  <gmaxwell> whered that patch using avx512 to do 16 in parallel go? :P
474 2018-12-12T22:34:09  <andytoshi> ok. the reason i ask is that in Elements we are directly using sha2 midstates to get the same speedup (which ofc changes the hash function so is completely incompatible with bitcoin)
475 2018-12-12T22:34:19  <andytoshi> and we're trying to rebase on #13191 and deciding the best course of action
476 2018-12-12T22:34:22  <gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub
477 2018-12-12T22:34:29  <sipa> https://github.com/bitcoin/bitcoin/pull/13989/files
478 2018-12-12T22:34:44  <gmaxwell> andytoshi: really? midstates, yuck. :P
479 2018-12-12T22:35:21  <andytoshi> gmaxwell: yes, yuck :P
480 2018-12-12T22:36:47  <gmaxwell> welp if you're not using SHA256D64 you can't use that code... it could be adapted to not include the length by changing some constants.
481 2018-12-12T22:37:16  <andytoshi> yep, that's what i'm concluding. thanks. probably we'll just keep our hacky midstate code and switch to SHA256D64 at the next hf opportunity
482 2018-12-12T22:37:17  *** dlb76_ is now known as dlb76
483 2018-12-12T22:37:20  *** dlb76 has joined #bitcoin-core-dev
484 2018-12-12T22:37:23  <gmaxwell> is what elements does SHA256D64 that just doesn't run the second compression function run?
485 2018-12-12T22:37:30  <andytoshi> gmaxwell: correct
486 2018-12-12T22:37:49  <gmaxwell> yes, then it could be adapted with some work. it would be somewhat faster than this code.
487 2018-12-12T22:38:21  *** Guyver2 has quit IRC
488 2018-12-12T22:38:52  <andytoshi> hmm, ok, maybe it's worth doing that work. though i'm uncomfortable enough with our effectively-homebrew hash function already without trying to optimize it :)
489 2018-12-12T22:39:53  <promag> should running with -wallet=xxx be an error if it's configured with --disable-wallet?
490 2018-12-12T22:40:13  <gmaxwell> andytoshi: well fortunately if you get it wrong it probably just won't work. :P
491 2018-12-12T22:40:32  <andytoshi> hehe, this is true
492 2018-12-12T22:40:34  *** nsh has joined #bitcoin-core-dev
493 2018-12-12T22:40:57  <gmaxwell> promag: hm in one sense, sure, but "I compiled differently and now I get an error on my config files" is not great.
494 2018-12-12T22:41:10  <promag> right, because config file
495 2018-12-12T22:41:23  <gmaxwell> promag: logging -wallet ignored due to ... is probably a reasonable middle ground, I dunno if we do that now.
496 2018-12-12T22:59:15  <promag> is there a long call like waitforblock but that holds a wallet?
497 2018-12-12T23:00:19  <sipa> i don't think so
498 2018-12-12T23:03:09  <tryphe> gmaxwell, it would be similar to setting some mempool options along with a "blocksonly=1" line in the config. one could uncomment the single "blocksonly=1" line to have the mempool options take effect. similar to commenting/uncommenting a "disable-wallet=1" line while having wallet= set.
499 2018-12-12T23:04:20  <tryphe> gmaxwell, uncomment=comment*, but you get the idea :)
500 2018-12-12T23:04:41  <sipa> tryphe: the difference is that with --disable-wallet, the wallet related code isn't even compiled in, so there would naively not be anything that can recognize those wallet lines as something meaningful in other configurations
501 2018-12-12T23:05:11  <tryphe> sipa, this is a good point
502 2018-12-12T23:07:18  <gmaxwell> the reason in favor of erroring on non-sensible configs is because silently giving the user something different than what they asked for isn't nice, and they might bash their head against a wall trying to figure out why it doesn't work because they didn't notice the other parameter.
503 2018-12-12T23:07:37  <gmaxwell> I generally prefer to log -- unless the interaction is one that if uncaught could cause funds loss.
504 2018-12-12T23:08:00  <gmaxwell> they'll find the log sometime between the third and fourth hour of troubleshooting. :P
505 2018-12-12T23:08:21  *** wxss has quit IRC
506 2018-12-12T23:16:18  *** Tralfaz has quit IRC
507 2018-12-12T23:19:03  *** drexl has joined #bitcoin-core-dev
508 2018-12-12T23:27:45  <promag> review beg #14641
509 2018-12-12T23:27:47  <gribble> https://github.com/bitcoin/bitcoin/issues/14641 | rpc: Add min_conf option to fund transaction calls by promag · Pull Request #14641 · bitcoin/bitcoin · GitHub
510 2018-12-12T23:28:07  *** Randolf has quit IRC
511 2018-12-12T23:34:06  *** jarthur has quit IRC
512 2018-12-12T23:36:45  *** bitcoinjunior has quit IRC
513 2018-12-12T23:39:31  <promag> gmaxwell: are you suggesting to not apply min_conf to ismine utxo?
514 2018-12-12T23:41:03  *** shesek has quit IRC
515 2018-12-12T23:41:22  *** shesek has joined #bitcoin-core-dev
516 2018-12-12T23:42:04  *** kmels has quit IRC
517 2018-12-12T23:42:32  *** brianhoffman_ has joined #bitcoin-core-dev
518 2018-12-12T23:42:39  *** tryphe_ has joined #bitcoin-core-dev
519 2018-12-12T23:45:28  *** brianhoffman has quit IRC
520 2018-12-12T23:45:29  *** brianhoffman_ is now known as brianhoffman
521 2018-12-12T23:46:05  *** tryphe has quit IRC
522 2018-12-12T23:48:26  *** tryphe_ is now known as tryphe