1 2019-01-11T00:05:10  *** Zenton has quit IRC
  2 2019-01-11T00:08:17  *** promag has quit IRC
  3 2019-01-11T00:11:26  *** promag has joined #bitcoin-core-dev
  4 2019-01-11T00:23:56  *** booyah has quit IRC
  5 2019-01-11T00:24:24  *** booyah has joined #bitcoin-core-dev
  6 2019-01-11T00:37:01  *** Aaronvan_ has joined #bitcoin-core-dev
  7 2019-01-11T00:39:45  *** Aaronvan_ has quit IRC
  8 2019-01-11T00:40:24  *** AaronvanW has quit IRC
  9 2019-01-11T00:56:01  *** promag has quit IRC
 10 2019-01-11T01:03:30  *** mistergold has joined #bitcoin-core-dev
 11 2019-01-11T01:03:38  *** pinheadmz has quit IRC
 12 2019-01-11T01:06:03  *** jimmysong has quit IRC
 13 2019-01-11T01:08:11  *** pinheadmz has joined #bitcoin-core-dev
 14 2019-01-11T01:09:47  *** miknotauro has quit IRC
 15 2019-01-11T01:09:50  *** mistergold has quit IRC
 16 2019-01-11T01:13:29  <benthecarman> Can someone point me to a good source to learn about p2sh
 17 2019-01-11T01:13:33  *** DeanGuss has quit IRC
 18 2019-01-11T01:25:03  <sipa> bip16
 19 2019-01-11T01:31:01  *** promag has joined #bitcoin-core-dev
 20 2019-01-11T01:35:31  *** promag has quit IRC
 21 2019-01-11T01:50:52  *** mistergold has joined #bitcoin-core-dev
 22 2019-01-11T01:56:47  *** mistergold has quit IRC
 23 2019-01-11T02:00:22  <hidden> ReserveKeyFromKeyPool: unknown key in key pool (code -1) :(
 24 2019-01-11T02:09:40  <phantomcircuit> sipa, why have a bunch of functions that modify a struct instead of a class?
 25 2019-01-11T02:12:11  <sipa> phantomcircuit: wut?
 26 2019-01-11T02:12:31  <phantomcircuit> the rng stuff
 27 2019-01-11T02:12:53  <sipa> i don't understand
 28 2019-01-11T02:13:26  <sipa> you mean why is RNGState a struct and not a class?
 29 2019-01-11T02:13:32  <phantomcircuit> yes
 30 2019-01-11T02:13:46  <sipa> you know what the difference is between the two?
 31 2019-01-11T02:13:52  <phantomcircuit> like AddDataToRng could be a method instead of calling GetRNGState
 32 2019-01-11T02:14:13  <sipa> sure
 33 2019-01-11T02:14:14  <phantomcircuit> sipa, public/private default, but i meant more the style change that typically happens with a class
 34 2019-01-11T02:14:29  <sipa> maybe i should make the internal state orivate
 35 2019-01-11T02:14:31  <sipa> *private
 36 2019-01-11T02:14:44  <sipa> that seems like a nice guarantee anyway
 37 2019-01-11T02:14:58  <sipa> to avoid bugs that accidentally wipe the state
 38 2019-01-11T02:15:51  <gmaxwell> can the state get stored in the mlocked pool, or is there some initalization order issue there.
 39 2019-01-11T02:16:22  <sipa> that's actually pretty doable
 40 2019-01-11T02:30:21  *** Emcy has quit IRC
 41 2019-01-11T02:30:33  *** Emcy has joined #bitcoin-core-dev
 42 2019-01-11T02:34:22  <sipa> done
 43 2019-01-11T02:34:26  <sipa> that was surprisingly easy
 44 2019-01-11T02:37:06  *** bitstein has joined #bitcoin-core-dev
 45 2019-01-11T02:38:49  *** pinheadmz has quit IRC
 46 2019-01-11T02:41:50  *** bitstein has quit IRC
 47 2019-01-11T02:43:51  *** spinza has quit IRC
 48 2019-01-11T02:45:54  *** DougieBot5000_ has joined #bitcoin-core-dev
 49 2019-01-11T02:48:47  *** DougieBot5000 has quit IRC
 50 2019-01-11T02:56:59  *** rex4539 has quit IRC
 51 2019-01-11T03:00:19  *** ddustin has joined #bitcoin-core-dev
 52 2019-01-11T03:01:11  *** spinza has joined #bitcoin-core-dev
 53 2019-01-11T03:01:32  *** benthecarman has quit IRC
 54 2019-01-11T03:13:32  *** dviola has quit IRC
 55 2019-01-11T03:34:39  *** DougieBot5000_ has quit IRC
 56 2019-01-11T03:34:53  *** promag has joined #bitcoin-core-dev
 57 2019-01-11T03:39:40  *** promag has quit IRC
 58 2019-01-11T03:50:48  *** Krellan has quit IRC
 59 2019-01-11T03:51:16  *** Krellan has joined #bitcoin-core-dev
 60 2019-01-11T03:55:49  *** Krellan has quit IRC
 61 2019-01-11T04:00:36  *** gelmutshmidt has quit IRC
 62 2019-01-11T04:01:09  *** chenpo has quit IRC
 63 2019-01-11T04:05:01  *** pinheadmz has joined #bitcoin-core-dev
 64 2019-01-11T04:06:44  *** DougieBot5000 has joined #bitcoin-core-dev
 65 2019-01-11T04:12:43  *** Eagle[TM] has joined #bitcoin-core-dev
 66 2019-01-11T04:14:46  *** EagleTM has quit IRC
 67 2019-01-11T04:15:02  *** rh0nj has quit IRC
 68 2019-01-11T04:16:07  *** rh0nj has joined #bitcoin-core-dev
 69 2019-01-11T04:16:58  *** gkrizek34 has joined #bitcoin-core-dev
 70 2019-01-11T04:25:24  *** qrestlove has quit IRC
 71 2019-01-11T04:28:38  *** miknotauro has joined #bitcoin-core-dev
 72 2019-01-11T04:34:40  *** pinheadmz has quit IRC
 73 2019-01-11T04:42:50  *** jimmysong has joined #bitcoin-core-dev
 74 2019-01-11T04:46:30  *** gekisai has quit IRC
 75 2019-01-11T04:47:10  *** gekisai has joined #bitcoin-core-dev
 76 2019-01-11T04:51:24  *** gekisai has quit IRC
 77 2019-01-11T05:00:47  *** promag has joined #bitcoin-core-dev
 78 2019-01-11T05:05:34  *** promag has quit IRC
 79 2019-01-11T05:14:09  *** qrestlove has joined #bitcoin-core-dev
 80 2019-01-11T05:29:01  *** pinheadmz has joined #bitcoin-core-dev
 81 2019-01-11T05:34:27  *** gkrizek has quit IRC
 82 2019-01-11T05:38:45  *** TX1683 has quit IRC
 83 2019-01-11T05:43:20  *** gkrizek has joined #bitcoin-core-dev
 84 2019-01-11T05:45:08  *** gekisai has joined #bitcoin-core-dev
 85 2019-01-11T05:45:09  *** TX1683 has joined #bitcoin-core-dev
 86 2019-01-11T05:48:17  *** pinheadmz has quit IRC
 87 2019-01-11T05:49:53  *** gekisai has quit IRC
 88 2019-01-11T05:58:27  *** chenpo has joined #bitcoin-core-dev
 89 2019-01-11T06:07:52  *** zenogais has quit IRC
 90 2019-01-11T06:15:02  *** Murch has quit IRC
 91 2019-01-11T06:41:33  *** chenpo has quit IRC
 92 2019-01-11T06:43:44  *** gkrizek has quit IRC
 93 2019-01-11T06:44:02  *** gkrizek has joined #bitcoin-core-dev
 94 2019-01-11T06:45:30  *** Giszmo has quit IRC
 95 2019-01-11T07:07:05  *** booyah_ has joined #bitcoin-core-dev
 96 2019-01-11T07:08:20  *** booyah has quit IRC
 97 2019-01-11T07:16:59  *** Krellan has joined #bitcoin-core-dev
 98 2019-01-11T07:21:46  *** Krellan has quit IRC
 99 2019-01-11T07:24:22  *** Eagle[TM] has quit IRC
100 2019-01-11T07:26:00  *** Krellan has joined #bitcoin-core-dev
101 2019-01-11T07:39:14  *** TX1683 has quit IRC
102 2019-01-11T07:40:11  *** mistergold has joined #bitcoin-core-dev
103 2019-01-11T07:44:49  *** TX1683 has joined #bitcoin-core-dev
104 2019-01-11T08:15:57  *** gekisai has joined #bitcoin-core-dev
105 2019-01-11T08:17:01  *** rh0nj has quit IRC
106 2019-01-11T08:18:12  *** rh0nj has joined #bitcoin-core-dev
107 2019-01-11T08:36:35  *** jungly has joined #bitcoin-core-dev
108 2019-01-11T08:37:10  *** gekisai has quit IRC
109 2019-01-11T08:37:44  *** hebasto has joined #bitcoin-core-dev
110 2019-01-11T08:39:29  *** miknotauro has quit IRC
111 2019-01-11T09:05:06  *** Cory has quit IRC
112 2019-01-11T09:05:25  *** setpill has joined #bitcoin-core-dev
113 2019-01-11T09:11:26  *** hebasto has quit IRC
114 2019-01-11T09:12:18  *** Cory has joined #bitcoin-core-dev
115 2019-01-11T09:14:05  *** gekisai has joined #bitcoin-core-dev
116 2019-01-11T09:16:31  *** promag has joined #bitcoin-core-dev
117 2019-01-11T09:18:35  *** gekisai has quit IRC
118 2019-01-11T09:27:38  *** mistergold has quit IRC
119 2019-01-11T09:31:50  *** elichai2 has joined #bitcoin-core-dev
120 2019-01-11T09:35:40  *** Zenton has joined #bitcoin-core-dev
121 2019-01-11T09:46:18  *** gekisai has joined #bitcoin-core-dev
122 2019-01-11T09:53:56  *** AaronvanW has joined #bitcoin-core-dev
123 2019-01-11T09:59:27  *** ddustin has quit IRC
124 2019-01-11T09:59:50  *** benthecarman has joined #bitcoin-core-dev
125 2019-01-11T09:59:53  *** timothy has joined #bitcoin-core-dev
126 2019-01-11T10:42:42  *** mistergold has joined #bitcoin-core-dev
127 2019-01-11T10:47:16  *** spinza has quit IRC
128 2019-01-11T10:53:56  *** gekisai has quit IRC
129 2019-01-11T10:55:53  *** spinza has joined #bitcoin-core-dev
130 2019-01-11T11:02:46  <wumpus> we should probably restart the discussion about wallet recovery at some point  #10540 #8745  #10991 it kind of bled out
131 2019-01-11T11:02:48  <gribble> https://github.com/bitcoin/bitcoin/issues/10540 | [WIP] Salvage wallet should not set the aggressive flag on Db::verify() by jnewbery · Pull Request #10540 · bitcoin/bitcoin · GitHub
132 2019-01-11T11:02:50  <gribble> https://github.com/bitcoin/bitcoin/issues/8745 | [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" by jonasschnelli · Pull Request #8745 · bitcoin/bitcoin · GitHub
133 2019-01-11T11:02:51  <gribble> https://github.com/bitcoin/bitcoin/issues/10991 | -salvagewallet seems to be causing more issues than it fixes, it should be removed · Issue #10991 · bitcoin/bitcoin · GitHub
134 2019-01-11T11:05:25  *** NicolasDorier has quit IRC
135 2019-01-11T11:10:19  <wumpus> it would still make sense to do the separate wallet recovery tool
136 2019-01-11T11:40:31  *** mistergold has quit IRC
137 2019-01-11T12:14:49  *** miknotauro has joined #bitcoin-core-dev
138 2019-01-11T12:23:09  *** elichai2 has quit IRC
139 2019-01-11T12:46:25  *** PhilippE has joined #bitcoin-core-dev
140 2019-01-11T12:47:01  *** promag has quit IRC
141 2019-01-11T12:50:53  *** PhilippE has quit IRC
142 2019-01-11T12:54:05  *** fanquake has joined #bitcoin-core-dev
143 2019-01-11T13:01:02  *** spinza has quit IRC
144 2019-01-11T13:10:02  *** rh0nj has quit IRC
145 2019-01-11T13:11:07  *** rh0nj has joined #bitcoin-core-dev
146 2019-01-11T13:40:36  *** spinza has joined #bitcoin-core-dev
147 2019-01-11T13:47:36  *** hidden has quit IRC
148 2019-01-11T13:52:40  *** Victorsueca has quit IRC
149 2019-01-11T13:58:24  *** Victorsueca has joined #bitcoin-core-dev
150 2019-01-11T14:16:06  *** promag has joined #bitcoin-core-dev
151 2019-01-11T14:19:08  *** baldur has quit IRC
152 2019-01-11T14:20:34  *** miknotauro has quit IRC
153 2019-01-11T14:25:08  <promag> sipa: ping https://github.com/bitcoin/bitcoin/pull/15107#issuecomment-452821812 in case you missed the notification
154 2019-01-11T14:38:11  *** user69699 has joined #bitcoin-core-dev
155 2019-01-11T14:40:13  *** Guyver2 has joined #bitcoin-core-dev
156 2019-01-11T14:43:02  *** spaced0ut has joined #bitcoin-core-dev
157 2019-01-11T15:01:56  *** user69699 has quit IRC
158 2019-01-11T15:04:21  *** justanotheruser has quit IRC
159 2019-01-11T15:11:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
160 2019-01-11T15:16:46  *** booyah_ is now known as booyah
161 2019-01-11T15:27:16  *** profmac has quit IRC
162 2019-01-11T15:30:07  *** profmac has joined #bitcoin-core-dev
163 2019-01-11T15:34:05  *** Murch has joined #bitcoin-core-dev
164 2019-01-11T15:34:25  *** pinheadmz has joined #bitcoin-core-dev
165 2019-01-11T15:37:53  *** pinheadmz has quit IRC
166 2019-01-11T15:41:12  *** profmac has quit IRC
167 2019-01-11T15:45:40  *** profmac has joined #bitcoin-core-dev
168 2019-01-11T15:46:24  *** benthecarman_ has joined #bitcoin-core-dev
169 2019-01-11T15:46:33  *** arubi has quit IRC
170 2019-01-11T15:46:55  *** gkrizek has quit IRC
171 2019-01-11T15:47:01  *** arubi has joined #bitcoin-core-dev
172 2019-01-11T15:47:15  *** gkrizek has joined #bitcoin-core-dev
173 2019-01-11T15:48:41  *** benthecarman has quit IRC
174 2019-01-11T16:02:10  *** setpill has quit IRC
175 2019-01-11T16:07:14  *** gkrizek has quit IRC
176 2019-01-11T16:10:09  *** gkrizek has joined #bitcoin-core-dev
177 2019-01-11T16:12:43  *** gkrizek has quit IRC
178 2019-01-11T16:12:59  *** gkrizek has joined #bitcoin-core-dev
179 2019-01-11T16:15:05  *** rex4539 has joined #bitcoin-core-dev
180 2019-01-11T16:25:06  *** mistergold has joined #bitcoin-core-dev
181 2019-01-11T16:26:39  *** michaelsdunn1 has joined #bitcoin-core-dev
182 2019-01-11T16:27:38  *** michaels_ has joined #bitcoin-core-dev
183 2019-01-11T16:29:09  *** michaels_ has quit IRC
184 2019-01-11T16:29:24  *** michaels_ has joined #bitcoin-core-dev
185 2019-01-11T16:30:47  *** michaelsdunn1 has quit IRC
186 2019-01-11T16:39:55  *** michaelsdunn1 has joined #bitcoin-core-dev
187 2019-01-11T16:43:07  *** michaels_ has quit IRC
188 2019-01-11T16:49:51  *** Zenton has quit IRC
189 2019-01-11T16:51:12  *** miknotauro has joined #bitcoin-core-dev
190 2019-01-11T16:51:50  *** zenogais has joined #bitcoin-core-dev
191 2019-01-11T16:53:58  *** Chris_Stewart_5 has quit IRC
192 2019-01-11T17:09:55  *** jungly has quit IRC
193 2019-01-11T17:12:18  *** ddustin has joined #bitcoin-core-dev
194 2019-01-11T17:16:51  *** ddustin has quit IRC
195 2019-01-11T17:30:35  *** hidden has joined #bitcoin-core-dev
196 2019-01-11T17:34:12  *** michaelsdunn1 has quit IRC
197 2019-01-11T17:39:56  *** Krellan has quit IRC
198 2019-01-11T17:53:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
199 2019-01-11T17:56:00  *** michaelsdunn1 has joined #bitcoin-core-dev
200 2019-01-11T17:56:00  *** michaelsdunn1 has quit IRC
201 2019-01-11T17:56:00  *** michaelsdunn1 has joined #bitcoin-core-dev
202 2019-01-11T17:57:48  *** rerfjhj has joined #bitcoin-core-dev
203 2019-01-11T18:00:31  *** rerfjhj has left #bitcoin-core-dev
204 2019-01-11T18:01:09  *** hidden has quit IRC
205 2019-01-11T18:11:45  <sipa> I'll probably miss the wallet meeting today, i'm at real world crypto
206 2019-01-11T18:14:02  *** ken2812221 has joined #bitcoin-core-dev
207 2019-01-11T18:28:16  *** baldur has joined #bitcoin-core-dev
208 2019-01-11T18:29:49  *** Tralfaz has quit IRC
209 2019-01-11T18:30:06  *** jarthur has joined #bitcoin-core-dev
210 2019-01-11T18:31:42  *** ken2812221_ has joined #bitcoin-core-dev
211 2019-01-11T18:32:51  *** ken2812221 has quit IRC
212 2019-01-11T18:33:34  *** kexkey has joined #bitcoin-core-dev
213 2019-01-11T18:35:45  *** spaced0ut has quit IRC
214 2019-01-11T18:40:21  *** ddustin has joined #bitcoin-core-dev
215 2019-01-11T18:40:32  *** ken2812221_ is now known as ken2812221
216 2019-01-11T18:43:57  *** so has quit IRC
217 2019-01-11T18:49:00  *** baldur has quit IRC
218 2019-01-11T18:50:57  *** Krellan has joined #bitcoin-core-dev
219 2019-01-11T18:51:30  *** so has joined #bitcoin-core-dev
220 2019-01-11T18:55:36  *** Krellan has quit IRC
221 2019-01-11T18:58:42  *** Chris_Stewart_5 has quit IRC
222 2019-01-11T19:00:14  <meshcollider> #startmeeting
223 2019-01-11T19:00:14  <lightningbot> Meeting started Fri Jan 11 19:00:14 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
224 2019-01-11T19:00:14  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
225 2019-01-11T19:00:17  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
226 2019-01-11T19:00:30  <jnewbery> hi
227 2019-01-11T19:00:30  <instagibbs> hi
228 2019-01-11T19:00:34  <phantomcircuit> hi
229 2019-01-11T19:00:45  <meshcollider> First wallet meeting of 2019
230 2019-01-11T19:00:49  <meshcollider> Any topics?
231 2019-01-11T19:00:54  <achow101> hi
232 2019-01-11T19:01:15  <achow101> what's the status on #14491
233 2019-01-11T19:01:17  <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
234 2019-01-11T19:01:47  <instagibbs> I've been mostly paying attention to HWI sorry :X
235 2019-01-11T19:01:53  <achow101> same
236 2019-01-11T19:02:24  *** zenogais has quit IRC
237 2019-01-11T19:02:37  <meshcollider> I've got to address a few comments there, and split up one of the commits
238 2019-01-11T19:02:42  <jnewbery> I think might still be some rebase issues with 14491. I commented in the PR
239 2019-01-11T19:03:24  <meshcollider> I'm travelling for the next few days unfortunately so I'm not sure how soon I'll have time
240 2019-01-11T19:04:25  *** pinheadmz has joined #bitcoin-core-dev
241 2019-01-11T19:05:45  <jnewbery> I might have some time next week to try to rearrange the commits
242 2019-01-11T19:06:31  <instagibbs> open Q I brought up in HWI: You cannot actually import two addresses if the wall already "understands the script" and then it complains about private keys. Is that an intentional limitation?
243 2019-01-11T19:06:44  <instagibbs> say first one is native segwit
244 2019-01-11T19:06:53  <instagibbs> second is p2sh wrapped, it doesn't let you import the second
245 2019-01-11T19:07:06  <instagibbs> is this just a Core thingy we'll wait until "new wallet" to fix?
246 2019-01-11T19:07:20  * instagibbs finding the exact test case I ran into and had to work around
247 2019-01-11T19:08:07  <meshcollider> Is it a case of the wallet saying it already contains the script
248 2019-01-11T19:08:45  <instagibbs> https://github.com/achow101/HWI/commit/68a4935c8803fa04801257ace34c6f07b03d57ac#diff-0d9a21f6363f36a267f2576c8d3d3863R232
249 2019-01-11T19:08:58  <instagibbs> i reordered the keys to generate a new script here, but to test you can unscramble
250 2019-01-11T19:09:02  <instagibbs> we can discuss offline
251 2019-01-11T19:09:10  *** miknotauro has quit IRC
252 2019-01-11T19:09:11  <achow101> i think it's the wallet saying it already has the script
253 2019-01-11T19:09:52  <instagibbs> im sure that was the intended message
254 2019-01-11T19:10:10  <meshcollider> Because of the "learn relayed scripts" hack
255 2019-01-11T19:10:12  <meshcollider> Related*
256 2019-01-11T19:10:26  <instagibbs> right, so might be "core problems" until revamp
257 2019-01-11T19:10:50  <meshcollider> I can look into it further if you want, if you're not convinced its that
258 2019-01-11T19:11:29  <instagibbs> if you think it's that it's probably that
259 2019-01-11T19:11:45  <instagibbs> realistically you shouldn't be reusing same core script anyways
260 2019-01-11T19:14:00  <instagibbs> other topics?
261 2019-01-11T19:14:01  <meshcollider> But you're right the revamp will fix that
262 2019-01-11T19:14:19  <instagibbs> indeed
263 2019-01-11T19:15:30  *** gekisai has joined #bitcoin-core-dev
264 2019-01-11T19:16:20  <meshcollider> Looks like no other topics for now then
265 2019-01-11T19:16:46  <meshcollider> #endmeeting
266 2019-01-11T19:16:46  <lightningbot> Meeting ended Fri Jan 11 19:16:46 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
267 2019-01-11T19:16:46  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-11-19.00.html
268 2019-01-11T19:16:46  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-11-19.00.txt
269 2019-01-11T19:16:46  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-11-19.00.log.html
270 2019-01-11T19:18:50  *** ken2812221 has quit IRC
271 2019-01-11T19:18:55  *** benthecarman_ has quit IRC
272 2019-01-11T19:19:09  *** benthecarman has joined #bitcoin-core-dev
273 2019-01-11T19:19:38  *** gekisai has quit IRC
274 2019-01-11T19:29:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
275 2019-01-11T19:30:11  *** benthecarman has quit IRC
276 2019-01-11T19:52:58  *** Krellan has joined #bitcoin-core-dev
277 2019-01-11T19:55:00  *** zenogais has joined #bitcoin-core-dev
278 2019-01-11T19:59:06  *** twistedline has quit IRC
279 2019-01-11T20:02:22  *** twistedline has joined #bitcoin-core-dev
280 2019-01-11T20:03:13  *** A_ has joined #bitcoin-core-dev
281 2019-01-11T20:23:38  *** A_ has quit IRC
282 2019-01-11T20:25:10  *** dviola has joined #bitcoin-core-dev
283 2019-01-11T20:34:23  <luke-jr> is there a good reason we have 3 different "decompose transaction" functions? :x
284 2019-01-11T20:34:33  <luke-jr> (all with subtle differences!)
285 2019-01-11T20:45:12  *** timothy has quit IRC
286 2019-01-11T20:51:17  <marcinja> 1
287 2019-01-11T20:52:02  *** mistergold has quit IRC
288 2019-01-11T20:52:21  <phantomcircuit> luke-jr, hmm?
289 2019-01-11T20:53:10  <luke-jr> phantomcircuit: wallet.cpp has one used by RPC; the GUI has one for the tx list, and then another for the tx details
290 2019-01-11T20:53:52  <luke-jr> I guess maybe RPC needs a separate one for higher compatibility requirements, but.. :/
291 2019-01-11T20:54:34  <luke-jr> at least once send-to-self is gone, I think what we want is identical anyway?
292 2019-01-11T20:58:12  *** gekisai has joined #bitcoin-core-dev
293 2019-01-11T20:58:58  *** pinheadmz has quit IRC
294 2019-01-11T21:02:37  *** pinheadmz has joined #bitcoin-core-dev
295 2019-01-11T21:23:08  *** Guyver2 has quit IRC
296 2019-01-11T21:37:54  *** miknotauro has joined #bitcoin-core-dev
297 2019-01-11T21:44:12  *** Zenton has joined #bitcoin-core-dev
298 2019-01-11T21:49:38  *** miknotauro has quit IRC
299 2019-01-11T21:53:45  *** Chris_Stewart_5 has quit IRC
300 2019-01-11T21:55:59  *** Krellan has quit IRC
301 2019-01-11T21:56:04  *** Krellan_ has joined #bitcoin-core-dev
302 2019-01-11T22:08:49  *** gekisai has quit IRC
303 2019-01-11T22:10:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
304 2019-01-11T22:12:00  *** spinza has quit IRC
305 2019-01-11T22:17:41  *** spinza has joined #bitcoin-core-dev
306 2019-01-11T22:21:24  *** ddustin has quit IRC
307 2019-01-11T22:25:21  *** ddustin has joined #bitcoin-core-dev
308 2019-01-11T22:29:38  *** miknotauro has joined #bitcoin-core-dev
309 2019-01-11T22:40:01  *** rh0nj has quit IRC
310 2019-01-11T22:41:08  *** rh0nj has joined #bitcoin-core-dev
311 2019-01-11T22:45:30  *** cryptapus has quit IRC
312 2019-01-11T22:45:56  *** cryptapus has joined #bitcoin-core-dev
313 2019-01-11T22:46:04  *** cryptapus has quit IRC
314 2019-01-11T22:46:05  *** cryptapus has joined #bitcoin-core-dev
315 2019-01-11T22:46:10  *** jarthur has quit IRC
316 2019-01-11T22:48:26  <phantomcircuit> luke-jr, oh you mean the CTransction -> json things
317 2019-01-11T22:48:40  <phantomcircuit> yeah an the rpc results are weird as a result
318 2019-01-11T22:48:56  *** dviola has quit IRC
319 2019-01-11T22:54:42  <luke-jr> well, ->JSON is just one of 3 implemetnations
320 2019-01-11T22:54:51  *** ddustin has quit IRC
321 2019-01-11T22:54:59  <luke-jr> the others go ->GUI and ->HTML
322 2019-01-11T22:55:09  *** ddustin has joined #bitcoin-core-dev
323 2019-01-11T22:55:31  *** ddustin has joined #bitcoin-core-dev
324 2019-01-11T23:01:06  *** justanotheruser has joined #bitcoin-core-dev
325 2019-01-11T23:19:52  *** rex4539 has quit IRC
326 2019-01-11T23:44:57  *** benthecarman has joined #bitcoin-core-dev
327 2019-01-11T23:49:54  *** michaelsdunn1 has quit IRC
328 2019-01-11T23:50:09  *** DeanGuss has joined #bitcoin-core-dev
329 2019-01-11T23:58:20  *** miknotauro has quit IRC