12019-01-15T00:24:57 *** ddustin has joined #bitcoin-core-dev
22019-01-15T00:26:33 *** Murch has quit IRC
32019-01-15T00:30:12 *** ddustin has quit IRC
42019-01-15T00:32:09 *** bzb_ has quit IRC
52019-01-15T00:35:05 *** Murch has joined #bitcoin-core-dev
62019-01-15T00:39:37 *** mistergold has quit IRC
72019-01-15T00:56:42 *** ddustin has joined #bitcoin-core-dev
82019-01-15T00:58:57 *** Dean_Guss has quit IRC
92019-01-15T01:01:00 *** promag has quit IRC
102019-01-15T01:01:22 *** ddustin has quit IRC
112019-01-15T01:05:20 *** jb55 has quit IRC
122019-01-15T01:13:17 *** pinheadmz has quit IRC
132019-01-15T01:17:02 *** rh0nj has quit IRC
142019-01-15T01:18:13 *** rh0nj has joined #bitcoin-core-dev
152019-01-15T01:32:21 *** Tralfaz has quit IRC
162019-01-15T01:35:10 *** benthecarman has joined #bitcoin-core-dev
172019-01-15T01:36:08 <benthecarman> Is the mailing list down? It won't let me add myself
182019-01-15T01:37:06 *** wajz has joined #bitcoin-core-dev
192019-01-15T01:38:35 <wajz> Hi there!, just a simple question. I'm reading a blockchain paper which I would like to discuss. Is this an appropiate channel or there's any 'research channel'?
202019-01-15T01:39:56 *** Chris_Stewart_5 has joined #bitcoin-core-dev
212019-01-15T01:40:37 <kanzure> /join #bitcoin-wizards
222019-01-15T01:41:25 <wajz> Thanks kanzure
232019-01-15T01:51:19 *** ossifrage has quit IRC
242019-01-15T01:51:47 *** ossifrage has joined #bitcoin-core-dev
252019-01-15T02:12:31 *** dviola has quit IRC
262019-01-15T02:12:34 *** Chris_Stewart_5 has quit IRC
272019-01-15T02:16:04 *** Murch has quit IRC
282019-01-15T02:17:06 *** Murch has joined #bitcoin-core-dev
292019-01-15T02:23:27 *** wajz has quit IRC
302019-01-15T02:44:15 *** jb55 has joined #bitcoin-core-dev
312019-01-15T02:44:30 *** ddustin has joined #bitcoin-core-dev
322019-01-15T02:57:52 *** Dean_Guss has joined #bitcoin-core-dev
332019-01-15T03:01:21 *** AaronvanW has quit IRC
342019-01-15T03:01:51 *** bitcoin-git has joined #bitcoin-core-dev
352019-01-15T03:01:51 <bitcoin-git> [bitcoin] sdaftuar opened pull request #15169: WIP: Parallelize CheckInputs() in AcceptToMemoryPool() (master...2018-12-parallel-mempool-scriptchecks) https://github.com/bitcoin/bitcoin/pull/15169
362019-01-15T03:01:51 *** bitcoin-git has left #bitcoin-core-dev
372019-01-15T03:07:40 *** Krellan has quit IRC
382019-01-15T03:12:06 *** karlos has joined #bitcoin-core-dev
392019-01-15T03:12:16 *** bitcoin-git has joined #bitcoin-core-dev
402019-01-15T03:12:16 <bitcoin-git> [bitcoin] koalaman opened pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170
412019-01-15T03:12:16 *** bitcoin-git has left #bitcoin-core-dev
422019-01-15T03:18:33 *** Dean_Guss has quit IRC
432019-01-15T03:25:24 *** Dean_Guss has joined #bitcoin-core-dev
442019-01-15T03:39:29 *** dviola has joined #bitcoin-core-dev
452019-01-15T03:40:01 *** karlos has quit IRC
462019-01-15T04:00:17 *** Dean_Guss has quit IRC
472019-01-15T04:06:06 *** schnerch_ has joined #bitcoin-core-dev
482019-01-15T04:08:49 *** schnerchi has quit IRC
492019-01-15T04:10:25 *** rasrenato has joined #bitcoin-core-dev
502019-01-15T04:23:54 *** benthecarman has quit IRC
512019-01-15T04:27:10 *** dviola has quit IRC
522019-01-15T04:32:55 *** karlos has joined #bitcoin-core-dev
532019-01-15T04:55:52 *** DeanGuss has joined #bitcoin-core-dev
542019-01-15T05:06:35 *** sipa has quit IRC
552019-01-15T05:08:22 *** sipa has joined #bitcoin-core-dev
562019-01-15T05:19:01 *** rh0nj has quit IRC
572019-01-15T05:20:07 *** rh0nj has joined #bitcoin-core-dev
582019-01-15T05:36:36 *** qrestlove has quit IRC
592019-01-15T05:39:21 <meshcollider> gwillen: maybe only one or two more, hopefully promag or someone who commented early on is willing to do a full review
602019-01-15T05:54:40 *** spaced0ut has quit IRC
612019-01-15T06:01:13 *** qrestlove has joined #bitcoin-core-dev
622019-01-15T06:10:23 *** karlos has quit IRC
632019-01-15T06:11:17 *** Klox has joined #bitcoin-core-dev
642019-01-15T06:14:02 <gwillen> meshcollider: cool, thanks
652019-01-15T06:14:13 <gwillen> I would ping promag here but he doesn't seem to be on at the moment
662019-01-15T06:14:44 <meshcollider> He'll get pinged by my message anyway :)
672019-01-15T06:15:01 <gwillen> well he would if he were here, anyway :-)
682019-01-15T06:20:50 *** rhavar has quit IRC
692019-01-15T06:30:27 *** zenogais has quit IRC
702019-01-15T07:10:51 *** Krellan has joined #bitcoin-core-dev
712019-01-15T07:22:18 *** hebasto has joined #bitcoin-core-dev
722019-01-15T07:26:30 *** pinheadmz has joined #bitcoin-core-dev
732019-01-15T07:35:06 *** bitcoin-git has joined #bitcoin-core-dev
742019-01-15T07:35:06 <bitcoin-git> [bitcoin] Empact opened pull request #15171: test: Wait before cleanup on exit (master...test-wait-cleanup) https://github.com/bitcoin/bitcoin/pull/15171
752019-01-15T07:35:06 *** bitcoin-git has left #bitcoin-core-dev
762019-01-15T07:35:30 *** ddustin has quit IRC
772019-01-15T07:43:52 *** ddustin has joined #bitcoin-core-dev
782019-01-15T07:58:53 *** wangkaixuan has joined #bitcoin-core-dev
792019-01-15T08:00:19 *** wangkaixuan has quit IRC
802019-01-15T08:21:47 <gmaxwell> Security warning: if you scp files from a malicious ssh server, it can overwrite arbritary files in/under your target directory.
812019-01-15T08:27:14 <DeanGuss> so you're saying don't work with malicious ssh servers?
822019-01-15T08:38:33 *** karlos has joined #bitcoin-core-dev
832019-01-15T08:44:24 <booyah> gmaxwell: that seems like a serious bug. you are not controling the file name? scp foo@bar.org:/tmp/a.txt ./ can result in something else then ./a.txt ?
842019-01-15T08:59:39 <cjd> that's what it sounds like
852019-01-15T08:59:53 <cjd> or worse, a.txt as you expected plus also click_here_please.exe as well
862019-01-15T09:00:57 <cjd> or .bashrc or any of a plethora of other nasties
872019-01-15T09:03:58 *** setpill has joined #bitcoin-core-dev
882019-01-15T09:10:52 *** pinheadmz has quit IRC
892019-01-15T09:12:35 *** luc_ has joined #bitcoin-core-dev
902019-01-15T09:14:43 *** mistergold has joined #bitcoin-core-dev
912019-01-15T09:16:51 *** luc_ has quit IRC
922019-01-15T09:21:01 *** rh0nj has quit IRC
932019-01-15T09:23:07 <wumpus> wonder if rsync has the same problem? that's what I usually yse
942019-01-15T09:27:59 *** ExtraCrispy has joined #bitcoin-core-dev
952019-01-15T09:32:46 *** murrayn has quit IRC
962019-01-15T09:33:17 *** hebasto has quit IRC
972019-01-15T09:37:20 *** Guyver2 has joined #bitcoin-core-dev
982019-01-15T09:44:14 *** promag has joined #bitcoin-core-dev
992019-01-15T09:48:23 *** promag has quit IRC
1002019-01-15T09:50:01 <cjd> hmm, my intuition is that ssh to malicious machines is a minefield
1012019-01-15T09:51:40 *** promag has joined #bitcoin-core-dev
1022019-01-15T09:54:10 <promag> #14941 should be ready for last ack and merge
1032019-01-15T09:54:12 <gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
1042019-01-15T10:00:31 *** murrayn has joined #bitcoin-core-dev
1052019-01-15T10:04:56 *** kexkey has quit IRC
1062019-01-15T10:14:52 *** spinza has quit IRC
1072019-01-15T10:16:28 *** miknotauro has quit IRC
1082019-01-15T10:20:55 *** philgee has joined #bitcoin-core-dev
1092019-01-15T10:21:36 *** TheV01d_ has quit IRC
1102019-01-15T10:21:45 *** TheV01d_ has joined #bitcoin-core-dev
1112019-01-15T10:35:44 *** timothy has joined #bitcoin-core-dev
1122019-01-15T10:40:40 *** spinza has joined #bitcoin-core-dev
1132019-01-15T10:43:15 *** karlos has quit IRC
1142019-01-15T10:55:44 *** fanquake has joined #bitcoin-core-dev
1152019-01-15T11:03:18 *** rex4539 has quit IRC
1162019-01-15T11:19:14 *** timothy has quit IRC
1172019-01-15T11:21:12 *** AaronvanW has joined #bitcoin-core-dev
1182019-01-15T11:22:14 *** timothy has joined #bitcoin-core-dev
1192019-01-15T11:42:55 *** spinza has quit IRC
1202019-01-15T11:48:57 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1212019-01-15T11:50:39 *** spinza has joined #bitcoin-core-dev
1222019-01-15T11:55:02 *** rex4539 has joined #bitcoin-core-dev
1232019-01-15T12:07:32 *** rex4539 has quit IRC
1242019-01-15T12:21:14 *** guga has joined #bitcoin-core-dev
1252019-01-15T12:24:53 *** sakalli_ has joined #bitcoin-core-dev
1262019-01-15T12:25:10 *** sakalli_ has joined #bitcoin-core-dev
1272019-01-15T12:29:08 *** rh0nj has joined #bitcoin-core-dev
1282019-01-15T12:29:42 *** sakalli_ has quit IRC
1292019-01-15T12:30:45 *** Guyver2 has quit IRC
1302019-01-15T12:38:49 *** rex4539 has joined #bitcoin-core-dev
1312019-01-15T12:48:46 *** promag has quit IRC
1322019-01-15T12:53:56 *** fanquake has quit IRC
1332019-01-15T12:58:51 *** hebasto has joined #bitcoin-core-dev
1342019-01-15T13:07:07 *** Chris_Stewart_5 has quit IRC
1352019-01-15T13:11:43 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1362019-01-15T13:16:28 <wumpus> but do you ever know for sure that the machine you're sshing to is not 'malicious'? if exploits can easily travel from ssh servers to clients, this makes e.g. VMs mostly useless as an isolation mechanism
1372019-01-15T13:21:48 <wumpus> but yes, if you know you're sshing to a compromised machine it's good to be careful I guess
1382019-01-15T13:37:36 *** jungly has joined #bitcoin-core-dev
1392019-01-15T13:38:53 *** bitcoin-git has joined #bitcoin-core-dev
1402019-01-15T13:38:53 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf0c67b62c20...1b6fc3053045
1412019-01-15T13:38:54 <bitcoin-git> bitcoin/master c37851d João Barbosa: rpc: Make unloadwallet wait for complete wallet unload
1422019-01-15T13:38:54 <bitcoin-git> bitcoin/master 645e905 João Barbosa: doc: Add release notes for unloadwallet change to synchronous call
1432019-01-15T13:38:55 <bitcoin-git> bitcoin/master 1b6fc30 Wladimir J. van der Laan: Merge #14941: rpc: Make unloadwallet wait for complete wallet unload...
1442019-01-15T13:38:55 *** bitcoin-git has left #bitcoin-core-dev
1452019-01-15T13:39:34 *** bitcoin-git has joined #bitcoin-core-dev
1462019-01-15T13:39:34 <bitcoin-git> [bitcoin] laanwj closed pull request #14941: rpc: Make unloadwallet wait for complete wallet unload (master...2018-12-sync-unloadwallet) https://github.com/bitcoin/bitcoin/pull/14941
1472019-01-15T13:39:34 *** bitcoin-git has left #bitcoin-core-dev
1482019-01-15T13:43:49 <wumpus> whoa, bitcoin-git is *working* again
1492019-01-15T13:44:15 *** mistergo1d has joined #bitcoin-core-dev
1502019-01-15T13:46:06 *** mistergold has quit IRC
1512019-01-15T13:46:45 *** Chris_Stewart_5 has quit IRC
1522019-01-15T13:47:36 <wumpus> gkrizek: is that your bot now?
1532019-01-15T14:02:18 *** Emcy has quit IRC
1542019-01-15T14:12:06 *** Emcy has joined #bitcoin-core-dev
1552019-01-15T14:13:06 *** promag has joined #bitcoin-core-dev
1562019-01-15T14:21:20 *** bitcoin-git has joined #bitcoin-core-dev
1572019-01-15T14:21:20 <bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
1582019-01-15T14:21:20 *** bitcoin-git has left #bitcoin-core-dev
1592019-01-15T14:21:37 *** bitcoin-git has joined #bitcoin-core-dev
1602019-01-15T14:21:37 <bitcoin-git> [bitcoin] Mr-Leshiy reopened pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
1612019-01-15T14:21:37 *** bitcoin-git has left #bitcoin-core-dev
1622019-01-15T14:27:37 *** bitcoin-git has joined #bitcoin-core-dev
1632019-01-15T14:27:38 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b6fc3053045...a5daf70ffb80
1642019-01-15T14:27:38 <bitcoin-git> bitcoin/master a88640e Hennadii Stepanov: Fix minimized window bug on Linux...
1652019-01-15T14:27:39 <bitcoin-git> bitcoin/master a5daf70 Wladimir J. van der Laan: Merge #14594: qt: Fix minimized window bug on Linux...
1662019-01-15T14:27:39 *** bitcoin-git has left #bitcoin-core-dev
1672019-01-15T14:28:03 *** bitcoin-git has joined #bitcoin-core-dev
1682019-01-15T14:28:03 <bitcoin-git> [bitcoin] laanwj closed pull request #14594: qt: Fix minimized window bug on Linux (master...20181028-restore-minimized) https://github.com/bitcoin/bitcoin/pull/14594
1692019-01-15T14:28:03 *** bitcoin-git has left #bitcoin-core-dev
1702019-01-15T14:29:27 *** bitcoin-git has joined #bitcoin-core-dev
1712019-01-15T14:29:28 <bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160
1722019-01-15T14:29:28 *** bitcoin-git has left #bitcoin-core-dev
1732019-01-15T14:30:30 *** miknotauro has joined #bitcoin-core-dev
1742019-01-15T14:30:46 *** spaced0ut has joined #bitcoin-core-dev
1752019-01-15T14:33:24 *** owowo has joined #bitcoin-core-dev
1762019-01-15T14:34:26 <luke-jr> yikes re scp
1772019-01-15T14:34:31 <luke-jr> is there a CVE?
1782019-01-15T14:37:33 *** Guest51719 has joined #bitcoin-core-dev
1792019-01-15T14:41:55 *** bitcoin-git has joined #bitcoin-core-dev
1802019-01-15T14:41:56 <bitcoin-git> [bitcoin] laanwj closed pull request #14965: minor: fix extra "non" in source code comment (master...minor-comment-double-negation) https://github.com/bitcoin/bitcoin/pull/14965
1812019-01-15T14:41:56 *** bitcoin-git has left #bitcoin-core-dev
1822019-01-15T14:41:58 <timothy> luke-jr: yes, much CVE-s
1832019-01-15T14:42:18 <timothy> luke-jr: https://sintonen.fi/advisories/scp-client-multiple-vulnerabilities.txt
1842019-01-15T14:43:14 *** Murch has joined #bitcoin-core-dev
1852019-01-15T14:43:55 <wumpus> thanks timothy
1862019-01-15T14:44:00 <luke-jr> ^
1872019-01-15T14:44:30 <luke-jr> wumpus: rsync supports wildcards, so I suspect it has the same problem :/
1882019-01-15T14:44:45 <luke-jr> eg, rsync foo@bar:/path/to/\* ./
1892019-01-15T14:45:50 <wumpus> hmm true, but if you use a wildcard you're kind of asking for the remote to be able to overwrite any file locally (unless you provide the flag not to)
1902019-01-15T14:46:07 <wumpus> well any file within the destination path obviously not outside it
1912019-01-15T14:46:12 <luke-jr> wumpus: yes, but that feature implies the local client needs to do its own globbing check
1922019-01-15T14:47:20 *** qrestlove has quit IRC
1932019-01-15T14:48:00 <wumpus> luke-jr: but the remote can always lie about which files are available, I'd think
1942019-01-15T14:48:32 <wumpus> oh you mean to match against the globs, of course
1952019-01-15T14:49:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1962019-01-15T14:50:37 <wumpus> promag: please rebase #14458
1972019-01-15T14:50:40 <gribble> https://github.com/bitcoin/bitcoin/issues/14458 | WIP: Add JSON-RPC interface documentation by promag · Pull Request #14458 · bitcoin/bitcoin · GitHub
1982019-01-15T14:51:18 *** qrestlove has joined #bitcoin-core-dev
1992019-01-15T14:54:18 *** owowo has quit IRC
2002019-01-15T14:55:08 *** elichai2 has joined #bitcoin-core-dev
2012019-01-15T14:56:27 <gkrizek> wumpus: no, I commented about it when it started up yesterday. "GitHub IRC Service is out of its brown out until the 31st when itâs fully depreciated. Iâm still working on a replacement and itâs close to done. Will def be done before the 31st."
2022019-01-15T14:56:33 *** Guyver2 has joined #bitcoin-core-dev
2032019-01-15T14:56:39 <gkrizek> So it's still GitHub back for a couple weeks before it's really really dead
2042019-01-15T14:57:49 <wumpus> gkrizek: okay ! thanks again for working on it
2052019-01-15T14:58:10 <wumpus> apparently missed that comment :)
2062019-01-15T14:58:16 <gkrizek> No problem, happy to do it!
2072019-01-15T14:59:10 *** owowo has joined #bitcoin-core-dev
2082019-01-15T15:00:13 <promag> wumpus: on it
2092019-01-15T15:01:44 <promag> wumpus: #14958 could also go
2102019-01-15T15:01:46 <gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
2112019-01-15T15:01:51 <wumpus> ook
2122019-01-15T15:02:41 <wumpus> would be nice if MarcoFalke could take a look at that one
2132019-01-15T15:09:48 *** setpill has quit IRC
2142019-01-15T15:10:38 *** Guest51719 has quit IRC
2152019-01-15T15:11:57 <promag> no problem
2162019-01-15T15:15:58 *** muzaffer has joined #bitcoin-core-dev
2172019-01-15T15:18:25 <promag> there's like 1 month until feature freeze?
2182019-01-15T15:20:16 *** muzaffer has quit IRC
2192019-01-15T15:31:48 <wumpus> 'for (uint64_t j = static_cast<uint64_t>(1) << (i - 1); (j >> i) == 0; ++j) {'
2202019-01-15T15:32:14 <wumpus> isn't there a shorter way to do this? static_casting 1 to uint64_t seems... outrageous
2212019-01-15T15:32:58 *** michaelsdunn1 has joined #bitcoin-core-dev
2222019-01-15T15:38:36 <wumpus> (concerning #14151)
2232019-01-15T15:38:40 <gribble> https://github.com/bitcoin/bitcoin/issues/14151 | windows: Fix remaining compiler warnings (MSVC) by practicalswift · Pull Request #14151 · bitcoin/bitcoin · GitHub
2242019-01-15T15:39:29 <wumpus> promag: yes exactly a month you're right ! (#14438)
2252019-01-15T15:39:30 <gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
2262019-01-15T15:40:02 <luke-jr> at the very least it could be uint64_t(1)
2272019-01-15T15:40:22 <luke-jr> FWIW, I confirmed rsync IS vulnerable to the same
2282019-01-15T15:40:37 *** zenogais has joined #bitcoin-core-dev
2292019-01-15T15:40:49 <wumpus> luke-jr: thanks for the suggestion, will try
2302019-01-15T15:40:55 <luke-jr> (to reproduce, make a dummy shell script that just does exec ${SSH_ORIGINAL_COMMAND/dummyA\/a/dummyA\/*}, and use SSH forced commands to call it)
2312019-01-15T15:44:27 <sipa> wumpus: so it's counting from 2**(i-1) to (2**i)-1 ?
2322019-01-15T15:48:51 <phantomcircuit> wumpus, remote can also send sym and hard links with rsync so like... yeah
2332019-01-15T15:49:21 <luke-jr> phantomcircuit: depends on client configuration in theory
2342019-01-15T15:49:30 <luke-jr> and that's expected behaviour at least
2352019-01-15T15:49:38 <phantomcircuit> luke-jr, iirc the flags just control what the client requests
2362019-01-15T15:50:00 <wumpus> sipa: it kind of confuses me, according to the test it's supposed to generate bit patterns in j with i bits set
2372019-01-15T15:50:05 <luke-jr> phantomcircuit: ugh
2382019-01-15T15:50:38 *** rex4539 has quit IRC
2392019-01-15T15:51:15 <phantomcircuit> luke-jr, tons of stuff works that way
2402019-01-15T15:51:36 <luke-jr> wumpus: actually, looking at that further looks .. dumb
2412019-01-15T15:52:45 * luke-jr wonders wtf that's *trying* to do
2422019-01-15T15:56:58 *** promag has quit IRC
2432019-01-15T15:58:09 *** promag has joined #bitcoin-core-dev
2442019-01-15T15:58:24 <luke-jr> for (unsigned j = 1U << (i - 1); (j >> i) == 0; ++j) {
2452019-01-15T15:59:37 <wumpus> that creates an 'unsigned int' which is probably 32 bit, won't the shift potentially shift out of the register or even create undefined behavior
2462019-01-15T16:03:02 <luke-jr> wumpus: unsigned int is guaranteed to be at least 16-bit, and this is only done when i is <10
2472019-01-15T16:04:17 <wumpus> hhmm okay
2482019-01-15T16:04:45 <wumpus> I... don't think adding that reliance is very nice
2492019-01-15T16:05:21 <luke-jr> it's gotta rely on some bit width regardless. no reason to do 64-bit when we know it won't be 64-bit :p
2502019-01-15T16:05:51 <wumpus> the input to that bitcounting function is 64-bit, and it's a test for that, so limiting it at that makes some sense
2512019-01-15T16:06:08 <luke-jr> and if the standards-required assumption of 16-bit ever fails, the test will just fail
2522019-01-15T16:06:37 <luke-jr> which we probably want anyway, considering other code currently assumes it's 32-bit :p
2532019-01-15T16:11:46 *** philgee has quit IRC
2542019-01-15T16:12:38 <wumpus> true; I wish C++ had 1u64 like rust
2552019-01-15T16:13:01 *** guga has quit IRC
2562019-01-15T16:14:07 <sipa> e could define a user-defined literal for it
2572019-01-15T16:14:12 <sipa> c++11 feature :)
2582019-01-15T16:15:29 <wumpus> interesting
2592019-01-15T16:16:45 <luke-jr> sipa: ?
2602019-01-15T16:16:46 <wumpus> nice feature, I don't think that's used anywhere in the code yet
2612019-01-15T16:17:32 <wumpus> https://en.cppreference.com/w/cpp/language/user_literal
2622019-01-15T16:17:43 <sipa> luke-jr: in c++11 you can define compile-time code to evaluate expressions of the form 1234_u64 for example
2632019-01-15T16:18:26 <wumpus> kind of overkill for this, but still, nice :)
2642019-01-15T16:18:30 <sipa> kinda surprising they didn't include a few default instances of it in the std library for things like this
2652019-01-15T16:19:05 <luke-jr> wow
2662019-01-15T16:19:06 <wumpus> looks like they defined a few default instances for std::complex and std::chrono::*
2672019-01-15T16:19:13 <wumpus> but not this unfortunately yeh
2682019-01-15T16:19:37 <wumpus> oh wait that's *C++14* nm\
2692019-01-15T16:19:47 <sipa> and only in c++14, and a few more in c++20
2702019-01-15T16:22:19 <wumpus> right
2712019-01-15T16:25:21 *** miknotauro has quit IRC
2722019-01-15T16:26:50 *** miknotauro has joined #bitcoin-core-dev
2732019-01-15T16:30:01 *** rh0nj has quit IRC
2742019-01-15T16:31:07 *** rh0nj has joined #bitcoin-core-dev
2752019-01-15T16:32:07 *** miknotauro has quit IRC
2762019-01-15T16:37:17 *** drexl has joined #bitcoin-core-dev
2772019-01-15T16:39:43 *** bitcoin-git has joined #bitcoin-core-dev
2782019-01-15T16:39:44 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5daf70ffb80...e8ad580f5153
2792019-01-15T16:39:44 <bitcoin-git> bitcoin/master fb3ce75 Hennadii Stepanov: Don't label transactions "Open" while catching up...
2802019-01-15T16:39:45 <bitcoin-git> bitcoin/master e8ad580 Wladimir J. van der Laan: Merge #14556: qt: fix confirmed transaction labeled "open" (#13299)...
2812019-01-15T16:39:45 *** bitcoin-git has left #bitcoin-core-dev
2822019-01-15T16:40:21 *** bitcoin-git has joined #bitcoin-core-dev
2832019-01-15T16:40:22 <bitcoin-git> [bitcoin] laanwj closed pull request #14556: qt: fix confirmed transaction labeled "open" (#13299) (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556
2842019-01-15T16:40:22 *** bitcoin-git has left #bitcoin-core-dev
2852019-01-15T16:42:41 *** bitcoin-git has joined #bitcoin-core-dev
2862019-01-15T16:42:42 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8ad580f5153...eb2aecfb8066
2872019-01-15T16:42:43 <bitcoin-git> bitcoin/master 03b8596 TheCharlatan: Add checksum in gitian build scripts for ossl...
2882019-01-15T16:42:43 <bitcoin-git> bitcoin/master eb2aecf Wladimir J. van der Laan: Merge #14433: Add checksum in gitian build scripts for ossl...
2892019-01-15T16:42:44 *** bitcoin-git has left #bitcoin-core-dev
2902019-01-15T16:43:06 *** bitcoin-git has joined #bitcoin-core-dev
2912019-01-15T16:43:06 <bitcoin-git> [bitcoin] laanwj closed pull request #14433: Add checksum in gitian build scripts for ossl (master...osslChecksum) https://github.com/bitcoin/bitcoin/pull/14433
2922019-01-15T16:43:06 *** bitcoin-git has left #bitcoin-core-dev
2932019-01-15T16:48:15 *** promag has quit IRC
2942019-01-15T16:51:37 *** pinheadmz has joined #bitcoin-core-dev
2952019-01-15T16:57:48 *** rex4539 has joined #bitcoin-core-dev
2962019-01-15T17:16:00 *** jarthur has joined #bitcoin-core-dev
2972019-01-15T17:21:51 *** promag has joined #bitcoin-core-dev
2982019-01-15T17:26:23 *** promag has quit IRC
2992019-01-15T17:32:24 *** pinheadmz has quit IRC
3002019-01-15T17:32:55 *** pinheadmz has joined #bitcoin-core-dev
3012019-01-15T17:39:44 *** lnostdal has quit IRC
3022019-01-15T17:41:56 *** jungly has quit IRC
3032019-01-15T17:42:31 *** lnostdal has joined #bitcoin-core-dev
3042019-01-15T17:51:15 *** promag has joined #bitcoin-core-dev
3052019-01-15T17:58:10 *** promag has quit IRC
3062019-01-15T18:02:27 *** Guest9_ has joined #bitcoin-core-dev
3072019-01-15T18:02:42 *** Guest9_ is now known as ThomasLuong
3082019-01-15T18:03:06 *** jimmysong has joined #bitcoin-core-dev
3092019-01-15T18:03:31 *** ThomasLuong is now known as luongthomas_
3102019-01-15T18:04:04 *** luongthomas_ is now known as luongthomas
3112019-01-15T18:04:42 *** luongthomas is now known as ThomasLuong
3122019-01-15T18:14:01 *** promag has joined #bitcoin-core-dev
3132019-01-15T18:15:25 *** ddustin_ has joined #bitcoin-core-dev
3142019-01-15T18:15:28 *** Chris_Stewart_5 has quit IRC
3152019-01-15T18:16:22 *** ddustin has quit IRC
3162019-01-15T18:30:31 *** soundsalad has joined #bitcoin-core-dev
3172019-01-15T18:35:43 *** promag has quit IRC
3182019-01-15T18:37:18 *** timothy has quit IRC
3192019-01-15T18:37:42 *** promag has joined #bitcoin-core-dev
3202019-01-15T18:39:05 <dongcarl> Anything else that needs doing for: https://github.com/bitcoin/bitcoin/pull/12255
3212019-01-15T18:42:40 <luke-jr> dongcarl: the release notes seem wrong
3222019-01-15T18:43:08 <dongcarl> luke-jr: Comment on the PR, happy to fix.
3232019-01-15T18:43:17 <luke-jr> yeah, will do
3242019-01-15T18:44:03 <luke-jr> (it's actually init.md)
3252019-01-15T18:44:17 *** bitcoin-git has joined #bitcoin-core-dev
3262019-01-15T18:44:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/eb2aecfb8066...82ffd4d91832
3272019-01-15T18:44:18 <bitcoin-git> bitcoin/master fac4558 MarcoFalke: sync: Add RecursiveMutex type alias
3282019-01-15T18:44:18 <bitcoin-git> bitcoin/master fafe941 MarcoFalke: test: Add missing validation locks
3292019-01-15T18:44:19 <bitcoin-git> bitcoin/master fa5c346 MarcoFalke: doc: Add comment to cs_main and mempool::cs
3302019-01-15T18:44:19 *** bitcoin-git has left #bitcoin-core-dev
3312019-01-15T18:44:36 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3322019-01-15T18:44:56 *** bitcoin-git has joined #bitcoin-core-dev
3332019-01-15T18:44:56 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14963: mempool, validation: Explain cs_main locking semantics (master...Mf1812-docValLocks) https://github.com/bitcoin/bitcoin/pull/14963
3342019-01-15T18:44:56 *** bitcoin-git has left #bitcoin-core-dev
3352019-01-15T18:46:05 <dongcarl> luke-jr: Thanks!
3362019-01-15T18:50:50 *** ddustin_ has quit IRC
3372019-01-15T18:51:27 *** ddustin has joined #bitcoin-core-dev
3382019-01-15T18:56:20 *** ddustin has quit IRC
3392019-01-15T18:58:46 *** bitcoin-git has joined #bitcoin-core-dev
3402019-01-15T18:58:46 <bitcoin-git> [bitcoin] Sjors opened pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173
3412019-01-15T18:58:46 *** bitcoin-git has left #bitcoin-core-dev
3422019-01-15T19:01:35 *** hebasto has quit IRC
3432019-01-15T19:02:22 *** bitcoin-git has joined #bitcoin-core-dev
3442019-01-15T19:02:22 <bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/82ffd4d91832...c7c84209bb0a
3452019-01-15T19:02:23 <bitcoin-git> bitcoin/master f411c8b João Barbosa: gui: Remove unused return type in some BitcoinGUI methods
3462019-01-15T19:02:23 <bitcoin-git> bitcoin/master 8a79261 João Barbosa: gui: Keep network style in BitcoinGUI
3472019-01-15T19:02:24 <bitcoin-git> bitcoin/master fe7048b João Barbosa: gui: Show current wallet name in window title
3482019-01-15T19:02:24 *** bitcoin-git has left #bitcoin-core-dev
3492019-01-15T19:02:58 *** bitcoin-git has joined #bitcoin-core-dev
3502019-01-15T19:02:58 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #15149: gui: Show current wallet name in window title (master...2019-01-updatewindowtitle) https://github.com/bitcoin/bitcoin/pull/15149
3512019-01-15T19:02:58 *** bitcoin-git has left #bitcoin-core-dev
3522019-01-15T19:16:19 *** soundsalad has quit IRC
3532019-01-15T19:26:39 *** Krellan has quit IRC
3542019-01-15T19:28:51 *** pinheadmz has quit IRC
3552019-01-15T19:30:06 *** pinheadmz has joined #bitcoin-core-dev
3562019-01-15T19:34:19 *** DougieBot5000_ has joined #bitcoin-core-dev
3572019-01-15T19:34:23 <jamesob> is there any good reason that ofstream objects can't be used as a stream with the serialize functions?
3582019-01-15T19:35:56 <sipa> jamesob: i think it just diverged; they used to implement a similar interface, but nothing used stdlib stream objects, so changes over time broke the compatibility?
3592019-01-15T19:36:08 <sipa> what causes it? the GetVersion etc?
3602019-01-15T19:37:57 <jamesob> trying to figure that out atm but I don't think it's GetVersion; top line of the compiler barf is
3612019-01-15T19:37:58 <jamesob> ./compressor.h:55:15: error: invalid operands to binary expression ('std::basic_ofstream<char>' and 'Span<typename std::remove_pointer<decltype(std::declval<vector<unsigned char, allocator<unsigned char> > >().data())>::type>' (aka 'Span<unsigned char>'))
3622019-01-15T19:38:08 *** DougieBot5000 has quit IRC
3632019-01-15T19:38:57 <jamesob> in the meantime I can do a CDataStream intermediary I guess
3642019-01-15T19:40:32 <gwillen> heh, I just tried to do this the other day
3652019-01-15T19:40:36 <gwillen> and assumed it was just not meant to work
3662019-01-15T19:40:52 <gwillen> and wrote a little std::string returning wrapper around CDataStream nonsense instead
3672019-01-15T19:44:55 <jamesob> ah funny. I'm dealing with binary and so want to avoid string
3682019-01-15T19:44:55 *** riemann has joined #bitcoin-core-dev
3692019-01-15T19:54:40 *** Aaronvan_ has joined #bitcoin-core-dev
3702019-01-15T19:57:12 *** Aaronva__ has joined #bitcoin-core-dev
3712019-01-15T19:57:34 *** AaronvanW has quit IRC
3722019-01-15T19:58:57 *** Aaronvan_ has quit IRC
3732019-01-15T20:00:02 *** pinheadmz has quit IRC
3742019-01-15T20:01:10 *** Aaronva__ is now known as AaronvanW
3752019-01-15T20:22:53 *** Murch has quit IRC
3762019-01-15T20:27:40 *** StopAndDecrypt has joined #bitcoin-core-dev
3772019-01-15T20:32:01 *** rh0nj has quit IRC
3782019-01-15T20:37:38 *** pinheadmz has joined #bitcoin-core-dev
3792019-01-15T20:38:12 *** Murch has joined #bitcoin-core-dev
3802019-01-15T20:42:07 <luke-jr> followup on the random_tests failure the other day, apparently some are seeing it with raii_tests instead: https://bugs.gentoo.org/675546 :/
3812019-01-15T20:46:48 *** DougieBot5000_ is now known as DougieBot5000
3822019-01-15T20:46:52 *** Krellan has joined #bitcoin-core-dev
3832019-01-15T20:48:55 *** morcos has quit IRC
3842019-01-15T20:49:19 *** morcos has joined #bitcoin-core-dev
3852019-01-15T20:51:18 *** Krellan has quit IRC
3862019-01-15T20:53:59 *** mistergold has joined #bitcoin-core-dev
3872019-01-15T20:57:08 *** mistergo1d has quit IRC
3882019-01-15T20:58:14 *** ThomasLuong has quit IRC
3892019-01-15T21:00:12 *** Murch has quit IRC
3902019-01-15T21:05:37 *** DougieBot5000 has quit IRC
3912019-01-15T21:07:48 *** DougieBot5000 has joined #bitcoin-core-dev
3922019-01-15T21:08:08 *** achow101 has quit IRC
3932019-01-15T21:08:09 *** bitcoin-git has joined #bitcoin-core-dev
3942019-01-15T21:08:10 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7c84209bb0a...391a27376b30
3952019-01-15T21:08:11 <bitcoin-git> bitcoin/master 04215eb Sjors Provoost: [doc] explain what .python-version does
3962019-01-15T21:08:11 <bitcoin-git> bitcoin/master 391a273 MarcoFalke: Merge #15173: [doc] explain what .python-version does...
3972019-01-15T21:08:12 *** bitcoin-git has left #bitcoin-core-dev
3982019-01-15T21:08:49 *** bitcoin-git has joined #bitcoin-core-dev
3992019-01-15T21:08:50 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173
4002019-01-15T21:08:50 *** bitcoin-git has left #bitcoin-core-dev
4012019-01-15T21:17:34 *** jarthur has quit IRC
4022019-01-15T21:17:39 *** achow101 has joined #bitcoin-core-dev
4032019-01-15T21:28:27 *** mistergold has quit IRC
4042019-01-15T21:28:48 *** mistergold has joined #bitcoin-core-dev
4052019-01-15T21:37:49 *** booyah is now known as booyah_
4062019-01-15T21:39:23 *** booyah_ is now known as booyah
4072019-01-15T21:41:43 *** Murch has joined #bitcoin-core-dev
4082019-01-15T22:00:39 <ryanofsky> jamesob, std::string is fine for binary data
4092019-01-15T22:05:51 <gwillen> I can confirm what ryanofsky
4102019-01-15T22:05:55 <gwillen> says*
4112019-01-15T22:06:06 <gwillen> I checked this very carefully before going that route, it was slightly surprising to me too
4122019-01-15T22:06:28 <gwillen> std::string will happily hold binary data as long as you do not like, call c_str and try to use the result as a zero-terminated string
4132019-01-15T22:06:33 <gwillen> but std::string itself is 100% binary safe
4142019-01-15T22:09:12 *** spinza has quit IRC
4152019-01-15T22:11:59 *** Chris_Stewart_5 has quit IRC
4162019-01-15T22:13:30 *** spinza has joined #bitcoin-core-dev
4172019-01-15T22:28:42 *** jarthur has joined #bitcoin-core-dev
4182019-01-15T22:29:30 *** sfhi has joined #bitcoin-core-dev
4192019-01-15T22:31:56 *** miknotauro has joined #bitcoin-core-dev
4202019-01-15T22:32:30 *** jarthur has quit IRC
4212019-01-15T22:44:05 *** ThomasLuong has joined #bitcoin-core-dev
4222019-01-15T22:44:26 *** tryphe has quit IRC
4232019-01-15T22:44:50 *** tryphe has joined #bitcoin-core-dev
4242019-01-15T22:48:58 *** spaced0ut has quit IRC
4252019-01-15T22:57:12 <luke-jr> gwillen: in standard or practice only?
4262019-01-15T22:58:51 <gwillen> in standard
4272019-01-15T23:00:47 <sipa> std::string is just a weirdly specialized vector of chars
4282019-01-15T23:02:42 <gwillen> and much to my chagrin, in Clang its iterator is interchangeable with one to a vector<char> but in g++ it is not.
4292019-01-15T23:04:52 *** elichai2 has quit IRC
4302019-01-15T23:06:19 <gmaxwell> but why not use a vector<char> ? :)
4312019-01-15T23:08:54 <gwillen> in my case it was because there are other interfaces that use std::string
4322019-01-15T23:08:59 <gwillen> and converting back and forth is extra lines of code
4332019-01-15T23:26:13 *** sfhi has quit IRC
4342019-01-15T23:37:34 *** michaelsdunn1 has quit IRC
4352019-01-15T23:55:50 *** mistergold has quit IRC
4362019-01-15T23:58:08 *** rh0nj has joined #bitcoin-core-dev