1 2019-01-16T00:16:42  *** miknotauro has quit IRC
  2 2019-01-16T00:21:08  <gwillen> promag: would you be interested in doing a full review of #14978
  3 2019-01-16T00:21:10  <gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
  4 2019-01-16T00:21:19  <gwillen> (meshcollider mentioned your name but you weren't on at the time)
  5 2019-01-16T00:21:35  <gwillen> he was suggesting a couple more reviews
  6 2019-01-16T00:27:53  <sipa> gwillen: i will review soon
  7 2019-01-16T00:34:27  <promag> will do tomorrow
  8 2019-01-16T00:38:15  *** ddustin has joined #bitcoin-core-dev
  9 2019-01-16T00:41:46  *** Guyver2 has quit IRC
 10 2019-01-16T00:51:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 11 2019-01-16T00:54:41  *** StopAndDecrypt has quit IRC
 12 2019-01-16T01:00:16  *** StopAndDecrypt has joined #bitcoin-core-dev
 13 2019-01-16T01:02:02  *** promag has quit IRC
 14 2019-01-16T01:02:31  *** pinheadmz has quit IRC
 15 2019-01-16T01:03:36  *** fanquake has joined #bitcoin-core-dev
 16 2019-01-16T01:10:03  *** Chris_Stewart_5 has quit IRC
 17 2019-01-16T01:11:42  <gwillen> thanks sipa and promag!
 18 2019-01-16T01:30:08  *** ThomasLuong has quit IRC
 19 2019-01-16T02:44:02  *** miknotauro has joined #bitcoin-core-dev
 20 2019-01-16T02:51:14  *** pinheadmz has joined #bitcoin-core-dev
 21 2019-01-16T02:54:52  *** miknotauro has quit IRC
 22 2019-01-16T02:56:15  *** kexkey has joined #bitcoin-core-dev
 23 2019-01-16T02:57:20  *** kexkey_ has joined #bitcoin-core-dev
 24 2019-01-16T03:01:07  *** kexkey has quit IRC
 25 2019-01-16T03:17:38  *** pinheadmz has quit IRC
 26 2019-01-16T03:52:30  *** AaronvanW has quit IRC
 27 2019-01-16T03:52:54  *** Murch has quit IRC
 28 2019-01-16T03:53:34  *** ThomasLuong has joined #bitcoin-core-dev
 29 2019-01-16T03:56:08  *** promag has joined #bitcoin-core-dev
 30 2019-01-16T03:56:14  *** pinheadmz has joined #bitcoin-core-dev
 31 2019-01-16T04:00:44  *** promag has quit IRC
 32 2019-01-16T04:05:44  *** schnerchi has joined #bitcoin-core-dev
 33 2019-01-16T04:08:23  *** schnerch_ has quit IRC
 34 2019-01-16T04:11:29  *** Murch has joined #bitcoin-core-dev
 35 2019-01-16T04:26:27  *** Cory has quit IRC
 36 2019-01-16T04:32:47  *** Pasha has joined #bitcoin-core-dev
 37 2019-01-16T04:34:49  *** pinheadmz has quit IRC
 38 2019-01-16T04:35:58  *** Pasha is now known as Cory
 39 2019-01-16T04:39:36  *** riemann_ has joined #bitcoin-core-dev
 40 2019-01-16T04:42:08  *** riemann has quit IRC
 41 2019-01-16T04:49:54  *** shesek has joined #bitcoin-core-dev
 42 2019-01-16T04:49:54  *** shesek has quit IRC
 43 2019-01-16T04:49:54  *** shesek has joined #bitcoin-core-dev
 44 2019-01-16T05:10:27  *** Murch has quit IRC
 45 2019-01-16T05:56:40  *** miknotauro has joined #bitcoin-core-dev
 46 2019-01-16T06:33:11  *** brianhoffman_ has joined #bitcoin-core-dev
 47 2019-01-16T06:35:46  *** brianhoffman has quit IRC
 48 2019-01-16T06:35:46  *** brianhoffman_ is now known as brianhoffman
 49 2019-01-16T06:36:56  *** Krellan has joined #bitcoin-core-dev
 50 2019-01-16T06:48:03  *** zenogais has quit IRC
 51 2019-01-16T07:09:11  *** guga has joined #bitcoin-core-dev
 52 2019-01-16T07:09:21  *** guga_ has joined #bitcoin-core-dev
 53 2019-01-16T07:18:20  *** miknotauro has quit IRC
 54 2019-01-16T07:21:35  *** tronglx has joined #bitcoin-core-dev
 55 2019-01-16T07:24:24  *** a5m0 has quit IRC
 56 2019-01-16T07:27:31  *** promag has joined #bitcoin-core-dev
 57 2019-01-16T07:28:21  *** ThomasLuong has quit IRC
 58 2019-01-16T07:30:21  *** tronglx has left #bitcoin-core-dev
 59 2019-01-16T07:30:38  *** promag has quit IRC
 60 2019-01-16T07:36:49  <wumpus> yes, std::string is binary safe, it is string encoding agnostic and doesn't enforce, like rust's strings, UTF-8. That said, using it for arbitrary binary data is bad because it communicates to developers "this is a string!".
 61 2019-01-16T07:39:43  *** a5m0 has joined #bitcoin-core-dev
 62 2019-01-16T07:56:25  *** promag has joined #bitcoin-core-dev
 63 2019-01-16T08:00:02  *** promag has quit IRC
 64 2019-01-16T08:01:02  *** ddustin has quit IRC
 65 2019-01-16T08:01:26  *** ddustin has joined #bitcoin-core-dev
 66 2019-01-16T08:13:54  *** hebasto has joined #bitcoin-core-dev
 67 2019-01-16T08:18:18  *** luc___ has joined #bitcoin-core-dev
 68 2019-01-16T08:20:06  *** jungly_ has joined #bitcoin-core-dev
 69 2019-01-16T08:26:11  *** luc___ has quit IRC
 70 2019-01-16T08:36:08  *** luc___ has joined #bitcoin-core-dev
 71 2019-01-16T08:37:07  *** ThomasLuong has joined #bitcoin-core-dev
 72 2019-01-16T08:41:01  *** spinza has quit IRC
 73 2019-01-16T08:55:28  *** spinza has joined #bitcoin-core-dev
 74 2019-01-16T09:07:34  *** setpill has joined #bitcoin-core-dev
 75 2019-01-16T09:10:11  *** bitcoin-git has joined #bitcoin-core-dev
 76 2019-01-16T09:10:12  <bitcoin-git> [bitcoin] Empact opened pull request #15175: build: Drop macports support (master...drop-macports) https://github.com/bitcoin/bitcoin/pull/15175
 77 2019-01-16T09:10:12  *** bitcoin-git has left #bitcoin-core-dev
 78 2019-01-16T09:12:40  *** ddustin has quit IRC
 79 2019-01-16T09:13:10  *** ddustin has joined #bitcoin-core-dev
 80 2019-01-16T09:16:31  <wumpus> std::vector<uint8_t> would be the preferred type for 'arbitrary binary blob'-IMO
 81 2019-01-16T09:16:36  *** Guyver2 has joined #bitcoin-core-dev
 82 2019-01-16T09:17:59  *** ddustin has quit IRC
 83 2019-01-16T09:34:18  *** Deinogalerix21 has joined #bitcoin-core-dev
 84 2019-01-16T09:35:27  *** promag has joined #bitcoin-core-dev
 85 2019-01-16T09:39:07  *** Deinogalerix21 has quit IRC
 86 2019-01-16T09:40:11  *** ExtraCrispy has quit IRC
 87 2019-01-16T09:45:33  <promag> can I have #15002 in HP->backport?
 88 2019-01-16T09:45:36  <gribble> https://github.com/bitcoin/bitcoin/issues/15002 | 0.17: Backport #14941 by promag · Pull Request #15002 · bitcoin/bitcoin · GitHub
 89 2019-01-16T09:46:47  <wumpus> sure!
 90 2019-01-16T09:46:49  <promag> and #15101 should be ready, I think after provoostenator review it could be merged
 91 2019-01-16T09:46:51  <gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
 92 2019-01-16T09:47:04  <promag> it would be great to avoid chaining prs
 93 2019-01-16T09:47:15  <provoostenator> Will review, but I'm going through the RNG stuff now :-)
 94 2019-01-16T09:47:49  <promag> provoostenator: cool, stay with that :D
 95 2019-01-16T09:47:59  <wumpus> 15002 already has the tag backport
 96 2019-01-16T09:48:21  <wumpus> it's impossible to avoid chaining PRs ,some work always depends on previous work that isn't merged yet
 97 2019-01-16T09:49:17  <promag> wumpus: sure
 98 2019-01-16T09:49:18  <wumpus> I agree it can be confusing, especially if the PR texts aren't clear on it, but in itself it's unavoidable; you can't expect people to keep working on something just because the precursor isn't merged yet
 99 2019-01-16T09:49:34  <wumpus> eh *stop working on something*
100 2019-01-16T09:49:40  <promag> wumpus: I usually prefer that than big prs
101 2019-01-16T09:51:57  <promag> btw
102 2019-01-16T09:53:29  <promag> wdyt about https://github.com/bitcoin/bitcoin/pull/13339#discussion_r246725075?
103 2019-01-16T09:59:28  *** luc____ has joined #bitcoin-core-dev
104 2019-01-16T10:02:55  *** luc___ has quit IRC
105 2019-01-16T10:05:10  *** kexkey_ has quit IRC
106 2019-01-16T10:05:41  *** dermoth has quit IRC
107 2019-01-16T10:09:47  *** Skirmant has quit IRC
108 2019-01-16T10:10:29  *** timothy has joined #bitcoin-core-dev
109 2019-01-16T10:10:45  <fanquake> evening
110 2019-01-16T10:14:13  *** spinza has quit IRC
111 2019-01-16T10:16:13  *** Skirmant has joined #bitcoin-core-dev
112 2019-01-16T10:19:06  *** spinza has joined #bitcoin-core-dev
113 2019-01-16T10:19:12  <wumpus> evening!
114 2019-01-16T10:19:40  *** dermoth has joined #bitcoin-core-dev
115 2019-01-16T10:23:18  *** bitcoin-git has joined #bitcoin-core-dev
116 2019-01-16T10:23:18  <bitcoin-git> [bitcoin] merland opened pull request #15176: Rename README_osx.md (master...rename-osx-readme) https://github.com/bitcoin/bitcoin/pull/15176
117 2019-01-16T10:23:18  *** bitcoin-git has left #bitcoin-core-dev
118 2019-01-16T10:25:53  *** luc____ has quit IRC
119 2019-01-16T10:26:15  *** luc___ has joined #bitcoin-core-dev
120 2019-01-16T10:27:48  *** luc___ has quit IRC
121 2019-01-16T10:29:48  *** ThomasLuong has quit IRC
122 2019-01-16T10:33:08  *** Skirmant has quit IRC
123 2019-01-16T10:35:29  *** laurentmt has joined #bitcoin-core-dev
124 2019-01-16T10:39:34  *** laurentmt has quit IRC
125 2019-01-16T10:41:01  *** rh0nj has quit IRC
126 2019-01-16T10:42:07  *** rh0nj has joined #bitcoin-core-dev
127 2019-01-16T10:50:39  *** Skirmant has joined #bitcoin-core-dev
128 2019-01-16T10:58:24  *** AaronvanW has joined #bitcoin-core-dev
129 2019-01-16T11:04:02  *** bitcoin-git has joined #bitcoin-core-dev
130 2019-01-16T11:04:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/391a27376b30...16c4a5373b87
131 2019-01-16T11:04:04  <bitcoin-git> bitcoin/master cbd9091 Vidar Holen: refactor/lint: Add ignored suggestions to an array...
132 2019-01-16T11:04:04  <bitcoin-git> bitcoin/master 16c4a53 Wladimir J. van der Laan: Merge #15170: refactor/lint: Add ignored shellcheck suggestions to an array...
133 2019-01-16T11:04:05  *** bitcoin-git has left #bitcoin-core-dev
134 2019-01-16T11:04:55  *** bitcoin-git has joined #bitcoin-core-dev
135 2019-01-16T11:04:55  <bitcoin-git> [bitcoin] laanwj closed pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170
136 2019-01-16T11:04:55  *** bitcoin-git has left #bitcoin-core-dev
137 2019-01-16T11:12:53  *** bitcoin-git has joined #bitcoin-core-dev
138 2019-01-16T11:12:54  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/16c4a5373b87...bcdd31f26569
139 2019-01-16T11:12:54  <bitcoin-git> bitcoin/master 059a3cf Wladimir J. van der Laan: contrib: Detailed reporting for http errors in github-merge...
140 2019-01-16T11:12:55  <bitcoin-git> bitcoin/master a4c5bbf Wladimir J. van der Laan: contrib: Add support for http[s] URLs in github-merge...
141 2019-01-16T11:12:55  <bitcoin-git> bitcoin/master f1bd219 Wladimir J. van der Laan: contrib: Allow use of github API authentication in github-merge...
142 2019-01-16T11:12:56  *** bitcoin-git has left #bitcoin-core-dev
143 2019-01-16T11:13:30  *** bitcoin-git has joined #bitcoin-core-dev
144 2019-01-16T11:13:30  <bitcoin-git> [bitcoin] laanwj closed pull request #15165: contrib: Allow use of github API authentication in github-merge (master...2019_01_ghmerge) https://github.com/bitcoin/bitcoin/pull/15165
145 2019-01-16T11:13:30  *** bitcoin-git has left #bitcoin-core-dev
146 2019-01-16T11:15:10  <fanquake> +1 for 15170. Makes testing in random/temporary vms a bit easier
147 2019-01-16T11:20:08  *** mistergold has joined #bitcoin-core-dev
148 2019-01-16T11:24:47  <wumpus> pretty cool that the shellcheck author contributes himself
149 2019-01-16T11:25:32  <fanquake> yes. I wonder if he just stumbled on/was watching the project and decided to jump in, or someone reached out.
150 2019-01-16T11:25:37  *** drexl has quit IRC
151 2019-01-16T11:38:52  *** bitcoin-git has joined #bitcoin-core-dev
152 2019-01-16T11:38:53  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bcdd31f26569...acec9e45c6fb
153 2019-01-16T11:38:54  <bitcoin-git> bitcoin/master b0037c5 Hennadii Stepanov: Improve Peers tab layout...
154 2019-01-16T11:38:54  <bitcoin-git> bitcoin/master 3537c83 Hennadii Stepanov: Do not deselect peer when switching away from tab...
155 2019-01-16T11:38:55  <bitcoin-git> bitcoin/master acec9e4 Wladimir J. van der Laan: Merge #15136: qt: "Peers" tab overhaul...
156 2019-01-16T11:38:55  *** bitcoin-git has left #bitcoin-core-dev
157 2019-01-16T11:39:32  *** bitcoin-git has joined #bitcoin-core-dev
158 2019-01-16T11:39:33  <bitcoin-git> [bitcoin] laanwj closed pull request #15136: qt: "Peers" tab overhaul (master...20190109-peerstab-overhaul) https://github.com/bitcoin/bitcoin/pull/15136
159 2019-01-16T11:39:33  *** bitcoin-git has left #bitcoin-core-dev
160 2019-01-16T11:46:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
161 2019-01-16T11:46:58  *** bitcoin-git has joined #bitcoin-core-dev
162 2019-01-16T11:46:58  <bitcoin-git> [bitcoin] promag opened pull request #15177: doc: Explain empty result of /rest/headers (master...2019-01-restheadersdoc) https://github.com/bitcoin/bitcoin/pull/15177
163 2019-01-16T11:46:58  *** bitcoin-git has left #bitcoin-core-dev
164 2019-01-16T11:52:28  <promag> wumpus: Marco reviewed #14958 yesterday
165 2019-01-16T11:52:30  <gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
166 2019-01-16T11:52:40  <wumpus> promag: ok
167 2019-01-16T12:00:18  <wumpus> promag: whoops in commit message "qa: Remove race between conneting and shutdown"
168 2019-01-16T12:00:43  <promag> darn :D
169 2019-01-16T12:04:20  *** shesek has quit IRC
170 2019-01-16T12:05:52  <promag> wumpus: pushed
171 2019-01-16T12:05:54  *** bitcoin-git has joined #bitcoin-core-dev
172 2019-01-16T12:05:55  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/acec9e45c6fb...3ae3748ce1bd
173 2019-01-16T12:05:55  <bitcoin-git> bitcoin/master 4412a59 João Barbosa: qa: Remove race between connecting and shutdown on separate connections
174 2019-01-16T12:05:56  <bitcoin-git> bitcoin/master 3ae3748 Wladimir J. van der Laan: Merge #14958: qa: Remove race between connecting and shutdown on separate connections...
175 2019-01-16T12:05:56  *** bitcoin-git has left #bitcoin-core-dev
176 2019-01-16T12:06:36  *** bitcoin-git has joined #bitcoin-core-dev
177 2019-01-16T12:06:37  <bitcoin-git> [bitcoin] laanwj closed pull request #14958: qa: Remove race between connecting and shutdown on separate connections (master...2018-12-improve-shutdown-test) https://github.com/bitcoin/bitcoin/pull/14958
178 2019-01-16T12:06:37  *** bitcoin-git has left #bitcoin-core-dev
179 2019-01-16T12:07:46  *** bitcoin-git has joined #bitcoin-core-dev
180 2019-01-16T12:07:47  <bitcoin-git> [bitcoin] hebasto opened pull request #15178: qt: Improve "help-console" message (master...20190116-improve-help-console) https://github.com/bitcoin/bitcoin/pull/15178
181 2019-01-16T12:07:47  *** bitcoin-git has left #bitcoin-core-dev
182 2019-01-16T12:21:36  <hebasto> promag: mind reviewing #14409?
183 2019-01-16T12:21:37  <gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
184 2019-01-16T12:21:55  <promag> sure
185 2019-01-16T12:23:07  <hebasto> promag: thanks
186 2019-01-16T12:27:20  <promag> "Beside that, I'm considering EncodeBase64 the wallet name/path" is this shell friendly?
187 2019-01-16T12:27:41  <wumpus> I think that's a bad idea honestly
188 2019-01-16T12:28:29  <wumpus> WTF-github now hides utACKs as "one more similar comment" yeeh, thanks
189 2019-01-16T12:29:00  <promag> where? ^
190 2019-01-16T12:29:16  <wumpus> happened in #14409 to me, missed Marco's utACK due to that
191 2019-01-16T12:29:18  <gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub
192 2019-01-16T12:29:34  <echeveria> now you need an ack nonce.
193 2019-01-16T12:29:58  <wumpus> if you don't see it I can make a screenshot...
194 2019-01-16T12:30:11  <wumpus> echeveria: hah, or signed ACKs again
195 2019-01-16T12:37:16  *** hebasto has quit IRC
196 2019-01-16T12:38:12  *** drexl has joined #bitcoin-core-dev
197 2019-01-16T12:40:52  *** bitcoin-git has joined #bitcoin-core-dev
198 2019-01-16T12:40:52  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ae3748ce1bd...64ee94356fb4
199 2019-01-16T12:40:53  <bitcoin-git> bitcoin/master c3f1821 Hennadii Stepanov: Make blockdir always net specific...
200 2019-01-16T12:40:53  <bitcoin-git> bitcoin/master e4a0c35 Hennadii Stepanov: Improve blocksdir functional test....
201 2019-01-16T12:40:54  <bitcoin-git> bitcoin/master 64ee943 Wladimir J. van der Laan: Merge #14409: utils and libraries: Make 'blocksdir' always net specific...
202 2019-01-16T12:40:54  *** bitcoin-git has left #bitcoin-core-dev
203 2019-01-16T12:41:16  *** bitcoin-git has joined #bitcoin-core-dev
204 2019-01-16T12:41:16  <bitcoin-git> [bitcoin] laanwj closed pull request #14409: utils and libraries: Make 'blocksdir' always net specific (master...20181005-blockspath-always-netspecific) https://github.com/bitcoin/bitcoin/pull/14409
205 2019-01-16T12:41:16  *** bitcoin-git has left #bitcoin-core-dev
206 2019-01-16T12:42:17  *** tno23 has joined #bitcoin-core-dev
207 2019-01-16T12:48:20  *** tno23 has quit IRC
208 2019-01-16T12:50:27  *** Chris_Stewart_5 has quit IRC
209 2019-01-16T12:51:01  *** bitcoin-git has joined #bitcoin-core-dev
210 2019-01-16T12:51:02  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64ee94356fb4...19c60ca4975d
211 2019-01-16T12:51:02  <bitcoin-git> bitcoin/master b9dafe7 practicalswift: Fix remaining compiler warnings (MSVC). Move disabling of specific warnings from /nowarn to project file.
212 2019-01-16T12:51:03  <bitcoin-git> bitcoin/master 19c60ca Wladimir J. van der Laan: Merge #14151: windows: Fix remaining compiler warnings (MSVC)...
213 2019-01-16T12:51:03  *** bitcoin-git has left #bitcoin-core-dev
214 2019-01-16T12:51:23  *** bitcoin-git has joined #bitcoin-core-dev
215 2019-01-16T12:51:24  <bitcoin-git> [bitcoin] laanwj closed pull request #14151: windows: Fix remaining compiler warnings (MSVC) (master...fix-remaining-compiler-warnings-msvc) https://github.com/bitcoin/bitcoin/pull/14151
216 2019-01-16T12:51:24  *** bitcoin-git has left #bitcoin-core-dev
217 2019-01-16T13:09:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
218 2019-01-16T13:11:57  *** m8tion has joined #bitcoin-core-dev
219 2019-01-16T13:12:02  <wumpus> let's try to get #14605 in finally
220 2019-01-16T13:12:06  <gribble> https://github.com/bitcoin/bitcoin/issues/14605 | Return of the Banman by dongcarl · Pull Request #14605 · bitcoin/bitcoin · GitHub
221 2019-01-16T13:12:26  <wumpus> it has been reviewed a lot but surprisingly little (ut)ACKs
222 2019-01-16T13:17:19  *** m8tion_ has joined #bitcoin-core-dev
223 2019-01-16T13:20:37  *** m8tion has quit IRC
224 2019-01-16T13:20:45  *** Chris_Stewart_5 has quit IRC
225 2019-01-16T13:21:45  <wumpus> the original PR had three utACKs though
226 2019-01-16T13:46:18  *** mistergold has quit IRC
227 2019-01-16T13:47:20  *** mistergold has joined #bitcoin-core-dev
228 2019-01-16T13:48:47  *** mistergo1d has joined #bitcoin-core-dev
229 2019-01-16T13:52:15  *** mistergold has quit IRC
230 2019-01-16T13:56:52  *** bitcoin-git has joined #bitcoin-core-dev
231 2019-01-16T13:56:52  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/19c60ca4975d...d44b01f028e2
232 2019-01-16T13:56:53  <bitcoin-git> bitcoin/master 951a44e Ben Woosley: Drop unused setRange arg to BerkeleyBatch::ReadAtCursor
233 2019-01-16T13:56:53  <bitcoin-git> bitcoin/master 1a9f9f7 Ben Woosley: Introduce SafeDbt to handle DB_DBT_MALLOC raii-style...
234 2019-01-16T13:56:54  <bitcoin-git> bitcoin/master 4a86a0a Ben Woosley: Make SafeDbt DB_DBT_MALLOC on default initialization...
235 2019-01-16T13:56:54  *** bitcoin-git has left #bitcoin-core-dev
236 2019-01-16T13:57:16  *** bitcoin-git has joined #bitcoin-core-dev
237 2019-01-16T13:57:16  <bitcoin-git> [bitcoin] laanwj closed pull request #14268:  Introduce SafeDbt to handle Dbt with free or memory_cleanse raii-style (master...malloced-dbt) https://github.com/bitcoin/bitcoin/pull/14268
238 2019-01-16T13:57:16  *** bitcoin-git has left #bitcoin-core-dev
239 2019-01-16T14:11:46  *** kexkey has joined #bitcoin-core-dev
240 2019-01-16T14:12:59  *** mr9 has joined #bitcoin-core-dev
241 2019-01-16T14:15:04  *** merland has joined #bitcoin-core-dev
242 2019-01-16T14:26:02  *** merland has quit IRC
243 2019-01-16T14:36:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
244 2019-01-16T14:43:01  *** rh0nj has quit IRC
245 2019-01-16T14:44:08  *** rh0nj has joined #bitcoin-core-dev
246 2019-01-16T14:52:20  <promag> wumpus: checking #14605
247 2019-01-16T14:52:24  <gribble> https://github.com/bitcoin/bitcoin/issues/14605 | Return of the Banman by dongcarl · Pull Request #14605 · bitcoin/bitcoin · GitHub
248 2019-01-16T14:52:32  <wumpus> thank you
249 2019-01-16T15:00:17  *** bitcoin-git has joined #bitcoin-core-dev
250 2019-01-16T15:00:18  <bitcoin-git> [bitcoin] lontivero closed pull request #14939: rpc: Allow testmempoolaccept to test unsigned transactions (master...TestAcceptanceForUnsignedTransactions) https://github.com/bitcoin/bitcoin/pull/14939
251 2019-01-16T15:00:18  *** bitcoin-git has left #bitcoin-core-dev
252 2019-01-16T15:04:02  <dongcarl> w/re the banman PR, I'm not 100% sure about this discussion: https://github.com/bitcoin/bitcoin/pull/14605#discussion_r248050771
253 2019-01-16T15:04:52  <dongcarl> I don't know the intricacies of `static_cast` that well, and it seems like either there's something I'm not seeing or it was put there for no reason
254 2019-01-16T15:05:15  <sipa> i think empact is confused here
255 2019-01-16T15:06:36  <dongcarl> sipa: so no casting of any kind is needed there right? That would be cfields was also confused haha
256 2019-01-16T15:11:11  *** spaced0ut has joined #bitcoin-core-dev
257 2019-01-16T15:13:34  *** jhfrontz has quit IRC
258 2019-01-16T15:14:40  *** guga has quit IRC
259 2019-01-16T15:15:38  <promag> dongcarl: is this comment really correct https://github.com/bitcoin/bitcoin/pull/14605/commits/b4ca7e2933d9325728cee97f3de1438f330b124b#diff-eff7adeaec73a769788bb78858815c91R2969 ?
260 2019-01-16T15:15:41  *** bitcoin-git has joined #bitcoin-core-dev
261 2019-01-16T15:15:42  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d44b01f028e2...f71c2ea6620a
262 2019-01-16T15:15:42  <bitcoin-git> bitcoin/master b745e14 John Newbery: [docs] Expand help text for importmulti changes
263 2019-01-16T15:15:43  <bitcoin-git> bitcoin/master f71c2ea Wladimir J. van der Laan: Merge #15122: [RPC] Expand help text for importmulti changes...
264 2019-01-16T15:15:43  *** bitcoin-git has left #bitcoin-core-dev
265 2019-01-16T15:16:36  *** bitcoin-git has joined #bitcoin-core-dev
266 2019-01-16T15:16:36  <bitcoin-git> [bitcoin] laanwj closed pull request #15122: [RPC] Expand help text for importmulti changes (master...pr14565_release_notes) https://github.com/bitcoin/bitcoin/pull/15122
267 2019-01-16T15:16:36  *** bitcoin-git has left #bitcoin-core-dev
268 2019-01-16T15:16:39  <dongcarl> promag: perhaps I should omit the "disconnect" part of the comment since it's structured this way now
269 2019-01-16T15:16:47  *** setpill has quit IRC
270 2019-01-16T15:17:02  <promag> dongcarl: looks like "// Disconnect" comment could be just before pnode->fDisconnect = true;
271 2019-01-16T15:17:10  <dongcarl> true
272 2019-01-16T15:17:12  <promag> or that, just remove
273 2019-01-16T15:17:50  <promag> anyway, isn't this changing behavior?
274 2019-01-16T15:18:31  <promag> old CConnman::Ban would disconnect all matching nodes
275 2019-01-16T15:19:00  <promag> disclaimer, I'm not familiar with net code
276 2019-01-16T15:19:51  <promag> so looks like `pnode->fDisconnect = true;` should be `DisconnectNode(pnode->addr)`\ ?
277 2019-01-16T15:22:45  <dongcarl> promag: I think what Cory meant by behavior is the behavior of the node, not the CConnman
278 2019-01-16T15:23:06  <dongcarl> promag: see https://github.com/bitcoin/bitcoin/pull/14605#discussion_r248065847
279 2019-01-16T15:23:58  *** laurentmt has joined #bitcoin-core-dev
280 2019-01-16T15:28:19  <promag> note that the old behavior `connman->Ban(pnode->addr, BanReasonNodeMisbehaving)` would go thru all nodes to disconnect (code that was moved to CConnman::DisconnectNode)
281 2019-01-16T15:29:19  <promag> in other words, iiuc, before SendRejectsAndCheckIfBanned could result in multiple disconnected nodes, now it only results in 1 one
282 2019-01-16T15:29:32  <promag> .. 1 node
283 2019-01-16T15:31:25  *** bitcoin-git has joined #bitcoin-core-dev
284 2019-01-16T15:31:25  <bitcoin-git> [bitcoin] instagibbs opened pull request #15179: [trivial] Slight clarity boost to SEQUENCE_LOCKTIME_DISABLE_FLAG (master...rel_lock_lang) https://github.com/bitcoin/bitcoin/pull/15179
285 2019-01-16T15:31:25  *** bitcoin-git has left #bitcoin-core-dev
286 2019-01-16T15:32:43  <promag> dongcarl: or does this means that CSubNet(addr).Match() only returns true once?
287 2019-01-16T15:34:05  *** michaelsdunn1 has joined #bitcoin-core-dev
288 2019-01-16T15:34:05  *** michaelsdunn1 has quit IRC
289 2019-01-16T15:34:05  *** michaelsdunn1 has joined #bitcoin-core-dev
290 2019-01-16T15:42:28  <dongcarl> promag: The version of `Ban` that takes in a `CNetAddr` constructs a single ip subnet (<ipv4>/32 or <ipv6>/128) `CSubNet` from that `CNetAddr`
291 2019-01-16T15:42:57  <promag> so only one node matches that?
292 2019-01-16T15:43:49  <dongcarl> unless 2 pnodes share the same addr, which I don't think can be the case but I'm double checking here
293 2019-01-16T15:44:00  *** tripleslash has quit IRC
294 2019-01-16T15:45:14  <promag> dongcarl I think that very likely, if you have 2 nodes at home they share the same addr?
295 2019-01-16T15:47:40  *** tripleslash has joined #bitcoin-core-dev
296 2019-01-16T15:49:50  <dongcarl> promag: You are right
297 2019-01-16T15:52:40  *** zenogais has joined #bitcoin-core-dev
298 2019-01-16T15:53:35  <dongcarl> promag: So what I think I'll do is for the `IsLocal` case I'll use fDisconnect, and use the pnode->addr in the other case
299 2019-01-16T15:55:21  <promag> you mean DisconnectNode(pnode->addr) in the else branch?
300 2019-01-16T15:55:34  <dongcarl> promag: right
301 2019-01-16T15:55:41  <promag> lgtm
302 2019-01-16T15:57:53  <dongcarl> promag: thanks for the help, lmk if you spot anything else!
303 2019-01-16T15:58:11  <promag> sure
304 2019-01-16T16:00:29  *** ddustin has joined #bitcoin-core-dev
305 2019-01-16T16:05:27  *** ddustin has quit IRC
306 2019-01-16T16:07:00  *** bitcoin-git has joined #bitcoin-core-dev
307 2019-01-16T16:07:00  <bitcoin-git> [bitcoin] domob1812 closed pull request #15158: Use real bind address in RPC help curl example (master...rpchelp-addr) https://github.com/bitcoin/bitcoin/pull/15158
308 2019-01-16T16:07:00  *** bitcoin-git has left #bitcoin-core-dev
309 2019-01-16T16:09:38  *** bitcoin-git has joined #bitcoin-core-dev
310 2019-01-16T16:09:39  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f71c2ea6620a...fcb6694a9945
311 2019-01-16T16:09:40  <bitcoin-git> bitcoin/master 8928237 Cory Fields: threads: fix unitialized members in sched_param...
312 2019-01-16T16:09:40  <bitcoin-git> bitcoin/master fcb6694 Wladimir J. van der Laan: Merge #14839: [rebase] threads: fix unitialized members in sched_param...
313 2019-01-16T16:09:40  *** bitcoin-git has left #bitcoin-core-dev
314 2019-01-16T16:10:18  *** bitcoin-git has joined #bitcoin-core-dev
315 2019-01-16T16:10:19  <bitcoin-git> [bitcoin] laanwj closed pull request #14839: [rebase] threads: fix unitialized members in sched_param (master...rebased-fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14839
316 2019-01-16T16:10:19  *** bitcoin-git has left #bitcoin-core-dev
317 2019-01-16T16:11:00  *** spaced0ut has quit IRC
318 2019-01-16T16:30:11  *** farmerwampum has joined #bitcoin-core-dev
319 2019-01-16T16:33:06  *** farmerwampum has quit IRC
320 2019-01-16T16:33:31  *** farmerwampum has joined #bitcoin-core-dev
321 2019-01-16T16:34:44  *** farmerwampum has quit IRC
322 2019-01-16T16:35:35  *** farmerwampum has joined #bitcoin-core-dev
323 2019-01-16T16:43:35  *** farmerwampum has quit IRC
324 2019-01-16T16:43:59  *** farmerwampum has joined #bitcoin-core-dev
325 2019-01-16T16:48:07  *** farmerwampum has quit IRC
326 2019-01-16T16:48:31  *** farmerwampum has joined #bitcoin-core-dev
327 2019-01-16T16:52:38  *** farmerwampum_ has joined #bitcoin-core-dev
328 2019-01-16T16:52:53  <promag> dongcarl: 7cc2b9f looks good, I'll continue tonight
329 2019-01-16T16:53:26  <dongcarl> promag: thank you sir!
330 2019-01-16T16:53:45  *** mr9 has quit IRC
331 2019-01-16T16:53:57  *** intcat has joined #bitcoin-core-dev
332 2019-01-16T16:56:40  *** mistergo1d has quit IRC
333 2019-01-16T16:57:10  *** mistergold has joined #bitcoin-core-dev
334 2019-01-16T17:02:50  *** intcat has quit IRC
335 2019-01-16T17:06:41  *** pinheadmz has joined #bitcoin-core-dev
336 2019-01-16T17:07:45  *** bitcoin-git has joined #bitcoin-core-dev
337 2019-01-16T17:07:45  <bitcoin-git> [bitcoin] domob1812 opened pull request #15181: Use correct RPC port in help curl example (master...rpchelp-port) https://github.com/bitcoin/bitcoin/pull/15181
338 2019-01-16T17:07:45  *** bitcoin-git has left #bitcoin-core-dev
339 2019-01-16T17:09:21  *** intcat has joined #bitcoin-core-dev
340 2019-01-16T17:14:23  *** laurentmt has quit IRC
341 2019-01-16T17:15:18  *** bitcoin-git has joined #bitcoin-core-dev
342 2019-01-16T17:15:18  <bitcoin-git> [bitcoin] shahzadlone opened pull request #15182: [Minor Performance Fix] - Reserve vectors, to save reallocation costs. (master...master) https://github.com/bitcoin/bitcoin/pull/15182
343 2019-01-16T17:15:18  *** bitcoin-git has left #bitcoin-core-dev
344 2019-01-16T17:15:50  *** ddustin has joined #bitcoin-core-dev
345 2019-01-16T17:18:35  *** farmerwampum has quit IRC
346 2019-01-16T17:18:59  *** farmerwampum has joined #bitcoin-core-dev
347 2019-01-16T17:22:12  *** zshlyk has joined #bitcoin-core-dev
348 2019-01-16T17:23:43  *** intcat has quit IRC
349 2019-01-16T17:25:51  *** miknotauro has joined #bitcoin-core-dev
350 2019-01-16T17:33:07  *** farmerwampum has quit IRC
351 2019-01-16T17:33:32  *** farmerwampum has joined #bitcoin-core-dev
352 2019-01-16T17:37:33  *** ThomasLuong has joined #bitcoin-core-dev
353 2019-01-16T17:43:37  *** spaced0ut has joined #bitcoin-core-dev
354 2019-01-16T17:44:22  *** laurentmt has joined #bitcoin-core-dev
355 2019-01-16T17:45:23  *** Murch has joined #bitcoin-core-dev
356 2019-01-16T17:45:26  *** bitcoin-git has joined #bitcoin-core-dev
357 2019-01-16T17:45:27  <bitcoin-git> [bitcoin] marcoagner opened pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value: (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183
358 2019-01-16T17:45:27  *** bitcoin-git has left #bitcoin-core-dev
359 2019-01-16T17:53:03  *** jarthur has joined #bitcoin-core-dev
360 2019-01-16T17:53:35  *** farmerwampum has quit IRC
361 2019-01-16T17:53:59  *** farmerwampum has joined #bitcoin-core-dev
362 2019-01-16T17:58:06  *** farmerwampum has quit IRC
363 2019-01-16T17:58:30  *** farmerwampum has joined #bitcoin-core-dev
364 2019-01-16T18:07:54  *** miknotauro has quit IRC
365 2019-01-16T18:13:52  *** ram_ has joined #bitcoin-core-dev
366 2019-01-16T18:14:56  *** hebasto has joined #bitcoin-core-dev
367 2019-01-16T18:16:34  *** vicnicius has joined #bitcoin-core-dev
368 2019-01-16T18:17:39  *** vicnicius has quit IRC
369 2019-01-16T18:23:35  *** farmerwampum has quit IRC
370 2019-01-16T18:23:59  *** farmerwampum has joined #bitcoin-core-dev
371 2019-01-16T18:28:06  *** farmerwampum has quit IRC
372 2019-01-16T18:28:30  *** rex4539 has quit IRC
373 2019-01-16T18:28:31  *** farmerwampum has joined #bitcoin-core-dev
374 2019-01-16T18:28:32  *** pinheadmz has quit IRC
375 2019-01-16T18:28:35  *** Chris_Stewart_5 has quit IRC
376 2019-01-16T18:29:30  *** pinheadmz has joined #bitcoin-core-dev
377 2019-01-16T18:30:25  *** Murch has quit IRC
378 2019-01-16T18:35:53  *** bitcoin-git has joined #bitcoin-core-dev
379 2019-01-16T18:35:53  <bitcoin-git> [bitcoin] laanwj closed pull request #15182: [Minor Performance Fix] - Reserve vectors, to save reallocation costs. (master...master) https://github.com/bitcoin/bitcoin/pull/15182
380 2019-01-16T18:35:53  *** bitcoin-git has left #bitcoin-core-dev
381 2019-01-16T18:38:35  *** farmerwampum has quit IRC
382 2019-01-16T18:38:59  *** farmerwampum has joined #bitcoin-core-dev
383 2019-01-16T18:42:56  *** Murch has joined #bitcoin-core-dev
384 2019-01-16T18:43:06  *** farmerwampum has quit IRC
385 2019-01-16T18:43:31  *** farmerwampum has joined #bitcoin-core-dev
386 2019-01-16T18:44:54  *** Murch has quit IRC
387 2019-01-16T18:45:01  *** rh0nj has quit IRC
388 2019-01-16T18:45:21  *** sfhi has joined #bitcoin-core-dev
389 2019-01-16T18:46:07  *** rh0nj has joined #bitcoin-core-dev
390 2019-01-16T18:47:11  *** Murch has joined #bitcoin-core-dev
391 2019-01-16T18:52:24  *** jhfrontz has joined #bitcoin-core-dev
392 2019-01-16T18:54:39  *** jungly_ has quit IRC
393 2019-01-16T18:55:23  *** rex4539 has joined #bitcoin-core-dev
394 2019-01-16T19:03:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
395 2019-01-16T19:12:14  *** pinheadmz has quit IRC
396 2019-01-16T19:13:18  *** pinheadmz has joined #bitcoin-core-dev
397 2019-01-16T19:18:35  *** farmerwampum has quit IRC
398 2019-01-16T19:18:59  *** farmerwampum has joined #bitcoin-core-dev
399 2019-01-16T19:19:01  *** timothy has quit IRC
400 2019-01-16T19:23:06  *** farmerwampum has quit IRC
401 2019-01-16T19:23:31  *** farmerwampum has joined #bitcoin-core-dev
402 2019-01-16T19:29:42  *** ThomasLuong has quit IRC
403 2019-01-16T19:54:51  *** ddustin has quit IRC
404 2019-01-16T19:55:21  *** ddustin has joined #bitcoin-core-dev
405 2019-01-16T19:58:35  *** farmerwampum has quit IRC
406 2019-01-16T19:58:59  *** farmerwampum has joined #bitcoin-core-dev
407 2019-01-16T20:00:30  *** ddustin has quit IRC
408 2019-01-16T20:01:18  *** ThomasLuong has joined #bitcoin-core-dev
409 2019-01-16T20:03:06  *** farmerwampum has quit IRC
410 2019-01-16T20:03:30  *** farmerwampum has joined #bitcoin-core-dev
411 2019-01-16T20:07:55  *** schmidty has joined #bitcoin-core-dev
412 2019-01-16T20:07:55  *** schmidty has joined #bitcoin-core-dev
413 2019-01-16T20:10:42  *** irc_viewer_test has joined #bitcoin-core-dev
414 2019-01-16T20:11:44  *** pinheadmz has quit IRC
415 2019-01-16T20:12:40  *** laurentmt has quit IRC
416 2019-01-16T20:17:02  *** riemann_ has quit IRC
417 2019-01-16T20:17:31  <wumpus> travis is failing on master and I don't understand why: https://travis-ci.org/bitcoin/bitcoin/builds/480544455?utm_medium=notification&utm_source=email
418 2019-01-16T20:19:02  <wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/480544456  the only visible warning is the one about a missspelling in fuzzing.md, however that's an old warning and also spelling errors don't cause the test to fail
419 2019-01-16T20:23:56  *** laurentmt has joined #bitcoin-core-dev
420 2019-01-16T20:25:50  *** sfhi has quit IRC
421 2019-01-16T20:28:04  *** jarthur has quit IRC
422 2019-01-16T20:31:39  *** pinheadmz has joined #bitcoin-core-dev
423 2019-01-16T20:31:39  *** air_willy has joined #bitcoin-core-dev
424 2019-01-16T20:31:49  *** ThomasLuong has quit IRC
425 2019-01-16T20:32:21  *** irc_viewer_test has quit IRC
426 2019-01-16T20:38:35  *** farmerwampum has quit IRC
427 2019-01-16T20:38:59  *** farmerwampum has joined #bitcoin-core-dev
428 2019-01-16T20:41:24  *** mistergold has quit IRC
429 2019-01-16T20:41:43  *** mistergold has joined #bitcoin-core-dev
430 2019-01-16T20:41:47  *** Chris_Stewart_5 has quit IRC
431 2019-01-16T20:43:06  *** farmerwampum has quit IRC
432 2019-01-16T20:43:31  *** farmerwampum has joined #bitcoin-core-dev
433 2019-01-16T20:43:48  *** laurentmt has quit IRC
434 2019-01-16T20:44:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
435 2019-01-16T20:58:30  *** air_willy has quit IRC
436 2019-01-16T20:58:41  *** harrymm has quit IRC
437 2019-01-16T21:00:19  *** ThomasLuong has joined #bitcoin-core-dev
438 2019-01-16T21:01:07  *** spinza has quit IRC
439 2019-01-16T21:05:36  *** harrymm has joined #bitcoin-core-dev
440 2019-01-16T21:09:53  *** EagleTM has joined #bitcoin-core-dev
441 2019-01-16T21:12:52  *** spinza has joined #bitcoin-core-dev
442 2019-01-16T21:23:35  *** farmerwampum has quit IRC
443 2019-01-16T21:23:59  *** farmerwampum has joined #bitcoin-core-dev
444 2019-01-16T21:26:41  *** kexkey has quit IRC
445 2019-01-16T21:28:13  *** farmerwampum has quit IRC
446 2019-01-16T21:28:37  *** farmerwampum has joined #bitcoin-core-dev
447 2019-01-16T21:28:59  *** spaced0ut has quit IRC
448 2019-01-16T21:36:42  <meshcollider> Is it the failing subtree checks above it?
449 2019-01-16T21:39:31  *** ddustin has joined #bitcoin-core-dev
450 2019-01-16T21:43:18  *** hebasto has quit IRC
451 2019-01-16T21:53:56  *** EagleTM has quit IRC
452 2019-01-16T21:54:04  *** emilr has quit IRC
453 2019-01-16T21:54:13  *** emilr has joined #bitcoin-core-dev
454 2019-01-16T21:55:44  *** dophe has joined #bitcoin-core-dev
455 2019-01-16T21:58:37  *** dophe has quit IRC
456 2019-01-16T22:05:45  *** jarthur has joined #bitcoin-core-dev
457 2019-01-16T22:07:03  *** spinza has quit IRC
458 2019-01-16T22:09:32  *** Guyver2 has quit IRC
459 2019-01-16T22:11:48  *** spinza has joined #bitcoin-core-dev
460 2019-01-16T22:12:23  <gkrizek> I thought the same thing meshcollider but I can see those errors are still there in the last passing CI run
461 2019-01-16T22:15:37  *** miknotauro has joined #bitcoin-core-dev
462 2019-01-16T22:17:16  <gkrizek> I think it's in contrib/verify-commits/verify-commits.py
463 2019-01-16T22:20:27  <gkrizek> If you look at the raw log from Travis there is this line at the end "Still running (1 of 50): contrib/verify-commits/verify-commits.py --clean-merge=2"  doesn't show up in the UI
464 2019-01-16T22:22:15  *** zshlyk has quit IRC
465 2019-01-16T22:23:14  *** zshlyk has joined #bitcoin-core-dev
466 2019-01-16T22:24:14  *** Chris_Stewart_5 has quit IRC
467 2019-01-16T22:26:15  <gkrizek> Seems like this if statement is the only thing in the script that could exit(1) without logging a message:   https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/verify-commits.py#L110-L120
468 2019-01-16T22:30:35  <gkrizek> Eh I'm not sure, maybe someone with more experience with that script can tell, but the issue definitely seems to be there. wumpus
469 2019-01-16T22:35:54  <gkrizek> Now that I look, the Cron CI runs have been failing for a while now
470 2019-01-16T22:40:06  <gkrizek> Found it! This commit broke the Cron CI runs. https://github.com/bitcoin/bitcoin/commit/74ce32683199b987e45eb16f0320ae392ff10edc
471 2019-01-16T22:40:44  <gkrizek> So it seems the verify-commits.py script needs python 3.6
472 2019-01-16T22:43:35  *** farmerwampum has quit IRC
473 2019-01-16T22:44:20  *** farmerwampum has joined #bitcoin-core-dev
474 2019-01-16T22:47:01  *** rh0nj has quit IRC
475 2019-01-16T22:48:07  *** rh0nj has joined #bitcoin-core-dev
476 2019-01-16T22:48:13  *** farmerwampum has quit IRC
477 2019-01-16T22:48:25  *** DeanGuss has quit IRC
478 2019-01-16T22:48:38  *** farmerwampum has joined #bitcoin-core-dev
479 2019-01-16T22:55:53  *** michaelsdunn1 has quit IRC
480 2019-01-16T22:58:17  *** mistergo1d has joined #bitcoin-core-dev
481 2019-01-16T23:01:42  *** mistergold has quit IRC
482 2019-01-16T23:03:14  *** xor216 has joined #bitcoin-core-dev
483 2019-01-16T23:08:26  *** user__ has joined #bitcoin-core-dev
484 2019-01-16T23:08:37  <wumpus> gkrizek: thanks for looking into it! I'm surprised if it is the python version though, that change went in more than a month ago right?
485 2019-01-16T23:08:50  <wumpus> gkrizek: travis still passed earlier today
486 2019-01-16T23:09:01  <gkrizek> Yes, and it's been failing every since. No only the Cron runs.
487 2019-01-16T23:09:34  <gkrizek> See the "CRON" label next to the branch name
488 2019-01-16T23:09:49  <wumpus> OHH
489 2019-01-16T23:10:01  <gkrizek> https://github.com/bitcoin/bitcoin/blob/master/.travis/lint_06_script.sh#L21-L25
490 2019-01-16T23:10:26  <gkrizek> Those scripts only run on the cron runs...
491 2019-01-16T23:10:57  *** m8tion_ has quit IRC
492 2019-01-16T23:11:10  <gkrizek> I was trying to install 3.4.9 to try to find out what it is but now my pyenv isn't working
493 2019-01-16T23:39:14  *** xor216 has left #bitcoin-core-dev
494 2019-01-16T23:40:39  *** EagleTM has joined #bitcoin-core-dev