12019-01-17T00:20:20 *** ddustin has quit IRC
22019-01-17T00:21:00 *** ddustin has joined #bitcoin-core-dev
32019-01-17T00:25:20 *** ddustin has quit IRC
42019-01-17T00:27:04 *** davec has quit IRC
52019-01-17T00:28:27 *** davec has joined #bitcoin-core-dev
62019-01-17T00:29:57 *** m8tion has joined #bitcoin-core-dev
72019-01-17T00:33:34 *** user__ has quit IRC
82019-01-17T00:38:46 *** davec has quit IRC
92019-01-17T00:40:35 *** davec has joined #bitcoin-core-dev
102019-01-17T00:41:33 *** fanquake has quit IRC
112019-01-17T00:46:37 *** drexl has quit IRC
122019-01-17T00:57:52 *** mistergo1d has quit IRC
132019-01-17T00:57:59 *** jarthur has quit IRC
142019-01-17T00:59:08 *** EagleTM has quit IRC
152019-01-17T00:59:38 *** lnostdal has quit IRC
162019-01-17T01:01:14 *** lnostdal has joined #bitcoin-core-dev
172019-01-17T01:08:34 *** twistedline_ has joined #bitcoin-core-dev
182019-01-17T01:08:45 *** pinheadmz has quit IRC
192019-01-17T01:09:06 *** twistedline_ has quit IRC
202019-01-17T01:10:12 *** twistedline has quit IRC
212019-01-17T01:20:28 *** esotericnonsense has quit IRC
222019-01-17T01:22:34 *** esotericnonsense has joined #bitcoin-core-dev
232019-01-17T01:23:19 *** twistedline has joined #bitcoin-core-dev
242019-01-17T01:36:29 *** Murch has quit IRC
252019-01-17T01:39:01 *** ThomasLuong has quit IRC
262019-01-17T01:39:22 *** Murch has joined #bitcoin-core-dev
272019-01-17T01:40:37 *** Chris_Stewart_5 has joined #bitcoin-core-dev
282019-01-17T01:42:14 *** ThomasLuong has joined #bitcoin-core-dev
292019-01-17T01:48:38 *** Murch has quit IRC
302019-01-17T01:53:54 *** Murch has joined #bitcoin-core-dev
312019-01-17T01:55:24 *** Murch has quit IRC
322019-01-17T02:19:11 *** rockhouse has quit IRC
332019-01-17T02:19:32 *** rockhouse has joined #bitcoin-core-dev
342019-01-17T02:19:49 *** victorSN has quit IRC
352019-01-17T02:20:27 *** m8tion has quit IRC
362019-01-17T02:21:56 *** victorSN has joined #bitcoin-core-dev
372019-01-17T02:24:01 *** rh0nj has quit IRC
382019-01-17T02:25:08 *** rh0nj has joined #bitcoin-core-dev
392019-01-17T02:26:50 *** bitcoin-git has joined #bitcoin-core-dev
402019-01-17T02:26:50 <bitcoin-git> [bitcoin] benthecarman opened pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185
412019-01-17T02:26:50 *** bitcoin-git has left #bitcoin-core-dev
422019-01-17T02:35:51 *** ThomasLuong has quit IRC
432019-01-17T02:37:26 *** cfields_ has joined #bitcoin-core-dev
442019-01-17T02:37:48 *** davec_ has joined #bitcoin-core-dev
452019-01-17T02:37:49 *** ThomasLuong has joined #bitcoin-core-dev
462019-01-17T02:41:23 *** victorSN has quit IRC
472019-01-17T02:41:26 *** a2 has joined #bitcoin-core-dev
482019-01-17T02:41:52 *** aj__ has joined #bitcoin-core-dev
492019-01-17T02:42:16 *** gwollon has joined #bitcoin-core-dev
502019-01-17T02:43:04 *** [\\\] has joined #bitcoin-core-dev
512019-01-17T02:45:30 *** CubicEarth_ has joined #bitcoin-core-dev
522019-01-17T02:45:31 *** gribble has quit IRC
532019-01-17T02:46:15 *** davec has quit IRC
542019-01-17T02:46:15 *** harrymm has quit IRC
552019-01-17T02:46:15 *** tripleslash has quit IRC
562019-01-17T02:46:15 *** CubicEarth has quit IRC
572019-01-17T02:46:15 *** yxz has quit IRC
582019-01-17T02:46:15 *** asoltys has quit IRC
592019-01-17T02:46:15 *** sdaftuar has quit IRC
602019-01-17T02:46:15 *** aj has quit IRC
612019-01-17T02:46:15 *** gwillen has quit IRC
622019-01-17T02:46:15 *** cfields has quit IRC
632019-01-17T02:49:04 *** Chris_Stewart_5 has quit IRC
642019-01-17T02:49:15 *** owowo has quit IRC
652019-01-17T02:49:36 *** victorSN has joined #bitcoin-core-dev
662019-01-17T02:50:21 *** gribble has joined #bitcoin-core-dev
672019-01-17T02:50:54 *** harrymm has joined #bitcoin-core-dev
682019-01-17T02:51:22 *** owowo has joined #bitcoin-core-dev
692019-01-17T02:54:49 *** ThomasLu_ has joined #bitcoin-core-dev
702019-01-17T02:55:03 *** rhavar_ has joined #bitcoin-core-dev
712019-01-17T02:57:52 *** ThomasLuong has quit IRC
722019-01-17T02:58:58 *** pinheadmz has joined #bitcoin-core-dev
732019-01-17T03:11:05 *** asoltys has joined #bitcoin-core-dev
742019-01-17T03:11:05 *** sdaftuar has joined #bitcoin-core-dev
752019-01-17T03:13:37 *** gwollon is now known as gwillen
762019-01-17T03:26:42 *** benthecarman has joined #bitcoin-core-dev
772019-01-17T03:34:49 <gkrizek> wumpus the problem is the 'encoding' arg to the subprocess.check_output function. That was introduced in 3.6. I don't really see a need for that parameter anyway, so I think it's safe to just remove it. I can open a PR for it
782019-01-17T03:38:44 *** AaronvanW has quit IRC
792019-01-17T03:40:28 *** aj__ is now known as aj
802019-01-17T03:44:12 *** miknotauro has quit IRC
812019-01-17T03:54:52 *** pinheadmz has quit IRC
822019-01-17T04:03:35 *** farmerwampum has quit IRC
832019-01-17T04:03:59 *** farmerwampum has joined #bitcoin-core-dev
842019-01-17T04:04:26 *** schnerch_ has joined #bitcoin-core-dev
852019-01-17T04:07:12 *** schnerchi has quit IRC
862019-01-17T04:08:06 *** farmerwampum has quit IRC
872019-01-17T04:08:32 *** farmerwampum has joined #bitcoin-core-dev
882019-01-17T04:16:31 *** benthecarman_ has joined #bitcoin-core-dev
892019-01-17T04:17:14 *** benthecarman has quit IRC
902019-01-17T04:18:52 *** bentheacarman__ has joined #bitcoin-core-dev
912019-01-17T04:19:05 *** bentheacarman__ is now known as bentheacarman
922019-01-17T04:21:27 *** benthecarman_ has quit IRC
932019-01-17T04:24:43 *** bentheacarman has quit IRC
942019-01-17T04:32:21 *** miknotauro has joined #bitcoin-core-dev
952019-01-17T04:37:09 *** hebasto has joined #bitcoin-core-dev
962019-01-17T05:01:23 *** zshlyk has quit IRC
972019-01-17T05:02:13 *** zshlyk has joined #bitcoin-core-dev
982019-01-17T05:14:21 *** sakalli_ has joined #bitcoin-core-dev
992019-01-17T05:16:43 *** sakalli_ has quit IRC
1002019-01-17T05:22:30 *** DeanGuss has joined #bitcoin-core-dev
1012019-01-17T05:23:27 *** pinheadmz has joined #bitcoin-core-dev
1022019-01-17T05:24:22 *** DougieBot5000_ has joined #bitcoin-core-dev
1032019-01-17T05:25:20 *** DougieBot5000 is now known as Guest50520
1042019-01-17T05:25:21 *** DougieBot5000_ is now known as DougieBot5000
1052019-01-17T05:48:34 *** pinheadmz has quit IRC
1062019-01-17T05:55:14 *** karelb has quit IRC
1072019-01-17T05:57:49 *** sakalli_ has joined #bitcoin-core-dev
1082019-01-17T05:58:10 *** sakalli_ has joined #bitcoin-core-dev
1092019-01-17T06:13:35 *** farmerwampum has quit IRC
1102019-01-17T06:13:59 *** farmerwampum has joined #bitcoin-core-dev
1112019-01-17T06:18:06 *** farmerwampum has quit IRC
1122019-01-17T06:18:30 *** farmerwampum has joined #bitcoin-core-dev
1132019-01-17T06:19:54 *** zenogais has quit IRC
1142019-01-17T06:24:19 *** hebasto has quit IRC
1152019-01-17T06:26:33 *** sakalli_ has quit IRC
1162019-01-17T06:48:02 *** rh0nj has quit IRC
1172019-01-17T06:48:11 *** pinheadmz has joined #bitcoin-core-dev
1182019-01-17T06:49:07 *** rh0nj has joined #bitcoin-core-dev
1192019-01-17T06:55:46 <wumpus> gkrizek: the encoding parameter is for operating systems such as FreeBSD which don't set the system locale to utf-8 by default, leaving it up to python to decide what the locale is. It'll then pick ASCII only which results in problems in some cases.
1202019-01-17T06:57:19 <wumpus> gkrizek: (for example when calling git, and any of the commit messages contains characters >=128)
1212019-01-17T07:13:09 *** ThomasLu_ has quit IRC
1222019-01-17T07:14:37 *** rex4539 has quit IRC
1232019-01-17T07:18:02 *** rex4539 has joined #bitcoin-core-dev
1242019-01-17T07:31:04 *** bitcoin-git has joined #bitcoin-core-dev
1252019-01-17T07:31:04 <bitcoin-git> [bitcoin] fanquake opened pull request #15186: rpc: remove duplicate solvable field from getaddressinfo (master...duplicate-solvable-fields) https://github.com/bitcoin/bitcoin/pull/15186
1262019-01-17T07:31:04 *** bitcoin-git has left #bitcoin-core-dev
1272019-01-17T07:37:18 *** ThomasLuong has joined #bitcoin-core-dev
1282019-01-17T08:03:29 *** rhavar_ has quit IRC
1292019-01-17T08:19:01 *** promag has quit IRC
1302019-01-17T08:20:07 *** promag has joined #bitcoin-core-dev
1312019-01-17T08:24:47 *** promag has quit IRC
1322019-01-17T08:36:05 *** jungly has joined #bitcoin-core-dev
1332019-01-17T08:37:32 *** bintangblue has joined #bitcoin-core-dev
1342019-01-17T08:38:21 *** bintangblue has quit IRC
1352019-01-17T08:39:49 *** pinheadmz has quit IRC
1362019-01-17T08:42:17 *** zshlyk has quit IRC
1372019-01-17T08:44:45 *** zshlyk has joined #bitcoin-core-dev
1382019-01-17T08:58:35 *** farmerwampum has quit IRC
1392019-01-17T08:58:59 *** farmerwampum has joined #bitcoin-core-dev
1402019-01-17T09:03:15 *** farmerwampum has quit IRC
1412019-01-17T09:03:39 *** farmerwampum has joined #bitcoin-core-dev
1422019-01-17T09:18:56 *** ThomasLuong has quit IRC
1432019-01-17T09:22:36 *** bitcoin-git has joined #bitcoin-core-dev
1442019-01-17T09:22:36 <bitcoin-git> [bitcoin] Empact closed pull request #15133: [WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder (master...factories) https://github.com/bitcoin/bitcoin/pull/15133
1452019-01-17T09:22:36 *** bitcoin-git has left #bitcoin-core-dev
1462019-01-17T09:47:48 *** promag has joined #bitcoin-core-dev
1472019-01-17T09:48:09 *** Wilmar has joined #bitcoin-core-dev
1482019-01-17T09:49:50 *** Wilmar has quit IRC
1492019-01-17T09:52:26 *** promag has quit IRC
1502019-01-17T09:53:03 *** promag has joined #bitcoin-core-dev
1512019-01-17T09:53:35 *** farmerwampum has quit IRC
1522019-01-17T09:53:59 *** farmerwampum has joined #bitcoin-core-dev
1532019-01-17T09:56:48 *** hebasto has joined #bitcoin-core-dev
1542019-01-17T09:58:06 *** farmerwampum has quit IRC
1552019-01-17T09:58:30 *** farmerwampum has joined #bitcoin-core-dev
1562019-01-17T10:06:44 *** setpill has joined #bitcoin-core-dev
1572019-01-17T10:28:59 *** timothy has joined #bitcoin-core-dev
1582019-01-17T10:49:27 *** Victorsueca has quit IRC
1592019-01-17T10:52:02 <promag> wumpus: pushKV should assert(key not exist)
1602019-01-17T10:52:41 <promag> it checks for duplicate but overwrites
1612019-01-17T10:53:06 *** spinza has quit IRC
1622019-01-17T10:53:15 <promag> I don't think that's our use case (from API point of view)
1632019-01-17T10:58:35 *** farmerwampum has quit IRC
1642019-01-17T10:58:59 *** farmerwampum has joined #bitcoin-core-dev
1652019-01-17T11:00:38 <hebasto> wumpus: hi, mind reviewing #14250?
1662019-01-17T11:00:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14250 | qt: Remove redundant stopThread() and stopExecutor() signals by hebasto · Pull Request #14250 · bitcoin/bitcoin · GitHub
1672019-01-17T11:03:23 *** farmerwampum has quit IRC
1682019-01-17T11:03:47 *** farmerwampum has joined #bitcoin-core-dev
1692019-01-17T11:08:35 *** farmerwampum has quit IRC
1702019-01-17T11:08:59 *** farmerwampum has joined #bitcoin-core-dev
1712019-01-17T11:13:06 *** farmerwampum has quit IRC
1722019-01-17T11:13:31 *** farmerwampum has joined #bitcoin-core-dev
1732019-01-17T11:14:22 *** rex4539 has joined #bitcoin-core-dev
1742019-01-17T11:16:55 *** rex4539 has quit IRC
1752019-01-17T11:21:02 *** laurentmt has joined #bitcoin-core-dev
1762019-01-17T11:30:02 *** laurentmt has quit IRC
1772019-01-17T11:33:35 *** farmerwampum has quit IRC
1782019-01-17T11:33:59 *** farmerwampum has joined #bitcoin-core-dev
1792019-01-17T11:38:08 *** farmerwampum has quit IRC
1802019-01-17T11:38:33 *** farmerwampum has joined #bitcoin-core-dev
1812019-01-17T11:45:54 *** miknotauro has quit IRC
1822019-01-17T11:48:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1832019-01-17T11:54:00 *** spinza has joined #bitcoin-core-dev
1842019-01-17T12:03:35 *** farmerwampum has quit IRC
1852019-01-17T12:03:59 *** farmerwampum has joined #bitcoin-core-dev
1862019-01-17T12:04:40 *** Chris_Stewart_5 has quit IRC
1872019-01-17T12:06:14 *** AaronvanW has joined #bitcoin-core-dev
1882019-01-17T12:13:08 *** farmerwampum has quit IRC
1892019-01-17T12:13:32 *** farmerwampum has joined #bitcoin-core-dev
1902019-01-17T12:18:19 *** rex4539 has joined #bitcoin-core-dev
1912019-01-17T12:27:47 *** TheRec has quit IRC
1922019-01-17T12:29:57 *** TheRec has joined #bitcoin-core-dev
1932019-01-17T12:32:59 *** TheRec has joined #bitcoin-core-dev
1942019-01-17T12:33:00 *** TheRec has joined #bitcoin-core-dev
1952019-01-17T12:33:00 <wumpus> promag: from the point of view of our API that's true, though on the other hand there's nothing in JSON that disallows multiple values per key
1962019-01-17T12:33:20 <wumpus> hebasto: sure
1972019-01-17T12:35:12 <wumpus> promag: and checking that *efficiently* would involve adding a set to the Univalue type; not instead, but in addition to the vector because we want to preserve order as well
1982019-01-17T12:35:54 <promag> true, univalue is generic and that's fine. just think it could have more specialized mutations. for instance, pushKV should be setKV ?
1992019-01-17T12:35:56 <wumpus> (also asserting is really dangerous here; it can turn a mild asthetic issue into a crash)
2002019-01-17T12:36:47 <promag> wumpus: that should be fine, we don't use user keys
2012019-01-17T12:36:58 <wumpus> (say, REST returns some JSON structure and the code can be manipulated to add the same field twice, somehow, whoopsie instant DoS - a better solution would be to replace the value for the existing key)
2022019-01-17T12:37:47 <wumpus> that'd also be "javascript semantics" FWIW, in any case there's no need to overreact to this case
2032019-01-17T12:38:11 *** farmerwampum__ has joined #bitcoin-core-dev
2042019-01-17T12:38:28 <promag> wumpus: look #14984 for instance
2052019-01-17T12:38:30 <gribble> https://github.com/bitcoin/bitcoin/issues/14984 | rpc: Speedup getrawmempool when verbose=true by promag · Pull Request #14984 · bitcoin/bitcoin · GitHub
2062019-01-17T12:38:30 <wumpus> if there's anything to worry that would be that this should have been caught at *review time* :)
2072019-01-17T12:39:47 <promag> I'm not arguing it shouldn't be caught at review time
2082019-01-17T12:40:57 <wumpus> I know, but I mean *if* this should trigger any kind of discussion it's that; the end result of a key appearing twice on the API is hardly a problem, the only worry (if this was, say, a silent merge issue) is that it could have been worse
2092019-01-17T12:41:16 <wumpus> *silent merge conflict*
2102019-01-17T12:41:42 *** farmerwampum has quit IRC
2112019-01-17T12:41:42 *** farmerwampum_ has quit IRC
2122019-01-17T12:42:01 *** farmerwampum has joined #bitcoin-core-dev
2132019-01-17T12:46:01 *** rh0nj has quit IRC
2142019-01-17T12:47:08 *** rh0nj has joined #bitcoin-core-dev
2152019-01-17T12:49:07 *** promag has quit IRC
2162019-01-17T12:54:31 *** m8tion has joined #bitcoin-core-dev
2172019-01-17T12:59:46 *** mistergold has joined #bitcoin-core-dev
2182019-01-17T13:16:39 *** schnerch_ has quit IRC
2192019-01-17T13:17:05 *** schnerchi has joined #bitcoin-core-dev
2202019-01-17T13:22:45 *** fanquake has joined #bitcoin-core-dev
2212019-01-17T13:23:53 <fanquake> wumpus how often do you use the mallocinfo mode for getmemoryinfo ?
2222019-01-17T13:24:04 *** Guyver2 has joined #bitcoin-core-dev
2232019-01-17T13:28:35 *** farmerwampum__ has quit IRC
2242019-01-17T13:29:03 *** farmerwampum_ has joined #bitcoin-core-dev
2252019-01-17T13:31:51 *** promag has joined #bitcoin-core-dev
2262019-01-17T13:32:24 *** TheRec_ has joined #bitcoin-core-dev
2272019-01-17T13:32:24 *** TheRec_ has joined #bitcoin-core-dev
2282019-01-17T13:33:08 *** farmerwampum_ has quit IRC
2292019-01-17T13:33:44 *** TheRec has quit IRC
2302019-01-17T13:33:50 *** TheRec_ has quit IRC
2312019-01-17T13:34:01 *** TheRec has joined #bitcoin-core-dev
2322019-01-17T13:34:01 *** TheRec has joined #bitcoin-core-dev
2332019-01-17T13:34:40 *** Sunil_ has joined #bitcoin-core-dev
2342019-01-17T13:35:00 *** TheRec has quit IRC
2352019-01-17T13:35:32 *** TheRec has joined #bitcoin-core-dev
2362019-01-17T13:35:32 *** TheRec has joined #bitcoin-core-dev
2372019-01-17T13:36:03 *** promag has quit IRC
2382019-01-17T13:36:41 *** TheRec has quit IRC
2392019-01-17T13:38:08 *** TheRec has joined #bitcoin-core-dev
2402019-01-17T13:38:08 *** TheRec has joined #bitcoin-core-dev
2412019-01-17T13:39:40 *** TheRec has quit IRC
2422019-01-17T13:40:21 *** TheRec has joined #bitcoin-core-dev
2432019-01-17T13:40:21 *** TheRec has joined #bitcoin-core-dev
2442019-01-17T13:40:27 *** Sunil_ has quit IRC
2452019-01-17T13:41:14 *** bitcoin-git has joined #bitcoin-core-dev
2462019-01-17T13:41:15 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fcb6694a9945...7ee604487f54
2472019-01-17T13:41:15 <bitcoin-git> bitcoin/master 1c0e0a5 Hennadii Stepanov: Remove redundant stopThread() signal
2482019-01-17T13:41:15 <bitcoin-git> bitcoin/master 24313fb Hennadii Stepanov: Remove redundant stopExecutor() signal
2492019-01-17T13:41:16 <bitcoin-git> bitcoin/master 7ee6044 Wladimir J. van der Laan: Merge #14250: qt: Remove redundant stopThread() and stopExecutor() signals...
2502019-01-17T13:41:16 *** bitcoin-git has left #bitcoin-core-dev
2512019-01-17T13:41:47 *** bitcoin-git has joined #bitcoin-core-dev
2522019-01-17T13:41:47 <bitcoin-git> [bitcoin] laanwj closed pull request #14250: qt: Remove redundant stopThread() and stopExecutor() signals (master...stopthread-signal) https://github.com/bitcoin/bitcoin/pull/14250
2532019-01-17T13:41:47 *** bitcoin-git has left #bitcoin-core-dev
2542019-01-17T13:44:16 *** mistergold has quit IRC
2552019-01-17T13:44:38 *** TheRec has quit IRC
2562019-01-17T13:51:20 *** hebasto_ has joined #bitcoin-core-dev
2572019-01-17T13:51:42 *** hebasto has quit IRC
2582019-01-17T13:51:46 *** TheRec has joined #bitcoin-core-dev
2592019-01-17T13:51:46 *** TheRec has joined #bitcoin-core-dev
2602019-01-17T13:54:16 *** TheRec_ has joined #bitcoin-core-dev
2612019-01-17T13:56:18 *** TheRec has quit IRC
2622019-01-17T14:01:05 <wumpus> fanquake: not often, why?
2632019-01-17T14:01:34 *** TheRec_ has quit IRC
2642019-01-17T14:03:42 <fanquake> wumpus just curious, don't see it mentioned often, and had just about forgotten it was a thing, but am writing RPC wrappers. Can't use it on macOS anyways.
2652019-01-17T14:05:57 *** TheRec has joined #bitcoin-core-dev
2662019-01-17T14:06:23 <wumpus> it's mostly useful for developers when diagnosing some kinds of allocation behavior
2672019-01-17T14:14:51 *** laurentmt has joined #bitcoin-core-dev
2682019-01-17T14:19:14 *** TheRec has quit IRC
2692019-01-17T14:23:46 *** guga has joined #bitcoin-core-dev
2702019-01-17T14:27:24 *** shesek has joined #bitcoin-core-dev
2712019-01-17T14:28:48 <dongcarl> luke-jr: how does OpenRC work with env vars? How are they passed to the service?
2722019-01-17T14:29:37 <dongcarl> I can do the same for #12255, which means the user can override env vars in their systemd unit
2732019-01-17T14:29:39 <gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
2742019-01-17T14:31:26 *** TheRec has joined #bitcoin-core-dev
2752019-01-17T14:32:17 *** laurentmt has quit IRC
2762019-01-17T14:33:49 *** cluelessperson_ has joined #bitcoin-core-dev
2772019-01-17T14:34:58 *** TheRec has joined #bitcoin-core-dev
2782019-01-17T14:34:58 *** TheRec has joined #bitcoin-core-dev
2792019-01-17T14:36:23 <gkrizek> wumpus thanks for the explanation on the encoding arg. So is there a work around for 3.4? That arg wasnât introduced until 3.6.
2802019-01-17T14:37:08 *** cluelessperson_ has quit IRC
2812019-01-17T14:37:30 *** cluelessperson_ has joined #bitcoin-core-dev
2822019-01-17T14:37:32 *** zshlyk has quit IRC
2832019-01-17T14:38:32 *** zshlyk has joined #bitcoin-core-dev
2842019-01-17T14:38:40 *** spaced0ut has joined #bitcoin-core-dev
2852019-01-17T14:39:34 *** setpill has quit IRC
2862019-01-17T14:39:55 *** setpill has joined #bitcoin-core-dev
2872019-01-17T14:51:15 <wumpus> gkrizek: I don't know if there's a workaround for earlier versions :/
2882019-01-17T14:52:29 <wumpus> well, one way would be to read *bytes* from the pipe and convert it to utf-8 using an encoder
2892019-01-17T14:52:37 *** miknotauro has joined #bitcoin-core-dev
2902019-01-17T14:52:56 <wumpus> I think I did this in the github-merge script
2912019-01-17T14:54:14 <wumpus> can't wait until we can support 3.6 as minimum python version tbh, this keeps coming up
2922019-01-17T14:56:18 *** m8tion has quit IRC
2932019-01-17T14:56:54 <gkrizek> Ha, I agree. Ok Iâll try to look around and find some other scripts to see how they do it
2942019-01-17T15:01:27 <wumpus> yes see contrib/devtools/github-merge.py
2952019-01-17T15:04:13 *** bitcoin-git has joined #bitcoin-core-dev
2962019-01-17T15:04:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee604487f54...003a47f804b1
2972019-01-17T15:04:15 <bitcoin-git> bitcoin/master 31097b7 benthecarman: docs: Spelling error fix on fuzzing.md
2982019-01-17T15:04:15 <bitcoin-git> bitcoin/master 003a47f MarcoFalke: Merge #15185: docs: Spelling error fix on fuzzing.md...
2992019-01-17T15:04:16 *** bitcoin-git has left #bitcoin-core-dev
3002019-01-17T15:05:06 *** bitcoin-git has joined #bitcoin-core-dev
3012019-01-17T15:05:06 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185
3022019-01-17T15:05:06 *** bitcoin-git has left #bitcoin-core-dev
3032019-01-17T15:10:03 *** miknotauro has quit IRC
3042019-01-17T15:10:26 *** spaced0ut has quit IRC
3052019-01-17T15:11:06 *** farmerwampum_ has joined #bitcoin-core-dev
3062019-01-17T15:13:42 *** farmerwampum has quit IRC
3072019-01-17T15:14:16 *** pinheadmz has joined #bitcoin-core-dev
3082019-01-17T15:15:24 *** setpill has quit IRC
3092019-01-17T15:22:12 *** laurentmt has joined #bitcoin-core-dev
3102019-01-17T15:23:28 <fanquake> Looks like configuring with zmq on macOS is broken after brew bumped to 4.3.1 :(
3112019-01-17T15:24:58 <wumpus> hmm
3122019-01-17T15:26:24 <fanquake> Some discussion here: https://github.com/Homebrew/homebrew-core/pull/35940#issuecomment-454177261
3132019-01-17T15:27:00 *** laurentmt has quit IRC
3142019-01-17T15:27:26 *** bitcoin-git has joined #bitcoin-core-dev
3152019-01-17T15:27:26 <bitcoin-git> [bitcoin] practicalswift opened pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187
3162019-01-17T15:27:26 *** bitcoin-git has left #bitcoin-core-dev
3172019-01-17T15:32:03 *** zenogais has joined #bitcoin-core-dev
3182019-01-17T15:32:42 *** kewde[m] has quit IRC
3192019-01-17T15:33:19 *** savil has quit IRC
3202019-01-17T15:33:27 *** ajtowns[m] has quit IRC
3212019-01-17T15:33:28 *** TheFuzzStone[m] has quit IRC
3222019-01-17T15:33:32 *** farmerwampum has joined #bitcoin-core-dev
3232019-01-17T15:33:50 *** ajtowns[m] has joined #bitcoin-core-dev
3242019-01-17T15:34:38 *** michaelsdunn1 has joined #bitcoin-core-dev
3252019-01-17T15:34:38 *** michaelsdunn1 has quit IRC
3262019-01-17T15:34:38 *** michaelsdunn1 has joined #bitcoin-core-dev
3272019-01-17T15:36:16 *** kewde[m] has joined #bitcoin-core-dev
3282019-01-17T15:38:05 *** spaced0ut has joined #bitcoin-core-dev
3292019-01-17T15:39:12 *** Bilith_ has joined #bitcoin-core-dev
3302019-01-17T15:39:53 *** savil has joined #bitcoin-core-dev
3312019-01-17T15:42:52 *** pinheadmz has quit IRC
3322019-01-17T15:43:21 *** TheFuzzStone[m] has joined #bitcoin-core-dev
3332019-01-17T15:43:43 *** pinheadmz has joined #bitcoin-core-dev
3342019-01-17T15:45:41 *** mistergold has joined #bitcoin-core-dev
3352019-01-17T15:56:42 <wumpus> fanquake: so it might be a bug in their packaging of the new version, instead of the code itself?
3362019-01-17T15:56:42 *** dabedoc has joined #bitcoin-core-dev
3372019-01-17T15:56:57 *** ExtraCrispy has joined #bitcoin-core-dev
3382019-01-17T15:58:07 *** bitcoin-git has joined #bitcoin-core-dev
3392019-01-17T15:58:07 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/003a47f804b1...12b30105fc59
3402019-01-17T15:58:08 <bitcoin-git> bitcoin/master 638e53b practicalswift: Pin shellcheck version to v0.6.0
3412019-01-17T15:58:08 <bitcoin-git> bitcoin/master 07a53dc practicalswift: Remove repeated suppression. Fix indentation.
3422019-01-17T15:58:09 <bitcoin-git> bitcoin/master 0b7196e practicalswift: Fix warnings introduced in shellcheck v0.6.0
3432019-01-17T15:58:09 *** bitcoin-git has left #bitcoin-core-dev
3442019-01-17T15:58:35 *** farmerwampum has quit IRC
3452019-01-17T15:58:48 *** bitcoin-git has joined #bitcoin-core-dev
3462019-01-17T15:58:48 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15166: qa: Pin shellcheck version (master...opt-out-of-new-shellcheck-warnings) https://github.com/bitcoin/bitcoin/pull/15166
3472019-01-17T15:58:48 *** bitcoin-git has left #bitcoin-core-dev
3482019-01-17T15:58:59 *** farmerwampum has joined #bitcoin-core-dev
3492019-01-17T16:03:07 *** farmerwampum has quit IRC
3502019-01-17T16:03:31 *** farmerwampum has joined #bitcoin-core-dev
3512019-01-17T16:05:44 *** pinheadmz has quit IRC
3522019-01-17T16:09:19 <hebasto_> provoostenator: thanks
3532019-01-17T16:11:41 *** m8tion has joined #bitcoin-core-dev
3542019-01-17T16:12:51 *** dabedoc has quit IRC
3552019-01-17T16:16:37 *** shesek has quit IRC
3562019-01-17T16:18:10 *** guga has quit IRC
3572019-01-17T16:19:39 *** Bilith_ has quit IRC
3582019-01-17T16:20:09 *** mistergold has quit IRC
3592019-01-17T16:20:42 *** jarthur has joined #bitcoin-core-dev
3602019-01-17T16:25:26 <jnewbery> promag: I've lost the thread a bit on where we are with #13100. Is there a path to getting all the load/unload/create wallet functionality into the GUI for v0.18?
3612019-01-17T16:25:28 <gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
3622019-01-17T16:26:23 *** bitcoin-git has joined #bitcoin-core-dev
3632019-01-17T16:26:23 <bitcoin-git> [bitcoin] rex4539 opened pull request #15188: Update zmq to 4.3.1 (master...update-zmq) https://github.com/bitcoin/bitcoin/pull/15188
3642019-01-17T16:26:23 *** bitcoin-git has left #bitcoin-core-dev
3652019-01-17T16:33:15 <luke-jr> dongcarl: /etc/conf.d/<servicename> sets them, and they're in the environment for the init script
3662019-01-17T16:33:35 *** farmerwampum has quit IRC
3672019-01-17T16:33:59 *** farmerwampum has joined #bitcoin-core-dev
3682019-01-17T16:34:03 <dongcarl> I see... I think I'll make it easy to override for systemd as well then. Thanks!
3692019-01-17T16:43:11 *** farmerwampum has quit IRC
3702019-01-17T16:44:47 *** zenogais has quit IRC
3712019-01-17T16:46:24 *** ThomasLuong has joined #bitcoin-core-dev
3722019-01-17T16:46:51 *** farmerwampum has joined #bitcoin-core-dev
3732019-01-17T16:53:35 *** ExtraCrispy has quit IRC
3742019-01-17T16:57:32 *** zenogais has joined #bitcoin-core-dev
3752019-01-17T16:59:40 *** ThomasLuong has quit IRC
3762019-01-17T16:59:51 *** farmerwampum has quit IRC
3772019-01-17T17:01:51 *** farmerwampum_ has quit IRC
3782019-01-17T17:01:52 *** farmerwampum has joined #bitcoin-core-dev
3792019-01-17T17:08:31 *** shesek has joined #bitcoin-core-dev
3802019-01-17T17:08:31 *** shesek has joined #bitcoin-core-dev
3812019-01-17T17:11:26 *** pinheadmz has joined #bitcoin-core-dev
3822019-01-17T17:15:28 *** farmerwampum has quit IRC
3832019-01-17T17:16:00 *** farmerwampum has joined #bitcoin-core-dev
3842019-01-17T17:18:41 *** farmerwampum has quit IRC
3852019-01-17T17:20:06 <wumpus> ryanofsky: thanks for the extensive reviews on various PRs by the way
3862019-01-17T17:25:47 *** promag has joined #bitcoin-core-dev
3872019-01-17T17:29:15 <promag> could #15101 be merged?
3882019-01-17T17:29:18 <gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
3892019-01-17T17:40:06 <wumpus> promag: it's quite a large chance to the gui, would be nice if jonasschnelli could at least take a look at it
3902019-01-17T17:40:48 *** elichai2 has joined #bitcoin-core-dev
3912019-01-17T17:43:51 *** wumpus has quit IRC
3922019-01-17T17:43:56 *** ThomasLuong has joined #bitcoin-core-dev
3932019-01-17T17:44:07 *** wumpus has joined #bitcoin-core-dev
3942019-01-17T17:44:38 *** farmerwampum has joined #bitcoin-core-dev
3952019-01-17T17:45:40 *** farmerwampum has left #bitcoin-core-dev
3962019-01-17T17:48:22 *** riemann has joined #bitcoin-core-dev
3972019-01-17T17:51:04 *** Murch has joined #bitcoin-core-dev
3982019-01-17T17:59:42 *** farmerwampum has joined #bitcoin-core-dev
3992019-01-17T18:03:25 *** farmerwampum has quit IRC
4002019-01-17T18:03:59 *** farmerwampum has joined #bitcoin-core-dev
4012019-01-17T18:05:26 *** davec_ has quit IRC
4022019-01-17T18:07:08 *** davec has joined #bitcoin-core-dev
4032019-01-17T18:10:43 *** promag has quit IRC
4042019-01-17T18:13:53 *** jungly has quit IRC
4052019-01-17T18:15:48 *** mistergold has joined #bitcoin-core-dev
4062019-01-17T18:18:53 *** farmerwampum has quit IRC
4072019-01-17T18:22:34 *** farmerwampum has joined #bitcoin-core-dev
4082019-01-17T18:23:27 *** farmerwampum has quit IRC
4092019-01-17T18:29:18 *** Ghost-Coder0101 has joined #bitcoin-core-dev
4102019-01-17T18:34:36 *** Ghost-Coder0101 has quit IRC
4112019-01-17T18:43:45 *** laurentmt has joined #bitcoin-core-dev
4122019-01-17T18:53:52 *** promag has joined #bitcoin-core-dev
4132019-01-17T18:55:48 <jonasschnelli> I'll take a closer look
4142019-01-17T18:59:23 <wumpus> jonasschnelli: thank you!
4152019-01-17T19:00:05 <luke-jr> hi
4162019-01-17T19:00:17 <jonasschnelli> hi
4172019-01-17T19:00:29 <gleb> hi
4182019-01-17T19:00:45 <promag> hi
4192019-01-17T19:00:48 <promag> jonasschnelli: ty
4202019-01-17T19:01:06 <wumpus> #startmeeting
4212019-01-17T19:01:06 <lightningbot> Meeting started Thu Jan 17 19:01:06 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4222019-01-17T19:01:06 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4232019-01-17T19:01:10 <achow101> hi
4242019-01-17T19:01:15 <sipa> hi, will have to run in 5-10 minutes
4252019-01-17T19:01:35 <jamesob> hi
4262019-01-17T19:01:44 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
4272019-01-17T19:02:02 <instagibbs> sup
4282019-01-17T19:02:24 <wumpus> any topics?
4292019-01-17T19:02:40 <wumpus> (nothing scheduled in moneyball's list)
4302019-01-17T19:03:00 <kanzure> hi.
4312019-01-17T19:03:27 <gleb> I would appreciate if we prioritize 14897 because a) I know someone stacks new changes on top of it and b) people on twitter are really exciting about replicating the topology inference through this vuln. on mainnet :)
4322019-01-17T19:03:35 <jonasschnelli> #14897
4332019-01-17T19:03:38 <gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
4342019-01-17T19:03:54 <wumpus> #topic high priority for review
4352019-01-17T19:04:13 <meshcollider> hi
4362019-01-17T19:04:42 <wumpus> gleb: ok added
4372019-01-17T19:04:47 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
4382019-01-17T19:05:14 <gleb> wumpus: thanks!
4392019-01-17T19:05:58 *** laurentmt has quit IRC
4402019-01-17T19:06:26 <wumpus> anyone wants anything to be added and/or removed otherwise? 7 is quite a lot of things to have in the list, in any case
4412019-01-17T19:06:58 <wumpus> anything nearing ready for merge?
4422019-01-17T19:07:10 <sipa> i'll go through them soon
4432019-01-17T19:07:13 <luke-jr> it seems 14897 was rewritten to do some refactoring too
4442019-01-17T19:07:25 <sipa> #14897
4452019-01-17T19:07:27 <gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub
4462019-01-17T19:07:34 <luke-jr> I would think it'd be nice to get a minimal implementation of the change reviewed and merged, and THEN do the refactoring
4472019-01-17T19:07:42 <luke-jr> that way the former can be backported easier
4482019-01-17T19:07:49 <wumpus> looks like meshcollider could take over jnewbery's branch in #14491 to make it pass travis again
4492019-01-17T19:07:52 <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
4502019-01-17T19:07:59 <meshcollider> Yep I'll do that shortly
4512019-01-17T19:08:27 <sipa> luke-jr: i'm not sure that's possible; do you see anything obvious that could be left out?
4522019-01-17T19:08:58 <sipa> or gleb ?
4532019-01-17T19:09:11 <luke-jr> sipa: well, the original PR was apparently 60 LOC changed, and it got revised by request?
4542019-01-17T19:09:58 <gleb> Half of the new LOC is a comment :)
4552019-01-17T19:10:41 <gleb> Most of the comments on the original work were about *significant* refactoring (move from net to net_processing), which I did
4562019-01-17T19:11:27 <luke-jr> you mean insignificant?
4572019-01-17T19:11:34 <wumpus> if you got those comments and implemented them I think it's unfair to complain about it now
4582019-01-17T19:11:40 <luke-jr> I'm not sure I have the original code to compare
4592019-01-17T19:12:27 <luke-jr> if it was just a code move, no worries
4602019-01-17T19:12:47 <luke-jr> gmaxwell's suggestion sounded more in depth than that though
4612019-01-17T19:13:00 <achow101> luke-jr: github shows the diffs between force pushes now
4622019-01-17T19:13:14 <luke-jr> achow101: how?
4632019-01-17T19:13:30 <luke-jr> ooh, neat
4642019-01-17T19:13:38 <wumpus> ok, any other topics?
4652019-01-17T19:13:41 <luke-jr> rebasing seems to break it though
4662019-01-17T19:14:18 <meshcollider> achow101: only in a nice way if it was a commit amendment, rebases are impossible to read
4672019-01-17T19:14:33 <gleb> luke-jr: Well, I first did what gmaxwell suggested (before other reviews), THEN received refactoring comments, and then we moved code. Not sure which step was wrong and what I should've done better :)
4682019-01-17T19:14:50 *** bitcoin-git has joined #bitcoin-core-dev
4692019-01-17T19:14:51 <bitcoin-git> [bitcoin] practicalswift closed pull request #15187: fees: Complete the removal of fee-estimation file read code for old versions (master...fee-estimation) https://github.com/bitcoin/bitcoin/pull/15187
4702019-01-17T19:14:51 *** bitcoin-git has left #bitcoin-core-dev
4712019-01-17T19:15:10 <luke-jr> gleb: I'm not saying any of it was wrong, just that doing it in two separate steps/PRs would make it easier to backport ONLY the fix part
4722019-01-17T19:15:39 <wumpus> if people deem the refactor a necessary part of this, then that should be backported too
4732019-01-17T19:15:54 <sipa> mostly afk, but will check occasionally if someone pings me
4742019-01-17T19:17:01 <wumpus> but sure if it's possible to do a minimal fix for the 0.17 branch that might be less risky, if this is a risky refactor, but if it's move-only I don't think that's the case
4752019-01-17T19:17:11 <wumpus> for master this is fine anyhow
4762019-01-17T19:17:14 <wumpus> any other topics?
4772019-01-17T19:20:40 <wumpus> apparently not! that's a short meeting then
4782019-01-17T19:21:25 <wumpus> #endmeeting
4792019-01-17T19:21:25 <lightningbot> Meeting ended Thu Jan 17 19:21:25 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4802019-01-17T19:21:25 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-17-19.01.html
4812019-01-17T19:21:25 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-17-19.01.txt
4822019-01-17T19:21:25 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-17-19.01.log.html
4832019-01-17T19:24:55 <sipa> sorry, seems i killed the party :)
4842019-01-17T19:25:30 <wumpus> are people traveling or is something going on?
4852019-01-17T19:26:46 <jonasschnelli> The usual january-downer probably. :)
4862019-01-17T19:26:55 <wumpus> ahh :)
4872019-01-17T19:27:14 <sipa> i'm about to fly to boston for the mystery hunt
4882019-01-17T19:28:50 <jonasschnelli> promag: with 15101, does that mean we would no longer instantiate the WalletModels at startup? (ref: with getOrCreateModel())
4892019-01-17T19:31:16 *** air_willy has joined #bitcoin-core-dev
4902019-01-17T19:31:26 <promag> WalletController construtor queries interfaces::Node for all current wallets and instantiates respective WalletModel's
4912019-01-17T19:31:40 <promag> jonasschnelli: ^
4922019-01-17T19:34:06 *** rabidus has quit IRC
4932019-01-17T19:35:41 <jonasschnelli> promag: your pull makes first use of QMutexLocker? Would it be terrible wrong to use the core class synchronisation stuff?
4942019-01-17T19:35:54 <jonasschnelli> But its probably a non issue
4952019-01-17T19:35:58 <jonasschnelli> (to use QMutexLocker)
4962019-01-17T19:36:09 *** rabidus has joined #bitcoin-core-dev
4972019-01-17T19:37:51 <promag> jonasschnelli: that's true
4982019-01-17T19:38:35 <promag> jonasschnelli: I can replace
4992019-01-17T19:39:15 <jonasschnelli> I'm not sure if it makes a difference... so I'll leave it up to you. Was just a thought
5002019-01-17T19:39:45 <jonasschnelli> But most places in the GUI code we just use our marcos (LOCK/LOCK2)
5012019-01-17T19:39:53 <jonasschnelli> *macros
5022019-01-17T19:40:11 <wumpus> if the lock is not shared with the core code, I think it's fine to use qt primitives
5032019-01-17T19:40:29 <wumpus> we also use qt's threading primitives in the qt code
5042019-01-17T19:41:10 <luke-jr> it may actually be safer to use Qt mutexes with Qt threading
5052019-01-17T19:41:14 <jonasschnelli> Yeah. I agree. I only thought: "what if we port the code to the Core layer"... but I guess that never happens.
5062019-01-17T19:41:30 <luke-jr> well, porting implies changing that then :p
5072019-01-17T19:41:37 <jonasschnelli> that *will* never happen
5082019-01-17T19:41:39 *** Krellan has quit IRC
5092019-01-17T19:41:56 <jonasschnelli> expect we'r writing a curses-like terminal UI.
5102019-01-17T19:42:50 *** np has joined #bitcoin-core-dev
5112019-01-17T19:42:58 <jonasschnelli> I agree with luke-jr, wumpus . Lets keep using QMutexLocker with QThread
5122019-01-17T19:44:02 *** rh0nj has quit IRC
5132019-01-17T19:45:08 *** rh0nj has joined #bitcoin-core-dev
5142019-01-17T19:47:04 *** np has quit IRC
5152019-01-17T19:49:24 *** Chuck_ has joined #bitcoin-core-dev
5162019-01-17T19:53:30 <promag> ok, I won't change :P
5172019-01-17T19:55:06 <wumpus> ok
5182019-01-17T19:55:58 *** air_willy has quit IRC
5192019-01-17T20:01:28 *** bitcoin-git has joined #bitcoin-core-dev
5202019-01-17T20:01:28 <bitcoin-git> [bitcoin] practicalswift opened pull request #15189: validation: Add missing cs_nBlockSequenceId lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189
5212019-01-17T20:01:28 *** bitcoin-git has left #bitcoin-core-dev
5222019-01-17T20:07:08 *** shesek has quit IRC
5232019-01-17T20:09:59 *** bitcoin-git has joined #bitcoin-core-dev
5242019-01-17T20:10:00 <bitcoin-git> [bitcoin] LifeIsPizza opened pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190
5252019-01-17T20:10:00 *** bitcoin-git has left #bitcoin-core-dev
5262019-01-17T20:10:32 <luke-jr> ^ here we go..
5272019-01-17T20:12:27 <sipa> every year :p
5282019-01-17T20:13:04 <gwillen> can we like, spent a few bucks to get a legal opinion that says you don't have to have the year in every file for it to count? :-P
5292019-01-17T20:13:10 <gwillen> I know that many projects do not do this anymore
5302019-01-17T20:13:19 <gwillen> spend*
5312019-01-17T20:13:58 *** bitcoin-git has joined #bitcoin-core-dev
5322019-01-17T20:13:58 <bitcoin-git> [bitcoin] LifeIsPizza closed pull request #15190: [Trivial] Update copyright comments to 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15190
5332019-01-17T20:13:58 *** bitcoin-git has left #bitcoin-core-dev
5342019-01-17T20:14:26 *** AaronvanW has quit IRC
5352019-01-17T20:16:16 <sipa> gwillen: IANAL but i believe those copyright statements per file (and much less the year indications) are almost certainly worthless, especially when attributing to "The Bitcoin Core developers", which is not a legal entity
5362019-01-17T20:16:26 <wumpus> it wouldn't prevent people from opening such PRs anyway
5372019-01-17T20:16:52 <wumpus> and just posting 'we do this at the end of the year' then closing isn't exactly that much work
5382019-01-17T20:16:55 <gwillen> sipa: I am in total agreement with you on this
5392019-01-17T20:17:17 <gwillen> right, but we do still actually do it, right?
5402019-01-17T20:17:35 <wumpus> yes, once per year with an automated script
5412019-01-17T20:17:40 <gwillen> ahh, *nods*
5422019-01-17T20:18:01 <gwillen> removing all the years would prevent the PRs and having to run the script, but if it's fully automated I guess it could be worse.
5432019-01-17T20:18:27 *** promag has quit IRC
5442019-01-17T20:18:59 <wumpus> hah yes, that's true, removing the years would make it impossible for people to make PR changing them
5452019-01-17T20:20:44 <gwillen> also like, when I made a new file that was largely code copied from another file, I spent some time contemplating what exactly I should do for the copyright header
5462019-01-17T20:21:01 *** bitcoin-git has joined #bitcoin-core-dev
5472019-01-17T20:21:01 <bitcoin-git> [bitcoin] practicalswift opened pull request #15191: validation: Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning. (master...cs_LastBlockFile) https://github.com/bitcoin/bitcoin/pull/15191
5482019-01-17T20:21:01 *** bitcoin-git has left #bitcoin-core-dev
5492019-01-17T20:21:03 <gwillen> which would be fixed by having a generic invariant one.
5502019-01-17T20:22:12 <luke-jr> gwillen: copyright counts even if there's no copyright notice at all
5512019-01-17T20:22:17 <luke-jr> IANAL also btw
5522019-01-17T20:23:51 <gwillen> yeah, this is true. I was going to say that a written copyright notice still does something, but after quickly reading the wikipedia article on copyright notices to refresh my memory... it's not actually clear that they have any practical effect here
5532019-01-17T20:24:27 <[\\\]> According to copyright.gov, "Copyright notice is optional for works published on or after March 1, 1989, unpublished works, and foreign works; however, there are legal benefits for including notice on your work."
5542019-01-17T20:24:32 <[\\\]> https://www.copyright.gov/circs/circ03.pdf
5552019-01-17T20:24:43 *** AaronvanW has joined #bitcoin-core-dev
5562019-01-17T20:25:05 <gwillen> the strongest benefit that Wikipedia lists is that it prevents an infringer from claiming ignorance as a defense, which would reduce statutory penalties
5572019-01-17T20:25:18 <wumpus> also mind that this is an international project, not only US law counts
5582019-01-17T20:25:40 <gwillen> anyway I'm not advocating removing the notice
5592019-01-17T20:25:50 <luke-jr> arguably, we can't remove it entirely due to the MIT license and Satoshi's notices
5602019-01-17T20:26:13 <gwillen> just replacing it with some kind of simple fixed notice with a pointer to the COPYING file, without varying years or names other than "the Bitcoin developers" or what have you
5612019-01-17T20:26:21 <wumpus> IIRC the idea was to remove the years, not the entire notice
5622019-01-17T20:26:38 <gwillen> yeah, I would advocate for removing anything that changes between files
5632019-01-17T20:26:39 <luke-jr> fwiw, from me, ACK removing years
5642019-01-17T20:26:45 *** bitcoin-git has joined #bitcoin-core-dev
5652019-01-17T20:26:46 <bitcoin-git> [bitcoin] practicalswift closed pull request #15189: validation: Add missing lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. (master...cs_nBlockSequenceId) https://github.com/bitcoin/bitcoin/pull/15189
5662019-01-17T20:26:46 *** bitcoin-git has left #bitcoin-core-dev
5672019-01-17T20:29:02 *** AaronvanW has quit IRC
5682019-01-17T20:31:11 <wumpus> how does the "Needs gitian build" label work? I've added it to #15188, does this mean it will automatically pick it up?
5692019-01-17T20:31:12 <gribble> https://github.com/bitcoin/bitcoin/issues/15188 | Update zmq to 4.3.1 by rex4539 · Pull Request #15188 · bitcoin/bitcoin · GitHub
5702019-01-17T20:33:16 *** promag has joined #bitcoin-core-dev
5712019-01-17T20:37:48 *** promag has quit IRC
5722019-01-17T20:44:17 *** promag has joined #bitcoin-core-dev
5732019-01-17T20:44:48 *** fabianfabian has joined #bitcoin-core-dev
5742019-01-17T20:45:30 *** trotski2000 has quit IRC
5752019-01-17T20:45:35 *** promag has quit IRC
5762019-01-17T20:45:49 *** AaronvanW has joined #bitcoin-core-dev
5772019-01-17T20:50:27 *** AaronvanW has quit IRC
5782019-01-17T20:57:36 <luke-jr> wumpus: fwiw, it's not exactly pretty, but I haven't had any problem reports from https://github.com/bitcoinknots/bitcoin/commit/8261704f7fec4e3879f2b018fc27eb8834e698a6 so far
5792019-01-17T21:02:50 *** AaronvanW has joined #bitcoin-core-dev
5802019-01-17T21:04:03 *** shesek has joined #bitcoin-core-dev
5812019-01-17T21:04:18 *** promag has joined #bitcoin-core-dev
5822019-01-17T21:06:50 *** Chuck_ has quit IRC
5832019-01-17T21:07:16 *** AaronvanW has quit IRC
5842019-01-17T21:17:38 *** bitcoin-git has joined #bitcoin-core-dev
5852019-01-17T21:17:39 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/12b30105fc59...cd42553b1178
5862019-01-17T21:17:39 <bitcoin-git> bitcoin/master 7c572c4 Hennadii Stepanov: Add workaround for QProgressDialog bug on macOS...
5872019-01-17T21:17:40 <bitcoin-git> bitcoin/master cd42553 Jonas Schnelli: Merge #15040: qt: Add workaround for QProgressDialog bug on macOS...
5882019-01-17T21:17:40 *** bitcoin-git has left #bitcoin-core-dev
5892019-01-17T21:18:17 *** bitcoin-git has joined #bitcoin-core-dev
5902019-01-17T21:18:17 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #15040: qt: Add workaround for QProgressDialog bug on macOS (master...20181226-fix-macos-qprogressdialog) https://github.com/bitcoin/bitcoin/pull/15040
5912019-01-17T21:18:17 *** bitcoin-git has left #bitcoin-core-dev
5922019-01-17T21:22:45 *** DeanGuss has quit IRC
5932019-01-17T21:24:46 <jonasschnelli> This is eventually ready #14353 (maybe another review)?
5942019-01-17T21:24:49 <gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
5952019-01-17T21:28:28 *** cryptapus has quit IRC
5962019-01-17T21:29:43 *** bitcoin-git has joined #bitcoin-core-dev
5972019-01-17T21:29:43 <bitcoin-git> [bitcoin] practicalswift opened pull request #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache() and benchmarks/tests. Add annotations. (master...validation-cs_main) https://github.com/bitcoin/bitcoin/pull/15192
5982019-01-17T21:29:43 *** bitcoin-git has left #bitcoin-core-dev
5992019-01-17T21:31:53 *** cryptapus has joined #bitcoin-core-dev
6002019-01-17T21:32:19 *** bitcoin-git has joined #bitcoin-core-dev
6012019-01-17T21:32:19 <bitcoin-git> [bitcoin] practicalswift closed pull request #11652: Add missing locks: validation.cpp + related (master...init-and-validation-locks) https://github.com/bitcoin/bitcoin/pull/11652
6022019-01-17T21:32:19 *** bitcoin-git has left #bitcoin-core-dev
6032019-01-17T21:35:26 *** AaronvanW has joined #bitcoin-core-dev
6042019-01-17T21:39:55 *** AJ__ has joined #bitcoin-core-dev
6052019-01-17T21:40:22 *** AaronvanW has quit IRC
6062019-01-17T21:47:31 *** hebasto_ has quit IRC
6072019-01-17T21:55:33 *** bitcoin-git has joined #bitcoin-core-dev
6082019-01-17T21:55:33 <bitcoin-git> [bitcoin] sdaftuar opened pull request #15193: Default -whitelistforcelay to off (master...2019-01-forcerelayoff) https://github.com/bitcoin/bitcoin/pull/15193
6092019-01-17T21:55:33 *** bitcoin-git has left #bitcoin-core-dev
6102019-01-17T22:02:01 *** michaelsdunn1 has quit IRC
6112019-01-17T22:02:35 *** michaelsdunn1 has joined #bitcoin-core-dev
6122019-01-17T22:02:56 *** michaelsdunn1 has quit IRC
6132019-01-17T22:06:15 *** miknotauro has joined #bitcoin-core-dev
6142019-01-17T22:13:27 *** spinza has quit IRC
6152019-01-17T22:28:23 *** pinheadmz has quit IRC
6162019-01-17T22:32:51 *** spinza has joined #bitcoin-core-dev
6172019-01-17T22:39:54 *** AaronvanW has joined #bitcoin-core-dev
6182019-01-17T22:42:12 *** Aaronvan_ has joined #bitcoin-core-dev
6192019-01-17T22:45:03 *** AaronvanW has quit IRC
6202019-01-17T22:49:16 *** Guyver2 has quit IRC
6212019-01-17T23:03:02 *** ddustin has joined #bitcoin-core-dev
6222019-01-17T23:03:54 *** ddustin has joined #bitcoin-core-dev
6232019-01-17T23:04:14 *** Aaronvan_ has quit IRC
6242019-01-17T23:05:57 *** fabianfabian has quit IRC
6252019-01-17T23:10:45 *** pinheadmz has joined #bitcoin-core-dev
6262019-01-17T23:17:11 <dongcarl> Any further review on https://github.com/bitcoin/bitcoin/pull/14605 ?
6272019-01-17T23:29:03 *** gatangan36 has joined #bitcoin-core-dev
6282019-01-17T23:29:24 *** bitcoin-git has joined #bitcoin-core-dev
6292019-01-17T23:29:24 <bitcoin-git> [bitcoin] dongcarl opened pull request #15194: Add comment describing fDisconnect behavior (master...2019-01-add-fDisconnect-comment) https://github.com/bitcoin/bitcoin/pull/15194
6302019-01-17T23:29:24 *** bitcoin-git has left #bitcoin-core-dev
6312019-01-17T23:29:50 *** pinheadmz has quit IRC
6322019-01-17T23:30:15 *** gatangan36 has quit IRC
6332019-01-17T23:33:12 *** jb55 has quit IRC
6342019-01-17T23:34:46 *** owowo has quit IRC
6352019-01-17T23:35:28 *** pinheadmz has joined #bitcoin-core-dev
6362019-01-17T23:35:55 *** morcos has quit IRC
6372019-01-17T23:38:14 <fanquake> wumpus looks like that might be the case
6382019-01-17T23:38:52 <fanquake> dongcarl congrats on the Chaincode hire
6392019-01-17T23:39:25 <dongcarl> Haha thank you thank you :-)
6402019-01-17T23:40:15 *** morcos has joined #bitcoin-core-dev
6412019-01-17T23:46:01 *** rh0nj has quit IRC
6422019-01-17T23:47:08 *** rh0nj has joined #bitcoin-core-dev