1 2019-01-18T00:15:32  *** Zenton has quit IRC
  2 2019-01-18T00:16:36  *** xor216 has joined #bitcoin-core-dev
  3 2019-01-18T00:36:20  *** ThomasLuong has quit IRC
  4 2019-01-18T00:36:43  *** miknotauro has quit IRC
  5 2019-01-18T00:39:32  *** riemann_ has joined #bitcoin-core-dev
  6 2019-01-18T00:41:47  *** riemann has quit IRC
  7 2019-01-18T00:43:22  <promag> dongcarl: sorry didn't complete the review
  8 2019-01-18T00:43:23  *** asoltys has quit IRC
  9 2019-01-18T00:44:13  *** sdaftuar has quit IRC
 10 2019-01-18T00:44:21  *** asoltys has joined #bitcoin-core-dev
 11 2019-01-18T00:45:19  *** elichai2 has quit IRC
 12 2019-01-18T00:45:41  *** bitcoin-git has joined #bitcoin-core-dev
 13 2019-01-18T00:45:41  <bitcoin-git> [bitcoin] promag opened pull request #15195: gui: Add close wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195
 14 2019-01-18T00:45:41  *** bitcoin-git has left #bitcoin-core-dev
 15 2019-01-18T00:47:55  *** sdaftuar has joined #bitcoin-core-dev
 16 2019-01-18T01:09:40  *** promag has quit IRC
 17 2019-01-18T01:25:01  *** fanquake has quit IRC
 18 2019-01-18T01:33:57  *** xor216 has left #bitcoin-core-dev
 19 2019-01-18T01:35:37  *** Krellan has joined #bitcoin-core-dev
 20 2019-01-18T01:37:19  *** pinheadmz has quit IRC
 21 2019-01-18T01:40:41  *** promag has joined #bitcoin-core-dev
 22 2019-01-18T01:45:28  *** promag has quit IRC
 23 2019-01-18T01:50:39  *** brianhoffman_ has joined #bitcoin-core-dev
 24 2019-01-18T01:51:15  *** Bullitje has joined #bitcoin-core-dev
 25 2019-01-18T01:51:34  *** riemann has joined #bitcoin-core-dev
 26 2019-01-18T01:52:00  *** schmidty_ has joined #bitcoin-core-dev
 27 2019-01-18T01:52:44  *** TheRec_ has joined #bitcoin-core-dev
 28 2019-01-18T01:52:45  *** TheRec_ has joined #bitcoin-core-dev
 29 2019-01-18T01:53:38  *** StopAndDecrypt_ has joined #bitcoin-core-dev
 30 2019-01-18T01:55:12  *** IGHOR_ has joined #bitcoin-core-dev
 31 2019-01-18T01:55:36  *** achow101_ has joined #bitcoin-core-dev
 32 2019-01-18T01:55:59  *** rafalcpp has joined #bitcoin-core-dev
 33 2019-01-18T01:56:13  *** asoltys_ has joined #bitcoin-core-dev
 34 2019-01-18T01:57:14  *** mistergold has quit IRC
 35 2019-01-18T01:58:07  *** achow101 has quit IRC
 36 2019-01-18T01:58:11  *** achow101_ is now known as achow101
 37 2019-01-18T01:59:25  *** Pasha has joined #bitcoin-core-dev
 38 2019-01-18T02:00:13  *** pinheadmz has joined #bitcoin-core-dev
 39 2019-01-18T02:00:18  *** asoltys has quit IRC
 40 2019-01-18T02:00:18  *** riemann_ has quit IRC
 41 2019-01-18T02:00:18  *** rh0nj has quit IRC
 42 2019-01-18T02:00:18  *** TheRec has quit IRC
 43 2019-01-18T02:00:18  *** schmidty has quit IRC
 44 2019-01-18T02:00:18  *** brianhoffman has quit IRC
 45 2019-01-18T02:00:18  *** Cory has quit IRC
 46 2019-01-18T02:00:18  *** StopAndDecrypt has quit IRC
 47 2019-01-18T02:00:18  *** Bullit has quit IRC
 48 2019-01-18T02:00:18  *** rafalcpp_ has quit IRC
 49 2019-01-18T02:00:18  *** IGHOR has quit IRC
 50 2019-01-18T02:00:20  *** brianhoffman_ is now known as brianhoffman
 51 2019-01-18T02:01:08  *** rh0nj has joined #bitcoin-core-dev
 52 2019-01-18T02:02:37  *** Pasha is now known as Cory
 53 2019-01-18T02:17:50  *** pinheadmz has quit IRC
 54 2019-01-18T02:25:37  *** pinheadmz has joined #bitcoin-core-dev
 55 2019-01-18T02:28:44  *** m8tion has quit IRC
 56 2019-01-18T02:40:20  *** jarthur has quit IRC
 57 2019-01-18T02:45:51  *** Murch has quit IRC
 58 2019-01-18T02:47:17  *** ddustin has quit IRC
 59 2019-01-18T02:47:57  *** ddustin has joined #bitcoin-core-dev
 60 2019-01-18T02:53:00  *** ddustin has quit IRC
 61 2019-01-18T03:04:07  *** Krellan has quit IRC
 62 2019-01-18T03:04:56  *** pinheadmz has quit IRC
 63 2019-01-18T03:05:27  *** pinheadmz has joined #bitcoin-core-dev
 64 2019-01-18T03:23:23  *** zenogais has quit IRC
 65 2019-01-18T03:24:05  *** arshbot has joined #bitcoin-core-dev
 66 2019-01-18T03:26:16  *** pinheadmz has quit IRC
 67 2019-01-18T03:38:59  *** DeanGuss has joined #bitcoin-core-dev
 68 2019-01-18T03:50:09  *** ThomasLuong has joined #bitcoin-core-dev
 69 2019-01-18T03:51:48  *** pinheadmz has joined #bitcoin-core-dev
 70 2019-01-18T03:52:31  *** zenogais has joined #bitcoin-core-dev
 71 2019-01-18T03:55:38  *** DeanGuss has quit IRC
 72 2019-01-18T03:56:05  *** DeanGuss has joined #bitcoin-core-dev
 73 2019-01-18T04:00:12  *** Murch has joined #bitcoin-core-dev
 74 2019-01-18T04:03:28  *** schnerch_ has joined #bitcoin-core-dev
 75 2019-01-18T04:06:43  *** schnerchi has quit IRC
 76 2019-01-18T04:07:38  *** pinheadmz has quit IRC
 77 2019-01-18T04:09:02  *** pinheadmz has joined #bitcoin-core-dev
 78 2019-01-18T04:11:29  *** schmidty_ has quit IRC
 79 2019-01-18T04:13:13  *** schmidty has joined #bitcoin-core-dev
 80 2019-01-18T04:13:54  *** miknotauro has joined #bitcoin-core-dev
 81 2019-01-18T04:18:10  *** schmidty has quit IRC
 82 2019-01-18T04:30:47  *** pinheadmz has quit IRC
 83 2019-01-18T04:41:20  *** ThomasLuong has quit IRC
 84 2019-01-18T04:48:06  *** schmidty has joined #bitcoin-core-dev
 85 2019-01-18T04:54:05  *** bitcoin-git has joined #bitcoin-core-dev
 86 2019-01-18T04:54:06  <bitcoin-git> [bitcoin] gkrizek opened pull request #15196: Update all subprocess.check_output functions to be Python 3.4 compatible (master...cron-ci-fix) https://github.com/bitcoin/bitcoin/pull/15196
 87 2019-01-18T04:54:06  *** bitcoin-git has left #bitcoin-core-dev
 88 2019-01-18T04:56:12  <gkrizek> wumpus: ^
 89 2019-01-18T05:11:43  *** zenogais has quit IRC
 90 2019-01-18T05:15:21  *** rhavar_ has joined #bitcoin-core-dev
 91 2019-01-18T05:17:07  *** pinheadmz has joined #bitcoin-core-dev
 92 2019-01-18T05:25:22  *** Mutter has joined #bitcoin-core-dev
 93 2019-01-18T05:26:51  *** Mutter_ has joined #bitcoin-core-dev
 94 2019-01-18T05:27:33  *** schmidty has quit IRC
 95 2019-01-18T05:30:27  *** Mutter has quit IRC
 96 2019-01-18T05:30:35  *** Murch has quit IRC
 97 2019-01-18T05:38:29  *** Murch has joined #bitcoin-core-dev
 98 2019-01-18T05:39:34  *** Mutter_ has quit IRC
 99 2019-01-18T06:02:02  *** rh0nj has quit IRC
100 2019-01-18T06:03:07  *** rh0nj has joined #bitcoin-core-dev
101 2019-01-18T06:05:48  *** promag has joined #bitcoin-core-dev
102 2019-01-18T06:09:52  *** schmidty has joined #bitcoin-core-dev
103 2019-01-18T06:10:23  *** promag has quit IRC
104 2019-01-18T06:15:17  *** schmidty has quit IRC
105 2019-01-18T06:23:12  *** pinheadmz has quit IRC
106 2019-01-18T06:26:16  *** Alixe has joined #bitcoin-core-dev
107 2019-01-18T06:27:18  <Alixe> Hello
108 2019-01-18T06:27:38  <Alixe> Can I ask questions here regarding full node?
109 2019-01-18T06:29:17  <arshbot> shoot
110 2019-01-18T06:29:21  *** schmidty has joined #bitcoin-core-dev
111 2019-01-18T06:31:46  <Alixe> So I think mining hash power can't do anything because full nodes enforce consensus rules. But some people think governments or corporates can buy a lot of nodes to affect Bitcoin with having majority of full nodes. Is it possible?
112 2019-01-18T06:32:18  *** pinheadmz has joined #bitcoin-core-dev
113 2019-01-18T06:32:45  <sipa> #bitcoin
114 2019-01-18T06:33:47  *** schmidty has quit IRC
115 2019-01-18T06:40:16  <Alixe> I really want to know devs opinion on this
116 2019-01-18T06:41:00  <luke-jr> Alixe: this is not "talk to devs", it is "talk about development", and your question is not about development. some of us are in #bitcoin too
117 2019-01-18T06:41:00  *** arshbot has quit IRC
118 2019-01-18T06:42:27  *** farmerwampum has joined #bitcoin-core-dev
119 2019-01-18T06:43:45  *** farmerwampum has left #bitcoin-core-dev
120 2019-01-18T06:51:04  <Alixe> I guess everyone is busy
121 2019-01-18T06:51:27  <Alixe> Will ask on slack maybe
122 2019-01-18T06:51:39  *** Alixe has quit IRC
123 2019-01-18T07:04:51  *** bitcoin-git has joined #bitcoin-core-dev
124 2019-01-18T07:04:52  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15197: Refactor and slightly stricter p2p message processing (master...2019/01/netmsg_1) https://github.com/bitcoin/bitcoin/pull/15197
125 2019-01-18T07:04:52  *** bitcoin-git has left #bitcoin-core-dev
126 2019-01-18T07:07:13  <wumpus> gkrizek: thanks!
127 2019-01-18T07:08:07  <gkrizek> No problem!
128 2019-01-18T07:28:09  *** guga has joined #bitcoin-core-dev
129 2019-01-18T07:28:11  *** pinheadmz has quit IRC
130 2019-01-18T07:31:21  *** Murch has quit IRC
131 2019-01-18T07:33:20  *** Murch has joined #bitcoin-core-dev
132 2019-01-18T07:34:25  *** Murch has quit IRC
133 2019-01-18T07:41:00  *** Murch has joined #bitcoin-core-dev
134 2019-01-18T07:52:22  *** schmidty has joined #bitcoin-core-dev
135 2019-01-18T07:55:59  *** hebasto has joined #bitcoin-core-dev
136 2019-01-18T07:57:04  *** schmidty has quit IRC
137 2019-01-18T07:57:51  *** guga has quit IRC
138 2019-01-18T07:57:51  *** Murch has quit IRC
139 2019-01-18T07:58:09  *** guga has joined #bitcoin-core-dev
140 2019-01-18T07:58:30  *** Murch has joined #bitcoin-core-dev
141 2019-01-18T07:58:30  *** pinheadmz has joined #bitcoin-core-dev
142 2019-01-18T08:01:46  *** pinheadmz has quit IRC
143 2019-01-18T08:06:51  *** promag has joined #bitcoin-core-dev
144 2019-01-18T08:11:07  *** promag has quit IRC
145 2019-01-18T08:18:38  *** promag has joined #bitcoin-core-dev
146 2019-01-18T08:22:01  *** schmidty has joined #bitcoin-core-dev
147 2019-01-18T08:23:03  *** promag has quit IRC
148 2019-01-18T08:26:43  *** schmidty has quit IRC
149 2019-01-18T08:32:56  *** jungly has joined #bitcoin-core-dev
150 2019-01-18T08:39:16  *** dufferzafar has joined #bitcoin-core-dev
151 2019-01-18T08:40:27  <dufferzafar> i'm doing some network measurement experiments on bitcoin
152 2019-01-18T08:40:31  <dufferzafar> i have bitcoin daemons running on multiple machines
153 2019-01-18T08:40:34  <dufferzafar> and to simulate real network like delays and latencies i'm using Linux's tc/netem
154 2019-01-18T08:40:36  <dufferzafar> i want to add delays between P2P ports of machines
155 2019-01-18T08:40:39  <dufferzafar> but i think the p2p ports aren't fixed
156 2019-01-18T08:40:42  <dufferzafar> how would i go about adding delays?
157 2019-01-18T08:41:58  <wumpus> "but i think the p2p ports aren't fixed" by default it is always 8333, unless you change it, which you obviously wouldn't do for a simulated network
158 2019-01-18T08:47:37  *** Krellan has joined #bitcoin-core-dev
159 2019-01-18T08:52:18  *** Krellan has quit IRC
160 2019-01-18T08:55:04  <wumpus> (8333 is assuming this is mainnet; testnet and regtest networks have different, but also fixed ports)
161 2019-01-18T08:57:28  *** luke-jr has quit IRC
162 2019-01-18T09:08:58  *** murrayn_ has joined #bitcoin-core-dev
163 2019-01-18T09:10:20  *** murrayn has quit IRC
164 2019-01-18T09:11:26  *** rh0nj has quit IRC
165 2019-01-18T09:12:14  *** rh0nj has joined #bitcoin-core-dev
166 2019-01-18T09:17:32  *** Murch has quit IRC
167 2019-01-18T09:18:13  *** AaronvanW has joined #bitcoin-core-dev
168 2019-01-18T09:18:16  <dufferzafar> wumpus: i did change the p2p port, but bitcoind is binding to some other ports as well
169 2019-01-18T09:18:21  <dufferzafar> it only listens on the p2p port
170 2019-01-18T09:18:42  <dufferzafar> but i think data transmissions happen on other ports (which can't be configured?)
171 2019-01-18T09:18:50  <wumpus> by default it will listen on the P2P publicly and the RPC port localhost-only
172 2019-01-18T09:19:40  <wumpus> no, there is only one kind of P2P connection and that always connects to a P2P port
173 2019-01-18T09:20:14  *** Aaronvan_ has joined #bitcoin-core-dev
174 2019-01-18T09:20:25  <dufferzafar> let me explain by the output of "lsof -i" (lists all open ports)
175 2019-01-18T09:20:28  <dufferzafar> bitcoind 22139 baadalvm  IPv4 TCP btc1:33542->btc2:12476 (ESTABLISHED)
176 2019-01-18T09:20:30  <dufferzafar> bitcoind 22139 baadalvm  IPv4 TCP *:12192 (LISTEN)
177 2019-01-18T09:20:31  <dufferzafar> bitcoind 22139 baadalvm  IPv4 TCP btc1:12192->btc2:60332 (ESTABLISHED)
178 2019-01-18T09:21:01  <dufferzafar> so, the ports 12192 & 12476 are the ones the two bitcoin processes (btc1 & btc2) are listening on
179 2019-01-18T09:21:07  <dufferzafar> these are the p2p ports
180 2019-01-18T09:21:08  <wumpus> there are two possiblities: incoming connections, which go *to* the P2P port on the local host, or outgoing connections which go to the P2P port of a remote host
181 2019-01-18T09:22:45  <dufferzafar> i don't get where the ports 33542 & 60332 are coming from
182 2019-01-18T09:22:57  <dufferzafar> i didn't specify these numbers anywhere in the config
183 2019-01-18T09:23:24  <wumpus> aren't they the ephermal source ports for the TCP connections?
184 2019-01-18T09:23:27  *** AaronvanW has quit IRC
185 2019-01-18T09:24:48  <dufferzafar> yeah, but they're dynamic right
186 2019-01-18T09:25:01  <dufferzafar> so i won't be able to set a delay
187 2019-01-18T09:25:15  <dufferzafar> because that requires me knowing the ports beforehand
188 2019-01-18T09:25:30  <dufferzafar> i was running a command like: "tcset ens3 --delay 120s --dst-network 10.17.6.18 --src-port 12476 --dst-port 12192"
189 2019-01-18T09:26:00  <dufferzafar> but since the data is being transmitted over the ephemeral ports, the delay doesn't work
190 2019-01-18T09:26:23  *** jb55 has joined #bitcoin-core-dev
191 2019-01-18T09:26:48  <wumpus> source ports for TCP connections are *always* dynamic, remember that the (source host:port, target host:port) tuple has to be unique for a connection, so otherwise you could only have one connection to a certain service from one host!
192 2019-01-18T09:27:37  <dufferzafar> yeah, i understand why it has to be dynamic
193 2019-01-18T09:27:49  <dufferzafar> but i don't get how i would be able to add delays then
194 2019-01-18T09:27:54  <wumpus> I think you need to read up on how your tooling is used with other TCP protocols, it's not really different for bitcoin
195 2019-01-18T09:28:48  <dufferzafar> i even tried something like: "tcset ens3 --delay 120s --dst-port 12192"
196 2019-01-18T09:28:53  <dufferzafar> but that doesn't work either
197 2019-01-18T09:29:15  <dufferzafar> leading me to believe that the P2P port isn't being used
198 2019-01-18T09:29:36  <echeveria> isn’t being used?
199 2019-01-18T09:29:51  *** schmidty has joined #bitcoin-core-dev
200 2019-01-18T09:29:51  <dufferzafar> as in, it is only being used to listen for new clients
201 2019-01-18T09:30:06  <dufferzafar> but the actual data is transmitted on some other port
202 2019-01-18T09:30:08  <wumpus> it is being used, believe me
203 2019-01-18T09:30:11  <dufferzafar> (just my hypothesis)
204 2019-01-18T09:30:12  <echeveria> no.
205 2019-01-18T09:30:34  <wumpus> if it's not being used then your node has no connection in the first place
206 2019-01-18T09:30:40  <echeveria> you’re not listening to experts that know the system. it does not use other ports. your hypothesis is utterly irrelevant.
207 2019-01-18T09:31:19  <wumpus> I suggest you ask in the help channel for your simulation tooling why it isn't working, I don't think anyone can help you here
208 2019-01-18T09:31:35  <wumpus> also this isn't a help channel, it's about development
209 2019-01-18T09:32:11  <dufferzafar> okay, is it bitcoin-help? i saw this channel mentioned on slack, so came here
210 2019-01-18T09:32:22  *** dufferzafar has left #bitcoin-core-dev
211 2019-01-18T09:32:53  <wumpus> it's fine as long as you don't go arguing how bitcoin's P2P protocol works...
212 2019-01-18T09:33:22  *** laurentmt has joined #bitcoin-core-dev
213 2019-01-18T09:41:28  *** Zenton has joined #bitcoin-core-dev
214 2019-01-18T09:44:30  *** rhavar_ has quit IRC
215 2019-01-18T09:51:40  *** mistergold has joined #bitcoin-core-dev
216 2019-01-18T09:55:13  *** owowo has joined #bitcoin-core-dev
217 2019-01-18T10:04:33  <DeanGuss> Anybody happen to know why wallet.cpp shuts bitcoind down when encryptwallet rpc command is called? https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp line 676
218 2019-01-18T10:08:59  <wumpus> DeanGuss: it was a crude but effective way to be sure that all the unencrypted data is removed from memory, and to be sure only the encrypted wallet is loaded next time
219 2019-01-18T10:09:59  <wumpus> the behavior is removed in #12493
220 2019-01-18T10:10:05  <gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub
221 2019-01-18T10:10:43  <wumpus> if it still shuts down it's a bug
222 2019-01-18T10:11:21  <DeanGuss> it definitely does
223 2019-01-18T10:11:38  <DeanGuss> running 0.17.1
224 2019-01-18T10:11:39  <wumpus> then, please file a bug report with as much info about the issue as possible: https://github.com/bitcoin/bitcoin/issues/new
225 2019-01-18T10:11:54  <DeanGuss> cool will do
226 2019-01-18T10:11:56  <wumpus> oh, in 0.17.1 that's expected
227 2019-01-18T10:12:20  <wumpus> you posted a link to master, which shouldn't have it anymore
228 2019-01-18T10:12:35  <wumpus> master will be 0.18.0
229 2019-01-18T10:12:35  <DeanGuss> ah.. ok cool, so next release?
230 2019-01-18T10:12:51  <wumpus> next major release
231 2019-01-18T10:12:53  <DeanGuss> sweet!  Thanks
232 2019-01-18T10:13:28  <DeanGuss> any idea when that will be?
233 2019-01-18T10:14:04  <wumpus> see #14438
234 2019-01-18T10:14:06  <gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
235 2019-01-18T10:15:05  <DeanGuss> awesome thanks
236 2019-01-18T10:17:27  *** schmidty has quit IRC
237 2019-01-18T10:18:42  *** spinza has quit IRC
238 2019-01-18T10:20:56  *** schmidty has joined #bitcoin-core-dev
239 2019-01-18T10:22:40  *** promag has joined #bitcoin-core-dev
240 2019-01-18T10:24:36  *** miknotauro has quit IRC
241 2019-01-18T10:25:28  *** schmidty has quit IRC
242 2019-01-18T10:26:47  *** promag has quit IRC
243 2019-01-18T10:30:05  *** spinza has joined #bitcoin-core-dev
244 2019-01-18T10:31:35  *** bitcoin-git has joined #bitcoin-core-dev
245 2019-01-18T10:31:35  <bitcoin-git> [bitcoin] DesWurstes opened pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
246 2019-01-18T10:31:35  *** bitcoin-git has left #bitcoin-core-dev
247 2019-01-18T10:32:58  *** owowo has quit IRC
248 2019-01-18T10:39:15  *** promag has joined #bitcoin-core-dev
249 2019-01-18T10:41:19  *** hebasto has quit IRC
250 2019-01-18T10:41:21  *** owowo has joined #bitcoin-core-dev
251 2019-01-18T10:41:25  *** hebasto_ has joined #bitcoin-core-dev
252 2019-01-18T10:49:07  <promag> jnewbery: jonasschnelli: #15195 the open/close walelt actions (it includes #15101 and #15153)
253 2019-01-18T10:49:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
254 2019-01-18T10:49:11  <gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
255 2019-01-18T10:49:13  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
256 2019-01-18T10:50:02  <promag> it would be nice someone test 15195 in linux/windows
257 2019-01-18T11:06:43  *** hebasto_ has quit IRC
258 2019-01-18T11:07:02  *** hebasto_ has joined #bitcoin-core-dev
259 2019-01-18T11:22:09  *** schmidty has joined #bitcoin-core-dev
260 2019-01-18T11:27:39  *** sipa has quit IRC
261 2019-01-18T11:27:54  *** guga has quit IRC
262 2019-01-18T11:28:49  *** sipa has joined #bitcoin-core-dev
263 2019-01-18T11:35:48  *** Krellan has joined #bitcoin-core-dev
264 2019-01-18T11:35:57  *** schmidty has quit IRC
265 2019-01-18T11:40:26  *** Krellan has quit IRC
266 2019-01-18T11:46:06  *** guga has joined #bitcoin-core-dev
267 2019-01-18T11:49:06  *** rabidus has quit IRC
268 2019-01-18T12:00:03  *** rabidus has joined #bitcoin-core-dev
269 2019-01-18T12:01:23  *** schmidty has joined #bitcoin-core-dev
270 2019-01-18T12:02:19  *** Aaronvan_ is now known as AaronvanW
271 2019-01-18T12:06:00  *** schmidty has quit IRC
272 2019-01-18T12:08:28  *** mistergold has quit IRC
273 2019-01-18T12:09:25  *** schmidty has joined #bitcoin-core-dev
274 2019-01-18T12:13:28  *** schmidty has quit IRC
275 2019-01-18T12:13:44  *** schmidty has joined #bitcoin-core-dev
276 2019-01-18T12:30:33  *** laurentmt has quit IRC
277 2019-01-18T12:48:06  *** promag has quit IRC
278 2019-01-18T12:57:01  *** rh0nj has quit IRC
279 2019-01-18T12:58:08  *** rh0nj has joined #bitcoin-core-dev
280 2019-01-18T13:23:21  *** promag has joined #bitcoin-core-dev
281 2019-01-18T13:27:33  *** promag has quit IRC
282 2019-01-18T13:35:27  *** guga_ has joined #bitcoin-core-dev
283 2019-01-18T13:37:27  *** owowo has quit IRC
284 2019-01-18T13:38:40  *** guga has quit IRC
285 2019-01-18T13:42:35  *** owowo has joined #bitcoin-core-dev
286 2019-01-18T13:49:13  *** farmerwampum has joined #bitcoin-core-dev
287 2019-01-18T13:52:22  *** farmerwampum has left #bitcoin-core-dev
288 2019-01-18T13:58:23  *** promag has joined #bitcoin-core-dev
289 2019-01-18T14:03:20  *** promag has quit IRC
290 2019-01-18T14:19:05  *** kexkey has joined #bitcoin-core-dev
291 2019-01-18T14:24:05  *** miknotauro has joined #bitcoin-core-dev
292 2019-01-18T14:33:48  *** miknotauro has quit IRC
293 2019-01-18T14:34:44  *** Guyver2 has joined #bitcoin-core-dev
294 2019-01-18T14:38:14  *** laurentmt has joined #bitcoin-core-dev
295 2019-01-18T14:52:38  *** rafalcpp has quit IRC
296 2019-01-18T14:52:40  *** queip has quit IRC
297 2019-01-18T15:02:53  *** rafalcpp has joined #bitcoin-core-dev
298 2019-01-18T15:07:57  *** queip has joined #bitcoin-core-dev
299 2019-01-18T15:18:28  *** arshbot_ has joined #bitcoin-core-dev
300 2019-01-18T15:21:40  *** laurentmt has quit IRC
301 2019-01-18T15:26:58  *** promag has joined #bitcoin-core-dev
302 2019-01-18T15:30:03  *** sakalli_ has joined #bitcoin-core-dev
303 2019-01-18T15:30:20  *** sakalli_ has joined #bitcoin-core-dev
304 2019-01-18T15:31:51  *** bitcoin-git has joined #bitcoin-core-dev
305 2019-01-18T15:31:51  <bitcoin-git> [bitcoin] practicalswift opened pull request #15201: net: Add missing cs_vNodes lock in CConnman::Stop(). Add missing locking annotation. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
306 2019-01-18T15:31:51  *** bitcoin-git has left #bitcoin-core-dev
307 2019-01-18T15:32:26  *** sakalli_ has quit IRC
308 2019-01-18T15:32:43  *** bitcoin-git has joined #bitcoin-core-dev
309 2019-01-18T15:32:43  <bitcoin-git> [bitcoin] promag opened pull request #15202: gui: Add Close All Wallets action (master...2019-01-closeallwallets) https://github.com/bitcoin/bitcoin/pull/15202
310 2019-01-18T15:32:43  *** bitcoin-git has left #bitcoin-core-dev
311 2019-01-18T15:37:59  *** bitcoin-git has joined #bitcoin-core-dev
312 2019-01-18T15:37:59  <bitcoin-git> [bitcoin] DesWurstes closed pull request #15199: P2P: Don't fill with zeros twice (master...patch-8) https://github.com/bitcoin/bitcoin/pull/15199
313 2019-01-18T15:37:59  *** bitcoin-git has left #bitcoin-core-dev
314 2019-01-18T15:44:31  *** michaelsdunn1 has joined #bitcoin-core-dev
315 2019-01-18T15:48:45  <rafalcpp> hi, how Bitcoin achieves deterministic builds of Qt client too?
316 2019-01-18T15:50:14  <rafalcpp> the Qt library itself, must be built in cross-build version, that is also deterministic and static?
317 2019-01-18T15:55:07  *** arshbot_ has quit IRC
318 2019-01-18T15:55:37  *** guga_ has quit IRC
319 2019-01-18T15:55:56  *** bitcoin-git has joined #bitcoin-core-dev
320 2019-01-18T15:55:56  <bitcoin-git> [bitcoin] dooglus opened pull request #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault) (master...fix-startup-crash) https://github.com/bitcoin/bitcoin/pull/15203
321 2019-01-18T15:55:56  *** bitcoin-git has left #bitcoin-core-dev
322 2019-01-18T16:03:56  *** bitcoin-git has joined #bitcoin-core-dev
323 2019-01-18T16:03:56  <bitcoin-git> [bitcoin] promag opened pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
324 2019-01-18T16:03:56  *** bitcoin-git has left #bitcoin-core-dev
325 2019-01-18T16:07:06  *** Meee3333 has joined #bitcoin-core-dev
326 2019-01-18T16:07:17  *** Meee3333 has quit IRC
327 2019-01-18T16:08:53  *** miknotauro has joined #bitcoin-core-dev
328 2019-01-18T16:13:21  <promag> jnewbery: jonasschnelli: see #15204 for most complete GUI work, missing "New Wallet..." action
329 2019-01-18T16:13:22  <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
330 2019-01-18T16:13:30  <achow101> rafalcpp: the depends system is used to compile all dependencies deterministically and as static libraries
331 2019-01-18T16:18:39  <rafalcpp> achow101: is there any plan on moving to cmake one day? I'm looking to recreating this but in cmake, in next months
332 2019-01-18T16:19:01  <achow101> rafalcpp: no
333 2019-01-18T16:19:48  <achow101> autotools currently works. changing to a completely different build system would require tons of work and probably no one would review it since not many people understand build systems
334 2019-01-18T16:20:26  <rafalcpp> I wonder if automake is not even harder to understand though
335 2019-01-18T16:23:35  *** schnerch_ has quit IRC
336 2019-01-18T16:27:35  *** arshbot_ has joined #bitcoin-core-dev
337 2019-01-18T16:28:23  *** kexkey has quit IRC
338 2019-01-18T16:28:53  *** promag has quit IRC
339 2019-01-18T16:35:14  *** pinheadmz has joined #bitcoin-core-dev
340 2019-01-18T16:37:55  *** kexkey has joined #bitcoin-core-dev
341 2019-01-18T16:53:08  *** arshbot_ has quit IRC
342 2019-01-18T16:59:01  *** rh0nj has quit IRC
343 2019-01-18T17:00:11  *** rh0nj has joined #bitcoin-core-dev
344 2019-01-18T17:01:10  *** miknotauro has quit IRC
345 2019-01-18T17:02:44  *** zenogais has joined #bitcoin-core-dev
346 2019-01-18T17:09:21  *** jarthur has joined #bitcoin-core-dev
347 2019-01-18T17:13:14  *** Zenton has quit IRC
348 2019-01-18T17:24:15  <wumpus> I understand automake/autoconf better than cmake and that's not saying a lot
349 2019-01-18T17:25:11  *** ThomasLuong has joined #bitcoin-core-dev
350 2019-01-18T17:25:16  <wumpus> I'd nack moving to a different build system, it's just not a good use of limited reviewer bandwidth, and it will take ages to fix all the little problems again we've managed to with this build system
351 2019-01-18T17:40:39  *** ikus has joined #bitcoin-core-dev
352 2019-01-18T17:40:41  <ikus> Hello
353 2019-01-18T17:42:12  *** luke-jr has joined #bitcoin-core-dev
354 2019-01-18T17:53:36  *** jungly has quit IRC
355 2019-01-18T17:58:53  *** achow101 has quit IRC
356 2019-01-18T18:00:02  *** achow101 has joined #bitcoin-core-dev
357 2019-01-18T18:01:50  *** promag has joined #bitcoin-core-dev
358 2019-01-18T18:02:28  *** zenogais has quit IRC
359 2019-01-18T18:10:28  *** luke-jr has quit IRC
360 2019-01-18T18:23:16  *** zenogais has joined #bitcoin-core-dev
361 2019-01-18T18:26:51  *** Aaronvan_ has joined #bitcoin-core-dev
362 2019-01-18T18:27:27  *** AaronvanW has quit IRC
363 2019-01-18T18:31:07  *** pinheadmz has quit IRC
364 2019-01-18T18:31:53  *** pinheadmz has joined #bitcoin-core-dev
365 2019-01-18T18:35:14  <jnewbery> promag: thanks. After #15204, is there just a 'create wallet' menu item to add and then we're done?
366 2019-01-18T18:35:15  <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
367 2019-01-18T18:38:40  <promag> jnewbery: yes I think so
368 2019-01-18T18:39:30  <promag> jnewbery: create wallet should open a dialog to ask for: name / external path, create empty? encrypted?
369 2019-01-18T18:39:34  *** luke-jr has joined #bitcoin-core-dev
370 2019-01-18T18:44:34  *** Murch has joined #bitcoin-core-dev
371 2019-01-18T18:44:55  <midnightmagic> Well.. boost's jam is way easier to build for, and a faster build too. But. Lot of work and hard to get right for multi-platform. :-/
372 2019-01-18T18:45:41  *** DeanGuss has quit IRC
373 2019-01-18T18:45:44  <jnewbery> I'd leave createempty and encrypted out for now to avoid dependency on 14938 and 15006. Seems like it shouldn't be too difficult to add those checkboxes in a follow-up
374 2019-01-18T18:46:47  *** Aaronvan_ has quit IRC
375 2019-01-18T18:46:52  <jnewbery> I'd really love to see load/unload/create wallet in the GUI for 0.18. Avoiding dependencies on other PRs increases the chances of us making it.
376 2019-01-18T18:47:28  *** AaronvanW has joined #bitcoin-core-dev
377 2019-01-18T18:54:29  *** ThomasLuong has quit IRC
378 2019-01-18T18:54:44  <promag> I think I can submit the "create wallet" pr this weekend
379 2019-01-18T18:55:02  *** ThomasLuong has joined #bitcoin-core-dev
380 2019-01-18T18:55:27  <promag> jnewbery: Avoiding dependencies on other PRs increases the chances of us making it -> you mean dependencies to 14938 and 15006?
381 2019-01-18T18:55:37  <promag> I don't want to depend on those
382 2019-01-18T18:56:35  <promag> initially I had the "file -> new wallet" use QInputDialog to type the wallet name
383 2019-01-18T18:57:02  <promag> and "file -> new external wallet" to use QFileDialog
384 2019-01-18T18:57:36  <promag> but I think I should create a dialog/wizard to easily extend with those options later
385 2019-01-18T19:03:09  <jnewbery> I think the distinction between open wallet and open external wallet (also new wallet and new external wallet) is probably confusing for most users. I'd lean towards just having one menu item for each
386 2019-01-18T19:03:43  <jnewbery> yes, I mean avoid having createempty and encrypted as options for create wallet, since that's unmerged functionality
387 2019-01-18T19:04:24  <promag> fot that (just one open wallet action) I would have to create a custom dialog
388 2019-01-18T19:05:20  <promag> Unless I add "file -> open wallet -> other ..." at the end of the menu
389 2019-01-18T19:06:12  *** pinheadmz has quit IRC
390 2019-01-18T19:07:16  <promag> jnewbery: I also think it's fair to improve after 0.18
391 2019-01-18T19:07:22  *** pinheadmz has joined #bitcoin-core-dev
392 2019-01-18T19:08:52  *** bitcoin-git has joined #bitcoin-core-dev
393 2019-01-18T19:08:52  <bitcoin-git> [bitcoin] jamesob opened pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
394 2019-01-18T19:08:52  *** bitcoin-git has left #bitcoin-core-dev
395 2019-01-18T19:11:15  *** ikus has quit IRC
396 2019-01-18T19:14:28  *** kexkey has quit IRC
397 2019-01-18T19:14:56  *** promag has quit IRC
398 2019-01-18T19:15:00  *** kexkey has joined #bitcoin-core-dev
399 2019-01-18T19:32:04  *** Victorsueca has joined #bitcoin-core-dev
400 2019-01-18T19:37:31  *** Murch has quit IRC
401 2019-01-18T19:48:25  *** owowo has quit IRC
402 2019-01-18T19:50:30  *** Murch has joined #bitcoin-core-dev
403 2019-01-18T19:53:40  *** owowo has joined #bitcoin-core-dev
404 2019-01-18T19:55:44  *** spaced0ut has quit IRC
405 2019-01-18T19:59:58  *** spaced0ut has joined #bitcoin-core-dev
406 2019-01-18T20:08:30  *** farmerwampum has joined #bitcoin-core-dev
407 2019-01-18T20:21:37  *** bitcoin-git has joined #bitcoin-core-dev
408 2019-01-18T20:21:37  <bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cd42553b1178...63144335becb
409 2019-01-18T20:21:38  <bitcoin-git> bitcoin/master cefb399 João Barbosa: gui: Use AutoConnection for WalletModel::unload signal
410 2019-01-18T20:21:38  <bitcoin-git> bitcoin/master 8fa271f João Barbosa: gui: Add WalletController
411 2019-01-18T20:21:39  <bitcoin-git> bitcoin/master 0dd9bde João Barbosa: gui: Refactor to use WalletController
412 2019-01-18T20:21:39  *** bitcoin-git has left #bitcoin-core-dev
413 2019-01-18T20:22:16  *** bitcoin-git has joined #bitcoin-core-dev
414 2019-01-18T20:22:17  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #15101: gui: Add WalletController (master...2019-01-walletcontroller) https://github.com/bitcoin/bitcoin/pull/15101
415 2019-01-18T20:22:17  *** bitcoin-git has left #bitcoin-core-dev
416 2019-01-18T20:24:37  *** kexkey has quit IRC
417 2019-01-18T20:28:35  *** farmerwampum has quit IRC
418 2019-01-18T20:28:59  *** farmerwampum has joined #bitcoin-core-dev
419 2019-01-18T20:30:03  *** riemann_ has joined #bitcoin-core-dev
420 2019-01-18T20:30:24  *** luke-jr has quit IRC
421 2019-01-18T20:32:14  *** laurentmt has joined #bitcoin-core-dev
422 2019-01-18T20:32:33  *** riemann has quit IRC
423 2019-01-18T20:33:06  *** farmerwampum has quit IRC
424 2019-01-18T20:33:30  *** farmerwampum has joined #bitcoin-core-dev
425 2019-01-18T20:34:11  *** promag has joined #bitcoin-core-dev
426 2019-01-18T20:34:15  *** luke-jr has joined #bitcoin-core-dev
427 2019-01-18T20:39:03  <promag> jonasschnelli ty \o/
428 2019-01-18T20:39:22  <jnewbery> I agree! \o/
429 2019-01-18T20:39:32  *** DougieBot5000_ has joined #bitcoin-core-dev
430 2019-01-18T20:39:44  <jonasschnelli> I think its good enough,... minor comment improvements (and similar things) can be done later
431 2019-01-18T20:39:46  <promag> jnewbery: typo in "Add an "opem wallet" command in bitcoin-qt" 13059
432 2019-01-18T20:39:52  *** DougieBot5000 is now known as Guest50915
433 2019-01-18T20:39:52  *** DougieBot5000_ is now known as DougieBot5000
434 2019-01-18T20:40:07  <jnewbery> fixed. Thanks
435 2019-01-18T20:40:10  *** bitcoin-git has joined #bitcoin-core-dev
436 2019-01-18T20:40:11  <bitcoin-git> [bitcoin] promag closed pull request #13100: gui: Add dynamic wallets support  (master...2018-04-ui-open-wallet) https://github.com/bitcoin/bitcoin/pull/13100
437 2019-01-18T20:40:11  *** bitcoin-git has left #bitcoin-core-dev
438 2019-01-18T20:41:36  <jnewbery> #15153 is next in the sequence I think. Mind if I add it to high priority?
439 2019-01-18T20:41:39  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
440 2019-01-18T20:41:44  <promag> sure
441 2019-01-18T20:41:51  *** laurentmt has quit IRC
442 2019-01-18T20:41:56  <promag> hope we get "open wallet" and "close wallet" the next couple of days
443 2019-01-18T20:42:32  *** Guest50915 has quit IRC
444 2019-01-18T20:42:34  <jnewbery> That'd be great. Thanks for all your work on this!
445 2019-01-18T20:42:58  <promag> "close all wallets" is optional I think
446 2019-01-18T20:43:11  <promag> no problem, sorry for the delay
447 2019-01-18T20:44:48  <promag> had to make listwalletdir, walletlocation in before this. also #14670 to a lot to fix
448 2019-01-18T20:44:50  <gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
449 2019-01-18T20:44:54  <promag> *took a lot
450 2019-01-18T20:46:16  <jnewbery> yeah, that one took a while. I don't think there have been any complaints since 14670 so hopefully we won't have to touch that again
451 2019-01-18T20:50:08  *** promag has quit IRC
452 2019-01-18T20:50:44  *** promag has joined #bitcoin-core-dev
453 2019-01-18T20:53:33  *** ranabd36 has joined #bitcoin-core-dev
454 2019-01-18T20:53:43  <jonasschnelli> #14353 needs re-acks and another review (easy to review)
455 2019-01-18T20:53:45  <gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub
456 2019-01-18T20:54:57  *** pinheadmz has quit IRC
457 2019-01-18T20:55:11  *** promag has quit IRC
458 2019-01-18T20:55:12  *** ranabd36 has quit IRC
459 2019-01-18T21:02:40  *** mistergold has joined #bitcoin-core-dev
460 2019-01-18T21:04:49  *** zivl has joined #bitcoin-core-dev
461 2019-01-18T21:08:13  *** riemann_ has quit IRC
462 2019-01-18T21:11:08  *** dgenr8 has joined #bitcoin-core-dev
463 2019-01-18T21:16:31  *** bitcoin-git has joined #bitcoin-core-dev
464 2019-01-18T21:16:31  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15206: p2p: immediately disconnect on invalid net message checksum (master...2019/01/netmsg_2) https://github.com/bitcoin/bitcoin/pull/15206
465 2019-01-18T21:16:31  *** bitcoin-git has left #bitcoin-core-dev
466 2019-01-18T21:31:26  *** kinlo has quit IRC
467 2019-01-18T21:31:41  *** Krellan has joined #bitcoin-core-dev
468 2019-01-18T21:35:45  *** kinlo has joined #bitcoin-core-dev
469 2019-01-18T21:36:45  *** spinza has quit IRC
470 2019-01-18T21:38:36  *** farmerwampum has quit IRC
471 2019-01-18T21:39:21  *** spaced0ut has quit IRC
472 2019-01-18T21:40:48  *** spinza has joined #bitcoin-core-dev
473 2019-01-18T21:44:49  *** pinheadmz has joined #bitcoin-core-dev
474 2019-01-18T21:45:44  *** farmerwampum has joined #bitcoin-core-dev
475 2019-01-18T21:48:36  *** DeanGuss has joined #bitcoin-core-dev
476 2019-01-18T21:50:23  *** Murch has quit IRC
477 2019-01-18T21:54:14  *** Murch has joined #bitcoin-core-dev
478 2019-01-18T22:01:51  *** pinheadmz has quit IRC
479 2019-01-18T22:02:56  *** pinheadmz has joined #bitcoin-core-dev
480 2019-01-18T22:04:12  *** mistergo1d has joined #bitcoin-core-dev
481 2019-01-18T22:05:02  *** luke-jr has quit IRC
482 2019-01-18T22:07:53  *** spinza has quit IRC
483 2019-01-18T22:08:02  *** mistergold has quit IRC
484 2019-01-18T22:09:50  <jnewbery> jonasschnelli: done!
485 2019-01-18T22:10:11  *** Guyver2 has quit IRC
486 2019-01-18T22:32:08  *** spinza has joined #bitcoin-core-dev
487 2019-01-18T22:32:45  *** luke-jr has joined #bitcoin-core-dev
488 2019-01-18T22:46:27  *** jarthur_ has joined #bitcoin-core-dev
489 2019-01-18T22:48:07  *** jarthur has quit IRC
490 2019-01-18T22:49:05  *** spinza has quit IRC
491 2019-01-18T22:50:17  *** farmerwampum has quit IRC
492 2019-01-18T22:56:48  *** spinza has joined #bitcoin-core-dev
493 2019-01-18T22:57:16  *** rh0nj has quit IRC
494 2019-01-18T22:58:08  *** rh0nj has joined #bitcoin-core-dev
495 2019-01-18T23:01:38  *** spinza has quit IRC
496 2019-01-18T23:03:38  *** Murch has quit IRC
497 2019-01-18T23:05:30  *** kexkey has joined #bitcoin-core-dev
498 2019-01-18T23:05:58  *** spinza has joined #bitcoin-core-dev
499 2019-01-18T23:07:49  *** jarthur_ is now known as jarthur
500 2019-01-18T23:09:22  *** TX1683 has quit IRC
501 2019-01-18T23:10:44  *** kexkey has quit IRC
502 2019-01-18T23:10:54  *** michaelsdunn1 has quit IRC
503 2019-01-18T23:12:21  *** Murch has joined #bitcoin-core-dev
504 2019-01-18T23:15:32  *** TX1683 has joined #bitcoin-core-dev
505 2019-01-18T23:26:16  *** kexkey has joined #bitcoin-core-dev
506 2019-01-18T23:32:20  *** ratonlaveur has joined #bitcoin-core-dev
507 2019-01-18T23:33:23  *** farmerwampum has joined #bitcoin-core-dev
508 2019-01-18T23:38:31  *** jarthur has quit IRC
509 2019-01-18T23:38:51  *** farmerwampum has quit IRC
510 2019-01-18T23:38:58  *** jarthur has joined #bitcoin-core-dev
511 2019-01-18T23:40:50  *** pinheadmz has quit IRC
512 2019-01-18T23:42:18  *** ratonlaveur_ has joined #bitcoin-core-dev
513 2019-01-18T23:42:54  *** ratonlaveur__ has joined #bitcoin-core-dev
514 2019-01-18T23:42:59  *** ratonlaveur has quit IRC
515 2019-01-18T23:47:19  *** ratonlaveur_ has quit IRC
516 2019-01-18T23:56:17  *** jarthur has quit IRC
517 2019-01-18T23:58:48  *** coco has joined #bitcoin-core-dev