12019-01-29T00:11:36 *** ThomasLuong has quit IRC
22019-01-29T00:15:16 *** spinza has quit IRC
32019-01-29T00:19:44 *** michaelsdunn1 has quit IRC
42019-01-29T00:34:36 *** spinza has joined #bitcoin-core-dev
52019-01-29T00:35:17 *** jarthur has quit IRC
62019-01-29T00:37:52 *** gelmutshmidt has quit IRC
72019-01-29T01:16:30 *** ratonlaveur has quit IRC
82019-01-29T01:18:47 *** miknotauro has quit IRC
92019-01-29T01:22:47 *** AaronvanW has quit IRC
102019-01-29T01:22:57 *** pinheadmz has quit IRC
112019-01-29T01:25:22 *** AaronvanW has joined #bitcoin-core-dev
122019-01-29T01:28:12 *** ap4lmtree has quit IRC
132019-01-29T01:29:34 *** promag has quit IRC
142019-01-29T01:31:40 *** ratonlaveur has joined #bitcoin-core-dev
152019-01-29T01:40:45 *** ertasdf has joined #bitcoin-core-dev
162019-01-29T01:42:20 *** ertasdf has quit IRC
172019-01-29T01:48:10 *** Murch has quit IRC
182019-01-29T01:53:40 *** AaronvanW has quit IRC
192019-01-29T02:03:16 *** ap4lmtree has joined #bitcoin-core-dev
202019-01-29T02:03:43 *** drexl has quit IRC
212019-01-29T02:12:02 *** hashist has quit IRC
222019-01-29T02:25:29 *** mistergold has joined #bitcoin-core-dev
232019-01-29T02:29:07 *** mistergo1d has quit IRC
242019-01-29T02:30:29 *** pinheadmz has joined #bitcoin-core-dev
252019-01-29T02:42:06 *** Skirmant has quit IRC
262019-01-29T02:57:27 *** ratonlaveur has quit IRC
272019-01-29T03:13:18 *** kinlo has quit IRC
282019-01-29T03:20:12 *** mistergo1d has joined #bitcoin-core-dev
292019-01-29T03:20:21 *** kinlo has joined #bitcoin-core-dev
302019-01-29T03:24:10 *** mistergold has quit IRC
312019-01-29T03:36:50 *** pinheadmz has quit IRC
322019-01-29T03:51:07 *** pinheadmz has joined #bitcoin-core-dev
332019-01-29T04:05:51 *** mistergold has joined #bitcoin-core-dev
342019-01-29T04:09:26 *** mistergo1d has quit IRC
352019-01-29T04:17:32 *** mistergo1d has joined #bitcoin-core-dev
362019-01-29T04:20:28 *** mistergold has quit IRC
372019-01-29T04:32:08 *** mistergo1d has quit IRC
382019-01-29T04:33:46 *** hebasto has joined #bitcoin-core-dev
392019-01-29T04:39:20 *** ap4lmtree- has joined #bitcoin-core-dev
402019-01-29T04:42:16 *** ap4lmtree has quit IRC
412019-01-29T04:52:06 *** pinheadmz has quit IRC
422019-01-29T04:53:42 *** pinheadmz has joined #bitcoin-core-dev
432019-01-29T05:21:43 *** Zenton has quit IRC
442019-01-29T05:29:26 *** Zenton has joined #bitcoin-core-dev
452019-01-29T05:33:26 *** Zenton has quit IRC
462019-01-29T05:34:15 *** Zenton has joined #bitcoin-core-dev
472019-01-29T05:57:45 *** dviola has joined #bitcoin-core-dev
482019-01-29T06:00:15 <Bullit> Hello, I have a questions concerning the potential of distribution, is there a map with distribution spread network ups since 2014?
492019-01-29T06:00:28 <echeveria> Bullit: #bitcoin please.
502019-01-29T06:06:13 *** Kevin__6 has joined #bitcoin-core-dev
512019-01-29T06:17:23 *** ThomasLuong has joined #bitcoin-core-dev
522019-01-29T06:20:17 *** pinheadmz has quit IRC
532019-01-29T06:21:15 *** miknotauro has joined #bitcoin-core-dev
542019-01-29T06:35:23 *** pinheadmz has joined #bitcoin-core-dev
552019-01-29T06:44:47 *** Krellan has joined #bitcoin-core-dev
562019-01-29T06:52:36 *** pinheadmz has quit IRC
572019-01-29T07:01:10 *** Kevin__6 has quit IRC
582019-01-29T07:08:02 *** pinheadmz has joined #bitcoin-core-dev
592019-01-29T07:16:17 *** Skirmant has joined #bitcoin-core-dev
602019-01-29T07:19:21 *** tomrobbo has joined #bitcoin-core-dev
612019-01-29T07:23:01 *** jimmysong has quit IRC
622019-01-29T07:23:25 *** jimmysong has joined #bitcoin-core-dev
632019-01-29T07:31:27 *** tomrobbo has quit IRC
642019-01-29T08:06:01 *** rex4539 has quit IRC
652019-01-29T08:11:09 *** pinheadmz has quit IRC
662019-01-29T08:11:35 *** pinheadmz has joined #bitcoin-core-dev
672019-01-29T08:27:26 *** dviola has quit IRC
682019-01-29T09:01:11 *** setpill has joined #bitcoin-core-dev
692019-01-29T09:04:06 *** timothy has joined #bitcoin-core-dev
702019-01-29T09:07:36 *** setpill has quit IRC
712019-01-29T09:09:39 *** setpill has joined #bitcoin-core-dev
722019-01-29T09:40:47 *** miknotauro has quit IRC
732019-01-29T09:41:43 *** miknotauro has joined #bitcoin-core-dev
742019-01-29T10:13:38 *** fanquake has joined #bitcoin-core-dev
752019-01-29T10:23:19 *** Guyver2 has joined #bitcoin-core-dev
762019-01-29T10:26:16 *** promag has joined #bitcoin-core-dev
772019-01-29T10:31:27 *** jungly has joined #bitcoin-core-dev
782019-01-29T10:40:28 *** tomrobbo has joined #bitcoin-core-dev
792019-01-29T10:52:45 <stevenroose> luke-jr: people don't like BIP70, though :)
802019-01-29T10:53:29 <stevenroose> sipa: unless you want it to be usable with other networks so you just want to leave space for more values without wanting to have to go arbiter what values are legitimate
812019-01-29T10:57:34 *** spinza has quit IRC
822019-01-29T10:59:45 <echeveria> "legitimate" is irrelevant really. most altcoins just re-using the same version bytes for P2PKH or P2SH should tell you that.
832019-01-29T11:01:34 *** spinza has joined #bitcoin-core-dev
842019-01-29T11:03:58 *** e4xit has quit IRC
852019-01-29T11:05:11 <cjd> altcoins just re-using the same version bytes for P2PKH or P2SH <-- probably because they want to be able to pull from upstream with minimal patching
862019-01-29T11:05:14 *** e4xit has joined #bitcoin-core-dev
872019-01-29T11:09:14 <echeveria> no, it's generally because they're unaware of the impact. see Litecoin duplicating the P2SH version byte but not the P2PKH version byte.
882019-01-29T11:11:53 <cjd> In the case of segwit version bytes, I must admit I'm also unaware of the impact
892019-01-29T11:12:54 <echeveria> in any case you can't expect that people will change version bytes at all, or that bitcoin won't, so using them as identifiers would be a poor decision.
902019-01-29T11:15:56 <cjd> *nod* I wouldn't, and since I'm working on an alt I guess that's significant
912019-01-29T11:16:41 <cjd> though changing the magic is something I sort of expect people to do, since the way the code is laid out sort of encourages it
922019-01-29T11:27:33 *** promag has quit IRC
932019-01-29T11:32:31 *** drexl has joined #bitcoin-core-dev
942019-01-29T11:34:13 *** promag has joined #bitcoin-core-dev
952019-01-29T11:38:46 *** promag has quit IRC
962019-01-29T11:39:05 *** tomrobbo has quit IRC
972019-01-29T11:44:02 *** miknotauro has quit IRC
982019-01-29T11:45:45 *** promag has joined #bitcoin-core-dev
992019-01-29T11:50:28 *** AaronvanW has joined #bitcoin-core-dev
1002019-01-29T11:58:00 <luke-jr> stevenroose: sure, I was just mentioning it since it has string network ids
1012019-01-29T12:07:12 <stevenroose> I'm leaning towards network magic (uint32) or BIP44 coin type ids: https://github.com/satoshilabs/slips/blob/master/slip-0044.md
1022019-01-29T12:08:42 <echeveria> both of which are things that altcoins frequently don't change.
1032019-01-29T12:13:46 <stevenroose> echeveria: I generally don't really care about altcoins ;)
1042019-01-29T12:14:00 <stevenroose> mostly thinking liquid or other potential sidechains
1052019-01-29T12:15:37 <echeveria> stevenroose: that's nice. back here in the real world, things exist which you may not like and you need to take them into consideration when writing specifications.
1062019-01-29T12:41:18 <fanquake> wumpus #15270 probably mergable (given Ken has tested on windows), also 15252 & 15243.
1072019-01-29T12:41:21 <gribble> https://github.com/bitcoin/bitcoin/issues/15270 | Pull leveldb subtree by MarcoFalke · Pull Request #15270 · bitcoin/bitcoin · GitHub
1082019-01-29T13:03:57 *** Guyver2 has quit IRC
1092019-01-29T13:13:04 *** dviola has joined #bitcoin-core-dev
1102019-01-29T13:13:35 *** promag has quit IRC
1112019-01-29T13:42:22 *** mildly_risky has joined #bitcoin-core-dev
1122019-01-29T13:42:37 *** promag has joined #bitcoin-core-dev
1132019-01-29T13:47:08 *** promag has quit IRC
1142019-01-29T13:57:25 *** pinheadmz has joined #bitcoin-core-dev
1152019-01-29T14:03:22 *** Skirmant has quit IRC
1162019-01-29T14:11:55 *** promag has joined #bitcoin-core-dev
1172019-01-29T14:12:59 *** pinheadmz has quit IRC
1182019-01-29T14:21:00 *** dviola has quit IRC
1192019-01-29T14:33:34 *** diego3 has joined #bitcoin-core-dev
1202019-01-29T14:34:18 *** diego3 has quit IRC
1212019-01-29T14:40:21 *** laurentmt has joined #bitcoin-core-dev
1222019-01-29T14:40:43 *** rex4539 has joined #bitcoin-core-dev
1232019-01-29T14:43:20 *** zagalou has joined #bitcoin-core-dev
1242019-01-29T15:02:23 <promag> provoostenator: hebasto: could you test #15153, it is rebased on #15280.
1252019-01-29T15:02:31 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
1262019-01-29T15:02:32 <gribble> https://github.com/bitcoin/bitcoin/issues/15280 | gui: Fix shutdown order by promag · Pull Request #15280 · bitcoin/bitcoin · GitHub
1272019-01-29T15:02:57 <provoostenator> promag: yeah, was about to run through my Github notifications...
1282019-01-29T15:03:53 <fanquake> I think a fair bit needs rebasing now
1292019-01-29T15:07:01 <provoostenator> We need rebase bots that devs can run on their computer, to handle the more trivial rebases.
1302019-01-29T15:07:12 <provoostenator> That or assistants :-)
1312019-01-29T15:08:54 <provoostenator> "Always two there are. No more, no less. A master and a rebaser"
1322019-01-29T15:15:18 *** pinheadmz has joined #bitcoin-core-dev
1332019-01-29T15:15:27 *** laurentmt has quit IRC
1342019-01-29T15:23:57 <promag> provoostenator: ty
1352019-01-29T15:30:52 *** kexkey has joined #bitcoin-core-dev
1362019-01-29T15:32:09 *** michaelsdunn1 has joined #bitcoin-core-dev
1372019-01-29T15:32:19 *** pinheadmz has quit IRC
1382019-01-29T15:37:15 <provoostenator> sipa promag can you leave some more thoughts about error catching on #14978? (maybe distinguish between best long term and fine for now)
1392019-01-29T15:37:19 <gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
1402019-01-29T15:38:47 *** zagalou has quit IRC
1412019-01-29T15:41:58 *** pinheadmz has joined #bitcoin-core-dev
1422019-01-29T15:43:02 *** Guyver2 has joined #bitcoin-core-dev
1432019-01-29T15:49:35 *** fanquake has quit IRC
1442019-01-29T15:53:13 *** Dean_Guss has quit IRC
1452019-01-29T15:53:44 <promag> I tend to avoid exceptions, and I don't see a strong reason to use them. I usually try to distinguish exceptions from validations and failures. In that case exception is something that the code doesn't handle so it is interrupted.
1462019-01-29T15:56:00 <promag> Also, I think it's bad practice to use exceptions as a way to do control flow
1472019-01-29T15:57:46 <provoostenator> My suggestion for using exceptions was mostly based on how RPC currently already uses that pattern. I'm also fine with functions returning status codes and passing &error strings e.g.,
1482019-01-29T16:00:53 <promag> some reading https://softwareengineering.stackexchange.com/a/189225
1492019-01-29T16:01:58 *** pinheadmz has quit IRC
1502019-01-29T16:04:11 <hebasto> promag: will do
1512019-01-29T16:04:29 <cjd> I always felt like in a parser, throwing is the right way to bail out of deeply nested parsing when you hit something that's invalid and wrong
1522019-01-29T16:04:45 <cjd> otherwise it's layer after layer of if err { return err; }
1532019-01-29T16:04:48 *** setpill has quit IRC
1542019-01-29T16:05:01 <cjd> sorry if err != nil { return err; } :)
1552019-01-29T16:06:39 <promag> MarcoFalke: not sure if serious or trolling :D
1562019-01-29T16:09:34 *** spinza has quit IRC
1572019-01-29T16:11:45 <promag> cjd: maybe it should not have such call stack depth
1582019-01-29T16:12:45 <cjd> there are non-recursive ways to parse nested structured data, but you're just putting the stack somewhere else
1592019-01-29T16:14:06 <cjd> I agree that runtime exceptions in c++ are monsters because of constructors and destructors, but I think exceptions have been wrongly blamed for that
1602019-01-29T16:15:23 <cjd> IMO throw is the correct way to say "none of what we're doing is useful anymore, bail out and fail whatever we were trying to do"
1612019-01-29T16:16:47 <promag> cjd: the problem is not at throw, but where it is catched
1622019-01-29T16:17:42 <promag> you never know to where you are throwing, and what is ditched in between
1632019-01-29T16:18:46 <cjd> you mean what was allocated ?
1642019-01-29T16:19:36 <promag> not only that, but what was changed, written to disk, displayed on the screen whatever
1652019-01-29T16:20:01 <promag> I think it is always preferable to return to the caller with enough information
1662019-01-29T16:20:44 <cjd> Ahh, you're talking about public API throwing, that's a good point
1672019-01-29T16:21:20 <cjd> I tend to confine my throws to either what will stay in a file or what will terminate the program
1682019-01-29T16:27:47 <provoostenator> You could have a rule that a caller MUST catch any exception class defined in the callee. I think some languages do that. Not sure how easy to automagically enforce though.
1692019-01-29T16:33:49 *** spinza has joined #bitcoin-core-dev
1702019-01-29T16:34:05 <promag> provoostenator: return a typed error instead?
1712019-01-29T16:34:50 <promag> take Qt for instance, it is a mature c++ framework, it avoids exceptions
1722019-01-29T16:37:09 <cjd> throwing unchecked exceptions from an API is basically like calling abort() IMO
1732019-01-29T16:41:55 <provoostenator> When it comes to the wallet RPC there's another problem, namely that we can't really do atomic operations.
1742019-01-29T16:57:34 *** promag has quit IRC
1752019-01-29T16:58:10 *** promag has joined #bitcoin-core-dev
1762019-01-29T17:02:45 *** promag has quit IRC
1772019-01-29T17:04:52 *** pinheadmz has joined #bitcoin-core-dev
1782019-01-29T17:05:01 *** rh0nj has quit IRC
1792019-01-29T17:06:07 *** rh0nj has joined #bitcoin-core-dev
1802019-01-29T17:34:49 *** pinheadmz has quit IRC
1812019-01-29T17:35:06 *** promag has joined #bitcoin-core-dev
1822019-01-29T17:38:41 *** Murch has joined #bitcoin-core-dev
1832019-01-29T17:43:29 <promag> provoostenator: have you seen #11826?
1842019-01-29T17:43:31 <gribble> https://github.com/bitcoin/bitcoin/issues/11826 | RFC: Activity feature · Issue #11826 · bitcoin/bitcoin · GitHub
1852019-01-29T17:44:49 <provoostenator> I think I have in the past yes. It's pretty ugly in the animated gif though :-)
1862019-01-29T17:45:32 <provoostenator> I would probably reuse the bottom progress bar (used during IBD) and when you click on that, show different interuptable processes.
1872019-01-29T17:46:20 <provoostenator> (I'll leave a comment to that effect)
1882019-01-29T17:46:31 <promag> provoostenator: ah I see you are a man of taste XD
1892019-01-29T17:47:00 <promag> well I'm point out that because of the load wallet progress
1902019-01-29T17:47:28 <provoostenator> I think instagibbs ownes the man-of-taste trademark.
1912019-01-29T17:49:01 <promag> I think something like that must be in place to correctly implement non-blocking UI.
1922019-01-29T17:49:38 <provoostenator> I don't mind blocking the UI for one-off long stuff like rescanning a long unused wallet. Non-blocking of course would be nice.
1932019-01-29T17:50:59 <provoostenator> Did Travis get slower again? A few weeks ago it seemed to finish a lot of runs in <15 minutes, but now I'm seeing 30+ minutes for my PR again.
1942019-01-29T17:51:37 *** pinheadmz has joined #bitcoin-core-dev
1952019-01-29T17:52:09 *** Dean_Guss has joined #bitcoin-core-dev
1962019-01-29T17:55:37 *** jungly has quit IRC
1972019-01-29T17:57:06 *** jarthur has joined #bitcoin-core-dev
1982019-01-29T18:00:28 *** davec has quit IRC
1992019-01-29T18:02:27 *** davec has joined #bitcoin-core-dev
2002019-01-29T18:12:16 *** promag has quit IRC
2012019-01-29T18:20:07 *** pinheadmz has quit IRC
2022019-01-29T18:27:01 *** hebasto has quit IRC
2032019-01-29T18:27:14 *** laurentmt has joined #bitcoin-core-dev
2042019-01-29T18:31:33 *** pinheadmz has joined #bitcoin-core-dev
2052019-01-29T18:40:40 *** djaen has joined #bitcoin-core-dev
2062019-01-29T18:41:12 *** laurentmt has quit IRC
2072019-01-29T18:45:25 *** timothy has quit IRC
2082019-01-29T18:48:00 *** djaen has quit IRC
2092019-01-29T19:06:19 <instagibbs> it's extremely variable for my repos
2102019-01-29T19:07:07 *** promag has joined #bitcoin-core-dev
2112019-01-29T19:09:41 *** Krellan has quit IRC
2122019-01-29T19:11:18 *** promag has quit IRC
2132019-01-29T19:31:40 *** ThomasLuong has joined #bitcoin-core-dev
2142019-01-29T19:33:26 <MarcoFalke> provoostenator: Might be one of the sanitizer jobs
2152019-01-29T19:35:31 <MarcoFalke> wumpus: Mind adding dongcarl to the github org? Would make it easier to use the pull request filter auto-suggestion.
2162019-01-29T19:37:38 *** h9560 has joined #bitcoin-core-dev
2172019-01-29T19:40:38 *** h9560 has quit IRC
2182019-01-29T19:41:17 <sdaftuar> i think #14929 is ready for merge
2192019-01-29T19:41:20 <gribble> https://github.com/bitcoin/bitcoin/issues/14929 | net: Allow connections from misbehavior banned peers by gmaxwell · Pull Request #14929 · bitcoin/bitcoin · GitHub
2202019-01-29T19:51:12 *** Bullitje has joined #bitcoin-core-dev
2212019-01-29T19:52:31 *** Evel-Knievel has quit IRC
2222019-01-29T19:52:39 *** Evel-Knievel has joined #bitcoin-core-dev
2232019-01-29T19:54:35 *** Bullit has quit IRC
2242019-01-29T20:09:03 *** promag has joined #bitcoin-core-dev
2252019-01-29T20:25:15 *** promag has quit IRC
2262019-01-29T20:33:13 *** ThomasLuong has quit IRC
2272019-01-29T20:34:20 *** ThomasLuong has joined #bitcoin-core-dev
2282019-01-29T20:35:26 *** ThomasLuong has quit IRC
2292019-01-29T20:36:30 *** ThomasLuong has joined #bitcoin-core-dev
2302019-01-29T20:50:36 *** promag has joined #bitcoin-core-dev
2312019-01-29T20:50:39 *** promag has quit IRC
2322019-01-29T20:50:57 *** Dean_Guss has quit IRC
2332019-01-29T21:01:37 *** Aaronvan_ has joined #bitcoin-core-dev
2342019-01-29T21:03:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2352019-01-29T21:05:03 *** ThomasLuong has quit IRC
2362019-01-29T21:05:27 *** AaronvanW has quit IRC
2372019-01-29T21:08:41 *** promag has joined #bitcoin-core-dev
2382019-01-29T21:13:21 *** promag has quit IRC
2392019-01-29T21:28:45 *** ddustin has joined #bitcoin-core-dev
2402019-01-29T21:34:06 *** promag has joined #bitcoin-core-dev
2412019-01-29T21:40:21 *** Skirmant has joined #bitcoin-core-dev
2422019-01-29T21:58:31 *** Guyver2 has quit IRC
2432019-01-29T22:06:09 *** TheHoliestRoger has quit IRC
2442019-01-29T22:06:17 *** TheHoliestRoger has joined #bitcoin-core-dev
2452019-01-29T22:14:46 *** dviola has joined #bitcoin-core-dev
2462019-01-29T22:14:51 <wumpus> huh I got a transient error "test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation) (code 64)" while running rpc_createmultisig.py locally, once, but cannot reproduce it
2472019-01-29T22:17:10 <wumpus> happened during tx = node0.sendrawtransaction(rawtx3["hex"], True)
2482019-01-29T22:20:56 *** zivl has quit IRC
2492019-01-29T22:29:51 *** hashist has joined #bitcoin-core-dev
2502019-01-29T22:31:11 *** ThomasLuong has joined #bitcoin-core-dev
2512019-01-29T22:35:09 *** ThomasLuong has quit IRC
2522019-01-29T22:36:49 *** Chris_Stewart_5 has quit IRC
2532019-01-29T22:36:58 *** ThomasLuong has joined #bitcoin-core-dev
2542019-01-29T22:39:52 *** kexkey has quit IRC
2552019-01-29T22:50:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2562019-01-29T22:51:13 <jonasschnelli> wumpus: do you get that on current master?
2572019-01-29T22:52:11 <jonasschnelli> test runs successful on my end (master)
2582019-01-29T22:53:20 *** Krellan has joined #bitcoin-core-dev
2592019-01-29T22:53:48 *** bitbee has joined #bitcoin-core-dev
2602019-01-29T22:54:30 *** spinza has quit IRC
2612019-01-29T22:55:40 *** pinheadmz has quit IRC
2622019-01-29T23:05:47 *** StopAndDecrypt has quit IRC
2632019-01-29T23:06:04 *** StopAndDecrypt has joined #bitcoin-core-dev
2642019-01-29T23:06:13 *** StopAndDecrypt has quit IRC
2652019-01-29T23:06:14 *** StopAndDecrypt has joined #bitcoin-core-dev
2662019-01-29T23:07:37 <MarcoFalke> Hmm, looks like the intermittent errors are returning at just in time for the branch-off
2672019-01-29T23:14:14 *** Dean_Guss has joined #bitcoin-core-dev
2682019-01-29T23:15:01 *** miknotauro has joined #bitcoin-core-dev
2692019-01-29T23:27:18 *** pinheadmz has joined #bitcoin-core-dev
2702019-01-29T23:29:58 <promag> MarcoFalke: a bit late imo
2712019-01-29T23:35:15 *** michaelsdunn1 has quit IRC
2722019-01-29T23:43:57 *** Krellan has quit IRC
2732019-01-29T23:44:11 *** Krellan has joined #bitcoin-core-dev