1 2019-02-01T00:02:26  *** DeanGuss has joined #bitcoin-core-dev
  2 2019-02-01T00:03:53  *** ddustin has quit IRC
  3 2019-02-01T00:04:32  *** ddustin has joined #bitcoin-core-dev
  4 2019-02-01T00:08:47  *** ddustin has quit IRC
  5 2019-02-01T00:12:07  *** ChA1NsAw has quit IRC
  6 2019-02-01T00:17:39  *** timothy has quit IRC
  7 2019-02-01T00:19:17  *** justanotheruser has joined #bitcoin-core-dev
  8 2019-02-01T00:21:26  *** justanotheruser has quit IRC
  9 2019-02-01T00:22:58  *** Chris_Stewart_5 has quit IRC
 10 2019-02-01T00:31:56  <aj> jnewbery: yeah, wallet_multiwallet --usecli takes forever for me fwiw
 11 2019-02-01T00:32:13  <aj> jnewbery: like 5x as long as without --usecli
 12 2019-02-01T00:49:09  <sipa> could this be since RNG changes?
 13 2019-02-01T00:50:45  <gmaxwell> considering the rdrand and strenghtening fixes haven't been merged, I'd be surprised.
 14 2019-02-01T00:53:50  <aj> i'd seen it in december, as at cb52cee2 fwiw
 15 2019-02-01T01:01:20  *** ThomasLuong has quit IRC
 16 2019-02-01T01:03:19  *** Skirmant has quit IRC
 17 2019-02-01T01:15:51  *** pinheadmz has quit IRC
 18 2019-02-01T01:29:53  *** DeanGuss has quit IRC
 19 2019-02-01T01:30:21  *** DeanGuss has joined #bitcoin-core-dev
 20 2019-02-01T01:34:42  *** Krellan has quit IRC
 21 2019-02-01T01:34:51  *** Krellan_ has joined #bitcoin-core-dev
 22 2019-02-01T01:38:56  *** owowo has quit IRC
 23 2019-02-01T01:43:01  *** ddustin has joined #bitcoin-core-dev
 24 2019-02-01T01:44:10  *** owowo has joined #bitcoin-core-dev
 25 2019-02-01T02:08:22  *** pinheadmz has joined #bitcoin-core-dev
 26 2019-02-01T02:10:34  *** ddustin has quit IRC
 27 2019-02-01T02:11:10  *** ddustin has joined #bitcoin-core-dev
 28 2019-02-01T02:15:20  *** ddustin has quit IRC
 29 2019-02-01T02:22:00  *** Krellan_ has quit IRC
 30 2019-02-01T02:32:11  *** millerti has quit IRC
 31 2019-02-01T02:37:45  *** murrayn has quit IRC
 32 2019-02-01T02:40:59  *** pinheadmz has quit IRC
 33 2019-02-01T02:45:33  *** pinheadmz has joined #bitcoin-core-dev
 34 2019-02-01T02:56:01  *** pinheadmz has quit IRC
 35 2019-02-01T03:06:28  *** owowo has quit IRC
 36 2019-02-01T03:11:18  *** owowo has joined #bitcoin-core-dev
 37 2019-02-01T03:26:18  *** pinheadmz has joined #bitcoin-core-dev
 38 2019-02-01T03:32:37  *** fanquake has joined #bitcoin-core-dev
 39 2019-02-01T03:36:56  *** pinheadmz has quit IRC
 40 2019-02-01T03:43:08  <fanquake> aj I see the same, created #15309
 41 2019-02-01T03:43:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15309 | tests: Running with --usecli ~5x slower than without · Issue #15309 · bitcoin/bitcoin · GitHub
 42 2019-02-01T04:11:45  *** AaronvanW has quit IRC
 43 2019-02-01T04:13:09  *** ThomasLuong has joined #bitcoin-core-dev
 44 2019-02-01T04:15:01  *** zshlyk has quit IRC
 45 2019-02-01T04:17:20  *** zshlyk has joined #bitcoin-core-dev
 46 2019-02-01T04:18:42  *** ThomasLuong has quit IRC
 47 2019-02-01T04:47:56  *** spinza has quit IRC
 48 2019-02-01T04:51:57  *** spinza has joined #bitcoin-core-dev
 49 2019-02-01T05:05:14  *** justanotheruser has joined #bitcoin-core-dev
 50 2019-02-01T05:26:56  *** midnightmagic has quit IRC
 51 2019-02-01T05:26:56  *** profmac has quit IRC
 52 2019-02-01T05:28:15  *** jarthur_ has joined #bitcoin-core-dev
 53 2019-02-01T05:29:12  *** profmac has joined #bitcoin-core-dev
 54 2019-02-01T05:29:33  *** jarthur_ has quit IRC
 55 2019-02-01T05:30:03  *** jarthur_ has joined #bitcoin-core-dev
 56 2019-02-01T05:31:43  *** jarthur has quit IRC
 57 2019-02-01T05:31:49  *** harrymm has quit IRC
 58 2019-02-01T05:32:09  *** midnightmagic has joined #bitcoin-core-dev
 59 2019-02-01T05:34:42  *** jarthur_ has quit IRC
 60 2019-02-01T06:01:41  *** AaronvanW has joined #bitcoin-core-dev
 61 2019-02-01T06:22:55  *** AaronvanW has quit IRC
 62 2019-02-01T06:35:59  *** andrewbenson has joined #bitcoin-core-dev
 63 2019-02-01T06:41:44  *** leishman has joined #bitcoin-core-dev
 64 2019-02-01T06:44:28  *** leishman has quit IRC
 65 2019-02-01T06:45:44  *** leishman has joined #bitcoin-core-dev
 66 2019-02-01T06:48:36  *** leishman has quit IRC
 67 2019-02-01T06:55:14  *** andrewbenson has quit IRC
 68 2019-02-01T07:02:01  *** pinheadmz has joined #bitcoin-core-dev
 69 2019-02-01T07:05:00  *** fanquake_ has joined #bitcoin-core-dev
 70 2019-02-01T07:07:53  *** fanquake has quit IRC
 71 2019-02-01T07:30:50  *** promag has joined #bitcoin-core-dev
 72 2019-02-01T07:38:21  *** fanquake_ has quit IRC
 73 2019-02-01T07:46:15  *** pinheadmz has quit IRC
 74 2019-02-01T07:53:27  *** hebasto has joined #bitcoin-core-dev
 75 2019-02-01T07:58:26  *** hashistnd has quit IRC
 76 2019-02-01T08:00:38  *** tripleslash has quit IRC
 77 2019-02-01T08:26:12  *** promag has quit IRC
 78 2019-02-01T08:31:07  *** wpaulino has quit IRC
 79 2019-02-01T08:37:05  *** jtimon has quit IRC
 80 2019-02-01T08:38:33  *** bitcoin-git has joined #bitcoin-core-dev
 81 2019-02-01T08:38:34  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
 82 2019-02-01T08:38:40  *** bitcoin-git has left #bitcoin-core-dev
 83 2019-02-01T08:54:53  *** DeanGuss has quit IRC
 84 2019-02-01T08:55:05  *** laurentmt has joined #bitcoin-core-dev
 85 2019-02-01T08:55:27  *** DeanGuss has joined #bitcoin-core-dev
 86 2019-02-01T08:59:06  *** tripleslash has joined #bitcoin-core-dev
 87 2019-02-01T09:01:19  *** hashist has joined #bitcoin-core-dev
 88 2019-02-01T09:02:37  *** laurentmt has quit IRC
 89 2019-02-01T09:28:21  *** mistergold has joined #bitcoin-core-dev
 90 2019-02-01T09:39:28  *** drexl has quit IRC
 91 2019-02-01T10:03:15  *** kexkey has quit IRC
 92 2019-02-01T10:07:12  *** promag has joined #bitcoin-core-dev
 93 2019-02-01T10:08:58  *** setpill has joined #bitcoin-core-dev
 94 2019-02-01T10:11:28  *** spinza has quit IRC
 95 2019-02-01T10:14:42  *** dermoth has quit IRC
 96 2019-02-01T10:15:15  *** dermoth has joined #bitcoin-core-dev
 97 2019-02-01T10:40:35  *** spinza has joined #bitcoin-core-dev
 98 2019-02-01T10:51:27  *** timothy has joined #bitcoin-core-dev
 99 2019-02-01T11:47:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
100 2019-02-01T11:59:00  *** rex4539 has quit IRC
101 2019-02-01T12:00:11  *** promag has quit IRC
102 2019-02-01T12:13:16  *** mistergold has quit IRC
103 2019-02-01T12:14:56  *** Skirmant has joined #bitcoin-core-dev
104 2019-02-01T12:18:08  *** mistergold has joined #bitcoin-core-dev
105 2019-02-01T12:27:42  *** shesek has quit IRC
106 2019-02-01T12:35:44  *** promag has joined #bitcoin-core-dev
107 2019-02-01T12:43:36  *** rex4539 has joined #bitcoin-core-dev
108 2019-02-01T12:49:56  *** Deinogalerix21 has joined #bitcoin-core-dev
109 2019-02-01T12:52:24  *** Chris_Stewart_5 has quit IRC
110 2019-02-01T12:56:33  *** Deinogalerix21 has quit IRC
111 2019-02-01T13:00:15  *** AaronvanW has joined #bitcoin-core-dev
112 2019-02-01T13:02:01  *** bitcoin-git has joined #bitcoin-core-dev
113 2019-02-01T13:02:02  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cb35f1d305d8...3e38d4087379
114 2019-02-01T13:02:02  <bitcoin-git> bitcoin/master 1f77f67 Andrew Chow: tests: unify RPC argument to cli argument conversion and handle dicts and ...
115 2019-02-01T13:02:03  <bitcoin-git> bitcoin/master b5c5021 Andrew Chow: Refactor importwallet to extract data from the file and then import
116 2019-02-01T13:02:04  <bitcoin-git> bitcoin/master e6c58d3 Andrew Chow: Do not import private keys to wallets with private keys disabled
117 2019-02-01T13:02:12  *** bitcoin-git has left #bitcoin-core-dev
118 2019-02-01T13:02:38  *** bitcoin-git has joined #bitcoin-core-dev
119 2019-02-01T13:02:38  <bitcoin-git> [bitcoin] laanwj merged pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
120 2019-02-01T13:02:49  *** bitcoin-git has left #bitcoin-core-dev
121 2019-02-01T13:07:33  *** Soligor has quit IRC
122 2019-02-01T13:09:29  *** promag has quit IRC
123 2019-02-01T13:10:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
124 2019-02-01T13:21:13  *** shesek has joined #bitcoin-core-dev
125 2019-02-01T13:28:15  *** Chris_Stewart_5 has quit IRC
126 2019-02-01T13:31:47  *** shesek has quit IRC
127 2019-02-01T13:32:55  *** shesek has joined #bitcoin-core-dev
128 2019-02-01T13:32:55  *** shesek has joined #bitcoin-core-dev
129 2019-02-01T13:34:25  *** jtimon has joined #bitcoin-core-dev
130 2019-02-01T13:43:58  *** dermoth has quit IRC
131 2019-02-01T13:43:59  *** dermoth_ has joined #bitcoin-core-dev
132 2019-02-01T13:44:16  *** dermoth_ is now known as dermoth
133 2019-02-01T13:50:42  *** shesek has quit IRC
134 2019-02-01T13:59:32  *** jungly has joined #bitcoin-core-dev
135 2019-02-01T14:02:55  *** spinza has quit IRC
136 2019-02-01T14:10:56  *** tryphe has quit IRC
137 2019-02-01T14:12:11  *** bitcoin-git has joined #bitcoin-core-dev
138 2019-02-01T14:12:11  <bitcoin-git> [bitcoin] harding opened pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
139 2019-02-01T14:12:23  *** bitcoin-git has left #bitcoin-core-dev
140 2019-02-01T14:12:53  *** tryphe has joined #bitcoin-core-dev
141 2019-02-01T14:14:14  *** owowo has quit IRC
142 2019-02-01T14:16:48  *** spinza has joined #bitcoin-core-dev
143 2019-02-01T14:19:31  *** jarthur has joined #bitcoin-core-dev
144 2019-02-01T14:20:08  *** bitcoin-git has joined #bitcoin-core-dev
145 2019-02-01T14:20:08  <bitcoin-git> [bitcoin] harding opened pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
146 2019-02-01T14:20:11  *** bitcoin-git has left #bitcoin-core-dev
147 2019-02-01T14:20:25  *** owowo has joined #bitcoin-core-dev
148 2019-02-01T14:20:33  *** promag has joined #bitcoin-core-dev
149 2019-02-01T14:25:03  *** promag_ has joined #bitcoin-core-dev
150 2019-02-01T14:25:56  *** promag has quit IRC
151 2019-02-01T14:27:22  *** andrewbenson has joined #bitcoin-core-dev
152 2019-02-01T14:30:15  *** andrewbenson has quit IRC
153 2019-02-01T14:31:35  <promag_> jnewbery: #15297 could be in https://github.com/bitcoin/bitcoin/projects/2
154 2019-02-01T14:31:36  <gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
155 2019-02-01T14:31:52  *** Guyver2 has joined #bitcoin-core-dev
156 2019-02-01T14:37:51  *** bitcoin-git has joined #bitcoin-core-dev
157 2019-02-01T14:37:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e38d4087379...5c99bb004700
158 2019-02-01T14:37:52  <bitcoin-git> bitcoin/master fa21983 MarcoFalke: qa: Style-only fixes in touched files
159 2019-02-01T14:37:53  <bitcoin-git> bitcoin/master fa5278a MarcoFalke: qa: Use wallet to retrieve raw transactions
160 2019-02-01T14:37:53  <bitcoin-git> bitcoin/master 5c99bb0 MarcoFalke: Merge #15247: qa: Use wallet to retrieve raw transactions
161 2019-02-01T14:37:56  *** bitcoin-git has left #bitcoin-core-dev
162 2019-02-01T14:38:33  *** bitcoin-git has joined #bitcoin-core-dev
163 2019-02-01T14:38:33  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
164 2019-02-01T14:38:34  *** bitcoin-git has left #bitcoin-core-dev
165 2019-02-01T14:40:22  *** promag_ has quit IRC
166 2019-02-01T14:46:05  <dongcarl> Hi all, if anyone can add https://github.com/bitcoin/bitcoin/pull/14856 to the "P2P refactor" board that'd be great. Also, could I get permissions to modify that board?
167 2019-02-01T14:49:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
168 2019-02-01T14:52:20  *** spaced0ut has joined #bitcoin-core-dev
169 2019-02-01T14:57:26  *** cryptapus has quit IRC
170 2019-02-01T15:02:17  *** cryptapus has joined #bitcoin-core-dev
171 2019-02-01T15:02:17  *** cryptapus has quit IRC
172 2019-02-01T15:02:17  *** cryptapus has joined #bitcoin-core-dev
173 2019-02-01T15:12:07  *** arubi has quit IRC
174 2019-02-01T15:12:29  *** arubi has joined #bitcoin-core-dev
175 2019-02-01T15:25:11  <dongcarl> Do people think that future consensus meanings of the witness reserved value will most likely be in the form of a sha256d commitment?
176 2019-02-01T15:36:15  *** pinheadmz has joined #bitcoin-core-dev
177 2019-02-01T15:39:25  *** pinheadmz has quit IRC
178 2019-02-01T15:55:23  *** michaelsdunn1 has joined #bitcoin-core-dev
179 2019-02-01T16:06:39  <rex4539> On master HEAD, I have few tests failing reliably. It's an old, slow machine with 4GB RAM so slowness could definitely be a factor here.
180 2019-02-01T16:06:42  <rex4539> https://paste.fedoraproject.org/paste/rY-48P5ypXZZXBdw03BEeg
181 2019-02-01T16:06:50  *** owowo has quit IRC
182 2019-02-01T16:11:06  *** owowo has joined #bitcoin-core-dev
183 2019-02-01T16:11:45  *** cryptapus has quit IRC
184 2019-02-01T16:21:01  *** cryptapus has joined #bitcoin-core-dev
185 2019-02-01T16:21:01  *** cryptapus has quit IRC
186 2019-02-01T16:21:01  *** cryptapus has joined #bitcoin-core-dev
187 2019-02-01T16:39:50  *** pinheadmz has joined #bitcoin-core-dev
188 2019-02-01T16:40:02  *** rh0nj has quit IRC
189 2019-02-01T16:41:07  *** rh0nj has joined #bitcoin-core-dev
190 2019-02-01T16:54:38  *** mistergold has quit IRC
191 2019-02-01T16:57:12  <provoostenator> I'm trying to build a Descriptor composer. It should allow something like auto desc =  PKHDescriptor(myCPubKey);
192 2019-02-01T16:57:33  *** jarthur has quit IRC
193 2019-02-01T16:57:36  <provoostenator> Not sure what the right approach is, and the abstract class stuff is a bit over my head.
194 2019-02-01T16:57:57  <sipa> provoostenator: oh, i was thinking about that
195 2019-02-01T16:58:06  <sipa> i'll pr it
196 2019-02-01T16:58:34  <provoostenator> The end goal is that I want to generate a descriptor like wpkh([000000/84'/0'/0']xpub.../0/*) without weird string concatenation.
197 2019-02-01T16:58:40  <provoostenator> sipa: awesome that would help!
198 2019-02-01T16:59:31  <provoostenator> Once that works, I would like to introduce descriptor-requests somehow. The same, but with xpub missing. The point of that is to ask a signer to fill in that part.
199 2019-02-01T17:00:45  <provoostenator> With that I can significantly reduce the amount of spaghetti in my hardware wallet integration WIP PR :-)
200 2019-02-01T17:01:14  <provoostenator> I suppose the lazy solution is just an all 0 public key.
201 2019-02-01T17:01:36  *** promag has joined #bitcoin-core-dev
202 2019-02-01T17:06:33  *** promag has quit IRC
203 2019-02-01T17:11:57  <wumpus> rex4539: by default it runs four tests at the same time which is too much for slower systems, certainly with little memory; it might help if you set -j1 on test runner?
204 2019-02-01T17:13:10  <rex4539> Running them individually it's the same failure.
205 2019-02-01T17:17:07  *** darosior has joined #bitcoin-core-dev
206 2019-02-01T17:19:10  <wumpus> definitely looks like a test that takes much longer than expected and hits the timeout
207 2019-02-01T17:22:13  <wumpus> you might be able to make it pass by increasing the timeout value in the source
208 2019-02-01T17:23:41  *** ThomasLuong has joined #bitcoin-core-dev
209 2019-02-01T17:31:09  *** tripleslash has quit IRC
210 2019-02-01T17:36:27  *** ThomasLuong has quit IRC
211 2019-02-01T17:38:05  *** ThomasLuong has joined #bitcoin-core-dev
212 2019-02-01T17:45:23  *** setpill has quit IRC
213 2019-02-01T17:53:08  *** dermoth has quit IRC
214 2019-02-01T17:53:34  *** dermoth has joined #bitcoin-core-dev
215 2019-02-01T17:57:59  *** Murch has joined #bitcoin-core-dev
216 2019-02-01T17:57:59  *** andrewbenson has joined #bitcoin-core-dev
217 2019-02-01T18:03:54  *** Skirmant has quit IRC
218 2019-02-01T18:08:21  *** bitcoin-git has joined #bitcoin-core-dev
219 2019-02-01T18:08:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5c99bb004700...2c0867a1811b
220 2019-02-01T18:08:24  <bitcoin-git> bitcoin/master 1971f5b Ben Woosley: Piecewise construct to avoid invalid construction
221 2019-02-01T18:08:24  <bitcoin-git> bitcoin/master 267eac0 Ben Woosley: Prefer boost::optional#get_value_or over #value_or
222 2019-02-01T18:08:25  <bitcoin-git> bitcoin/master 64f2854 Ben Woosley: Revert "travis: Compile trusty with depends for now"
223 2019-02-01T18:08:28  *** bitcoin-git has left #bitcoin-core-dev
224 2019-02-01T18:09:03  *** bitcoin-git has joined #bitcoin-core-dev
225 2019-02-01T18:09:03  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15308: build: Restore compatibility with older boost (master...trusty-no-depends) https://github.com/bitcoin/bitcoin/pull/15308
226 2019-02-01T18:09:14  *** bitcoin-git has left #bitcoin-core-dev
227 2019-02-01T18:11:16  *** Chris_Stewart_5 has quit IRC
228 2019-02-01T18:11:41  *** jungly has quit IRC
229 2019-02-01T18:14:55  *** Skirmant has joined #bitcoin-core-dev
230 2019-02-01T18:16:36  *** pinheadmz has quit IRC
231 2019-02-01T18:21:03  *** pinheadmz has joined #bitcoin-core-dev
232 2019-02-01T18:21:07  *** bitcoin-git has joined #bitcoin-core-dev
233 2019-02-01T18:21:07  <bitcoin-git> [bitcoin] Sjors opened pull request #15320: [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis (master...019/02/do-not-merge-qt52) https://github.com/bitcoin/bitcoin/pull/15320
234 2019-02-01T18:21:11  *** bitcoin-git has left #bitcoin-core-dev
235 2019-02-01T18:21:31  <provoostenator> (guess I could have done that on my own fork, anyway...)
236 2019-02-01T18:27:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
237 2019-02-01T18:29:44  <MarcoFalke> provoostenator: The issue was closed accidentally because the description in #15308 was not updated to reflect the latest status of the pull
238 2019-02-01T18:29:45  <gribble> https://github.com/bitcoin/bitcoin/issues/15308 | build: Restore compatibility with older boost by Empact · Pull Request #15308 · bitcoin/bitcoin · GitHub
239 2019-02-01T18:31:50  *** andrewbenson has quit IRC
240 2019-02-01T18:41:34  *** jarthur has joined #bitcoin-core-dev
241 2019-02-01T19:42:39  *** DeanGuss has quit IRC
242 2019-02-01T20:06:13  *** bitcoin-git has joined #bitcoin-core-dev
243 2019-02-01T20:06:13  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
244 2019-02-01T20:06:15  *** bitcoin-git has left #bitcoin-core-dev
245 2019-02-01T20:12:54  *** Soligor has joined #bitcoin-core-dev
246 2019-02-01T20:14:01  *** bitcoin-git has joined #bitcoin-core-dev
247 2019-02-01T20:14:01  <bitcoin-git> [bitcoin] practicalswift closed pull request #15111: Avoid UB (member call on nullptr) when failing to read randomness in the startup process (master...random-ub) https://github.com/bitcoin/bitcoin/pull/15111
248 2019-02-01T20:14:04  *** bitcoin-git has left #bitcoin-core-dev
249 2019-02-01T20:26:01  *** pinheadmz has quit IRC
250 2019-02-01T20:28:43  *** Skirmant has quit IRC
251 2019-02-01T20:31:37  *** Murch has quit IRC
252 2019-02-01T20:34:24  *** promag has joined #bitcoin-core-dev
253 2019-02-01T20:39:08  *** andrewbenson has joined #bitcoin-core-dev
254 2019-02-01T20:44:24  *** ThomasLuong has quit IRC
255 2019-02-01T20:48:31  <dongcarl> ryanofsky:
256 2019-02-01T20:48:44  <dongcarl> ryanofsky: Could you see if the wording I just pushed makes sense?
257 2019-02-01T20:49:06  <dongcarl> Or should we explicitly mention that out of the box you can't override datadir?
258 2019-02-01T20:49:25  <dongcarl> talking about #12255 ofc
259 2019-02-01T20:49:27  <gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
260 2019-02-01T20:54:28  <ryanofsky> previous ca07fa88c82 seems better than current 9c8d535211d. new wording is ok but less clear
261 2019-02-01T20:56:16  *** quangthong81 has joined #bitcoin-core-dev
262 2019-02-01T20:58:27  *** Guyver2 has quit IRC
263 2019-02-01T20:59:23  *** quangthong81 has quit IRC
264 2019-02-01T21:08:59  *** pinheadmz has joined #bitcoin-core-dev
265 2019-02-01T21:10:40  *** dermoth has quit IRC
266 2019-02-01T21:11:06  *** dermoth has joined #bitcoin-core-dev
267 2019-02-01T21:12:20  *** ThomasLuong has joined #bitcoin-core-dev
268 2019-02-01T21:14:13  *** bitcoin-git has joined #bitcoin-core-dev
269 2019-02-01T21:14:13  <bitcoin-git> [bitcoin] promag opened pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
270 2019-02-01T21:14:17  *** bitcoin-git has left #bitcoin-core-dev
271 2019-02-01T21:15:05  *** darosior has quit IRC
272 2019-02-01T21:15:19  <dongcarl> ryanofsky: Okay I'll revert then
273 2019-02-01T21:16:23  *** andrewbenson has quit IRC
274 2019-02-01T21:16:48  <promag> http://releases.llvm.org/5.0.2/tools/clang/docs/ThreadSafetyAnalysis.html#no-checking-inside-constructors-and-destructors
275 2019-02-01T21:17:18  <promag> was this mentioned in the past? I wasn't aware :/
276 2019-02-01T21:20:47  <sipa> promag: what are you referring to?
277 2019-02-01T21:21:59  <promag> no thread safety analysis on constructors and destructors
278 2019-02-01T21:24:05  <sipa> yes, i can read
279 2019-02-01T21:24:16  <sipa> i don't know what you want to convey
280 2019-02-01T21:29:48  <promag> see #15322, initially I couldn't understand who held the lock when ~BerkeleyEnvironment, then I realized there was no checking at destructors
281 2019-02-01T21:29:49  <gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
282 2019-02-01T21:29:58  *** Krellan has joined #bitcoin-core-dev
283 2019-02-01T21:30:16  <sipa> ah
284 2019-02-01T21:30:39  <promag> so I wonder if there are more cases like that
285 2019-02-01T21:30:43  <sipa> sorry, i thought you were trying to say we should use something mentioned in that document, and i couldn't figure out what
286 2019-02-01T21:30:55  <promag> no problem
287 2019-02-01T21:31:53  <promag> I think this is tricky because we may be missing some important locks and we think it's all good because annotations "protect" us
288 2019-02-01T21:35:49  <gmaxwell> I hope people aren't relying on those annotations instead of actually reviewing...
289 2019-02-01T21:43:05  *** Skirmant has joined #bitcoin-core-dev
290 2019-02-01T21:59:13  *** sipa has quit IRC
291 2019-02-01T22:00:52  *** sipa has joined #bitcoin-core-dev
292 2019-02-01T22:06:43  *** justanotheruser has quit IRC
293 2019-02-01T22:08:42  *** Soligor has quit IRC
294 2019-02-01T22:12:17  *** Soligor has joined #bitcoin-core-dev
295 2019-02-01T22:14:58  *** bitcoin-git has joined #bitcoin-core-dev
296 2019-02-01T22:14:58  <bitcoin-git> [bitcoin] Empact opened pull request #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo (master...load-mempool-race) https://github.com/bitcoin/bitcoin/pull/15323
297 2019-02-01T22:15:09  *** bitcoin-git has left #bitcoin-core-dev
298 2019-02-01T22:17:21  *** bitcoin-git has joined #bitcoin-core-dev
299 2019-02-01T22:17:21  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
300 2019-02-01T22:17:26  *** bitcoin-git has left #bitcoin-core-dev
301 2019-02-01T22:21:17  *** Murch has joined #bitcoin-core-dev
302 2019-02-01T22:25:46  *** bitcoin-git has joined #bitcoin-core-dev
303 2019-02-01T22:25:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2c0867a1811b...b3a715301a0f
304 2019-02-01T22:25:47  <bitcoin-git> bitcoin/master faee6c9 MarcoFalke: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
305 2019-02-01T22:25:48  <bitcoin-git> bitcoin/master facaae4 MarcoFalke: travis: Save cache when compilation took very long
306 2019-02-01T22:25:48  <bitcoin-git> bitcoin/master b3a7153 MarcoFalke: Merge #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
307 2019-02-01T22:25:54  *** bitcoin-git has left #bitcoin-core-dev
308 2019-02-01T22:26:26  *** bitcoin-git has joined #bitcoin-core-dev
309 2019-02-01T22:26:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG (master...Mf1901-travisFun) https://github.com/bitcoin/bitcoin/pull/15303
310 2019-02-01T22:26:27  *** bitcoin-git has left #bitcoin-core-dev
311 2019-02-01T22:28:51  *** drexl has joined #bitcoin-core-dev
312 2019-02-01T22:30:46  *** andrewbenson has joined #bitcoin-core-dev
313 2019-02-01T22:31:39  *** spinza has quit IRC
314 2019-02-01T22:52:27  *** spinza has joined #bitcoin-core-dev
315 2019-02-01T22:58:07  *** AaronvanW has quit IRC
316 2019-02-01T23:12:56  *** Chris_Stewart_5 has quit IRC
317 2019-02-01T23:15:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
318 2019-02-01T23:19:23  *** michaelsdunn1 has quit IRC
319 2019-02-01T23:24:34  *** Chris_Stewart_5 has quit IRC
320 2019-02-01T23:34:26  *** jarthur has quit IRC
321 2019-02-01T23:55:45  *** DougieBot5000_ has joined #bitcoin-core-dev
322 2019-02-01T23:58:15  *** DougieBot5000 has quit IRC