12019-02-01T00:02:26  *** DeanGuss has joined #bitcoin-core-dev
  22019-02-01T00:03:53  *** ddustin has quit IRC
  32019-02-01T00:04:32  *** ddustin has joined #bitcoin-core-dev
  42019-02-01T00:08:47  *** ddustin has quit IRC
  52019-02-01T00:12:07  *** ChA1NsAw has quit IRC
  62019-02-01T00:17:39  *** timothy has quit IRC
  72019-02-01T00:19:17  *** justanotheruser has joined #bitcoin-core-dev
  82019-02-01T00:21:26  *** justanotheruser has quit IRC
  92019-02-01T00:22:58  *** Chris_Stewart_5 has quit IRC
 102019-02-01T00:31:56  <aj> jnewbery: yeah, wallet_multiwallet --usecli takes forever for me fwiw
 112019-02-01T00:32:13  <aj> jnewbery: like 5x as long as without --usecli
 122019-02-01T00:49:09  <sipa> could this be since RNG changes?
 132019-02-01T00:50:45  <gmaxwell> considering the rdrand and strenghtening fixes haven't been merged, I'd be surprised.
 142019-02-01T00:53:50  <aj> i'd seen it in december, as at cb52cee2 fwiw
 152019-02-01T01:01:20  *** ThomasLuong has quit IRC
 162019-02-01T01:03:19  *** Skirmant has quit IRC
 172019-02-01T01:15:51  *** pinheadmz has quit IRC
 182019-02-01T01:29:53  *** DeanGuss has quit IRC
 192019-02-01T01:30:21  *** DeanGuss has joined #bitcoin-core-dev
 202019-02-01T01:34:42  *** Krellan has quit IRC
 212019-02-01T01:34:51  *** Krellan_ has joined #bitcoin-core-dev
 222019-02-01T01:38:56  *** owowo has quit IRC
 232019-02-01T01:43:01  *** ddustin has joined #bitcoin-core-dev
 242019-02-01T01:44:10  *** owowo has joined #bitcoin-core-dev
 252019-02-01T02:08:22  *** pinheadmz has joined #bitcoin-core-dev
 262019-02-01T02:10:34  *** ddustin has quit IRC
 272019-02-01T02:11:10  *** ddustin has joined #bitcoin-core-dev
 282019-02-01T02:15:20  *** ddustin has quit IRC
 292019-02-01T02:22:00  *** Krellan_ has quit IRC
 302019-02-01T02:32:11  *** millerti has quit IRC
 312019-02-01T02:37:45  *** murrayn has quit IRC
 322019-02-01T02:40:59  *** pinheadmz has quit IRC
 332019-02-01T02:45:33  *** pinheadmz has joined #bitcoin-core-dev
 342019-02-01T02:56:01  *** pinheadmz has quit IRC
 352019-02-01T03:06:28  *** owowo has quit IRC
 362019-02-01T03:11:18  *** owowo has joined #bitcoin-core-dev
 372019-02-01T03:26:18  *** pinheadmz has joined #bitcoin-core-dev
 382019-02-01T03:32:37  *** fanquake has joined #bitcoin-core-dev
 392019-02-01T03:36:56  *** pinheadmz has quit IRC
 402019-02-01T03:43:08  <fanquake> aj I see the same, created #15309
 412019-02-01T03:43:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15309 | tests: Running with --usecli ~5x slower than without · Issue #15309 · bitcoin/bitcoin · GitHub
 422019-02-01T04:11:45  *** AaronvanW has quit IRC
 432019-02-01T04:13:09  *** ThomasLuong has joined #bitcoin-core-dev
 442019-02-01T04:15:01  *** zshlyk has quit IRC
 452019-02-01T04:17:20  *** zshlyk has joined #bitcoin-core-dev
 462019-02-01T04:18:42  *** ThomasLuong has quit IRC
 472019-02-01T04:47:56  *** spinza has quit IRC
 482019-02-01T04:51:57  *** spinza has joined #bitcoin-core-dev
 492019-02-01T05:05:14  *** justanotheruser has joined #bitcoin-core-dev
 502019-02-01T05:26:56  *** midnightmagic has quit IRC
 512019-02-01T05:26:56  *** profmac has quit IRC
 522019-02-01T05:28:15  *** jarthur_ has joined #bitcoin-core-dev
 532019-02-01T05:29:12  *** profmac has joined #bitcoin-core-dev
 542019-02-01T05:29:33  *** jarthur_ has quit IRC
 552019-02-01T05:30:03  *** jarthur_ has joined #bitcoin-core-dev
 562019-02-01T05:31:43  *** jarthur has quit IRC
 572019-02-01T05:31:49  *** harrymm has quit IRC
 582019-02-01T05:32:09  *** midnightmagic has joined #bitcoin-core-dev
 592019-02-01T05:34:42  *** jarthur_ has quit IRC
 602019-02-01T06:01:41  *** AaronvanW has joined #bitcoin-core-dev
 612019-02-01T06:22:55  *** AaronvanW has quit IRC
 622019-02-01T06:35:59  *** andrewbenson has joined #bitcoin-core-dev
 632019-02-01T06:41:44  *** leishman has joined #bitcoin-core-dev
 642019-02-01T06:44:28  *** leishman has quit IRC
 652019-02-01T06:45:44  *** leishman has joined #bitcoin-core-dev
 662019-02-01T06:48:36  *** leishman has quit IRC
 672019-02-01T06:55:14  *** andrewbenson has quit IRC
 682019-02-01T07:02:01  *** pinheadmz has joined #bitcoin-core-dev
 692019-02-01T07:05:00  *** fanquake_ has joined #bitcoin-core-dev
 702019-02-01T07:07:53  *** fanquake has quit IRC
 712019-02-01T07:30:50  *** promag has joined #bitcoin-core-dev
 722019-02-01T07:38:21  *** fanquake_ has quit IRC
 732019-02-01T07:46:15  *** pinheadmz has quit IRC
 742019-02-01T07:53:27  *** hebasto has joined #bitcoin-core-dev
 752019-02-01T07:58:26  *** hashistnd has quit IRC
 762019-02-01T08:00:38  *** tripleslash has quit IRC
 772019-02-01T08:26:12  *** promag has quit IRC
 782019-02-01T08:31:07  *** wpaulino has quit IRC
 792019-02-01T08:37:05  *** jtimon has quit IRC
 802019-02-01T08:38:33  *** bitcoin-git has joined #bitcoin-core-dev
 812019-02-01T08:38:34  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
 822019-02-01T08:38:40  *** bitcoin-git has left #bitcoin-core-dev
 832019-02-01T08:54:53  *** DeanGuss has quit IRC
 842019-02-01T08:55:05  *** laurentmt has joined #bitcoin-core-dev
 852019-02-01T08:55:27  *** DeanGuss has joined #bitcoin-core-dev
 862019-02-01T08:59:06  *** tripleslash has joined #bitcoin-core-dev
 872019-02-01T09:01:19  *** hashist has joined #bitcoin-core-dev
 882019-02-01T09:02:37  *** laurentmt has quit IRC
 892019-02-01T09:28:21  *** mistergold has joined #bitcoin-core-dev
 902019-02-01T09:39:28  *** drexl has quit IRC
 912019-02-01T10:03:15  *** kexkey has quit IRC
 922019-02-01T10:07:12  *** promag has joined #bitcoin-core-dev
 932019-02-01T10:08:58  *** setpill has joined #bitcoin-core-dev
 942019-02-01T10:11:28  *** spinza has quit IRC
 952019-02-01T10:14:42  *** dermoth has quit IRC
 962019-02-01T10:15:15  *** dermoth has joined #bitcoin-core-dev
 972019-02-01T10:40:35  *** spinza has joined #bitcoin-core-dev
 982019-02-01T10:51:27  *** timothy has joined #bitcoin-core-dev
 992019-02-01T11:47:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1002019-02-01T11:59:00  *** rex4539 has quit IRC
1012019-02-01T12:00:11  *** promag has quit IRC
1022019-02-01T12:13:16  *** mistergold has quit IRC
1032019-02-01T12:14:56  *** Skirmant has joined #bitcoin-core-dev
1042019-02-01T12:18:08  *** mistergold has joined #bitcoin-core-dev
1052019-02-01T12:27:42  *** shesek has quit IRC
1062019-02-01T12:35:44  *** promag has joined #bitcoin-core-dev
1072019-02-01T12:43:36  *** rex4539 has joined #bitcoin-core-dev
1082019-02-01T12:49:56  *** Deinogalerix21 has joined #bitcoin-core-dev
1092019-02-01T12:52:24  *** Chris_Stewart_5 has quit IRC
1102019-02-01T12:56:33  *** Deinogalerix21 has quit IRC
1112019-02-01T13:00:15  *** AaronvanW has joined #bitcoin-core-dev
1122019-02-01T13:02:01  *** bitcoin-git has joined #bitcoin-core-dev
1132019-02-01T13:02:02  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cb35f1d305d8...3e38d4087379
1142019-02-01T13:02:02  <bitcoin-git> bitcoin/master 1f77f67 Andrew Chow: tests: unify RPC argument to cli argument conversion and handle dicts and ...
1152019-02-01T13:02:03  <bitcoin-git> bitcoin/master b5c5021 Andrew Chow: Refactor importwallet to extract data from the file and then import
1162019-02-01T13:02:04  <bitcoin-git> bitcoin/master e6c58d3 Andrew Chow: Do not import private keys to wallets with private keys disabled
1172019-02-01T13:02:12  *** bitcoin-git has left #bitcoin-core-dev
1182019-02-01T13:02:38  *** bitcoin-git has joined #bitcoin-core-dev
1192019-02-01T13:02:38  <bitcoin-git> [bitcoin] laanwj merged pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
1202019-02-01T13:02:49  *** bitcoin-git has left #bitcoin-core-dev
1212019-02-01T13:07:33  *** Soligor has quit IRC
1222019-02-01T13:09:29  *** promag has quit IRC
1232019-02-01T13:10:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1242019-02-01T13:21:13  *** shesek has joined #bitcoin-core-dev
1252019-02-01T13:28:15  *** Chris_Stewart_5 has quit IRC
1262019-02-01T13:31:47  *** shesek has quit IRC
1272019-02-01T13:32:55  *** shesek has joined #bitcoin-core-dev
1282019-02-01T13:32:55  *** shesek has joined #bitcoin-core-dev
1292019-02-01T13:34:25  *** jtimon has joined #bitcoin-core-dev
1302019-02-01T13:43:58  *** dermoth has quit IRC
1312019-02-01T13:43:59  *** dermoth_ has joined #bitcoin-core-dev
1322019-02-01T13:44:16  *** dermoth_ is now known as dermoth
1332019-02-01T13:50:42  *** shesek has quit IRC
1342019-02-01T13:59:32  *** jungly has joined #bitcoin-core-dev
1352019-02-01T14:02:55  *** spinza has quit IRC
1362019-02-01T14:10:56  *** tryphe has quit IRC
1372019-02-01T14:12:11  *** bitcoin-git has joined #bitcoin-core-dev
1382019-02-01T14:12:11  <bitcoin-git> [bitcoin] harding opened pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
1392019-02-01T14:12:23  *** bitcoin-git has left #bitcoin-core-dev
1402019-02-01T14:12:53  *** tryphe has joined #bitcoin-core-dev
1412019-02-01T14:14:14  *** owowo has quit IRC
1422019-02-01T14:16:48  *** spinza has joined #bitcoin-core-dev
1432019-02-01T14:19:31  *** jarthur has joined #bitcoin-core-dev
1442019-02-01T14:20:08  *** bitcoin-git has joined #bitcoin-core-dev
1452019-02-01T14:20:08  <bitcoin-git> [bitcoin] harding opened pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
1462019-02-01T14:20:11  *** bitcoin-git has left #bitcoin-core-dev
1472019-02-01T14:20:25  *** owowo has joined #bitcoin-core-dev
1482019-02-01T14:20:33  *** promag has joined #bitcoin-core-dev
1492019-02-01T14:25:03  *** promag_ has joined #bitcoin-core-dev
1502019-02-01T14:25:56  *** promag has quit IRC
1512019-02-01T14:27:22  *** andrewbenson has joined #bitcoin-core-dev
1522019-02-01T14:30:15  *** andrewbenson has quit IRC
1532019-02-01T14:31:35  <promag_> jnewbery: #15297 could be in https://github.com/bitcoin/bitcoin/projects/2
1542019-02-01T14:31:36  <gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
1552019-02-01T14:31:52  *** Guyver2 has joined #bitcoin-core-dev
1562019-02-01T14:37:51  *** bitcoin-git has joined #bitcoin-core-dev
1572019-02-01T14:37:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e38d4087379...5c99bb004700
1582019-02-01T14:37:52  <bitcoin-git> bitcoin/master fa21983 MarcoFalke: qa: Style-only fixes in touched files
1592019-02-01T14:37:53  <bitcoin-git> bitcoin/master fa5278a MarcoFalke: qa: Use wallet to retrieve raw transactions
1602019-02-01T14:37:53  <bitcoin-git> bitcoin/master 5c99bb0 MarcoFalke: Merge #15247: qa: Use wallet to retrieve raw transactions
1612019-02-01T14:37:56  *** bitcoin-git has left #bitcoin-core-dev
1622019-02-01T14:38:33  *** bitcoin-git has joined #bitcoin-core-dev
1632019-02-01T14:38:33  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
1642019-02-01T14:38:34  *** bitcoin-git has left #bitcoin-core-dev
1652019-02-01T14:40:22  *** promag_ has quit IRC
1662019-02-01T14:46:05  <dongcarl> Hi all, if anyone can add https://github.com/bitcoin/bitcoin/pull/14856 to the "P2P refactor" board that'd be great. Also, could I get permissions to modify that board?
1672019-02-01T14:49:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1682019-02-01T14:52:20  *** spaced0ut has joined #bitcoin-core-dev
1692019-02-01T14:57:26  *** cryptapus has quit IRC
1702019-02-01T15:02:17  *** cryptapus has joined #bitcoin-core-dev
1712019-02-01T15:02:17  *** cryptapus has quit IRC
1722019-02-01T15:02:17  *** cryptapus has joined #bitcoin-core-dev
1732019-02-01T15:12:07  *** arubi has quit IRC
1742019-02-01T15:12:29  *** arubi has joined #bitcoin-core-dev
1752019-02-01T15:25:11  <dongcarl> Do people think that future consensus meanings of the witness reserved value will most likely be in the form of a sha256d commitment?
1762019-02-01T15:36:15  *** pinheadmz has joined #bitcoin-core-dev
1772019-02-01T15:39:25  *** pinheadmz has quit IRC
1782019-02-01T15:55:23  *** michaelsdunn1 has joined #bitcoin-core-dev
1792019-02-01T16:06:39  <rex4539> On master HEAD, I have few tests failing reliably. It's an old, slow machine with 4GB RAM so slowness could definitely be a factor here.
1802019-02-01T16:06:42  <rex4539> https://paste.fedoraproject.org/paste/rY-48P5ypXZZXBdw03BEeg
1812019-02-01T16:06:50  *** owowo has quit IRC
1822019-02-01T16:11:06  *** owowo has joined #bitcoin-core-dev
1832019-02-01T16:11:45  *** cryptapus has quit IRC
1842019-02-01T16:21:01  *** cryptapus has joined #bitcoin-core-dev
1852019-02-01T16:21:01  *** cryptapus has quit IRC
1862019-02-01T16:21:01  *** cryptapus has joined #bitcoin-core-dev
1872019-02-01T16:39:50  *** pinheadmz has joined #bitcoin-core-dev
1882019-02-01T16:40:02  *** rh0nj has quit IRC
1892019-02-01T16:41:07  *** rh0nj has joined #bitcoin-core-dev
1902019-02-01T16:54:38  *** mistergold has quit IRC
1912019-02-01T16:57:12  <provoostenator> I'm trying to build a Descriptor composer. It should allow something like auto desc =  PKHDescriptor(myCPubKey);
1922019-02-01T16:57:33  *** jarthur has quit IRC
1932019-02-01T16:57:36  <provoostenator> Not sure what the right approach is, and the abstract class stuff is a bit over my head.
1942019-02-01T16:57:57  <sipa> provoostenator: oh, i was thinking about that
1952019-02-01T16:58:06  <sipa> i'll pr it
1962019-02-01T16:58:34  <provoostenator> The end goal is that I want to generate a descriptor like wpkh([000000/84'/0'/0']xpub.../0/*) without weird string concatenation.
1972019-02-01T16:58:40  <provoostenator> sipa: awesome that would help!
1982019-02-01T16:59:31  <provoostenator> Once that works, I would like to introduce descriptor-requests somehow. The same, but with xpub missing. The point of that is to ask a signer to fill in that part.
1992019-02-01T17:00:45  <provoostenator> With that I can significantly reduce the amount of spaghetti in my hardware wallet integration WIP PR :-)
2002019-02-01T17:01:14  <provoostenator> I suppose the lazy solution is just an all 0 public key.
2012019-02-01T17:01:36  *** promag has joined #bitcoin-core-dev
2022019-02-01T17:06:33  *** promag has quit IRC
2032019-02-01T17:11:57  <wumpus> rex4539: by default it runs four tests at the same time which is too much for slower systems, certainly with little memory; it might help if you set -j1 on test runner?
2042019-02-01T17:13:10  <rex4539> Running them individually it's the same failure.
2052019-02-01T17:17:07  *** darosior has joined #bitcoin-core-dev
2062019-02-01T17:19:10  <wumpus> definitely looks like a test that takes much longer than expected and hits the timeout
2072019-02-01T17:22:13  <wumpus> you might be able to make it pass by increasing the timeout value in the source
2082019-02-01T17:23:41  *** ThomasLuong has joined #bitcoin-core-dev
2092019-02-01T17:31:09  *** tripleslash has quit IRC
2102019-02-01T17:36:27  *** ThomasLuong has quit IRC
2112019-02-01T17:38:05  *** ThomasLuong has joined #bitcoin-core-dev
2122019-02-01T17:45:23  *** setpill has quit IRC
2132019-02-01T17:53:08  *** dermoth has quit IRC
2142019-02-01T17:53:34  *** dermoth has joined #bitcoin-core-dev
2152019-02-01T17:57:59  *** Murch has joined #bitcoin-core-dev
2162019-02-01T17:57:59  *** andrewbenson has joined #bitcoin-core-dev
2172019-02-01T18:03:54  *** Skirmant has quit IRC
2182019-02-01T18:08:21  *** bitcoin-git has joined #bitcoin-core-dev
2192019-02-01T18:08:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5c99bb004700...2c0867a1811b
2202019-02-01T18:08:24  <bitcoin-git> bitcoin/master 1971f5b Ben Woosley: Piecewise construct to avoid invalid construction
2212019-02-01T18:08:24  <bitcoin-git> bitcoin/master 267eac0 Ben Woosley: Prefer boost::optional#get_value_or over #value_or
2222019-02-01T18:08:25  <bitcoin-git> bitcoin/master 64f2854 Ben Woosley: Revert "travis: Compile trusty with depends for now"
2232019-02-01T18:08:28  *** bitcoin-git has left #bitcoin-core-dev
2242019-02-01T18:09:03  *** bitcoin-git has joined #bitcoin-core-dev
2252019-02-01T18:09:03  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15308: build: Restore compatibility with older boost (master...trusty-no-depends) https://github.com/bitcoin/bitcoin/pull/15308
2262019-02-01T18:09:14  *** bitcoin-git has left #bitcoin-core-dev
2272019-02-01T18:11:16  *** Chris_Stewart_5 has quit IRC
2282019-02-01T18:11:41  *** jungly has quit IRC
2292019-02-01T18:14:55  *** Skirmant has joined #bitcoin-core-dev
2302019-02-01T18:16:36  *** pinheadmz has quit IRC
2312019-02-01T18:21:03  *** pinheadmz has joined #bitcoin-core-dev
2322019-02-01T18:21:07  *** bitcoin-git has joined #bitcoin-core-dev
2332019-02-01T18:21:07  <bitcoin-git> [bitcoin] Sjors opened pull request #15320: [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis (master...019/02/do-not-merge-qt52) https://github.com/bitcoin/bitcoin/pull/15320
2342019-02-01T18:21:11  *** bitcoin-git has left #bitcoin-core-dev
2352019-02-01T18:21:31  <provoostenator> (guess I could have done that on my own fork, anyway...)
2362019-02-01T18:27:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2372019-02-01T18:29:44  <MarcoFalke> provoostenator: The issue was closed accidentally because the description in #15308 was not updated to reflect the latest status of the pull
2382019-02-01T18:29:45  <gribble> https://github.com/bitcoin/bitcoin/issues/15308 | build: Restore compatibility with older boost by Empact · Pull Request #15308 · bitcoin/bitcoin · GitHub
2392019-02-01T18:31:50  *** andrewbenson has quit IRC
2402019-02-01T18:41:34  *** jarthur has joined #bitcoin-core-dev
2412019-02-01T19:42:39  *** DeanGuss has quit IRC
2422019-02-01T20:06:13  *** bitcoin-git has joined #bitcoin-core-dev
2432019-02-01T20:06:13  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
2442019-02-01T20:06:15  *** bitcoin-git has left #bitcoin-core-dev
2452019-02-01T20:12:54  *** Soligor has joined #bitcoin-core-dev
2462019-02-01T20:14:01  *** bitcoin-git has joined #bitcoin-core-dev
2472019-02-01T20:14:01  <bitcoin-git> [bitcoin] practicalswift closed pull request #15111: Avoid UB (member call on nullptr) when failing to read randomness in the startup process (master...random-ub) https://github.com/bitcoin/bitcoin/pull/15111
2482019-02-01T20:14:04  *** bitcoin-git has left #bitcoin-core-dev
2492019-02-01T20:26:01  *** pinheadmz has quit IRC
2502019-02-01T20:28:43  *** Skirmant has quit IRC
2512019-02-01T20:31:37  *** Murch has quit IRC
2522019-02-01T20:34:24  *** promag has joined #bitcoin-core-dev
2532019-02-01T20:39:08  *** andrewbenson has joined #bitcoin-core-dev
2542019-02-01T20:44:24  *** ThomasLuong has quit IRC
2552019-02-01T20:48:31  <dongcarl> ryanofsky:
2562019-02-01T20:48:44  <dongcarl> ryanofsky: Could you see if the wording I just pushed makes sense?
2572019-02-01T20:49:06  <dongcarl> Or should we explicitly mention that out of the box you can't override datadir?
2582019-02-01T20:49:25  <dongcarl> talking about #12255 ofc
2592019-02-01T20:49:27  <gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
2602019-02-01T20:54:28  <ryanofsky> previous ca07fa88c82 seems better than current 9c8d535211d. new wording is ok but less clear
2612019-02-01T20:56:16  *** quangthong81 has joined #bitcoin-core-dev
2622019-02-01T20:58:27  *** Guyver2 has quit IRC
2632019-02-01T20:59:23  *** quangthong81 has quit IRC
2642019-02-01T21:08:59  *** pinheadmz has joined #bitcoin-core-dev
2652019-02-01T21:10:40  *** dermoth has quit IRC
2662019-02-01T21:11:06  *** dermoth has joined #bitcoin-core-dev
2672019-02-01T21:12:20  *** ThomasLuong has joined #bitcoin-core-dev
2682019-02-01T21:14:13  *** bitcoin-git has joined #bitcoin-core-dev
2692019-02-01T21:14:13  <bitcoin-git> [bitcoin] promag opened pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
2702019-02-01T21:14:17  *** bitcoin-git has left #bitcoin-core-dev
2712019-02-01T21:15:05  *** darosior has quit IRC
2722019-02-01T21:15:19  <dongcarl> ryanofsky: Okay I'll revert then
2732019-02-01T21:16:23  *** andrewbenson has quit IRC
2742019-02-01T21:16:48  <promag> http://releases.llvm.org/5.0.2/tools/clang/docs/ThreadSafetyAnalysis.html#no-checking-inside-constructors-and-destructors
2752019-02-01T21:17:18  <promag> was this mentioned in the past? I wasn't aware :/
2762019-02-01T21:20:47  <sipa> promag: what are you referring to?
2772019-02-01T21:21:59  <promag> no thread safety analysis on constructors and destructors
2782019-02-01T21:24:05  <sipa> yes, i can read
2792019-02-01T21:24:16  <sipa> i don't know what you want to convey
2802019-02-01T21:29:48  <promag> see #15322, initially I couldn't understand who held the lock when ~BerkeleyEnvironment, then I realized there was no checking at destructors
2812019-02-01T21:29:49  <gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
2822019-02-01T21:29:58  *** Krellan has joined #bitcoin-core-dev
2832019-02-01T21:30:16  <sipa> ah
2842019-02-01T21:30:39  <promag> so I wonder if there are more cases like that
2852019-02-01T21:30:43  <sipa> sorry, i thought you were trying to say we should use something mentioned in that document, and i couldn't figure out what
2862019-02-01T21:30:55  <promag> no problem
2872019-02-01T21:31:53  <promag> I think this is tricky because we may be missing some important locks and we think it's all good because annotations "protect" us
2882019-02-01T21:35:49  <gmaxwell> I hope people aren't relying on those annotations instead of actually reviewing...
2892019-02-01T21:43:05  *** Skirmant has joined #bitcoin-core-dev
2902019-02-01T21:59:13  *** sipa has quit IRC
2912019-02-01T22:00:52  *** sipa has joined #bitcoin-core-dev
2922019-02-01T22:06:43  *** justanotheruser has quit IRC
2932019-02-01T22:08:42  *** Soligor has quit IRC
2942019-02-01T22:12:17  *** Soligor has joined #bitcoin-core-dev
2952019-02-01T22:14:58  *** bitcoin-git has joined #bitcoin-core-dev
2962019-02-01T22:14:58  <bitcoin-git> [bitcoin] Empact opened pull request #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo (master...load-mempool-race) https://github.com/bitcoin/bitcoin/pull/15323
2972019-02-01T22:15:09  *** bitcoin-git has left #bitcoin-core-dev
2982019-02-01T22:17:21  *** bitcoin-git has joined #bitcoin-core-dev
2992019-02-01T22:17:21  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
3002019-02-01T22:17:26  *** bitcoin-git has left #bitcoin-core-dev
3012019-02-01T22:21:17  *** Murch has joined #bitcoin-core-dev
3022019-02-01T22:25:46  *** bitcoin-git has joined #bitcoin-core-dev
3032019-02-01T22:25:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2c0867a1811b...b3a715301a0f
3042019-02-01T22:25:47  <bitcoin-git> bitcoin/master faee6c9 MarcoFalke: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
3052019-02-01T22:25:48  <bitcoin-git> bitcoin/master facaae4 MarcoFalke: travis: Save cache when compilation took very long
3062019-02-01T22:25:48  <bitcoin-git> bitcoin/master b3a7153 MarcoFalke: Merge #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
3072019-02-01T22:25:54  *** bitcoin-git has left #bitcoin-core-dev
3082019-02-01T22:26:26  *** bitcoin-git has joined #bitcoin-core-dev
3092019-02-01T22:26:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG (master...Mf1901-travisFun) https://github.com/bitcoin/bitcoin/pull/15303
3102019-02-01T22:26:27  *** bitcoin-git has left #bitcoin-core-dev
3112019-02-01T22:28:51  *** drexl has joined #bitcoin-core-dev
3122019-02-01T22:30:46  *** andrewbenson has joined #bitcoin-core-dev
3132019-02-01T22:31:39  *** spinza has quit IRC
3142019-02-01T22:52:27  *** spinza has joined #bitcoin-core-dev
3152019-02-01T22:58:07  *** AaronvanW has quit IRC
3162019-02-01T23:12:56  *** Chris_Stewart_5 has quit IRC
3172019-02-01T23:15:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3182019-02-01T23:19:23  *** michaelsdunn1 has quit IRC
3192019-02-01T23:24:34  *** Chris_Stewart_5 has quit IRC
3202019-02-01T23:34:26  *** jarthur has quit IRC
3212019-02-01T23:55:45  *** DougieBot5000_ has joined #bitcoin-core-dev
3222019-02-01T23:58:15  *** DougieBot5000 has quit IRC