12019-02-02T00:05:21  *** Krellan has quit IRC
  22019-02-02T00:08:20  *** DeanGuss has joined #bitcoin-core-dev
  32019-02-02T00:16:29  *** irc_viewer_test has joined #bitcoin-core-dev
  42019-02-02T00:18:32  *** andrewbenson has quit IRC
  52019-02-02T00:23:09  *** ghost43 has quit IRC
  62019-02-02T00:28:01  *** ghost43 has joined #bitcoin-core-dev
  72019-02-02T00:31:43  *** timothy has quit IRC
  82019-02-02T00:33:41  *** Krellan has joined #bitcoin-core-dev
  92019-02-02T00:34:02  *** irc_viewer_test has quit IRC
 102019-02-02T00:36:01  *** copumpkin has quit IRC
 112019-02-02T00:37:10  *** mistergold has joined #bitcoin-core-dev
 122019-02-02T00:52:21  *** ThomasLuong has quit IRC
 132019-02-02T00:54:19  *** DeanGuss has quit IRC
 142019-02-02T01:11:30  *** Murch has quit IRC
 152019-02-02T01:21:39  *** pinheadmz has quit IRC
 162019-02-02T01:31:33  *** IGHOR has quit IRC
 172019-02-02T01:34:33  *** IGHOR has joined #bitcoin-core-dev
 182019-02-02T01:35:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 192019-02-02T01:36:44  *** StopAndDecrypt has quit IRC
 202019-02-02T01:53:44  *** rh0nj has quit IRC
 212019-02-02T01:54:07  *** rh0nj has joined #bitcoin-core-dev
 222019-02-02T01:55:53  *** Chris_Stewart_5 has quit IRC
 232019-02-02T01:57:40  *** rh0nj has quit IRC
 242019-02-02T02:01:07  *** rh0nj has joined #bitcoin-core-dev
 252019-02-02T02:04:38  *** hebasto has quit IRC
 262019-02-02T02:23:32  *** promag has quit IRC
 272019-02-02T02:26:07  *** pinheadmz has joined #bitcoin-core-dev
 282019-02-02T02:48:36  *** Krellan has quit IRC
 292019-02-02T03:10:55  *** drexl has quit IRC
 302019-02-02T03:39:39  *** pinheadmz has quit IRC
 312019-02-02T03:51:43  *** Skirmant has quit IRC
 322019-02-02T04:04:02  *** pinheadmz has joined #bitcoin-core-dev
 332019-02-02T04:35:03  *** pinheadmz has quit IRC
 342019-02-02T04:52:24  *** pinheadmz has joined #bitcoin-core-dev
 352019-02-02T05:07:30  *** pinheadmz has quit IRC
 362019-02-02T05:11:49  *** justanotheruser has joined #bitcoin-core-dev
 372019-02-02T05:19:14  *** pinheadmz has joined #bitcoin-core-dev
 382019-02-02T05:20:40  *** pinheadmz has quit IRC
 392019-02-02T05:21:17  *** pinheadmz has joined #bitcoin-core-dev
 402019-02-02T05:37:56  *** profmac has quit IRC
 412019-02-02T05:39:40  *** midnightmagic has quit IRC
 422019-02-02T05:43:49  *** profmac has joined #bitcoin-core-dev
 432019-02-02T05:46:42  *** midnightmagic has joined #bitcoin-core-dev
 442019-02-02T05:52:13  *** jtimon has quit IRC
 452019-02-02T05:55:47  *** pinheadmz has quit IRC
 462019-02-02T05:58:36  *** Krellan has joined #bitcoin-core-dev
 472019-02-02T05:59:15  *** pinheadmz has joined #bitcoin-core-dev
 482019-02-02T06:00:26  *** pinheadmz has quit IRC
 492019-02-02T06:01:34  *** murrayn has joined #bitcoin-core-dev
 502019-02-02T06:03:28  *** Krellan has quit IRC
 512019-02-02T06:25:27  *** Krellan has joined #bitcoin-core-dev
 522019-02-02T06:33:19  *** pinheadmz has joined #bitcoin-core-dev
 532019-02-02T06:34:26  *** midnightmagic has quit IRC
 542019-02-02T06:34:26  *** profmac has quit IRC
 552019-02-02T06:44:19  *** profmac has joined #bitcoin-core-dev
 562019-02-02T06:49:46  *** midnightmagic has joined #bitcoin-core-dev
 572019-02-02T07:05:15  *** rex4539 has quit IRC
 582019-02-02T07:23:25  *** miknotauro has joined #bitcoin-core-dev
 592019-02-02T07:33:37  *** pinheadmz has quit IRC
 602019-02-02T07:45:41  *** spinza has quit IRC
 612019-02-02T07:49:45  *** spinza has joined #bitcoin-core-dev
 622019-02-02T08:05:18  *** rex4539 has joined #bitcoin-core-dev
 632019-02-02T08:06:01  *** deadlysin has joined #bitcoin-core-dev
 642019-02-02T08:09:30  *** deadlysin has quit IRC
 652019-02-02T08:11:37  *** rex4539 has quit IRC
 662019-02-02T08:21:54  *** rex4539 has joined #bitcoin-core-dev
 672019-02-02T08:34:02  *** fanquake has joined #bitcoin-core-dev
 682019-02-02T08:41:43  *** miknotauro has quit IRC
 692019-02-02T09:09:12  *** Soligor has quit IRC
 702019-02-02T09:19:38  *** davec has quit IRC
 712019-02-02T09:21:51  *** davec has joined #bitcoin-core-dev
 722019-02-02T09:28:38  *** Soligor has joined #bitcoin-core-dev
 732019-02-02T09:34:05  *** miknotauro has joined #bitcoin-core-dev
 742019-02-02T09:43:36  *** Soligor has quit IRC
 752019-02-02T09:44:20  *** Soligor has joined #bitcoin-core-dev
 762019-02-02T09:55:24  *** hebasto has joined #bitcoin-core-dev
 772019-02-02T10:28:56  *** DeanGuss has joined #bitcoin-core-dev
 782019-02-02T10:29:47  *** spinza has quit IRC
 792019-02-02T10:29:51  *** murrayn has quit IRC
 802019-02-02T10:33:30  *** spinza has joined #bitcoin-core-dev
 812019-02-02T10:58:13  <fanquake> wumpus #15315 can go in
 822019-02-02T10:58:14  <gribble> https://github.com/bitcoin/bitcoin/issues/15315 | [0.17] [Doc] Backport release note about PSBT doc by harding · Pull Request #15315 · bitcoin/bitcoin · GitHub
 832019-02-02T11:03:36  <wumpus> loooooks like travis is acting up again (in #15324 at least): /home/travis/.travis/job_stages: line 104: .travis/test_06_script.sh: No such file or directory
 842019-02-02T11:03:37  *** DeanGuss has quit IRC
 852019-02-02T11:03:39  <gribble> https://github.com/bitcoin/bitcoin/issues/15324 | test: Make bloom tests deterministic by MarcoFalke · Pull Request #15324 · bitcoin/bitcoin · GitHub
 862019-02-02T11:03:56  *** DeanGuss has joined #bitcoin-core-dev
 872019-02-02T11:10:25  <fanquake> wumpus Looks like it needs rebasing on master after #15303, which split test_06_script.sh into two files
 882019-02-02T11:10:26  <gribble> https://github.com/bitcoin/bitcoin/issues/15303 | travis: Remove unused FUNCTIONAL_TESTS_CONFIG by MarcoFalke · Pull Request #15303 · bitcoin/bitcoin · GitHub
 892019-02-02T11:20:04  <fanquake> Looks like now all PRs prior to the one, will need rebasing on master, otherwise Travis will fail same as in #15324
 902019-02-02T11:20:06  <gribble> https://github.com/bitcoin/bitcoin/issues/15324 | test: Make bloom tests deterministic by MarcoFalke · Pull Request #15324 · bitcoin/bitcoin · GitHub
 912019-02-02T11:21:53  <wumpus> fanquake: right, was about to say, "it doesn't touch that"! but yea if it applies to all PRs that's it then
 922019-02-02T11:23:49  * fanquake rebases all 262 PRs
 932019-02-02T11:31:01  *** miknotauro has quit IRC
 942019-02-02T11:31:11  <wumpus> :-(
 952019-02-02T11:31:18  *** bitcoin-git has joined #bitcoin-core-dev
 962019-02-02T11:31:18  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to .17: https://github.com/bitcoin/bitcoin/compare/30db5cc6418a...392d1382c1b1
 972019-02-02T11:31:19  <bitcoin-git> bitcoin/.17 807add9 David A. Harding: [0.17] [Doc] Backport release note about PSBT doc
 982019-02-02T11:31:19  <bitcoin-git> bitcoin/.17 392d138 Wladimir J. van der Laan: Merge #15315: [0.17] [Doc] Backport release note about PSBT doc
 992019-02-02T11:31:29  *** bitcoin-git has left #bitcoin-core-dev
1002019-02-02T11:31:46  *** bitcoin-git has joined #bitcoin-core-dev
1012019-02-02T11:31:46  <bitcoin-git> [bitcoin] laanwj merged pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
1022019-02-02T11:31:54  *** bitcoin-git has left #bitcoin-core-dev
1032019-02-02T11:36:16  <wumpus> gkrizek: "[bitcoin] ... (.17...019-02-backport-release-notes)" looks like the first letter of the branch names is missing ! :)
1042019-02-02T11:56:34  *** hebasto has quit IRC
1052019-02-02T12:20:10  *** hebasto has joined #bitcoin-core-dev
1062019-02-02T13:22:12  *** booyah has quit IRC
1072019-02-02T13:33:08  *** jtimon has joined #bitcoin-core-dev
1082019-02-02T13:50:15  *** dviola has joined #bitcoin-core-dev
1092019-02-02T13:53:04  *** Skirmant has joined #bitcoin-core-dev
1102019-02-02T13:53:23  *** tryphe has quit IRC
1112019-02-02T13:54:34  *** EagleTM has joined #bitcoin-core-dev
1122019-02-02T13:55:54  *** tryphe has joined #bitcoin-core-dev
1132019-02-02T13:58:23  *** DeanGuss has quit IRC
1142019-02-02T13:58:56  *** DeanGuss has joined #bitcoin-core-dev
1152019-02-02T14:14:19  *** promag has joined #bitcoin-core-dev
1162019-02-02T14:24:05  *** fanquake has quit IRC
1172019-02-02T14:31:39  *** promag has quit IRC
1182019-02-02T14:42:08  <gkrizek> Yeah I noticed that. I think it only happens on the branch names with ‘0.X’.  I’ll look into it
1192019-02-02T14:46:27  *** EagleTM has quit IRC
1202019-02-02T15:16:13  *** booyah has joined #bitcoin-core-dev
1212019-02-02T15:29:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1222019-02-02T15:30:17  *** booyah has quit IRC
1232019-02-02T15:31:14  *** booyah has joined #bitcoin-core-dev
1242019-02-02T15:50:37  *** darosior has joined #bitcoin-core-dev
1252019-02-02T15:57:36  *** kexkey has joined #bitcoin-core-dev
1262019-02-02T16:08:12  *** rex4539 has joined #bitcoin-core-dev
1272019-02-02T16:13:11  <wumpus> gkrizek: maybe always when it starts with a number
1282019-02-02T16:13:31  <wumpus> the 019-02... one looks cut-off too
1292019-02-02T16:21:03  *** justanotheruser has quit IRC
1302019-02-02T16:27:28  *** hashist has quit IRC
1312019-02-02T16:35:28  *** Guyver2 has joined #bitcoin-core-dev
1322019-02-02T16:39:31  *** miknotauro has joined #bitcoin-core-dev
1332019-02-02T16:47:16  <gkrizek> Ah, could be!
1342019-02-02T16:52:40  *** miknotauro has quit IRC
1352019-02-02T16:54:32  *** Chris_Stewart_5 has quit IRC
1362019-02-02T16:55:05  *** fleshwounded has joined #bitcoin-core-dev
1372019-02-02T16:57:20  <fleshwounded> woot woot found the @wumpus
1382019-02-02T16:57:36  <fleshwounded> you really dont leave the irc do you lol?
1392019-02-02T17:07:15  <fleshwounded> hope that router is doing some fancy stuff now? you plug an pcie in? or what was is again msata I forget lol... been eye humping those routers ever since we talked lol
1402019-02-02T17:08:04  <fleshwounded> I wanna do the satellite node now...
1412019-02-02T17:10:22  *** miknotauro has joined #bitcoin-core-dev
1422019-02-02T17:17:29  *** drexl has joined #bitcoin-core-dev
1432019-02-02T17:32:41  *** Kvaciral has quit IRC
1442019-02-02T17:44:27  *** pinheadmz has joined #bitcoin-core-dev
1452019-02-02T17:46:49  *** DougieBot5000_ is now known as DougieBot5000
1462019-02-02T17:59:21  *** pinheadmz has quit IRC
1472019-02-02T18:11:36  *** spinza has quit IRC
1482019-02-02T18:12:31  <wumpus> fleshwounded: my IRC runs on a server that's always on (weechat on tmux right now), this is useful to not miss backlog
1492019-02-02T18:14:44  *** ExtraCrispy has joined #bitcoin-core-dev
1502019-02-02T18:17:50  <wumpus> fleshwounded: and feel free to PM me about the other things, this is off topic for the channel
1512019-02-02T18:18:44  *** kexkey_ has joined #bitcoin-core-dev
1522019-02-02T18:18:48  *** kexkey has quit IRC
1532019-02-02T18:21:27  *** miknotauro has quit IRC
1542019-02-02T18:22:29  *** spinza has joined #bitcoin-core-dev
1552019-02-02T18:29:53  *** andrewbenson has joined #bitcoin-core-dev
1562019-02-02T18:35:17  *** bitcoin-git has joined #bitcoin-core-dev
1572019-02-02T18:35:17  <bitcoin-git> [bitcoin] practicalswift opened pull request #15327: tests: Make tests updatecoins_simulation_test and knapsack_solver_test deterministic (master...SeedInsecureRand(true);) https://github.com/bitcoin/bitcoin/pull/15327
1582019-02-02T18:35:18  *** bitcoin-git has left #bitcoin-core-dev
1592019-02-02T18:41:01  *** pinheadmz has joined #bitcoin-core-dev
1602019-02-02T18:43:17  <fleshwounded> I just wasnt sure if I was in the right place or not @wumpus not a problem lol
1612019-02-02T18:46:15  <wumpus> ok !
1622019-02-02T19:00:16  *** andrewbenson has quit IRC
1632019-02-02T19:01:11  <MarcoFalke> re travis failures: Not all pull requests need rebase (only those that failed prior to now and need to be run again). A force push or push should also suffice, though.
1642019-02-02T19:03:59  *** dviola has quit IRC
1652019-02-02T19:22:44  *** jtimon has quit IRC
1662019-02-02T19:27:08  *** andrewbenson has joined #bitcoin-core-dev
1672019-02-02T19:27:51  *** pinheadmz has quit IRC
1682019-02-02T19:28:40  *** pinheadmz has joined #bitcoin-core-dev
1692019-02-02T19:37:16  *** andrewbenson has quit IRC
1702019-02-02T19:41:39  <provoostenator> Any idea what I should cherry-pick to prevent "Assertion failed: (!m_result.empty()), function RPCResult, file ./rpc/util.h, line 118." ?
1712019-02-02T19:42:54  *** bitcoin-git has joined #bitcoin-core-dev
1722019-02-02T19:42:55  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15328: travis: Revert "Run extended tests once daily" (master...Mf1902-travisExt) https://github.com/bitcoin/bitcoin/pull/15328
1732019-02-02T19:42:59  *** bitcoin-git has left #bitcoin-core-dev
1742019-02-02T19:44:15  *** AaronvanW has joined #bitcoin-core-dev
1752019-02-02T19:44:35  *** promag has joined #bitcoin-core-dev
1762019-02-02T19:48:20  <MarcoFalke> provoostenator: It tells you to not pass in an m_result that is empty
1772019-02-02T19:48:35  <MarcoFalke> All rpc have a result (even if it is Null)
1782019-02-02T19:53:57  *** darosior has quit IRC
1792019-02-02T19:54:27  *** promag has quit IRC
1802019-02-02T20:01:15  *** DeanGuss has quit IRC
1812019-02-02T20:10:32  *** pinheadmz has quit IRC
1822019-02-02T20:13:36  *** Kvaciral has joined #bitcoin-core-dev
1832019-02-02T20:19:44  *** justanotheruser has joined #bitcoin-core-dev
1842019-02-02T20:24:38  <provoostenator> It crashes for src/bitcoin-cli help
1852019-02-02T20:25:05  *** hebasto has quit IRC
1862019-02-02T20:25:17  *** hebasto has joined #bitcoin-core-dev
1872019-02-02T20:25:49  *** pinheadmz has joined #bitcoin-core-dev
1882019-02-02T20:29:59  <provoostenator> During the block rewind phase "bitcoin-cli help" complains as usualy that it's still rewinding. After that it crashes. Same if I use the console in QT.
1892019-02-02T20:30:20  <provoostenator> If nothing comes to mind though, I'm just going to go through the misery of rebasing and see if that magically helps :-)
1902019-02-02T20:41:31  *** EagleTM has joined #bitcoin-core-dev
1912019-02-02T20:50:04  *** pinheadmz has quit IRC
1922019-02-02T21:09:40  *** justanotheruser has quit IRC
1932019-02-02T21:11:57  <provoostenator> achow101 / meshcollider: if you get a chance to rebase #14491 that would be quite helpful. I can't figure it out.
1942019-02-02T21:12:01  <gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
1952019-02-02T21:14:31  *** bitcoin-git has joined #bitcoin-core-dev
1962019-02-02T21:14:31  <bitcoin-git> [bitcoin] hebasto opened pull request #15329: [WIP] Fix InitError() and InitWarning() content (master...0190202-initerror) https://github.com/bitcoin/bitcoin/pull/15329
1972019-02-02T21:14:39  *** bitcoin-git has left #bitcoin-core-dev
1982019-02-02T21:15:37  *** promag has joined #bitcoin-core-dev
1992019-02-02T21:17:53  *** shesek has joined #bitcoin-core-dev
2002019-02-02T21:17:53  *** shesek has joined #bitcoin-core-dev
2012019-02-02T21:30:46  *** promag has quit IRC
2022019-02-02T21:30:56  <meshcollider> provoostenator: yep I'll rebase but it can't be fixed til #15263
2032019-02-02T21:30:57  <gribble> https://github.com/bitcoin/bitcoin/issues/15263 | Descriptor expansions only need pubkey entries for PKH/WPKH by sipa · Pull Request #15263 · bitcoin/bitcoin · GitHub
2042019-02-02T21:31:09  <meshcollider> So I'd prefer to just wait for that
2052019-02-02T21:31:33  <provoostenator> Some WIP on top of that would be quite useful though
2062019-02-02T21:32:16  <meshcollider> Stacked PRs again 🙃
2072019-02-02T21:32:26  <provoostenator> Oh yes...
2082019-02-02T21:32:51  <provoostenator> I either need to solve a mysterious crash or figure out how to rebase this thing. Neither feels appealing.
2092019-02-02T21:33:19  <meshcollider> Is it the rebase or the existing bug that's causing the issue?
2102019-02-02T21:33:24  <provoostenator> Both
2112019-02-02T21:33:46  <provoostenator> And maybe even a local machine issue, who knows.
2122019-02-02T21:34:05  <provoostenator> It's quite weird though: I can run the functional tests fine, but using the RPC crashes.
2132019-02-02T21:34:20  <meshcollider> That's very weird, using the same input?
2142019-02-02T21:34:23  <provoostenator> And I'm pretty sure it worked earlier today with the exact same commit.
2152019-02-02T21:34:36  <provoostenator> #14912
2162019-02-02T21:34:38  <gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
2172019-02-02T21:34:50  <provoostenator> "bitcoin-cli help" causes a reliable crash
2182019-02-02T21:35:10  <provoostenator> But not on master
2192019-02-02T21:35:46  <provoostenator> So I figured that I probably created too much of a nested PR mess and need to start again from master, but that's not an option pending that rebase.
2202019-02-02T21:36:13  <meshcollider> So somewhere in those 36 commits theres a bug, yay!
2212019-02-02T21:36:41  <provoostenator> Maybe, and it's possible I didn't notice it earlier today because some cached thing saved me.
2222019-02-02T21:36:55  <meshcollider> Ok I'll try and get it done today or tomorrow at the latest but like you say, its a bit of a headache to rebase this one
2232019-02-02T21:37:26  <provoostenator> Meanwhile I'll try nuking some things on my end to see if I can get things to compile
2242019-02-02T21:37:28  <meshcollider> I'll have to base it on top of sipas PR so then we have yet another PR in the tower
2252019-02-02T21:39:12  <provoostenator> It'd say the descriptor import PR is the scariest thing in the tower. Should be smooth sailing once that's merged...
2262019-02-02T21:39:35  <provoostenator> Because it's both a big refactor and adding new functionality.
2272019-02-02T21:40:00  <provoostenator> And every time we find a problem, we've been adding some parallel PR to deal with that.
2282019-02-02T21:41:57  <provoostenator> I'd also love to move most of that stuff out of the RPC codebase and into a place where it can also be used by the GUI, but let's not for now :-)
2292019-02-02T21:43:37  <meshcollider> yep lets do a move PR after the water clears a bit :)
2302019-02-02T21:44:52  <provoostenator> #14978 is a good example of moving stuff out of RPC codebase
2312019-02-02T21:44:55  <gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
2322019-02-02T21:48:03  *** Sentineo has quit IRC
2332019-02-02T21:48:17  <meshcollider> actually is anyone around e.g. jnewbery that could quickly review #15263
2342019-02-02T21:48:18  <gribble> https://github.com/bitcoin/bitcoin/issues/15263 | Descriptor expansions only need pubkey entries for PKH/WPKH by sipa · Pull Request #15263 · bitcoin/bitcoin · GitHub
2352019-02-02T21:48:21  <meshcollider> its pretty much RTM
2362019-02-02T21:49:05  <provoostenator> Indeed
2372019-02-02T21:49:38  *** Sentineo has joined #bitcoin-core-dev
2382019-02-02T21:50:40  <MarcoFalke> provoostenator: https://github.com/bitcoin/bitcoin/pull/14912/files#r253279565
2392019-02-02T21:51:34  <provoostenator> Oh, that RPCResult stuff is called runtime?
2402019-02-02T21:51:50  <provoostenator> I thought it was some compiler magick.
2412019-02-02T21:52:14  <MarcoFalke> std::string is not constexpr
2422019-02-02T21:52:58  <MarcoFalke> And in any case RPCResult should be moved away from strings to types (just like RPCArg)
2432019-02-02T21:53:09  *** bitcoin-git has joined #bitcoin-core-dev
2442019-02-02T21:53:09  <bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3a715301a0f...6e6b859f85a8
2452019-02-02T21:53:10  <provoostenator> So I need to do RPCResult{"null"} for entries without no result doc?
2462019-02-02T21:53:10  <bitcoin-git> bitcoin/master 11e0fd8 Pieter Wuille: Descriptor expansions only need pubkey entries for PKH/WPKH
2472019-02-02T21:53:10  <bitcoin-git> bitcoin/master 6e6b859 MeshCollider: Merge #15263: Descriptor expansions only need pubkey entries for PKH/WPKH
2482019-02-02T21:53:12  *** bitcoin-git has left #bitcoin-core-dev
2492019-02-02T21:53:58  *** bitcoin-git has joined #bitcoin-core-dev
2502019-02-02T21:53:58  <bitcoin-git> [bitcoin] MeshCollider merged pull request #15263: Descriptor expansions only need pubkey entries for PKH/WPKH (master...01901_flatprovider_pkh) https://github.com/bitcoin/bitcoin/pull/15263
2512019-02-02T21:54:02  <MarcoFalke> Yes, I believe we should document that the return value is json-null instead of ommiting it
2522019-02-02T21:54:03  *** bitcoin-git has left #bitcoin-core-dev
2532019-02-02T21:54:18  <MarcoFalke> * omitting
2542019-02-02T21:56:52  <provoostenator> MarcoFalke: same for RPCExamples?
2552019-02-02T21:57:18  <MarcoFalke> Not required, up to you to provide examples
2562019-02-02T21:59:13  <provoostenator> Crash gone! Thanks.
2572019-02-02T22:01:50  *** spinza has quit IRC
2582019-02-02T22:02:55  <meshcollider> \o/
2592019-02-02T22:03:16  <provoostenator> meshcollider: I see you merged it :-) Maybe add my "Test importing of a P2PKH address via descriptor" when you rebase?
2602019-02-02T22:03:56  <meshcollider> provoostenator: will do, thanks
2612019-02-02T22:04:34  <provoostenator> No rush though, with the crash out of the way at least I'm not stuck. Though I'd still like to get that the descriptor import multi PR merged, to pave the way to get achow101's PR's merged.
2622019-02-02T22:04:43  <meshcollider> yeah I agree
2632019-02-02T22:04:51  <meshcollider> these stacked PRs make things so much harder
2642019-02-02T22:04:54  <provoostenator> With a bit of luck we'll have everything to use HWI Python scripts in standalone mode before 0.18
2652019-02-02T22:06:31  <hebasto> wumpus: regarding #15329; what about translation of errors related to wallets or invalid option values?
2662019-02-02T22:06:32  <gribble> https://github.com/bitcoin/bitcoin/issues/15329 | Fix InitError() and InitWarning() content by hebasto · Pull Request #15329 · bitcoin/bitcoin · GitHub
2672019-02-02T22:13:28  *** DeanGuss has joined #bitcoin-core-dev
2682019-02-02T22:15:37  *** spinza has joined #bitcoin-core-dev
2692019-02-02T22:19:36  *** Guyver2 has quit IRC
2702019-02-02T22:20:36  *** Aaronvan_ has joined #bitcoin-core-dev
2712019-02-02T22:22:34  *** AaronvanW has quit IRC
2722019-02-02T22:26:37  <wumpus> hebasto: I don't know, don't have a strong opinion on it; but note that we also don't translate option help
2732019-02-02T22:28:21  <wumpus> hebasto: in any case I think the criterion for translation should be "does this message make sense to a user/translator", you can assume knowledge of bitcoin terminology such as blocks, transactions, wallets, etc, but not internals of the software
2742019-02-02T22:29:25  <wumpus> so for the wallet messages it makes more sense to translate I guess
2752019-02-02T22:29:28  *** pinheadmz has joined #bitcoin-core-dev
2762019-02-02T22:29:44  <hebasto> ^^ that was my initial intention
2772019-02-02T22:30:19  <wumpus> somthing like "wallet cannot be loaded" is very translatable
2782019-02-02T22:30:50  <gmaxwell> Doesn't translation of errors make googling for help impossible?
2792019-02-02T22:30:52  <wumpus> but something highly technical, like, "wallet premature EOF truncated key" you'd certainly not want to translate
2802019-02-02T22:31:26  <wumpus> gmaxwell: yes that was exactly my point in  #15329
2812019-02-02T22:31:27  <gribble> https://github.com/bitcoin/bitcoin/issues/15329 | [WIP] Fix InitError() and InitWarning() content by hebasto · Pull Request #15329 · bitcoin/bitcoin · GitHub
2822019-02-02T22:32:34  <wumpus> I mean you could also say "don't translate any errors at all" but that'd be a new policy, in fact some InitError and InitWarning are translated at the moment
2832019-02-02T22:32:59  <wumpus> it's fine with me though ...
2842019-02-02T22:34:00  <gmaxwell> It might be more useful to show both the translated and english error, but I dunno if the translation infrastructure makes that possible
2852019-02-02T22:35:08  <gmaxwell> otherwise I think we're stuck wondering if the error is user actionable ("wallet file not found") vs not ("hyperspatial cascade failure in wallet")
2862019-02-02T22:35:38  <wumpus> yes
2872019-02-02T22:35:38  <hebasto> for future maintenance purpose is it good to explicitly comment untranslated errors?
2882019-02-02T22:36:05  <wumpus> so I think the first point here should be: do we actually have a problem? is this a serious issue?
2892019-02-02T22:36:30  <gmaxwell> hebasto: I think most errors outside of UI components are intentionally not translated.
2902019-02-02T22:36:40  <wumpus> gmaxwell: yes
2912019-02-02T22:36:54  <wumpus> it's only the UI that does translation, in any case
2922019-02-02T22:37:11  <hebasto> InitError() presents error via UI
2932019-02-02T22:38:13  <echeveria> I've seen users turn up with translated error messages before. it wasn't useful to me as someone who does not know russian, and they being bilingual and having to translate it back for me.
2942019-02-02T22:38:46  <wumpus> It might be more useful to show both the translated and english error -> this is not possible at the moment, would be possible to create a _() alternative that returns both the original string and the transalation I guess, but that'd need changes to a few scripts
2952019-02-02T22:39:17  <wumpus> (e.g. gettext needs to pick it up)
2962019-02-02T22:39:24  <wumpus> echeveria: yeah... it's terrible
2972019-02-02T22:39:25  <gmaxwell> I would guess that this is one reason that some commercial packages have numbered error messages.
2982019-02-02T22:41:07  <wumpus> numbering errors makes sense
2992019-02-02T22:43:01  <sipa> SHA256("english error") % 2^32
3002019-02-02T22:43:11  <sipa> very likely to be unique
3012019-02-02T22:43:28  <echeveria> PATCH: fix typo in error text
3022019-02-02T22:43:55  <sipa> haha
3032019-02-02T22:44:02  <echeveria> I jest.
3042019-02-02T22:47:01  *** rh0nj has quit IRC
3052019-02-02T22:48:08  *** rh0nj has joined #bitcoin-core-dev
3062019-02-02T22:48:37  *** bitcoin-git has joined #bitcoin-core-dev
3072019-02-02T22:48:37  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15330: test: Fix race in p2p_invalid_messages (master...Mf1902-qaRaceMagic) https://github.com/bitcoin/bitcoin/pull/15330
3082019-02-02T22:48:50  *** bitcoin-git has left #bitcoin-core-dev
3092019-02-02T22:49:06  <wumpus> that works :) though the usual way is to make errors an enum, per subsystem, e.g. 1xxx is block chain error, 2xxx wallet error and so on, this way having the error strings in the code can be avoided completely, they can be in some text/database file including translations ...
3102019-02-02T22:51:55  <gmaxwell> [SHA256] PATCH: adjust round constants to preserve E1132 with new text.
3112019-02-02T22:53:21  <wumpus> hehe
3122019-02-02T22:54:01  <gmaxwell> lets just make _() steg encode the line number into case alterations in the text...  "A légpáRnásOM tELe vaN anGolnákKal."
3132019-02-02T22:54:02  <wumpus> or add random data to the end of the error message and grind
3142019-02-02T22:54:18  * sipa writes gramtropy grammar
3152019-02-02T22:54:32  <gmaxwell> oh bitcoin error messages grammar.
3162019-02-02T22:54:32  <wumpus> or that
3172019-02-02T23:06:25  <sipa> gmaxwell: among degree 7, length 32767, distance 4 codes there exist only 1800 unique ones; among those, there is one with length 172 distance distance 5
3182019-02-02T23:09:15  <gmaxwell> sipa: sadly not long enough for the 'P2WSH 2-of-3 multisig' example in the descriptors docs.
3192019-02-02T23:09:47  <sipa> yup
3202019-02-02T23:09:55  <sipa> i can look at 8 character codes
3212019-02-02T23:10:41  <gmaxwell> Worth taking a look.
3222019-02-02T23:12:15  <gmaxwell> 5 up to 172 is still better than just distance 4... though I'd be particularly satisfied if it was long enough for 2 of 3 with hex pubkeys. (about 221-ish?)
3232019-02-02T23:13:09  <sipa> 209
3242019-02-02T23:13:48  <gmaxwell> 209 is without wsh() and without the checkvalue itself.
3252019-02-02T23:13:51  <sipa> though 280 if we have 3-to-4 expansion for the character classes inline
3262019-02-02T23:13:56  <sipa> ah yes!
3272019-02-02T23:15:46  <gmaxwell> if we have 3-to-4 characters there will be a base-58 check though.
3282019-02-02T23:16:11  *** jtimon has joined #bitcoin-core-dev
3292019-02-02T23:17:17  <sipa> we can also have all character class 'symbols' first and then all the individual character symbols, in which case the length only applies whenever errors within the class are made (which is very likely for the multisig with hex pubkeys example; it only excludes errors in the wsh/multi keywords)
3302019-02-02T23:17:47  <gmaxwell> jinx I was just thinking about that.
3312019-02-02T23:18:18  <gmaxwell> But it wasn't completely clear to me if it was possible without having placeholder characters.
3322019-02-02T23:18:28  <gmaxwell> or without a weird integration with parsing.
3332019-02-02T23:19:17  <sipa> there are 94 printable ascii characters, so you only need 3 character classes
3342019-02-02T23:19:22  *** pinheadmz has quit IRC
3352019-02-02T23:19:22  <gmaxwell> like... would you process this by parsing to strip all the base-58 parts then check them then apply the checksum to the base58parts then the stripped part?
3362019-02-02T23:20:29  <sipa> no, with every character you assign a character class and a 5-bit position within that class; and then you transform every 3 characters into 4 symbols, where the first symbol is cls1*9+cls2*3+cls3, and the other 3 are the individual positions of the 3 characters in their class
3372019-02-02T23:20:41  <sipa> ah i see what you're getting at
3382019-02-02T23:20:55  <sipa> you could actually sort all index positions based on their class
3392019-02-02T23:22:19  <sipa> so then as long as all errors are within the same class, the distance is excluding any intermediary characters in other classes
3402019-02-02T23:23:02  <gmaxwell> but an error that changes a base58 character to non-base58 than shifts all the non-base58 characters.
3412019-02-02T23:23:05  *** pinheadmz has joined #bitcoin-core-dev
3422019-02-02T23:23:07  *** EagleTM has quit IRC
3432019-02-02T23:23:09  <gmaxwell> e.g. a one character error could be undetected.
3442019-02-02T23:23:33  <sipa> ah yes
3452019-02-02T23:23:40  <sipa> that would be unfortunate
3462019-02-02T23:24:00  <gmaxwell> thats why I was musing about parsing to split.
3472019-02-02T23:24:09  <sipa> let's see what distance we can do with degree 8
3482019-02-02T23:24:16  <sipa> eh, what length
3492019-02-02T23:24:17  <gmaxwell> yep sounds good.
3502019-02-02T23:32:36  *** justanotheruser has joined #bitcoin-core-dev
3512019-02-02T23:37:00  *** justanotheruser has quit IRC
3522019-02-02T23:38:03  *** pinheadmz has quit IRC
3532019-02-02T23:38:36  *** bitcoin-git has joined #bitcoin-core-dev
3542019-02-02T23:38:37  <bitcoin-git> [bitcoin] laanwj closed pull request #14872: contrib: Adding -daemon default option to bitcoind.init (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14872
3552019-02-02T23:38:43  *** bitcoin-git has left #bitcoin-core-dev
3562019-02-02T23:38:50  *** justanotheruser has joined #bitcoin-core-dev
3572019-02-02T23:39:07  <phantomcircuit> gmaxwell, we could include an error code which is just a hash of the english version
3582019-02-02T23:39:19  <phantomcircuit> wait sipa already said that
3592019-02-02T23:39:20  <phantomcircuit> nvm
3602019-02-02T23:40:06  *** Aaronvan_ has quit IRC
3612019-02-02T23:41:23  <wumpus> please don't actually do that
3622019-02-02T23:45:49  *** spinza has quit IRC
3632019-02-02T23:50:41  <sipa> gmaxwell: i've already found some degree 8 codes with distance 5 up to length 800
3642019-02-02T23:51:43  <gmaxwell> oh sweet. any have distance 6 at 221? :P
3652019-02-02T23:51:48  <gmaxwell> er 222
3662019-02-02T23:54:30  <sipa> that'll take much more time to say for certain, but based on results so far, i'd say it's unlikely
3672019-02-02T23:54:37  *** spinza has joined #bitcoin-core-dev
3682019-02-02T23:55:00  *** shesek has quit IRC