1 2019-02-06T00:00:11  *** Murch has quit IRC
  2 2019-02-06T00:05:53  *** bitcoin-git has joined #bitcoin-core-dev
  3 2019-02-06T00:05:53  <bitcoin-git> [bitcoin] promag opened pull request #15350: qa: Drop RPC connection if --usecli (master...2019-01-fixusecli) https://github.com/bitcoin/bitcoin/pull/15350
  4 2019-02-06T00:05:54  *** bitcoin-git has left #bitcoin-core-dev
  5 2019-02-06T00:08:25  *** Murch has joined #bitcoin-core-dev
  6 2019-02-06T00:20:17  *** spinza has quit IRC
  7 2019-02-06T00:21:41  <CubicEarth> Does anyone know the status of SIGHASH_NOINPUT? Discussion on the ML seems to have quieted down...
  8 2019-02-06T00:28:54  *** spinza has joined #bitcoin-core-dev
  9 2019-02-06T00:39:58  *** promag has quit IRC
 10 2019-02-06T00:53:28  *** Murch has quit IRC
 11 2019-02-06T00:55:29  *** Murch has joined #bitcoin-core-dev
 12 2019-02-06T00:55:33  *** bitcoin-git has joined #bitcoin-core-dev
 13 2019-02-06T00:55:33  <bitcoin-git> [bitcoin] OverlordQ opened pull request #15351: Update linearize-hashes.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15351
 14 2019-02-06T00:55:44  *** bitcoin-git has left #bitcoin-core-dev
 15 2019-02-06T00:58:44  *** Saroja has joined #bitcoin-core-dev
 16 2019-02-06T01:00:53  *** Saroja has quit IRC
 17 2019-02-06T01:01:40  *** dqx has quit IRC
 18 2019-02-06T01:15:19  *** AaronvanW has joined #bitcoin-core-dev
 19 2019-02-06T01:15:47  *** AaronvanW has quit IRC
 20 2019-02-06T01:17:37  *** dqx has joined #bitcoin-core-dev
 21 2019-02-06T01:18:48  *** Aaronvan_ has quit IRC
 22 2019-02-06T01:21:13  *** Murch has quit IRC
 23 2019-02-06T01:24:48  *** dviola has quit IRC
 24 2019-02-06T01:25:08  *** dqx has quit IRC
 25 2019-02-06T01:25:25  *** Murch has joined #bitcoin-core-dev
 26 2019-02-06T01:27:40  *** Murchone has joined #bitcoin-core-dev
 27 2019-02-06T01:27:51  *** Murch has quit IRC
 28 2019-02-06T01:28:43  *** Murchone has quit IRC
 29 2019-02-06T01:45:35  *** dqx has joined #bitcoin-core-dev
 30 2019-02-06T01:47:16  *** jcorgan has joined #bitcoin-core-dev
 31 2019-02-06T02:12:09  *** twistedline has joined #bitcoin-core-dev
 32 2019-02-06T02:13:29  *** Murch has joined #bitcoin-core-dev
 33 2019-02-06T02:15:37  *** DeanGuss has joined #bitcoin-core-dev
 34 2019-02-06T02:16:07  *** twistedline has quit IRC
 35 2019-02-06T02:17:42  *** pinheadmz has quit IRC
 36 2019-02-06T02:23:55  *** pinheadmz has joined #bitcoin-core-dev
 37 2019-02-06T02:50:31  *** Murch has quit IRC
 38 2019-02-06T02:55:56  *** nelsonhb has joined #bitcoin-core-dev
 39 2019-02-06T02:58:01  *** twistedline has joined #bitcoin-core-dev
 40 2019-02-06T03:10:44  *** twistedline has joined #bitcoin-core-dev
 41 2019-02-06T03:12:36  *** twistedline has quit IRC
 42 2019-02-06T03:16:43  *** Krellan_ has quit IRC
 43 2019-02-06T03:27:36  *** twistedline has joined #bitcoin-core-dev
 44 2019-02-06T03:27:55  *** twistedline has quit IRC
 45 2019-02-06T03:28:08  *** pinheadmz has quit IRC
 46 2019-02-06T03:28:11  <nelsonhb> Guangdong Pilot Free Trade Zone
 47 2019-02-06T03:28:11  <nelsonhb> Guilin High-tech Industrial Development Zone
 48 2019-02-06T03:28:11  <nelsonhb> Nanning Economic & Technological Development Area
 49 2019-02-06T03:28:11  <nelsonhb> Kunming High-tech Industrial Development Zone (biological medicine, new materials, electronic information, photoelectron, agriculture) and Kunming Economic and Technology Development Zone (mechanical equipment production, biological science and food industry, information industry, software).
 50 2019-02-06T03:28:11  <nelsonhb> Chenggong Industrial Park
 51 2019-02-06T03:28:11  <nelsonhb> Anning Industrial Park
 52 2019-02-06T03:28:11  <nelsonhb> Songming Yanglin Industrial Development Zone
 53 2019-02-06T03:28:12  <nelsonhb> Dongchuan Special Industrial Park
 54 2019-02-06T03:28:12  <nelsonhb> Xundian Special Industrial Park
 55 2019-02-06T03:28:13  <nelsonhb> Kunming Haikou Industrial Park.
 56 2019-02-06T03:30:02  *** sidhujag has joined #bitcoin-core-dev
 57 2019-02-06T03:30:13  <sidhujag> hey guys just wondering is coinbase outputs to witness programs (bech32) considered safe?
 58 2019-02-06T03:30:41  <sidhujag> i thought you normally would pay to legacy addresses in coinbase because witness programs aren't verified in coinbase
 59 2019-02-06T03:31:30  <sidhujag> i was watching blocks found a weird one pop up with 1 tx only.. and saw its outputting to a bech32
 60 2019-02-06T03:31:31  <sidhujag> 0000000000000000000ad0dd07019a8dae9aa5b6eb3d39782e9af8e082353b39
 61 2019-02-06T03:33:30  *** nelsonhb has quit IRC
 62 2019-02-06T03:37:57  *** volkov has joined #bitcoin-core-dev
 63 2019-02-06T03:39:57  *** kexkey has joined #bitcoin-core-dev
 64 2019-02-06T03:41:38  *** drexl has quit IRC
 65 2019-02-06T03:45:26  *** kexkey has quit IRC
 66 2019-02-06T03:46:48  *** kexkey has joined #bitcoin-core-dev
 67 2019-02-06T03:47:23  *** sidhujag has quit IRC
 68 2019-02-06T03:59:00  *** Skirmant has quit IRC
 69 2019-02-06T04:09:01  *** rh0nj has quit IRC
 70 2019-02-06T04:10:07  *** rh0nj has joined #bitcoin-core-dev
 71 2019-02-06T04:12:14  *** ddustin has quit IRC
 72 2019-02-06T04:12:53  *** ddustin has joined #bitcoin-core-dev
 73 2019-02-06T04:12:53  *** Randolf has joined #bitcoin-core-dev
 74 2019-02-06T04:17:22  *** ddustin has quit IRC
 75 2019-02-06T04:17:54  *** twistedline has joined #bitcoin-core-dev
 76 2019-02-06T04:42:08  *** Lang_ has joined #bitcoin-core-dev
 77 2019-02-06T04:43:04  *** Lang_ has quit IRC
 78 2019-02-06T04:54:28  *** pinheadmz has joined #bitcoin-core-dev
 79 2019-02-06T05:03:02  *** volkov has quit IRC
 80 2019-02-06T05:18:35  *** pinheadmz has quit IRC
 81 2019-02-06T05:20:17  *** pinheadmz has joined #bitcoin-core-dev
 82 2019-02-06T05:40:49  *** pinheadmz has quit IRC
 83 2019-02-06T05:56:09  *** ppisati has quit IRC
 84 2019-02-06T05:59:31  *** jtimon has quit IRC
 85 2019-02-06T06:02:23  *** ghost43 has quit IRC
 86 2019-02-06T06:02:50  *** ppisati has joined #bitcoin-core-dev
 87 2019-02-06T06:03:16  *** ghost43 has joined #bitcoin-core-dev
 88 2019-02-06T06:08:37  *** Randolf has quit IRC
 89 2019-02-06T06:09:10  *** Randolf has joined #bitcoin-core-dev
 90 2019-02-06T06:19:13  *** hebasto has joined #bitcoin-core-dev
 91 2019-02-06T06:19:38  *** pinheadmz has joined #bitcoin-core-dev
 92 2019-02-06T06:20:30  *** Krellan has joined #bitcoin-core-dev
 93 2019-02-06T06:21:51  *** Krellan_ has joined #bitcoin-core-dev
 94 2019-02-06T06:25:20  *** Krellan has quit IRC
 95 2019-02-06T06:33:51  *** ap4lmtree has quit IRC
 96 2019-02-06T06:38:28  *** ap4lmtree has joined #bitcoin-core-dev
 97 2019-02-06T07:02:33  *** pinheadmz has quit IRC
 98 2019-02-06T07:04:47  *** warren has quit IRC
 99 2019-02-06T07:05:56  *** warren has joined #bitcoin-core-dev
100 2019-02-06T07:43:59  *** hebasto has quit IRC
101 2019-02-06T08:27:43  *** elichai2 has joined #bitcoin-core-dev
102 2019-02-06T08:34:03  *** Squidicuz has quit IRC
103 2019-02-06T08:46:52  *** Squidicuz has joined #bitcoin-core-dev
104 2019-02-06T09:05:35  *** setpill has joined #bitcoin-core-dev
105 2019-02-06T09:28:52  *** promag has joined #bitcoin-core-dev
106 2019-02-06T09:31:43  *** mn9495882 has quit IRC
107 2019-02-06T09:33:15  *** promag has quit IRC
108 2019-02-06T09:35:07  *** Randolf has quit IRC
109 2019-02-06T09:35:18  *** mn949588 has joined #bitcoin-core-dev
110 2019-02-06T09:40:26  *** Randolf has joined #bitcoin-core-dev
111 2019-02-06T10:01:10  *** AaronvanW has joined #bitcoin-core-dev
112 2019-02-06T10:03:29  *** kexkey has quit IRC
113 2019-02-06T10:05:23  *** bitcoin-git has joined #bitcoin-core-dev
114 2019-02-06T10:05:23  <bitcoin-git> [bitcoin] practicalswift opened pull request #15352: tests: Reduce noise level in test_bitcoin output (master...test_bitcoin-output-spam) https://github.com/bitcoin/bitcoin/pull/15352
115 2019-02-06T10:05:25  *** bitcoin-git has left #bitcoin-core-dev
116 2019-02-06T10:06:05  *** spinza has quit IRC
117 2019-02-06T10:06:26  *** fanquake has joined #bitcoin-core-dev
118 2019-02-06T10:16:56  *** spinza has joined #bitcoin-core-dev
119 2019-02-06T10:47:51  *** AaronvanW has quit IRC
120 2019-02-06T10:49:24  *** Skirmant has joined #bitcoin-core-dev
121 2019-02-06T10:52:24  *** drexl has joined #bitcoin-core-dev
122 2019-02-06T10:57:41  *** promag has joined #bitcoin-core-dev
123 2019-02-06T11:03:15  *** darosior has joined #bitcoin-core-dev
124 2019-02-06T11:08:03  *** promag has quit IRC
125 2019-02-06T11:17:26  *** dviola has joined #bitcoin-core-dev
126 2019-02-06T11:21:04  *** midnightmagic has quit IRC
127 2019-02-06T11:46:29  *** midnightmagic has joined #bitcoin-core-dev
128 2019-02-06T11:48:15  *** rex4539 has quit IRC
129 2019-02-06T12:02:05  *** darosior has quit IRC
130 2019-02-06T12:03:40  <fanquake> jonasschnelli Are #7949 or #9502 Prs you'd still like to try and get into 0.18.0 ?
131 2019-02-06T12:03:43  <gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
132 2019-02-06T12:03:46  <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
133 2019-02-06T12:05:34  *** AaronvanW has joined #bitcoin-core-dev
134 2019-02-06T12:14:41  *** Deinogalerix21 has joined #bitcoin-core-dev
135 2019-02-06T12:17:58  *** davec has quit IRC
136 2019-02-06T12:20:01  *** davec has joined #bitcoin-core-dev
137 2019-02-06T12:21:18  *** Deinogalerix21 has quit IRC
138 2019-02-06T12:26:53  *** Jackielove4u has quit IRC
139 2019-02-06T12:33:36  *** AaronvanW has quit IRC
140 2019-02-06T12:38:04  *** rex4539 has joined #bitcoin-core-dev
141 2019-02-06T12:47:46  *** promag has joined #bitcoin-core-dev
142 2019-02-06T12:54:51  *** promag has quit IRC
143 2019-02-06T13:16:44  *** Randolf has quit IRC
144 2019-02-06T13:17:36  *** promag has joined #bitcoin-core-dev
145 2019-02-06T13:30:44  *** promag has quit IRC
146 2019-02-06T13:31:07  *** darosior has joined #bitcoin-core-dev
147 2019-02-06T13:44:11  *** Guyver2 has joined #bitcoin-core-dev
148 2019-02-06T13:51:33  *** jtimon has joined #bitcoin-core-dev
149 2019-02-06T13:55:24  *** bitcoin-git has joined #bitcoin-core-dev
150 2019-02-06T13:55:24  <bitcoin-git> [bitcoin] merland opened pull request #15353: docs: Minor textual improvements in translation_strings_policy.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15353
151 2019-02-06T13:55:37  *** bitcoin-git has left #bitcoin-core-dev
152 2019-02-06T13:58:26  *** Skirmant has quit IRC
153 2019-02-06T13:59:34  *** Skirmant has joined #bitcoin-core-dev
154 2019-02-06T14:07:03  *** Jackielove4u has joined #bitcoin-core-dev
155 2019-02-06T14:10:13  *** setpill has quit IRC
156 2019-02-06T14:16:04  <provoostenator> Two new RPC methods probably ready, but awaiting a little more review love #14667 & #15226
157 2019-02-06T14:16:07  <gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddresses RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
158 2019-02-06T14:16:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
159 2019-02-06T14:17:21  <instagibbs> well, if we're letting a pure utility function in, I'll review...
160 2019-02-06T14:23:17  <provoostenator> There was some general discussion about that. There's not really a safe alternative for deriveaddresses, because you'd have to implement descriptors. At least until we figure out how to properly library-ify the codebase.
161 2019-02-06T14:24:22  <provoostenator> Longer term though: #14671
162 2019-02-06T14:24:23  <gribble> https://github.com/bitcoin/bitcoin/issues/14671 | Utility to replace RPC calls that dont need wallet or chain context · Issue #14671 · bitcoin/bitcoin · GitHub
163 2019-02-06T14:35:39  <luke-jr> dunno if it's worth finishing up, but at least as an example of a way to do a non-fork blockchain feature: https://github.com/bitcoin/bitcoin/compare/v0.17.1…luke-jr:extra_weight
164 2019-02-06T14:35:57  <luke-jr> ugh, elipsis collapsed..
165 2019-02-06T14:36:04  <luke-jr> dunno if it's worth finishing up, but at least as an example of a way to do a non-fork blockchain feature: https://github.com/bitcoin/bitcoin/compare/v0.17.1...luke-jr:extra_weight
166 2019-02-06T14:36:48  *** spaced0ut has quit IRC
167 2019-02-06T14:39:10  *** spaced0ut has joined #bitcoin-core-dev
168 2019-02-06T15:08:55  *** fanquake has quit IRC
169 2019-02-06T15:10:47  *** darosior has quit IRC
170 2019-02-06T15:15:51  <wumpus> some of the PRs in the 0.18 tag haven't been active for ages (#7949, #9502), might be better to remove them?
171 2019-02-06T15:15:54  <gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
172 2019-02-06T15:15:57  <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
173 2019-02-06T15:21:06  *** bitcoin-git has joined #bitcoin-core-dev
174 2019-02-06T15:21:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15354: doc: Add missing bitcoin-wallet tool manpages (master...Mf1902-docWalletTool) https://github.com/bitcoin/bitcoin/pull/15354
175 2019-02-06T15:21:09  *** bitcoin-git has left #bitcoin-core-dev
176 2019-02-06T15:22:08  <sdaftuar> does anyone look at appveyor failures?
177 2019-02-06T15:22:37  <wumpus> you mean, in general?
178 2019-02-06T15:22:52  <sdaftuar> yeah
179 2019-02-06T15:22:55  <wumpus> we do try to have both appveyor and travis pass before merging
180 2019-02-06T15:23:37  <sdaftuar> ok... i can try to debug then. seems like it fails randomly so wasn't sure how to treat failures on a PR
181 2019-02-06T15:23:43  <wumpus> is there a problem with that at the moment?
182 2019-02-06T15:23:58  <wumpus> yea two CI's is double the chance of random failures, unfortunately
183 2019-02-06T15:24:25  <sdaftuar> i haven't tried to do any debugging yet, i'll see if i can track it down
184 2019-02-06T15:24:41  *** Randolf has joined #bitcoin-core-dev
185 2019-02-06T15:28:04  <wumpus> ok let me know if you'd like me to have a look
186 2019-02-06T15:29:35  <luke-jr> it'd be nice if a failure popped up a console on the dev's screen to debug :P
187 2019-02-06T15:29:46  <wumpus> oh yes
188 2019-02-06T15:30:47  <wumpus> interactive debug that would be a great feature
189 2019-02-06T15:32:03  <instagibbs> I've previously tried to get travis to cough up a core dump on various kinds of errors, was unable to
190 2019-02-06T15:32:25  <wumpus> much more efficient than trying to reproduce the exact environment locally (for appveyor that isn't even an option for me I don't have windows)
191 2019-02-06T15:32:58  *** bitcoin-git has joined #bitcoin-core-dev
192 2019-02-06T15:32:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5029e94f855c...645a1264f336
193 2019-02-06T15:33:00  <bitcoin-git> bitcoin/master 7fdb92e OverlordQ: Update linearize-hashes.py
194 2019-02-06T15:33:00  <bitcoin-git> bitcoin/master 645a126 MarcoFalke: Merge #15351: Update linearize-hashes.py
195 2019-02-06T15:33:05  *** bitcoin-git has left #bitcoin-core-dev
196 2019-02-06T15:33:28  <wumpus> "Update linearize-hashes.py" that's a terrible PR title
197 2019-02-06T15:33:46  *** bitcoin-git has joined #bitcoin-core-dev
198 2019-02-06T15:33:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15351: Update linearize-hashes.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15351
199 2019-02-06T15:33:52  *** bitcoin-git has left #bitcoin-core-dev
200 2019-02-06T15:34:14  <luke-jr> wumpus: re status of #13339 there's quite a few unresolved issues; I have an older version I use in Knots that ignores the escaping issue entirely, but it seemed like people didn't like that
201 2019-02-06T15:34:18  <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
202 2019-02-06T15:34:25  *** kexkey has joined #bitcoin-core-dev
203 2019-02-06T15:35:01  <luke-jr> (the current PR has copyrighted code that isn't licensed for redistribution)
204 2019-02-06T15:36:04  <Randolf> That could be a big problem.  Whoops!
205 2019-02-06T15:36:13  <wumpus> ok, removiing it from the tag then
206 2019-02-06T15:37:38  *** bitcoin-git has joined #bitcoin-core-dev
207 2019-02-06T15:37:38  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/645a1264f336...ddae781a0cc1
208 2019-02-06T15:37:38  <bitcoin-git> bitcoin/master fa1db33 MarcoFalke: travis: Only exit early if compilation took longer than 30 min
209 2019-02-06T15:37:39  <bitcoin-git> bitcoin/master ddae781 MarcoFalke: Merge #15349: travis: Only exit early if compilation took longer than 30 m...
210 2019-02-06T15:37:40  *** bitcoin-git has left #bitcoin-core-dev
211 2019-02-06T15:37:41  <wumpus> (this doesn't mean it can't still make 0.18, but I don't think it makes sense to prioritize it for review as it is)
212 2019-02-06T15:38:25  *** bitcoin-git has joined #bitcoin-core-dev
213 2019-02-06T15:38:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349
214 2019-02-06T15:38:26  *** bitcoin-git has left #bitcoin-core-dev
215 2019-02-06T15:38:28  <wumpus> luke-jr: I'm surprised and shocked that escaping turns out to be so difficult
216 2019-02-06T15:40:10  <wumpus> I used to think it was simply replacing ' by '\''  and surrounding by single quotes
217 2019-02-06T15:41:00  <wumpus> though usually it's preferable to avoid it entirely by not going through the shell and passing the arguments one-to-one directly to execv() etc
218 2019-02-06T15:42:12  *** michaelsdunn1 has joined #bitcoin-core-dev
219 2019-02-06T15:42:12  *** michaelsdunn1 has quit IRC
220 2019-02-06T15:42:12  *** michaelsdunn1 has joined #bitcoin-core-dev
221 2019-02-06T15:43:04  *** pinheadmz has joined #bitcoin-core-dev
222 2019-02-06T15:50:00  *** pinheadmz has joined #bitcoin-core-dev
223 2019-02-06T15:51:41  *** pinheadmz has quit IRC
224 2019-02-06T15:54:27  <luke-jr> wumpus: that works fine on *nix, just not Windows
225 2019-02-06T15:54:44  <luke-jr> wumpus: on Windows, the command line is passed as one big string to the program, and the program decides how to parse it
226 2019-02-06T15:55:05  *** pinheadmz has joined #bitcoin-core-dev
227 2019-02-06T15:58:16  *** hebasto has joined #bitcoin-core-dev
228 2019-02-06T16:01:06  *** bitcoin-git has joined #bitcoin-core-dev
229 2019-02-06T16:01:07  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddae781a0cc1...12a910c9435c
230 2019-02-06T16:01:08  <bitcoin-git> bitcoin/master 7bb45e4 Jonas Schnelli: Qt: update header count regardless of update delay
231 2019-02-06T16:01:08  <bitcoin-git> bitcoin/master e8db6b8 Jonas Schnelli: Qt: Fix update headers-count
232 2019-02-06T16:01:09  <bitcoin-git> bitcoin/master 12a910c Wladimir J. van der Laan: Merge #15091: GUI: fix model overlay header sync
233 2019-02-06T16:01:12  *** bitcoin-git has left #bitcoin-core-dev
234 2019-02-06T16:01:41  *** bitcoin-git has joined #bitcoin-core-dev
235 2019-02-06T16:01:41  <bitcoin-git> [bitcoin] laanwj merged pull request #15091: GUI: fix model overlay header sync (master...2019/01/qt_fix_modal) https://github.com/bitcoin/bitcoin/pull/15091
236 2019-02-06T16:01:48  *** bitcoin-git has left #bitcoin-core-dev
237 2019-02-06T16:04:02  *** EagleTM has joined #bitcoin-core-dev
238 2019-02-06T16:21:23  *** bitcoin-git has joined #bitcoin-core-dev
239 2019-02-06T16:21:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12a910c9435c...1a6036978e9d
240 2019-02-06T16:21:24  <bitcoin-git> bitcoin/master fa0fe3b MarcoFalke: contrib: Add missing wallet tool to gen-manpages.sh
241 2019-02-06T16:21:25  <bitcoin-git> bitcoin/master fa1e281 MarcoFalke: doc: Add missing wallet-tool manpages
242 2019-02-06T16:21:25  <bitcoin-git> bitcoin/master 1a60369 MarcoFalke: Merge #15354: doc: Add missing bitcoin-wallet tool manpages
243 2019-02-06T16:21:34  *** bitcoin-git has left #bitcoin-core-dev
244 2019-02-06T16:22:11  *** bitcoin-git has joined #bitcoin-core-dev
245 2019-02-06T16:22:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15354: doc: Add missing bitcoin-wallet tool manpages (master...Mf1902-docWalletTool) https://github.com/bitcoin/bitcoin/pull/15354
246 2019-02-06T16:22:12  *** bitcoin-git has left #bitcoin-core-dev
247 2019-02-06T16:25:06  *** EagleTM has quit IRC
248 2019-02-06T16:41:38  *** Randolf has quit IRC
249 2019-02-06T17:12:46  *** skyikot has joined #bitcoin-core-dev
250 2019-02-06T17:33:37  <sdaftuar> wumpus: fyi one of the appveyor test failures we regularly see is due to an actual test bug, i'll PR something soon
251 2019-02-06T17:37:55  *** iimatey has joined #bitcoin-core-dev
252 2019-02-06T17:46:34  *** Murch has joined #bitcoin-core-dev
253 2019-02-06T18:02:07  *** volkov has joined #bitcoin-core-dev
254 2019-02-06T18:05:44  *** kexkey has quit IRC
255 2019-02-06T18:07:35  *** pinheadmz has quit IRC
256 2019-02-06T18:10:06  *** volkov has quit IRC
257 2019-02-06T18:16:37  <wumpus> sdaftuar: thanks !
258 2019-02-06T18:21:56  *** jtimon has quit IRC
259 2019-02-06T18:27:25  *** promag has joined #bitcoin-core-dev
260 2019-02-06T18:29:55  *** bitcoin-git has joined #bitcoin-core-dev
261 2019-02-06T18:29:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a6036978e9d...5cdb82111cc1
262 2019-02-06T18:29:56  <bitcoin-git> bitcoin/master fa2a69f practicalswift: doc: Add cs_main lock annotations for mapBlockIndex
263 2019-02-06T18:29:56  <bitcoin-git> bitcoin/master 5cdb821 MarcoFalke: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex
264 2019-02-06T18:29:58  *** bitcoin-git has left #bitcoin-core-dev
265 2019-02-06T18:30:51  *** bitcoin-git has joined #bitcoin-core-dev
266 2019-02-06T18:30:52  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
267 2019-02-06T18:30:58  *** bitcoin-git has left #bitcoin-core-dev
268 2019-02-06T18:31:27  *** promag has quit IRC
269 2019-02-06T18:33:02  *** pinheadmz has joined #bitcoin-core-dev
270 2019-02-06T18:33:51  *** ajonas_ has joined #bitcoin-core-dev
271 2019-02-06T18:47:33  *** bitcoin-git has joined #bitcoin-core-dev
272 2019-02-06T18:47:34  <bitcoin-git> [bitcoin] JBaczuk opened pull request #15357: Move maxTxFee initialization to init.cpp (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
273 2019-02-06T18:47:35  *** bitcoin-git has left #bitcoin-core-dev
274 2019-02-06T18:47:41  *** iimatey has quit IRC
275 2019-02-06T18:48:09  *** kexkey has joined #bitcoin-core-dev
276 2019-02-06T18:51:04  *** AaronvanW has joined #bitcoin-core-dev
277 2019-02-06T18:51:40  *** Aaronvan_ has joined #bitcoin-core-dev
278 2019-02-06T18:51:40  *** kexkey has quit IRC
279 2019-02-06T18:55:28  *** AaronvanW has quit IRC
280 2019-02-06T18:57:22  *** iimatey has joined #bitcoin-core-dev
281 2019-02-06T19:00:00  *** dviola has quit IRC
282 2019-02-06T19:02:41  *** bitcoin-git has joined #bitcoin-core-dev
283 2019-02-06T19:02:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15358: util: Add SetupHelpOptions() (master...Mf1902-Help) https://github.com/bitcoin/bitcoin/pull/15358
284 2019-02-06T19:02:46  *** bitcoin-git has left #bitcoin-core-dev
285 2019-02-06T19:04:47  *** Murch has quit IRC
286 2019-02-06T19:05:44  *** Murch has joined #bitcoin-core-dev
287 2019-02-06T19:06:12  *** diego4 has joined #bitcoin-core-dev
288 2019-02-06T19:06:48  *** diego4 has left #bitcoin-core-dev
289 2019-02-06T19:07:15  *** elichai2 has quit IRC
290 2019-02-06T19:07:20  *** dviola has joined #bitcoin-core-dev
291 2019-02-06T19:13:51  *** promag has joined #bitcoin-core-dev
292 2019-02-06T19:14:23  *** Aaronvan_ has quit IRC
293 2019-02-06T19:25:59  *** twistedline has quit IRC
294 2019-02-06T19:47:01  *** rh0nj has quit IRC
295 2019-02-06T19:48:07  *** rh0nj has joined #bitcoin-core-dev
296 2019-02-06T19:48:27  *** ajonas_ has quit IRC
297 2019-02-06T19:54:22  *** EagleTM has joined #bitcoin-core-dev
298 2019-02-06T19:55:36  <promag> sdaftuar: please include #15350 in your branch and see if it fixes the slow down
299 2019-02-06T19:55:38  <gribble> https://github.com/bitcoin/bitcoin/issues/15350 | qa: Drop RPC connection if --usecli by promag · Pull Request #15350 · bitcoin/bitcoin · GitHub
300 2019-02-06T19:57:29  *** riemann has joined #bitcoin-core-dev
301 2019-02-06T20:11:47  *** schmidty has quit IRC
302 2019-02-06T20:12:10  *** schmidty has joined #bitcoin-core-dev
303 2019-02-06T20:28:53  *** michaelsdunn1 has quit IRC
304 2019-02-06T20:29:33  *** spinza has quit IRC
305 2019-02-06T20:30:24  *** twistedline has joined #bitcoin-core-dev
306 2019-02-06T20:30:48  *** michaelsdunn1 has joined #bitcoin-core-dev
307 2019-02-06T20:36:22  *** michaelsdunn1 has quit IRC
308 2019-02-06T20:39:59  *** Murch has quit IRC
309 2019-02-06T20:43:17  *** jtimon has joined #bitcoin-core-dev
310 2019-02-06T20:43:20  <kewde[m]> https://github.com/bitcoin/bitcoin/blob/6e6b3b944d12a252a0fd9a1d68fec9843dd5b4f8/src/random.h#L162
311 2019-02-06T20:44:40  <kewde[m]> randrange(0) -> wraps around and caused our tests to hang for a while :P (found by @tecnovert)
312 2019-02-06T20:47:14  *** promag has quit IRC
313 2019-02-06T20:47:52  *** promag has joined #bitcoin-core-dev
314 2019-02-06T20:48:36  <kewde[m]> 0 is a nonsensical value to enter, but our test suite sometimes found itself in that situation and created some interesting fireworks..
315 2019-02-06T20:48:38  *** spinza has joined #bitcoin-core-dev
316 2019-02-06T20:52:00  *** hebasto has quit IRC
317 2019-02-06T20:52:03  <gmaxwell> kewde[m]: I'm not sure of the purpose of your report.
318 2019-02-06T20:52:07  *** promag has quit IRC
319 2019-02-06T20:52:15  <gmaxwell> If there was any place in the codebase where it could be called with 0 that would be a bug.
320 2019-02-06T20:52:19  <gmaxwell> But AFAIK there is not.
321 2019-02-06T20:52:43  <gmaxwell> so it just sounds like your test suite is broken.
322 2019-02-06T20:52:43  <sipa> we can document the precondition range>0
323 2019-02-06T20:52:54  <sipa> but otherwise i don't see what needs to be done
324 2019-02-06T20:53:18  <gmaxwell> hm. did we have clearer docs on another one? I thought we did.
325 2019-02-06T20:53:26  *** bitcoin-git has joined #bitcoin-core-dev
326 2019-02-06T20:53:26  <bitcoin-git> [bitcoin] kewde opened pull request #15359: Prevent undefined behavior of randrange() (@tecnovert) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15359
327 2019-02-06T20:53:39  *** bitcoin-git has left #bitcoin-core-dev
328 2019-02-06T20:53:58  <gmaxwell> That isn't undefined behavior.
329 2019-02-06T20:54:43  <sipa> does it go into an infinite loop? (if so, that's technically UB)
330 2019-02-06T20:56:11  <gmaxwell> it's not an infinite loop, technically. :)
331 2019-02-06T20:56:14  <kewde[m]> It caused weird behavior when the value was used afterwards, anyways, it returned a value that was out of the max of the range became 0xFFFFFFFFFFFFFFFF.
332 2019-02-06T20:58:21  <sipa> well you're using the function wrong
333 2019-02-06T20:58:38  <gmaxwell> If it were to change at all, it should change to assert. But considering randrange gets used in innerloops and whatnot, I'm dubious of the value of that tradeoff.
334 2019-02-06T20:58:46  <sipa> returning 0 is equally invalid, as it's outside of the range [0, 0)
335 2019-02-06T21:02:31  *** bitcoin-git has joined #bitcoin-core-dev
336 2019-02-06T21:02:31  <bitcoin-git> [bitcoin] kewde closed pull request #15359: Add zero check to randrange() (@tecnovert) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15359
337 2019-02-06T21:02:32  *** bitcoin-git has left #bitcoin-core-dev
338 2019-02-06T21:03:17  <kewde[m]> Yeah makes sense, I didn't spot the ) bracket at the end. I just thought I'd make a note of it, it was interesting bug we had.
339 2019-02-06T21:03:58  *** pinheadmz has quit IRC
340 2019-02-06T21:06:21  *** michaelsdunn1 has joined #bitcoin-core-dev
341 2019-02-06T21:08:28  *** Murch has joined #bitcoin-core-dev
342 2019-02-06T21:09:40  *** jtimon has quit IRC
343 2019-02-06T21:09:58  *** jtimon has joined #bitcoin-core-dev
344 2019-02-06T21:12:30  *** iimatey has quit IRC
345 2019-02-06T21:14:49  *** iimatey has joined #bitcoin-core-dev
346 2019-02-06T21:14:55  *** AaronvanW has joined #bitcoin-core-dev
347 2019-02-06T21:16:48  *** AaronvanW has quit IRC
348 2019-02-06T21:17:30  *** AaronvanW has joined #bitcoin-core-dev
349 2019-02-06T21:18:51  *** AaronvanW has quit IRC
350 2019-02-06T21:21:19  *** EagleTM has quit IRC
351 2019-02-06T21:23:32  *** EagleTM has joined #bitcoin-core-dev
352 2019-02-06T21:29:34  *** AaronvanW has joined #bitcoin-core-dev
353 2019-02-06T21:33:54  *** AaronvanW has quit IRC
354 2019-02-06T21:36:15  *** dviola has quit IRC
355 2019-02-06T21:43:38  *** pinheadmz has joined #bitcoin-core-dev
356 2019-02-06T21:48:04  *** bitcoin-git has joined #bitcoin-core-dev
357 2019-02-06T21:48:04  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5cdb82111cc1...72d34c0edc5a
358 2019-02-06T21:48:05  <bitcoin-git> bitcoin/master 6180b5f Carl Dong: netaddress: Fix indentation in IsLocal
359 2019-02-06T21:48:05  <bitcoin-git> bitcoin/master 87aa0b4 Carl Dong: netaddress: Make IPv4 loopback comment more descriptive
360 2019-02-06T21:48:06  <bitcoin-git> bitcoin/master 72d34c0 Wladimir J. van der Laan: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptiv...
361 2019-02-06T21:48:07  *** bitcoin-git has left #bitcoin-core-dev
362 2019-02-06T21:48:53  *** bitcoin-git has joined #bitcoin-core-dev
363 2019-02-06T21:48:53  <bitcoin-git> [bitcoin] laanwj merged pull request #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive (master...2019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343
364 2019-02-06T21:48:57  *** bitcoin-git has left #bitcoin-core-dev
365 2019-02-06T22:04:23  *** DeanGuss has quit IRC
366 2019-02-06T22:18:09  *** AaronvanW has joined #bitcoin-core-dev
367 2019-02-06T22:23:09  *** spinza has quit IRC
368 2019-02-06T22:27:33  *** AaronvanW has quit IRC
369 2019-02-06T22:31:09  *** iimatey has quit IRC
370 2019-02-06T22:34:39  *** spinza has joined #bitcoin-core-dev
371 2019-02-06T22:42:22  *** Murch has quit IRC
372 2019-02-06T22:45:15  *** Murch has joined #bitcoin-core-dev
373 2019-02-06T23:05:56  *** Murch has quit IRC
374 2019-02-06T23:19:03  *** timothy has quit IRC
375 2019-02-06T23:19:36  *** Zenton has quit IRC
376 2019-02-06T23:25:16  *** EagleTM has quit IRC
377 2019-02-06T23:29:38  *** bitcoin-git has joined #bitcoin-core-dev
378 2019-02-06T23:29:38  <bitcoin-git> [bitcoin] sdaftuar opened pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
379 2019-02-06T23:29:48  *** bitcoin-git has left #bitcoin-core-dev
380 2019-02-06T23:32:40  *** michaelsdunn1 has quit IRC