12019-02-08T00:04:58 *** justan0theruser has joined #bitcoin-core-dev
22019-02-08T00:07:06 *** justanotheruser has quit IRC
32019-02-08T00:42:46 *** hyperion has quit IRC
42019-02-08T00:42:54 *** Murch has quit IRC
52019-02-08T00:49:37 *** elichai2 has quit IRC
62019-02-08T01:00:07 *** timothy has quit IRC
72019-02-08T01:11:08 *** DeanGuss has joined #bitcoin-core-dev
82019-02-08T01:16:23 *** DeanGuss has quit IRC
92019-02-08T01:47:48 *** e4xit has quit IRC
102019-02-08T01:49:02 *** bralyclow has joined #bitcoin-core-dev
112019-02-08T01:50:17 *** ddustin has joined #bitcoin-core-dev
122019-02-08T01:50:23 *** bralyclow has quit IRC
132019-02-08T01:52:27 *** e4xit has joined #bitcoin-core-dev
142019-02-08T01:53:18 *** bralyclo_ has quit IRC
152019-02-08T01:53:55 *** ddustin_ has quit IRC
162019-02-08T02:03:07 *** jarthur has joined #bitcoin-core-dev
172019-02-08T02:49:37 *** kexkey has joined #bitcoin-core-dev
182019-02-08T02:51:47 *** kexkey has quit IRC
192019-02-08T03:09:03 *** drexl has quit IRC
202019-02-08T03:23:09 *** spinza has quit IRC
212019-02-08T03:23:58 *** murrayn has quit IRC
222019-02-08T03:24:22 *** murrayn has joined #bitcoin-core-dev
232019-02-08T03:30:55 *** AaronvanW has joined #bitcoin-core-dev
242019-02-08T03:31:47 *** spinza has joined #bitcoin-core-dev
252019-02-08T03:35:28 *** AaronvanW has quit IRC
262019-02-08T03:50:04 *** volkov has joined #bitcoin-core-dev
272019-02-08T04:12:45 *** bitcoin-git has joined #bitcoin-core-dev
282019-02-08T04:12:45 <bitcoin-git> [bitcoin] sipa pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9127bd7abaf8...b9b26d9c3615
292019-02-08T04:12:46 <bitcoin-git> bitcoin/master 1cff3d6 Gleb Naumenko: Change in transaction pull scheduling to prevent InvBlock-related attacks
302019-02-08T04:12:47 <bitcoin-git> bitcoin/master b9b26d9 Pieter Wuille: Merge #14897: randomize GETDATA(tx) request order and introduce bias towar...
312019-02-08T04:12:50 *** bitcoin-git has left #bitcoin-core-dev
322019-02-08T04:13:26 *** bitcoin-git has joined #bitcoin-core-dev
332019-02-08T04:13:26 <bitcoin-git> [bitcoin] sipa merged pull request #14897: randomize GETDATA(tx) request order and introduce bias toward outbound (master...master) https://github.com/bitcoin/bitcoin/pull/14897
342019-02-08T04:13:30 *** bitcoin-git has left #bitcoin-core-dev
352019-02-08T04:25:56 *** rex4539 has quit IRC
362019-02-08T04:29:15 <meshcollider> I've put a few wallet PRs that we could hope to get in on the milestone, maybe not all are feasible, depends how avid reviewers are this week :)
372019-02-08T04:30:20 <meshcollider> Definitely the open wallet menu should go in, and it'd be nice to have the listuspent segwit PR since its the last unmerged on the segwit project
382019-02-08T05:07:32 *** DeanGuss has joined #bitcoin-core-dev
392019-02-08T05:31:49 *** volkov has quit IRC
402019-02-08T05:32:25 *** AaronvanW has joined #bitcoin-core-dev
412019-02-08T05:38:20 *** AaronvanW has quit IRC
422019-02-08T05:54:39 *** AaronvanW has joined #bitcoin-core-dev
432019-02-08T05:59:08 *** AaronvanW has quit IRC
442019-02-08T06:00:07 *** jarthur has quit IRC
452019-02-08T06:42:17 *** fanquake has joined #bitcoin-core-dev
462019-02-08T06:55:33 <fanquake> promag think 15153 is good enough now. Still some behaviour that can be cleaned up later. Could you rebase 15195 ontop of the latest version of 15153, be good to get that into 0.18 too.
472019-02-08T07:02:40 <sipa> #15153
482019-02-08T07:02:42 <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
492019-02-08T07:19:50 *** promag has joined #bitcoin-core-dev
502019-02-08T07:33:21 *** promag has quit IRC
512019-02-08T07:36:53 *** promag has joined #bitcoin-core-dev
522019-02-08T07:44:48 *** promag has quit IRC
532019-02-08T07:55:38 *** AaronvanW has joined #bitcoin-core-dev
542019-02-08T08:01:07 *** AaronvanW has quit IRC
552019-02-08T08:24:45 *** ghost43 has quit IRC
562019-02-08T08:25:01 *** ghost43 has joined #bitcoin-core-dev
572019-02-08T08:39:46 *** ddustin has quit IRC
582019-02-08T08:40:24 *** ddustin has joined #bitcoin-core-dev
592019-02-08T08:44:43 *** ddustin has quit IRC
602019-02-08T09:12:34 *** volkov has joined #bitcoin-core-dev
612019-02-08T09:13:32 *** setpill has joined #bitcoin-core-dev
622019-02-08T09:17:11 *** timothy has joined #bitcoin-core-dev
632019-02-08T09:27:50 *** fanquake has quit IRC
642019-02-08T09:32:30 *** promag has joined #bitcoin-core-dev
652019-02-08T09:33:57 *** timothy has quit IRC
662019-02-08T09:34:01 <promag> fanquanke: I prefer to rebase after merge, otherwise I'll have to rebase again
672019-02-08T09:34:30 *** promag has quit IRC
682019-02-08T09:37:34 *** timothy has joined #bitcoin-core-dev
692019-02-08T09:41:12 <provoostenator> promag: I can't reason about the things that might go wrong when a wallet keeps rescanning after a user cancels the load action.
702019-02-08T09:41:33 <provoostenator> Can it lead to data loss? Crashes?
712019-02-08T09:41:48 <provoostenator> I fully expect users to just keep trying to open the same wallet, while that rescan is still going.
722019-02-08T09:42:40 *** timothy has quit IRC
732019-02-08T09:46:11 *** AaronvanW has joined #bitcoin-core-dev
742019-02-08T09:46:12 *** timothy has joined #bitcoin-core-dev
752019-02-08T09:52:56 *** rockhouse4 has joined #bitcoin-core-dev
762019-02-08T09:53:04 *** victorSN1 has joined #bitcoin-core-dev
772019-02-08T09:57:17 *** victorSN1 has quit IRC
782019-02-08T09:59:13 *** rockhouse4 has quit IRC
792019-02-08T10:05:39 *** volkov has quit IRC
802019-02-08T10:05:58 *** dqx has quit IRC
812019-02-08T10:11:34 *** AaronvanW has quit IRC
822019-02-08T10:11:55 *** AaronvanW has joined #bitcoin-core-dev
832019-02-08T10:16:30 *** dqx has joined #bitcoin-core-dev
842019-02-08T10:21:43 *** Deinogalerix21 has joined #bitcoin-core-dev
852019-02-08T10:31:10 *** sakalli_ has joined #bitcoin-core-dev
862019-02-08T10:33:31 *** sakalli_ has quit IRC
872019-02-08T10:36:17 *** spinza has quit IRC
882019-02-08T10:41:42 *** sakalli_ has joined #bitcoin-core-dev
892019-02-08T10:43:45 *** spinza has joined #bitcoin-core-dev
902019-02-08T10:47:32 *** Deinogalerix21 has quit IRC
912019-02-08T10:49:02 *** rh0nj has quit IRC
922019-02-08T10:49:57 *** spinza has quit IRC
932019-02-08T10:50:08 *** rh0nj has joined #bitcoin-core-dev
942019-02-08T10:51:01 *** sakalli_ has quit IRC
952019-02-08T10:53:49 *** spinza has joined #bitcoin-core-dev
962019-02-08T11:31:01 *** bitcoin-git has joined #bitcoin-core-dev
972019-02-08T11:31:02 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9b26d9c3615...6fc656a410b6
982019-02-08T11:31:02 <bitcoin-git> bitcoin/master d855e4c practicalswift: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an in...
992019-02-08T11:31:02 <bitcoin-git> bitcoin/master 6fc656a Wladimir J. van der Laan: Merge #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0...
1002019-02-08T11:31:05 *** bitcoin-git has left #bitcoin-core-dev
1012019-02-08T11:31:28 *** bitcoin-git has joined #bitcoin-core-dev
1022019-02-08T11:31:28 <bitcoin-git> [bitcoin] laanwj merged pull request #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) (master...ub-in-DecodeSecret) https://github.com/bitcoin/bitcoin/pull/14242
1032019-02-08T11:31:29 *** bitcoin-git has left #bitcoin-core-dev
1042019-02-08T11:53:23 *** dqx has quit IRC
1052019-02-08T11:59:22 *** dqx has joined #bitcoin-core-dev
1062019-02-08T12:21:53 *** m8tion has joined #bitcoin-core-dev
1072019-02-08T12:29:10 *** AaronvanW has quit IRC
1082019-02-08T12:36:39 *** drexl has joined #bitcoin-core-dev
1092019-02-08T12:56:29 *** booyah has quit IRC
1102019-02-08T12:57:38 *** booyah has joined #bitcoin-core-dev
1112019-02-08T13:15:09 *** mn9495883 has joined #bitcoin-core-dev
1122019-02-08T13:18:34 *** BGL has quit IRC
1132019-02-08T13:18:55 *** mn949588 has quit IRC
1142019-02-08T13:18:55 *** lio17 has quit IRC
1152019-02-08T13:18:58 *** Apocalyptic has quit IRC
1162019-02-08T13:19:24 *** lio17 has joined #bitcoin-core-dev
1172019-02-08T13:19:46 *** echeveria has quit IRC
1182019-02-08T13:20:35 *** arubi has quit IRC
1192019-02-08T13:26:29 *** m8tion has quit IRC
1202019-02-08T13:26:35 *** arubi has joined #bitcoin-core-dev
1212019-02-08T13:26:46 *** m8tion has joined #bitcoin-core-dev
1222019-02-08T13:28:13 *** echeveria has joined #bitcoin-core-dev
1232019-02-08T13:29:35 *** rockhouse has quit IRC
1242019-02-08T13:29:36 *** victorSN has quit IRC
1252019-02-08T13:30:08 *** Skirmant has quit IRC
1262019-02-08T13:30:53 *** bitcoin-git has joined #bitcoin-core-dev
1272019-02-08T13:30:54 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
1282019-02-08T13:31:02 *** bitcoin-git has left #bitcoin-core-dev
1292019-02-08T13:31:16 *** rockhouse has joined #bitcoin-core-dev
1302019-02-08T13:31:24 *** victorSN has joined #bitcoin-core-dev
1312019-02-08T13:33:06 *** m8tion has quit IRC
1322019-02-08T13:38:02 *** victorSN has quit IRC
1332019-02-08T13:38:28 *** rockhouse has quit IRC
1342019-02-08T13:43:35 *** m8tion has joined #bitcoin-core-dev
1352019-02-08T13:48:21 *** dermoth has quit IRC
1362019-02-08T13:49:14 *** fanquake has joined #bitcoin-core-dev
1372019-02-08T13:49:41 <fanquake> promag fair enough, I'll review post rebase
1382019-02-08T13:50:05 *** m8tion_ has joined #bitcoin-core-dev
1392019-02-08T13:50:52 *** owowo has quit IRC
1402019-02-08T13:54:22 *** darosior has joined #bitcoin-core-dev
1412019-02-08T13:56:12 *** owowo has joined #bitcoin-core-dev
1422019-02-08T14:00:59 *** m8tion_ has quit IRC
1432019-02-08T14:01:05 *** m8tion has quit IRC
1442019-02-08T14:01:53 *** bitcoin-git has joined #bitcoin-core-dev
1452019-02-08T14:01:53 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fc656a410b6...30495d1e756c
1462019-02-08T14:01:53 <bitcoin-git> bitcoin/master eea02be practicalswift: Add locking annotation for vNodes. vNodes is guarded by cs_vNodes.
1472019-02-08T14:01:54 <bitcoin-git> bitcoin/master 30495d1 MarcoFalke: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is gu...
1482019-02-08T14:01:57 *** bitcoin-git has left #bitcoin-core-dev
1492019-02-08T14:02:31 *** bitcoin-git has joined #bitcoin-core-dev
1502019-02-08T14:02:31 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
1512019-02-08T14:02:32 *** bitcoin-git has left #bitcoin-core-dev
1522019-02-08T14:03:16 *** m8tion has joined #bitcoin-core-dev
1532019-02-08T14:03:46 *** m8tion has quit IRC
1542019-02-08T14:07:46 *** promag has joined #bitcoin-core-dev
1552019-02-08T14:09:49 *** rockhouse has joined #bitcoin-core-dev
1562019-02-08T14:09:56 *** Apocalyptic has joined #bitcoin-core-dev
1572019-02-08T14:10:27 *** victorSN has joined #bitcoin-core-dev
1582019-02-08T14:12:03 *** ap4lmtree- has joined #bitcoin-core-dev
1592019-02-08T14:15:03 *** ap4lmtree has quit IRC
1602019-02-08T14:24:22 *** benthecarman has joined #bitcoin-core-dev
1612019-02-08T14:25:19 <benthecarman> Is there a better way for checking the address format than just seeing what the address starts with
1622019-02-08T14:25:57 *** BGL has joined #bitcoin-core-dev
1632019-02-08T14:31:08 <promag> benthecarman: not that I'm aware of, why?
1642019-02-08T14:32:30 <benthecarman> promag: just making sure I am doing something correctly
1652019-02-08T14:33:00 *** spaced0ut has joined #bitcoin-core-dev
1662019-02-08T14:50:21 *** promag has quit IRC
1672019-02-08T14:53:01 *** darosior has quit IRC
1682019-02-08T15:07:44 *** fanquake has quit IRC
1692019-02-08T15:14:37 *** darosior has joined #bitcoin-core-dev
1702019-02-08T15:16:49 *** goatpig has quit IRC
1712019-02-08T15:20:42 *** bitcoin-git has joined #bitcoin-core-dev
1722019-02-08T15:20:43 <bitcoin-git> [bitcoin] benthecarman opened pull request #15371: gui: Optimization for bech32 qr codes (master...gui_bech_32_optimized_qr_codes) https://github.com/bitcoin/bitcoin/pull/15371
1732019-02-08T15:20:46 *** bitcoin-git has left #bitcoin-core-dev
1742019-02-08T15:20:50 *** benthecarman has quit IRC
1752019-02-08T15:21:03 *** benthecarman has joined #bitcoin-core-dev
1762019-02-08T15:34:10 *** owowo has quit IRC
1772019-02-08T15:38:51 *** owowo has joined #bitcoin-core-dev
1782019-02-08T15:38:54 *** benthecarman has quit IRC
1792019-02-08T15:39:15 *** bitcoin-git has joined #bitcoin-core-dev
1802019-02-08T15:39:16 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30495d1e756c...020695660859
1812019-02-08T15:39:16 <bitcoin-git> bitcoin/master faa4647 MarcoFalke: wallet: Add lock annotation for mapAddressBook
1822019-02-08T15:39:17 <bitcoin-git> bitcoin/master 0206956 MarcoFalke: Merge #15365: wallet: Add lock annotation for mapAddressBook
1832019-02-08T15:39:18 *** bitcoin-git has left #bitcoin-core-dev
1842019-02-08T15:40:01 *** bitcoin-git has joined #bitcoin-core-dev
1852019-02-08T15:40:01 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15365: wallet: Add lock annotation for mapAddressBook (master...Mf1902-LockAnnotmapAddressBook) https://github.com/bitcoin/bitcoin/pull/15365
1862019-02-08T15:40:09 *** bitcoin-git has left #bitcoin-core-dev
1872019-02-08T15:44:06 *** bitcoin-git has joined #bitcoin-core-dev
1882019-02-08T15:44:07 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/020695660859...1477933f289e
1892019-02-08T15:44:07 <bitcoin-git> bitcoin/master faf3d22 MarcoFalke: test_runner: Remove unused --force option
1902019-02-08T15:44:08 <bitcoin-git> bitcoin/master fae8b8b MarcoFalke: qa: Add tool-prefix to functional test readme
1912019-02-08T15:44:08 <bitcoin-git> bitcoin/master 1477933 MarcoFalke: Merge #15370: test_runner: Remove unused --force option
1922019-02-08T15:44:10 *** bitcoin-git has left #bitcoin-core-dev
1932019-02-08T15:44:51 *** bitcoin-git has joined #bitcoin-core-dev
1942019-02-08T15:44:51 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
1952019-02-08T15:44:58 *** bitcoin-git has left #bitcoin-core-dev
1962019-02-08T15:52:08 *** ap4lmtree- has quit IRC
1972019-02-08T15:52:35 *** ap4lmtree- has joined #bitcoin-core-dev
1982019-02-08T15:53:22 *** bitcoin-git has joined #bitcoin-core-dev
1992019-02-08T15:53:22 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15364: qa: Fix race in feature_notifications (master...Mf1902-qaNotifRace) https://github.com/bitcoin/bitcoin/pull/15364
2002019-02-08T15:53:25 *** bitcoin-git has left #bitcoin-core-dev
2012019-02-08T15:53:48 *** ap4lmtree- has quit IRC
2022019-02-08T15:54:13 *** fanquake has joined #bitcoin-core-dev
2032019-02-08T15:54:27 *** ap4lmtree has joined #bitcoin-core-dev
2042019-02-08T15:56:18 *** Skirmant has joined #bitcoin-core-dev
2052019-02-08T16:02:37 *** jtimon has quit IRC
2062019-02-08T16:04:25 *** darosior has quit IRC
2072019-02-08T16:07:50 *** phwalkr has quit IRC
2082019-02-08T16:08:01 *** phwalkr has joined #bitcoin-core-dev
2092019-02-08T16:11:44 *** benthecarman has joined #bitcoin-core-dev
2102019-02-08T16:13:40 *** benthecarman has quit IRC
2112019-02-08T16:15:11 *** EagleTM has joined #bitcoin-core-dev
2122019-02-08T16:24:04 *** jtimon has joined #bitcoin-core-dev
2132019-02-08T16:26:32 *** millerti has joined #bitcoin-core-dev
2142019-02-08T16:37:51 *** Guyver2 has joined #bitcoin-core-dev
2152019-02-08T16:41:18 *** setpill has quit IRC
2162019-02-08T17:00:00 *** jarthur has joined #bitcoin-core-dev
2172019-02-08T17:01:58 *** benthecarman has joined #bitcoin-core-dev
2182019-02-08T17:19:02 *** fanquake has quit IRC
2192019-02-08T17:21:23 *** Eagle[TM] has joined #bitcoin-core-dev
2202019-02-08T17:22:30 *** EagleTM has quit IRC
2212019-02-08T17:24:00 *** Murch has joined #bitcoin-core-dev
2222019-02-08T17:41:07 *** Eagle[TM] has quit IRC
2232019-02-08T17:41:08 *** Cory has quit IRC
2242019-02-08T17:41:09 *** pinheadmz has joined #bitcoin-core-dev
2252019-02-08T17:47:19 *** justan0theruser is now known as justanotheruser
2262019-02-08T17:48:40 *** Cory has joined #bitcoin-core-dev
2272019-02-08T17:49:30 *** bitcoin-git has joined #bitcoin-core-dev
2282019-02-08T17:49:31 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1477933f289e...d5dbb45bdf7d
2292019-02-08T17:49:31 <bitcoin-git> bitcoin/master 9ad5ca1 David A. Harding: Release notes: integrate detached & rm backports
2302019-02-08T17:49:32 <bitcoin-git> bitcoin/master 5d35d43 David A. Harding: Update release notes through to cb35f1d3
2312019-02-08T17:49:32 <bitcoin-git> bitcoin/master d5dbb45 MarcoFalke: Merge #15314: [Doc] update release notes for changes up to cb35f1d
2322019-02-08T17:49:35 *** bitcoin-git has left #bitcoin-core-dev
2332019-02-08T17:49:39 *** fanquake has joined #bitcoin-core-dev
2342019-02-08T17:50:12 *** bitcoin-git has joined #bitcoin-core-dev
2352019-02-08T17:50:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...2019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
2362019-02-08T17:50:21 *** bitcoin-git has left #bitcoin-core-dev
2372019-02-08T17:53:48 *** fanquake has quit IRC
2382019-02-08T17:56:24 *** benthecarman has quit IRC
2392019-02-08T18:03:58 *** EagleTM has joined #bitcoin-core-dev
2402019-02-08T18:07:10 *** timothy has quit IRC
2412019-02-08T18:30:55 *** Murch has quit IRC
2422019-02-08T18:31:25 *** hebasto has joined #bitcoin-core-dev
2432019-02-08T18:32:35 *** Murch has joined #bitcoin-core-dev
2442019-02-08T18:34:23 *** ddustin has joined #bitcoin-core-dev
2452019-02-08T18:36:16 *** promag has joined #bitcoin-core-dev
2462019-02-08T18:40:04 <achow101> there's a wallet meeting today, right?
2472019-02-08T18:40:28 *** promag has quit IRC
2482019-02-08T18:42:16 *** michaels_ has joined #bitcoin-core-dev
2492019-02-08T18:44:15 <gwillen> achow101: as far as I know, in 15 minutes
2502019-02-08T18:46:03 *** EagleTM has quit IRC
2512019-02-08T18:46:05 <sipa> yup, will be there
2522019-02-08T18:48:08 *** Murch has quit IRC
2532019-02-08T18:52:18 *** promag has joined #bitcoin-core-dev
2542019-02-08T18:53:27 <meshcollider> Yep
2552019-02-08T19:00:32 <meshcollider> #startmeeting
2562019-02-08T19:00:32 <lightningbot> Meeting started Fri Feb 8 19:00:32 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
2572019-02-08T19:00:32 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2582019-02-08T19:00:50 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
2592019-02-08T19:01:01 <achow101> only half here
2602019-02-08T19:01:12 <sipa> here
2612019-02-08T19:01:13 <promag> hi
2622019-02-08T19:01:15 <meshcollider> Ok, topics?
2632019-02-08T19:01:45 <meshcollider> I guess we should start with discussing what wallet PRs we can aim to get into 0.18
2642019-02-08T19:02:01 <jnewbery> hi
2652019-02-08T19:03:05 <meshcollider> https://github.com/bitcoin/bitcoin/milestone/35
2662019-02-08T19:03:43 <gwillen> yes hello
2672019-02-08T19:04:25 <gwillen> I am pestering for people to go review #13932
2682019-02-08T19:04:28 <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
2692019-02-08T19:04:38 <sipa> will do
2702019-02-08T19:04:48 <jnewbery> https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+milestone%3A0.18.0+label%3AWallet
2712019-02-08T19:04:56 <achow101> also review #15226 pls
2722019-02-08T19:05:00 <gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
2732019-02-08T19:05:01 <jnewbery> only wallet PRs ^
2742019-02-08T19:06:02 <achow101> #14075 and #14021 would be nice, but they're a bit more involved
2752019-02-08T19:06:04 <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
2762019-02-08T19:06:07 <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
2772019-02-08T19:06:44 <meshcollider> Yes, I put them on the milestone but not sure they'll be ready in time
2782019-02-08T19:07:09 <achow101> there's also a merge conflict between those two and 15226 which may not be trivial to resolve, so i don't think we can get all of them in
2792019-02-08T19:08:27 *** spaced0ut has quit IRC
2802019-02-08T19:09:36 <meshcollider> I would really like at least #14021 but we'll see I guess
2812019-02-08T19:09:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
2822019-02-08T19:09:55 <meshcollider> achow101: Is 15226 your highest priority one
2832019-02-08T19:10:03 <jnewbery> I'd love to see #15288 merged soon since we now seem to have some momentum in that series of PRs, but it might be better to do that after forking 0.18
2842019-02-08T19:10:06 <gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
2852019-02-08T19:10:17 <kanzure> hi.
2862019-02-08T19:10:30 <jnewbery> it's a very easy review. Lots of line change but all very mechanical, and nicely structured commits
2872019-02-08T19:10:31 <meshcollider> jnewbery: yeah I think after 0.18 is better, but I agree
2882019-02-08T19:10:38 <achow101> currently 14021 is my highest priority
2892019-02-08T19:11:22 <achow101> (since 14491 is merged now)
2902019-02-08T19:12:08 <jnewbery> achow101: perhaps you could give a summary of the state of HWI? How far are we from HWI in master?
2912019-02-08T19:12:31 <jnewbery> instagibbs: or you if you're around ^
2922019-02-08T19:12:59 <meshcollider> I think #14912 is tracking
2932019-02-08T19:13:05 <gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
2942019-02-08T19:13:11 <achow101> hwi has all basic functionality completed for the 5 common hardware wallets
2952019-02-08T19:13:59 <achow101> provoostenator has a branch for calling it from core
2962019-02-08T19:14:11 *** Murch has joined #bitcoin-core-dev
2972019-02-08T19:14:48 <achow101> we would need that and 14021 and 14075 for hwi to work.
2982019-02-08T19:15:37 <achow101> (gtg, have to take a quiz now)
2992019-02-08T19:15:40 <meshcollider> Also #14481 is the last PR on the "Segwit" github project which hasn't gone in, it'd be nice to have that in for 0.18
3002019-02-08T19:15:42 <gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
3012019-02-08T19:16:36 <meshcollider> Quite a small PR to review
3022019-02-08T19:16:40 <sipa> meshcollider: i'm slightly inclined to instead just aim to have signrawtransaction etc work with descriptors
3032019-02-08T19:16:49 <sipa> as listunspent gives the descriptors already
3042019-02-08T19:17:08 <sipa> (not an objection to also doing that PR... but i suspect in the end the descriptor based approach is more convenient)
3052019-02-08T19:19:30 *** ddustin has quit IRC
3062019-02-08T19:19:45 <meshcollider> sipa: I think having both is nice, but yeah making descriptors more consistently used across the RPCs would be a nice change
3072019-02-08T19:19:58 <meshcollider> But we can't aim for that in 0.18
3082019-02-08T19:20:07 <sipa> agree
3092019-02-08T19:21:03 <meshcollider> Does anyone have any other topics for the meeting?
3102019-02-08T19:21:47 <meshcollider> sipa: how's the checksum search coming
3112019-02-08T19:22:22 <sipa> meshcollider: #15368
3122019-02-08T19:22:23 <gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
3132019-02-08T19:22:38 <sipa> i'll add documentation and release notes today
3142019-02-08T19:24:30 <meshcollider> Ok
3152019-02-08T19:24:59 <meshcollider> Looks like there's nothing else to discuss this week
3162019-02-08T19:25:13 <meshcollider> #endmeeting
3172019-02-08T19:25:13 <lightningbot> Meeting ended Fri Feb 8 19:25:13 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3182019-02-08T19:25:13 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-08-19.00.html
3192019-02-08T19:25:13 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-08-19.00.txt
3202019-02-08T19:25:13 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-08-19.00.log.html
3212019-02-08T19:25:18 <meshcollider> Thanks everyone
3222019-02-08T19:25:46 <promag> jnewbery: do you think I should fix your case in the open wallet pr?
3232019-02-08T19:26:18 <jnewbery> I think so, unless you can explain why it isn't a problem
3242019-02-08T19:26:38 <jnewbery> is there a reason you wouldn't want the file checking in the LoadWallet() function?
3252019-02-08T19:27:39 <promag> I don't think I thought of that, it was just a small step towards minimizing code duplication
3262019-02-08T19:28:39 <promag> long term I'd like to break CreateWalletFromFile so that the UI can have the wallet interface asap
3272019-02-08T19:29:22 <promag> I'll update the branch then
3282019-02-08T19:37:12 <jnewbery> thanks!
3292019-02-08T19:41:39 *** promag has quit IRC
3302019-02-08T19:43:05 *** hebasto has quit IRC
3312019-02-08T19:44:29 *** bitcoin-git has joined #bitcoin-core-dev
3322019-02-08T19:44:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5dbb45bdf7d...294549242493
3332019-02-08T19:44:30 <bitcoin-git> bitcoin/master dfbf117 Jordan Baczuk: Move maxTxFee initialization to init.cpp
3342019-02-08T19:44:31 <bitcoin-git> bitcoin/master 2945492 MarcoFalke: Merge #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled
3352019-02-08T19:44:34 *** bitcoin-git has left #bitcoin-core-dev
3362019-02-08T19:45:13 *** bitcoin-git has joined #bitcoin-core-dev
3372019-02-08T19:45:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
3382019-02-08T19:45:25 *** bitcoin-git has left #bitcoin-core-dev
3392019-02-08T19:46:31 *** promag has joined #bitcoin-core-dev
3402019-02-08T19:51:20 *** bitcoin-git has joined #bitcoin-core-dev
3412019-02-08T19:51:20 <bitcoin-git> [bitcoin] sdaftuar closed pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
3422019-02-08T19:51:21 *** bitcoin-git has left #bitcoin-core-dev
3432019-02-08T19:54:13 *** ddustin has joined #bitcoin-core-dev
3442019-02-08T19:54:51 *** rex4539 has joined #bitcoin-core-dev
3452019-02-08T19:55:13 <promag> forgot to mention #15341 on the meeting.. is it worth?
3462019-02-08T19:55:15 <gribble> https://github.com/bitcoin/bitcoin/issues/15341 | rpc: Support specifying change address in bumpfee by promag · Pull Request #15341 · bitcoin/bitcoin · GitHub
3472019-02-08T20:13:54 *** Murch has quit IRC
3482019-02-08T20:14:39 *** promag has quit IRC
3492019-02-08T20:30:47 *** EagleTM has joined #bitcoin-core-dev
3502019-02-08T20:41:45 *** davec has quit IRC
3512019-02-08T20:45:53 *** davec has joined #bitcoin-core-dev
3522019-02-08T20:46:16 *** nehan_ has quit IRC
3532019-02-08T20:46:29 *** woody1345 has joined #bitcoin-core-dev
3542019-02-08T20:47:11 *** woody1345 has quit IRC
3552019-02-08T20:47:32 *** nehan has quit IRC
3562019-02-08T20:50:30 *** promag has joined #bitcoin-core-dev
3572019-02-08T20:51:09 *** nehan has joined #bitcoin-core-dev
3582019-02-08T20:53:52 *** ddustin has quit IRC
3592019-02-08T20:54:56 *** promag has quit IRC
3602019-02-08T21:02:58 *** Guyver2 has quit IRC
3612019-02-08T21:12:37 *** justanotheruser has quit IRC
3622019-02-08T21:18:19 *** tryphe has quit IRC
3632019-02-08T21:19:06 *** spinza has quit IRC
3642019-02-08T21:21:58 *** ddustin has joined #bitcoin-core-dev
3652019-02-08T21:23:46 *** fanquake has joined #bitcoin-core-dev
3662019-02-08T21:25:22 *** justanotheruser has joined #bitcoin-core-dev
3672019-02-08T21:25:47 *** jtimon has quit IRC
3682019-02-08T21:26:53 *** promag has joined #bitcoin-core-dev
3692019-02-08T21:28:12 *** fanquake has quit IRC
3702019-02-08T21:31:40 *** promag has quit IRC
3712019-02-08T21:34:05 *** jtimon has joined #bitcoin-core-dev
3722019-02-08T21:38:07 *** nullptr| has quit IRC
3732019-02-08T21:41:49 *** Murch has joined #bitcoin-core-dev
3742019-02-08T21:42:55 *** tryphe has joined #bitcoin-core-dev
3752019-02-08T21:44:10 *** nullptr| has joined #bitcoin-core-dev
3762019-02-08T21:46:56 *** fabianfabian has joined #bitcoin-core-dev
3772019-02-08T21:54:43 *** spinza has joined #bitcoin-core-dev
3782019-02-08T21:59:06 *** rex4539 has quit IRC
3792019-02-08T22:06:43 *** promag has joined #bitcoin-core-dev
3802019-02-08T22:10:13 *** IGHOR has quit IRC
3812019-02-08T22:10:56 *** promag has quit IRC
3822019-02-08T22:12:12 *** IGHOR has joined #bitcoin-core-dev
3832019-02-08T22:14:35 *** michaels_ has quit IRC
3842019-02-08T22:25:43 *** DeanGuss has quit IRC
3852019-02-08T22:31:23 *** bitcoin-git has joined #bitcoin-core-dev
3862019-02-08T22:31:24 <bitcoin-git> [bitcoin] ryanofsky opened pull request #15373: Move ParseConfirmTarget from rpc/mining to rpc/util (master...pr/movtarget) https://github.com/bitcoin/bitcoin/pull/15373
3872019-02-08T22:31:25 *** bitcoin-git has left #bitcoin-core-dev
3882019-02-08T22:34:58 *** ap4lmtree has quit IRC
3892019-02-08T22:36:31 *** pinheadmz has quit IRC
3902019-02-08T22:37:05 *** pinheadmz has joined #bitcoin-core-dev
3912019-02-08T22:37:17 *** anonymous_ has joined #bitcoin-core-dev
3922019-02-08T22:38:05 *** ap4lmtree has joined #bitcoin-core-dev
3932019-02-08T22:39:15 *** ap4lmtree has joined #bitcoin-core-dev
3942019-02-08T22:41:32 *** ddustin has quit IRC
3952019-02-08T22:42:12 *** ddustin has joined #bitcoin-core-dev
3962019-02-08T22:43:09 *** spinza has quit IRC
3972019-02-08T22:46:59 *** ddustin has quit IRC
3982019-02-08T22:54:39 *** spinza has joined #bitcoin-core-dev
3992019-02-08T23:07:21 *** fanquake has joined #bitcoin-core-dev
4002019-02-08T23:08:58 *** bitconner has joined #bitcoin-core-dev
4012019-02-08T23:22:05 *** CryptoKingNeedsH has joined #bitcoin-core-dev
4022019-02-08T23:36:54 *** justanotheruser has quit IRC
4032019-02-08T23:38:01 *** justanotheruser has joined #bitcoin-core-dev
4042019-02-08T23:43:46 *** IGHOR has quit IRC
4052019-02-08T23:44:03 *** IGHOR has joined #bitcoin-core-dev
4062019-02-08T23:55:03 *** IGHOR has quit IRC
4072019-02-08T23:56:49 *** IGHOR has joined #bitcoin-core-dev