1 2019-02-10T00:17:27  *** rockhouse has quit IRC
  2 2019-02-10T00:17:52  *** rockhouse has joined #bitcoin-core-dev
  3 2019-02-10T00:22:03  *** fanquake has joined #bitcoin-core-dev
  4 2019-02-10T00:27:26  *** viajero has joined #bitcoin-core-dev
  5 2019-02-10T00:29:21  *** kallewoof has quit IRC
  6 2019-02-10T00:30:35  *** viajero has left #bitcoin-core-dev
  7 2019-02-10T00:47:09  *** dviola has quit IRC
  8 2019-02-10T01:08:07  *** Kvaciral has quit IRC
  9 2019-02-10T01:08:48  *** bitcoin-git has joined #bitcoin-core-dev
 10 2019-02-10T01:08:48  <bitcoin-git> [bitcoin] benthecarman opened pull request #15378: tests: Added missing tests for RPC wallet errors (master...tests_missing_tests) https://github.com/bitcoin/bitcoin/pull/15378
 11 2019-02-10T01:08:52  *** bitcoin-git has left #bitcoin-core-dev
 12 2019-02-10T01:09:18  *** millerti has quit IRC
 13 2019-02-10T01:10:13  *** Kvaciral has joined #bitcoin-core-dev
 14 2019-02-10T01:29:47  *** ExtraCrispy has quit IRC
 15 2019-02-10T01:30:44  *** justan0theruser has joined #bitcoin-core-dev
 16 2019-02-10T01:32:47  *** justanotheruser has quit IRC
 17 2019-02-10T01:42:47  *** ExtraCrispy has joined #bitcoin-core-dev
 18 2019-02-10T02:08:01  *** Karyon has joined #bitcoin-core-dev
 19 2019-02-10T02:19:40  *** skyikot has joined #bitcoin-core-dev
 20 2019-02-10T02:38:07  *** EagleTM has quit IRC
 21 2019-02-10T02:47:35  *** skyikot has quit IRC
 22 2019-02-10T02:49:36  *** justanotheruser has joined #bitcoin-core-dev
 23 2019-02-10T02:49:38  *** justan0theruser has quit IRC
 24 2019-02-10T02:57:26  *** DeanGuss has joined #bitcoin-core-dev
 25 2019-02-10T02:57:49  *** jtimon has quit IRC
 26 2019-02-10T03:02:30  *** drexl has quit IRC
 27 2019-02-10T03:48:22  *** Karyon has quit IRC
 28 2019-02-10T03:56:36  *** Emcy has quit IRC
 29 2019-02-10T03:57:08  *** Emcy has joined #bitcoin-core-dev
 30 2019-02-10T04:02:14  <meshcollider> provoostenator: if you can get a last review of #15226 done, I think it'll be ready to merge
 31 2019-02-10T04:02:17  <gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
 32 2019-02-10T04:02:24  <meshcollider> (If you have a bit of time)
 33 2019-02-10T04:04:14  <achow101> meshcollider: do you think we can get #14021 and #14075 in for 0.18? I've changed 14075 so that it doesn't conflict with 15226 anymore
 34 2019-02-10T04:04:16  <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
 35 2019-02-10T04:04:19  <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
 36 2019-02-10T04:05:24  <meshcollider> Maybe 14021 but I dont think 14075 as well unless theres a sudden surge of review :)
 37 2019-02-10T04:06:27  <achow101> 14021 would be nice since it actually makes hwi usable with core
 38 2019-02-10T04:25:53  *** DeanGuss has quit IRC
 39 2019-02-10T04:26:24  *** DeanGuss has joined #bitcoin-core-dev
 40 2019-02-10T04:47:07  *** Karyon has joined #bitcoin-core-dev
 41 2019-02-10T04:49:43  *** londer has joined #bitcoin-core-dev
 42 2019-02-10T04:52:15  *** londer has quit IRC
 43 2019-02-10T05:11:53  <fanquake> \o/
 44 2019-02-10T05:27:56  *** Karyon has quit IRC
 45 2019-02-10T05:42:29  *** tryphe_ has joined #bitcoin-core-dev
 46 2019-02-10T05:46:04  *** tryphe has quit IRC
 47 2019-02-10T05:54:59  *** skyikot has joined #bitcoin-core-dev
 48 2019-02-10T05:59:22  *** mryandao has joined #bitcoin-core-dev
 49 2019-02-10T06:02:47  <mryandao> hello, i've stumbled upon a threading exception with bitcoind and the program crashed. The exception message is "invalid argument in bitcoin scheduler"
 50 2019-02-10T06:03:46  <mryandao> the commit i'm running is "5029e94f855c73bad2e0ea6dc0378f33787ae131"
 51 2019-02-10T06:18:32  <fanquake> mryandao Can you open an issue with the details, include a stack trace if possible etc
 52 2019-02-10T06:20:36  <mryandao> i have the corefile
 53 2019-02-10T06:20:54  <mryandao> 500+ MB, would that be helpful?
 54 2019-02-10T06:22:37  <gmaxwell> you can use the corefile to get a stack trace.
 55 2019-02-10T06:27:09  <mryandao> yep, ok. On it.
 56 2019-02-10T06:38:24  <mryandao> issue created: https://github.com/bitcoin/bitcoin/issues/15379
 57 2019-02-10T06:59:22  *** TheHoliestRoger has quit IRC
 58 2019-02-10T07:02:00  *** TheHoliestRoger has joined #bitcoin-core-dev
 59 2019-02-10T07:13:16  *** spinza has quit IRC
 60 2019-02-10T07:15:19  <fanquake> mryandao thanks
 61 2019-02-10T07:27:14  *** spinza has joined #bitcoin-core-dev
 62 2019-02-10T07:33:09  *** skyikot has quit IRC
 63 2019-02-10T07:38:09  *** fabianfabian has joined #bitcoin-core-dev
 64 2019-02-10T07:56:53  *** hebasto has joined #bitcoin-core-dev
 65 2019-02-10T08:15:30  *** jtimon has joined #bitcoin-core-dev
 66 2019-02-10T08:35:20  *** elichai2 has joined #bitcoin-core-dev
 67 2019-02-10T08:45:35  *** Soligor has quit IRC
 68 2019-02-10T08:48:00  *** Soligor has joined #bitcoin-core-dev
 69 2019-02-10T09:13:36  *** ctrlbreak_MAD has joined #bitcoin-core-dev
 70 2019-02-10T09:15:14  *** ctrlbreak has quit IRC
 71 2019-02-10T09:18:01  *** rh0nj has quit IRC
 72 2019-02-10T09:19:07  *** rh0nj has joined #bitcoin-core-dev
 73 2019-02-10T09:29:15  *** hebasto has quit IRC
 74 2019-02-10T09:46:27  *** justanotheruser has quit IRC
 75 2019-02-10T09:50:15  *** mildly_risky has joined #bitcoin-core-dev
 76 2019-02-10T09:54:17  *** mildly_risky has quit IRC
 77 2019-02-10T09:54:36  *** mildly_risky has joined #bitcoin-core-dev
 78 2019-02-10T09:55:03  *** mildly_risky has quit IRC
 79 2019-02-10T09:55:23  *** mildly_risky has joined #bitcoin-core-dev
 80 2019-02-10T09:56:00  *** shesek has quit IRC
 81 2019-02-10T10:11:22  *** hebasto has joined #bitcoin-core-dev
 82 2019-02-10T10:24:14  *** EagleTM has joined #bitcoin-core-dev
 83 2019-02-10T10:44:03  *** spinza has quit IRC
 84 2019-02-10T10:54:44  *** jkjk has joined #bitcoin-core-dev
 85 2019-02-10T10:56:14  *** jkjk has quit IRC
 86 2019-02-10T10:56:46  *** EagleTM has quit IRC
 87 2019-02-10T11:00:08  *** EagleTM has joined #bitcoin-core-dev
 88 2019-02-10T11:15:26  *** root2 has joined #bitcoin-core-dev
 89 2019-02-10T11:16:32  *** spinza has joined #bitcoin-core-dev
 90 2019-02-10T11:22:56  *** hebasto has quit IRC
 91 2019-02-10T11:23:49  *** jb55 has quit IRC
 92 2019-02-10T11:32:43  *** ap4lmtree has quit IRC
 93 2019-02-10T11:33:07  *** ap4lmtree has joined #bitcoin-core-dev
 94 2019-02-10T11:39:01  *** Guyver2 has joined #bitcoin-core-dev
 95 2019-02-10T11:46:12  *** EagleTM has quit IRC
 96 2019-02-10T11:53:27  *** hebasto has joined #bitcoin-core-dev
 97 2019-02-10T12:05:34  *** cjd has quit IRC
 98 2019-02-10T12:05:42  *** cjd has joined #bitcoin-core-dev
 99 2019-02-10T12:22:38  *** EagleTM has joined #bitcoin-core-dev
100 2019-02-10T12:26:51  *** cubancorona has quit IRC
101 2019-02-10T12:27:11  *** cubancorona has joined #bitcoin-core-dev
102 2019-02-10T12:51:03  *** AaronvanW has joined #bitcoin-core-dev
103 2019-02-10T12:56:43  *** Skirmant has quit IRC
104 2019-02-10T13:10:31  *** Skirmant has joined #bitcoin-core-dev
105 2019-02-10T13:11:47  *** fanquake has quit IRC
106 2019-02-10T13:15:34  *** zndtoshi has joined #bitcoin-core-dev
107 2019-02-10T13:16:21  <zndtoshi> Hello. I connect to bitcoin network over Tor. Can someone please tell me how I can change the onion address of my bitcoin core?
108 2019-02-10T13:18:47  *** riemann has joined #bitcoin-core-dev
109 2019-02-10T13:26:44  <booyah> zndtoshi: it is best to ask in #bitcoin for usage questoins
110 2019-02-10T13:33:53  *** hebasto has quit IRC
111 2019-02-10T13:41:18  *** grepsuzette has joined #bitcoin-core-dev
112 2019-02-10T13:49:10  *** ken2812221` has joined #bitcoin-core-dev
113 2019-02-10T13:50:16  *** ken2812221` has quit IRC
114 2019-02-10T13:51:49  *** ken2812221 has joined #bitcoin-core-dev
115 2019-02-10T13:58:03  *** tryphe has joined #bitcoin-core-dev
116 2019-02-10T13:59:47  *** tryphe_ has quit IRC
117 2019-02-10T14:02:00  *** mildly_risky has quit IRC
118 2019-02-10T14:04:22  *** riemann has quit IRC
119 2019-02-10T14:09:21  *** AaronvanW has quit IRC
120 2019-02-10T14:11:24  *** Karyon has joined #bitcoin-core-dev
121 2019-02-10T14:40:12  *** Scrat has joined #bitcoin-core-dev
122 2019-02-10T14:46:12  *** Scrat has left #bitcoin-core-dev
123 2019-02-10T15:10:16  <provoostenator> meshcollider: on my list, should be today or tomorrow
124 2019-02-10T15:25:59  *** mn949588 has joined #bitcoin-core-dev
125 2019-02-10T15:28:55  *** grepsuzette has quit IRC
126 2019-02-10T15:29:45  *** grepsuzette has joined #bitcoin-core-dev
127 2019-02-10T15:33:00  <wumpus> still kind of meh about  #14239, do we know for sure the change to validation (ConnectBlock) is safe?
128 2019-02-10T15:33:02  <gribble> https://github.com/bitcoin/bitcoin/issues/14239 | Avoid dividing by zero (undefined behaviour) in EstimateMedianVal (policy)/ConnectTip (validation)/CreateTransaction (wallet) by practicalswift · Pull Request #14239 · bitcoin/bitcoin · GitHub
129 2019-02-10T15:39:51  <wumpus> zndtoshi: if it's auto-binding to tor, delete $DATADIR/onion_private_key and restart, if you've configured the hidden service manually then see the tor manual I guess
130 2019-02-10T15:44:26  *** Karyon has quit IRC
131 2019-02-10T15:45:00  *** Karyon has joined #bitcoin-core-dev
132 2019-02-10T15:52:23  *** justanotheruser has joined #bitcoin-core-dev
133 2019-02-10T16:11:58  *** spinza has quit IRC
134 2019-02-10T16:13:22  *** dviola has joined #bitcoin-core-dev
135 2019-02-10T16:18:38  *** DougieBot5000_ has joined #bitcoin-core-dev
136 2019-02-10T16:19:11  *** DougieBot5000_ has quit IRC
137 2019-02-10T16:19:51  *** DougieBot5000_ has joined #bitcoin-core-dev
138 2019-02-10T16:21:18  *** DougieBot5000 has quit IRC
139 2019-02-10T16:26:24  *** spinza has joined #bitcoin-core-dev
140 2019-02-10T16:31:24  <wumpus> thanks for looking at it gmaxwell
141 2019-02-10T16:34:22  <gmaxwell> wumpus: np. I feel kind of overwhelmed by changes like these myself, and I'm only looking at a fraction of the ones you are.
142 2019-02-10T16:36:21  <gmaxwell> assuming that I'm correct in my belief that nBlocksTotal is only accessed in those bench lines, that part of the change is consensus safe. (The same behavior or arguably better could also be had by initilizing it to 1, instead of zero...)
143 2019-02-10T16:37:14  <wumpus> I think you're correct in that
144 2019-02-10T16:44:08  *** drexl has joined #bitcoin-core-dev
145 2019-02-10T17:06:39  *** TannerR has joined #bitcoin-core-dev
146 2019-02-10T17:20:34  *** TannerR has quit IRC
147 2019-02-10T17:27:33  *** promag has joined #bitcoin-core-dev
148 2019-02-10T17:28:32  *** hebasto has joined #bitcoin-core-dev
149 2019-02-10T17:46:47  *** promag has quit IRC
150 2019-02-10T17:55:57  *** elichai2 has quit IRC
151 2019-02-10T18:02:54  *** belcher has quit IRC
152 2019-02-10T18:07:32  *** promag has joined #bitcoin-core-dev
153 2019-02-10T18:11:56  *** promag has quit IRC
154 2019-02-10T18:22:14  *** MrPaz has quit IRC
155 2019-02-10T18:29:11  *** mistergold has joined #bitcoin-core-dev
156 2019-02-10T18:49:58  *** mistergold has quit IRC
157 2019-02-10T18:54:22  *** ctrlbreak_MAD is now known as ctrlbreak
158 2019-02-10T18:59:51  *** promag has joined #bitcoin-core-dev
159 2019-02-10T19:09:29  *** bitcoin-git has joined #bitcoin-core-dev
160 2019-02-10T19:09:30  <bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/294549242493...6f4e0d154256
161 2019-02-10T19:09:31  <bitcoin-git> bitcoin/master 7687f78 Andrew Chow: [wallet] Support creating a blank wallet
162 2019-02-10T19:09:31  <bitcoin-git> bitcoin/master 6f4e0d1 MeshCollider: Merge #15226: Allow creating blank (empty) wallets (alternative)
163 2019-02-10T19:09:38  *** bitcoin-git has left #bitcoin-core-dev
164 2019-02-10T19:10:14  *** bitcoin-git has joined #bitcoin-core-dev
165 2019-02-10T19:10:14  <bitcoin-git> [bitcoin] MeshCollider merged pull request #15226: Allow creating blank (empty) wallets (alternative) (master...blank-wallets) https://github.com/bitcoin/bitcoin/pull/15226
166 2019-02-10T19:10:25  *** bitcoin-git has left #bitcoin-core-dev
167 2019-02-10T19:12:04  *** DougieBot5000_ is now known as DougieBot5000
168 2019-02-10T19:24:28  *** AaronvanW has joined #bitcoin-core-dev
169 2019-02-10T19:28:10  *** promag has quit IRC
170 2019-02-10T19:33:27  *** elichai2 has joined #bitcoin-core-dev
171 2019-02-10T19:41:29  *** sfhi has joined #bitcoin-core-dev
172 2019-02-10T19:43:39  *** hebasto has quit IRC
173 2019-02-10T19:50:21  <meshcollider> because of the nature of #15368, it will be difficult for most people to review the maths behind the checksum (just like for bech32). Who do we need to have reviews from there? gmaxwell and andytoshi?
174 2019-02-10T19:50:22  <gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
175 2019-02-10T19:55:58  <sipa> meshcollider: i'll change the checksum soon once a more extensive analysis finishes (in a day or 2), but the design is similar to bech32
176 2019-02-10T19:56:40  <sipa> also, it's massive overkill in any case - almost any 8 character checksum will have a one in a trillion chance for failure; the added properties in addition are nice to have
177 2019-02-10T20:00:12  <meshcollider> Oh ok, I missed that it wasn't final yet
178 2019-02-10T20:00:12  <meshcollider> thanks :)
179 2019-02-10T20:00:32  <sipa> also, perhaps sdaftuar wants to have a look
180 2019-02-10T20:03:49  *** promag has joined #bitcoin-core-dev
181 2019-02-10T20:08:24  *** promag has quit IRC
182 2019-02-10T20:08:55  <achow101> meshcollider: do you think #15006 can make it for 0.18?
183 2019-02-10T20:08:56  <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
184 2019-02-10T20:11:01  <meshcollider> IMO no, it hasn't had much review yet and itd be better for reviewers to focus on the others in the milestone
185 2019-02-10T20:11:51  <meshcollider> but as always, depends on whether other people agree/disagree and review it in time :)
186 2019-02-10T20:21:08  *** ap4lmtree has quit IRC
187 2019-02-10T20:26:07  *** Lucky_ has joined #bitcoin-core-dev
188 2019-02-10T20:26:27  *** Karyon has quit IRC
189 2019-02-10T20:32:40  *** ap4lmtree has joined #bitcoin-core-dev
190 2019-02-10T20:35:05  *** Lucky_ has quit IRC
191 2019-02-10T20:54:01  *** belcher has joined #bitcoin-core-dev
192 2019-02-10T20:54:38  *** Karyon has joined #bitcoin-core-dev
193 2019-02-10T21:03:15  *** sakalli_ has joined #bitcoin-core-dev
194 2019-02-10T21:05:45  *** sakalli_ has quit IRC
195 2019-02-10T21:08:36  *** trillhc has joined #bitcoin-core-dev
196 2019-02-10T21:10:08  *** dviola has quit IRC
197 2019-02-10T21:12:15  *** Karyon_ has joined #bitcoin-core-dev
198 2019-02-10T21:14:26  *** Karyon has quit IRC
199 2019-02-10T21:28:26  *** Aaronvan_ has joined #bitcoin-core-dev
200 2019-02-10T21:28:36  *** AaronvanW has quit IRC
201 2019-02-10T21:31:16  *** anon7485 has joined #bitcoin-core-dev
202 2019-02-10T21:31:56  <anon7485> Hello, one question. why validateaddress is not reporting the option "ismine"? I have wallet enabled and can generate addresses, but when I use validateaddress it doesn't display the field "ismine"
203 2019-02-10T21:37:12  <sipa> anon7485: use getaddressinfo instead
204 2019-02-10T21:37:27  <sipa> validateaddress is now a node-level rpc which is independent of the wallet
205 2019-02-10T21:39:53  <anon7485> Wow man, thanks a lot. I was reading the docs but didn't see anything related to that change, also neither the command "getaddressinfo"
206 2019-02-10T21:45:06  *** Aaronvan_ has quit IRC
207 2019-02-10T21:55:35  <sipa> anon7485: it's in the release notes
208 2019-02-10T21:57:24  <sipa> for 0.17.0
209 2019-02-10T21:57:30  <anon7485> I just saw it now since you provided me the command, thanks again
210 2019-02-10T21:57:41  <anon7485> I was reading here https://bitcoin.org/en/developer-reference
211 2019-02-10T21:58:03  <anon7485> instead of bitcoincore.org website
212 2019-02-10T22:12:04  *** AaronvanW has joined #bitcoin-core-dev
213 2019-02-10T22:13:09  *** AaronvanW has quit IRC
214 2019-02-10T22:14:25  *** a5m0 has quit IRC
215 2019-02-10T22:18:27  *** aza has joined #bitcoin-core-dev
216 2019-02-10T22:19:16  *** bitcoin-git has joined #bitcoin-core-dev
217 2019-02-10T22:19:16  <bitcoin-git> [bitcoin] andrewtoth opened pull request #15380: trivial: correct parameter name in comments (master...fix-comment) https://github.com/bitcoin/bitcoin/pull/15380
218 2019-02-10T22:19:28  *** bitcoin-git has left #bitcoin-core-dev
219 2019-02-10T22:19:59  *** aza has quit IRC
220 2019-02-10T22:20:41  *** AaronvanW has joined #bitcoin-core-dev
221 2019-02-10T22:25:04  *** fabianfabian has quit IRC
222 2019-02-10T22:25:46  *** AaronvanW has quit IRC
223 2019-02-10T22:35:43  *** DeanGuss has quit IRC
224 2019-02-10T22:38:25  *** AaronvanW has joined #bitcoin-core-dev
225 2019-02-10T22:46:37  *** Guyver2 has quit IRC
226 2019-02-10T22:50:32  *** AaronvanW has quit IRC
227 2019-02-10T22:52:11  *** AaronvanW has joined #bitcoin-core-dev
228 2019-02-10T22:54:03  *** anon7485 has quit IRC
229 2019-02-10T22:54:44  *** jarthur has joined #bitcoin-core-dev
230 2019-02-10T22:55:15  *** Karyon_ has quit IRC
231 2019-02-10T22:57:28  *** Karyon has joined #bitcoin-core-dev
232 2019-02-10T22:57:54  *** spinza has quit IRC
233 2019-02-10T23:02:03  *** Karyon_ has joined #bitcoin-core-dev
234 2019-02-10T23:02:28  *** Victorsueca has quit IRC
235 2019-02-10T23:02:46  *** Karyon has quit IRC
236 2019-02-10T23:03:10  *** spinza has joined #bitcoin-core-dev
237 2019-02-10T23:03:36  *** Victorsueca has joined #bitcoin-core-dev
238 2019-02-10T23:05:58  *** AaronvanW has quit IRC
239 2019-02-10T23:13:42  *** AaronvanW has joined #bitcoin-core-dev
240 2019-02-10T23:16:35  *** a5m0 has joined #bitcoin-core-dev
241 2019-02-10T23:17:05  *** sfhi has quit IRC
242 2019-02-10T23:22:33  *** AaronvanW has quit IRC
243 2019-02-10T23:26:21  *** eXtreme has joined #bitcoin-core-dev
244 2019-02-10T23:31:04  *** eXtreme has quit IRC
245 2019-02-10T23:32:58  *** pinheadmz has joined #bitcoin-core-dev
246 2019-02-10T23:34:07  *** AaronvanW has joined #bitcoin-core-dev
247 2019-02-10T23:42:45  *** promag has joined #bitcoin-core-dev
248 2019-02-10T23:44:48  *** pinheadmz has quit IRC
249 2019-02-10T23:45:18  *** pinheadmz has joined #bitcoin-core-dev